Re: [PATCH 07/23] drm/vmwgfx: stop using dma_resv_excl_fence

2022-03-22 Thread Christian König
Am 21.03.22 um 16:11 schrieb Zack Rusin: On Mon, 2022-03-21 at 15:12 +0100, Christian König wrote: Am 21.03.22 um 15:02 schrieb Zack Rusin: On Mon, 2022-03-21 at 14:58 +0100, Christian König wrote: ⚠ External Email: This email originated from outside of the organization. Do not click links or

Re: [PATCH] drm/ttm: fix potential null ptr deref in when mem space alloc fails

2022-03-22 Thread Christian König
Am 21.03.22 um 16:44 schrieb Robert Beckett: On 21/03/2022 09:51, Christian König wrote: Am 18.03.22 um 20:50 schrieb Robert Beckett: when allocating a resource in place it is common to free the buffer's resource, then allocate a new resource in a different placement. e.g. amdgpu_bo_create_k

Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Pin-yen Lin
Hi Xin, Can we use dev_dbg instead of dev_info for the logging? The log here is more like a debugging message, and using dev_dbg makes it consistent with anx7625_dp_stop. Sorry for not catching this earlier. Best regards, Pin-yen On Thu, Mar 3, 2022 at 3:52 PM Pin-yen Lin wrote: > > Reviewed-

Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
On Tue, Mar 22, 2022 at 03:33:17PM +0800, Pin-yen Lin wrote: > Hi Xin, > > Can we use dev_dbg instead of dev_info for the logging? > > The log here is more like a debugging message, and using dev_dbg makes > it consistent with anx7625_dp_stop. > > Sorry for not catching this earlier. > > Best r

[PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
As downstream sink was set into standby mode while bridge disabled, this patch used for setting downstream sink into normal status while enable bridge. Signed-off-by: Xin Ji Reviewed-by: Pin-Yen Lin --- V1 -> V2: use dev_dbg replace of dev_info --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Hsin-Yi Wang
On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > As downstream sink was set into standby mode while bridge disabled, > this patch used for setting downstream sink into normal status > while enable bridge. > > Signed-off-by: Xin Ji > Reviewed-by: Pin-Yen Lin > > --- > V1 -> V2: use dev_dbg repla

Re: [PATCH v2 4/7] drm/i915/guc: use the memcpy_from_wc call from the drm

2022-03-22 Thread Michal Wajdeczko
On 21.03.2022 22:14, Lucas De Marchi wrote: > On Thu, Mar 03, 2022 at 11:30:10PM +0530, Balasubramani Vivekanandan wrote: >> memcpy_from_wc functions in i915_memcpy.c will be removed and replaced >> by the implementation in drm_cache.c. >> Updated to use the functions provided by drm_cache.c. >>

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > As downstream sink was set into standby mode while bridge disabled, > > this patch used for setting downstream sink into normal status > > while enable bridge. > > > > Signed-off-b

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Pin-yen Lin
The DRM_DEV_* macros have been deprecated: https://www.kernel.org/doc/html/latest/gpu/drm-internals.html#c.DRM_DEV_DEBUG_DRIVER On Tue, Mar 22, 2022 at 4:43 PM Hsin-Yi Wang wrote: > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > As downstream sink was set into standby mode while bridge

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Chen-Yu Tsai
On Tue, Mar 22, 2022 at 4:52 PM Xin Ji wrote: > > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > > > As downstream sink was set into standby mode while bridge disabled, > > > this patch used for setting downstream sink into

Re: [PATCH v5 1/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-03-22 Thread Thomas Hellström
On Tue, 2022-03-22 at 04:14 +0530, Ramalingam C wrote: > Use faster XY_FAST_COLOR_BLT cmd on graphics version of 12 and more, > for clearing (Zero out) the pages of the newly allocated object. > > XY_FAST_COLOR_BLT is faster than the older XY_COLOR_BLT. > > v2: >   Typo fix at title [Thomas] > >

Re: [PATCH 0/4] Drop wbinvd_on_all_cpus usage

2022-03-22 Thread Tvrtko Ursulin
On 21/03/2022 15:15, Thomas Hellström wrote: On Mon, 2022-03-21 at 14:43 +, Tvrtko Ursulin wrote: On 21/03/2022 13:40, Thomas Hellström wrote: Hi, On Mon, 2022-03-21 at 13:12 +, Tvrtko Ursulin wrote: On 21/03/2022 12:33, Thomas Hellström wrote: On Mon, 2022-03-21 at 12:22 +,

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
On Tue, Mar 22, 2022 at 05:16:43PM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 22, 2022 at 4:52 PM Xin Ji wrote: > > > > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > > > > > As downstream sink was set into standby mode whil

Re: [PATCH 0/4] Drop wbinvd_on_all_cpus usage

2022-03-22 Thread Thomas Hellström
On Tue, 2022-03-22 at 10:13 +, Tvrtko Ursulin wrote: > > On 21/03/2022 15:15, Thomas Hellström wrote: > > On Mon, 2022-03-21 at 14:43 +, Tvrtko Ursulin wrote: > > > > > > On 21/03/2022 13:40, Thomas Hellström wrote: > > > > Hi, > > > > > > > > On Mon, 2022-03-21 at 13:12 +, Tvrtko Ur

Re: [PATCH 0/4] Drop wbinvd_on_all_cpus usage

2022-03-22 Thread Thomas Hellström
On Tue, 2022-03-22 at 11:26 +0100, Thomas Hellström wrote: > On Tue, 2022-03-22 at 10:13 +, Tvrtko Ursulin wrote: > > > > On 21/03/2022 15:15, Thomas Hellström wrote: > > > On Mon, 2022-03-21 at 14:43 +, Tvrtko Ursulin wrote: > > > > > > > > On 21/03/2022 13:40, Thomas Hellström wrote: >

Re: [PATCH 21/22] drm: Use drm_mode_init() for on-stack modes

2022-03-22 Thread Andrzej Hajda
On 18.02.2022 11:04, Ville Syrjala wrote: From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head, or that we aren't copying over another mode's list head. Based on the following cocci script, with manual fixups: @decl@ identifier M; ex

Re: [PATCH 22/22] drm: Use drm_mode_copy()

2022-03-22 Thread Andrzej Hajda
On 18.02.2022 11:04, Ville Syrjala wrote: From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the des

[PATCH v6 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-22 Thread Ramalingam C
When we are swapping out the local memory obj on flat-ccs capable platform, we need to capture the ccs data too along with main meory and we need to restore it when we are swapping in the content. When lmem object is swapped into a smem obj, smem obj will have the extra pages required to hold the

Re: [PATCH 0/4] Drop wbinvd_on_all_cpus usage

2022-03-22 Thread Tvrtko Ursulin
On 22/03/2022 10:26, Thomas Hellström wrote: On Tue, 2022-03-22 at 10:13 +, Tvrtko Ursulin wrote: On 21/03/2022 15:15, Thomas Hellström wrote: On Mon, 2022-03-21 at 14:43 +, Tvrtko Ursulin wrote: On 21/03/2022 13:40, Thomas Hellström wrote: Hi, On Mon, 2022-03-21 at 13:12 +,

Re: [PATCH 0/4] Drop wbinvd_on_all_cpus usage

2022-03-22 Thread Thomas Hellström
On Tue, 2022-03-22 at 11:20 +, Tvrtko Ursulin wrote: > > On 22/03/2022 10:26, Thomas Hellström wrote: > > On Tue, 2022-03-22 at 10:13 +, Tvrtko Ursulin wrote: > > > > > > On 21/03/2022 15:15, Thomas Hellström wrote: > > > > On Mon, 2022-03-21 at 14:43 +, Tvrtko Ursulin wrote: > > > >

Re: [PATCH 07/23] drm/vmwgfx: stop using dma_resv_excl_fence

2022-03-22 Thread Zack Rusin
On Tue, 2022-03-22 at 08:13 +0100, Christian König wrote: > Am 21.03.22 um 16:11 schrieb Zack Rusin: > > On Mon, 2022-03-21 at 15:12 +0100, Christian König wrote: > > > Am 21.03.22 um 15:02 schrieb Zack Rusin: > > > > On Mon, 2022-03-21 at 14:58 +0100, Christian König wrote: > > > > > ⚠ External Em

[PATCH] drm/nouveau/pmu: Add missing callbacks for Tegra devices

2022-03-22 Thread Karol Herbst
Fixes a crash booting on those platforms with nouveau. Fixes: 4cdd2450bf73 ("drm/nouveau/pmu/gm200-: use alternate falcon reset sequence") Cc: Ben Skeggs Cc: Karol Herbst Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Cc: # v5.17+ Signed-off-by: Karol Herbst --- driver

Re: [PATCH 0/4] Drop wbinvd_on_all_cpus usage

2022-03-22 Thread Tvrtko Ursulin
On 22/03/2022 11:37, Thomas Hellström wrote: On Tue, 2022-03-22 at 11:20 +, Tvrtko Ursulin wrote: On 22/03/2022 10:26, Thomas Hellström wrote: On Tue, 2022-03-22 at 10:13 +, Tvrtko Ursulin wrote: On 21/03/2022 15:15, Thomas Hellström wrote: On Mon, 2022-03-21 at 14:43 +, Tvrtk

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

2022-03-22 Thread Jiaxun Yang
在 2022/3/22 2:33, Sui Jingfeng 写道: On 2022/3/22 07:20, Rob Herring wrote: On Tue, Mar 22, 2022 at 12:29:14AM +0800, Sui Jingfeng wrote: From: suijingfeng Needs a commit message. Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273...@189.cn> Same person? Don't need both e

Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board

2022-03-22 Thread Jiaxun Yang
在 2022/3/21 16:29, Sui Jingfeng 写道: From: suijingfeng The board name is LS3A4000_7A1000_EVB_BOARD_V1.4, it consist of 1.8Ghz mips64r5 4-core CPU and LS7A1000 bridge chip. It has PCIe GEN2 x8 slot, therefore can play with discrete graphics card. Hi Jingfeng, As we've discussed before if yo

[PATCH 1/7] drm/gma500: Use managed drmm_mode_config_init()

2022-03-22 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 45df9de22007..2b99c996fdc2 100644 --- a/drivers/gpu/drm/gma500/frameb

[PATCH 3/7] drm/gma500: Make use of the drm connector iterator

2022-03-22 Thread Patrik Jakobsson
This makes sure we're using proper locking when iterating the list of connectors. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.c| 10 ++-- drivers/gpu/drm/gma500/cdv_intel_display.c | 9 +-- drivers/gpu/drm/gma500/framebuffer.c | 6 +++-- drivers/

[PATCH 4/7] drm/gma500: gma500 don't register non-hotpluggable connectors

2022-03-22 Thread Patrik Jakobsson
According to docs we should only register connectors that are hotpluggable. No connectors in gma500 are hotpluggable. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 3 --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 3 --- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2

[PATCH 2/7] drm/gma500: Uninstall interrupts on driver removal

2022-03-22 Thread Patrik Jakobsson
Reloading the driver revealed that the interrupt handler never got uninstalled. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index 82d51e9821ad..b231f

[PATCH 5/7] drm/gma500: Free the correct connector allocation

2022-03-22 Thread Patrik Jakobsson
The allocation is made for the gma_connector object so we must use the same address when free()ing the object. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 3 ++- drivers/gpu/drm/gma500/cdv_intel_dp.c | 3 ++- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 3 ++- dr

[PATCH 6/7] drm/gma500: Declare a few functions static

2022-03-22 Thread Patrik Jakobsson
These functions are not used outside of their file scope so can be declared as static. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 15 +++ drivers/gpu/drm/gma500/psb_drv.c | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drive

[PATCH 7/7] drm/gma500: Add crtc prefix to vblank functions

2022-03-22 Thread Patrik Jakobsson
These functions operate on a crtc and should be prefixed properly. Suggested-by: Thomas Zimmermann Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 6 +++--- drivers/gpu/drm/gma500/psb_irq.c | 6 +++--- drivers/gpu/drm/gma500/psb_irq.h | 6 +++--- 3 files chang

Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board

2022-03-22 Thread Sui Jingfeng
On 2022/3/22 21:05, Jiaxun Yang wrote: 在 2022/3/21 16:29, Sui Jingfeng 写道: From: suijingfeng The board name is LS3A4000_7A1000_EVB_BOARD_V1.4, it consist of 1.8Ghz mips64r5 4-core CPU and LS7A1000 bridge chip. It has PCIe GEN2 x8 slot, therefore can play with discrete graphics card. Hi J

Re: [PATCH v2 4/7] drm/i915/guc: use the memcpy_from_wc call from the drm

2022-03-22 Thread Balasubramani Vivekanandan
On 21.03.2022 14:14, Lucas De Marchi wrote: > On Thu, Mar 03, 2022 at 11:30:10PM +0530, Balasubramani Vivekanandan wrote: > > memcpy_from_wc functions in i915_memcpy.c will be removed and replaced > > by the implementation in drm_cache.c. > > Updated to use the functions provided by drm_cache.c. >

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

2022-03-22 Thread Sui Jingfeng
On 2022/3/22 21:08, Jiaxun Yang wrote: 在 2022/3/22 2:33, Sui Jingfeng 写道: On 2022/3/22 07:20, Rob Herring wrote: On Tue, Mar 22, 2022 at 12:29:14AM +0800, Sui Jingfeng wrote: From: suijingfeng Needs a commit message. Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273..

Re: [PATCH] drm: drm_bufs: Error out if 'dev->agp' is a null pointer

2022-03-22 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 09:02:47PM +0800, Zheyu Ma wrote: > On Thu, Mar 17, 2022 at 6:49 PM Daniel Vetter wrote: > > > > On Fri, Mar 11, 2022 at 07:23:02AM +, Zheyu Ma wrote: > > > The user program can control the 'drm_buf_desc::flags' via ioctl system > > > call and enter the function drm_leg

[PATCH 1/2] dt-bindings: lcdif: Add compatible for i.MX8MP

2022-03-22 Thread Marek Vasut
Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. However, except for

[PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-03-22 Thread Marek Vasut
pm_runtime_get_sync(drm->dev); + + drm_crtc_vblank_off(&lcdif->crtc); + + drm_kms_helper_poll_fini(drm); + drm_mode_config_cleanup(drm); + + pm_runtime_put_sync(drm->dev); + pm_runtime_disable(drm->dev); + + free_irq(lcdif->irq, drm-

Re: [Intel-gfx] [PATCH 1/4] i915/gem: drop wbinvd_on_all_cpus usage

2022-03-22 Thread Daniel Vetter
On Mon, Mar 21, 2022 at 10:42:03AM -0700, Michael Cheng wrote: > > On 2022-03-21 10:28 a.m., Tvrtko Ursulin wrote: > > > > On 21/03/2022 16:31, Michael Cheng wrote: > > > On 2022-03-21 3:30 a.m., Tvrtko Ursulin wrote: > > > > > > > > > > > On 19/03/2022 19:42, Michael Cheng wrote: > > > > > Pre

[PATCH v2] drm/i915: Add a DP1.2 compatible way to read LTTPR capabilities

2022-03-22 Thread Imre Deak
At least some DELL monitors (P2715Q) with DPCD_REV 1.2 return corrupted DPCD register values when reading from the 0xF- LTTPR range with an AUX transaction block size bigger than 1. The DP standard requires 0 to be returned - as for any other reserved/invalid addresses - but these monitors retu

Re: [PATCH 3/7] drm/gma500: Make use of the drm connector iterator

2022-03-22 Thread Daniel Vetter
On Tue, Mar 22, 2022 at 02:17:38PM +0100, Patrik Jakobsson wrote: > This makes sure we're using proper locking when iterating the list of > connectors. > > Signed-off-by: Patrik Jakobsson Note that this is only needed if your driver deals with hotpluggable connectors. Since gma500 doesn't, not r

Re: [PATCH 0/4] Drop wbinvd_on_all_cpus usage

2022-03-22 Thread Thomas Hellström
On 3/22/22 13:53, Tvrtko Ursulin wrote: On 22/03/2022 11:37, Thomas Hellström wrote: On Tue, 2022-03-22 at 11:20 +, Tvrtko Ursulin wrote: On 22/03/2022 10:26, Thomas Hellström wrote: On Tue, 2022-03-22 at 10:13 +, Tvrtko Ursulin wrote: On 21/03/2022 15:15, Thomas Hellström wrote:

Re: [PATCH 3/7] drm/gma500: Make use of the drm connector iterator

2022-03-22 Thread Patrik Jakobsson
On Tue, Mar 22, 2022 at 3:39 PM Daniel Vetter wrote: > > On Tue, Mar 22, 2022 at 02:17:38PM +0100, Patrik Jakobsson wrote: > > This makes sure we're using proper locking when iterating the list of > > connectors. > > > > Signed-off-by: Patrik Jakobsson > > Note that this is only needed if your dr

Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board

2022-03-22 Thread Jiaxun Yang
在 2022/3/22 13:38, Sui Jingfeng 写道: On 2022/3/22 21:05, Jiaxun Yang wrote: 在 2022/3/21 16:29, Sui Jingfeng 写道: From: suijingfeng The board name is LS3A4000_7A1000_EVB_BOARD_V1.4, it consist of 1.8Ghz mips64r5 4-core CPU and LS7A1000 bridge chip. It has PCIe GEN2 x8 slot, therefore can p

Re: [RFC v3 8/8] selftests: Add binder cgroup gpu memory transfer test

2022-03-22 Thread Christian Brauner
On Mon, Mar 14, 2022 at 05:43:40PM -0700, Todd Kjos wrote: > On Wed, Mar 9, 2022 at 8:53 AM T.J. Mercier wrote: > > > > This test verifies that the cgroup GPU memory charge is transferred > > correctly when a dmabuf is passed between processes in two different > > cgroups and the sender specifies

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

2022-03-22 Thread Jiaxun Yang
在 2022/3/22 13:54, Sui Jingfeng 写道: On 2022/3/22 21:08, Jiaxun Yang wrote: 在 2022/3/22 2:33, Sui Jingfeng 写道: On 2022/3/22 07:20, Rob Herring wrote: On Tue, Mar 22, 2022 at 12:29:14AM +0800, Sui Jingfeng wrote: From: suijingfeng Needs a commit message. Signed-off-by: suijingfeng

[RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin ... Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula Cc: Lucas De Marchi --- Typed up how I see it - bash away. --- drivers/gpu/drm/i915/display/intel_bw.c | 3 +- drivers/gpu/drm/i915/display/intel_display.c | 9 - drivers/gpu/drm/i915/display/intel_display.h |

Re: [Intel-gfx] [PATCH v13 09/13] drm/i915/guc: Check sizing of guc_capture output

2022-03-22 Thread Lucas De Marchi
On Mon, Mar 21, 2022 at 09:45:23AM -0700, Alan Previn wrote: Add intel_guc_capture_output_min_size_est function to provide a reasonable minimum size for error-capture region before allocating the shared buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/in

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-03-22 Thread Vinod Koul
On 17-02-22, 16:11, Marijn Suijten wrote: > Hi Vinod, > > Thanks for taking time to go through this review, please find some > clarifications below. > > On 2022-02-17 16:44:04, Vinod Koul wrote: > > Hi Marijn, > > > > On 11-12-21, 01:03, Marijn Suijten wrote: > > > > > > +static int dsi_dsc_upd

Re: [PATCH v2] drm/i915: Add a DP1.2 compatible way to read LTTPR capabilities

2022-03-22 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 04:38:44PM +0200, Imre Deak wrote: > At least some DELL monitors (P2715Q) with DPCD_REV 1.2 return corrupted > DPCD register values when reading from the 0xF- LTTPR range with an > AUX transaction block size bigger than 1. The DP standard requires 0 to > be returned - as

Re: [PATCH 1/2] dt-bindings: display: imx: Add fsl,imx21-lcdc docs

2022-03-22 Thread Uwe Kleine-König
Hi Rob, On Mon, Feb 21, 2022 at 02:55:36PM +0100, Uwe Kleine-König wrote: > On Thu, Feb 10, 2022 at 06:54:13PM +0100, Lucas Stach wrote: > > Am Dienstag, dem 01.02.2022 um 11:35 -0600 schrieb Rob Herring: > > > On Fri, Jan 28, 2022 at 06:58:29PM +0100, Uwe Kleine-König wrote: > > > > On Fri, Jan 2

[PATCH v6] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-03-22 Thread Vinod Polimera
- Some DPU versions support inline rot90. It is supported only for limited amount of UBWC formats. - There are two versions of inline rotators, v1 (present on sm8250 and sm7250) and v2 (sc7280). These versions differ in the list of supported formats and in the scaler possibilities. Changes in RFC:

Re: [PATCH v13 00/13] Add GuC Error Capture Support

2022-03-22 Thread Lucas De Marchi
On Mon, Mar 21, 2022 at 09:45:14AM -0700, Alan Previn wrote: This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS

Re: [PATCH v2] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-22 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to drm-misc-next On Sat, 2022-03-19 at 11:27 +0100, Christophe Leroy wrote: > While working at fixing powerpc headers, I ended up with the > following error. > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowrom.c:48:1: error: > conflicting types for '

Re: [PATCH 1/2] dt-bindings: display: imx: Add fsl,imx21-lcdc docs

2022-03-22 Thread Rob Herring
On Thu, Feb 10, 2022 at 11:54 AM Lucas Stach wrote: > > Hi Rob, > > Am Dienstag, dem 01.02.2022 um 11:35 -0600 schrieb Rob Herring: > > On Fri, Jan 28, 2022 at 06:58:29PM +0100, Uwe Kleine-König wrote: > > > Hello Rob, > > > > > > On Fri, Jan 28, 2022 at 07:04:10AM -0600, Rob Herring wrote: > > >

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-03-22 Thread Marijn Suijten
On 2022-03-22 22:46:50, Vinod Koul wrote: > On 17-02-22, 16:11, Marijn Suijten wrote: > > Hi Vinod, > > > > Thanks for taking time to go through this review, please find some > > clarifications below. > > > > On 2022-02-17 16:44:04, Vinod Koul wrote: > > > Hi Marijn, > > > > > > On 11-12-21, 01:

Re: [PATCH v7 06/12] clk: Always set the rate on clk_set_range_rate

2022-03-22 Thread Dmitry Osipenko
On 2/25/22 17:35, Maxime Ripard wrote: > When we change a clock minimum or maximum using clk_set_rate_range(), > clk_set_min_rate() or clk_set_max_rate(), the current code will only > trigger a new rate change if the rate is outside of the new boundaries. > > However, a clock driver might want to

[PATCH 1/8] drm: Put related statements next to each other in Makefile

2022-03-22 Thread Thomas Zimmermann
Give the Makefile a bit more structure by putting rules for core, helpers, drivers, etc next to each other. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/driver

[PATCH 0/8] drm: Introduce display-helper library

2022-03-22 Thread Thomas Zimmermann
Move DisplayPort, HDMI and various other display helpers from KMS helpers into a new module. Adapt all drivers. This patch is part of an on-going effort to reduce the minimum size of DRM when linked into the kernel binary. The helpers for various display and video-output standards are not required

[PATCH 7/8] drm/display: Move HDMI helpers into display-helper module

2022-03-22 Thread Thomas Zimmermann
Move DRM's HMDI helpers into the display/ subdirectoy and add it to DRM's display helpers. Update all affected drivers. No functional changes. The HDMI helpers were implemented in the EDID and connector code, but are actually unrelated. With the move to the display-helper library, we can remove th

[PATCH 4/8] drm/display: Split DisplayPort header into core and helper

2022-03-22 Thread Thomas Zimmermann
Move DisplayPort protocol constants and structures into the new header drm_dp.h, which can be used by DRM core components. The existing header drm_dp_helper.h now only contains helper code for graphics drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/drm-kms

[PATCH 5/8] drm/display: Move DSC header and helpers into display-helper module

2022-03-22 Thread Thomas Zimmermann
DSC is the Display Stream Compression standard for DisplayPort. Move the DSC code into display/ and split the header into files for protocol core and DRM helpers. Adapt all users of the code. No functional changes. To avoid the proliferation of Kconfig options, DSC is part of DRM's support for Dis

[PATCH 8/8] drm/display: Move SCDC helpers into display-helper library

2022-03-22 Thread Thomas Zimmermann
SCDC is the Status and Control Data Channel for HDMI. Move the SCDC helpers into display/ and split the header into files for core and helpers. Update all affected drivers. No functional changes. To avoid the proliferation of Kconfig options, SCDC is part of DRM's support for HDMI. If necessary, a

[PATCH 6/8] drm/display: Move HDCP helpers into display-helper module

2022-03-22 Thread Thomas Zimmermann
Move DRM's HDCP helper library into the display/ subdirectory and add it to DRM's display helpers. Split the header file into core and helpers. Update all affected drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/drm-kms-helpers.rst | 2 +- drivers/

[PATCH 2/8] drm: Rename dp/ to display/

2022-03-22 Thread Thomas Zimmermann
Rename dp/ to display/ to account for additional display-related helpers, such as HDMI. Update all related include statements. No functional changes. Various drivers, such as i915 and amdgpu, use similar naming scheme by putting code for video-output standards into a local display/ directory. The

[PATCH 3/8] drm/display: Introduce a DRM display-helper module

2022-03-22 Thread Thomas Zimmermann
Replace the DP-helper module with a display-helper module. Update all related Kconfig and Makefile rules. Besides the existing code for DisplayPort, the new module will contain helpers for other video-output standards, such as HDMI. Drivers will still be able to select the required video-output he

Re: [PATCH 1/7] drm/gma500: Use managed drmm_mode_config_init()

2022-03-22 Thread Thomas Zimmermann
Hi Patrik Am 22.03.22 um 14:17 schrieb Patrik Jakobsson: Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 45df9de

[GIT PULL] fbdev updates & fixes for v5.18-rc1

2022-03-22 Thread Helge Deller
Hello Linus, please pull the latest fbdev updates and fixes for kernel 5.18-rc1. This patchset has been in linux-next without any reported problems and includes a lot of small fixes and code cleanups across many traditional fbdev drivers. Thanks! Helge --

Re: [PATCH 1/7] drm/gma500: Use managed drmm_mode_config_init()

2022-03-22 Thread Thomas Zimmermann
Am 22.03.22 um 20:30 schrieb Thomas Zimmermann: Hi Patrik Am 22.03.22 um 14:17 schrieb Patrik Jakobsson: Signed-off-by: Patrik Jakobsson ---   drivers/gpu/drm/gma500/framebuffer.c | 4 ++--   1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b

Re: [PATCH 3/7] drm/gma500: Make use of the drm connector iterator

2022-03-22 Thread Thomas Zimmermann
Hi Am 22.03.22 um 16:46 schrieb Patrik Jakobsson: On Tue, Mar 22, 2022 at 3:39 PM Daniel Vetter wrote: On Tue, Mar 22, 2022 at 02:17:38PM +0100, Patrik Jakobsson wrote: This makes sure we're using proper locking when iterating the list of connectors. Signed-off-by: Patrik Jakobsson Note

Re: [PATCH 7/7] drm/gma500: Add crtc prefix to vblank functions

2022-03-22 Thread Thomas Zimmermann
Hi Am 22.03.22 um 14:17 schrieb Patrik Jakobsson: These functions operate on a crtc and should be prefixed properly. Suggested-by: Thomas Zimmermann Signed-off-by: Patrik Jakobsson For the whole patchset: Reviewed-by: Thomas Zimmermann If you like, please consider the few comments I had.

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

2022-03-22 Thread Rob Herring
On Tue, Mar 22, 2022 at 09:54:08PM +0800, Sui Jingfeng wrote: > > On 2022/3/22 21:08, Jiaxun Yang wrote: > > > > > > 在 2022/3/22 2:33, Sui Jingfeng 写道: > > > > > > On 2022/3/22 07:20, Rob Herring wrote: > > > > On Tue, Mar 22, 2022 at 12:29:14AM +0800, Sui Jingfeng wrote: > > > > > From: suijin

[PATCH] fbdev: udlfb: properly check endpoint type

2022-03-22 Thread Pavel Skripkin
syzbot reported warning in usb_submit_urb, which is caused by wrong endpoint type. This driver uses out bulk endpoint for communication, so let's check if this endpoint is present and bail out early if not. Fail log: usb 1-1: BOGUS urb xfer, pipe 3 != type 1 WARNING: CPU: 0 PID: 4822 at drivers/

[Bug 215727] New: drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx_0.0.0 timeout when using firefox, chrome or icaclient

2022-03-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215727 Bug ID: 215727 Summary: drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx_0.0.0 timeout when using firefox, chrome or icaclient Product: Drivers Version: 2.5

[Bug 215727] drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx_0.0.0 timeout when using firefox, chrome or icaclient

2022-03-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215727 --- Comment #1 from Wojciech Krol (scal...@poczta.fm) --- Created attachment 300600 --> https://bugzilla.kernel.org/attachment.cgi?id=300600&action=edit Partial umr -R gfx_0.0.0 -- You may reply to this email to add a comment. You are receivi

[PATCH] video: of: display_timing: Remove a redundant zeroing of memory

2022-03-22 Thread Christophe JAILLET
of_parse_display_timing() already call memset(0) on its 2nd argument, so there is no need to clear it explicitly before calling this function. Use kmalloc() instead of kzalloc() to save a few cycles. Signed-off-by: Christophe JAILLET --- drivers/video/of_display_timing.c | 2 +- 1 file changed,

Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller

2022-03-22 Thread Rob Herring
On Tue, Mar 22, 2022 at 12:29:16AM +0800, Sui Jingfeng wrote: > From: suijingfeng > > There is a display controller in loongson's LS2K1000 SoC and LS7A1000 > bridge chip, the display controller is a PCI device in those chips. It > has two display pipes but with only one hardware cursor. Each way

Re: [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller

2022-03-22 Thread Rob Herring
On Tue, Mar 22, 2022 at 10:33:45AM +0800, Sui Jingfeng wrote: > > On 2022/3/22 07:20, Rob Herring wrote: > > On Tue, Mar 22, 2022 at 12:29:14AM +0800, Sui Jingfeng wrote: > > > From: suijingfeng > > > > > Needs a commit message. > > > > > Signed-off-by: suijingfeng > > > Signed-off-by: Sui Jin

Re: Parallel modesets and private state objects broken, where to go with MST?

2022-03-22 Thread Lyude Paul
OK so - this has become a bit of a larger rabbit hole. I've been putting quite a bit of work into this and I think I'm starting to make some progress - although on a different aspect of this issue. After talking with danvet they realized that we're also potentially not handling encoder stealing wit

[RFC 00/19] drm/edid: overhaul CEA data block iteration

2022-03-22 Thread Jani Nikula
Add iterators for EDID blocks and CEA data blocks, to iterate through all data blocks across all CEA extensions and CTA blocks in DisplayID data blocks. Fix all code assuming only one CEA extension. Fix code assuming CTA blocks contain everything that CEA extensions do. Sprinkle a bunch of cleanups

[RFC 02/19] drm: use drm_edid_extension_block_count() and drm_edid_size()

2022-03-22 Thread Jani Nikula
Use the block count and size helpers in all drm core code. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_connector.c | 2 +- drivers/gpu/drm/drm_debugfs.c | 3 +-- drivers/gpu/drm/drm_edid.c | 14 +++--- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/driver

[RFC 01/19] drm/edid: add drm_edid_extension_block_count() and drm_edid_size()

2022-03-22 Thread Jani Nikula
Add abstractions for getting the number of EDID extension blocks and the total EDID size in bytes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 18 ++ include/drm/drm_edid.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/d

[RFC 03/19] drm/edid: clean up CEA data block tag definitions

2022-03-22 Thread Jani Nikula
Add prefixed names, group, sort, add references. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 59 +- 1 file changed, 32 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b96906774433..6c18

[RFC 04/19] drm/edid: add iterator for EDID base and extension blocks

2022-03-22 Thread Jani Nikula
Add an iterator abstraction for going through all the EDID blocks. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 6c188539493e..31d

[RFC 05/19] drm/edid: add iterator for CEA data blocks

2022-03-22 Thread Jani Nikula
Add an iterator for CEA Data Blocks across CEA extensions and CTA DisplayID Data Blocks. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 198 ++--- 1 file changed, 186 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gp

[RFC 06/19] drm/edid: clean up cea_db_is_*() functions

2022-03-22 Thread Jani Nikula
Abstract helpers for matching vendor data blocks and extended tags, and use them to simplify all the cea_db_is_*() functions. Take void pointer as parameter to allow transitional use for both u8 * and struct cea_db *. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 113 -

[RFC 07/19] drm/edid: convert add_cea_modes() to use cea db iter

2022-03-22 Thread Jani Nikula
Iterate through all CEA EDID extension blocks and DisplayID CTA data blocks to add CEA modes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 67 ++ 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/driver

[RFC 09/19] drm/edid: convert drm_edid_to_sad() to use cea db iter

2022-03-22 Thread Jani Nikula
Use the cea db iterator for short audio descriptors. We'll still stop at the first audio data block, but not at the first CEA extension if that doesn't have the info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 34 +- 1 file changed, 9 insertions(+

[RFC 08/19] drm/edid: convert drm_edid_to_speaker_allocation() to use cea db iter

2022-03-22 Thread Jani Nikula
Use the cea db iterator for speaker allocation. We'll still stop at the first speaker data block, but not at the first CEA extension if that doesn't have the info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 47 -- 1 file changed, 15 insertions

[RFC 10/19] drm/edid: convert drm_detect_hdmi_monitor() to use cea db iter

2022-03-22 Thread Jani Nikula
Iterate through all CEA data blocks, not just the first CEA extension. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index e34179052

[RFC 11/19] drm/edid: convert drm_detect_monitor_audio() to use cea db iter

2022-03-22 Thread Jani Nikula
Iterate through all CEA data blocks. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 399e69dc1aed..77763d94dd93 100644 --- a/drive

[RFC 13/19] drm/edid: convert drm_edid_to_eld() to use cea db iter

2022-03-22 Thread Jani Nikula
Iterate through all CEA data blocks across all CEA extensions and DisplayID data blocks. This may gather more data than before, and if there's duplicated data, some is overwritten by whichever comes last. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 64 +---

[RFC 12/19] drm/edid: convert drm_parse_cea_ext() to use cea db iter

2022-03-22 Thread Jani Nikula
Iterate through all CEA data blocks across all CEA extensions and DisplayID data blocks. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid

[RFC 15/19] drm/edid: restore some type safety to cea_db_*() functions

2022-03-22 Thread Jani Nikula
During the transition, we accepted a void pointer for a poor C programmer's version of polymorphism. Switch the functions to use struct cea_db * to regain some more type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 19 --- 1 file changed, 8 insertions(+), 1

[RFC 14/19] drm/edid: sunset the old unused cea data block iterators

2022-03-22 Thread Jani Nikula
All CEA data block iteration has now been converted to the new cea db iterators. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 45 -- 1 file changed, 45 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ccba

[RFC 18/19] drm/edid: skip CEA extension scan in drm_edid_to_eld() just for CEA rev

2022-03-22 Thread Jani Nikula
The DisplayID CTA data block version does not necessarily match the CEA revision. Simplify by postponing drm_edid_to_eld() slightly, and reusing the CEA revision extracted by drm_parse_cea_ext(). By not bailing out early in drm_edid_to_eld() we may end up filling meaningless data to the ELD. Howev

[RFC 17/19] drm/edid: detect color formats and CEA revision only on CEA extension

2022-03-22 Thread Jani Nikula
The CTA data block in DisplayID does not have the bits from byte 3 that a CEA extension has. Only look for them in CEA extensions, but also look for them in all CEA extensions. The DisplayID CTA data block version does not seem to match the CEA revision either. Ignore it for the purpose of CEA rev

[RFC 19/19] drm/edid: sunset drm_find_cea_extension()

2022-03-22 Thread Jani Nikula
Convert drm_find_cea_extension() to a predicate function to check if the EDID has a CEA extension or a DisplayID CTA data block. This is mainly to avoid adding new users that only find the first CEA extension. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 17 - 1 fi

[RFC 16/19] drm/edid: detect basic audio only on CEA extension

2022-03-22 Thread Jani Nikula
The CTA data block in DisplayID does not have the bits from byte 3 that a CEA extension has. Only look for them in CEA extensions, but also look for them in all CEA extensions. References: https://patchwork.freedesktop.org/patch/msgid/20220321044330.27723-1-cooper.ch...@intel.com Signed-off-by: J

Re: [PATCH 1/7] drm/gma500: Use managed drmm_mode_config_init()

2022-03-22 Thread Patrik Jakobsson
On Tue, Mar 22, 2022 at 8:32 PM Thomas Zimmermann wrote: > > > > Am 22.03.22 um 20:30 schrieb Thomas Zimmermann: > > Hi Patrik > > > > Am 22.03.22 um 14:17 schrieb Patrik Jakobsson: > >> Signed-off-by: Patrik Jakobsson > >> --- > >> drivers/gpu/drm/gma500/framebuffer.c | 4 ++-- > >> 1 file ch

  1   2   >