RE: [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-16 Thread Yang, Fei
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>> b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>> index e1470bb60f34..7e8552414275 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c >>> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c

Re: [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-16 Thread Dmitry Baryshkov
On 16/03/2022 03:28, Abhinav Kumar wrote: On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MSM DRM driver already allows one to compile out the DP or DSI support. Add support for disabling other features like MDP4/MDP5/DPU drivers or direct HDMI output support. Suggested-by: Stephen Boyd Signed-

RE: [Intel-gfx] [PATCH v6 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9)

2022-03-16 Thread Kasireddy, Vivek
Hi Tvrtko, > > On 15/03/2022 07:28, Kasireddy, Vivek wrote: > > Hi Tvrtko, Daniel, > > > >> > >> On 11/03/2022 09:39, Daniel Vetter wrote: > >>> On Mon, 7 Mar 2022 at 21:38, Vivek Kasireddy > >>> wrote: > > On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or > m

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-16 Thread Sascha Hauer
On Tue, Mar 15, 2022 at 02:46:35PM +0800, Andy Yan wrote: > Hi Sascha: > > On 3/11/22 16:33, Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver ha

Re: [PATCH v2 0/6] Allow drm_writeback_connector to accept pointer to drm_encoder

2022-03-16 Thread Dmitry Baryshkov
Hi Abhinav, On 16/03/2022 02:11, Abhinav Kumar wrote: There are some vendor drivers for which the writeback encoder shares hardware resources such as clocks and interrupts with the rest of the display pipeline. In addition, there can be use-cases where the writeback encoder could be a shared enc

[PATCH] drm/blend: fix typo in the comment

2022-03-16 Thread Dmitry Baryshkov
The documentation for drm_rotation_simplify() uses DRM_MODE_ROTATE_X, while it's clear the the comment should mention DRM_MODE_REFLECT_X instead. The example passes all flags except the DRM_MODE_REFLECT_X as supported and expects to eliminate this flag. Fixes: c2c446ad2943 ("drm: Add DRM_MODE_ROTA

Re: [Intel-gfx] [PATCH 18/22] drm/i915: Use drm_mode_init() for on-stack modes

2022-03-16 Thread Jani Nikula
On Fri, 18 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Initialize on-stack modes with drm_mode_init() to guarantee > no stack garbage in the list head, or that we aren't copying > over another mode's list head. > > Based on the following cocci script, with manual fixups: > @decl@ > i

Re: [Intel-gfx] [PATCH 19/22] drm/i915: Use drm_mode_copy()

2022-03-16 Thread Jani Nikula
On Fri, 18 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > struct drm_display_mode embeds a list head, so overwriting > the full struct with another one will corrupt the list > (if the destination mode is on a list). Use drm_mode_copy() > instead which explicitly preserves the list head

Re: [PATCH] drm/blend: fix typo in the comment

2022-03-16 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH v8 08/16] drm/meson: dw-hdmi: Don't open code devm_clk_get_enabled()

2022-03-16 Thread Neil Armstrong
On 14/03/2022 15:16, Uwe Kleine-König wrote: devm_clk_get_enabled() returns a clock prepared and enabled and already registers a devm exit handler to disable (and unprepare) the clock. There is slight change in behavior as a failure to enable the clock now results in an error message, too. Also

Re: (subset) [PATCH] drm/blend: fix typo in the comment

2022-03-16 Thread Maxime Ripard
On Wed, 16 Mar 2022 10:46:48 +0300, Dmitry Baryshkov wrote: > The documentation for drm_rotation_simplify() uses DRM_MODE_ROTATE_X, > while it's clear the the comment should mention DRM_MODE_REFLECT_X > instead. The example passes all flags except the DRM_MODE_REFLECT_X as > supported and expects t

Re: [PATCH v7 00/12] clk: Improve clock range handling

2022-03-16 Thread Maxime Ripard
Hi, On Fri, Mar 11, 2022 at 07:08:39PM -0800, Stephen Boyd wrote: > Quoting Maxime Ripard (2022-02-25 06:35:22) > > Hi, > > > > This is a follow-up of the discussion here: > > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > > > and here: > > https://lore.kernel.org

[PATCH] drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire()

2022-03-16 Thread Dan Carpenter
This post-op should be a pre-op so that we do not pass -1 as the bit number to test_bit(). The current code will loop downwards from 63 to -1. After changing to a pre-op, it loops from 63 to 0. Fixes: 71c37505e7ea ("drm/amdgpu/gfx: move more common KIQ code to amdgpu_gfx.c") Signed-off-by: Dan

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-16 Thread Pekka Paalanen
On Tue, 15 Mar 2022 10:54:38 -0400 Alex Deucher wrote: > On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote: > > > > On Mon, 14 Mar 2022 10:23:27 -0400 > > Alex Deucher wrote: > > > > > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen > > > wrote: > > > > > > > > On Thu, 10 Mar 2022 11:5

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/gem: Remove logic for wbinvd_on_all_cpus

2022-03-16 Thread Intel
Hi, Michael, others. This is the response from Linus last time we copied that already pre-existing wbinvd_on_all_cpus() macro to another place in the driver: https://lists.freedesktop.org/archives/dri-devel/2021-November/330928.html My first interpretation of this is that even if there curren

Re: Parallel modesets and private state objects broken, where to go with MST?

2022-03-16 Thread Pekka Paalanen
On Mon, 14 Mar 2022 18:16:36 -0400 Lyude Paul wrote: > So, the actual problem: following a conversation with Daniel Vetter today I've > gotten the impression that private modesetting objects are basically just > broken with parallel modesets? I'm still wrapping my head around all of this > honest

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Sascha Hauer
On Mon, Mar 14, 2022 at 08:54:27PM +0300, Dmitry Osipenko wrote: > On 3/14/22 11:18, Sascha Hauer wrote: > > On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: > >> On 3/11/22 11:33, Sascha Hauer wrote: > >>> The rk3568 HDMI has an additional clock that needs to be enabled for the > >

Re: [PATCH v4 00/24] DEPT(Dependency Tracker)

2022-03-16 Thread Hyeonggon Yoo
On Wed, Mar 16, 2022 at 01:32:13PM +0900, Byungchul Park wrote: > On Sat, Mar 12, 2022 at 01:53:26AM +, Hyeonggon Yoo wrote: > > On Fri, Mar 04, 2022 at 04:06:19PM +0900, Byungchul Park wrote: > > > Hi Linus and folks, > > > > > > I've been developing a tool for detecting deadlock possibilitie

Re: [PATCH v2] drm: Fix a infinite loop condition when order becomes 0

2022-03-16 Thread Christian König
Am 16.03.22 um 07:34 schrieb Arunpravin Paneer Selvam: handle a situation in the condition order-- == min_order, when order = 0 and min_order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return

Re: [RFC PATCH 5/7] drm/ttm: add range busy check for range manager

2022-03-16 Thread Christian König
Am 15.03.22 um 19:04 schrieb Robert Beckett: RFC: do we want this to become a generic interface in ttm_resource_manager_func? RFC: would we prefer a different interface? e.g. for_each_resource_in_range or for_each_bo_in_range Well completely NAK to that. Why do you need that? The long term go

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-16 Thread Tvrtko Ursulin
On 04/03/2022 22:14, fei.y...@intel.com wrote: From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalid

Re: [PATCH 1/2] drm: mediatek: mtk_drm_plane: Use kmalloc in mtk_plane_duplicate_state

2022-03-16 Thread AngeloGioacchino Del Regno
Il 25/01/22 17:36, Chun-Kuang Hu ha scritto: Hi, AngeloGioacchino: AngeloGioacchino Del Regno 於 2022年1月18日 週二 下午9:38寫道: There is no need to zero out the newly allocated memory because we are duplicating all members of struct mtk_plane_state: switch to kmalloc to save some overhead. Reviewed

RE: [PATCH] WIP: drm/dp_mst: Add support for dumping topology ref histories from debugfs

2022-03-16 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Wednesday, March 16, 2022 8:48 AM > To: Lin, Wayne > Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org > Subject: Re: [PATCH] WIP: drm/dp_mst: Add support for dumping topology ref > histories from debugfs > > (Add

Re: Parallel modesets and private state objects broken, where to go with MST?

2022-03-16 Thread Ville Syrjälä
On Mon, Mar 14, 2022 at 06:16:36PM -0400, Lyude Paul wrote: > Hi! First a little bit of background: I've recently been trying to get rid of > all of the non-atomic payload bandwidth management code in the MST helpers in > order to make it easier to implement DSC and fallback link rate retraining >

Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-16 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2022-03-14 17:35:17) > > On 12/03/2022 04:16, Matt Atwood wrote: > > On Thu, Mar 10, 2022 at 12:26:12PM +, Tvrtko Ursulin wrote: > >> > >> On 10/03/2022 05:18, Matt Atwood wrote: > >>> Newer platforms have DSS that aren't necessarily available for both > >>> geometry an

Re: [PATCH v2] drm: Fix a infinite loop condition when order becomes 0

2022-03-16 Thread Matthew Auld
On 16/03/2022 06:34, Arunpravin Paneer Selvam wrote: handle a situation in the condition order-- == min_order, when order = 0 and min_order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return -E

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-16 Thread Andy Yan
Hi Sascha and Daniel: On 3/16/22 15:40, Sascha Hauer wrote: On Tue, Mar 15, 2022 at 02:46:35PM +0800, Andy Yan wrote: Hi Sascha: On 3/11/22 16:33, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the ol

Re: [PATCH v2] drm: Fix a infinite loop condition when order becomes 0

2022-03-16 Thread Christian König
Am 16.03.22 um 12:31 schrieb Matthew Auld: On 16/03/2022 06:34, Arunpravin Paneer Selvam wrote: handle a situation in the condition order-- == min_order, when order = 0 and min_order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same co

Re: [PATCH v5] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-03-16 Thread Dmitry Baryshkov
On 15/03/2022 13:07, Vinod Polimera wrote: - Some DPU versions support inline rot90. It is supported only for limited amount of UBWC formats. - There are two versions of inline rotators, v1 (present on sm8250 and sm7250) and v2 (sc7280). These versions differ in the list of supported formats and

Re: [PATCH v2 4/8] drm/virtio: Improve DMA API usage for shmem BOs

2022-03-16 Thread Robin Murphy
On 2022-03-14 22:42, Dmitry Osipenko wrote: DRM API requires the DRM's driver to be backed with the device that can be used for generic DMA operations. The VirtIO-GPU device can't perform DMA operations if it uses PCI transport because PCI device driver creates a virtual VirtIO-GPU device that is

Re: [PATCH 0/3] Move FPU related code from DCN3.1x drivers to DML folder

2022-03-16 Thread Rodrigo Siqueira Jordao
On 2022-03-07 10:47, Melissa Wen wrote: This series moves FPU code from DCN 3.1x drivers to dml/dcn31 folder to isolate FPU operations. For this, it creates dcn31_fpu files to centralize FPU operations and structs from dcn31x drivers, that include: - _vcs_dpi_ip_params_st and _vcs_dpi_soc_boun

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Dmitry Osipenko
On 3/16/22 12:12, Sascha Hauer wrote: > On Mon, Mar 14, 2022 at 08:54:27PM +0300, Dmitry Osipenko wrote: >> On 3/14/22 11:18, Sascha Hauer wrote: >>> On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: On 3/11/22 11:33, Sascha Hauer wrote: > The rk3568 HDMI has an additional c

[PATCH v2 0/7] Add RZ/G2L Display support

2022-03-16 Thread Biju Das
RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. This patch series aims to add basic display support on RZ/G2L SMARC EVK platform. T

[PATCH v2 1/7] dt-bindings: display: renesas, du: Document r9a07g044l bindings

2022-03-16 Thread Biju Das
Extend the Renesas DU display bindings to support the r9a07g044l DU module found on RZ/G2L LCDC. Signed-off-by: Biju Das --- v1->v2: * Updated commit description. * Removed LCDC references * Changed clock name from du.0->aclk * Changed reset name from du.0->du RFC->v1: * Changed minItems->m

[PATCH v2 2/7] drm: rcar-du: Add num_rpf to struct rcar_du_device_info

2022-03-16 Thread Biju Das
Number of RPF's VSP is different on R-Car and RZ/G2L R-Car Gen3 -> 5 RPFs R-Car Gen2 -> 4 RPFs RZ/G2L -> 2 RPFs Add num_rpf to struct rcar_du_device_info to support later SoC without any code changes. Signed-off-by: Biju Das --- v1->v2: * No change RFC->v1: * Fixed the comment for num_rpf s

[PATCH v2 3/7] drm: rcar-du: Add max_width and max_height to struct rcar_du_device_info

2022-03-16 Thread Biju Das
There are some differences related to max frame size supported by different R-Car/RZ-G family of SoC's Max frame size supported by R-Car Gen1 & R-Car Gen2 is 4095x2047 Max frame size supported by R-Car Gen3 is 8190x8190 Max frame size supported by RZ/G2L is 1920x1080 Add max_width and max_height

[PATCH v2 6/7] drm: rcar-du: Factorise rcar_du_vsp{complete, enable, plane_atomic_check}

2022-03-16 Thread Biju Das
RZ/G2L SoC's does not have group/plane registers compared to RCar, hence it needs a different CRTC implementation. Factorise rcar_du_vsp{complete, enable,plane_atomic_check} so that it can support RZ/G2L SoC without any code changes. Signed-off-by: Biju Das --- v1->v2: * No change RFC->v1: * Ne

[PATCH v2 5/7] drm: rcar-du: Factorise rcar_du_{atomic_check, modeset_init}

2022-03-16 Thread Biju Das
RZ/G2L SoC's does not have group/plane registers compared to RCar, hence it needs a different CRTC implementation. Factorise rcar_du_{atomic_check, modeset_init} by adding struct rcar_du_crtc_helper_funcs to struct rcar_du_device_info, so that it can support RZ/G2L SoC without any code changes. Si

[PATCH v2 7/7] drm: rcar-du: Add RZ/G2L DU Support

2022-03-16 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support blending of two picture layers and raster operations (ROPs). The DU part i

[PATCH v2 4/7] drm: rcar-du: Move rcar_du_output_name() to rcar_du_common.c

2022-03-16 Thread Biju Das
RZ/G2L SoC's does not have group/plane registers compared to RCar, hence it needs a different CRTC implementation. Move rcar_du_output_name() to a new common file rcar_du_common.c, So that the same function can be reused by RZ/G2L SoC later. Signed-off-by: Biju Das --- v1->v2: * No change RFC->

Re: [PATCH 07/22] drm/gma500: Use drm_mode_copy()

2022-03-16 Thread Patrik Jakobsson
On Fri, Feb 18, 2022 at 11:04 AM Ville Syrjala wrote: > > From: Ville Syrjälä > > struct drm_display_mode embeds a list head, so overwriting > the full struct with another one will corrupt the list > (if the destination mode is on a list). Use drm_mode_copy() > instead which explicitly preserves

Re: [RFC PATCH 5/7] drm/ttm: add range busy check for range manager

2022-03-16 Thread Robert Beckett
On 16/03/2022 09:54, Christian König wrote: Am 15.03.22 um 19:04 schrieb Robert Beckett: RFC: do we want this to become a generic interface in ttm_resource_manager_func? RFC: would we prefer a different interface? e.g. for_each_resource_in_range or for_each_bo_in_range Well completely NAK

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/gem: Don't try to map and fence large scanout buffers (v9)

2022-03-16 Thread Tvrtko Ursulin
On 16/03/2022 07:37, Kasireddy, Vivek wrote: Hi Tvrtko, On 15/03/2022 07:28, Kasireddy, Vivek wrote: Hi Tvrtko, Daniel, On 11/03/2022 09:39, Daniel Vetter wrote: On Mon, 7 Mar 2022 at 21:38, Vivek Kasireddy wrote: On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or

Re: [PATCH v8 18/19] drm/mediatek: change the aux retries times when receiving AUX_DEFER

2022-03-16 Thread Chen-Yu Tsai
On Fri, Feb 18, 2022 at 11:15 PM Guillaume Ranquet wrote: > > From: Jitao Shi > > DP 1.4a Section 2.8.7.1.5.6.1: > A DP Source device shall retry at least seven times upon receiving > AUX_DEFER before giving up the AUX transaction. > > Aux should retry to send msg whether how many bytes. > > Sign

Re: [RFC PATCH 5/7] drm/ttm: add range busy check for range manager

2022-03-16 Thread Christian König
Am 16.03.22 um 14:19 schrieb Robert Beckett: On 16/03/2022 09:54, Christian König wrote: Am 15.03.22 um 19:04 schrieb Robert Beckett: RFC: do we want this to become a generic interface in ttm_resource_manager_func? RFC: would we prefer a different interface? e.g. for_each_resource_in_range o

Re: [PATCH v2 4/8] drm/virtio: Improve DMA API usage for shmem BOs

2022-03-16 Thread Dmitry Osipenko
On 3/16/22 15:41, Robin Murphy wrote: > On 2022-03-14 22:42, Dmitry Osipenko wrote: >> DRM API requires the DRM's driver to be backed with the device that can >> be used for generic DMA operations. The VirtIO-GPU device can't perform >> DMA operations if it uses PCI transport because PCI device d

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Robin Murphy
On 2022-03-16 13:01, Dmitry Osipenko wrote: On 3/16/22 12:12, Sascha Hauer wrote: On Mon, Mar 14, 2022 at 08:54:27PM +0300, Dmitry Osipenko wrote: On 3/14/22 11:18, Sascha Hauer wrote: On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: On 3/11/22 11:33, Sascha Hauer wrote: The

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Dmitry Osipenko
On 3/16/22 16:55, Robin Murphy wrote: >> To me that NIU quirk should be internal to the clk h/w module, so it >> doesn't feel nice to mix the clk h/w description with the HDMI h/w >> description. >> >> On the other hand, making clk driver to handle this case indeed will >> take some effort as I see

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-16 Thread Alex Deucher
On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen wrote: > > On Tue, 15 Mar 2022 10:54:38 -0400 > Alex Deucher wrote: > > > On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote: > > > > > > On Mon, 14 Mar 2022 10:23:27 -0400 > > > Alex Deucher wrote: > > > > > > > On Fri, Mar 11, 2022 at 3:30 AM

Re: [PATCH v2 7/8] drm/virtio: Support memory shrinking

2022-03-16 Thread Dmitry Osipenko
On 3/15/22 15:43, Emil Velikov wrote: > Greetings everyone, > > Food for thought: Would it make sense to have the madvise ioctl as > generic DRM one? > Looking around - i915, msm & panfrost already have one and the virtio > implementation [below] seems as generic as it gets. > > On Mon, 14 Mar 20

Re: [RFC PATCH 5/7] drm/ttm: add range busy check for range manager

2022-03-16 Thread Robert Beckett
On 16/03/2022 13:43, Christian König wrote: Am 16.03.22 um 14:19 schrieb Robert Beckett: On 16/03/2022 09:54, Christian König wrote: Am 15.03.22 um 19:04 schrieb Robert Beckett: RFC: do we want this to become a generic interface in ttm_resource_manager_func? RFC: would we prefer a differ

Re: [PATCH v8 09/24] drm/rockchip: dw_hdmi: Add support for niu clk

2022-03-16 Thread Sascha Hauer
On Wed, Mar 16, 2022 at 04:01:49PM +0300, Dmitry Osipenko wrote: > On 3/16/22 12:12, Sascha Hauer wrote: > > On Mon, Mar 14, 2022 at 08:54:27PM +0300, Dmitry Osipenko wrote: > >> On 3/14/22 11:18, Sascha Hauer wrote: > >>> On Sun, Mar 13, 2022 at 12:07:56AM +0300, Dmitry Osipenko wrote: > On 3

Re: [RFC PATCH 5/7] drm/ttm: add range busy check for range manager

2022-03-16 Thread Christian König
Am 16.03.22 um 15:26 schrieb Robert Beckett: [SNIP] this is where I replace an existing range check via drm_mm with the range check I added in this patch. Mhm, I still don't get the use case from the code, but I don't think it matters any more. I suppose we could add another drm_mm range t

Re: [PATCH v2 6/8] drm/shmem-helper: Add generic memory shrinker

2022-03-16 Thread Steven Price
On 14/03/2022 22:42, Dmitry Osipenko wrote: > Introduce a common DRM SHMEM shrinker. It allows to reduce code > duplication among DRM drivers, it also handles complicated lockings > for the drivers. This is initial version of the shrinker that covers > basic needs of GPU drivers. > > This patch is

Re: [PATCH v2 8/8] drm/panfrost: Switch to generic memory shrinker

2022-03-16 Thread Steven Price
On 14/03/2022 22:42, Dmitry Osipenko wrote: > Replace Panfrost's memory shrinker with a generic DRM memory shrinker. > > Signed-off-by: Dmitry Osipenko > --- I gave this a spin on my Firefly-RK3288 board and everything seems to work. So feel free to add a: Tested-by: Steven Price As Alyssa ha

Re: [PATCH 1/2] drm: mediatek: mtk_drm_plane: Use kmalloc in mtk_plane_duplicate_state

2022-03-16 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年3月16日 週三 下午6:40寫道: > > Il 25/01/22 17:36, Chun-Kuang Hu ha scritto: > > Hi, AngeloGioacchino: > > > > AngeloGioacchino Del Regno 於 > > 2022年1月18日 週二 下午9:38寫道: > >> > >> There is no need to zero out the newly allocated memory because we are > >> dupli

Re: [PATCH -next] drm/solomon: Make DRM_SSD130X depends on MMU

2022-03-16 Thread Javier Martinez Canillas
On 3/15/22 10:18, Javier Martinez Canillas wrote: > Hello YueHaibing, > > Thanks for the patch. > > On 3/12/22 07:34, YueHaibing wrote: >> WARNING: unmet direct dependencies detected for DRM_GEM_SHMEM_HELPER >> Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && MMU [=n] >> Selected by [m]: >> -

Re: [PATCH V8 1/5] dt-bindings: display: mediatek: add aal binding for MT8183

2022-03-16 Thread Krzysztof Kozlowski
On 16/03/2022 12:51, Rex-BC Chen wrote: > Add aal binding for MT8183. > > Signed-off-by: Rex-BC Chen > --- > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml| 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/med

Re: [RFC PATCH 5/7] drm/ttm: add range busy check for range manager

2022-03-16 Thread Robert Beckett
On 16/03/2022 14:39, Christian König wrote: Am 16.03.22 um 15:26 schrieb Robert Beckett: [SNIP] this is where I replace an existing range check via drm_mm with the range check I added in this patch. Mhm, I still don't get the use case from the code, but I don't think it matters any more.

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-16 Thread Rob Clark
On Wed, Mar 16, 2022 at 7:12 AM Alex Deucher wrote: > > On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen wrote: > > [snip] > > With new UAPI comes the demand of userspace proof, not hand-waving. You > > would not be proposing this new interface if you didn't have use cases > > in mind, even just on

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-16 Thread Alex Deucher
On Wed, Mar 16, 2022 at 11:35 AM Rob Clark wrote: > > On Wed, Mar 16, 2022 at 7:12 AM Alex Deucher wrote: > > > > On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen wrote: > > > > [snip] > > > With new UAPI comes the demand of userspace proof, not hand-waving. You > > > would not be proposing this n

Re: [PATCH v2 0/6] Allow drm_writeback_connector to accept pointer to drm_encoder

2022-03-16 Thread Abhinav Kumar
Hi Dmitry On 3/16/2022 12:40 AM, Dmitry Baryshkov wrote: Hi Abhinav, On 16/03/2022 02:11, Abhinav Kumar wrote: There are some vendor drivers for which the writeback encoder shares hardware resources such as clocks and interrupts with the rest of the display pipeline. In addition, there can be

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-16 Thread Rob Clark
On Wed, Mar 16, 2022 at 8:48 AM Alex Deucher wrote: > > On Wed, Mar 16, 2022 at 11:35 AM Rob Clark wrote: > > > > On Wed, Mar 16, 2022 at 7:12 AM Alex Deucher wrote: > > > > > > On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen > > > wrote: > > > > > > [snip] > > > > With new UAPI comes the deman

RE: [RFC PATCH v2 5/5] drm/msm/dp: remove extra wrappers and public functions

2022-03-16 Thread Sankeerth Billakanti (QUIC)
> Subject: [RFC PATCH v2 5/5] drm/msm/dp: remove extra wrappers and > public functions > Date: Sat, 12 Feb 2022 01:40:06 +0300 > From: Dmitry Baryshkov > To: Bjorn Andersson , Rob Clark > , Sean Paul , Abhinav Kumar > , Kuogee Hsieh > CC: Stephen Boyd , David Airlie , > Daniel Vetter , linux-arm-

RE: [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

2022-03-16 Thread Sankeerth Billakanti (QUIC)
> Subject: Re: [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with > drm_bridge_connector > Date: Wed, 23 Feb 2022 16:40:56 -0800 > From: Kuogee Hsieh > To: Stephen Boyd , Dmitry Baryshkov > > CC: Abhinav Kumar , Bjorn Andersson > , Rob Clark , Sean Paul > , David Airlie , Daniel Vetter > ,

Re: [PATCH v2 00/12] drm/gma500: Various cleanups to GEM code

2022-03-16 Thread Patrik Jakobsson
On Tue, Mar 8, 2022 at 8:52 PM Thomas Zimmermann wrote: > > Refactor and simplify various parts of the memory management. This > includes locking, initialization and finalizer functions, and code > organization. > > Tested on Atom N2800 hardware. > > v2: > * put common code in psb_gtt_{ini

Re: [PATCH v1 1/1] staging: fbtft: Consider type of init sequence values in fbtft_init_display()

2022-03-16 Thread Andy Shevchenko
On Mon, Mar 14, 2022 at 06:28:41PM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote: ... > Any reason you didn't test build this? My test build doesn't include the WERROR for this driver, so I missed the warning. Sorry for that. Now fixed. > dri

[PATCH v2 1/2] staging: fbtft: Constify buf parameter in fbtft_dbg_hex()

2022-03-16 Thread Andy Shevchenko
It's obvious that we don't and shouldn't modify buffer that is about to be dumped. Constify parameter in fbtft_dbg_hex() to make it clear. Fixes: c296d5f9957c ("staging: fbtft: core support") Signed-off-by: Andy Shevchenko --- v2: new patch to fix a warning (Greg) drivers/staging/fbtft/fbtft-cor

[PATCH v2 2/2] staging: fbtft: Consider type of init sequence values in fbtft_init_display()

2022-03-16 Thread Andy Shevchenko
In the fbtft_init_display() the init sequence is printed for the debug purposes. Unfortunately the current code doesn't take into account that values in the buffer are of the s16 type. Consider that and replace the printing code with fbtft_par_dbg_hex() call. Fixes: b97014a9 ("staging/fbtft:

Re: [Freedreno] [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-16 Thread Abhinav Kumar
On 3/16/2022 12:31 AM, Dmitry Baryshkov wrote: On 16/03/2022 03:28, Abhinav Kumar wrote: On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MSM DRM driver already allows one to compile out the DP or DSI support. Add support for disabling other features like MDP4/MDP5/DPU drivers or direct HDMI o

[PATCH v5 0/9] Add support for the eDP panel on sc7280 CRD

2022-03-16 Thread Sankeerth Billakanti
This series adds support for eDP on sc7280 CRD platform. These changes are dependent on the following series in order: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=620127&state=* https://patchwork.kernel.org/project/linux-arm-msm/list/?series=616587&state=* https://patchwork.ker

[PATCH v5 1/9] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

2022-03-16 Thread Sankeerth Billakanti
Rename the edp_out label in the sc7280 platform to mdss_edp_out so that the nodes related to mdss are all grouped together in the board specific files. Signed-off-by: Sankeerth Billakanti --- Changes in v5: - Change the order of patches - Modify commit text arch/arm64/boot/dts/qcom/sc7280.

[PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-16 Thread Sankeerth Billakanti
Enable support for eDP interface via aux_bus on CRD platform. Signed-off-by: Sankeerth Billakanti --- Changes in v5: - Change the order of patches - Remove the backlight nodes - Remove the bias setting - Fix compilation issue - Model VREG_EDP_BP for backlight power Changes in v4: -

[PATCH v5 3/9] arm64: dts: qcom: sc7280: Enable backlight for eDP panel

2022-03-16 Thread Sankeerth Billakanti
Enable backlight support for eDP panel on CRD platform for sc7280. Signed-off-by: Sankeerth Billakanti --- Changes in v5: - Separate out backlight nodes arch/arm64/boot/dts/qcom/sc7280-crd.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc

[PATCH v5 4/9] drm/panel-edp: add LQ140M1JW46 edp panel entry

2022-03-16 Thread Sankeerth Billakanti
Add panel identification entry for the sharp LQ140M1JW46 eDP panel with power sequencing delay information. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/pan

[PATCH v5 5/9] drm/msm/dp: Add eDP support via aux_bus

2022-03-16 Thread Sankeerth Billakanti
This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel should be ready before the bridge connec

[PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-16 Thread Sankeerth Billakanti
The source device should ensure the sink is ready before proceeding to read the sink capability or performing any aux transactions. The sink will indicate its readiness by asserting the HPD line. The eDP sink requires power from the source and its HPD line will be asserted only aft

[PATCH v5 7/9] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-03-16 Thread Sankeerth Billakanti
The panel-edp enables the eDP panel power during probe, get_modes and enable. The eDP connect and disconnect interrupts for the eDP/DP controller are directly dependent on panel power. As eDP display can be assumed as always connected, the controller driver can skip the eDP connect and disc

[PATCH v5 8/9] drm/msm/dp: Handle eDP mode_valid case

2022-03-16 Thread Sankeerth Billakanti
The panel-edp driver modes needs to be validated differently from DP because the link capabilities are not available for EDP by that time. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/

[PATCH v5 9/9] drm/msm/dp: Support edp/dp without hpd

2022-03-16 Thread Sankeerth Billakanti
Some eDP sinks or platform boards will not support hpd. This patch adds support for those cases. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_catalog.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gp

RE: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-16 Thread Yang, Fei
>> diff --git a/drivers/gpu/drm/i915/gt/gen2_engine_cs.c >> b/drivers/gpu/drm/i915/gt/gen2_engine_cs.c >> index 1c82caf525c3..0ec4986e4805 100644 >> --- a/drivers/gpu/drm/i915/gt/gen2_engine_cs.c >> +++ b/drivers/gpu/drm/i915/gt/gen2_engine_cs.c >> @@ -37,6 +37,9 @@ int gen2_emit_flush(struct i915

[PATCH] drm/panel: add CONFIG_DRM_KMS_HELPER dependencies

2022-03-16 Thread Arnd Bergmann
From: Arnd Bergmann The driver fails to build when the KMS helpers are disabled: ld.lld: error: undefined symbol: drm_gem_fb_get_obj >>> referenced by drm_mipi_dbi.c >>> gpu/drm/drm_mipi_dbi.o:(mipi_dbi_buf_copy) in archive >>> drivers/built-in.a >>> referenced by drm_mipi_dbi.c >

[PATCH] drm/tegra: vic: fix unused-function warnings

2022-03-16 Thread Arnd Bergmann
From: Arnd Bergmann The use of the old-style SET_RUNTIME_PM_OPS() and SET_SYSTEM_SLEEP_PM_OPS() macros requires function definitions to be hidden to avoid drivers/gpu/drm/tegra/vic.c:326:12: error: 'vic_runtime_suspend' defined but not used [-Werror=unused-function] 326 | static int vic_runti

[PATCH v3 0/3] Allow drm_writeback_connector to accept pointer to drm_encoder

2022-03-16 Thread Abhinav Kumar
There are some vendor drivers for which the writeback encoder shares hardware resources such as clocks and interrupts with the rest of the display pipeline. In addition, there can be use-cases where the writeback encoder could be a shared encoder between the physical display path and the writeback

[PATCH v3 1/3] drm: allow real encoder to be passed for drm_writeback_connector

2022-03-16 Thread Abhinav Kumar
For some vendor driver implementations, display hardware can be shared between the encoder used for writeback and the physical display. In addition resources such as clocks and interrupts can also be shared between writeback and the real encoder. To accommodate such vendor drivers and hardware, a

[PATCH v3 3/3] drm/vc4: change vc4 driver to use drm_writeback_connector_init_with_encoder()

2022-03-16 Thread Abhinav Kumar
vc4 driver currently embeds the drm_encoder into struct vc4_txp and later on uses container_of to retrieve the vc4_txp from the drm_encoder. Since drm_encoder has now been made a pointer inside drm_writeback_connector, make vc4 driver use the new API so that the embedded encoder model can be retai

[PATCH v3 2/3] drm: introduce drm_writeback_connector_init_with_encoder API

2022-03-16 Thread Abhinav Kumar
For vendors drivers which pass an already allocated and initialized encoder especially for cases where the encoder hardware is shared OR the writeback encoder shares the resources with the rest of the display pipeline introduce a new API, drm_writeback_connector_init_with_encoder() which expects an

Re: [PATCH] drm/panel: add CONFIG_DRM_KMS_HELPER dependencies

2022-03-16 Thread Thomas Zimmermann
Hi Am 16.03.22 um 19:36 schrieb Arnd Bergmann: From: Arnd Bergmann The driver fails to build when the KMS helpers are disabled: ld.lld: error: undefined symbol: drm_gem_fb_get_obj referenced by drm_mipi_dbi.c gpu/drm/drm_mipi_dbi.o:(mipi_dbi_buf_copy) in archive drivers/built

Re: [PATCH v2 00/12] drm/gma500: Various cleanups to GEM code

2022-03-16 Thread Thomas Zimmermann
Hi Am 16.03.22 um 17:45 schrieb Patrik Jakobsson: On Tue, Mar 8, 2022 at 8:52 PM Thomas Zimmermann wrote: Refactor and simplify various parts of the memory management. This includes locking, initialization and finalizer functions, and code organization. Tested on Atom N2800 hardware. v2:

Re: [PATCH] drm/panel: add CONFIG_DRM_KMS_HELPER dependencies

2022-03-16 Thread Thomas Zimmermann
Am 16.03.22 um 20:12 schrieb Thomas Zimmermann: Hi Am 16.03.22 um 19:36 schrieb Arnd Bergmann: From: Arnd Bergmann The driver fails to build when the KMS helpers are disabled: ld.lld: error: undefined symbol: drm_gem_fb_get_obj referenced by drm_mipi_dbi.c    gpu/drm/drm_mipi_

2022 X.Org Board of Directors Elections Nomination period is NOW

2022-03-16 Thread Lyude Paul
The Board consists of directors elected from the membership. Each year, an election is held to bring the total number of directors to eight. The four members receiving the highest vote totals will serve as directors for two year terms. The directors who received two year terms starting in 2021 we

2022 X.Org Foundation Membership deadline for voting in the election

2022-03-16 Thread Lyude Paul
The 2022 X.Org Foundation elections are rapidly approaching. We will be forwarding the election schedule and nominating process to the membership shortly. Please note that only current members can vote in the upcoming election, and that the deadline for new memberships or renewals to vote in the u

[PATCH] drm/ttm: fix uninit ptr deref in range manager alloc error path

2022-03-16 Thread Robert Beckett
ttm_range_man_alloc would try to ttm_resource_fini the res pointer before it is allocated. Fixes: de3688e469b0 (drm/ttm: add ttm_resource_fini v2) Signed-off-by: Robert Beckett --- drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

Re: [PATCH v2 6/8] drm/shmem-helper: Add generic memory shrinker

2022-03-16 Thread Rob Clark
On Mon, Mar 14, 2022 at 3:44 PM Dmitry Osipenko wrote: > > Introduce a common DRM SHMEM shrinker. It allows to reduce code > duplication among DRM drivers, it also handles complicated lockings > for the drivers. This is initial version of the shrinker that covers > basic needs of GPU drivers. > >

Re: Parallel modesets and private state objects broken, where to go with MST?

2022-03-16 Thread Lyude Paul
On Wed, 2022-03-16 at 13:01 +0200, Ville Syrjälä wrote: > On Mon, Mar 14, 2022 at 06:16:36PM -0400, Lyude Paul wrote: > > Hi! First a little bit of background: I've recently been trying to get rid > > of > > all of the non-atomic payload bandwidth management code in the MST helpers > > in > > order

Re: [PATCH] drm/nouveau: Fix spelling mistake "endianess" -> "endianness"

2022-03-16 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to drm-misc-next in just a moment On Tue, 2022-03-15 at 22:19 +, Colin Ian King wrote: > There is a spelling mistake in a nvdev_error error message. Fix it. > > Signed-off-by: Colin Ian King > --- >  drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 2 +-

Re: [PATCH] drm/panel: add CONFIG_DRM_KMS_HELPER dependencies

2022-03-16 Thread Arnd Bergmann
On Wed, Mar 16, 2022 at 8:31 PM Thomas Zimmermann wrote: > Am 16.03.22 um 20:12 schrieb Thomas Zimmermann: > >> > >> Adding a dependency in all drivers that select DRM_MIPI_DBI avoids > >> the problem for now, adding the dependency in DRM_MIPI_DBI as well > >> should help make it easier to figure

Re: [PATCH] drm: Don't make DRM_PANEL_BRIDGE dependent on DRM_KMS_HELPERS

2022-03-16 Thread Brian Masney
On Tue, Mar 15, 2022 at 09:45:59AM +0100, Thomas Zimmermann wrote: > Fix a number of undefined references to drm_kms_helper.ko in > drm_dp_helper.ko: > > arm-suse-linux-gnueabi-ld: drivers/gpu/drm/dp/drm_dp_mst_topology.o: in > function `drm_dp_mst_duplicate_state': > drm_dp_mst_topology.c:(.

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-16 Thread Rob Clark
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma wrote: > > From: Shashank Sharma > > This patch adds a new sysfs event, which will indicate > the userland about a GPU reset, and can also provide > some information like: > - process ID of the process involved with the GPU reset > - process name of

[PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-16 Thread Matt Atwood
Newer platforms have DSS that aren't necessarily available for both geometry and compute, two queries will need to exist. This introduces the first, when passing a valid engine class and engine instance in the flags returns a topology describing geometry. v2: fix white space errors v3: change flag

  1   2   >