Re: [PATCH v5] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-03-15 Thread kernel test robot
Hi Vinod, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next next-20220315] [cannot apply to tegra-drm/drm/tegra/for-next v5.17-rc8] [If your patch is

Re: [PATCH v3 4/5] drm/msm: stop using device's match data pointer

2022-03-15 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: Let's make the match's data pointer a (sub-)driver's private data. The only user currently is the msm_drm_init() function, using this data to select kms_init callback. Pass this callback through the driver's private data instead. Signed-off-by: Dmi

Re: [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-15 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MSM DRM driver already allows one to compile out the DP or DSI support. Add support for disabling other features like MDP4/MDP5/DPU drivers or direct HDMI output support. Suggested-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gp

KASAN splat in vmwgfx driver

2022-03-15 Thread Chuck Lever III
For a kernel development project I'm working on, I'm using Linux in a VMware guest. After kernel v5.16.2, I noticed this KASAN splat: Mar 15 14:50:39 oracle-102.nfsv4.dev kernel: vmwgfx :00:0f.0: vgaarb: deactivate vga console Mar 15 14:50:39 oracle-102.nfsv4.dev kernel: Console: switching to

Re: [PATCH] WIP: drm/dp_mst: Add support for dumping topology ref histories from debugfs

2022-03-15 Thread Lyude Paul
(Adding this back to the dri-devel mailing list since I didn't notice it got dropped from there) Hm, some comments on this issue down below. Sorry for the delayed response, I was going to try this right after I finished the MST legacy removal but that's ending up taking longer than I hoped. On Tu

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-15 Thread Andy Yan
Hi Daniel: On 3/15/22 20:43, Daniel Stone wrote: Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: On 3/11/22 16:33, Sascha Hauer wrote: The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB board. Overlay support is tested with the modetest utility. AFBC support on the cl

[PATCH v10 00/13] Add GuC Error Capture Support

2022-03-15 Thread Alan Previn
This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register said lists of global, engi

[PATCH RFC v5 05/21] dept: Apply Dept to mutex families

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by mutex families. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 18 +++--- include/linux/mutex.h | 32 include/linux/rtmutex.h | 7 +++ 3 files changed, 54 insertions(+), 3 deletions(-) diff

[PATCH RFC v5 11/21] dept: Introduce split map concept and new APIs for them

2022-03-15 Thread Byungchul Park
There is a case where total maps for its wait/event is so large in size. For instance, struct page for PG_locked and PG_writeback is the case. The additional memory size for the maps would be 'the # of pages * sizeof(struct dept_map)' if each struct page keeps its map all the way, which might be to

[PATCH RFC v5 13/21] dept: Apply SDT to swait

2022-03-15 Thread Byungchul Park
Makes SDT able to track dependencies by swait. Signed-off-by: Byungchul Park --- include/linux/swait.h | 4 kernel/sched/swait.c | 10 ++ 2 files changed, 14 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index 6a8c22b..dbdf2ce 100644 --- a/include/linux

[PATCH RFC v5 06/21] dept: Apply Dept to rwlock

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by rwlock. Signed-off-by: Byungchul Park --- include/linux/lockdep.h| 25 - include/linux/rwlock.h | 50 ++ include/linux/rwlock_api_smp.h | 8 +++ include/linux/rwlock_types.h

[PATCH RFC v5 04/21] dept: Apply Dept to spinlock

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by spinlock. Signed-off-by: Byungchul Park --- include/linux/lockdep.h| 18 +++--- include/linux/spinlock.h | 25 + include/linux/spinlock_types_raw.h | 13 + 3 files changed, 53 insertion

[PATCH RFC v5 12/21] dept: Apply Dept to wait/event of PG_{locked, writeback}

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by PG_{locked,writeback}. For instance, (un)lock_page() generates that type of dependency. Signed-off-by: Byungchul Park --- include/linux/dept_page.h | 78 + include/linux/page-flags.h | 45

[PATCH RFC v5 09/21] dept: Apply Dept to rwsem

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by rwsem. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 24 include/linux/percpu-rwsem.h | 10 +- include/linux/rwsem.h| 32 3 files changed, 61 insertions(+), 5 del

[PATCH RFC v5 18/21] dept: Disable Dept within the wait_bit layer by default

2022-03-15 Thread Byungchul Park
The struct wait_queue_head array, bit_wait_table[] in sched/wait_bit.c are shared by all its users, which unfortunately vary in terms of class. So each should've been assigned its own class to avoid false positives. It'd better let Dept work at a higher layer than wait_bit. So disabled Dept within

[PATCH RFC v5 15/21] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2022-03-15 Thread Byungchul Park
cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced, fal

[PATCH RFC v5 17/21] dept: Distinguish each work from another

2022-03-15 Thread Byungchul Park
Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let Dept assign a different context id to each work. Signed-off-by: Byungchul Park ---

[PATCH RFC v5 01/21] llist: Move llist_{head, node} definition to types.h

2022-03-15 Thread Byungchul Park
llist_head and llist_node can be used by very primitives. For example, Dept for tracking dependency uses llist things in its header. To avoid header dependency, move those to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2 file

[PATCH RFC v5 03/21] dept: Embed Dept data in Lockdep

2022-03-15 Thread Byungchul Park
Dept should work independently from Lockdep. However, there's no choise but to rely on Lockdep code and its instances for now. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 72 --- include/linux/lockdep_types.h | 3 ++ kernel/locking/l

[PATCH RFC v5 14/21] dept: Apply SDT to wait(waitqueue)

2022-03-15 Thread Byungchul Park
Makes SDT able to track dependencies by wait(waitqueue). Signed-off-by: Byungchul Park --- include/linux/wait.h | 6 +- kernel/sched/wait.c | 16 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/include/linux/wait.h b/include/linux/wait.h index 851e07d..21339

[PATCH RFC v5 07/21] dept: Apply Dept to wait_for_completion()/complete()

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 42 -- kernel/sched/completion.c | 12 ++-- 2 files changed, 50 insertions(+), 4 deletions(-) diff --git a/i

[PATCH RFC v5 00/21] DEPT(Dependency Tracker)

2022-03-15 Thread Byungchul Park
I'm gonna re-add RFC for a while at Ted's request. But hard testing is needed to find false alarms for now that there's no false alarm with my system. I'm gonna look for other systems that might produce false alarms. And it'd be appreciated if you share it when you see any alarms with yours. ---

[PATCH RFC v5 16/21] dept: Distinguish each syscall context from another

2022-03-15 Thread Byungchul Park
It enters kernel mode on each syscall and each syscall handling should be considered independently from the point of view of Dept. Otherwise, Dept may wrongly track dependencies across different syscalls. That might be a real dependency from user mode. However, now that Dept just started to work,

[PATCH RFC v5 20/21] dept: Disable Dept on struct crypto_larval's completion for now

2022-03-15 Thread Byungchul Park
struct crypto_larval's completion is used for multiple purposes e.g. waiting for test to complete or waiting for probe to complete. The completion variable needs to be split according to what it's used for. Otherwise, Dept cannot distinguish one from another and doesn't work properly. Now that it

[PATCH RFC v5 21/21] dept: Don't create dependencies between different depths in any case

2022-03-15 Thread Byungchul Park
Dept already prevents creating dependencies between different depths of the class indicated by *_lock_nested() when the lock acquisitions happen consecutively. For example: lock A0 with depth lock_nested A1 with depth + 1 ... unlock A1 unlock A0 Dept does not create A0 -> A1 depe

[PATCH RFC v5 02/21] dept: Implement Dept(Dependency Tracker)

2022-03-15 Thread Byungchul Park
CURRENT STATUS -- Lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. Lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm a

[PATCH RFC v5 10/21] dept: Add proc knobs to show stats and dependency graph

2022-03-15 Thread Byungchul Park
It'd be useful to show Dept internal stats and dependency graph on runtime via proc for better information. Introduced the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 24 -- kernel/dependency/dept_internal.h | 26

[PATCH RFC v5 19/21] dept: Add nocheck version of init_completion()

2022-03-15 Thread Byungchul Park
For completions who don't want to get tracked by Dept, added init_completion_nocheck() to disable Dept on it. Signed-off-by: Byungchul Park --- include/linux/completion.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/linux/completion.h b/include/linu

[PATCH RFC v5 08/21] dept: Apply Dept to seqlock

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by seqlock with adding wait annotation on read side of seqlock. Signed-off-by: Byungchul Park --- include/linux/seqlock.h | 68 +++-- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git a/include/linux/seq

Re: KASAN splat in vmwgfx driver

2022-03-15 Thread Zack Rusin
On Wed, 2022-03-16 at 00:45 +, Chuck Lever III wrote: > For a kernel development project I'm working on, I'm using > Linux in a VMware guest. After kernel v5.16.2, I noticed > this KASAN splat: Ah, yea, thanks. It's because vmw_bo_create_kernel creates a raw ttm_buffer_object instead of vmw_bu

Re: [PATCH v4 00/24] DEPT(Dependency Tracker)

2022-03-15 Thread Byungchul Park
On Sat, Mar 12, 2022 at 01:53:26AM +, Hyeonggon Yoo wrote: > On Fri, Mar 04, 2022 at 04:06:19PM +0900, Byungchul Park wrote: > > Hi Linus and folks, > > > > I've been developing a tool for detecting deadlock possibilities by > > tracking wait/event rather than lock(?) acquisition order to try

Re: [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-15 Thread Summers, Stuart
On Fri, 2022-03-04 at 14:14 -0800, fei.y...@intel.com wrote: > From: Fei Yang > > GPU hangs have been observed when multiple engines write to the > same aux_inv register at the same time. To avoid this each engine > should only invalidate its own auxiliary table. The function > gen12_emit_flush_x

[linux-next:master] BUILD REGRESSION a32cd981a6da2373c093d471ee4405a915e217d5

2022-03-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a32cd981a6da2373c093d471ee4405a915e217d5 Add linux-next specific files for 20220315 Error/Warning reports: https://lore.kernel.org/linux-doc/202202240704.pqd40a9l-...@intel.com https

RE: [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-15 Thread Yang, Fei
>> @@ -157,6 +163,9 @@ int gen11_emit_flush_rcs(struct i915_request *rq, >> u32 mode) >> intel_ring_advance(rq, cs); >> } >> >> +/* hsdes: 1809175790. No fixup needed for gen11 rcs */ >> +rq->aux_inv_fixup = NULL; > > This is a little ugly to me. Can we just set this to

[PATCH v2] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Arunpravin Paneer Selvam
handle a situation in the condition order-- == min_order, when order = 0 and min_order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return -ENOSPC v2: use full name in email program and in Signed

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Arunpravin Paneer Selvam
On 15/03/22 9:14 pm, Paul Menzel wrote: > Dear Arunpravin, > > > Am 15.03.22 um 16:42 schrieb Arunpravin: > >> On 15/03/22 2:35 pm, Paul Menzel wrote: > >>> Am 15.03.22 um 10:01 schrieb Arunpravin: >>> On 15/03/22 1:49 pm, Paul Menzel wrote: >>> > Am 14.03.22 um 20:40 schrieb Arunpr

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunprivin, Am 16.03.22 um 07:49 schrieb Arunpravin Paneer Selvam: On 15/03/22 9:14 pm, Paul Menzel wrote: Am 15.03.22 um 16:42 schrieb Arunpravin: On 15/03/22 2:35 pm, Paul Menzel wrote: Am 15.03.22 um 10:01 schrieb Arunpravin: On 15/03/22 1:49 pm, Paul Menzel wrote: Am 14.0

<    1   2