RE: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()

2022-03-07 Thread Alison Wang
Acked-by: Alison Wang Best Regards, Alison Wang -Original Message- From: Yang Li Sent: 2022年3月3日 10:30 To: Alison Wang Cc: ste...@agner.ch; airl...@linux.ie; dan...@ffwll.ch; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; Yang Li ; Abaci Robot Subject: [EXT] [PATC

[PATCH RFC] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
Sometimes you might want to use MAP_POPULATE to ask a device driver to initialize the device memory in some specific manner. SGX driver can use this to request more memory by issuing ENCLS[EAUG] x86 opcode for each page in the address range. Add f_ops->populate() with the same parameters as f_ops-

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-07 Thread Joel Fernandes
On Sat, Mar 05, 2022 at 11:15:38PM +0900, Byungchul Park wrote: > On Fri, Mar 04, 2022 at 10:26:23PM -0500, Theodore Ts'o wrote: > > On Fri, Mar 04, 2022 at 09:42:37AM +0900, Byungchul Park wrote: > > > > > > All contexts waiting for any of the events in the circular dependency > > > chain will be

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-03-07 Thread Reimar Döffinger
Hi, Sorry to butt in as an outsider, but this seems like a shockingly disrespectful discussion for such a wide CC list. I don't want to make rules how you discuss things (I very rarely contribute), and I see the value in a frank discussion, but maybe you could continue with a reduced CC list? I

Re: [PATCH] drm: Drop commas after SoC match table sentinels

2022-03-07 Thread Neil Armstrong
On 03/03/2022 13:44, Geert Uytterhoeven wrote: It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/nwl-dsi.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +- 2 files ch

Re: [PATCH] drm: Drop commas after SoC match table sentinels

2022-03-07 Thread Geert Uytterhoeven
Hi Neil, On Mon, Mar 7, 2022 at 9:30 AM Neil Armstrong wrote: > On 03/03/2022 13:44, Geert Uytterhoeven wrote: > > It does not make sense to have a comma after a sentinel, as any new > > elements must be added before the sentinel. > > > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Neil Ar

Re: [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support

2022-03-07 Thread Naresh Kamboju
Hi Rob, On Sun, 20 Feb 2022 at 00:02, Rob Clark wrote: > > From: Rob Clark > > Avoid going down devfreq paths on devices where devfreq is not > initialized. > > Reported-by: Linux Kernel Functional Testing > Reported-by: Anders Roxell > Signed-off-by: Rob Clark I have tested this patch and t

Re: [PATCH v12 03/23] dt-bindings: mediatek: add ethdr definition for mt8195

2022-03-07 Thread AngeloGioacchino Del Regno
Il 07/03/22 03:33, Nancy.Lin ha scritto: Hi Angelo, Thanks for the review. On Wed, 2022-03-02 at 11:13 +0100, AngeloGioacchino Del Regno wrote: Il 22/02/22 11:07, Nancy.Lin ha scritto: Add vdosys1 ETHDR definition. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- .../display/medi

Re: [PATCH v2 2/2] drm/i915/dg2: Add debugfs to control global preemption setting

2022-03-07 Thread Tvrtko Ursulin
On 04/03/2022 23:46, Matt Roper wrote: From: Akeem G Abodunrin Since DG2 and beyond only support global preemption enable/disable (see Wa_14015141709), userspace no longer has a way to control preemption on a per-context basis. Preemption is globally enabled by default, but the UMD teams hav

[PATCH] drm/omap: fix NULL but dereferenced coccicheck error

2022-03-07 Thread Wan Jiabing
Fix the following coccicheck warning: ./drivers/gpu/drm/omapdrm/omap_overlay.c:89:22-25: ERROR: r_ovl is NULL but dereferenced. Here should be ovl->idx rather than r_ovl->idx. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/omapdrm/omap_overlay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread David Hildenbrand
On 06.03.22 06:32, Jarkko Sakkinen wrote: > For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does nothing. Allow > to use that for initializing the device memory by providing a new callback > f_ops->populate() for the purpose. > > SGX patches are provided to show the callback in context. >

Re: [PATCH] drm: Drop commas after SoC match table sentinels

2022-03-07 Thread Neil Armstrong
Hi, On Thu, 3 Mar 2022 13:44:56 +0100, Geert Uytterhoeven wrote: > It does not make sense to have a comma after a sentinel, as any new > elements must be added before the sentinel. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm: Drop comm

Re: [PATCH 7/8] drm/i915: fixup the initial fb base on DG1

2022-03-07 Thread Matthew Auld
On 04/03/2022 19:33, Ville Syrjälä wrote: On Fri, Mar 04, 2022 at 05:23:32PM +, Matthew Auld wrote: The offset we get looks to be the exact start of DSM, but the inital_plane_vma expects the address to be relative. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- .../drm/i915/displa

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Sun, Mar 06, 2022 at 03:41:54PM -0800, Dave Hansen wrote: > On 3/6/22 15:24, Andrew Morton wrote: > > On Sun, 6 Mar 2022 05:26:55 +0200 Jarkko Sakkinen > > wrote: > > > >> Sometimes you might want to use MAP_POPULATE to ask a device driver to > >> initialize the device memory in some specifi

Re: [PATCH v7 15/24] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz

2022-03-07 Thread Andy Yan
Hi:  I have a test with the 24 patches applied on Linux-5.17-rc5 on rk3568-evb1-v10 board with Sony XR-75z9j  HDMI TV, 4K don't work, the tv shows no signal. 1080P can work. On 2/25/22 15:51, Sascha Hauer wrote: From: Nickey Yang add 594Mhz configuration parameters in rockchip_phy_config

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-07 Thread Andy Yan
Hi Sascha: On 2/25/22 15:51, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonsta

[PATCH] omapfb: Add missing of_node_put() in dvic_probe_of

2022-03-07 Thread Miaoqian Lin
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") Signed-off-by: Miaoqian Lin --- drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 1 + 1

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-07 Thread Sascha Hauer
Hi Andy, On Mon, Mar 07, 2022 at 08:18:08PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/25/22 15:51, Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This

[PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()

2022-03-07 Thread Dan Carpenter
Set the error code to -ENOMEM if drm_random_order() fails. Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/selfte

Re: [PATCH 5.15 000/262] 5.15.27-rc1 review

2022-03-07 Thread Naresh Kamboju
On Mon, 7 Mar 2022 at 15:07, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.15.27 release. > There are 262 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Sun, Mar 06, 2022 at 03:24:56PM -0800, Andrew Morton wrote: > On Sun, 6 Mar 2022 05:26:55 +0200 Jarkko Sakkinen wrote: > > > Sometimes you might want to use MAP_POPULATE to ask a device driver to > > initialize the device memory in some specific manner. SGX driver can use > > this to request

Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver

2022-03-07 Thread Daniel Stone
Hi Andy, On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > On 2/25/22 15:51, Sascha Hauer wrote: > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has been derived from the downstream Rockchip

Re: [PATCH RFC 1/3] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Sun, Mar 06, 2022 at 10:43:31PM +, Matthew Wilcox wrote: > On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote: > > So can I conclude from this that in general having populate available for > > device memory is something horrid, or just the implementation path? > > You haven't e

Re: [PATCH] omapfb: Add missing of_node_put() in dvic_probe_of

2022-03-07 Thread Helge Deller
On 3/7/22 13:38, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") > Signed-off-by: Miaoqian Lin applied to the fbdev for

Re: [PATCH RFC 1/3] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Mon, Mar 07, 2022 at 03:16:57PM +0200, Jarkko Sakkinen wrote: > On Sun, Mar 06, 2022 at 10:43:31PM +, Matthew Wilcox wrote: > > On Sun, Mar 06, 2022 at 07:02:57PM +0200, Jarkko Sakkinen wrote: > > > So can I conclude from this that in general having populate available for > > > device memory

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread Jarkko Sakkinen
On Sun, Mar 06, 2022 at 11:48:26PM -0800, Christoph Hellwig wrote: > On Sun, Mar 06, 2022 at 11:33:02AM +, Matthew Wilcox wrote: > > On Sun, Mar 06, 2022 at 07:32:04AM +0200, Jarkko Sakkinen wrote: > > > For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does nothing. Allow > > > to use tha

[PATCH] drm/msm/adreno: fix cast in adreno_get_param()

2022-03-07 Thread Dan Carpenter
These casts need to happen before the shift. The only time it would matter would be if "rev.core" is >= 128. In that case the sign bit would be extended and we do not want that. Fixes: afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace") Signed-off-by: Dan Carpenter --- drivers/gpu/dr

[PATCH v3 0/6] drm/i915/ttm: Evict and restore of compressed object

2022-03-07 Thread Ramalingam C
On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the requir

[PATCH v3 1/6] drm/i915/gt: Use XY_FASR_COLOR_BLT to clear obj on graphics ver 12+

2022-03-07 Thread Ramalingam C
XY_FAST_COLOR_BLT cmd is faster than the older XY_COLOR_BLT. Hence for clearing (Zero out) the pages of the newly allocated object, faster cmd is used. Signed-off-by: Ramalingam C Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 ++ drivers/gpu/drm/i915/gt/intel

[PATCH v3 2/6] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-07 Thread Ramalingam C
Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. XY_FAST_COLOR_BLT cmd provides a option to clear the ccs metadata corresponding

[PATCH v3 3/6] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-03-07 Thread Ramalingam C
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that driver needs extra pages in ttm_tt. v2: Used imperative wording [Thomas and Christian] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Christian Konig ---

[PATCH v3 5/6] drm/i915/gt: Optimize the migration loop

2022-03-07 Thread Ramalingam C
Move the static calculations out of the loop. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 34 - 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c

[PATCH v3 4/6] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-07 Thread Ramalingam C
On Xe-HP and later devices, dedicated compression control state (CCS) stored in local memory is used for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory size. So before the kernel boot, the requi

[PATCH v3 6/6] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-07 Thread Ramalingam C
When we are swapping out the local memory obj on flat-ccs capable platform, we need to capture the ccs data too along with main meory and we need to restore it when we are swapping in the content. When lmem object is swapped into a smem obj, smem obj will have the extra pages required to hold the

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread Jarkko Sakkinen
On Mon, Mar 07, 2022 at 11:12:44AM +0100, David Hildenbrand wrote: > On 06.03.22 06:32, Jarkko Sakkinen wrote: > > For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does nothing. Allow > > to use that for initializing the device memory by providing a new callback > > f_ops->populate() for the

Re: [PATCH v3 1/6] drm/i915/gt: Use XY_FASR_COLOR_BLT to clear obj on graphics ver 12+

2022-03-07 Thread Hellstrom, Thomas
Hi, Ram. Typo in patch title FASR/FAST On Mon, 2022-03-07 at 19:10 +0530, Ramalingam C wrote: > XY_FAST_COLOR_BLT cmd is faster than the older XY_COLOR_BLT. Hence > for > clearing (Zero out) the pages of the newly allocated object, faster > cmd > is used. > > Signed-off-by: Ramalingam C > Signe

Re: [PATCH v3 2/6] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-07 Thread Hellstrom, Thomas
On Mon, 2022-03-07 at 19:10 +0530, Ramalingam C wrote: > Xe-HP and latest devices support Flat CCS which reserved a portion of > the device memory to store compression metadata, during the clearing > of > device memory buffer object we also need to clear the associated > CCS buffer. > > XY_FAST_CO

Re: [PATCH] simpldrm: Enable boot time VESA graphic mode selection.

2022-03-07 Thread Javier Martinez Canillas
On 3/4/22 21:47, Javier Martinez Canillas wrote: > Hello Thomas, > > On 3/4/22 21:00, Thomas Zimmermann wrote: >> Hi, >> >> I've merged the patches into drm-misc-fixes. Thanks a lot to both of you. >> > > Ard already picked these through the efi tree: > > https://git.kernel.org/pub/scm/linux/ker

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread David Hildenbrand
On 07.03.22 15:22, Jarkko Sakkinen wrote: > On Mon, Mar 07, 2022 at 11:12:44AM +0100, David Hildenbrand wrote: >> On 06.03.22 06:32, Jarkko Sakkinen wrote: >>> For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does nothing. Allow >>> to use that for initializing the device memory by providing

[PATCH] drm: remove min_order BUG_ON check

2022-03-07 Thread Arunpravin
place BUG_ON(order < min_order) outside do..while loop as it fails Unigine Heaven benchmark. Unigine Heaven has buffer allocation requests for example required pages are 161 and alignment request is 128. To allocate the remaining 33 pages, continues the iteration to find the order value which is 5

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Matthew Wilcox
On Sun, Mar 06, 2022 at 03:41:54PM -0800, Dave Hansen wrote: > In short: page faults stink. The core kernel has lots of ways of > avoiding page faults like madvise(MADV_WILLNEED) or mmap(MAP_POPULATE). > But, those only work on normal RAM that the core mm manages. > > SGX is weird. SGX memory i

Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()

2022-03-07 Thread Arunpravin
Reviewed-by:Arunpravin On 07/03/22 6:24 pm, Dan Carpenter wrote: > Set the error code to -ENOMEM if drm_random_order() fails. > > Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- > 1

Re: [Intel-gfx] [PATCH] drm: remove min_order BUG_ON check

2022-03-07 Thread Jani Nikula
On Mon, 07 Mar 2022, Arunpravin wrote: > place BUG_ON(order < min_order) outside do..while > loop as it fails Unigine Heaven benchmark. > > Unigine Heaven has buffer allocation requests for > example required pages are 161 and alignment request > is 128. To allocate the remaining 33 pages, continu

Re: [Freedreno] [PATCH] drm/msm/adreno: fix cast in adreno_get_param()

2022-03-07 Thread Akhil P Oommen
On 3/7/2022 7:01 PM, Dan Carpenter wrote: These casts need to happen before the shift. The only time it would matter would be if "rev.core" is >= 128. In that case the sign bit would be extended and we do not want that. Fixes: afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace") Signe

Re: [PATCH 0/6] Remove usage of list iterator past the loop body

2022-03-07 Thread Dan Carpenter
Updating this API is risky because some places rely on the old behavior and not all of them have been updated. Here are some additional places you might want to change. drivers/usb/host/uhci-q.c:466 link_async() warn: iterator used outside loop: 'pqh' drivers/infiniband/core/mad.c:968 ib_get_rmp

Re: [PATCH] drm/msm/a6xx: Fix missing ARRAY_SIZE() check

2022-03-07 Thread Akhil P Oommen
On 3/5/2022 11:04 PM, Rob Clark wrote: From: Rob Clark Fixes: f6d62d091cfd ("drm/msm/a6xx: add support for Adreno 660 GPU") Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) d

Re: [PATCH 0/4] drm/msm: Clear perf counters across context switch

2022-03-07 Thread Akhil P Oommen
On 3/4/2022 6:22 AM, Rob Clark wrote: From: Rob Clark Some clever folks figured out a way to use performance counters as a side-channel[1]. But, other than the special case of using the perf counters for system profiling, we can reset the counters across context switches to protect against thi

Re: [PATCH 5.15 000/262] 5.15.27-rc1 review

2022-03-07 Thread Greg Kroah-Hartman
On Mon, Mar 07, 2022 at 06:30:18PM +0530, Naresh Kamboju wrote: > On Mon, 7 Mar 2022 at 15:07, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 5.15.27 release. > > There are 262 patches in this series, all will be posted as a response > > to this one. If a

RE: [PATCH 0/6] Remove usage of list iterator past the loop body

2022-03-07 Thread David Laight
From: Dan Carpenter > Sent: 07 March 2022 15:01 > > Updating this API is risky because some places rely on the old behavior > and not all of them have been updated. Here are some additional places > you might want to change. I really can't help thinking that trying to merge this patch is actuall

Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format

2022-03-07 Thread Max Krummenacher
On Wed, Mar 2, 2022 at 5:22 PM Marek Vasut wrote: > > On 3/2/22 15:21, Maxime Ripard wrote: > > Hi, > > Hi, > > > Please try to avoid top posting Sorry. > > > > On Wed, Feb 23, 2022 at 04:25:19PM +0100, Max Krummenacher wrote: > >> The goal here is to set the element bus_format in the struct > >>

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Dave Hansen
On 3/7/22 03:27, Jarkko Sakkinen wrote: > But e.g. in __mm_populate() anything with (VM_IO | VM_PFNMAP) gets > filtered out and never reach that function. > > I don't know unorthodox that'd be but could we perhaps have a VM > flag for SGX? SGX only works on a subset of the chips from one vendor o

Re: [PATCH v3 4/6] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-07 Thread Matthew Auld
On 07/03/2022 13:40, Ramalingam C wrote: On Xe-HP and later devices, dedicated compression control state (CCS) stored in local memory is used for each surface, to support the 3D and media compression formats. The memory required for the CCS of the entire local memory is 1/256 of the local memory

[RESEND PATCH] drm/doc: Clarify what ioctls can be used on render nodes

2022-03-07 Thread Jeffrey Hugo
The documentation for render nodes indicates that only "PRIME-related" ioctls are valid on render nodes, but the documentation does not clarify what that means. If the reader is not familiar with PRIME, they may beleive this to be only the ioctls with "PRIME" in the name and not other ioctls such

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Mon, Mar 07, 2022 at 02:37:48PM +, Matthew Wilcox wrote: > On Sun, Mar 06, 2022 at 03:41:54PM -0800, Dave Hansen wrote: > > In short: page faults stink. The core kernel has lots of ways of > > avoiding page faults like madvise(MADV_WILLNEED) or mmap(MAP_POPULATE). > > But, those only work

Re: [PATCH RFC v2] mm: Add f_ops->populate()

2022-03-07 Thread Jarkko Sakkinen
On Mon, Mar 07, 2022 at 07:29:22AM -0800, Dave Hansen wrote: > On 3/7/22 03:27, Jarkko Sakkinen wrote: > > But e.g. in __mm_populate() anything with (VM_IO | VM_PFNMAP) gets > > filtered out and never reach that function. > > > > I don't know unorthodox that'd be but could we perhaps have a VM > >

[PATCH v1 0/2] Revert vendor property from anx7625 bindings

2022-03-07 Thread Robert Foss
An issue[1] related to how the V4L2_FWNODE_BUS_TYPE_PARALLEL flag is mis-used was found in recent addition to the anx7625 driver. In order to not introduce this issue into the ABI, let's revert the changes to the anx7625 dt-binding related to this. [1] https://lore.kernel.org/all/yitruicikyxs3...

[PATCH v1 1/2] Revert "dt-bindings:drm/bridge:anx7625:add vendor define"

2022-03-07 Thread Robert Foss
This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39. --- .../display/bridge/analogix,anx7625.yaml | 65 +-- 1 file changed, 2 insertions(+), 63 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetr

[PATCH v1 2/2] Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint"

2022-03-07 Thread Robert Foss
This reverts commit 32568ae37596b529628ac09b875f4874e614f63f. --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi index e8f13

[PATCH 0/3] Move FPU related code from DCN3.1x drivers to DML folder

2022-03-07 Thread Melissa Wen
This series moves FPU code from DCN 3.1x drivers to dml/dcn31 folder to isolate FPU operations. For this, it creates dcn31_fpu files to centralize FPU operations and structs from dcn31x drivers, that include: - _vcs_dpi_ip_params_st and _vcs_dpi_soc_bounding_box_st structs - dcn31x_update_bw_boundi

[PATCH 2/3] drm/amd/display: move FPU related code from dcn315 to dml/dcn31 folder

2022-03-07 Thread Melissa Wen
Moves related structs and dcn315_update_bw_bounding_box from dcn315 driver code to dml/dcn31_fpu that centralizes FPU code for DCN 3.1x. Signed-off-by: Melissa Wen --- .../gpu/drm/amd/display/dc/dcn315/Makefile| 26 -- .../amd/display/dc/dcn315/dcn315_resource.c | 232 +-

[PATCH 1/3] drm/amd/dicplay: move FPU related code from dcn31 to dml/dcn31 folder

2022-03-07 Thread Melissa Wen
Creates FPU files in dml/dcn31 folder to centralize FPU operations from 3.1x drivers and moves all FPU-associated code from dcn31 driver to there. It includes the struct _vcs_dpi_ip_params_st and _vcs_dpi_soc_bounding_box_st and functions: - dcn31_calculate_wm_and_dlg_fp() - dcn31_update_bw_boundi

[PATCH 3/3] drm/amd/display: move FPU related code from dcn316 to dml/dcn31 folder

2022-03-07 Thread Melissa Wen
Moves FPU-related structs and dcn316_update_bw_bounding_box from dcn316 driver to dml/dcn31 that centralize FPU operations for DCN 3.1x Signed-off-by: Melissa Wen --- .../gpu/drm/amd/display/dc/dcn316/Makefile| 26 -- .../amd/display/dc/dcn316/dcn316_resource.c | 231 +- .

Re: [PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature

2022-03-07 Thread Robert Foss
On Mon, 7 Mar 2022 at 07:12, Chen-Yu Tsai wrote: > > On Sun, Mar 06, 2022 at 07:13:30PM +0200, Laurent Pinchart wrote: > > Hello Xin, > > > > (Question for Rob below, and I'm afraid this is urgent as we need to > > merge a fix in v5.17). > > > > On Fri, Nov 05, 2021 at 11:19:03AM +0800, Xin Ji wro

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread Jarkko Sakkinen
On Mon, Mar 07, 2022 at 03:33:52PM +0100, David Hildenbrand wrote: > On 07.03.22 15:22, Jarkko Sakkinen wrote: > > On Mon, Mar 07, 2022 at 11:12:44AM +0100, David Hildenbrand wrote: > >> On 06.03.22 06:32, Jarkko Sakkinen wrote: > >>> For device memory (aka VM_IO | VM_PFNMAP) MAP_POPULATE does noth

Re: [PATCH v1 0/2] Revert vendor property from anx7625 bindings

2022-03-07 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Mon, Mar 07, 2022 at 04:45:56PM +0100, Robert Foss wrote: > An issue[1] related to how the V4L2_FWNODE_BUS_TYPE_PARALLEL flag is mis-used > was found in recent addition to the anx7625 driver. > > In order to not introduce this issue into the ABI, let's revert

Re: [PATCH] drm: remove min_order BUG_ON check

2022-03-07 Thread Christian König
Am 07.03.22 um 15:37 schrieb Arunpravin: place BUG_ON(order < min_order) outside do..while loop as it fails Unigine Heaven benchmark. Unigine Heaven has buffer allocation requests for example required pages are 161 and alignment request is 128. To allocate the remaining 33 pages, continues the i

RE: a null derefrence at [v7, 9/9] drm/omap: Add a 'right overlay' to plane state

2022-03-07 Thread Weiguo Li
> > From: Benoit Parrot > > If the drm_plane has a source width that's greater than the max width > supported by a single hw overlay, then we assign a 'r_overlay' to it in > omap_plane_atomic_check(). > > Both overlays should have the capabilities required to handle the source > framebuffer. Th

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory

2022-03-07 Thread Jarkko Sakkinen
On Mon, Mar 07, 2022 at 07:56:53AM -0800, Christoph Hellwig wrote: > On Mon, Mar 07, 2022 at 03:29:35PM +0200, Jarkko Sakkinen wrote: > > So what would you suggest to sort out the issue? I'm happy to go with > > ioctl if nothing else is acceptable. > > PLenty of drivers treat all mmaps as if MAP_P

RE: [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-07 Thread Vinod Polimera
> WARNING: This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. > > On Sat, 5 Mar 2022 at 00:49, Doug Anderson > wrote: > > On Thu, Mar 3, 2022 at 4:16 PM Dmitry Baryshkov > > wrote: > > > > > > On Fri, 4 Mar 2022 at 02:56, Steph

[PATCH v2] drm/mode: Improve drm_mode_fb_cmd2 documentation

2022-03-07 Thread Geert Uytterhoeven
From: Geert Uytterhoeven Fix various grammar mistakes in the kerneldoc comments documenting the drm_mode_fb_cmd2 structure: - s/is/are/, - s/8 bit/8-bit/. Signed-off-by: Geert Uytterhoeven Acked-by: Sam Ravnborg --- v2: - Add Acked-by, - Rebase on top of commit a3574119826d9a4e ("drm:

Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()

2022-03-07 Thread Christian König
Pushed to drm-misc-next. Just one nit below. Am 07.03.22 um 15:54 schrieb Arunpravin: Reviewed-by:Arunpravin Some people are picky about using the full name here. And you I think we should volunteer you for maintaining that stuff :) So you might want to get commit rights for drm-misc-next a

Re: [PATCH 5.15 000/262] 5.15.27-rc1 review

2022-03-07 Thread Greg Kroah-Hartman
On Mon, Mar 07, 2022 at 06:30:18PM +0530, Naresh Kamboju wrote: > drivers/gpu/drm/mediatek/mtk_dsi.c: In function 'mtk_dsi_host_attach': > drivers/gpu/drm/mediatek/mtk_dsi.c:858:28: error: implicit declaration > of function 'devm_drm_of_get_bridge'; did you mean > 'devm_drm_panel_bridge_add'? [-Wer

Re: [PATCH v2] drm/mode: Improve drm_mode_fb_cmd2 documentation

2022-03-07 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH v1 2/2] Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint"

2022-03-07 Thread Robert Foss
Signed-off-by: Robert Foss On Mon, 7 Mar 2022 at 16:46, Robert Foss wrote: > > This reverts commit 32568ae37596b529628ac09b875f4874e614f63f. > --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt81

Re: [PATCH v1 1/2] Revert "dt-bindings:drm/bridge:anx7625:add vendor define"

2022-03-07 Thread Robert Foss
On Mon, 7 Mar 2022 at 16:46, Robert Foss wrote: > > This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39. > --- > .../display/bridge/analogix,anx7625.yaml | 65 +-- > 1 file changed, 2 insertions(+), 63 deletions(-) > > diff --git > a/Documentation/devicetree/binding

Re: [PATCH 00/10] drm/gma500: Various cleanups to GEM code

2022-03-07 Thread Patrik Jakobsson
On Sun, Mar 6, 2022 at 9:36 PM Thomas Zimmermann wrote: > > Refactor and simplify various parts of the memory management. This > includes locking, initialization and finalizer functions, and code > organization. > > Tested on Atom N2800 hardware. Hi Thomas, nice cleanups! All patches are: Acked-

Re: [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-07 Thread Dmitry Baryshkov
On Mon, 7 Mar 2022 at 19:05, Vinod Polimera wrote: > > > WARNING: This email originated from outside of Qualcomm. Please be wary > > of any links or attachments, and do not enable macros. > > > > On Sat, 5 Mar 2022 at 00:49, Doug Anderson > > wrote: > > > On Thu, Mar 3, 2022 at 4:16 PM Dmitry Bar

[PATCH v2] drm/vmwgfx: Implement MSI/MSI-X support for IRQs

2022-03-07 Thread Zack Rusin
From: Zack Rusin SVGAv3 deprecates legacy interrupts and adds support for MSI/MSI-X. With MSI the driver visible side remains largely unchanged but with MSI-X each interrupt gets delivered on its own vector. Add support for MSI/MSI-X while preserving the old functionality for SVGAv2. Code betwee

Re: [PATCH v1 1/2] Revert "dt-bindings:drm/bridge:anx7625:add vendor define"

2022-03-07 Thread Rob Herring
On Mon, Mar 07, 2022 at 04:45:57PM +0100, Robert Foss wrote: > This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39. S-o-b and reason for the revert? > --- > .../display/bridge/analogix,anx7625.yaml | 65 +-- > 1 file changed, 2 insertions(+), 63 deletions(-) > > di

Re: [PATCH] drm: remove min_order BUG_ON check

2022-03-07 Thread Matthew Auld
On 07/03/2022 14:37, Arunpravin wrote: place BUG_ON(order < min_order) outside do..while loop as it fails Unigine Heaven benchmark. Unigine Heaven has buffer allocation requests for example required pages are 161 and alignment request is 128. To allocate the remaining 33 pages, continues the ite

Re: [PATCH v1 2/2] Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint"

2022-03-07 Thread Rob Herring
On Mon, Mar 07, 2022 at 04:45:58PM +0100, Robert Foss wrote: > This reverts commit 32568ae37596b529628ac09b875f4874e614f63f. > --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.d

Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()

2022-03-07 Thread Dan Carpenter
On Mon, Mar 07, 2022 at 05:14:59PM +0100, Christian König wrote: > Pushed to drm-misc-next. Just one nit below. > > Am 07.03.22 um 15:54 schrieb Arunpravin: > > Reviewed-by:Arunpravin > > Some people are picky about using the full name here. > Signed-off-by is like signing a legal document to

Re: [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-07 Thread Michael Cheng
Ah Thanks for the great feedback! @Lucas or @Matt, could you please chime in? Michael Cheng On 2022-03-02 11:10 a.m., Robin Murphy wrote: On 2022-03-02 15:55, Michael Cheng wrote: Thanks for the feedback Robin! Sorry my choices of word weren't that great, but what I meant is to understand h

Re: [PATCH v1 1/2] Revert "dt-bindings:drm/bridge:anx7625:add vendor define"

2022-03-07 Thread Robert Foss
On Mon, 7 Mar 2022 at 17:38, Rob Herring wrote: > > On Mon, Mar 07, 2022 at 04:45:57PM +0100, Robert Foss wrote: > > This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39. > > S-o-b and reason for the revert? > > > --- > > .../display/bridge/analogix,anx7625.yaml | 65 +---

Re: [PATCH v5 0/3] Update VMware maintainer entries

2022-03-07 Thread Srivatsa S. Bhat
[+virtualization list, which I forgot to CC when posting v5] Hi Thomas, other x86 maintainers, On 2/25/22 2:23 PM, Srivatsa S. Bhat wrote: > This series updates a few maintainer entries for VMware-maintained > subsystems and cleans up references to VMware's private mailing lists > to make it clea

Re: [PATCH 7/8] drm/i915: fixup the initial fb base on DG1

2022-03-07 Thread Ville Syrjälä
On Mon, Mar 07, 2022 at 10:32:36AM +, Matthew Auld wrote: > On 04/03/2022 19:33, Ville Syrjälä wrote: > > On Fri, Mar 04, 2022 at 05:23:32PM +, Matthew Auld wrote: > >> The offset we get looks to be the exact start of DSM, but the > >> inital_plane_vma expects the address to be relative. >

Re: [PATCH v1 1/2] Revert "dt-bindings:drm/bridge:anx7625:add vendor define"

2022-03-07 Thread Laurent Pinchart
On Mon, Mar 07, 2022 at 05:57:47PM +0100, Robert Foss wrote: > On Mon, 7 Mar 2022 at 17:38, Rob Herring wrote: > > > > On Mon, Mar 07, 2022 at 04:45:57PM +0100, Robert Foss wrote: > > > This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39. > > > > S-o-b and reason for the revert? > > > > >

Re: [PATCH v1 1/2] Revert "dt-bindings:drm/bridge:anx7625:add vendor define"

2022-03-07 Thread Rob Herring
On Mon, Mar 7, 2022 at 11:11 AM Laurent Pinchart wrote: > > On Mon, Mar 07, 2022 at 05:57:47PM +0100, Robert Foss wrote: > > On Mon, 7 Mar 2022 at 17:38, Rob Herring wrote: > > > > > > On Mon, Mar 07, 2022 at 04:45:57PM +0100, Robert Foss wrote: > > > > This reverts commit a43661e7e819b100e1f833a

[PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support non-eDP DisplayPort connectors

2022-03-07 Thread Kieran Bingham
Implement support for non eDP connectors on the TI-SN65DSI86 bridge, and provide IRQ based hotplug detect to identify when the connector is present. no-hpd is extended to be the default behaviour for non DisplayPort connectors. This series is based on top of José Expósito's patch [0] "drm/bridge:

[PATCH v2 3/4] drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode

2022-03-07 Thread Kieran Bingham
From: Laurent Pinchart Despite the SN65DSI86 being an eDP bridge, on some systems its output is routed to a DisplayPort connector. Enable DisplayPort mode when the next component in the display pipeline is detected as a DisplayPort connector, and disable eDP features in that case. Signed-off-by:

[PATCH v2 2/4] drm/bridge: ti-sn65dsi86: Make connector creation optional

2022-03-07 Thread Kieran Bingham
From: Laurent Pinchart Now that the driver supports the connector-related bridge operations, make the connector creation optional. This enables usage of the sn65dsi86 with the DRM bridge connector helper. Signed-off-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- Changes since v1: - N

[PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2022-03-07 Thread Kieran Bingham
From: Laurent Pinchart Implement the bridge connector-related .get_edid() operation, and report the related bridge capabilities and type. Signed-off-by: Laurent Pinchart Reviewed-by: Stephen Boyd Reviewed-by: Douglas Anderson Signed-off-by: Kieran Bingham --- Changes since v1: - The connect

[PATCH v2 4/4] drm/bridge: ti-sn65dsi86: Support hotplug detection

2022-03-07 Thread Kieran Bingham
When the SN65DSI86 is used in DisplayPort mode, its output is likely routed to a DisplayPort connector, which can benefit from hotplug detection. Support it in such cases, with polling mode only for now. The implementation is limited to the bridge operations, as the connector operations are legacy

Re: [PATCH v1 3/3] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable

2022-03-07 Thread Christophe Branchereau
Hi Paul, it should in theory, but doesn't work in practice, the display doesn't like having that bit set outside of the init sequence. Feel free to experiment if you think you can make it work though, you should have that panel on 1 or 2 devices I think. KR CB On Wed, Mar 2, 2022 at 12:22 PM Pau

[PATCH] drm/rockchip: remove redundant assignment to pointer connector

2022-03-07 Thread Colin Ian King
The pointer connector is being assigned a value that is never read, it is being re-assigned in the following statement. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/rockchip/rockchip_rgb.c:153:2: warning: Value stored to 'connector' is never r

Re: [PATCH 7/8] drm/i915: fixup the initial fb base on DG1

2022-03-07 Thread Matthew Auld
On 07/03/2022 17:06, Ville Syrjälä wrote: On Mon, Mar 07, 2022 at 10:32:36AM +, Matthew Auld wrote: On 04/03/2022 19:33, Ville Syrjälä wrote: On Fri, Mar 04, 2022 at 05:23:32PM +, Matthew Auld wrote: The offset we get looks to be the exact start of DSM, but the inital_plane_vma expects

Re: [PATCH 7/8] drm/i915: fixup the initial fb base on DG1

2022-03-07 Thread Ville Syrjälä
On Mon, Mar 07, 2022 at 06:26:32PM +, Matthew Auld wrote: > On 07/03/2022 17:06, Ville Syrjälä wrote: > > On Mon, Mar 07, 2022 at 10:32:36AM +, Matthew Auld wrote: > >> On 04/03/2022 19:33, Ville Syrjälä wrote: > >>> On Fri, Mar 04, 2022 at 05:23:32PM +, Matthew Auld wrote: > The o

Re: [PATCH 06/10] drm/gma500: Move GTT resume logic out of psb_gtt_init()

2022-03-07 Thread Sam Ravnborg
Hi Thomas, One comment below. On Sun, Mar 06, 2022 at 09:36:15PM +0100, Thomas Zimmermann wrote: > The current implementation of psb_gtt_init() also does resume > handling. Move the resume code into its own helper. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/gma500/gtt.c |

Re: [Intel-gfx] [PATCH 7/8] drm/i915: fixup the initial fb base on DG1

2022-03-07 Thread Matthew Auld
On Mon, 7 Mar 2022 at 18:41, Ville Syrjälä wrote: > > On Mon, Mar 07, 2022 at 06:26:32PM +, Matthew Auld wrote: > > On 07/03/2022 17:06, Ville Syrjälä wrote: > > > On Mon, Mar 07, 2022 at 10:32:36AM +, Matthew Auld wrote: > > >> On 04/03/2022 19:33, Ville Syrjälä wrote: > > >>> On Fri, Mar

Re: [PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2022-03-07 Thread Doug Anderson
Hi, On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham wrote: > > From: Laurent Pinchart > > Implement the bridge connector-related .get_edid() operation, and report > the related bridge capabilities and type. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Stephen Boyd > Reviewed-by: Douglas A

  1   2   >