Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hi Suraj, On Sat, Feb 26, 2022 at 05:10:06AM +, Kandpal, Suraj wrote: > Hi Abhinav, > > > Based on the discussion in this thread [1] , it seems like having > > drm_encoder > > as a pointer seems to have merits for both of us and also in agreement with > > the folks on this thread and has a b

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hi Rob, On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: > On Wed, Feb 2, 2022 at 7:41 AM Jani Nikula wrote: > > On Wed, 02 Feb 2022, Laurent Pinchart wrote: > > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > > >> On Wed, 02 Feb 2022, Laurent Pinchart wrote: > > >> > On

Re: [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Arnd Bergmann
On Sun, Feb 27, 2022 at 11:36 PM Linus Torvalds wrote: > > And I don't want somebody with a newer compiler version to not notice > that he or she ended up using a c17 feature, just because _that_ > compiler supported it, and then other people get build errors because > their compilers use gnu11 in

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Dmitry Baryshkov
On Mon, 28 Feb 2022 at 11:00, Laurent Pinchart wrote: > > Hi Suraj, > > On Sat, Feb 26, 2022 at 05:10:06AM +, Kandpal, Suraj wrote: > > Hi Abhinav, > > > > > Based on the discussion in this thread [1] , it seems like having > > > drm_encoder > > > as a pointer seems to have merits for both of

Re: [greybus-dev] [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Arnd Bergmann
On Mon, Feb 28, 2022 at 12:04 AM Alex Elder wrote: > On 2/27/22 3:52 PM, Arnd Bergmann wrote: From: Arnd Bergmann > > I put the suggestion into patch form, based on what we discussed > > in the thread. I only gave it minimal testing, but it would > > be good to have it in linux-next if we want

Re: [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Arnd Bergmann
On Mon, Feb 28, 2022 at 1:14 AM John Stoffel wrote: > > On Sun, Feb 27, 2022 at 10:52:43PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > During a patch discussion, Linus brought up the option of changing > > the C standard version from gnu89 to gnu99, which allows using variable > >

[PATCH] drm/bridge: it6505: Fix the read buffer array bound

2022-02-28 Thread Hsin-Yi Wang
The size of read_buf is READ_BUFFER_SIZE (200), so we can't access it with read_buf + PAGE_SIZE (4096). Extend the READ_BUFFER_SIZE to 400 and set the end position to read_buf + READ_BUFFER_SIZE. Fixes: b5c84a9edcd418 ("drm/bridge: add it6505 driver") Reported-by: Mark Brown Signed-off-by: Hsin-Y

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-28 Thread Liu Ying
On Mon, 2022-02-28 at 07:57 +0100, Marek Vasut wrote: > On 2/28/22 07:37, Liu Ying wrote: > > Hi Marek, > > Hi, > > > On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: > > > Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 > > > and is completely different from the LCDI

Re: (subset) [PATCH v6 1/5] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:09 +0100, Noralf Trønnes wrote: > Add binding for MIPI DBI compatible SPI panels. > > v6: > - Fix indentation (Rob) > > v5: > - Add sainsmart18 to compatible items (Rob) > - Expand write-only description (Sam) > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks!

Re: (subset) [PATCH v6 3/5] drm/modes: Add of_get_drm_panel_display_mode()

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:11 +0100, Noralf Trønnes wrote: > Add a function to get a drm_display_mode from a panel-timing > device tree subnode. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v6 2/5] drm/modes: Remove trailing whitespace

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:10 +0100, Noralf Trønnes wrote: > Remove trailing whitespace from a comment. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v6 4/5] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:12 +0100, Noralf Trønnes wrote: > devm_drm_dev_alloc() can't allocate structures that embed a structure > which then again embeds drm_device. Workaround this by adding a > driver_private pointer to struct mipi_dbi_dev which the driver can use for > its additional state. >

Re: (subset) [PATCH v6 5/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-28 Thread Maxime Ripard
On Sun, 27 Feb 2022 13:47:13 +0100, Noralf Trønnes wrote: > Add a driver that will work with most MIPI DBI compatible SPI panels. > This avoids adding a driver for every new MIPI DBI compatible controller > that is to be used by Linux. The 'compatible' Device Tree property with > a '.bin' suffix wi

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hi Dmitry, On Mon, Feb 28, 2022 at 11:07:41AM +0300, Dmitry Baryshkov wrote: > On Mon, 28 Feb 2022 at 11:00, Laurent Pinchart wrote: > > On Sat, Feb 26, 2022 at 05:10:06AM +, Kandpal, Suraj wrote: > > > Hi Abhinav, > > > > > > > Based on the discussion in this thread [1] , it seems like having

Re: [PATCH v6 0/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-28 Thread Maxime Ripard
Hi, On Sun, Feb 27, 2022 at 01:47:08PM +0100, Noralf Trønnes wrote: > Hi, > > This patchset adds a driver that will work with most MIPI DBI compatible > SPI panels out there. > > One change this time: Fix indentation in the DT binding. > > All patches are reviewed now so I will apply this after

Re: [PATCH] drm/todo: Update panic handling todo

2022-02-28 Thread Daniel Vetter
On Thu, Feb 24, 2022 at 10:53:01AM -0300, Guilherme G. Piccoli wrote: > On 24/02/2022 10:24, Daniel Vetter wrote: > > Some things changed, and add two useful links. > > > > v2: Also include a link to the QR encoding work. Plus review from > > Javier. > > > > Reviewed-by: Javier Martinez Canillas

Re: [PATCH 2/2] drm/atomic: Force bridge self-refresh-exit on CRTC switch

2022-02-28 Thread Liu Ying
Hi Brian, On Tue, 2022-02-15 at 15:54 -0800, Brian Norris wrote: > It's possible to change which CRTC is in use for a given > connector/encoder/bridge while we're in self-refresh without fully > disabling the connector/encoder/bridge along the way. This can confuse > the bridge encoder/bridge, bec

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-28 Thread Byungchul Park
On Thu, Feb 24, 2022 at 11:22:39AM +0100, Jan Kara wrote: > On Thu 24-02-22 10:11:02, Byungchul Park wrote: > > On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote: > > > > KJOURNALD2(kthread) TASK1(ksys_write) TASK2(ksys_write) > > > > > > > > wait A > > > > --- stuck > > > >

Re: [PATCH] drm/panel: simple: Initialize bpc in RK101II01D-CT panel descriptor

2022-02-28 Thread Tomi Valkeinen
On 10/02/2022 16:03, Rahul T R wrote: Initialize bpc while creating panel_desc structure for RK101II01D-CT Below warning is triggered since bpc is not being initialized WARNING: CPU: 2 PID: 47 at drivers/gpu/drm/panel/panel-simple.c:614 panel_simple_probe+0x1b0/0x3c8 Signed-off-by: Rahul T R

Re: [PATCH] drm/bridge: cdns-dsi: Make sure to to create proper aliases for dt

2022-02-28 Thread Tomi Valkeinen
On 09/11/2021 16:55, Nishanth Menon wrote: On 12:40-20210921, Nishanth Menon wrote: Add MODULE_DEVICE_TABLE to the device tree table to create required aliases needed for module to be loaded with device tree based platform. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-b

Re: [PATCH v5 4/7] drm/aspeed: Add AST2600 chip support

2022-02-28 Thread Joel Stanley
On Wed, 8 Dec 2021 at 01:34, Tommy Haung wrote: > > From: tommy-huang > > Add AST2600 chip support and setting. > > Signed-off-by: tommy-huang Reviewed-by: Joel Stanley > --- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/g

Re: [PATCH v5 5/7] drm/aspeed: Add reset and clock for AST2600

2022-02-28 Thread Joel Stanley
On Wed, 8 Dec 2021 at 01:34, Tommy Haung wrote: > > From: tommy-huang > > Add more reset and clock select code for AST2600. > The gfx_flags parameter was added for chip caps idenified. Can you tell me a bit more about the two reset lines: What is the CRT reset line controlling? What does the e

Re: [PATCH v5 0/7] Add Aspeed AST2600 soc display support

2022-02-28 Thread Joel Stanley
Hi Tommy, On Wed, 8 Dec 2021 at 01:34, Tommy Haung wrote: > > v5: > Add lost reset define. > > v4: > Add necessary reset control for ast2600. > Add chip caps for futher use. > These code are test on AST2500 and AST2600 by below steps. > > 1. Add below config to turn VT and LOGO on. > >

[PATCH v3 08/21] dept: Apply Dept to wait_for_completion()/complete()

2022-02-28 Thread Byungchul Park
Makes Dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 42 -- kernel/sched/completion.c | 12 ++-- 2 files changed, 50 insertions(+), 4 deletions(-) diff --git a/i

[PATCH v3 00/21] DEPT(Dependency Tracker)

2022-02-28 Thread Byungchul Park
I didn't want to bother you so I was planning to send the next spin after making more progress. However, PATCH v2 reports too many false positives because Dept tracked the bit_wait_table[] wrong way - I apologize for that. So I decided to send PATCH v3 first before going further for those who want

[PATCH v3 09/21] dept: Apply Dept to seqlock

2022-02-28 Thread Byungchul Park
Makes Dept able to track dependencies by seqlock with adding wait annotation on read side of seqlock. Signed-off-by: Byungchul Park --- include/linux/seqlock.h | 59 - 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/include/linux/seql

[PATCH v3 06/21] dept: Apply Dept to mutex families

2022-02-28 Thread Byungchul Park
Makes Dept able to track dependencies by mutex families. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 18 +++--- include/linux/mutex.h | 33 + include/linux/rtmutex.h | 7 +++ 3 files changed, 55 insertions(+), 3 deletions(-) dif

[PATCH v3 19/21] dept: Disable Dept within the wait_bit layer by default

2022-02-28 Thread Byungchul Park
The struct wait_queue_head array, bit_wait_table[] in sched/wait_bit.c are shared by all its users, which unfortunately vary in terms of class. So each should've been assigned its own class to avoid false positives. It'd better let Dept work at a higher layer than wait_bit. So disabled Dept within

[PATCH v3 01/21] llist: Move llist_{head,node} definition to types.h

2022-02-28 Thread Byungchul Park
llist_head and llist_node can be used by very primitives. For example, Dept for tracking dependency uses llist things in its header. To avoid header dependency, move those to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2 file

[PATCH v3 14/21] dept: Apply SDT to swait

2022-02-28 Thread Byungchul Park
Makes SDT able to track dependencies by swait. Signed-off-by: Byungchul Park --- include/linux/swait.h | 4 kernel/sched/swait.c | 10 ++ 2 files changed, 14 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index 6a8c22b..dbdf2ce 100644 --- a/include/linux

[PATCH v3 07/21] dept: Apply Dept to rwlock

2022-02-28 Thread Byungchul Park
Makes Dept able to track dependencies by rwlock. Signed-off-by: Byungchul Park --- include/linux/lockdep.h| 25 include/linux/rwlock.h | 52 ++ include/linux/rwlock_api_smp.h | 8 +++ include/linux/rwlock_types.h

[PATCH v3 12/21] dept: Introduce split map concept and new APIs for them

2022-02-28 Thread Byungchul Park
There is a case where all maps used for a type of wait/event is so large in size. For instance, struct page can be a type for (un)lock_page(). The additional memory size for the maps would be 'the # of pages * sizeof(struct dept_map)' if each struct page keeps its map all the way, which might be to

[PATCH v3 20/21] dept: Add nocheck version of init_completion()

2022-02-28 Thread Byungchul Park
For completions who don't want to get tracked by Dept, added init_completion_nocheck() to disable Dept on it. Signed-off-by: Byungchul Park --- include/linux/completion.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/linux/completion.h b/include/linu

[PATCH v3 17/21] dept: Distinguish each syscall context from another

2022-02-28 Thread Byungchul Park
It enters kernel mode on each syscall and each syscall handling should be considered independently from the point of view of Dept. Otherwise, Dept may wrongly track dependencies across different syscalls. That might be a real dependency from user mode. However, now that Dept just started to work,

[PATCH v3 02/21] dept: Implement Dept(Dependency Tracker)

2022-02-28 Thread Byungchul Park
CURRENT STATUS -- Lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. Lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm a

[PATCH v3 10/21] dept: Apply Dept to rwsem

2022-02-28 Thread Byungchul Park
Makes Dept able to track dependencies by rwsem. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 24 include/linux/percpu-rwsem.h | 10 +- include/linux/rwsem.h| 33 + 3 files changed, 62 insertions(+), 5 de

[PATCH v3 13/21] dept: Apply Dept to wait/event of PG_{locked, writeback}

2022-02-28 Thread Byungchul Park
Makes Dept able to track dependencies by PG_{locked,writeback}. For instance, (un)lock_page() generates that type of dependency. Signed-off-by: Byungchul Park --- include/linux/dept_page.h | 78 + include/linux/page-flags.h | 45

[PATCH v3 05/21] dept: Apply Dept to spinlock

2022-02-28 Thread Byungchul Park
Makes Dept able to track dependencies by spinlock. Signed-off-by: Byungchul Park --- include/linux/lockdep.h| 18 +++--- include/linux/spinlock.h | 26 ++ include/linux/spinlock_types_raw.h | 13 + 3 files changed, 54 insertio

[PATCH v3 15/21] dept: Apply SDT to wait(waitqueue)

2022-02-28 Thread Byungchul Park
Makes SDT able to track dependencies by wait(waitqueue). Signed-off-by: Byungchul Park --- include/linux/wait.h | 6 +- kernel/sched/wait.c | 16 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/include/linux/wait.h b/include/linux/wait.h index 851e07d..21339

[PATCH v3 21/21] dept: Disable Dept on struct crypto_larval's completion for now

2022-02-28 Thread Byungchul Park
struct crypto_larval's completion is used for multiple purposes e.g. waiting for test to complete or waiting for probe to complete. The completion variable needs to be split according to what it's used for. Otherwise, Dept cannot distinguish one from another and doesn't work properly. Now that it

[PATCH v3 16/21] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2022-02-28 Thread Byungchul Park
cb92173d1f0 (locking/lockdep, cpu/hotplug: Annotate AP thread) was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced, false

[PATCH v3 18/21] dept: Distinguish each work from another

2022-02-28 Thread Byungchul Park
Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let Dept assign a different context id to each work. Signed-off-by: Byungchul Park ---

[PATCH v3 03/21] dept: Embed Dept data in Lockdep

2022-02-28 Thread Byungchul Park
Dept should work independently from Lockdep. However, there's no choise but to rely on Lockdep code and its instances for now. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 71 --- include/linux/lockdep_types.h | 3 ++ kernel/locking/l

[PATCH v3 04/21] dept: Add a API for skipping dependency check temporarily

2022-02-28 Thread Byungchul Park
Dept would skip check for dmaps marked by dept_map_nocheck() permanently. However, sometimes it needs to skip check for some dmaps temporarily and back to normal, for instance, lock acquisition with a nest lock. Lock usage check with regard to nest lock could be performed by Lockdep, however, depe

[PATCH v3 11/21] dept: Add proc knobs to show stats and dependency graph

2022-02-28 Thread Byungchul Park
It'd be useful to show Dept internal stats and dependency graph on runtime via proc for better information. Introduced the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 24 -- kernel/dependency/dept_internal.h | 26

Re: [PATCH] drm/i915: Depend on !PREEMPT_RT.

2022-02-28 Thread Tvrtko Ursulin
Hi, On 25/02/2022 23:03, Sebastian Andrzej Siewior wrote: On 2022-02-14 19:59:08 [+0100], To intel-...@lists.freedesktop.org wrote: There are a few sections in the driver which are not compatible with PREEMPT_RT. They trigger warnings and can lead to deadlocks at runtime. Disable the i915 dr

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-28 Thread Jan Kara
On Mon 28-02-22 18:28:26, Byungchul Park wrote: > On Thu, Feb 24, 2022 at 11:22:39AM +0100, Jan Kara wrote: > > On Thu 24-02-22 10:11:02, Byungchul Park wrote: > > > On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote: > > > > > KJOURNALD2(kthread) TASK1(ksys_write) TASK2(ksys_write) >

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Mika Westerberg
Hi Bjorn, On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote: > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external-facing" > assumption above. Not having a Thunderbolt spec, I have no idea how > you deal with that. You can download the spec here: https://www.usb.org/si

Re: [PATCH 1/2] drm/i915: Fix assert in i915_ggtt_pin

2022-02-28 Thread Tvrtko Ursulin
On 25/02/2022 17:58, Ville Syrjälä wrote: On Fri, Feb 25, 2022 at 05:41:17PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use lockdep_assert_not_held to simplify and correct the code. Otherwise false positive are hit if lock state is uknown like after a previous taint. Signed-off-by: T

[PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Arnd Bergmann
From: Arnd Bergmann During a patch discussion, Linus brought up the option of changing the C standard version from gnu89 to gnu99, which allows using variable declaration inside of a for() loop. While the C99, C11 and later standards introduce many other features, most of these are already availa

Re: [Intel-gfx] [CI 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation (v4)

2022-02-28 Thread Tvrtko Ursulin
Hi Vivek, On 27/02/2022 17:29, Vivek Kasireddy wrote: This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() functions to identify suitable holes for an allocation of a given size by efficiently traversing the rbtree associated with the given allocator. It replaces the for loop in

Re: [PATCH] drm/i915: Depend on !PREEMPT_RT.

2022-02-28 Thread Sebastian Andrzej Siewior
On 2022-02-28 10:10:48 [+], Tvrtko Ursulin wrote: > Hi, Hi, > Could you paste a link to the queue of i915 patches pending for a quick > overview of how much work there is and in what areas? Last post to the list: https://https://lkml.kernel.org/r/.kernel.org/all/20211214140301.520464-1-big

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-02-28 Thread Maxime Ripard
On Fri, Feb 25, 2022 at 01:29:03PM -0800, Daniel Latypov wrote: > On Fri, Feb 25, 2022 at 5:23 AM Maxime Ripard wrote: > > > > Hi Daniel, > > > > On Wed, Feb 23, 2022 at 02:50:59PM -0800, Daniel Latypov wrote: > > > On Wed, Feb 23, 2022 at 2:56 AM Maxime Ripard wrote: > > > > > > > > Let's test v

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > During a patch discussion, Linus brought up the option of changing > the C standard version from gnu89 to gnu99, which allows using variable > declaration inside of a for() loop. While the C99, C11 and later

Re: [PATCH v2] drm/amdgpu: Fix realloc of ptr

2022-02-28 Thread Christian König
Am 27.02.22 um 16:33 schrieb t...@redhat.com: From: Tom Rix Clang static analysis reports this error amdgpu_debugfs.c:1690:9: warning: 1st function call argument is an uninitialized value tmp = krealloc_array(tmp, i + 1, ^~~ realloc uses tmp, so tmp can n

Re: [drm/selftests] 39ec47bbfd: kernel_BUG_at_drivers/gpu/drm/drm_buddy.c

2022-02-28 Thread Christian König
Arun can you take a look at that one here? It looks like a real problem to me and not just a potential false negative like the other issue. Thanks, Christian. Am 27.02.22 um 16:18 schrieb kernel test robot: Greeting, FYI, we noticed the following commit (built with gcc-9): commit: 39ec47b

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-02-28 Thread Maxime Ripard
On Fri, Feb 25, 2022 at 02:44:04PM -0800, Stephen Boyd wrote: > Quoting Maxime Ripard (2022-02-25 06:26:06) > > Hi Stephen, > > > > On Thu, Feb 24, 2022 at 02:54:20PM -0800, Stephen Boyd wrote: > > > Quoting Daniel Latypov (2022-02-23 14:50:59) > > > > On Wed, Feb 23, 2022 at 2:56 AM Maxime Ripard

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > If the list does not contain the expected element, the value of > list_for_each_entry() iterator will not point to a valid structure. > To avoid type confusion in such case, the list iterator > scope will be limited to list_for_each_e

Re: [PATCH v4,3/5] soc: mediatek: mmsys: add mt8186 mmsys routing table

2022-02-28 Thread Matthias Brugger
On 22/02/2022 06:28, Rex-BC Chen wrote: From: Yongqiang Niu Add new routing table for MT8186. In MT8186, there are two routing pipelines for internal and external display. Internal display: OVL0->RDMA0->COLOR0->CCORR0->AAL0->GAMMA->POSTMASK0-> DITHER->DSI0 External display

Re: [PATCH v4,4/5] soc: mediatek: add MTK mutex support for MT8186

2022-02-28 Thread Matthias Brugger
On 22/02/2022 06:28, Rex-BC Chen wrote: From: Yongqiang Niu Add MTK mutex support for MT8186 SoC. We need MTK mutex to control timing of display modules and there are two display pipelines for MT8186 including internal and external display. MTK mutex for internal display: - Timing source: D

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Mark Rutland
Hi Arnd, This is great! On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > During a patch discussion, Linus brought up the option of changing > the C standard version from gnu89 to gnu99, which allows using variable > declaration inside of a for() loop. Whi

Re: [PATCH 1/6] drivers: usb: remove usage of list iterator past the loop body

2022-02-28 Thread Dan Carpenter
On Mon, Feb 28, 2022 at 12:08:17PM +0100, Jakob Koschel wrote: > diff --git a/drivers/usb/gadget/udc/at91_udc.c > b/drivers/usb/gadget/udc/at91_udc.c > index 9040a0561466..0fd0307bc07b 100644 > --- a/drivers/usb/gadget/udc/at91_udc.c > +++ b/drivers/usb/gadget/udc/at91_udc.c > @@ -150,13 +150,14 @

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Arnd Bergmann
On Mon, Feb 28, 2022 at 12:25 PM Mark Rutland wrote: > On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > > > > Nathan Chancellor reported an additional -Wdeclaration-after-statement > > warning that appears in a system header on arm, this still needs a > > workaround. > > FWIW, I ha

Re: [PATCH 3/6] treewide: fix incorrect use to determine if list is empty

2022-02-28 Thread Dan Carpenter
On Mon, Feb 28, 2022 at 12:08:19PM +0100, Jakob Koschel wrote: > The list iterator value will *always* be set by list_for_each_entry(). > It is incorrect to assume that the iterator value will be NULL if the > list is empty. > > Instead of checking the pointer it should be checked if > the list is

Re: [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread John Stoffel
On Sun, Feb 27, 2022 at 10:52:43PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > During a patch discussion, Linus brought up the option of changing > the C standard version from gnu89 to gnu99, which allows using variable > declaration inside of a for() loop. While the C99, C11 and later

Re: [greybus-dev] [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Alex Elder
On 2/27/22 3:52 PM, Arnd Bergmann wrote: From: Arnd Bergmann During a patch discussion, Linus brought up the option of changing the C standard version from gnu89 to gnu99, which allows using variable declaration inside of a for() loop. While the C99, C11 and later standards introduce many other

amdgpu: sometimes black screen

2022-02-28 Thread Dāvis Mosāns
Hi, I've Gigabyte Radeon RX Vega 64 and sometimes when booting it doesn't give any signal to monitor over DisplayPort. Rebooting usually helps and it works fine after. Not sure if it's hardware or software issue. In dmesg only suspicious thing I see is many [drm] perform_link_training_with_retri

Re: [greybus-dev] [PATCH] Kbuild: remove -std=gnu89 from compiler arguments

2022-02-28 Thread Alex Elder
On 2/27/22 5:11 PM, Linus Torvalds wrote: On Sun, Feb 27, 2022 at 3:04 PM Alex Elder wrote: Glancing at the Greybus code, I don't believe there's any reason it needs to shift a negative value. Such warnings could be fixed by making certain variables unsigned, for example. As mentioned in th

[PATCH 5/6] treewide: remove dereference of list iterator after loop body

2022-02-28 Thread Jakob Koschel
The list iterator variable will be a bogus pointer if no break was hit. Dereferencing it could load *any* out-of-bounds/undefined value making it unsafe to use that in the comparision to determine if the specific element was found. This is fixed by using a separate list iterator variable for the l

[PATCH 1/6] drivers: usb: remove usage of list iterator past the loop body

2022-02-28 Thread Jakob Koschel
If the list representing the request queue does not contain the expected request, the value of list_for_each_entry() iterator will not point to a valid structure. To avoid type confusion in such case, the list iterator scope will be limited to list_for_each_entry() loop. In preparation to limiting

[PATCH 6/6] treewide: remove check of list iterator against head past the loop body

2022-02-28 Thread Jakob Koschel
When list_for_each_entry() completes the iteration over the whole list without breaking the loop, the iterator value will be a bogus pointer computed based on the head element. While it is safe to use the pointer to determine if it was computed based on the head element, either with list_entry_is_

[PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Jakob Koschel
If the list does not contain the expected element, the value of list_for_each_entry() iterator will not point to a valid structure. To avoid type confusion in such case, the list iterator scope will be limited to list_for_each_entry() loop. In preparation to limiting scope of a list iterator to th

[PATCH 3/6] treewide: fix incorrect use to determine if list is empty

2022-02-28 Thread Jakob Koschel
The list iterator value will *always* be set by list_for_each_entry(). It is incorrect to assume that the iterator value will be NULL if the list is empty. Instead of checking the pointer it should be checked if the list is empty. In acpi_get_pmu_hw_inf() instead of setting the pointer to NULL on

[PATCH 0/6] Remove usage of list iterator past the loop body

2022-02-28 Thread Jakob Koschel
This is the first patch removing several categories of use cases of the list iterator variable past the loop. This is follow up to the discussion in: https://lore.kernel.org/all/20220217184829.1991035-1-jakobkosc...@gmail.com/ As concluded in: https://lore.kernel.org/all/yhdfeiwi4edth...@kroah.com

Re: [PATCH v7 03/24] drm/rockchip: dw_hdmi: rename vpll clock to reference clock

2022-02-28 Thread Dmitry Osipenko
On 2/25/22 10:51, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. The clo

Re: [PATCH 6/6] treewide: remove check of list iterator against head past the loop body

2022-02-28 Thread Dominique Martinet
This is a bit more work (and a lot more noise), but I'd prefer if this were split into as many patches as there are components. I'm not going to review the parts of the patches that don't concern me, and if something turns out to be a problem later one (it shouldn't but one never knows) it'll be m

[PATCH 4/6] drivers: remove unnecessary use of list iterator variable

2022-02-28 Thread Jakob Koschel
When list_for_each_entry() completes the iteration over the whole list without breaking the loop, the iterator value will *always* be a bogus pointer computed based on the head element. To avoid type confusion use the actual list head directly instead of last iterator value. Signed-off-by: Jakob

Re: [PATCH v6 0/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-28 Thread Noralf Trønnes
Den 28.02.2022 09.31, skrev Maxime Ripard: > Hi, > > On Sun, Feb 27, 2022 at 01:47:08PM +0100, Noralf Trønnes wrote: >> Hi, >> >> This patchset adds a driver that will work with most MIPI DBI compatible >> SPI panels out there. >> >> One change this time: Fix indentation in the DT binding. >> >

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Arnd Bergmann
On Mon, Feb 28, 2022 at 12:47 PM Marco Elver wrote: > On Mon, 28 Feb 2022 at 11:32, Arnd Bergmann wrote: > > > Nathan Chancellor reported an additional -Wdeclaration-after-statement > > warning that appears in a system header on arm, this still needs a > > workaround. > > On the topic of Wdeclara

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Jani Nikula
On Mon, 28 Feb 2022, Laurent Pinchart wrote: > Hi Rob, > > On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: >> On Wed, Feb 2, 2022 at 7:41 AM Jani Nikula wrote: >> > On Wed, 02 Feb 2022, Laurent Pinchart wrote: >> > > On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: >> > >> O

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Christian König
Am 28.02.22 um 12:08 schrieb Jakob Koschel: If the list does not contain the expected element, the value of list_for_each_entry() iterator will not point to a valid structure. To avoid type confusion in such case, the list iterator scope will be limited to list_for_each_entry() loop. We explici

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hi Jani, On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: > On Mon, 28 Feb 2022, Laurent Pinchart wrote: > > On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: > >> On Wed, Feb 2, 2022 at 7:41 AM Jani Nikula wrote: > >> > On Wed, 02 Feb 2022, Laurent Pinchart wrote: > >> > > On

[CI 1/4] drm/i915/ttm: make eviction mappable aware

2022-02-28 Thread Matthew Auld
If we need to make room for some mappable object, then we should only victimize objects that have one or pages that occupy the visible portion of LMEM. Let's also create a new priority hint for objects that are placed in mappable memory, where we know that CPU access was requested, that way we hope

[CI 4/4] drm/i915/selftests: exercise mmap migration

2022-02-28 Thread Matthew Auld
Exercise each of the migration scenarios, verifying that the final placement and buffer contents match our expectations. v2(Thomas): Replace for_i915_gem_ww() block with simpler object_lock() v3: - For testing purposes allow forcing the io_size such that we can exercise the allocation + migrati

[CI 2/4] drm/i915/ttm: mappable migration on fault

2022-02-28 Thread Matthew Auld
The end goal is to have userspace tell the kernel what buffers will require CPU access, however if we ever reach the CPU fault handler, and the current resource is not mappable, then we should attempt to migrate the buffer to the mappable portion of LMEM, or even system memory, if the allowable pla

[CI 3/4] drm/i915/selftests: handle allocation failures

2022-02-28 Thread Matthew Auld
If we have to contend with non-mappable LMEM, then we need to ensure the object fits within the mappable portion, like in the selftests, where we later try to CPU access the pages. However if it can't then we need to gracefully handle this, without throwing an error. Also it looks like TTM will re

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Jani Nikula
On Mon, 28 Feb 2022, Arnd Bergmann wrote: > From: Arnd Bergmann > > During a patch discussion, Linus brought up the option of changing > the C standard version from gnu89 to gnu99, which allows using variable > declaration inside of a for() loop. While the C99, C11 and later standards > introduce

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread David Sterba
On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > > Link: > https://lore.kernel.org/lkml/CAHk-=wiych7xehcmifj-ygxuy2jaj7pnkdkpcovt8fybvfw...@mail.gmail.com/ > Link: https://github.com/ClangBuiltLinux/linux/issues/1603 > Suggested-by: Linus Torvalds > Cc:

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Arnd Bergmann
On Mon, Feb 28, 2022 at 1:36 PM Jani Nikula wrote: > > > > One minor issue that remains is an added gcc warning for shifts of > > negative integers when building with -Werror, which happens with the > > 'make W=1' option, as well as for three drivers in the kernel that always > > enable -Werror, b

Re: [PATCH 6/6] treewide: remove check of list iterator against head past the loop body

2022-02-28 Thread Dan Carpenter
On Mon, Feb 28, 2022 at 12:08:22PM +0100, Jakob Koschel wrote: > diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c > b/drivers/infiniband/hw/hfi1/tid_rdma.c > index 2a7abf7a1f7f..a069847b56aa 100644 > --- a/drivers/infiniband/hw/hfi1/tid_rdma.c > +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c > @@ -

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Dan Carpenter
On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > diff --git a/drivers/scsi/scsi_transport_sas.c > b/drivers/scsi/scsi_transport_sas.c > index 4ee578b181da..a8cbd90db9d2 100644 > --- a/drivers/scsi/scsi_transport_sas.c > +++ b/drivers/scsi/scsi_transport_sas.c > @@ -1060,26 +1060,29

Re: [PATCH 1/6] drivers: usb: remove usage of list iterator past the loop body

2022-02-28 Thread Dan Carpenter
On Mon, Feb 28, 2022 at 01:03:36PM +0100, Jakob Koschel wrote: > >> @@ -954,7 +957,6 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request > >> *_req) > >>dev_dbg(ep->dev->dev, "unlink (%s) pio\n", _ep->name); > >>net2272_done(ep, req, -ECONNRESET); > >>} > >> - re

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread David Sterba
On Mon, Feb 28, 2022 at 02:01:06PM +0100, Arnd Bergmann wrote: > On Mon, Feb 28, 2022 at 1:36 PM Jani Nikula > wrote: > > > > > > One minor issue that remains is an added gcc warning for shifts of > > > negative integers when building with -Werror, which happens with the > > > 'make W=1' option,

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-28 Thread Laurent Pinchart
Hello, On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: > On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: > > On Mon, 28 Feb 2022, Laurent Pinchart wrote: > > > On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: > > >> On Wed, Feb 2, 2022 at 7:41 AM Jani Nikul

Re: [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk

2022-02-28 Thread Sascha Hauer
On Fri, Feb 25, 2022 at 02:11:54PM +0100, Sascha Hauer wrote: > On Fri, Feb 25, 2022 at 12:41:23PM +, Robin Murphy wrote: > > On 2022-02-25 11:10, Dmitry Osipenko wrote: > > > 25.02.2022 13:49, Sascha Hauer пишет: > > > > On Fri, Feb 25, 2022 at 01:26:14PM +0300, Dmitry Osipenko wrote: > > > >

[PATCH] drm/nouveau/instmem: fix uninitialized_var.cocci warning

2022-02-28 Thread Guo Zhengkui
Fix following coccicheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c:316:11-12: WARNING this kind of initialization is deprecated. `void *map = map` has the same form of uninitialized_var() macro. I remove the redundant assignement. It has been tested with gcc (Debian 8.3.0-6) 8.3.

Re: [PATCH 3/3] drm/msm: Expose client engine utilization via fdinfo

2022-02-28 Thread Tvrtko Ursulin
On 25/02/2022 22:14, Rob Clark wrote: On Fri, Feb 25, 2022 at 12:25 PM Rob Clark wrote: From: Rob Clark Similar to AMD commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation fo

RE: [drm/selftests] 39ec47bbfd: kernel_BUG_at_drivers/gpu/drm/drm_buddy.c

2022-02-28 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only] Hi Christian, I will check Thanks, Arun -Original Message- From: Koenig, Christian Sent: Monday, February 28, 2022 4:29 PM To: kernel test robot ; Paneer Selvam, Arunpravin Cc: 0day robot ; Matthew Auld ; LKML ; l...@lists.01.org; dri-devel@lists.freedesktop.

Re: [PATCH] drm/bridge: it6505: Fix the read buffer array bound

2022-02-28 Thread Robert Foss
On Mon, 28 Feb 2022 at 09:14, Hsin-Yi Wang wrote: > > The size of read_buf is READ_BUFFER_SIZE (200), so we can't access it > with read_buf + PAGE_SIZE (4096). Extend the READ_BUFFER_SIZE to 400 and > set the end position to read_buf + READ_BUFFER_SIZE. > > Fixes: b5c84a9edcd418 ("drm/bridge: add

Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

2022-02-28 Thread Tvrtko Ursulin
On 25/02/2022 19:03, John Harrison wrote: On 2/25/2022 10:29, Tvrtko Ursulin wrote: On 25/02/2022 18:01, John Harrison wrote: On 2/25/2022 09:39, Tvrtko Ursulin wrote: On 25/02/2022 17:11, John Harrison wrote: On 2/25/2022 08:36, Tvrtko Ursulin wrote: On 24/02/2022 20:02, John Harrison wro

  1   2   3   >