Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-24 Thread Sascha Hauer
On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/18/22 16:00, Sascha Hauer wrote: > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 2/17/22 22:06, Heiko Stübner wrote: > > > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET

Re: [PATCH v3 3/5] fbdev: Remove trailing whitespaces from cfbimgblt.c

2022-02-24 Thread Javier Martinez Canillas
On 2/23/22 20:38, Thomas Zimmermann wrote: > Fix coding style. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-24 Thread Javier Martinez Canillas
On 2/23/22 20:38, Thomas Zimmermann wrote: > Improve the performance of cfb_imageblit() by manually unrolling > the inner blitting loop and moving some invariants out. The compiler > failed to do this automatically. This change keeps cfb_imageblit() > in sync with sys_imagebit(). > > A microbenchm

Re: [PATCH v3 5/5] drm: Add TODO item for optimizing format helpers

2022-02-24 Thread Javier Martinez Canillas
On 2/23/22 20:38, Thomas Zimmermann wrote: > Add a TODO item for optimizing blitting and format-conversion helpers > in DRM and fbdev. There's always demand for faster graphics output. > > Signed-off-by: Thomas Zimmermann > --- After fixing the typos mentioned by Sam: Reviewed-by: Javier Martin

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-24 Thread Javier Martinez Canillas
Hello Sam, On 2/23/22 21:25, Sam Ravnborg wrote: [snip] > > Question: What is cfb an abbreviation for anyway? > Not related to the patch - but if I have known the memory is lost.. > I was curious so I dug on this. It seems CFB stands for Color Frame Buffer. Doing a `git grep "(CFB)"` in the l

[PATCH 1/6] drm/i915/uapi: introduce drm_i915_gem_create_ext

2022-02-24 Thread Pallavi Mishra
From: Matthew Auld Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. v2:(Chris) - Use separate ioctl number for gem_create_ext, instead of hijacking the existing gem_create ioctl, otherwise we run into the issue with be

[PATCH 2/6] drm/i915/uapi: implement object placement extension

2022-02-24 Thread Pallavi Mishra
From: Matthew Auld Add new extension to support setting an immutable-priority-list of potential placements, at creation time. If we use the normal gem_create or gem_create_ext without the extensions/placements then we still get the old behaviour with only placing the object in system memory. v2

[PATCH 3/6] drm/i915/gem: clear userspace buffers for LMEM

2022-02-24 Thread Pallavi Mishra
From: Matthew Auld All userspace objects must be cleared when allocating the backing store, before they are potentially visible to userspace. For now use simple CPU based clearing to do this for device local-memory objects, note that in the near future this will instead use the blitter engine.

[PATCH 4/6] drm/i915/gem: hide new uAPI behind CONFIG_BROKEN

2022-02-24 Thread Pallavi Mishra
From: Matthew Auld Treat it the same as the fake local-memory stuff, where it is disabled for normal kernels, in case some random UMD is tempted to use this. Once we have all the other bits and pieces in place, like the TTM conversion, we can turn this on for real. Signed-off-by: Matthew Auld C

Re: [PATCH 3/3] drm: bridge: Switch to devm_drm_of_get_bridge

2022-02-24 Thread Jagan Teki
Hi Linus, On Sat, Dec 11, 2021 at 11:59 AM Jagan Teki wrote: > > Hi Linus, > > On Sat, Dec 11, 2021 at 5:37 AM Linus Walleij > wrote: > > > > On Fri, Dec 10, 2021 at 6:49 PM Jagan Teki > > wrote: > > > > > > devm_drm_of_get_bridge is capable of looking up the downstream > > > bridge and panel

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-24 Thread Tvrtko Ursulin
On 23/02/2022 19:03, John Harrison wrote: On 2/23/2022 04:13, Tvrtko Ursulin wrote: On 23/02/2022 02:11, John Harrison wrote: On 2/22/2022 01:52, Tvrtko Ursulin wrote: On 18/02/2022 21:33, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timesl

Re: Report 2 in ext4 and journal based on v5.17-rc1

2022-02-24 Thread Jan Kara
On Thu 24-02-22 10:11:02, Byungchul Park wrote: > On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote: > > > KJOURNALD2(kthread) TASK1(ksys_write) TASK2(ksys_write) > > > > > > wait A > > > --- stuck > > > wait B > > > --- stuck > > >

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-24 Thread Sam Ravnborg
Hi Javier, On Thu, Feb 24, 2022 at 10:02:59AM +0100, Javier Martinez Canillas wrote: > Hello Sam, > > On 2/23/22 21:25, Sam Ravnborg wrote: > > [snip] > > > > > Question: What is cfb an abbreviation for anyway? > > Not related to the patch - but if I have known the memory is lost.. > > > > I

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-02-24 Thread Geert Uytterhoeven
Hi Javier, On Thu, Feb 24, 2022 at 10:03 AM Javier Martinez Canillas wrote: > On 2/23/22 21:25, Sam Ravnborg wrote: > > Question: What is cfb an abbreviation for anyway? > > Not related to the patch - but if I have known the memory is lost.. > > I was curious so I dug on this. It seems CFB stands

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-24 Thread Andy Yan
Hi Sascha: On 2/24/22 16:19, Sascha Hauer wrote: On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: Hi Sascha: On 2/18/22 16:00, Sascha Hauer wrote: On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: Hi Sascha: On 2/17/22 22:06, Heiko Stübner wrote: Am Donnerstag, 17. Februar

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-02-24 Thread Tvrtko Ursulin
On 23/02/2022 20:00, John Harrison wrote: On 2/23/2022 05:58, Tvrtko Ursulin wrote: On 23/02/2022 02:45, John Harrison wrote: On 2/22/2022 03:19, Tvrtko Ursulin wrote: On 18/02/2022 21:33, john.c.harri...@intel.com wrote: From: John Harrison Compute workloads are inherantly not pre-emptib

[PULL] drm-intel-fixes

2022-02-24 Thread Tvrtko Ursulin
Hi Dave, Daniel, An assortment of display fixes for -rc6. Regards, Tvrtko drm-intel-fixes-2022-02-24: - Fix QGV handling on ADL-P+ (Ville Syrjälä) - Fix bw atomic check when switching between SAGV vs. no SAGV (Ville Syrjälä) - Disconnect PHYs left connected by BIOS on disabled ports (Imre De

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-24 Thread Sascha Hauer
On Thu, Feb 24, 2022 at 06:54:35PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/24/22 16:19, Sascha Hauer wrote: > > On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 2/18/22 16:00, Sascha Hauer wrote: > > > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy

[PATCH] drm/todo: Update panic handling todo

2022-02-24 Thread Daniel Vetter
Some things changed, and add two useful links. Cc: Javier Martinez Canillas Cc: Pekka Paalanen Cc: gpicc...@igalia.com Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/Documentation/gpu/todo.r

[PATCH] drm/i915: Be more gentle when exiting non-persistent contexts

2022-02-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When a non-persistent context exits we currently mark it as banned in order to trigger fast termination of any outstanding GPU jobs it may have left running. In doing so we apply a very strict 1ms limit in which the left over job has to preempt before we issues an engine res

Re: [PATCH] drm/todo: Update panic handling todo

2022-02-24 Thread Javier Martinez Canillas
Hello Daniel, On 2/24/22 13:59, Daniel Vetter wrote: > Some things changed, and add two useful links. > > Cc: Javier Martinez Canillas > Cc: Pekka Paalanen > Cc: gpicc...@igalia.com > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 21 + > 1 file changed,

[PATCH] drm/todo: Update panic handling todo

2022-02-24 Thread Daniel Vetter
Some things changed, and add two useful links. v2: Also include a link to the QR encoding work. Plus review from Javier. Reviewed-by: Javier Martinez Canillas Cc: Javier Martinez Canillas Cc: Pekka Paalanen Cc: gpicc...@igalia.com Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst |

Re: [PATCH] drm/todo: Update panic handling todo

2022-02-24 Thread Guilherme G. Piccoli
On 24/02/2022 10:24, Daniel Vetter wrote: > Some things changed, and add two useful links. > > v2: Also include a link to the QR encoding work. Plus review from > Javier. > > Reviewed-by: Javier Martinez Canillas > Cc: Javier Martinez Canillas > Cc: Pekka Paalanen > Cc: gpicc...@igalia.com > S

Re: [PATCH v8 15/19] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-02-24 Thread AngeloGioacchino Del Regno
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. It supports the mt8195, the embedded DisplayPort units. It offers hot-plug-detection and DisplayPort 1.4 with up to 4 lanes. The driver creates a

Re: [PATCH v5 1/4] drm/i915/guc: Add fetch of hwconfig table

2022-02-24 Thread Michal Wajdeczko
On 22.02.2022 11:36, Jordan Justen wrote: > From: John Harrison > > Implement support for fetching the hardware description table from the > GuC. The call is made twice - once without a destination buffer to > query the size and then a second time to fill in the buffer. > > Note that the tabl

Re: [PATCH] drm/repaper: Use format helper for xrgb8888 to monochrome conversion

2022-02-24 Thread Noralf Trønnes
Den 23.02.2022 20.37, skrev Javier Martinez Canillas: > There is now a drm_fb_xrgb_to_mono_reversed() helper function to do > format conversion from XRGB to reversed monochrome. > > Use that helper and remove the open coded version in the repaper driver. > > Signed-off-by: Javier Marti

[PATCH 0/3] enhanced edid driver compatibility

2022-02-24 Thread Lee Shawn C
Support to parse multiple CEA extension blocks and HF-EEODB to extend drm edid driver's capability. Lee Shawn C (3): drm/edid: parse multiple CEA extension block drm/edid: read HF-EEODB ext block drm/edid: parse HF-EEODB CEA extension block drivers/gpu/drm/drm_connector.c | 5 +- drivers

[PATCH 2/3] drm/edid: read HF-EEODB ext block

2022-02-24 Thread Lee Shawn C
Support to read HF_EEODB block that request by HDMI 2.1 specification. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_connector.c | 5 ++- drivers/gpu/drm/drm_edid.c | 76 ++--- include/drm/drm_edid.h

[PATCH 1/3] drm/edid: parse multiple CEA extension block

2022-02-24 Thread Lee Shawn C
Try to find and parse more CEA ext blocks if edid->extensions is greater than one. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_edid.c | 110 - 1 file changed, 60 insertions(+), 50 deletions(-) dif

[PATCH 3/3] drm/edid: parse HF-EEODB CEA extension block

2022-02-24 Thread Lee Shawn C
While adding CEA modes, try to get available EEODB block number. Then based on it to parse numbers of ext blocks, retrieve CEA information and add more CEA modes. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/drm_displayid.c | 5 - dr

Re: [PATCH] drm/repaper: Use format helper for xrgb8888 to monochrome conversion

2022-02-24 Thread Javier Martinez Canillas
Hello Noralf, On 2/24/22 15:04, Noralf Trønnes wrote: > > > Den 23.02.2022 20.37, skrev Javier Martinez Canillas: >> There is now a drm_fb_xrgb_to_mono_reversed() helper function to do >> format conversion from XRGB to reversed monochrome. >> >> Use that helper and remove the open coded

gpu/drm/dp/drm_dp.c:59:27: warning: array subscript 10 is outside array bounds of 'const u8[6]'

2022-02-24 Thread Naresh Kamboju
[Please ignore this email if it is already reported] Linux next-20220223 arch riscv build warnings noticed. Build configs: - riscv-gcc-9-defconfig - riscv-gcc-9-defconfig - riscv-gcc-10-defconfig - riscv-gcc-11-defconfig metadata: git_ref: master git_repo: https://gitlab.com/Linaro/lk

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-24 Thread Sascha Hauer
On Thu, Feb 24, 2022 at 05:36:29PM +0300, Dmitry Osipenko wrote: > On 2/24/22 10:47, Sascha Hauer wrote: > > On Thu, Feb 17, 2022 at 04:24:29PM +0300, Dmitry Osipenko wrote: > >> 17.02.2022 11:29, Sascha Hauer пишет: > >>> @@ -28,6 +28,12 @@ config ROCKCHIP_VOP > >>> This selects support for th

Re: [PATCH 3/7] drm/bridge: Extend struct drm_bus_cfg with clock field

2022-02-24 Thread Maxime Ripard
Hi, On Sat, Feb 19, 2022 at 01:28:40AM +0100, Marek Vasut wrote: > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index 1701c2128a5cb..32455cf28f0bc 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -1077,6 +1077,11 @@ struct drm_bus_cfg { >*

[PATCH v5 1/5] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-24 Thread Noralf Trønnes
Add binding for MIPI DBI compatible SPI panels. v5: - Add sainsmart18 to compatible items (Rob) - Expand write-only description (Sam) v4: - There should only be two compatible (Maxime) - s/panel-dbi-spi/panel-mipi-dbi-spi/in compatible v3: - Move properties to Device Tree (Maxime) - Use contains

[PATCH v5 4/5] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev

2022-02-24 Thread Noralf Trønnes
devm_drm_dev_alloc() can't allocate structures that embed a structure which then again embeds drm_device. Workaround this by adding a driver_private pointer to struct mipi_dbi_dev which the driver can use for its additional state. v3: - Add documentation Acked-by: Maxime Ripard Acked-by: Sam Rav

[PATCH v5 2/5] drm/modes: Remove trailing whitespace

2022-02-24 Thread Noralf Trønnes
Remove trailing whitespace from a comment. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 96b13e36293c..77a4c8dd0bb8 100644 --- a/drivers/gpu/drm/drm

[PATCH v5 0/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-24 Thread Noralf Trønnes
Hi, This patchset adds a driver that will work with most MIPI DBI compatible SPI panels out there. It can replace the SPI interface support in these drivers: $ grep -lr MIPI_DCS drivers/staging/fbtft/ | grep -v "-" | uniq | sort drivers/staging/fbtft/fb_hx8340bn.c drivers/staging/fbtft/fb_hx8353

[PATCH v5 3/5] drm/modes: Add of_get_drm_panel_display_mode()

2022-02-24 Thread Noralf Trønnes
Add a function to get a drm_display_mode from a panel-timing device tree subnode. Suggested-by: Sam Ravnborg Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_modes.c | 49 + include/drm/drm_modes.h | 8 ++ 2 files changed, 57 insertions(+) diff

[PATCH v5 5/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-24 Thread Noralf Trønnes
Add a driver that will work with most MIPI DBI compatible SPI panels. This avoids adding a driver for every new MIPI DBI compatible controller that is to be used by Linux. The 'compatible' Device Tree property with a '.bin' suffix will be used to load a firmware file that contains the controller co

Re: [RFC][PATCH 0/7] drm/bridge: Add support for selecting DSI host HS clock from DSI bridge

2022-02-24 Thread Maxime Ripard
Hi, On Sat, Feb 19, 2022 at 01:28:37AM +0100, Marek Vasut wrote: > This patch series attempts to address a problem of missing support for DSI > bridge-to-bridge or panel-to-bridge clock frequency negotiation. The problem > has two variants. > > First, a DSI->to->x bridge derives its own internal

Re: [PATCH v1] drm/tegra: Use dev_err_probe()

2022-02-24 Thread Thierry Reding
On Tue, Feb 08, 2022 at 12:29:23AM +0300, Dmitry Osipenko wrote: > Replace dev_printk() with a generic dev_err_probe() helper which silences > noisy error messages about deferred probe and makes easy to debug failing > deferred probe by printing notification about the failure to KMSG in the > end o

Re: [RFC v4 02/11] drm/amdgpu: Move scheduler init to after XGMI is ready

2022-02-24 Thread Andrey Grodzovsky
No because all the patch-set including this patch was landed into drm-misc-next and will reach amd-staging-drm-next on the next upstream rebase i guess. Andrey On 2022-02-24 01:47, JingWen Chen wrote: Hi Andrey, Will you port this patch into amd-staging-drm-next? on 2/10/22 2:06 AM, Andrey

linux-next: manual merge of the drm tree with the drm-fixes tree

2022-02-24 Thread broonie
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/dc/core/dc_resource.c between commit: 3743e7f6fcb93 ("drm/amd/display: Fix stream->link_enc unassigned during stream removal") from the drm-fixes tree and commits: 6d33f0e820bfb ("drm/amd/di

Re: [PATCH 1/2] kernel/hung_task: Exporting sysctl_hung_task_timeout_secs

2022-02-24 Thread Lucas De Marchi
On Thu, Feb 24, 2022 at 01:22:02AM +0530, Ramalingam C wrote: Exporting sysctl_hung_task_timeout_secs, to make it available for other kernel modules. I guess this should only be done if second patch is accepted by sound subsystem maintainers. If it is, then I'd do some changes in the commit mes

Re: [Intel-gfx] [PATCH 2/2] hda/i915: split the wait for the component binding

2022-02-24 Thread Kai Vehmanen
Hi, On Thu, 24 Feb 2022, Ramalingam C wrote: > Split the wait for component binding from i915 in multiples of > sysctl_hung_task_timeout_secs. This helps to avoid the possible kworker > thread hung detection given below. while I understand the problem, I'm not sure whether a simpler option shoul

Re: [PATCH libdrm v2 02/25] tegra: Remove unused IOCTL implementations

2022-02-24 Thread Dmitry Osipenko
17.02.2022 22:16, Thierry Reding пишет: > From: Thierry Reding > > The DRM_TEGRA_GEM_{GET,SET}_FLAGS and DRM_TEGRA_GEM_{GET,SET}_TILING > IOCTLs were badly designed and have since been obsoleted by framebuffer > modifiers. Remove these implementations to make it clear their usage is > discouraged

Re: [PATCH libdrm v2 07/25] tegra: Make API more consistent

2022-02-24 Thread Dmitry Osipenko
17.02.2022 22:19, Thierry Reding пишет: > From: Thierry Reding > > Most functions in libdrm_tegra take as first parameter the object that > they operate on. Make the device and buffer object creation functions > follow the same scheme. > > Signed-off-by: Thierry Reding > --- > tegra/tegra.c

Re: [RFC v4 02/11] drm/amdgpu: Move scheduler init to after XGMI is ready

2022-02-24 Thread Deucher, Alexander
[Public] If it applies cleanly, feel free to drop it in. I'll drop those patches for drm-next since they are already in drm-misc. Alex From: amd-gfx on behalf of Andrey Grodzovsky Sent: Thursday, February 24, 2022 11:24 AM To: Chen, JingWen ; Christian König

Re: [PATCH 2/2] hda/i915: split the wait for the component binding

2022-02-24 Thread Lucas De Marchi
On Thu, Feb 24, 2022 at 01:22:03AM +0530, Ramalingam C wrote: Split the wait for component binding from i915 in multiples of sysctl_hung_task_timeout_secs. This helps to avoid the possible kworker thread hung detection given below. <3>[ 60.946316] INFO: task kworker/11:1:104 blocked for more t

Re: [PATCH libdrm v2 05/25] tegra: Add flink helpers

2022-02-24 Thread Dmitry Osipenko
17.02.2022 22:16, Thierry Reding пишет: > +int drm_tegra_bo_get_name(struct drm_tegra_bo *bo, uint32_t *name); > +int drm_tegra_bo_open(struct drm_tegra *drm, uint32_t name, uint32_t flags, > + struct drm_tegra_bo **bop); drm_tegra_bo_open() isn't a very good name for a functi

Re: [RFC v4 02/11] drm/amdgpu: Move scheduler init to after XGMI is ready

2022-02-24 Thread Andrey Grodzovsky
No problem if so but before I do, JingWen - why you think this patch is needed as a standalone now ? It has no use without the entire feature together with it. Is it some changes you want to do on top of that code ? Andrey On 2022-02-24 12:12, Deucher, Alexander wrote: [Public] If it

Re: [PATCH v5 1/5] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-24 Thread Rob Herring
On Thu, 24 Feb 2022 16:27:04 +0100, Noralf Trønnes wrote: > Add binding for MIPI DBI compatible SPI panels. > > v5: > - Add sainsmart18 to compatible items (Rob) > - Expand write-only description (Sam) > > v4: > - There should only be two compatible (Maxime) > - s/panel-dbi-spi/panel-mipi-dbi-sp

linux-next: manual merge of the drm-intel tree with the drm-intel-gt tree

2022-02-24 Thread broonie
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c between commit: 721fd84ea1fe9 ("drm/i915/pmu: Use PM timestamp instead of RING TIMESTAMP for reference") from the drm-intel-gt tree and commit: b3f74938d6566 ("dr

Re: [PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-24 Thread Kuogee Hsieh
Hi Stephen, Are you still has concern on this patch? Thanks, On 2/17/2022 12:01 PM, Kuogee Hsieh wrote: On 2/17/2022 11:36 AM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-02-17 10:35:30) Since DRM_DEBUG_DP is deprecated in favor of drm_dbg_dp(NULL, ...), this patch replace all DRM_DEBUG

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

2022-02-24 Thread Abhinav Kumar
On 2/18/2022 6:26 PM, Dmitry Baryshkov wrote: On 19/02/2022 02:56, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-02-11 14:40:02) In commit 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") the DP driver received a drm_bridge instance, which is always at

Re: [PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-17 10:35:30) > Since DRM_DEBUG_DP is deprecated in favor of drm_dbg_dp(NULL, ...), > this patch replace all DRM_DEBUG_DP with drm_dbg_dp(). > > Changes in v4: > -- replace (strucr drm_dev *)NULL with drm_dev > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen

Re: [PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp

2022-02-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-24 10:20:31) > Hi Stephen, > > Are you still has concern on this patch? > No more concerns.

Re: [PATCH v5 1/5] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-24 Thread Rob Herring
On Thu, Feb 24, 2022 at 04:27:04PM +0100, Noralf Trønnes wrote: > Add binding for MIPI DBI compatible SPI panels. > > v5: > - Add sainsmart18 to compatible items (Rob) > - Expand write-only description (Sam) > > v4: > - There should only be two compatible (Maxime) > - s/panel-dbi-spi/panel-mipi-d

Re: [PATCH V2 04/11] drm/bridge: tc358767: Implement atomic_check callback

2022-02-24 Thread Marek Vasut
On 2/21/22 10:01, Maxime Ripard wrote: On Sat, Feb 19, 2022 at 03:26:40AM +0100, Marek Vasut wrote: On 2/18/22 18:34, Lucas Stach wrote: Hi [...] drivers/gpu/drm/bridge/tc358767.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc35

Re: [PATCH V2 05/11] drm/bridge: tc358767: Move hardware init to enable callback

2022-02-24 Thread Marek Vasut
On 2/21/22 10:12, Lucas Stach wrote: Am Samstag, dem 19.02.2022 um 03:39 +0100 schrieb Marek Vasut: On 2/18/22 18:49, Lucas Stach wrote: Am Freitag, dem 18.02.2022 um 02:00 +0100 schrieb Marek Vasut: The TC358767/TC358867/TC9595 are all capable of operating either from attached Xtal or from DS

[PATCH 0/4] Address a few compilation warnings

2022-02-24 Thread Magali Lemes
This patchset addresses a few warnings reported by the Kernel Test Robot and sparse. Magali Lemes (4): drm/amd/display: Adjust functions documentation drm/amd/display: Add conditional around function drm/amd/display: Use NULL instead of 0 drm/amd/display: Turn functions into static drive

Re: [PATCH v4,1/5] dt-bindings: arm: mediatek: mmsys: add support for MT8186

2022-02-24 Thread Rob Herring
On Tue, 22 Feb 2022 13:27:59 +0800, Rex-BC Chen wrote: > Add "mediatek,mt8186-mmsys" to binding document. > > Signed-off-by: Rex-BC Chen > --- > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

[PATCH 1/4] drm/amd/display: Adjust functions documentation

2022-02-24 Thread Magali Lemes
Part of the documentation of the 'dc_process_dmub_aux_transfer_async' function was misplaced, being put together with the ‘dc_enable_dmub_notifications’ documentation. This caused the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3757: warning: expecting prototype for dc_pr

[PATCH 2/4] drm/amd/display: Add conditional around function

2022-02-24 Thread Magali Lemes
When CONFIG_DRM_AMD_DC_DCN is not set, the function 'dm_helpers_enable_periodic_detection' doesn't have its prototype defined, causing the following warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:805:6: warning: no previous prototype for function 'dm_helpers_enable_p

[PATCH 3/4] drm/amd/display: Use NULL instead of 0

2022-02-24 Thread Magali Lemes
Silence the following sparse warnings: ../drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:865:16: sparse: warning: Using plain integer as NULL pointer ../drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1588:84: sparse: warning: Using plain integer as NULL p

[PATCH 4/4] drm/amd/display: Turn functions into static

2022-02-24 Thread Magali Lemes
Silence [-Wmissing-prototypes] sparse warnings from the display folder such as: ../drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_smu.c:126:5: warning: no previous prototype for ‘dcn315_smu_send_msg_with_param’ [-Wmissing-prototypes] 126 | int dcn315_smu_send_msg_with_param(

Re: [PATCH v4,2/5] dt-bindings: display: mediatek: add MT8186 SoC binding

2022-02-24 Thread Rob Herring
On Tue, Feb 22, 2022 at 01:28:00PM +0800, Rex-BC Chen wrote: > Add MT8186 SoC binding to AAL, CCORR, COLOR, DITHER, GAMMA, MUTEX, > OVL, POSTMASK and RDMA. > > Signed-off-by: Rex-BC Chen > --- > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 7 +++ > .../bindings/display/mediat

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-24 Thread John Harrison
On 2/24/2022 01:59, Tvrtko Ursulin wrote: On 23/02/2022 19:03, John Harrison wrote: On 2/23/2022 04:13, Tvrtko Ursulin wrote: On 23/02/2022 02:11, John Harrison wrote: On 2/22/2022 01:52, Tvrtko Ursulin wrote: On 18/02/2022 21:33, john.c.harri...@intel.com wrote: From: John Harrison GuC co

Re: [PATCH v5 2/5] drm/modes: Remove trailing whitespace

2022-02-24 Thread Sam Ravnborg
On Thu, Feb 24, 2022 at 04:27:05PM +0100, Noralf Trønnes wrote: > Remove trailing whitespace from a comment. > > Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_modes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm

Re: [PATCH v5 3/5] drm/modes: Add of_get_drm_panel_display_mode()

2022-02-24 Thread Sam Ravnborg
On Thu, Feb 24, 2022 at 04:27:06PM +0100, Noralf Trønnes wrote: > Add a function to get a drm_display_mode from a panel-timing > device tree subnode. Thanks for implementing this! > > Suggested-by: Sam Ravnborg > Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg

Re: [PATCH v5 5/5] drm/tiny: Add MIPI DBI compatible SPI driver

2022-02-24 Thread Sam Ravnborg
Hi Noralf, On Thu, Feb 24, 2022 at 04:27:08PM +0100, Noralf Trønnes wrote: > Add a driver that will work with most MIPI DBI compatible SPI panels. > This avoids adding a driver for every new MIPI DBI compatible controller > that is to be used by Linux. The 'compatible' Device Tree property with >

Re: [PATCH 0/4] Address a few compilation warnings

2022-02-24 Thread Harry Wentland
Series is Reviewed-by: Harry Wentland Harry On 2022-02-24 14:15, Magali Lemes wrote: > This patchset addresses a few warnings reported by the Kernel Test Robot and > sparse. > > Magali Lemes (4): > drm/amd/display: Adjust functions documentation > drm/amd/display: Add conditional around fun

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-02-24 Thread John Harrison
On 2/24/2022 03:41, Tvrtko Ursulin wrote: On 23/02/2022 20:00, John Harrison wrote: On 2/23/2022 05:58, Tvrtko Ursulin wrote: On 23/02/2022 02:45, John Harrison wrote: On 2/22/2022 03:19, Tvrtko Ursulin wrote: On 18/02/2022 21:33, john.c.harri...@intel.com wrote: From: John Harrison Comput

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-24 Thread John Harrison
On 2/24/2022 11:19, John Harrison wrote: [snip] I'll change it to _uses_ and repost, then. [    7.683149] kernel BUG at drivers/gpu/drm/i915/gt/uc/intel_guc.h:367! Told you that one went bang. John.

Re: [RFC PATCH v2 2/5] drm/msm/dp: support attaching bridges to the DP encoder

2022-02-24 Thread Abhinav Kumar
On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: Currently DP driver will allocate panel bridge for eDP panels. This supports only the following topology: - eDP encoder ⇒ eDP panel (wrapped using panel-bridge) Simplify this code to just check if there is any next bridge in the chain (be it a pa

[PATCH V3 00/12] drm/bridge: tc358767: Add DSI-to-DPI mode support

2022-02-24 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Clean up the driver, switch to atomic ops, and add support for the DSI-to-DPI mode in addition to already supported DPI-to-(e)DP mode. Cc: Jonas Karlman Cc: Laurent Pinchart Cc: M

[PATCH V3 08/12] drm/bridge: tc358767: Wrap (e)DP aux I2C registration into tc_aux_link_setup()

2022-02-24 Thread Marek Vasut
This bit of code is (e)DP and aux I2C link specific, move it into tc_aux_link_setup() to permit cleaner addition of DSI-to-DPI mode. No functional change. Reviewed-by: Lucas Stach Signed-off-by: Marek Vasut Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Maxime Ripard Cc: Neil Armstrong Cc: Sam R

[PATCH V3 09/12] drm/bridge: tc358767: Move bridge ops setup into tc_probe_edp_bridge_endpoint()

2022-02-24 Thread Marek Vasut
The bridge ops are specific to the bridge configuration, move them into tc_probe_edp_bridge_endpoint() to permit cleaner addition of DSI-to-DPI mode. No functional change. Signed-off-by: Marek Vasut Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Maxime Ripard Cc: Neil Armstrong Cc: Sam Ravnborg

[PATCH V3 02/12] dt-bindings: display: bridge: tc358867: Document DSI data-lanes property

2022-02-24 Thread Marek Vasut
It is necessary to specify the number of connected/used DSI data lanes when using the DSI input port of this bridge. Document the 'data-lanes' property of the DSI input port. Signed-off-by: Marek Vasut Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Maxime Ripard Cc: Neil Armstrong Cc: Rob Herring

[PATCH V3 01/12] dt-bindings: display: bridge: tc358867: Document DPI output support

2022-02-24 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Document support for the DPI output port, which can now be connected both as input and output. Signed-off-by: Marek Vasut Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Maxime Ripard

[PATCH V3 11/12] drm/bridge: tc358767: Split tc_set_video_mode() into common and (e)DP part

2022-02-24 Thread Marek Vasut
The tc_set_video_mode() sets up both common and (e)DP video mode settings of the bridge chip. Split the function into tc_set_common_video_mode() to set the common settings and tc_set_edp_video_mode() to set the (e)DP specific settings. No functional change. Reviewed-by: Lucas Stach Signed-off-by:

[PATCH V3 10/12] drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT

2022-02-24 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Only the first mode is currently supported. It is possible to find out the mode in which the bridge should be operated by testing connected endpoints in DT. Port allocation: port@0

[PATCH V3 04/12] drm/bridge: tc358767: Convert to atomic ops

2022-02-24 Thread Marek Vasut
Use the atomic version of the enable/disable operations to continue the transition to the atomic API. This will be needed to access the mode from the atomic state. Reviewed-by: Lucas Stach Signed-off-by: Marek Vasut Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Maxime Ripard Cc: Neil Armstrong

[PATCH V3 06/12] drm/bridge: tc358767: Move hardware init to enable callback

2022-02-24 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating either from attached Xtal or from DSI clock lane clock. In case the later is used, all I2C accesses will fail until the DSI clock lane is running and supplying clock to the chip. Move all hardware initialization to enable callback to guaran

[PATCH V3 03/12] drm/bridge: tc358767: Change tc_ prefix to tc_edp_ for (e)DP specific functions

2022-02-24 Thread Marek Vasut
These functions are specific to (e)DP output initialization and operation, add specific tc_edp_ prefix to those functions to discern them from DPI output functions that will be added later in this series. No functional change. Reviewed-by: Lucas Stach Signed-off-by: Marek Vasut Cc: Jonas Karlman

[PATCH V3 12/12] drm/bridge: tc358767: Add DSI-to-DPI mode support

2022-02-24 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Add support for the DSI-to-DPI mode. This requires skipping most of the (e)DP initialization code, which is currently a large part of this driver, hence it is better to have far sim

[PATCH V3 07/12] drm/bridge: tc358767: Move (e)DP bridge endpoint parsing into dedicated function

2022-02-24 Thread Marek Vasut
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Only the first mode is currently supported. In order to support the rest of the modes without making the tc_probe() overly long, split the bridge endpoint parsing into dedicated func

[PATCH V3 05/12] drm/bridge: tc358767: Implement atomic_check callback

2022-02-24 Thread Marek Vasut
Implement .atomic_check callback which prevents user space from setting unsupported mode. The tc_edp_common_atomic_check() variant is already prepared for DSI-to-DPI mode addition, which has different frequency limits. Signed-off-by: Marek Vasut Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Maxime

Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

2022-02-24 Thread John Harrison
On 2/23/2022 04:00, Tvrtko Ursulin wrote: On 23/02/2022 02:22, John Harrison wrote: On 2/22/2022 01:53, Tvrtko Ursulin wrote: On 18/02/2022 21:33, john.c.harri...@intel.com wrote: From: John Harrison Compute workloads are inherently not pre-emptible on current hardware. Thus the pre-emption

Re: [PATCH 3/7] drm/bridge: Extend struct drm_bus_cfg with clock field

2022-02-24 Thread Marek Vasut
On 2/24/22 16:19, Maxime Ripard wrote: Hi, Hi, On Sat, Feb 19, 2022 at 01:28:40AM +0100, Marek Vasut wrote: diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 1701c2128a5cb..32455cf28f0bc 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -1077,6 +107

Re: [RFC PATCH v2 3/5] drm/msm/dp: support finding next bridge even for DP interfaces

2022-02-24 Thread Abhinav Kumar
On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: It is possible to supply display-connector (bridge) to the DP interface, add support for parsing it too. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_parser.c | 19 --- 1 file changed, 12 insertions(+), 7 delet

Re: [PATCH 0/4] Address a few compilation warnings

2022-02-24 Thread Alex Deucher
Applied with some minor modifications to patches 3 and 4 to avoid adding new warnings. Alex On Thu, Feb 24, 2022 at 2:44 PM Harry Wentland wrote: > > Series is > Reviewed-by: Harry Wentland > > Harry > > On 2022-02-24 14:15, Magali Lemes wrote: > > This patchset addresses a few warnings reporte

Re: [RFC][PATCH 0/7] drm/bridge: Add support for selecting DSI host HS clock from DSI bridge

2022-02-24 Thread Marek Vasut
On 2/24/22 16:40, Maxime Ripard wrote: Hi, Hi, On Sat, Feb 19, 2022 at 01:28:37AM +0100, Marek Vasut wrote: This patch series attempts to address a problem of missing support for DSI bridge-to-bridge or panel-to-bridge clock frequency negotiation. The problem has two variants. First, a DSI-

Re: [PATCH] drm/nouveau: Remove the unused header file nvif/list.h

2022-02-24 Thread Lyude Paul
Thanks for the ping! Reviewed-by: Lyude Paul I will push this to drm-misc-next in a bit On Wed, 2022-02-23 at 10:18 +0800, Cai Huoqing wrote: > On 09 2月 22 14:53:19, Cai Huoqing wrote: > > The nouveau driver depends on include/linux/list.h instead of > > nvif/list.h, so remove the obstacle-nvif

Re: [PATCH 0/3] drm/helpers: Make the suballocation manager drm generic.

2022-02-24 Thread Maarten Lankhorst
Op 23-02-2022 om 16:11 schreef Christian König: > Am 23.02.22 um 14:51 schrieb Maarten Lankhorst: >> Second version of the patch. I didn't fix the copyright (which ame up >> in the previous version), as I feel the original author should send a >> patch for that. >> >> I've made the suballocator int

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

2022-02-24 Thread Dmitry Baryshkov
On Thu, 24 Feb 2022 at 21:25, Abhinav Kumar wrote: > > > > On 2/18/2022 6:26 PM, Dmitry Baryshkov wrote: > > On 19/02/2022 02:56, Stephen Boyd wrote: > >> Quoting Dmitry Baryshkov (2022-02-11 14:40:02) > >>> In commit 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display > >>> enable and

Re: [RFC PATCH v2 3/5] drm/msm/dp: support finding next bridge even for DP interfaces

2022-02-24 Thread Dmitry Baryshkov
On Thu, 24 Feb 2022 at 23:13, Abhinav Kumar wrote: > > > > On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: > > It is possible to supply display-connector (bridge) to the DP interface, > > add support for parsing it too. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/dp/dp

Re: [RFC PATCH v2 3/5] drm/msm/dp: support finding next bridge even for DP interfaces

2022-02-24 Thread Abhinav Kumar
On 2/24/2022 12:49 PM, Dmitry Baryshkov wrote: On Thu, 24 Feb 2022 at 23:13, Abhinav Kumar wrote: On 2/11/2022 2:40 PM, Dmitry Baryshkov wrote: It is possible to supply display-connector (bridge) to the DP interface, add support for parsing it too. Signed-off-by: Dmitry Baryshkov ---

Re: [Intel-gfx] [PATCH 5/8] drm/i915/guc: Move lrc desc setup to where it is needed

2022-02-24 Thread John Harrison
On 2/23/2022 18:03, Ceraolo Spurio, Daniele wrote: On 2/23/2022 12:23 PM, John Harrison wrote: On 2/22/2022 17:12, Ceraolo Spurio, Daniele wrote: On 2/17/2022 3:52 PM, john.c.harri...@intel.com wrote: From: John Harrison The LRC descriptor was being initialised early on in the context regist

  1   2   >