Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-22 Thread Ceraolo Spurio, Daniele
On 2/18/2022 1:33 PM, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst case scenario is approximately 110 sec

Re: [PATCH 2/5] drm/msm/adreno: Generate name from chipid for 7c3

2022-02-22 Thread Rob Clark
On Mon, Feb 21, 2022 at 6:41 AM Akhil P Oommen wrote: > > Use a gpu name which is sprintf'ed from the chipid for 7c3 gpu instead of > hardcoding one. This helps to avoid code churn in case of a gpu rename. > > Signed-off-by: Akhil P Oommen > --- > > drivers/gpu/drm/msm/adreno/adreno_device.c |

Re: [PATCH 0/5] Support 7c3 gpu SKUs

2022-02-22 Thread Rob Clark
On Mon, Feb 21, 2022 at 6:41 AM Akhil P Oommen wrote: > > This series supercedes [1]. Major change in this series is that it is now > optional to include a gpu name in the gpu-list. This helps to avoid the > confusion when we have different SKUs with different gpu names. And also > I am pretty hap

Re: [PATCH 3/8] drm/i915/guc: Better name for context id limit

2022-02-22 Thread Ceraolo Spurio, Daniele
On 2/17/2022 3:52 PM, john.c.harri...@intel.com wrote: From: John Harrison The LRC descriptor pool is going away. So, stop using it as the limit for how many context ids are available. I think this could be slightly reworded to make it clear that the numbers are not changing. Maybe add so

Re: [Intel-gfx] [PATCH 4/8] drm/i915/guc: Split guc_lrc_desc_pin apart

2022-02-22 Thread Ceraolo Spurio, Daniele
On 2/17/2022 3:52 PM, john.c.harri...@intel.com wrote: From: John Harrison The LRC descriptor pool is going away. Further, the function that was populating it was also doing a bunch of logic about the context registration sequence. So, split that code apart into separate state setup and try

Re: [Intel-gfx] [PATCH 5/8] drm/i915/guc: Move lrc desc setup to where it is needed

2022-02-22 Thread Ceraolo Spurio, Daniele
On 2/17/2022 3:52 PM, john.c.harri...@intel.com wrote: From: John Harrison The LRC descriptor was being initialised early on in the context registration sequence. It could then be determined that the actual registration needs to be delayed and the descriptor would be wiped out. This is ineff

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/gem: Remove logic for wbinvd_on_all_cpus

2022-02-22 Thread Michael Cheng
Thanks for letting me know! I will try for a different solution. On 2022-02-22 11:24 a.m., Thomas Hellström (Intel) wrote: Hi, Michael, On 2/22/22 18:26, Michael Cheng wrote: This patch removes logic for wbinvd_on_all_cpus and brings in drm_cache.h. This header has the logic that outputs a war

Re: [PATCH 6/8] drm/i915/guc: Rename desc_idx to ctx_id

2022-02-22 Thread Ceraolo Spurio, Daniele
On 2/17/2022 3:52 PM, john.c.harri...@intel.com wrote: From: John Harrison The LRC descriptor pool is going away. So, stop naming context ids as descriptor pool indecies. While at it, add a bunch of missing line feeds to some error messages. Signed-off-by: John Harrison Reviewed-by: Dan

Re: [PATCH 7/8] drm/i915/guc: Drop obsolete H2G definitions

2022-02-22 Thread Ceraolo Spurio, Daniele
On 2/17/2022 3:52 PM, john.c.harri...@intel.com wrote: From: John Harrison The CTB registration process changed significantly a while back using a single KLV based H2G. So drop the original and now obsolete H2G definitions. The GuC specs has those defines marked as deprecated since v63 and

Re: [PATCH 8/8] drm/i915/guc: Fix potential invalid pointer dereferences when decoding G2Hs

2022-02-22 Thread Ceraolo Spurio, Daniele
On 2/17/2022 3:52 PM, john.c.harri...@intel.com wrote: From: John Harrison Some G2H handlers were reading the context id field from the payload before checking the payload met the minimum length required. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio While double-che

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Do not complain about stale reset notifications

2022-02-22 Thread Ceraolo Spurio, Daniele
On 2/11/2022 5:04 PM, john.c.harri...@intel.com wrote: From: John Harrison It is possible for reset notifications to arrive for a context that is in the process of being banned. So don't flag these as an error, just report it as informational (because it is still useful to know that resets a

Re: Report 1 in ext4 and journal based on v5.17-rc1

2022-02-22 Thread Byungchul Park
On Tue, Feb 22, 2022 at 09:27:23AM +0100, Jan Kara wrote: > On Thu 17-02-22 20:10:03, Byungchul Park wrote: > > [7.009608] === > > [7.009613] DEPT: Circular dependency has been detected. > > [7.009614] 5.17.0-rc1-00014-g8a599299c0cb-dirty

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Do not complain about stale reset notifications

2022-02-22 Thread John Harrison
On 2/22/2022 17:39, Ceraolo Spurio, Daniele wrote: On 2/11/2022 5:04 PM, john.c.harri...@intel.com wrote: From: John Harrison It is possible for reset notifications to arrive for a context that is in the process of being banned. So don't flag these as an error, just report it as informational

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-22 Thread John Harrison
On 2/22/2022 01:52, Tvrtko Ursulin wrote: On 18/02/2022 21:33, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-22 Thread John Harrison
On 2/22/2022 16:52, Ceraolo Spurio, Daniele wrote: On 2/18/2022 1:33 PM, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platfo

Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

2022-02-22 Thread John Harrison
On 2/22/2022 01:53, Tvrtko Ursulin wrote: On 18/02/2022 21:33, john.c.harri...@intel.com wrote: From: John Harrison Compute workloads are inherently not pre-emptible on current hardware. Thus the pre-emption timeout was disabled as a workaround to prevent unwanted resets. Instead, the hang det

Re: [PATCH] drm/nouveau: Remove the unused header file nvif/list.h

2022-02-22 Thread Cai Huoqing
On 09 2月 22 14:53:19, Cai Huoqing wrote: > The nouveau driver depends on include/linux/list.h instead of > nvif/list.h, so remove the obstacle-nvif/list.h. > > Signed-off-by: Cai Huoqing > --- Ping :) > drivers/gpu/drm/nouveau/include/nvif/list.h | 353 > 1 file changed, 353

Re: [PATCH v5 01/11] clk: Introduce Kunit Tests for the framework

2022-02-22 Thread kernel test robot
e-handling/20220222-212043 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20220223/202202231024.8sblrlyr-...@intel.com/config) compiler: mips-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build):

[PATCH AUTOSEL 5.16 22/30] drm/amd/pm: correct UMD pstate clocks for Dimgrey Cavefish and Beige Goby

2022-02-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit 0136f5844b006e2286f873457c3fcba8c45a3735 ] Correct the UMD pstate profiling clocks for Dimgrey Cavefish and Beige Goby. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../amd/pm/swsmu/smu11/sie

[PATCH AUTOSEL 5.15 20/28] drm/amd/pm: correct UMD pstate clocks for Dimgrey Cavefish and Beige Goby

2022-02-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit 0136f5844b006e2286f873457c3fcba8c45a3735 ] Correct the UMD pstate profiling clocks for Dimgrey Cavefish and Beige Goby. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../amd/pm/swsmu/smu11/sie

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-02-22 Thread John Harrison
On 2/22/2022 03:19, Tvrtko Ursulin wrote: On 18/02/2022 21:33, john.c.harri...@intel.com wrote: From: John Harrison Compute workloads are inherantly not pre-emptible for long periods on current hardware. As a workaround for this, the pre-emption timeout for compute capable engines was disabled

Re: [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support

2022-02-22 Thread Dmitry Baryshkov
On 19/02/2022 21:33, Rob Clark wrote: From: Rob Clark Avoid going down devfreq paths on devices where devfreq is not initialized. Reported-by: Linux Kernel Functional Testing Reported-by: Anders Roxell Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 31 +++

Re: Report 1 in ext4 and journal based on v5.17-rc1

2022-02-22 Thread Byungchul Park
On Tue, Feb 22, 2022 at 09:27:23AM +0100, Jan Kara wrote: > On Thu 17-02-22 20:10:03, Byungchul Park wrote: > > [7.009608] === > > [7.009613] DEPT: Circular dependency has been detected. > > [7.009614] 5.17.0-rc1-00014-g8a599299c0cb-dirty

RE: [PATCH v2 1/3] drm/mm: Ensure that the entry is not NULL before extracting rb_node

2022-02-22 Thread Kasireddy, Vivek
Hi Tvrtko, > > On 18/02/2022 03:47, Kasireddy, Vivek wrote: > > Hi Tvrtko, > > > >> > >> On 17/02/2022 07:50, Vivek Kasireddy wrote: > >>> While looking for next holes suitable for an allocation, although, > >>> it is highly unlikely, make sure that the DECLARE_NEXT_HOLE_ADDR > >>> macro is using

Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-22 Thread Laurent Pinchart
On Tue, Feb 22, 2022 at 11:44:54PM +0100, Linus Walleij wrote: > On Tue, Feb 22, 2022 at 11:19 PM Douglas Anderson > wrote: > > > > The PM Runtime docs say: > > Drivers in ->remove() callback should undo the runtime PM changes done > > in ->probe(). Usually this means calling pm_runtime_disab

[PATCH v11 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-22 Thread Michael Cheng
Add arm64 support for drm_clflush_virt_range. dcache_clean_inval_poc performs a flush by first performing a clean, follow by an invalidation operation. v2 (Michael Cheng): Use correct macro for cleaning and invalidation the dcache. Thanks Tvrtko for the suggestion. v3 (Michael

[PATCH v11 2/6] drm/i915/gt: Re-work intel_write_status_page

2022-02-22 Thread Michael Cheng
Re-work intel_write_status_page to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_engine.h | 13 - 1 file changed, 4 insertions(+), 9 deleti

[PATCH v11 3/6] drm/i915/gt: Drop invalidate_csb_entries

2022-02-22 Thread Michael Cheng
Drop invalidate_csb_entries and directly call drm_clflush_virt_range. This allows for one less function call, and prevent complier errors when building for non-x86 architectures. v2(Michael Cheng): Drop invalidate_csb_entries function and directly invoke drm_clflush_virt_range.

[PATCH v11 0/6] Use drm_clflush* instead of clflush

2022-02-22 Thread Michael Cheng
This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures. v2: s/PAGE_SIZE/sizeof(value) for Re-work intel_write_status_page and added more patches to convert addi

[PATCH v11 5/6] drm/i915/: Re-work clflush_write32

2022-02-22 Thread Michael Cheng
Use drm_clflush_virt_range instead of clflushopt and remove the memory barrier, since drm_clflush_virt_range takes care of that. v2(Michael Cheng): Use sizeof(*addr) instead of sizeof(addr) to get the actual size of the page. Thanks to Matt Roper for pointing

[PATCH v11 6/6] drm/i915/gt: replace cache_clflush_range

2022-02-22 Thread Michael Cheng
Replace all occurrence of cache_clflush_range with drm_clflush_virt_range. This will prevent compile errors on non-x86 platforms. Signed-off-by: Michael Cheng Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 12 ++-- drivers/gpu/drm/i915/gt/intel_execli

[PATCH v11 4/6] drm/i915/gt: Re-work reset_csb

2022-02-22 Thread Michael Cheng
Use drm_clflush_virt_range instead of directly invoking clflush. This will prevent compiler errors when building for non-x86 architectures. v2(Michael Cheng): Remove extra clflush v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range takes care of it. v4(Michae

RE: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-22 Thread Kandpal, Suraj
Hey, > The connector/encoder funcs you do have to pass to > drm_writeback_connector_init() can't use any of the shared driver > infrastructure that assume a certain inheritance. > > See also my reply to Laurent [1]. > > > It well might be that we all misunderstand your design. Do you have a > >

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-22 Thread Christian König
Hi Jiawei, can you take a look at this? The kernel build robots screaming that this breaks the V3D build. Probably just a typo or missing include. I would rather like to push this sooner than later. Thanks, Christian. Am 21.02.22 um 16:51 schrieb kernel test robot: Hi Jiawei, Thank you fo

RE: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-22 Thread Gu, JiaWei (Will)
[AMD Official Use Only] Hi Christian, I noticed that and it has been fixed with the latest patch. And I pushed it to amd-staging-drm-next already. Best regards, Jiawei -Original Message- From: Koenig, Christian Sent: Wednesday, February 23, 2022 3:12 PM To: kernel test robot ; Gu, Jia

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-22 Thread Christian König
Well that's bad. This should not be pushed to amd-staging-drm-next at all. This patch is touching multiple drivers and therefore needs to go upstream through drm-misc-next. Alex can you drop that one before you send out a pull request? I'm going to cherry-pick it over to drm-misc-next. Than

Re: [PATCH v2] drm/amdgpu: check vm ready by amdgpu_vm->evicting flag

2022-02-22 Thread Paul Menzel
Dear Qiang, Am 22.02.22 um 03:46 schrieb Qiang Yu: Workstation application ANSA/META v21.1.4 get this error dmesg when running CI test suite provided by ANSA/META: [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) This is caused by: 1. create a 256MB buffer in invisible VR

Re: [v1] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-02-22 Thread Dmitry Baryshkov
On 18/02/2022 14:30, Vinod Polimera wrote: - Some DPU versions support inline rot90. It is supported only for limited amount of UBWC formats. - There are two versions of inline rotators, v1 (present on sm8250 and sm7250) and v2 (sc7280). These versions differ in the list of supported formats and

Re: [PATCH v2] drm/amdgpu: check vm ready by amdgpu_vm->evicting flag

2022-02-22 Thread Qiang Yu
On Wed, Feb 23, 2022 at 3:47 PM Paul Menzel wrote: > > Dear Qiang, > > > Am 22.02.22 um 03:46 schrieb Qiang Yu: > > Workstation application ANSA/META v21.1.4 get this error dmesg when > > running CI test suite provided by ANSA/META: > > [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO

<    1   2   3