[PATCH v2 1/3] drm/mm: Ensure that the entry is not NULL before extracting rb_node

2022-02-17 Thread Vivek Kasireddy
While looking for next holes suitable for an allocation, although, it is highly unlikely, make sure that the DECLARE_NEXT_HOLE_ADDR macro is using a valid node before it extracts the rb_node from it. Cc: Tvrtko Ursulin Cc: Christian König Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/drm_

[PATCH v2 0/3] drm/mm: Add an iterator to optimally walk over holes suitable for an allocation

2022-02-17 Thread Vivek Kasireddy
The first patch is a drm core patch that replaces the for loop in drm_mm_insert_node_in_range() with the iterator and would not cause any functional changes. The second patch is a i915 driver specific patch that also uses the iterator but solves a different problem. v2: - Added a new patch to this

[PATCH v2 2/3] drm/mm: Add an iterator to optimally walk over holes for an allocation (v4)

2022-02-17 Thread Vivek Kasireddy
This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() functions to identify suitable holes for an allocation of a given size by efficiently traversing the rbtree associated with the given allocator. It replaces the for loop in drm_mm_insert_node_in_range() and can also be used by drm

[PATCH v2 3/3] drm/i915/gem: Don't try to map and fence large scanout buffers (v8)

2022-02-17 Thread Vivek Kasireddy
On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or more framebuffers/scanout buffers results in only one that is mappable/ fenceable. Therefore, pageflipping between these 2 FBs where only one is mappable/fenceable creates latencies large enough to miss alternate vblanks thereby

[PATCH v2] drm/bridge: Clear the DP_AUX_I2C_MOT bit passed in aux read command.

2022-02-17 Thread Hsin-Yi Wang
If the previous transfer didn't end with a command without DP_AUX_I2C_MOT, the next read trasnfer will miss the first byte. But if the command in previous transfer is requested with length 0, it's a no-op to anx7625 since it can't process this command. anx7625 requires the last command to be read c

[PATCH v3 2/2] drm/msm/gpu: Cancel idle/boost work on suspend

2022-02-17 Thread Anders Roxell
From: Rob Clark From: Rob Clark With system suspend using pm_runtime_force_suspend() we can't rely on the pm_runtime_get_if_in_use() trick to deal with devfreq callbacks after (or racing with) suspend. So flush any pending idle or boost work in the suspend path. Signed-off-by: Rob Clark ---

[PATCH] drm/imx/dcss: i.MX8MQ DCSS select DRM_GEM_CMA_HELPER

2022-02-17 Thread Rudi Heitbaum
Without DRM_GEM_CMA_HELPER i.MX8MQ DCSS won't build. This needs to be there. Signed-off-by: Rudi Heitbaum --- drivers/gpu/drm/imx/dcss/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig index 7374f1952762..5c2b2277afbf

[PATCH v6 05/23] drm/rockchip: dw_hdmi: add rk3568 support

2022-02-17 Thread Sascha Hauer
Add a new dw_hdmi_plat_data struct and new compatible for rk3568. Signed-off-by: Benjamin Gaignard Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 31 + 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v6 00/23] drm/rockchip: RK356x VOP2 support

2022-02-17 Thread Sascha Hauer
This is v6 of adding RK356x VOP2 support. Biggest change this time is that I no longer modify struct drm_encoder, instead the rockchip drivers now embed struct drm_encoder in a rockchip specific struct. Sascha Changes since v5: - Add new patch to fix dw-hdmi of_graph binding - Drop "drm/encoder:

[PATCH v6 02/23] drm/rockchip: dw_hdmi: rename vpll clock to reference clock

2022-02-17 Thread Sascha Hauer
"vpll" is a misnomer. A clock input to a device should be named after the usage in the device, not after the clock that drives it. On the rk3568 the same clock is driven by the HPLL. To fix that, this patch renames the vpll clock to ref clock. The clock name "vpll" is left for compatibility to old

[PATCH v6 13/23] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always

2022-02-17 Thread Sascha Hauer
From: Douglas Anderson Jitter was improved by lowering the MPLL bandwidth to account for high frequency noise in the rk3288 PLL. In each case MPLL bandwidth was lowered only enough to get us a comfortable margin. We believe that lowering the bandwidth like this is safe given sufficient testing.

[PATCH v6 18/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-17 Thread Sascha Hauer
This enabled the VOP2 display controller along with hdmi and the required port routes which is enough to get a picture out of the hdmi port of the board. Signed-off-by: Sascha Hauer --- Notes: Changes since v5: - Drop reg property from single endpoint node Changes since v4:

[PATCH v6 22/23] dt-bindings: display: rockchip: Add binding for VOP2

2022-02-17 Thread Sascha Hauer
The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. The binding differs slightly from the existing VOP binding, so add a new binding file for it. Signed-off-by: Sascha Hauer Reviewed-by: Rob Herring --- Notes: Changes since v5: - Add Robs Reviewed-by: Change

[PATCH v6 17/23] arm64: dts: rockchip: rk356x: Add HDMI nodes

2022-02-17 Thread Sascha Hauer
Add support for the HDMI port found on RK3568. Signed-off-by: Sascha Hauer --- Notes: Changes since v5: - Drop unnecessary #size-cells/#address-cells from nodes with only single endpoint arch/arm64/boot/dts/rockchip/rk356x.dtsi | 33 +++- 1 file changed, 32 inserti

[PATCH v6 19/23] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a

2022-02-17 Thread Sascha Hauer
From: Michael Riesch Enable the RK356x Video Output Processor (VOP) 2 on the Pine64 Quartz64 Model A. Signed-off-by: Michael Riesch Signed-off-by: Sascha Hauer --- Notes: Changes since v5: - Drop reg property from single endpoint node Changes since v4: - Sort nodes alphab

[PATCH v6 07/23] drm/rockchip: dw_hdmi: add regulator support

2022-02-17 Thread Sascha Hauer
The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed for the HDMI port. add support for these to the driver for boards which have them supplied by switchable regulators. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 41 +++-- 1

[PATCH v6 11/23] drm/rockchip: dw_hdmi: Use auto-generated tables

2022-02-17 Thread Sascha Hauer
From: Douglas Anderson The previous tables for mpll_cfg and curr_ctrl were created using the 20-pages of example settings provided by the PHY vendor. Those example settings weren't particularly dense, so there were places where we were guessing what the settings would be for 10-bit and 12-bit (n

[PATCH v6 04/23] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref'

2022-02-17 Thread Sascha Hauer
The reference clock for the HDMI controller has been renamed to 'ref', the previous 'vpll' name is only left for compatibility in the driver. Rename the clock to the new name. Signed-off-by: Sascha Hauer --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v6 09/23] drm/rockchip: dw_hdmi: Add support for hclk

2022-02-17 Thread Sascha Hauer
The rk3568 HDMI has an additional clock that needs to be enabled for the HDMI controller to work. The purpose of that clock is not clear. It is named "hclk" in the downstream driver, so use the same name. Signed-off-by: Sascha Hauer --- Notes: Changes since v5: - Use devm_clk_get_optiona

[PATCH v6 15/23] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional

2022-02-17 Thread Sascha Hauer
None of the upstream device tree files has a "unwedge" pinctrl specified. Make it optional. Signed-off-by: Sascha Hauer Acked-by: Rob Herring --- Notes: Changes since v4: - Add Robs Ack .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 1 + 1 file changed, 1 insertion

[PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Sascha Hauer
From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonstandard DRM properties have been removed - dropped str

[PATCH v6 16/23] arm64: dts: rockchip: rk356x: Add VOP2 nodes

2022-02-17 Thread Sascha Hauer
The VOP2 is the display output controller on the RK3568. Add the node for it to the dtsi file along with the required display-subsystem node and the iommu node. Signed-off-by: Sascha Hauer Acked-by: Rob Herring --- Notes: Changes since v4: - Add Robs Ack Changes since v3: -

[PATCH v6 23/23] dt-bindings: display: rockchip: dw-hdmi: fix ports description

2022-02-17 Thread Sascha Hauer
Current port description doesn't cover all possible cases. It currently expects one single port with two endpoints. When the HDMI connector is described in the device tree there can be two ports, first one going to the VOP and the second one going to the connector. Also on SoCs which only have a

[PATCH v6 14/23] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz

2022-02-17 Thread Sascha Hauer
From: Nickey Yang add 594Mhz configuration parameters in rockchip_phy_config Signed-off-by: Nickey Yang Signed-off-by: Sascha Hauer --- Notes: Changes since v3: - new patch drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/dr

[PATCH v6 03/23] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name

2022-02-17 Thread Sascha Hauer
"vpll" is a misnomer. A clock input to a device should be named after the usage in the device, not after the clock that drives it. On the rk3568 the same clock is driven by the HPLL. This patch adds "ref" as a new alternative clock name for "vpll" Signed-off-by: Sascha Hauer Acked-by: Rob Herring

[PATCH v6 10/23] dt-bindings: display: rockchip: dw-hdmi: Add additional clock

2022-02-17 Thread Sascha Hauer
The rk3568 HDMI has an additional clock that needs to be enabled for the HDMI controller to work. The purpose of that clock is not clear. It is named "hclk" in the downstream driver, so use the same name. Signed-off-by: Sascha Hauer Acked-by: Rob Herring --- Notes: Changes since v4: - A

[PATCH v6 01/23] drm/rockchip: Embed drm_encoder into rockchip_decoder

2022-02-17 Thread Sascha Hauer
The VOP2 driver needs rockchip specific information for a drm_encoder. This patch creates a struct rockchip_encoder with a struct drm_encoder embedded in it. This is used throughout the rockchip driver instead of struct drm_encoder directly. The information the VOP2 drivers needs is the of_graph

[PATCH v6 20/23] drm/rockchip: Make VOP driver optional

2022-02-17 Thread Sascha Hauer
With upcoming VOP2 support VOP won't be the only choice anymore, so make the VOP driver optional. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/Kconfig| 8 drivers/gpu/drm/rockchip/Makefile | 3 ++- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- 3 f

[PATCH v6 08/23] dt-bindings: display: rockchip: dw-hdmi: Add regulator support

2022-02-17 Thread Sascha Hauer
The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed for the HDMI port. Add the binding for these supplies. Signed-off-by: Sascha Hauer Acked-by: Rob Herring --- Notes: Changes since v4: - Add Robs Ack .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 11

[PATCH v6 12/23] drm/rockchip: dw_hdmi: drop mode_valid hook

2022-02-17 Thread Sascha Hauer
The driver checks if the pixel clock of the given mode matches an entry in the mpll config table. The frequencies in the mpll table are meant as a frequency range up to which the entry works, not as a frequency that must match the pixel clock. The downstream Kernel also does not have this check, so

[PATCH v6 06/23] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI

2022-02-17 Thread Sascha Hauer
From: Benjamin Gaignard Define a new compatible for rk3568 HDMI. This version of HDMI hardware block needs two new clocks hclk_vio and hclk to provide phy reference clocks. Signed-off-by: Benjamin Gaignard Reviewed-by: Rob Herring Signed-off-by: Sascha Hauer --- .../devicetree/bindings/displ

Re: [PATCH v2] drm/bridge: Clear the DP_AUX_I2C_MOT bit passed in aux read command.

2022-02-17 Thread Xin Ji
On Thu, Feb 17, 2022 at 04:22:25PM +0800, Hsin-Yi Wang wrote: > If the previous transfer didn't end with a command without DP_AUX_I2C_MOT, > the next read trasnfer will miss the first byte. But if the command in > previous transfer is requested with length 0, it's a no-op to anx7625 > since it can'

Re: [PATCH v6 2/3] dt-bindings: ls2k1000: add the display controller device node

2022-02-17 Thread Krzysztof Kozlowski
On 16/02/2022 15:01, Sui Jingfeng wrote: > > On 2022/2/3 16:50, Krzysztof Kozlowski wrote: >> On Thu, 3 Feb 2022 at 09:26, Sui Jingfeng <15330273...@189.cn> wrote: >>> From: suijingfeng >>> >>> The display controller is a pci device, its vendor id is 0x0014 >>> its device id is 0x7a06. >> The sam

Re: [PATCH v3 02/16] iosys-map: Add a few more helpers

2022-02-17 Thread Thomas Zimmermann
Hi Am 16.02.22 um 18:41 schrieb Lucas De Marchi: First the simplest ones: - iosys_map_memset(): when abstracting system and I/O memory, just like the memcpy() use case, memset() also has dedicated functions to be called for using IO memory. - iosys_map_memcpy

Re: [PATCH v8 2/3] MIPS: Loongson64: dts: update the display controller device node

2022-02-17 Thread Krzysztof Kozlowski
On 16/02/2022 19:17, Sui Jingfeng wrote: > From: suijingfeng > > The display controller is a pci device, its PCI vendor id is 0x0014 > its PCI device id is 0x7a06. > > 1) In order to let the lsdc kms driver to know which chip the DC is >contained in, we add different compatible for different

Re: [PATCH v8 3/3] MAINTAINERS: add maintainers for DRM LSDC driver

2022-02-17 Thread Krzysztof Kozlowski
On 16/02/2022 19:17, Sui Jingfeng wrote: > From: suijingfeng > > Signed-off-by: suijingfeng > Signed-off-by: Sui Jingfeng <15330273...@189.cn> > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ea3e6c914384..3f5e13a6358b 1006

Re: [PATCH] drm/mode: Improve drm_mode_fb_cmd2 documentation

2022-02-17 Thread Simon Ser
drm-misc-next has changed this doc comment. Can you rebase your changes? Any any case, r-b me. [1]: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a3574119826d9a4ef807fb973cf5150c3b90da43

Re: [Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/solomon/ssd130x.c:451:18: error: incomplete definition of type 'struct dma_buf_map'

2022-02-17 Thread Javier Martinez Canillas
d6ebae3137a51b >> commit: 7ca6504c36709f35c4cc38ae6acc1c9c3d72136f [4/8] Merge remote-tracking >> branch 'drm-misc/drm-misc-next' into drm-tip >> config: mips-buildonly-randconfig-r002-20220217 >> (https://download.01.org/0day-ci/archive/20220217/202202171455.bclm1ybc-...@intel.com/config) >&

[PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-17 Thread Qiang Yu
Workstation application ANSA/META get this error dmesg: [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) This is caused by: 1. create a 256MB buffer in invisible VRAM 2. CPU map the buffer and access it causes vm_fault and try to move it to visible VRAM 3. force visible VR

Re: [PATCH v2 1/3] drm/mm: Ensure that the entry is not NULL before extracting rb_node

2022-02-17 Thread Tvrtko Ursulin
On 17/02/2022 07:50, Vivek Kasireddy wrote: While looking for next holes suitable for an allocation, although, it is highly unlikely, make sure that the DECLARE_NEXT_HOLE_ADDR macro is using a valid node before it extracts the rb_node from it. Was the need for this just a consequence of insuf

Re: [Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/solomon/ssd130x.c:451:18: error: incomplete definition of type 'struct dma_buf_map'

2022-02-17 Thread Lucas De Marchi
: 7ca6504c36709f35c4cc38ae6acc1c9c3d72136f [4/8] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip config: mips-buildonly-randconfig-r002-20220217 (https://download.01.org/0day-ci/archive/20220217/202202171455.bclm1ybc-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/ll

Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-17 Thread Christian König
Am 17.02.22 um 10:04 schrieb Qiang Yu: Workstation application ANSA/META get this error dmesg: [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) This is caused by: 1. create a 256MB buffer in invisible VRAM 2. CPU map the buffer and access it causes vm_fault and try to move

Re: [PATCH v2 3/3] drm/i915/gem: Don't try to map and fence large scanout buffers (v8)

2022-02-17 Thread Tvrtko Ursulin
On 17/02/2022 07:50, Vivek Kasireddy wrote: On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or more framebuffers/scanout buffers results in only one that is mappable/ fenceable. Therefore, pageflipping between these 2 FBs where only one is mappable/fenceable creates latencies

Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC

2022-02-17 Thread Krzysztof Kozlowski
On 06/02/2022 09:00, Andreas Kemnade wrote: > Add a binding for the Electrophoretic Display Controller found at least > in the i.MX6. > The timing subnode is directly here to avoid having display parameters > spread all over the plate. > > Supplies are organized the same way as in the fbdev driver

Re: [Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/solomon/ssd130x.c:451:18: error: incomplete definition of type 'struct dma_buf_map'

2022-02-17 Thread Lucas De Marchi
: e141e36b2871c529379f7ec7d5d6ebae3137a51b commit: 7ca6504c36709f35c4cc38ae6acc1c9c3d72136f [4/8] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip config: mips-buildonly-randconfig-r002-20220217 (https://download.01.org/0day-ci/archive/20220217/202202171455.bclm1ybc-...@intel.com/config) compi

Re: [REPOST PATCH v4 13/13] drm/msm/dsi: Add support for DSC configuration

2022-02-17 Thread Marijn Suijten
Vinod, On 2022-02-10 16:04:23, Vinod Koul wrote: > When DSC is enabled, we need to configure DSI registers accordingly and > configure the respective stream compression registers. > > Add support to calculate the register setting based on DSC params and > timing information and configure these re

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-17 Thread Mika Westerberg
Hi Mario, On Wed, Feb 16, 2022 at 10:50:31AM -0600, Limonciello, Mario wrote: > On 2/16/2022 08:44, Alex Deucher wrote: > > On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg > > wrote: > > > > > > Hi all, > > > > > > On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote: > > > > On 2

Re: [Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/solomon/ssd130x.c:451:18: error: incomplete definition of type 'struct dma_buf_map'

2022-02-17 Thread Javier Martinez Canillas
On 2/17/22 10:25, Lucas De Marchi wrote: > On Thu, Feb 17, 2022 at 10:00:42AM +0100, Javier Martinez Canillas wrote: [snip] >>> this is now called iosys_map in drm-intel... drm-tip will need a fixup >>> for the merge. >>> >> >> I thought that the drm-intel tree was only for Intel DRM drivers chan

Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-17 Thread Qiang Yu
On Thu, Feb 17, 2022 at 5:15 PM Christian König wrote: > > Am 17.02.22 um 10:04 schrieb Qiang Yu: > > Workstation application ANSA/META get this error dmesg: > > [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) > > > > This is caused by: > > 1. create a 256MB buffer in invisi

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param

2022-02-17 Thread Tvrtko Ursulin
On 16/02/2022 18:15, Vinay Belgaumkar wrote: SLPC unset param H2G only needs one parameter - the id of the param. Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits") How serious is this? Does it need backporting? If so: Cc: # v5.15+ ? Regards, Tvrtko Suggested-b

Re: [Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/solomon/ssd130x.c:451:18: error: incomplete definition of type 'struct dma_buf_map'

2022-02-17 Thread Thomas Zimmermann
Hi Am 17.02.22 um 10:25 schrieb Lucas De Marchi: [...] $ git grep "TODO: Use mapping abstraction properly" | wc -l 15 If you point me the proper way, I'll be happy to post a patch to change it. It depends what you want to do with the address. There are APIs to copy from/to. I also added a fe

[drm-intel:topic/core-for-CI 1/1] drivers/gpu/drm/i915/intel_device_info.c:236:14: error: 'INTEL_SUBPLATFORM_G12' undeclared; did you mean 'INTEL_SUBPLATFORM_G10'?

2022-02-17 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel topic/core-for-CI head: b56d8d7bad86a9badc1d1b9ea2d1730fa1d3978b commit: b56d8d7bad86a9badc1d1b9ea2d1730fa1d3978b [1/1] drm/i915: Add DG2 PCI IDs config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220217

Re: [PATCH 1/8] drm/fourcc: Add DRM_FORMAT_C[124]

2022-02-17 Thread Pekka Paalanen
On Tue, 15 Feb 2022 17:52:19 +0100 Geert Uytterhoeven wrote: > Introduce fourcc codes for color-indexed frame buffer formats with two, > four, and sixteen color, and provide a suitable mapping from bit per > pixel and depth to fourcc codes. > > As the number of bits per pixel is less than eight,

Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-17 Thread Christian König
Am 17.02.22 um 10:40 schrieb Qiang Yu: On Thu, Feb 17, 2022 at 5:15 PM Christian König wrote: Am 17.02.22 um 10:04 schrieb Qiang Yu: Workstation application ANSA/META get this error dmesg: [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) This is caused by: 1. create a 25

Re: [Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/solomon/ssd130x.c:451:18: error: incomplete definition of type 'struct dma_buf_map'

2022-02-17 Thread Javier Martinez Canillas
On 2/17/22 10:41, Thomas Zimmermann wrote: > Hi > > Am 17.02.22 um 10:25 schrieb Lucas De Marchi: > [...] >>> $ git grep "TODO: Use mapping abstraction properly" | wc -l >>> 15 >>> >>> If you point me the proper way, I'll be happy to post a patch to >>> change it. >> >> It depends what you want t

Re: [PATCH 7/8] drm/fourcc: Add DRM_FORMAT_R[124]

2022-02-17 Thread Pekka Paalanen
On Tue, 15 Feb 2022 17:52:25 +0100 Geert Uytterhoeven wrote: > Introduce fourcc codes for single-channel frame buffer formats with two, > four, and sixteen intensity levels. Traditionally, the first channel > has been called the "red" channel, but the fourcc can also be used for > other light-on

Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Pekka Paalanen
On Tue, 15 Feb 2022 17:52:26 +0100 Geert Uytterhoeven wrote: > Introduce a fourcc code for a single-channel frame buffer format with two > darkness levels. This can be used for two-level dark-on-light displays. > > As the number of bits per pixel is less than eight, this relies on > proper bloc

Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Simon Ser
Hi, On Tuesday, February 15th, 2022 at 17:52, Geert Uytterhoeven wrote: > Introduce a fourcc code for a single-channel frame buffer format with two > darkness levels. This can be used for two-level dark-on-light displays. The previous patches introduce C1 and R1. Do we really need D1? Can't we

Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-17 Thread Qiang Yu
On Thu, Feb 17, 2022 at 5:46 PM Christian König wrote: > > Am 17.02.22 um 10:40 schrieb Qiang Yu: > > On Thu, Feb 17, 2022 at 5:15 PM Christian König > > wrote: > >> Am 17.02.22 um 10:04 schrieb Qiang Yu: > >>> Workstation application ANSA/META get this error dmesg: > >>> [drm:amdgpu_gem_va_ioctl

Re: [PATCH] drm/fb: Improve drm_framebuffer.offsets documentation

2022-02-17 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH] linux/fb.h: Spelling s/palette/palette/

2022-02-17 Thread Pekka Paalanen
On Wed, 16 Feb 2022 09:39:22 +0100 Geert Uytterhoeven wrote: > Fix a misspelling of "palette" in a comment. > > Signed-off-by: Geert Uytterhoeven > --- > include/uapi/linux/fb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/fb.h b/include/uapi/lin

[PULL] drm-intel-gt-next

2022-02-17 Thread Joonas Lahtinen
Hi Dave & Daniel, Here is the first drm-intel-gt-next feature PR towards v5.18. For DG2 adds subplatform G12, missing workarounds and fixes GuC loading on ARM64. C0/D0 stepping info added for RPL-S. For uAPI enables support for simple parallel submission with execlists which was previously enabl

[PATCH 2/2] fbdev: Improve performance of sys_imageblit()

2022-02-17 Thread Thomas Zimmermann
Improve the performance of sys_imageblit() by manually unrolling the inner blitting loop and moving some invariants out. The compiler failed to do this automatically. The resulting binary code was even slower than the cfb_imageblit() helper, which uses the same algorithm, but operates on I/O memory

[PATCH 0/2] fbdev: Improve performance of fbdev console

2022-02-17 Thread Thomas Zimmermann
Optimize performance of the fbdev console for the common case of software-based clearing and image blitting. The commit descripton of each patch contains resuls os a simple microbenchmark. I also tested the full patchset's effect on the console output by printing directory listings (i7-4790, FullH

[PATCH 1/2] fbdev: Improve performance of sys_fillrect()

2022-02-17 Thread Thomas Zimmermann
Improve the performance of sys_fillrect() by using word-aligned 32/64-bit mov instructions. While the code tried to implement this, the compiler failed to create fast instructions. The resulting binary instructions were even slower than cfb_fillrect(), which uses the same algorithm, but operates on

[PULL] drm-intel-fixes

2022-02-17 Thread Tvrtko Ursulin
Hi Dave, Daniel, An assortment of fixes for -rc5, mostly display and one for the TTM backend. Contains a merge of two trivial GVT fixes as well which came via GVT pull request. Regards, Tvrtko drm-intel-fixes-2022-02-17: - GVT kerneldoc cleanup. (Randy Dunlap) - GVT Kconfig should depend on

Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-17 Thread Christian König
Am 17.02.22 um 11:13 schrieb Qiang Yu: On Thu, Feb 17, 2022 at 5:46 PM Christian König wrote: Am 17.02.22 um 10:40 schrieb Qiang Yu: On Thu, Feb 17, 2022 at 5:15 PM Christian König wrote: Am 17.02.22 um 10:04 schrieb Qiang Yu: Workstation application ANSA/META get this error dmesg: [drm:

Re: [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1

2022-02-17 Thread Geert Uytterhoeven
Hi Pekka, On Thu, Feb 17, 2022 at 11:10 AM Pekka Paalanen wrote: > On Tue, 15 Feb 2022 17:52:26 +0100 > Geert Uytterhoeven wrote: > > Introduce a fourcc code for a single-channel frame buffer format with two > > darkness levels. This can be used for two-level dark-on-light displays. > > > > As

[PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-17 Thread Jiawei Gu
Add device pointer so scheduler's printing can use DRM_DEV_ERROR() instead, which makes life easier under multiple GPU scenario. v2: amend all calls of drm_sched_init() Signed-off-by: Jiawei Gu --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- drivers/gpu/drm/etnaviv/etnaviv_sched.c | 2

Re: [Freedreno] [REPOST PATCH v4 13/13] drm/msm/dsi: Add support for DSC configuration

2022-02-17 Thread Vinod Koul
Hi Marijn, On 17-02-22, 10:27, Marijn Suijten wrote: > Vinod, > > On 2022-02-10 16:04:23, Vinod Koul wrote: > > When DSC is enabled, we need to configure DSI registers accordingly and > > configure the respective stream compression registers. > > > > Add support to calculate the register setting

[PATCH v9 0/4] drm/lsdc: add drm driver for loongson display controller

2022-02-17 Thread Sui Jingfeng
There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge chip, it is a PCI device in those chips. It has two display pipes but with only one hardware cursor. Each way has a DVO interface which provide RGB888 signals, vertical & horizontal synchronisations, data enable and the pi

[PATCH v9 1/4] drm/lsdc: add drm driver for loongson display controller

2022-02-17 Thread Sui Jingfeng
From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge chip, it is a PCI device in those chips. It has two display pipes but with only one hardware cursor. Each way has a DVO interface which provide RGB888 signals, vertical & horizontal synchronisations, da

[PATCH v9 3/4] Documentation/dt: Add descriptions for loongson display controller

2022-02-17 Thread Sui Jingfeng
From: suijingfeng Add DT documentation for loongson display controller found in LS2K1000, LS2K0500, LS7A1000 and LS7A2000. v2: DT binding docs and includes should be a separate patch, fix a warnning because of that. Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273...@189.cn

[PATCH v9 4/4] MAINTAINERS: add maintainers for DRM LSDC driver

2022-02-17 Thread Sui Jingfeng
From: suijingfeng v2: Fix warnnings reported by checkpatch script Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273...@189.cn> --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea3e6c914384..abf7a2d6c94d 100644 --- a/MAI

[PATCH v9 2/4] MIPS: Loongson64: dts: update the display controller device node

2022-02-17 Thread Sui Jingfeng
From: suijingfeng The display controller is a pci device, its PCI vendor id is 0x0014 its PCI device id is 0x7a06. 1) In order to let the driver to know chip which the DC is contained in, the compatible string is updated according to the chip's name. 2) Add display controller device node for

Re: [PATCH v9 3/4] Documentation/dt: Add descriptions for loongson display controller

2022-02-17 Thread Krzysztof Kozlowski
On 17/02/2022 11:55, Sui Jingfeng wrote: > From: suijingfeng > > Add DT documentation for loongson display controller found in > LS2K1000, LS2K0500, LS7A1000 and LS7A2000. > > v2: DT binding docs and includes should be a separate patch, > fix a warnning because of that. > > Signed-off-by: s

Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-17 Thread Qiang Yu
On Thu, Feb 17, 2022 at 6:39 PM Christian König wrote: > > > > Am 17.02.22 um 11:13 schrieb Qiang Yu: > > On Thu, Feb 17, 2022 at 5:46 PM Christian König > > wrote: > >> Am 17.02.22 um 10:40 schrieb Qiang Yu: > >>> On Thu, Feb 17, 2022 at 5:15 PM Christian König > >>> wrote: > Am 17.02.22 u

Re: [PATCH 2/2] fbdev: Improve performance of sys_imageblit()

2022-02-17 Thread Gerd Hoffmann
> - for (j = k; j--; ) { > - shift -= ppw; > - end_mask = tab[(*src >> shift) & bit_mask]; > - *dst++ = (end_mask & eorx) ^ bgx; > - if (!shift) { > - shift = 8; > -

Re: [PATCH v8 2/3] MIPS: Loongson64: dts: update the display controller device node

2022-02-17 Thread Sui Jingfeng
On 2022/2/17 16:42, Krzysztof Kozlowski wrote: .../boot/dts/loongson/loongson64-2k1000.dtsi | 8 ++ arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 7 +- 4 files changed, 140 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/loongson/loongson

Re: [Freedreno] [PATCH v3 12/13] drm/msm/dsi: Add support for DSC configuration

2022-02-17 Thread Vinod Koul
Hi Marijn, On 11-12-21, 01:03, Marijn Suijten wrote: > > +static int dsi_dsc_update_pic_dim(struct msm_display_dsc_config *dsc, > > + int pic_width, int pic_height) > > This function - adopted from downstream - does not seem to perform a > whole lot, especially withou

[PULL] drm-misc-fixes

2022-02-17 Thread Thomas Zimmermann
Hi Dave and Daniel, here's drm-misc-fixes for this week. Best regards Thomas drm-misc-fixes-2022-02-17: * drm/cma-helper: Set VM_DONTEXPAND * drm/atomic: Fix error handling in drm_atomic_set_mode_for_crtc() The following changes since commit 9da1e9ab82c92d0e89fe44cad2cd7c2d18d64070: drm/roc

Re: [PATCH v9 3/4] Documentation/dt: Add descriptions for loongson display controller

2022-02-17 Thread Sui Jingfeng
On 2022/2/17 18:57, Krzysztof Kozlowski wrote: On 17/02/2022 11:55, Sui Jingfeng wrote: From: suijingfeng Add DT documentation for loongson display controller found in LS2K1000, LS2K0500, LS7A1000 and LS7A2000. v2: DT binding docs and includes should be a separate patch, fix a warnning

Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC

2022-02-17 Thread Andreas Kemnade
On Thu, 17 Feb 2022 10:21:15 +0100 Krzysztof Kozlowski wrote: > On 06/02/2022 09:00, Andreas Kemnade wrote: > > Add a binding for the Electrophoretic Display Controller found at least > > in the i.MX6. > > The timing subnode is directly here to avoid having display parameters > > spread all over

Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC

2022-02-17 Thread Krzysztof Kozlowski
On 17/02/2022 12:31, Andreas Kemnade wrote: > On Thu, 17 Feb 2022 10:21:15 +0100 > Krzysztof Kozlowski wrote: > >> On 06/02/2022 09:00, Andreas Kemnade wrote: >>> Add a binding for the Electrophoretic Display Controller found at least >>> in the i.MX6. >>> The timing subnode is directly here to a

Re: [PATCH] drm/i915: Clarify vma lifetime

2022-02-17 Thread Matthew Auld
On 10/02/2022 07:19, Thomas Hellström wrote: It's unclear what reference the initial vma kref refernce refers to. A vma can have multiple weak references, the object vma list, the vm's bound list and the GT's closed_list, and the initial vma reference can be put from lookups of all these lists.

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Andy Yan
Hi Sascha: On 2/17/22 16:29, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonsta

Re: [PATCH 2/2] fbdev: Improve performance of sys_imageblit()

2022-02-17 Thread Thomas Zimmermann
Hi Am 17.02.22 um 12:05 schrieb Gerd Hoffmann: - for (j = k; j--; ) { - shift -= ppw; - end_mask = tab[(*src >> shift) & bit_mask]; - *dst++ = (end_mask & eorx) ^ bgx; - if (!shift) { -

Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-17 Thread Christian König
Am 17.02.22 um 11:58 schrieb Qiang Yu: On Thu, Feb 17, 2022 at 6:39 PM Christian König wrote: Am 17.02.22 um 11:13 schrieb Qiang Yu: On Thu, Feb 17, 2022 at 5:46 PM Christian König wrote: Am 17.02.22 um 10:40 schrieb Qiang Yu: On Thu, Feb 17, 2022 at 5:15 PM Christian König wrote: Am 17

Re: [PATCH v6 09/23] drm/rockchip: dw_hdmi: Add support for hclk

2022-02-17 Thread Dmitry Osipenko
17.02.2022 11:29, Sascha Hauer пишет: > The rk3568 HDMI has an additional clock that needs to be enabled for the > HDMI controller to work. The purpose of that clock is not clear. It is > named "hclk" in the downstream driver, so use the same name. Have you checked that DSI works without the enabl

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-02-17 Thread Tomi Valkeinen
Hi, On 19/01/2022 12:23, Ivaylo Dimitrov wrote: On devices with DMM, all allocations are done through either DMM or TILER. DMM/TILER being a limited resource means that such allocations will start to fail before actual free memory is exhausted. What is even worse is that with time DMM/TILER spac

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix for PHY_MISC_TC1 offset

2022-02-17 Thread Ville Syrjälä
On Wed, Feb 16, 2022 at 05:01:35PM +0200, Ville Syrjälä wrote: > On Wed, Feb 16, 2022 at 02:11:54PM +, Hogander, Jouni wrote: > > On Wed, 2022-02-16 at 12:07 +0200, Ville Syrjälä wrote: > > > On Wed, Feb 16, 2022 at 09:36:02AM +, Hogander, Jouni wrote: > > > > On Wed, 2022-02-16 at 10:50 +0

Re: [PATCH 0/3] drm: omapdrm: Fix excessive GEM buffers DMM/CMA usage

2022-02-17 Thread Tomi Valkeinen
Hi Ivaylo, On 19/01/2022 12:23, Ivaylo Dimitrov wrote: This patch series fixes excessive DMM or CMA usage of GEM buffers leading to various runtime allocation failures. The series enables daily usage of devices without exausting limited resources like CMA or DMM space if GPU rendering is needed.

[Bug 214621] WARNING: CPU: 3 PID: 521 at drivers/gpu/drm/ttm/ttm_bo.c:409 ttm_bo_release+0xb64/0xe40 [ttm]

2022-02-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214621 Kakha (ka...@soft.ge) changed: What|Removed |Added CC||ka...@soft.ge --- Comment #21 fro

Re: Report 1 in ext4 and journal based on v5.17-rc1

2022-02-17 Thread Matthew Wilcox
On Thu, Feb 17, 2022 at 08:10:03PM +0900, Byungchul Park wrote: > [7.009608] === > [7.009613] DEPT: Circular dependency has been detected. > [7.009614] 5.17.0-rc1-00014-g8a599299c0cb-dirty #30 Tainted: GW > [7.009616] -

Re: [PATCH v6 02/23] drm/rockchip: dw_hdmi: rename vpll clock to reference clock

2022-02-17 Thread Sascha Hauer
On Thu, Feb 17, 2022 at 04:20:15PM +0300, Dmitry Osipenko wrote: > 17.02.2022 11:29, Sascha Hauer пишет: > > + hdmi->ref_clk = devm_clk_get(hdmi->dev, "ref"); > > + if (PTR_ERR(hdmi->ref_clk) == -ENOENT) > > + hdmi->ref_clk = devm_clk_get(hdmi->dev, "vpll"); > > + > > + if (PTR_ERR(

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Sascha Hauer
Hi Andy, Please trim the context in your answers to the relevant parts, it makes it easier to find the things you said. On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > Hi Sascha: > > > + > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->encoder_mask) > > { > > +

[PATCH 0/9] drm/i915: use ref_tracker library for tracking wakerefs

2022-02-17 Thread Andrzej Hajda
Hi, Appearance of ref_tracker library allows to drop custom solution for wakeref tracking used in i915 and reuse the library. For this few adjustements has been made to ref_tracker, details in patches. I hope changes are OK for original author. The patchset has been rebased on top of drm-tip to a

[PATCH 1/9] lib/ref_tracker: add unlocked leak print helper

2022-02-17 Thread Andrzej Hajda
To have reliable detection of leaks, caller must be able to check under the same lock both: tracked counter and the leaks. dir.lock is natural candidate for such lock and unlocked print helper can be called with this lock taken. As a bonus we can reuse this helper in ref_tracker_dir_exit. Signed-o

[PATCH 2/9] lib/ref_tracker: compact stacktraces before printing

2022-02-17 Thread Andrzej Hajda
In cases references are taken alternately on multiple exec paths leak report can grow substantially, sorting and grouping leaks by stack_handle allows to compact it. Signed-off-by: Andrzej Hajda Reviewed-by: Chris Wilson --- lib/ref_tracker.c | 35 +++ 1 file cha

[PATCH 3/9] lib/ref_tracker: __ref_tracker_dir_print improve printing

2022-02-17 Thread Andrzej Hajda
To improve readibility of ref_tracker printing following changes have been performed: - added display name for ref_tracker_dir, - stack trace is printed indented, in the same printk call, - total number of references is printed every time, - print info about dropped references. Signed-off-by: Andr

  1   2   3   4   >