Re: [RFC v4 09/11] drm/amdgpu: Move in_gpu_reset into reset_domain

2022-02-09 Thread Christian König
Am 09.02.22 um 01:23 schrieb Andrey Grodzovsky: We should have a single instance per entrire reset domain. Signed-off-by: Andrey Grodzovsky Suggested-by: Lijo Lazar Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 ++- drivers/gpu/drm/amd/amdgpu/amdg

Re: [RFC v4 10/11] drm/amdgpu: Rework amdgpu_device_lock_adev

2022-02-09 Thread Christian König
Am 09.02.22 um 01:23 schrieb Andrey Grodzovsky: This functions needs to be split into 2 parts where one is called only once for locking single instance of reset_domain's sem and reset flag and the other part which handles MP1 states should still be called for each device in XGMI hive. Signed-off

Re: [RFC v4 11/11] Revert 'drm/amdgpu: annotate a false positive recursive locking'

2022-02-09 Thread Christian König
Am 09.02.22 um 01:23 schrieb Andrey Grodzovsky: Since we have a single instance of reset semaphore which we lock only once even for XGMI hive we don't need the nested locking hint anymore. Signed-off-by: Andrey Grodzovsky Oh, yes please :) Reviewed-by: Christian König --- drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state

2022-02-09 Thread Tvrtko Ursulin
On 08/02/2022 18:53, John Harrison wrote: On 2/8/2022 01:39, Tvrtko Ursulin wrote: On 08/02/2022 02:07, john.c.harri...@intel.com wrote: From: John Harrison A flag query helper was actually writing to the flags word rather than just reading. Fix that. Also update the function's comment as

Re: [PATCH v7 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-09 Thread Tvrtko Ursulin
On 09/02/2022 06:30, Michael Cheng wrote: Add arm64 support for drm_clflush_virt_range. dcache_clean_inval_poc performs a flush by first performing a clean, follow by an invalidation operation. v2 (Michael Cheng): Use correct macro for cleaning and invalidation the dcache.

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Fri, Feb 04, 2022 at 12:41:37AM +0800, Sui Jingfeng wrote: > > > +static int lsdc_primary_plane_atomic_check(struct drm_plane *plane, > > > +struct drm_atomic_state *state) > > > +{ > > > + struct drm_device *ddev = plane->dev; > > > + struct lsdc_device *ldev

[PATCH] gpu: drm: msm: use div64_u64() instead of do_div()

2022-02-09 Thread Qing Wang
From: Wang Qing do_div() does a 64-by-32 division. When the divisor is u64, do_div() truncates it to 32 bits, this means it can test non-zero and be truncated to zero for division. fix do_div.cocci warning: do_div() does a 64-by-32 division, please consider using div64_u64 instead. Signed-off-b

Re: [PATCH 5/5] spi: make remove callback a void function

2022-02-09 Thread Mark Brown
On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-König wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no va

[PATCH] video: fbdev: replace snprintf with sysfs_emit

2022-02-09 Thread davidcomponentone
From: Yang Guang coccinelle report: ./drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c: 202:8-16: WARNING: use scnprintf or sprintf ./drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c: 172:8-16: WARNING: use scnprintf or sprintf Use sysfs_emit instead of scnprintf

Re: [syzbot] WARNING in component_del

2022-02-09 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+60df062e1c41940ca...@syzkaller.appspotmail.com Tested on: commit: 555f3d7b Merge tag '5.17-rc3-ksmbd-server-fixes' of gi.. git tree: upstream kernel config: h

[PATCH] drm/bridge: anx7625: Fix overflow issue on reading EDID

2022-02-09 Thread Pin-Yen Lin
The length of EDID block can be longer than 256 bytes, so we should use `int` instead of `u8` for the `edid_pos` variable. Signed-off-by: Pin-Yen Lin --- drivers/gpu/drm/bridge/analogix/anx7625.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/analog

drm/ttm: moving the LRU into the resource

2022-02-09 Thread Christian König
Hi guys, so hopefully the last round for this set. It fixes both a long outstanding problem with TTM and resource allocation as well as Bas's new performance problem with RADV. Please review and comment. Thanks, Christian.

[PATCH 3/9] drm/ttm: add resource iterator v2

2022-02-09 Thread Christian König
Instead of duplicating that at different places add an iterator over all the resources in a resource manager. v2: add lockdep annotation and kerneldoc Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 41 ++-

[PATCH 1/9] drm/ttm: add common accounting to the resource mgr v3

2022-02-09 Thread Christian König
It makes sense to have this in the common manager for debugging and accounting of how much resources are used. v2: cleanup kerneldoc a bit v3: drop the atomic, update counter under lock instead Signed-off-by: Christian König Reviewed-by: Huang Rui (v1) Tested-by: Bas Nieuwenhuizen --- drivers

[PATCH 2/9] drm/ttm: move the LRU into resource handling v3

2022-02-09 Thread Christian König
This way we finally fix the problem that new resource are not immediately evict-able after allocation. That has caused numerous problems including OOM on GDS handling and not being able to use TTM as general resource manager. v2: stop assuming in ttm_resource_fini that res->bo is still valid. v3:

[PATCH 4/9] drm/radeon: remove resource accounting

2022-02-09 Thread Christian König
Use the one provided by TTM instead. Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/radeon/radeon.h| 2 -- drivers/gpu/drm/radeon/radeon_kms.c| 7 -- drivers/gpu/drm/radeon/radeon_object.c | 30 +++--- drivers/gpu/drm/radeon

[PATCH 5/9] drm/amdgpu: remove GTT accounting

2022-02-09 Thread Christian König
This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 49 + drivers/gpu/drm/amd/amd

[PATCH 6/9] drm/amdgpu: remove VRAM accounting

2022-02-09 Thread Christian König
This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH 7/9] drm/amdgpu: drop amdgpu_gtt_node v2

2022-02-09 Thread Christian König
We have the BO pointer in the base structure now as well. v2: add lockdep and kerneldoc Signed-off-by: Christian König Reviewed-by: Daniel Vetter Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 49 - include/drm/ttm/ttm_resource.h

[PATCH 8/9] drm/ttm: allow bulk moves for all domains

2022-02-09 Thread Christian König
Not just TT and VRAM. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Tested-by: Bas Nieuwenhuizen --- drivers/gpu/drm/ttm/ttm_resource.c | 52 +- include/drm/ttm/ttm_device.h | 2 -- include/drm/ttm/ttm_resource.h | 4 +-- 3 files changed, 17

[PATCH 9/9] drm/ttm: rework bulk move handling v2

2022-02-09 Thread Christian König
Instead of providing the bulk move structure for each LRU update set this as property of the BO. This should avoid costly bulk move rebuilds with some games under RADV. v2: some name polishing, add a few more kerneldoc words. v3: add some lockdep Signed-off-by: Christian König Tested-by: Bas Nie

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Fri, Feb 04, 2022 at 12:29:39AM +0800, Sui Jingfeng wrote: > > > +static int lsdc_modeset = 1; > > > +MODULE_PARM_DESC(modeset, "Enable/disable CMA-based KMS(1 = > > > enabled(default), 0 = disabled)"); > > > +module_param_named(modeset, lsdc_modeset, int, 0644); > > > + > > > +static int lsdc_

[PATCH] fbcon: use min() to make code cleaner

2022-02-09 Thread cgel . zte
From: Changcheng Deng Use min() in order to make code cleaner. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c in

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: > > > +/* Get the simple EDID data from the device tree > > > + * the length must be EDID_LENGTH, since it is simple. > > > + * > > > + * @np: device node contain edid data > > > + * @edid_data: where the edid data to store to > > > + */

[PATCH v5 0/5] Add GPU for RK356x SoCs

2022-02-09 Thread Michael Riesch
Hi all, This series seems to be abandoned so I would like to pick it up in order to bring the GPU support for the RK356x mainline. The series (in conjunction with the VOP2/HDMI TX patches v4 [0]) has been tested successfully on a RK3568 EVB1 with weston and glmark2-es2-wayland. It should be note

[PATCH v5 3/5] arm64: dts: rockchip: add cooling map and trip points for gpu to rk356x

2022-02-09 Thread Michael Riesch
From: Alex Bee RK356x SoCs have a second thermal sensor for the GPU. This adds the cooling map and trip points for it to make use of its contribution as a cooling device. Signed-off-by: Alex Bee Signed-off-by: Michael Riesch --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 27 ++

[PATCH v5 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu

2022-02-09 Thread Michael Riesch
From: Alex Bee The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. Reflect this in the SoC specific part of the binding. Signed-off-by: Alex Bee [move the changes to the SoC section] Signed-off-by: Michael Riesch --- .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 +

[PATCH v5 2/5] arm64: dts: rockchip: add gpu node to rk356x

2022-02-09 Thread Michael Riesch
From: Ezequiel Garcia Rockchip SoCs RK3566 and RK3568 have a Mali Gondul core which is based on the Bifrost architecture. It has one shader core and two execution engines. Quoting the datasheet: Mali-G52 1-Core-2EE * Support 1600Mpix/s fill rate when 800MHz clock frequency * Support 38.4GLOPs w

[PATCH v5 5/5] arm64: dts: rockchip: enable the gpu on rk3568-evb1-v10

2022-02-09 Thread Michael Riesch
Enable the GPU core on the Rockchip RK3568 EVB1. Signed-off-by: Michael Riesch --- arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt

[PATCH v5 4/5] arm64: dts: rockchip: enable the gpu on quartz64-a

2022-02-09 Thread Michael Riesch
From: Ezequiel Garcia Enable the GPU core on the Pine64 Quartz64 Model A. Signed-off-by: Ezequiel Garcia Signed-off-by: Alex Bee Signed-off-by: Michael Riesch --- arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/r

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Thu, Feb 03, 2022 at 11:47:16PM +0800, Sui Jingfeng wrote: > On 2022/2/3 16:58, Maxime Ripard wrote: > > > diff --git a/drivers/gpu/drm/lsdc/Kconfig b/drivers/gpu/drm/lsdc/Kconfig > > > new file mode 100644 > > > index ..7ed1b0fdbe1b > > > --- /dev/null > > > +++ b/drivers/gpu/drm/ls

[PATCH v3 0/4] Add support for the eDP panel on sc7280 CRD

2022-02-09 Thread Sankeerth Billakanti
Add support for the eDP panel on sc7280 CRD platform. The eDP panel does not need HPD line for connect disconnect. So, this series will report eDP as always connected. The driver needs to register for IRQ_HPD only for eDP. This support will be added later. These changes are dependent on the follow

[PATCH v3 2/4] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-09 Thread Sankeerth Billakanti
Enable the eDP display panel support without HPD on sc7280 platform. Signed-off-by: Sankeerth Billakanti --- Changes in v3: - Sort the nodes alphabetically - Use - instead of _ as node names - Place the backlight and panel nodes under root - Change the name of edp_out to mdss_edp_out -

[PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

2022-02-09 Thread Sankeerth Billakanti
Add support for the 14" sharp,lq140m1jw46 eDP panel. Signed-off-by: Sankeerth Billakanti --- Changes in v3: None drivers/gpu/drm/panel/panel-edp.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/p

[PATCH v3 4/4] drm/msm/dp: Add driver support to utilize drm panel

2022-02-09 Thread Sankeerth Billakanti
Add support in the DP driver to utilize the custom eDP panels from drm/panels. An eDP panel is always connected to the platform. So, the eDP connector can be reported as always connected. The display mode will be sourced from the panel. The panel mode will be set after the link training is complet

[PATCH v3 1/4] dt-bindings: display: simple: Add sharp LQ140M1JW46 panel

2022-02-09 Thread Sankeerth Billakanti
Add support for sharp LQ140M1JW46 display panel. It is a 14" eDP panel with 1920x1080 display resolution. Signed-off-by: Sankeerth Billakanti --- Changes in v3: None Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Docume

[PATCH v3 1/7] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()

2022-02-09 Thread Javier Martinez Canillas
Pull the per-line conversion logic into a separate helper function. This will allow to do line-by-line conversion in other helpers that convert to a gray8 format. Suggested-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Add a drm_fb_xrgb_to_gray8_line()

[PATCH v3 0/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Javier Martinez Canillas
This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. Using the DRM fb emulation, all the tests from Geert Uytterhoeven's fbtest (https://git.kernel.org/pub/scm/linux/kernel/git/geert/fbtest.git) passes.

[PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Javier Martinez Canillas
This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED display controllers. It's only the core part of the driver and a bus specific driver is needed for each transport interface supported by the display controllers. Signed-off-by: Javier Martinez Canillas --- Changes in

[PATCH v3 2/7] drm/format-helper: Add drm_fb_{xrgb8888, gray8}_to_mono_reversed()

2022-02-09 Thread Javier Martinez Canillas
Add support to convert XR24 and 8-bit grayscale to reversed monochrome for drivers that control monochromatic panels, that only have 1 bit per pixel. The drm_fb_gray8_to_mono_reversed() helper was based on the function that does the same in the drivers/gpu/drm/tiny/repaper.c driver. Signed-off-by

[PATCH v3 4/7] drm/solomon: Add SSD130X OLED displays I2C support

2022-02-09 Thread Javier Martinez Canillas
The ssd130x driver only provides the core support for these devices but it does not have any bus transport logic. Add a driver to interface over I2C. Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Add a separate driver for SSD130X chips I2C support (Andy Shevchenko) drivers/gpu/d

Re: [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-09 Thread Maxime Ripard
Hi Noralf, On Tue, Feb 08, 2022 at 01:16:44PM +0100, Noralf Trønnes wrote: > Den 08.02.2022 00.20, skrev Rob Herring: > > On Thu, Jan 27, 2022 at 10:37:22AM +0100, Maxime Ripard wrote: > >> Hi, > >> > >> On Tue, Jan 25, 2022 at 06:56:58PM +0100, Noralf Trønnes wrote: > >>> Add binding for MIPI DBI

Re: [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote: >> > #ifdef CONFIG_DRM_I915_GVT >> > + >> > +#define D_BDW (1 << 0) >> > +#define D_SKL (1 << 1) >> > +#define D_KBL (1 << 2) >> > +#define D_BXT (1 << 3) >> > +#define D_CFL

Re: [PATCH v2 6/8] drm/i915/dp: add 128b/132b support to link status checks

2022-02-09 Thread Jani Nikula
On Tue, 08 Feb 2022, Ville Syrjälä wrote: > On Thu, Feb 03, 2022 at 11:03:55AM +0200, Jani Nikula wrote: >> Abstract link status check to a function that takes 128b/132b and 8b/10b >> into account, and use it. Also dump link status on failures. >> >> Cc: Uma Shankar >> Cc: Ville Syrjälä >> Sign

[PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support

2022-02-09 Thread Javier Martinez Canillas
The ssd130x driver only provides the core support for these devices but it does not have any bus transport logic. Add a driver to interface over SPI. Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Add a separate driver for SSD130X chips SPI support (Andy Shevchenko) drivers/gpu/d

[PATCH v3 6/7] MAINTAINERS: Add entry for Solomon SSD130X OLED displays DRM driver

2022-02-09 Thread Javier Martinez Canillas
To make sure that tools like the get_maintainer.pl script will suggest to Cc me if patches are posted for this driver. Also include the Device Tree binding for the old ssd1307fb fbdev driver since the new DRM driver was made compatible with the existing binding. Signed-off-by: Javier Martinez Can

[PATCH v3 7/7] dt-bindings: display: ssd1307fb: Add myself as binding co-maintainer

2022-02-09 Thread Javier Martinez Canillas
The ssd130x DRM driver also makes use of this Device Tree binding to allow existing users of the fbdev driver to migrate without the need to change their Device Trees. Add myself as another maintainer of the binding, to make sure that I will be on Cc when patches are proposed for it. Suggested-by

Re: [PATCH v2 6/8] drm/i915/dp: add 128b/132b support to link status checks

2022-02-09 Thread Ville Syrjälä
On Wed, Feb 09, 2022 at 11:09:41AM +0200, Jani Nikula wrote: > On Tue, 08 Feb 2022, Ville Syrjälä wrote: > > On Thu, Feb 03, 2022 at 11:03:55AM +0200, Jani Nikula wrote: > >> Abstract link status check to a function that takes 128b/132b and 8b/10b > >> into account, and use it. Also dump link stat

[PATCH 1/2] drm/atomic: Don't pollute crtc_state->mode_blob with error pointers

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä Make sure we don't assign an error pointer to crtc_state->mode_blob as that will break all kinds of places that assume either NULL or a valid pointer (eg. drm_property_blob_put()). Reported-by: fuyufan Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic_uapi.c | 14

[PATCH 2/2] drm/modes: Fix drm_mode_copy() docs

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä There is no object id in drm_display_mode anymore. Remove stale comments to the contrary. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes

Re: [PATCH v2 0/8] drm/dp, drm/i915: 128b/132b updates

2022-02-09 Thread Jani Nikula
On Thu, 03 Feb 2022, Jani Nikula wrote: > v2 of https://patchwork.freedesktop.org/series/99324/ > > BR, > Jani. > > Jani Nikula (8): > drm/dp: add drm_dp_128b132b_read_aux_rd_interval() > drm/dp: add 128b/132b link status helpers from DP 2.0 E11 > drm/dp: add some new DPCD macros from DP 2.0

Re: [PATCH] lima: avoid error task dump attempt when not enabled

2022-02-09 Thread Javier Martinez Canillas
Hello Erico, On 2/5/22 19:59, Erico Nunes wrote: > Currently when users try to run an application with lima and that hits > an issue such as a timeout, a message saying "fail to save task state" > and "error task list is full" is shown in dmesg. > > The error task dump is a debug feature disabled

[PATCH v2] drm/lima: avoid error task dump attempt when not enabled

2022-02-09 Thread Erico Nunes
Currently when users try to run an application with lima and that hits an issue such as a timeout, a message saying "fail to save task state" and "error task list is full" is shown in dmesg. The error task dump is a debug feature disabled by default, so the error task list is usually not going to

Re: [PATCH 6/9] drm/amdgpu: remove VRAM accounting

2022-02-09 Thread Matthew Auld
On Wed, 9 Feb 2022 at 08:41, Christian König wrote: > > This is provided by TTM now. > > Also switch man->size to bytes instead of pages and fix the double > printing of size and usage in debugfs. > > Signed-off-by: Christian König > Tested-by: Bas Nieuwenhuizen > --- > drivers/gpu/drm/amd/amdg

[PATCH v5 03/23] drm/rockchip: dw_hdmi: rename vpll clock to reference clock

2022-02-09 Thread Sascha Hauer
"vpll" is a misnomer. A clock input to a device should be named after the usage in the device, not after the clock that drives it. On the rk3568 the same clock is driven by the HPLL. To fix that, this patch renames the vpll clock to ref clock. The clock name "vpll" is left for compatibility to old

[PATCH v5 00/23] drm/rockchip: RK356x VOP2 support

2022-02-09 Thread Sascha Hauer
This is v5 of adding RK356x VOP2 support. I've dropped the patches that Heiko already applied, for testing either apply to linux-next or pick the missing clk patches from v4. I consider this series being ready for primetime now. One problem might be patch 1 [drm/encoder: Add of_graph port to struc

[PATCH v5 10/23] drm/rockchip: dw_hdmi: Add support for hclk

2022-02-09 Thread Sascha Hauer
The rk3568 HDMI has an additional clock that needs to be enabled for the HDMI controller to work. The purpose of that clock is not clear. It is named "hclk" in the downstream driver, so use the same name. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 18 ++

[PATCH v5 05/23] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref'

2022-02-09 Thread Sascha Hauer
The reference clock for the HDMI controller has been renamed to 'ref', the previous 'vpll' name is only left for compatibility in the driver. Rename the clock to the new name. Signed-off-by: Sascha Hauer --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v5 02/23] drm/rockchip: dw_hdmi: Do not leave clock enabled in error case

2022-02-09 Thread Sascha Hauer
The driver returns an error when devm_phy_optional_get() fails leaving the previously enabled clock turned on. Change order and enable the clock only after the phy has been acquired. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 14 +++--- 1 file changed,

[PATCH v5 06/23] drm/rockchip: dw_hdmi: add rk3568 support

2022-02-09 Thread Sascha Hauer
Add a new dw_hdmi_plat_data struct and new compatible for rk3568. Signed-off-by: Benjamin Gaignard Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 31 + 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v5 16/23] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional

2022-02-09 Thread Sascha Hauer
None of the upstream device tree files has a "unwedge" pinctrl specified. Make it optional. Signed-off-by: Sascha Hauer Acked-by: Rob Herring --- Notes: Changes since v4: - Add Robs Ack .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 1 + 1 file changed, 1 insertion

[PATCH v5 21/23] drm/rockchip: Make VOP driver optional

2022-02-09 Thread Sascha Hauer
With upcoming VOP2 support VOP won't be the only choice anymore, so make the VOP driver optional. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/Kconfig| 8 drivers/gpu/drm/rockchip/Makefile | 3 ++- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- 3 f

[PATCH v5 07/23] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI

2022-02-09 Thread Sascha Hauer
From: Benjamin Gaignard Define a new compatible for rk3568 HDMI. This version of HDMI hardware block needs two new clocks hclk_vio and hclk to provide phy reference clocks. Signed-off-by: Benjamin Gaignard Reviewed-by: Rob Herring Signed-off-by: Sascha Hauer --- .../devicetree/bindings/displ

[PATCH v5 17/23] arm64: dts: rockchip: rk356x: Add VOP2 nodes

2022-02-09 Thread Sascha Hauer
The VOP2 is the display output controller on the RK3568. Add the node for it to the dtsi file along with the required display-subsystem node and the iommu node. Signed-off-by: Sascha Hauer Acked-by: Rob Herring --- Notes: Changes since v4: - Add Robs Ack Changes since v3: -

[PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-09 Thread Sascha Hauer
This enabled the VOP2 display controller along with hdmi and the required port routes which is enough to get a picture out of the hdmi port of the board. Signed-off-by: Sascha Hauer --- Notes: Changes since v4: - Sort nodes alphabetically Changes since v3: - Fix HDMI connect

[PATCH v5 04/23] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name

2022-02-09 Thread Sascha Hauer
"vpll" is a misnomer. A clock input to a device should be named after the usage in the device, not after the clock that drives it. On the rk3568 the same clock is driven by the HPLL. This patch adds "ref" as a new alternative clock name for "vpll" Signed-off-by: Sascha Hauer Acked-by: Rob Herring

[PATCH v5 01/23] drm/encoder: Add of_graph port to struct drm_encoder

2022-02-09 Thread Sascha Hauer
Add a device node to drm_encoder which corresponds with the port node in the DT description of the encoder. This allows drivers to find the of_graph link between a crtc and an encoder. Signed-off-by: Sascha Hauer --- include/drm/drm_encoder.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH v5 20/23] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a

2022-02-09 Thread Sascha Hauer
From: Michael Riesch Enable the RK356x Video Output Processor (VOP) 2 on the Pine64 Quartz64 Model A. Signed-off-by: Michael Riesch Signed-off-by: Sascha Hauer --- Notes: Changes since v4: - Sort nodes alphabetically Changes since v3: - Fix HDMI connector type .../boot/

[PATCH v5 11/23] dt-bindings: display: rockchip: dw-hdmi: Add additional clock

2022-02-09 Thread Sascha Hauer
The rk3568 HDMI has an additional clock that needs to be enabled for the HDMI controller to work. The purpose of that clock is not clear. It is named "hclk" in the downstream driver, so use the same name. Signed-off-by: Sascha Hauer Acked-by: Rob Herring --- Notes: Changes since v4: - A

[PATCH v5 15/23] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz

2022-02-09 Thread Sascha Hauer
From: Nickey Yang add 594Mhz configuration parameters in rockchip_phy_config Signed-off-by: Nickey Yang Signed-off-by: Sascha Hauer --- Notes: Changes since v3: - new patch drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/dr

[PATCH v5 12/23] drm/rockchip: dw_hdmi: Use auto-generated tables

2022-02-09 Thread Sascha Hauer
From: Douglas Anderson The previous tables for mpll_cfg and curr_ctrl were created using the 20-pages of example settings provided by the PHY vendor. Those example settings weren't particularly dense, so there were places where we were guessing what the settings would be for 10-bit and 12-bit (n

[PATCH v5 22/23] drm: rockchip: Add VOP2 driver

2022-02-09 Thread Sascha Hauer
From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonstandard DRM properties have been removed - dropped str

[PATCH v5 14/23] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always

2022-02-09 Thread Sascha Hauer
From: Douglas Anderson Jitter was improved by lowering the MPLL bandwidth to account for high frequency noise in the rk3288 PLL. In each case MPLL bandwidth was lowered only enough to get us a comfortable margin. We believe that lowering the bandwidth like this is safe given sufficient testing.

[PATCH v5 08/23] drm/rockchip: dw_hdmi: add regulator support

2022-02-09 Thread Sascha Hauer
The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed for the HDMI port. add support for these to the driver for boards which have them supplied by switchable regulators. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 41 +++-- 1

[PATCH v5 23/23] dt-bindings: display: rockchip: Add binding for VOP2

2022-02-09 Thread Sascha Hauer
The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. The binding differs slightly from the existing VOP binding, so add a new binding file for it. Signed-off-by: Sascha Hauer --- Notes: Changes since v4: - Fix clk names in example - Drop unnecessary assigned-clocks

[PATCH v5 18/23] arm64: dts: rockchip: rk356x: Add HDMI nodes

2022-02-09 Thread Sascha Hauer
Add support for the HDMI port found on RK3568. Signed-off-by: Sascha Hauer --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 37 +++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dts

[PATCH v5 13/23] drm/rockchip: dw_hdmi: drop mode_valid hook

2022-02-09 Thread Sascha Hauer
The driver checks if the pixel clock of the given mode matches an entry in the mpll config table. The frequencies in the mpll table are meant as a frequency range up to which the entry works, not as a frequency that must match the pixel clock. The downstream Kernel also does not have this check, so

[PATCH v5 09/23] dt-bindings: display: rockchip: dw-hdmi: Add regulator support

2022-02-09 Thread Sascha Hauer
The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed for the HDMI port. Add the binding for these supplies. Signed-off-by: Sascha Hauer Acked-by: Rob Herring --- Notes: Changes since v4: - Add Robs Ack .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 11

Re: [PATCH v5 02/23] drm/rockchip: dw_hdmi: Do not leave clock enabled in error case

2022-02-09 Thread Heiko Stübner
Am Mittwoch, 9. Februar 2022, 10:53:29 CET schrieb Sascha Hauer: > The driver returns an error when devm_phy_optional_get() fails leaving > the previously enabled clock turned on. Change order and enable the > clock only after the phy has been acquired. > > Signed-off-by: Sascha Hauer just a not

Re: [PATCH v5 12/23] drm/rockchip: dw_hdmi: Use auto-generated tables

2022-02-09 Thread Heiko Stübner
Am Mittwoch, 9. Februar 2022, 10:53:39 CET schrieb Sascha Hauer: > From: Douglas Anderson > > The previous tables for mpll_cfg and curr_ctrl were created using the > 20-pages of example settings provided by the PHY vendor. Those > example settings weren't particularly dense, so there were places

Re: [PATCH v5 01/23] drm/encoder: Add of_graph port to struct drm_encoder

2022-02-09 Thread Sascha Hauer
David, Daniel, I'll need a word from you regarding this patch. It's needed in patch 22/23 in this series. vop2_crtc_atomic_enable() needs to control the mux which routes the display output to the different encoders. Which encoder is used is described in the of_graph port, so I need a way to identi

Re: [PATCH 2/9] drm/ttm: move the LRU into resource handling v3

2022-02-09 Thread Matthew Auld
On Wed, 9 Feb 2022 at 08:41, Christian König wrote: > > This way we finally fix the problem that new resource are > not immediately evict-able after allocation. > > That has caused numerous problems including OOM on GDS handling > and not being able to use TTM as general resource manager. > > v2:

Re: [PATCH 1/5] drm/fb-helper: Fix clip rectangle height

2022-02-09 Thread Javier Martinez Canillas
Hello Thomas, On 2/6/22 20:29, Thomas Zimmermann wrote: > Computing the clip rectangle is prone to off-by-one errors when writes > happen near the end of a memory page. Point the end of the memory area > to the first trailing byte, so that (end - start) returns the area's > length. > > Signed-off

Re: [PATCH 2/5] drm/fb-helper: Fix vertical damage clipping

2022-02-09 Thread Javier Martinez Canillas
On 2/6/22 20:29, Thomas Zimmermann wrote: > Don't clip the damage rectangle against the viewport. This only > works if the viewport is located at the beginning of the video > memory and the video memory doesn't extend the screen (i.e., if > there's no overallocation). > > Fbdev emulation transfers

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Add fallback inside memcpy_from_wc functions

2022-02-09 Thread Balasubramani Vivekanandan
On 08.02.2022 11:11, Lucas De Marchi wrote: > On Mon, Feb 07, 2022 at 09:43:08PM +0530, Balasubramani Vivekanandan wrote: > > memcpy_from_wc functions can fail if SSE4.1 is not supported or the > > supplied addresses are not 16-byte aligned. It was then upto to the > > caller to use memcpy as fallb

Re: [PATCH 3/5] drm/fb-helper: Calculate damaged area in separate helper

2022-02-09 Thread Javier Martinez Canillas
On 2/6/22 20:29, Thomas Zimmermann wrote: > Add drm_fb_helper_clip_to_memory_range(), a helper function that > accepts an linear range of video memory and converts it into a > rectangle. The computed rectangle describes the damaged area in > terms of scanlines and pixels per scanline. > > While at

Re: [PATCH 4/5] drm/fb-helper: Clip damage area to written memory range

2022-02-09 Thread Javier Martinez Canillas
On 2/6/22 20:29, Thomas Zimmermann wrote: > Write helpers used to mark the complete screen as dirty. This is > wasteful for writes that only change a small portion of the screen. > Fix the problem by computing the damaged area from the written > memory range and perform damage handling accordingly.

Re: [PATCH v5 01/23] drm/encoder: Add of_graph port to struct drm_encoder

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Sascha Hauer wrote: > David, Daniel, > > I'll need a word from you regarding this patch. It's needed in patch > 22/23 in this series. > vop2_crtc_atomic_enable() needs to control the mux which routes the > display output to the different encoders. Which encoder is used is > de

Re: [PATCH 5/5] drm/fb-helper: Clip damage area horizontally

2022-02-09 Thread Javier Martinez Canillas
On 2/6/22 20:29, Thomas Zimmermann wrote: > Clip the damage area horizontally if only a single scanline has been > changed. This is helpful to reduce the memcpy overhead for small writes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier M

[PATCH] drm/i915/ttm: tweak priority hint selection

2022-02-09 Thread Matthew Auld
For some reason we are selecting PRIO_HAS_PAGES when we don't have mm.pages, and vice versa. v2(Thomas): - Add missing fixes tag Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend") Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- d

Re: [PATCH v13 0/9] MIPS: JZ4780 and CI20 HDMI

2022-02-09 Thread Paul Cercueil
Hi Nikolaus, I tried applying patches 1-2, but they don't apply cleanly on top of drm-misc/drm-misc-next. Could you rebase on top of that tree? Cheers, -Paul Le mer., févr. 2 2022 at 17:31:14 +0100, H. Nikolaus Schaller a écrit : PATCH V13 2022-02-02 17:31:22: * 7/9: remove call to gpiod

Re: [PATCH v13 5/9] drm/synopsys+ingenic: repair hot plug detection

2022-02-09 Thread Paul Cercueil
Hi Nikolaus, Le mer., févr. 2 2022 at 17:31:19 +0100, H. Nikolaus Schaller a écrit : so that it calls drm_kms_helper_hotplug_event(). We need to set .poll_enabled but that struct component can only be accessed in the core code. Hence we add a public setter function. Signed-off-by: H. Nikolau

Re: [PATCH 2/9] drm/ttm: move the LRU into resource handling v3

2022-02-09 Thread Christian König
Am 09.02.22 um 11:09 schrieb Matthew Auld: On Wed, 9 Feb 2022 at 08:41, Christian König wrote: This way we finally fix the problem that new resource are not immediately evict-able after allocation. That has caused numerous problems including OOM on GDS handling and not being able to use TTM

Re: [PATCH 6/9] drm/amdgpu: remove VRAM accounting

2022-02-09 Thread Christian König
Am 09.02.22 um 10:53 schrieb Matthew Auld: On Wed, 9 Feb 2022 at 08:41, Christian König wrote: This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen

Re: [PATCH v13 6/9] dw-hdmi/ingenic-dw-hdmi: repair interworking with hdmi-connector

2022-02-09 Thread Paul Cercueil
Hi Nikolaus, Le mer., févr. 2 2022 at 17:31:20 +0100, H. Nikolaus Schaller a écrit : Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts callbacks") introduced a new mechanism to negotiate bus formats between hdmi connector and the synopsys hdmi driver inside the jz47

Re: [PATCH v3 0/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Geert Uytterhoeven
Hi Javier, On Wed, Feb 9, 2022 at 10:03 AM Javier Martinez Canillas wrote: > This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, > SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. [...] > - Fix a bug when doing partial updates (Geert Uytterhoeven)

Re: [PATCH v3 4/7] drm/solomon: Add SSD130X OLED displays I2C support

2022-02-09 Thread Geert Uytterhoeven
Hi Javier, On Wed, Feb 9, 2022 at 10:03 AM Javier Martinez Canillas wrote: > The ssd130x driver only provides the core support for these devices but it > does not have any bus transport logic. Add a driver to interface over I2C. > > Signed-off-by: Javier Martinez Canillas Thanks for your patch!

Re: [PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support

2022-02-09 Thread Geert Uytterhoeven
Hi Javier, On Wed, Feb 9, 2022 at 10:12 AM Javier Martinez Canillas wrote: > The ssd130x driver only provides the core support for these devices but it > does not have any bus transport logic. Add a driver to interface over SPI. > > Signed-off-by: Javier Martinez Canillas Thanks for your patch!

Re: [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-09 Thread Noralf Trønnes
Den 09.02.2022 10.04, skrev Maxime Ripard: > Hi Noralf, > > On Tue, Feb 08, 2022 at 01:16:44PM +0100, Noralf Trønnes wrote: >> Den 08.02.2022 00.20, skrev Rob Herring: >>> On Thu, Jan 27, 2022 at 10:37:22AM +0100, Maxime Ripard wrote: Hi, On Tue, Jan 25, 2022 at 06:56:58PM +0100,

Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount

2022-02-09 Thread Jason Gunthorpe
On Wed, Feb 09, 2022 at 07:23:45AM +0100, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 07:30:11PM -0800, Dan Williams wrote: > > Interesting. I had expected that to really fix the refcount problem > > that fs/dax.c would need to start taking real page references as pages > > were added to a m

  1   2   3   4   >