[PATCH v2 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread Kandpal Suraj
Changing drm_connector and drm_encoder feilds to pointers in drm_writeback_connector as the elements of struct drm_writeback_connector are: struct drm_writeback_connector { struct drm_connector base; struct drm_encoder encoder; Similarly the elements of intel_encoder and intel_conne

[PATCH v2 2/6] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Making changes to komeda driver because we had to change drm_writeback_connector.base into a pointer the reason for which is expained in the Patch (drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- drive

[PATCH v2 3/6] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Changing vkms driver to accomadate the change of drm_writeback_connector.base to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vkms/vkms_writeback.c | 9 ++--- 1 file changed, 6 inserti

[PATCH v2 4/6] drm/vc4: vc4 driver changes to accommodate changes done in drm_writeback_connector structure

2022-02-02 Thread Kandpal Suraj
Changing vc4 driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vc4/vc4_txp.c | 20

[PATCH v2 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing rcar_du driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h

[PATCH v2 6/6] drm/arm: changes to malidp driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing malidp driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/malidp_crtc.c | 2 +

[PATCH v2 0/2] mxsfb fixes

2022-02-02 Thread Alexander Stein
This v2 collects both single patches from [1] and [2]. Changes in v2: * Added Reviewed-by: Marek Vasut to patch 1 * Updated commit message of patch 2 as suggested by Marek [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220121095644.329256-1-alexander.st...@ew.tq-group.com/ [2

[PATCH v2 1/2] drm: mxsfb: Use dev_err_probe() helper

2022-02-02 Thread Alexander Stein
Use the dev_err_probe() helper, instead of open-coding the same operation. This also adds a nice hint in /sys/kernel/debug/devices_deferred. Reviewed-by: Marek Vasut Signed-off-by: Alexander Stein --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) dif

[PATCH v2 2/2] drm: mxsfb: Fix NULL pointer dereference

2022-02-02 Thread Alexander Stein
mxsfb should not never dereference the NULL pointer which drm_atomic_get_new_bridge_state is allowed to return. Assume a fixed format instead. Fixes: commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if present") Signed-off-by: Alexander Stein --- drivers/gpu/drm/mxsfb/mx

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Thomas Zimmermann
Hi Am 01.02.22 um 15:36 schrieb Javier Martinez Canillas: On 2/1/22 15:05, Geert Uytterhoeven wrote: Hi Javier, On Tue, Feb 1, 2022 at 2:02 PM Javier Martinez Canillas wrote: On 2/1/22 10:33, Thomas Zimmermann wrote: +{ +u8 col_end = col_start + cols - 1; +int ret; + +if (col_st

Re: [PATCH v2 2/2] drm: mxsfb: Fix NULL pointer dereference

2022-02-02 Thread Marek Vasut
On 2/2/22 09:17, Alexander Stein wrote: mxsfb should not never dereference the NULL pointer which ... not ever ... but that's really a nitpick. drm_atomic_get_new_bridge_state is allowed to return. Assume a fixed format instead. Fixes: commit b776b0f00f24 ("drm: mxsfb: Use bus_format from th

Re: [PATCH v2 1/2] drm: mxsfb: Use dev_err_probe() helper

2022-02-02 Thread Marek Vasut
On 2/2/22 09:17, Alexander Stein wrote: Use the dev_err_probe() helper, instead of open-coding the same operation. This also adds a nice hint in /sys/kernel/debug/devices_deferred. Reviewed-by: Marek Vasut Signed-off-by: Alexander Stein --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- 1 file

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Javier Martinez Canillas
Hello Thomas, On 2/2/22 09:23, Thomas Zimmermann wrote: [snip] > > Thanks to both of you. I was asking because I found the code to be > repetitive and it's not clear that these 3 statements belong together. > > I'd like to suggest to add a function > >ssd1307_write_cmds(client, len, cons

Re: [PATCH v2] drm: document struct drm_mode_fb_cmd2

2022-02-02 Thread Pekka Paalanen
On Tue, 01 Feb 2022 09:41:20 + Simon Ser wrote: > Follow-up for the DRM_IOCTL_MODE_GETFB2 docs. > > v2: (Daniel Stone) > - Replace fourcc.org with drm_fourcc.h because this is the > authoritative source and the website may have mismatches. > - Drop assumption that offsets will generally be

Re: linux-next: build warning after merge of the drm tree

2022-02-02 Thread Hans de Goede
Hi, On 2/2/22 05:03, Stephen Rothwell wrote: > Hi all, > > On Wed, 2 Feb 2022 15:02:01 +1100 Stephen Rothwell > wrote: >> >> After merging the drm tree, today's linux-next build (htmldocs) produced >> this warning: >> >> drivers/gpu/drm/drm_privacy_screen.c:X: warning: Function parameter or >>

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Javier Martinez Canillas
Hello Sam, On 2/1/22 21:40, Sam Ravnborg wrote: [snip] > > I took a look at the datasheets - and all ssd1305, ssd1306 and ssd1307 > are the same. They have timing constrains on the Vcc. > The random schematic I found on the net showed me that a PWM was used to > control the Vcc voltage - which

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-02 Thread Javier Martinez Canillas
On 2/1/22 23:29, Simon Ser wrote: > On Tuesday, February 1st, 2022 at 21:57, Sam Ravnborg > wrote: > >> As I wrote in another part of this thread(s) - typing the patch is easy. >> But I do not understand the userspace implications so I need someone >> else to say go. > > User-space shouldn't re

[PATCH 0/6] drm writeback connector changes

2022-02-02 Thread Kandpal Suraj
This patch series contains drm_writeback_connector structure change i.e change of drm_connector and drm_encoder fields to a pointer the reason for which is explained in patch(1/6) drm: add writeback pointers to drm_connector and the accompanying changes to the different drivers that were effected

[PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread Kandpal Suraj
Changing drm_connector and drm_encoder feilds to pointers in drm_writeback_connector as the elements of struct drm_writeback_connector are: struct drm_writeback_connector { struct drm_connector base; struct drm_encoder encoder; Similarly the elements of intel_encoder and intel_conne

[PATCH 2/6] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Making changes to komeda driver because we had to change drm_writeback_connector.base into a pointer the reason for which is expained in the Patch (drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj Reviewed-by: Carsten Haitzler --- drivers/gpu/drm/arm/display/komeda/k

[PATCH 3/6] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-02-02 Thread Kandpal Suraj
Changing vkms driver to accomadate the change of drm_writeback_connector.base to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vkms/vkms_writeback.c | 9 ++--- 1 file changed, 6 inserti

[PATCH 4/6] drm/vc4: vc4 driver changes to accommodate changes done in drm_writeback_connector structure

2022-02-02 Thread Kandpal Suraj
Changing vc4 driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/vc4/vc4_txp.c | 20

[PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing rcar_du driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h

[PATCH 6/6] drm/arm: changes to malidp driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Kandpal Suraj
Changing malidp driver to accomadate the change of drm_writeback_connector.base and drm_writeback_connector.encoder to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal Suraj --- drivers/gpu/drm/arm/malidp_crtc.c | 2 +

Re: (EXT) Re: [PATCH v2 1/2] drm: mxsfb: Use dev_err_probe() helper

2022-02-02 Thread Alexander Stein
Am Mittwoch, 2. Februar 2022, 09:29:20 CET schrieb Marek Vasut: > On 2/2/22 09:17, Alexander Stein wrote: > > Use the dev_err_probe() helper, instead of open-coding the same > > operation. This also adds a nice hint in > > /sys/kernel/debug/devices_deferred. > > > > Reviewed-by: Marek Vasut > > S

Re: [PATCH v6 1/6] drm: sun4i: dsi: Drop DRM bind race with bridge attach

2022-02-02 Thread Maxime Ripard
On Mon, Jan 17, 2022 at 09:12:37PM +0530, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 10:32 PM Maxime Ripard wrote: > > > > On Fri, Dec 10, 2021 at 04:47:06PM +0530, Jagan Teki wrote: > > > Existing host driver will keep looking for DRM pointer in > > > sun6i_dsi_attach and defers even if the part

Re: (EXT) Re: [PATCH v2 2/2] drm: mxsfb: Fix NULL pointer dereference

2022-02-02 Thread Alexander Stein
Am Mittwoch, 2. Februar 2022, 09:30:38 CET schrieb Marek Vasut: > On 2/2/22 09:17, Alexander Stein wrote: > > mxsfb should not never dereference the NULL pointer which > > ... not ever ... but that's really a nitpick. Doh, I just copied it from my mail... You want me to send a v2.1? Or will someo

[next] arm: panel-edp.c:(.text+0xb74): undefined reference to `drm_panel_dp_aux_backlight'

2022-02-02 Thread Naresh Kamboju
Following builds failed on Linux next 20220202 arm architecture. - arm-gcc-10-omap2plus_defconfig - arm-clang-nightly-shmobile_defconfig - arm-gcc-8-lpc32xx_defconfig - arm-clang-13-shmobile_defconfig - arm-gcc-10-shmobile_defconfig - arm-clang-11-shmobile_defconfig - arm-clang-11

RE: [PATCH v2] fbdev: fbmem: Fix the implicit type casting

2022-02-02 Thread David Laight
From: Yizhuo Zhai > Sent: 01 February 2022 02:36 > > In function do_fb_ioctl(), the "arg" is the type of unsigned long, > and in "case FBIOBLANK:" this argument is casted into an int before > passig to fb_blank(). In fb_blank(), the comparision > if (blank > FB_BLANK_POWERDOWN) would be bypass if

Re: (EXT) Re: [PATCH v2 2/2] drm: mxsfb: Fix NULL pointer dereference

2022-02-02 Thread Marek Vasut
On 2/2/22 10:00, Alexander Stein wrote: Am Mittwoch, 2. Februar 2022, 09:30:38 CET schrieb Marek Vasut: On 2/2/22 09:17, Alexander Stein wrote: mxsfb should not never dereference the NULL pointer which ... not ever ... but that's really a nitpick. Doh, I just copied it from my mail... You w

Re: (EXT) Re: [PATCH v2 1/2] drm: mxsfb: Use dev_err_probe() helper

2022-02-02 Thread Marek Vasut
On 2/2/22 09:58, Alexander Stein wrote: Am Mittwoch, 2. Februar 2022, 09:29:20 CET schrieb Marek Vasut: On 2/2/22 09:17, Alexander Stein wrote: Use the dev_err_probe() helper, instead of open-coding the same operation. This also adds a nice hint in /sys/kernel/debug/devices_deferred. Reviewed-

Re: [next] arm: panel-edp.c:(.text+0xb74): undefined reference to `drm_panel_dp_aux_backlight'

2022-02-02 Thread Thomas Zimmermann
Hi Am 02.02.22 um 10:02 schrieb Naresh Kamboju: Following builds failed on Linux next 20220202 arm architecture. - arm-gcc-10-omap2plus_defconfig - arm-clang-nightly-shmobile_defconfig - arm-gcc-8-lpc32xx_defconfig - arm-clang-13-shmobile_defconfig - arm-gcc-10-shmobile_defconfig

[PATCH v2] dma-buf-map: Rename to iosys-map

2022-02-02 Thread Lucas De Marchi
Rename struct dma_buf_map to struct iosys_map and corresponding APIs. Over time dma-buf-map grew up to more functionality than the one used by dma-buf: in fact it's just a shim layer to abstract system memory, that can be accessed via regular load and store, from IO memory, that needs to be accesse

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-02 Thread Thomas Zimmermann
Hi Noralf, since you're here, I'll just hijack the discussion to ask something only semi-related. IIRC the gud driver doesn't update the display immediately during atomic commits. Instead, it instructs a helper thread to do the update. What's the rational behind this design? Is that somethin

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Pekka Paalanen
On Tue, 1 Feb 2022 12:07:07 +0100 Geert Uytterhoeven wrote: > Hi Pekka, > > On Tue, Feb 1, 2022 at 11:42 AM Pekka Paalanen wrote: > > On Tue, 1 Feb 2022 10:49:03 +0100 > > Javier Martinez Canillas wrote: > > > On 2/1/22 09:38, Daniel Vetter wrote: > > > > On Tue, Feb 1, 2022 at 9:34 AM Sim

Re: [PATCH v2] dma-buf-map: Rename to iosys-map

2022-02-02 Thread Christian König
Am 02.02.22 um 10:11 schrieb Lucas De Marchi: [SNIP] diff --git a/MAINTAINERS b/MAINTAINERS index d03ad8da1f36..112676f11792 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5675,7 +5675,6 @@ T:git git://anongit.freedesktop.org/drm/drm-misc F:Documentation/driver-api/dma-buf.rst

Re: [next] arm: panel-edp.c:(.text+0xb74): undefined reference to `drm_panel_dp_aux_backlight'

2022-02-02 Thread Ard Biesheuvel
On Wed, 2 Feb 2022 at 10:08, Thomas Zimmermann wrote: > > Hi > > Am 02.02.22 um 10:02 schrieb Naresh Kamboju: > > Following builds failed on Linux next 20220202 arm architecture. > >- arm-gcc-10-omap2plus_defconfig > >- arm-clang-nightly-shmobil

Re: [PATCH v2] dma-buf-map: Rename to iosys-map

2022-02-02 Thread Lucas De Marchi
On Wed, Feb 02, 2022 at 10:25:28AM +0100, Christian König wrote: Am 02.02.22 um 10:11 schrieb Lucas De Marchi: [SNIP] diff --git a/MAINTAINERS b/MAINTAINERS index d03ad8da1f36..112676f11792 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5675,7 +5675,6 @@ T:git git://anongit.freedesktop.o

[PATCH] drm/connector: Fix typo in documentation

2022-02-02 Thread Maxime Ripard
Commit 4adc33f36d80 ("drm/edid: Split deep color modes between RGB and YUV444") introduced two new variables in struct drm_display_info and their documentation, but the documentation part had a typo resulting in a doc build warning. Fixes: 4adc33f36d80 ("drm/edid: Split deep color modes between RG

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-02 Thread Noralf Trønnes
Den 02.02.2022 10.14, skrev Thomas Zimmermann: > Hi Noralf, > > since you're here, I'll just hijack the discussion to ask something only > semi-related. > > IIRC the gud driver doesn't update the display immediately during atomic > commits. Instead, it instructs a helper thread to do the updat

Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2022-02-02 Thread Maxime Ripard
On Thu, Jan 27, 2022 at 03:22:15PM +0100, Maxime Ripard wrote: > Hi Laurent, > > On Tue, Jan 11, 2022 at 03:05:10PM +0200, Laurent Pinchart wrote: > > On Tue, Jan 11, 2022 at 12:06:35PM +0100, Maxime Ripard wrote: > > > Following the previous patch, let's introduce a generic panel-lvds > > > bindi

Re: [PATCH] drm/msm/dpu: Bind pingpong block to intf on active ctls in cmd encoder

2022-02-02 Thread Marijn Suijten
On 2022-01-20 02:12:51, Dmitry Baryshkov wrote: > On 22/12/2021 13:55, Marijn Suijten wrote: > > As per the specification of DPU_CTL_ACTIVE_CFG the configuration of > > active blocks should be proactively specified, and the pingpong block is > > no different. > > > > The downstream display driver

Re: (subset) [PATCH] drm/vc4: hdmi: Simplify the connector state retrieval

2022-02-02 Thread Maxime Ripard
On Thu, 27 Jan 2022 12:14:04 +0100, Maxime Ripard wrote: > When we have the entire DRM state, retrieving the connector state only > requires the drm_connector pointer. Fortunately for us, we have > allocated it as a part of the vc4_hdmi structure, so we can retrieve get > a pointer by simply access

Re: (subset) [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2022-02-02 Thread Maxime Ripard
On Tue, 11 Jan 2022 12:06:35 +0100, Maxime Ripard wrote: > Following the previous patch, let's introduce a generic panel-lvds > binding that documents the panels that don't have any particular > constraint documented. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v4 1/2] dt-bindings: display: Turn lvds.yaml into a generic schema

2022-02-02 Thread Maxime Ripard
On Thu, 27 Jan 2022 15:30:44 +0100, Maxime Ripard wrote: > The lvds.yaml file so far was both defining the generic LVDS properties > (such as data-mapping) that could be used for any LVDS sink, but also > the panel-lvds binding. > > That last binding was to describe LVDS panels simple enough, and

Re: [PATCH v2] drm/msm/dp: add wide bus support

2022-02-02 Thread Dmitry Baryshkov
On 02/02/2022 03:30, Kuogee Hsieh wrote: Normally, mdp will push one pixel of data per pixel clock to interface to display. Wide bus feature will increase bus width from 32 bits to 64 bits so that it can push two pixel of data per pixel clock to interface to display. This feature is pre requireme

Re: [PATCH] drm/connector: Fix typo in documentation

2022-02-02 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH v12 3/9] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2022-02-02 Thread Paul Cercueil
Hi Nikolaus, Le lun., janv. 31 2022 at 13:26:49 +0100, H. Nikolaus Schaller a écrit : From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc:

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-02 Thread Maxime Ripard
On Thu, Jan 27, 2022 at 06:53:48PM +0100, Noralf Trønnes wrote: > >> +struct panel_mipi_dbi_config { > >> + /* Magic string: panel_mipi_dbi_magic */ > >> + u8 magic[15]; > >> + > >> + /* Config file format version */ > >> + u8 file_format_version; > >> + > >> + /* Width in pixels */ > >> + __

Re: [PATCH v12 4/9] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-02 Thread Paul Cercueil
Hi Nikolaus, Le lun., janv. 31 2022 at 13:26:50 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig

Re: [PATCH 5/8] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-02 Thread Jani Nikula
On Wed, 26 Jan 2022, Ville Syrjälä wrote: > On Tue, Jan 25, 2022 at 07:03:43PM +0200, Jani Nikula wrote: >> The DP 2.0 errata completely overhauls the 128b/132b link training, with >> no provisions for backward compatibility with the original DP 2.0 >> specification. >> >> The changes are too int

Re: [PATCH 5/8] drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata

2022-02-02 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjälä wrote: > On Tue, Jan 25, 2022 at 07:03:43PM +0200, Jani Nikula wrote: > >> +static bool >> +intel_dp_128b132b_lane_cds(struct intel_dp *intel_dp, >> + const struct intel_crtc_state *crtc_state, >> + int lttpr_count) >>

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Cercueil
Hi Nikolaus, Le lun., janv. 31 2022 at 13:26:48 +0100, H. Nikolaus Schaller a écrit : From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Tested on MIPS Creator

Re: [PATCH 10/20] drm/i915/selftests: mock test io_size

2022-02-02 Thread Thomas Hellström
On 1/26/22 16:21, Matthew Auld wrote: Check that mappable vs non-mappable matches our expectations. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- .../drm/i915/selftests/intel_memory_region.c | 143 ++ 1 file changed, 143 insertio

Re: [next] arm: panel-edp.c:(.text+0xb74): undefined reference to `drm_panel_dp_aux_backlight'

2022-02-02 Thread Thomas Zimmermann
Hi Am 02.02.22 um 10:28 schrieb Ard Biesheuvel: On Wed, 2 Feb 2022 at 10:08, Thomas Zimmermann wrote: Hi Am 02.02.22 um 10:02 schrieb Naresh Kamboju: Following builds failed on Linux next 20220202 arm architecture. - arm-gcc-10-omap2plus_defconfig - arm-clang-nightly

Re: [PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread Dmitry Baryshkov
On Wed, 2 Feb 2022 at 11:46, Kandpal Suraj wrote: > > Changing drm_connector and drm_encoder feilds to pointers in > drm_writeback_connector as the elements of struct > drm_writeback_connector are: > struct drm_writeback_connector { > struct drm_connector base; > struct drm_encoder

Re: [PATCH v12 7/9] drm/bridge: display-connector: add ddc-en gpio support

2022-02-02 Thread Paul Cercueil
Hi Nikolaus, Le lun., janv. 31 2022 at 13:26:53 +0100, H. Nikolaus Schaller a écrit : "hdmi-connector.yaml" bindings defines an optional property "ddc-en-gpios" for a single gpio to enable DDC operation. Usually this controls +5V power on the HDMI connector. This +5V may also be needed for HP

Re: [PATCH v12 8/9] MIPS: DTS: CI20: fix how ddc power is enabled

2022-02-02 Thread Paul Cercueil
Le lun., janv. 31 2022 at 13:26:54 +0100, H. Nikolaus Schaller a écrit : Originally we proposed a new hdmi-5v-supply regulator reference for CI20 device tree but that was superseded by a better idea to use the already defined "ddc-en-gpios" property of the "hdmi-connector". Since "MIPS: DTS

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Geert Uytterhoeven
Hi Pekka, On Wed, Feb 2, 2022 at 10:20 AM Pekka Paalanen wrote: > On Tue, 1 Feb 2022 12:07:07 +0100 > Geert Uytterhoeven wrote: > > On Tue, Feb 1, 2022 at 11:42 AM Pekka Paalanen wrote: > > > On Tue, 1 Feb 2022 10:49:03 +0100 > > > Javier Martinez Canillas wrote: > > > > On 2/1/22 09:38, Danie

Re: [PATCH v3 3/3] fbcon: Add option to enable legacy hardware acceleration

2022-02-02 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 11:52 PM Helge Deller wrote: > > Hello Daniel, > > On 2/1/22 21:11, Daniel Vetter wrote: > > On Tue, Feb 1, 2022 at 7:59 PM Helge Deller wrote: > >> > >> Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to > >> enable bitblt and fillrect hardware accelerat

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Andy Shevchenko
On Wed, Feb 02, 2022 at 09:38:51AM +0100, Javier Martinez Canillas wrote: > On 2/1/22 21:40, Sam Ravnborg wrote: ... > Peter Robinson suggested to > make the driver mutually exclusive and add !FB_SSD1307 in the config symbol. And how will distros choose "the right" option in this case? What to d

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Daniel Stone
On Mon, 31 Jan 2022 at 21:06, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head

Re: [Intel-gfx] [PATCH 1/6] drm: add writeback pointers to drm_connector

2022-02-02 Thread kernel test robot
Hi Kandpal, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip v5.17-rc2 next-20220202] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Tomi Valkeinen
On 31/01/2022 23:05, Daniel Vetter wrote: Ever since Tomi extracted the core code in 2014 it's been defacto me maintaining this, with help from others from dri-devel and sometimes Linus (but those are mostly merge conflicts): $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 35 Dani

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Maxime Ripard
On Mon, Jan 31, 2022 at 10:05:32PM +0100, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/c

[Bug 201957] amdgpu: ring gfx timeout

2022-02-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 Jon (kernel...@digininja.net) changed: What|Removed |Added CC||kernel...@digininja.net -

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Javier Martinez Canillas
Hello Andy, On 2/2/22 12:06, Andy Shevchenko wrote: > On Wed, Feb 02, 2022 at 09:38:51AM +0100, Javier Martinez Canillas wrote: >> On 2/1/22 21:40, Sam Ravnborg wrote: > > ... > >> Peter Robinson suggested to >> make the driver mutually exclusive and add !FB_SSD1307 in the config symbol. > > An

Re: [PATCH v12 4/9] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-02 Thread H. Nikolaus Schaller
Hi Paul, > Am 02.02.2022 um 11:16 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le lun., janv. 31 2022 at 13:26:50 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> A specialisation of the generic Synopsys HDMI driver is employed for >> JZ4780 HDMI support. This requires a new dr

Re: [PATCH v12 7/9] drm/bridge: display-connector: add ddc-en gpio support

2022-02-02 Thread H. Nikolaus Schaller
Hi Paul, > Am 02.02.2022 um 11:32 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le lun., janv. 31 2022 at 13:26:53 +0100, H. Nikolaus Schaller > a écrit : >> "hdmi-connector.yaml" bindings defines an optional property >> "ddc-en-gpios" for a single gpio to enable DDC operation. >> Usually this

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Andy Shevchenko
On Wed, Feb 02, 2022 at 12:39:29PM +0100, Javier Martinez Canillas wrote: > On 2/2/22 12:06, Andy Shevchenko wrote: > > On Wed, Feb 02, 2022 at 09:38:51AM +0100, Javier Martinez Canillas wrote: > >> On 2/1/22 21:40, Sam Ravnborg wrote: > > And how will distros choose "the right" option in this cas

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Javier Martinez Canillas
On 2/2/22 12:50, Andy Shevchenko wrote: [snip] >> What's your suggestion then to solve the issue mentioned above ? With my >> distro >> maintainer hat I don't care that much, since the fbdev drivers will be >> disabled. > > I think both of them can work together. If user doesn't care, the firs

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
Hi Paul, thanks for the reviews. Looks as if we are close to making a goal. > Am 02.02.2022 um 11:23 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le lun., janv. 31 2022 at 13:26:48 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> Add support for the LCD controller present on JZ

Re: [PATCH v12 3/9] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2022-02-02 Thread H. Nikolaus Schaller
Hi Paul, > Am 02.02.2022 um 10:59 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le lun., janv. 31 2022 at 13:26:49 +0100, H. Nikolaus Schaller > a écrit : >> From: Sam Ravnborg >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kak

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Cercueil
Hi Nikolaus, Le mer., févr. 2 2022 at 12:56:35 +0100, H. Nikolaus Schaller a écrit : Hi Paul, thanks for the reviews. Looks as if we are close to making a goal. Am 02.02.2022 um 11:23 schrieb Paul Cercueil : Hi Nikolaus, Le lun., janv. 31 2022 at 13:26:48 +0100, H. Nikolaus Schaller a

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
Hi Paul, > Am 02.02.2022 um 13:06 schrieb Paul Cercueil : > > Hi Nikolaus, > @@ -446,6 +454,9 @@ static int ingenic_drm_plane_atomic_check(struct drm_plane *plane, if (!crtc) return 0; + if (plane == &priv->f0) + return -EINVAL; >>> This wil

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Andy Shevchenko
On Wed, Feb 02, 2022 at 12:54:32PM +0100, Javier Martinez Canillas wrote: > On 2/2/22 12:50, Andy Shevchenko wrote: > >> What's your suggestion then to solve the issue mentioned above ? With my > >> distro > >> maintainer hat I don't care that much, since the fbdev drivers will be > >> disabled.

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Cercueil
Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 02.02.2022 um 13:06 schrieb Paul Cercueil : Hi Nikolaus, @@ -446,6 +454,9 @@ static int ingenic_drm_plane_atomic_check(struct drm_plane *plane, if (!crtc) return 0; + if

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : > > > > Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 02.02.2022 um 13:06 schrieb Paul Cercueil : >>> Hi Nikolaus, >> @@ -446,6 +454,9 @@ static int ingenic_drm_plane_atomic_check(struct >>>

[RFC PATCH] drm/i915: Fix vma lifetime

2022-02-02 Thread Thomas Hellström
It's unclear what reference the initial vma refcount refers to. A vma can have multiple weak references, the object vma list, the vm's bound list and the gt's closed_list, and that initial vma refcount can be put from lookups of all these lists. The problem is that if another user is also holding a

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread Paul Cercueil
Le mer., févr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller a écrit : Am 02.02.2022 um 13:28 schrieb Paul Cercueil : Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 02.02.2022 um 13:06 schrieb Paul Cercueil : Hi Nikolaus, @@ -446,6 +454,

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Laurent Pinchart
Hi Kandpal, Thank you for the patch. On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > Changing rcar_du driver to accomadate the change of > drm_writeback_connector.base and drm_writeback_connector.encoder > to a pointer the reason for which is explained in the > Patch(drm: add wri

Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2022-02-02 Thread Laurent Pinchart
Hi Maxime, On Wed, Feb 02, 2022 at 10:48:45AM +0100, Maxime Ripard wrote: > On Thu, Jan 27, 2022 at 03:22:15PM +0100, Maxime Ripard wrote: > > On Tue, Jan 11, 2022 at 03:05:10PM +0200, Laurent Pinchart wrote: > > > On Tue, Jan 11, 2022 at 12:06:35PM +0100, Maxime Ripard wrote: > > > > Following th

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
> Am 02.02.2022 um 13:41 schrieb Paul Cercueil : > > > > Le mer., févr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller > a écrit : >>> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : >>> Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller >>> a écrit : Hi Paul, > Am 02.0

Re: [PATCH 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation

2022-02-02 Thread Tvrtko Ursulin
On 02/02/2022 01:13, Vivek Kasireddy wrote: This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() functions to identify suitable holes for an allocation of a given size by efficently traversing the rbtree associated with the given allocator. It replaces the for loop in drm_mm_inse

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Jani Nikula
On Wed, 02 Feb 2022, Laurent Pinchart wrote: > Hi Kandpal, > > Thank you for the patch. > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: >> Changing rcar_du driver to accomadate the change of >> drm_writeback_connector.base and drm_writeback_connector.encoder >> to a pointer the

Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2022-02-02 Thread Maxime Ripard
On Wed, Feb 02, 2022 at 02:47:14PM +0200, Laurent Pinchart wrote: > On Wed, Feb 02, 2022 at 10:48:45AM +0100, Maxime Ripard wrote: > > On Thu, Jan 27, 2022 at 03:22:15PM +0100, Maxime Ripard wrote: > > > On Tue, Jan 11, 2022 at 03:05:10PM +0200, Laurent Pinchart wrote: > > > > On Tue, Jan 11, 2022

Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2022-02-02 Thread Laurent Pinchart
On Wed, Feb 02, 2022 at 02:16:23PM +0100, Maxime Ripard wrote: > On Wed, Feb 02, 2022 at 02:47:14PM +0200, Laurent Pinchart wrote: > > On Wed, Feb 02, 2022 at 10:48:45AM +0100, Maxime Ripard wrote: > > > On Thu, Jan 27, 2022 at 03:22:15PM +0100, Maxime Ripard wrote: > > > > On Tue, Jan 11, 2022 at

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Laurent Pinchart
Hi Jani, On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > On Wed, 02 Feb 2022, Laurent Pinchart wrote: > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > >> Changing rcar_du driver to accomadate the change of > >> drm_writeback_connector.base and drm_writeback_conne

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Ville Syrjälä
On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: > On Wed, 02 Feb 2022, Laurent Pinchart > wrote: > > Hi Kandpal, > > > > Thank you for the patch. > > > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > >> Changing rcar_du driver to accomadate the change of > >> drm_w

Re: [PATCH 11/20] drm/i915/ttm: tweak priority hint selection

2022-02-02 Thread Thomas Hellström
On 1/26/22 16:21, Matthew Auld wrote: For some reason we are selecting PRIO_HAS_PAGES when we don't have mm.pages, and vice versa. Perhaps something else is going on here. Signed-off-by: Matthew Auld Cc: Thomas Hellström LGTM. Should we add a Fixes: tag here? Reviewed-by: Thomas Hellström

Re: [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-02 Thread Dmitry Baryshkov
On Wed, 2 Feb 2022 at 16:15, Jani Nikula wrote: > > On Wed, 02 Feb 2022, Laurent Pinchart > wrote: > > Hi Kandpal, > > > > Thank you for the patch. > > > > On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: > >> Changing rcar_du driver to accomadate the change of > >> drm_writeback_c

Re: [PATCH v3 3/3] fbcon: Add option to enable legacy hardware acceleration

2022-02-02 Thread Helge Deller
On 2/2/22 12:05, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 11:52 PM Helge Deller wrote: >> >> Hello Daniel, >> >> On 2/1/22 21:11, Daniel Vetter wrote: >>> On Tue, Feb 1, 2022 at 7:59 PM Helge Deller wrote: Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to e

Re: [PATCH 12/20] drm/i915/ttm: make eviction mappable aware

2022-02-02 Thread Thomas Hellström
On 1/26/22 16:21, Matthew Auld wrote: If we need to make room for some some mappable object, then we should only victimize objects that have one or pages that occupy the visible portion of LMEM. Let's also create a new priority hint for objects that are placed in mappable memory, where we know

Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2022-02-02 Thread Maxime Ripard
On Wed, Feb 02, 2022 at 03:21:05PM +0200, Laurent Pinchart wrote: > On Wed, Feb 02, 2022 at 02:16:23PM +0100, Maxime Ripard wrote: > > On Wed, Feb 02, 2022 at 02:47:14PM +0200, Laurent Pinchart wrote: > > > On Wed, Feb 02, 2022 at 10:48:45AM +0100, Maxime Ripard wrote: > > > > On Thu, Jan 27, 2022

[PATCH 1/9] drm/ttm: add common accounting to the resource mgr v3

2022-02-02 Thread Christian König
It makes sense to have this in the common manager for debugging and accounting of how much resources are used. v2: cleanup kerneldoc a bit v3: drop the atomic, update counter under lock instead Signed-off-by: Christian König Reviewed-by: Huang Rui --- drivers/gpu/drm/ttm/ttm_resource.c | 30 ++

[PATCH 2/9] drm/ttm: move the LRU into resource handling v3

2022-02-02 Thread Christian König
This way we finally fix the problem that new resource are not immediately evict-able after allocation. That has caused numerous problems including OOM on GDS handling and not being able to use TTM as general resource manager. v2: stop assuming in ttm_resource_fini that res->bo is still valid. v3:

[PATCH 3/9] drm/ttm: add resource iterator

2022-02-02 Thread Christian König
Instead of duplicating that at different places add an iterator over all the resources in a resource manager. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 41 +++ drivers/gpu/drm/ttm/ttm_device.c | 26 - drivers/gpu/drm/ttm/ttm

[PATCH 4/9] drm/radeon: remove resource accounting

2022-02-02 Thread Christian König
Use the one provided by TTM instead. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon.h| 2 -- drivers/gpu/drm/radeon/radeon_kms.c| 7 -- drivers/gpu/drm/radeon/radeon_object.c | 30 +++--- drivers/gpu/drm/radeon/radeon_object.h | 1 - drive

[PATCH 5/9] drm/amdgpu: remove GTT accounting

2022-02-02 Thread Christian König
This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 50 + drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 +--

[PATCH 6/9] drm/amdgpu: remove VRAM accounting

2022-02-02 Thread Christian König
This is provided by TTM now. Also switch man->size to bytes instead of pages and fix the double printing of size and usage in debugfs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/a

  1   2   3   >