Re: [PATCH] dma-buf: heaps: Fix potential spectre v1 gadget

2022-02-01 Thread Sumit Semwal
Hello Jordy, On Tue, 1 Feb 2022 at 02:09, John Stultz wrote: > > On Sat, Jan 29, 2022 at 7:06 AM Jordy Zomer wrote: > > > > It appears like nr could be a Spectre v1 gadget as it's supplied by a > > user and used as an array index. Prevent the contents > > of kernel memory from being leaked to us

Re: [PATCH 00/14] Rename dma-buf-map

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 08:46 schrieb Christian König: [..] 2) If renaming, would it still keep the same entry in MAINTAINERS? Thomas suggested drivers core, but this all seem to be used mainly on drm/, with just one exception. I would just add a complete new entry for this and use Thomas as mainta

Re: [Intel-gfx] [PATCH 21/21] fbdev: Make registered_fb[] private to fbmem.c

2022-02-01 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/some-fbcon-patches-mostly-locking/20220201-050907 base: git://anongit.freedesktop.org/tegra/linux.git drm

Re: [PULL] drm-misc-next

2022-02-01 Thread Maarten Lankhorst
Op 01-02-2022 om 07:38 schreef Dave Airlie: > On Thu, 27 Jan 2022 at 21:57, Maarten Lankhorst > wrote: >> Hi Dave & Daniel, >> >> First pull for v5.18 > I was trying to be all efficient and get this pulled in time for once. > > > However it broke building on my arm test build. > > The new DP helpe

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
On Mon, Jan 31, 2022 at 9:39 PM Simon Ser wrote: > On Monday, January 31st, 2022 at 21:36, Simon Ser wrote: > > > This driver only advertises XRGB in ssd1307_formats. It would be nice to > > expose R8 as well so that user-space can directly produce suitable buffers. > > It would also be nice

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven wrote: > What's the story with the Rn formats? > > The comments say "n bpp Red", while this is a monochrome (even > inverted) display? I don't think the color matters that much. "Red" was picked just because it was an arbitrary color,

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Simon, On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven > wrote: > > What's the story with the Rn formats? > > > > The comments say "n bpp Red", while this is a monochrome (even > > inverted) display? > > I don't think the color ma

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > > On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven > wrote: > > > What's the story with the Rn formats? > > > > The comments say "n bpp Red", while this is a monochrome (even > > inverted) display? > > I don't think the color matters t

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Mon, Jan 31, 2022 at 9:12 PM Javier Martinez Canillas wrote: > This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, > SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. Thanks for your series! I'll give it a try on an Adafruit FeatherWi

Re: [PATCH v3 2/3] drm/i915: Fix header test for !CONFIG_X86

2022-02-01 Thread Siva Mullati
Reviewed-by: Siva Mullati On 31/01/22 10:29 pm, Lucas De Marchi wrote: > Architectures others than x86 have a stub implementation calling > WARN_ON_ONCE(). The appropriate headers need to be included, otherwise > the header-test target will fail with: > > HDRTEST drivers/gpu/drm/i915/i915_mm.h

Re: [PATCH v11] drm/bridge: add it6505 driver

2022-02-01 Thread AngeloGioacchino Del Regno
Il 31/01/22 19:36, Robert Foss ha scritto: On Mon, 31 Jan 2022 at 17:55, Hsin-Yi Wang wrote: On Tue, Feb 1, 2022 at 12:37 AM Robert Foss wrote: On Thu, 20 Jan 2022 at 16:25, AngeloGioacchino Del Regno wrote: Il 14/01/22 10:14, allen ha scritto: This adds support for the iTE IT6505. This

Re: [PATCH] drm/bridge_connector: enable HPD by default if supported

2022-02-01 Thread Nikita Yushchenko
Hotplug events reported by bridge drivers over drm_bridge_hpd_notify() get ignored unless somebody calls drm_bridge_hpd_enable(). When the connector for the bridge is bridge_connector, such a call is done from drm_bridge_connector_enable_hpd(). However drm_bridge_connector_enable_hpd() is never c

[PATCH 1/3] drm/panel: ltk050h3146w: add mipi_dsi_device.mode_flags to of_match_data

2022-02-01 Thread quentin . schulz
From: Quentin Schulz To prepare for a new display to be supported by this driver which has a slightly different set of DSI mode related flags, let's move the currently hardcoded mode flags to the .data field of of_device_id structure. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drive

[PATCH] drm/panel-simple: Add a timing for the Raspberry Pi 7" panel

2022-02-01 Thread Detlev Casanova
From: Dave Stevenson The Raspberry Pi 7" 800x480 panel uses a Toshiba TC358762 DSI to DPI bridge chip, so there is a requirement for the timings to be specified for the end panel. Add such a definition. Signed-off-by: Dave Stevenson Signed-off-by: Detlev Casanova --- drivers/gpu/drm/panel/pan

[PATCH] dt-bindings: ltk050h3146w: replace Heiko Stuebner by myself as maintainer

2022-02-01 Thread quentin . schulz
From: Quentin Schulz Heiko does not work at Theobroma Systems anymore and the boards using those panels are downstream, maintained internally by the company, so let's relieve Heiko of maintainership duties. Cc: Heiko Stuebner Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- .../devicetre

[PATCH 2/3] drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant

2022-02-01 Thread quentin . schulz
From: Klaus Goger The LTK050H3148W-CTA6 is a 5.0" 720x1280 DSI display, whose driving controller is a Himax HX8394-F, slightly different from LTK050H3146W by its init sequence, mode details and mode flags. Cc: Quentin Schulz Signed-off-by: Klaus Goger Signed-off-by: Quentin Schulz --- .../dr

[PATCH 3/3] dt-bindings: ltk050h3146w: add compatible for LTK050H3148W-CTA6 variant

2022-02-01 Thread quentin . schulz
From: Quentin Schulz The LTK050H3148W-CTA6 is a 5.0" 720x1280 DSI display, whose driving controller is a Himax HX8394-F, slightly different from LTK050H3146W by its init sequence, mode details and mode flags. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- .../devicetree/bindings/display

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2022-02-01 Thread Tvrtko Ursulin
On 31/01/2022 22:27, Stephen Rothwell wrote: Hi all, After merging the drm-intel-fixes tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/i915_vma.c: In function 'i915_vma_bind': drivers/gpu/drm/i915/i915_vma.c:451:25: error: 'ret' undeclared (first us

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 09:43, Geert Uytterhoeven wrote: > Does there exist another simple test program for showing something > using the DRM API? If you're fine with going low-level, there's tentative [1] which can apply an arbitrary KMS state. See for instance [2] for basic mode-set

Re: [PATCH 4/4] MAINTAINERS: Add entry for Solomon SSD1307 OLED displays DRM driver

2022-02-01 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 09:15:37PM +0100, Javier Martinez Canillas wrote: > To make sure that tools like the get_maintainer.pl script will suggest > to Cc me if patches are posted for this driver. > > Also include the Device Tree binding for the old ssd1307fb fbdev driver > since the new DRM drive

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Thomas Zimmermann
Hi Javier, please see comments and questions below. Am 31.01.22 um 21:29 schrieb Javier Martinez Canillas: Add a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED controllers that can be programmed via an I2C interface. This is a port of the ssd1307fb driver that already support

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: ... > > Patch #3 adds the driver. The name ssd1307 was used instead of ssd130x > > (which would be more accurate) to avoid confusion for users who want to > >

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote: ... > > +config TINYDRM_SSD1307 > > + tristate "DRM support for Solomon SSD1307 OLED displays" > Use SSD130X here - so SSD1306 users can find it. It's bette

[Bug 215511] Dual monitor with amd 5700 causes system to hang at startup.

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215511 --- Comment #2 from Jose Mestre (pmes...@gmail.com) --- Hello. I've been unable to compile a specific kernel commit (i did not have too much time to find the docs about how to do it) and i don't know C. I've tried releases for archlinux and i can

[PATCH v2] drm: document struct drm_mode_fb_cmd2

2022-02-01 Thread Simon Ser
Follow-up for the DRM_IOCTL_MODE_GETFB2 docs. v2: (Daniel Stone) - Replace fourcc.org with drm_fourcc.h because this is the authoritative source and the website may have mismatches. - Drop assumption that offsets will generally be 0. - Mention that unused entries must be zero'ed out. Signed-off

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote: > On 1/31/22 22:30, Sam Ravnborg wrote: > > On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote: ... > > The driver uses the pwms property for the backlight. > > It would have been much better to bite t

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 09:38, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: >> >> On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven >> wrote: >> >>> What's the story with the Rn formats? >>> >>> The comments say "n bpp Red", while this is a monochrome (even >>> inverted) di

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Tue, Feb 01, 2022 at 10:33:31AM +0100, Thomas Zimmermann wrote: > Am 31.01.22 um 21:29 schrieb Javier Martinez Canillas: > > +obj-$(CONFIG_TINYDRM_SSD1307) += ssd1307.o > > Maybe call it ssd130x Either way it's good to list all supported models in "help" of Kconfig. Also here is

Re: [PATCH] drm/i915/ttm: Return some errors instead of trying memcpy move

2022-02-01 Thread Matthew Auld
On 01/02/2022 07:03, Thomas Hellström wrote: The i915_ttm_accel_move() function may return error codes that should be propagated further up the stack rather than consumed assuming that the accel move failed and could be replaced with a memcpy move. For -EINTR, -ERESTARTSYS and -EAGAIN, just prop

Re: [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed()

2022-02-01 Thread Thomas Zimmermann
Hi Am 31.01.22 um 21:12 schrieb Javier Martinez Canillas: Add support to convert 8-bit grayscale to reversed monochrome for drivers that control monochromatic displays, that only have 1 bit per pixel depth. This helper function was based on repaper_gray8_to_mono_reversed() from the drivers/gpu/

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven: Hi Simon, On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven wrote: What's the story with the Rn formats? The comments say "n bpp Red", while this is a monochrome (even inverted) d

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 11:08, Thomas Zimmermann wrote: > Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven: > > > I'd expect 8-bit grayscale to be Y8 instead. > > I like this naming, but DRM_FORMAT_R8 is uapi already. :/ If anything, > we could add Yn formats in addition to existing Rn

Re: [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 1/31/22 22:05, Daniel Vetter wrote: > This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated > scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION > option. you have two trivial copy-n-paste errors in this patch which still prevent the console acceleration. > diff -

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 11:11 schrieb Simon Ser: On Tuesday, February 1st, 2022 at 11:08, Thomas Zimmermann wrote: Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven: I'd expect 8-bit grayscale to be Y8 instead. I like this naming, but DRM_FORMAT_R8 is uapi already. :/ If anything, we could add Y

Re: [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 11:16, Helge Deller wrote: > On 1/31/22 22:05, Daniel Vetter wrote: >> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated >> scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION >> option. > > you have two trivial copy-n-paste errors in this patch which stil

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Thomas Zimmermann
Am 31.01.22 um 22:05 schrieb Daniel Vetter: Ever since Tomi extracted the core code in 2014 it's been defacto me maintaining this, with help from others from dri-devel and sometimes Linus (but those are mostly merge conflicts): $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 35

Re: [PATCH v11] drm/bridge: add it6505 driver

2022-02-01 Thread Robert Foss
On Fri, 14 Jan 2022 at 10:29, allen wrote: > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Tested-by: Hsin-yi Wang > Signed-off-by: Hermes Wu > Signed-off-by: Allen Chen > --- > v10 -> v11 : remove drm_bridge_new_crtc_state >

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Helge Deller
On 1/31/22 22:05, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 > 35

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
Hello Geert, On 2/1/22 09:43, Geert Uytterhoeven wrote: > Hi Javier, > > On Mon, Jan 31, 2022 at 9:12 PM Javier Martinez Canillas > wrote: >> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, >> SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. >

Re: [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: > > On 1/31/22 22:05, Daniel Vetter wrote: > > This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated > > scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION > > option. > > you have two trivial copy-n-paste errors in

Re: [PATCH 09/21] fbcon: Replace FBCON_FLAGS_INIT with a boolean

2022-02-01 Thread Thomas Zimmermann
Am 31.01.22 um 22:05 schrieb Daniel Vetter: It's only one flag and slightly tidier code. Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Tetsuo Handa Cc: Greg Kroah-Hartman Cc: Du Cheng Cc: Thomas Zimmermann Cc: Claudio Suarez Acked-by: Thomas Zimmermann --- drivers/video/fbde

Re: [PATCH 08/20] drm/i915/buddy: adjust res->start

2022-02-01 Thread Thomas Hellström
On Wed, 2022-01-26 at 15:21 +, Matthew Auld wrote: > Differentiate between mappable vs non-mappable resources, also if > this > is an actual range allocation ensure we set res->start as the > starting > pfn. Later when we need to do non-mappable -> mappable moves then we > want TTM to see that

Re: [PATCH 09/20] drm/i915/buddy: tweak 2big check

2022-02-01 Thread Thomas Hellström
On Wed, 2022-01-26 at 15:21 +, Matthew Auld wrote: > Otherwise we get -EINVAL, instead of the more useful -E2BIG if the > allocation doesn't fit within the pfn range, like with mappable lmem. > The hugepages selftest, for example, needs this to know if a smaller > size is needed. > > Signed-of

[PATCH v5 00/19] drm/i915/dg2: Enabling 64k page size and flat ccs

2022-02-01 Thread Ramalingam C
This series introduces the enabling patches for new memory compression feature Flat CCS and 64k page support for i915 local memory, along with documentation on the uAPI impact. Included the details of the feature and the implications on the uAPI below. Which is also added into Documentation/gpu/rfc

[PATCH v5 01/19] drm/i915: add needs_compact_pt flag

2022-02-01 Thread Ramalingam C
Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only indicate requirement of 64K GTT page sizes or larger for device local memory access. v6: * minor doc formatting S

[PATCH v5 03/19] drm/i915: support 64K GTT pages for discrete cards

2022-02-01 Thread Ramalingam C
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no long

[PATCH v5 02/19] drm/i915: enforce min GTT alignment for discrete cards

2022-02-01 Thread Ramalingam C
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into account.

[PATCH v5 05/19] drm/i915/gtt: allow overriding the pt alignment

2022-02-01 Thread Ramalingam C
From: Matthew Auld On some platforms we have alignment restrictions when accessing LMEM from the GTT. In the next patch few patches we need to be able to modify the page-tables directly via the GTT itself. Suggested-by: Ramalingam C Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalin

[PATCH v5 04/19] drm/i915: add gtt misalignment test

2022-02-01 Thread Ramalingam C
From: Robert Beckett add test to check handling of misaligned offsets and sizes v4: * remove spurious blank lines * explicitly cast intel_region_id to intel_memory_type in misaligned_pin Reported-by: kernel test robot v6: * use NEEDS_COMPACT_PT instead of hard coding for

[PATCH v5 06/19] drm/i915/gtt: add xehpsdv_ppgtt_insert_entry

2022-02-01 Thread Ramalingam C
From: Matthew Auld If this is LMEM then we get a 32 entry PT, with each PTE pointing to some 64K block of memory, otherwise it's just the usual 512 entry PT. This very much assumes the caller knows what they are doing. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C Reviewed

[PATCH v5 07/19] drm/i915/migrate: add acceleration support for DG2

2022-02-01 Thread Ramalingam C
From: Matthew Auld This is all kinds of awkward since we now have to contend with using 64K GTT pages when mapping anything in LMEM(including the page-tables themselves). v2: Rebased [Ram] Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_mi

[PATCH v5 08/19] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-01 Thread Ramalingam C
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. v3: fix typos and less emphasis v2: Fixed suggestions on formatting

[PATCH v5 09/19] Doc/gpu/rfc/i915: i915 DG2 64k pagesize uAPI

2022-02-01 Thread Ramalingam C
Details of the 64k pagesize support added as part of DG2 enabling and its implicit impact on the uAPI. v2: improvised the Flat-CCS documentation [Danvet & CQ] v3: made only for 64k pagesize support Signed-off-by: Ramalingam C cc: Daniel Vetter cc: Matthew Auld cc: Simon Ser cc: Pekka Paalanen

[PATCH v5 10/19] drm/i915/xehpsdv: Add has_flat_ccs to device info

2022-02-01 Thread Ramalingam C
From: CQ Tang Platforms of XeHP and beyond support 3D surface (buffer) compression and various compression formats. This is accomplished by an additional compression control state (CCS) stored for each surface. Gen 12 devices(TGL family and DG1) stores compression states in a separate region of

[PATCH v5 11/19] drm/i915/lmem: Enable lmem for platforms with Flat CCS

2022-02-01 Thread Ramalingam C
From: Abdiel Janulgue A portion of device memory is reserved for Flat CCS so usable device memory will be reduced by size of Flat CCS. Size of Flat CCS is specified in “XEHPSDV_FLAT_CCS_BASE_ADDR”. So to get effective device memory we need to subtract total device memory by Flat CCS memory size.

[PATCH v5 12/19] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-02-01 Thread Ramalingam C
From: Ayaz A Siddiqui Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. Flat CCS memory can not be directly accessed by S/W. Ad

[PATCH v5 13/19] drm/i915: Introduce new Tile 4 format

2022-02-01 Thread Ramalingam C
From: Stanislav Lisovskiy This tiling layout uses 4KB tiles in a row-major layout. It has the same shape as Tile Y at two granularities: 4KB (128B x 32) and 64B (16B x 4). It only differs from Tile Y at the 256B granularity in between. At this granularity, Tile Y has a shape of 16B x 32 rows, but

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Pekka Paalanen
On Tue, 1 Feb 2022 10:49:03 +0100 Javier Martinez Canillas wrote: > On 2/1/22 09:38, Daniel Vetter wrote: > > On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > >> > >> On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven > >> wrote: > >> > >>> What's the story with the Rn formats? >

[PATCH v5 14/19] drm/i915/dg2: Tile 4 plane format support

2022-02-01 Thread Ramalingam C
From: Stanislav Lisovskiy Tile4 in bspec format is 4K tile organized into 64B subtiles with same basic shape as for legacy TileY which will be supported by Display13. v2: - Moved Tile4 assocating struct for modifier/display to the beginning(Imre Deak) - Removed unneeded case I915_FORMA

[PATCH v5 15/19] drm/i915/dg2: Add DG2 unified compression

2022-02-01 Thread Ramalingam C
From: Matt Roper DG2 unifies render compression and media compression into a single format for the first time. The programming and buffer layout is supposed to match compression on older gen12 platforms, but the actual compression algorithm is different from any previous platform; as such, we ne

[PATCH v5 16/19] uapi/drm/dg2: Introduce format modifier for DG2 clear color

2022-02-01 Thread Ramalingam C
From: Mika Kahola DG2 clear color render compression uses Tile4 layout. Therefore, we need to define a new format modifier for uAPI to support clear color rendering. v2: Display version is fixed. [Imre] KDoc is enhanced for cc modifier. [Nanley & Lionel] Signed-off-by: Mika Kahola cc: Ansh

[PATCH v5 17/19] drm/i915/dg2: Flat CCS Support

2022-02-01 Thread Ramalingam C
From: Anshuman Gupta DG2 onwards discrete gfx has support for new flat CCS mapping, which brings in display feature in to avoid Aux walk for compressed surface. This support build on top of Flat CCS support added in XEHPSDV. FLAT CCS surface base address should be 64k aligned, Compressed displaya

[PATCH v5 18/19] drm/i915/Flat-CCS: Document on Flat-CCS memory compression

2022-02-01 Thread Ramalingam C
Documents the Flat-CCS feature and kernel handling required along with modifiers used. Signed-off-by: Ramalingam C cc: Simon Ser cc: Pekka Paalanen Cc: Jordan Justen Cc: Kenneth Graunke Cc: mesa-...@lists.freedesktop.org Cc: Tony Ye Cc: Slawomir Milczarek --- drivers/gpu/drm/i915/gt/intel_

[PATCH v5 19/19] Doc/gpu/rfc/i915: i915 DG2 flat-CCS uAPI

2022-02-01 Thread Ramalingam C
Details of the Flat-CCS getting added as part of DG2 enabling and its implicit impact on the uAPI. Signed-off-by: Ramalingam C cc: Daniel Vetter cc: Matthew Auld cc: Simon Ser cc: Pekka Paalanen Cc: Jordan Justen Cc: Kenneth Graunke Cc: mesa-...@lists.freedesktop.org Cc: Tony Ye Cc: Slawom

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Greg Kroah-Hartman
On Tue, Feb 01, 2022 at 11:19:54AM +0100, Thomas Zimmermann wrote: > > > Am 31.01.22 um 22:05 schrieb Daniel Vetter: > > Ever since Tomi extracted the core code in 2014 it's been defacto me > > maintaining this, with help from others from dri-devel and sometimes > > Linus (but those are mostly me

[Bug 215549] My 6900XT can't recover while it's idle (but not asleep), and sometimes doesn't show at boot

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215549 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v5 07/19] drm/i915/migrate: add acceleration support for DG2

2022-02-01 Thread Matthew Auld
On 01/02/2022 10:41, Ramalingam C wrote: From: Matthew Auld This is all kinds of awkward since we now have to contend with using 64K GTT pages when mapping anything in LMEM(including the page-tables themselves). v2: Rebased [Ram] Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramaling

[PATCH v3] fbdev: fbmem: Fix the implicit type casting

2022-02-01 Thread Yizhuo Zhai
In function do_fb_ioctl(), the "arg" is the type of unsigned long, and in "case FBIOBLANK:" this argument is casted into an int before passig to fb_blank(). In fb_blank(), the comparision if (blank > FB_BLANK_POWERDOWN) would be bypass if the original "arg" is a large number, which is possible beca

[PATCH v3] fbdev: fbmem: Fix the implicit type casting

2022-02-01 Thread Yizhuo Zhai
In function do_fb_ioctl(), the "arg" is the type of unsigned long, and in "case FBIOBLANK:" this argument is casted into an int before passig to fb_blank(). In fb_blank(), the comparision if (blank > FB_BLANK_POWERDOWN) would be bypass if the original "arg" is a large number, which is possible beca

Re: [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 11:36, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: >> >> On 1/31/22 22:05, Daniel Vetter wrote: >>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated >>> scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION >>> option. >> >>

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Pekka, On Tue, Feb 1, 2022 at 11:42 AM Pekka Paalanen wrote: > On Tue, 1 Feb 2022 10:49:03 +0100 > Javier Martinez Canillas wrote: > > On 2/1/22 09:38, Daniel Vetter wrote: > > > On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > > >> On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeve

Re: [PATCH] drm/panel: simple: Assign data from panel_dpi_probe() correctly

2022-02-01 Thread Marek Vasut
On 2/1/22 12:01, Christoph Niedermaier wrote: In the function panel_simple_probe() the pointer panel->desc is assigned to the passed pointer desc. If function panel_dpi_probe() is called panel->desc will be updated, but further on only desc will be evaluated. So update the desc pointer to be able

Re: [PATCH] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check()

2022-02-01 Thread Marek Vasut
On 2/1/22 12:03, Christoph Niedermaier wrote: If display timings were read from the devicetree using of_get_display_timing() and pixelclk-active is defined there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is automatically generated. Through the function drm_bus_flags_from_videomode() e.g. calle

Re: [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed()

2022-02-01 Thread Pekka Paalanen
On Tue, 1 Feb 2022 10:59:43 +0100 Thomas Zimmermann wrote: > Hi > > Am 31.01.22 um 21:12 schrieb Javier Martinez Canillas: > > Add support to convert 8-bit grayscale to reversed monochrome for drivers > > that control monochromatic displays, that only have 1 bit per pixel depth. > > > > This he

Re: [PULL] drm-misc-next

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 09:17 schrieb Maarten Lankhorst: Op 01-02-2022 om 07:38 schreef Dave Airlie: On Thu, 27 Jan 2022 at 21:57, Maarten Lankhorst wrote: Hi Dave & Daniel, First pull for v5.18 I was trying to be all efficient and get this pulled in time for once. However it broke building on

[Bug 215558] New: amdgpu driver sometimes crashes when playing games

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215558 Bug ID: 215558 Summary: amdgpu driver sometimes crashes when playing games Product: Drivers Version: 2.5 Kernel Version: 5.15 Hardware: All OS: Linux Tree: Ma

[Bug 215558] amdgpu driver sometimes crashes when playing games

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215558 smoe...@uni-bremen.de changed: What|Removed |Added Component|Video(DRI - non Intel) |Video(Other) -- You may reply to

Re: [PATCH 4/4] MAINTAINERS: Add entry for Solomon SSD1307 OLED displays DRM driver

2022-02-01 Thread Javier Martinez Canillas
Hello Andy, On 2/1/22 10:32, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 09:15:37PM +0100, Javier Martinez Canillas wrote: >> To make sure that tools like the get_maintainer.pl script will suggest >> to Cc me if patches are posted for this driver. >> >> Also include the Device Tree binding fo

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:37, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: >> On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: > > ... > >>> Patch #3 adds the driver. The name ssd1307 was used instead of ssd130x >>> (which would be more accura

Re: [PATCH -next 1/2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err()

2022-02-01 Thread Helge Deller
On 2/1/22 07:26, Yang Li wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > Eliminate the follow coccicheck warning: > ./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because > platform_get_irq() already prints an error > > R

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 1, 2022 at 12:31 PM Javier Martinez Canillas wrote: > On 2/1/22 10:37, Andy Shevchenko wrote: > > On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: > >> On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: > > > > ... > > > >>> Patch #3 adds

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:41, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote: >> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote: > > ... > >>> +config TINYDRM_SSD1307 >>> + tristate "DRM support for Solomon SSD1307 OLED displays" >> Use SSD130

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:44, Andy Shevchenko wrote: > On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote: >> On 1/31/22 22:30, Sam Ravnborg wrote: >>> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote: > > ... > >>> The driver uses the pwms property for the backli

Re: [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed()

2022-02-01 Thread Javier Martinez Canillas
Hello Thomas, Thanks a lot for your feedback. On 2/1/22 10:59, Thomas Zimmermann wrote: > Hi > > Am 31.01.22 um 21:12 schrieb Javier Martinez Canillas: >> Add support to convert 8-bit grayscale to reversed monochrome for drivers >> that control monochromatic displays, that only have 1 bit per pi

[PATCH v2] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-02-01 Thread Thomas Zimmermann
Mark screen buffers in system memory with FB_VIRTFB. Otherwise, fbdev deferred I/O marks mmap'ed areas of system memory with VM_IO. (There's an inverse relation ship between the two flags.) For shadow buffers, also set the FB_READS_FAST hint. v2: * updated commit description (Daniel)

[PATCH -next 1/2 v2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err()

2022-02-01 Thread Yang Li
The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang L

[PATCH -next 2/2 v2] video: fbdev: pxa3xx-gcu: Remove unnecessary print function dev_err()

2022-02-01 Thread Yang Li
The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/video/fbdev/pxa3xx-gcu.c:615:2-9: line 615 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
Den 31.01.2022 21.52, skrev Sam Ravnborg: > On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >> There isn't a connector type for display controllers accesed through I2C, >> most drivers use DRM_MODE_CONNECTOR_Unknown or DRM_MODE_CONNECTOR_VIRTUAL. >> >> Add an I2C connec

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:33, Thomas Zimmermann wrote: > Hi Javier, > > please see comments and questions below. > Thanks again for your comments. [snip] >> >> +config TINYDRM_SSD1307 > > TINYDRM is so 2010's. Just call it DRM. > Haha, Ok. I just followed what other drivers did and thought was a conve

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Javier Martinez Canillas
Hello Noralf, On 2/1/22 13:58, Noralf Trønnes wrote: > > > Den 31.01.2022 21.52, skrev Sam Ravnborg: >> On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >>> There isn't a connector type for display controllers accesed through I2C, >>> most drivers use DRM_MODE_CONNECTOR_

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
Hello Geert, On 2/1/22 12:38, Geert Uytterhoeven wrote: [snip] >> >> Since the current binding has a compatible "ssd1305fb-i2c", we could make the >> new one "ssd1305drm-i2c" or better, just "ssd1305-i2c". > > DT describes hardware, not software policy. > If the hardware is the same, the DT bin

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
Den 01.02.2022 14.06, skrev Javier Martinez Canillas: > Hello Noralf, > > On 2/1/22 13:58, Noralf Trønnes wrote: >> >> >> Den 31.01.2022 21.52, skrev Sam Ravnborg: >>> On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: There isn't a connector type for display control

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 13:58, Noralf Trønnes wrote: > It turned out that I wasn't entirely correct here, mpv didn't cope with > unknown types. In the PR to add support Emil Velikov wondered if libdrm > should handle these connector names: Opened this MR to try to make things easier

Re: [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 12:01 PM Helge Deller wrote: > On 2/1/22 11:36, Daniel Vetter wrote: > > On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: > >> > >> On 1/31/22 22:05, Daniel Vetter wrote: > >>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated > >>> scrolling"), but behi

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 14:20, Noralf Trønnes wrote: > > > Den 01.02.2022 14.06, skrev Javier Martinez Canillas: >> Hello Noralf, >> >> On 2/1/22 13:58, Noralf Trønnes wrote: >>> >>> >>> Den 31.01.2022 21.52, skrev Sam Ravnborg: On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >>>

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Javier Martinez Canillas
On 1/31/22 22:05, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 > 35

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Tue, Feb 01, 2022 at 12:45:53PM +0100, Javier Martinez Canillas wrote: > On 2/1/22 10:44, Andy Shevchenko wrote: > > On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote: ... > > The problem with no backward compatibility means that removal of old driver > > makes users unh

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 1, 2022 at 2:02 PM Javier Martinez Canillas wrote: > On 2/1/22 10:33, Thomas Zimmermann wrote: > >> +{ > >> +u8 col_end = col_start + cols - 1; > >> +int ret; > >> + > >> +if (col_start == ssd1307->col_start && col_end == ssd1307->col_end) > >> +retu

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 1, 2022 at 2:09 PM Javier Martinez Canillas wrote: > On 2/1/22 12:38, Geert Uytterhoeven wrote: > >> Since the current binding has a compatible "ssd1305fb-i2c", we could make > >> the > >> new one "ssd1305drm-i2c" or better, just "ssd1305-i2c". > > > > DT describes hardwar

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
Den 01.02.2022 14.38, skrev Simon Ser: > > On Tuesday, February 1st, 2022 at 13:58, Noralf Trønnes > wrote: > >> It turned out that I wasn't entirely correct here, mpv didn't cope with >> unknown types. In the PR to add support Emil Velikov wondered if libdrm >> should handle these connector

  1   2   3   >