Re: [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offse

[PATCH] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-01-27 Thread RyanLin
[Why] External displays take priority over internal display when there are fewer display controllers than displays. [How] The root cause is because of that number of the crtc is not correct. The number of the crtc on the 3250c is 3, but on the 3500c is 4. On the source code, we can see that numbe

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to init

[PATCH] drm/doc: Add section in the introduction page about learning material

2022-01-27 Thread Javier Martinez Canillas
The Linux DRM subsystem supports complex graphics devices and it could be quite overwhelming for newcomers to learn about the subsystem's internals. There are lots of useful talks, slides and articles available that can be used to get familiar with the needed concepts and ease the learning curve.

[PATCH] drm/tilcdc: Fix typo in comment

2022-01-27 Thread tangmeng
Replace disbale with disable Signed-off-by: tangmeng --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 29890d704cb4..b986946b3b10 100644 --- a/drivers/gpu

Re: [PATCH v1, 4/8] media: mtk-vcodec: Adds compatible for mt8195

2022-01-27 Thread Macpaul Lin
On 1/27/22 10:55 AM, Yunfei Dong wrote: Adds compatible for mt8195 platform. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/

[PATCH on v5.17-rc1 11/14] dept: Introduce split map concept and new APIs for them

2022-01-27 Thread Byungchul Park
There is a case where all maps used for a type of wait/event is so large in size. For instance, struct page can be a type for (un)lock_page(). The additional memory size for the maps would be 'the # of pages * sizeof(struct dept_map)' if each struct page keeps its map all the way, which might be to

[PATCH on v5.17-rc1 04/14] dept: Apply Dept to spinlock

2022-01-27 Thread Byungchul Park
Makes Dept able to track dependencies by spinlock. Signed-off-by: Byungchul Park --- include/linux/lockdep.h| 18 +++--- include/linux/spinlock.h | 24 include/linux/spinlock_types_raw.h | 13 + 3 files changed, 52 insertions

Patches(Dept) for v5.17-rc1

2022-01-27 Thread Byungchul Park
The following messages are for the latest tag, v5.17-rc1. Hope you are gonna be satisfied with it! Thanks, Byungchul --->8--- >From 68ee7ab996fc7d67b6b506f48da106493ca2546a Mon Sep 17 00:00:00 2001 From: Byungchul Park Date: Tue, 25 Jan 2022 10:12:54 +0900 Subject: [RFC 00/14] DEPT(DEPendency Tr

Re: [PATCH v1, 3/8] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8195

2022-01-27 Thread Macpaul Lin
On 1/27/22 10:55 AM, Yunfei Dong wrote: Adds decoder dt-bindings for mt8195. Signed-off-by: Yunfei Dong --- .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-dec

[PATCH on v5.17-rc1 06/14] dept: Apply Dept to rwlock

2022-01-27 Thread Byungchul Park
Makes Dept able to track dependencies by rwlock. Signed-off-by: Byungchul Park --- include/linux/lockdep.h| 25 +- include/linux/rwlock.h | 48 ++ include/linux/rwlock_api_smp.h | 8 +++ include/linux/rwlock_types.h

Re: [PATCH v1, 6/8] media: mtk-vcodec: prevent kernel crash when scp ipi timeout

2022-01-27 Thread Macpaul Lin
On 1/27/22 10:55 AM, Yunfei Dong wrote: From: Tinghan Shen When SCP timeout during playing video, kernel crashes with following message. It's caused by accessing NULL pointer in vpu_dec_ipi_handler. This patch doesn't solve the root cause of NULL pointer, but merely prevent kernel crashed whe

[PATCH on v5.17-rc1 07/14] dept: Apply Dept to wait_for_completion()/complete()

2022-01-27 Thread Byungchul Park
Makes Dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 42 -- kernel/sched/completion.c | 12 ++-- 2 files changed, 50 insertions(+), 4 deletions(-) diff --git a/i

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-27 Thread Sven Schnelle
Helge Deller writes: > On 1/26/22 12:24, Daniel Vetter wrote: >> And that point was about 5 years ago, and has been discussed at some >> plumbers meanwhile, resulting in the staging TODO patches to make >> these drm drivers to destage them. >> >> Fixing bugs in fbdev is all fine, reopening it for

[PATCH on v5.17-rc1 02/14] dept: Implement Dept(Dependency Tracker)

2022-01-27 Thread Byungchul Park
CURRENT STATUS -- Lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. Lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm a

[PATCH on v5.17-rc1 01/14] llist: Move llist_{head, node} definition to types.h

2022-01-27 Thread Byungchul Park
llist_head and llist_node can be used by very primitives. For example, Dept for tracking dependency uses llist things in its header. To avoid header dependency, move those to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2 file

[PATCH on v5.17-rc1 08/14] dept: Apply Dept to seqlock

2022-01-27 Thread Byungchul Park
Makes Dept able to track dependencies by seqlock with adding wait annotation on read side of seqlock. Signed-off-by: Byungchul Park --- include/linux/seqlock.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/include/linux/seqlock.h b/include/linux/seqlock.

[PATCH on v5.17-rc1 03/14] dept: Embed Dept data in Lockdep

2022-01-27 Thread Byungchul Park
Dept should work independently from Lockdep. However, there's no choise but to rely on Lockdep code and its instances for now. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 71 --- include/linux/lockdep_types.h | 3 ++ kernel/locking/l

[PATCH on v5.17-rc1 12/14] dept: Apply Dept to wait/event of PG_{locked, writeback}

2022-01-27 Thread Byungchul Park
Makes Dept able to track dependencies by PG_{locked,writeback}. For instance, (un)lock_page() generates that type of dependency. Signed-off-by: Byungchul Park --- include/linux/dept_page.h | 71 + include/linux/page-flags.h | 43

[PATCH on v5.17-rc1 09/14] dept: Apply Dept to rwsem

2022-01-27 Thread Byungchul Park
Makes Dept able to track dependencies by rwsem. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 24 include/linux/percpu-rwsem.h | 10 +- include/linux/rwsem.h| 31 +++ 3 files changed, 60 insertions(+), 5 dele

[PATCH on v5.17-rc1 10/14] dept: Add proc knobs to show stats and dependency graph

2022-01-27 Thread Byungchul Park
It'd be useful to show Dept internal stats and dependency graph on runtime via proc for better information. Introduced the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 24 -- kernel/dependency/dept_internal.h | 26

[PATCH on v5.17-rc1 05/14] dept: Apply Dept to mutex families

2022-01-27 Thread Byungchul Park
Makes Dept able to track dependencies by mutex families. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 18 +++--- include/linux/mutex.h | 31 +++ include/linux/rtmutex.h | 7 +++ 3 files changed, 53 insertions(+), 3 deletions(-) diff

[PATCH on v5.17-rc1 14/14] dept: Apply SDT to swait

2022-01-27 Thread Byungchul Park
Makes SDT able to track dependencies by swait. Signed-off-by: Byungchul Park --- include/linux/swait.h | 4 kernel/sched/swait.c | 8 2 files changed, 12 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index 6a8c22b..dbdf2ce 100644 --- a/include/linux/swa

[PATCH on v5.17-rc1 13/14] dept: Separate out SDT(Single-event Dependency Tracker) header

2022-01-27 Thread Byungchul Park
Now that Dept has already been applied to major synchronization machanisms e.g. spinlock, wait_for_completion and the like, we can take advantage of Dept by default if CONFIG_DEPT is on. However, sometimes we need to manually tag wait/event on places where Dept hasn't been applied. SDT(Single-even

Re: [RFC 00/14] DEPT(DEPendency Tracker)

2022-01-27 Thread Byungchul Park
+cc linux...@kvack.org a...@linux-foundation.org mho...@kernel.org minc...@kernel.org han...@cmpxchg.org vdavydov@gmail.com s...@kernel.org jgli...@redhat.com den...@kernel.org c...@linux.com penb...@kernel.org rient...@google.com vba...@suse.cz ngu...@vflare.org linux-bl...@vger.kernel.org ax

[PATCH] drivers: Fix typo in comment

2022-01-27 Thread tangmeng
Replace disbale with disable and replace unavaibale with unavailable. Signed-off-by: tangmeng --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- drivers/pcmcia/rsrc_nonstatic.c | 2 +- drivers/usb/chipidea/udc.c| 2 +- 4 files change

[PATCH] drm/amd/amdgpu: fix spelling mistake "disbale" -> "disable"

2022-01-27 Thread tangmeng
There is a spelling mistake. Fix it. Signed-off-by: tangmeng --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c index aef9d059ae52..a642c04cf17d 100644 --- a/

Re: [PATCH 04/12] drm/ttm: add common accounting to the resource mgr v2

2022-01-27 Thread Daniel Vetter
On Wed, Jan 26, 2022 at 03:42:21PM +0100, Christian König wrote: > Am 25.01.22 um 17:37 schrieb Daniel Vetter: > > On Mon, Jan 24, 2022 at 01:25:06PM +0100, Christian König wrote: > > > It makes sense to have this in the common manager for debugging and > > > accounting of how much resources are us

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: [SNIP] humn... not sure i

Re: [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: > Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > > On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: > > > Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > > > > When dma_buf_map struct is passed around, it's useful to

Re: [PATCH] drm: rcar-du: Drop LVDS device tree backward compatibility

2022-01-27 Thread Geert Uytterhoeven
Hi Laurent, Thanks for your patch! On Wed, Jan 26, 2022 at 9:30 PM Laurent Pinchart wrote: > The rcar-du driver goes to great lengths to preserve device tree > backward compatibility for the LVDS encoders by patching old device > trees at runtime. > > The last R-Car Gen2 platform was converted t

Re: [Intel-gfx] [PATCH 01/19] dma-buf-map: Add read/write helpers

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 08:59:36AM +0100, Christian König wrote: > Am 27.01.22 um 08:36 schrieb Matthew Brost: > > [SNIP] > > > >/** > > > > * dma_buf_map_memcpy_to - Memcpy into dma-buf mapping > > > > * @dst: The dma-buf mapping structure > > > > @@ -263,4 +304,44 @@ static inline

[PULL] drm-misc-fixes

2022-01-27 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. Besides the bug fixes, it contains a backmerge from drm/drm-fixes to get the tree to v5.17-rc1. Best regards Thomas drm-misc-fixes-2022-01-27: * drm/ast: Revert 1600x800 with 108MHz PCLK * drm/atomic: fix CRTC handling during modese

Re: [PATCH] drm/doc: Add section in the introduction page about learning material

2022-01-27 Thread Pekka Paalanen
On Thu, 27 Jan 2022 09:20:58 +0100 Javier Martinez Canillas wrote: > The Linux DRM subsystem supports complex graphics devices and it could be > quite overwhelming for newcomers to learn about the subsystem's internals. > > There are lots of useful talks, slides and articles available that can b

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:55:05AM +0100, Christian König wrote: Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-27 Thread Maxime Ripard
On Wed, Jan 26, 2022 at 03:30:35PM +0200, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 12:38:09PM +0100, Helge Deller wrote: > > On 1/26/22 12:24, Daniel Vetter wrote: > > > On Wed, Jan 26, 2022 at 12:18 PM Javier Martinez Canillas > > > wrote: > > >> On 1/26/22 11:59, Helge Deller wrote: > >

Re: [PATCH] drm/doc: Add section in the introduction page about learning material

2022-01-27 Thread Thomas Zimmermann
Hi Javier, thanks for this patch. Acked-by: Thomas Zimmermann Find some ideas for consideration below. Am 27.01.22 um 09:20 schrieb Javier Martinez Canillas: The Linux DRM subsystem supports complex graphics devices and it could be quite overwhelming for newcomers to learn about the subsyste

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 10:12 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:55:05AM +0100, Christian König wrote: Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 0

Re: [PATCH v1, 7/8] media: uapi: Init VP9 stateless decode params

2022-01-27 Thread Chen-Yu Tsai
Hi, On Thu, Jan 27, 2022 at 10:56 AM Yunfei Dong wrote: > > Init some of VP9 frame decode params to default value. > > Signed-off-by: Yunfei Dong Maybe add Fixes: b88dbe38dca8 ("media: uapi: Add VP9 stateless decoder controls") > --- > drivers/media/v4l2-core/v4l2-ctrls-core.c | 8 >

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-01-27 Thread Sascha Hauer
Hi Peter, On Wed, Jan 26, 2022 at 03:24:26PM -0500, Peter Geis wrote: > The hdmi-cec clock must be 32khz in order for cec to work correctly. > Ensure after enabling the clock we set it in order for the hardware to > work as expected. > Warn on failure, in case this is a static clock that is slight

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: > > Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > > >

RE: [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-27 Thread Kandpal, Suraj
> > + laurent on this > > Hi Suraj > Jani pointed me to this thread as i had posted something similar here : > https://patchwork.freedesktop.org/patch/470296/ but since this thread was > posted earlier, we can discuss further here. > > Overall, its similar to what I had posted in the RFC and you

Re: [PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-27 Thread Maxime Ripard
Hi Rob, On Mon, Jan 24, 2022 at 10:42:37AM -0600, Rob Herring wrote: > On Mon, Jan 24, 2022 at 10:28 AM Noralf Trønnes wrote: > > > > > > > > Den 24.01.2022 17.08, skrev Rob Herring: > > > On Sun, Jan 23, 2022 at 11:25 AM Noralf Trønnes > > > wrote: > > >> > > >> Add binding for MIPI DBI compat

Re: [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-27 Thread Maxime Ripard
Hi, On Tue, Jan 25, 2022 at 06:56:58PM +0100, Noralf Trønnes wrote: > Add binding for MIPI DBI compatible SPI panels. > > v2: > - Fix path for panel-common.yaml > - Use unevaluatedProperties > - Drop properties which are in the allOf section > - Drop model property (Rob) > > Signed-off-by: Noral

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: add needs_compact_pt flag

2022-01-27 Thread Intel
On 1/26/22 18:11, Robert Beckett wrote: On 26/01/2022 13:49, Thomas Hellström (Intel) wrote: On 1/25/22 20:35, Robert Beckett wrote: From: Ramalingam C Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages.

Re: mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h)

2022-01-27 Thread Jani Nikula
On Wed, 26 Jan 2022, Randy Dunlap wrote: > On 1/26/22 21:04, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2022-01-26-21-04 has been uploaded to >> >>https://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >> https://www.ozl

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: > On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: > > On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: > > > Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > > > > On Thu, Jan 27, 2022 at 08:27:11AM +0100

Re: [RFC PATCH v5 0/3] Add support modifiers for drivers whose planes only support linear layout

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 12:25:36PM +0900, Tomohito Esaki wrote: > Some drivers whose planes only support linear layout fb do not support format > modifiers. > These drivers should support modifiers, however the DRM core should handle > this > rather than open-coding in every driver. > > In this p

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Maxime Ripard
On Tue, Jan 25, 2022 at 06:57:00PM +0100, Noralf Trønnes wrote: > Add a driver that will work with most MIPI DBI compatible SPI panels. > This avoids adding a driver for every new MIPI DBI compatible controller > that is to be used by Linux. The 'compatible' Device Tree property with > a '.bin' suf

Re: [PATCH] drivers: Fix typo in comment

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 07:56:05AM +0100, Greg KH wrote: > On Thu, Jan 27, 2022 at 02:51:56PM +0800, tangmeng wrote: > > Replace disbale with disable and replace unavaibale with unavailable. > > > > Signed-off-by: tangmeng > > --- > > drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +- > > drivers/gpu

[PATCH v2] drm/v3d: fix missing unlock

2022-01-27 Thread Yongzhi Liu
[why] Unlock is needed on the error handling path to prevent dead lock. v3d_submit_cl_ioctl and v3d_submit_csd_ioctl is missing unlock. [how] Fix this by change goto target on the error handling path. As unlock is handle in fail_unreserve, i keep the failures handling around there. So the goto tar

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Ja

[PATCH] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-01-27 Thread Thomas Zimmermann
Mark screen buffers in system memory with FB_VIRTFB. Otherwise, the buffers are mmap'ed as I/O memory (i.e., VM_IO). For shadow buffers, also set the FB_READS_FAST hint. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletio

[PATCH 1/2] drm/gem-shmem: Set vm_ops in static initializer

2022-01-27 Thread Thomas Zimmermann
Initialize default vm_ops in static initialization of the GEM SHMEM funcs, instead of the mmap code. It's simply better style. GEM helpers will later set a VMA's vm_ops from the default automatically. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 +++- 1 file ch

[PATCH 2/2] drm/gem-shmem: Don't store mmap'ed buffers in core dumps

2022-01-27 Thread Thomas Zimmermann
Set the VM_DONTDUMP flag on mmap'ed VMAs to omit them from core dumps. It's display-buffer memory; who knows what secrets these buffers contain. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-01-27 Thread Thomas Zimmermann
Am 27.01.22 um 11:26 schrieb Thomas Zimmermann: Mark screen buffers in system memory with FB_VIRTFB. Otherwise, the FBINFO_ is the name. Will be fixed before merging buffers are mmap'ed as I/O memory (i.e., VM_IO). For shadow buffers, also set the FB_READS_FAST hint. Signed-off-by: Thomas

Re: [PATCH v2] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-27 Thread AngeloGioacchino Del Regno
Il 12/01/22 08:09, Jagan Teki ha scritto: On Tue, Jan 4, 2022 at 3:30 PM AngeloGioacchino Del Regno wrote: DRM bridge drivers are now attaching their DSI device at probe time, which requires us to register our DSI host in order to let the bridge to probe: this recently started producing an end

Re: [PATCH v1, 7/8] media: uapi: Init VP9 stateless decode params

2022-01-27 Thread AngeloGioacchino Del Regno
Il 27/01/22 03:55, Yunfei Dong ha scritto: Init some of VP9 frame decode params to default value. Signed-off-by: Yunfei Dong Hello Yunfei, This patch is not strictly related to MediaTek SoCs, since it's modfying v4l2-core. Can you please send this patch separately? Thanks, Angelo --- dr

Re: [PATCH] drm/doc: Add section in the introduction page about learning material

2022-01-27 Thread Javier Martinez Canillas
Hello Pekka, Thanks a lot for your feedback. On 1/27/22 10:05, Pekka Paalanen wrote: > On Thu, 27 Jan 2022 09:20:58 +0100 > Javier Martinez Canillas wrote: > >> The Linux DRM subsystem supports complex graphics devices and it could be >> quite overwhelming for newcomers to learn about the subsy

Re: [PATCH] drm/doc: Add section in the introduction page about learning material

2022-01-27 Thread Javier Martinez Canillas
Hello Thomas, On 1/27/22 10:18, Thomas Zimmermann wrote: > Hi Javier, > > thanks for this patch. > > Acked-by: Thomas Zimmermann > Thanks! > Find some ideas for consideration below. > [snip] >> + >> +Learning material >> += > > Maybe 'External References'. > Agreed, I'll

Re: [PATCH 27/27] drm: rockchip: Add VOP2 driver

2022-01-27 Thread Sascha Hauer
On Thu, Jan 27, 2022 at 10:17:13AM +0100, Piotr Oniszczuk wrote: > Sascha, > > FYI > small report regarding 4k modes support in v4: > > -on rk3399 it gives me 4k screen where right vertical 1/3 part of screen is > garbage > -on rk3566 my samsung 4k monitor has black screen and cycle of OSD msgs

Re: [PATCH 09/27] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always

2022-01-27 Thread Sascha Hauer
On Wed, Jan 26, 2022 at 07:42:48AM -0800, Doug Anderson wrote: > Hi, > > On Wed, Jan 26, 2022 at 6:58 AM Sascha Hauer wrote: > > > > From: Douglas Anderson > > > > Jitter was improved by lowering the MPLL bandwidth to account for high > > frequency noise in the rk3288 PLL. In each case MPLL ban

Re: [PATCH] drm/doc: Add section in the introduction page about learning material

2022-01-27 Thread Pekka Paalanen
On Thu, 27 Jan 2022 11:46:44 +0100 Javier Martinez Canillas wrote: > Hello Pekka, > > Thanks a lot for your feedback. > > On 1/27/22 10:05, Pekka Paalanen wrote: > > On Thu, 27 Jan 2022 09:20:58 +0100 > > Javier Martinez Canillas wrote: > > > >> The Linux DRM subsystem supports complex grap

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 11:32:58AM +0100, Dmitry Vyukov wrote: > On Thu, 27 Jan 2022 at 07:30, Dan Carpenter wrote: > > > > On Wed, Jan 26, 2022 at 11:31:02PM +0100, Daniel Vetter wrote: > > > dOn Wed, Jan 26, 2022 at 3:46 PM Dan Carpenter > > > wrote: > > > > > > > > The other advantage of stag

[PATCH] drm/vc4: hdmi: Simplify the connector state retrieval

2022-01-27 Thread Maxime Ripard
When we have the entire DRM state, retrieving the connector state only requires the drm_connector pointer. Fortunately for us, we have allocated it as a part of the vc4_hdmi structure, so we can retrieve get a pointer by simply accessing our field in that structure. Signed-off-by: Maxime Ripard -

[PATCH] drm/vc4: hdmi: Unregister codec device on unbind

2022-01-27 Thread Maxime Ripard
On bind we will register the HDMI codec device but we don't unregister it on unbind, leading to a device leakage. Unregister our device at unbind. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 8 drivers/gpu/drm/vc4/vc4_hdmi.h | 1 + 2 files changed, 9 insertions(+)

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: > Am 27.01.22 um 11:00 schrieb Daniel Vetter: > > On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: > > > On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: > > > > On Thu, Jan 27, 2022 at 09:02:54AM +0100,

Re: [PATCH v1] drm/panel: simple: Tune timing for ET057090DHU

2022-01-27 Thread kernel test robot
Hi Francesco, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v5.17-rc1 next-20220127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH 07/27] drm/rockchip: dw_hdmi: Use auto-generated tables

2022-01-27 Thread Sascha Hauer
On Wed, Jan 26, 2022 at 07:54:53AM -0800, Doug Anderson wrote: > Hi, > > On Wed, Jan 26, 2022 at 6:58 AM Sascha Hauer wrote: > > > > From: Douglas Anderson > > > > The previous tables for mpll_cfg and curr_ctrl were created using the > > 20-pages of example settings provided by the PHY vendor.

Re: [PATCH] drm/vc4: hdmi: Simplify the connector state retrieval

2022-01-27 Thread Thomas Zimmermann
Am 27.01.22 um 12:14 schrieb Maxime Ripard: When we have the entire DRM state, retrieving the connector state only requires the drm_connector pointer. Fortunately for us, we have allocated it as a part of the vc4_hdmi structure, so we can retrieve get a pointer by simply accessing our field in

Re: [PATCH] drm/doc: Add section in the introduction page about learning material

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 11:50:30AM +0100, Javier Martinez Canillas wrote: > Hello Thomas, > > On 1/27/22 10:18, Thomas Zimmermann wrote: > > Hi Javier, > > > > thanks for this patch. > > > > Acked-by: Thomas Zimmermann > > > > Thanks! > > > Find some ideas for consideration below. > > > >

Re: [PATCH] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 11:26:21AM +0100, Thomas Zimmermann wrote: > Mark screen buffers in system memory with FB_VIRTFB. Otherwise, the > buffers are mmap'ed as I/O memory (i.e., VM_IO). For shadow buffers, > also set the FB_READS_FAST hint. Maybe clarify that this only holds for the defio case,

Re: [Linaro-mm-sig] Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 12:16 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan

[PATCH v2] drm/panel: simple: Tune timing for ET057090DHU

2022-01-27 Thread Francesco Dolcini
From: Oleksandr Suvorov VESA Display Monitor Timing v1.13 has recommendations for the historical VGA mode 640x480 60Hz. These parameters are compatible with EDT ET057090DHU recommended timings. Use VESA DMT timing parameters for EDT ET057090DHU panel. Signed-off-by: Oleksandr Suvorov Cc: Oleks

[PATCH] drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Thomas Hellström
The vma destruction code was using an unlocked advisory check for drm_mm_node_allocated() to avoid racing with eviction code unbinding the vma. This is very fragile and prohibits the dereference of non-refcounted pointers of dying vmas after a call to __i915_vma_unbind(). It also prohibits the der

Re: [Linaro-mm-sig] Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 12:44:21PM +0100, Christian König wrote: > Am 27.01.22 um 12:16 schrieb Daniel Vetter: > > On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: > > > Am 27.01.22 um 11:00 schrieb Daniel Vetter: > > > > On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wro

Re: [PATCH] drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Maarten Lankhorst
Op 27-01-2022 om 12:56 schreef Thomas Hellström: > The vma destruction code was using an unlocked advisory check for > drm_mm_node_allocated() to avoid racing with eviction code unbinding > the vma. > > This is very fragile and prohibits the dereference of non-refcounted > pointers of dying vmas af

[PULL] drm-misc-next

2022-01-27 Thread Maarten Lankhorst
Hi Dave & Daniel, First pull for v5.18 drm-misc-next-2022-01-27: drm-misc-next for v5.18: UAPI Changes: - Fix invalid IN_FORMATS blob when plane->format_mod_supported is NULL. Cross-subsystem Changes: - Assorted dt bindings updates. - Fix vga16fb vga checking on x86. - Fix extra semicolon in rw

Re: [PATCH] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-01-27 Thread Thomas Zimmermann
Hi Am 27.01.22 um 12:42 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 11:26:21AM +0100, Thomas Zimmermann wrote: Mark screen buffers in system memory with FB_VIRTFB. Otherwise, the buffers are mmap'ed as I/O memory (i.e., VM_IO). For shadow buffers, also set the FB_READS_FAST hint. Maybe cla

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Maarten Lankhorst
Op 26-01-2022 om 13:55 schreef Gwan-gyeong Mun: > > > On 1/26/22 9:37 AM, Maarten Lankhorst wrote: >> set_cache_level may unbind the object, which will result in the below >> lockdep splat: >> <6> [184.578145] [IGT] kms_addfb_basic: starting subtest >> addfb25-framebuffer-vs-set-tiling >> <4> [184

[PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Zhi Wang
From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g initialization path has to be separated into two phases: a) Early initialization. The early initialization of GVT requires to be done when lo

[PATCH 2/3] i915/gvt: save the initial HW state snapshot in i915.

2022-01-27 Thread Zhi Wang
Save the inital HW state snapshot in i915 so that the rest code of GVT-g can be moved into a dedicated module while it can still get a clean initial HW state saved at the correct time during the initialization of i915. The futhrer vGPU created by GVT-g will use this HW state as the initial HW state

[PATCH 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-01-27 Thread Zhi Wang
The code of saving initial HW state snapshot has been moved into i915. Let the GVT-g core logic use that snapshot. Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Vivi Rodrigo Cc: Zhenyu Wang Cc: Zhi Wang Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/g

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On Thu, 2022-01-27 at 13:02 +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 13:55 schreef Gwan-gyeong Mun: > > > > > > On 1/26/22 9:37 AM, Maarten Lankhorst wrote: > > > set_cache_level may unbind the object, which will result in the > > > below > > > lockdep splat: > > > <6> [184.578145] [IGT

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On 1/27/22 13:05, Thomas Hellström wrote: The bug on vm_close is a separate bug, and would probably best be fixed in a separate patch. Could I get a r-b on this? It should fix some issues, even if the unbind there is a separate bug. ~Maarten Recognizing that it doesn't fix the vm_close is

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Maarten Lankhorst
Op 27-01-2022 om 13:09 schreef Thomas Hellström: > > On 1/27/22 13:05, Thomas Hellström wrote: >> >>> The bug on vm_close is a separate bug, and would probably best be >>> fixed in a separate patch. >>> >>> Could I get a r-b on this? It should fix some issues, even if the >>> unbind there is a sepa

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On 1/27/22 13:38, Maarten Lankhorst wrote: Op 27-01-2022 om 13:09 schreef Thomas Hellström: On 1/27/22 13:05, Thomas Hellström wrote: The bug on vm_close is a separate bug, and would probably best be fixed in a separate patch. Could I get a r-b on this? It should fix some issues, even if the

Re: acpi_get_devices() crash when acpi_disabled==true (was [PATCH v2] drm/privacy-screen: honor acpi=off in detect_thinkpad_privacy_screen)

2022-01-27 Thread Hans de Goede
Hi, On 1/26/22 18:11, Rafael J. Wysocki wrote: > On Wed, Jan 26, 2022 at 5:41 PM Hans de Goede wrote: >> >> Hi, >> >> On 1/26/22 16:54, Rafael J. Wysocki wrote: >>> On Wed, Jan 26, 2022 at 2:47 PM Hans de Goede wrote: Hi All, On 1/23/22 10:10, Tong Zhang wrote: > when acp

Re: [PATCH] drm/doc: Add section in the introduction page about learning material

2022-01-27 Thread Javier Martinez Canillas
On 1/27/22 12:31, Daniel Vetter wrote: > On Thu, Jan 27, 2022 at 11:50:30AM +0100, Javier Martinez Canillas wrote: [snip] >> Indeed. And we can add such section as a follow-up. Maybe referring to some >> of the drivers in drivers/gpu/drm/tiny. > > Do we have a talk anywhere for tiny? > I couldn

[PATCH] drm/vc4: hdmi: Ensure we don't use 2711 HPD registers on Pi0-3

2022-01-27 Thread Maxime Ripard
From: Dave Stevenson The existing logic was flawed in that it could try reading the 2711 specific registers for HPD on a CM1/3 where the HPD GPIO hadn't been defined in DT. Ensure we don't do the 2711 register read on invalid hardware, and then Signed-off-by: Dave Stevenson Signed-off-by: Maxi

Re: [PATCH] misc: fastrpc: avoid double fput() on failed usercopy

2022-01-27 Thread Greg Kroah-Hartman
On Thu, Jan 27, 2022 at 02:24:29PM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 27, 2022 at 02:02:18PM +0100, Mathias Krause wrote: > > If the copy back to userland fails for the FASTRPC_IOCTL_ALLOC_DMA_BUFF > > ioctl(), we shouldn't assume that 'buf->dmabuf' is still valid. In fact, > > dma_buf_

Re: acpi_get_devices() crash when acpi_disabled==true (was [PATCH v2] drm/privacy-screen: honor acpi=off in detect_thinkpad_privacy_screen)

2022-01-27 Thread Rafael J. Wysocki
On Thu, Jan 27, 2022 at 2:05 PM Hans de Goede wrote: > > Hi, > > On 1/26/22 18:11, Rafael J. Wysocki wrote: > > On Wed, Jan 26, 2022 at 5:41 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 1/26/22 16:54, Rafael J. Wysocki wrote: > >>> On Wed, Jan 26, 2022 at 2:47 PM Hans de Goede wrote: > >>>

Re: acpi_get_devices() crash when acpi_disabled==true (was [PATCH v2] drm/privacy-screen: honor acpi=off in detect_thinkpad_privacy_screen)

2022-01-27 Thread Hans de Goede
Hi, On 1/27/22 14:33, Rafael J. Wysocki wrote: > On Thu, Jan 27, 2022 at 2:05 PM Hans de Goede wrote: >> >> Hi, >> >> On 1/26/22 18:11, Rafael J. Wysocki wrote: >>> On Wed, Jan 26, 2022 at 5:41 PM Hans de Goede wrote: Hi, On 1/26/22 16:54, Rafael J. Wysocki wrote: > On We

[PATCH] drm/vc4: hdmi: Don't try disabling SCDC on Pi0-3.

2022-01-27 Thread Maxime Ripard
From: Dave Stevenson The code that set the scdc_enabled flag to ensure it was disabled at boot time also ran on Pi0-3 where there is no SCDC support. This lead to a warning in vc4_hdmi_encoder_post_crtc_disable due to vc4_hdmi_disable_scrambling being called and trying to read (and write) registe

[PATCH] drm/vc4: hdmi: Allow DBLCLK modes even if horz timing is odd.

2022-01-27 Thread Maxime Ripard
From: Dave Stevenson The 2711 pixel valve can't produce odd horizontal timings, and checks were added to vc4_hdmi_encoder_atomic_check and vc4_hdmi_encoder_mode_valid to filter out/block selection of such modes. Modes with DRM_MODE_FLAG_DBLCLK double all the horizontal timing values before progr

Re: [PATCH] misc: fastrpc: avoid double fput() on failed usercopy

2022-01-27 Thread Christian König
Am 27.01.22 um 14:26 schrieb Greg Kroah-Hartman: On Thu, Jan 27, 2022 at 02:24:29PM +0100, Greg Kroah-Hartman wrote: On Thu, Jan 27, 2022 at 02:02:18PM +0100, Mathias Krause wrote: If the copy back to userland fails for the FASTRPC_IOCTL_ALLOC_DMA_BUFF ioctl(), we shouldn't assume that 'buf->dm

[PATCH v5 0/6] drm/vc4: hdmi: Yet Another Approach to HDMI YUV output

2022-01-27 Thread Maxime Ripard
Hi, This is another attempt at supporting the HDMI YUV output in the vc4 HDMI driver. This is a follow-up of https://lore.kernel.org/dri-devel/20210317154352.732095-1-max...@cerno.tech/ And the discussions that occured recently on the mailing lists and IRC about this. The series mentioned above

[PATCH v5 1/6] drm/vc4: hdmi: Move clock validation to its own function

2022-01-27 Thread Maxime Ripard
Our code is doing the same clock rate validation in multiple instances. Let's create a helper to share the rate validation. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/gpu

[PATCH v5 2/6] drm/vc4: hdmi: Move clock calculation into its own function

2022-01-27 Thread Maxime Ripard
The code to compute our clock rate for a given setup will be called in multiple places in the next patches, so let's create a separate function for it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 49 +++--- 1 file changed, 34 insertions(+), 15 de

[PATCH v5 5/6] drm/vc4: hdmi: Always try to have the highest bpc

2022-01-27 Thread Maxime Ripard
Currently we take the max_bpc property as the bpc value and do not try anything else. However, what the other drivers seem to be doing is that they would try with the highest bpc allowed by the max_bpc property and the hardware capabilities, test if it results in an acceptable configuration, and i

  1   2   3   >