Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Geert Uytterhoeven
Hi Gerd, On Tue, Jan 18, 2022 at 7:30 AM Gerd Hoffmann wrote: > Also note that using a shadow framebuffer allows to decouple fbcon > updates and scanout framebuffer updates. Can be used to speed up > things without depending on the 2d blitter. Assuming accesses to the shadow frame buffer are fa

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Helge Deller
On 1/18/22 07:11, Gerd Hoffmann wrote: > On Mon, Jan 17, 2022 at 02:29:47PM +0100, Geert Uytterhoeven wrote: >> Hi Gerd, >> >> On Mon, Jan 17, 2022 at 1:57 PM Gerd Hoffmann wrote: b) to include new drivers (for old hardware) if they arrive (probably happens rarely but there can be). >>>

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Helge Deller
On 1/18/22 07:29, Gerd Hoffmann wrote: >> Please correct me if I'm wrong, but text-console emulation/scrolling on DRM >> is >> currently unaccelerated and bound to Truecolour modes only, > > Yes. Adding support for formats beside argb to the drm fbcon > emulation shouldn't be that much of a p

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Pekka Paalanen
On Mon, 17 Jan 2022 19:47:39 +0100 Sven Schnelle wrote: > I also tested the speed on my Thinkpad X1 with Intel graphics, and there > a dmesg with 919 lines one the text console took about 2s to display. In > x11, i measure 22ms. This might be unfair because encoding might be > different, but i ca

Re: [PATCH 3/4] drm/i915: add gtt misalignment test

2022-01-18 Thread Ramalingam C
On 2022-01-11 at 18:02:37 +, Robert Beckett wrote: > add test to check handling of misaligned offsets and sizes Bob, This needs the rebase. I have rebased the other three patches of the series.. Meanwhile i will review the changes. Ram. > > Signed-off-by: Robert Beckett > --- > drivers/gp

[RFC PATCH v4 0/3] Add support modifiers for drivers whose planes only support linear layout

2022-01-18 Thread Tomohito Esaki
Some drivers whose planes only support linear layout fb do not support format modifiers. These drivers should support modifiers, however the DRM core should handle this rather than open-coding in every driver. In this patch series, these drivers expose format modifiers based on the following sugge

[RFC PATCH v4 1/3] drm: introduce fb_modifiers_not_supported flag in mode_config

2022-01-18 Thread Tomohito Esaki
If only linear modifier is advertised, since there are many drivers that only linear supported, the DRM core should handle this rather than open-coding in every driver. However, there are legacy drivers such as radeon that do not support modifiers but infer the actual layout of the underlying buffe

[RFC PATCH v4 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-18 Thread Tomohito Esaki
The LINEAR modifier is advertised as default if a driver doesn't specify modifiers. Signed-off-by: Tomohito Esaki --- drivers/gpu/drm/drm_plane.c | 15 --- include/drm/drm_plane.h | 3 +++ 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.

[RFC PATCH v4 3/3] drm: remove allow_fb_modifiers

2022-01-18 Thread Tomohito Esaki
The allow_fb_modifiers flag is unnecessary since it has been replaced with cannot_support_modifiers flag. Signed-off-by: Tomohito Esaki --- drivers/gpu/drm/drm_plane.c | 9 - drivers/gpu/drm/selftests/test-drm_framebuffer.c | 1 - include/drm/drm_mode_config.h

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Jani Nikula
On Mon, 17 Jan 2022, Helge Deller wrote: > On 1/17/22 22:40, Jani Nikula wrote: >> On Mon, 17 Jan 2022, Thomas Zimmermann wrote: >>> Seems like few people read linux-fbdev these days. >> >> How much traffic is there to linux-fbdev that is *not* Cc'd to dri-devel >> also? > > Doesn't seem like muc

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Geert Uytterhoeven
Hi Jani, On Tue, Jan 18, 2022 at 9:38 AM Jani Nikula wrote: > On Mon, 17 Jan 2022, Helge Deller wrote: > > On 1/17/22 22:40, Jani Nikula wrote: > >> On Mon, 17 Jan 2022, Thomas Zimmermann wrote: > >>> Seems like few people read linux-fbdev these days. > >> > >> How much traffic is there to linu

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Helge Deller
Hello Daniel, On 1/17/22 16:00, Daniel Vetter wrote: > On Mon, Jan 17, 2022 at 1:16 PM Helge Deller wrote: >> On 1/17/22 11:02, Daniel Vetter wrote: >>> On Fri, Jan 14, 2022 at 7:18 PM Helge Deller wrote: The fbdev layer is orphaned, but seems to need some care. So I'd like to ste

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Helge Deller
On 1/18/22 09:38, Jani Nikula wrote: > On Mon, 17 Jan 2022, Helge Deller wrote: >> On 1/17/22 22:40, Jani Nikula wrote: >>> On Mon, 17 Jan 2022, Thomas Zimmermann wrote: Seems like few people read linux-fbdev these days. >>> >>> How much traffic is there to linux-fbdev that is *not* Cc'd to

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Michel Dänzer
On 2022-01-17 19:47, Sven Schnelle wrote: > >> * There's no new development in fbdev and there are no new >>drivers. Everyone works on DRM, which is better in most >>regards. The consequence is that userspace is slowly loosing the >> ability to use fbdev. > > That might be caused by th

Re: [Intel-gfx] [PATCH v7 4/6] drm/i915: Use vma resources for async unbinding

2022-01-18 Thread Thomas Hellström
Hi, On Mon, 2022-01-17 at 21:07 +, Robert Beckett wrote: > > > On 10/01/2022 17:22, Thomas Hellström wrote: > > Implement async (non-blocking) unbinding by not syncing the vma > > before > > calling unbind on the vma_resource. > > Add the resulting unbind fence to the object's dma_resv from

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Helge Deller
On 1/18/22 09:41, Helge Deller wrote: > Hello Daniel, > > On 1/17/22 16:00, Daniel Vetter wrote: >> On Mon, Jan 17, 2022 at 1:16 PM Helge Deller wrote: >>> On 1/17/22 11:02, Daniel Vetter wrote: On Fri, Jan 14, 2022 at 7:18 PM Helge Deller wrote: > > The fbdev layer is orphaned, but

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Gerd Hoffmann
On Tue, Jan 18, 2022 at 09:20:43AM +0100, Helge Deller wrote: > On 1/18/22 07:29, Gerd Hoffmann wrote: > >> Please correct me if I'm wrong, but text-console emulation/scrolling on > >> DRM is > >> currently unaccelerated and bound to Truecolour modes only, > > > > Yes. Adding support for formats

[PATCH v4 1/4] drm/bridge: anx7625: send DPCD command to downstream

2022-01-18 Thread Hsin-Yi Wang
From: Xin Ji Send DPCD command to downstream before anx7625 power down, let downstream monitor enter into standby mode. Signed-off-by: Xin Ji Signed-off-by: Hsin-Yi Wang --- v3->v4: Use common DP_AUX_NATIVE_READ/WRITE Previously in: https://patchwork.kernel.org/project/dri-devel/patch/1f36f8b

[PATCH v4 2/4] drm/bridge: anx7625: Convert to use devm_kzalloc

2022-01-18 Thread Hsin-Yi Wang
Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory handled by driver detach. Signed-off-by: Hsin-Yi Wang Reviewed-by: Xin Ji --- v2->v3: remove kfree() in anx7625_i2c_remove(). --- drivers/gpu/drm/bridge/analogix/anx7625.c | 10 +++--- 1 file changed, 3 insertions(+), 7 de

[PATCH v4 3/4] drm/bridge: anx7625: Support reading edid through aux channel

2022-01-18 Thread Hsin-Yi Wang
Support reading edid through aux channel if panel is connected to aux bus. Extend anx7625_aux_dpcd_trans() to implement aux transfer function: 1. panel is populated in devm_of_dp_aux_populate_ep_devices(), so move anx7625_parse_dt() after. 2. Use pm runtime autosuspend since aux transfer functi

[PATCH v4 4/4] dt-bindings: drm/bridge: anx7625: Add aux-bus node

2022-01-18 Thread Hsin-Yi Wang
List panel under aux-bus node if it's connected to anx7625's aux bus. Signed-off-by: Hsin-Yi Wang Reviewed-by: Xin Ji --- .../display/bridge/analogix,anx7625.yaml| 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/anal

Re: [PATCH] phy: dphy: Correct clk_pre parameter

2022-01-18 Thread Andrzej Hajda
Hi, On 18.01.2022 03:59, Liu Ying wrote: The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE parameter's unit is Unit Interval(UI) and the minimum value is 8. Also, kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy mentions that it should be in UI. How

Re: [PATCH v3 1/3] drm/bridge: anx7625: Convert to use devm_kzalloc

2022-01-18 Thread Hsin-Yi Wang
On Mon, Jan 17, 2022 at 6:04 PM Hsin-Yi Wang wrote: > > hi Robert, > > The second patch depends on "drm/bridge: anx7625: send DPCD command to > downstream" > (https://patchwork.kernel.org/project/dri-devel/patch/1f36f8bf0a48fb2bba17bacec23700e58c1d407d.1641891874.git@analogixsemi.com/). > But

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Javier Martinez Canillas
On 1/18/22 09:54, Helge Deller wrote: > On 1/18/22 09:38, Jani Nikula wrote: >> On Mon, 17 Jan 2022, Helge Deller wrote: >>> On 1/17/22 22:40, Jani Nikula wrote: On Mon, 17 Jan 2022, Thomas Zimmermann wrote: > Seems like few people read linux-fbdev these days. How much traffic

Re: [PATCH AUTOSEL 5.15 123/188] drm/tegra: dc: rgb: Allow changing PLLD rate on Tegra30+

2022-01-18 Thread Dmitry Osipenko
18.01.2022 05:30, Sasha Levin пишет: > From: Dmitry Osipenko > > [ Upstream commit 0c921b6d4ba06bc899fd84d3ce1c1afd3d00bc1c ] > > Asus Transformer TF700T is a Tegra30 tablet device which uses RGB->DSI > bridge that requires a precise clock rate in order to operate properly. > Tegra30 has a dedic

Re: [PATCH AUTOSEL 5.15 123/188] drm/tegra: dc: rgb: Allow changing PLLD rate on Tegra30+

2022-01-18 Thread Dmitry Osipenko
18.01.2022 12:37, Dmitry Osipenko пишет: > 18.01.2022 05:30, Sasha Levin пишет: >> From: Dmitry Osipenko >> >> [ Upstream commit 0c921b6d4ba06bc899fd84d3ce1c1afd3d00bc1c ] >> >> Asus Transformer TF700T is a Tegra30 tablet device which uses RGB->DSI >> bridge that requires a precise clock rate in o

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Geert Uytterhoeven
Hi Javier, On Tue, Jan 18, 2022 at 10:33 AM Javier Martinez Canillas wrote: > On 1/18/22 09:54, Helge Deller wrote: > > On 1/18/22 09:38, Jani Nikula wrote: > >> On Mon, 17 Jan 2022, Helge Deller wrote: > >>> On 1/17/22 22:40, Jani Nikula wrote: > On Mon, 17 Jan 2022, Thomas Zimmermann wro

Re: [RFC PATCH v4 0/3] Add support modifiers for drivers whose planes only support linear layout

2022-01-18 Thread Andy Shevchenko
On Tue, Jan 18, 2022 at 05:36:49PM +0900, Tomohito Esaki wrote: > Some drivers whose planes only support linear layout fb do not support format > modifiers. > These drivers should support modifiers, however the DRM core should handle > this > rather than open-coding in every driver. > > In this p

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Gerd Hoffmann
On Tue, Jan 18, 2022 at 10:33:23AM +0200, Pekka Paalanen wrote: > On Mon, 17 Jan 2022 19:47:39 +0100 > Sven Schnelle wrote: > > > I also tested the speed on my Thinkpad X1 with Intel graphics, and there > > a dmesg with 919 lines one the text console took about 2s to display. In > > x11, i measur

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-18 Thread Andy Shevchenko
On Mon, Jan 17, 2022 at 02:15:48PM +0900, Esaki Tomohito wrote: > On 2022/01/14 23:16, Andy Shevchenko wrote: > > On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote: > > > The LINEAR modifier is advertised as default if a driver doesn't specify > > > modifiers. > > > > ... > > > > > +

[PATCH 0/7] Add GuC Error Capture Support

2022-01-18 Thread Alan Previn
This series: 1. Enables support of GuC to execute error- state-capture based on a list of MMIO registers the driver registers and GuC will dump and report back right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register lists of global

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Helge Deller
On 1/18/22 10:16, Gerd Hoffmann wrote: > On Tue, Jan 18, 2022 at 09:20:43AM +0100, Helge Deller wrote: >> On 1/18/22 07:29, Gerd Hoffmann wrote: Please correct me if I'm wrong, but text-console emulation/scrolling on DRM is currently unaccelerated and bound to Truecolour modes only,

Re: [PATCH] phy: dphy: Correct clk_pre parameter

2022-01-18 Thread Liu Ying
Hi Andrzej, Thanks for your review. On Tue, 2022-01-18 at 10:24 +0100, Andrzej Hajda wrote: > Hi, > > On 18.01.2022 03:59, Liu Ying wrote: > > The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE > > parameter's unit is Unit Interval(UI) and the minimum value is 8. Also, > > ke

Re: [PATCH] phy: dphy: Correct clk_pre parameter

2022-01-18 Thread Andrzej Hajda
On 18.01.2022 11:14, Liu Ying wrote: Hi Andrzej, Thanks for your review. On Tue, 2022-01-18 at 10:24 +0100, Andrzej Hajda wrote: Hi, On 18.01.2022 03:59, Liu Ying wrote: The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE parameter's unit is Unit Interval(UI) and the mini

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Helge Deller
On 1/18/22 11:13, Helge Deller wrote: > On 1/18/22 10:16, Gerd Hoffmann wrote: >> On Tue, Jan 18, 2022 at 09:20:43AM +0100, Helge Deller wrote: >>> On 1/18/22 07:29, Gerd Hoffmann wrote: > Please correct me if I'm wrong, but text-console emulation/scrolling on > DRM is > currently unac

[PATCH v9 1/6] drm: move the buddy allocator from i915 into common drm

2022-01-18 Thread Arunpravin
Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix header file dependencies - Fix alignment issues

[PATCH v9 3/6] drm: implement top-down allocation method

2022-01-18 Thread Arunpravin
Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver requests address at a low specific range,

[PATCH v9 2/6] drm: improve drm_buddy_alloc function

2022-01-18 Thread Arunpravin
- Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation and memory alignment logic from i915 drive

[PATCH v9 5/6] drm/amdgpu: move vram inline functions into a header

2022-01-18 Thread Arunpravin
Move shared vram inline functions and structs into a header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 51 1 file changed, 51 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h diff --git a/drivers/gpu/drm/a

[PATCH v9 4/6] drm: implement a method to free unused pages

2022-01-18 Thread Arunpravin
On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim - replace input argument name 'actual_siz

[PATCH v9 6/6] drm/amdgpu: add drm buddy support to amdgpu

2022-01-18 Thread Arunpravin
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Sven Schnelle
Hi Michel, Michel Dänzer writes: > On 2022-01-17 19:47, Sven Schnelle wrote: >> >>> * There's no new development in fbdev and there are no new >>>drivers. Everyone works on DRM, which is better in most >>>regards. The consequence is that userspace is slowly loosing the >>> ability to

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Daniel Vetter
On Mon, Jan 17, 2022 at 10:55 PM Ilia Mirkin wrote: > > On Mon, Jan 17, 2022 at 2:47 PM Helge Deller wrote: > > > > On 1/17/22 17:21, Helge Deller wrote: > > > On 1/17/22 16:58, Thomas Zimmermann wrote: > > >> Hi > > >> > > >> Am 17.01.22 um 16:42 schrieb Helge Deller: > > >>> [...] > > > c)

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-18 Thread Tvrtko Ursulin
On 17/01/2022 19:32, Andi Shyti wrote: The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those d

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Daniel Vetter
On Tue, Jan 18, 2022 at 9:56 AM Helge Deller wrote: > > On 1/18/22 09:38, Jani Nikula wrote: > > On Mon, 17 Jan 2022, Helge Deller wrote: > >> On 1/17/22 22:40, Jani Nikula wrote: > >>> On Mon, 17 Jan 2022, Thomas Zimmermann wrote: > Seems like few people read linux-fbdev these days. > >>>

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Daniel Vetter
On Tue, Jan 18, 2022 at 10:54 AM Gerd Hoffmann wrote: > > On Tue, Jan 18, 2022 at 10:33:23AM +0200, Pekka Paalanen wrote: > > On Mon, 17 Jan 2022 19:47:39 +0100 > > Sven Schnelle wrote: > > > > > I also tested the speed on my Thinkpad X1 with Intel graphics, and there > > > a dmesg with 919 lines

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Daniel Vetter
On Tue, Jan 18, 2022 at 9:41 AM Geert Uytterhoeven wrote: > > Hi Jani, > > On Tue, Jan 18, 2022 at 9:38 AM Jani Nikula > wrote: > > On Mon, 17 Jan 2022, Helge Deller wrote: > > > On 1/17/22 22:40, Jani Nikula wrote: > > >> On Mon, 17 Jan 2022, Thomas Zimmermann wrote: > > >>> Seems like few pe

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Helge Deller
On 1/18/22 12:18, Daniel Vetter wrote: > On Tue, Jan 18, 2022 at 9:56 AM Helge Deller wrote: >> >> On 1/18/22 09:38, Jani Nikula wrote: >>> On Mon, 17 Jan 2022, Helge Deller wrote: On 1/17/22 22:40, Jani Nikula wrote: > On Mon, 17 Jan 2022, Thomas Zimmermann wrote: >> Seems

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Daniel Vetter
On Tue, Jan 18, 2022 at 9:10 AM Geert Uytterhoeven wrote: > > Hi Gerd, > > On Tue, Jan 18, 2022 at 7:30 AM Gerd Hoffmann wrote: > > Also note that using a shadow framebuffer allows to decouple fbcon > > updates and scanout framebuffer updates. Can be used to speed up > > things without depending

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Gerd Hoffmann
Hi, > > fbcon could do the same, i.e. render to fbdev in a 60Hz timer instead of > > doing it synchronously. > > Yeah, and if you use the shadow fb support in drm fbdev helpers, > that's what you get. Maybe we should just make that the default, since > that would also greatly simply stuff like

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Simon Ser
On Tuesday, January 18th, 2022 at 12:41, Daniel Vetter wrote: > On Tue, Jan 18, 2022 at 9:41 AM Geert Uytterhoeven > wrote: > > > > Hi Jani, > > > > On Tue, Jan 18, 2022 at 9:38 AM Jani Nikula > > wrote: > > > On Mon, 17 Jan 2022, Helge Deller wrote: > > > > On 1/17/22 22:40, Jani Nikula wro

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Gerd Hoffmann
Hi, > > fbcon/fbdev emulation: RGB332 support must be added I think. But both > > argb888 and rgb565 are supported today, so it should not be hard to find > > the places where you have to add some code to handle RGB332 too. > > I'd expect that that framework is provided by DRM developers if th

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-18 Thread Andi Shyti
Hi Tvrtko, > > +bool is_object_gt(struct kobject *kobj) > > Not sure if you will need it exported in a later patch but for now it seems > only users are local to this file. it is actually used by sysfs_gt.c and sysfs_gt_pm.c. Thank you, Andi PS. in this v4 I forgot to replace many drm_err() wi

[PATCH 1/2] drm: mediatek: mtk_drm_plane: Use kmalloc in mtk_plane_duplicate_state

2022-01-18 Thread AngeloGioacchino Del Regno
There is no need to zero out the newly allocated memory because we are duplicating all members of struct mtk_plane_state: switch to kmalloc to save some overhead. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 2/2] drm: mediatek: mtk_drm_crtc: Use kmalloc in mtk_drm_crtc_duplicate_state

2022-01-18 Thread AngeloGioacchino Del Regno
Optimize mtk_drm_crtc_duplicate_state() by switching from kzalloc() to kmalloc(): the only variable of this struct that gets checked in other functions is `pending_config`, but if that's set to false, then all of the remaining variables will only ever be set, but not read - so, also set `pending_co

Re: [PATCH] drm/amdgpu: Add missing pm_runtime_put_autosuspend

2022-01-18 Thread Lazar, Lijo
On 1/18/2022 5:31 PM, Yongzhi Liu wrote: pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Yongzhi Liu Thanks! Reviewed-by: Lijo Laza

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Thomas Zimmermann
Hi Am 17.01.22 um 19:47 schrieb Sven Schnelle: Hi Thomas, Thomas Zimmermann writes: Hi Am 14.01.22 um 19:11 schrieb Helge Deller: The fbdev layer is orphaned, but seems to need some care. So I'd like to step up as new maintainer. Signed-off-by: Helge Deller First of all, thank you for s

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Thomas Zimmermann
Hi Am 17.01.22 um 17:21 schrieb Helge Deller: On 1/17/22 16:58, Thomas Zimmermann wrote: Hi Am 17.01.22 um 16:42 schrieb Helge Deller: [...] c) reintroduce the state where fbcon is fast on fbdev. This is important for non-DRM machines,     either when run on native hardware or in an emulat

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Thomas Zimmermann
Hi Am 18.01.22 um 09:10 schrieb Geert Uytterhoeven: Hi Gerd, On Tue, Jan 18, 2022 at 7:30 AM Gerd Hoffmann wrote: Also note that using a shadow framebuffer allows to decouple fbcon updates and scanout framebuffer updates. Can be used to speed up things without depending on the 2d blitter.

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-18 Thread Simon Ser
On Tuesday, January 18th, 2022 at 15:23, Thomas Zimmermann wrote: > Am 18.01.22 um 09:10 schrieb Geert Uytterhoeven: > > Hi Gerd, > > > > On Tue, Jan 18, 2022 at 7:30 AM Gerd Hoffmann wrote: > >> Also note that using a shadow framebuffer allows to decouple fbcon > >> updates and scanout framebu

Re: [PATCH] drm/i915: Add locking to i915_gem_evict_vm(), v3.

2022-01-18 Thread Maarten Lankhorst
Op 17-01-2022 om 15:08 schreef Thomas Hellström: > > On 1/17/22 08:56, Maarten Lankhorst wrote: >> i915_gem_evict_vm will need to be able to evict objects that are >> locked by the current ctx. By testing if the current context already >> locked the object, we can do this correctly. This allows us

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2022-01-18 Thread H. Nikolaus Schaller
Hi Paul, any insights on the JZ_REG_LCD_OSDC issue below? There is a second, unrelated issue with the introduction of "drm/bridge: display-connector: implement bus fmts callbacks" which breaks bus format negotiations. These are the two last unsolved issues to submit a fully working driver. > A

[PATCH 1/2] drm/msm: add support for QCM2290 MDSS

2022-01-18 Thread Loic Poulain
Add compatibility for QCM2290 display subsystem, including required entries in DPU hw catalog. Signed-off-by: Loic Poulain --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 175 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu

[PATCH 2/2] dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindings

2022-01-18 Thread Loic Poulain
QCM2290 MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for DPU device tree bindings Signed-off-by: Loic Poulain --- .../bindings/display/msm/dpu-qcm2290.yaml | 214 + 1 file changed, 214 insertions(+)

[PATCH] drm/selftests: Select DRM_DP_HELPER

2022-01-18 Thread Thomas Zimmermann
Resolve warnings about non-existing symbols by selecting DRM_DP_HELPER. Signed-off-by: Thomas Zimmermann Fixes: adb9d5a2cc77 ("drm/dp: Move DisplayPort helpers into separate helper module") Reported-by: kernel test robot Cc: Lyude Paul Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripar

[PATCH] drm/msm: Fix include statements for DisplayPort

2022-01-18 Thread Thomas Zimmermann
Update the include statements for DisplayPort helpers. The header files are in the dp/ subdirectory. Signed-off-by: Thomas Zimmermann Fixes: 5b529e8d9c38 ("drm/dp: Move public DisplayPort headers into dp/") Reported-by: kernel test robot Cc: Lyude Paul Cc: Daniel Vetter Cc: Maarten Lankhorst

Re: [PATCH v3] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2022-01-18 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 12:51:12PM -0700, Navare, Manasi wrote: > > Hi Ville, > > Could you take a look at this, this addresses teh review comments from prev > version I don't think I ever got an answer to my question as to whether this was tested with all the interesting scenarios: 1) just wit

Re: [PATCH] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-18 Thread Javier Martinez Canillas
Hello Jocelyn, On 1/14/22 10:47, Jocelyn Falempe wrote: > On some server with MGA G200e (rev 42), booting with Legacy BIOS, > The hardware hangs when using kdump and kexec into the kdump kernel. > This happens when the uncompress code tries to write "Decompressing Linux" > to the VGA Console. > >

Re: [PATCH] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-18 Thread Jocelyn Falempe
On 18/01/2022 17:38, Javier Martinez Canillas wrote: Hello Jocelyn, On 1/14/22 10:47, Jocelyn Falempe wrote: My worry is if this could cause other issues so I would only do this change if (is_kdump_kernel()), to make it as non intrusive as possible. And also add a verbose comment about why t

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2022-01-18 Thread Paul Cercueil
Hi Nikolaus, Le mar., janv. 18 2022 at 15:50:01 +0100, H. Nikolaus Schaller a écrit : Hi Paul, any insights on the JZ_REG_LCD_OSDC issue below? Sorry, I missed your previous email. I blame the holidays ;) There is a second, unrelated issue with the introduction of "drm/bridge: display-con

Re: [PATCH] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-18 Thread Javier Martinez Canillas
On 1/18/22 17:52, Jocelyn Falempe wrote: > On 18/01/2022 17:38, Javier Martinez Canillas wrote: >> Hello Jocelyn, >> >> On 1/14/22 10:47, Jocelyn Falempe wrote: > >> >> My worry is if this could cause other issues so I would only do this change >> if (is_kdump_kernel()), to make it as non intrusiv

Re: [PATCH] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-18 Thread Jocelyn Falempe
On 18/01/2022 18:17, Javier Martinez Canillas wrote: On 1/18/22 17:52, Jocelyn Falempe wrote: On 18/01/2022 17:38, Javier Martinez Canillas wrote: Hello Jocelyn, On 1/14/22 10:47, Jocelyn Falempe wrote: My worry is if this could cause other issues so I would only do this change if (is_kdum

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2022-01-18 Thread H. Nikolaus Schaller
Hi Paul, > Am 18.01.2022 um 17:58 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le mar., janv. 18 2022 at 15:50:01 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >> any insights on the JZ_REG_LCD_OSDC issue below? > > Sorry, I missed your previous email. I blame the holidays ;) No proble

Re: [RE]: [PATCH v3 10/10] vfio/ccw: Move the lifecycle of the struct vfio_ccw_private to the mdev

2022-01-18 Thread Eric Farman
On Mon, 2022-01-17 at 11:35 -0400, Jason Gunthorpe wrote: > On Fri, Jan 14, 2022 at 11:30:36AM -0500, Eric Farman wrote: > > On Fri, 2022-01-14 at 20:28 +0800, Liu Yi L wrote: > > > Hi Eric, > > > > > > Hope you are back from new year holiday.:-) Have you got chane to > > > consider > > > this pat

[PATCH v2 0/4] discsrete card 64K page support

2022-01-18 Thread Robert Beckett
This series continues support for 64K pages for discrete cards. It supersedes the 64K patches from https://patchwork.freedesktop.org/series/95686/#rev4 Changes since that series: - set min alignment for DG2 to 2MB in i915_address_space_init - replace coloring with simpler 2MB VA alignment for lme

[PATCH v2 1/4] drm/i915: enforce min GTT alignment for discrete cards

2022-01-18 Thread Robert Beckett
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into account.

[PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-18 Thread Robert Beckett
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. v2: Fixed suggestions on formatting [Daniel] Signed-off-by: Matthe

[PATCH v2 2/4] drm/i915: support 64K GTT pages for discrete cards

2022-01-18 Thread Robert Beckett
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no long

[PATCH v2 3/4] drm/i915: add gtt misalignment test

2022-01-18 Thread Robert Beckett
add test to check handling of misaligned offsets and sizes Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 130 ++ 1 file changed, 130 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i91

Re: [PATCH 1/2] drm/msm: add support for QCM2290 MDSS

2022-01-18 Thread Dmitry Baryshkov
On 18/01/2022 18:47, Loic Poulain wrote: Add compatibility for QCM2290 display subsystem, including required entries in DPU hw catalog. Signed-off-by: Loic Poulain --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 175 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog

[PATCH 1/2] staging: fbtft: Fix error path in fbtft_driver_module_init()

2022-01-18 Thread Uwe Kleine-König
If registering the platform driver fails, the function must not return without undoing the spi driver registration first. Fixes: c296d5f9957c ("staging: fbtft: core support") Signed-off-by: Uwe Kleine-König --- drivers/staging/fbtft/fbtft.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(

[PATCH 2/2] staging: fbtft: Deduplicate driver registration macros

2022-01-18 Thread Uwe Kleine-König
The two macros FBTFT_REGISTER_DRIVER and FBTFT_REGISTER_SPI_DRIVER contain quite some duplication: Both define an spi driver and an of device table and the differences are quite subtle. So create two new macros and use both twice. Signed-off-by: Uwe Kleine-König --- drivers/staging/fbtft/fbtft.

[PATCH v18 0/4] group dp driver related patches into one series

2022-01-18 Thread Kuogee Hsieh
Group below 4 dp driver related patches into one series. Kuogee Hsieh (4): drm/msm/dp: do not initialize phy until plugin interrupt received drm/msm/dp: populate connector of struct dp_panel drm/msm/dp: add support of tps4 (training pattern 4) for HBR3 drm/msm/dp: stop link training after

[PATCH v18 2/4] drm/msm/dp: populate connector of struct dp_panel

2022-01-18 Thread Kuogee Hsieh
DP CTS test case 4.2.2.6 has valid edid with bad checksum on purpose and expect DP source return correct checksum. During drm edid read, correct edid checksum is calculated and stored at connector::real_edid_checksum. The problem is struct dp_panel::connector never be assigned, instead the connect

[PATCH v18 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-18 Thread Kuogee Hsieh
Current DP drivers have regulators, clocks, irq and phy are grouped together within a function and executed not in a symmetric manner. This increase difficulty of code maintenance and limited code scalability. This patch divides the driver life cycle of operation into four states, resume (including

[PATCH v18 4/4] drm/msm/dp: stop link training after link training 2 failed

2022-01-18 Thread Kuogee Hsieh
Each DP link training contains link training 1 followed by link training 2. There is maximum of 5 retries of DP link training before declared link training failed. It is required to stop link training at end of link training 2 if it is failed so that next link training 1 can start freshly. This pa

[PATCH v18 3/4] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-18 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes in V3: --

[drm-tip:drm-tip 8/10] drivers/gpu/drm/i915/i915_gem_evict.h:15:15: error: declaration of 'struct i915_gem_ww_ctx' will not be visible outside of this function

2022-01-18 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: ceefc39c8abf37ff93eb36001f82e725756863c8 commit: e38294cfc29f789b541ecc08be2e578da746663c [8/10] Merge remote-tracking branch 'drm-intel/drm-intel-gt-next' into drm-tip config: x86_64-randconfig-a002-20220117 (https://download.01.o

Re: [PATCH v3] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2022-01-18 Thread Navare, Manasi
On Tue, Jan 18, 2022 at 06:34:20PM +0200, Ville Syrjälä wrote: > On Fri, Oct 22, 2021 at 12:51:12PM -0700, Navare, Manasi wrote: > > > > Hi Ville, > > > > Could you take a look at this, this addresses teh review comments from prev > > version > > I don't think I ever got an answer to my questio

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-18 Thread Javier Martinez Canillas
Hello Zack, On 1/17/22 19:03, Zack Rusin wrote: > From: Zack Rusin > > When sysfb_simple is enabled loading vmwgfx fails because the regions > are held by the platform. In that case remove_conflicting*_framebuffers > only removes the simplefb but not the regions held by sysfb. > Indeed, that's

Re: [PATCH] mgag200 fix memmapsl configuration in GCTL6 register

2022-01-18 Thread Lyude Paul
We should probably Cc: sta...@vger.kernel.org this as well, see: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for more info. As well, some useful tools for adding the appropriate Fixes: tags: https://drm.pages.freedesktop.org/maintainer-tools/dim.html At least on my

Re: [PATCH v11 03/19] dyndbg: add write-to-tracefs code

2022-01-18 Thread jim . cromie
On Fri, Jan 14, 2022 at 4:46 AM Vincent Whitchurch wrote: > > On Fri, Jan 07, 2022 at 06:29:26AM +0100, Jim Cromie wrote: > > > > Enabling debug-to-tracefs is 2 steps: > > > > # event enable > > echo 1 > /sys/kernel/tracing/events/dyndbg/enable > > # callsite enable > > echo module foo +T

Re: [PATCH 1/2] drm/msm/dsi: move DSI host powerup to modeset time

2022-01-18 Thread Abhinav Kumar
On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: The DSI subsystem does not fully fall into the pre-enable/enable system of callbacks, since typically DSI device bridge drivers expect to be able to communicate with DSI devices at the pre-enable() callback. The reason is that for some DSI hosts en

Re: [PATCH 2/2] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-01-18 Thread Abhinav Kumar
On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directly to the DSI host. Simplify the code path by using panel-bridge driver (already selected in Kconfig) and

Re: [PATCH] drm/dp: Remove common Post Cursor2 register handling

2022-01-18 Thread Gustavo A. R. Silva
On 1/5/22 11:35, Kees Cook wrote: > The link_status array was not large enough to read the Adjust Request > Post Cursor2 register, so remove the common helper function to avoid > an OOB read, found with a -Warray-bounds build: > > drivers/gpu/drm/drm_dp_helper.c: In function > 'drm_dp_get_adju

Re: [Freedreno] [PATCH v2] drm/msm: reduce usage of round_pixclk callback

2022-01-18 Thread Abhinav Kumar
On 1/5/2022 11:06 PM, Dmitry Baryshkov wrote: The round_pixclk() callback returns different rate only on MDP4 in HDMI (DTV) case. Stop using this callback in other cases to simplify mode_valid callbacks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- Changes since v1: -

Re: [PATCH 2/2] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-01-18 Thread Dmitry Baryshkov
On Tue, 18 Jan 2022 at 22:41, Abhinav Kumar wrote: > > > > On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: > > Currently the DSI driver has two separate paths: one if the next device > > in a chain is a bridge and another one if the panel is connected > > directly to the DSI host. Simplify the code

Re: [PATCH 1/2] drm/msm/dsi: move DSI host powerup to modeset time

2022-01-18 Thread Dmitry Baryshkov
On Tue, 18 Jan 2022 at 22:29, Abhinav Kumar wrote: > > > > On 12/7/2021 2:29 PM, Dmitry Baryshkov wrote: > > The DSI subsystem does not fully fall into the pre-enable/enable system > > of callbacks, since typically DSI device bridge drivers expect to be > > able to communicate with DSI devices at

Re: [PATCH] drm/amdgpu: Add missing pm_runtime_put_autosuspend

2022-01-18 Thread Alex Deucher
Applied. Strangely I can't seem to find this patch in my inbox or in the dri-devel or amd-gfx archives. Alex On Tue, Jan 18, 2022 at 9:03 AM Lazar, Lijo wrote: > > > > On 1/18/2022 5:31 PM, Yongzhi Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > > when it ret

Re: [PATCH] drm/radeon: fix UVD suspend error

2022-01-18 Thread Alex Deucher
Applied. Thanks! On Mon, Jan 17, 2022 at 3:05 PM Leo Liu wrote: > > > On 2022-01-17 2:47 a.m., Qiang Ma wrote: > > I met a bug recently and the kernel log: > > > > [ 330.171875] radeon :03:00.0: couldn't schedule ib > > [ 330.175781] [drm:radeon_uvd_suspend [radeon]] *ERROR* Error destroyi

  1   2   >