Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2022-01-12 Thread Neil Armstrong
Hi, On 12/01/2022 08:24, Jagan Teki wrote: > Hi Neil, > > On Mon, Sep 7, 2020 at 1:48 PM Neil Armstrong wrote: >> >> The Amlogic AXg SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), >> with a custom >> glue managing the IP resets, clock and data input similar to the DW-HDMI >> Glue

[PATCH] drm/vmwgfx: remove redundant ret variable

2022-01-12 Thread cgel . zte
From: Minghao Chi Return value from vmw_gem_object_create_with_handle() directly instead of taking this in another redundant variable. Reported-by: Zeal Robot Signed-off-by: Minghao Chi Signed-off-by: CGEL ZTE --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 6 +- 1 file changed, 1 insertion(+),

[PATCH] drm/gma500: remove redundant ret variable

2022-01-12 Thread cgel . zte
From: Minghao Chi Return value directly instead of taking this in another redundant variable. Reported-by: Zeal Robot Signed-off-by: Minghao Chi Signed-off-by: CGEL ZTE --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/

[PATCH 2/2] drm/tegra: Support semi-planar formats on Tegra114+

2022-01-12 Thread Thierry Reding
From: Thierry Reding The NV12, NV21, NV16, NV61, NV24 and NV42 formats are supported by Tegra114 and later display hardware. Add the necessary programming to allow them to be used. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c| 30 drivers/gpu/drm/tegra/

[PATCH 1/2] drm/tegra: Fix planar formats on Tegra186 and later

2022-01-12 Thread Thierry Reding
From: Thierry Reding Use the correct pitch when programming the DC_WIN_PLANAR_STORAGE_UV register's PITCH_U field to ensure the correct value is used in all cases. This isn't currently causing any problems because the pitch for both U and V planes is always the same. Signed-off-by: Thierry Redin

[v2 3/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2022-01-12 Thread Rajeev Nandan
The clock and data lanes of the DSI PHY have a calibration circuitry feature. As per the MSM DSI PHY tuning guidelines, the drive strength tuning can be done by adjusting rescode offset for hstop/hsbot, and the drive level tuning can be done by adjusting the LDO output level for the HSTX drive. Si

[v2 0/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2022-01-12 Thread Rajeev Nandan
This series is to add DSI PHY tuning support in Qualcomm Snapdragon SoCs with 10nm DSI PHY e.g. SC7180 In most cases the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases (for example, where extreme board parasitics cause the eye sh

[PATCH 2/4] arm64: dts: qcom: sc7280: Support gpu speedbin

2022-01-12 Thread Akhil P Oommen
Add the speedbin fuse and the required opps to support gpu sku. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc728

Re: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver

2022-01-12 Thread Kris Karas (Bug reporting)
Hi Javier, Geert, et al, Javier Martinez Canillas wrote: Changes in v2: - Make the change only for x86 (Geert Uytterhoeven) - Only check the suppported video mode for x86 (Geert Uytterhoeven). I just updated Bug 215001 to reflect that I have tested this new, V2 patch against 4 systems, one mo

[PATCH 3/4] drm/msm/adreno: Expose speedbin to userspace

2022-01-12 Thread Akhil P Oommen
Expose speedbin through MSM_PARAM_CHIP_ID parameter to help userspace identify the sku. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/d

[PATCH 4/4] drm/msm/adreno: Update the name of 7c3 gpu

2022-01-12 Thread Akhil P Oommen
Update the name in the gpulist for 7c3 gpu as per the latest recommendation. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/

[v2 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-12 Thread Rajeev Nandan
In most cases, the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases where extreme board parasitics cause the eye shape to degrade, the override bits can be used to improve the signal quality. The general guidelines for DSI PHY tuni

[v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-12 Thread Rajeev Nandan
Add support for MSM DSI PHY tuning configuration. Current design is to support drive strength and drive level/amplitude tuning for 10nm PHY version, but this can be extended to other PHY versions. Signed-off-by: Rajeev Nandan --- Changes in v2: - New. - Split into generic code and 10nm-specifi

[PATCH 1/4] drm/msm/adreno: Add support for Adreno 8c Gen 3

2022-01-12 Thread Akhil P Oommen
Add support for "Adreno 8c Gen 3" gpu along with the necessary speedbin support. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 21 + drivers/gpu/drm/msm/adreno/adreno_device.c | 29 ++--- drivers/gpu/drm/msm/adreno/adr

Re: [PATCH 2/3] arm64: dts: renesas: r8a77961: Add lvds0 device node

2022-01-12 Thread Nikita Yushchenko
Hi i.e. will queue in renesas-devel for v5.18. that is, for current + 2 ?

[PATCH] Remove extra device acquisition method of i2c client in lt9611 driver

2022-01-12 Thread lzmlzm
Signed-off-by: lzmlzm --- drivers/gpu/drm/bridge/lontium-lt9611.c| 2 +- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index dafb1b47c15f..e0f

Re: [PATCH v5 1/3] drm/privacy_screen: Add drvdata in drm_privacy_screen

2022-01-12 Thread Rajat Jain
On Mon, Jan 10, 2022 at 3:24 AM Hans de Goede wrote: > > Hi All, > > On 1/7/22 20:02, Rajat Jain wrote: > > Allow a privacy screen provider to stash its private data pointer in the > > drm_privacy_screen, and update the drm_privacy_screen_register() call to > > accept that. Also introduce a *_get_

[PATCH 2/2] platform: make platform_get_irq_byname_optional() optional

2022-01-12 Thread Sergey Shtylyov
Currently platform_get_irq_byname_optional() returns an error code even if IRQ resource simply has not been found. It prevents the callers from being error code agnostic in their error handling: ret = platform_get_irq_byname_optional(...); if (ret < 0 && ret != -ENXIO)

Re: [PATCH 1/2] drm/i2c/tda998x: Switch to atomic operations

2022-01-12 Thread Tommaso Merciai
On Sun, Jan 09, 2022 at 03:44:07PM -0300, Fabio Estevam wrote: > Hi Tommaso, > > On Sat, Jan 8, 2022 at 4:17 PM Tommaso Merciai wrote: > > > Hi Fabio, > > If you need some test let me know. Whitch filesystem are you using? > > I am using a rootfs generated by Buildroot. > > The issue I see see

Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI

2022-01-12 Thread Niklas Schnelle
On Thu, 2022-01-06 at 17:41 +, John Garry wrote: > On 05/01/2022 19:47, Bjorn Helgaas wrote: > > > > > > ok if the PCI maintainers decide otherwise. > > > > > I don't really like the "LEGACY_PCI" Kconfig option. "Legacy" just > > > > > means something old and out of favor; it doesn't say*wha

Re: [PATCH] drm/gma500: remove redundant ret variable

2022-01-12 Thread Patrik Jakobsson
On Wed, Jan 12, 2022 at 9:25 AM wrote: > > From: Minghao Chi > > Return value directly instead of taking this in another redundant > variable. > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > Signed-off-by: CGEL ZTE Thanks for the patch. I'll apply this to drm-misc-next -Patrik >

Re: [Intel-gfx] [PATCH] drm/i915: Flip guc_id allocation partition

2022-01-12 Thread Tvrtko Ursulin
On 11/01/2022 16:30, Matthew Brost wrote: Move the multi-lrc guc_id from the lower allocation partition (0 to number of multi-lrc guc_ids) to upper allocation partition (number of single-lrc to max guc_ids). Just a reminder that best practice for commit messages is to include the "why" as we

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-12 Thread Yong Wu
On Tue, 2022-01-11 at 16:27 -0800, Stephen Boyd wrote: > Quoting Yong Wu (2022-01-11 04:22:23) > > Hi Stephen, > > > > Thanks for helping update here. > > > > On Thu, 2022-01-06 at 13:45 -0800, Stephen Boyd wrote: > > > Use an aggregate driver instead of component ops so that we can > > > get > >

Re: [PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy

2022-01-12 Thread Thomas Zimmermann
Hi Am 11.01.22 um 14:32 schrieb Noralf Trønnes: Den 11.01.2022 14.26, skrev Thomas Zimmermann: Set the source-buffer address after mapping the buffer into the kernel's address space. Makes MIPI DBI helpers work again. Signed-off-by: Thomas Zimmermann Fixes: c47160d8edcd ("drm/mipi-dbi: Remo

Re: [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

2022-01-12 Thread yannick Fertre
Hello José, thanks for your patch. Reviewed-by: Yannick Fertre Tested-by: Yannick Fertre On 12/22/21 10:05 AM, José Expósito wrote: The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/stm/ltdc.

[PATCH v18, 00/19] Support multi hardware decode using of_platform_populate

2022-01-12 Thread Yunfei Dong
This series adds support for multi hardware decode into mtk-vcodec, by first adding use of_platform_populate to manage each hardware information: interrupt, clock, register bases and power. Secondly add core work queue to deal with core hardware message, at the same time, add msg queue for diffe

[PATCH v18, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2022-01-12 Thread Yunfei Dong
Different platforms may have different numbers of register bases. Gets the numbers of register bases from dts (sizeof(u32) * 4 bytes for each). Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 37 ++- 1 file changed, 28 in

[PATCH v18, 05/19] media: mtk-vcodec: Support MT8192

2022-01-12 Thread Yunfei Dong
Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". Adds MT8192's device private data mtk_lat_sig_core_pdata. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/mtk_vcodec_dec.h | 1 + .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4

[PATCH v18, 03/19] media: mtk-vcodec: Refactor vcodec pm interface

2022-01-12 Thread Yunfei Dong
Using the needed params for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 ++--- ..

[PATCH v18, 04/19] media: mtk-vcodec: export decoder pm functions

2022-01-12 Thread Yunfei Dong
When mtk vcodec decoder is build as a module, we need to export mtk-vcodec-dec pm functions to make them visible by the other components. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benjamin Gaignard --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c

[PATCH v18, 06/19] media: mtk-vcodec: Add to support multi hardware decode

2022-01-12 Thread Yunfei Dong
There are more than two hardwares for decoder: LAT0, LAT1 and CORE. In order to manage these hardwares, register each hardware as independent platform device for the larbs are different. Each hardware module controls its own information which includes interrupt/power/clocks/registers. Calling of_

[PATCH v18, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2022-01-12 Thread Yunfei Dong
Vdec and venc can use the same function to wake up interrupt event. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 + drivers/media/platform/mtk-vcodec

[PATCH v18, 07/19] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

2022-01-12 Thread Yunfei Dong
Separate decoder and encoder document for the dts are big difference. Signed-off-by: Yunfei Dong Reviewed-by: Rob Herring --- .../media/mediatek,vcodec-decoder.yaml| 176 + .../media/mediatek,vcodec-encoder.yaml| 187 ++ .../bindings/media/mediate

[PATCH v18, 08/19] media: mtk-vcodec: Use pure single core for MT8183

2022-01-12 Thread Yunfei Dong
Separates different architecture for hardware: pure_sin_core and lat_sin_core. MT8183 is pure single core. Uses .hw_arch to distinguish. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_stateful.c | 1 + .../platform/mtk-vcodec

[PATCH v18, 09/19] media: mtk-vcodec: Add irq interface for multi hardware

2022-01-12 Thread Yunfei Dong
Adds irq interface for multi hardware. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 --- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25 ++

[PATCH v18, 12/19] media: mtk-vcodec: Add new interface to lock different hardware

2022-01-12 Thread Yunfei Dong
For add new hardware, not only need to lock lat hardware, also need to lock core hardware in case of different instance start to decoder at the same time. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 ++-- dri

[PATCH v18, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2022-01-12 Thread Yunfei Dong
For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- drivers/media/platfor

[PATCH v18, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces

2022-01-12 Thread Yunfei Dong
Generalizes power and clock on/off interfaces to support different hardware. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_d

[PATCH v18, 14/19] media: mtk-vcodec: Support 34bits dma address for vdec

2022-01-12 Thread Yunfei Dong
Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it depends on the dma-ranges property of vdec dtsi nod

[PATCH v18, 13/19] media: mtk-vcodec: Add work queue for core hardware decode

2022-01-12 Thread Yunfei Dong
Add work queue to process core hardware information. First, get lat_buf from message queue, then call core hardware of each codec(H264/VP9/AV1) to decode, finally puts lat_buf back to the message. Signed-off-by: Yunfei Dong Reviewed-by: Steve Cho --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c

[PATCH v18, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

2022-01-12 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_enc_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *_clk since it only has clock operations now.

[PATCH v18, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2022-01-12 Thread Yunfei Dong
Adds decoder dt-bindings for mt8192. Signed-off-by: Yunfei Dong Reviewed-by: Rob Herring --- .../media/mediatek,vcodec-subdev-decoder.yaml | 265 ++ 1 file changed, 265 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml

[PATCH v18, 17/19] media: mtk-vcodec: Use codec type to separate different hardware

2022-01-12 Thread Yunfei Dong
There is just one core thread, in order to separate different hardware, using codec type to separeate it in scp driver. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 12 --- .../media/platform/mtk-vcodec/vdec_vpu_if.c

[PATCH v18, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg

2022-01-12 Thread Yunfei Dong
Add core dec and dec end ipi msg: AP_IPIMSG_DEC_CORE/AP_IPIMSG_DEC_CORE_END. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 4 .../media/platform/mtk-vcodec/vdec_vpu_if.c| 12 .../media/platform/mtk

[PATCH v18, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm

2022-01-12 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_dec_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_init_dec_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_dec_pm to *_clk since it only has clock operations now. Si

Re: [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

2022-01-12 Thread Jagan Teki
On Wed, Dec 22, 2021 at 2:36 PM José Expósito wrote: > > The "drm_plane_funcs.format_mod_supported" can be removed in favor of > the default implementation. > > Signed-off-by: José Expósito > --- Reviewed-by: Jagan Teki Tested-by: Jagan Teki # i.Core STM32MP1

Re: [PATCH] Revert "drm: exynos: dsi: Convert to bridge driver"

2022-01-12 Thread Robert Foss
Thank you again for catching this and submitting a revert. Reviewed-by: Robert Foss

Re: [PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const

2022-01-12 Thread Robert Foss
On Sun, 9 Jan 2022 at 23:58, Laurent Pinchart wrote: > > Hi Colin, > > Thank you for the patch. > > On Sun, Jan 09, 2022 at 08:41:05PM +, Colin Ian King wrote: > > Don't populate the read-only array clock_div_by_lanes on the stack but > > instead it static const. Also makes the object code a l

Re: [PATCH v2] drm: bridge: nwl-dsi: Drop panel_bridge from nwl_dsi

2022-01-12 Thread Robert Foss
On Mon, 10 Jan 2022 at 18:25, Jagan Teki wrote: > > panel_bridge pointer never used anywhere except the one it > looked up at nwl_dsi_bridge_attach. > > Drop it from the nwl_dsi structure. > > Reviewed-by: Guido Günther > Signed-off-by: Jagan Teki > --- > Changes for v2: > - collect Guido r-b >

Re: [PATCH v3 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

2022-01-12 Thread Alistair Popple
I have been looking at this in relation to the migration code and noticed we have the following in try_to_migrate(): if (is_zone_device_page(page) && !is_device_private_page(page)) return; Which if I'm understanding correctly means that migration of device coherent pages w

Re: [PATCH v3 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

2022-01-12 Thread David Hildenbrand
On 10.01.22 23:31, Alex Sierra wrote: > This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory > owned by a device that can be mapped into CPU page tables like > MEMORY_DEVICE_GENERIC and can also be migrated like > MEMORY_DEVICE_PRIVATE. > > Christoph, the suggestion to incorporate

Re: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver

2022-01-12 Thread Javier Martinez Canillas
Hello Kris, On 1/12/22 03:19, Kris Karas (Bug reporting) wrote: > Hi Javier, Geert, et al, > > Javier Martinez Canillas wrote: >> Changes in v2: >> - Make the change only for x86 (Geert Uytterhoeven) >> - Only check the suppported video mode for x86 (Geert Uytterhoeven). > > I just updated Bug 2

Re: [PATCH v2 1/3] clk: Introduce a clock request API

2022-01-12 Thread Maxime Ripard
Hi Stephen, Thanks for your answer On Tue, Jan 11, 2022 at 07:37:15PM -0800, Stephen Boyd wrote: > Sorry for being super delayed on response here. I'm buried in other > work. +Jerome for exclusive clk API. > > Quoting Maxime Ripard (2021-09-14 02:35:13) > > It's not unusual to find clocks being

Re: [PATCH 3/3] drm/atomic: Make private objs proper objects

2022-01-12 Thread Ville Syrjälä
On Tue, Jan 11, 2022 at 10:34:34AM +0200, Jani Nikula wrote: > On Mon, 10 Jan 2022, Ville Syrjälä wrote: > > On Fri, Dec 31, 2021 at 03:23:31PM +0200, Jani Nikula wrote: > >> On Wed, 12 Jul 2017, ville.syrj...@linux.intel.com wrote: > >> > From: Ville Syrjälä > >> > > >> > Make the atomic private

Re: [PATCH v2 01/14] drm/edid: Don't clear YUV422 if using deep color

2022-01-12 Thread Ville Syrjälä
On Tue, Jan 11, 2022 at 04:55:35PM +0100, Maxime Ripard wrote: > Hi Ville, > > Thanks for your review > > On Wed, Dec 15, 2021 at 03:48:39PM +0200, Ville Syrjälä wrote: > > On Wed, Dec 15, 2021 at 01:43:53PM +0100, Maxime Ripard wrote: > > > The current code, when parsing the EDID Deep Color dept

Re: [PATCH v2 0/3] clk: Implement a clock request API

2022-01-12 Thread Dmitry Osipenko
14.09.2021 12:35, Maxime Ripard пишет: > Hi, > > This is a follow-up of the discussion here: > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > This implements a mechanism to raise and lower clock rates based on consumer > workloads, with an example of such an implem

Re: [PATCH v2 0/3] clk: Implement a clock request API

2022-01-12 Thread Maxime Ripard
Hi Dmitry, On Wed, Jan 12, 2022 at 04:28:41PM +0300, Dmitry Osipenko wrote: > 14.09.2021 12:35, Maxime Ripard пишет: > > Hi, > > > > This is a follow-up of the discussion here: > > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > > > This implements a mechanism to r

Re: [PATCH v2 0/3] clk: Implement a clock request API

2022-01-12 Thread Dmitry Osipenko
h is abstract value expressed in kbytes/sec. The state machine will be ICC provider then, although you'll need to model that machine as a separate device somehow. For example, on Tegra we needed to specify clocks as separate devices to model GENPD [2][3]. [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b1bc04a2ac5 [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/boot/dts/tegra30.dtsi?h=next-20220112#n394

[PATCH] drm/mediatek: DP HPD Detect with debounce

2022-01-12 Thread Jitao Shi
DP Spec 1.4a 3.3 requires dp detect the hpd with debounce. Upstream implementations should implement HPD signal de-bouncing on an external connection. A period of 100ms should be used for detecting an HPD connect event (i.e., the event, “HPD high,” is confirmed only after HPD has been continuously

Re: [PATCH v3] drm/ast: Create the driver for ASPEED proprietory Display-Port

2022-01-12 Thread Thomas Zimmermann
Hi Am 04.01.22 um 09:50 schrieb KuoHsiang Chou: V1: 1. The MCU FW controling ASPEED DP is loaded by BMC boot loader. 2. Driver starts after CR[3:1] == 111b that indicates Tx is ASTDP, and CRD1[5] has been asserted by BMVC boot loader. 3. EDID is prioritized by DP monitor. 4. DP's EDID has hi

[Bug 210263] brightness device returns ENXIO (?) on brightness restore at boot, with bootoption "quiet"

2022-01-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210263 --- Comment #8 from ninel...@protonmail.com --- (In reply to Fabian from comment #5) > As of Kernel 5.15, I don't need fbcon=nodefer anymore. By default the > backlight works and is set on start. I still get from time to time an > boot-error by sy

Re: [git pull] drm for 5.17-rc1 (pre-merge window pull)

2022-01-12 Thread Harry Wentland
On 2022-01-11 15:51, Linus Torvalds wrote: > On Tue, Jan 11, 2022 at 7:38 AM Harry Wentland wrote: >> >> Attached is a v2 of the buggy patch that should get this right. >> If you have a chance to try it out let us know > > I can confirm that I do not see the horribly flickering behavior with >

Re: [PATCH] drm/panfrost: Check for error num after setting mask

2022-01-12 Thread Steven Price
On 06/01/2022 03:03, Jiasheng Jiang wrote: > Because of the possible failure of the dma_supported(), the > dma_set_mask_and_coherent() may return error num. > Therefore, it should be better to check it and return the error if > fails. > > Fixes: d9b631f0a0c4 ("drm/panfrost: Set DMA masks earlier")

Re: [PATCH v3 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

2022-01-12 Thread Felix Kuehling
Am 2022-01-12 um 6:16 a.m. schrieb David Hildenbrand: > On 10.01.22 23:31, Alex Sierra wrote: >> This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory >> owned by a device that can be mapped into CPU page tables like >> MEMORY_DEVICE_GENERIC and can also be migrated like >> MEMORY_D

Re: [PATCH 1/2] drm/panfrost: Remove features meant for userspace

2022-01-12 Thread Steven Price
On 09/01/2022 17:09, Alyssa Rosenzweig wrote: > Early versions of the legacy kernel driver included comprehensive > feature lists for every GPU, even though most of the enumerated features > only matter to userspace. For example, HW_FEATURE_INTERPIPE_REG_ALIASING > was a feature bit indicating that

Re: [PATCH 2/2] drm/panfrost: Merge some feature lists

2022-01-12 Thread Steven Price
On 09/01/2022 17:09, Alyssa Rosenzweig wrote: > Now that we only list features of interest to kernel space, lots of GPUs > have the same feature bits. To cut down on the repetition in the file, > merge feature lists that are identical between similar GPUs. > > Note that this leaves some unmerged i

Re: [PATCH 2/2] drm/panfrost: adjusted job affinity for dual core group GPUs

2022-01-12 Thread Steven Price
On 10/01/2022 17:42, Alyssa Rosenzweig wrote: >> Whether it's worth the effort depends on whether anyone really cares >> about getting the full performance out of this particular GPU. >> >> At this stage I think the main UABI change would be to add the opposite >> flag to kbase, (e.g. "PANFROST_JD_

Re: [Intel-gfx] [PATCH] drm/i915: Flip guc_id allocation partition

2022-01-12 Thread Piotr Piórkowski
Tvrtko Ursulin wrote on śro [2022-sty-12 08:54:19 +]: > > On 11/01/2022 16:30, Matthew Brost wrote: > > Move the multi-lrc guc_id from the lower allocation partition (0 to > > number of multi-lrc guc_ids) to upper allocation partition (number of > > single-lrc to max guc_ids). > > Just a re

Re: [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-12 Thread Dmitry Baryshkov
On Wed, 12 Jan 2022 at 19:09, Rajeev Nandan wrote: > > Hi Dmitry, > > > > > > > + if (phy->cfg->ops.tuning_cfg_init) > > > + phy->cfg->ops.tuning_cfg_init(phy); > > > > Please rename to parse_dt_properties() or something like that. > Sure. I didn't understand your comment in v1

Re: [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-12 Thread Sundaresan, Sujaritha
On 1/11/2022 4:15 AM, Andi Shyti wrote: The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those

Re: [Intel-gfx] [PATCH] drm/i915: Flip guc_id allocation partition

2022-01-12 Thread Matthew Brost
On Wed, Jan 12, 2022 at 06:09:06PM +0100, Piotr Piórkowski wrote: > Tvrtko Ursulin wrote on śro [2022-sty-12 > 08:54:19 +]: > > > > On 11/01/2022 16:30, Matthew Brost wrote: > > > Move the multi-lrc guc_id from the lower allocation partition (0 to > > > number of multi-lrc guc_ids) to upper

Re: [RFC PATCH 1/7] drm/msm/dp: fix panel bridge attachment

2022-01-12 Thread Kuogee Hsieh
On 1/6/2022 6:01 PM, Dmitry Baryshkov wrote: In commit 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") the DP driver received a drm_bridge instance, which is always attached to the encoder as a root bridge. However it conflicts with the panel_bridge support f

[RFC 00/28] Add RZ/G2L Display support

2022-01-12 Thread Biju Das
RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. This patch series aims to add basic display support on RZ/G2L SMARC EVK platform.

[RFC 10/28] drm: rcar-du: of: Increase buff size for compatible variable

2022-01-12 Thread Biju Das
Increase buff size for compatible variable to avoid stack corruption with RZ/G2L SoC's(renesas,du-r9a07g044l) which requires a buff size more than the current allocated size. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[RFC 11/28] drm: rcar-du: Add num_rpf to struct rcar_du_device_info

2022-01-12 Thread Biju Das
Number of RPF's VSP is different on R-Car and RZ/G2L R-Car Gen3 -> 5 RPF's R-Car Gen2 -> 4 RPF's RZ/G2L -> 2 RPF's Add num_rpf to struct rcar_du_device_info to support later SoC without any code changes. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 17 +

[RFC 12/28] drm: rcar-du: Add max_width and max_height to struct rcar_du_device_info

2022-01-12 Thread Biju Das
There are some differences related to max frame size supported by different R-Car/RZ-G family of SoC's Max frame size supported by R-Car Gen1 & R-Car Gen2 is 4095x2047 Max frame size supported by R-Car Gen3 is 8190x8190 Max frame size supported by RZ/G2L is 1920x1080 Add max_width and max_height

[RFC 13/28] drm: rcar-du: Add RCAR_DU_FEATURE_PLANE feature bit

2022-01-12 Thread Biju Das
DU plane registers are available on R-Car, but it is not present on RZ/G2L. Add RCAR_DU_FEATURE_PLANE feature bit to support later SoC. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 51 ++- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + 2 files change

[RFC 14/28] drm: rcar-du: Allow DU plane feature based on DU feature bit

2022-01-12 Thread Biju Das
RZ/G2L LCDC does not have DU plane registers. This patch supports DU planes only for the SoC's with plane feature bit is set. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 3 +++ drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-

[RFC 15/28] drm: rcar_du: Add RCAR_DU_FEATURE_GROUP feature bit

2022-01-12 Thread Biju Das
R-Car has supports DU groups in DU HW, where as it is not supported in RZ/G2L. Add RCAR_DU_FEATURE_GROUP feature bit to support RZ/G2L. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 17 + drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + 2 files changed, 18 ins

[RFC 16/28] drm: rcar-du: Allow DU group feature based on feature bit

2022-01-12 Thread Biju Das
RZ/G2L LCDC does not have DU group registers. This patch allows accessing DU group registers for SoC's with group feature bit is set. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 34 - drivers/gpu/drm/rcar-du/rcar_du_group.c | 10 +++- 2 files

[RFC 17/28] dt-bindings: display: renesas, du: Document r9a07g044l bindings

2022-01-12 Thread Biju Das
Extend the Renesas DU display bindings to support the r9a07g044l RZ/G2L. Signed-off-by: Biju Das --- .../bindings/display/renesas,du.yaml | 54 +++ 1 file changed, 54 insertions(+) diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/d

[RFC 18/28] drm: rcar-du: Add RZ/G2L LCDC Support

2022-01-12 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 rpf's to support blending of two picture layers and raster operations (ROPs). A feature bi

[RFC 21/28] dt-bindings: display: bridge: Document RZ/G2L MIPI DSI TX bindings

2022-01-12 Thread Biju Das
The RZ/G2L MIPI DSI TX is embedded in the Renesas RZ/G2L family SoC's. It can operate in DSI mode, with up to four data lanes. Signed-off-by: Biju Das --- .../bindings/display/bridge/renesas,dsi.yaml | 143 ++ 1 file changed, 143 insertions(+) create mode 100644 Documentation/

[RFC 22/28] drm: rcar-du: Add RZ/G2L DSI driver

2022-01-12 Thread Biju Das
This driver supports the MIPI DSI encoder found in the RZ/G2L SoC. It currently supports DSI mode only. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/Kconfig | 7 + drivers/gpu/drm/rcar-du/Makefile | 1 + drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c | 676 ++

Re: [PATCH] drm/i915/selftests: Fix NULL vs IS_ERR checking for kernel_context

2022-01-12 Thread Matthew Brost
On Wed, Dec 22, 2021 at 07:58:29AM +, Miaoqian Lin wrote: > Since i915_gem_create_context() function return error pointers, > the kernel_context() function does not return null, It returns error > pointers too. Using IS_ERR() to check the return value to fix this. > Just a nit, err is initial

Re: [PATCH] drm/vmwgfx: remove redundant ret variable

2022-01-12 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on next-20220112] [cannot apply to v5.16] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH] udmabuf: validate ubuf->pagecount

2022-01-12 Thread Pavel Skripkin
On 12/30/21 17:26, Pavel Skripkin wrote: Syzbot has reported GPF in sg_alloc_append_table_from_pages(). The problem was in ubuf->pages == ZERO_PTR. ubuf->pagecount is calculated from arguments passed from user-space. If user creates udmabuf with list.size == 0 then ubuf->pagecount will be also e

Re: Phyr Starter

2022-01-12 Thread Matthew Wilcox
On Tue, Jan 11, 2022 at 06:53:06PM -0400, Jason Gunthorpe wrote: > IOMMU is not common in those cases, it is slow. > > So you end up with 16 bytes per entry then another 24 bytes in the > entirely redundant scatter list. That is now 40 bytes/page for typical > HPC case, and I can't see that being

Re: [PATCH 1/2] drm/i915: Prepare for multiple GTs

2022-01-12 Thread Andi Shyti
Hi Dale, thanks for looking into this patch, > > + /* > > +* i915->gt[0] == &i915->gt0 > > +*/ > > +#define I915_MAX_GT 4 > > + struct intel_gt *gt[I915_MAX_GT]; > > + > > > It would be nice if I915_MAX_GT was defined in a more basic header file so > that the definition of I915_MAX_

Re: [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-12 Thread Andi Shyti
Hi Sujaritha, [...] > > +static ssize_t act_freq_mhz_show(struct device *dev, > > +struct device_attribute *attr, char *buff) > Alignment with the initial ( OK [...] > > +static INTEL_GT_RPS_SYSFS_ATTR(RP1_freq_mhz, 0444, rps_rp_mhz_show, NULL); > > +static INT

Re: Phyr Starter

2022-01-12 Thread Jason Gunthorpe
On Wed, Jan 12, 2022 at 06:37:03PM +, Matthew Wilcox wrote: > On Tue, Jan 11, 2022 at 06:53:06PM -0400, Jason Gunthorpe wrote: > > IOMMU is not common in those cases, it is slow. > > > > So you end up with 16 bytes per entry then another 24 bytes in the > > entirely redundant scatter list. Tha

Re: [PATCH 1/2] drm/panfrost: Remove features meant for userspace

2022-01-12 Thread Alyssa Rosenzweig
> (although it's a good thing kbase never did this cleanup - it's a useful > source of public information ;) ) Haha, yes. Actually, kbase did do the clean up recently (Valhall era kbase, I guess). To be fair, I still don't know what some of these were, like "T7xx pairing rules"... Presumably somet

Re: [PATCH 2/2] drm/panfrost: Merge some feature lists

2022-01-12 Thread Alyssa Rosenzweig
> > Now that we only list features of interest to kernel space, lots of GPUs > > have the same feature bits. To cut down on the repetition in the file, > > merge feature lists that are identical between similar GPUs. > > > > Note that this leaves some unmerged identical Bifrost feature lists, as >

Re: [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-11 10:43:23) > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch divides the driver life cyc

[Bug 215445] AMDGPU -- UBSAN: invalid-load in amdgpu_dm.c:5882:84 - load of value 32 is not a valid value for type '_Bool'

2022-01-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215445 --- Comment #7 from Bogdan (bogdan.pylypenko...@gmail.com) --- UBSAN <- Undefined Behaviour sanity checker > Compile-time instrumentation is used to detect various undefined behaviours > at runtime. > For more details, see: Documentation/dev-tools

Re: [RFC PATCH 1/7] drm/msm/dp: fix panel bridge attachment

2022-01-12 Thread Dmitry Baryshkov
On Wed, 12 Jan 2022 at 20:41, Kuogee Hsieh wrote: > > > On 1/6/2022 6:01 PM, Dmitry Baryshkov wrote: > > In commit 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display > > enable and disable") the DP driver received a drm_bridge instance, which > > is always attached to the encoder as a

RE: [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-12 Thread Rajeev Nandan
Hi Dmitry, > > > > + if (phy->cfg->ops.tuning_cfg_init) > > + phy->cfg->ops.tuning_cfg_init(phy); > > Please rename to parse_dt_properties() or something like that. Sure. I didn't understand your comment in v1 to use config_dt() hook. I think, now I understood. This function

Re: [PATCH 1/2] drm/panfrost: mmu: improved memory attributes

2022-01-12 Thread Alexey Sheplyakov
Hi, Robin, On Fri, Dec 24, 2021 at 12:56:57PM +, Robin Murphy wrote: > I'd note that panfrost has been working OK - to the extent that Mesa > supports its older ISA - on the T624 (single core group) in Arm's Juno SoC > for over a year now since commit 268af50f38b1. > > If you have to force o

RE: [v2 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-12 Thread Rajeev Nandan
Hi Dmitry, Rob, Thanks for the review. > > On Mon, Jan 10, 2022 at 05:06:03PM +0300, Dmitry Baryshkov wrote: > > On Mon, 10 Jan 2022 at 15:56, Rajeev Nandan > wrote: > > > > > > In most cases, the default values of DSI PHY tuning registers should > > > be sufficient as they are fully optimized.

[PATCH] drm/msm: Fix wrong size calculation

2022-01-12 Thread Xianting Tian
For example, memory-region in .dts as below, reg = <0x0 0x5000 0x0 0x2000> We can get below values, struct resource r; r.start = 0x5000; r.end = 0x6fff; So the size should be: size = r.end - r.start + 1 = 0x2000 Signed-off-by: Xianting Tian --- drivers/gpu/drm/msm

  1   2   >