Re: Phyr Starter

2022-01-11 Thread John Hubbard
On 1/10/22 11:34, Matthew Wilcox wrote: TLDR: I want to introduce a new data type: struct phyr { phys_addr_t addr; size_t len; }; and use it to replace bio_vec as well as using it to replace the array of struct pages used by get_user_pages() and friends. --- This would cert

Re: [PATCH 3/3] drm/atomic: Make private objs proper objects

2022-01-11 Thread Jani Nikula
On Mon, 10 Jan 2022, Ville Syrjälä wrote: > On Fri, Dec 31, 2021 at 03:23:31PM +0200, Jani Nikula wrote: >> On Wed, 12 Jul 2017, ville.syrj...@linux.intel.com wrote: >> > From: Ville Syrjälä >> > >> > Make the atomic private object stuff less special by introducing proper >> > base classes for th

Re: [PATCH 1/2] arm64: dts: exynos: Link DSI panel at port@1 for TM2 board

2022-01-11 Thread Andrzej Hajda
+CC: dri-devel On 10.01.2022 16:27, Jagan Teki wrote: TM2 board DSI pipeline has input from MIC and output to s6e3ha2 panel. The existing pipeline has child nodes of ports, panel and MIC is remote-endpoint reference of port@0 of ports. Adding panel as another child node to DSI is unconventiona

Re: [PATCH] dma-buf: Move sysfs work out of DMA-BUF export/release path

2022-01-11 Thread Daniel Vetter
On Tue, Jan 11, 2022 at 7:02 AM Hridya Valsaraju wrote: > > On Sun, Jan 9, 2022 at 11:28 PM Christian König > wrote: > > > > Am 07.01.22 um 22:25 schrieb Hridya Valsaraju: > > > On Fri, Jan 7, 2022 at 10:17 AM Hridya Valsaraju > > > wrote: > > >> On Fri, Jan 7, 2022 at 2:22 AM Christian König

RE: 回复: [PATCH] drm/ttm: Put BO in its memory manager's lru list

2022-01-11 Thread Chen, Guchun
[Public] Hi Christian, Looks this patch still missed in 5.16 kernel. Is it intentional? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/ttm/ttm_bo.c?h=v5.16 Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Pan, Xinhui Sent: Tuesday,

Re: [PATCH] dma-buf-map: Fix dot vs comma in example

2022-01-11 Thread Thomas Zimmermann
Hi Am 11.01.22 um 01:33 schrieb Lucas De Marchi: Fix typo: separate arguments with comma rather than dot. Signed-off-by: Lucas De Marchi Thank you. It's in drm-misc-next. Best regards Thomas --- include/linux/dma-buf-map.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v3 00/10] drm: Make drivers to honour the nomodeset parameter

2022-01-11 Thread Thomas Zimmermann
Hi patches 6 to 10 are Acked-by: Thomas Zimmermann Best regards Thomas Am 22.12.21 um 09:28 schrieb Javier Martinez Canillas: The nomodeset kernel command line parameter is used to prevent the KMS/DRM drivers to be registered/probed. But only a few drivers implement support for this and most

Re: Phyr Starter

2022-01-11 Thread Daniel Vetter
Dropping some thoughts from the gpu driver perspective, feel free to tell me it's nonsense from the mm/block view :-) Generally I think we really, really need something like this that's across all subsystems and consistent. On Tue, Jan 11, 2022 at 1:41 AM Jason Gunthorpe wrote: > On Mon, Jan 10,

[PATCH v3 1/1] drm/bridge: anx7625: send DPCD command to downstream

2022-01-11 Thread Xin Ji
Send DPCD command to downstream before anx7625 power down, let downstream monitor enter into standby mode. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 42 +++ 1 file changed, 35 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/analo

Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig

2022-01-11 Thread Javier Martinez Canillas
Hello Kevin, On 12/24/21 15:12, Kevin Tang wrote: > On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") > adds the config DRM_SPRD, > which selects DRM_KMS_CMA_HELPER. > According to "The canonical patch format" section in [0], the body of the explanation has to be line

Re: [PATCH] i915: make array flex_regs static const

2022-01-11 Thread Tvrtko Ursulin
On 09/01/2022 20:31, Colin Ian King wrote: Don't populate the read-only array flex_regs on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH v1 2/2] drm/sprd: fix potential NULL dereference

2022-01-11 Thread Javier Martinez Canillas
On 12/24/21 15:12, Kevin Tang wrote: > platform_get_resource() may fail and return NULL, so check it's value > before using it. > > 'drm' could be null in sprd_drm_shutdown, and drm_warn maybe dereference > it, remove this warning log. > I would split this second change in a separate patch and ju

Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig

2022-01-11 Thread Thomas Zimmermann
Hi Am 24.12.21 um 15:12 schrieb Kevin Tang: On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") adds the config DRM_SPRD, which selects DRM_KMS_CMA_HELPER. However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") just removed the DRM_KMS_CMA_HELPE

Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig

2022-01-11 Thread Lukas Bulwahn
On Fri, Dec 24, 2021 at 3:12 PM Kevin Tang wrote: > > On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") > adds the config DRM_SPRD, > which selects DRM_KMS_CMA_HELPER. > That this commit is _currently_ on linux-next is just a matter of the current state. The commit mes

Re: [PATCH v10 0/5] group dp driver related patches into one series

2022-01-11 Thread Dmitry Baryshkov
On 10/01/2022 23:55, Kuogee Hsieh wrote: Group below 5 dp driver related patches into one series. Could you please rebase this on top of msm-next? Kuogee Hsieh (5): drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed This patch is already a part of the tree

Re: [PATCH RESEND v4 v5 4/4] drm/vc4: Notify the firmware when DRM is in charge

2022-01-11 Thread Javier Martinez Canillas
Hello Maxime, On Wed, Dec 15, 2021 at 10:51 AM Maxime Ripard wrote: > > Once the call to drm_fb_helper_remove_conflicting_framebuffers() has > been made, simplefb has been unregistered and the KMS driver is entirely > in charge of the display. > > Thus, we can notify the firmware it can free what

[RFC v3 0/7] Add GuC Error Capture Support

2022-01-11 Thread Alan Previn
This series: 1. Supports the roll out of an upcoming GuC feature to enable error-state-capture that allows the driver to register lists of MMIO registers that GuC will report during a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register lists of glo

Re: [PATCH v1 2/2] drm/sprd: fix potential NULL dereference

2022-01-11 Thread Thomas Zimmermann
Hi, on the changes for platform_get_resource(), you can Acked-by: Thomas Zimmermann but see my comments below. Am 24.12.21 um 15:12 schrieb Kevin Tang: platform_get_resource() may fail and return NULL, so check it's value before using it. 'drm' could be null in sprd_drm_shutdown, and drm_wa

Re: [PATCH v4 0/6] drm: exynos: dsi: Convert drm bridge

2022-01-11 Thread Jagan Teki
Hi Andrzej, On Tue, Dec 28, 2021 at 4:18 PM Andrzej Hajda wrote: > > Hi Marek, > > On 23.12.2021 10:15, Marek Szyprowski wrote: > > Hi Jagan, > > > > On 18.12.2021 00:16, Marek Szyprowski wrote: > >> On 15.12.2021 15:56, Jagan Teki wrote: > >>> On Wed, Dec 15, 2021 at 7:49 PM Marek Szyprowski > >

Re: [PATCH 1/2] arm64: dts: exynos: Link DSI panel at port@1 for TM2 board

2022-01-11 Thread Jagan Teki
Hi Andrzej, On Tue, Jan 11, 2022 at 2:05 PM Andrzej Hajda wrote: > > +CC: dri-devel > > On 10.01.2022 16:27, Jagan Teki wrote: > > TM2 board DSI pipeline has input from MIC and output to > > s6e3ha2 panel. > > > > The existing pipeline has child nodes of ports, panel and > > MIC is remote-endpoin

Re: [PATCH RESEND v4 v5 4/4] drm/vc4: Notify the firmware when DRM is in charge

2022-01-11 Thread Thomas Zimmermann
Hi Am 15.12.21 um 10:51 schrieb Maxime Ripard: Once the call to drm_fb_helper_remove_conflicting_framebuffers() has been made, simplefb has been unregistered and the KMS driver is entirely in charge of the display. Thus, we can notify the firmware it can free whatever resource it was using to m

Re: (subset) [PATCH] drm/sun4i: dw-hdmi: Fix missing put_device() call in sun8i_hdmi_phy_get

2022-01-11 Thread Maxime Ripard
On Fri, 7 Jan 2022 08:36:32 +, Miaoqian Lin wrote: > The reference taken by 'of_find_device_by_node()' must be released when > not needed anymore. > Add the corresponding 'put_device()' in the error handling path. > > Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime

[Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption

2022-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215001 --- Comment #12 from Javier Martinez Canillas (jav...@dowhile0.org) --- Hello Kris, Could you please also test the patches in v2? https://lore.kernel.org/dri-devel/20220110095625.278836-1-javi...@redhat.com/ There shouldn't be any changes with

[PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-11 Thread Kandpal, Suraj
Changing drm_connector and drm_encoder feilds to pointers in drm_writeback_connector as the elements of struct drm_writeback_connector are: struct drm_writeback_connector { struct drm_connector base; struct drm_encoder encoder; Similarly the elements of intel_encoder and intel_conne

[PATCH 3/3] drm/vkms: change vkms driver to use drm_writeback_connector.base pointer

2022-01-11 Thread Kandpal, Suraj
Changing vkms driver to accomadate the change of drm_writeback_connector.base to a pointer the reason for which is explained in the Patch(drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal, Suraj --- drivers/gpu/drm/vkms/vkms_writeback.c | 6 +++--- 1 file changed, 3 insertion

[PATCH 2/3] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-01-11 Thread Kandpal, Suraj
Making changes to komeda driver because we had to change drm_writeback_connector.base into a pointer the reason for which is expained in the Patch (drm: add writeback pointers to drm_connector). Signed-off-by: Kandpal, Suraj --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- dr

Re: [PATCH v2 3/5] drm/dp: Move DisplayPort helpers into separate helper module

2022-01-11 Thread Javier Martinez Canillas
On Wed, Dec 15, 2021 at 12:12 PM Thomas Zimmermann wrote: > > Hi > > Am 15.12.21 um 12:04 schrieb Jani Nikula: > > On Wed, 15 Dec 2021, Thomas Zimmermann wrote: > >> * move DP helper code into dp/ (Jani) > > > > I suggested adding the subdirectory, but I'm going to bikeshed the name, > > whi

[Bug 215445] AMDGPU -- UBSAN: invalid-load in amdgpu_dm.c:5882:84 - load of value 32 is not a valid value for type '_Bool'

2022-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215445 --- Comment #5 from Martin Pecka (pe...@seznam.cz) --- This problem has disappeared for me in kernel 5.16.0. Can anybody else confirm? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the as

Re: [PATCH] i915: make array flex_regs static const

2022-01-11 Thread Tvrtko Ursulin
On 11/01/2022 09:13, Tvrtko Ursulin wrote: On 09/01/2022 20:31, Colin Ian King wrote: Don't populate the read-only array flex_regs on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King ---   drivers/gpu/drm/i915/i915_perf.c | 2 +

Re: [PATCH 3/5] dt-bindings: display: simple: add Geekworm MZP280 Panel

2022-01-11 Thread Maxime Ripard
Hi, On Mon, Jan 03, 2022 at 11:41:04AM -0600, Chris Morgan wrote: > From: Chris Morgan > > The Geekworm MZP280 panel is a 480x640 (portrait) panel with a > capacitive touch interface and a 40 pin header meant to interface > directly with the Raspberry Pi. The screen is 2.8 inches diagonally, > a

Re: [PATCH 4/5] drm/panel: simple: add Geekworm MZP280 Panel

2022-01-11 Thread Maxime Ripard
On Mon, Jan 03, 2022 at 11:41:05AM -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Geekworm MZP280 Panel > > Signed-off-by: Chris Morgan Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v9 13/15] memory: mtk-smi: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: After adding device_link between the iommu consumer and smi-larb, the pm_runtime_get(_sync) of smi-larb and smi-common will be called automatically. we can get rid of mtk_smi_larb_get/put. CC: Matthias Brugger Signed-off-by: Yong Wu Reviewed-by: Evan Gree

Re: [PATCH v9 15/15] arm64: dts: mediatek: Get rid of mediatek, larb for MM nodes

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: After adding device_link between the IOMMU consumer and smi, the mediatek,larb is unnecessary now. CC: Matthias Brugger Signed-off-by: Yong Wu Reviewed-by: Evan Green Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 12/15] media: mtk-vcodec: enc: Remove mtk_vcodec_release_enc_pm

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: After this patchset, mtk_vcodec_release_enc_pm has only one line. then remove that function, use pm_runtime_disable instead. meanwhile, mtk_vcodec_init_enc_pm only operate for the clocks, rename it from the _pm to _clk. No functional change. CC: Tiffany L

Re: [PATCH v9 10/15] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: MediaTek IOMMU has already added the device_link between the consumer and smi-larb device. If the vcodec device call the pm_runtime_get_sync, the smi-larb's pm_runtime_get_sync also be called automatically. CC: Tiffany Lin CC: Irui Wang Signed-off-by: Yon

Re: [PATCH v9 11/15] media: mtk-vcodec: dec: Remove mtk_vcodec_release_dec_pm

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: After this patchset, mtk_vcodec_release_dec_pm has only one line. then remove that function. Use pm_runtime_disable directly instead. For symmetry, move the pm_runtime_enable out from mtk_vcodec_init_dec_pm, then mtk_vcodec_init_dec_pm only operate for the

Re: [PATCH v9 08/15] drm/mediatek: Add pm runtime support for ovl and rdma

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: From: Yongqiang Niu Prepare for smi cleaning up "mediatek,larb". Display use the dispsys device to call pm_rumtime_get_sync before. This patch add pm_runtime_xx with ovl and rdma device whose nodes has "iommus" property, then display could help pm_runtime

Re: [PATCH v9 06/15] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: MediaTek IOMMU has already added device_link between the consumer and smi-larb device. If the jpg device call the pm_runtime_get_sync, the smi-larb's pm_runtime_get_sync also be called automatically. After removing the larb_get operations, then mtk_jpeg_clk

Re: [PATCH v9 07/15] media: mtk-mdp: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: MediaTek IOMMU has already added the device_link between the consumer and smi-larb device. If the mdp device call the pm_runtime_get_sync, the smi-larb's pm_runtime_get_sync also be called automatically. CC: Minghsiu Tsai CC: Houlong Wei Signed-off-by: Yo

Re: [PATCH v9 09/15] drm/mediatek: Get rid of mtk_smi_larb_get/put

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:55, Yong Wu ha scritto: MediaTek IOMMU has already added the device_link between the consumer and smi-larb device. If the drm device call the pm_runtime_get_sync, the smi-larb's pm_runtime_get_sync also be called automatically. CC: CK Hu CC: Philipp Zabel Signed-off-by: Yong Wu

Re: [PATCH v9 03/15] iommu/mediatek: Return ENODEV if the device is NULL

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:54, Yong Wu ha scritto: The platform device is created at: of_platform_default_populate_init: arch_initcall_sync ->of_platform_populate ->of_platform_device_create_pdata When entering our probe, all the devices should be already created. if it is null, means NODEV. Cu

Re: [PATCH v9 01/15] dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:54, Yong Wu ha scritto: After adding device_link between the consumer with the smi-larbs, if the consumer call its owner pm_runtime_get(_sync), the pm_runtime_get(_sync) of smi-larb and smi-common will be called automatically. Thus, the consumer don't need this property. And IOMMU

Re: [PATCH v9 04/15] iommu/mediatek: Add probe_defer for smi-larb

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:54, Yong Wu ha scritto: Prepare for adding device_link. The iommu consumer should use device_link to connect with the smi-larb(supplier). then the smi-larb should run before the iommu consumer. Here we delay the iommu driver until the smi driver is ready, then all the iommu consum

Re: [PATCH v9 05/15] iommu/mediatek: Add device_link between the consumer and the larb devices

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:54, Yong Wu ha scritto: MediaTek IOMMU-SMI diagram is like below. all the consumer connect with smi-larb, then connect with smi-common. M4U | smi-common | - | |... | | larb1 larb2 | | vdec

Re: [PATCH v9 02/15] iommu/mediatek-v1: Free the existed fwspec if the master dev already has

2022-01-11 Thread AngeloGioacchino Del Regno
Il 12/11/21 11:54, Yong Wu ha scritto: When the iommu master device enters of_iommu_xlate, the ops may be NULL(iommu dev is defered), then it will initialize the fwspec here: [] (dev_iommu_fwspec_set) from [] (iommu_fwspec_init+0xbc/0xd4) [] (iommu_fwspec_init) from [] (of_iommu_xlate+0x7c/0x12c

Re: [PATCH] dma-buf: Move sysfs work out of DMA-BUF export/release path

2022-01-11 Thread Christian König
Am 11.01.22 um 09:35 schrieb Daniel Vetter: On Tue, Jan 11, 2022 at 7:02 AM Hridya Valsaraju wrote: On Sun, Jan 9, 2022 at 11:28 PM Christian König wrote: Am 07.01.22 um 22:25 schrieb Hridya Valsaraju: On Fri, Jan 7, 2022 at 10:17 AM Hridya Valsaraju wrote: On Fri, Jan 7, 2022 at 2:22 AM C

Re: [PATCH v2] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-11 Thread AngeloGioacchino Del Regno
Il 06/01/22 06:22, CK Hu ha scritto: Hi, Angelo: On Tue, 2022-01-04 at 10:59 +0100, AngeloGioacchino Del Regno wrote: DRM bridge drivers are now attaching their DSI device at probe time, which requires us to register our DSI host in order to let the bridge to probe: this recently started produc

[PATCH v3 1/2] dt-bindings: display: Turn lvds.yaml into a generic schema

2022-01-11 Thread Maxime Ripard
The lvds.yaml file so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding. That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it

[PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2022-01-11 Thread Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented. Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard --- Changes from v2: - Added a MAINTAINERS entry Changes from v1: - Added missin

Re: [PATCH] dma-buf: Move sysfs work out of DMA-BUF export/release path

2022-01-11 Thread Greg Kroah-Hartman
On Tue, Jan 11, 2022 at 11:58:07AM +0100, Christian König wrote: > > > This is also not a problem due to the high number of DMA-BUF > > > exports during launch time, as even a single export can be delayed for > > > an unpredictable amount of time. We cannot eliminate DMA-BUF exports > > > completel

[PATCH 1/3] drm/bridge: anx7625: Convert to use devm_kzalloc

2022-01-11 Thread Hsin-Yi Wang
Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory handled by driver detach. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drive

[PATCH 2/3] drm/bridge: anx7625: Support reading edid through aux channel

2022-01-11 Thread Hsin-Yi Wang
Support reading edid through aux channel if panel is connected to aux bus. Extend anx7625_aux_dpcd_trans() to implement aux transfer function: 1. panel is populated in devm_of_dp_aux_populate_ep_devices(), so move anx7625_parse_dt() after. 2. Use pm runtime autosuspend since aux transfer functi

[PATCH 3/3] dt-bindings: drm/bridge: anx7625: Add aux-bus node

2022-01-11 Thread Hsin-Yi Wang
List panel under aux-bus node if it's connected to anx7625's aux bus. Signed-off-by: Hsin-Yi Wang --- .../display/bridge/analogix,anx7625.yaml| 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/

Re: 回复: [PATCH] drm/ttm: Put BO in its memory manager's lru list

2022-01-11 Thread Christian König
IIRC we have completely dropped this patch in favor of a check at a different place. Regards, Christian. Am 11.01.22 um 09:47 schrieb Chen, Guchun: [Public] Hi Christian, Looks this patch still missed in 5.16 kernel. Is it intentional? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds

Re: Phyr Starter

2022-01-11 Thread Thomas Zimmermann
Hi Am 10.01.22 um 20:34 schrieb Matthew Wilcox: TLDR: I want to introduce a new data type: struct phyr { phys_addr_t addr; size_t len; }; Did you look at struct dma_buf_map? [1] For graphics framebuffers, we have the problem that these buffers can be in I/O or system memor

[Bug 215445] AMDGPU -- UBSAN: invalid-load in amdgpu_dm.c:5882:84 - load of value 32 is not a valid value for type '_Bool'

2022-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215445 talktome7...@gmail.com changed: What|Removed |Added CC||talktome7...@gmail.com --- Comme

Re: [PATCH] dma-buf: Move sysfs work out of DMA-BUF export/release path

2022-01-11 Thread Christian König
Am 11.01.22 um 12:16 schrieb Greg Kroah-Hartman: On Tue, Jan 11, 2022 at 11:58:07AM +0100, Christian König wrote: This is also not a problem due to the high number of DMA-BUF exports during launch time, as even a single export can be delayed for an unpredictable amount of time. We cannot elimi

Re: [PATCH v4 0/6] drm: exynos: dsi: Convert drm bridge

2022-01-11 Thread Andrzej Hajda
Hi Jagan, On 11.01.2022 10:32, Jagan Teki wrote: Hi Andrzej, On Tue, Dec 28, 2021 at 4:18 PM Andrzej Hajda wrote: Hi Marek, On 23.12.2021 10:15, Marek Szyprowski wrote: Hi Jagan, On 18.12.2021 00:16, Marek Szyprowski wrote: On 15.12.2021 15:56, Jagan Teki wrote: On Wed, Dec 15, 2021 at 7

[PATCH 1/8] drm/ast: Fail if connector initialization fails

2022-01-11 Thread Thomas Zimmermann
Update the connector code to fail if the connector could not be initialized. The current code just ignored the error and failed later when the connector was supposed to be used. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 13 - 1 file changed, 8 insertions(+

[PATCH 0/8] drm/ast: Untangle connector helpers

2022-01-11 Thread Thomas Zimmermann
The ast driver supports different transmitter chips to support DVI and HDMI connectors. It's al been packed into the same helpers functons and exported as VGA connector. Introduce a separate set of connector helpers for each transmitter chip, and thus connector type. Also provide the correct encod

[PATCH 6/8] drm/ast: Initialize encoder and connector for VGA in helper function

2022-01-11 Thread Thomas Zimmermann
Move encoder and connector initialization into a single helper and put all related mode-setting structures into a single place. Done in preparation of moving transmitter code into separate helpers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 8 ++

[PATCH 5/8] drm/ast: Rename struct ast_connector to struct ast_vga_connector

2022-01-11 Thread Thomas Zimmermann
Prepare for introducing other connectors besides VGA. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 10 drivers/gpu/drm/ast/ast_mode.c | 45 +- 2 files changed, 27 insertions(+), 28 deletions(-) diff --git a

[PATCH 4/8] drm/ast: Remove unused value dp501_maxclk

2022-01-11 Thread Thomas Zimmermann
Remove reading the link-rate. The value is maintained by the connector code but never used. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c | 58 - drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/ast/ast_mode.c | 7 ++-- 3 files chan

[PATCH 3/8] drm/ast: Remove AST_TX_ITE66121 constant

2022-01-11 Thread Thomas Zimmermann
The ITE66121 is an HDMI transmitter chip. There's no code for detecting or programming the chip within ast. Remove the enum constant. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/

[PATCH 2/8] drm/ast: Move connector mode_valid function to CRTC

2022-01-11 Thread Thomas Zimmermann
The tests in ast_mode_valid() verify the correct resolution for the supplied mode. This is a limitation of the CRTC, so move the function to the CRTC helpers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 129 + 1 fil

[PATCH 7/8] drm/ast: Move DP501-based connector code into separate helpers

2022-01-11 Thread Thomas Zimmermann
Add helpers for DP501-based connectors. DP501 provides output via DisplayPort. This used to be handled by the VGA connector code. If a DP501 chip has been detected, ast will now create a DisplayPort connector instead of a VGA connector. Remove the DP501 code from ast_vga_connector_helper_get_mode

[PATCH 8/8] drm/ast: Move SIL164-based connector code into separate helpers

2022-01-11 Thread Thomas Zimmermann
Add helpers for initializing SIL164-based connectors. These used to be handled by the VGA connector code. But SIL164 provides output via DVI-I, so set the encoder and connector types accordingly. If a SIL164 chip has been detected, ast will now create a DVI-I connector instead of a VGA connector.

Re: [PATCH v2 1/2] drm/mipi-dbi: Remove dependency on GEM CMA helper library

2022-01-11 Thread Noralf Trønnes
> The MIPI DBI helpers access struct drm_gem_cma_object.vaddr in a > few places. Replace all instances with the correct generic GEM > functions. Use drm_gem_fb_vmap() for mapping a framebuffer's GEM > objects and drm_gem_fb_vunmap() for unmapping them. This removes > the dependency on CMA helpers w

[PATCH 0/2] Introduce multitile support

2022-01-11 Thread Andi Shyti
Hi, This is the second series that prepares i915 to host multitile platforms. It introduces the for_each_gt() macro that loops over the tiles to perform per gt actions. This patch is a combination of two patches developed originally by Abdiel, who introduced some refactoring during probe, and the

[PATCH 1/2] drm/i915: Prepare for multiple GTs

2022-01-11 Thread Andi Shyti
From: Tvrtko Ursulin On a multi-tile platform, each tile has its own registers + GGTT space, and BAR 0 is extended to cover all of them. Up to four gts are supported in i915->gt[], with slot zero shadowing the existing i915->gt0 to enable source compatibility with legacy driver paths. A for_each

[PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-11 Thread Andi Shyti
The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those directories. The previous power management

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-11 Thread Yong Wu
Hi Stephen, Thanks for helping update here. On Thu, 2022-01-06 at 13:45 -0800, Stephen Boyd wrote: > Use an aggregate driver instead of component ops so that we can get > proper driver probe ordering of the aggregate device with respect to > all > the component devices that make up the aggregate

Re: [PATCH RESEND v4 v5 0/4] drm/vc4: Use the firmware to stop the display pipeline

2022-01-11 Thread Maxime Ripard
On Wed, 15 Dec 2021 10:51:13 +0100, Maxime Ripard wrote: > The VC4 driver has had limited support to disable the HDMI controllers and > pixelvalves at boot if the firmware has enabled them. > > However, this proved to be limited, and a bit unreliable so a new firmware > command has been introduced

Re: [PATCH RESEND v4 v5 4/4] drm/vc4: Notify the firmware when DRM is in charge

2022-01-11 Thread Maxime Ripard
Hi Thomas, On Tue, Jan 11, 2022 at 10:38:36AM +0100, Thomas Zimmermann wrote: > Hi > > Am 15.12.21 um 10:51 schrieb Maxime Ripard: > > Once the call to drm_fb_helper_remove_conflicting_framebuffers() has > > been made, simplefb has been unregistered and the KMS driver is entirely > > in charge of

Re: [PATCH v3 1/2] dt-bindings: display: Turn lvds.yaml into a generic schema

2022-01-11 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Tue, Jan 11, 2022 at 12:06:34PM +0100, Maxime Ripard wrote: > The lvds.yaml file so far was both defining the generic LVDS properties > (such as data-mapping) that could be used for any LVDS sink, but also > the panel-lvds binding. > > That last binding was

Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2022-01-11 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Tue, Jan 11, 2022 at 12:06:35PM +0100, Maxime Ripard wrote: > Following the previous patch, let's introduce a generic panel-lvds > binding that documents the panels that don't have any particular > constraint documented. > > Reviewed-by: Rob Herring > Sign

Re: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver

2022-01-11 Thread Maxime Ripard
Hi, On Mon, Jan 10, 2022 at 10:56:23AM +0100, Javier Martinez Canillas wrote: > This patch series contains two fixes for the vga16fb driver. I looked at > the driver due a regression reported [0], caused by commit d391c5827107 > ("drivers/firmware: move x86 Generic System Framebuffers support"). >

[PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy

2022-01-11 Thread Thomas Zimmermann
Set the source-buffer address after mapping the buffer into the kernel's address space. Makes MIPI DBI helpers work again. Signed-off-by: Thomas Zimmermann Fixes: c47160d8edcd ("drm/mipi-dbi: Remove dependency on GEM CMA helper library") Reported-by: Noralf Trønnes Cc: Thomas Zimmermann Cc: Da

Re: [PATCH v2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX

2022-01-11 Thread Andrzej Hajda
Hi Brian, I am not DP specialist so CC-ed people working with DP On 01.10.2021 23:42, Brian Norris wrote: If the display is not enable()d, then we aren't holding a runtime PM reference here. Thus, it's easy to accidentally cause a hang, if user space is poking around at /dev/drm_dp_aux0 at the

Re: [PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy

2022-01-11 Thread Noralf Trønnes
Den 11.01.2022 14.26, skrev Thomas Zimmermann: > Set the source-buffer address after mapping the buffer into the > kernel's address space. Makes MIPI DBI helpers work again. > > Signed-off-by: Thomas Zimmermann > Fixes: c47160d8edcd ("drm/mipi-dbi: Remove dependency on GEM CMA helper > librar

Re: [PATCH v4 0/6] drm: exynos: dsi: Convert drm bridge

2022-01-11 Thread Jagan Teki
On Tue, Jan 11, 2022 at 5:20 PM Andrzej Hajda wrote: > > Hi Jagan, > > On 11.01.2022 10:32, Jagan Teki wrote: > > Hi Andrzej, > > > > On Tue, Dec 28, 2021 at 4:18 PM Andrzej Hajda > > wrote: > >> Hi Marek, > >> > >> On 23.12.2021 10:15, Marek Szyprowski wrote: > >>> Hi Jagan, > >>> > >>> On 18.1

Re: Phyr Starter

2022-01-11 Thread Matthew Wilcox
On Tue, Jan 11, 2022 at 12:40:10PM +0100, Thomas Zimmermann wrote: > Hi > > Am 10.01.22 um 20:34 schrieb Matthew Wilcox: > > TLDR: I want to introduce a new data type: > > > > struct phyr { > > phys_addr_t addr; > > size_t len; > > }; > > Did you look at struct dma_buf_map? [1]

Re: Phyr Starter

2022-01-11 Thread Matthew Wilcox
On Tue, Jan 11, 2022 at 12:17:18AM -0800, John Hubbard wrote: > Zooming in on the pinning aspect for a moment: last time I attempted to > convert O_DIRECT callers from gup to pup, I recall wanting very much to > record, in each bio_vec, whether these pages were acquired via FOLL_PIN, > or some non-

Re: Phyr Starter

2022-01-11 Thread Thomas Zimmermann
Hi Am 11.01.22 um 14:56 schrieb Matthew Wilcox: On Tue, Jan 11, 2022 at 12:40:10PM +0100, Thomas Zimmermann wrote: Hi Am 10.01.22 um 20:34 schrieb Matthew Wilcox: TLDR: I want to introduce a new data type: struct phyr { phys_addr_t addr; size_t len; }; Did you look at s

Re: Phyr Starter

2022-01-11 Thread Jason Gunthorpe
On Tue, Jan 11, 2022 at 04:32:56AM +, Matthew Wilcox wrote: > On Mon, Jan 10, 2022 at 08:41:26PM -0400, Jason Gunthorpe wrote: > > On Mon, Jan 10, 2022 at 07:34:49PM +, Matthew Wilcox wrote: > > > > > Finally, it may be possible to stop using scatterlist to describe the > > > input to the

Re: Phyr Starter

2022-01-11 Thread Jason Gunthorpe
On Tue, Jan 11, 2022 at 02:01:17PM +, Matthew Wilcox wrote: > On Tue, Jan 11, 2022 at 12:17:18AM -0800, John Hubbard wrote: > > Zooming in on the pinning aspect for a moment: last time I attempted to > > convert O_DIRECT callers from gup to pup, I recall wanting very much to > > record, in each

Re: [git pull] drm for 5.17-rc1 (pre-merge window pull)

2022-01-11 Thread Alex Deucher
On Mon, Jan 10, 2022 at 9:53 PM Linus Torvalds wrote: > > On Mon, Jan 10, 2022 at 6:44 PM Linus Torvalds > wrote: > > > > I'll double-check to see if a revert fixes it at the top of my tree. > > Yup. It reverts cleanly, and the end result builds and works fine, and > doesn't show the horrendous f

Re: [git pull] drm for 5.17-rc1 (pre-merge window pull)

2022-01-11 Thread Harry Wentland
On 2022-01-11 10:08, Alex Deucher wrote: > On Mon, Jan 10, 2022 at 9:53 PM Linus Torvalds > wrote: >> >> On Mon, Jan 10, 2022 at 6:44 PM Linus Torvalds >> wrote: >>> >>> I'll double-check to see if a revert fixes it at the top of my tree. >> >> Yup. It reverts cleanly, and the end result builds

Re: [PATCH] drm/atomic: Check new_crtc_state->active to determine if CRTC needs disable in self refresh mode

2022-01-11 Thread Alex Deucher
Pushed out to drm-misc-next-fixes. Alex On Fri, Jan 7, 2022 at 9:07 PM Liu Ying wrote: > > On Fri, 2022-01-07 at 14:53 -0500, Alex Deucher wrote: > > On Wed, Dec 29, 2021 at 11:07 PM Liu Ying wrote: > > > > > > Actual hardware state of CRTC is controlled by the member 'active' > > > in > > > st

Re: [Patch v4 18/24] drm/amdkfd: CRIU checkpoint and restore xnack mode

2022-01-11 Thread philip yang
On 2022-01-10 7:10 p.m., Felix Kuehling wrote: On 2022-01-05 10:22 a.m., philip yang wrote: On 2021-12-22 7:37 p.m., Rajneesh Bhardwaj wrote: Recoverable page faults are represented by the xnac

Re: [Intel-gfx] [PATCH 1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201

2022-01-11 Thread Jani Nikula
On Mon, 10 Jan 2022, Ville Syrjälä wrote: > On Tue, Jan 04, 2022 at 08:48:56PM +0200, Jani Nikula wrote: >> DP_SINK_COUNT_ESI and DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 have the same >> contents as DP_SINK_COUNT and DP_DEVICE_SERVICE_IRQ_VECTOR, >> respectively. > > IIRC there was an oversight in the e

Re: [PATCH v2 01/14] drm/edid: Don't clear YUV422 if using deep color

2022-01-11 Thread Maxime Ripard
Hi Ville, Thanks for your review On Wed, Dec 15, 2021 at 03:48:39PM +0200, Ville Syrjälä wrote: > On Wed, Dec 15, 2021 at 01:43:53PM +0100, Maxime Ripard wrote: > > The current code, when parsing the EDID Deep Color depths, that the > > YUV422 cannot be used, referring to the HDMI 1.3 Specificati

Re: [Patch v4 23/24] drm/amdkfd: CRIU prepare for svm resume

2022-01-11 Thread philip yang
On 2022-01-10 6:58 p.m., Felix Kuehling wrote: On 2022-01-05 9:43 a.m., philip yang wrote: On 2021-12-22 7:37 p.m., Rajneesh Bhardwaj wrote: During CRIU restore phase, the VMAs for the virtual

[PATCH] drm/i915: Flip guc_id allocation partition

2022-01-11 Thread Matthew Brost
Move the multi-lrc guc_id from the lower allocation partition (0 to number of multi-lrc guc_ids) to upper allocation partition (number of single-lrc to max guc_ids). Signed-off-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 57 ++- 1 file changed, 42 insert

[PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-11 Thread Matthew Brost
Don't use the interruptable version of the timeline mutex lock in the error path of eb_pin_timeline as the cleanup must always happen. v2: (John Harrison) - Don't check for interrupt during mutex lock v3: (Tvrtko) - A comment explaining why lock helper isn't used Fixes: 544460c33821 ("drm/i

[PATCH 0/4] dicsrete card 64K page support

2022-01-11 Thread Robert Beckett
This series continues support for 64K pages for discrete cards. It supersedes the 64K patches from https://patchwork.freedesktop.org/series/95686/#rev4 Changes since that series: - set min alignment for DG2 to 2MB in i915_address_space_init - replace coloring with simpler 2MB VA alignment for lme

[PATCH 1/4] drm/i915: enforce min GTT alignment for discrete cards

2022-01-11 Thread Robert Beckett
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into account.

[PATCH 2/4] drm/i915: support 64K GTT pages for discrete cards

2022-01-11 Thread Robert Beckett
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no long

[PATCH 3/4] drm/i915: add gtt misalignment test

2022-01-11 Thread Robert Beckett
add test to check handling of misaligned offsets and sizes Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 130 ++ 1 file changed, 130 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i91

[PATCH 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-11 Thread Robert Beckett
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. v2: Fixed suggestions on formatting [Daniel] Signed-off-by: Matthe

  1   2   >