Re: [PATCH v7 1/6] drm: move the buddy allocator from i915 into common drm

2022-01-10 Thread Christian König
Am 09.01.22 um 15:19 schrieb Arunpravin: +// SPDX-License-Identifier: MIT +MODULE_DESCRIPTION("DRM Buddy Allocator"); +MODULE_LICENSE("GPL"); I'm not an expert on this, but maybe we should use "Dual MIT/GPL" here? The code is certainly MIT licensed. Regards, Christian.

[PATCH] drm/self_refresh: Don't trigger the entry timer for self refresh work if CRTC state is inactive

2022-01-10 Thread Liu Ying
If the CRTC state is already inactive, it doesn't make sense to trigger the entry timer for self refresh work to make the display enter self refresh mode, because the disabled CRTC hints that either the entire display pipeline is disabled or the previous atomic commit is triggered by the self refre

Re: [PATCH 1/2] video: vga16fb: Fix logic that checks for the display standard

2022-01-10 Thread Javier Martinez Canillas
Hello Geert and Kara, On 1/9/22 21:20, Kris Karas (Bug reporting) wrote: > Groetje, Geert, > > Geert Uytterhoeven wrote: >> >>> - par->isVGA = screen_info.orig_video_isVGA; >>> + par->isVGA = screen_info.orig_video_isVGA == VIDEO_TYPE_VGAC; >> All non-x86 architectures (except for 2 M

[PATCH] i915: make array flex_regs static const

2022-01-10 Thread Colin Ian King
Don't populate the read-only array flex_regs on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_per

Re: [PATCH 1/2] drm/i2c/tda998x: Switch to atomic operations

2022-01-10 Thread Tommaso Merciai
On Mon, Jan 03, 2022 at 09:35:14AM -0300, Fabio Estevam wrote: > Hi Laurent, > > On Mon, Jan 3, 2022 at 8:48 AM Laurent Pinchart > wrote: > > > With the comment from 2/2 taken into account, > > > > Reviewed-by: Laurent Pinchart > > Thanks for the review. I addressed your feedback and sent v2.

[PATCH] drm/bridge: adv7533: make array clock_div_by_lanes static const

2022-01-10 Thread Colin Ian King
Don't populate the read-only array clock_div_by_lanes on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/

Re: [PATCH v2] hv: account for packet descriptor in maximum packet size

2022-01-10 Thread Andrea Parri
(Extending Cc: list,) On Sun, Jan 09, 2022 at 05:55:16PM +0800, Yanming Liu wrote: > Commit adae1e931acd ("Drivers: hv: vmbus: Copy packets sent by Hyper-V > out of the ring buffer") introduced a notion of maximum packet size in > vmbus channel and used that size to initialize a buffer holding all

Re: [PATCH 1/2] video: vga16fb: Fix logic that checks for the display standard

2022-01-10 Thread Kris Karas (Bug reporting)
Groetje, Geert, Geert Uytterhoeven wrote: - par->isVGA = screen_info.orig_video_isVGA; + par->isVGA = screen_info.orig_video_isVGA == VIDEO_TYPE_VGAC; All non-x86 architectures (except for 2 MIPS platforms) treat orig_video_isVGA as a boolean flag, and just assign 1 to it. Hence t

[PATCH] fbdev: aty128fb: make some arrays static const

2022-01-10 Thread Colin Ian King
Don't populate some read-only arrays on the stack but instead make them static const. Also makes the object code a little smaller. Re-format one of the declarations. Add spaces between commas and make PostDivSet unsigned int to fixup checkpatch warnings. Signed-off-by: Colin Ian King --- drivers

[PATCH v4, 01/15] media: mtk-vcodec: Add vdec enable/disable hardware helpers

2022-01-10 Thread Yunfei Dong
Lock, power and clock are highly coupled operations. Adds vdec enable/disable hardware helpers and uses them. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 5 - .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 168 +++--- .

[PATCH v4, 00/15] media: mtk-vcodec: support for MT8192 decoder

2022-01-10 Thread Yunfei Dong
This series adds support for mt8192 h264/vp8/vp9 decoder drivers. Firstly, refactor power/clock/interrupt interfaces for mt8192 is lat and core architecture. Secondly, add new functions to get frame buffer size and resolution according to decoder capability from scp side. Then add callback functi

[PATCH v4, 03/15] media: mtk-vcodec: get capture queue buffer size from scp

2022-01-10 Thread Yunfei Dong
Different capture buffer format has different buffer size, need to get real buffer size according to buffer type from scp. Signed-off-by: Yunfei Dong --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 37 ++ .../media/platform/mtk-vcodec/vdec_vpu_if.c | 50 +++ ...

[PATCH v4, 02/15] media: mtk-vcodec: Using firmware type to separate different firmware architecture

2022-01-10 Thread Yunfei Dong
MT8173 platform use vpu firmware, mt8183/mt8192 will use scp firmware instead, using chip name is not reasonable to separate different firmware architecture. Using firmware type is much better. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno --- ..

[PATCH v4, 04/15] media: mtk-vcodec: Read max resolution from dec_capability

2022-01-10 Thread Yunfei Dong
Supported max resolution for different platforms are not the same: 2K or 4K, getting it according to dec_capability. Signed-off-by: Yunfei Dong Reviewed-by: Tzung-Bi Shih --- .../platform/mtk-vcodec/mtk_vcodec_dec.c | 31 +++ .../platform/mtk-vcodec/mtk_vcodec_drv.h |

[PATCH v4, 05/15] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered

2022-01-10 Thread Yunfei Dong
lat thread: output queue \ -> lat hardware -> lat trans buffer lat trans buffer / core thread: capture queue \ ->core hardware -> capture queue lat trans buffer / Lat and core work in different thre

[PATCH v4, 06/15] media: mtk-vcodec: Refactor get and put capture buffer flow

2022-01-10 Thread Yunfei Dong
For lat and core decode in parallel, need to get capture buffer when core start to decode and put put capture buffer to display list when core decode done. Signed-off-by: Yunfei Dong --- .../mtk-vcodec/mtk_vcodec_dec_stateless.c | 123 -- .../platform/mtk-vcodec/mtk_vcodec_dr

[PATCH v4, 07/15] media: mtk-vcodec: Refactor supported vdec formats and framesizes

2022-01-10 Thread Yunfei Dong
Supported output and capture format types for mt8192 are different with mt8183. Needs to get format types according to decoder capability. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec.c | 8 +- .../mtk-vcodec/mtk_vcodec_dec_stateful.c | 13 +- .../mtk-vcodec

[PATCH v4, 09/15] media: mtk-vcodec: disable vp8 4K capability

2022-01-10 Thread Yunfei Dong
For vp8 not support 4K, need to disable it. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_d

[PATCH v4, 08/15] media: mtk-vcodec: Add format to support MT21C

2022-01-10 Thread Yunfei Dong
Needs to use mediatek compressed mode for mt8192 decoder. Signed-off-by: Yunfei Dong --- .../media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c | 7 ++- drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v4, 10/15] media: mtk-vcodec: Fix v4l2-compliance fail

2022-01-10 Thread Yunfei Dong
Need to use default pic info when get pic info fail. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/m

[PATCH v4, 11/15] media: mtk-vcodec: record capture queue format type

2022-01-10 Thread Yunfei Dong
Capture queue format type is difference for different platform, need to calculate capture buffer size according to capture queue format type in scp. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 2 ++ drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 2 ++

[PATCH v4, 13/15] media: mtk-vcodec: support stateless H.264 decoding for mt8192

2022-01-10 Thread Yunfei Dong
Adds h264 lat and core architecture driver for mt8192, and the decode mode is frame based for stateless decoder. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/Makefile| 1 + .../mtk-vcodec/vdec/vdec_h264_req_multi_if.c | 605 ++ .../media/platform/mtk-v

[PATCH v4, 14/15] media: mtk-vcodec: support stateless VP8 decoding

2022-01-10 Thread Yunfei Dong
Add support for VP8 decoding using the stateless API, as supported by MT8192. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/Makefile| 1 + .../mtk-vcodec/mtk_vcodec_dec_stateless.c | 24 +- .../platform/mtk-vcodec/mtk_vcodec_drv.h | 1 + .../mtk-vcodec/vdec/v

[PATCH v4, 12/15] media: mtk-vcodec: Extract H264 common code

2022-01-10 Thread Yunfei Dong
Mt8192 can use some of common code with mt8183. Moves them to a new file in order to reuse. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/Makefile| 1 + .../mtk-vcodec/vdec/vdec_h264_req_common.c| 311 ++ .../mtk-vcodec/vdec/vdec_h264_req_common.h| 25

[PATCH v4, 15/15] media: mtk-vcodec: support stateless VP9 decoding

2022-01-10 Thread Yunfei Dong
Add support for VP9 decoding using the stateless API, as supported by MT8192. And the drivers is lat and core architecture. Signed-off-by: George Sun Co-developed-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/Makefile|1 + .../mtk-vcodec/mtk_vcodec_dec_stateless.c | 26 +-

Re: [PATCH 2/3] arm64: dts: renesas: r8a77961: Add lvds0 device node

2022-01-10 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Dec 29, 2021 at 5:56 PM Laurent Pinchart wrote: > On Fri, Dec 24, 2021 at 08:23:08AM +0300, Nikita Yushchenko wrote: > > Add the missing lvds0 node for the R-Car M3-W+ SoC. > > > > Signed-off-by: Nikita Yushchenko > > --- > > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 27 ++

[PATCH v11 04/22] dt-bindings: reset: mt8195: add vdosys1 reset control bit

2022-01-10 Thread Nancy . Lin
Add vdosys1 reset control bit for MT8195 platform. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- include/dt-bindings/reset/mt8195-resets.h | 12 1 file changed, 12 insertions(+) diff --git a/include/dt-bindings/reset/mt8195-resets.h b/include/dt-bindings/reset/mt8195-re

[PATCH v11 15/22] drm/mediatek: add display merge async reset control

2022-01-10 Thread Nancy . Lin
Add merge async reset control in mtk_merge_stop. Async hw doesn't do self reset on each sof signal(start of frame), so need to reset the async to clear the hw status for the next merge start. Signed-off-by: Nancy.Lin Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 1 f

[PATCH v11 03/22] dt-bindings: mediatek: add ethdr definition for mt8195

2022-01-10 Thread Nancy . Lin
Add vdosys1 ETHDR definition. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- .../display/mediatek/mediatek,ethdr.yaml | 147 ++ 1 file changed, 147 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.yaml diff --git

[PATCH v11 02/22] dt-bindings: mediatek: add vdosys1 MERGE property for mt8195

2022-01-10 Thread Nancy . Lin
MT8195 vdosys1 merge1 to merge4 have HW mute function. Add MERGE additional mute property description. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu Acked-By: AngeloGioacchino Del Regno --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 4 1 file changed, 4 insertio

[PATCH v11 09/22] soc: mediatek: change the mutex defines and the mutex_mod type

2022-01-10 Thread Nancy . Lin
This is a preparation for adding support for mt8195 vdosys1 mutex. The vdosys1 path component contains ovl_adaptor, merge5, and dp_intf1. Ovl_adaptor is composed of several sub-elements, so change it to support multi-bit control. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mtk-mutex.c | 24

[PATCH v11 21/22] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

2022-01-10 Thread Nancy . Lin
Add driver data of mt8195 vdosys1 to mediatek-drm. Signed-off-by: Nancy.Lin --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 36430f956b4f..e851

[PATCH v11 07/22] soc: mediatek: add cmdq support of mtk-mmsys config API for mt8195 vdosys1

2022-01-10 Thread Nancy . Lin
Add cmdq support for mtk-mmsys config API. The mmsys config register settings need to take effect with the other HW settings(like OVL_ADAPTOR...) at the same vblanking time. If we use CPU to write the mmsys reg, we can't guarantee all the settings can be written in the same vblanking time. Cmdq is

[PATCH v11 06/22] soc: mediatek: add mtk-mmsys config API for mt8195 vdosys1

2022-01-10 Thread Nancy . Lin
Add mmsys config API. The config API is used for config mmsys reg. Some mmsys regs need to be setting according to the HW engine binding to the mmsys simultaneously. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mt8195-mmsys.h| 62 ++ drivers/soc/mediatek/mtk-mmsy

[PATCH v11 18/22] drm/mediatek: add ovl_adaptor support for MT8195

2022-01-10 Thread Nancy . Lin
Add ovl_adaptor driver for MT8195. Ovl_adaptor is an encapsulated module and designed for simplified DRM control flow. This module is composed of 8 RDMAs, 4 MERGEs and an ETHDR. Two RDMAs merge into one layer, so this module support 4 layers. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu -

[PATCH v11 14/22] drm/mediatek: add display merge mute/unmute support for MT8195

2022-01-10 Thread Nancy . Lin
Add merge mute/unmute setting for MT8195. MT8195 Vdosys1 merge1~merge4 support HW mute function. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_merge.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp

[PATCH v11 10/22] soc: mediatek: add mtk-mutex support for mt8195 vdosys1

2022-01-10 Thread Nancy . Lin
Add mtk-mutex support for mt8195 vdosys1. The vdosys1 path component contains ovl_adaptor, merge5, and dp_intf1. Ovl_adaptor is composed of several sub-elements. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mtk-mutex.c | 54 1 file changed, 54 insertions(+)

[PATCH v11 13/22] drm/mediatek: add display merge start/stop API for cmdq support

2022-01-10 Thread Nancy . Lin
Add merge start/stop API for cmdq support. The ovl_adaptor merges are configured with each drm plane update. Need to enable/disable merge with cmdq making sure all the settings taken effect in the same vblank. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_

[PATCH v11 20/22] drm/mediatek: add drm ovl_adaptor sub driver for MT8195

2022-01-10 Thread Nancy . Lin
Add drm ovl_adaptor sub driver. Bring up ovl_adaptor sub driver if the component exists in the path. Signed-off-by: Nancy.Lin --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 30 --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp

[PATCH v11 00/22] Add MediaTek SoC DRM (vdosys1) support for mt8195

2022-01-10 Thread Nancy . Lin
The hardware path of vdosys1 with DPTx output need to go through by several modules, such as, OVL_ADAPTOR and MERGE. Add DRM and these modules support by the patches below: Changes in v11: - remove ethdr vblank spin lock - refine ovl_adaptor print message Changes in v10: - refine ethdr reset co

[PATCH v11 12/22] drm/mediatek: add display merge advance config API for MT8195

2022-01-10 Thread Nancy . Lin
Add merge new advance config API. The original merge API is mtk_ddp_comp_funcs function prototype. The API interface parameters cannot be modified, so add a new config API for extension. This is the preparation for ovl_adaptor merge control. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --

[PATCH v11 22/22] arm64: dts: mt8195: add display node for vdosys1

2022-01-10 Thread Nancy . Lin
Add display node for vdosys1. Signed-off-by: Nancy.Lin --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 222 +++ 1 file changed, 222 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi index e136761345db..a69a7b57e070

[PATCH v11 08/22] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1

2022-01-10 Thread Nancy . Lin
MT8195 vdosys1 has more than 32 reset bits and a different reset base than other chips. Modify mmsys for support 64 bit and different reset base. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mt8195-mmsys.h | 1 + drivers/soc/mediatek/mtk-mmsys.c| 21 - drivers/soc/m

[PATCH v11 11/22] drm/mediatek: add display MDP RDMA support for MT8195

2022-01-10 Thread Nancy . Lin
Add MDP_RDMA driver for MT8195. MDP_RDMA is the DMA engine of the ovl_adaptor component. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 7 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + dr

[PATCH v11 01/22] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-01-10 Thread Nancy . Lin
Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin --- .../arm/mediatek/mediatek,mdp-rdma.yaml | 77 +++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mdp-rdma.yaml diff --git a/Documentation/devicetree/bi

[PATCH v11 19/22] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support

2022-01-10 Thread Nancy . Lin
MT8195 have two mmsys. Modify drm for MT8195 multi-mmsys support. The two mmsys (vdosys0 and vdosys1) will bring up two drm drivers, only one drm driver register as the drm device. Each drm driver binds its own component. The last bind drm driver allocates and registers the drm device to drm core.

[PATCH v11 16/22] drm/mediatek: add ETHDR support for MT8195

2022-01-10 Thread Nancy . Lin
ETHDR is a part of ovl_adaptor. ETHDR is designed for HDR video and graphics conversion in the external display path. It handles multiple HDR input types and performs tone mapping, color space/color format conversion, and then combine different layers, output the required HDR or SDR signal to the s

[PATCH v11 17/22] drm/mediatek: add mediatek-drm plane color encoding info

2022-01-10 Thread Nancy . Lin
Add plane color encoding information for color space conversion. It's a preparation for adding support for mt8195 ovl_adaptor mdp_rdma csc control. Signed-off-by: Nancy.Lin Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 + drivers/gpu/drm/mediatek/mtk_drm_plane.h |

[PATCH v11 05/22] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1

2022-01-10 Thread Nancy . Lin
Add mt8195 vdosys1 clock driver name and routing table to the driver data of mtk-mmsys. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mt8195-mmsys.h| 136 + drivers/soc/mediatek/mtk-mmsys.c | 10 ++ include/linux/soc/mediatek/mtk-mmsys.h | 2 + 3 files ch

Re: [PATCH 2/3] arm64: dts: renesas: r8a77961: Add lvds0 device node

2022-01-10 Thread Laurent Pinchart
Hi Geert, On Mon, Jan 10, 2022 at 09:43:58AM +0100, Geert Uytterhoeven wrote: > On Wed, Dec 29, 2021 at 5:56 PM Laurent Pinchart wrote: > > On Fri, Dec 24, 2021 at 08:23:08AM +0300, Nikita Yushchenko wrote: > > > Add the missing lvds0 node for the R-Car M3-W+ SoC. > > > > > > Signed-off-by: Nikita

Re: [PATCH 2/3] arm64: dts: renesas: r8a77961: Add lvds0 device node

2022-01-10 Thread Geert Uytterhoeven
On Fri, Dec 24, 2021 at 6:23 AM Nikita Yushchenko wrote: > Add the missing lvds0 node for the R-Car M3-W+ SoC. > > Signed-off-by: Nikita Yushchenko Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.18. Gr{oetje,eeting}s, Geert -- Geert Uytterhoe

Re: [PATCH 3/6] drm/meson: venc: add ENCL encoder setup for MIPI-DSI output

2022-01-10 Thread Neil Armstrong
On 07/01/2022 23:33, Martin Blumenstingl wrote: > Hi Neil, > > On Fri, Jan 7, 2022 at 3:57 PM Neil Armstrong wrote: >> >> This adds supports for the ENCL encoder connected to a MIPI-DSI transceiver >> on the >> Amlogic AXG SoCs> Should this be "AXG and newer SoCs" or is this really AXG >> spec

Re: [PATCH 5/6] drm/meson: add DSI encoder

2022-01-10 Thread Neil Armstrong
On 07/01/2022 23:35, Martin Blumenstingl wrote: > Hi Neil, > > On Fri, Jan 7, 2022 at 3:57 PM Neil Armstrong wrote: > > [...] >> + writel_bits_relaxed(BIT(3), BIT(3), priv->io_base + >> _REG(ENCL_VIDEO_MODE_ADV)); > see my comment on patch #3 from this series for BIT(3) > Yep, thanks,

Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2022-01-10 Thread Neil Armstrong
On 07/01/2022 23:49, Martin Blumenstingl wrote: > Hi Neil, > > some high-level comments from me below. > > On Fri, Jan 7, 2022 at 3:58 PM Neil Armstrong wrote: > [...] >> +/* MIPI DSI Relative REGISTERs Definitions */ >> +/* For MIPI_DSI_TOP_CNTL */ >> +#define BIT_DPI_COLOR_MODE20 >> +

Re: [PATCH 2/3] arm64: dts: renesas: r8a77961: Add lvds0 device node

2022-01-10 Thread Geert Uytterhoeven
Hi Nikita, On Mon, Jan 10, 2022 at 10:51 AM Nikita Yushchenko wrote: > > i.e. will queue in renesas-devel for v5.18. > > that is, for current + 2 ? That is correct, as the merge window for v5.17 has already opened. The deadline for new features to be accepted for v5.17 in the soc tree was around

[PATCH v2 0/2] video: A couple of fixes for the vga16fb driver

2022-01-10 Thread Javier Martinez Canillas
This patch series contains two fixes for the vga16fb driver. I looked at the driver due a regression reported [0], caused by commit d391c5827107 ("drivers/firmware: move x86 Generic System Framebuffers support"). The mentioned commit didn't change any logic but just moved the platform device regis

[PATCH v2 2/2] video: vga16fb: Only probe for EGA and VGA 16 color graphic cards

2022-01-10 Thread Javier Martinez Canillas
The vga16fb framebuffer driver only supports Enhanced Graphics Adapter (EGA) and Video Graphics Array (VGA) 16 color graphic cards. But it doesn't check if the adapter is one of those or if a VGA16 mode is used. This means that the driver will be probed even if a VESA BIOS Extensions (VBE) or Grap

[PATCH v2 1/2] video: vga16fb: Fix logic that checks for the display standard

2022-01-10 Thread Javier Martinez Canillas
The vga16fb framebuffer driver supports both Enhanced Graphics Adapter (EGA) and Video Graphics Array (VGA) 16 color graphic cards. But the logic to check whether the EGA or VGA standard are used is not correct. It just checks if screen_info.orig_video_isVGA is set, but it should check if is set t

Re: [PATCH v3 3/3] drm/bridge: anx7625: add audio codec .get_eld support

2022-01-10 Thread Robert Foss
Applied series to drm-misc-next

Re: [PATCH] drm: bridge: adv7511: Fix ADV7535 HPD enablement

2022-01-10 Thread Robert Foss
Hey Jagan, Thanks for submitting this fix. On Sun, 9 Jan 2022 at 18:30, Jagan Teki wrote: > > Existing HPD enablement logic is not compatible with ADV7535 > bridge, thus any runtime plug-in of HDMI cable is not working > on these bridge designs. > > Unlike other ADV7511 family of bridges, the AD

Re: [PATCH v4 0/6] drm: exynos: dsi: Convert drm bridge

2022-01-10 Thread Jagan Teki
Hi Marek, On Thu, Dec 23, 2021 at 2:45 PM Marek Szyprowski wrote: > > Hi Jagan, > > On 18.12.2021 00:16, Marek Szyprowski wrote: > > On 15.12.2021 15:56, Jagan Teki wrote: > >> On Wed, Dec 15, 2021 at 7:49 PM Marek Szyprowski > >> wrote: > >>> On 15.12.2021 13:57, Jagan Teki wrote: > On Wed

Re: [PATCH] drm/hisilicon/hibmc: Allow to be built if COMPILE_TEST is enabled

2022-01-10 Thread Javier Martinez Canillas
On 12/16/21 22:09, Javier Martinez Canillas wrote: > The commit feeb07d0ca5a ("drm/hisilicon/hibmc: Make CONFIG_DRM_HISI_HIBMC > depend on ARM64") made the driver Kconfig symbol to depend on ARM64 since > it only supports that architecture and loading the module on others would > lead to incorrect

Re: [PATCH 1/2] drm: exynos: dsi: Convert to bridge driver

2022-01-10 Thread Jagan Teki
Hi Robert, On Mon, Nov 22, 2021 at 9:34 PM Marek Szyprowski wrote: > > On 22.11.2021 16:07, Marek Szyprowski wrote: > > On 22.11.2021 15:55, Jagan Teki wrote: > >> On Mon, Nov 22, 2021 at 7:59 PM Jagan Teki > >> wrote: > >>> On Mon, Nov 22, 2021 at 7:51 PM Jagan Teki > >>> wrote: > On Mon,

Re: [PATCH v5 03/32] component: Move struct aggregate_device out to header file

2022-01-10 Thread Jani Nikula
On Fri, 07 Jan 2022, Stephen Boyd wrote: > Quoting Jani Nikula (2022-01-07 05:07:59) >> On Thu, 06 Jan 2022, Stephen Boyd wrote: >> > This allows aggregate driver writers to use the device passed to their >> > probe/remove/shutdown functions properly instead of treating it as an >> > opaque point

Re: [PATCH v5 1/3] drm/privacy_screen: Add drvdata in drm_privacy_screen

2022-01-10 Thread Hans de Goede
Hi All, On 1/7/22 20:02, Rajat Jain wrote: > Allow a privacy screen provider to stash its private data pointer in the > drm_privacy_screen, and update the drm_privacy_screen_register() call to > accept that. Also introduce a *_get_drvdata() so that it can retrieved > back when needed. > > This al

[PATCH] drm: bridge: chipone-icn6211: Drop unnecessary bridge type

2022-01-10 Thread Jagan Teki
Explicit assignment of connector to bridge type during bridge addition is optional. Some of the bridges like ICN6211 has panel to be connected and that panel driver has taken care of associated connector type of it. Drop it. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/chipone-icn6211.

[PATCH v4 4/7] drm/i915: Add i915_vma_unbind_unlocked, and take obj lock for i915_vma_unbind, v2.

2022-01-10 Thread Maarten Lankhorst
We want to remove more members of i915_vma, which requires the locking to be held more often. Start requiring gem object lock for i915_vma_unbind, as it's one of the callers that may unpin pages. Some special care is needed when evicting, because the last reference to the object may be held by th

[PATCH v4 0/7] drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

2022-01-10 Thread Maarten Lankhorst
Previously, short term pinning in execbuf was required because i915_vma was effectively independent from objects, and has its own refcount, locking, lifetime rules and pinning. This series removes the separate locking, by requiring vma->obj->resv to be held when pinning and unbinding. This will al

[PATCH v4 2/7] drm/i915: Add locking to i915_gem_evict_vm()

2022-01-10 Thread Maarten Lankhorst
i915_gem_evict_vm will need to be able to evict objects that are locked by the current ctx. By testing if the current context already locked the object, we can do this correctly. This allows us to evict the entire vm even if we already hold some objects' locks. Previously, this was spread over sev

[PATCH v4 1/7] drm/i915: Call i915_gem_evict_vm in vm_fault_gtt to prevent new ENOSPC errors, v2.

2022-01-10 Thread Maarten Lankhorst
Now that we cannot unbind kill the currently locked object directly because we're removing short term pinning, we may have to unbind the object from gtt manually, using a i915_gem_evict_vm() call. Changes since v1: - Remove -ENOSPC warning, can still happen with concurrent mmaps where we can't u

[PATCH v4 3/7] drm/i915: Add object locking to i915_gem_evict_for_node and i915_gem_evict_something

2022-01-10 Thread Maarten Lankhorst
Because we will start to require the obj->resv lock for unbinding, ensure these shrinker functions also take the lock. This requires some function signature changes, to ensure that the ww context is passed around, but is mostly straightforward. Previously this was split up into several patches, b

[PATCH v4 7/7] drm/i915: Remove short-term pins from execbuf, v6.

2022-01-10 Thread Maarten Lankhorst
Add a flag PIN_VALIDATE, to indicate we don't need to pin and only protected by the object lock. This removes the need to unpin, which is done by just releasing the lock. eb_reserve is slightly reworked for readability, but the same steps are still done: - First pass pins with NONBLOCK. - Second

[PATCH v4 6/7] drm/i915: Remove support for unlocked i915_vma unbind

2022-01-10 Thread Maarten Lankhorst
Now that we require the object lock for all ops, some code handling race conditions can be removed. This is required to not take short-term pins inside execbuf. Signed-off-by: Maarten Lankhorst Acked-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 55 +--

[PATCH v4 5/7] drm/i915: Remove assert_object_held_shared

2022-01-10 Thread Maarten Lankhorst
This duck tape workaround is no longer required, unbind and destroy are fixed to take the obj->resv mutex before destroying and obj->mm.lock has been removed, always requiring obj->resv as well. Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_obj

Re: [PATCH v6 4/6] drm/i915: Use vma resources for async unbinding

2022-01-10 Thread Matthew Auld
On 07/01/2022 14:23, Thomas Hellström wrote: Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should

Re: [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

2022-01-10 Thread Matthew Auld
On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object. Signed-off-by: Thomas Hellström --- driver

Re: [v2 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-10 Thread Dmitry Baryshkov
On Mon, 10 Jan 2022 at 15:56, Rajeev Nandan wrote: > > In most cases, the default values of DSI PHY tuning registers should be > sufficient as they are fully optimized. However, in some cases where > extreme board parasitics cause the eye shape to degrade, the override > bits can be used to improv

Re: [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-10 Thread Dmitry Baryshkov
On Mon, 10 Jan 2022 at 15:56, Rajeev Nandan wrote: > > Add support for MSM DSI PHY tuning configuration. Current design is > to support drive strength and drive level/amplitude tuning for > 10nm PHY version, but this can be extended to other PHY versions. > > Signed-off-by: Rajeev Nandan > --- >

Re: [PATCH 2/2] drm/panfrost: adjusted job affinity for dual core group GPUs

2022-01-10 Thread Steven Price
On 24/12/2021 08:56, Alexey Sheplyakov wrote: > Hi, > > On 23.12.2021 18:11, Alyssa Rosenzweig wrote: >>> The kernel driver itself can't guess which jobs need a such a strict >>> affinity, so setting proper requirements is the responsibility of >>> the userspace (Mesa). However the userspace is no

Re: [Intel-gfx] [PATCH v6 6/6] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2022-01-10 Thread Matthew Auld
On Fri, 7 Jan 2022 at 14:24, Thomas Hellström wrote: > > There is always a struct vma_resource guaranteed to be alive when we > access a corresponding struct vma_snapshot. > > So ditch the latter and instead of allocating vma_snapshots, reference > the already existning vma_resource. > > This requ

Re: [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

2022-01-10 Thread Thomas Hellström
On 1/10/22 14:59, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object. Sign

Re: [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

2022-01-10 Thread Matthew Auld
On 10/01/2022 14:36, Thomas Hellström wrote: On 1/10/22 14:59, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vm

Re: [PATCH v6 4/6] drm/i915: Use vma resources for async unbinding

2022-01-10 Thread Thomas Hellström
On 1/10/22 14:21, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration

Re: [PATCH 1/2] drm: exynos: dsi: Convert to bridge driver

2022-01-10 Thread Robert Foss
Hey Jagan, This is a mistake on my end, I must have been looking at reviewing this series and then accidentally included it with another batch of patches. Thank you for catching this. I would suggest reverting these two patches[1][2]. Is that ok with you? [1] https://cgit.freedesktop.org/drm/dr

Re: [PATCH 1/2] drm: exynos: dsi: Convert to bridge driver

2022-01-10 Thread Jagan Teki
Hi Robert, On Mon, Jan 10, 2022 at 9:02 PM Robert Foss wrote: > > Hey Jagan, > > This is a mistake on my end, I must have been looking at reviewing > this series and then accidentally included it with another batch of > patches. Thank you for catching this. Thanks for the response. > > I would

Re: [git pull] drm final fixes for 5.16

2022-01-10 Thread Daniel Vetter
On Fri, Jan 7, 2022 at 6:42 PM Linus Torvalds wrote: > > On Thu, Jan 6, 2022 at 7:23 PM Dave Airlie wrote: > > > > There is only the amdgpu runtime pm regression fix in here. > > Thanks, from a quick test it works for me - the backlight actually > does eventually go away. > > It does so only on t

Re: [PATCH 1/2] drm: exynos: dsi: Convert to bridge driver

2022-01-10 Thread Robert Foss
On Mon, 10 Jan 2022 at 16:35, Jagan Teki wrote: > > Hi Robert, > > On Mon, Jan 10, 2022 at 9:02 PM Robert Foss wrote: > > > > Hey Jagan, > > > > This is a mistake on my end, I must have been looking at reviewing > > this series and then accidentally included it with another batch of > > patches.

Re: [PATCH 3/3] drm/atomic: Make private objs proper objects

2022-01-10 Thread Ville Syrjälä
On Fri, Dec 31, 2021 at 03:23:31PM +0200, Jani Nikula wrote: > On Wed, 12 Jul 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Make the atomic private object stuff less special by introducing proper > > base classes for the object and its state. Drivers can embed these in

Re: [Intel-gfx] [PATCH 1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201

2022-01-10 Thread Ville Syrjälä
On Tue, Jan 04, 2022 at 08:48:56PM +0200, Jani Nikula wrote: > DP_SINK_COUNT_ESI and DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 have the same > contents as DP_SINK_COUNT and DP_DEVICE_SERVICE_IRQ_VECTOR, > respectively. IIRC there was an oversight in the earlier spec revisions that showed bit 7 as reserved

Re: [Intel-gfx] [PATCH 2/2] drm/mst: use DP_GET_SINK_COUNT() for sink count in ESI

2022-01-10 Thread Ville Syrjälä
On Tue, Jan 04, 2022 at 08:48:57PM +0200, Jani Nikula wrote: > Take bit 7 into account when reading sink count from > DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] drm/amd/display: invalid parameter check in dmub_hpd_callback

2022-01-10 Thread Harry Wentland
On 2022-01-09 13:42, José Expósito wrote: > The function performs a check on the "adev" input parameter, however, it > is used before the check. > > Initialize the "dev" variable after the sanity check to avoid a possible > NULL pointer dereference. > > Fixes: e27c41d5b0681 ("drm/amd/display: Sup

Re: [PATCH] drm/panfrost: Update create_bo flags comment

2022-01-10 Thread Steven Price
On 09/01/2022 16:37, Alyssa Rosenzweig wrote: > Update a comment stating create_bo took no flags, since it now takes a > bit mask of optional flags NOEXEC and HEAP. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Steven Price I'll push this to drm-misc-next. Thanks, Steve > --- > include

Re: [git pull] drm fixes for 5.16-rc3

2022-01-10 Thread Linus Torvalds
On Sun, Jan 9, 2022 at 11:38 PM Geert Uytterhoeven wrote: > > The commit that merged this branch made a seemingly innocent change to > the top Makefile: "Seemingly" innocent? Or something darker and more sinister, related to the unrelenting slaughter of flightless fowl? You be the judge.

Re: [v2 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-10 Thread Rob Herring
On Mon, 10 Jan 2022 18:25:35 +0530, Rajeev Nandan wrote: > In most cases, the default values of DSI PHY tuning registers should be > sufficient as they are fully optimized. However, in some cases where > extreme board parasitics cause the eye shape to degrade, the override > bits can be used to imp

Re: [RFC PATCH] drm/panfrost: Handle IDVS_GROUP_SIZE feature

2022-01-10 Thread Steven Price
On 09/01/2022 17:12, Alyssa Rosenzweig wrote: > The IDVS group size feature was missing. It is used on some Bifrost and > Valhall GPUs, and is the last kernel-relevant Bifrost feature we're > missing. > > This feature adds an extra IDVS group size field to the JM_CONFIG > register. In kbase, the v

[PATCH v7 0/6] drm/i915: Asynchronous vma unbinding

2022-01-10 Thread Thomas Hellström
This patch series introduces infrastructure for asynchronous vma unbinding. The single enabled use-case is initially at buffer object migration where we otherwise sync when unbinding vmas before migration. This in theory allows us to pipeline any number of migrations, but in practice the number i

[PATCH v7 1/6] drm/i915: Initial introduction of vma resources

2022-01-10 Thread Thomas Hellström
Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for asynchronous vma unbinding. v6: - Some document

[PATCH v7 2/6] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-10 Thread Thomas Hellström
When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma() and unbind_vma() ops. Similarly change the ins

[PATCH v7 3/6] drm/i915: Don't pin the object pages during pending vma binds

2022-01-10 Thread Thomas Hellström
A pin-count is already held by vma->pages so taking an additional pin during async binds is not necessary. When we introduce async unbinding we have other means of keeping the object pages alive. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_vma.c | 5

[PATCH v7 4/6] drm/i915: Use vma resources for async unbinding

2022-01-10 Thread Thomas Hellström
Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should be coalesced with the migration blit fence to a

  1   2   >