[PATCH] drm: omapdrm: Fix implicit dma_buf fencing

2022-01-06 Thread Ivaylo Dimitrov
Currently omapdrm driver does not initialize dma_buf_export_info resv member, which leads to a new dma_resv being allocated and attached to the exported dma_buf. This leads to the issue that fences created on dma_buf objects imported by other drivers are ignored by omapdrm, as only fences in gem ob

Re: [PATCH 1/3] phy: mediatek: phy-mtk-mipi-dsi: Switch to regmap for mmio access

2022-01-06 Thread Chunfeng Yun
On Mon, 2022-01-03 at 15:53 +0100, AngeloGioacchino Del Regno wrote: > Switch to using the generic regmap API instead of calls to > readl/writel > for MMIO register access, removing custom crafted > update/set/clear_bits > functions and also allowing us to reduce code size. It seems make the driver

Re: [PATCH 1/4] phy: mediatek: phy-mtk-hdmi: Switch to regmap for mmio access

2022-01-06 Thread Chunfeng Yun
On Mon, 2022-01-03 at 16:30 +0100, AngeloGioacchino Del Regno wrote: > Switch to using the generic regmap API instead of calls to > readl/writel > for MMIO register access, removing custom crafted > update/set/clear_bits > functions and also allowing us to reduce code size. Using readl/writel is si

Re: [PATCH 2/3] phy: mediatek: phy-mtk-mipi-dsi: Reorder and stop implicit header inclusion

2022-01-06 Thread Chunfeng Yun
On Mon, 2022-01-03 at 15:53 +0100, AngeloGioacchino Del Regno wrote: > All the headers for phy-mtk-mipi-{dsi,dsi-mt8173,dsi-mt8183}.c were > included from phy-mtk-mipi-dsi.h, but this isn't optimal: in order to > increase readability and sensibly reduce build times, the inclusions > should be done

Re: [PATCH] dma-buf: Move sysfs work out of DMA-BUF export/release path

2022-01-06 Thread Christian König
Am 05.01.22 um 00:51 schrieb Hridya Valsaraju: Recently, we noticed an issue where a process went into direct reclaim while holding the kernfs rw semaphore for sysfs in write(exclusive) mode. This caused processes who were doing DMA-BUF exports and releases to go into uninterruptible sleep since

Re: [PATCH] drm/ttm: Don't inherit GEM object VMAs in child process

2022-01-06 Thread Christian König
Am 05.01.22 um 17:16 schrieb Felix Kuehling: [SNIP] But KFD doesn't know anything about the inherited BOs from the parent process. Ok, why that? When the KFD is reinitializing it's context why shouldn't it cleanup those VMAs? That cleanup has to be initiated by user mode. Basically closing the

Re: [RFC v2 8/8] drm/amd/virt: Drop concurrent GPU reset protection for SRIOV

2022-01-06 Thread Christian König
Am 06.01.22 um 06:18 schrieb JingWen Chen: On 2022/1/6 下午12:59, JingWen Chen wrote: On 2022/1/6 上午2:24, Andrey Grodzovsky wrote: On 2022-01-05 2:59 a.m., Christian König wrote: Am 05.01.22 um 08:34 schrieb JingWen Chen: On 2022/1/5 上午12:56, Andrey Grodzovsky wrote: On 2022-01-04 6:36 a.m., C

Re: [PATCH 3/3] phy: mediatek: phy-mtk-mipi-dsi: Simplify with dev_err_probe()

2022-01-06 Thread Chunfeng Yun
On Mon, 2022-01-03 at 15:53 +0100, AngeloGioacchino Del Regno wrote: > Use the dev_err_probe() helper to simplify error handling during > probe. > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delre...@collabora.com> > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 29

Re: [PATCH 4/4] phy: mediatek: phy-mtk-hdmi: Simplify with dev_err_probe()

2022-01-06 Thread Chunfeng Yun
On Mon, 2022-01-03 at 16:30 +0100, AngeloGioacchino Del Regno wrote: > Use the dev_err_probe() helper to simplify error handling during > probe. > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delre...@collabora.com> > --- > drivers/phy/mediatek/phy-mtk-hdmi.c | 50 +++-

Re: [PATCH 3/4] phy: mediatek: phy-mtk-hdmi: Reorder and stop implicit header inclusion

2022-01-06 Thread Chunfeng Yun
On Mon, 2022-01-03 at 16:30 +0100, AngeloGioacchino Del Regno wrote: > All the headers for phy-mtk-{hdmi,hdmi-mt2701,hdmi-mt8183}.c were > included from phy-mtk-mipi-dsi.h, but this isn't optimal: in order to > increase readability and sensibly reduce build times, the inclusions > should be done pe

Re: [PATCH 2/4] phy: mediatek: phy-mtk-hdmi: Reorder to remove forward declarations

2022-01-06 Thread Chunfeng Yun
On Mon, 2022-01-03 at 16:30 +0100, AngeloGioacchino Del Regno wrote: > Forward declarations for mtk_hdmi_power_{on,off} aren't necessary: > move mtk_hdmi_phy_dev_ops down to remove forward declarations. > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delre...@collabora.com> > --

Re: [PATCH] drm/ast: Enable the supporting of wide screen on AST2600

2022-01-06 Thread Thomas Zimmermann
Hi Am 29.12.21 um 09:27 schrieb KuoHsiang Chou: Enable the supporting of wide sscreen on AST2600, so that the resolution of 16:9 and 16:10 are able to be selected on Display Settings. Signed-off-by: KuoHsiang Chou Added to drm-misc-next. Thanks for the patch. Best regards Thomas --- dri

[PATCH] omapfb: use default_groups in kobj_type

2022-01-06 Thread Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the omapfb sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups t

Re: [PATCH 1/2] fbdev: fbmem: add a helper to determine if an aperture is used by a fw fb

2022-01-06 Thread Thomas Zimmermann
Hi Am 27.12.21 um 19:25 schrieb Alex Deucher: Add a function for drivers to check if the a firmware initialized fb is corresponds to their aperture. This allows drivers to check if the device corresponds to what the firmware set up as the display device. If simpledrm is in use, it will regist

Re: [Openpvrsgx-devgroup] [PATCH] drm: omapdrm: Fix implicit dma_buf fencing

2022-01-06 Thread Tony Lindgren
* Ivaylo Dimitrov [220105 15:38]: > Fix that by initializing dma_buf resv to the resv of the gem object being > exported. Nice find! This also fixes my wlroots test case with termite running on sway where termite would only partially update when switching between desktops, so: Tested-by: Tony Li

[PATCH] drm/amdgpu: use default_groups in kobj_type

2022-01-06 Thread Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the amdgpu sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups t

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-06 Thread Tvrtko Ursulin
On 05/01/2022 16:24, Matthew Brost wrote: On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin wrote: On 04/01/2022 23:30, Matthew Brost wrote: Don't use the interruptable version of the timeline mutex lock in the interruptible error path of eb_pin_timeline as the cleanup must always

[PATCH] drm/amdkfd: use default_groups in kobj_type

2022-01-06 Thread Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the amdkfd sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups t

[PATCH] drm/vmwgfx: use default_groups in kobj_type

2022-01-06 Thread Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the vmwgfx sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups t

[PATCH v3 1/3] drm/bridge: anx7625: Add bridge helper atomic conversion

2022-01-06 Thread Xin Ji
Add bridge helper atomic conversion. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 46 +++ drivers/gpu/drm/bridge/analogix/anx7625.h | 1 + 2 files changed, 40 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridg

[PATCH v3 2/3] drm/bridge: anx7625: add HDCP support

2022-01-06 Thread Xin Ji
This patch provides HDCP setting interface for userspace to dynamic enable/disable HDCP function. Reported-by: kernel test robot Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 335 +- drivers/gpu/drm/bridge/analogix/anx7625.h

[PATCH v3 3/3] drm/bridge: anx7625: add audio codec .get_eld support

2022-01-06 Thread Xin Ji
Provide .get_eld interface in hdmi_codec_ops for hdmi-codec driver. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/b

Re: [PATCH] drm/v3d/v3d_drv: Check for error num after setting mask

2022-01-06 Thread Melissa Wen
On 01/06, Jiasheng Jiang wrote: > Because of the possible failure of the dma_supported(), the > dma_set_mask_and_coherent() may return error num. > Therefore, it should be better to check it and return the error if > fails. > > Fixes: 334dd38a3878 ("drm/v3d: Set dma_mask as well as coherent_dma_ma

[bug report] drm/ast: Handle failed I2C initialization gracefully

2022-01-06 Thread Dan Carpenter
Hello Thomas Zimmermann, The patch 55dc449a7c60: "drm/ast: Handle failed I2C initialization gracefully" from Dec 6, 2021, leads to the following Smatch static checker warning: drivers/gpu/drm/ast/ast_mode.c:1232 ast_get_modes() warn: passing freed memory 'edid' drivers/gpu/drm/as

[PATCH v2 1/4] drm/i915: don't call free_mmap_offset when purging

2022-01-06 Thread Matthew Auld
The TTM backend is in theory the only user here(also purge should only be called once we have dropped the pages), where it is setup at object creation and is only removed once the object is destroyed. Also resetting the node here might be iffy since the ttm fault handler uses the stored fake offset

[PATCH v2 2/4] drm/i915/ttm: only fault WILLNEED objects

2022-01-06 Thread Matthew Auld
Don't attempt to fault and re-populate purged objects. By some fluke this passes the dontneed-after-mmap IGT, but for the wrong reasons. Fixes: cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.") Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- driv

[PATCH v2 3/4] drm/i915/ttm: add unmap_virtual callback

2022-01-06 Thread Matthew Auld
Ensure we call ttm_bo_unmap_virtual when releasing the pages. Importantly this should now handle the ttm swapping case, and all other places that already call into i915_ttm_move_notify(). Fixes: cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.") Signed-off-by: Matthew Auld Cc: Thomas

[PATCH v2 4/4] drm/i915/ttm: ensure we unmap when purging

2022-01-06 Thread Matthew Auld
Purging can happen during swapping out, or directly invoked with the madvise ioctl. In such cases this doesn't involve a ttm move, which skips umapping the object. v2(Thomas): - add ttm_truncate helper, and just call into i915_ttm_move_notify() to handle the unmapping step Fixes: cf3e3e86d779 (

Re: [PATCH] drm/v3d: Fix PM disable depth imbalance in v3d_platform_drm_probe

2022-01-06 Thread Dave Stevenson
Thanks for the patch. On Wed, 5 Jan 2022 at 12:04, Miaoqian Lin wrote: > > The pm_runtime_enable will increase power disable depth. > If the probe fails, we should use pm_runtime_disable() to balance > pm_runtime_enable(). > > Fixes: 57692c9 ("drm/v3d: Introduce a new DRM driver for Broadcom V3D

Re: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

2022-01-06 Thread Thomas Zimmermann
Hi Am 03.01.22 um 08:41 schrieb Christian König: Am 26.12.21 um 21:59 schrieb Arunpravin: Hi Thomas On 16/12/21 5:05 pm, Thomas Zimmermann wrote: Hi Am 01.12.21 um 17:39 schrieb Arunpravin: - Make drm_buddy_alloc a single function to handle     range allocation and non-range allocation de

Re: [PATCH v5 4/6] drm/i915: Use vma resources for async unbinding

2022-01-06 Thread Matthew Auld
On 04/01/2022 12:51, Thomas Hellström wrote: Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should

Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe

2022-01-06 Thread Miaoqian Lin
Hi, Chun-Kuang: On Fri, Dec 31, 2021 at 12:31:33AM +0800, Chun-Kuang Hu wrote: > > diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > > b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > > index 28ad9403c441..67b005d5b9e3 100644 > > --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > > +++ b/drivers/phy

[PATCH v2] drm/v3d: Fix PM disable depth imbalance in v3d_platform_drm_probe

2022-01-06 Thread Miaoqian Lin
The pm_runtime_enable will increase power disable depth. If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable(). Fixes: 57692c9 ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Signed-off-by: Miaoqian Lin --- Changes in v2 - put pm_runtime_disable befo

Re: [PATCH] drm: omapdrm: Fix implicit dma_buf fencing

2022-01-06 Thread Tomi Valkeinen
Hi, On 05/01/2022 17:36, Ivaylo Dimitrov wrote: Currently omapdrm driver does not initialize dma_buf_export_info resv member, which leads to a new dma_resv being allocated and attached to the exported dma_buf. This leads to the issue that fences created on dma_buf objects imported by other drive

[Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption

2022-01-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215001 The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) changed: What|Removed |Added C

Re: [PATCH v5 1/6] drm/i915: Initial introduction of vma resources

2022-01-06 Thread Matthew Auld
On 04/01/2022 12:51, Thomas Hellström wrote: Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for a

Re: [PATCH v5 2/6] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-06 Thread Matthew Auld
On 04/01/2022 12:51, Thomas Hellström wrote: When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma()

Re: [PATCH v5 3/6] drm/i915: Don't pin the object pages during pending vma binds

2022-01-06 Thread Matthew Auld
On 04/01/2022 12:51, Thomas Hellström wrote: A pin-count is already held by vma->pages so taking an additional pin during async binds is not necessary. When we introduce async unbinding we have other means of keeping the object pages alive. Signed-off-by: Thomas Hellström Reviewed-by: Matthew

Re: [PATCH v8 04/10] vgaarb: Move framebuffer detection to ADD_DEVICE path

2022-01-06 Thread Bjorn Helgaas
On Thu, Jan 06, 2022 at 02:44:42PM +0800, Huacai Chen wrote: > On Thu, Jan 6, 2022 at 8:07 AM Bjorn Helgaas wrote: > > Previously we selected a device that owns the boot framebuffer as the > > default device in vga_arb_select_default_device(). This was only done in > > the vga_arb_device_init() s

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-06 Thread Matthew Brost
On Thu, Jan 06, 2022 at 09:56:03AM +, Tvrtko Ursulin wrote: > > On 05/01/2022 16:24, Matthew Brost wrote: > > On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin wrote: > > > > > > On 04/01/2022 23:30, Matthew Brost wrote: > > > > Don't use the interruptable version of the timeline mutex

Re: [PATCH v8 00/10] vgaarb: Rework default VGA device selection

2022-01-06 Thread Bjorn Helgaas
[+to Maarten, Maxime, Thomas: sorry, I forgot to use get_maintainer.pl so I missed you the first time. Beginning of thread: https://lore.kernel.org/all/20220106000658.243509-1-helg...@kernel.org/#t Git branch with this v8 + a couple trivial renames, based on v5.16-rc1: https://git.kernel.org/pub/s

Re: [PATCH] drm/ttm: Don't inherit GEM object VMAs in child process

2022-01-06 Thread Christian König
Am 06.01.22 um 17:45 schrieb Felix Kuehling: Am 2022-01-06 um 4:05 a.m. schrieb Christian König: Am 05.01.22 um 17:16 schrieb Felix Kuehling: [SNIP] But KFD doesn't know anything about the inherited BOs from the parent process. Ok, why that? When the KFD is reinitializing it's context why sho

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-06 Thread Tvrtko Ursulin
On 06/01/2022 16:18, Matthew Brost wrote: On Thu, Jan 06, 2022 at 09:56:03AM +, Tvrtko Ursulin wrote: On 05/01/2022 16:24, Matthew Brost wrote: On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin wrote: On 04/01/2022 23:30, Matthew Brost wrote: Don't use the interruptable version

Re: [PATCH] drm/ttm: Don't inherit GEM object VMAs in child process

2022-01-06 Thread Felix Kuehling
Am 2022-01-06 um 11:48 a.m. schrieb Christian König: > Am 06.01.22 um 17:45 schrieb Felix Kuehling: >> Am 2022-01-06 um 4:05 a.m. schrieb Christian König: >>> Am 05.01.22 um 17:16 schrieb Felix Kuehling: [SNIP] >> But KFD doesn't know anything about the inherited BOs >> from the parent

[PATCH 0/7] Per client GPU stats

2022-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Same old work but now rebased and series ending with some DRM docs proposing the common specification which should enable nice common userspace tools to be written. For the moment I only have intel_gpu_top converted to use this and that seems to work okay. v2: * Added prot

[PATCH 1/7] drm/i915: Explicitly track DRM clients

2022-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tracking DRM clients more explicitly will allow later patches to accumulate past and current GPU usage in a centralised place and also consolidate access to owning task pid/name. Unique client id is also assigned for the purpose of distinguishing/ consolidating between multi

[PATCH 2/7] drm/i915: Make GEM contexts track DRM clients

2022-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Make GEM contexts keep a reference to i915_drm_client for the whole of of their lifetime which will come handy in following patches. v2: Don't bother supporting selftests contexts from debugfs. (Chris) v3 (Lucas): Finish constructing ctx before adding it to the list v4 (Ram)

[PATCH 3/7] drm/i915: Track runtime spent in closed and unreachable GEM contexts

2022-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes. As GEM contexts are closed we want to have the DRM client remember how much GPU time they used (per class) so later we can used it for smarter

[PATCH 4/7] drm/i915: Track all user contexts per client

2022-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We soon want to start answering questions like how much GPU time is the context belonging to a client which exited still using. To enable this we start tracking all context belonging to a client on a separate list. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamse

[PATCH 5/7] drm/i915: Track context current active time

2022-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track context active (on hardware) status together with the start timestamp. This will be used to provide better granularity of context runtime reporting in conjunction with already tracked pphwsp accumulated runtime. The latter is only updated on context save so does not g

[PATCH 6/7] drm: Document fdinfo format specification

2022-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Proposal to standardise the fdinfo text format as optionally output by DRM drivers. Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM. i91

[PATCH 7/7] drm/i915: Expose client engine utilisation via fdinfo

2022-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similar to AMD commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for i915. Example of the output: pos:0 flags: 012 mnt_id: 21 drm-driver:

Re: [Intel-gfx] [PATCH] drm/i915: Lock timeline mutex directly in error path of eb_pin_timeline

2022-01-06 Thread Matthew Brost
On Thu, Jan 06, 2022 at 04:51:21PM +, Tvrtko Ursulin wrote: > > On 06/01/2022 16:18, Matthew Brost wrote: > > On Thu, Jan 06, 2022 at 09:56:03AM +, Tvrtko Ursulin wrote: > > > > > > On 05/01/2022 16:24, Matthew Brost wrote: > > > > On Wed, Jan 05, 2022 at 09:35:44AM +, Tvrtko Ursulin

Re: [PATCH] drm/ttm: Don't inherit GEM object VMAs in child process

2022-01-06 Thread Felix Kuehling
Am 2022-01-06 um 4:05 a.m. schrieb Christian König: > Am 05.01.22 um 17:16 schrieb Felix Kuehling: >> [SNIP] But KFD doesn't know anything about the inherited BOs from the parent process. >>> Ok, why that? When the KFD is reinitializing it's context why >>> shouldn't it cleanup those VMAs

Re: [PATCH v2] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Kuogee Hsieh
On 1/5/2022 1:34 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-12-29 11:17:02) There is kernel crashed due to unable to handle kernel NULL pointer dereference of dp_panel->connector while running DP link layer compliance test case 4.2.2.6 (EDID Corruption Detection). Can you explain how

[PATCH v3] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-06 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Changes in V2: -- replace dp_catalog_ctrl_set_pattern() with dp_catalog_ctrl_set_pattern_state_bit() Changes in V3: --

[PATCH v3] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Kuogee Hsieh
We never assign struct dp_panel::connector, instead the connector is stored in struct msm_dp::connector. When we run compliance testing test case 4.2.2.6 dp_panel_handle_sink_request() won't have a valid edid set in struct dp_panel::edid so we'll try to use the connectors real_edid_checksum and hit

Re: [PATCH v6 4/6] drm: implement a method to free unused pages

2022-01-06 Thread Arunpravin
On 04/01/22 7:41 pm, Matthew Auld wrote: > On 26/12/2021 22:24, Arunpravin wrote: >> On contiguous allocation, we round up the size >> to the *next* power of 2, implement a function >> to free the unused pages after the newly allocate block. >> >> v2(Matthew Auld): >>- replace function name

Re: [Openpvrsgx-devgroup] [PATCH] drm: omapdrm: Fix implicit dma_buf fencing

2022-01-06 Thread H. Nikolaus Schaller
Hi Ivo, > Am 06.01.2022 um 17:26 schrieb Ivaylo Dimitrov : > > Hi, > > On 6.01.22 г. 15:43 ч., Tomi Valkeinen wrote: >> Hi, >> On 05/01/2022 17:36, Ivaylo Dimitrov wrote: >>> Currently omapdrm driver does not initialize dma_buf_export_info resv >>> member, which leads to a new dma_resv being all

[PATCH v3 1/4] drm/i915: don't call free_mmap_offset when purging

2022-01-06 Thread Matthew Auld
The TTM backend is in theory the only user here(also purge should only be called once we have dropped the pages), where it is setup at object creation and is only removed once the object is destroyed. Also resetting the node here might be iffy since the ttm fault handler uses the stored fake offset

[PATCH v3 3/4] drm/i915/ttm: add unmap_virtual callback

2022-01-06 Thread Matthew Auld
Ensure we call ttm_bo_unmap_virtual when releasing the pages. Importantly this should now handle the ttm swapping case, and all other places that already call into i915_ttm_move_notify(). v2: fix up the selftest Fixes: cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.") Signed-off-by:

[PATCH v3 2/4] drm/i915/ttm: only fault WILLNEED objects

2022-01-06 Thread Matthew Auld
Don't attempt to fault and re-populate purged objects. By some fluke this passes the dontneed-after-mmap IGT, but for the wrong reasons. Fixes: cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.") Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- driv

[PATCH v3 4/4] drm/i915/ttm: ensure we unmap when purging

2022-01-06 Thread Matthew Auld
Purging can happen during swapping out, or directly invoked with the madvise ioctl. In such cases this doesn't involve a ttm move, which skips umapping the object. v2(Thomas): - add ttm_truncate helper, and just call into i915_ttm_move_notify() to handle the unmapping step Fixes: cf3e3e86d779 (

Re: [PATCH v3] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Bjorn Andersson
On Thu 06 Jan 09:15 PST 2022, Kuogee Hsieh wrote: > We never assign struct dp_panel::connector, instead the connector is > stored in struct msm_dp::connector. When we run compliance testing test > case 4.2.2.6 dp_panel_handle_sink_request() won't have a valid edid set I unfortunately have no idea

[Bug 206475] amdgpu under load drop signal to monitor until hard reset

2022-01-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206475 rends...@gmail.com (rends...@gmail.com) changed: What|Removed |Added CC||rends...@gmail.c

[PATCH] drm/etnaviv: relax submit size limits

2022-01-06 Thread Lucas Stach
While all userspace tried to limit commandstreams to 64K in size, a bug in the Mesa driver lead to command streams of up to 128K being submitted. Allow those to avoid breaking existing userspace. Fixes: 6dfa2fab8ddd ("drm/etnaviv: limit submit sizes") Cc: sta...@vger.kernel.org Signed-off-by: Luca

Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI

2022-01-06 Thread Bjorn Helgaas
On Thu, Jan 06, 2022 at 05:41:00PM +, John Garry wrote: > On 05/01/2022 19:47, Bjorn Helgaas wrote: > > IMO inb() should > > be present but do something innocuous like return ~0, as it would if > > I/O port space is supported but there's no device at that address. > > > > [1]https://git.kerne

[PATCH 0/2] drm/msm/gpu: System suspend fixes

2022-01-06 Thread Rob Clark
From: Rob Clark Because system suspend uses pm_runtime_force_suspend() we can't rely runpm refcnt's to protect us if the GPU is active, etc. Fortunately *usually* the GPU is idle when system suspend is triggered. But that isn't quite good enough. The first patch attempts to block for a modest

[PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-06 Thread Rob Clark
From: Rob Clark System suspend uses pm_runtime_force_suspend(), which cheekily bypasses the runpm reference counts. This doesn't actually work so well when the GPU is active. So add a reasonable delay waiting for the GPU to become idle. Alternatively we could just return -EBUSY in this case, b

[PATCH 2/2] drm/msm/gpu: Cancel idle/boost work on suspend

2022-01-06 Thread Rob Clark
From: Rob Clark With system suspend using pm_runtime_force_suspend() we can't rely on the pm_runtime_get_if_in_use() trick to deal with devfreq callbacks after (or racing with) suspend. So flush any pending idle or boost work in the suspend path. Signed-off-by: Rob Clark --- drivers/gpu/drm/m

Re: [Openpvrsgx-devgroup] [PATCH] drm: omapdrm: Fix implicit dma_buf fencing

2022-01-06 Thread Merlijn Wajer
Hi, On 06/01/2022 10:45, Tony Lindgren wrote: > * Ivaylo Dimitrov [220105 15:38]: >> Fix that by initializing dma_buf resv to the resv of the gem object being >> exported. > > Nice find! This also fixes my wlroots test case with termite running on > sway where termite would only partially update

Re: [PATCH] drm: omapdrm: Fix implicit dma_buf fencing

2022-01-06 Thread Ivaylo Dimitrov
Hi, On 6.01.22 г. 15:43 ч., Tomi Valkeinen wrote: Hi, On 05/01/2022 17:36, Ivaylo Dimitrov wrote: Currently omapdrm driver does not initialize dma_buf_export_info resv member, which leads to a new dma_resv being allocated and attached to the exported dma_buf. This leads to the issue that fence

[PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS

2022-01-06 Thread Jiri Vanek
Fixed wrong register shift for single/dual link LVDS output. Tested-by: Jiri Vanek Signed-off-by: Jiri Vanek --- v1: * Initial version v2: * Tested-by tag added --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc

Re: [RFC v2 8/8] drm/amd/virt: Drop concurrent GPU reset protection for SRIOV

2022-01-06 Thread Andrey Grodzovsky
On 2022-01-06 12:18 a.m., JingWen Chen wrote: On 2022/1/6 下午12:59, JingWen Chen wrote: On 2022/1/6 上午2:24, Andrey Grodzovsky wrote: On 2022-01-05 2:59 a.m., Christian König wrote: Am 05.01.22 um 08:34 schrieb JingWen Chen: On 2022/1/5 上午12:56, Andrey Grodzovsky wrote: On 2022-01-04 6:36 a.

[PATCH v4] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Kuogee Hsieh
DP CTS test case 4.2.2.6 has valid edid with bad checksum on purpose and expect DP source return correct checksum. During drm edid read, correct edid checksum is calculated and stored at connector::real_edid_checksum. The problem is struct dp_panel::connector never be assigned, instead the connect

[PATCH v4] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Kuogee Hsieh
DP CTS test case 4.2.2.6 has valid edid with bad checksum on purpose and expect DP source return correct checksum. During drm edid read, correct edid checksum is calculated and stored at connector::real_edid_checksum. The problem is struct dp_panel::connector never be assigned, instead the connect

Re: [PATCH v6 2/6] drm: improve drm_buddy_alloc function

2022-01-06 Thread Arunpravin
> -Original Message- > From: amd-gfx On Behalf Of Matthew > Auld > Sent: Tuesday, January 4, 2022 7:32 PM > To: Paneer Selvam, Arunpravin ; > dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: Deucher, Alexander ; tzimmerm...@suse.d

[PATCH v5 00/32] component: Make into an aggregate bus

2022-01-06 Thread Stephen Boyd
This series is from discussion we had on reordering the device lists for drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put the aggregate device onto and then we probe the aggregate device once all the components are probed and call component_add(). The probe/remove hooks are whe

[PATCH v5 01/32] component: Replace most references to 'master' with 'aggregate device'

2022-01-06 Thread Stephen Boyd
Remove most references to 'master' in the code and replace them with some form of 'aggregate device'. This better reflects the reality of what this code does, i.e. an aggregate device that represents a device like a GPU card once some set of devices that make up the aggregate device probe and regis

[PATCH v5 02/32] component: Introduce the aggregate bus_type

2022-01-06 Thread Stephen Boyd
The component framework only provides 'bind' and 'unbind' callbacks to tell the host driver that it is time to assemble the aggregate driver now that all the components have probed. The component framework doesn't attempt to resolve runtime PM or suspend/resume ordering, and explicitly mentions thi

[PATCH v5 03/32] component: Move struct aggregate_device out to header file

2022-01-06 Thread Stephen Boyd
This allows aggregate driver writers to use the device passed to their probe/remove/shutdown functions properly instead of treating it as an opaque pointer. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kanna

[PATCH v5 04/32] component: Add {bind, unbind}_component() ops that take aggregate device

2022-01-06 Thread Stephen Boyd
We'd like to get more device model features in the component framework so let's pass the struct aggregate_device pointer instead of the parent device pointer to the component binding functions. This will allow drivers to inspect and control things related to the aggregate device in case they need i

[PATCH v5 06/32] drm/msm: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
The device lists are poorly ordered when the component device code is used. This is because component_master_add_with_match() returns 0 regardless of component devices calling component_add() first. It can really only fail if an allocation fails, in which case everything is going bad and we're out

[PATCH v5 07/32] drm/komeda: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: James Qian Wang (Arm Technology China) Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clar

[PATCH v5 09/32] drm/malidp: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. TODO: This can be updated to move the drm helper logic into the aggregate driver shutdown op. Cc: L

[PATCH v5 05/32] drm/of: Add a drm_of_aggregate_probe() API

2022-01-06 Thread Stephen Boyd
Similar to drm_of_component_probe() but using the new API that registers a driver instead of an ops struct. This allows us to migrate the users of drm_of_component_probe() to the new way of doing things. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell K

[PATCH v5 08/32] drm/arm/hdlcd: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Liviu Dudau Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Sa

[PATCH v5 10/32] drm/armada: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Russell King Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Saravana Kannan Si

[PATCH v5 11/32] drm/etnaviv: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Lucas Stach Cc: Russell King Cc: Christian Gmeiner Cc: Daniel Vetter Cc: "Rafael J. Wysocki"

[PATCH v5 12/32] drm/kirin: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Xinliang Liu Cc: Tian Tao Cc: John Stultz Cc: Xinwei Kong Cc: Chen Feng Cc: Daniel Vetter

[PATCH v5 13/32] drm/exynos: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Daniel Vetter Cc: "Rafa

[PATCH v5 14/32] drm/imx: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Philipp Zabel Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc:

[PATCH v5 15/32] drm/ingenic: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. TODO: Move the helpers to PM in aggregate driver hooks. Acked-by: Paul Cercueil Cc: Daniel Vetter

[PATCH v5 16/32] drm/mcde: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Te

[PATCH v5 17/32] drm/mediatek: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

[PATCH v5 19/32] drm/omap: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Tomi Valkeinen Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc:

[PATCH v5 18/32] drm/meson: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Neil Armstrong Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc:

[PATCH v5 20/32] drm/rockchip: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

[PATCH v5 21/32] drm/sti: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Si

[PATCH v5 22/32] drm/sun4i: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

  1   2   >