Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI

2021-12-28 Thread Greg Kroah-Hartman
On Mon, Dec 27, 2021 at 05:42:46PM +0100, Niklas Schnelle wrote: > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -23,6 +23,17 @@ menuconfig PCI > > if PCI > > +config LEGACY_PCI > + bool "Enable support for legacy PCI devices" > + depends on HAVE_PCI > + help > +

Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI

2021-12-28 Thread Mauro Carvalho Chehab
Em Tue, 28 Dec 2021 09:21:23 +0100 Greg Kroah-Hartman escreveu: > On Mon, Dec 27, 2021 at 05:42:46PM +0100, Niklas Schnelle wrote: > > --- a/drivers/pci/Kconfig > > +++ b/drivers/pci/Kconfig > > @@ -23,6 +23,17 @@ menuconfig PCI > > > > if PCI > > > > +config LEGACY_PCI > > + bool "Enable

[PATCH v2, 00/12] media: mtk-vcodec: support for MT8192 decoder

2021-12-28 Thread Yunfei Dong
This series adds support for mt8192 h264 decoder. Firstly, need to refactor power/clock/interrupt interfaces for mt8192 is lat and core architecture. Secondly, add new functions to get frame buffer size and resolution according to decoder capability from scp side. Then add callback function to get

[PATCH v2, 01/12] media: mtk-vcodec: Add vdec enable/disable hardware helpers

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong Lock, power and clock are highly coupled operations. Adds vdec enable/disable hardware helpers and uses them. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 5 - .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 168 +++--- .../plat

[PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong For lat and core architecture, just need to get output buffer for lat decode. For core hardware need to get lat's message and capture buffer. In order to let lat and core decode in parallel, need to set capture buffer buffered. Signed-off-by: Yunfei Dong --- drivers/media/pla

[PATCH v2, 02/12] media: mtk-vcodec: Using firmware type to separate different firmware architecture

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong MT8173 platform use vpu firmware, mt8183/mt8192 will use scp firmware instead, using chip name is not reasonable to separate different firmware architecture. Using firmware type is much better. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_st

[PATCH v2, 03/12] media: mtk-vcodec: get capture queue buffer size from scp

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong Different capture buffer format has different buffer size, need to get real buffer size according to buffer type from scp. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec.c | 2 + .../platform/mtk-vcodec/mtk_vcodec_drv.h | 2 + .../media/plat

[PATCH v2, 04/12] media: mtk-vcodec: Read max resolution from dec_capability

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong Supported max resolution for different platforms are not the same: 2K or 4K, getting it according to dec_capability. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec.c | 31 +++ .../platform/mtk-vcodec/mtk_vcodec_drv.h | 4 +++

[PATCH v2, 08/12] media: mtk-vcodec: Add format to support MT21C

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong Needs to use mediatek compressed mode for mt8192 decoder. Signed-off-by: Yunfei Dong --- .../media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c | 7 ++- drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-)

[PATCH v2, 10/12] media: mtk-vcodec: Fix v4l2-compliance fail

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong Need to use default pic info when get pic info fail from scp side. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/d

[PATCH v2, 09/12] media: mtk-vcodec: disable vp8 4K capability

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong For vp8 not support 4K, need to disable it. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk

[PATCH v2, 07/12] media: mtk-vcodec: Refactor supported vdec formats and framesizes

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong Supported output and capture format types for mt8192 are different with mt8183. Needs to get format types according to decoder capability. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec.c | 8 +- .../mtk-vcodec/mtk_vcodec_dec_stateful.c | 1

[PATCH v2, 11/12] media: mtk-vcodec: Extract H264 common code

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong H264 driver can reuse the same code for lat architecture with pure single. Moves them to a new file and add header file to call. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/Makefile| 1 + .../mtk-vcodec/vdec/vdec_h264_req_common.c| 303 +

[PATCH v2, 12/12] media: mtk-vcodec: Add h264 decoder driver for mt8192

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong Adds h264 lat and core driver for mt8192, and the decode mode is frame based for stateless decoder. Lat need output and trans buffers to decode, writing decode result to trans buffer when decode done. Core need capture and trans buffers, writing decode result to capture buffer

[PATCH v2, 06/12] media: mtk-vcodec: Refactor get and put capture buffer flow

2021-12-28 Thread Yunfei Dong
From: Yunfei Dong For lat and core decode in parallel, need to get capture buffer when core start to decode and put put capture buffer to display list when core decode done. Signed-off-by: Yunfei Dong --- .../mtk-vcodec/mtk_vcodec_dec_stateless.c | 123 -- .../platform/mtk-

Re: [PATCH] drm/edid: support Microsoft extension for HMDs and specialized monitors

2021-12-28 Thread Jani Nikula
On Mon, 13 Dec 2021, Philipp Zabel wrote: > Add minimal support for parsing VSDBs documented in Microsoft's "EDID > extension for head-mounted and specialized monitors" [1]. The version > field and the desktop usage flag can be used to set the non_desktop > connector property. > > Remove the non-d

[PATCH] drm/edid: improve non-desktop quirk logging

2021-12-28 Thread Jani Nikula
Improve non-desktop quirk logging if the EDID indicates non-desktop. If both are set, note about redundant quirk. If there's no quirk but the EDID indicates non-desktop, don't log non-desktop is set to 0. Cc: Philipp Zabel Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 17 +

Re: [PATCH] drm/edid: support Microsoft extension for HMDs and specialized monitors

2021-12-28 Thread Jani Nikula
On Tue, 28 Dec 2021, Jani Nikula wrote: > On Mon, 13 Dec 2021, Philipp Zabel wrote: >> Add minimal support for parsing VSDBs documented in Microsoft's "EDID >> extension for head-mounted and specialized monitors" [1]. The version >> field and the desktop usage flag can be used to set the non_desk

Re: [PATCH v4 0/6] drm: exynos: dsi: Convert drm bridge

2021-12-28 Thread Andrzej Hajda
Hi Marek, On 23.12.2021 10:15, Marek Szyprowski wrote: Hi Jagan, On 18.12.2021 00:16, Marek Szyprowski wrote: On 15.12.2021 15:56, Jagan Teki wrote: On Wed, Dec 15, 2021 at 7:49 PM Marek Szyprowski wrote: On 15.12.2021 13:57, Jagan Teki wrote: On Wed, Dec 15, 2021 at 5:31 PM Marek Szyprows

[Bug 214963] [amdgpu] resuming from suspend fails when IOMMU is missing

2021-12-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214963 spassw...@web.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI

2021-12-28 Thread Greg Kroah-Hartman
On Tue, Dec 28, 2021 at 11:58:55AM +0100, Niklas Schnelle wrote: > We add both LEGACY_PCI and HAS_IOPORT to differentiate between two > cases. HAS_IOPORT is for PC-style devices that are not on a PCI card > while LEGACY_PCI is for PCI drivers that require port I/O. This > includes pre-PCIe devices

Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI

2021-12-28 Thread Mauro Carvalho Chehab
Em Tue, 28 Dec 2021 11:58:55 +0100 Niklas Schnelle escreveu: > On Tue, 2021-12-28 at 10:15 +0100, Mauro Carvalho Chehab wrote: > > Em Tue, 28 Dec 2021 09:21:23 +0100 > > Greg Kroah-Hartman escreveu: > > > > > On Mon, Dec 27, 2021 at 05:42:46PM +0100, Niklas Schnelle wrote: > > > > --- a/dri

Re: [PATCH] drm/mediatek: Fix unused-but-set variable warning

2021-12-28 Thread Matthias Brugger
On 28/12/2021 10:25, Miles Chen wrote: Fix unused-but-set variable warning: drivers/gpu/drm/mediatek/mtk_cec.c:85:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] Actually we ignore the value passed to mtk_cec_mask. In case of mtk_cec_mask(cec, CEC_CKGEN, 0 | CEC_32K

Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI

2021-12-28 Thread Mauro Carvalho Chehab
Em Tue, 28 Dec 2021 16:06:44 +0100 Niklas Schnelle escreveu: (on a side note: the c/c list of this patch is too long. I would try to avoid using a too long list, as otherwise this e-mail may end being rejected by mail servers) > On Tue, 2021-12-28 at 13:54 +0100, Mauro Carvalho Chehab wrote: > >

Re: [PATCH] drm/msm/dp: Fix a potential double free in an error handling path

2021-12-28 Thread Kuogee Hsieh
On 12/26/2021 7:14 AM, Christophe JAILLET wrote: 'dp_bridge' is devm_alloc'ed, so there is no need to free it explicitly or there will be a double free(). Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") Signed-off-by: Christophe JAILLET Reviewed-by

[PATCH] drm/msm/dp: populate connector of struct dp_panel

2021-12-28 Thread Kuogee Hsieh
There is kernel crashed happen due to unable to handle kernel NULL pointer dereference of dp_panel->connector while running DP link layer compliance test case 4.2.2.6 (EDIDCorruption Detection). This patch will fixed the problem by populating connector of dp_panel. Fixes: 7948fe12d47 ("drm/msm/dp

Re: [PATCH] drm/msm/dp: populate connector of struct dp_panel

2021-12-28 Thread Bjorn Andersson
On Tue 28 Dec 09:51 PST 2021, Kuogee Hsieh wrote: > There is kernel crashed happen due to unable to handle kernel NULL It would be wonderful, for my understanding today, as well as people in the coming months to be able to search for the callstack etc on the mailing list, if you could provide som

[PATCH] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2021-12-28 Thread Kuogee Hsieh
From: Kuogee Hsieh Some DP sinkers prefer to use tps4 instead of tps3 during training #2. This patch will use tps4 to perform link training #2 if sinker's DPCD supports it. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 16 1 file changed, 12 insertions(+),

[PATCH] drm/bridge: sn65dsi83: Fix an error handling path in sn65dsi83_probe()

2021-12-28 Thread Christophe JAILLET
sn65dsi83_parse_dt() takes a reference on 'ctx->host_node' that must be released in the error handling path of the probe. This is only done in the remove function up to now. Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver") Signed-off-by: Christophe JAILLET

Re: [PATCH] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2021-12-28 Thread Bjorn Andersson
On Tue 28 Dec 10:51 PST 2021, Kuogee Hsieh wrote: > From: Kuogee Hsieh > > Some DP sinkers prefer to use tps4 instead of tps3 during training #2. > This patch will use tps4 to perform link training #2 if sinker's DPCD > supports it. > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/

Re: [PATCH v2 2/2] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2021-12-28 Thread Dmitry Baryshkov
Kuogee, Some time ago you volonteered to check these two patches on a DP hosts. Any progress? On 26/11/2021 05:35, Dmitry Baryshkov wrote: In order to simplify DP code, drop hand-coded loops over clock arrays, replacing them with clk_bulk_* functions. Signed-off-by: Dmitry Baryshkov --- d

question about an intel-gfx issue (4447)

2021-12-28 Thread Randy Dunlap
Hi, For https://gitlab.freedesktop.org/drm/intel/-/issues/4447, are people aware of it or do I need to make people aware of it somehow? Do I need to provide more information? If so, what? thanks. -- ~Randy

Re: [PATCH v2 2/2] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2021-12-28 Thread Bjorn Andersson
On Thu 25 Nov 20:35 CST 2021, Dmitry Baryshkov wrote: > In order to simplify DP code, drop hand-coded loops over clock arrays, > replacing them with clk_bulk_* functions. > I've yet to debug this, but applying the two patches and attaching an HDMI cable to my USB dongle results in the follwing s

Re: [PATCH v7 6/8] phy: phy-mtk-dp: Add driver for DP phy

2021-12-28 Thread Vinod Koul
On 17-12-21, 16:08, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann Pls cc relevant folks on cover so that they know what is going on in the series... Is this dependent on rest? It should not and can be sent and reviewed separately! > This is a new driver that supports the integrate

Re: [PATCH] drm/bridge: sn65dsi83: Fix an error handling path in sn65dsi83_probe()

2021-12-28 Thread Laurent Pinchart
Hi Christophe, Thank you for the patch. On Tue, Dec 28, 2021 at 11:37:25PM +0100, Christophe JAILLET wrote: > sn65dsi83_parse_dt() takes a reference on 'ctx->host_node' that must be > released in the error handling path of the probe. > This is only done in the remove function up to now. > > Fixe

Re: [PATCH v2, 03/12] media: mtk-vcodec: get capture queue buffer size from scp

2021-12-28 Thread yunfei.d...@mediatek.com
Hi Tzung-Bi, Thanks for your suggestion. On Wed, 2021-12-29 at 13:36 +0800, Tzung-Bi Shih wrote: > On Tue, Dec 28, 2021 at 05:41:37PM +0800, Yunfei Dong wrote: > > From: Yunfei Dong > > [...] > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c > > b/drivers/media/platform/mtk-vco