Re: [PATCH v2 1/4] drm: exynos: dsi: Check panel for panel helpers

2021-12-13 Thread Andrzej Hajda
On 10.12.2021 20:19, Jagan Teki wrote: Trigger the panel operation helpers only if host found the panel. Add check. Signed-off-by: Jagan Teki Both helpers handle already "NULL panels", so these checks are redundant. Regards Andrzej --- Changes for v2: - new patch drivers/gpu/drm/e

Re: [PATCH v3 2/3] drm/format-helper: Add drm_fb_xrgb8888_to_xrgb2101010_toio()

2021-12-13 Thread Thomas Zimmermann
Am 12.12.21 um 07:24 schrieb Hector Martin: Add XRGB emulation support for devices that can only do XRGB2101010. This is chiefly useful for simpledrm on Apple devices where the bootloader-provided framebuffer is 10-bit. Signed-off-by: Hector Martin Reviewed-by: Thomas Zimmermann ---

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Thomas Zimmermann
Hi Am 12.12.21 um 22:29 schrieb Rob Herring: On Sun, Dec 12, 2021 at 12:24 AM Hector Martin wrote: This code is required for both simplefb and simpledrm, so let's move it into the OF core instead of having it as an ad-hoc initcall in the drivers. Acked-by: Thomas Zimmermann Signed-off-by: H

Re: [PATCH v2 1/4] drm: exynos: dsi: Check panel for panel helpers

2021-12-13 Thread Jagan Teki
Hi Andrzej, On Mon, Dec 13, 2021 at 1:44 PM Andrzej Hajda wrote: > > > On 10.12.2021 20:19, Jagan Teki wrote: > > Trigger the panel operation helpers only if host found the panel. > > > > Add check. > > > > Signed-off-by: Jagan Teki > > > Both helpers handle already "NULL panels", so these check

Re: [PATCH v12, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-12-13 Thread yunfei.d...@mediatek.com
Hi Rob, Thanks for your suggestion. On Fri, 2021-12-10 at 10:49 -0600, Rob Herring wrote: > On Thu, Dec 02, 2021 at 11:45:40AM +0800, Yunfei Dong wrote: > > Adds decoder dt-bindings for mt8192. > > > > Signed-off-by: Yunfei Dong > > --- > > .../media/mediatek,vcodec-subdev-decoder.yaml | 266 >

Re: [PATCH v12, 06/19] media: mtk-vcodec: Add to support multi hardware decode

2021-12-13 Thread yunfei.d...@mediatek.com
Hi Steve, Thanks for your suggestion, On Thu, 2021-12-09 at 15:29 -0800, Steve Cho wrote: > Few comments and questions. > > On Wed, Dec 1, 2021 at 7:46 PM Yunfei Dong > wrote: > > > > There are more than two hardwares for decoder: LAT0, LAT1 and CORE. > > In order to > > manage these hardwares,

[PATCH v13, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-12-13 Thread Yunfei Dong
Different platforms may have different numbers of register bases. Gets the numbers of register bases from dts (sizeof(u32) * 4 bytes for each). Reviewed-by: Tzung-Bi Shih Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 37 ++- 1 file changed, 28 ins

[PATCH v13, 00/19] Support multi hardware decode using of_platform_populate

2021-12-13 Thread Yunfei Dong
This series adds support for multi hardware decode into mtk-vcodec, by first adding use of_platform_populate to manage each hardware information: interrupt, clock, register bases and power. Secondly add core work queue to deal with core hardware message, at the same time, add msg queue for diffe

[PATCH v13, 04/19] media: mtk-vcodec: export decoder pm functions

2021-12-13 Thread Yunfei Dong
When mtk vcodec decoder is build as a module, we need to export mtk-vcodec-dec pm functions to make them visible by the other components. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benjamin Gaignard Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c

[PATCH v13, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-12-13 Thread Yunfei Dong
Vdec and venc can use the same function to wake up interrupt event. Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 + drivers/media/platform/mtk-vcodec

[PATCH v13, 06/19] media: mtk-vcodec: Add to support multi hardware decode

2021-12-13 Thread Yunfei Dong
There are more than two hardwares for decoder: LAT0, LAT1 and CORE. In order to manage these hardwares, register each hardware as independent platform device for the larbs are different. Each hardware module controls its own information which includes interrupt/power/ clocks/registers. Calling o

[PATCH v13, 07/19] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

2021-12-13 Thread Yunfei Dong
Separate decoder and encoder document for the dts are big difference. Reviewed-by: Rob Herring Signed-off-by: Yunfei Dong --- .../media/mediatek,vcodec-decoder.yaml| 176 + .../media/mediatek,vcodec-encoder.yaml| 187 ++ .../bindings/media/mediatek

[PATCH v13, 05/19] media: mtk-vcodec: Support MT8192

2021-12-13 Thread Yunfei Dong
From: Yunfei Dong Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". Adds MT8192's device private data mtk_lat_sig_core_pdata. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong --- .../media/platform/mtk-vcodec/mtk_vcodec_dec.h | 1 + .../platform/mtk-vcodec/mtk_vcode

[PATCH v13, 03/19] media: mtk-vcodec: Refactor vcodec pm interface

2021-12-13 Thread Yunfei Dong
Using the needed params for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 ++--- ..

[PATCH v13, 08/19] media: mtk-vcodec: Use pure single core for MT8183

2021-12-13 Thread Yunfei Dong
Separates different architecture for hardware: pure_sin_core and lat_sin_core. MT8183 is pure single core. Uses .hw_arch to distinguish. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_stateful.c | 1 + .../platform/mtk-vcodec

[PATCH v13, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-12-13 Thread Yunfei Dong
For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/Makefile| 1 + .../plat

[PATCH v13, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces

2021-12-13 Thread Yunfei Dong
Generalizes power and clock on/off interfaces to support different hardware. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_d

[PATCH v13, 12/19] media: mtk-vcodec: Add new interface to lock different hardware

2021-12-13 Thread Yunfei Dong
For add new hardware, not only need to lock lat hardware, also need to lock core hardware in case of different instance start to decoder at the same time. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 ++-- dri

[PATCH v13, 14/19] media: mtk-vcodec: Support 34bits dma address for vdec

2021-12-13 Thread Yunfei Dong
Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it depends on the dma-ranges property of vdec dtsi nod

[PATCH v13, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-12-13 Thread Yunfei Dong
Adds decoder dt-bindings for mt8192. Signed-off-by: Yunfei Dong --- Fix comments from rob. --- .../media/mediatek,vcodec-subdev-decoder.yaml | 265 ++ 1 file changed, 265 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yam

[PATCH v13, 17/19] media: mtk-vcodec: Use codec type to separate different hardware

2021-12-13 Thread Yunfei Dong
There is just one core thread, in order to separate different hardware, using codec type to separeate it in scp driver. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 12 --- .../media/platform/mtk-vcodec/vdec_vpu_if.c

[PATCH v13, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm

2021-12-13 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_dec_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_init_dec_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_dec_pm to *_clk since it only has clock operations now. Re

[PATCH v13, 13/19] media: mtk-vcodec: Add work queue for core hardware decode

2021-12-13 Thread Yunfei Dong
Add work queue to process core hardware information. First, get lat_buf from message queue, then call core hardware of each codec(H264/VP9/AV1) to decode, finally puts lat_buf back to the message. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 16 +++- .../pla

[PATCH v13, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg

2021-12-13 Thread Yunfei Dong
Add core dec and dec end ipi msg: AP_IPIMSG_DEC_CORE/AP_IPIMSG_DEC_CORE_END. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 4 .../media/platform/mtk-vcodec/vdec_vpu_if.c| 12 .../media/platform/mtk

[PATCH v13, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

2021-12-13 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_enc_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *_clk since it only has clock operations now.

[PATCH v13, 09/19] media: mtk-vcodec: Add irq interface for multi hardware

2021-12-13 Thread Yunfei Dong
Adds irq interface for multi hardware. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 32 --- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25 ++

Re: WARNING: CPU: 1 PID: 722 at drivers/gpu/drm/i915/display/intel_tc.c:761

2021-12-13 Thread Ammar Faizi
On Wed, Dec 8, 2021 at 12:18 AM Imre Deak wrote: > > Hi Ammar, > > On Tue, Dec 07, 2021 at 10:54:59AM +0700, Ammar Faizi wrote: > > Hello, > > > > I found warnings in the stable tree. > > > > Commit: a2547651bc896f95a3680a6a0a27401e7c7a1080 ("Linux 5.15.6") > > > > There are two unique warn locati

[PATCH] drm: simpledrm: fix wrong unit with pixel clock

2021-12-13 Thread Alejandro Concepcion-Rodriguez
Pixel clock has to be set in kHz. Fixes: 11e8f5fd223b ("drm: Add simpledrm driver") Signed-off-by: Alejandro Concepcion-Rodriguez --- drivers/gpu/drm/tiny/simpledrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simp

[PATCH] drm: simpledrm: fix wrong unit with pixel clock

2021-12-13 Thread Alejandro Concepcion-Rodriguez
Pixel clock has to be set in kHz. Fixes: 11e8f5fd223b ("drm: Add simpledrm driver") Signed-off-by: Alejandro Concepcion-Rodriguez --- drivers/gpu/drm/tiny/simpledrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simp

Re: WARNING: CPU: 1 PID: 722 at drivers/gpu/drm/i915/display/intel_tc.c:761

2021-12-13 Thread Ammar Faizi
On Sun, Dec 12, 2021 at 7:01 PM Ammar Faizi wrote: > > On Wed, Dec 8, 2021 at 12:18 AM Imre Deak wrote: > > > > Hi Ammar, > > > > On Tue, Dec 07, 2021 at 10:54:59AM +0700, Ammar Faizi wrote: > > > Hello, > > > > > > I found warnings in the stable tree. > > > > > > Commit: a2547651bc896f95a3680a6a

[PATCH 00/10] dt-binding patches for sm6350

2021-12-13 Thread Luca Weiss
This series adds compatibles to the dt-bindings documentation where it was missed before. Finally, the last patch solves some further dtbs_check errors by modifying the sm6350.dtsi to match the binding docs more closely. Please note, that the first patch from Konrad is a resend that wasn't picked

[PATCH 09/10] dt-bindings: simple-framebuffer: allow standalone compatible

2021-12-13 Thread Luca Weiss
Qualcomm platforms use "simple-framebuffer" without a more specific compatible. Allow that in the binding doc. Signed-off-by: Luca Weiss --- .../bindings/display/simple-framebuffer.yaml | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Documentation/devicet

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Javier Martinez Canillas
Hello Hector, On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: > > This code is required for both simplefb and simpledrm, so let's move it > into the OF core instead of having it as an ad-hoc initcall in the > drivers. > > Acked-by: Thomas Zimmermann > Signed-off-by: Hector Martin > --- >

Re: [PATCH v12, 13/19] media: mtk-vcodec: Add work queue for core hardware decode

2021-12-13 Thread yunfei.d...@mediatek.com
Hi steve, Thanks for your suggestion. On Thu, 2021-12-09 at 15:44 -0800, Steve Cho wrote: > On Wed, Dec 1, 2021 at 7:46 PM Yunfei Dong > wrote: > > > > Add work queue to process core hardware information. > > First, get lat_buf from message queue, then call core > > hardware of each codec(H264/

Re: [PATCH] drm/stm: ltdc: support of new hardware version

2021-12-13 Thread Raphael Gallais-Pou
Hello Yannick, Thank you for this patch. Tested-by: Raphael Gallais-Pou mailto:raphael.gallais-...@foss.st.com>> Reviewed-by: Raphael Gallais-Pou mailto:raphael.gallais-...@foss.st.com>> Regards, Raphaël Gallais-Pou On 12/3/21 9:56 AM, Yannick Fertre wrote: > Add support of new hardware ve

Re: [PATCH v3 2/7] drm: exynos: dsi: Use drm panel_bridge API

2021-12-13 Thread Andrzej Hajda
On 12.12.2021 19:14, Jagan Teki wrote: Replace the manual panel handling code by a drm panel_bridge via devm_drm_of_get_bridge(). Adding panel_bridge handling, - Drops drm_connector and related operations as drm_bridge_attach creates connector during attachment. - Drops panel pointer and

Re: [PATCH v3 2/7] drm: exynos: dsi: Use drm panel_bridge API

2021-12-13 Thread Jagan Teki
Hi Andrzej, On Mon, Dec 13, 2021 at 2:39 PM Andrzej Hajda wrote: > > > On 12.12.2021 19:14, Jagan Teki wrote: > > Replace the manual panel handling code by a drm panel_bridge via > > devm_drm_of_get_bridge(). > > > > Adding panel_bridge handling, > > > > - Drops drm_connector and related operatio

[PATCH v3 0/3] drm/vc4: Use the firmware to stop the display pipeline

2021-12-13 Thread Maxime Ripard
Hi, The VC4 driver has had limited support to disable the HDMI controllers and pixelvalves at boot if the firmware has enabled them. However, this proved to be limited, and a bit unreliable so a new firmware command has been introduced some time ago to make it free all its resources and disable a

[PATCH v3 2/3] drm/vc4: Remove conflicting framebuffers before callind bind_all

2021-12-13 Thread Maxime Ripard
The bind hooks will modify their controller registers, so simplefb is going to be unusable anyway. Let's avoid any transient state where it could still be in the system but no longer functionnal. Acked-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.c | 8

[PATCH v3 1/3] firmware: raspberrypi: Add RPI_FIRMWARE_NOTIFY_DISPLAY_DONE

2021-12-13 Thread Maxime Ripard
The RPI_FIRMWARE_NOTIFY_DISPLAY_DONE firmware call allows to tell the firmware the kernel is in charge of the display now and the firmware can free whatever resources it was using. Acked-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- include/soc/bcm2835/raspberrypi-firmware.h | 1 +

Re: [PATCH v2] drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock().

2021-12-13 Thread Tvrtko Ursulin
On 10/12/2021 20:44, Sebastian Andrzej Siewior wrote: This is a revert of commits d67739268cf0e ("drm/i915/gt: Mark up the nested engine-pm timeline lock as irqsafe") 6c69a45445af9 ("drm/i915/gt: Mark context->active_count as protected by timeline->mutex") 6dcb85a0ad990 ("drm/i915

[PATCH v3 3/3] drm/vc4: Notify the firmware when DRM is in charge

2021-12-13 Thread Maxime Ripard
Once the call to drm_fb_helper_remove_conflicting_framebuffers() has been made, simplefb has been unregistered and the KMS driver is entirely in charge of the display. Thus, we can notify the firmware it can free whatever resource it was using to maintain simplefb functional. Signed-off-by: Maxim

Re: [PATCH] drm/stm: ltdc: support of new hardware version

2021-12-13 Thread Raphael Gallais-Pou
Hello Yannick, Thank you for this patch. Tested-by: Raphael Gallais-Pou mailto:raphael.gallais-...@foss.st.com>> Reviewed-by: Raphael Gallais-Pou mailto:raphael.gallais-...@foss.st.com>> Regards, Raphaël Gallais-Pou On 12/3/21 9:56 AM, Yannick Fertre wrote: > Add support of new hardware v

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-13 Thread Jani Nikula
On Fri, 10 Dec 2021, Kees Cook wrote: > On Fri, Dec 10, 2021 at 12:06:20PM +0200, Jani Nikula wrote: >> Post Cursor2 was completely optional for the transmitter even before it >> was deprecated. >> >> And now we'd be adding 5 bytes extra to all link status reads. To fix >> the only user of drm_dp

Re: [PATCH v3 3/7] drm: exynos: dsi: Convert to bridge driver

2021-12-13 Thread Andrzej Hajda
On 12.12.2021 19:14, Jagan Teki wrote: Convert the encoders to bridge drivers in order to standardize on a single API with built-in dumb encoder support for compatibility with existing component drivers. Driver bridge conversion will help to reuse the same bridge on different platforms as exyn

[PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

2021-12-13 Thread Thomas Zimmermann
Split-off DisplayPort functions from KMS helper library and move them into their own module. Reduces the size of drm_kms_helper.ko by ~50%. This patchset is part of an on-going effort to reduce the minimum binary size of the DRM core and helpers. It's helpful for systems with early-boot DRM graphi

[PATCH 1/3] drm/dp_mst: Remove trailing whitespace.

2021-12-13 Thread Thomas Zimmermann
Fix coding style. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index f3d79eda94bb..7f0ff96261cf 100644 --- a/drivers/gp

[PATCH 3/3] drm/dp: Move DisplayPort helpers into separate helper module

2021-12-13 Thread Thomas Zimmermann
Move DisplayPort functions into a separate module to reduce the size of the KMS helpers. Select DRM_DP_HELPER for all users of the code. To avoid naming conflicts, rename drm_dp_helper.c to drm_dp.c This change can help to reduce the size of the kernel binary. Some numbers from a x86-64 test build

[PATCH 2/3] drm/dp: Move DP declarations into separate header file

2021-12-13 Thread Thomas Zimmermann
Split the DP declarations from other helpers before moving the DP functions into a separate module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_crtc_helper_internal.h | 27 - drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- drivers/gpu/drm/drm_dp_helper.c

[PATCH] gpu: drm: mcde: add missing of_node_put before return

2021-12-13 Thread Qing Wang
From: Wang Qing Fix following coccicheck warning: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return. Early exits from for_each_available_child_of_node should decrement the node reference counter. Signed-off-by: Wang Qing --- drivers/gpu/drm/mcde/mcd

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

2021-12-13 Thread Michel Dänzer
On 2021-12-11 13:20, Rodrigo Siqueira Jordao wrote: > > > On 2021-12-09 11:46 a.m., Michel Dänzer wrote: >> From: Michel Dänzer >> >> Move code using the Pipe struct to a new helper function. >> >> Works around[0] this warning (resulting in failure to build a RHEL debug >> kernel with Werror ena

Re: [PATCH v3 2/3] drm/vc4: Remove conflicting framebuffers before callind bind_all

2021-12-13 Thread Thomas Zimmermann
Hi Maxime Am 13.12.21 um 10:25 schrieb Maxime Ripard: The bind hooks will modify their controller registers, so simplefb is going to be unusable anyway. Let's avoid any transient state where it could still be in the system but no longer functionnal. Acked-by: Nicolas Saenz Julienne Signed-off-

Re: [PATCH v3 2/3] drm/vc4: Remove conflicting framebuffers before callind bind_all

2021-12-13 Thread Thomas Zimmermann
Am 13.12.21 um 10:47 schrieb Thomas Zimmermann: Hi Maxime Am 13.12.21 um 10:25 schrieb Maxime Ripard: The bind hooks will modify their controller registers, so simplefb is going to be unusable anyway. Let's avoid any transient state where it could still be in the system but no longer function

Re: [PATCH v3 4/7] drm: exynos: dsi: Separate pre_enable, post_disable code

2021-12-13 Thread Andrzej Hajda
On 12.12.2021 19:14, Jagan Teki wrote: Existing driver is calling manual bridge pre_enable, enable, disable and post_disable helpers with their enable and disable functions. Separate the enable code with pre_enable and enable helpers like enable the DSI in pre_enable and set the display in ena

Re: [PATCH] drm/ast: potential dereference of null pointer

2021-12-13 Thread Thomas Zimmermann
Hi, thanks for the patch. Am 13.12.21 um 06:39 schrieb Jiasheng Jiang: he return value of kzalloc() needs to be checked. 'The' To avoid use of null pointer '&ast_state->base' in case of the failure of alloc. Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size") S

Re: [Intel-gfx] [PATCH 2/3] drm/dp: Move DP declarations into separate header file

2021-12-13 Thread Jani Nikula
On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split the DP declarations from other helpers before moving the > DP functions into a separate module. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 - > drivers/gpu/drm/drm_dp_aux_d

Re: [PATCH] drm/mediatek: hdmi: Perform NULL pointer check for mtk_hdmi_conf

2021-12-13 Thread AngeloGioacchino Del Regno
Il 28/10/21 09:43, AngeloGioacchino Del Regno ha scritto: In commit 41ca9caaae0b ("drm/mediatek: hdmi: Add check for CEA modes only") a check for CEA modes was added to function mtk_hdmi_bridge_mode_valid() in order to address possible issues on MT8167; moreover, with commit c91026a938c2 ("drm/me

Re: [PATCH] drm: simpledrm: fix wrong unit with pixel clock

2021-12-13 Thread Thomas Zimmermann
Hi Am 12.12.21 um 17:06 schrieb Alejandro Concepcion-Rodriguez: Pixel clock has to be set in kHz. Fixes: 11e8f5fd223b ("drm: Add simpledrm driver") Signed-off-by: Alejandro Concepcion-Rodriguez Applied to drm-misc-fixes. Thanks. Best regards Thomas --- drivers/gpu/drm/tiny/simpledrm.c

Re: [PATCH 1/2] drm/imx/dcss: add missing drm_bridge.h include

2021-12-13 Thread Laurentiu Palcu
Hi Lucas, On Sat, Dec 11, 2021 at 11:18:47PM +0100, Lucas Stach wrote: > This has been pulled in via some other include before, which is no > longer true. > > Signed-off-by: Lucas Stach > --- Reviewed-by: Laurentiu Palcu > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 + > 1 file changed, 1 inserti

Re: [PATCH 2/2] drm/imx/dcss: select DRM_KMS_HELPER

2021-12-13 Thread Laurentiu Palcu
Hi Lucas, On Sat, Dec 11, 2021 at 11:18:48PM +0100, Lucas Stach wrote: > DCSS can not be built without the DRM_KMS_HELPERs being available. > Select this symbol to disallow this invalid configuration. > > Signed-off-by: Lucas Stach Reviewed-by: Laurentiu Palcu Can you also push these 2 patches

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Hector Martin
On 13/12/2021 17.44, Javier Martinez Canillas wrote: Hello Hector, On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: This code is required for both simplefb and simpledrm, so let's move it into the OF core instead of having it as an ad-hoc initcall in the drivers. Acked-by: Thomas Zimmerm

Re: [PATCH 07/18] dt-bindings: display: rockchip: dw-hdmi: Allow "ref" as clock name

2021-12-13 Thread Sascha Hauer
On Sun, Dec 12, 2021 at 11:09:24PM +0100, Heiko Stuebner wrote: > Am Mittwoch, 8. Dezember 2021, 16:12:19 CET schrieb Sascha Hauer: > > "vpll" is a misnomer. A clock input to a device should be named after > > the usage in the device, not after the clock that drives it. On the > > rk3568 the same c

Re: [RFC PATCH v4 0/2] RDMA/rxe: Add dma-buf support

2021-12-13 Thread Shunsuke Mie
2021年12月10日(金) 22:29 Christian König : > > Am 10.12.21 um 14:26 schrieb Jason Gunthorpe: > > On Fri, Dec 10, 2021 at 01:47:37PM +0100, Christian König wrote: > >> Am 10.12.21 um 13:42 schrieb Jason Gunthorpe: > >>> On Fri, Dec 10, 2021 at 08:29:24PM +0900, Shunsuke Mie wrote: > Hi Jason, > >>>

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 Renaud R. (kernel...@iopsthecloud.com) changed: What|Removed |Added CC||kernel...@iopsthe

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 --- Comment #19 from Renaud R. (kernel...@iopsthecloud.com) --- (In reply to Renaud R. from comment #18) > My setup: > * Latitude E5570 via dock DisplayPort > * Kernel: https://bugzilla.kernel.org Kernel: 5.15.7-051507-generic #202112080459 SMP

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Javier Martinez Canillas
On Mon, Dec 13, 2021 at 11:46 AM Hector Martin wrote: > > On 13/12/2021 17.44, Javier Martinez Canillas wrote: > > Hello Hector, > > > > On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: > >> > >> This code is required for both simplefb and simpledrm, so let's move it > >> into the OF core ins

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Hector Martin
On 13/12/2021 20.30, Javier Martinez Canillas wrote: On Mon, Dec 13, 2021 at 11:46 AM Hector Martin wrote: On 13/12/2021 17.44, Javier Martinez Canillas wrote: Hello Hector, On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: This code is required for both simplefb and simpledrm, so let'

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Marek Szyprowski
Dear Jagan, On 12.12.2021 19:14, Jagan Teki wrote: > Updated series about drm bridge conversion of exynos dsi. > > Patch 1: panel checker > > Patch 2: panel_bridge API > > Patch 3: Bridge conversion > > Patch 4: pree_enable, post_disable > > Patch 5: Atomic functions > > Patch 6: atomic_set > > Pa

Re: RPI 7" display touch controller

2021-12-13 Thread Dave Stevenson
On Fri, 10 Dec 2021 at 22:40, Tim Harvey wrote: > > On Fri, Dec 10, 2021 at 11:29 AM Tim Harvey wrote: > > > > On Fri, Dec 10, 2021 at 10:41 AM Dave Stevenson > > wrote: > > > > > > On Fri, 10 Dec 2021 at 18:20, Tim Harvey wrote: > > > > > > > > On Thu, Nov 18, 2021 at 12:52 PM Tim Harvey > >

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Jagan Teki
Hi Marek, On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski wrote: > > Dear Jagan, > > On 12.12.2021 19:14, Jagan Teki wrote: > > Updated series about drm bridge conversion of exynos dsi. > > > > Patch 1: panel checker > > > > Patch 2: panel_bridge API > > > > Patch 3: Bridge conversion > > > > Pa

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Marek Szyprowski
Hi Jagan, On 13.12.2021 13:08, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski > wrote: >> On 12.12.2021 19:14, Jagan Teki wrote: >>> Updated series about drm bridge conversion of exynos dsi. >>> >>> Patch 1: panel checker >>> >>> Patch 2: panel_bridge API >>> >>> Patch 3: Br

Re: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Ville Syrjälä
On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: > According to CEA-861-F chapter 7.5.4. It says "The VSDB shall contain the > 3 bytes of the IEEE OUI as well as any additional payload bytes needed." > Now DRM driver check HDMI OUI but VSDB payload size at least five bytes. > That may c

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Jagan Teki
Hi Marek, On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski wrote: > > Hi Jagan, > > On 13.12.2021 13:08, Jagan Teki wrote: > > On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski > > wrote: > >> On 12.12.2021 19:14, Jagan Teki wrote: > >>> Updated series about drm bridge conversion of exynos dsi. >

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

2021-12-13 Thread Ville Syrjälä
On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > From: Ira Weiny > > kmap() is being deprecated and these usages are all local to the thread > so there is no reason kmap_local_page() can't be used. > > Replace kmap() calls with kmap_local_page(). > > Signed-off-by: Ira Wei

RE: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Lee, Shawn C
On Monday, December 13, 2021 8:31 PM, Ville Syrjälä wrote: >On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: >> According to CEA-861-F chapter 7.5.4. It says "The VSDB shall contain >> the >> 3 bytes of the IEEE OUI as well as any additional payload bytes needed." >> Now DRM driver c

Re: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Ville Syrjälä
On Mon, Dec 13, 2021 at 12:42:22PM +, Lee, Shawn C wrote: > > On Monday, December 13, 2021 8:31 PM, Ville Syrjälä wrote: > >On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: > >> According to CEA-861-F chapter 7.5.4. It says "The VSDB shall contain > >> the > >> 3 bytes of the IEEE

[PATCH] drm/i915/debugfs: add noreclaim annotations

2021-12-13 Thread Matthew Auld
We have a debugfs hook to directly call into i915_gem_shrink() with the fs_reclaim acquire annotations to simulate hitting direct reclaim. However we should also annotate this with memalloc_noreclaim, which will set PF_MEMALLOC for us on the current context, to ensure we can't re-enter direct recla

Re: [PATCH] drm/i915/debugfs: add noreclaim annotations

2021-12-13 Thread Thomas Hellström
On 12/13/21 13:55, Matthew Auld wrote: We have a debugfs hook to directly call into i915_gem_shrink() with the fs_reclaim acquire annotations to simulate hitting direct reclaim. However we should also annotate this with memalloc_noreclaim, which will set PF_MEMALLOC for us on the current contex

Re: [PATCH] drm/i915/ttm: fix large buffer population trucation

2021-12-13 Thread Matthew Auld
On 10/12/2021 19:50, Robert Beckett wrote: ttm->num_pages is uint32_t which was causing very large buffers to only populate a truncated size. This fixes gem_create@create-clear igt test on large memory systems. Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") Signed-off-by: Robert Bec

Re: [PATCH] drm/mediatek: hdmi: Perform NULL pointer check for mtk_hdmi_conf

2021-12-13 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2021年12月13日 週一 下午6:02寫道: > > Il 28/10/21 09:43, AngeloGioacchino Del Regno ha scritto: > > In commit 41ca9caaae0b ("drm/mediatek: hdmi: Add check for CEA modes only") > > a check for CEA modes was added to function mtk_hdmi_bridge_mode_valid() > > in orde

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Marek Szyprowski
Hi Jagan, On 13.12.2021 13:31, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski > wrote: >> On 13.12.2021 13:08, Jagan Teki wrote: >>> On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski >>> wrote: On 12.12.2021 19:14, Jagan Teki wrote: > Updated series about drm bridge

Re: [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

2021-12-13 Thread Jani Nikula
On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and help

[PATCH v5 0/4] ti-sn65dsi83 patches

2021-12-13 Thread Alexander Stein
Changes in V5 of this set: * Rebased to next-20211208 * Fix format string in error message * Remove superfluous error value for dev_err_probe() * Added Reviewed-by: Jagan Teki for patch 3 & 4 Changes in V4 of this set: * Rebased to next-2028 (due to merge-conflict in linux-next) * Added Rob He

[PATCH v5 1/4] dt-bindings: display: bridge: sn65dsi83: Make enable GPIO optional

2021-12-13 Thread Alexander Stein
From: Laurent Pinchart The SN65DSI8x EN signal may be tied to VCC, or otherwise controlled by means not available to the kernel. Make the GPIO optional. Signed-off-by: Laurent Pinchart Acked-by: Rob Herring Signed-off-by: Alexander Stein --- .../devicetree/bindings/display/bridge/ti,sn65dsi8

[PATCH v5 2/4] drm/bridge: ti-sn65dsi83: Make enable GPIO optional

2021-12-13 Thread Alexander Stein
The enable signal may not be controllable by the kernel. Make it optional. This is a similar to commit bbda1704fc15 ("drm/bridge: ti-sn65dsi86: Make enable GPIO optional") Reviewed-by: Laurent Pinchart Reviewed-by: Sam Ravnborg Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/ti-sn65d

[PATCH v5 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-12-13 Thread Alexander Stein
Add a VCC regulator which needs to be enabled before the EN pin is released. Reviewed-by: Sam Ravnborg Acked-by: Rob Herring Reviewed-by: Jagan Teki Signed-off-by: Alexander Stein --- .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 1 file changed, 4 insertions(+) diff

[PATCH v5 4/4] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support

2021-12-13 Thread Alexander Stein
VCC needs to be enabled before releasing the enable GPIO. Reviewed-by: Laurent Pinchart Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridg

Re: [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

2021-12-13 Thread Thomas Zimmermann
Hi Am 13.12.21 um 14:34 schrieb Jani Nikula: On Mon, 13 Dec 2021, Thomas Zimmermann wrote: Split-off DisplayPort functions from KMS helper library and move them into their own module. Reduces the size of drm_kms_helper.ko by ~50%. This patchset is part of an on-going effort to reduce the mini

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Jagan Teki
Hi Marek, On Mon, Dec 13, 2021 at 6:51 PM Marek Szyprowski wrote: > > Hi Jagan, > > On 13.12.2021 13:31, Jagan Teki wrote: > > On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski > > wrote: > >> On 13.12.2021 13:08, Jagan Teki wrote: > >>> On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski > >>> wro

RE: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Lee, Shawn C
On Monday, December 13, 2021 at 12:45 p.m, Ville Syrjälä wrote: >On Mon, Dec 13, 2021 at 12:42:22PM +, Lee, Shawn C wrote: >> >> On Monday, December 13, 2021 8:31 PM, Ville Syrjälä wrote: >> >On Sun, Dec 12, 2021 at 11:33:31PM +0800, Lee Shawn C wrote: >> >> According to CEA-861-F chapter 7.

Re: [PATCH v3 0/7] drm: exynos: dsi: Convert drm bridge

2021-12-13 Thread Marek Szyprowski
Hi Jagan, On 13.12.2021 14:56, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 6:51 PM Marek Szyprowski > wrote: >> On 13.12.2021 13:31, Jagan Teki wrote: >>> On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski >>> wrote: On 13.12.2021 13:08, Jagan Teki wrote: > On Mon, Dec 13, 2021 at 5:34 PM

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

2021-12-13 Thread Rodrigo Siqueira Jordao
On 2021-12-13 4:46 a.m., Michel Dänzer wrote: On 2021-12-11 13:20, Rodrigo Siqueira Jordao wrote: On 2021-12-09 11:46 a.m., Michel Dänzer wrote: From: Michel Dänzer Move code using the Pipe struct to a new helper function. Works around[0] this warning (resulting in failure to build a RH

Re: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Ville Syrjälä
On Mon, Dec 13, 2021 at 02:09:33PM +, Lee, Shawn C wrote: > > On Monday, December 13, 2021 at 12:45 p.m, Ville Syrjälä wrote: > >On Mon, Dec 13, 2021 at 12:42:22PM +, Lee, Shawn C wrote: > >> > >> On Monday, December 13, 2021 8:31 PM, Ville Syrjälä wrote: > >> >On Sun, Dec 12, 2021 at 11:

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Rob Herring
On Mon, Dec 13, 2021 at 5:30 AM Javier Martinez Canillas wrote: > > On Mon, Dec 13, 2021 at 11:46 AM Hector Martin wrote: > > > > On 13/12/2021 17.44, Javier Martinez Canillas wrote: > > > Hello Hector, > > > > > > On Sun, Dec 12, 2021 at 7:24 AM Hector Martin wrote: > > >> > > >> This code is r

Re: [PATCH v3 1/3] of: Move simple-framebuffer device handling from simplefb to of

2021-12-13 Thread Rob Herring
On Mon, Dec 13, 2021 at 2:16 AM Thomas Zimmermann wrote: > > Hi > > Am 12.12.21 um 22:29 schrieb Rob Herring: > > On Sun, Dec 12, 2021 at 12:24 AM Hector Martin wrote: > >> > >> This code is required for both simplefb and simpledrm, so let's move it > >> into the OF core instead of having it as a

RE: [PATCH] drm/edid: Refine HDMI VSDB detect

2021-12-13 Thread Lee, Shawn C
On Monday, December 13, 2021 at 02:36 p.m, Ville Syrjälä wrote: >On Mon, Dec 13, 2021 at 02:09:33PM +, Lee, Shawn C wrote: >> >> On Monday, December 13, 2021 at 12:45 p.m, Ville Syrjälä wrote: >> >On Mon, Dec 13, 2021 at 12:42:22PM +, Lee, Shawn C wrote: >> >> >> >> On Monday, December 13

Re: [PATCH v3 5/8] drm/i915/gtt: allow overriding the pt alignment

2021-12-13 Thread Ramalingam C
On 2021-12-06 at 13:31:37 +, Matthew Auld wrote: > On some platforms we have alignment restrictions when accessing LMEM > from the GTT. In the next patch few patches we need to be able to modify probably extra "patch" Apart from that looks good to me Reviewed-by : Ramalingam C > the page-ta

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

2021-12-13 Thread Ira Weiny
On Mon, Dec 13, 2021 at 02:39:59PM +0200, Ville Syrjälä wrote: > On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > kmap() is being deprecated and these usages are all local to the thread > > so there is no reason kmap_local_page() can't be used. > >

Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

2021-12-13 Thread Ira Weiny
On Mon, Dec 13, 2021 at 01:04:07AM -0800, Christoph Hellwig wrote: > On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > > - vaddr = kmap(page); > > + vaddr = kmap_local_page(page); > > memcpy(vaddr, data, len); > > - kunmap(page); > > +

[PATCH v2] drm/mediatek: Set the default value of rotation to DRM_MODE_ROTATE_0

2021-12-13 Thread Mark Yacoub
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1. Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic} Signed-of

  1   2   >