Re: [PATCH v4 07/16] drm/i915/dg2: Tile 4 plane format support

2021-12-10 Thread Ramalingam C
On 2021-12-10 at 09:33:07 +0200, Lisovskiy, Stanislav wrote: > On Thu, Dec 09, 2021 at 09:15:24PM +0530, Ramalingam C wrote: > > From: Stanislav Lisovskiy > > > > Tile4 in bspec format is 4K tile organized into > > 64B subtiles with same basic shape as for legacy TileY > > which will be supported

Re: [PATCH 2/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 62 +- > drivers/gpu/drm/i915/gvt/g

Re: [PATCH 3/9] drm/i915/gvt: Constify intel_gvt_irq_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/interrupt.c | 10 +- > drivers/gpu/drm/i915/gvt/interrupt.h | 2 +-

Re: [PATCH 4/9] drm/i915/gvt: Constify intel_gvt_sched_policy_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/sched_policy.c | 2 +- > drivers/gpu/drm/i915/gvt/scheduler.h| 2 +- >

Re: [PATCH 5/9] drm/i915/gvt: Constify gvt_mmio_block

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put it in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gvt.h | 2 +- > drivers/gpu/drm/i915/gvt/handlers.c | 12 ++-- >

Re: [PATCH 6/9] drm/i915/gvt: Constify cmd_interrupt_events

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 7/9] drm/i915/gvt: Constify formats

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. WHile at it, make the description const > char* since it is never modified. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/

Re: [PATCH 8/9] drm/i915/gvt: Constify gtt_type_table_entry

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

Re: [PATCH 9/9] drm/i915/gvt: Constify vgpu_types

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. While at it, make name a const char*. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/vgpu.c | 4 ++-- > 1 file changed, 2 insertio

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Thomas Zimmermann
Hi Am 09.12.21 um 19:17 schrieb Guilherme G. Piccoli: Thanks again Alex! Some comments inlined below: On 09/12/2021 15:06, Alex Deucher wrote: Not really in a generic way. It's asic and platform specific. In addition most modern displays require link training to bring up the display, so you

[PATCH] drm/i915/selftests: Fix inconsistent object in IS_ERR and PTR_ERR

2021-12-10 Thread Miaoqian Lin
Fix inconsistent object in IS_ERR and PTR_ERR in igt_dmabuf_import_same_driver and igt_dmabuf_import_same_driver_lmem. As obj is the return value of __i915_gem_object_create_user, the proper object to be passed as argument to PTR_ERR is obj. Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/i915/g

[PATCH] drm: i915: display: intel_dmc: Fixes an unsigned subtraction which can never be negative.

2021-12-10 Thread Harshit Mogalapalli
smatch warning: drivers/gpu/drm/i915/display/intel_dmc.c:601 parse_dmc_fw() warn: unsigned 'fw->size - offset' is never less than zero Firmware size is size_t and offset is u32. So the subtraction is unsigned which can never be less than zero. Fixes: 3d5928a168a9 ("drm/i915/xelpd: Pipe A DMC plug

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use correct context lock when callig clr_context_registered

2021-12-10 Thread Tvrtko Ursulin
On 09/12/2021 19:14, Daniele Ceraolo Spurio wrote: On 12/9/2021 10:48 AM, Matthew Brost wrote: s/ce/cn/ when grabbing guc_state.lock before calling clr_context_registered. Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking") Signed-off-by: Matthew Brost Cc: I think Cc: sta

Re: [PATCH 18/18] [HACK, RFC] clk: rk3568: do not divide dclk_vop0

2021-12-10 Thread Sascha Hauer
On Wed, Dec 08, 2021 at 05:51:43PM +0100, Heiko Stübner wrote: > Hi Sascha, > > Am Mittwoch, 8. Dezember 2021, 16:12:30 CET schrieb Sascha Hauer: > > On the rk3568 we have this (simplified) situation: > > > > .. .-..-. > > -| hpll |--.--| /n ||dclk_vop0|- > >

Re: [PATCH 17/18] drm: rockchip: Add VOP2 driver

2021-12-10 Thread Sascha Hauer
Hi Johan, On Wed, Dec 08, 2021 at 05:59:16PM +0100, Johan Jonker wrote: > Hi, > > On 12/8/21 4:12 PM, Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This

Re: [PATCH 0/2] Add SMBus features to Tegra I2C

2021-12-10 Thread Thierry Reding
On Thu, Dec 09, 2021 at 07:04:30PM +0300, Dmitry Osipenko wrote: > 09.12.2021 18:05, Akhil R пишет: > > Add support for SMBus Alert and SMBus block read functions to > > i2c-tegra driver > > > > Akhil R (2): > > dt-bindings: i2c: tegra: Add SMBus feature properties > > i2c: tegra: Add SMBus bl

Re: [PATCH 1/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 4 ++-- > drivers/gpu/drm/i915/gvt/gtt.h | 2 +- > 2 files changed

Re: [PATCH 0/9] drm/i915/gvt: Constify static structs

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > Constify a number of static structs that are never modified to allow the > compiler to put them in read-only memory. In order to do this, constify a > number of local variables and pointers in structs. > > This is most important for structs that cont

Re: [PATCH] drm/panel: ilitek-ili9881c: Avoid unbalance prepare/unprepare

2021-12-10 Thread Michael Nazzareno Trimarchi
Hi Dave some questions below On Thu, Dec 9, 2021 at 7:10 PM Michael Nazzareno Trimarchi wrote: > > Hi Dave > > On Thu, Dec 9, 2021 at 6:58 PM Dave Stevenson > wrote: > > > > Hi Michael > > > > On Thu, 9 Dec 2021 at 16:58, Michael Nazzareno Trimarchi > > wrote: > > > > > > Hi all > > > > > > On

Re: [Nouveau] [PATCH] drm/nouveau: wait for the exclusive fence after the shared ones v2

2021-12-10 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker speaking. On 09.12.21 11:23, Christian König wrote: > Always waiting for the exclusive fence resulted on some performance > regressions. So try to wait for the shared fences first, then the > exclusive fence should always be signaled already. > > v

Re: [PATCH v2 3/3] drm/vc4: Notify the firmware when DRM is in charge

2021-12-10 Thread nicolas saenz julienne
Hi Maxime, On Fri, 2021-12-03 at 14:51 +0100, Maxime Ripard wrote: > Once the call to drm_fb_helper_remove_conflicting_framebuffers() has > been made, simplefb has been unregistered and the KMS driver is entirely > in charge of the display. > > Thus, we can notify the firmware it can free whateve

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-10 Thread Jani Nikula
On Thu, 09 Dec 2021, Kees Cook wrote: > On Thu, Dec 09, 2021 at 05:20:45PM -0500, Harry Wentland wrote: >> >> >> On 2021-12-09 01:23, Kees Cook wrote: >> > On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote: >> >> On Fri, 03 Dec 2021, Kees Cook wrote: >> >>> The link_status array was n

Re: [PATCH 1/2] drm/i915: Introduce new Tile 4 format

2021-12-10 Thread Imre Deak
On Thu, Dec 09, 2021 at 05:14:56PM +0200, Chery, Nanley G wrote: > > > > -Original Message- > > From: Lisovskiy, Stanislav > > Sent: Thursday, December 9, 2021 5:47 AM > > To: intel-...@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org; Lisovskiy, Stanislav > > ; Saarinen, Ja

Re: [PATCH 02/10] drm: Add privacy-screen class (v4)

2021-12-10 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker speaking. Top-posting for once, to make this easy accessible to everyone. Hans, I stumbled upon your blog post about something that afaics is related to below patch: https://hansdegoede.livejournal.com/25948.html To quote: > To avoid any regressi

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-12-10 Thread AngeloGioacchino Del Regno
Il 10/11/21 14:06, Guillaume Ranquet ha scritto: From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC and a according phy driver mediatek-dp-phy. It supports both functional units on the mt8195, the embedded DisplayPort as well as the external Displa

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use correct context lock when callig clr_context_registered

2021-12-10 Thread Jani Nikula
On Fri, 10 Dec 2021, Tvrtko Ursulin wrote: > On 09/12/2021 19:14, Daniele Ceraolo Spurio wrote: >> >> >> On 12/9/2021 10:48 AM, Matthew Brost wrote: >>> s/ce/cn/ when grabbing guc_state.lock before calling >>> clr_context_registered. >>> >>> Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simpli

Re: [Intel-gfx] [PATCH v4 11/16] drm/i915/dg2: Add DG2 unified compression

2021-12-10 Thread Imre Deak
On Thu, Dec 09, 2021 at 09:15:28PM +0530, Ramalingam C wrote: > From: Matt Roper > > DG2 unifies render compression and media compression into a single > format for the first time. The programming and buffer layout is > supposed to match compression on older gen12 platforms, but the actual > com

Re: [PATCH 02/10] drm: Add privacy-screen class (v4)

2021-12-10 Thread Hans de Goede
Hi Thorsten, On 12/10/21 11:12, Thorsten Leemhuis wrote: > Hi, this is your Linux kernel regression tracker speaking. > > Top-posting for once, to make this easy accessible to everyone. > > Hans, I stumbled upon your blog post about something that afaics is > related to below patch: > https://ha

[PATCH] drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This effectively removes writeback which was added in 2d6692e642e7 ("drm/i915: Start writeback from the shrinker"). Digging through the history it seems we went back and forth on the topic of whether it would be safe a couple of times. See for instance 5537252b6b6d ("drm/i91

[PATCH v6 0/6] drm: sun4i: dsi: Bridge support

2021-12-10 Thread Jagan Teki
This series add bridge support for Allwinner DSI controller. In addition to previous version, this series add bridge support only not doing any bridge conversion at the moment. Previous version changes [1]. Patch 1: Drop the DRM bind race while attaching bridges Patch 2: Move component_add into

[PATCH v6 1/6] drm: sun4i: dsi: Drop DRM bind race with bridge attach

2021-12-10 Thread Jagan Teki
Existing host driver will keep looking for DRM pointer in sun6i_dsi_attach and defers even if the particular DSI device is found for the first time. Meanwhile it triggers the bind callback and gets the DRM pointer and then continues the sun6i_dsi_attach. This makes a deadlock situation if sun6i_ds

[PATCH v6 2/6] drm: sun4i: dsi: Add component only once DSI device attached

2021-12-10 Thread Jagan Teki
Having component_add for running all drm bind callbacks returns error or unbound due to chain of DSI devices connected across bridge topology on a display pipeline. In a typical bridge oriented display pipeline where the host is connected to the bridge converter and that indeed connected to a pane

[PATCH v6 3/6] drm: sun4i: dsi: Add bridge support

2021-12-10 Thread Jagan Teki
Some display panels would come up with a non-DSI output, those can have an option to connect the DSI host by means of interface bridge converter. This DSI to non-DSI interface bridge converter would require DSI Host to handle drm bridge functionalities in order to communicate interface bridge. Th

[DO NOT MERGE] [PATCH v6 4/6] ARM: dts: sun8i: bananapi-m2m: Enable iS070WV20-CT16 DSI Panel

2021-12-10 Thread Jagan Teki
Bananapi S070WV20-CT16 is a pure RGB output panel with ICN6211 DSI/RGB convertor bridge. Enable support for it. Signed-off-by: Jagan Teki --- .../boot/dts/sun8i-r16-bananapi-m2m-panel.dts | 41 +++ 1 file changed, 41 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-r16-banana

[DO NOT MERGE] [PATCH v6 5/6] ARM: dts: sun8i: bananapi-m2m: Enable ICN6211 DSI Bridge

2021-12-10 Thread Jagan Teki
Bananapi S070WV20-CT16 is a pure RGB output panel with ICN6211 DSI/RGB convertor bridge. Enable bridge along with associated panel. Signed-off-by: Jagan Teki --- arch/arm/boot/dts/sun8i-r16-bananapi-m2m.dts | 64 1 file changed, 64 insertions(+) diff --git a/arch/arm/boot/

[DO NOT MERGE] [PATCH v6 6/6] ARM: dts: sun8i: bananapi-m2m: Enable DLPC3433 Bridge (I2C)

2021-12-10 Thread Jagan Teki
R16 board has DLCP3433 DSI bridge for connecting TI DMD Projectors. Enable support for it. Note: This is for testing purpose, DLPC3433 not available in BPI-M2M. Signed-off-by: Jagan Teki --- .../boot/dts/sun8i-r16-bananapi-m2m-i2c.dts | 69 +++ 1 file changed, 69 insertions(+

Re: [PATCH 02/10] drm: Add privacy-screen class (v4)

2021-12-10 Thread Thorsten Leemhuis
On 10.12.21 11:46, Hans de Goede wrote: > On 12/10/21 11:12, Thorsten Leemhuis wrote: >> Hi, this is your Linux kernel regression tracker speaking. >> >> Top-posting for once, to make this easy accessible to everyone. >> >> Hans, I stumbled upon your blog post about something that afaics is >> rela

Re: [RFC PATCH v4 0/2] RDMA/rxe: Add dma-buf support

2021-12-10 Thread Shunsuke Mie
Hi Jason, Thank you for replying. 2021年12月8日(水) 2:14 Jason Gunthorpe : > > On Fri, Dec 03, 2021 at 12:51:44PM +0900, Shunsuke Mie wrote: > > Hi maintainers, > > > > Could you please review this patch series? > > Why is it RFC? > > I'm confused why this is useful? > > This can't do copy from MMIO m

[PATCH] video: ocfb: add const to of_device_id 

2021-12-10 Thread Chunyang Zhong
struct of_device_id should normally be const. Signed-off-by: Chunyang Zhong --- drivers/video/fbdev/ocfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c index bfa4ed421148..da7e1457e58f 100644 --- a/drivers/video/fbdev

[PATCH] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2021-12-10 Thread AngeloGioacchino Del Regno
DRM bridge drivers are now attaching their DSI device at probe time, which requires us to register our DSI host in order to let the bridge to probe: this recently started producing an endless -EPROBE_DEFER loop on some machines that are using external bridges, like the parade-ps8640, found on the A

Re: [PATCH v8 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2021-12-10 Thread Maarten Lankhorst
On 07-12-2021 15:27, Kevin Tang wrote: > Adds dsi host controller support for the Unisoc's display subsystem. > Adds dsi phy support for the Unisoc's display subsystem. > Only MIPI DSI Displays supported, DP/TV/HMDI will be support > in the feature. > > v1: > - Remove dphy and dsi graph binding,

Re: [RFC PATCH v4 0/2] RDMA/rxe: Add dma-buf support

2021-12-10 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 08:29:24PM +0900, Shunsuke Mie wrote: > Hi Jason, > Thank you for replying. > > 2021年12月8日(水) 2:14 Jason Gunthorpe : > > > > On Fri, Dec 03, 2021 at 12:51:44PM +0900, Shunsuke Mie wrote: > > > Hi maintainers, > > > > > > Could you please review this patch series? > > > > Wh

Re: [RFC PATCH v4 0/2] RDMA/rxe: Add dma-buf support

2021-12-10 Thread Christian König
Am 10.12.21 um 13:42 schrieb Jason Gunthorpe: On Fri, Dec 10, 2021 at 08:29:24PM +0900, Shunsuke Mie wrote: Hi Jason, Thank you for replying. 2021年12月8日(水) 2:14 Jason Gunthorpe : On Fri, Dec 03, 2021 at 12:51:44PM +0900, Shunsuke Mie wrote: Hi maintainers, Could you please review this patch

Re: [RFC PATCH v4 0/2] RDMA/rxe: Add dma-buf support

2021-12-10 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 01:47:37PM +0100, Christian König wrote: > Am 10.12.21 um 13:42 schrieb Jason Gunthorpe: > > On Fri, Dec 10, 2021 at 08:29:24PM +0900, Shunsuke Mie wrote: > > > Hi Jason, > > > Thank you for replying. > > > > > > 2021年12月8日(水) 2:14 Jason Gunthorpe : > > > > On Fri, Dec 03,

Re: [RFC PATCH v4 0/2] RDMA/rxe: Add dma-buf support

2021-12-10 Thread Christian König
Am 10.12.21 um 14:26 schrieb Jason Gunthorpe: On Fri, Dec 10, 2021 at 01:47:37PM +0100, Christian König wrote: Am 10.12.21 um 13:42 schrieb Jason Gunthorpe: On Fri, Dec 10, 2021 at 08:29:24PM +0900, Shunsuke Mie wrote: Hi Jason, Thank you for replying. 2021年12月8日(水) 2:14 Jason Gunthorpe : On

Re: Habanalabs, Ask for the linux firmware code which loads by coprocesseor

2021-12-10 Thread Cai Huoqing
On 09 12月 21 14:23:45, Oded Gabbay wrote: > On Tue, Dec 7, 2021 at 9:19 AM Cai Huoqing wrote: > > > > Hi Oded Gabbay and habanalabs folks. > > > > I'm insterested in this kind of AI acceralator. > > > > After scanning the driver code. > > It seems that there are a linux firmware which is loaded by

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Guilherme G. Piccoli
Thanks a lot Alex / Gerd and Thomas, very informative stuff! I'm glad there are projects to collect/save the data and reuse after a kdump, this is very useful. I'll continue my study on the atombios thing of AMD and QXL, maybe at least we can make it work in qemu, that'd be great (like a small ini

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Alex Deucher
On Fri, Dec 10, 2021 at 9:09 AM Guilherme G. Piccoli wrote: > > Thanks a lot Alex / Gerd and Thomas, very informative stuff! I'm glad > there are projects to collect/save the data and reuse after a kdump, > this is very useful. > > I'll continue my study on the atombios thing of AMD and QXL, maybe

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Guilherme G. Piccoli
On 10/12/2021 11:16, Alex Deucher wrote:> [...] > Why not just reload the driver after kexec? > > Alex Because the original issue is the kdump case, and we want a very very tiny kernel - also, the crash originally could have been caused by amdgpu itself, so if it's a GPU issue, we don't want to m

RE: [PATCH v3 1/3] dt-bindings: gpu: mali-bifrost: Document RZ/G2L support

2021-12-10 Thread Biju Das
Hi All, Gentle ping. Cheers, Biju > Subject: [PATCH v3 1/3] dt-bindings: gpu: mali-bifrost: Document RZ/G2L > support > > The Renesas RZ/G2{L, LC} SoC (a.k.a R9A07G044) has a Bifrost Mali-G31 GPU, > add a compatible string for it. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar > --

Re: [PATCH] drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Thomas Hellström
On Fri, 2021-12-10 at 11:05 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This effectively removes writeback which was added in 2d6692e642e7 > ("drm/i915: Start writeback from the shrinker"). > > Digging through the history it seems we went back and forth on the > topic > of whether it

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Christian König
Am 10.12.21 um 15:25 schrieb Guilherme G. Piccoli: On 10/12/2021 11:16, Alex Deucher wrote:> [...] Why not just reload the driver after kexec? Alex Because the original issue is the kdump case, and we want a very very tiny kernel - also, the crash originally could have been caused by amdgpu

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Guilherme G. Piccoli
On 10/12/2021 12:13, Christian König wrote: > [...] > How about issuing a PCIe reset and re-initializing the ASIC with just > the VBIOS? > > That should be pretty straightforward I think. > > Christian. Thanks Christian, that'd be perfect! Is it feasible? Per Alex comment, we'd need to run ato

Re: [PATCH v7 08/11] drm/i915/pxp: Use to_gt() helper

2021-12-10 Thread Matt Roper
On Fri, Dec 10, 2021 at 03:07:56AM +0200, Andi Shyti wrote: > Use to_gt() helper consistently throughout the codebase. > Pure mechanical s/i915->gt/to_gt(i915). No functional changes. > > Signed-off-by: Andi Shyti Reviewed-by: Matt Roper > --- > Hi, > > the inline of i915_dev_to_pxp() was acc

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Christian König
Am 10.12.21 um 16:24 schrieb Guilherme G. Piccoli: On 10/12/2021 12:13, Christian König wrote: [...] How about issuing a PCIe reset and re-initializing the ASIC with just the VBIOS? That should be pretty straightforward I think. Christian. Thanks Christian, that'd be perfect! Is it feasible?

Re: [PATCH] drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Tvrtko Ursulin
On 10/12/2021 14:46, Thomas Hellström wrote: On Fri, 2021-12-10 at 11:05 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This effectively removes writeback which was added in 2d6692e642e7 ("drm/i915: Start writeback from the shrinker"). Digging through the history it seems we went back an

Re: [PATCH] drm/panel: ilitek-ili9881c: Avoid unbalance prepare/unprepare

2021-12-10 Thread Dave Stevenson
Hi Michael On Fri, 10 Dec 2021 at 09:05, Michael Nazzareno Trimarchi wrote: > > Hi Dave > > some questions below > > On Thu, Dec 9, 2021 at 7:10 PM Michael Nazzareno Trimarchi > wrote: > > > > Hi Dave > > > > On Thu, Dec 9, 2021 at 6:58 PM Dave Stevenson > > wrote: > > > > > > Hi Michael > > >

Re: [PATCH v7 1/3] drm/dsi: transer dsi hs packet aligned

2021-12-10 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This patch looks good to me, how do you think about it? Regards, Chun-Kuang. Jitao Shi 於 2021年11月4日 週四 上午11:36寫道: > > Hi sirs > > Pls help to review this change. > > Best Regards > Jitao. > > On Tue, 2021-10-05 at 07:53 +0800, Chun-Kuang Hu wrote: > > Hi, Jitao: > > > > Jitao

Re: [PATCH v2 03/11] mm/gup: migrate PIN_LONGTERM dev coherent pages to system

2021-12-10 Thread Felix Kuehling
On 2021-12-09 8:31 p.m., Alistair Popple wrote: On Friday, 10 December 2021 3:54:31 AM AEDT Sierra Guiza, Alejandro (Alex) wrote: On 12/9/2021 10:29 AM, Felix Kuehling wrote: Am 2021-12-09 um 5:53 a.m. schrieb Alistair Popple: On Thursday, 9 December 2021 5:55:26 AM AEDT Sierra Guiza, Alejand

[PATCH 1/2] drm/panel: panel-simple: add bus_format and connector_type to cdtech_s043wq26h_ct7 panel

2021-12-10 Thread Giulio Benetti
Add bus_format and connector_type to cdtech_s043wq26h_ct7 panel. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index eb475a3a774b..c8ad71386

[PATCH 2/2] drm/panel: panel-simple: add bus_format and connector_type to cdtech_s070wv95_ct16 panel

2021-12-10 Thread Giulio Benetti
Add bus_format and connector_type to cdtech_s070wv95_ct16 panel. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index c8ad713865cb..dc300ace4

Re: [PATCH v12, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-12-10 Thread Rob Herring
On Thu, Dec 02, 2021 at 11:45:40AM +0800, Yunfei Dong wrote: > Adds decoder dt-bindings for mt8192. > > Signed-off-by: Yunfei Dong > --- > .../media/mediatek,vcodec-subdev-decoder.yaml | 266 ++ > 1 file changed, 266 insertions(+) > create mode 100644 > Documentation/devicetree

Re: [PATCH v11 3/8] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-12-10 Thread Rob Herring
On Thu, Dec 02, 2021 at 07:39:48PM +0100, H. Nikolaus Schaller wrote: > From: Sam Ravnborg > > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. > Based on .txt binding from Zubair Lutfullah Kakakhel > > We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml > > Signed-off-by: S

Re: [PATCH] drm/dp: Actually read Adjust Request Post Cursor2 register

2021-12-10 Thread Kees Cook
On Fri, Dec 10, 2021 at 12:06:20PM +0200, Jani Nikula wrote: > On Thu, 09 Dec 2021, Kees Cook wrote: > > On Thu, Dec 09, 2021 at 05:20:45PM -0500, Harry Wentland wrote: > >> > >> > >> On 2021-12-09 01:23, Kees Cook wrote: > >> > On Wed, Dec 08, 2021 at 01:19:28PM +0200, Jani Nikula wrote: > >> >

Re: [PATCH] drm: i915: display: intel_dmc: Fixes an unsigned subtraction which can never be negative.

2021-12-10 Thread Lucas De Marchi
On Thu, Dec 09, 2021 at 08:41:24PM -0800, Harshit Mogalapalli wrote: smatch warning: drivers/gpu/drm/i915/display/intel_dmc.c:601 parse_dmc_fw() warn: unsigned 'fw->size - offset' is never less than zero Firmware size is size_t and offset is u32. So the subtraction is unsigned which can never be

[PATCH 00/17] MediaTek MT8192 APU

2021-12-10 Thread Flora Fu
The MediaTek AI Processing Unit (APU) is a proprietary hardware in the SoC to support AI functions. The patches support the MT8192 APU runs on internal microprocessor. Software packages contins mailbox, iommu, APU remote processor, power control, middleware and debug looger. This series is based o

[PATCH 01/17] dt-bindings: mailbox: mediatek: Add APU mailbox compatible

2021-12-10 Thread Flora Fu
Add the mailbox compatible for the MediaTek APU. The MT8192 and MT8195 SOC will use it. Signed-off-by: Pi-Cheng Chen Signed-off-by: Flora Fu --- .../mailbox/mediatek,apu-mailbox.yaml | 47 +++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetre

[PATCH 02/17] dt-bindings: memory: mediatek: Add MT8192 apu iommu bindings

2021-12-10 Thread Flora Fu
MT8192 has one APU iommu hardware and add apu iommu bindings. Signed-off-by: Flora Fu --- .../devicetree/bindings/iommu/mediatek,iommu.yaml | 7 +-- include/dt-bindings/memory/mt8192-larb-port.h | 4 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/D

[PATCH 04/17] dt-bindings: soc: mediatek: apu: Add APU power compatible

2021-12-10 Thread Flora Fu
Add new document for APU power compatible. Signed-off-by: Flora Fu --- .../soc/mediatek/mediatek,apu-pwr.yaml| 80 +++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,apu-pwr.yaml diff --git a/Documentation/

[PATCH 05/17] dt-bindings: soc: mediatek: apu: Add apu logger compatible

2021-12-10 Thread Flora Fu
Add new document for apu logger compatible. Signed-off-by: Flora Fu --- .../soc/mediatek/mediatek,apu-logger.yaml | 42 +++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,apu-logger.yaml diff --git a/Documentat

[PATCH 03/17] dt-bindings: remoteproc: mediatek: Add APU rproc compatible

2021-12-10 Thread Flora Fu
Add new binding document for the APU remote processor. The initial version is used for MT8192 SOC. Signed-off-by: Pi-Cheng Chen Signed-off-by: Flora Fu --- .../bindings/remoteproc/mediatek,apu-rv.yaml | 106 ++ 1 file changed, 106 insertions(+) create mode 100644 Documentati

[PATCH 06/17] mailbox: mediatek: add mtk-apu-mailbox driver

2021-12-10 Thread Flora Fu
Add mtk-apu-mailbox driver to support communication with APU remote microprocessor. Signed-off-by: Pi-Cheng Chen Signed-off-by: Flora Fu --- drivers/mailbox/Kconfig | 9 ++ drivers/mailbox/Makefile | 2 + drivers/mailbox/mtk-apu-mailbox.c | 162 ++

[PATCH 07/17] iommu/mediatek: Support APU iommu and config data for mt8192

2021-12-10 Thread Flora Fu
APU IOMMU is a new iommu HW. it uses a new pagetable. Add support for mt8192 apu iommu. Signed-off-by: Yong Wu Signed-off-by: Flora Fu --- drivers/iommu/mtk_iommu.c | 45 ++- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/mtk_iom

[PATCH 11/17] soc: mediatek: apu: Add middleware driver

2021-12-10 Thread Flora Fu
The APU middleware is responsible to receive all user's requests and control command and device related flow. In Kernel side, the middleware use the IPI to send command to remote tinysys to dispatch commands to AI engines in APU. Signed-off-by: JB Tsai Signed-off-by: Flora Fu --- drivers/soc/m

[PATCH 09/17] soc: mediatek: apu: Add Apu power driver

2021-12-10 Thread Flora Fu
Add APU power driver to support for subsys clock and regulator controller. Add MT8192 platform APU power driver's platform data. Signed-off-by: Flora Fu --- drivers/soc/mediatek/apusys/Kconfig | 23 + drivers/soc/mediatek/apusys/Makefile | 5 + drivers/soc/mediatek/apusys/apu-pwr-

[PATCH 15/17] arm64: dts: mt8192: Add APU power nodes

2021-12-10 Thread Flora Fu
Add APU power node for MT8192. Signed-off-by: Flora Fu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 61 1 file changed, 61 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index de73fbf0cb90..f95d381ff1cc

[PATCH 13/17] arm64: dts: mt8192: Add APU-IOMMU nodes

2021-12-10 Thread Flora Fu
Add APU-IOMMI nodes Signed-off-by: Yong Wu Signed-off-by: Flora Fu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 5c97dc7985b4..62acaba7b033 100

[PATCH 16/17] arm64: dts: mt8192: Add apu-sw-logger node

2021-12-10 Thread Flora Fu
Add apu-sw-logger node to enable debug into tinysys. Signed-off-by: Flora Fu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index f95d381ff1cc..c8cc58e74f

[PATCH 12/17] arm64: dts: mt8192: Add APU mtk-apu-mailbox node

2021-12-10 Thread Flora Fu
Add mtk-apu-mailbox for mt8192 SOC. Signed-off-by: Flora Fu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index cb2b171e0080..5c97dc7985b4 100644 --- a/

[PATCH 17/17] arm64: dts: mt8192: Set up regulators for APU subsys

2021-12-10 Thread Flora Fu
Set up APU regulators for mdla and vvpu. Signed-off-by: Flora Fu --- arch/arm64/boot/dts/mediatek/mt8192-evb.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192-evb.dts b/arch/arm64/boot/dts/mediatek/mt8192-evb.dts index 5d9e108e41f5..431008466d77 1

[PATCH 10/17] soc: mediatek: apu: Add APU software logger dirver

2021-12-10 Thread Flora Fu
The APU software logger is for debug for remote processor. The remote microprocessor's logs will be output to the mapped memory and application processor can read logs from the dedicated reserved registers Signed-off-by: Flora Fu --- drivers/soc/mediatek/apusys/Makefile| 2 + drivers/

[PATCH 14/17] arm64: dts: mt8192: Add apu tinysys node

2021-12-10 Thread Flora Fu
Add node for APU tinysys. Signed-off-by: Flora Fu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 35 1 file changed, 35 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 62acaba7b033..de73fbf0cb90 1006

[PATCH 08/17] remoteproc: mediatek: Add APU remoteproc driver

2021-12-10 Thread Flora Fu
APU integrated subsystem having MD32RV33 (MD32) that runs tinysys The tinysys is runs on a microprocessor in APU. Its firmware is loaded and booted from Kernel side. Kernel and tinysys use IPI to send and receive messages. Signed-off-by: Pi-Cheng Chen Signed-off-by: Flora Fu --- drivers/remote

[PATCH 1/3] drm: bridge: nwl-dsi: Drop panel_bridge from nwl_dsi

2021-12-10 Thread Jagan Teki
panel_bridge pointer never used anywhere except the one it looked up at nwl_dsi_bridge_attach. Drop it from the nwl_dsi structure. Cc: Guido Günther Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/nwl-dsi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 2/3] Revert "drm/bridge: dw-mipi-dsi: Find the possible DSI devices"

2021-12-10 Thread Jagan Teki
This reverts commit c206c7faeb3263a7cc7b4de443a3877cd7a5e74b. In order to avoid any probe ordering issues, the I2C based downstream bridge drivers now register and attach the DSI devices at the probe instead of doing it on drm_bridge_function.attach(). Examples of those commits are: commit <6ef7

[PATCH 3/3] drm: bridge: Switch to devm_drm_of_get_bridge

2021-12-10 Thread Jagan Teki
devm_drm_of_get_bridge is capable of looking up the downstream bridge and panel and trying to add a panel bridge if the panel is found. Replace explicit finding calls with devm_drm_of_get_bridge. Cc: Philipp Zabel Cc: Chun-Kuang Hu Cc: Linus Walleij Signed-off-by: Jagan Teki --- Note: for mcd

[PATCH v2 02/11] gpu: host1x: Add missing DMA API include

2021-12-10 Thread Robin Murphy
Host1x seems to be relying on picking up dma-mapping.h transitively from iova.h, which has no reason to include it in the first place. Fix the former issue before we totally break things by fixing the latter one. CC: Thierry Reding CC: Mikko Perttunen CC: dri-devel@lists.freedesktop.org Signed-o

[PATCH v2 03/11] drm/tegra: vic: Fix DMA API misuse

2021-12-10 Thread Robin Murphy
Upon failure, dma_alloc_coherent() returns NULL. If that does happen, passing some uninitialised stack contents to dma_mapping_error() - which belongs to a different API in the first place - has precious little chance of detecting it. Also include the correct header, because the fragile transitive

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use correct context lock when callig clr_context_registered

2021-12-10 Thread Matthew Brost
On Fri, Dec 10, 2021 at 08:41:22AM +, Tvrtko Ursulin wrote: > > On 09/12/2021 19:14, Daniele Ceraolo Spurio wrote: > > > > > > On 12/9/2021 10:48 AM, Matthew Brost wrote: > > > s/ce/cn/ when grabbing guc_state.lock before calling > > > clr_context_registered. > > > > > > Fixes: 0f7976506de6

Re: RPI 7" display touch controller

2021-12-10 Thread Tim Harvey
On Thu, Nov 18, 2021 at 12:52 PM Tim Harvey wrote: > > On Thu, Nov 18, 2021 at 10:30 AM Dave Stevenson > wrote: > > > > On Thu, 18 Nov 2021 at 17:36, Tim Harvey wrote: > > > > > > On Thu, Nov 18, 2021 at 6:28 AM Dave Stevenson > > > wrote: > > > > > > > > Hi Tim > > > > > > > > On Thu, 18 Nov 2

Re: [PATCH 1/3] drm: bridge: nwl-dsi: Drop panel_bridge from nwl_dsi

2021-12-10 Thread Guido Günther
Hi, On Fri, Dec 10, 2021 at 11:18:17PM +0530, Jagan Teki wrote: > panel_bridge pointer never used anywhere except the one it > looked up at nwl_dsi_bridge_attach. > > Drop it from the nwl_dsi structure. > > Cc: Guido Günther > Signed-off-by: Jagan Teki Reviewed-by: Guido Günther > --- > dri

Re: RPI 7" display touch controller

2021-12-10 Thread Dave Stevenson
On Fri, 10 Dec 2021 at 18:20, Tim Harvey wrote: > > On Thu, Nov 18, 2021 at 12:52 PM Tim Harvey wrote: > > > > On Thu, Nov 18, 2021 at 10:30 AM Dave Stevenson > > wrote: > > > > > > On Thu, 18 Nov 2021 at 17:36, Tim Harvey wrote: > > > > > > > > On Thu, Nov 18, 2021 at 6:28 AM Dave Stevenson >

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Alex Deucher
On Fri, Dec 10, 2021 at 9:25 AM Guilherme G. Piccoli wrote: > > On 10/12/2021 11:16, Alex Deucher wrote:> [...] > > Why not just reload the driver after kexec? > > > > Alex > > Because the original issue is the kdump case, and we want a very very > tiny kernel - also, the crash originally could ha

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

2021-12-10 Thread Alex Deucher
On Fri, Dec 10, 2021 at 10:24 AM Guilherme G. Piccoli wrote: > > On 10/12/2021 12:13, Christian König wrote: > > [...] > > How about issuing a PCIe reset and re-initializing the ASIC with just > > the VBIOS? > > > > That should be pretty straightforward I think. > > > > Christian. > > > Thanks Chr

[PATCH v2 0/4] drm: exynos: dsi: Convert drm bridge

2021-12-10 Thread Jagan Teki
Updated series about drm bridge conversion of exynos dsi. Patch 1: panel checker Patch 2: panel_bridge API Patch 3: Bridge conversion Patch 4: Atomic functions [1] https://patchwork.kernel.org/project/dri-devel/cover/20211122070633.89219-1-ja...@amarulasolutions.com/ Any inputs? Jagan. Jaga

[PATCH v2 1/4] drm: exynos: dsi: Check panel for panel helpers

2021-12-10 Thread Jagan Teki
Trigger the panel operation helpers only if host found the panel. Add check. Signed-off-by: Jagan Teki --- Changes for v2: - new patch drivers/gpu/drm/exynos/exynos_drm_dsi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/d

[PATCH v2 2/4] drm: exynos: dsi: Use drm panel_bridge API

2021-12-10 Thread Jagan Teki
Replace the manual panel handling code by a drm panel_bridge via devm_drm_of_get_bridge(). Adding panel_bridge handling, - Drops drm_connector and related operations as drm_bridge_attach creates connector during attachment. - Drops panel pointer and iterate the bridge, so-that it can operate

[PATCH v2 3/4] drm: exynos: dsi: Convert to bridge driver

2021-12-10 Thread Jagan Teki
Convert the encoders to bridge drivers in order to standardize on a single API with built-in dumb encoder support for compatibility with existing component drivers. Driver bridge conversion will help to reuse the same bridge on different platforms as exynos dsi driver can be used as a Samsung DSIM

[PATCH v2 4/4] drm: exynos: dsi: Switch to atomic funcs

2021-12-10 Thread Jagan Teki
The new support drm bridges are moving towards atomic functions. Replace atomic version of functions to continue the transition to the atomic API. Signed-off-by: Jagan Teki --- Changes for v2: - new patch drivers/gpu/drm/exynos/exynos_drm_dsi.c | 23 ++- 1 file changed, 14

Re: RPI 7" display touch controller

2021-12-10 Thread Tim Harvey
On Fri, Dec 10, 2021 at 10:41 AM Dave Stevenson wrote: > > On Fri, 10 Dec 2021 at 18:20, Tim Harvey wrote: > > > > On Thu, Nov 18, 2021 at 12:52 PM Tim Harvey wrote: > > > > > > On Thu, Nov 18, 2021 at 10:30 AM Dave Stevenson > > > wrote: > > > > > > > > On Thu, 18 Nov 2021 at 17:36, Tim Harvey

  1   2   >