[PATCH v1 5/8] drm/msm/dpu: stop manually removing debugfs files for the DPU plane

2021-12-01 Thread Dmitry Baryshkov
DRM code handles removing all debugfs recursively. Drop plane-specific code to perform that. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 28 --- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v1 7/8] drm/msm/dpu: simplify DPU's regset32 code

2021-12-01 Thread Dmitry Baryshkov
Squash dpu_debugfs_setup_regset32() into dpu_debugfs_create_regset32(). it makes little sense to have separate function to just setup the structure. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 32 --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h |

[PATCH v1 6/8] drm/msm/dpu: stop manually removing debugfs files for the DPU CRTC

2021-12-01 Thread Dmitry Baryshkov
DRM code handles removing all debugfs recursively. Drop CRTC-specific code to perform that. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 3 --- 2 files changed, 4 insertions(+), 14 deletions(-) dif

[PATCH v1 8/8] drm/msm/dpu: move SSPP debugfs support from plane to SSPP code

2021-12-01 Thread Dmitry Baryshkov
We are preparing to change DPU plane implementation. Move SSPP debugfs code from dpu_plane.c to dpu_hw_sspp.c, where it belongs. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 67 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 4 + drivers/gpu

[PATCH v2 0/4] drm/msm/dpu: cleanup plane state

2021-12-01 Thread Dmitry Baryshkov
This is a cleanup part of the DPU multirect patchset [1], split away to ease review and merging per Abhinav's request. Changes in v2: - Drop patches that were accepted - Removed pe argument from _dpu_hw_sspp_setup_scaler3 - Add CDP setup and DPU_SSPP features checks patches that were left from the

[PATCH v2 1/4] drm/msm/dpu: drop scaler config from plane state

2021-12-01 Thread Dmitry Baryshkov
Scaler and pixel_ext configuration does not contain a long living state, it is used only during plane update, so remove these two fiels from dpu_plane_state and allocate them on stack. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 59 ++- dri

[PATCH v2 2/4] drm/msm/dpu: drop pe argument from _dpu_hw_sspp_setup_scaler3

2021-12-01 Thread Dmitry Baryshkov
The _dpu_hw_sspp_setup_scaler3 (hw_sspp->setup_scaler) does not use pe argument. Let's remove it while we are cleaning scaled configuration. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 2 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 -- drivers/gpu/drm

[PATCH v2 3/4] drm/msm/dpu: simplify DPU_SSPP features checks

2021-12-01 Thread Dmitry Baryshkov
Add DPU_SSPP_CSC_ANY denoting any CSC block. As we are at it, rewrite DPU_SSPP_SCALER (any scaler) to use BIT(x) instead of hand-coded bitshifts. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 16 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c |

[PATCH v2 4/4] drm/msm/dpu: fix CDP setup to account for multirect index

2021-12-01 Thread Dmitry Baryshkov
Client driven prefetch (CDP) is properly setup only for SSPP REC0 currently. Enable client driven prefetch also for SSPP REC1. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 12 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 4 +++- drivers/gpu/drm

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-12-01 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit d58071a8a76d779eedab38033ae4c821c30295a5: Linux 5.16-rc3 (2021-11-28 14:09:19 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.16-2021-12-01 for you to fe

Re: [PATCH v2 01/20] ASoC: dt-bindings: Add binding for Tegra20 S/PDIF

2021-12-01 Thread Rob Herring
On Fri, Nov 26, 2021 at 07:17:48PM +0300, Dmitry Osipenko wrote: > Add device-tree binding for Tegra20 S/PDIF controller. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/sound/nvidia,tegra20-spdif.yaml | 85 +++ > 1 file changed, 85 insertions(+) > create mode 100644 >

Re: [PATCH v2 02/20] ASoC: dt-bindings: tegra20-i2s: Convert to schema

2021-12-01 Thread Rob Herring
On Fri, 26 Nov 2021 19:17:49 +0300, Dmitry Osipenko wrote: > Convert NVIDIA Tegra20 I2S binding to schema. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/sound/nvidia,tegra20-i2s.txt | 30 > .../bindings/sound/nvidia,tegra20-i2s.yaml| 70 +++ > 2 files c

Re: [PATCH v2 03/20] ASoC: dt-bindings: tegra20-i2s: Document new nvidia,fixed-parent-rate property

2021-12-01 Thread Rob Herring
On Fri, 26 Nov 2021 19:17:50 +0300, Dmitry Osipenko wrote: > Document new nvidia,fixed-parent-rate property which instructs that this > board wants parent clock to stay at a fixed rate. It allows to prevent > conflicts between audio components that share same parent PLL. For > instance, this proper

Re: [PATCH v2 04/20] dt-bindings: host1x: Document optional HDMI sound-dai-cells

2021-12-01 Thread Rob Herring
On Fri, 26 Nov 2021 19:17:51 +0300, Dmitry Osipenko wrote: > Document new optional sound-dai-cells property of HDMI node. This node will > be used as endpoint of HDMI sound DAI graph. > > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt | 1

Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-12-01 Thread Steve Cho
LGTM. On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > Vdec and venc can use the same function to wake up interrupt event. > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_dr

Re: [PATCH v11, 05/19] media: mtk-vcodec: Support MT8192

2021-12-01 Thread Steve Cho
Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 4:10 AM AngeloGioacchino Del Regno wrote: > > Il 29/11/21 04:41, Yunfei Dong ha scritto: > > From: Yunfei Dong > > > > Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". > > Adds MT8192's device private data mtk_lat_sig_core_pdata. > > > > Signe

Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-12-01 Thread Steve Cho
Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 3:55 PM Steve Cho wrote: > > LGTM. > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > > > Vdec and venc can use the same function to wake up interrupt event. > > > > Reviewed-by: Tzung-Bi Shih > > Reviewed-by: AngeloGioacchino Del Regno >

Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions

2021-12-01 Thread Steve Cho
Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 4:09 AM AngeloGioacchino Del Regno wrote: > > Il 29/11/21 04:41, Yunfei Dong ha scritto: > > Register each hardware as platform device, need to call pm functions > > to open/close power and clock from module mtk-vcodec-dec, export these > > functions

Re: [PATCH v11, 03/19] media: mtk-vcodec: Refactor vcodec pm interface

2021-12-01 Thread Steve Cho
Reviewed-by: Steve Cho On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > Using the needed param for pm init/release function and remove unused > param mtkdev in 'struct mtk_vcodec_pm'. nit: How about s/needed param/needed params |pdev| and |pm|/ ? > Reviewed-by: Tzung-Bi Shih > Reviewed

[PATCH] drm/i915: replace X86_FEATURE_PAT with pat_enabled()

2021-12-01 Thread Lucas De Marchi
PAT can be disabled on boot with "nopat" in the command line. Replace one x86-ism with another, which is slightly more correct to prepare for supporting other architectures. Cc: Matt Roper Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 8 drivers/gpu/drm

linux-next: manual merge of the drm-intel-gt tree with the drm-intel tree

2021-12-01 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel-gt tree got a conflict in: drivers/gpu/drm/i915/display/intel_fbc.c between commit: d06188234427 ("drm/i915/fbc: s/dev_priv/i915/") from the drm-intel tree and commit: cca084692394 ("drm/i915: Use per device iommu check") from the drm-i

Re: [PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.16-rc3] [cannot apply to drm/drm-next drm-tip/drm-tip next-20211201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-12-01 Thread yunfei.d...@mediatek.com
Hi Benjamin, Thanks for your suggestion. On Tue, 2021-11-30 at 14:20 +0100, Benjamin Gaignard wrote: > Le 29/11/2021 à 04:41, Yunfei Dong a écrit : > > Different platform may has different numbers of register bases. > > Gets the > > numbers of register bases from DT (sizeof(u32) * 4 bytes for each

Re: [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-12-01 Thread yunfei.d...@mediatek.com
Hi Steve, Thanks for your suggestion.On Wed, 2021-12-01 at 15:36 -0800, Steve Cho wrote: > LGTM with few nits. > > Thanks,Steve > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong > wrote: > > Different platform may has different numbers of register bases. > > Gets the > > > > numbers of register

[PATCH v12, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-12-01 Thread Yunfei Dong
Different platforms may have different numbers of register bases. Gets the numbers of register bases from dts (sizeof(u32) * 4 bytes for each). Reviewed-by: Tzung-Bi Shih Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 37 ++- 1 file changed, 28 ins

[PATCH v12, 00/19] Support multi hardware decode using of_platform_populate

2021-12-01 Thread Yunfei Dong
This series adds support for multi hardware decode into mtk-vcodec, by first adding use of_platform_populate to manage each hardware information: interrupt, clock, register bases and power. Secondly add core work queue to deal with core hardware message, at the same time, add msg queue for diffe

[PATCH v12, 04/19] media: mtk-vcodec: export decoder pm functions

2021-12-01 Thread Yunfei Dong
When mtk vcodec decoder is build as a module, we need to export mtk-vcodec-dec pm functions to make them visible by the other components. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Benjamin Gaignard Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c

[PATCH v12, 05/19] media: mtk-vcodec: Support MT8192

2021-12-01 Thread Yunfei Dong
From: Yunfei Dong Adds MT8192's compatible "mediatek,mt8192-vcodec-dec". Adds MT8192's device private data mtk_lat_sig_core_pdata. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong --- .../media/platform/mtk-vcodec/mtk_vcodec_dec.h | 1 + .../platform/mtk-vcodec/mtk_vcode

[PATCH v12, 03/19] media: mtk-vcodec: Refactor vcodec pm interface

2021-12-01 Thread Yunfei Dong
Using the needed params for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 ++--- ..

[PATCH v12, 06/19] media: mtk-vcodec: Add to support multi hardware decode

2021-12-01 Thread Yunfei Dong
There are more than two hardwares for decoder: LAT0, LAT1 and CORE. In order to manage these hardwares, register each hardware as independent platform device for the larbs are different. Each hardware module controls its own information which includes interrupt/power/ clocks/registers. Calling o

[PATCH v12, 08/19] media: mtk-vcodec: Use pure single core for MT8183

2021-12-01 Thread Yunfei Dong
Separates different architecture for hardware: pure_sin_core and lat_sin_core. MT8183 is pure single core. Uses .hw_arch to distinguish. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_stateful.c | 1 + .../platform/mtk-vcodec

[PATCH v12, 07/19] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

2021-12-01 Thread Yunfei Dong
Separate decoder and encoder document for the dts are big difference. Reviewed-by: Rob Herring Signed-off-by: Yunfei Dong --- .../media/mediatek,vcodec-decoder.yaml| 176 + .../media/mediatek,vcodec-encoder.yaml| 187 ++ .../bindings/media/mediatek

[PATCH v12, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-12-01 Thread Yunfei Dong
Vdec and venc can use the same function to wake up interrupt event. Reviewed-by: Tzung-Bi Shih Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steve Cho Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 + drivers/media/platform/mtk-vcodec

[PATCH v12, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces

2021-12-01 Thread Yunfei Dong
Generalizes power and clock on/off interfaces to support different hardware. Signed-off-by: Yunfei Dong --- fix comments from Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/m

[PATCH v12, 09/19] media: mtk-vcodec: Add irq interface for multi hardware

2021-12-01 Thread Yunfei Dong
Adds irq interface for multi hardware. Signed-off-by: Yunfei Dong --- fix comments from Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 32 --- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_

[PATCH v12, 10/19] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-12-01 Thread Yunfei Dong
For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong --- fix comments from Reviewed-by: AngeloGioacchino Del Regno ---

[PATCH v12, 13/19] media: mtk-vcodec: Add work queue for core hardware decode

2021-12-01 Thread Yunfei Dong
Add work queue to process core hardware information. First, get lat_buf from message queue, then call core hardware of each codec(H264/VP9/AV1) to decode, finally puts lat_buf back to the message. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 16 +++- .../pla

[PATCH v12, 14/19] media: mtk-vcodec: Support 34bits dma address for vdec

2021-12-01 Thread Yunfei Dong
Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it depends on the dma-ranges property of vdec dtsi nod

[PATCH v12, 12/19] media: mtk-vcodec: Add new interface to lock different hardware

2021-12-01 Thread Yunfei Dong
For add new hardware, not only need to lock lat hardware, also need to lock core hardware in case of different instance start to decoder at the same time. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 ++-- dri

[PATCH v12, 16/19] media: mtk-vcodec: Add core dec and dec end ipi msg

2021-12-01 Thread Yunfei Dong
Add core dec and dec end ipi msg: AP_IPIMSG_DEC_CORE/AP_IPIMSG_DEC_CORE_END. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 4 .../media/platform/mtk-vcodec/vdec_vpu_if.c| 12 .../media/platform/mtk

[PATCH v12, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-12-01 Thread Yunfei Dong
Adds decoder dt-bindings for mt8192. Signed-off-by: Yunfei Dong --- .../media/mediatek,vcodec-subdev-decoder.yaml | 266 ++ 1 file changed, 266 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml diff --git a/Documentat

[PATCH v12, 17/19] media: mtk-vcodec: Use codec type to separate different hardware

2021-12-01 Thread Yunfei Dong
There is just one core thread, in order to separate different hardware, using codec type to separeate it in scp driver. Signed-off-by: Yunfei Dong Reviewed-by: AngeloGioacchino Del Regno --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 12 --- .../media/platform/mtk-vcodec/vdec_vpu_if.c

[PATCH v12, 19/19] media: mtk-vcodec: Remove mtk_vcodec_release_enc_pm

2021-12-01 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_enc_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_release_enc_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_enc_pm to *_clk since it only has clock operations now.

[PATCH v12, 18/19] media: mtk-vcodec: Remove mtk_vcodec_release_dec_pm

2021-12-01 Thread Yunfei Dong
There are only two lines in mtk_vcodec_release_dec_pm, using pm_runtime_disable and put_device instead directly. Move pm_runtime_enable outside mtk_vcodec_init_dec_pm to symmetry with pm_runtime_disable, after that, rename mtk_vcodec_init_dec_pm to *_clk since it only has clock operations now. Re

Re: [PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.16-rc3] [cannot apply to drm/drm-next drm-tip/drm-tip next-20211201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH] drm/i915: Fix error pointer dereference in i915_gem_do_execbuffer()

2021-12-01 Thread Matthew Brost
From: Dan Carpenter Originally "out_fence" was set using out_fence = sync_file_create() but which returns NULL, but now it is set with out_fence = eb_requests_create() which returns error pointers. The error path needs to be modified to avoid an Oops in the "goto err_request;" path. Fixes: 5444

[PATCH v4 1/2] drm/mediatek: add wait_for_event for crtc disable by cmdq

2021-12-01 Thread jason-jh . lin
mtk_drm_crtc_atomic_disable will send an async cmd to cmdq driver, so it may not finish when cmdq_suspend is called sometimes. Add wait_for_event after sending async disable plane cmd to make sure the lastest cmd is done before cmdq_suspend. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/media

[PATCH v4 0/2] Fix mediatek-drm suspend and resume issue

2021-12-01 Thread jason-jh . lin
Change in v4: - change completment function to wait_for_event. - release the mbox channel when device_link_add fail with cmdq and still return 0 because drm can configure register by cpu. Change in v3: - fix return typo: modify -NOEDV to -ENODEV. - add missing complete function in ddp_cmdq_cb.

[PATCH v4 2/2] drm/mediatek: add devlink to cmdq dev

2021-12-01 Thread jason-jh . lin
Add devlink to cmdq to make sure the order of suspend and resume is correct. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 43 ++--- 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/

<    1   2