Re: Questions about KMS flip

2021-11-16 Thread Lang Yu
On Tue, Nov 16, 2021 at 08:14:08AM +0100, Christian KKKnig wrote: > Am 16.11.21 um 04:27 schrieb Lang Yu: > > On Mon, Nov 15, 2021 at 01:04:15PM +0100, Michel DDDnzer wrote: > > > [SNIP] > > > > Though a single call to dce_v*_0_crtc_do_set_base() will > > > > only pin the BO, I found it will be unp

Re: Questions about KMS flip

2021-11-16 Thread Christian König
Am 16.11.21 um 09:00 schrieb Lang Yu: On Tue, Nov 16, 2021 at 08:14:08AM +0100, Christian KKKnig wrote: Am 16.11.21 um 04:27 schrieb Lang Yu: On Mon, Nov 15, 2021 at 01:04:15PM +0100, Michel DDDnzer wrote: [SNIP] Though a single call to dce_v*_0_crtc_do_set_base() will only pin the BO, I foun

Re: [RFC v2 05/22] drm/i915/xelpd: Define Degamma Lut range struct for HDR planes

2021-11-16 Thread Pekka Paalanen
On Fri, 12 Nov 2021 16:54:35 +0200 Ville Syrjälä wrote: > On Thu, Nov 11, 2021 at 04:10:41PM -0500, Harry Wentland wrote: > > > > > > On 2021-11-11 15:42, Shankar, Uma wrote: > > > > > > > > >> -Original Message- > > >> From: Ville Syrjälä > > >> Sent: Thursday, November 11, 2021

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Christian König
Am 16.11.21 um 08:43 schrieb Thomas Hellström: On 11/16/21 08:19, Christian König wrote: Am 13.11.21 um 12:26 schrieb Thomas Hellström: Hi, Zack, On 11/11/21 17:44, Zack Rusin wrote: On Wed, 2021-11-10 at 09:50 -0500, Zack Rusin wrote: TTM takes full control over TTM_PL_SYSTEM placed buffers

Re: [PATCH 06/11] dmaengine: sprd: stop referencing config->slave_id

2021-11-16 Thread Baolin Wang
Hi Arnd, On Mon, Nov 15, 2021 at 4:55 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > It appears that the code that reads the slave_id from the channel config > was copied incorrectly from other drivers. Nothing ever sets this field > on platforms that use this driver, so remove the referenc

[PATCH] drm: drm_probe_helper: add modes upto 1920x1080

2021-11-16 Thread Angus Ainslie
Lots of monitors nowdays support more than 1024x768 so if the EDID is unknown then add resolutions upto 1920x1080. Signed-off-by: Angus Ainslie --- drivers/gpu/drm/drm_probe_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers

Re: [PATCH 3/4] drm/aspeed: Update INTR_STS handling

2021-11-16 Thread Joel Stanley
On Mon, 1 Nov 2021 at 11:01, tommy-huang wrote: > > The V-sync INTR_STS is differnet on AST2600. > Change into general rule to handle it. > > Signed-off-by: tommy-huang > --- > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 ++ > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 26 +++

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Thomas Hellström
On 11/16/21 09:20, Christian König wrote: Am 16.11.21 um 08:43 schrieb Thomas Hellström: On 11/16/21 08:19, Christian König wrote: Am 13.11.21 um 12:26 schrieb Thomas Hellström: Hi, Zack, On 11/11/21 17:44, Zack Rusin wrote: On Wed, 2021-11-10 at 09:50 -0500, Zack Rusin wrote: TTM takes f

Re: [PATCH] drm: drm_probe_helper: add modes upto 1920x1080

2021-11-16 Thread Jani Nikula
Cc: Ville On Mon, 15 Nov 2021, Angus Ainslie wrote: > Lots of monitors nowdays support more than 1024x768 so if the EDID is > unknown then add resolutions upto 1920x1080. IIUC it's supposed to be the fallback that's pretty much guaranteed to work. What's going to happen if we add 1920x1080 and

Re: [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC

2021-11-16 Thread Pekka Paalanen
On Fri, 12 Nov 2021 10:08:41 -0500 Jason Baron wrote: > On 11/12/21 6:49 AM, Vincent Whitchurch wrote: > > On Thu, Nov 11, 2021 at 03:02:04PM -0700, Jim Cromie wrote: > >> Sean Paul proposed, in: > >> https://urldefense.com/v3/__https://patchwork.freedesktop.org/series/78133/__;!!GjvTz_vk!HcKnM

Re: [PATCH] drm: drm_probe_helper: add modes upto 1920x1080

2021-11-16 Thread Daniel Vetter
On Tue, Nov 16, 2021 at 9:44 AM Jani Nikula wrote: > > > Cc: Ville > > On Mon, 15 Nov 2021, Angus Ainslie wrote: > > Lots of monitors nowdays support more than 1024x768 so if the EDID is > > unknown then add resolutions upto 1920x1080. > > IIUC it's supposed to be the fallback that's pretty much

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Christian König
Am 16.11.21 um 09:33 schrieb Thomas Hellström: On 11/16/21 09:20, Christian König wrote: Am 16.11.21 um 08:43 schrieb Thomas Hellström: On 11/16/21 08:19, Christian König wrote: Am 13.11.21 um 12:26 schrieb Thomas Hellström: Hi, Zack, On 11/11/21 17:44, Zack Rusin wrote: On Wed, 2021-11-10

Re: [PATCH 1/3] drm/cma-helper: Move driver and file ops to the end of header

2021-11-16 Thread Thomas Zimmermann
Hi Laurent Am 15.11.21 um 14:40 schrieb Laurent Pinchart: Hi Thomas, Thank you for the patch. On Mon, Nov 15, 2021 at 01:01:46PM +0100, Thomas Zimmermann wrote: Restructure the header file for CMA helpers by moving declarations for driver and file operations to the end of the file. No functio

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Thomas Hellström
On 11/16/21 09:54, Christian König wrote: Am 16.11.21 um 09:33 schrieb Thomas Hellström: On 11/16/21 09:20, Christian König wrote: Am 16.11.21 um 08:43 schrieb Thomas Hellström: On 11/16/21 08:19, Christian König wrote: Am 13.11.21 um 12:26 schrieb Thomas Hellström: Hi, Zack, On 11/11/21

Re: [PATCH 3/3] drm/cma-helper: Pass GEM CMA object in public interfaces

2021-11-16 Thread Thomas Zimmermann
Hi Laurent Am 15.11.21 um 14:50 schrieb Laurent Pinchart: Hi Thomas, Thank you for the patch. On Mon, Nov 15, 2021 at 01:01:48PM +0100, Thomas Zimmermann wrote: Change all GEM CMA object functions that receive a GEM object of type struct drm_gem_object to expect an object of type struct drm_g

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Christian König
Am 16.11.21 um 10:00 schrieb Thomas Hellström: On 11/16/21 09:54, Christian König wrote: Am 16.11.21 um 09:33 schrieb Thomas Hellström: On 11/16/21 09:20, Christian König wrote: Am 16.11.21 um 08:43 schrieb Thomas Hellström: On 11/16/21 08:19, Christian König wrote: [SNIP] Well my long ter

Re: [PATCH 2/3] drm/vmwgfx: Copy DRM hash-table code into driver

2021-11-16 Thread Thomas Zimmermann
Hi Sam Am 15.11.21 um 17:27 schrieb Sam Ravnborg: Hi Thomas, On Mon, Nov 15, 2021 at 01:55:38PM +0100, Thomas Zimmermann wrote: Besides some legacy code, vmwgfx is the only user of DRM's hash- table implementation. Copy the code into the driver, so that the core code can be retired. For the r

Re: [PATCH 06/15] iio: buffer-dmaengine: Enable write support

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:20 PM Paul Cercueil wrote: > > Use the iio_dma_buffer_write() and iio_dma_buffer_space_available() > functions provided by the buffer-dma core, to enable write support in > the buffer-dmaengine code. > This is a bit related to the comment about iio_dma_buffer_space_avail

Re: [PATCH 02/15] iio: buffer-dma: Remove unused iio_buffer_block struct

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:19 PM Paul Cercueil wrote: > > This structure was never used anywhere, so it can safely be dropped. > > It will later be re-introduced as a different structure in a > different header. Reviewed-by: Alexandru Ardelean > > Signed-off-by: Paul Cercueil > --- > include/l

Re: [PATCH 04/15] iio: buffer-dma: Enable buffer write support

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:19 PM Paul Cercueil wrote: > > Adding write support to the buffer-dma code is easy - the write() > function basically needs to do the exact same thing as the read() > function: dequeue a block, read or write the data, enqueue the block > when entirely processed. > > There

Re: [PATCH 01/15] iio: buffer-dma: Get rid of incoming/outgoing queues

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:19 PM Paul Cercueil wrote: > > The buffer-dma code was using two queues, incoming and outgoing, to > manage the state of the blocks in use. > > While this totally works, it adds some complexity to the code, > especially since the code only manages 2 blocks. It is much eas

Re: [PATCH 03/15] iio: buffer-dma: Use round_down() instead of rounddown()

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:19 PM Paul Cercueil wrote: > > We know that the buffer's alignment will always be a power of two; > therefore, we can use the faster round_down() macro. > Reviewed-by: Alexandru Ardelean > Signed-off-by: Paul Cercueil > --- > drivers/iio/buffer/industrialio-buffer-dm

Re: [PATCH 05/15] iio: buffer-dmaengine: Support specifying buffer direction

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:20 PM Paul Cercueil wrote: > > Update the devm_iio_dmaengine_buffer_setup() function to support > specifying the buffer direction. > > Update the iio_dmaengine_buffer_submit() function to handle input > buffers as well as output buffers. > Reviewed-by: Alexandru Ardelea

Re: [PATCH] drm/amd/display: cleanup the code a bit

2021-11-16 Thread Christian König
Am 16.11.21 um 02:34 schrieb Bernard Zhao: In function dc_sink_destruct, kfree will check pointer, no need to check again. This change is to cleanup the code a bit. Signed-off-by: Bernard Zhao This one and the other patch are Acked-by: Christian König --- drivers/gpu/drm/amd/display/dc

Re: [PATCH 2/3] drm/vmwgfx: Copy DRM hash-table code into driver

2021-11-16 Thread Thomas Zimmermann
Hi Am 15.11.21 um 18:00 schrieb Zack Rusin: On Mon, 2021-11-15 at 13:55 +0100, Thomas Zimmermann wrote: Besides some legacy code, vmwgfx is the only user of DRM's hash- table implementation. Copy the code into the driver, so that the core code can be retired. No functional changes. However, th

[PATCH] omapfb: add one more "fallthrough" statement

2021-11-16 Thread Arnd Bergmann
From: Arnd Bergmann clang warns about one missing fallthrough that gcc ignores: drivers/video/fbdev/omap/omapfb_main.c:1558:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] Add it here as well. Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/oma

[PATCH 1/2] drm/scheduler: fix drm_sched_job_add_implicit_dependencies

2021-11-16 Thread Christian König
Trivial fix since we now need to grab a reference to the fence we have added. Previously the dma_resv function where doing that for us. Signed-off-by: Christian König Fixes: 9c2ba265352a ("drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2") Link: https://patchwork.fr

[PATCH 2/2] drm/sched: fix dropping the last fence ref

2021-11-16 Thread Christian König
We need to grab another ref before trying to add the fence to the sched job and not after. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gp

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Javier Martinez Canillas
Hello Geert, On 11/15/21 17:20, Geert Uytterhoeven wrote: [snip] >> @@ -351,6 +351,17 @@ static int efifb_probe(struct platform_device *dev) >> char *option = NULL; >> efi_memory_desc_t md; >> >> + /* >> +* Generic drivers must not be registered if a framebuffer exi

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Geert Uytterhoeven
Hi Javier, On Tue, Nov 16, 2021 at 10:30 AM Javier Martinez Canillas wrote: > On 11/15/21 17:20, Geert Uytterhoeven wrote: > >> @@ -351,6 +351,17 @@ static int efifb_probe(struct platform_device *dev) > >> char *option = NULL; > >> efi_memory_desc_t md; > >> > >> + /* > >> +

[PATCH v3 0/2] seperate panel power control from panel prepare/unprepare

2021-11-16 Thread Jitao Shi
Changes since v2: - Panel driver panel-boe-tv101wum-nl6.c provides the power sequence apis. - The apis are called before dsi poweron and after dsi poweroff. Changes since v1: - Fix null point when dsi next bridge isn't a panel. - "dsi mmsys reset" is implement by https://patchwork.kernel.or

[PATCH v3 2/2] drm/mediatek: control panel's power before MIPI LP11

2021-11-16 Thread Jitao Shi
"auo,kd101n80-45na" requires the panel's IOVDD take precedence over MIPI DATA. Otherwise there is a risk of leakage. Signed-off-by: Jitao Shi Change-Id: I2da6179dea7e15bc5a53fe36db200b6c04f4d551 --- drivers/gpu/drm/mediatek/mtk_dsi.c | 28 ++-- 1 file changed, 22 insertio

[PATCH v3 1/2] drm/panel: panel-boe-tv101wum-nl6: tune the power sequence to avoid leakage

2021-11-16 Thread Jitao Shi
"auo,kd101n80-45na" 2st LCD SPEC update, need to modify the timing between IOVCC and mipi data. The 2st version of SPEC modifies the timing requirements from IOVCC to Mipi Data. IOVCC is now required to take precedence over MIPI DATA, otherwise there is a risk of leakage. It is recommended that the

[Bug 215025] [amdgpu] Thinkpad A275 hangs on shutdown / screen does not turn on after reboot

2021-11-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215025 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

[Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption

2021-11-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215001 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added CC||dri-devel@lists.freede

[Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption

2021-11-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215001 --- Comment #2 from Artem S. Tashkinov (a...@gmx.com) --- CC'ing the relevant mailing list. > A regression in kernel 5.15 causes FB_VGA16 (vga16fb) to fail to detect that > it has been passed a firmware-initialized graphics bitmap instead of a >

Re: [PATCH] drm/tegra: remove no need NULL check before kfree

2021-11-16 Thread Mikko Perttunen
On 11/16/21 3:55 AM, Bernard Zhao wrote: This change is to cleanup the code a bit. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/tegra/submit.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index 77

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Javier Martinez Canillas
Hello Geert, On 11/16/21 10:43, Geert Uytterhoeven wrote: [snip] >> >> So this is already a fragile solution and $SUBJECT doesn't make things worse >> IMO. Since not having something like this can lead to issues as reported by: >> >> https://lore.kernel.org/all/2020200253.rfudkt3edbd3nsyj@la

Re: Build regressions/improvements in v5.16-rc1

2021-11-16 Thread Thomas Bogendoerfer
On Mon, Nov 15, 2021 at 05:12:50PM +0100, Geert Uytterhoeven wrote: > > + error: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] > > undefined!: => N/A > > + error: modpost: "mips_cm_lock_other" > > [drivers/pci/controller/pcie-mt7621.ko] undefined!: => N/A > > + error: mo

Remaining i915 iterator patches

2021-11-16 Thread Christian König
Hi guys, just sending that out once more to make sure CI is happy. Regards, Christian.

[PATCH 2/6] drm/i915: use new iterator in i915_gem_object_wait_priority

2021-11-16 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 31 +--- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915

[PATCH 5/6] drm/i915: Fix i915_request fence wait semantics

2021-11-16 Thread Christian König
From: Maarten Lankhorst The i915_request fence wait behaves differently for timeout = 0 compared to expected dma-fence behavior. i915 behavior: - Unsignaled: -ETIME - Signaled: 0 (= timeout) Expected: - Unsignaled: 0 - Signaled: 1 Signed-off-by: Maarten Lankhorst Acked-by: Daniel Vetter Acke

[PATCH 1/6] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-11-16 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++-- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/driver

[PATCH 3/6] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

2021-11-16 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_sw_fence.c | 53 ++

[PATCH 6/6] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-11-16 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König [mlankhorst: Handle timeout = 0 correctly, use new i915_request_wait_timeout.] Signed-off-by: Maarten Lankhorst Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 63 +++- 1 file changed, 19 inse

[PATCH 4/6] drm/i915: use new cursor in intel_prepare_plane_fb v2

2021-11-16 Thread Christian König
Simplifying the code a bit. v2: rebased Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i

Re: [PATCH] drm/nouveau/core: fix the uninitialized use in nvkm_ioctl_map()

2021-11-16 Thread Karol Herbst
On Tue, Nov 16, 2021 at 6:58 AM Yizhuo Zhai wrote: > > Hi Karol: > Thanks for the feedback, the patch might be too old to apply to the > latest code tree. Let me check and get back to you soon. > sorry, that's not what I meant. It used whitespaces instead of tabs and the headers were also a bit b

Re: [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate

2021-11-16 Thread yunfei.d...@mediatek.com
Hi Ezequiel, Thanks for you suggestion. On Sun, 2021-11-14 at 19:04 -0300, Ezequiel Garcia wrote: > Hi Yunfei, > > On Thu, 11 Nov 2021 at 01:15, Yunfei Dong > wrote: > > > > This series adds support for multi hardware decode into mtk-vcodec, > > by first adding use > > of_platform_populate to

[PATCH] drm/i915: Fix error pointer dereference in i915_gem_do_execbuffer()

2021-11-16 Thread Dan Carpenter
Originally "out_fence" was set using out_fence = sync_file_create() but which returns NULL, but now it is set with out_fence = eb_requests_create() which returns error pointers. The error path needs to be modified to avoid an Oops in the "goto err_request;" path. Fixes: 544460c33821 ("drm/i915: M

[PATCH] drm/i915/guc: fix NULL vs IS_ERR() checking

2021-11-16 Thread Dan Carpenter
The intel_engine_create_virtual() function does not return NULL. It returns error pointers. Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH v2] backlight: ili922x: fix kernel-doc warnings & notation

2021-11-16 Thread Daniel Thompson
On Mon, Nov 15, 2021 at 06:33:55PM -0800, Randy Dunlap wrote: > Convert function-like macro comments to kernel-doc notation and > fix other kernel-doc warnings: > > drivers/video/backlight/ili922x.c:85: warning: This comment starts with > '/**', but isn't a kernel-doc comment. Refer > Documentat

Re: [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion

2021-11-16 Thread Daniel Thompson
On Mon, Nov 15, 2021 at 09:34:53PM +0100, Marijn Suijten wrote: > The kernel already provides appropriate primitives to perform endianness > conversion which should be used in favour of manual bit-wrangling. > > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno > Reviewed

Re: [PATCH v3 4/9] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

2021-11-16 Thread Daniel Thompson
On Mon, Nov 15, 2021 at 09:34:54PM +0100, Marijn Suijten wrote: > When not specifying num-strings in the DT the default is used, but +1 is > added to it which turns WLED3 into 4 and WLED4/5 into 5 strings instead > of 3 and 4 respectively, causing out-of-bounds reads and register > read/writes. Th

Re: [PATCH v3 5/9] backlight: qcom-wled: Override default length with qcom,enabled-strings

2021-11-16 Thread Daniel Thompson
On Mon, Nov 15, 2021 at 09:34:55PM +0100, Marijn Suijten wrote: > The length of qcom,enabled-strings as property array is enough to > determine the number of strings to be enabled, without needing to set > qcom,num-strings to override the default number of strings when less > than the default (whic

Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings

2021-11-16 Thread Daniel Thompson
Hi Lee On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > This patchset fixes WLED's handling of enabled-strings: besides some > cleanup it is now actually possible to specify a non-contiguous array of > enabled strings (not necessarily starting at zero) and the values from > DT are

Re: [PATCH v10, 15/19] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-11-16 Thread yunfei.d...@mediatek.com
Hi Ezequiel, Thanks for your suggestion. On Sun, 2021-11-14 at 18:56 -0300, Ezequiel Garcia wrote: > Yunfei, > > On Thu, 11 Nov 2021 at 01:15, Yunfei Dong > wrote: > > > > Adds decoder dt-bindings for mt8192. > > > > Signed-off-by: Yunfei Dong > > --- > > .../media/mediatek,vcodec-subdev-dec

Re: [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate

2021-11-16 Thread Ezequiel Garcia
Hi Yunfei, On Tue, 16 Nov 2021 at 08:42, yunfei.d...@mediatek.com wrote: > > Hi Ezequiel, > > Thanks for you suggestion. > On Sun, 2021-11-14 at 19:04 -0300, Ezequiel Garcia wrote: > > Hi Yunfei, > > > > On Thu, 11 Nov 2021 at 01:15, Yunfei Dong > > wrote: > > > > > > This series adds support fo

[bug report] drm/msm/dpu: merge struct dpu_irq into struct dpu_hw_intr

2021-11-16 Thread Dan Carpenter
Hello Dmitry Baryshkov, The patch f25f656608e3: "drm/msm/dpu: merge struct dpu_irq into struct dpu_hw_intr" from Jun 18, 2021, leads to the following Smatch static checker warnings: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:569 dpu_core_irq_preinstall() error: potential null dereference '

Re: [PATCH v10, 00/19] Support multi hardware decode using of_platform_populate

2021-11-16 Thread yunfei.d...@mediatek.com
Hi Ezequiel, On Tue, 2021-11-16 at 09:06 -0300, Ezequiel Garcia wrote: > Hi Yunfei, > > On Tue, 16 Nov 2021 at 08:42, yunfei.d...@mediatek.com > wrote: > > > > Hi Ezequiel, > > > > Thanks for you suggestion. > > On Sun, 2021-11-14 at 19:04 -0300, Ezequiel Garcia wrote: > > > Hi Yunfei, > > >

[PATCH] gpu/drm: fix potential memleak in error branch

2021-11-16 Thread Bernard Zhao
This patch try to fix potential memleak in error branch. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/drm_dp_mst_topology.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.

Re: Backlight control broken on UM325 (OLED) on 5.15 (bisected)

2021-11-16 Thread Samuel Čavoj
Hi Alex, thank you for your response. On 15.11.2021 10:43, Alex Deucher wrote: > [...] > > That patch adds support for systems with multiple backlights. Do you > have multiple backlight devices now? If so, does the other one work? No, there is still only one backlight device -- amdgpu_bl0. >

[syzbot] KASAN: use-after-free Read in drm_gem_object_release_handle

2021-11-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:8ab774587903 Merge tag 'trace-v5.16-5' of git://git.kernel.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1174ace6b0 kernel config: https://syzkaller.appspot.com/x/.config?x=6d3b8fd1977c1e73 das

Re: [PATCH 13/15] iio: core: Add support for cyclic buffers

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:22 PM Paul Cercueil wrote: > > Introduce a new flag IIO_BUFFER_DMABUF_CYCLIC in the "flags" field of > the iio_dmabuf uapi structure. > > When set, the DMABUF enqueued with the enqueue ioctl will be endlessly > repeated on the TX output, until the buffer is disabled. > R

Re: [PATCH 14/15] iio: buffer-dmaengine: Add support for cyclic buffers

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:23 PM Paul Cercueil wrote: > > Handle the IIO_BUFFER_DMABUF_CYCLIC flag to support cyclic buffers. > Reviewed-by: Alexandru Ardelean > Signed-off-by: Paul Cercueil > --- > drivers/iio/buffer/industrialio-buffer-dma.c | 1 + > .../iio/buffer/industrialio-buffer-

Re: [PATCH 08/15] iio: buffer-dma: split iio_dma_buffer_fileio_free() function

2021-11-16 Thread Alexandru Ardelean
On Mon, Nov 15, 2021 at 4:20 PM Paul Cercueil wrote: > > From: Alexandru Ardelean > > A part of the logic in the iio_dma_buffer_exit() is required for the change > to add mmap support to IIO buffers. > This change splits the logic into a separate function, which will be > re-used later. > Not su

[PATCH] drm/bridge: megachips: Ensure both bridges are probed before registration

2021-11-16 Thread Martyn Welch
In the configuration used by the b850v3, the STDP2690 is used to read EDID data whilst it's the STDP4028 which can detect when monitors are connected. This can result in problems at boot with monitors connected when the STDP4028 is probed first, a monitor is detected and an attempt is made to read

Re: [PATCH v2] fbdev: Prevent probing generic drivers if a FB is already registered

2021-11-16 Thread Javier Martinez Canillas
On 11/16/21 11:01, Javier Martinez Canillas wrote: > Hello Geert, > > On 11/16/21 10:43, Geert Uytterhoeven wrote: > > [snip] > >>> >>> So this is already a fragile solution and $SUBJECT doesn't make things worse >>> IMO. Since not having something like this can lead to issues as reported by: >>

Re: Questions about KMS flip

2021-11-16 Thread Alex Deucher
On Tue, Nov 16, 2021 at 3:09 AM Christian König wrote: > > Am 16.11.21 um 09:00 schrieb Lang Yu: > > On Tue, Nov 16, 2021 at 08:14:08AM +0100, Christian KKKnig wrote: > >> Am 16.11.21 um 04:27 schrieb Lang Yu: > >>> On Mon, Nov 15, 2021 at 01:04:15PM +0100, Michel DDDnzer wrote: > [SNIP] > >>

[PATCH 2/2] dt-bindings: panel: Introduce a panel-lvds binding

2021-11-16 Thread Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented. Signed-off-by: Maxime Ripard --- .../bindings/display/panel/panel-lvds.yaml| 56 +++ 1 file changed, 56 insertions(+) cr

[PATCH 1/2] dt-bindings: display: Turn lvds.yaml into a generic schema

2021-11-16 Thread Maxime Ripard
The lvds.yaml file so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding. That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it

Re: [Intel-gfx] [PATCH] drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-16 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 02:20:36PM -0500, Rodrigo Vivi wrote: > On Mon, Nov 15, 2021 at 09:10:54PM +0530, Tilak Tangudu wrote: > > s2idle and runtime pm puts the pci gfx device in D3Hot, ACPI runtime > > monitors the pci tree,if it sees complete tree as D3Hot,it transitions > > the device to D3Cold

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-16 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 09:58:56AM -0500, Rodrigo Vivi wrote: > On Mon, Nov 15, 2021 at 01:44:57PM +0200, Jani Nikula wrote: > > On Mon, 15 Nov 2021, Tilak Tangudu wrote: > > > > The actual commit message with explanations why it will work now and > > didn't work before go here. > > The truth is

Re: Questions about KMS flip

2021-11-16 Thread Michel Dänzer
On 2021-11-16 15:10, Alex Deucher wrote: > On Tue, Nov 16, 2021 at 3:09 AM Christian König > wrote: >> >> Am 16.11.21 um 09:00 schrieb Lang Yu: >>> On Tue, Nov 16, 2021 at 08:14:08AM +0100, Christian KKKnig wrote: Am 16.11.21 um 04:27 schrieb Lang Yu: > On Mon, Nov 15, 2021 at 01:04:15PM

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-11-16 Thread Maxime Ripard
Hi, On Mon, Nov 15, 2021 at 09:33:52AM -0500, Guillaume Ranquet wrote: > Quoting Maxime Ripard (2021-11-15 11:11:29) > > > The driver creates a child device for the phy. The child device will > > > never exist without the parent being active. As they are sharing a > > > register range, the parent

Re: [Intel-gfx] [PATCH] drm/i915/guc: fix NULL vs IS_ERR() checking

2021-11-16 Thread Rodrigo Vivi
On Tue, Nov 16, 2021 at 02:49:16PM +0300, Dan Carpenter wrote: > The intel_engine_create_virtual() function does not return NULL. It > returns error pointers. > > Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface") > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vi

Re: [PATCH] omapfb: add one more "fallthrough" statement

2021-11-16 Thread Nathan Chancellor
On Tue, Nov 16, 2021 at 10:21:54AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang warns about one missing fallthrough that gcc ignores: > > drivers/video/fbdev/omap/omapfb_main.c:1558:2: error: unannotated > fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > > A

Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings

2021-11-16 Thread Lee Jones
On Tue, 16 Nov 2021, Daniel Thompson wrote: > Hi Lee > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > This patchset fixes WLED's handling of enabled-strings: besides some > > cleanup it is now actually possible to specify a non-contiguous array of > > enabled strings (not n

Re: [PATCH v3 11/12] drm/virtio: implement context init: add virtio_gpu_fence_event

2021-11-16 Thread Daniel Vetter
On Mon, Nov 15, 2021 at 07:26:14PM +, Kasireddy, Vivek wrote: > Hi Daniel, Greg, > > If it is the same or a similar crash reported here: > https://lists.freedesktop.org/archives/dri-devel/2021-November/330018.html > and here: > https://lists.freedesktop.org/archives/dri-devel/2021-November/33

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Daniel Vetter
On Tue, Nov 16, 2021 at 10:09:44AM +0100, Christian König wrote: > Am 16.11.21 um 10:00 schrieb Thomas Hellström: > > On 11/16/21 09:54, Christian König wrote: > > > Am 16.11.21 um 09:33 schrieb Thomas Hellström: > > > > On 11/16/21 09:20, Christian König wrote: > > > > > Am 16.11.21 um 08:43 schri

[PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

2021-11-16 Thread Rob Clark
From: Rob Clark drm_sched_job_add_dependency() could drop the last ref, so we need to do the dma_fence_get() first. Cc: Christian König Fixes: 9c2ba265352a drm/scheduler: ("use new iterator in drm_sched_job_add_implicit_dependencies v2") Signed-off-by: Rob Clark --- Applies on top of "drm/sch

[PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-16 Thread Tilak Tangudu
v1: Enable runtime pm autosuspend by default for Gen12 and later versions. v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville) v3: Change commit message(Nikula Jani) Let's enable runtime pm autosuspend by default everywhere. So, we can allow D3hot and bigger power saving

Re: [PATCH v4] drm/ttm: Clarify that the TTM_PL_SYSTEM is under TTMs control

2021-11-16 Thread Zack Rusin
> On Nov 16, 2021, at 03:20, Christian König wrote: > > Am 16.11.21 um 08:43 schrieb Thomas Hellström: >> On 11/16/21 08:19, Christian König wrote: >>> Am 13.11.21 um 12:26 schrieb Thomas Hellström: Hi, Zack, On 11/11/21 17:44, Zack Rusin wrote: > On Wed, 2021-11-10 at 09:50

Re: [PATCH 00/15] iio: buffer-dma: write() and new DMABUF based API

2021-11-16 Thread Daniel Vetter
On Mon, Nov 15, 2021 at 02:57:37PM +, Paul Cercueil wrote: > Hi Daniel, > > Le lun., nov. 15 2021 at 15:37:16 +0100, Daniel Vetter a > écrit : > > On Mon, Nov 15, 2021 at 02:19:10PM +, Paul Cercueil wrote: > > > Hi Jonathan, > > > > > > This patchset introduces a new userspace interfac

Re: [PATCH 00/15] iio: buffer-dma: write() and new DMABUF based API

2021-11-16 Thread Laurent Pinchart
On Tue, Nov 16, 2021 at 05:02:25PM +0100, Daniel Vetter wrote: > On Mon, Nov 15, 2021 at 02:57:37PM +, Paul Cercueil wrote: > > Le lun., nov. 15 2021 at 15:37:16 +0100, Daniel Vetter a écrit : > > > On Mon, Nov 15, 2021 at 02:19:10PM +, Paul Cercueil wrote: > > > > Hi Jonathan, > > > > >

Re: [PATCH 2/2] drm/sched: fix dropping the last fence ref

2021-11-16 Thread Daniel Vetter
On Tue, Nov 16, 2021 at 10:25:19AM +0100, Christian König wrote: > We need to grab another ref before trying to add the fence to the sched > job and not after. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter I wondered first why this goes boom, but then I realized that in some ca

Re: [PATCH] drm/i915: Fix error pointer dereference in i915_gem_do_execbuffer()

2021-11-16 Thread Matthew Brost
On Tue, Nov 16, 2021 at 02:48:17PM +0300, Dan Carpenter wrote: > Originally "out_fence" was set using out_fence = sync_file_create() but > which returns NULL, but now it is set with out_fence = eb_requests_create() > which returns error pointers. The error path needs to be modified to > avoid an O

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-16 Thread Claudio Suarez
On Mon, Nov 15, 2021 at 10:17:58PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Claudio Suarez wrote: > > On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > >> On Sun, 14 Nov 2021, Claudio Suarez wrote: > >> > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > >> >> H

[PATCH v4] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-16 Thread Kuogee Hsieh
Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename d

[PATCH v3 1/5] drm/i915/dg2: s/DISP_STEPPING/DISPLAY_STEPPING/

2021-11-16 Thread Matt Roper
Commit cd0fcf5af791 ("drm/i915: rename DISP_STEPPING->DISPLAY_STEP and GT_STEPPING->GT_STEP") renamed all platforms' display stepping tests, but the DG2 patches were still in-flight at that time and did not incorporate the new naming scheme. Rename DG2's macro now for consistency with other platfo

[PATCH v3 0/5] i915: Additional DG2 workarounds

2021-11-16 Thread Matt Roper
We have a few more DG2 workarounds that weren't included in the initial batch. v2: - Apply pipe control workaround to rcs indirect context rather than xcs indirect context. v3: - s/IS_DG2_DISP_STEP/IS_DG2_DISPLAY_STEPPING/ for consistency with other platforms. Matt Atwood (1): drm/i91

[PATCH v3 4/5] drm/i915/dg2: Add Wa_16013000631

2021-11-16 Thread Matt Roper
From: Ramalingam C Invalidate IC cache through pipe control command as part of the ctx restore flow through indirect ctx pointer. v2: - Move pipe control from xcs indirect context to the rcs indirect context. We'll eventually need this on the CCS engines too, but support for those hasn't

[PATCH v3 3/5] drm/i915/dg2: Add Wa_16011777198

2021-11-16 Thread Matt Roper
Coarse power gating for render should not be enabled on some DG2 steppings. Bspec: 52698 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_rc6.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i

[PATCH v3 2/5] drm/i915/dg2: Add Wa_14010547955

2021-11-16 Thread Matt Roper
This workaround is documented a bit strangely in the bspec; it's listed as an A0 workaround, but the description clarifies that the workaround is implicitly handled by the hardware and what the driver really needs to do is program a chicken bit to reenable some internal behavior. Signed-off-by: Ma

[PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2

2021-11-16 Thread Matt Roper
From: Matt Atwood Extend existing workaround 1409120013 to DG2. Cc: José Roberto de Souza Signed-off-by: Matt Atwood Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers

Re: [PATCH 2/2] drm/sched: fix dropping the last fence ref

2021-11-16 Thread Rob Clark
On Tue, Nov 16, 2021 at 8:37 AM Daniel Vetter wrote: > > On Tue, Nov 16, 2021 at 10:25:19AM +0100, Christian König wrote: > > We need to grab another ref before trying to add the fence to the sched > > job and not after. > > > > Signed-off-by: Christian König > > Reviewed-by: Daniel Vetter > > I

Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

2021-11-16 Thread Amit Pundir
On Tue, 16 Nov 2021 at 21:21, Rob Clark wrote: > > From: Rob Clark > > drm_sched_job_add_dependency() could drop the last ref, so we need to do > the dma_fence_get() first. > It fixed the splats I saw on RB5 (sm8250 | A650). Thanks. Tested-by: Amit Pundir > Cc: Christian König > Fixes: 9c2ba

[PATCH AUTOSEL 5.15 03/65] backlight: Propagate errors from get_brightness()

2021-11-16 Thread Sasha Levin
From: Thomas Weißschuh [ Upstream commit 563edf85ce18a90dd0a7b39e279a691d937205f6 ] backlight.h documents "struct backlight_ops->get_brightness()" to return a negative errno on failure. So far these errors have not been handled in the backlight core. This leads to negative values being exposed

[PATCH AUTOSEL 5.15 07/65] fbdev: fbmem: Fix double free of 'fb_info->pixmap.addr'

2021-11-16 Thread Sasha Levin
From: Zheyu Ma [ Upstream commit 2c0c19b681d5a331b53aab0d170f72a87c7bff12 ] savagefb and some other drivers call kfree to free 'info->pixmap.addr' even after calling unregister_framebuffer, which may cause double free. Fix this by setting 'fb_info->pixmap.addr' to NULL after kfree in unregister

[PATCH AUTOSEL 5.15 08/65] drm/virtio: fix the missed drm_gem_object_put() in virtio_gpu_user_framebuffer_create()

2021-11-16 Thread Sasha Levin
From: Jing Xiangfeng [ Upstream commit a63f393dd7e1ebee707c9dee1d197fdc33d6486b ] virtio_gpu_user_framebuffer_create() misses to call drm_gem_object_put() in an error path. Add the missed function call to fix it. Signed-off-by: Jing Xiangfeng Link: http://patchwork.freedesktop.org/patch/msgid

[PATCH AUTOSEL 5.15 03/65] backlight: Propagate errors from get_brightness()

2021-11-16 Thread Sasha Levin
From: Thomas Weißschuh [ Upstream commit 563edf85ce18a90dd0a7b39e279a691d937205f6 ] backlight.h documents "struct backlight_ops->get_brightness()" to return a negative errno on failure. So far these errors have not been handled in the backlight core. This leads to negative values being exposed

  1   2   >