Clang static analysis reports this error
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2870:7: warning:
Dereference of null pointer [clang-analyzer-core.NullDereference]
if
(top_pipe_to_program->stream_res.tg->funcs->lock_doublebuffer_enable) {
^
top_pipe_
On Mon, Nov 15, 2021 at 7:33 AM Randy Dunlap wrote:
> Fix fallthrough warnings in sh776fb.c:
>
> ../drivers/video/fbdev/sh7760fb.c: In function 'sh7760fb_get_color_info':
> ../drivers/video/fbdev/sh7760fb.c:138:23: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> 138 |
On 2021-11-15 07:41, Lang Yu wrote:
> On Fri, Nov 12, 2021 at 05:10:27PM +0100, Michel DDDnzer wrote:
>> On 2021-11-12 16:03, Christian König wrote:
>>> Am 12.11.21 um 15:30 schrieb Michel Dänzer:
On 2021-11-12 15:29, Michel Dänzer wrote:
> On 2021-11-12 13:47, Christian König wrote:
>
From: Arnd Bergmann
I recently came across some new uses of the 'slave_id' field that
I had (almost) removed a few years ago. There are no legitimate
uses of this field in the kernel, only a few stale references and
two drivers that abuse the field as a side-channel between the
dmaengine driver a
From: Arnd Bergmann
This field is never set, and serves no purpose, so remove it.
Signed-off-by: Arnd Bergmann
---
include/sound/dmaengine_pcm.h | 2 --
sound/core/pcm_dmaengine.c | 5 ++---
sound/soc/tegra/tegra20_spdif.c | 1 -
3 files changed, 2 insertions(+), 6 deletions(-)
diff --
From: Arnd Bergmann
Setting slave_id makes no sense with DT based probing, and
should eventually get removed entirely. Address this driver
by no longer setting the field here.
I could not find which DMA driver is used on PIC32, if it's
in the tree at all, but none of the obvious ones even care
a
From: Arnd Bergmann
The field is not interpreted by the DMA engine driver, as all the data
is passed from devicetree instead. Remove the assignment so the field
can eventually be deleted.
Signed-off-by: Arnd Bergmann
---
drivers/mmc/host/bcm2835.c | 2 --
1 file changed, 2 deletions(-)
diff -
From: Arnd Bergmann
The slave device is picked through either devicetree or a filter
function, and any remaining out-of-tree drivers would have warned
about this usage since 2015.
Stop interpreting the field finally so it can be removed from
the interface.
Signed-off-by: Arnd Bergmann
---
dri
From: Arnd Bergmann
The last driver referencing the slave_id on Marvell PXA and MMP platforms
was the SPI driver, but this stopped doing so a long time ago, so the
TODO from the earlier patch can no be removed.
Fixes: b729bf34535e ("spi/pxa2xx: Don't use slave_id of dma_slave_config")
Fixes: 13b
From: Arnd Bergmann
It appears that the code that reads the slave_id from the channel config
was copied incorrectly from other drivers. Nothing ever sets this field
on platforms that use this driver, so remove the reference.
Signed-off-by: Arnd Bergmann
---
drivers/dma/sprd-dma.c | 3 ---
1 fi
From: Arnd Bergmann
The slave_id was previously used to pick one DMA slave instead of another,
but this is now done through the DMA descriptors in device tree.
For the qcom_adm driver, the configuration is documented in the DT
binding to contain a tuple of device identifier and a "crci" field,
b
From: Arnd Bergmann
The display driver wants to pass a custom flag to the DMA engine driver,
which it started doing by using the slave_id field that was traditionally
used for a different purpose.
As there is no longer a correct use for the slave_id field, it should
really be removed, and the re
From: Arnd Bergmann
Nothing sets the slave_id field any more, so stop accessing
it to allow the removal of this field.
Signed-off-by: Arnd Bergmann
---
drivers/dma/tegra20-apb-dma.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb
From: Arnd Bergmann
Picking the connection between a DMA controller and its attached device
is done through devicetree using the "dmas" property, which is implemented
by the gdma driver, but it also allows overriding the "req" configuration
with the slave_id field, as it was done in some linux-2.
From: Arnd Bergmann
All references to the slave_id field have been removed, so
remove the field as well to prevent new references from
creeping in again.
Signed-off-by: Arnd Bergmann
---
include/linux/dmaengine.h | 4
1 file changed, 4 deletions(-)
diff --git a/include/linux/dmaengine.h
Hi Arnd,
Thank you for the patch.
On Mon, Nov 15, 2021 at 09:53:56AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The slave device is picked through either devicetree or a filter
> function, and any remaining out-of-tree drivers would have warned
> about this usage since 2015.
>
> Sto
Hi Arnd,
Thank you for the patch.
On Mon, Nov 15, 2021 at 09:54:00AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The display driver wants to pass a custom flag to the DMA engine driver,
> which it started doing by using the slave_id field that was traditionally
> used for a different
On Thursday, November 11th, 2021 at 13:50, Ville Syrjälä
wrote:
> On Thu, Nov 11, 2021 at 10:10:54AM +, Simon Ser wrote:
> > User-space shouldn't look up the modifier array when the modifier
> > flag is missing, but at the moment no docs make this clear (working
> > on it). Right now the mod
Hi Arnd,
Thank you for the patch.
On Mon, Nov 15, 2021 at 09:54:03AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> All references to the slave_id field have been removed, so
> remove the field as well to prevent new references from
> creeping in again.
A rationale to explain why the sl
On 2021-11-15 10:04, Lang Yu wrote:
> On Mon, Nov 15, 2021 at 09:38:47AM +0100, Michel DDDnzer wrote:
>> On 2021-11-15 07:41, Lang Yu wrote:
>>> On Fri, Nov 12, 2021 at 05:10:27PM +0100, Michel DDDnzer wrote:
On 2021-11-12 16:03, Christian König wrote:
> Am 12.11.21 um 15:30 schrieb Michel
Signed-off-by: Bhanuprakash Modem
---
include/drm-uapi/drm.h | 10 ++
include/drm-uapi/drm_mode.h | 28
2 files changed, 38 insertions(+)
diff --git a/include/drm-uapi/drm.h b/include/drm-uapi/drm.h
index 5e54c3aa4c..9ca3dbe8e5 100644
--- a/include/drm-u
>From the Plane Color Management feature design, userspace can
take the smart blending decisions based on hardware supported
plane color features to obtain an accurate color profile.
These IGT patches extend the existing pipe color management
tests to the plane level.
Kernel implementation:
https
Add support for Plane color management properties.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Bhanuprakash Modem
---
lib/igt_kms.c | 5 +
lib/igt_kms.h | 5 +
2 files changed, 10 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.
To verify Plane gamma, draw 3 gradient rectangles in red, green and blue,
with a maxed out gamma LUT and verify we have the same CRC as drawing solid
color rectangles.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Bhanuprakash Modem
---
tests/kms
Add helper functions to support Plane color management properties.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Bhanuprakash Modem
---
tests/kms_color_helper.c | 173 +++
tests/kms_color_helper.h | 29 +++
To verify Plane degamma, draw 3 gradient rectangles in red, green and blue,
with a maxed out degamma LUT and verify we have the same CRC as drawing solid
color rectangles without degamma.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Bhanuprakash M
Negative check for:
* plane gamma lut sizes
* plane degamma lut sizes
* plane ctm matrix sizes
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Bhanuprakash Modem
---
tests/kms_color.c | 127 ++
1 file
To verify plane CTM, draw 3 rectangles using before colors with the
ctm matrix applied and verify the CRC is equal to using after colors
with an identify ctm matrix.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Bhanuprakash Modem
---
tests/kms_c
To verify Plane gamma, draw 3 gradient rectangles in red, green and blue,
with a maxed out gamma LUT and verify we have the same frame dump as
drawing solid color rectangles.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Cc: Kunal Joshi
Signed-off-by: Bhanupraka
To verify Plane degamma, draw 3 gradient rectangles in red, green and blue,
with a maxed out degamma LUT and verify we have the same frame dump as
drawing solid color rectangles with linear gamma LUT.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Cc: Kunal Joshi
To verify plane CTM, draw 3 rectangles using before colors with the
ctm matrix applied and verify the frame dump is equal to using after
colors with an identify ctm matrix.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Cc: Kunal Joshi
Signed-off-by: Bhanuprakash
From: Mukunda Pramodh Kumar
Add helper functions to support logarithmic gamma mode
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Mukunda Pramodh Kumar
Signed-off-by: Bhanuprakash Modem
---
tests/kms_color_helper.c | 127 +++
From: Mukunda Pramodh Kumar
Add support for Pipe color management properties.
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Mukunda Pramodh Kumar
Signed-off-by: Bhanuprakash Modem
---
lib/igt_kms.c | 1 +
lib/igt_kms.h | 1 +
2 files changed,
From: Mukunda Pramodh Kumar
Extended IGT tests to support logarithmic gamma mode on pipe
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Uma Shankar
Signed-off-by: Mukunda Pramodh Kumar
Signed-off-by: Bhanuprakash Modem
---
tests/kms_color.c | 19 +++
1 fi
Extended IGT tests to support logarithmic gamma mode on pipe
Cc: Harry Wentland
Cc: Ville Syrjälä
Cc: Juha-Pekka Heikkila
Cc: Kunal Joshi
Cc: Uma Shankar
Signed-off-by: Mukunda Pramodh Kumar
Signed-off-by: Bhanuprakash Modem
---
tests/kms_color_chamelium.c | 40
On Mon, 8 Nov 2021 22:23:51 -0500, Julian Braha wrote:
> When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER
> is not selected, Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY
> Depends on [n]: (ARCH_SUNXI [=n] || COMPILE_TEST [=
On Mon, 2021-11-15 at 09:53 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The field is not interpreted by the DMA engine driver, as all the data
> is passed from devicetree instead. Remove the assignment so the field
> can eventually be deleted.
>
> Signed-off-by: Arnd Bergmann
> ---
R
https://bugzilla.kernel.org/show_bug.cgi?id=215025
--- Comment #3 from Bjoern Franke (b...@nord-west.org) ---
mainline 5.16rc1 is also affected.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
Enable runtime pm autosuspend by default
Signed-off-by: Tilak Tangudu
Tilak Tangudu (1):
drm/i915/rpm: Enable runtime pm autosuspend by default
drivers/gpu/drm/i915/intel_runtime_pm.c | 4
1 file changed, 4 insertions(+)
--
2.25.1
Enable runtime pm autosuspend by default.
Signed-off-by: Tilak Tangudu
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
b/drivers/gpu/drm/i915/intel_runtime_pm.c
index eaf7688f517d..ef75f24288ef 100644
--
Hi,
On Wed, Nov 10, 2021 at 02:06:23PM +0100, Guillaume Ranquet wrote:
> From: Markus Schneider-Pargmann
>
> This patch adds a DisplayPort driver for the Mediatek mt8195 SoC and a
> according phy driver mediatek-dp-phy.
>
> It supports both functional units on the mt8195, the embedded
> Display
https://bugzilla.kernel.org/show_bug.cgi?id=215025
--- Comment #4 from Bjoern Franke (b...@nord-west.org) ---
It seems it is https://gitlab.freedesktop.org/drm/amd/-/issues/1789
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee o
On Mon, Nov 15, 2021 at 10:14 AM Laurent Pinchart
wrote:
> On Mon, Nov 15, 2021 at 09:54:00AM +0100, Arnd Bergmann wrote:
> > @@ -1285,11 +1287,13 @@ static int xilinx_dpdma_config(struct dma_chan
> > *dchan,
> > spin_lock_irqsave(&chan->lock, flags);
> >
> > /*
> > - * Abuse the
On Sat, 13 Nov 2021, Claudio Suarez wrote:
> The prefered way to log connectors is [CONNECTOR:id:name]. Change it in
> drm core programs.
>
> Suggested-by: Ville Syrjälä
> Signed-off-by: Claudio Suarez
> ---
> drivers/gpu/drm/drm_client_modeset.c | 51 ++--
> drivers/gpu
On Mon, Nov 15, 2021 at 10:55 AM Sergio Paracuellos
wrote:
> On Mon, Nov 15, 2021 at 9:55 AM Arnd Bergmann wrote:
> > ---
> > drivers/staging/ralink-gdma/ralink-gdma.c | 12 +---
> > 1 file changed, 5 insertions(+), 7 deletions(-)
>
> This driver has been already deleted from the staging
On Sun, 14 Nov 2021, Claudio Suarez wrote:
> On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote:
>> Hi Claudio,
>>
>> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote:
>> > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in
>> > drm core programs.
>> >
From: Jackie Liu
Nobody care about drm_enc on dpu_encoder_setup, cleanup.
[...]
*** CID 1493979: Possible Control flow issues (DEADCODE)
/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: 2186 in dpu_encoder_setup()
2180
2181return ret;
2182
2183 fail:
2184DPU_ERROR("fai
On Monday, November 15th, 2021 at 11:22, Jani Nikula
wrote:
> - Adding drm_dbg_connector() which would take drm_connector as context,
> and do drm_dbg_kms() with the above prefix.
This wouldn't work great in case multiple connectors/planes/etc are involved,
or when drm_dbg_atomic() is used.
Enable runtime pm autosuspend by default for all
platforms
Signed-off-by: Tilak Tangudu
Tilak Tangudu (1):
drm/i915/rpm: Enable runtime pm autosuspend by default
drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++
1 file changed, 3 insertions(+)
--
2.25.1
v1: Enable runtime pm autosuspend by default for Gen12
and later versions.
v2: Enable runtime pm autosuspend by default for all
platforms(Syrjala Ville)
Signed-off-by: Tilak Tangudu
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/dr
On 12/11/2021 17:59, Matthew Brost wrote:
On Fri, Nov 12, 2021 at 02:13:50PM +, Tvrtko Ursulin wrote:
On 11/11/2021 16:49, Matthew Brost wrote:
On Mon, Nov 01, 2021 at 10:35:09AM +, Tvrtko Ursulin wrote:
On 27/10/2021 21:10, Matthew Brost wrote:
On Wed, Oct 27, 2021 at 01:04:49PM
On Mon, 15 Nov 2021, Simon Ser wrote:
> On Monday, November 15th, 2021 at 11:22, Jani Nikula
> wrote:
>
>> - Adding drm_dbg_connector() which would take drm_connector as context,
>> and do drm_dbg_kms() with the above prefix.
>
> This wouldn't work great in case multiple connectors/planes/etc
On Mon, Nov 15, 2021 at 11:14 AM Lars-Peter Clausen wrote:
>
> On 11/15/21 9:53 AM, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > This field is never set, and serves no purpose, so remove it.
>
> I agree that we should remove it. Its been legacy support code for a
> while, but the descript
On 14/11/2021 11:12, Thomas Hellström wrote:
Move the i915_gem_obj_copy_ttm() function to i915_gem_ttm_move.h.
This will help keep a number of functions static when introducing
async moves.
Signed-off-by: Thomas Hellström
Reviewed-by: Matthew Auld
On 11/15/21 9:53 AM, Arnd Bergmann wrote:
From: Arnd Bergmann
This field is never set, and serves no purpose, so remove it.
I agree that we should remove it. Its been legacy support code for a
while, but the description that there is no user is not right.
The tegra20_spdif driver obviously
On 14/11/2021 11:12, Thomas Hellström wrote:
There is an interesting refcounting loop:
struct intel_memory_region has a struct ttm_resource_manager,
ttm_resource_manager->move may hold a reference to i915_request,
i915_request may hold a reference to intel_context,
intel_context may hold a refere
On Fri, 12 Nov 2021, Lyude Paul wrote:
> While working on supporting the Intel HDR backlight interface, I noticed
> that there's a couple of laptops that will very rarely manage to boot up
> without detecting Intel HDR backlight support - even though it's supported
> on the system. One example of
On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote:
> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote:
> > We have already few similar implementation and a lot of code that can
> > benefit
> > of the yesno() helper. Consolidate yesno() helpers under string.h hood.
>
On Fri, Nov 12, 2021 at 10:43:37PM +0100, Marijn Suijten wrote:
> On 2021-11-12 13:35:03, Marijn Suijten wrote:
> > On 2021-11-12 12:08:39, Daniel Thompson wrote:
> > > On Fri, Nov 12, 2021 at 01:26:57AM +0100, Marijn Suijten wrote:
> > > > When not specifying num-strings in the DT the default is u
Hi,
The conversion to DRM commit helpers (f3c420fe19f8, "drm/vc4: kms: Convert to
atomic helpers") introduced a number of issues in corner cases, most of them
showing themselves in the form of either a vblank timeout or use-after-free
error.
These patches should fix most of them, some of them sti
The HVS global state functions return an error pointer, but in most
cases we check if it's NULL, possibly resulting in an invalid pointer
dereference.
Fixes: 9ec03d7f1ed3 ("drm/vc4: kms: Wait on previous FIFO users before a
commit")
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/vc4/vc4_kms.c
Several DRM/KMS atomic commits can run in parallel if they affect
different CRTC. These commits share the global HVS state, so we have
some code to make sure we run commits in sequence. This synchronization
code is one of the first thing that runs in vc4_atomic_commit_tail().
Another constraints w
Commit 9ec03d7f1ed3 ("drm/vc4: kms: Wait on previous FIFO users before a
commit") introduced a global state for the HVS, with each FIFO storing
the current CRTC commit so that we can properly synchronize commits.
However, the refcounting was off and we thus ended up leaking the
drm_crtc_commit str
Commit 9ec03d7f1ed3 ("drm/vc4: kms: Wait on previous FIFO users before a
commit") introduced a wait on the previous commit done on a given HVS
FIFO.
However, we never cleared that pointer once done. Since
drm_crtc_commit_put can free the drm_crtc_commit structure directly if
we were the last user,
Our HVS global state, when duplicated, will also copy the pointer to the
drm_crtc_commit (and increase the reference count) for each FIFO if the
pointer is not NULL.
However, our atomic_setup function will overwrite that pointer without
putting the reference back leading to a memory leak.
Since t
Our current code is supposed to serialise the commits by waiting for all
the drm_crtc_commits associated to the previous HVS state.
However, assuming we have two CRTCs running and being configured and we
configure each one alternatively, we end up in a situation where we're
not waiting at all.
In
Hi,
On Fri, Nov 12, 2021 at 11:22:49AM +0800, Jian-Hong Pan wrote:
> Hi,
>
> I tested Linux mainline kernel 5.15 (aarch64) with enabled VC4 on RPi 4B. I
> notice UI freezes a while (about 10 seconds) some times.
>
> The kernel shows the error message during the time:
>
> [drm:drm_crtc_commit_wa
On Wed, Nov 10, 2021 at 05:39:33PM +0100, Thomas Zimmermann wrote:
> Am 10.11.21 um 17:34 schrieb Andy Shevchenko:
> > On Wed, Nov 10, 2021 at 3:55 PM Thomas Zimmermann
> > wrote:
> > > Am 10.11.21 um 11:24 schrieb Andy Shevchenko:
...
> > > > +#include
> > >
> > > I built this patch on a rec
On Sun, Nov 14, 2021 at 07:39:25PM -0800, Randy Dunlap wrote:
> Convert function-like macro comments to kernel-doc notation and
> fix other kernel-doc warnings:
>
> drivers/video/backlight/ili922x.c:85: warning: This comment starts with
> '/**', but isn't a kernel-doc comment. Refer
> Documentat
Am 13.11.21 um 07:22 schrieb Jianqun Xu:
Add DMA_BUF_IOCTL_SYNC_PARTIAL support for user to sync dma-buf with
offset and len.
You have not given an use case for this so it is a bit hard to review.
And from the existing use cases I don't see why this should be necessary.
Even worse from the e
On Mon, 15 Nov 2021, Andy Shevchenko wrote:
> On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote:
>> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote:
>> > We have already few similar implementation and a lot of code that can
>> > benefit
>> > of the yesno() helper. C
On Mon, 15 Nov 2021, Tilak Tangudu wrote:
The actual commit message with explanations why it will work now and
didn't work before go here. Just the changelog will not be enough.
BR,
Jani.
> v1: Enable runtime pm autosuspend by default for Gen12
> and later versions.
>
> v2: Enable runtime pm a
Am 15.11.21 um 08:07 schrieb Bernard Zhao:
This change is to cleanup the code style a bit.
To be honest I think the old style looked better. It took me a moment to
validate this now.
What you could to instead is to have goto style error handling which
would make this a bit more cleaner I th
Hi Arnd,
On Mon, Nov 15, 2021 at 11:21:30AM +0100, Arnd Bergmann wrote:
> On Mon, Nov 15, 2021 at 10:14 AM Laurent Pinchart wrote:
> > On Mon, Nov 15, 2021 at 09:54:00AM +0100, Arnd Bergmann wrote:
> > > @@ -1285,11 +1287,13 @@ static int xilinx_dpdma_config(struct dma_chan
> > > *dchan,
> > >
Took Andy's patch [1] and expanded on it a bit.
BR,
Jani.
[1]
https://patchwork.freedesktop.org/patch/msgid/2020102857.59604-1-andriy.shevche...@linux.intel.com
Cc: Andy Shevchenko
Andy Shevchenko (1):
agp/intel-gtt: Replace kernel.h with the necessary inclusions
Jani Nikula (2):
dr
Only intel_gt.c and intel_ggtt.c need the interface.
Cc: Andy Shevchenko
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 +
drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++
drivers/gpu/drm/i915/i915_drv.h | 1 -
3 files changed, 3 insertions(+), 1 deletion(-)
diff --gi
From: Andy Shevchenko
When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko
Signed-off-by: Jani Nikula
---
in
Don't include stuff on behalf of users if they're not strictly necessary
for the header.
Cc: Andy Shevchenko
Signed-off-by: Jani Nikula
---
drivers/char/agp/intel-gtt.c | 1 +
drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 +
include/drm/intel-gtt.h | 3 +--
3 files changed, 3 in
On Mon, 15 Nov 2021, Jani Nikula wrote:
> Took Andy's patch [1] and expanded on it a bit.
>
> BR,
> Jani.
>
>
> [1]
> https://patchwork.freedesktop.org/patch/msgid/2020102857.59604-1-andriy.shevche...@linux.intel.com
>
> Cc: Andy Shevchenko
>
> Andy Shevchenko (1):
> agp/intel-gtt: Replace
Restructure the header file for CMA helpers by moving declarations
for driver and file operations to the end of the file. No functional
changes.
Signed-off-by: Thomas Zimmermann
---
include/drm/drm_gem_cma_helper.h | 114 ---
1 file changed, 60 insertions(+), 54 delet
Convert GEM CMA functions to accept struct drm_gem_cma_object, provide
small wrappers for GEM object callbacks and update all users. Brings
up the interface to the pattern used in SHMEM and VRAM helpers.
Converting all GEM object functions to use drm_gem_cma_object enables
type checking by the C c
Wrap GEM CMA functions for struct drm_gem_object_funcs and update
all callers. This will allow for an update of the public interfaces
of the GEM CMA helper library.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_gem_cma_helper.c | 23
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 1
Change all GEM CMA object functions that receive a GEM object
of type struct drm_gem_object to expect an object of type
struct drm_gem_cma_object instead.
This change reduces the number of upcasts from struct drm_gem_object
by moving them into callers. The C compiler can now verify that the
GEM CM
-邮件原件-
发件人: bern...@vivo.com 代表 Christian K?nig
发送时间: 2021年11月15日 19:49
收件人: 赵军奎 ; Alex Deucher ;
Christian König ; Pan, Xinhui ;
David Airlie ; Daniel Vetter ; Jingwen Chen
; Candice Li ; John Clements
; Monk liu ; Peng Ju Zhou
; Jiawei Gu ; Bokun Zhang
; Zhigang Luo ; Lee Jones
;
On 2021-11-15 12:31, Lang Yu wrote:
> On Mon, Nov 15, 2021 at 10:49:39AM +0100, Michel DDDnzer wrote:
>> On 2021-11-15 10:04, Lang Yu wrote:
>>> On Mon, Nov 15, 2021 at 09:38:47AM +0100, Michel DDDnzer wrote:
On 2021-11-15 07:41, Lang Yu wrote:
> On Fri, Nov 12, 2021 at 05:10:27PM +0100, M
This change is to cleanup the code style a bit.
Signed-off-by: Bernard Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
On Thursday, November 11th, 2021 at 12:50, Daniel Stone
wrote:
> In fairness it is perfectly clear, it's just that I never considered
> calling it without master/admin because why would you ever do that?
FWIW, drm_info does it to display the current buffers metadata. Pretty
useful when debuggin
On 11/15/21 11:42 AM, Arnd Bergmann wrote:
On Mon, Nov 15, 2021 at 11:14 AM Lars-Peter Clausen wrote:
On 11/15/21 9:53 AM, Arnd Bergmann wrote:
From: Arnd Bergmann
This field is never set, and serves no purpose, so remove it.
I agree that we should remove it. Its been legacy support code fo
On Mon, Nov 08, 2021 at 07:55:00PM +0200, Ville Syrjälä wrote:
> On Mon, Nov 08, 2021 at 04:58:34PM +0100, Maxime Ripard wrote:
> > On Fri, Nov 05, 2021 at 08:14:04PM +0200, Ville Syrjälä wrote:
> > > On Fri, Nov 05, 2021 at 07:02:30PM +0100, Daniel Vetter wrote:
> > > > On Thu, Nov 04, 2021 at 05:
On 14/11/2021 11:12, Thomas Hellström wrote:
From: Maarten Lankhorst
For now, we will only allow async migration when TTM is used,
so the paths we care about are related to TTM.
The mmap path is handled by having the fence in ttm_bo->moving,
when pinning, the binding only becomes available aft
On Mon, Nov 15, 2021 at 12:49 PM Laurent Pinchart
wrote:
> On Mon, Nov 15, 2021 at 11:21:30AM +0100, Arnd Bergmann wrote:
> > On Mon, Nov 15, 2021 at 10:14 AM Laurent Pinchart wrote:
> > > On Mon, Nov 15, 2021 at 09:54:00AM +0100, Arnd Bergmann wrote:
> > > > @@ -1285,11 +1287,13 @@ static int xil
On 14/11/2021 11:12, Thomas Hellström wrote:
From: Maarten Lankhorst
We want to get rid of i915_vma tracking to simplify the code and
lifetimes. Add a way to set/put the moving fence, in preparation for
removing the tracking.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/gem/i91
On 11/15/21 13:36, Matthew Auld wrote:
On 14/11/2021 11:12, Thomas Hellström wrote:
From: Maarten Lankhorst
For now, we will only allow async migration when TTM is used,
so the paths we care about are related to TTM.
The mmap path is handled by having the fence in ttm_bo->moving,
when pinni
On 11/15/21 13:39, Matthew Auld wrote:
On 14/11/2021 11:12, Thomas Hellström wrote:
From: Maarten Lankhorst
We want to get rid of i915_vma tracking to simplify the code and
lifetimes. Add a way to set/put the moving fence, in preparation for
removing the tracking.
Signed-off-by: Maarten Lan
Clean up the last non-legacy users of DRM's hashtable code and put
the code behind CONFIG_DRM_LEGACY.
TTM only includes the header file, but does not use the hashtable.
The vmwgfx driver uses the hashtable internally. Copy the DRM code
into the driver. A later patchset should probably update vmwgf
Besides some legacy code, vmwgfx is the only user of DRM's hash-
table implementation. Copy the code into the driver, so that the
core code can be retired.
No functional changes. However, the real solution for vmwgfx is to
use Linux' generic hash-table functions.
Signed-off-by: Thomas Zimmermann
Remove the include statement for drm_hashtab.h. It's not required
by TTM.
Signed-off-by: Thomas Zimmermann
---
include/drm/ttm/ttm_bo_api.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h
index cd785cfa3123..c17b2df9178b 100644
--- a
The DRM hashtable code is only used by internal functions for legacy
UMS drivers. Move the implementation behind CONFIG_DRM_LEGACY and the
declarations into legacy header files. Unexport the symbols.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/Makefile | 6 +--
drivers/gpu/drm/drm
Hi Arnd,
On Mon, Nov 15, 2021 at 01:38:07PM +0100, Arnd Bergmann wrote:
> On Mon, Nov 15, 2021 at 12:49 PM Laurent Pinchart wrote:
> > On Mon, Nov 15, 2021 at 11:21:30AM +0100, Arnd Bergmann wrote:
> > > On Mon, Nov 15, 2021 at 10:14 AM Laurent Pinchart wrote:
> > > > On Mon, Nov 15, 2021 at 09:54
On Mon, 15 Nov 2021 at 09:55, Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> The field is not interpreted by the DMA engine driver, as all the data
> is passed from devicetree instead. Remove the assignment so the field
> can eventually be deleted.
>
> Signed-off-by: Arnd Bergmann
Acked-by: U
1 - 100 of 270 matches
Mail list logo
