Re: [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects

2021-11-08 Thread Thomas Hellström
On 11/5/21 16:18, Matthew Auld wrote: On 05/11/2021 13:03, Thomas Hellström wrote: Gem-TTM objects that are backed by shmem might have populated page-vectors without having the Gem pages set. Those objects aren't moved to the correct shrinker / purge list by the gem_madvise. Furthermore they a

Re: [PATCH/RFT] fbdev driver for HP Visualize FX cards

2021-11-08 Thread Thomas Zimmermann
Hi Am 06.11.21 um 22:02 schrieb Sven Schnelle: Thomas Zimmermann writes: Hi Am 01.11.21 um 09:54 schrieb Sven Schnelle: Hi Thomas, Thomas Zimmermann writes: Thanks, i wasn't aware as i normally don't do any graphics related development. I take a look at dri and port the driver, which is ho

Re: [PATCH] drm/i915/gem: Fix gem_madvise for ttm+shmem objects

2021-11-08 Thread Thomas Hellström
On 11/8/21 09:08, Thomas Hellström wrote: On 11/5/21 16:18, Matthew Auld wrote: On 05/11/2021 13:03, Thomas Hellström wrote: Gem-TTM objects that are backed by shmem might have populated page-vectors without having the Gem pages set. Those objects aren't moved to the correct shrinker / purge

Re: [PATCH v2 1/9] drm/format-helper: Export drm_fb_clip_offset()

2021-11-08 Thread Thomas Zimmermann
Hi Am 05.11.21 um 21:48 schrieb Noralf Trønnes: Den 01.11.2021 15.15, skrev Thomas Zimmermann: Provide a function that computes the offset into a blit destination buffer. This will allow to move destination-buffer clipping into the format-helper callers. v2: * provide documentation (

Re: [PATCH v2] drm: fsl-dcu: enable PIXCLK on LS1021A

2021-11-08 Thread Matthias Schiffer
On Tue, 2021-10-05 at 16:10 +0200, Matthias Schiffer wrote: > The PIXCLK needs to be enabled in SCFG before accessing the DCU on LS1021A, > or the access will hang. > > Signed-off-by: Matthias Schiffer Hi, what is the status of this patch? I found it "archived" in the dri- devel patchwork, shoul

[PATCH v2 1/3] drm/shmem-helper: Unexport drm_gem_shmem_create_with_handle()

2021-11-08 Thread Thomas Zimmermann
Turn drm_gem_shmem_create_with_handle() into an internal helper function. It's not used outside of the compilation unit. Signed-off-by: Thomas Zimmermann Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_gem_shmem_helper.c | 3 +-- include/drm/drm_gem_shmem_helper.h | 5 - 2 files changed

[PATCH v2 0/3] drm/shmem-helper: Cleanup public interface

2021-11-08 Thread Thomas Zimmermann
The interface of GEM SHMEM helpers inconsistently uses either struct drm_gem_object or drm_gem_shmem_object for the GEM object. Convert GEM SHMEM functions to accept struct drm_gem_shmem_object, provide small wrappers for GEM object callbacks and update all users. Converting all GEM object functio

[PATCH v2 2/3] drm/shmem-helper: Export dedicated wrappers for GEM object functions

2021-11-08 Thread Thomas Zimmermann
Wrap GEM SHMEM functions for struct drm_gem_object_funcs and update all callers. This will allow for an update of the public interfaces of the GEM SHMEM helper library. v2: * fix docs for drm_gem_shmem_object_print_info() Signed-off-by: Thomas Zimmermann Acked-by: Daniel Vetter --- dri

[PATCH v2 3/3] drm/shmem-helper: Pass GEM shmem object in public interfaces

2021-11-08 Thread Thomas Zimmermann
Change all GEM SHMEM object functions that receive a GEM object of type struct drm_gem_object to expect an object of type struct drm_gem_shmem_object instead. This change reduces the number of upcasts from struct drm_gem_object by moving them into callers. The C compiler can now verify that the GE

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread Paul Cercueil
Hi Nikolaus, Le dim., nov. 7 2021 at 21:25:38 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 07.11.2021 um 20:01 schrieb Paul Cercueil : Hi Nikolaus, Le dim., nov. 7 2021 at 14:41:18 +0100, H. Nikolaus Schaller a écrit : Hi Paul, sorry for the delay in getting back to this, but

Re: [RFC v2 02/22] drm: Add Enhanced Gamma and color lut range attributes

2021-11-08 Thread Pekka Paalanen
On Thu, 4 Nov 2021 12:27:56 -0400 Harry Wentland wrote: > On 2021-11-04 04:38, Pekka Paalanen wrote: > > On Wed, 3 Nov 2021 11:08:13 -0400 > > Harry Wentland wrote: > > > >> On 2021-09-06 17:38, Uma Shankar wrote: > >>> Existing LUT precision structure is having only 16 bit > >>> precision.

[RESEND PATCH 0/3] drm/{exynos, xen}: Implement gem_prime_mmap with drm_gem_prime_mmap()

2021-11-08 Thread Thomas Zimmermann
(Resending the patchset from [1]. Most drivers have already been updated and only two drivers are left.) Replace all remaining implementations of struct drm_driver.gem_prime_mmap with use drm_gem_prime_mmap(). For each affected driver, put the mmap code into struct drm_gem_object_funcs.mmap. With

[PATCH 1/3] drm/exynox: Implement mmap as GEM object function

2021-11-08 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective exynos functions are being removed. The file_operations structure exynos_drm_driver_fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-o

[PATCH 2/3] drm/xen: Implement mmap as GEM object function

2021-11-08 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective xen functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zimmerm

[PATCH 3/3] drm: Update documentation and TODO of gem_prime_mmap hook

2021-11-08 Thread Thomas Zimmermann
The hook gem_prime_mmap in struct drm_driver is deprecated. Document the new requirements. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst | 11 --- include/drm/drm_drv.h | 11 +++ 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/Documentation/

Re: [PATCH v2 0/8] Host1x context isolation support

2021-11-08 Thread Mikko Perttunen
On 9/16/21 5:32 PM, Mikko Perttunen wrote: Hi all, *** New in v2: Added support for Tegra194 Use standard iommu-map property instead of custom mechanism *** this series adds support for Host1x 'context isolation'. Since when programming engines through Host1x, userspace can program in any addr

Re: [PATCH 2/3] drm/xen: Implement mmap as GEM object function

2021-11-08 Thread Oleksandr Andrushchenko
Hi, Thomas! On 08.11.21 12:28, Thomas Zimmermann wrote: > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > The respective xen functions are being removed. The file_operations > structure fops is now being created by the

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread H. Nikolaus Schaller
Hi Paul, >> Am 08.11.2021 um 10:37 schrieb Paul Cercueil : >> >> Well, it was atomic: "add jz4780+hdmi functionality" or not. Now we separate >> into "preparation for adding jz4780" and "really adding". Yes, you can split >> atoms into quarks... > > And that's how it should be done. Lots of sm

Re: [PATCH v10, 4/5] soc: mediatek: add mtk mutex support for MT8192

2021-11-08 Thread yongqiang . niu
On Fri, 2021-10-08 at 13:27 +0200, Matthias Brugger wrote: > > On 30/09/2021 17:52, Yongqiang Niu wrote: > > Add mtk mutex support for MT8192 SoC. > > > > Signed-off-by: Yongqiang Niu > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: CK Hu > > Applied to v5.15-next/soc > > Thanks! please hel

Re: [PATCH v2 6/6] drm/ttm: Clarify that the TTM_PL_SYSTEM buffers need to stay idle

2021-11-08 Thread Christian König
Am 05.11.21 um 20:38 schrieb Zack Rusin: TTM was designed to allow TTM_PL_SYSTEM buffer to be fenced but over the years the code that was meant to handle it was broken and new changes can not deal with buffers which have been placed in TTM_PL_SYSTEM buf do not remain idle. CPU buffers which need

Re: [PATCH 2/3] drm/xen: Implement mmap as GEM object function

2021-11-08 Thread Thomas Zimmermann
Hi Am 08.11.21 um 11:46 schrieb Oleksandr Andrushchenko: Hi, Thomas! On 08.11.21 12:28, Thomas Zimmermann wrote: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective xen functions are being removed. The file_op

[PATCH v3 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-08 Thread Javier Martinez Canillas
There is a lot of historical baggage on this parameter. It is defined in the vgacon driver as nomodeset, but its set function is called text_mode() and the value queried with a function named vgacon_text_force(). All this implies that it's about forcing text mode for VGA, yet it is not used in nei

[PATCH v3 1/6] drm: Don't print messages if drivers are disabled due nomodeset

2021-11-08 Thread Javier Martinez Canillas
The nomodeset kernel parameter handler already prints a message that the DRM drivers will be disabled, so there's no need for drivers to do that. Suggested-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +---

[PATCH v3 2/6] drm/vboxvideo: Drop CONFIG_VGA_CONSOLE guard to call vgacon_text_force()

2021-11-08 Thread Javier Martinez Canillas
It is already handled by the console.h macro since a stub inline function is defined for vgacon_text_force() if CONFIG_VGA_CONSOLE is not set. There's no need to have ifdefery in the driver when calling the function. Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gp

[PATCH v3 4/6] drm: Decouple nomodeset from CONFIG_VGA_CONSOLE

2021-11-08 Thread Javier Martinez Canillas
This relationship was only for historical reasons and the nomodeset option should be available even on platforms that don't enable CONFIG_VGA_CONSOLE. Suggested-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/Kconfig | 6 ++ dr

[PATCH v3 3/6] drm: Move nomodeset kernel parameter to the DRM subsystem

2021-11-08 Thread Javier Martinez Canillas
The "nomodeset" kernel cmdline parameter is handled by the vgacon driver but the exported vgacon_text_force() symbol is only used by DRM drivers. It makes much more sense for the parameter logic to be in the subsystem of the drivers that are making use of it. Let's move the vgacon_text_force() fu

[PATCH v3 5/6] Documentation/admin-guide: Document nomodeset kernel parameter

2021-11-08 Thread Javier Martinez Canillas
The nomodeset kernel command line parameter is not documented. Its name is quite vague and is not intuitive what's the behaviour when it is set. Document in kernel-parameters.txt what actually happens when nomodeset is used. That way, users could know if they want to enable this option. Signed-of

[PATCH v3 6/6] drm: Make the nomodeset message less sensational

2021-11-08 Thread Javier Martinez Canillas
The message printed when nomodeset is present in the kernel command line makes it look as if the parameter must never be used and it's a bad idea. But there are valid reasons to use this parameter and the message should not imply otherwise. Change the text to be more accurate and restrained. Sugg

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread Paul Cercueil
Hi, Le lun., nov. 8 2021 at 11:52:20 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 08.11.2021 um 10:37 schrieb Paul Cercueil : Well, it was atomic: "add jz4780+hdmi functionality" or not. Now we separate into "preparation for adding jz4780" and "really adding". Yes, you can split a

[PATCH v2] drm/i915/gem: Fix gem_madvise for ttm+shmem objects

2021-11-08 Thread Thomas Hellström
Gem-TTM objects that are backed by shmem might have populated page-vectors without having the GEM pages set. Those objects aren't moved to the correct shrinker / purge list by gem_madvise. For such objects, identified by having the _SELF_MANAGED_SHRINK_LIST set, make sure they end up on the correc

Re: [PATCH v2] drm/i915/gem: Fix gem_madvise for ttm+shmem objects

2021-11-08 Thread Matthew Auld
On 08/11/2021 12:36, Thomas Hellström wrote: Gem-TTM objects that are backed by shmem might have populated page-vectors without having the GEM pages set. Those objects aren't moved to the correct shrinker / purge list by gem_madvise. For such objects, identified by having the _SELF_MANAGED_SHRIN

Re: [PATCH v3 5/6] Documentation/admin-guide: Document nomodeset kernel parameter

2021-11-08 Thread Thomas Zimmermann
Hi Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas: The nomodeset kernel command line parameter is not documented. Its name is quite vague and is not intuitive what's the behaviour when it is set. Document in kernel-parameters.txt what actually happens when nomodeset is used. That way, us

Re: [PATCH v3 6/6] drm: Make the nomodeset message less sensational

2021-11-08 Thread Thomas Zimmermann
Hi Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas: The message printed when nomodeset is present in the kernel command line makes it look as if the parameter must never be used and it's a bad idea. But there are valid reasons to use this parameter and the message should not imply otherwi

Re: [PATCH v3 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-08 Thread Thomas Zimmermann
Hi Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas: There is a lot of historical baggage on this parameter. It is defined in the vgacon driver as nomodeset, but its set function is called text_mode() and the value queried with a function named vgacon_text_force(). All this implies that it

Re: [PATCH v3 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-08 Thread Javier Martinez Canillas
Hello Thomas, On 11/8/21 13:50, Thomas Zimmermann wrote: > Hi > > Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas: >> There is a lot of historical baggage on this parameter. It is defined in >> the vgacon driver as nomodeset, but its set function is called text_mode() >> and the value queri

Re: [PATCH] drm/virtio: Fix NULL dereference error in virtio_gpu_poll

2021-11-08 Thread Gerd Hoffmann
On Thu, Nov 04, 2021 at 02:42:49PM -0700, Vivek Kasireddy wrote: > When virgl is not enabled, vfpriv pointer would not be allocated. > Therefore, check for a valid value before dereferencing. > > Reported-by: Christian Zigotzky > Cc: Gurchetan Singh > Cc: Gerd Hoffmann > Signed-off-by: Vivek Ka

[PATCH] drm/drm_plane.h: fix a typo: not -> note

2021-11-08 Thread Sui Jingfeng
From: suijingfeng Signed-off-by: suijingfeng --- include/drm/drm_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index fed97e35626f..0c1102dc4d88 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -

[PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-08 Thread Javier Martinez Canillas
There is a lot of historical baggage on this parameter. It is defined in the vgacon driver as nomodeset, but its set function is called text_mode() and the value queried with a function named vgacon_text_force(). All this implies that it's about forcing text mode for VGA, yet it is not used in nei

[PATCH v4 2/6] drm/vboxvideo: Drop CONFIG_VGA_CONSOLE guard to call vgacon_text_force()

2021-11-08 Thread Javier Martinez Canillas
It is already handled by the console.h macro since a stub inline function is defined for vgacon_text_force() if CONFIG_VGA_CONSOLE is not set. There's no need to have ifdefery in the driver when calling the function. Signed-off-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann --- (no c

[PATCH v4 1/6] drm: Don't print messages if drivers are disabled due nomodeset

2021-11-08 Thread Javier Martinez Canillas
The nomodeset kernel parameter handler already prints a message that the DRM drivers will be disabled, so there's no need for drivers to do that. Suggested-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann --- (no changes since v1) drivers/gpu/drm/amd/

[PATCH v4 5/6] Documentation/admin-guide: Document nomodeset kernel parameter

2021-11-08 Thread Javier Martinez Canillas
The nomodeset kernel command line parameter is not documented. Its name is quite vague and is not intuitive what's the behaviour when it is set. Document in kernel-parameters.txt what actually happens when nomodeset is used. That way, users could know if they want to enable this option. Signed-of

[PATCH v4 4/6] drm: Decouple nomodeset from CONFIG_VGA_CONSOLE

2021-11-08 Thread Javier Martinez Canillas
This relationship was only for historical reasons and the nomodeset option should be available even on platforms that don't enable CONFIG_VGA_CONSOLE. Suggested-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann --- (no changes since v1) drivers/gpu/drm

[PATCH v4 6/6] drm: Make the nomodeset message less sensational

2021-11-08 Thread Javier Martinez Canillas
The message printed when nomodeset is present in the kernel command line makes it look as if the parameter must never be used and it's a bad idea. But there are valid reasons to use this parameter and the message should not imply otherwise. Change the text to be more accurate and restrained. Sugg

[PATCH v4 3/6] drm: Move nomodeset kernel parameter to the DRM subsystem

2021-11-08 Thread Javier Martinez Canillas
The "nomodeset" kernel cmdline parameter is handled by the vgacon driver but the exported vgacon_text_force() symbol is only used by DRM drivers. It makes much more sense for the parameter logic to be in the subsystem of the drivers that are making use of it. Let's move the vgacon_text_force() fu

Re: [PATCH v4 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-08 Thread Thomas Zimmermann
Hi Am 08.11.21 um 15:06 schrieb Javier Martinez Canillas: There is a lot of historical baggage on this parameter. It is defined in the vgacon driver as nomodeset, but its set function is called text_mode() and the value queried with a function named vgacon_text_force(). All this implies that it

Re: [PATCH] drm/drm_plane.h: fix a typo: not -> note

2021-11-08 Thread Thomas Zimmermann
Hi Am 08.11.21 um 14:20 schrieb Sui Jingfeng: From: suijingfeng Signed-off-by: suijingfeng This was fixed a while ago. [1] If you want to work on the DRM framework, please use the latest repository from drm-tip. [2] Best regards Thomas [1] https://cgit.freedesktop.org/drm/drm-misc/comm

Re: Questions about KMS flip

2021-11-08 Thread Daniel Vetter
On Mon, Nov 08, 2021 at 08:44:24AM +0100, Christian König wrote: > Am 05.11.21 um 19:13 schrieb Daniel Vetter: > > On Thu, Nov 04, 2021 at 12:44:34PM -0400, Harry Wentland wrote: > > > +Nick > > > > > > It looks to be the old drm_plane_state->fb holds that reference. See > > > dm_plane_helper_cle

Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate

2021-11-08 Thread Maxime Ripard
On Thu, Nov 04, 2021 at 05:41:13PM +0200, Ville Syrjälä wrote: > On Thu, Nov 04, 2021 at 09:48:41AM +0100, Maxime Ripard wrote: > > Hi Ville, > > > > On Wed, Nov 03, 2021 at 08:05:16PM +0200, Ville Syrjälä wrote: > > > On Wed, Nov 03, 2021 at 01:02:11PM +0200, Ville Syrjälä wrote: > > > > On Tue,

Re: [PATCH 1/2] drm/atomic: document and enforce rules around "spurious" EBUSY

2021-11-08 Thread Daniel Vetter
On Fri, Nov 05, 2021 at 04:47:29PM -0400, Kazlauskas, Nicholas wrote: > Hi Daniel, > > Just got bitten by this warning when trying to do some refactoring in amdgpu > for trying to get rid of the DRM private object we use for our DC state. > > From a userspace perspective I understand that we want

Re: [PATCH v1 2/2] drm/tegra: Use drm_dp_aux_register_ddc/chardev() helpers

2021-11-08 Thread Daniel Vetter
On Mon, Nov 08, 2021 at 02:08:21AM +0300, Dmitry Osipenko wrote: > Use drm_dp_aux_register_ddc/chardev() helpers that allow to register I2C > adapter separately from the character device. This fixes broken display > panel driver of Acer Chromebook CB5-311 that fails to probe starting with > v5.13 k

Re: [PATCH] drm/drm_plane.h: fix a typo: not -> note

2021-11-08 Thread Daniel Vetter
On Mon, Nov 08, 2021 at 01:16:25PM +0800, suijingfeng wrote: > Signed-off-by: suijingfeng Merged into drm-misc-next-fixes for 5.16 merge window. -Daniel > --- > include/drm/drm_plane.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_plane.h b/include/dr

Re: [PATCH 1/3] drm/exynox: Implement mmap as GEM object function

2021-11-08 Thread Daniel Vetter
On Mon, Nov 08, 2021 at 11:28:44AM +0100, Thomas Zimmermann wrote: > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > The respective exynos functions are being removed. The file_operations > structure exynos_drm_driver_f

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread H. Nikolaus Schaller
Bnjour Paul, > Am 08.11.2021 um 13:20 schrieb Paul Cercueil : > > Hi, > > Le lun., nov. 8 2021 at 11:52:20 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, Am 08.11.2021 um 10:37 schrieb Paul Cercueil : Well, it was atomic: "add jz4780+hdmi functionality" or not. Now we sep

Re: [PATCH 1/2] drm/atomic: document and enforce rules around "spurious" EBUSY

2021-11-08 Thread Kazlauskas, Nicholas
On 2021-11-08 10:07 a.m., Daniel Vetter wrote: On Fri, Nov 05, 2021 at 04:47:29PM -0400, Kazlauskas, Nicholas wrote: Hi Daniel, Just got bitten by this warning when trying to do some refactoring in amdgpu for trying to get rid of the DRM private object we use for our DC state. From a userspac

Re: [PATCH v3 5/6] Documentation/admin-guide: Document nomodeset kernel parameter

2021-11-08 Thread Daniel Vetter
On Mon, Nov 08, 2021 at 01:48:24PM +0100, Thomas Zimmermann wrote: > Hi > > Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas: > > The nomodeset kernel command line parameter is not documented. Its name > > is quite vague and is not intuitive what's the behaviour when it is set. > > > > Docum

[PATCH v2] drm/fb-helper: Call drm_fb_helper_hotplug_event() when releasing drm master

2021-11-08 Thread Jocelyn Falempe
When using Xorg/Logind and an external monitor connected with an MST dock. After disconnecting the external monitor, switching to VT may not work, the (internal) monitor sill display Xorg, and you can't see what you are typing in the VT. This is related to commit e2809c7db818 ("drm/fb_helper: move

Re: [PATCH 1/2] drm/atomic: document and enforce rules around "spurious" EBUSY

2021-11-08 Thread Daniel Vetter
On Mon, Nov 08, 2021 at 10:32:04AM -0500, Kazlauskas, Nicholas wrote: > On 2021-11-08 10:07 a.m., Daniel Vetter wrote: > > On Fri, Nov 05, 2021 at 04:47:29PM -0400, Kazlauskas, Nicholas wrote: > > > Hi Daniel, > > > > > > Just got bitten by this warning when trying to do some refactoring in > > >

[PATCH v3] drm/ttm: Clarify that the TTM_PL_SYSTEM buffers need to stay idle

2021-11-08 Thread Zack Rusin
TTM was designed to allow TTM_PL_SYSTEM buffer to be fenced but over the years the code that was meant to handle it was broken and new changes can not deal with buffers which have been placed in TTM_PL_SYSTEM buf do not remain idle. CPU buffers which need to be fenced and shared with accelerators s

Re: [PATCH 02/13] drm/connector: Add helper to check if a mode requires scrambling

2021-11-08 Thread Maxime Ripard
On Fri, Nov 05, 2021 at 08:14:04PM +0200, Ville Syrjälä wrote: > On Fri, Nov 05, 2021 at 07:02:30PM +0100, Daniel Vetter wrote: > > On Thu, Nov 04, 2021 at 05:37:21PM +0200, Ville Syrjälä wrote: > > > On Tue, Nov 02, 2021 at 03:59:33PM +0100, Maxime Ripard wrote: > > > > --- a/include/drm/drm_modes

Re: [PATCH v2] drm/fb-helper: Call drm_fb_helper_hotplug_event() when releasing drm master

2021-11-08 Thread Daniel Vetter
On Mon, Nov 08, 2021 at 04:34:53PM +0100, Jocelyn Falempe wrote: > When using Xorg/Logind and an external monitor connected with an MST dock. > After disconnecting the external monitor, switching to VT may not work, > the (internal) monitor sill display Xorg, and you can't see what you are > typing

Re: [PATCH 02/13] drm/connector: Add helper to check if a mode requires scrambling

2021-11-08 Thread Daniel Vetter
On Mon, Nov 08, 2021 at 04:58:34PM +0100, Maxime Ripard wrote: > On Fri, Nov 05, 2021 at 08:14:04PM +0200, Ville Syrjälä wrote: > > On Fri, Nov 05, 2021 at 07:02:30PM +0100, Daniel Vetter wrote: > > > On Thu, Nov 04, 2021 at 05:37:21PM +0200, Ville Syrjälä wrote: > > > > On Tue, Nov 02, 2021 at 03:

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread Paul Cercueil
Hi, Le lun., nov. 8 2021 at 16:29:11 +0100, H. Nikolaus Schaller a écrit : Bnjour Paul, Am 08.11.2021 um 13:20 schrieb Paul Cercueil : Hi, Le lun., nov. 8 2021 at 11:52:20 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 08.11.2021 um 10:37 schrieb Paul Cercueil : Well, it was

Re: [PATCH/RFT] fbdev driver for HP Visualize FX cards

2021-11-08 Thread Sven Schnelle
Thomas Zimmermann writes: > Hi > > Am 06.11.21 um 22:02 schrieb Sven Schnelle: >> Thomas Zimmermann writes: >> >>> Hi >>> >>> Am 01.11.21 um 09:54 schrieb Sven Schnelle: Hi Thomas, Thomas Zimmermann writes: Thanks, i wasn't aware as i normally don't do any graphics related

Re: [PATCH v3 0/6] Cleanups for the nomodeset kernel command line parameter logic

2021-11-08 Thread Jani Nikula
On Mon, 08 Nov 2021, Javier Martinez Canillas wrote: > Hello Thomas, > > On 11/8/21 13:50, Thomas Zimmermann wrote: >> Hi >> >> Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas: >>> There is a lot of historical baggage on this parameter. It is defined in >>> the vgacon driver as nomodeset, b

[ANNOUNCE] libdrm 2.4.108

2021-11-08 Thread Simon Ser
Full commit history below. Aaron Liu (1): test/amdgpu: Bob to Alice copy should be TMZ in secure bounce test Alex Deucher (2): amdgpu: add marketing names from 21.30 amdgpu: add new marketing name Alex Richardson (1): Fix -Werror=format build errors on FreeBSD Christian

[PATCH] drm/i915/guc: Refcount context during error capture

2021-11-08 Thread Matthew Brost
From: John Harrison When i915 receives a context reset notification from GuC, it triggers an error capture before resetting any outstanding requsts of that context. Unfortunately, the error capture is not a time bound operation. In certain situations it can take a long time, particularly when mul

[PATCH] iommu/arm-smmu-qcom: Fix TTBR0 read

2021-11-08 Thread Rob Clark
From: Rob Clark It is a 64b register, lets not lose the upper bits. Fixes: ab5df7b953d8 ("iommu/arm-smmu-qcom: Add an adreno-smmu-priv callback to get pagefault info") Signed-off-by: Rob Clark --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2] drm/fb-helper: Call drm_fb_helper_hotplug_event() when releasing drm master

2021-11-08 Thread Jocelyn Falempe
On 08/11/2021 17:00, Daniel Vetter wrote: On Mon, Nov 08, 2021 at 04:34:53PM +0100, Jocelyn Falempe wrote: When using Xorg/Logind and an external monitor connected with an MST dock. After disconnecting the external monitor, switching to VT may not work, the (internal) monitor sill display Xorg,

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread H. Nikolaus Schaller
Hi Paul, > Am 08.11.2021 um 17:30 schrieb Paul Cercueil : > > Hi, > > Le lun., nov. 8 2021 at 16:29:11 +0100, H. Nikolaus Schaller > a écrit : >> Bnjour Paul, >>> Am 08.11.2021 um 13:20 schrieb Paul Cercueil : >>> Hi, e.g. jz4770.dtsi: lcd: lcd-controller@1305 {

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread Paul Cercueil
Hi, Le lun., nov. 8 2021 at 18:22:58 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 08.11.2021 um 17:30 schrieb Paul Cercueil : Hi, Le lun., nov. 8 2021 at 16:29:11 +0100, H. Nikolaus Schaller a écrit : Bnjour Paul, Am 08.11.2021 um 13:20 schrieb Paul Cercueil : Hi, e.g. jz

Re: [PATCH] iommu/arm-smmu-qcom: Fix TTBR0 read

2021-11-08 Thread Bjorn Andersson
On Mon 08 Nov 09:17 PST 2021, Rob Clark wrote: > From: Rob Clark > > It is a 64b register, lets not lose the upper bits. > > Fixes: ab5df7b953d8 ("iommu/arm-smmu-qcom: Add an adreno-smmu-priv callback > to get pagefault info") > Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson Regards

[PATCH] drm/msm: Do hw_init() before capturing GPU state

2021-11-08 Thread Rob Clark
From: Rob Clark In particular, we need to ensure all the necessary blocks are switched to 64b mode (a5xx+) otherwise the high bits of the address of the BO to snapshot state into will be ignored, resulting in: *** gpu fault: ttbr0= iova=00012000 dir=READ type=TRANSLATI

Re: [PATCH] dt-bindings: display: bridge: Convert toshiba,tc358767.txt to yaml

2021-11-08 Thread Rob Herring
On Thu, 28 Oct 2021 15:06:56 +0530, Rahul T R wrote: > Convert toshiba,tc358767.txt binding to yaml format > > Signed-off-by: Rahul T R > --- > .../display/bridge/toshiba,tc358767.txt | 54 -- > .../display/bridge/toshiba,tc358767.yaml | 158 ++ > 2 files changed,

Re: [PATCH 02/13] drm/connector: Add helper to check if a mode requires scrambling

2021-11-08 Thread Ville Syrjälä
On Mon, Nov 08, 2021 at 04:58:34PM +0100, Maxime Ripard wrote: > On Fri, Nov 05, 2021 at 08:14:04PM +0200, Ville Syrjälä wrote: > > On Fri, Nov 05, 2021 at 07:02:30PM +0100, Daniel Vetter wrote: > > > On Thu, Nov 04, 2021 at 05:37:21PM +0200, Ville Syrjälä wrote: > > > > On Tue, Nov 02, 2021 at 03:

[PATCH v6 1/4] drm/i915: Avoid allocating a page array for the gpu coredump

2021-11-08 Thread Thomas Hellström
The gpu coredump typically takes place in a dma_fence signalling critical path, and hence can't use GFP_KERNEL allocations, as that means we might hit deadlocks under memory pressure. However changing to __GFP_KSWAPD_RECLAIM which will be done in an upcoming patch will instead mean a lower chance o

[PATCH v6 0/4] drm/i915: Prepare error capture for asynchronous migration

2021-11-08 Thread Thomas Hellström
This patch series prepares error capture for asynchronous migration, where the vma pages may not reflect the pages the GPU is currently executing from but may be several migrations ahead. The first patch gets rid of some contigous memory allocations that may blow up due to the change of allocation

[PATCH v6 3/4] drm/i915: Update error capture code to avoid using the current vma state

2021-11-08 Thread Thomas Hellström
With asynchronous migrations, the vma state may be several migrations ahead of the state that matches the request we're capturing. Address that by introducing an i915_vma_snapshot structure that can be used to snapshot relevant state at request submission. In order to make sure we access the correc

[PATCH v6 2/4] drm/i915: Use __GFP_KSWAPD_RECLAIM in the capture code

2021-11-08 Thread Thomas Hellström
The capture code is typically run entirely in the fence signalling critical path. We're about to add lockdep annotation in an upcoming patch which reveals a lockdep splat similar to the below one. Fix the associated potential deadlocks using __GFP_KSWAPD_RECLAIM (which is the same as GFP_WAIT, but

[PATCH v6 4/4] drm/i915: Initial introduction of vma resources

2021-11-08 Thread Thomas Hellström
The vma resource are needed for asynchronous bind management and are similar to TTM resources. They contain the data needed for asynchronous unbinding (typically the vm range, any backend private information and a means to do refcounting and to hold the unbinding for error capture). When a vma is

Re: [PATCH v1 2/2] drm/tegra: Use drm_dp_aux_register_ddc/chardev() helpers

2021-11-08 Thread Dmitry Osipenko
08.11.2021 18:17, Daniel Vetter пишет: > On Mon, Nov 08, 2021 at 02:08:21AM +0300, Dmitry Osipenko wrote: >> Use drm_dp_aux_register_ddc/chardev() helpers that allow to register I2C >> adapter separately from the character device. This fixes broken display >> panel driver of Acer Chromebook CB5-311

[PATCH] dt-bindings: display: sync formats with simplefb.h

2021-11-08 Thread David Heidelberg
Sync all formats from simplefb.h into documentation. Signed-off-by: David Heidelberg --- .../bindings/display/simple-framebuffer.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b/Documentation/devic

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread H. Nikolaus Schaller
Hi Paul, > Am 08.11.2021 um 18:49 schrieb Paul Cercueil : > >>> Variant 4: the variant #2 without the changes to the DTSI files. >> Hm. If there is no cache and we can safely remove tight boundary checking >> (by JZ_REG_LCD_SIZE1) for jz4725/40/70 (by not fixing DTSI) why do we still >> need th

Re: [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-08 Thread Paul Cercueil
Hi Nikolaus, Le lun., nov. 8 2021 at 19:33:48 +0100, H. Nikolaus Schaller a écrit : Hi Paul, Am 08.11.2021 um 18:49 schrieb Paul Cercueil : Variant 4: the variant #2 without the changes to the DTSI files. Hm. If there is no cache and we can safely remove tight boundary checking (by JZ_

Re: [PATCH v2 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

2021-11-08 Thread Noralf Trønnes
Den 01.11.2021 15.15, skrev Thomas Zimmermann: > Enable the FB_DAMAGE_CLIPS property to reduce display-update > overhead. Also fixes a warning in the kernel log. > > simple-framebuffer simple-framebuffer.0: [drm] > drm_plane_enable_fb_damage_clips() not called > > Fix the computation of the

Re: [PATCH v2 3/9] drm/format-helper: Add destination-buffer pitch to drm_fb_swab()

2021-11-08 Thread Amanoel Dawod
Hi, On Mon, Nov 1, 2021, at 10:15 AM, Thomas Zimmermann wrote: > Add destination-buffer pitch as argument to drm_fb_swab(). Done for > consistency with the rest of the interface. > > v2: > * update documentation (Noralf) > > Signed-off-by: Thomas Zimmermann > Tested-by: Noralf Trønnes > Re

Re: [PATCH/RFT] fbdev driver for HP Visualize FX cards

2021-11-08 Thread Thomas Zimmermann
Hi Am 08.11.21 um 17:31 schrieb Sven Schnelle: Thomas Zimmermann writes: Hi Am 06.11.21 um 22:02 schrieb Sven Schnelle: Thomas Zimmermann writes: Hi Am 01.11.21 um 09:54 schrieb Sven Schnelle: Hi Thomas, Thomas Zimmermann writes: Thanks, i wasn't aware as i normally don't do any graph

Re: [PATCH v2 2/8] drm: improve drm_buddy_alloc function

2021-11-08 Thread Arunpravin
Hi Matthew, Thanks for the review, Please find my comments On 04/11/21 12:11 am, Matthew Auld wrote: > On 25/10/2021 14:00, Arunpravin wrote: >> - Make drm_buddy_alloc a single function to handle >>range allocation and non-range allocation demands >> >> - Implemented a new function alloc_range

[PATCH v2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-08 Thread Kuogee Hsieh
From: Kuogee Hsieh Combo phy supports both USB and DP simultaneously. There may has a possible conflict during phy initialization phase between USB and DP driver which may cause USB phy timeout when USB tries to power up its phy. This patch has the DP driver not initialize its phy during DP drive

Re: [PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private

2021-11-08 Thread Nadav Amit
> On Nov 8, 2021, at 12:30 PM, Srivatsa S. Bhat wrote: > > From: Srivatsa S. Bhat (VMware) > > VMware mailing lists in the MAINTAINERS file are private lists meant > for VMware-internal review/notification for patches to the respective > subsystems. So, in an earlier discussion [1][2], it was

Re: [PATCH v2 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

2021-11-08 Thread Noralf Trønnes
Den 01.11.2021 15.15, skrev Thomas Zimmermann: > Enable the FB_DAMAGE_CLIPS property to reduce display-update > overhead. Also fixes a warning in the kernel log. > > simple-framebuffer simple-framebuffer.0: [drm] > drm_plane_enable_fb_damage_clips() not called > > Fix the computation of the

Re: [PATCH v2 8/9] drm/simpledrm: Support virtual screen sizes

2021-11-08 Thread Noralf Trønnes
Den 01.11.2021 15.15, skrev Thomas Zimmermann: > Add constants for the maximum size of the shadow-plane surface > size. Useful for shadow planes with virtual screen sizes. The > current sizes are 4096 scanlines with 4096 pixels each. This > seems reasonable for current hardware, but can be incre

Re: [PATCH v2 9/9] drm: Clarify semantics of struct drm_mode_config.{min,max}_{width,height}

2021-11-08 Thread Noralf Trønnes
Den 01.11.2021 15.15, skrev Thomas Zimmermann: > Add additional information on the semantics of the size fields in > struct drm_mode_config. Also add a TODO to review all driver for > correct usage of these fields. > > Signed-off-by: Thomas Zimmermann > --- Acked-by: Noralf Trønnes

[PATCH] drm/i915/pmu: Fix synchronization of PMU callback with reset

2021-11-08 Thread Umesh Nerlige Ramappa
Since the PMU callback runs in irq context, it synchronizes with gt reset using the reset count. We could run into a case where the PMU callback could read the reset count before it is updated. This has a potential of corrupting the busyness stats. In addition to the reset count, check if the rese

[PATCH 1/3] i915/gvt: seperate tracked MMIO table from handlers.c

2021-11-08 Thread Zhi Wang
From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g MMIO snapshot still needs to be saved in i915 so that the inital clean HW state can be used for the further vGPU. Seperate the tracked MMIO tab

[PATCH 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2021-11-08 Thread Zhi Wang
From: Zhi Wang The code of saving initial HW state snapshot has been moved into i915. Let the GVT-g core logic use that snapshot. Cc: Joonas Lahtinen Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Zhenyu Wang Cc: Zhi Wang Cc: Christoph Hellwig Cc: Jason Gunthorpe Signed-off-by: Zhi Wang --- drive

[PATCH 2/2] MAINTAINERS: Mark VMware mailing list entries as private

2021-11-08 Thread Srivatsa S. Bhat
From: Srivatsa S. Bhat (VMware) VMware mailing lists in the MAINTAINERS file are private lists meant for VMware-internal review/notification for patches to the respective subsystems. So, in an earlier discussion [1][2], it was recommended to mark them as such. Update all the remaining VMware mail

[PATCH 2/3] i915/gvt: save the initial HW state snapshot in i915.

2021-11-08 Thread Zhi Wang
From: Zhi Wang Save the inital HW state snapshot in i915 so that the rest code of GVT-g can be moved into a dedicated module while it can still get a clean initial HW state saved at the correct time during the initialization of i915. The futhrer vGPU created by GVT-g will use this HW state as the

Re: [PATCH 3/8] drm: implement top-down allocation method

2021-11-08 Thread Arunpravin
On 04/11/21 12:14 am, Matthew Auld wrote: > On 25/10/2021 14:00, Arunpravin wrote: >> Implemented a function which walk through the order list, >> compares the offset and returns the maximum offset block, >> this method is unpredictable in obtaining the high range >> address blocks which depends

Re: [PATCH 6/8] drm/i915: add free_unused_pages support to i915

2021-11-08 Thread Arunpravin
On 04/11/21 12:48 am, Matthew Auld wrote: > On 25/10/2021 14:00, Arunpravin wrote: >> add drm_buddy_free_unused_pages() support on >> contiguous allocation >> >> Signed-off-by: Arunpravin >> --- >> drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 8 >> 1 file changed, 8 insertions(+)

Re: [PATCH 8/8] drm/amdgpu: add drm buddy support to amdgpu

2021-11-08 Thread Arunpravin
On 04/11/21 2:24 pm, Christian König wrote: > Am 04.11.21 um 09:49 schrieb Matthew Auld: >> On 04/11/2021 07:34, Christian König wrote: >>> >>> >>> Am 03.11.21 um 20:25 schrieb Matthew Auld: On 25/10/2021 14:00, Arunpravin wrote: > - Remove drm_mm references and replace with drm buddy f

  1   2   >