Re: [PATCH/RFT] fbdev driver for HP Visualize FX cards

2021-11-01 Thread Thomas Zimmermann
(cc'ing dri-devel) Hi Am 31.10.21 um 20:53 schrieb Sven Schnelle: Hi List(s), i wrote a fbdev driver for the HP Visualize FX cards used some of the PA-RISC workstations. It utilizes some of the 2D acceleration features present in the card. What is working right now: - modesetting (tested all

[PATCH 0/2] drm: Small CMA cleanups

2021-11-01 Thread Thomas Zimmermann
Remove CMA dependencies from MIPI-DBI and replace the config symbol DRM_KMS_CMA_HELPER with DRM_KMS_HELPER. This allows to link drm_fb_cma_helper.o into a helper library. Thomas Zimmermann (2): drm/mipi-dbi: Remove dependency on GEM CMA helper library drm: Remove CONFIG_DRM_KMS_CMA_HELPER opti

[PATCH 1/2] drm/mipi-dbi: Remove dependency on GEM CMA helper library

2021-11-01 Thread Thomas Zimmermann
The MIPI DBI helpers access struct drm_gem_cma_object.vaddr in a few places. Replace all instances with the correct generic GEM functions. Use drm_gem_fb_vmap() for mapping a framebuffer's GEM objects and drm_gem_fb_vunmap() for unmapping them. This removes the dependency on CMA helpers within MIPI

[PATCH 2/2] drm: Remove CONFIG_DRM_KMS_CMA_HELPER option

2021-11-01 Thread Thomas Zimmermann
Link drm_fb_cma_helper.o into drm_cma_helper.ko if CONFIG_DRM_KMS_HELPER has been set. Remove CONFIG_DRM_KMS_CMA_HELPER config option. Selecting KMS helpers and CMA will now automatically enable CMA KMS helpers. Some drivers' Kconfig files did not correctly select KMS or CMA helpers. Fix this as p

Re: linux-next: build failure after merge of the drm-misc tree

2021-11-01 Thread Stephen Rothwell
Hi all, On Fri, 15 Oct 2021 20:26:48 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/gpu/drm/drm_modeset_lock.c:111:29: error: conflicting types for > '__stack_depot_save' > 111 | static depo

Re: [PATCH 1/9] drm/format-helper: Export drm_fb_clip_offset()

2021-11-01 Thread Thomas Zimmermann
Hi Am 23.10.21 um 09:49 schrieb Sam Ravnborg: Hi Thomas, On Fri, Oct 22, 2021 at 03:28:21PM +0200, Thomas Zimmermann wrote: Provide a function that computes the offset into a blit destination buffer. This will allow to move destination-buffer clipping into the format-helper callers. Signed-of

[Bug 214621] WARNING: CPU: 3 PID: 521 at drivers/gpu/drm/ttm/ttm_bo.c:409 ttm_bo_release+0xb64/0xe40 [ttm]

2021-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214621 Lang Yu (lang...@amd.com) changed: What|Removed |Added CC||lang...@amd.com --- Comment #

Re: [PATCH 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

2021-11-01 Thread Thomas Zimmermann
Hi Am 24.10.21 um 17:20 schrieb Noralf Trønnes: Den 22.10.2021 15.28, skrev Thomas Zimmermann: Enable the FB_DAMAGE_CLIPS property to reduce display-update overhead. Also fixes a warning in the kernel log. simple-framebuffer simple-framebuffer.0: [drm] drm_plane_enable_fb_damage_clips()

[Bug 214901] amdgpu freezes HP laptop at start up

2021-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214901 --- Comment #2 from spassw...@web.de --- There is another error message just before the Oops: Nov 1 00:22:49 bart kernel: [2.137397] amdgpu :00:01.0: amdgpu: amdgpu_device_ip_init failed Nov 1 00:22:49 bart kernel: [2.137402] amdgpu

Re: linux-next: build warning after merge of the drm-misc tree

2021-11-01 Thread Stephen Rothwell
Hi Stephen, On Tue, 5 Oct 2021 18:59:40 +1100 Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/linux/dma-buf.h:456: warning: Function parameter or member 'cb_in' > not described in 'dma_buf' > inc

Re: [PATCH/RFT] fbdev driver for HP Visualize FX cards

2021-11-01 Thread Thomas Zimmermann
Hi Am 01.11.21 um 09:54 schrieb Sven Schnelle: Hi Thomas, Thomas Zimmermann writes: Am 31.10.21 um 20:53 schrieb Sven Schnelle: Hi List(s), i wrote a fbdev driver for the HP Visualize FX cards used some of the PA-RISC workstations. It utilizes some of the 2D acceleration features present in

[Bug 214901] amdgpu freezes HP laptop at start up

2021-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214901 --- Comment #3 from spassw...@web.de --- Actually the above message is not complete: Nov 1 00:22:49 bart kernel: [2.136382] kfd kfd: amdgpu: Allocated 3969056 bytes on gart Nov 1 00:22:49 bart kernel: [2.136462] kfd kfd: amdgpu: error ge

Re: [Intel-gfx] [PATCH 02/28] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-11-01 Thread Tvrtko Ursulin
On 28/10/2021 16:30, Daniel Vetter wrote: On Thu, Oct 28, 2021 at 10:41:38AM +0200, Christian König wrote: Am 21.10.21 um 13:13 schrieb Tvrtko Ursulin: On 21/10/2021 12:06, Maarten Lankhorst wrote: Op 21-10-2021 om 12:38 schreef Christian König: Am 21.10.21 um 12:35 schrieb Maarten Lankhor

Re: [PATCH 3/6] drm/etnaviv: stop getting the excl fence separately here

2021-11-01 Thread Lucas Stach
Am Donnerstag, dem 28.10.2021 um 15:26 +0200 schrieb Christian König: > Just grab all fences in one go. > > Signed-off-by: Christian König Reviewed-by: Lucas Stach > --- > drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dr

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Weak parallel submission support for execlists

2021-11-01 Thread Tvrtko Ursulin
On 27/10/2021 21:10, Matthew Brost wrote: On Wed, Oct 27, 2021 at 01:04:49PM -0700, John Harrison wrote: On 10/27/2021 12:17, Matthew Brost wrote: On Tue, Oct 26, 2021 at 02:58:00PM -0700, John Harrison wrote: On 10/20/2021 14:47, Matthew Brost wrote: A weak implementation of parallel submi

[Bug 214901] amdgpu freezes HP laptop at start up

2021-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214901 --- Comment #4 from spassw...@web.de --- Just confirmed that removing the 3 lines r = amdgpu_amdkfd_resume_iommu(adev); if (r) goto init_failed; can be used as a workaround. Removing only the if (r) check is not eno

[PATCH 0/4] Add Aspeed AST2600 soc display support

2021-11-01 Thread tommy-huang
The Aspeed AST2600 soc diaplay support is added in this patch. Because some hw designed is changed in this version, add them in this patch. v2: Remove some unnecessary patch. Refine for reviwer request. v1: First add patch. Joel Stanley (2): ARM: dts: aspeed: Add GFX node to AST2600 A

[PATCH 1/4] ARM: dts: aspeed: Add GFX node to AST2600

2021-11-01 Thread tommy-huang
From: Joel Stanley The GFX device is present in the AST2600 SoC. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi ind

[PATCH 2/4] ARM: dts: aspeed: ast2600-evb: Enable GFX device

2021-11-01 Thread tommy-huang
From: Joel Stanley Enable the GFX device with a framebuffer memory region. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/ar

[PATCH 3/4] drm/aspeed: Update INTR_STS handling

2021-11-01 Thread tommy-huang
The V-sync INTR_STS is differnet on AST2600. Change into general rule to handle it. Signed-off-by: tommy-huang --- drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 ++ drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 26 ++--- 2 files changed, 25 insertions(+), 3 deletions(-) d

[PATCH 4/4] dt-bindings: gpu: Add ASPEED GFX bindings document

2021-11-01 Thread tommy-huang
Add ast2600-gfx description for gfx driver. Signed-off-by: tommy-huang --- Documentation/devicetree/bindings/gpu/aspeed-gfx.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt b/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt index 9

Re: [PATCH] drm/rockchip: use generic fbdev setup

2021-11-01 Thread John Keeping
On Sun, 31 Oct 2021 19:09:39 +0100 Thomas Zimmermann wrote: > Am 30.10.21 um 14:05 schrieb John Keeping: > > On Fri, Oct 29, 2021 at 09:00:08PM +0200, Thomas Zimmermann wrote: > >> Am 29.10.21 um 13:50 schrieb John Keeping: > >>> The Rockchip fbdev code does not add anything compared to > >>>

[PATCH] drm/rockchip: pass 0 to drm_fbdev_generic_setup()

2021-11-01 Thread John Keeping
Allow drm_fbdev_generic_setup() to pick the default bpp value for the framebuffer. This has no functional impact because the default is 32, given that mode_config.preferred_depth is not set for Rockchip. Suggested-by: Thomas Zimmermann Signed-off-by: John Keeping --- This needs [1] to be applie

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915: Introduce refcounted sg-tables

2021-11-01 Thread Matthew Auld
On Fri, 29 Oct 2021 at 09:22, Thomas Hellström wrote: > > As we start to introduce asynchronous failsafe object migration, > where we update the object state and then submit asynchronous > commands we need to record what memory resources are actually used > by various part of the command stream. I

[PATCH v5] drm/i915: Introduce refcounted sg-tables

2021-11-01 Thread Thomas Hellström
As we start to introduce asynchronous failsafe object migration, where we update the object state and then submit asynchronous commands we need to record what memory resources are actually used by various part of the command stream. Initially for three purposes: 1) Error capture. 2) Asynchronous m

Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector

2021-11-01 Thread Jani Nikula
On Mon, 01 Nov 2021, He Ying wrote: > From the comments of drm_for_each_connector_iter(), we know > that "connector is only valid within the list body, if you > want to use connector after calling drm_connector_list_iter_end() > then you need to grab your own reference first using > drm_connector_

Re: [PATCH v2] drm/dp: Fix aux->transfer NULL pointer dereference on drm_dp_dpcd_access

2021-11-01 Thread Jani Nikula
On Mon, 01 Nov 2021, Perry Yuan wrote: > Fix below crash by adding a check in the drm_dp_dpcd_access which > ensures that aux->transfer was actually initialized earlier. Gut feeling says this is papering over a real usage issue somewhere else. Why is the aux being used for transfers before ->tran

Re: [Intel-gfx] [PATCH v5] drm/i915: Introduce refcounted sg-tables

2021-11-01 Thread Tvrtko Ursulin
On 01/11/2021 12:24, Thomas Hellström wrote: As we start to introduce asynchronous failsafe object migration, where we update the object state and then submit asynchronous commands we need to record what memory resources are actually used by various part of the command stream. Initially for thr

[PATCH v4] backlight: lp855x: Switch to atomic PWM API

2021-11-01 Thread Maíra Canal
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Signed-off-by: Maíra Canal --- V1 -> V2: Initialize variable and simply conditional loop V2 -> V3: Fix assignment of NULL variable V3 -> V4: Replace division for pwm_set_relative_duty_cycle --

Re: [PATCH 4/9] drm/format-helper: Rework format-helper conversion functions

2021-11-01 Thread Thomas Zimmermann
Hi Am 24.10.21 um 13:32 schrieb Noralf Trønnes: Den 22.10.2021 15.28, skrev Thomas Zimmermann: Move destination-buffer clipping from all format-helper conversion functions into callers. Support destination-buffer pitch. Only distinguish between system and I/O memory, but use same logic everyw

Re: linux-next: Tree for Nov 1 [drivers/gpu/drm/msm/msm.ko]

2021-11-01 Thread Randy Dunlap
On 11/1/21 2:44 AM, Stephen Rothwell wrote: Hi all, Changes since 20211029: On i386, when # CONFIG_COMMON_CLK is not set ERROR: modpost: "msm_hdmi_phy_8996_cfg" [drivers/gpu/drm/msm/msm.ko] undefined! Full randconfig file is attached. -- ~Randy config-r1095b.gz Description: application/

Re: [Intel-gfx] [PATCH v5] drm/i915: Introduce refcounted sg-tables

2021-11-01 Thread Thomas Hellström
Hi, Tvrtko On Mon, 2021-11-01 at 13:14 +, Tvrtko Ursulin wrote: > > On 01/11/2021 12:24, Thomas Hellström wrote: > > As we start to introduce asynchronous failsafe object migration, > > where we update the object state and then submit asynchronous > > commands we need to record what memory re

[PATCH v2 0/9] drm/simpledrm: Enable damage clips and virtual screens

2021-11-01 Thread Thomas Zimmermann
Enable FB_DAMAGE_CLIPS with simpledrm for improved performance and/or less overhead. With this in place, add support for virtual screens (i.e., framebuffers that are larger than the display resolution). This also enables fbdev panning and page flipping. After the discussion and bug fixing wrt to f

[PATCH v2 3/9] drm/format-helper: Add destination-buffer pitch to drm_fb_swab()

2021-11-01 Thread Thomas Zimmermann
Add destination-buffer pitch as argument to drm_fb_swab(). Done for consistency with the rest of the interface. v2: * update documentation (Noralf) Signed-off-by: Thomas Zimmermann Tested-by: Noralf Trønnes Reviewed-by: Noralf Trønnes --- drivers/gpu/drm/drm_format_helper.c | 21 +

[PATCH v2 1/9] drm/format-helper: Export drm_fb_clip_offset()

2021-11-01 Thread Thomas Zimmermann
Provide a function that computes the offset into a blit destination buffer. This will allow to move destination-buffer clipping into the format-helper callers. v2: * provide documentation (Sam) * return 'unsigned int' (Sam, Noralf) Signed-off-by: Thomas Zimmermann --- drivers/gp

[PATCH v2 4/9] drm/format-helper: Rework format-helper conversion functions

2021-11-01 Thread Thomas Zimmermann
Move destination-buffer clipping from all format-helper conversion functions into callers. Support destination-buffer pitch. Only distinguish between system and I/O memory, but use same logic everywhere. Simply harmonize the interface and semantics of the existing code. Not all conversion helpers

[PATCH v2 5/9] drm/format-helper: Streamline blit-helper interface

2021-11-01 Thread Thomas Zimmermann
Move destination-buffer clipping from format-helper blit function into caller. Rename drm_fb_blit_rect_dstclip() to drm_fb_blit_toio(). Done for consistency with the rest of the interface. Remove drm_fb_blit_dstclip(), which isn't required. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trø

[PATCH v2 2/9] drm/format-helper: Rework format-helper memcpy functions

2021-11-01 Thread Thomas Zimmermann
Move destination-buffer clipping from all format-helper memcpy function into callers. Support destination-buffer pitch. Only distinguish between system and I/O memory, but use same logic everywhere. Signed-off-by: Thomas Zimmermann Tested-by: Noralf Trønnes Reviewed-by: Noralf Trønnes --- driv

[PATCH v2 6/9] drm/fb-helper: Allocate shadow buffer of surface height

2021-11-01 Thread Thomas Zimmermann
Allocating a shadow buffer of the height of the buffer object does not support fbdev overallocation. Use surface height instead. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH v2 8/9] drm/simpledrm: Support virtual screen sizes

2021-11-01 Thread Thomas Zimmermann
Add constants for the maximum size of the shadow-plane surface size. Useful for shadow planes with virtual screen sizes. The current sizes are 4096 scanlines with 4096 pixels each. This seems reasonable for current hardware, but can be increased as necessary. In simpledrm, set the maximum framebuf

[PATCH v2 9/9] drm: Clarify semantics of struct drm_mode_config.{min, max}_{width, height}

2021-11-01 Thread Thomas Zimmermann
Add additional information on the semantics of the size fields in struct drm_mode_config. Also add a TODO to review all driver for correct usage of these fields. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst| 15 +++ include/drm/drm_mode_config.h | 13 ++

[PATCH v2 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

2021-11-01 Thread Thomas Zimmermann
Enable the FB_DAMAGE_CLIPS property to reduce display-update overhead. Also fixes a warning in the kernel log. simple-framebuffer simple-framebuffer.0: [drm] drm_plane_enable_fb_damage_clips() not called Fix the computation of the blit rectangle. This wasn't an issue so far, as simpledrm alway

Re: [Intel-gfx] [PATCH v5] drm/i915: Introduce refcounted sg-tables

2021-11-01 Thread Tvrtko Ursulin
On 01/11/2021 13:51, Thomas Hellström wrote: Hi, Tvrtko On Mon, 2021-11-01 at 13:14 +, Tvrtko Ursulin wrote: On 01/11/2021 12:24, Thomas Hellström wrote: As we start to introduce asynchronous failsafe object migration, where we update the object state and then submit asynchronous comman

Re: [PATCH/RFT] fbdev driver for HP Visualize FX cards

2021-11-01 Thread Sven Schnelle
Hi Thomas, Thomas Zimmermann writes: > Am 01.11.21 um 09:54 schrieb Sven Schnelle: >> Thomas Zimmermann writes: >> Thanks, i wasn't aware as i normally don't do any graphics related >> development. I take a look at dri and port the driver, which is >> hopefully not too hard. > > Sounds good. >

Re: Lockdep spalt on killing a processes

2021-11-01 Thread Andrey Grodzovsky
Pushed to drm-misc-next Andrey On 2021-10-29 3:07 a.m., Christian König wrote: Attached a patch. Give it a try please, I tested it on my side and tried to generate the right conditions to trigger this code path by repeatedly submitting commands while issuing GPU reset to stop the scheduler

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/uapi: Add query for hwconfig table

2021-11-01 Thread Jordan Justen
writes: > From: Rodrigo Vivi > > GuC contains a consolidated table with a bunch of information about the > current device. > > Previously, this information was spread and hardcoded to all the components > including GuC, i915 and various UMDs. The goal here is to consolidate > the data into GuC i

Re: [Intel-gfx] [PATCH v5] drm/i915: Introduce refcounted sg-tables

2021-11-01 Thread Thomas Hellström
Hi, On 11/1/21 15:50, Tvrtko Ursulin wrote: On 01/11/2021 13:51, Thomas Hellström wrote: Hi, Tvrtko On Mon, 2021-11-01 at 13:14 +, Tvrtko Ursulin wrote: On 01/11/2021 12:24, Thomas Hellström wrote: As we start to introduce asynchronous failsafe object migration, where we update the obj

Re: [PATCH/RFT] fbdev driver for HP Visualize FX cards

2021-11-01 Thread Sven Schnelle
Hi Thomas, Thomas Zimmermann writes: > Am 31.10.21 um 20:53 schrieb Sven Schnelle: >> Hi List(s), >> i wrote a fbdev driver for the HP Visualize FX cards used some of >> the >> PA-RISC workstations. It utilizes some of the 2D acceleration features >> present in the card. >> [..] > > Thanks for a

Re: [PATCH v7 03/20] dt-bindings: mediatek: add ethdr definition for mt8195

2021-11-01 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > Add vdosys1 ETHDR definition. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > .../display/mediatek/mediatek,ethdr.yaml | 147 ++ > 1 file changed, 147 insertions(+) > create mode 100644 > Documentation

Re: [PATCH 2/2] drm: Remove CONFIG_DRM_KMS_CMA_HELPER option

2021-11-01 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Small-CMA-cleanups/20211101-161911 base:bdcc9f6a568275aed4cc32fd2312432d2ff1b704 config: x86_64-randconfig-a00

Re: [PATCH] drm/msm/dsi: set default num_data_lanes

2021-11-01 Thread Doug Anderson
Hi, On Sat, Oct 30, 2021 at 10:08 AM Philip Chen wrote: > > If "data_lanes" property of the dsi output endpoint is missing in > the DT, num_data_lanes would be 0 by default, which could cause > dsi_host_attach() to fail if dsi->lanes is set to a non-zero value > by the bridge driver. > > Accordin

Re: [PATCH] drm/msm/dsi: set default num_data_lanes

2021-11-01 Thread Stephen Boyd
Quoting Philip Chen (2021-10-30 10:08:50) > If "data_lanes" property of the dsi output endpoint is missing in > the DT, num_data_lanes would be 0 by default, which could cause > dsi_host_attach() to fail if dsi->lanes is set to a non-zero value > by the bridge driver. > > According to the binding d

[PATCH 1/3] backlight: lp855x: Move device_config setting out of lp855x_configure()

2021-11-01 Thread Hans de Goede
Move the setting of the lp->cfg pointer to the chip specific lp855x_device_config struct from lp855x_configure() to lp855x_probe(), before calling lp855x_parse_dt(). This is a preperation patch for adding ACPI enumeration support. Signed-off-by: Hans de Goede --- drivers/video/backlight/lp855x_

[PATCH 3/3] backlight: lp855x: Add support ACPI enumeration

2021-11-01 Thread Hans de Goede
The Xiaomi Mi Pad 2 tablet uses an ACPI enumerated LP8556 backlight controller for its LCD-panel, with a Xiaomi specific ACPI HID of "XMCC0001", add support for this. Note the new "if (id)" check also fixes a NULL pointer deref when a user tries to manually bind the driver from sysfs. When CONFIG

[PATCH 2/3] backlight: lp855x: Add dev helper variable to lp855x_probe()

2021-11-01 Thread Hans de Goede
Add a dev local variable to the lp855x_probe(), to replace "&cl->dev" and "lp->dev" in various places. Also switch to dev_err_probe() in one case which takes care of not printing -EPROBE_DEFER errors for us. This is mostly a preparation for adding ACPI enumeration support which will use the new "

[PATCH v2 0/2] drm/i915: Failsafe migration blits

2021-11-01 Thread Thomas Hellström
This patch series introduces failsafe migration blits. The reason for this seemingly strange concept is that if the initial clearing or readback of LMEM fails for some reason[1], and we then set up either GPU- or CPU ptes to the allocated LMEM, we can expose old contents from other clients. So aft

[PATCH v2 2/2] drm/i915/ttm: Failsafe migration blits

2021-11-01 Thread Thomas Hellström
If the initial fill blit or copy blit of an object fails, the old content of the data might be exposed and read as soon as either CPU- or GPU PTEs are set up to point at the pages. Intercept the blit fence with an async callback that checks the blit fence for errors and if there are errors perform

[PATCH v2 1/2] drm/i915/ttm: Reorganize the ttm move code

2021-11-01 Thread Thomas Hellström
We are about to introduce failsafe- and asynchronous migration and ttm moves. This will add complexity and code to the TTM move code so it makes sense to split it out to a separate file to make the i915 TTM code easer to digest. Split the i915 TTM move code out and since we will have to change the

Re: [PATCH v3 24/34] drm/tilcdc: Migrate to aggregate driver

2021-11-01 Thread Jyri Sarha
On 2021-10-26 3:00, Stephen Boyd wrote: Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Jyri Sarha Cc: Tomi Valkeinen Cc: Daniel Vetter C

[Bug 214859] drm-amdgpu-init-iommu~fd-device-init.patch introduce bug

2021-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214859 --- Comment #2 from t...@siduction.org --- The relevant commit is 714d9e4574d54596973ee3b0624ee4a16264d700 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[Bug 214859] drm-amdgpu-init-iommu~fd-device-init.patch introduce bug

2021-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214859 t...@siduction.org changed: What|Removed |Added Kernel Version|5.14.15 |5.14.15, 5.15.0 Regression|N

Re: [PATCH 4/4] dt-bindings: gpu: Add ASPEED GFX bindings document

2021-11-01 Thread Rob Herring
On Mon, 01 Nov 2021 19:01:07 +0800, tommy-huang wrote: > Add ast2600-gfx description for gfx driver. > > Signed-off-by: tommy-huang > --- > Documentation/devicetree/bindings/gpu/aspeed-gfx.txt | 1 + > 1 file changed, 1 insertion(+) > Please add Acked-by/Reviewed-by tags when posting new vers

[Bug 214859] drm-amdgpu-init-iommu~fd-device-init.patch introduce bug

2021-11-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214859 --- Comment #3 from t...@siduction.org --- Additional info, after installing the kernel from a working system, 1st boot with that kernel is working flawless. Rebooting with that kernel and the boot is hanging a long time, then the desktop starts b

Re: [PATCH v2 0/3] drm/i915/guc/slpc: Implement waitboost for SLPC

2021-11-01 Thread Dixit, Ashutosh
On Sun, 31 Oct 2021 21:39:34 -0700, Belgaumkar, Vinay wrote: > > Waitboost is a legacy feature implemented in the Host Turbo algorithm. This > patch set implements it for the SLPC path. A "boost" happens when user > calls gem_wait ioctl on a submission that has not landed on HW yet. Afaiu user doe

Re: [PATCH 1/3] drm/i915/guc/slpc: Define and initialize boost frequency

2021-11-01 Thread Dixit, Ashutosh
On Sun, 31 Oct 2021 21:39:35 -0700, Belgaumkar, Vinay wrote: > > Define helpers and struct members required to record boost info. > Boost frequency is initialized to RP0 at SLPC init. Also define num_waiters > which can track the pending boost requests. > > Boost will be done by scheduling a worker

Re: [PATCH 2/3] drm/i915/guc/slpc: Add waitboost functionality for SLPC

2021-11-01 Thread Dixit, Ashutosh
On Sun, 31 Oct 2021 21:39:36 -0700, Belgaumkar, Vinay wrote: > > @@ -945,6 +960,17 @@ void intel_rps_boost(struct i915_request *rq) > if (!test_and_set_bit(I915_FENCE_FLAG_BOOST, &rq->fence.flags)) { > struct intel_rps *rps = &READ_ONCE(rq->engine)->gt->rps; > > + if

Re: [PATCH 3/3] drm/i915/guc/slpc: Update boost sysfs hooks for SLPC

2021-11-01 Thread Dixit, Ashutosh
On Sun, 31 Oct 2021 21:39:37 -0700, Belgaumkar, Vinay wrote: > > +static int set_boost_freq(struct intel_rps *rps, u32 val) Since this is legacy rps code path maybe change function name to rps_set_boost_freq?

Re: [PATCH v3 03/10] drm/i915: Restructure probe to handle multi-tile platforms

2021-11-01 Thread Andi Shyti
Hi Matt, On Thu, Oct 28, 2021 at 08:28:10PM -0700, Matt Roper wrote: > On a multi-tile platform, each tile has its own registers + GGTT space, > and BAR 0 is extended to cover all of them. Upcoming patches will start > exposing the tiles as multiple GTs within a single PCI device. In > preparati

Re: [PATCH v3 05/10] drm/i915: Prepare for multiple gts

2021-11-01 Thread Andi Shyti
Hi Matt and Tvrtko, [...] > static int > intel_gt_tile_setup(struct intel_gt *gt, unsigned int id, phys_addr_t > phys_addr) we don't actually need 'id', it's gt->info.id. It's introduced in patch 3 with the value '0' but it's not needed. > { > + struct drm_i915_private *i915 = gt->i915;

Re: [PATCH v3 03/10] drm/i915: Restructure probe to handle multi-tile platforms

2021-11-01 Thread Andi Shyti
Hi Matt, > +static int > +intel_gt_tile_setup(struct intel_gt *gt, unsigned int id, phys_addr_t > phys_addr) I have already r-b this, but, as I commented in patch 5, 'id' is redundant. Can we remove it? Andi > +{ > + int ret; > + > + intel_uncore_init_early(gt->uncore, gt->i915); > + >

Re: [PATCH v3 07/10] drm/i915/xehp: Determine which tile raised an interrupt

2021-11-01 Thread Andi Shyti
Hi Matt and Paulo, > @@ -2771,40 +2771,45 @@ static inline void dg1_master_intr_enable(void > __iomem * const regs) > static irqreturn_t dg1_irq_handler(int irq, void *arg) > { > struct drm_i915_private * const i915 = arg; > + void __iomem * const t0_regs = i915->gt.uncore->regs; >

Re: [PATCH v3 09/10] drm/i915/guc: Update CT debug macro for multi-tile

2021-11-01 Thread Andi Shyti
Hi Matt and Michal, On Thu, Oct 28, 2021 at 08:28:16PM -0700, Matt Roper wrote: > From: Michal Wajdeczko > > Update CT debug macros by including tile ID in all messages. > > Cc: Michał Winiarski > Signed-off-by: Michal Wajdeczko > Signed-off-by: Matt Roper Reviewed-by: Andi Shyti Andi

Re: [PATCH v2 0/3] drm/i915/guc/slpc: Implement waitboost for SLPC

2021-11-01 Thread Belgaumkar, Vinay
On 11/1/2021 1:24 PM, Dixit, Ashutosh wrote: On Sun, 31 Oct 2021 21:39:34 -0700, Belgaumkar, Vinay wrote: Waitboost is a legacy feature implemented in the Host Turbo algorithm. This patch set implements it for the SLPC path. A "boost" happens when user calls gem_wait ioctl on a submission th

Re: [PATCH 2/3] drm/i915/guc/slpc: Add waitboost functionality for SLPC

2021-11-01 Thread Belgaumkar, Vinay
On 11/1/2021 1:28 PM, Dixit, Ashutosh wrote: On Sun, 31 Oct 2021 21:39:36 -0700, Belgaumkar, Vinay wrote: @@ -945,6 +960,17 @@ void intel_rps_boost(struct i915_request *rq) if (!test_and_set_bit(I915_FENCE_FLAG_BOOST, &rq->fence.flags)) { struct intel_rps *rps = &READ

RE: [PATCH 4/4] dt-bindings: gpu: Add ASPEED GFX bindings document

2021-11-01 Thread Tommy Huang
Hi Rob, Thanks for your comments. I got it. By Tommy > -Original Message- > From: Rob Herring > Sent: Tuesday, November 2, 2021 4:02 AM > To: Tommy Huang > Cc: dri-devel@lists.freedesktop.org; linux-arm-ker...@lists.infradead.org; > linux-asp...@lists.ozlabs.org

Re: [PATCH 1/3] drm/i915/guc/slpc: Define and initialize boost frequency

2021-11-01 Thread Belgaumkar, Vinay
On 11/1/2021 1:26 PM, Dixit, Ashutosh wrote: On Sun, 31 Oct 2021 21:39:35 -0700, Belgaumkar, Vinay wrote: Define helpers and struct members required to record boost info. Boost frequency is initialized to RP0 at SLPC init. Also define num_waiters which can track the pending boost requests.

[PATCH v3 0/3] drm/i915/guc/slpc: Implement waitboost for SLPC

2021-11-01 Thread Vinay Belgaumkar
Waitboost is a legacy feature implemented in the Host Turbo algorithm. This patch set implements it for the SLPC path. A boost can happen when a request is waiting for an unmet dependency. GT frequency gets temporarily bumped to boost freq to allow the previous request to finish quickly. We achieve

[PATCH 1/3] drm/i915/guc/slpc: Define and initialize boost frequency

2021-11-01 Thread Vinay Belgaumkar
Define helpers and struct members required to record boost info. Boost frequency is initialized to RP0 at SLPC init. Also define num_waiters which can track the pending boost requests. Boost will be done by scheduling a worker thread. This will avoid the need to make H2G calls inside an interrupt

[PATCH 2/3] drm/i915/guc/slpc: Add waitboost functionality for SLPC

2021-11-01 Thread Vinay Belgaumkar
Add helper in RPS code for handling SLPC and non-SLPC paths. When boost is requested in the SLPC path, we can ask GuC to ramp up the frequency req by setting the minimum frequency to boost freq. Reset freq back to the min softlimit when there are no more waiters. v2: Schedule a worker thread which

[PATCH 3/3] drm/i915/guc/slpc: Update boost sysfs hooks for SLPC

2021-11-01 Thread Vinay Belgaumkar
Add a helper to sort through the SLPC/RPS paths of get/set methods. Boost frequency will be modified as long as it is within the constraints of RP0 and if it is different from the existing one. We will set min freq to boost only if there is at least one active waiter. v2: Add num_boosts to guc_slp

Re: [PATCH v3 0/3] drm/i915/guc/slpc: Implement waitboost for SLPC

2021-11-01 Thread Dixit, Ashutosh
On Mon, 01 Nov 2021 18:26:05 -0700, Vinay Belgaumkar wrote: > > Waitboost is a legacy feature implemented in the Host Turbo algorithm. This > patch set implements it for the SLPC path. A boost can happen when a request > is waiting for an unmet dependency. GT frequency gets temporarily bumped to >

Re: [PATCH v7 3/3] drm/bridge: anx7625: config hs packets end aligned to avoid screen shift

2021-11-01 Thread Xin Ji
On Mon, Nov 01, 2021 at 11:16:15AM +0800, Jitao Shi wrote: > Hi Xin, > > Please help to review the changes in anx7625.c > > On Thu, 2021-09-16 at 06:31 +0800, Jitao Shi wrote: > > This device requires the packets on lanes aligned at the end to fix > > screen shift or scroll. > > > > Signed-off-b

RE: [PATCH v2] drm/dp: Fix aux->transfer NULL pointer dereference on drm_dp_dpcd_access

2021-11-01 Thread Yuan, Perry
[AMD Official Use Only] Hi Jani: Thanks for your comments. > -Original Message- > From: Jani Nikula > Sent: Monday, November 1, 2021 9:07 PM > To: Yuan, Perry ; Maarten Lankhorst > ; Maxime Ripard ; > Thomas Zimmermann ; David Airlie ; > Daniel Vetter > Cc: Yuan, Perry ; dri-devel@lists

[PATCH] drm/exynos: Replace legacy gpio interface for gpiod interface

2021-11-01 Thread Maíra Canal
Considering the current transition of the GPIO subsystem, remove all dependencies of the legacy GPIO interface (linux/gpio.h and linux /of_gpio.h) and replace it with the descriptor-based GPIO approach. Signed-off-by: Maíra Canal --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 42 +

Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector

2021-11-01 Thread He Ying
在 2021/11/1 21:02, Jani Nikula 写道: On Mon, 01 Nov 2021, He Ying wrote: From the comments of drm_for_each_connector_iter(), we know that "connector is only valid within the list body, if you want to use connector after calling drm_connector_list_iter_end() then you need to grab your own refer