Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-10-18 Thread Dafna Hirschfeld
On 16.10.21 04:23, Yong Wu wrote: On Mon, 2021-10-11 at 14:36 +0200, Dafna Hirschfeld wrote: On 29.09.21 03:37, Yong Wu wrote: MediaTek IOMMU-SMI diagram is like below. all the consumer connect with smi-larb, then connect with smi-common. M4U | smi-common

Re: [PATCH] dt-bindings: display: xilinx: Fix example with psgtr

2021-10-18 Thread Laurent Pinchart
Hi Michal, Thank you for the patch. On Mon, Oct 18, 2021 at 08:40:12AM +0200, Michal Simek wrote: > Commit cea0f76a483d ("dt-bindings: phy: Add DT bindings for Xilinx ZynqMP > PSGTR PHY") clearly defines #phy-cells as 4. In past 5 cells were used by > it never went to upstream. That's why fix exa

Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-18 Thread Neil Armstrong
Hi, On 16/10/2021 00:34, Martin Blumenstingl wrote: > Hi Neil, Hi Sam, > > On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong > wrote: > [...] >> +static const struct drm_bridge_funcs meson_encoder_cvbs_bridge_funcs = { >> + .attach = meson_encoder_cvbs_attach, >> + .enable = meson_enco

Re: [PATCH v2 4/6] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2021-10-18 Thread Neil Armstrong
Hi, On 16/10/2021 00:07, Martin Blumenstingl wrote: > Hi Neil, > > On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong > wrote: >> >> This implements the necessary change to no more use the embedded >> connector in dw-hdmi and use the dedicated bridge connector driver >> by passing DRM_BRIDGE_ATTACH

Re: [PATCH 0/6] Refactor the vkms to accept new formats

2021-10-18 Thread Pekka Paalanen
On Tue, 5 Oct 2021 17:16:31 -0300 Igor Matheus Andrade Torrente wrote: > XRGB to ARGB behavior > = > During the development, I decided to always fill the alpha channel of > the output pixel whenever the conversion from a format without an alpha > channel to ARGB16161616 is necess

Re: [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-18 Thread Tvrtko Ursulin
On 16/10/2021 00:47, Umesh Nerlige Ramappa wrote: With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using sh

[PATCH] gpu: drm: nouveau: switch over to vmemdup_user()

2021-10-18 Thread Qing Wang
This patch fixes the following Coccinelle warning: drivers/gpu/drm/nouveau/nouveau_gem.c:630: WARNING opportunity for vmemdup_user Use vmemdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Signed-off-by: Qing Wang --- drivers/gpu/drm/

[PATCH] gpu: drm: tegra: switch over to vmemdup_user()

2021-10-18 Thread Qing Wang
This patch fixes the following Coccinelle warning: drivers/gpu/drm/tegra/submit.c:173:8-15: WARNING \ opportunity for vmemdup_user Use vmemdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Signed-off-by: Qing Wang ---

Re: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-18 Thread Maxime Ripard
Hi Simon, On Fri, Oct 15, 2021 at 04:33:45PM +, Simon Ser wrote: > If an hotplug event only updates a single connector, use > drm_kms_helper_connector_hotplug_event instead of > drm_kms_helper_hotplug_event. > > Signed-off-by: Simon Ser I guess we'd also need to update drm_connector_helper_

Re: [PATCH v2 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-18 Thread Das, Nirmoy
On 10/17/2021 10:03 PM, Lukas Wunner wrote: On Wed, Oct 13, 2021 at 08:36:01PM +0200, Nirmoy Das wrote: Debugfs APIs returns encoded error on failure so use debugfs_lookup() instead of checking for NULL. The commit message no longer matches up with the patch itself (debugfs_lookup() isn't cal

Re: [PATCH 6/6] drm: vkms: Refactor the plane composer to accept new formats

2021-10-18 Thread Pekka Paalanen
On Tue, 5 Oct 2021 17:16:37 -0300 Igor Matheus Andrade Torrente wrote: > Currently the blend function only accepts XRGB_ and ARGB_ > as a color input. > > This patch refactors all the functions related to the plane composition > to overcome this limitation. > > Now the blend function r

[PATCH linux-next] drm/i915/display: Remove unused assignment

2021-10-18 Thread luo penghao
The assignment will be overwritten by the later, but the variable is not used. The clang_analyzer complains as follows: drivers/gpu/drm/i915/display/intel_dpll.c:1568:2 warning: Value stored to 'dpio_val' is never read Reported-by: Zeal Robot Signed-off-by: luo penghao --- drivers/gpu/drm/i9

[PATCH linux-next] drm/i915/display: Remove unused variable and corresponding assignment

2021-10-18 Thread luo penghao
Variable is not used in functions, and its assignment is redundant too. So it should be deleted. The clang_analyzer complains as follows: drivers/gpu/drm/i915/display/vlv_dsi.c:143:2 warning: Value stored to 'data' is never read. Reported-by: Zeal Robot Signed-off-by: luo penghao --- drivers

Re: [PATCH 1/3] drm/dp: add helpers to read link training delays

2021-10-18 Thread Maxime Ripard
Hi Jani, On Fri, Oct 15, 2021 at 06:21:35PM +0300, Jani Nikula wrote: > On Thu, 14 Oct 2021, Jani Nikula wrote: > > The link training delays are different and/or available in different > > DPCD offsets depending on: > > > > - Clock recovery vs. channel equalization > > - DPRX vs. LTTPR > > - 128b

Re: [PATCH v3 6/6] i915/display/dp: send a more fine-grained link-status uevent

2021-10-18 Thread Simon Ser
On Friday, October 15th, 2021 at 21:44, Ville Syrjälä wrote: > > /* Send Hotplug uevent so userspace can reprobe */ > > drm_kms_helper_hotplug_event(connector->dev); > > + drm_sysfs_connector_status_event(connector, > > + > > connector->dev->mode_con

Re: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-18 Thread Simon Ser
On Friday, October 15th, 2021 at 21:41, Ville Syrjälä wrote: > So many things that "changed". Would it not be simpler to just grab the > first changed connector always, and count how many there were in total? Indeed, sounds much better. Will do that in the next version.

[PATCH linux-next] drm/i915/display: Remove unused variable and its assignment.

2021-10-18 Thread luo penghao
Variable is not used in functions, and its assignment is redundant too. So it should be deleted. The clang_analyzer complains as follows: drivers/gpu/drm/i915/display/intel_dpll.c:1653:2 warning: Value stored to 'bestm1' is never read. drivers/gpu/drm/i915/display/intel_dpll.c:1651:2 warning: Va

Re: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-18 Thread Simon Ser
On Monday, October 18th, 2021 at 10:15, Maxime Ripard wrote: > I guess we'd also need to update drm_connector_helper_hpd_irq_event ? Good catch! IIRC this function didn't exist when I first wrote the patchset.

[PATCH linux-next] drm/i915/display: Remove unused variable in the for loop.

2021-10-18 Thread luo penghao
Variable is not used in the loop, and its assignment is redundant too. So it should be deleted. The clang_analyzer complains as follows: drivers/gpu/drm/i915/display/intel_fb.c:1018:3 warning: Value stored to 'cpp' is never read. Reported-by: Zeal Robot Signed-off-by: luo penghao --- drivers

Re: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-18 Thread Simon Ser
On Friday, October 15th, 2021 at 22:03, Sam Ravnborg wrote: > This code is a little confusing to read. > > In case we have only one connector with a change we hit the else part. > What we really want to find out is if we have one or more connectors > with a change. > We could do something like: >

[PATCH linux-next] drm: Remove unused variable and its assignment.

2021-10-18 Thread luo penghao
The assignment in these two places is meaningless, so it should be deleted. The clang_analyzer complains as follows: drivers/gpu/drm/drm_crtc_helper.c:635:2 warning: Value stored to 'count' is never read. drivers/gpu/drm/drm_crtc_helper.c:681:2 warning: Value stored to 'count' is never read. Re

[PATCH v4 0/6] drm: add per-connector hotplug events

2021-10-18 Thread Simon Ser
When a uevent only updates a single connector, add a CONNECTOR property to the uevent. This allows user-space to ignore other connectors when handling the uevent. This is purely an optimization, drivers can still send a uevent without the CONNECTOR property. The CONNECTOR property is already set w

[PATCH v4 4/6] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-10-18 Thread Simon Ser
When updating a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_

[PATCH v4 2/6] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-10-18 Thread Simon Ser
This function is the same as drm_kms_helper_hotplug_event, but takes a connector instead of a device. Signed-off-by: Simon Ser Reviewed-by: Sam Ravnborg Acked-by: Harry Wentland --- drivers/gpu/drm/drm_probe_helper.c | 23 +++ include/drm/drm_probe_helper.h | 1 + 2 fi

[PATCH v4 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-18 Thread Simon Ser
If an hotplug event only updates a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Changes in v4: - Simplify loop logic (Ville, Sam) - Update drm_connector_helper_hpd_irq_event (Maxime) Signed-off-by: Simon Ser Cc: Ville Syrjala Cc: Sam Ravn

[PATCH v4 3/6] drm/connector: use drm_sysfs_connector_hotplug_event

2021-10-18 Thread Simon Ser
In drm_connector_register, use drm_sysfs_connector_hotplug_event instead of drm_sysfs_hotplug_event, because the hotplug event only updates a single connector. Signed-off-by: Simon Ser Reviewed-by: Sam Ravnborg Acked-by: Harry Wentland --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed

[PATCH v4 6/6] i915/display/dp: send a more fine-grained link-status uevent

2021-10-18 Thread Simon Ser
When link-status changes, send a hotplug uevent which contains the connector ID. That way, user-space can more easily figure out that only this connector has been updated. Changes in v4: avoid sending two uevents (Ville) Signed-off-by: Simon Ser Cc: Ville Syrjala --- drivers/gpu/drm/i915/displ

[PATCH v4 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-18 Thread Simon Ser
This function sends a hotplug uevent with a CONNECTOR property. Signed-off-by: Simon Ser Reviewed-by: Sam Ravnborg Acked-by: Harry Wentland --- drivers/gpu/drm/drm_sysfs.c | 25 + include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+) diff --git a/driver

[PATCH] drm/locking: fix __stack_depot_* name conflict

2021-10-18 Thread Jani Nikula
From: Stephen Rothwell Commit cd06ab2fd48f ("drm/locking: add backtrace for locking contended locks without backoff") added functions named __stack_depot_* in drm which conflict with stack depot. Rename to __drm_stack_depot_*. v2 by Jani: - Also rename __stack_depot_print References: https://lo

Re: [PATCH RFC 2/2] drm: introduce CLOSEFB IOCTL

2021-10-18 Thread Simon Ser
Thanks for having a look at this patch, Pekka! On Friday, October 8th, 2021 at 09:29, Pekka Paalanen wrote: > > +#define DRM_IOCTL_MODE_CLOSEFB DRM_IOWR(0xCF, unsigned int) > > Should it have a structure with 'flags' for future-proofing? > > ISTR some rule of thumb that everything n

Re: [PATCH linux-next] drm/i915/display: Remove unused variable and its assignment.

2021-10-18 Thread Ville Syrjälä
On Mon, Oct 18, 2021 at 08:43:31AM +, luo penghao wrote: > Variable is not used in functions, and its assignment is redundant too. > So it should be deleted. > > The clang_analyzer complains as follows: > > drivers/gpu/drm/i915/display/intel_dpll.c:1653:2 warning: > Value stored to 'bestm1' i

[PATCH linux-next] drm/i915: Remove redundant assignments

2021-10-18 Thread luo penghao
From: penghao luo The assignment of variables will be overwritten later, so the assignment here is meaningless. The clang_analyzer complains as follows: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:291: warning: Although the value stored to 'ret' is used in the enclosing expression, the value i

Re: [PATCH] drm/i915: Avoid bitwise vs logical OR warning in snb_wm_latency_quirk()

2021-10-18 Thread Ville Syrjälä
On Thu, Oct 14, 2021 at 02:21:43PM -0700, Nick Desaulniers wrote: > On Thu, Oct 14, 2021 at 2:19 PM Nathan Chancellor wrote: > > > > A new warning in clang points out a place in this file where a bitwise > > OR is being used with boolean types: > > > > drivers/gpu/drm/i915/intel_pm.c:3066:12: warn

Re: [PATCH RFC] virtio: wrap config->reset calls

2021-10-18 Thread Stefan Hajnoczi
On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote: > This will enable cleanups down the road. > The idea is to disable cbs, then add "flush_queued_cbs" callback > as a parameter, this way drivers can flush any work > queued after callbacks have been disabled. > > Signed-off-by: Mi

[PATCH v9 2/8] drm/i915/ttm: add tt shmem backend

2021-10-18 Thread Matthew Auld
For cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such objects. For now this is still disabled. v2(Thomas): - Add optional try_to_writeback hook for objects. Importantly we need to

[PATCH v9 3/8] drm/i915/gtt: drop unneeded make_unshrinkable

2021-10-18 Thread Matthew Auld
We already do this when mapping the pages. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 1 - drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/gen6_ppgtt

[PATCH v9 1/8] drm/i915/gem: Break out some shmem backend utils

2021-10-18 Thread Matthew Auld
From: Thomas Hellström Break out some shmem backend utils for future reuse by the TTM backend: shmem_alloc_st(), shmem_free_st() and __shmem_writeback() which we can use to provide a shmem-backed TTM page pool for cached-only TTM buffer objects. Main functional change here is that we now compute

[PATCH v9 6/8] drm/i915/ttm: move shrinker management into adjust_lru

2021-10-18 Thread Matthew Auld
We currently just evict lmem objects to system memory when under memory pressure. For this case we might lack the usual object mm.pages, which effectively hides the pages from the i915-gem shrinker, until we actually "attach" the TT to the object, or in the case of lmem-only objects it just gets mi

[PATCH v9 7/8] drm/i915/ttm: use cached system pages when evicting lmem

2021-10-18 Thread Matthew Auld
This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i9

Re: [PATCH linux-next] drm/i915/display: Remove unused variable in the for loop.

2021-10-18 Thread Jani Nikula
On Mon, 18 Oct 2021, luo penghao wrote: > Variable is not used in the loop, and its assignment is redundant too. > So it should be deleted. > > The clang_analyzer complains as follows: > > drivers/gpu/drm/i915/display/intel_fb.c:1018:3 warning: > > Value stored to 'cpp' is never read. > > Reported

[PATCH v9 5/8] drm/i915: add some kernel-doc for shrink_pin and friends

2021-10-18 Thread Matthew Auld
Attempt to document shrink_pin and the other relevant interfaces that interact with it, before we start messing with it. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 24 +- drivers/gpu/drm/i915/ge

[PATCH v9 4/8] drm/i915: drop unneeded make_unshrinkable in free_object

2021-10-18 Thread Matthew Auld
The comment here is no longer accurate, since the current shrinker code requires a full ref before touching any objects. Also unset_pages() should already do the required make_unshrinkable() for us, if needed, which is also nicely balanced with set_pages(). Signed-off-by: Matthew Auld Cc: Thomas

[PATCH v9 8/8] drm/i915/ttm: enable shmem tt backend

2021-10-18 Thread Matthew Auld
Turn on the shmem tt backend, and enable shrinking. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/driver

Re: [PATCH RFC] virtio: wrap config->reset calls

2021-10-18 Thread Stefano Garzarella
On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote: This will enable cleanups down the road. The idea is to disable cbs, then add "flush_queued_cbs" callback as a parameter, this way drivers can flush any work queued after callbacks have been disabled. Signed-off-by: Michael S. T

Re: [PATCH] drm/i915: Prefer struct_size over open coded arithmetic

2021-10-18 Thread Jani Nikula
On Sat, 16 Oct 2021, Len Baker wrote: > Hi Daniel and Jani, > > On Wed, Oct 13, 2021 at 01:51:30PM +0200, Daniel Vetter wrote: >> On Wed, Oct 13, 2021 at 02:24:05PM +0300, Jani Nikula wrote: >> > On Mon, 11 Oct 2021, Len Baker wrote: >> > > Hi, >> > > >> > > On Sun, Oct 03, 2021 at 12:42:58PM +02

Re: [PATCH 1/6] drm: vkms: Replace the deprecated drm_mode_config_init

2021-10-18 Thread Thomas Zimmermann
Hi Am 05.10.21 um 22:16 schrieb Igor Matheus Andrade Torrente: The `drm_mode_config_init` was deprecated since c3b790e commit, and it's being replaced by the `drmm_mode_config_init`. Signed-off-by: Igor Matheus Andrade Torrente --- drivers/gpu/drm/vkms/vkms_drv.c | 5 - 1 file changed,

Re: [PATCH 3/6] drm: vkms: Replace hardcoded value of `vkms_composer.map` to DRM_FORMAT_MAX_PLANES

2021-10-18 Thread Thomas Zimmermann
Hi Am 05.10.21 um 22:16 schrieb Igor Matheus Andrade Torrente: The `map` vector at `vkms_composer` uses a hardcoded value to define its size. If someday the maximum number of planes increases, this hardcoded value can be a problem. This value is being replaced with the DRM_FORMAT_MAX_PLANES ma

Re: [PATCH 4/6] drm: vkms: Add fb information to `vkms_writeback_job`

2021-10-18 Thread Thomas Zimmermann
Hi Am 05.10.21 um 22:16 schrieb Igor Matheus Andrade Torrente: This commit is the groundwork to introduce new formats to the planes and writeback buffer. As part of it, a new buffer metadata field is added to `vkms_writeback_job`, this metadata is represented by the `vkms_composer` struct. This

Re: [PATCH 5/6] drm: vkms: Prepare `vkms_wb_encoder_atomic_check` to accept multiple formats

2021-10-18 Thread Thomas Zimmermann
Hi Am 05.10.21 um 22:16 schrieb Igor Matheus Andrade Torrente: Currently, the vkms atomic check only goes through the first position of the `vkms_wb_formats` vector. This change prepares the atomic_check to check the entire vector. Signed-off-by: Igor Matheus Andrade Torrente --- drivers/gp

Re: [PATCH v2 1/5] [RFC]iommu: Add a IOMMU_DEVONLY protection flag

2021-10-18 Thread Joerg Roedel
On Fri, Oct 01, 2021 at 04:34:23PM +0200, Boris Brezillon wrote: > +/* > + * Mapping is only accessed by the device behind the iommu. That means other > + * devices or CPUs are not expected to access this physical memory region, > + * and the MMU driver can safely restrict the shareability domain t

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

2021-10-18 Thread Maarten Lankhorst
Op 14-10-2021 om 15:56 schreef Tvrtko Ursulin: > > On 14/10/2021 14:45, Maarten Lankhorst wrote: >> Op 14-10-2021 om 15:25 schreef Tvrtko Ursulin: >>> >>> On 14/10/2021 13:05, Maarten Lankhorst wrote: Op 14-10-2021 om 10:37 schreef Tvrtko Ursulin: > > On 13/10/2021 11:41, Maarten Lankh

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Fix dma_resv_wait_timeout handling of timeout = 0.

2021-10-18 Thread Christian König
Am 15.10.21 um 13:57 schrieb Maarten Lankhorst: Commit ada5c48b11a3 ("dma-buf: use new iterator in dma_resv_wait_timeout") accidentally started mishandling timeout = 0, by forcing a blocking wait with timeout = 1 passed to fences. This is not intended, as timeout = 0 may be used for peeking, simi

[PATCH V2] gpu: drm: tegra: switch over to vmemdup_user()

2021-10-18 Thread Qing Wang
This patch fixes the following Coccinelle warning: drivers/gpu/drm/tegra/submit.c:173: WARNING opportunity for vmemdup_user Use vmemdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Signed-off-by: Qing Wang --- drivers/gpu/drm

[PATCH V2] gpu: drm: nouveau: switch over to vmemdup_user()

2021-10-18 Thread Qing Wang
This patch fixes the following Coccinelle warning: drivers/gpu/drm/nouveau/nouveau_gem.c:630: WARNING opportunity for vmemdup_user Use vmemdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Signed-off-by: Qing Wang --- drivers/gpu/drm/

Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-18 Thread Christian König
Am 13.10.21 um 16:42 schrieb Arnd Bergmann: From: Arnd Bergmann When CONFIG_COMMON_CLOCK is disabled, the 8996 specific phy code is left out, which results in a link failure: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' This was only

Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-18 Thread Christian König
Am 18.10.21 um 13:38 schrieb Geert Uytterhoeven: Hi Christian, On Mon, Oct 18, 2021 at 1:37 PM Christian König wrote: Am 13.10.21 um 16:42 schrieb Arnd Bergmann: From: Arnd Bergmann When CONFIG_COMMON_CLOCK is disabled, the 8996 specific phy code is left out, which results in a link failure

Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-18 Thread Geert Uytterhoeven
Hi Christian, On Mon, Oct 18, 2021 at 1:37 PM Christian König wrote: > Am 13.10.21 um 16:42 schrieb Arnd Bergmann: > > From: Arnd Bergmann > > > > When CONFIG_COMMON_CLOCK is disabled, the 8996 specific > > phy code is left out, which results in a link failure: > > > > ld: drivers/gpu/drm/msm/hd

Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-18 Thread Arnd Bergmann
On Mon, Oct 18, 2021 at 1:40 PM Christian König wrote: > >> I have absolutely no idea how a platform can have IOMMU but no MMU > >> support but it indeed seems to be the case here. > > Huh? > > > > Parisc has config MMU def_bool y? > > Then why vmap isn't available? > > See the mail thread: [linux

Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-18 Thread Christian König
Am 18.10.21 um 13:46 schrieb Arnd Bergmann: On Mon, Oct 18, 2021 at 1:40 PM Christian König wrote: I have absolutely no idea how a platform can have IOMMU but no MMU support but it indeed seems to be the case here. Huh? Parisc has config MMU def_bool y? Then why vmap isn't available? See th

Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

2021-10-18 Thread Geert Uytterhoeven
Hi Christian, On Mon, Oct 18, 2021 at 1:41 PM Christian König wrote: > Am 18.10.21 um 13:38 schrieb Geert Uytterhoeven: > > On Mon, Oct 18, 2021 at 1:37 PM Christian König > > wrote: > >> Am 13.10.21 um 16:42 schrieb Arnd Bergmann: > >>> From: Arnd Bergmann > >>> > >>> When CONFIG_COMMON_CLOCK

Re: [PATCH v2 1/5] [RFC]iommu: Add a IOMMU_DEVONLY protection flag

2021-10-18 Thread Boris Brezillon
Hello Joerg, On Mon, 18 Oct 2021 12:25:38 +0200 Joerg Roedel wrote: > On Fri, Oct 01, 2021 at 04:34:23PM +0200, Boris Brezillon wrote: > > +/* > > + * Mapping is only accessed by the device behind the iommu. That means > > other > > + * devices or CPUs are not expected to access this physical m

Re: [PATCH linux-next] drm/i915/display: Remove unused variable in the for loop.

2021-10-18 Thread kernel test robot
Hi luo, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20211015] url: https://github.com/0day-ci/linux/commits/luo-penghao/drm-i915-display-Remove-unused-variable-in-the-for-loop/20211018-164557 base:7c832d2f9b959e3181370c8b0dacaf9efe13fc05 config

Re: [PATCH v3 07/10] drm/gma500: Inline psb_gtt_{alloc, free}_range() into rsp callers

2021-10-18 Thread Patrik Jakobsson
On Fri, Oct 15, 2021 at 10:40 AM Thomas Zimmermann wrote: > > psb_gtt_alloc_range() allocates struct gtt_range, create the GTT resource > and performs some half-baked initialization. Inline the function into its > only caller psb_gem_create(). For creating the GTT resource, introduce a > new helpe

Re: [PATCH v3 09/10] drm/gma500: Rewrite GTT page insert/remove without struct gtt_range

2021-10-18 Thread Patrik Jakobsson
On Fri, Oct 15, 2021 at 10:40 AM Thomas Zimmermann wrote: > > struct gtt_range represents a GEM object and should not be used for GTT > setup. Change psb_gtt_insert() and psb_gtt_remove() to receive all > necessary parameters from their caller. This also eliminates possible > failure from psb_gtt_

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-10-18 Thread Maxime Ripard
Hi Rob, On Wed, Oct 13, 2021 at 05:16:58PM -0700, Rob Clark wrote: > On Wed, Oct 13, 2021 at 7:16 AM Maxime Ripard wrote: > > > > Hi Caleb, > > > > On Thu, Sep 30, 2021 at 09:20:52PM +0100, Caleb Connolly wrote: > > > Hi, > > > > > > On 30/09/2021 20:49, Amit Pundir wrote: > > > > On Thu, 30 Sept

Re: [PATCH] drm: Remove redundant 'flush_workqueue()' calls

2021-10-18 Thread Christian Gmeiner
Am So., 10. Okt. 2021 um 16:08 Uhr schrieb Christophe JAILLET : > > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; >

Re: [PATCH for-next 1/3] dma-buf: Fix pin callback comment

2021-10-18 Thread Christian König
Am 12.10.21 um 14:09 schrieb Gal Pressman: The pin callback does not necessarily have to move the memory to system memory, remove the sentence from the comment. Signed-off-by: Gal Pressman Reviewed-by: Christian König --- include/linux/dma-buf.h | 4 ++-- 1 file changed, 2 insertions(+)

[PATCH 5.14 025/151] drm/fbdev: Clamp fbdev surface size if too large

2021-10-18 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit b693e42921e0220c0d564c55c6cdc680b0f85390 upstream. Clamp the fbdev surface size of the available maximumi height to avoid failing to init console emulation. An example error is shown below. bad framebuffer height 2304, should be >= 768 && <= 768 [drm] Initiali

Re: [PATCH v6] dt-bindings: drm/msm/gpu: convert to YAML

2021-10-18 Thread Rob Herring
On Sun, 17 Oct 2021 16:43:50 +0200, David Heidelberg wrote: > Conversion of text binding for Adreno GPU to the YAML format. > > Signed-off-by: David Heidelberg > --- > v2: > - added compatbile description from Rob Clark > - dropped reg description > - reg numbers increased to 3 (since we al

[PATCH] drm: fix null-ptr-deref in drm_minor_alloc_release

2021-10-18 Thread Wang Hai
I got a null-ptr-deref report: BUG: kernel NULL pointer dereference, address: 0030 ... RIP: 0010:kobject_put+0x2a/0x180 ... Call Trace: put_device+0x25/0x30 drm_minor_alloc_release.cold+0x45/0x7f [drm] drm_managed_release+0x158/0x2d0 [drm] drm_dev_init+0x3a7/0x4a0 [drm] __devm_drm

Re: [PATCH] drm/tegra: mark nvdec_writel as inline

2021-10-18 Thread Thierry Reding
On Wed, Oct 13, 2021 at 04:40:58PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Without CONFIG_IOMMU_API, the nvdec_writel() function is > unused, causing a warning: > > drivers/gpu/drm/tegra/nvdec.c:48:13: error: 'nvdec_writel' defined but not > used [-Werror=unused-function] >48

Re: [PATCH] drm/tegra: mark nvdec PM functions as __maybe_unused

2021-10-18 Thread Thierry Reding
On Wed, Oct 13, 2021 at 04:41:36PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The resume helper is called conditionally and causes a harmless > warning when stubbed out: > > drivers/gpu/drm/tegra/nvdec.c:240:12: error: 'nvdec_runtime_resume' defined > but not used [-Werror=unused-fun

Re: [PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

2021-10-18 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Fri, Oct 15, 2021 at 04:11:04PM +0200, Neil Armstrong wrote: > This moves all the non-DW-HDMI code where it should be: > an encoder in the drm/meson core driver. > > The bridge functions are copied as-is, except: > - the encoder init uses the simple kms helpe

Re: [PATCH v4 2/7] dt-bindings: mediatek, dp: Add Display Port binding

2021-10-18 Thread Markus Schneider-Pargmann
Hi Rob, On Mon, Oct 11, 2021 at 07:43:16PM -0500, Rob Herring wrote: > On Mon, Oct 11, 2021 at 11:46:19AM +0200, Markus Schneider-Pargmann wrote: > > This controller is present on several mediatek hardware. Currently > > mt8195 and mt8395 have this controller without a functional difference, > > s

[Bug 205649] Daisy Chain (MST) Session Crash after Screen Lock Resume

2021-10-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205649 --- Comment #5 from Michael Rauch (mich...@rauch.be) --- Created attachment 299241 --> https://bugzilla.kernel.org/attachment.cgi?id=299241&action=edit error messages with kernel 5.13 I still get errors and kernel freeze. -- You may reply to

[Bug 205649] Daisy Chain (MST) Session Crash after Screen Lock Resume

2021-10-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205649 Michael Rauch (mich...@rauch.be) changed: What|Removed |Added Kernel Version|5.3, 5.4, 5.5-rc3, 5.9-rc7 |5.3, 5.4, 5.5-rc3, 5.9-

[Bug 205649] Daisy Chain (MST) Session Crash after Screen Lock Resume --> amdgpu

2021-10-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205649 Michael Rauch (mich...@rauch.be) changed: What|Removed |Added Summary|Daisy Chain (MST) Session |Daisy Chain (MST) Sessi

[PATCH v6 0/9] drm/omap: Add virtual-planes support

2021-10-18 Thread Neil Armstrong
This patchset is the follow-up the v4 patchset from Benoit Parrot at [1]. This patch series adds virtual-plane support to omapdrm driver to allow the use of display wider than 2048 pixels. In order to do so we introduce the concept of hw_overlay which can then be dynamically allocated to a plane.

[PATCH v6 3/9] drm/omap: Add ovl checking funcs to dispc_ops

2021-10-18 Thread Neil Armstrong
From: Benoit Parrot In order to be able to dynamically assign overlays to planes we need to be able to asses the overlay capabilities. Add a helper function to be able to retrieve the supported capabilities of an overlay. And export the function to check if a fourcc is supported on a given over

[PATCH v6 4/9] drm/omap: introduce omap_hw_overlay

2021-10-18 Thread Neil Armstrong
From: Benoit Parrot Split out the hardware overlay specifics from omap_plane. To start, the hw overlays are statically assigned to planes. The goal is to eventually assign hw overlays dynamically to planes during plane->atomic_check() based on requested caps (scaling, YUV, etc). And then perform

[PATCH v6 8/9] drm/omap: add plane_atomic_print_state support

2021-10-18 Thread Neil Armstrong
From: Benoit Parrot Now that we added specific item to our subclassed drm_plane_state we can add omap_plane_atomic_print_state() helper to dump out our own driver specific plane state. Signed-off-by: Benoit Parrot Signed-off-by: Neil Armstrong --- drivers/gpu/drm/omapdrm/omap_plane.c | 16 +++

[PATCH v6 7/9] drm/omap: dynamically assign hw overlays to planes

2021-10-18 Thread Neil Armstrong
From: Benoit Parrot (re)assign the hw overlays to planes based on required caps, and to handle situations where we could not modify an in-use plane. This means all planes advertise the superset of formats and properties. Userspace must (as always) use atomic TEST_ONLY step for atomic updates, as

[PATCH v6 1/9] drm/omap: add sanity plane state check

2021-10-18 Thread Neil Armstrong
Call drm_atomic_helper_check_plane_state() from the plane atomic_check() callback in order to add plane state sanity checking. It will permit filtering out totally bad scaling factors, even if the real check are done later in the atomic commit. Signed-off-by: Benoit Parrot Signed-off-by: Neil Ar

[PATCH v6 6/9] drm/omap: Add global state as a private atomic object

2021-10-18 Thread Neil Armstrong
From: Benoit Parrot Global shared resources (like hw overlays) for omapdrm are implemented as a part of atomic state using the drm_private_obj infrastructure available in the atomic core. omap_global_state is introduced as a drm atomic private object. The two funcs omap_get_global_state() and om

[PATCH v6 2/9] drm/omap: Add ability to check if requested plane modes can be supported

2021-10-18 Thread Neil Armstrong
From: Benoit Parrot We currently assume that an overlay has the same maximum width and maximum height as the overlay manager. This assumption is incorrect. On some variants the overlay manager maximum width is twice the maximum width that the overlay can handle. We need to add the appropriate dat

[PATCH v6 9/9] drm/omap: Add a 'right overlay' to plane state

2021-10-18 Thread Neil Armstrong
From: Benoit Parrot If the drm_plane has a source width that's greater than the max width supported by a single hw overlay, then we assign a 'r_overlay' to it in omap_plane_atomic_check(). Both overlays should have the capabilities required to handle the source framebuffer. The only parameters t

[PATCH v6 5/9] drm/omap: omap_plane: subclass drm_plane_state

2021-10-18 Thread Neil Armstrong
From: Benoit Parrot In preparation to add omap plane state specific extensions we need to subclass drm_plane_state and add the relevant helpers. The addition of specific extension will be done separately. Signed-off-by: Benoit Parrot Signed-off-by: Neil Armstrong --- drivers/gpu/drm/omapdrm/

[PATCH v2] dt-bindings: display/bridge: tc358767: Convert to YAML binding

2021-10-18 Thread AngeloGioacchino Del Regno
Convert the Toshiba TC358767 txt documentation to YAML. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring --- .../display/bridge/toshiba,tc358767.txt | 54 .../display/bridge/toshiba,tc358767.yaml | 118 ++ 2 files changed, 118 insertions(+

[PATCH v2] dt-bindings: display/bridge: tc358764: Convert to YAML binding

2021-10-18 Thread AngeloGioacchino Del Regno
Convert the Toshiba TC358764 txt documentation to YAML. Signed-off-by: AngeloGioacchino Del Regno --- Note: dtbs_check on exynos5250-arndale.dts will give some warnings after applying this patch: since the preferred way is to have 'ports', this warning was ignored. I have no Ex

Re: [PATCH v2 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-18 Thread Maxime Ripard
On Sat, Oct 16, 2021 at 05:34:59AM +0300, Laurent Pinchart wrote: > On Thu, Oct 14, 2021 at 09:41:10AM +0200, Maxime Ripard wrote: > > On Wed, Oct 13, 2021 at 12:37:47PM +0300, Laurent Pinchart wrote: > > > On Wed, Oct 13, 2021 at 09:47:22AM +0200, Maxime Ripard wrote: > > > > On Tue, Oct 12, 2021

[PATCH] drm/msm/devfreq: Restrict idle clamping to a618 for now

2021-10-18 Thread Rob Clark
From: Rob Clark Until we better understand the stability issues caused by frequent frequency changes, lets limit them to a618. Signed-off-by: Rob Clark --- Caleb/John, I think this should help as a workaround for the power instability issues on a630.. could you give it a try? drivers/gpu/drm/

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-10-18 Thread Rob Clark
On Mon, Oct 18, 2021 at 5:34 AM Maxime Ripard wrote: > > Hi Rob, > > On Wed, Oct 13, 2021 at 05:16:58PM -0700, Rob Clark wrote: > > On Wed, Oct 13, 2021 at 7:16 AM Maxime Ripard wrote: > > > > > > Hi Caleb, > > > > > > On Thu, Sep 30, 2021 at 09:20:52PM +0100, Caleb Connolly wrote: > > > > Hi, >

Re: [PATCH] drm/msm/devfreq: Restrict idle clamping to a618 for now

2021-10-18 Thread John Stultz
On Mon, Oct 18, 2021 at 8:31 AM Rob Clark wrote: > > From: Rob Clark > > Until we better understand the stability issues caused by frequent > frequency changes, lets limit them to a618. > > Signed-off-by: Rob Clark > --- > Caleb/John, I think this should help as a workaround for the power > inst

Re: [PATCH 2/3] drm/amdgpu:move vram manager defines into a header file

2021-10-18 Thread Christian König
Am 13.10.21 um 15:38 schrieb Arunpravin: Move vram related defines and inline functions into a separate header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 72 1 file changed, 72 insertions(+) create mode 100644 drivers/gpu/drm/amd/

Re: [PATCH] drm/msm/devfreq: Restrict idle clamping to a618 for now

2021-10-18 Thread Caleb Connolly
Hi all, On 18/10/2021 17:42, John Stultz wrote: On Mon, Oct 18, 2021 at 8:31 AM Rob Clark wrote: From: Rob Clark Until we better understand the stability issues caused by frequent frequency changes, lets limit them to a618. Signed-off-by: Rob Clark --- Caleb/John, I think this should help

Re: [PATCH 5/6] drm: vkms: Prepare `vkms_wb_encoder_atomic_check` to accept multiple formats

2021-10-18 Thread Igor Matheus Andrade Torrente
Hello, On 10/18/21 7:14 AM, Thomas Zimmermann wrote: Hi Am 05.10.21 um 22:16 schrieb Igor Matheus Andrade Torrente: Currently, the vkms atomic check only goes through the first position of the `vkms_wb_formats` vector. This change prepares the atomic_check to check the entire vector. Signed-

Re: [PATCH v2 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-18 Thread Laurent Pinchart
Hi Maxime, On Mon, Oct 18, 2021 at 05:20:13PM +0200, Maxime Ripard wrote: > On Sat, Oct 16, 2021 at 05:34:59AM +0300, Laurent Pinchart wrote: > > On Thu, Oct 14, 2021 at 09:41:10AM +0200, Maxime Ripard wrote: > > > On Wed, Oct 13, 2021 at 12:37:47PM +0300, Laurent Pinchart wrote: > > > > On Wed, O

[PATCH 1/9] drm/i915: mark dmabuf objects as ALLOC_USER

2021-10-18 Thread Matthew Auld
These are userspace objects, so mark them as such. In a later patch it's useful to determine how paranoid we need to be when managing cache flushes. In theory no functional changes. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++- 1 file c

[PATCH 2/9] drm/i915: mark userptr objects as ALLOC_USER

2021-10-18 Thread Matthew Auld
These are userspace objects, so mark them as such. In a later patch it's useful to determine how paranoid we need to be when managing cache flushes. In theory no functional changes. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 3 ++- 1 file

[PATCH 6/9] drm/i915/shmem: ensure flush during swap-in on non-LLC

2021-10-18 Thread Matthew Auld
On non-LLC platforms, force the flush-on-acquire if this is ever swapped-in. Our async flush path is not trust worthy enough yet(and happens in the wrong order), and with some tricks it's conceivable for userspace to change the cache-level to I915_CACHE_NONE after the pages are swapped-in, and sinc

  1   2   >