[PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Alex Sierra
From: Ralph Campbell ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need to check the reference count to see that a page is not being used (gup, compaction, migration, etc.). Clean up the code so the reference

[PATCH v1 0/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Alex Sierra
This patch cleans up ZONE_DEVICE page refcounting. Quoting Matthew Wilcox, "it removes a ton of cruft from every call to put_page()" This work was originally done by Ralph Campbell and submitted as RFC. As of today, it has been ack by Theodore Ts'o / Darrick J. Wong, and reviewed by Christoph Hellw

[PATCH v1 1/2] ext4/xfs: add page refcount helper

2021-10-14 Thread Alex Sierra
From: Ralph Campbell There are several places where ZONE_DEVICE struct pages assume a reference count == 1 means the page is idle and free. Instead of open coding this, add a helper function to hide this detail. Signed-off-by: Ralph Campbell Signed-off-by: Alex Sierra Reviewed-by: Christoph He

Re: Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Steev Klimaszewski
On 10/14/21 8:54 AM, Dmitry Baryshkov wrote: From: Amit Pundir This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. This upstream commit broke AOSP (post Android 12 merge) build on RB5. The device either silently crashes into USB crash mode after android boot animation or we see a b

Re: [PATCH 2/3] drm/dp: reuse the 8b/10b link training delay helpers

2021-10-14 Thread Ville Syrjälä
On Thu, Oct 14, 2021 at 06:00:58PM +0300, Jani Nikula wrote: > Reuse the 8b/10b link training delay helpers. Functionally this skips > the check for invalid values for DPCD 1.4 and later at clock recovery > delay (as it's a fixed delay and bypasses the rd_interval) but the same > value will be chec

Re: Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Steev Klimaszewski
On 10/14/21 10:42 AM, Steev Klimaszewski wrote: On 10/14/21 8:54 AM, Dmitry Baryshkov wrote: From: Amit Pundir This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. This upstream commit broke AOSP (post Android 12 merge) build on RB5. The device either silently crashes into USB cra

Re: [PATCH v3 5/6] drm/mediatek: dpi: Add dpintf support

2021-10-14 Thread Chun-Kuang Hu
Hi, Markus: Markus Schneider-Pargmann 於 2021年10月1日 週五 下午5:44寫道: > > dpintf is the displayport interface hardware unit. This unit is similar > to dpi and can reuse most of the code. > > This patch adds support for mt8195-dpintf to this dpi driver. Main > differences are: > - Some features/functio

Re: [PATCH v1 1/2] ext4/xfs: add page refcount helper

2021-10-14 Thread Jason Gunthorpe
On Thu, Oct 14, 2021 at 10:39:27AM -0500, Alex Sierra wrote: > From: Ralph Campbell > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-of

Re: [PATCH 14/25] drm/i915/guc: Implement multi-lrc reset

2021-10-14 Thread kernel test robot
patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211

Re: [PATCH v1 1/2] ext4/xfs: add page refcount helper

2021-10-14 Thread Matthew Wilcox
On Thu, Oct 14, 2021 at 10:39:27AM -0500, Alex Sierra wrote: > From: Ralph Campbell > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-of

Re: [PATCH 16/25] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-14 Thread John Harrison
On 10/14/2021 08:32, Matthew Brost wrote: On Wed, Oct 13, 2021 at 06:02:42PM -0700, John Harrison wrote: On 10/13/2021 13:42, Matthew Brost wrote: Introduce 'set parallel submit' extension to connect UAPI to GuC multi-lrc interface. Kernel doc in new uAPI should explain it all. IGT: https://pa

Re: [PATCH 16/25] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-14 Thread Matthew Brost
On Thu, Oct 14, 2021 at 09:43:36AM -0700, John Harrison wrote: > On 10/14/2021 08:32, Matthew Brost wrote: > > On Wed, Oct 13, 2021 at 06:02:42PM -0700, John Harrison wrote: > > > On 10/13/2021 13:42, Matthew Brost wrote: > > > > Introduce 'set parallel submit' extension to connect UAPI to GuC > >

[PATCH] video: omapfb: Fix fall-through warning for Clang

2021-10-14 Thread Gustavo A. R. Silva
Fix the following fallthrough warnings: drivers/video/fbdev/omap/omapfb_main.c:1558:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case 0: ^ drivers/video/fbdev/omap/omapfb_main.c:1558:2: note: insert 'break;' to avoid fall-through

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Matthew Wilcox
On Thu, Oct 14, 2021 at 10:39:28AM -0500, Alex Sierra wrote: > From: Ralph Campbell > > ZONE_DEVICE struct pages have an extra reference count that complicates the > code for put_page() and several places in the kernel that need to check the > reference count to see that a page is not being used

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Jason Gunthorpe
On Thu, Oct 14, 2021 at 10:39:28AM -0500, Alex Sierra wrote: > From: Ralph Campbell > > ZONE_DEVICE struct pages have an extra reference count that complicates the > code for put_page() and several places in the kernel that need to check the > reference count to see that a page is not being used

Re: [PATCH 11/25] drm/i915/guc: Implement parallel context pin / unpin functions

2021-10-14 Thread John Harrison
On 10/13/2021 13:42, Matthew Brost wrote: Parallel contexts are perma-pinned by the upper layers which makes the backend implementation rather simple. The parent pins the guc_id and children increment the parent's pin count on pin to ensure all the contexts are unpinned before we disable scheduli

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Ralph Campbell
On 10/14/21 10:06 AM, Jason Gunthorpe wrote: On Thu, Oct 14, 2021 at 10:39:28AM -0500, Alex Sierra wrote: From: Ralph Campbell ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need to check the reference cou

Re: [PATCH 16/25] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-14 Thread John Harrison
On 10/14/2021 09:41, Matthew Brost wrote: On Thu, Oct 14, 2021 at 09:43:36AM -0700, John Harrison wrote: On 10/14/2021 08:32, Matthew Brost wrote: On Wed, Oct 13, 2021 at 06:02:42PM -0700, John Harrison wrote: On 10/13/2021 13:42, Matthew Brost wrote: Introduce 'set parallel submit' extension

[PATCH 01/25] drm/i915/guc: Move GuC guc_id allocation under submission state sub-struct

2021-10-14 Thread Matthew Brost
Move guc_id allocation under submission state sub-struct as a future patch will reuse the spin lock as a global submission state lock. Moving this into sub-struct makes ownership of fields / lock clear. v2: (Docs) - Add comment for submission_state sub-structure v3: (John Harrison) - Fixup a

[PATCH 00/25] Parallel submission aka multi-bb execbuf

2021-10-14 Thread Matthew Brost
As discussed in [1] we are introducing a new parallel submission uAPI for the i915 which allows more than 1 BB to be submitted in an execbuf IOCTL. This is the implemenation for both GuC and execlists. In addition to selftests in the series, an IGT is available implemented in the first 4 patches [

[PATCH 03/25] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-10-14 Thread Matthew Brost
Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while any user context has scheduling enabled. Returning GT idle when it is not can cause all sorts of issues throughout the stack. v2: (Daniel Vetter) - Add might_lock annotations to pin / unpin function v3: (CI)

[PATCH 02/25] drm/i915/guc: Take GT PM ref when deregistering context

2021-10-14 Thread Matthew Brost
Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while a deregister context H2G is in flight. To do this must issue the deregister H2G from a worker as context can be destroyed from an atomic context and taking GT PM ref blows up. Previously we took a runtime PM from th

Re: [PATCH 1/7] drm/bridge: display-connector: implement bus fmts callbacks

2021-10-14 Thread Sam Ravnborg
Hi Neil, code looks fine. A few improvement proposals to the comments. With the include order fixed and the comments considered: Reviewed-by: Sam Ravnborg Sam On Thu, Oct 14, 2021 at 05:26:00PM +0200, Neil Armstrong wrote: > Since this bridge is tied to the connector, it acts like a pas

[PATCH 07/25] drm/i915/guc: Introduce context parent-child relationship

2021-10-14 Thread Matthew Brost
Introduce context parent-child relationship. Once this relationship is created all pinning / unpinning operations are directed to the parent context. The parent context is responsible for pinning all of its children and itself. This is a precursor to the full GuC multi-lrc implementation but align

[PATCH 10/25] drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_ids

2021-10-14 Thread Matthew Brost
Assign contexts in parent-child relationship consecutive guc_ids. This is accomplished by partitioning guc_id space between ones that need to be consecutive (1/16 available guc_ids) and ones that do not (15/16 of available guc_ids). The consecutive search is implemented via the bitmap API. This is

[PATCH 20/25] drm/i915: Multi-BB execbuf

2021-10-14 Thread Matthew Brost
Allow multiple batch buffers to be submitted in a single execbuf IOCTL after a context has been configured with the 'set_parallel' extension. The number batches is implicit based on the contexts configuration. This is implemented with a series of loops. First a loop is used to find all the batches

[PATCH 08/25] drm/i915/guc: Add multi-lrc context registration

2021-10-14 Thread Matthew Brost
Add multi-lrc context registration H2G. In addition a workqueue and process descriptor are setup during multi-lrc context registration as these data structures are needed for multi-lrc submission. v2: (John Harrison) - Move GuC specific fields into sub-struct - Clean up WQ defines - Add com

[PATCH 15/25] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-10-14 Thread Matthew Brost
Display the workqueue status in debugfs for GuC contexts that are in parent-child relationship. v2: (John Harrison) - Output number children in debugfs Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 52 ++- 1 file

[PATCH 17/25] drm/i915/doc: Update parallel submit doc to point to i915_drm.h

2021-10-14 Thread Matthew Brost
Update parallel submit doc to point to i915_drm.h Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- Documentation/gpu/rfc/i915_parallel_execbuf.h | 122 -- Documentation/gpu/rfc/i915_scheduler.rst | 4 +- 2 files changed, 2 insertions(+), 124 deletions(-) delet

[PATCH 11/25] drm/i915/guc: Implement parallel context pin / unpin functions

2021-10-14 Thread Matthew Brost
Parallel contexts are perma-pinned by the upper layers which makes the backend implementation rather simple. The parent pins the guc_id and children increment the parent's pin count on pin to ensure all the contexts are unpinned before we disable scheduling with the GuC / or deregister the context.

[PATCH 22/25] drm/i915: Make request conflict tracking understand parallel submits

2021-10-14 Thread Matthew Brost
If an object in the excl or shared slot is a composite fence from a parallel submit and the current request in the conflict tracking is from the same parallel context there is no need to enforce ordering as the ordering is already implicit. Make the request conflict tracking understand this by comp

[PATCH 21/25] drm/i915/guc: Handle errors in multi-lrc requests

2021-10-14 Thread Matthew Brost
If an error occurs in the front end when multi-lrc requests are getting generated we need to skip these in the backend but we still need to emit the breadcrumbs seqno. An issues arises because with multi-lrc breadcrumbs there is a handshake between the parent and children to make forward progress.

[PATCH 19/25] drm/i915/guc: Implement no mid batch preemption for multi-lrc

2021-10-14 Thread Matthew Brost
For some users of multi-lrc, e.g. split frame, it isn't safe to preempt mid BB. To safely enable preemption at the BB boundary, a handshake between parent and child is needed, syncing the set of BBs at the beginning and end of each batch. This is implemented via custom emit_bb_start & emit_fini_bre

[PATCH 24/25] drm/i915: Enable multi-bb execbuf

2021-10-14 Thread Matthew Brost
Enable multi-bb execbuf by enabling the set_parallel extension. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index 9a00

[PATCH 23/25] drm/i915: Update I915_GEM_BUSY IOCTL to understand composite fences

2021-10-14 Thread Matthew Brost
Parallel submission create composite fences (dma_fence_array) for excl / shared slots in objects. The I915_GEM_BUSY IOCTL checks these slots to determine the busyness of the object. Prior to patch it only check if the fence in the slot was a i915_request. Update the check to understand composite fe

[PATCH 25/25] drm/i915/execlists: Weak parallel submission support for execlists

2021-10-14 Thread Matthew Brost
A weak implementation of parallel submission (multi-bb execbuf IOCTL) for execlists. Doing as little as possible to support this interface for execlists - basically just passing submit fences between each request generated and virtual engines are not allowed. This is on par with what is there for t

[PATCH 06/25] drm/i915: Expose logical engine instance to user

2021-10-14 Thread Matthew Brost
Expose logical engine instance to user via query engine info IOCTL. This is required for split-frame workloads as these needs to be placed on engines in a logically contiguous order. The logical mapping can change based on fusing. Rather than having user have knowledge of the fusing we simply just

[PATCH 05/25] drm/i915: Add logical engine mapping

2021-10-14 Thread Matthew Brost
Add logical engine mapping. This is required for split-frame, as workloads need to be placed on engines in a logically contiguous manner. v2: (Daniel Vetter) - Add kernel doc for new fields v3: (Tvrtko) - Update comment for new logical_mask field v4: (John Harrison) - Update comment for n

[PATCH 04/25] drm/i915/guc: Don't call switch_to_kernel_context with GuC submission

2021-10-14 Thread Matthew Brost
Calling switch_to_kernel_context isn't needed if the engine PM reference is taken while all user contexts are pinned as if don't have PM ref that guarantees that all user contexts scheduling is disabled. By not calling switch_to_kernel_context we save on issuing a request to the engine. v2: (Dani

[PATCH 09/25] drm/i915/guc: Ensure GuC schedule operations do not operate on child contexts

2021-10-14 Thread Matthew Brost
In GuC parent-child contexts the parent context controls the scheduling, ensure only the parent does the scheduling operations. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 13 - 1 file changed, 12 insertions(+), 1 d

[PATCH 14/25] drm/i915/guc: Implement multi-lrc reset

2021-10-14 Thread Matthew Brost
Update context and full GPU reset to work with multi-lrc. The idea is parent context tracks all the active requests inflight for itself and its children. The parent context owns the reset replaying / canceling requests as needed. v2: (John Harrison) - Simply loop in find active request - Add

[PATCH 16/25] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-14 Thread Matthew Brost
Introduce 'set parallel submit' extension to connect UAPI to GuC multi-lrc interface. Kernel doc in new uAPI should explain it all. IGT: https://patchwork.freedesktop.org/patch/447008/?series=93071&rev=1 media UMD: https://github.com/intel/media-driver/pull/1252 v2: (Daniel Vetter) - Add IGT l

[PATCH 12/25] drm/i915/guc: Implement multi-lrc submission

2021-10-14 Thread Matthew Brost
Implement multi-lrc submission via a single workqueue entry and single H2G. The workqueue entry contains an updated tail value for each request, of all the contexts in the multi-lrc submission, and updates these values simultaneously. As such, the tasklet and bypass path have been updated to coales

[PATCH 18/25] drm/i915/guc: Add basic GuC multi-lrc selftest

2021-10-14 Thread Matthew Brost
Add very basic (single submission) multi-lrc selftest. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 1 + .../drm/i915/gt/uc/selftest_guc_multi_lrc.c | 179 ++ .../drm/i915/selftests/i915_live_selftests.h | 1 +

[PATCH 13/25] drm/i915/guc: Insert submit fences between requests in parent-child relationship

2021-10-14 Thread Matthew Brost
The GuC must receive requests in the order submitted for contexts in a parent-child relationship to function correctly. To ensure this, insert a submit fence between the current request and last request submitted for requests / contexts in a parent child relationship. This is conceptually similar t

Re: [PATCH 2/7] drm/meson: remove useless recursive components matching

2021-10-14 Thread Sam Ravnborg
Hi Neil, one comment below. Other than that Acked-by: Sam Ravnborg Sam On Thu, Oct 14, 2021 at 05:26:01PM +0200, Neil Armstrong wrote: > The initial design was recursive to cover all port/endpoints, but only the > first layer > of endpoints should be covered by the components list. > T

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Jason Gunthorpe
On Thu, Oct 14, 2021 at 10:35:27AM -0700, Ralph Campbell wrote: > I ran xfstests-dev using the kernel boot option to "fake" a pmem device > when I first posted this patch. The tests ran OK (or at least the same > tests passed with and without my patch). Hmm. I know nothing of xfstests but test

Re: [PATCH 3/7] drm/meson: split out encoder from meson_dw_hdmi

2021-10-14 Thread Sam Ravnborg
Hi Neil, I did not verify all the code movements - but it looked correct from a quick glance. A few comments below, especially the use of mode_set() should be addressed as it is deprecated. Sam On Thu, Oct 14, 2021 at 05:26:02PM +0200, Neil Armstrong wrote: > This moves all the non-DW-HD

Re: [PATCH 4/7] drm/bridge: synopsys: dw-hdmi: also allow interlace on bridge

2021-10-14 Thread Sam Ravnborg
On Thu, Oct 14, 2021 at 05:26:03PM +0200, Neil Armstrong wrote: > Since we allow interlace on the encoder, also allow it on the bridge > so we can allow interlaced modes when using DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Signed-off-by: Neil Armstrong Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/b

Re: [PATCH 7/7] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-14 Thread Sam Ravnborg
Hi Neil, with include order fixed and the comment below considered: Acked-by: Sam Ravnborg Sam On Thu, Oct 14, 2021 at 05:26:06PM +0200, Neil Armstrong wrote: > Drop the local connector and move all callback to bridge funcs in order > to leverage the generic CVBS diplay connector. > >

Re: [PATCH 6/7] drm/meson: rename venc_cvbs to encoder_cvbs

2021-10-14 Thread Sam Ravnborg
On Thu, Oct 14, 2021 at 05:26:05PM +0200, Neil Armstrong wrote: > Rename the cvbs encoder to match the newly introduced meson_encoder_hdmi. > > Signed-off-by: Neil Armstrong Acked-by: Sam Ravnborg

Re: [PATCH 08/25] drm/i915/guc: Add multi-lrc context registration

2021-10-14 Thread John Harrison
On 10/14/2021 10:19, Matthew Brost wrote: Add multi-lrc context registration H2G. In addition a workqueue and process descriptor are setup during multi-lrc context registration as these data structures are needed for multi-lrc submission. v2: (John Harrison) - Move GuC specific fields into

Re: [PATCH 5/7] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2021-10-14 Thread Sam Ravnborg
Hi Neil, On Thu, Oct 14, 2021 at 05:26:04PM +0200, Neil Armstrong wrote: > This implements the necessary change to no more use the embedded > connector in dw-hdmi and use the dedicated bridge connector driver > by passing DRM_BRIDGE_ATTACH_NO_CONNECTOR to the bridge attach call. > > The necessary

Re: [PATCH 16/25] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-14 Thread John Harrison
On 10/14/2021 10:19, Matthew Brost wrote: Introduce 'set parallel submit' extension to connect UAPI to GuC multi-lrc interface. Kernel doc in new uAPI should explain it all. IGT: https://patchwork.freedesktop.org/patch/447008/?series=93071&rev=1 media UMD: https://github.com/intel/media-driver/p

Re: [PATCH] video: omapfb: Fix fall-through warning for Clang

2021-10-14 Thread Sam Ravnborg
Hi Gustavo, On Thu, Oct 14, 2021 at 11:53:20AM -0500, Gustavo A. R. Silva wrote: > Fix the following fallthrough warnings: > > drivers/video/fbdev/omap/omapfb_main.c:1558:2: warning: unannotated > fall-through between switch labels [-Wimplicit-fallthrough] >case 0: >^ >

Re: [PATCH 20/25] drm/i915: Multi-BB execbuf

2021-10-14 Thread John Harrison
On 10/14/2021 10:20, Matthew Brost wrote: Allow multiple batch buffers to be submitted in a single execbuf IOCTL after a context has been configured with the 'set_parallel' extension. The number batches is implicit based on the contexts configuration. This is implemented with a series of loops.

Re: [PATCH 24/25] drm/i915: Enable multi-bb execbuf

2021-10-14 Thread John Harrison
On 10/14/2021 10:20, Matthew Brost wrote: Enable multi-bb execbuf by enabling the set_parallel extension. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem

Re: [PATCH] video: omapfb: Fix fall-through warning for Clang

2021-10-14 Thread Gustavo A. R. Silva
On Thu, Oct 14, 2021 at 08:26:52PM +0200, Sam Ravnborg wrote: > Hi Gustavo, > On Thu, Oct 14, 2021 at 11:53:20AM -0500, Gustavo A. R. Silva wrote: > > Fix the following fallthrough warnings: > > > > drivers/video/fbdev/omap/omapfb_main.c:1558:2: warning: unannotated > > fall-through between switc

Re: [PATCH v2 2/2] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-10-14 Thread Sam Ravnborg
Hi Oleksij, On Thu, Oct 14, 2021 at 11:52:02AM +0200, Oleksij Rempel wrote: > Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7" > WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. > > Co-Developed-by: Robin van der Gracht > Signed-off-by: Robin van der Gra

Re: [PATCH v3 1/7] drm/kmb: Work around for higher system clock

2021-10-14 Thread Sam Ravnborg
Hi Anitha, On Wed, Oct 13, 2021 at 04:36:26PM -0700, Anitha Chrisanthus wrote: > Use a different value for system clock offset in the > ppl/llp ratio calculations for clocks higher than 500 Mhz. > > Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver") > Signed-off-by: Anitha Chris

Re: Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Vladimir Zapolskiy
Hi Dmitry, On 10/14/21 4:54 PM, Dmitry Baryshkov wrote: From: Amit Pundir This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. This upstream commit broke AOSP (post Android 12 merge) build on RB5. The device either silently crashes into USB crash mode after android boot animation or

Re: [PATCH v3 2/7] drm/kmb: Limit supported mode to 1080p

2021-10-14 Thread Sam Ravnborg
On Wed, Oct 13, 2021 at 04:36:27PM -0700, Anitha Chrisanthus wrote: > KMB only supports single resolution(1080p), this commit checks for > 1920x1080x60 or 1920x1080x59 in crtc_mode_valid. > Also, modes with vfp < 4 are not supported in KMB display. This change > prunes display modes with vfp < 4. >

Re: [PATCH v3 3/7] drm/kmb: Remove clearing DPHY regs

2021-10-14 Thread Sam Ravnborg
On Wed, Oct 13, 2021 at 04:36:28PM -0700, Anitha Chrisanthus wrote: > From: Edmund Dea > > Don't clear the shared DPHY registers common to MIPI Rx and MIPI Tx during > DSI initialization since this was causing MIPI Rx reset. Rest of the > writes are bitwise, so will not affect Mipi Rx side. > >

Re: [PATCH v3 4/7] drm/kmb: Disable change of plane parameters

2021-10-14 Thread Sam Ravnborg
Hi Anitha, On Wed, Oct 13, 2021 at 04:36:29PM -0700, Anitha Chrisanthus wrote: > From: Edmund Dea > > Due to HW limitations, KMB cannot change height, width, or > pixel format after initial plane configuration. > > v2: removed memset disp_cfg as it is already zero. > > Fixes: 7f7b96a8a0a1 ("dr

Re: [PATCH v3 5/7] drm/kmb: Corrected typo in handle_lcd_irq

2021-10-14 Thread Sam Ravnborg
Hi Anitha, On Wed, Oct 13, 2021 at 04:36:30PM -0700, Anitha Chrisanthus wrote: > Check for Overflow bits for layer3 in the irq handler. > > Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") > Signed-off-by: Anitha Chrisanthus Obvious fix, Acked-by: Sam Ravnborg

Re: [PATCH 25/25] drm/i915/execlists: Weak parallel submission support for execlists

2021-10-14 Thread John Harrison
On 10/14/2021 10:20, Matthew Brost wrote: A weak implementation of parallel submission (multi-bb execbuf IOCTL) for execlists. Doing as little as possible to support this interface for execlists - basically just passing submit fences between each request generated and virtual engines are not allo

Re: [PATCH v3 6/7] drm/kmb: Enable ADV bridge after modeset

2021-10-14 Thread Sam Ravnborg
Hi Anitha, On Wed, Oct 13, 2021 at 04:36:31PM -0700, Anitha Chrisanthus wrote: > On KMB, ADV bridge must be programmed and powered on prior to > MIPI DSI HW initialization. > > Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver") > Signed-off-by: Anitha Chrisanthus > --- > driv

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Matthew Wilcox
It would probably help if you cc'd Dan on this. As far as I know he's the only person left who cares about GUP on DAX. On Thu, Oct 14, 2021 at 02:06:34PM -0300, Jason Gunthorpe wrote: > On Thu, Oct 14, 2021 at 10:39:28AM -0500, Alex Sierra wrote: > > From: Ralph Campbell > > > > ZONE_DEVICE st

Re: [PATCH] drm/panel-simple: Add Vivax TPC-9150 panel v6

2021-10-14 Thread Sam Ravnborg
Hi Nikola, On Mon, Oct 11, 2021 at 11:27:31PM +0200, Nikola Pavlica wrote: > The model and make of the LCD panel of the Vivax TPC-9150 is unknown, > hence the panel settings that were retrieved with a FEX dump are named > after the device NOT the actual panel. > > The LCD in question is a 50 pin M

Re: [PATCH v3] drm: of: Add drm_of_lvds_get_data_mapping

2021-10-14 Thread Sam Ravnborg
Hi Marek, On Wed, Oct 13, 2021 at 12:42:52AM +0200, Marek Vasut wrote: > Add helper function to convert DT "data-mapping" property string value > into media bus format value, and deduplicate the code in panel-lvds.c > and lvds-codec.c . > > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart > Cc

Re: [PATCH] drm/bridge: display-connector: fix an uninitialized pointer in probe()

2021-10-14 Thread Sam Ravnborg
Hi Dan, On Wed, Oct 13, 2021 at 11:08:25AM +0300, Dan Carpenter wrote: > The "label" pointer is used for debug output. The code assumes that it > is either NULL or valid, but it is never set to NULL. It is either > valid or uninitialized. > > Fixes: 0c275c30176b ("drm/bridge: Add bridge driver

Re: [PATCH 25/25] drm/i915/execlists: Weak parallel submission support for execlists

2021-10-14 Thread Matthew Brost
On Thu, Oct 14, 2021 at 11:42:41AM -0700, John Harrison wrote: > On 10/14/2021 10:20, Matthew Brost wrote: > > A weak implementation of parallel submission (multi-bb execbuf IOCTL) for > > execlists. Doing as little as possible to support this interface for > > execlists - basically just passing su

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Dan Williams
On Thu, Oct 14, 2021 at 11:45 AM Matthew Wilcox wrote: > > > It would probably help if you cc'd Dan on this. Thanks. [..] > > On Thu, Oct 14, 2021 at 02:06:34PM -0300, Jason Gunthorpe wrote: > > On Thu, Oct 14, 2021 at 10:39:28AM -0500, Alex Sierra wrote: > > > From: Ralph Campbell > > > > > >

Re: [PATCH] drm/bridge: Ignore -EPROBE_DEFER when bridge attach fails

2021-10-14 Thread Sam Ravnborg
Hi Guido, > > > > > > + if (ret != -EPROBE_DEFER) { > > > #ifdef CONFIG_OF > > > - DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n", > > > - bridge->of_node, encoder->name, ret); > > > + DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n", > > > +

Re: [PATCH] drm: fix null-ptr-deref in drm_dev_init_release()

2021-10-14 Thread Sam Ravnborg
Hi Wang, On Wed, Oct 13, 2021 at 07:41:39PM +0800, Wang Hai wrote: > I got a null-ptr-deref report: > > [drm:drm_dev_init [drm]] *ERROR* Cannot allocate anonymous inode: -12 > == > BUG: KASAN: null-ptr-deref in iput+0x3c/0x4a0 > ...

RE: [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-14 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Wednesday, October 13, 2021 2:01 PM > To: Shankar, Uma > Cc: harry.wentl...@amd.com; ville.syrj...@linux.intel.com; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > brian.star...@arm.com; sebast...@sebastianwic

RE: [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-14 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Wednesday, October 13, 2021 12:56 PM > To: Shankar, Uma > Cc: Simon Ser ; daniel.vet...@ffwll.ch; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > harry.wentl...@amd.com; ville.syrj...@linux.intel.com; brian.sta

Re: [PATCH 0/3] drm/panel: Proper cleanup after mipi_dsi_attach()

2021-10-14 Thread Sam Ravnborg
Hi Brian, On Thu, Sep 23, 2021 at 05:33:52PM -0700, Brian Norris wrote: > I've tested a few dual-DSI panel drivers which choke if they PROBE_DEFER > at the wrong time, so I patched those up in patch 1 and 2. Patch 3 fixes > the other drivers that I couldn't test, but seem to have all the same > pr

Re: [PATCH] drm: panel: nt36672a: Removed extra whitespace.

2021-10-14 Thread Sam Ravnborg
Hi Cai, On Thu, Sep 16, 2021 at 03:37:05PM +0800, Cai Huoqing wrote: > Removed extra whitespace before dev_err_probe() according to coding style. > > Signed-off-by: Cai Huoqing Thanks, applied to drm-misc-next. Sam

Re: [PATCH] dt-bindings: display/bridge: tc358764: Convert to YAML binding

2021-10-14 Thread Rob Herring
On Mon, Oct 11, 2021 at 10:12:02PM +0200, Sam Ravnborg wrote: > Hi AngeloGioacchino, > > On Wed, Oct 06, 2021 at 03:51:50PM +0200, AngeloGioacchino Del Regno wrote: > > Convert the Toshiba TC358764 txt documentation to YAML. > > > > Signed-off-by: AngeloGioacchino Del Regno > > > > Thanks for

Re: [PATCH] drm/panel: ej030na: Make use of the helper function dev_err_probe()

2021-10-14 Thread Sam Ravnborg
Hi Cai, On Thu, Sep 16, 2021 at 06:42:24PM +0800, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > And using dev_err_probe() can reduce code size, and th

Re: [PATCH] dt-bindings: display/bridge: tc358767: Convert to YAML binding

2021-10-14 Thread Rob Herring
On Wed, Oct 06, 2021 at 03:52:04PM +0200, AngeloGioacchino Del Regno wrote: > Convert the Toshiba TC358767 txt documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../display/bridge/toshiba,tc358767.txt | 54 > .../display/bridge/toshiba,tc358767.yaml

[RFC PATCH] drm/panel: ilitek-ili9881d: add support for Wanchanglong W552946ABA panel

2021-10-14 Thread Michael Trimarchi
W552946ABA is a panel by Wanchanglong. This panel utilizes the Ilitek ILI9881D controller. Add this panel's initialzation sequence and timing to ILI9881D driver. Tested on px30-evb v11 Signed-off-by: Michael Trimarchi --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 238 +- 1

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-14 Thread Bhawanpreet Lakha
On 2021-10-13 6:25 p.m., Lyude Paul wrote: Some comments below (also, sorry again for the mixup on the last review!) On Tue, 2021-10-12 at 17:58 -0400, Bhawanpreet Lakha wrote: 8b/10b encoding format requires to reserve the first slot for recording metadata. Real data transmission starts from

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-14 Thread Bhawanpreet Lakha
Adding Mikita aswell On 2021-10-14 4:21 p.m., Bhawanpreet Lakha wrote: On 2021-10-13 6:25 p.m., Lyude Paul wrote: Some comments below (also, sorry again for the mixup on the last review!) On Tue, 2021-10-12 at 17:58 -0400, Bhawanpreet Lakha wrote: 8b/10b encoding format requires to reserve

Re: [PATCH v2] dt-bindings: display/bridge: sil,sii8620: Convert to YAML binding

2021-10-14 Thread Rob Herring
On Wed, Oct 06, 2021 at 05:04:59PM +0200, AngeloGioacchino Del Regno wrote: > Convert the Silicon Image SiI8620 HDMI/MHL bridge documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../bindings/display/bridge/sil,sii8620.yaml | 93 +++ > .../bindings/d

Re: [PATCH] dt-bindings: display/bridge: sil,sii9234: Convert to YAML binding

2021-10-14 Thread Rob Herring
On Wed, 06 Oct 2021 17:21:58 +0200, AngeloGioacchino Del Regno wrote: > Convert the Silicon Image SiI9234 HDMI/MHL bridge documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../bindings/display/bridge/sii9234.txt | 49 > .../bindings/display/bridge/si

Re: [PATCH v5 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

2021-10-14 Thread Sam Ravnborg
Hi lichenyang, On Sat, Sep 11, 2021 at 10:31:31AM +0800, lichenyang wrote: > From: Chenyang Li > > This patch adds an initial DRM driver for the Loongson LS7A1000 > bridge chip(LS7A). The LS7A bridge chip contains two display > controllers, support dual display output. The maximum support for > e

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Ralph Campbell
On 10/14/21 11:01 AM, Jason Gunthorpe wrote: On Thu, Oct 14, 2021 at 10:35:27AM -0700, Ralph Campbell wrote: I ran xfstests-dev using the kernel boot option to "fake" a pmem device when I first posted this patch. The tests ran OK (or at least the same tests passed with and without my patch).

[PATCH] drm/i915: Avoid bitwise vs logical OR warning in snb_wm_latency_quirk()

2021-10-14 Thread Nathan Chancellor
A new warning in clang points out a place in this file where a bitwise OR is being used with boolean types: drivers/gpu/drm/i915/intel_pm.c:3066:12: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical] changed = ilk_increase_wm_latency(dev_priv, dev_priv->wm.pr

Re: Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Dmitry Baryshkov
On Thu, 14 Oct 2021 at 19:54, Vladimir Zapolskiy wrote: > > Hi Dmitry, > > On 10/14/21 4:54 PM, Dmitry Baryshkov wrote: > > From: Amit Pundir > > > > This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. > > > > This upstream commit broke AOSP (post Android 12 merge) build > > on RB5. The

[PATCH] ARM: dts: qcom-apq8064: stop using legacy clock names for HDMI

2021-10-14 Thread Dmitry Baryshkov
Stop using legacy clock names (with _clk suffix) for HDMI and HDMI PHY device tree nodes. Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom-apq8064.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/q

Re: [PATCH] drm/msm/dp: Use the connector passed to dp_debug_get()

2021-10-14 Thread kernel test robot
Hi Bjorn, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.15-rc5 next-20211013] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://

Re: [PATCH v1 2/2] mm: remove extra ZONE_DEVICE struct page refcount

2021-10-14 Thread Jason Gunthorpe
On Thu, Oct 14, 2021 at 12:01:14PM -0700, Dan Williams wrote: > > > Does anyone know why devmap is pte_special anyhow? > > It does not need to be special as mentioned here: > > https://lore.kernel.org/all/CAPcyv4iFeVDVPn6uc=aksyuvkiu3-fk-n16ijvzq3n8ot00...@mail.gmail.com/ I added a remark there

Re: [PATCH v2 10/11] drm/msm/dsi: Add support for DSC configuration

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-of

[Bug 214725] New: simpledrm and i915 both active after boot

2021-10-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214725 Bug ID: 214725 Summary: simpledrm and i915 both active after boot Product: Drivers Version: 2.5 Kernel Version: 5.14.11 Hardware: All OS: Linux Tree: Mainline

Re: [PATCH 2/2] amd/amdgpu_dm: Verify Gamma and Degamma LUT sizes using DRM Core check

2021-10-14 Thread Sean Paul
On Wed, Oct 13, 2021 at 2:12 PM Mark Yacoub wrote: > > From: Mark Yacoub > > [Why] > drm_atomic_helper_check_crtc now verifies both legacy and non-legacy LUT > sizes. There is no need to check it within amdgpu_dm_atomic_check. > > [How] > Remove the local call to verify LUT sizes and use DRM Core

Re: [PATCH] drm/i915/gt: make a gt sysfs group and move power management files

2021-10-14 Thread Sundaresan, Sujaritha
On 10/13/2021 5:08 PM, Andi Shyti wrote: From: Andi Shyti The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management

[PATCH 2/2] drm/msm/hdmi: switch to drm_bridge_connector

2021-10-14 Thread Dmitry Baryshkov
Merge old hdmi_bridge and hdmi_connector implementations. Use drm_bridge_connector instead. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/hdmi/hdmi.c | 12 +- drivers/gpu/drm/msm/hdmi/hdmi.h | 19 ++-

[PATCH 1/2] drm/msm/hdmi: use bulk regulator API

2021-10-14 Thread Dmitry Baryshkov
Switch to using bulk regulator API instead of hand coding loops. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 34 +++ drivers/gpu/drm/msm/hdmi/hdmi.h | 6 ++-- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c| 20 - drivers/

<    1   2   3   >