[PATCH] drm/mcde: dsi: Add of_node_put() before return

2021-10-14 Thread Wan Jiabing
Fix following coccicheck warning: ./drivers/gpu/drm/mcde/mcde_dsi.c:1104:1-33: WARNING: Function for_each_available_child_of_node should have of_node_put() before return Early exits from for_each_available_child_of_node should decrement the node reference counter. Signed-off-by: Wan Jiabing --

Re: [PATCH 0/6] drm/i915: Failsafe migration blits

2021-10-14 Thread Thomas Hellström
Hi, Dave, On 10/14/21 03:50, Dave Airlie wrote: On Fri, 8 Oct 2021 at 23:36, Thomas Hellström wrote: This patch series introduces failsafe migration blits. The reason for this seemingly strange concept is that if the initial clearing or readback of LMEM fails for some reason, and we then set u

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

2021-10-14 Thread Tvrtko Ursulin
On 13/10/2021 17:17, Daniel Vetter wrote: On Wed, Oct 13, 2021 at 04:37:03PM +0100, Tvrtko Ursulin wrote: On 13/10/2021 15:00, Daniel Vetter wrote: On Wed, Oct 13, 2021 at 02:32:03PM +0200, Maarten Lankhorst wrote: No memory should be allocated when calling i915_gem_object_wait, because it

Re: [PATCH v2 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-14 Thread Maxime Ripard
On Wed, Oct 13, 2021 at 12:37:47PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > On Wed, Oct 13, 2021 at 09:47:22AM +0200, Maxime Ripard wrote: > > On Tue, Oct 12, 2021 at 08:48:42AM +0200, Alexander Stein wrote: > > > Add a VCC regulator which needs to be enabled before the EN pin is > > > rele

Re: [PATCH] fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)

2021-10-14 Thread Claudio Suarez
On Wed, Oct 13, 2021 at 04:08:02PM +0200, Thomas Zimmermann wrote: > Hi > > Am 01.10.21 um 14:48 schrieb Claudio Suarez: > > On Fri, Oct 01, 2021 at 10:21:44AM +0200, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 30.09.21 um 17:10 schrieb Claudio: > > > > Scroll acceleration is disabled in fbc

Re:linux-next: build failure after merge of the drm-misc tree

2021-10-14 Thread luo.penghao
Hi, I review the code. It seems I forget to delete the definition of the variable "inst",I'm sry for that.: ( I'll submit another patch soon. > Hi all,> > After merging the drm-misc tree, today's linux-next build (x86_64> > allmodconfig) failed like this:> > > drivers/gpu/drm/nouvea

Re: [PATCH RFC] virtio: wrap config->reset calls

2021-10-14 Thread Anton Yakovlev
On 13.10.2021 12:55, Michael S. Tsirkin wrote: This will enable cleanups down the road. The idea is to disable cbs, then add "flush_queued_cbs" callback as a parameter, this way drivers can flush any work queued after callbacks have been disabled. Signed-off-by: Michael S. Tsirkin --- sound/

Re: [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-14 Thread Tvrtko Ursulin
On 13/10/2021 01:56, Umesh Nerlige Ramappa wrote: With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using sha

Re: [PATCH RFC] virtio: wrap config->reset calls

2021-10-14 Thread Jean-Philippe Brucker
On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote: > This will enable cleanups down the road. > The idea is to disable cbs, then add "flush_queued_cbs" callback > as a parameter, this way drivers can flush any work > queued after callbacks have been disabled. > > Signed-off-by: Mi

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

2021-10-14 Thread Tvrtko Ursulin
On 13/10/2021 11:41, Maarten Lankhorst wrote: No memory should be allocated when calling i915_gem_object_wait, because it may be called to idle a BO when evicting memory. Fix this by using dma_resv_iter helpers to call i915_gem_object_wait_fence() on each fence, which cleans up the code a lot.

Re: [PATCH 1/2] drm/dp: add helpers to read link training delays

2021-10-14 Thread Jani Nikula
On Thu, 14 Oct 2021, Ville Syrjälä wrote: > On Tue, Oct 12, 2021 at 05:43:20PM +0300, Jani Nikula wrote: >> The link training delays are different and/or available in different >> DPCD offsets depending on: >> >> - Clock recovery vs. channel equalization >> - DPRX vs. LTTPR >> - 128b/132b vs. 8b/

[PATCH] drm/i915/gt: make a gt sysfs group and move power management files

2021-10-14 Thread Andi Shyti
From: Andi Shyti The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those directories. The previou

[PATCH 0/4] drm/i915: Make the driver not oops on load on old machines

2021-10-14 Thread Ville Syrjala
From: Ville Syrjälä Fix a pile of regression on older machines which just oops the driver on load. Cc: Dave Airlie Cc: Jani Nikula Cc: Maarten Lankhorst Cc: Thomas Hellström Cc: Chris Wilson Cc: Mika Kuoppala Ville Syrjälä (4): drm/i915: Replace the unconditional clflush with drm_cl

[PATCH 1/4] drm/i915: Replace the unconditional clflush with drm_clflush_virt_range()

2021-10-14 Thread Ville Syrjala
From: Ville Syrjälä Not all machines have clflush, so don't go assuming they do. Not really sure why the clflush is even here since hwsp is supposed to get snooped I thought. Although in my case we're talking about a i830 machine where render/blitter snooping is definitely busted. But it might w

[PATCH 2/4] drm/i915: Convert unconditional clflush to drm_clflush_virt_range()

2021-10-14 Thread Ville Syrjala
From: Ville Syrjälä This one is apparently a "clflush for good measure", so bit more justification (if you can call it that) than some of the others. Convert to drm_clflush_virt_range() again so that machines without clflush will survive the ordeal. Cc: sta...@vger.kernel.org Cc: Maarten Lankhor

[PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support

2021-10-14 Thread Ville Syrjala
From: Ville Syrjälä We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL. Let's not oops when loading the driver on one those machines. Cc: Dave Airlie Cc: Jani Nikula Fixes: cd030c7c11a4 ("drm/i915: constify hotplug function vtable.") Signed-off-by: Ville Syrjälä --- drive

[PATCH 3/4] drm/i915: Catch yet another unconditioal clflush

2021-10-14 Thread Ville Syrjala
From: Ville Syrjälä Replace the unconditional clflush() with drm_clflush_virt_range() which does the wbinvd() fallback when clflush is not available. This time no justification is given for the clflush in the offending commit. Cc: sta...@vger.kernel.org Cc: Maarten Lankhorst Cc: Thomas Hellstr

Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support

2021-10-14 Thread Jani Nikula
On Thu, 14 Oct 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL. > Let's not oops when loading the driver on one those machines. D'oh! Lemme guess, CI just casually dropped the machines from the results because they didn

Re: [PATCH v7, 04/15] media: mtk-vcodec: Manage multi hardware information

2021-10-14 Thread AngeloGioacchino Del Regno
Manage each hardware information which includes irq/power/clk. The hardware includes LAT0, LAT1 and CORE. Signed-off-by: Yunfei Dong --- v7: Using of_platform_populate not component framework to manage multi hardware. --- drivers/media/platform/mtk-vcodec/Makefile| 1 + .../platform/mtk

Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support

2021-10-14 Thread Jani Nikula
On Thu, 14 Oct 2021, Jani Nikula wrote: > On Thu, 14 Oct 2021, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL. >> Let's not oops when loading the driver on one those machines. > > D'oh! > > Lemme guess, CI just casually dr

Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support

2021-10-14 Thread Ville Syrjälä
On Thu, Oct 14, 2021 at 12:20:24PM +0300, Jani Nikula wrote: > On Thu, 14 Oct 2021, Jani Nikula wrote: > > On Thu, 14 Oct 2021, Ville Syrjala wrote: > >> From: Ville Syrjälä > >> > >> We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL. > >> Let's not oops when loading the dri

Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support

2021-10-14 Thread Ville Syrjälä
On Thu, Oct 14, 2021 at 12:18:23PM +0300, Jani Nikula wrote: > On Thu, 14 Oct 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL. > > Let's not oops when loading the driver on one those machines. > > D'oh! > > Lemme

Re: [PATCH v7, 04/15] media: mtk-vcodec: Manage multi hardware information

2021-10-14 Thread AngeloGioacchino Del Regno
> Manage each hardware information which includes irq/power/clk. > The hardware includes LAT0, LAT1 and CORE. > > Signed-off-by: Yunfei Dong > --- > v7: Using of_platform_populate not component framework to manage multi hardware. > --- > drivers/media/platform/mtk-vcodec/Makefile

RE: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support

2021-10-14 Thread Sarvela, Tomi P
> From: Ville Syrjälä > On Thu, Oct 14, 2021 at 12:18:23PM +0300, Jani Nikula wrote: > > On Thu, 14 Oct 2021, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > We don't have hpd support on i8xx/i915 which means > hotplug_funcs==NULL. > > > Let's not oops when loading the driver on one t

Re: [lib/stackdepot] 1cd8ce52c5: BUG:unable_to_handle_page_fault_for_address

2021-10-14 Thread Vlastimil Babka
On 10/14/21 10:54, kernel test robot wrote: > > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 1cd8ce52c520c26c513899fb5aee42b8e5f60d0d ("[PATCH v2] lib/stackdepot: > allow optional init and stack_table allocation by kvmalloc()") > url: > https://github.c

Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support

2021-10-14 Thread Ville Syrjälä
On Thu, Oct 14, 2021 at 09:31:40AM +, Sarvela, Tomi P wrote: > > From: Ville Syrjälä > > On Thu, Oct 14, 2021 at 12:18:23PM +0300, Jani Nikula wrote: > > > On Thu, 14 Oct 2021, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > > We don't have hpd support on i8xx/i915 which means

RE: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support

2021-10-14 Thread Sarvela, Tomi P
> From: Ville Syrjälä > On Thu, Oct 14, 2021 at 09:31:40AM +, Sarvela, Tomi P wrote: > > > From: Ville Syrjälä > > > On Thu, Oct 14, 2021 at 12:18:23PM +0300, Jani Nikula wrote: > > > > On Thu, 14 Oct 2021, Ville Syrjala > > > > wrote: > > > > > From: Ville Syrjälä > > > > > > > > > > We d

Re: [RFC v1 3/6] drm: Add a capability flag to support additional flip completion signalling

2021-10-14 Thread Pekka Paalanen
On Mon, 13 Sep 2021 16:35:26 -0700 Vivek Kasireddy wrote: > If a driver supports this capability, it means that there would be an > additional signalling mechanism for a page flip completion in addition > to out_fence or DRM_MODE_PAGE_FLIP_EVENT. > > This capability may only be relevant for Virt

[PATCH v2 2/2] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-10-14 Thread Oleksij Rempel
Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- drivers/gpu/drm/panel/panel-simple.c | 28

[PATCH v2 1/2] dt-bindings: display: simple: add Innolux G070Y2-T02 panel

2021-10-14 Thread Oleksij Rempel
Add binding for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Signed-off-by: Oleksij Rempel Acked-by: Rob Herring --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --gi

Re: [PATCH v7, 07/15] media: mtk-vcodec: Add irq interface for multi hardware

2021-10-14 Thread AngeloGioacchino Del Regno
Adds irq interface for multi hardware. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 +-- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25 ++ .../platform/mtk-vcodec/mtk

Re: [lib/stackdepot] 1cd8ce52c5: BUG:unable_to_handle_page_fault_for_address

2021-10-14 Thread Mike Rapoport
On Thu, Oct 14, 2021 at 11:33:03AM +0200, Vlastimil Babka wrote: > On 10/14/21 10:54, kernel test robot wrote: > > > > > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: 1cd8ce52c520c26c513899fb5aee42b8e5f60d0d ("[PATCH v2] > > lib/stackdepot: allow

[PATCH 2/2] drm/msm: Fix missing include files in msm_gem_shrinker.c

2021-10-14 Thread Yanteng Si
Include linux/vmalloc.h to fix below errors: error: implicit declaration of function 'register_vmap_purge_notifier' error: implicit declaration of function 'unregister_vmap_purge_notifier' Signed-off-by: Yanteng Si --- drivers/gpu/drm/msm/msm_gem_shrinker.c | 2 ++ 1 file changed, 2 insertions(+

[PATCH 0/2] drm/msm: fix build error

2021-10-14 Thread Yanteng Si
Include linux/vmalloc.h to fix below errors: error: implicit declaration of function 'vmap'; error: implicit declaration of function 'register_vmap_purge_notifier' error: implicit declaration of function 'unregister_vmap_purge_notifier' Yanteng Si (2): drm/msm: Fix missing include files in msm_

[PATCH 1/2] drm/msm: Fix missing include files in msm_gem.c

2021-10-14 Thread Yanteng Si
Include linux/vmalloc.h to fix below errors: error: implicit declaration of function 'vmap' Signed-off-by: Yanteng Si --- drivers/gpu/drm/msm/msm_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 40a9863f5951..198caa9c22

[PATCH v3] dma-buf: remove restriction of IOCTL:DMA_BUF_SET_NAME

2021-10-14 Thread guangming.cao
From: Guangming Cao In this patch(https://patchwork.freedesktop.org/patch/310349), it add a new IOCTL to support dma-buf user to set debug name. But it also added a limitation of this IOCTL, it needs the attachments of dmabuf should be empty, otherwise it will fail. For the original series, the

[PATCH v3] dma-buf: remove restriction of IOCTL:DMA_BUF_SET_NAME

2021-10-14 Thread guangming.cao
From: Guangming Cao On Wed, 2021-10-13 at 14:20 +0200, Christian König wrote: > Am 13.10.21 um 01:56 schrieb Sumit Semwal: > > Hello Guangming, Christian, > > > > > > > > On Tue, 12 Oct 2021, 14:09 , wrote: > > > From: Guangming Cao > > > > > > > Am 09.10.21 um 07:55 schrieb guangming@m

Re: [PATCH v7, 08/15] media: mtk-vcodec: Add msg queue feature for lat and core architecture

2021-10-14 Thread AngeloGioacchino Del Regno
For lat and core architecture, lat thread will send message to core thread when lat decode done. Core hardware will use the message from lat to decode, then free message to lat thread when decode done. Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/Makefile| 1 + .../p

Re: [PATCH v7, 09/15] media: mtk-vcodec: Generalize power and clock on/off interfaces

2021-10-14 Thread AngeloGioacchino Del Regno
Generalizes power and clock on/off interfaces to support different hardware. Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 +- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- .../platform/mtk-vcodec/mtk_vcodec_dec_hw.h | 4 + .../platform/mtk-vc

Re: [PATCH v7, 10/15] media: mtk-vcodec: Add new interface to lock different hardware

2021-10-14 Thread AngeloGioacchino Del Regno
For add new hardware, not only need to lock lat hardware, also need to lock core hardware in case of different instance start to decoder at the same time. Signed-off-by: Yunfei Dong --- Reviewed-By: AngeloGioacchino Del Regno

Re: [PATCH v7, 11/15] media: mtk-vcodec: Add core thread

2021-10-14 Thread AngeloGioacchino Del Regno
Core thread: 1. Gets lat_buf from core msg queue. 2. Proceeds core decode. 3. Puts the lat_buf back to lat msg queue. Both H264 and VP9 rely on the core thread. Signed-off-by: Yunfei Dong I would be happier to see a better commit message, for example: "Introduce a core thread, responsible for

Re: [PATCH v7, 12/15] media: mtk-vcodec: Support 34bits dma address for vdec

2021-10-14 Thread AngeloGioacchino Del Regno
Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it depends on the dma-ranges property of vdec dtsi no

Re: [PATCH v7, 14/15] media: mtk-vcodec: Add core dec and dec end ipi msg

2021-10-14 Thread AngeloGioacchino Del Regno
Add core dec and dec end ipi msg: AP_IPIMSG_DEC_CORE/AP_IPIMSG_DEC_CORE_END. Signed-off-by: Yunfei Dong --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 4 .../media/platform/mtk-vcodec/vdec_vpu_if.c| 12 .../media/platform/mtk-vcodec/vdec_vpu_if.h| 18

Re: [PATCH v7, 15/15] media: mtk-vcodec: Use codec type to separate different hardware

2021-10-14 Thread AngeloGioacchino Del Regno
There are just one core thread, in order to separeate different hardware, using codec type to separeate it in scp driver. Signed-off-by: Yunfei Dong --- .../media/platform/mtk-vcodec/vdec_ipi_msg.h | 12 --- .../media/platform/mtk-vcodec/vdec_vpu_if.c | 34 --- .../med

Re: [PATCH v7, 03/15] media: mtk-vcodec: Refactor vcodec pm interface

2021-10-14 Thread AngeloGioacchino Del Regno
Using the needed param for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. Reviewed-by: Tzung-Bi Shih Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 6 ++--- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 22 ---

Re: [PATCH v7, 02/15] media: mtk-vcodec: Align vcodec wake up interrupt interface

2021-10-14 Thread AngeloGioacchino Del Regno
Il 11/10/21 09:02, Yunfei Dong ha scritto: Vdec and venc can use the same function to wake up interrupt event. Reviewed-by: Tzung-Bi Shih Signed-off-by: Yunfei Dong Reviewed-By: AngeloGioacchino Del Regno

Re: [PATCH v7, 06/15] media: mtk-vcodec: Use pure single core for MT8183

2021-10-14 Thread AngeloGioacchino Del Regno
Separates different architecture for hardware: pure_sin_core and lat_sin_core. MT8183 is pure single core. Uses .hw_arch to distinguish. Signed-off-by: Yunfei Dong Acked-By: AngeloGioacchino Del Regno

Re: [PATCH 20/28] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-10-14 Thread Maarten Lankhorst
Op 05-10-2021 om 13:37 schreef Christian König: > Simplifying the code a bit. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/i915/gem/i915_gem_wait.c | 51 +--- > 1 file changed, 9 insertions(+), 42 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wa

[PULL] drm-misc-next

2021-10-14 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-next PR Maxime drm-misc-next-2021-10-14: drm-misc-next for 5.16: UAPI Changes: Cross-subsystem Changes: Core Changes: - fbdev: Fix double-free, Remove unused scrolling acceleration - locking: improve logging for contented locks without backoff

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

2021-10-14 Thread Maarten Lankhorst
Op 14-10-2021 om 10:37 schreef Tvrtko Ursulin: > > On 13/10/2021 11:41, Maarten Lankhorst wrote: >> No memory should be allocated when calling i915_gem_object_wait, >> because it may be called to idle a BO when evicting memory. >> >> Fix this by using dma_resv_iter helpers to call >> i915_gem_objec

[PULL] drm-misc-fixes

2021-10-14 Thread Maarten Lankhorst
drm-misc-fixes-2021-10-14: drm-misc-fixes for v5.15-rc6: - Respun clock fixes for vc4/hdmi. - Cap connector_bad_edid()'s num_of_ext by num_blocks read. - Clamp fbdev size to max available height. - Hide hyper-v's hw pointer, to prevent double pointers. - Use the correct engine bit in nouveau's g84_

Re: [PATCH v7, 11/15] media: mtk-vcodec: Add core thread

2021-10-14 Thread Ezequiel Garcia
Hi Yunfei, On Mon, Oct 11, 2021 at 03:02:43PM +0800, Yunfei Dong wrote: > Core thread: > 1. Gets lat_buf from core msg queue. > 2. Proceeds core decode. > 3. Puts the lat_buf back to lat msg queue. > > Both H264 and VP9 rely on the core thread. > Avoid the kthread API and instead go with the wo

Re: [PATCH v6, 00/15] Using component framework to support multi hardware decode

2021-10-14 Thread Ezequiel Garcia
Hi Yunfei, On Tue, 12 Oct 2021 at 22:17, yunfei.d...@mediatek.com wrote: > > Hi Ezequiel, > > Thanks for your feedback, > > The driver can work well now according to your advice with > of_platform_populate interface. > > In order to separate parent node with children node, parent node is > master

Re: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-14 Thread Thomas Zimmermann
Hi Am 14.10.21 um 01:36 schrieb Anitha Chrisanthus: Enable support for fbcon (framebuffer console). The user can initialize fbcon by loading kmb-drm with the parameter console=1. v2: added missing static clk_enable Signed-off-by: Edmund Dea Signed-off-by: Anitha Chrisanthus --- drivers/gpu

Re: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-14 Thread Thomas Zimmermann
Hi Am 14.10.21 um 01:36 schrieb Anitha Chrisanthus: Enable support for fbcon (framebuffer console). The user can initialize fbcon by loading kmb-drm with the parameter console=1. v2: added missing static clk_enable Signed-off-by: Edmund Dea Signed-off-by: Anitha Chrisanthus --- drivers/gpu

Re: Regression with mainline kernel on rpi4

2021-10-14 Thread Daniel Vetter
On Wed, Oct 13, 2021 at 05:01:03PM +0200, Maxime Ripard wrote: > On Thu, Sep 30, 2021 at 11:19:59AM +0200, Daniel Vetter wrote: > > On Tue, Sep 28, 2021 at 10:34:46AM +0200, Maxime Ripard wrote: > > > Hi Daniel, > > > > > > On Sat, Sep 25, 2021 at 12:50:17AM +0200, Daniel Vetter wrote: > > > > On

Re: DSI Bridge switching

2021-10-14 Thread Jagan Teki
Hi Laurent, On Fri, Oct 8, 2021 at 7:07 PM Laurent Pinchart wrote: > > Hello, > > On Fri, Oct 08, 2021 at 03:27:43PM +0200, Andrzej Hajda wrote: > > Hi, > > > > Removed my invalid email (I will update files next week). > > > > On 08.10.2021 13:14, Jagan Teki wrote: > > > Hi, > > > > > > I think t

[pull] amdgpu, amdkfd drm-next-5.16

2021-10-14 Thread Alex Deucher
Hi Dave, Daniel, Bug fixes for 5.16. The following changes since commit 1176d15f0f6e556d54ced510ac4a91694960332b: Merge tag 'drm-intel-gt-next-2021-10-08' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2021-10-11 18:09:39 +1000) are available in the Git repository at: http

Re: [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

2021-10-14 Thread Daniel Vetter
On Wed, Oct 13, 2021 at 07:35:48PM +0200, Sebastian Andrzej Siewior wrote: > On 2021-10-13 14:57:34 [+0200], Daniel Vetter wrote: > > Hm there's a pile of commits there, and nothing immediately jumps to > > light. The thing is, 18 is likely way too much, since if e.g. we have a > > single new prope

Re: [PATCH 1/4] drm: Introduce drm_modeset_lock_ctx_retry()

2021-10-14 Thread Daniel Vetter
On Wed, Oct 13, 2021 at 11:00:35PM +0200, Fernando Ramos wrote: > On 21/10/13 03:06PM, Ville Syrjälä wrote: > > > And yes C is dangerous, but also C is verbose. I think one lesson from igt > > > is that too many magic block constructs are bad, it's just not how C > > > works. Definitely not in the

[PATCH] video: smscufx: Fix null-ptr-deref in ufx_usb_probe()

2021-10-14 Thread Wang Hai
I got a null-ptr-deref report: BUG: kernel NULL pointer dereference, address: ... RIP: 0010:fb_destroy_modelist+0x38/0x100 ... Call Trace: ufx_usb_probe.cold+0x2b5/0xac1 [smscufx] usb_probe_interface+0x1aa/0x3c0 [usbcore] really_probe+0x167/0x460 ... ret_from_fork+0x1f/0x30 I

Re: [Intel-gfx] [PULL] drm-misc-next

2021-10-14 Thread Hans de Goede
Hi, On 10/14/21 2:04 PM, Maxime Ripard wrote: > Hi Dave, Daniel, > > Here's this week drm-misc-next PR > > Maxime > > drm-misc-next-2021-10-14: > drm-misc-next for 5.16: Ugh, this just missed the drm-privacy-screen work which I just pushed out to drm-misc-next (I was waiting for the last i915

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

2021-10-14 Thread Tvrtko Ursulin
On 14/10/2021 13:05, Maarten Lankhorst wrote: Op 14-10-2021 om 10:37 schreef Tvrtko Ursulin: On 13/10/2021 11:41, Maarten Lankhorst wrote: No memory should be allocated when calling i915_gem_object_wait, because it may be called to idle a BO when evicting memory. Fix this by using dma_resv_

Re: [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-14 Thread Daniel Vetter
On Thu, Oct 07, 2021 at 04:42:48PM -0400, Stephen Boyd wrote: > Quoting Greg Kroah-Hartman (2021-10-06 22:37:40) > > On Wed, Oct 06, 2021 at 12:37:47PM -0700, Stephen Boyd wrote: > > > > > > Let's make the component driver into an actual device driver that has > > > probe/remove/shutdown functions.

Re: [PATCH v2 03/11] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32

Re: [PATCH 03/14] drm/i915/xehpsdv: enforce min GTT alignment

2021-10-14 Thread Daniel Vetter
On Wed, Oct 13, 2021 at 03:13:33PM +0100, Matthew Auld wrote: > On 13/10/2021 14:38, Daniel Vetter wrote: > > On Mon, Oct 11, 2021 at 09:41:44PM +0530, Ramalingam C wrote: > > > From: Matthew Auld > > > > > > For local-memory objects we need to align the GTT addresses to 64K, both > > > for the p

Re: [PATCH v2 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: This adds SDM845 DSC blocks into hw_catalog Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov --- Changes since v1: - Remove DSC_SDM845_MASK and use 0 as feature mask .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 20 +++

Re: [PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc enabled and pass this to .setup_intf_cfg() Signe

Re: [PATCH v7, 03/15] media: mtk-vcodec: Refactor vcodec pm interface

2021-10-14 Thread Dafna Hirschfeld
On 11.10.21 09:02, Yunfei Dong wrote: Using the needed param for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. I see that there is a lot of code duplication between mtk_vcodec_release_dec_pm.c and mtk_vcodec_release_enc_pm.c I think if you bother to fac

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

2021-10-14 Thread Maarten Lankhorst
Op 14-10-2021 om 15:25 schreef Tvrtko Ursulin: > > On 14/10/2021 13:05, Maarten Lankhorst wrote: >> Op 14-10-2021 om 10:37 schreef Tvrtko Ursulin: >>> >>> On 13/10/2021 11:41, Maarten Lankhorst wrote: No memory should be allocated when calling i915_gem_object_wait, because it may be calle

Re: [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

2021-10-14 Thread Sebastian Andrzej Siewior
On 2021-10-14 15:21:22 [+0200], Daniel Vetter wrote: > On Wed, Oct 13, 2021 at 07:35:48PM +0200, Sebastian Andrzej Siewior wrote: > > c7fcbf2513973 -> does not boot > > c7fcbf2513973 + 2f425cf5242a0 -> boots, 18 x DRM_OBJECT_MAX_PROPERTY > > 6f11f37459d8f -> boots, 0 x DRM_OBJECT_MAX_PROPERTY > > 6

Re: [PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-14 Thread Dmitry Baryshkov
On 14/10/2021 16:41, Dmitry Baryshkov wrote: On 07/10/2021 10:08, Vinod Koul wrote: We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc ena

Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-14 Thread Dmitry Baryshkov
From: Amit Pundir This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. This upstream commit broke AOSP (post Android 12 merge) build on RB5. The device either silently crashes into USB crash mode after android boot animation or we see a blank blue screen with following dpu errors in dme

Re: [Intel-gfx] [PATCH] drm/i915: Use dma_resv_iter for waiting in i915_gem_object_wait_reservation.

2021-10-14 Thread Tvrtko Ursulin
On 14/10/2021 14:45, Maarten Lankhorst wrote: Op 14-10-2021 om 15:25 schreef Tvrtko Ursulin: On 14/10/2021 13:05, Maarten Lankhorst wrote: Op 14-10-2021 om 10:37 schreef Tvrtko Ursulin: On 13/10/2021 11:41, Maarten Lankhorst wrote: No memory should be allocated when calling i915_gem_objec

Re: [PATCH] video: smscufx: Fix null-ptr-deref in ufx_usb_probe()

2021-10-14 Thread Thomas Zimmermann
Hi Am 14.10.21 um 15:22 schrieb Wang Hai: I got a null-ptr-deref report: BUG: kernel NULL pointer dereference, address: ... RIP: 0010:fb_destroy_modelist+0x38/0x100 ... Call Trace: ufx_usb_probe.cold+0x2b5/0xac1 [smscufx] usb_probe_interface+0x1aa/0x3c0 [usbcore] really_p

Re: [PATCH v11 09/16] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2021-10-14 Thread AngeloGioacchino Del Regno
Add mt8195 vdosys0 clock driver name and routing table to the driver data of mtk-mmsys. Signed-off-by: jason-jh.lin --- This patch is base on [1] [1] soc: mediatek: mmsys: add mt8192 mmsys support - https://patchwork.kernel.org/project/linux-mediatek/list/?series=524857 The vdosys1 impelmentati

Re: [PATCH v2 07/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- Changes since v1: - Move this patch from 6 to 7 due to dependency on 6th one - Use DSC indices for programm

Re: [PATCH v2 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- Changes since v1: - Add _dpu_rm_reserve_dsc() function which checks if DSC is enabled - Fix to use dsc_blks drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/d

Re: [PATCH v2 09/11] drm/msm/disp/dpu1: Add support for DSC in topology

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions upto 4k. For more resolutions like 8k this won't work. Also, it is better to use 2 LMs and DSC instances as half width results in lesser power consumption as compar

[PULL] drm-intel-fixes

2021-10-14 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2021-10-14: drm/i915 fixes for v5.15-rc6: - Fix ACPI object leak - Fix context leak in user proto-context creation - Fix missing i915_sw_fence_fini call BR, Jani. The following changes since commit 64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc: Linux 5.15-rc5 (

Re: [PATCH 03/14] drm/i915/xehpsdv: enforce min GTT alignment

2021-10-14 Thread Matthew Auld
On 14/10/2021 14:33, Daniel Vetter wrote: On Wed, Oct 13, 2021 at 03:13:33PM +0100, Matthew Auld wrote: On 13/10/2021 14:38, Daniel Vetter wrote: On Mon, Oct 11, 2021 at 09:41:44PM +0530, Ramalingam C wrote: From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64

Re: [PATCH v11 15/16] drm/mediatek: add MERGE support for mediatek-drm

2021-10-14 Thread AngeloGioacchino Del Regno
Il 21/09/21 17:52, jason-jh.lin ha scritto: Add MERGE engine file: MERGE module is used to merge two slice-per-line inputs into one side-by-side output. Signed-off-by: jason-jh.lin --- rebase on series [1] [1] drm/mediatek: add support for mediatek SOC MT8192 - https://patchwork.kernel.org/pro

Re: [Intel-gfx] [PULL] drm-misc-next

2021-10-14 Thread Hans de Goede
Hi, On 10/14/21 3:24 PM, Hans de Goede wrote: > Hi, > > On 10/14/21 2:04 PM, Maxime Ripard wrote: >> Hi Dave, Daniel, >> >> Here's this week drm-misc-next PR >> >> Maxime >> >> drm-misc-next-2021-10-14: >> drm-misc-next for 5.16: > > Ugh, this just missed the drm-privacy-screen work which I just

Re: [PATCH v2 02/11] drm/msm/disp/dpu1: Add support for DSC

2021-10-14 Thread Dmitry Baryshkov
On 07/10/2021 10:08, Vinod Koul wrote: Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- Changes since v1: - remove unused variable lp - Update copyright year RFC: - Drop unused enums drivers/gpu/dr

Re: [PATCH v6 06/16] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1

2021-10-14 Thread AngeloGioacchino Del Regno
Add mt8195 vdosys1 clock driver name and routing table to the driver data of mtk-mmsys. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mt8195-mmsys.h| 136 + drivers/soc/mediatek/mtk-mmsys.c | 10 ++ include/linux/soc/mediatek/mtk-mmsys.h | 2 + 3 fil

Re: [PATCH v6 09/16] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1

2021-10-14 Thread AngeloGioacchino Del Regno
Il 04/10/21 08:21, Nancy.Lin ha scritto: MT8195 vdosys1 has more than 32 reset bits and a different reset base than other chips. Modify mmsys for support 64 bit and different reset base. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mt8195-mmsys.h | 1 + drivers/soc/mediatek/mtk-mmsys.c

[PATCH 3/3] drm/i915/dp: use new link training delay helpers

2021-10-14 Thread Jani Nikula
Use the new link training delay helpers, fixing the delays for 128b/132b. For existing 8b/10b functionality, this will cause additional 1-byte DPCD reads for LTTPR delays instead of using the cached values. It's just too complicated to combine generic helpers with local caching in a sensible way.

[PATCH 2/3] drm/dp: reuse the 8b/10b link training delay helpers

2021-10-14 Thread Jani Nikula
Reuse the 8b/10b link training delay helpers. Functionally this skips the check for invalid values for DPCD 1.4 and later at clock recovery delay (as it's a fixed delay and bypasses the rd_interval) but the same value will be checked and invalid values reported at channel equalization. Signed-off-

[PATCH 1/3] drm/dp: add helpers to read link training delays

2021-10-14 Thread Jani Nikula
The link training delays are different and/or available in different DPCD offsets depending on: - Clock recovery vs. channel equalization - DPRX vs. LTTPR - 128b/132b vs. 8b/10b - DPCD 1.4+ vs. earlier Add helpers to get the correct delays in us, reading DPCD if necessary. This is more straightfo

Re: [PATCH v6 10/16] soc: mediatek: add mtk-mutex support for mt8195 vdosys1

2021-10-14 Thread AngeloGioacchino Del Regno
Add mtk-mutex support for mt8195 vdosys1. The vdosys1 path component contains ovl_adaptor, merge5, and dp_intf1. Ovl_adaptor is composed of several sub-elements, so change it to support multi-bit control. Signed-off-by: Nancy.Lin --- drivers/soc/mediatek/mtk-mutex.c | 296 ++---

[PATCH 0/7] drm/meson: rework encoders to pass ATTACH_NO_CONNECTOR

2021-10-14 Thread Neil Armstrong
This serie finnally reworks the drm/meson driver by extracting the encoders in their own file and moves to bridge-only callbacks. This permits passing the ATTACH_NO_CONNECTOR bridge attach flag and finally use the CVBS & HDMI display-connector driver. This will ease Martin Blumenstingl writting t

[PATCH 1/7] drm/bridge: display-connector: implement bus fmts callbacks

2021-10-14 Thread Neil Armstrong
Since this bridge is tied to the connector, it acts like a passthrough, so concerning the output & input bus formats, either pass the bus formats from the previous bridge or return fallback data like done in the bridge function: drm_atomic_bridge_chain_select_bus_fmts() & select_bus_fmt_recursive.

[PATCH 4/7] drm/bridge: synopsys: dw-hdmi: also allow interlace on bridge

2021-10-14 Thread Neil Armstrong
Since we allow interlace on the encoder, also allow it on the bridge so we can allow interlaced modes when using DRM_BRIDGE_ATTACH_NO_CONNECTOR. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/

[PATCH 2/7] drm/meson: remove useless recursive components matching

2021-10-14 Thread Neil Armstrong
The initial design was recursive to cover all port/endpoints, but only the first layer of endpoints should be covered by the components list. This also breaks the MIPI-DSI init/bridge attach sequence, thus only parse the first endpoints instead of recursing. Signed-off-by: Neil Armstrong --- dr

[PATCH 6/7] drm/meson: rename venc_cvbs to encoder_cvbs

2021-10-14 Thread Neil Armstrong
Rename the cvbs encoder to match the newly introduced meson_encoder_hdmi. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/Makefile| 2 +- drivers/gpu/drm/meson/meson_drv.c | 4 +- ...meson_venc_cvbs.c => meson_encoder_cvbs.c} | 78 +-- ...mes

[PATCH 7/7] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-14 Thread Neil Armstrong
Drop the local connector and move all callback to bridge funcs in order to leverage the generic CVBS diplay connector. This will also permit adding custom cvbs connectors for ADC based HPD detection on some Amlogic SoC based boards. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_

[PATCH 3/7] drm/meson: split out encoder from meson_dw_hdmi

2021-10-14 Thread Neil Armstrong
This moves all the non-DW-HDMI code where it should be: an encoder in the drm/meson core driver. The bridge functions are copied as-is, the encoder init uses the simple kms helper and for now the bridge attach flags is 0. The meson dw-hdmi glue is slighly fixed to live without the encoder in the

[PATCH 5/7] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2021-10-14 Thread Neil Armstrong
This implements the necessary change to no more use the embedded connector in dw-hdmi and use the dedicated bridge connector driver by passing DRM_BRIDGE_ATTACH_NO_CONNECTOR to the bridge attach call. The necessary connector properties are added to handle the same functionalities as the embedded d

Re: [PATCH 16/25] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-14 Thread Matthew Brost
On Wed, Oct 13, 2021 at 06:02:42PM -0700, John Harrison wrote: > On 10/13/2021 13:42, Matthew Brost wrote: > > Introduce 'set parallel submit' extension to connect UAPI to GuC > > multi-lrc interface. Kernel doc in new uAPI should explain it all. > > > > IGT: https://patchwork.freedesktop.org/patc

Re: [PATCH 20/25] drm/i915: Multi-BB execbuf

2021-10-14 Thread Matthew Brost
On Wed, Oct 13, 2021 at 05:55:51PM -0700, John Harrison wrote: > On 10/13/2021 13:42, Matthew Brost wrote: > > Allow multiple batch buffers to be submitted in a single execbuf IOCTL > > after a context has been configured with the 'set_parallel' extension. > > The number batches is implicit based o

  1   2   3   >