[PATCH v2] drm/fbdev: Clamp fbdev surface size if too large

2021-10-05 Thread Thomas Zimmermann
Clamp the fbdev surface size of the available maximumi height to avoid failing to init console emulation. An example error is shown below. bad framebuffer height 2304, should be >= 768 && <= 768 [drm] Initialized simpledrm 1.0.0 20200625 for simple-framebuffer.0 on minor 0 simple-framebuffer

Re: [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-10-05 Thread Sebastian Andrzej Siewior
On 2021-07-27 12:15:59 [-0700], Daniele Ceraolo Spurio wrote: > On 7/26/2021 5:23 PM, Matthew Brost wrote: > > This adds GuC backend support for i915_request_cancel(), which in turn > > makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. > > > Reviewed-by: Daniele Ceraolo Spurio I have a few instances o

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-05 Thread Lucas De Marchi
On Tue, Oct 05, 2021 at 09:19:39AM +0300, Dan Carpenter wrote: On Mon, Oct 04, 2021 at 01:52:27PM -0700, Lucas De Marchi wrote: Cc'ing Dan Carpenter On Fri, Oct 01, 2021 at 12:57:13PM +0300, Jani Nikula wrote: > On Fri, 01 Oct 2021, Chris Wilson wrote: > > Quoting Lucas De Marchi (2021-10-01 0

Re: [PATCH v3 6/6] drm/mediatek: Add mt8195 DisplayPort driver

2021-10-05 Thread Markus Schneider-Pargmann
Hi Chun-Kuang, On Sat, Oct 02, 2021 at 12:16:26AM +0800, Chun-Kuang Hu wrote: > Hi, Markus: > [...] > > > > drivers/gpu/drm/mediatek/Kconfig |7 + > > drivers/gpu/drm/mediatek/Makefile |2 + > > drivers/gpu/drm/mediatek/mtk_dp.c | 2825 > > drivers

Re: refactor the i915 GVT support

2021-10-05 Thread Wang, Zhi A
Hi folks: It seems we haven't reached a possible solution of this refactor patch series. The current patch series needs to be re-worked because of the module/symbol dependency(The root cause has been discussed in another email). I have to get them off from our gvt-next repo so that we can cont

Re: [PATCH 08/28] dma-buf: use the new iterator in dma_buf_debug_show

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 11:05, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 61e

Re: [PATCH] drm/connector: refer to CTA-861-G in the "content type" prop docs

2021-10-05 Thread Pekka Paalanen
On Mon, 04 Oct 2021 09:12:50 + Simon Ser wrote: > The KMS documentation doesn't say much about the meaning of each > content type. Add a reference to the specification defining them. > > Signed-off-by: Simon Ser > Cc: Emmanuel Gil Peyrot > Cc: Daniel Vetter > Cc: Pekka Paalanen > Cc: Vil

Re: [PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 11:05, Christian König wrote: Simplify the code a bit. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c

Re: [PATCH 23/28] drm: use new iterator in drm_gem_fence_array_add_implicit v3

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 11:06, Christian König wrote: Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() v3: switch to locked version Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) dif

Re: [PATCH v2] drm/fbdev: Clamp fbdev surface size if too large

2021-10-05 Thread Ville Syrjälä
On Tue, Oct 05, 2021 at 09:03:55AM +0200, Thomas Zimmermann wrote: > Clamp the fbdev surface size of the available maximumi height to avoid > failing to init console emulation. An example error is shown below. > > bad framebuffer height 2304, should be >= 768 && <= 768 > [drm] Initialized simp

Re: [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 11:06, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 12/26] drm/i915/guc: Implement multi-lrc submission

2021-10-05 Thread kernel test robot
the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211005-061424 b

linux-next: build warning after merge of the drm-misc tree

2021-10-05 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/linux/dma-buf.h:456: warning: Function parameter or member 'cb_in' not described in 'dma_buf' include/linux/dma-buf.h:456: warning: Function parameter or member 'cb_out' not described in

[PATCH 1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Jani Nikula
Add a helper for getting the DP PHY name. In the interest of caller simplicity and to avoid allocations and passing in of buffers, duplicate the const strings to return. It's a minor penalty to pay for simplicity in all the call sites. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gp

[PATCH 2/2] drm/i915/dp: use drm_dp_phy_name() for logging

2021-10-05 Thread Jani Nikula
Drop the local intel_dp_phy_name() function, and replace with drm_dp_phy_name(). This lets us drop a number of local buffers. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_dp_link_training.c | 24 --- 1 file changed, 4 insertions(+), 20 deletions(-)

[PATCH v2 00/10] drm/gma500: Refactor GEM code

2021-10-05 Thread Thomas Zimmermann
Bring GEM code up to current standards and untangle the connection to GTT helpers. The allocation and pinning helpers for struct gtt_range are located in the GTT code, but actually part of the GEM implementation. The patchset moves them to GEM code and refactors much of the implementation. Most of

[PATCH v2 02/10] drm/gma500: Use to_gtt_range() everywhere

2021-10-05 Thread Thomas Zimmermann
Convert upcasts from struct drm_gem_object to struct gtt_range to to_gtt_range(). Some places used container_of() directly. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 4 ++-- drivers/gpu/drm/gma500/gma_display.c | 7 +++ 2 files ch

[PATCH v2 01/10] drm/gma500: Move helpers for struct gtt_range from gtt.c to gem.c

2021-10-05 Thread Thomas Zimmermann
Allocation and pinning helpers for struct gtt_range are GEM functions, so move them to gem.c. No functional changes. v2: * keep docs for psb_gtt_{attach,detach}_pages() (Patrik) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/framebuffer.c | 1 - drivers/gpu/drm/gma5

[PATCH v2 05/10] drm/gma500: Rename psb_gtt_{pin, unpin}() to psb_gem_{pin, unpin}()

2021-10-05 Thread Thomas Zimmermann
Rename psb_gtt_pin() to psb_gem_pin() to reflect the semantics of the function. Same for psb_gtt_unpin(). No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 8 drivers/gpu/drm/gma500/gem.h | 4 ++-- dr

[PATCH v2 04/10] drm/gma500: Allocate GTT ranges in stolen memory with psb_gem_create()

2021-10-05 Thread Thomas Zimmermann
Support private objects for stolen memory in psb_gem_create() and convert users to psb_gem_create(). For stolen memory, psb_gem_create() now initializes the GEM object via drm_gem_private_object_init(). In the fbdev setup, replace the open-coded initialization of struct gtt_range with a call to ps

[PATCH v2 08/10] drm/gma500: Set page-caching flags in GEM pin/unpin

2021-10-05 Thread Thomas Zimmermann
Caching of the GEM object's backing pages are unrelated to GTT management. Move the respective calls from GTT code to GEM code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/gem.c | 9 - drivers/gpu/drm/gma500/gtt.c | 17 ++--- drivers/gpu/drm/gma500/gtt.h | 2

[PATCH v2 09/10] drm/gma500: Rewrite GTT page insert/remove without struct gtt_range

2021-10-05 Thread Thomas Zimmermann
struct gtt_range represents a GEM object and should not be used for GTT setup. Change psb_gtt_insert() and psb_gtt_remove() to receive all necessary parameters from their caller. This also eliminates possible failure from psb_gtt_insert(). There's one exception in psb_gtt_restore(), which requires

[PATCH v2 07/10] drm/gma500: Inline psb_gtt_{alloc, free}_range() into rsp callers

2021-10-05 Thread Thomas Zimmermann
psb_gtt_alloc_range() allocates struct gtt_range, create the GTT resource and performs some half-baked initialization. Inline the function into its only caller psb_gem_create(). For creating the GTT resource, introduce a new helper, psb_gtt_alloc_resource() that hides the details of the GTT. For p

[PATCH v2 06/10] drm/gma500: Inline psb_gtt_attach_pages() and psb_gtt_detach_pages()

2021-10-05 Thread Thomas Zimmermann
psb_gtt_attach_pages() are not GTT functions but deal with the GEM object's SHMEM pages. The only callers of psb_gtt_attach_pages() and psb_gtt_detach_pages() are the GEM pin helpers. Inline the calls and cleanup the resulting code. v2: * unlock gtt_mutex in pin-error handling (Patrik) Si

[PATCH v2 03/10] drm/gma500: Reimplement psb_gem_create()

2021-10-05 Thread Thomas Zimmermann
Implement psb_gem_create() for general use. Create the GEM handle in psb_gem_create_dumb(). Allows to use psb_gem_create() for creating all of the GEM objects. While at it, clean-up drm_gem_dumb_create() to make it more readable. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson ---

[PATCH v2 10/10] drm/gma500: Rename struct gtt_range to struct psb_gem_object

2021-10-05 Thread Thomas Zimmermann
struct gtt_range represents a GEM object. Rename the structure to struct psb_gem_object and update all users. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c | 9 +- drivers/gpu/drm/gma500/gem.c |

Re: [PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-05 Thread Christian König
Am 05.10.21 um 09:44 schrieb Tvrtko Ursulin: On 01/10/2021 11:05, Christian König wrote: Simplify the code a bit. Signed-off-by: Christian König ---   drivers/dma-buf/dma-buf.c | 36 ++--   1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/d

Re: linux-next: build warning after merge of the drm-misc tree

2021-10-05 Thread Christian König
Thanks for the notice, going to fix this. Christian. Am 05.10.21 um 09:59 schrieb Stephen Rothwell: Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/linux/dma-buf.h:456: warning: Function parameter or member 'cb_in' not described in

Re: [PATCH 1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Ville Syrjälä
On Tue, Oct 05, 2021 at 11:10:52AM +0300, Jani Nikula wrote: > Add a helper for getting the DP PHY name. In the interest of caller > simplicity and to avoid allocations and passing in of buffers, duplicate > the const strings to return. It's a minor penalty to pay for simplicity > in all the call s

Re: [Intel-gfx] [PATCH 21/26] drm/i915: Multi-BB execbuf

2021-10-05 Thread kernel test robot
the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211005-061424 b

Re: [PATCH 1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Jani Nikula
On Tue, 05 Oct 2021, Ville Syrjälä wrote: > On Tue, Oct 05, 2021 at 11:10:52AM +0300, Jani Nikula wrote: >> Add a helper for getting the DP PHY name. In the interest of caller >> simplicity and to avoid allocations and passing in of buffers, duplicate >> the const strings to return. It's a minor p

Re: [PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-05 Thread Tvrtko Ursulin
On 05/10/2021 09:16, Christian König wrote: Am 05.10.21 um 09:44 schrieb Tvrtko Ursulin: On 01/10/2021 11:05, Christian König wrote: Simplify the code a bit. Signed-off-by: Christian König ---   drivers/dma-buf/dma-buf.c | 36 ++--   1 file changed, 6 inserti

Re: [PATCH v13 13/35] drm/tegra: gr2d: Support generic power domain and runtime PM

2021-10-05 Thread Ulf Hansson
On Mon, 4 Oct 2021 at 17:57, Dmitry Osipenko wrote: > > 04.10.2021 14:01, Ulf Hansson пишет: > > On Fri, 1 Oct 2021 at 21:00, Dmitry Osipenko wrote: > >> > >> 01.10.2021 17:55, Ulf Hansson пишет: > >>> On Fri, 1 Oct 2021 at 16:29, Dmitry Osipenko wrote: > > 01.10.2021 16:39, Ulf Hansso

Re: [PATCH 01/10] backlight: qcom-wled: Pass number of elements to read to read_u32_array

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:32PM +0200, Marijn Suijten wrote: > of_property_read_u32_array takes the number of elements to read as last > argument. This does not always need to be 4 (sizeof(u32)) but should > instead be the size of the array in DT as read just above with > of_property_count_elems

Re: [PATCH 02/10] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:33PM +0200, Marijn Suijten wrote: > The kernel already provides appropriate primitives to perform endianness > conversion which should be used in favour of manual bit-wrangling. > > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno > Reviewed

Re: [PATCH 04/10] backlight: qcom-wled: Validate enabled string indices in DT

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:35PM +0200, Marijn Suijten wrote: > The strings passed in DT may possibly cause out-of-bounds register > accesses and should be validated before use. > > Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") The first half of this patch actua

Re: [PATCH 05/10] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:36PM +0200, Marijn Suijten wrote: > When not specifying num-strings in the DT the default is used, but +1 is > added to it which turns wled3 into 4 and wled4/5 into 5 strings instead > of 3 and 4 respectively, causing out of bounds reads and register > read/writes. Th

Re: [PATCH 06/10] backlight: qcom-wled: Remove unnecessary 4th default string in wled3

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:37PM +0200, Marijn Suijten wrote: > The previous commit improves num_strings parsing to not go over the > maximum of 3 strings for wled3 anymore. Likewise this default index for > a hypothetical 4th string is invalid and could access registers that are > not mapped to

Re: [PATCH 07/10] backlight: qcom-wled: Provide enabled_strings default for wled 4 and 5

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:38PM +0200, Marijn Suijten wrote: > Only wled 3 sets a sensible default that allows operating this driver > with just qcom,num-strings in the DT; wled 4 and 5 require > qcom,enabled-strings to be provided otherwise enabled_strings remains > zero-initialized, resuling i

Re: [PATCH 08/10] backlight: qcom-wled: Remove unnecessary double whitespace

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:39PM +0200, Marijn Suijten wrote: > Remove redundant spaces inside for loop conditions. No other double > spaces were found that are not part of indentation with `[^\s] `. > > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by:

Re: [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 16:48, Matthew Brost wrote: On Fri, Oct 01, 2021 at 09:40:19AM +0100, Tvrtko Ursulin wrote: + Daniel as reviewer and maybe merge, avoid falling through cracks at least. Ty, working on push rights myself. I ended up pushing it myself to avoid having a potential crash in the

Re: [PATCH 09/10] backlight: qcom-wled: Consistently use enabled-strings in set_brightness

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:40PM +0200, Marijn Suijten wrote: > The hardware is capable of controlling any non-contiguous sequence of > LEDs specified in the DT using qcom,enabled-strings as u32 > array, and this also follows from the DT-bindings documentation. The > numbers specified in this ar

Re: [PATCH 03/10] backlight: qcom-wled: Override num-strings when enabled-strings is set

2021-10-05 Thread Daniel Thompson
On Mon, Oct 04, 2021 at 09:27:34PM +0200, Marijn Suijten wrote: > DT-bindings do not specify num-strings as mandatory property, yet it is > required to be specified even if enabled-strings is used. The length of > that property-array should already be enough to determine exactly which > and how ma

[PATCH v1] drm/msm: use compatible string to find mdp node

2021-10-05 Thread Krishna Manikandan
In the current implementation, substring comparison using device node name is used to find mdp node during driver probe. Use compatible string instead of node name to get mdp node from the parent mdss node. Signed-off-by: Krishna Manikandan --- drivers/gpu/drm/msm/msm_drv.c | 13 ++--- 1

Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-10-05 Thread mkrishn
On 2021-10-05 07:21, Stephen Boyd wrote: Quoting mkri...@codeaurora.org (2021-09-30 23:39:07) On 2021-09-30 23:28, Stephen Boyd wrote: > Quoting mkri...@codeaurora.org (2021-09-30 04:56:59) >> On 2021-08-19 01:27, Stephen Boyd wrote: >> > Quoting Krishna Manikandan (2021-08-18 03:27:02) >> >> di

Re: [PATCH 04/10] backlight: qcom-wled: Validate enabled string indices in DT

2021-10-05 Thread Marijn Suijten
On 2021-10-05 10:14:52, Daniel Thompson wrote: > On Mon, Oct 04, 2021 at 09:27:35PM +0200, Marijn Suijten wrote: > > The strings passed in DT may possibly cause out-of-bounds register > > accesses and should be validated before use. > > > > Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure t

Re: [PATCH 05/10] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

2021-10-05 Thread Marijn Suijten
On 2021-10-05 10:19:47, Daniel Thompson wrote: > On Mon, Oct 04, 2021 at 09:27:36PM +0200, Marijn Suijten wrote: > > When not specifying num-strings in the DT the default is used, but +1 is > > added to it which turns wled3 into 4 and wled4/5 into 5 strings instead > > of 3 and 4 respectively, caus

Re: [PATCH 09/10] backlight: qcom-wled: Consistently use enabled-strings in set_brightness

2021-10-05 Thread Marijn Suijten
On 2021-10-05 10:33:31, Daniel Thompson wrote: > On Mon, Oct 04, 2021 at 09:27:40PM +0200, Marijn Suijten wrote: > > The hardware is capable of controlling any non-contiguous sequence of > > LEDs specified in the DT using qcom,enabled-strings as u32 > > array, and this also follows from the DT-bind

Re: [Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-10-05 Thread Tvrtko Ursulin
On 05/10/2021 08:06, Sebastian Andrzej Siewior wrote: On 2021-07-27 12:15:59 [-0700], Daniele Ceraolo Spurio wrote: On 7/26/2021 5:23 PM, Matthew Brost wrote: This adds GuC backend support for i915_request_cancel(), which in turn makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. Reviewed-by: Dan

Re: [RFC PATCH v2 2/2] RDMA/rxe: Add dma-buf support

2021-10-05 Thread Shunsuke Mie
ping 2021年10月1日(金) 12:56 Shunsuke Mie : > > 2021年9月30日(木) 23:41 Daniel Vetter : > > > > On Wed, Sep 29, 2021 at 01:19:05PM +0900, Shunsuke Mie wrote: > > > Implement a ib device operation ‘reg_user_mr_dmabuf’. Generate a > > > rxe_map from the memory space linked the passed dma-buf. > > > > > > Si

Re: [PATCH] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2021-10-05 Thread Dave Stevenson
Hi Andrzej Sorry, I'm just coming back to this. I'd started this reply a while back, but got sidetracked onto other priorities and not sent it. On Wed, 8 Sept 2021 at 22:14, Andrzej Hajda wrote: > > > W dniu 08.09.2021 o 13:11, Dave Stevenson pisze: > > Hi Marek and Andrzej > > > > On Tue, 7 Sep

Re: [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-05 Thread Christian König
Am 05.10.21 um 09:53 schrieb Tvrtko Ursulin: On 01/10/2021 11:06, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König ---   drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++--   1 file changed,

Re: [Intel-gfx] [PATCH 12/26] drm/i915/guc: Implement multi-lrc submission

2021-10-05 Thread kernel test robot
wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211005-061424 b

Re: [PATCH 05/10] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

2021-10-05 Thread Daniel Thompson
On Tue, Oct 05, 2021 at 12:06:06PM +0200, Marijn Suijten wrote: > On 2021-10-05 10:19:47, Daniel Thompson wrote: > > On Mon, Oct 04, 2021 at 09:27:36PM +0200, Marijn Suijten wrote: > > > When not specifying num-strings in the DT the default is used, but +1 is > > > added to it which turns wled3 int

Re: [PATCH 04/10] backlight: qcom-wled: Validate enabled string indices in DT

2021-10-05 Thread Daniel Thompson
On Tue, Oct 05, 2021 at 12:03:50PM +0200, Marijn Suijten wrote: > On 2021-10-05 10:14:52, Daniel Thompson wrote: > > On Mon, Oct 04, 2021 at 09:27:35PM +0200, Marijn Suijten wrote: > > > The strings passed in DT may possibly cause out-of-bounds register > > > accesses and should be validated before

Re: [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-05 Thread Tvrtko Ursulin
On 05/10/2021 11:27, Christian König wrote: Am 05.10.21 um 09:53 schrieb Tvrtko Ursulin: On 01/10/2021 11:06, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König ---   drivers/gpu/drm/drm_gem_atomi

Re: [PATCH 05/10] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

2021-10-05 Thread Daniel Thompson
On Tue, Oct 05, 2021 at 11:38:43AM +0100, Daniel Thompson wrote: > On Tue, Oct 05, 2021 at 12:06:06PM +0200, Marijn Suijten wrote: > > On 2021-10-05 10:19:47, Daniel Thompson wrote: > > > On Mon, Oct 04, 2021 at 09:27:36PM +0200, Marijn Suijten wrote: > > > > When not specifying num-strings in the

Re: [Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-10-05 Thread Sebastian Andrzej Siewior
On 2021-10-05 11:13:16 [+0100], Tvrtko Ursulin wrote: > Needs this fix: > > commit d576b31bdece7b5034047cbe21170e948198d32f > Author: Matthew Auld > Date: Fri Sep 24 15:46:46 2021 +0100 > > drm/i915: remember to call i915_sw_fence_fini Thanks, works. Needed a tweak since it does not apply

Re: Questions over DSI within DRM.

2021-10-05 Thread Dave Stevenson
Hi Laurent On Sun, 3 Oct 2021 at 15:16, Laurent Pinchart wrote: > > Hello, > > Reviving a bit of an old thread. I'd been looking at reviving this conversation too as I've moved further on with DSI on the Pi, and converting from an encoder to a bridge > On Thu, Jul 15, 2021 at 11:50:22AM +0200,

Re: [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-05 Thread Christian König
Am 05.10.21 um 12:47 schrieb Tvrtko Ursulin: On 05/10/2021 11:27, Christian König wrote: Am 05.10.21 um 09:53 schrieb Tvrtko Ursulin: On 01/10/2021 11:06, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christi

[PATCH] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-10-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) when rendering is done on Intel dgfx and scanout/composition on Intel igfx. Before this patch the driver was not quite ready for that setup, mainly because it was able to emit a semaphore wait between th

[PATCH 01/28] dma-buf: add dma_resv_for_each_fence_unlocked v8

2021-10-05 Thread Christian König
Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they might be freed, improve kerneldoc, rename _cu

Deploying new iterator interface for dma-buf

2021-10-05 Thread Christian König
Hi guys, a few more bug fixes, looks like the more selftests I add the more odies I find. Assuming the CI tests now pass I will start pushing patches I've already got an rb for to drm-misc-next. Please review and/or comment, Christian.

[PATCH 06/28] dma-buf: use new iterator in dma_resv_wait_timeout

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 69 +- 1 file changed, 8 insertions(+), 61 deletions(-) diff --git a/drive

[PATCH 02/28] dma-buf: add dma_resv_for_each_fence v2

2021-10-05 Thread Christian König
A simpler version of the iterator to be used when the dma_resv object is locked. v2: fix index check here as well Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 49 ++ include/linux/dma-resv.h | 19 +++ 2 files changed, 68 inser

[PATCH 03/28] dma-buf: add dma_resv selftest v3

2021-10-05 Thread Christian König
Just exercising a very minor subset of the functionality, but already proven useful. v2: add missing locking v3: some more cleanup and consolidation, add unlocked test as well Signed-off-by: Christian König --- drivers/dma-buf/Makefile | 3 +- drivers/dma-buf/selftests.h | 1 + drive

[PATCH 05/28] dma-buf: use new iterator in dma_resv_get_fences v3

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead v3: fix rebase bug Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 108 - 1 file changed, 35

[PATCH 12/28] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index e8d70b6e6737..722e3c

[PATCH 11/28] drm/amdgpu: use the new iterator in amdgpu_sync_resv

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 862eb3

[PATCH 14/28] drm/msm: use new iterator in msm_gem_describe

2021-10-05 Thread Christian König
Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

[PATCH 16/28] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-10-05 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.

[PATCH 15/28] drm/radeon: use new iterator in radeon_sync_resv

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index 9257b60144c4..b991ba1

[PATCH 20/28] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 51 +--- 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index f909aaa

[PATCH 10/28] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

2021-10-05 Thread Christian König
This is probably a fix since we didn't even grabed a reference to the fences. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/g

[PATCH 13/28] drm/amdgpu: use new iterator in amdgpu_vm_prt_fini

2021-10-05 Thread Christian König
No need to actually allocate an array of fences here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amd

[PATCH 22/28] drm/i915: use new cursor in intel_prepare_plane_fb

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/intel_display.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 134a6acbd8fb..

[PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-05 Thread Christian König
Simplify the code a bit. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/dma-buf/dma-buf.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 8242b5d9baeb..b

[PATCH 07/28] dma-buf: use new iterator in dma_resv_test_signaled

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 57 +- 1 file changed, 7 insertions(+), 50 deletions(-) diff --git a/drive

[PATCH 17/28] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++-- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/dr

[PATCH 18/28] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

2021-10-05 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 53 ++-- 1 file change

[PATCH 08/28] dma-buf: use the new iterator in dma_buf_debug_show

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/dma-buf/dma-buf.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 61e20ae7b08b..8242b5d9ba

[PATCH 19/28] drm/i915: use the new iterator in i915_request_await_object v2

2021-10-05 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() v3: use dma_resv_for_each_fence instead Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 34 + 1 file changed, 5 insertions(+), 29 delet

[PATCH 04/28] dma-buf: use new iterator in dma_resv_copy_fences

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 84 +++--- 1 file changed, 32 insertions(+), 52 deletions(-) diff --git a/dri

[PATCH 23/28] drm: use new iterator in drm_gem_fence_array_add_implicit v3

2021-10-05 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() v3: switch to locked version Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_gem.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu

[PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb v2

2021-10-05 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). v2: improve coding and documentation Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH 28/28] drm/etnaviv: replace dma_resv_get_excl_unlocked

2021-10-05 Thread Christian König
We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etna

[PATCH 25/28] drm/nouveau: use the new iterator in nouveau_fence_sync

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 05d0b3eb

[PATCH 21/28] drm/i915: use new iterator in i915_gem_object_wait_priority

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 31 +--- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index a13193d

[PATCH 27/28] drm/etnaviv: use new iterator in etnaviv_gem_describe

2021-10-05 Thread Christian König
Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 31 ++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index 8f1b5

[PATCH 26/28] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

2021-10-05 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/g

Re: [PATCH 05/10] backlight: qcom-wled: Fix off-by-one maximum with default num_strings

2021-10-05 Thread Marijn Suijten
On 2021-10-05 11:53:12, Daniel Thompson wrote: > On Tue, Oct 05, 2021 at 11:38:43AM +0100, Daniel Thompson wrote: > > On Tue, Oct 05, 2021 at 12:06:06PM +0200, Marijn Suijten wrote: > > > On 2021-10-05 10:19:47, Daniel Thompson wrote: > > > > On Mon, Oct 04, 2021 at 09:27:36PM +0200, Marijn Suijten

[PATCH v5 0/7] MIPS: JZ4780 and CI20 HDMI

2021-10-05 Thread H. Nikolaus Schaller
PATCH V5 2021-10-05 14:28:44: - dropped mode_fixup and timings support in dw-hdmi as it is no longer needed in this V5 (by h...@goldelico.com) - dropped "drm/ingenic: add some jz4780 specific features" (stimulated by p...@crapouillou.net) - fixed typo in commit subject: "synopsis" -> "synopsys"

[PATCH v5 1/7] drm/ingenic: Fix drm_init error path if IPU was registered

2021-10-05 Thread H. Nikolaus Schaller
From: Paul Boddie If ingenic drm driver can not be registered, the IPU driver won't be deregistered. Code structure is chosen in preparation to add hdmi unregistration in error case following the same pattern by a later patch. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller ---

[PATCH v5 4/7] drm/ingenic: Add dw-hdmi driver for jz4780

2021-10-05 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/

[PATCH v5 7/7] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780

2021-10-05 Thread H. Nikolaus Schaller
Enable CONFIG options as modules. Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index ab7ebb066834..9c9c649d385

[PATCH v5 5/7] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers

2021-10-05 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi |

[PATCH v5 3/7] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-10-05 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc: devicet...@vger.kernel.org --- .../bindings/display/ingenic-jz4780-hdmi.

[PATCH v5 6/7] MIPS: DTS: CI20: Add DT nodes for HDMI setup

2021-10-05 Thread H. Nikolaus Schaller
From: Paul Boddie We need to hook up * HDMI connector * HDMI power regulator * DDC pinmux * HDMI and LCDC endpoint connections Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 67 + 1 file changed, 67 insertio

[PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output

2021-10-05 Thread H. Nikolaus Schaller
From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Tested on MIPS Creator CI20 board. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H.

Re: [PATCH] drm: fsl-dcu: enable PIXCLK on LS1021A

2021-10-05 Thread Matthias Schiffer
On Thu, 2021-09-16 at 14:50 +0200, Matthias Schiffer wrote: > On Fri, 2020-08-21 at 15:41 +0200, Stefan Agner wrote: > > Hi Matthias, > > > > On 2020-08-20 12:58, Matthias Schiffer wrote: > > > The PIXCLK needs to be enabled in SCFG before accessing the DCU on > > > LS1021A, > > > or the access w

  1   2   3   >