Re: [PATCH v2 2/3] drm/i915/utils: do not depend on config being defined

2021-09-30 Thread Andrzej Hajda
W dniu 30.09.2021 o 00:54, Lucas De Marchi pisze: > On Wed, Sep 29, 2021 at 11:08:18PM +0200, Andrzej Hajda wrote: >> >> W dniu 29.09.2021 o 20:33, Lucas De Marchi pisze: >>> Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to >>> return the right thing when the config is not de

Re: [v2 PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-09-30 Thread Enric Balletbo Serra
Hi Jason, Missatge de jason-jh.lin del dia dj., 30 de set. 2021 a les 4:47: > > Because mtk_drm_crtc_create_pkt didn't assign pkt->cl, it will > crash at using pkt->cl->chan in cmdq_pkt_finalize. > > So add struct cmdq_client and let mtk_drm_crtc instance define > cmdq_client as: > > struct mtk_

Re: [PATCH v8 03/12] iommu/mediatek: Add probe_defer for smi-larb

2021-09-30 Thread Yong Wu
On Wed, 2021-09-29 at 18:33 +0200, Dafna Hirschfeld wrote: > > On 29.09.21 03:37, Yong Wu wrote: > > Prepare for adding device_link. > > > > The iommu consumer should use device_link to connect with the > > smi-larb(supplier). then the smi-larb should run before the iommu > > consumer. Here we de

RE: [PATCH] drm/ast: Atomic CR/SR reg R/W

2021-09-30 Thread Kuo-Hsiang Chou
-Original Message- From: Thomas Zimmermann [mailto:tzimmerm...@suse.de] Sent: Monday, September 20, 2021 4:17 PM To: Kuo-Hsiang Chou ; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH] drm/ast: Atomic CR/SR reg R/W Hi Am 17.09.21 um 09:22 schrieb KuoHs

Re: [PATCH] drm/prime: Fix use after free in mmap with drm_gem_ttm_mmap

2021-09-30 Thread Thomas Zimmermann
Hi Am 30.09.21 um 01:00 schrieb Anand K Mistry: drm_gem_ttm_mmap() drops a reference to the gem object on success. If the gem object's refcount == 1 on entry to drm_gem_prime_mmap(), that drop will free the gem object, and the subsequent drm_gem_object_get() will be a UAF. Fix by grabbing a refe

Re: [PATCH 1/3] drm/ttm: s/FLAG_SG/FLAG_EXTERNAL/

2021-09-30 Thread Christian König
I pushed those to drm-misc-next and fixed the i915 merge fallout in drm-tip. Maybe take another look at the resolution in drm-tip if you have time. Christian. Am 29.09.21 um 15:26 schrieb Matthew Auld: It covers more than just ttm_bo_type_sg usage, like with say dma-buf, since one other user i

Re: [RFC PATCH v2 1/1] Providers/rxe: Add dma-buf support

2021-09-30 Thread Zhu Yanjun
On Thu, Sep 30, 2021 at 2:58 PM Shunsuke Mie wrote: > > 2021年9月30日(木) 15:37 Zhu Yanjun : > > > > On Thu, Sep 30, 2021 at 2:20 PM Shunsuke Mie wrote: > > > > > > Implement a new provider method for dma-buf base memory registration. > > > > > > Signed-off-by: Shunsuke Mie > > > --- > > > provider

Re: [RFC PATCH v2 1/1] Providers/rxe: Add dma-buf support

2021-09-30 Thread Zhu Yanjun
On Thu, Sep 30, 2021 at 2:20 PM Shunsuke Mie wrote: > > Implement a new provider method for dma-buf base memory registration. > > Signed-off-by: Shunsuke Mie > --- > providers/rxe/rxe.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/providers/rxe/rxe.c b/provider

Re: [Intel-gfx] [PATCH 1/3] drm/ttm: s/FLAG_SG/FLAG_EXTERNAL/

2021-09-30 Thread Matthew Auld
On Thu, 30 Sept 2021 at 08:28, Christian König wrote: > > I pushed those to drm-misc-next and fixed the i915 merge fallout in drm-tip. > > Maybe take another look at the resolution in drm-tip if you have time. Thanks, although it looks like there is some breakage in the build on drm-tip: drivers

Re: [Intel-gfx] [PATCH 1/3] drm/ttm: s/FLAG_SG/FLAG_EXTERNAL/

2021-09-30 Thread Christian König
Am 30.09.21 um 09:42 schrieb Matthew Auld: On Thu, 30 Sept 2021 at 08:28, Christian König wrote: I pushed those to drm-misc-next and fixed the i915 merge fallout in drm-tip. Maybe take another look at the resolution in drm-tip if you have time. Thanks, although it looks like there is some bre

Re: [Intel-gfx] [PATCH 1/3] drm/ttm: s/FLAG_SG/FLAG_EXTERNAL/

2021-09-30 Thread Matthew Auld
On Thu, 30 Sept 2021 at 08:45, Christian König wrote: > > Am 30.09.21 um 09:42 schrieb Matthew Auld: > > On Thu, 30 Sept 2021 at 08:28, Christian König > > wrote: > >> I pushed those to drm-misc-next and fixed the i915 merge fallout in > >> drm-tip. > >> > >> Maybe take another look at the reso

[PATCH v4 0/7] Add support to the mmsys driver to be a reset controller

2021-09-30 Thread Enric Balletbo i Serra
Dear all, The following patchset is a reimplementation of the patch sent by Jitao Shi [1] some time ago. As suggested by Chun-Kuang Hu, this time the reset is done using the reset API, where the mmsys driver is the reset controller and the mtk_dsi driver is the reset consumer. Note that the first

[PATCH v4 3/7] dt-bindings: display: mediatek: add dsi reset optional property

2021-09-30 Thread Enric Balletbo i Serra
Update device tree binding documentation for the dsi to add the optional property to reset the dsi controller. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- (no changes since v2) Changes in v2: - Added a new patch to describe the dsi reset optional property. .../devicetree/

[PATCH v4 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-09-30 Thread Enric Balletbo i Serra
Reset dsi0 HW to default when power on. This prevents to have different settingis between the bootloader and the kernel. As not all Mediatek boards have the reset consumer configured in their board description, also is not needed on all of them, the reset is optional, so the change is compatible w

Re: [PATCH v2 2/4] drm/v3d: alloc and init job in one shot

2021-09-30 Thread Iago Toral
On Wed, 2021-09-29 at 10:43 +0100, Melissa Wen wrote: > Move job memory allocation to v3d_job_init function. This aim to > facilitate > error handling in job initialization, since cleanup steps are similar > for all > (struct v3d_job)-based types of job involved in a command submission. > To > gene

[PULL] drm-intel-fixes

2021-09-30 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2021-09-30: drm/i915 fixes for v5.15-rc4: - Fix GVT scheduler ww lock usage - Fix pdfdocs documentation build - Fix request early tracepoints - Fix an invalid warning from rps worker BR, Jani. The following changes since commit 5816b3e6577eaa676ceb00a848f0fd6

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v7

2021-09-30 Thread Daniel Vetter
On Wed, Sep 22, 2021 at 01:08:44PM +0200, Christian König wrote: > Totally forgotten to ping once more about that. > > Michel has tested this now and I think we should push it ASAP. So can I get > an rb? spin_lock_irq(&dmabuf->poll.lock); if (dcb->active)

Re: [PATCH v3 0/6] drm/gud: Add some more pixel formats

2021-09-30 Thread Thomas Zimmermann
Hi Am 29.09.21 um 21:11 schrieb Noralf Trønnes: Hi, I'd appreciate if someone could review the 3 small driver patches. Series is Acked-by: Thomas Zimmermann Best regards Thomas Changes since version 2: - Drop the patch adding module parameter 'xrgb'. Both Daniel and Thomas had some

Re: [PATCH v2 2/2] drm/lease: allow empty leases

2021-09-30 Thread Daniel Stone
Hey, On Wed, 22 Sept 2021 at 09:48, Pekka Paalanen wrote: > that is one awesome commit message! It explains everything I might have wanted > to ask. Yeah, what he said. An awesome explanation of a terrible problem. My main worry is that we'd end up tripping over our own feet in either the kerne

Re: [PATCH v2 3/4] drm/v3d: add generic ioctl extension

2021-09-30 Thread Iago Toral
On Wed, 2021-09-29 at 10:44 +0100, Melissa Wen wrote: > Add support to attach generic extensions on job submission. This > patch > is third prep work to enable multiple syncobjs on job submission. > With > this work, when the job submission interface needs to be extended to > accomodate a new featu

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-30 Thread Daniel Vetter
On Tue, Sep 28, 2021 at 10:04:29AM +0300, Oded Gabbay wrote: > On Thu, Sep 23, 2021 at 12:22 PM Oded Gabbay wrote: > > > > On Sat, Sep 18, 2021 at 11:38 AM Oded Gabbay wrote: > > > > > > On Fri, Sep 17, 2021 at 3:30 PM Daniel Vetter wrote: > > > > > > > > On Thu, Sep 16, 2021 at 10:10:14AM -0300

Re: [PATCH v2 2/4] drm/v3d: alloc and init job in one shot

2021-09-30 Thread Melissa Wen
On 09/30, Iago Toral wrote: > On Wed, 2021-09-29 at 10:43 +0100, Melissa Wen wrote: > > Move job memory allocation to v3d_job_init function. This aim to > > facilitate > > error handling in job initialization, since cleanup steps are similar > > for all > > (struct v3d_job)-based types of job invol

Re: Regression with mainline kernel on rpi4

2021-09-30 Thread Daniel Vetter
On Tue, Sep 28, 2021 at 10:34:46AM +0200, Maxime Ripard wrote: > Hi Daniel, > > On Sat, Sep 25, 2021 at 12:50:17AM +0200, Daniel Vetter wrote: > > On Fri, Sep 24, 2021 at 3:30 PM Maxime Ripard wrote: > > > > > > On Wed, Sep 22, 2021 at 01:25:21PM -0700, Linus Torvalds wrote: > > > > On Wed, Sep 2

Re: [PATCH v2 3/4] drm/v3d: add generic ioctl extension

2021-09-30 Thread Melissa Wen
O 09/30, Iago Toral wrote: > On Wed, 2021-09-29 at 10:44 +0100, Melissa Wen wrote: > > Add support to attach generic extensions on job submission. This > > patch > > is third prep work to enable multiple syncobjs on job submission. > > With > > this work, when the job submission interface needs to

Re: Handling DRM master transitions cooperatively

2021-09-30 Thread Daniel Vetter
On Thu, Sep 23, 2021 at 11:23:00AM +0300, Pekka Paalanen wrote: > On Wed, 22 Sep 2021 11:21:16 +0200 > Hans de Goede wrote: > > > Hi, > > > > On 9/22/21 10:56 AM, Pekka Paalanen wrote: > > > On Tue, 14 Sep 2021 15:45:21 +0200 > > > Daniel Vetter wrote: > > > > > >> On Thu, Sep 09, 2021 at 10

Re: [PATCH v2 2/2] drm/lease: allow empty leases

2021-09-30 Thread Simon Ser
Thanks a lot for the reviews!

[PATCH] drm/amdgpu: fix some repeated includings

2021-09-30 Thread Guo Zhengkui
Remove two repeated includings in line 62 and 63. Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index 291a47f7992a..

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v7

2021-09-30 Thread Christian König
Am 30.09.21 um 11:00 schrieb Daniel Vetter: On Wed, Sep 22, 2021 at 01:08:44PM +0200, Christian König wrote: Totally forgotten to ping once more about that. Michel has tested this now and I think we should push it ASAP. So can I get an rb? spin_lock_irq(&dmabuf->poll.lock);

Re: [PATCH v2 4/4] drm/v3d: add multiple syncobjs support

2021-09-30 Thread Iago Toral
On Wed, 2021-09-29 at 10:45 +0100, Melissa Wen wrote: > Using the generic extension from the previous patch, a specific > multisync > extension enables more than one in/out binary syncobj per job > submission. > Arrays of syncobjs are set in struct drm_v3d_multisync, that also > cares > of determin

Re: [PATCH v2 3/4] drm/v3d: add generic ioctl extension

2021-09-30 Thread Iago Toral
On Thu, 2021-09-30 at 10:22 +0100, Melissa Wen wrote: > > > > O 09/30, Iago Toral wrote: > > On Wed, 2021-09-29 at 10:44 +0100, Melissa Wen wrote: (...) > > > /** > > > * struct drm_v3d_submit_cl - ioctl argument for submitting > > > commands > > > to the 3D > > > @@ -135,12 +149,16 @@ struct

Re: [PATCH v2 2/3] drm/i915/utils: do not depend on config being defined

2021-09-30 Thread Steven Price
On 29/09/2021 19:33, Lucas De Marchi wrote: > Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to > return the right thing when the config is not defined rather than a > build error, with the limitation that it can't be used on preprocessor > context. > > The trick here is that m

Re: [PATCH v5 12/13] drm/i915/ttm: use cached system pages when evicting lmem

2021-09-30 Thread Michel Dänzer
On 2021-09-29 13:54, Thomas Hellström wrote: > On Mon, 2021-09-27 at 12:41 +0100, Matthew Auld wrote: >> This should let us do an accelerated copy directly to the shmem pages >> when temporarily moving lmem-only objects, where the i915-gem >> shrinker >> can later kick in to swap out the pages, if

[PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

2021-09-30 Thread Oleksij Rempel
Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Co-Developed-by: Robin van der Gracht Signed-off-by: Robin van der Gracht Signed-off-by: Oleksij Rempel --- drivers/gpu/drm/panel/panel-simple.c | 16

[PATCH v1 1/3] dt-bindings: display: simple: add Innolux G070Y2-T02 panel

2021-09-30 Thread Oleksij Rempel
Add binding for the Innolux G070Y2-T02 panel. It is 7" WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit. Signed-off-by: Oleksij Rempel --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devic

[PATCH v1 3/3] panel-simple: add LOGIC Technologies LTTD800480070-L2RT panel

2021-09-30 Thread Oleksij Rempel
From: Søren Andersen Add support for the Logic Technologies LTTD800x480 L2RT 7" 800x480 TFT Resistive Touch Module. Signed-off-by: Søren Andersen Signed-off-by: Sam Ravnborg Signed-off-by: Oleksij Rempel --- drivers/gpu/drm/panel/panel-simple.c | 35 1 file chang

[PULL] drm-misc-fixes

2021-09-30 Thread Maarten Lankhorst
drm-misc-fixes-2021-09-30: drm-misc-fixes for v5.15: - Not sure if drm-misc-fixes-2021-09-08 tag was pulled, assuming it is. - Power management fixes for vc4. - Compiler fix for vc4. - Cursor fix for nouveau. - Fix ttm buffer moves for ampere gpu's by adding minimal acceleration support. - Small ro

Re: [PATCH] drm/amdgpu: fix some repeated includings

2021-09-30 Thread Simon Ser
One include is v2, the other is v3, or am I missing something?

[PATCH][next] drm/virtio: fix potential integer overflow on shift of a int

2021-09-30 Thread Colin King
From: Colin Ian King The left shift of unsigned int 32 bit integer constant 1 is evaluated using 32 bit arithmetic and then assigned to a signed 64 bit integer. In the case where i is 32 or more this can lead to an overflow. Fix this by shifting the value 1ULL instead. Addresses-Coverity: ("Unin

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v7

2021-09-30 Thread Daniel Vetter
On Thu, Sep 30, 2021 at 11:48:42AM +0200, Christian König wrote: > > > Am 30.09.21 um 11:00 schrieb Daniel Vetter: > > On Wed, Sep 22, 2021 at 01:08:44PM +0200, Christian König wrote: > > > Totally forgotten to ping once more about that. > > > > > > Michel has tested this now and I think we shou

[PATCH][next] drm/virtio: fix another potential integer overflow on shift of a int

2021-09-30 Thread Colin King
From: Colin Ian King The left shift of unsigned int 32 bit integer constant 1 is evaluated using 32 bit arithmetic and then assigned to a signed 64 bit integer. In the case where value is 32 or more this can lead to an overflow (value can be in range 0..MAX_CAPSET_ID (63). Fix this by shifting th

Re: [PATCH v2 4/4] drm/v3d: add multiple syncobjs support

2021-09-30 Thread Melissa Wen
On 09/30, Iago Toral wrote: > On Wed, 2021-09-29 at 10:45 +0100, Melissa Wen wrote: > > Using the generic extension from the previous patch, a specific > > multisync > > extension enables more than one in/out binary syncobj per job > > submission. > > Arrays of syncobjs are set in struct drm_v3d_mu

Re: [Intel-gfx] [PATCH] drm/i915: Add ww context to intel_dpt_pin, v2.

2021-09-30 Thread Maarten Lankhorst
Op 29-09-2021 om 16:50 schreef Thomas Hellström (Intel): > > On 9/29/21 10:59, Maarten Lankhorst wrote: >> Ensure i915_vma_pin_iomap and vma_unpin are done with dpt->obj lock held. >> >> I don't think there's much of a point in merging intel_dpt_pin() with >> intel_pin_fb_obj_dpt(), they touch diff

Re: [PATCH v2 1/3] drm/i915: rename IS_ACTIVE

2021-09-30 Thread Jani Nikula
On Wed, 29 Sep 2021, Lucas De Marchi wrote: > It took me some time to understand the need for IS_ACTIVE and why we > couldn't use kconfig.h. For anyone else wondering, the clues are in babaab2f4738 ("drm/i915: Encapsulate kconfig constant values inside boolean predicates"). But this series tries

AW: [PATCH] drm/amdgpu: fix some repeated includings

2021-09-30 Thread Koenig, Christian
Seconded, there is one include for each hardware version. At least of hand I don't see a duplicate. Von: Simon Ser Gesendet: Donnerstag, 30. September 2021 12:17 An: Guo Zhengkui Cc: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel V

Re: [Freedreno] [PATCH v2 00/22] drm/msm/dpu: switch dpu_plane to be virtual

2021-09-30 Thread Dmitry Baryshkov
Hi, On Thu, 30 Sept 2021 at 05:19, wrote: > > Hi Dmitry > > On 2021-07-04 18:20, Dmitry Baryshkov wrote: > > As discussed on IRC, change dpu_plane implementation to be virtual: > > register unified planes and select backing SSPP block at runtime. > > > > Use msm.dpu_use_virtual_planes=1 to enable

Re: [PATCH v8 09/12] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2021-09-30 Thread Dafna Hirschfeld
On 30.09.21 05:28, Yong Wu wrote: Hi Dafna, Thanks very much for the review. On Wed, 2021-09-29 at 14:13 +0200, Dafna Hirschfeld wrote: On 29.09.21 03:37, Yong Wu wrote: MediaTek IOMMU has already added the device_link between the consumer and smi-larb device. If the vcodec device call th

Re: [RFC PATCH v2 1/1] Providers/rxe: Add dma-buf support

2021-09-30 Thread Shunsuke Mie
2021年9月30日(木) 16:23 Zhu Yanjun : > > On Thu, Sep 30, 2021 at 2:58 PM Shunsuke Mie wrote: > > > > 2021年9月30日(木) 15:37 Zhu Yanjun : > > > > > > On Thu, Sep 30, 2021 at 2:20 PM Shunsuke Mie wrote: > > > > > > > > Implement a new provider method for dma-buf base memory registration. > > > > > > > > S

Re: [RFC PATCH v2 1/1] Providers/rxe: Add dma-buf support

2021-09-30 Thread Shunsuke Mie
2021年9月30日(木) 20:18 Zhu Yanjun : > > On Thu, Sep 30, 2021 at 7:06 PM Shunsuke Mie wrote: > > > > 2021年9月30日(木) 16:23 Zhu Yanjun : > > > > > > On Thu, Sep 30, 2021 at 2:58 PM Shunsuke Mie wrote: > > > > > > > > 2021年9月30日(木) 15:37 Zhu Yanjun : > > > > > > > > > > On Thu, Sep 30, 2021 at 2:20 PM Sh

[PULL] drm-misc-next

2021-09-30 Thread Maxime Ripard
Hi Daniel, Dave, Here's this week PR for drm-misc-next Maxime drm-misc-next-2021-09-30: drm-misc-next for 5.16: UAPI Changes: - virtio: UAPI additions to support context init Cross-subsystem Changes: Core Changes: - bridge: documentation improvements - mipi-dsi: new devm_mipi_dsi_device

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v7

2021-09-30 Thread Christian König
Am 30.09.21 um 12:26 schrieb Daniel Vetter: On Thu, Sep 30, 2021 at 11:48:42AM +0200, Christian König wrote: Am 30.09.21 um 11:00 schrieb Daniel Vetter: On Wed, Sep 22, 2021 at 01:08:44PM +0200, Christian König wrote: Totally forgotten to ping once more about that. Michel has tested this now

[PATCH v3] drm/i915/ttm: Rework object initialization slightly

2021-09-30 Thread Thomas Hellström
We may end up in i915_ttm_bo_destroy() in an error path before the object is fully initialized. In that case it's not correct to call __i915_gem_free_object(), because that function a) Assumes the gem object refcount is 0, which it isn't. b) frees the placements which are owned by the caller until

RE: [PATCH] drm/amdgpu: fix some repeated includings

2021-09-30 Thread 郭正奎
Actually the duplicates take place in line 46, 47 and 62, 63. diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index 291a47f7992a..94fca56583a0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +++ b/drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH] drm/amdgpu: fix some repeated includings

2021-09-30 Thread Christian König
Ah, that makes more sense. Then please remove the duplicates in lines 46 and 47 instead since the other ones are more correctly grouped together with their blocks. Christian. Am 30.09.21 um 13:54 schrieb 郭正奎: Actually the duplicates take place in line 46, 47 and 62, 63. diff --git a/drivers

Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-09-30 Thread mkrishn
On 2021-08-19 01:27, Stephen Boyd wrote: Quoting Krishna Manikandan (2021-08-18 03:27:02) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 53a21d0..fd7ff1c 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi

Re: [PATCH v5 12/13] drm/i915/ttm: use cached system pages when evicting lmem

2021-09-30 Thread Matthew Auld
On 30/09/2021 11:04, Michel Dänzer wrote: On 2021-09-29 13:54, Thomas Hellström wrote: On Mon, 2021-09-27 at 12:41 +0100, Matthew Auld wrote: This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later ki

Re: [PATCH v6 2/2] habanalabs: add support for dma-buf exporter

2021-09-30 Thread Oded Gabbay
On Wed, Sep 29, 2021 at 12:17 AM Oded Gabbay wrote: > > On Tue, Sep 28, 2021 at 8:36 PM Jason Gunthorpe wrote: > > > > On Sun, Sep 12, 2021 at 07:53:09PM +0300, Oded Gabbay wrote: > > > From: Tomer Tayar > > > > > > Implement the calls to the dma-buf kernel api to create a dma-buf > > > object b

Re: [PATCH v5 12/13] drm/i915/ttm: use cached system pages when evicting lmem

2021-09-30 Thread Michel Dänzer
On 2021-09-30 14:27, Matthew Auld wrote: > On 30/09/2021 11:04, Michel Dänzer wrote: >> On 2021-09-29 13:54, Thomas Hellström wrote: >>> On Mon, 2021-09-27 at 12:41 +0100, Matthew Auld wrote: This should let us do an accelerated copy directly to the shmem pages when temporarily moving lme

Repository for additional color and HDR related documentation (Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC)

2021-09-30 Thread Pekka Paalanen
On Thu, 23 Sep 2021 10:43:54 +0300 Pekka Paalanen wrote: > On Wed, 22 Sep 2021 11:28:37 -0400 > Harry Wentland wrote: > > > On 2021-09-22 04:31, Pekka Paalanen wrote: > > > On Tue, 21 Sep 2021 14:05:05 -0400 > > > Harry Wentland wrote: > > > > > >> On 2021-09-21 09:31, Pekka Paalanen wr

Re: [v2 PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-09-30 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2021年9月30日 週四 下午3:12寫道: > > Hi Jason, > > > Missatge de jason-jh.lin del dia dj., 30 > de set. 2021 a les 4:47: > > > > Because mtk_drm_crtc_create_pkt didn't assign pkt->cl, it will > > crash at using pkt->cl->chan in cmdq_pkt_finalize. > > > > So add struct cm

Re: [v2 PATCH 3/3] drm/mediatek: Fix cursor plane is not config when primary is updating

2021-09-30 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月30日 週四 上午10:47寫道: > > If cursor plane has updated but primary plane config task is not > finished, mtk_drm_crtc_update_config will call mbox_flush() to clear > all task in current GCE thread and let cursor plane re-send a new > GCE task with cursor + primary plane

[PATCH v2, 0/1] mailbox: cmdq: add instruction time-out interrupt support

2021-09-30 Thread Yongqiang Niu
Base v5.15 Yongqiang Niu (1): mailbox: cmdq: add instruction time-out interrupt support drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++ 1 file changed, 11 insertions(+) -- 2.25.1

[PATCH v2, 1/1] mailbox: cmdq: add instruction time-out interrupt support

2021-09-30 Thread Yongqiang Niu
add time-out cycle setting to make sure time-out interrupt irq will happened when instruction time-out for wait and poll Signed-off-by: Yongqiang Niu --- drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/driv

Re: [PATCH v1 4/4] drm/mediatek: add mt8195 hdmi TX support

2021-09-30 Thread Chun-Kuang Hu
Hi, Guillaume: This is a big patch, and I'm not familiar with this driver, so the review process would be long. So I tell you about how I review this patch, and if you could process according to my way, the process would be more short. 1. Find the common part of all hdmi driver. Even though mt819

[PATCH v3] drm/i915/bdb: Fix version check

2021-09-30 Thread Lukasz Majczak
With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" the size of bdb_lfp_backlight_data structure has been increased, causing if-statement in the parse_lfp_backlight function that comapres this structure size to the one retrieved from BDB, always to fail for older revisions. This patch cal

Re: [v2 PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-09-30 Thread Enric Balletbo Serra
Hi Chun-Kuang, Missatge de Chun-Kuang Hu del dia dj., 30 de set. 2021 a les 15:11: > > Hi, Enric: > > Enric Balletbo Serra 於 2021年9月30日 週四 下午3:12寫道: > > > > Hi Jason, > > > > > > Missatge de jason-jh.lin del dia dj., 30 > > de set. 2021 a les 4:47: > > > > > > Because mtk_drm_crtc_create_pkt di

[PATCH v9, 1/2] soc: mediatek: mmsys: add comp OVL_2L2/POSTMASK/RDMA4

2021-09-30 Thread Yongqiang Niu
This patch add some more ddp component OVL_2L2 is ovl which include 2 layers overlay POSTMASK control round corner for display frame RDMA4 read dma buffer Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Reviewed-by: Enric Balletbo i Serra Signed-off-by: Yongqiang Niu --- include/linux

[PATCH v9, 0/2] soc: mediatek: mmsys: add mt8192 mmsys support

2021-09-30 Thread Yongqiang Niu
base 5.15 Yongqiang Niu (2): soc: mediatek: mmsys: add comp OVL_2L2/POSTMASK/RDMA4 soc: mediatek: mmsys: Add mt8192 mmsys routing table drivers/soc/mediatek/mt8192-mmsys.h| 77 ++ drivers/soc/mediatek/mtk-mmsys.c | 11 include/linux/soc/mediatek/mtk-mms

[PATCH v9, 2/2] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-09-30 Thread Yongqiang Niu
mt8192 has different routing registers than mt8183 Signed-off-by: Yongqiang Niu Reviewed-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mt8192-mmsys.h | 77 + drivers/soc/mediatek/mtk-mmsys.c| 11 + 2 files changed, 88 insertions(+) create mode 100644 d

[PATCH 04/11] drm/msm/dpu: remove stage_cfg from struct dpu_crtc

2021-09-30 Thread Dmitry Baryshkov
The stage_cfg is not used outside of _dpu_crtc_blend_setup(), so remove the temporary config from global struct. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 11 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 2 -- 2 files changed, 6 insertions(+), 7 de

[PATCH 03/11] drm/msm/dpu: drop pipe_name from struct dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Use plane->name instead of artificial pipe_name. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index

[PATCH 07/11] drm/msm/dpu: drop dpu_csc_cfg from dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Simplify code surrounding CSC table setup by removing struct dpu_csc_cfg pointer from dpu_plane and getting it directly at the CSC setup time. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 +- drivers/gpu

[PATCH 06/11] drm/msm/dpu: drop scaler config from plane state

2021-09-30 Thread Dmitry Baryshkov
Scaler and pixel_ext configuration does not contain a long living state, it is used only during plane update, so remove these two fiels from dpu_plane_state and allocate them on stack. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 59 ++- dri

[PATCH 00/11] drm/msm/dpu: cleanup plane state

2021-09-30 Thread Dmitry Baryshkov
This is a cleanup part of the DPU multirect patchset [1], split away to ease review and merging per Abhinav's request. Currently significant part of atomic plane state is stored in the drm_plane's subclass rather than drm_plane_state's subclass. Move it either to the drm_plane_state or even to the

[PATCH 02/11] drm/msm/dpu: remove pipe_qos_cfg from struct dpu_plane

2021-09-30 Thread Dmitry Baryshkov
The pipe_qos_cfg is used only in _dpu_plane_set_qos_ctrl(), so remove it from the dpu_plane struct and allocate it on stack when necessary. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 30 --- 1 file changed, 16 insertions(+), 14 deletions(-

[PATCH 05/11] drm/msm/dpu: move dpu_hw_pipe_cfg out of struct dpu_plane

2021-09-30 Thread Dmitry Baryshkov
struct dpu_hw_pipe_cfg represents an interim state during atomic update/color fill, so move it out of struct dpu_plane. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 104 -- 1 file changed, 57 insertions(+), 47 deletions(-) diff --git a/driv

[PATCH 11/11] drm/msm/dpu: rip out debugfs support from dpu_plane

2021-09-30 Thread Dmitry Baryshkov
In preparations of virtualizing the dpu_plane rip out debugfs support from dpu_plane (as it is mostly used to expose plane's pipe registers). Also move disable_danger file to danger/ debugfs subdir where it belongs. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c |

[PATCH 09/11] drm/msm/dpu: don't cache pipe->cap->features in dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Do not cache hw_pipe's features in dpu_plane. Use pdpu->pipe_hw->cap->features directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/dri

[PATCH 08/11] drm/msm/dpu: remove dpu_hw_pipe_cdp_cfg from dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Remove struct dpu_hw_pipe_cdp_cfg instance from dpu_plane, it is an interim configuration structure. Allocate it on stack instead. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 14 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 -- 2 files changed

[PATCH 01/11] drm/msm/dpu: move LUT levels out of QOS config

2021-09-30 Thread Dmitry Baryshkov
LUT levels are setup outside of setup_qos_ctrl, so remove them from the struct dpu_hw_pipe_qos_cfg. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 15 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 16 ++-- drivers/gpu/drm/msm/disp/dp

[PATCH 10/11] drm/msm/dpu: don't cache pipe->cap->sblk in dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Do not cache hw_pipe's sblk in dpu_plane. Use pdpu->pipe_hw->cap->sblk directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 25 --- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b

Re: (subset) [PATCH] drm/bridge: Add stubs for devm_drm_of_get_bridge when OF is disabled

2021-09-30 Thread Maxime Ripard
On Tue, 28 Sep 2021 20:13:33 +0200, Maxime Ripard wrote: > If CONFIG_OF is disabled, devm_drm_of_get_bridge won't be compiled in > and drivers using that function will fail to build. > > Add an inline stub so that we can still build-test those cases. > > Applied to drm/drm-misc (drm-misc-next).

Re: [PATCH v2 3/3] Move IS_CONFIG_NONZERO() to kconfig.h

2021-09-30 Thread Masahiro Yamada
On Thu, Sep 30, 2021 at 3:34 AM Lucas De Marchi wrote: > > The check for config value doesn't really belong to i915_utils.h - we > are trying to eliminate that utils helper and share them when possible > with other drivers and subsystems. > > Rationale for having such macro is in commit > babaab2f

Re: [PATCH v13 16/35] usb: chipidea: tegra: Add runtime PM and OPP support

2021-09-30 Thread Peter Chen
On 21-09-27 01:40:39, Dmitry Osipenko wrote: > The Tegra USB controller belongs to the core power domain and we're going > to enable GENPD support for the core domain. Now USB controller must be > resumed using runtime PM API in order to initialize the USB power state. > We already support runtime

Re: [PATCH v13 16/35] usb: chipidea: tegra: Add runtime PM and OPP support

2021-09-30 Thread Dmitry Osipenko
30.09.2021 17:06, Peter Chen пишет: > On 21-09-27 01:40:39, Dmitry Osipenko wrote: >> The Tegra USB controller belongs to the core power domain and we're going >> to enable GENPD support for the core domain. Now USB controller must be >> resumed using runtime PM API in order to initialize the USB p

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v7

2021-09-30 Thread Daniel Vetter
On Thu, Sep 30, 2021 at 01:32:28PM +0200, Christian König wrote: > Am 30.09.21 um 12:26 schrieb Daniel Vetter: > > On Thu, Sep 30, 2021 at 11:48:42AM +0200, Christian König wrote: > > > > > > Am 30.09.21 um 11:00 schrieb Daniel Vetter: > > > > On Wed, Sep 22, 2021 at 01:08:44PM +0200, Christian Kö

Re: [PATCH] video: fbdev: gbefb: Only instantiate device when built for IP32

2021-09-30 Thread Daniel Vetter
On Tue, Sep 21, 2021 at 10:21:02PM +0100, Mark Brown wrote: > The gbefb driver not only registers a driver but also the device for that > driver. This is all well and good when run on the IP32 machines that are > supported by the driver but since the driver supports building with > COMPILE_TEST we

Re: [PATCH] drm/i915: Use direction definition DMA_BIDIRECTIONAL instead of PCI_DMA_BIDIRECTIONAL

2021-09-30 Thread Daniel Vetter
On Sat, Sep 25, 2021 at 08:46:12PM +0800, Cai Huoqing wrote: > Replace direction definition PCI_DMA_BIDIRECTIONAL > with DMA_BIDIRECTIONAL, because it helps to enhance readability > and avoid possible inconsistency. > > Signed-off-by: Cai Huoqing Applied to drm-intel-gt-next, thanks for the patc

Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency

2021-09-30 Thread Daniel Vetter
On Mon, Sep 27, 2021 at 09:23:45AM -0700, Kees Cook wrote: > On Mon, Sep 27, 2021 at 04:28:02PM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > With CONFIG_FB=m and CONFIG_DRM=y, we get a link error in the fb helper: > > > > aarch64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in funct

Re: [PATCH] drm/locking: add backtrace for locking contended locks without backoff

2021-09-30 Thread Daniel Vetter
On Wed, Sep 29, 2021 at 01:32:41AM +0300, Jani Nikula wrote: > If drm_modeset_lock() returns -EDEADLK, the caller is supposed to drop > all currently held locks using drm_modeset_backoff(). Failing to do so > will result in warnings and backtraces on the paths trying to lock a > contended lock. Add

Re: [RFC PATCH v2 2/2] RDMA/rxe: Add dma-buf support

2021-09-30 Thread Daniel Vetter
On Wed, Sep 29, 2021 at 01:19:05PM +0900, Shunsuke Mie wrote: > Implement a ib device operation ‘reg_user_mr_dmabuf’. Generate a > rxe_map from the memory space linked the passed dma-buf. > > Signed-off-by: Shunsuke Mie > --- > drivers/infiniband/sw/rxe/rxe_loc.h | 2 + > drivers/infiniband/

Re: [PATCH] drm: document pre-multiplied assumptions

2021-09-30 Thread Daniel Vetter
On Wed, Sep 29, 2021 at 04:07:01PM +0300, Pekka Paalanen wrote: > On Wed, 29 Sep 2021 09:54:14 + > Simon Ser wrote: > > > When a plane is missing the "alpha blend mode" property, KMS drivers > > will use the pre-multiplied mode. > > > > Signed-off-by: Simon Ser > > Cc: Daniel Vetter > > Cc

[PATCHi v6, 1/1] drm/mediatek: add dither 6 setting

2021-09-30 Thread Yongqiang Niu
dither 6 setting is missed in a6b7c98afdca bit 1 is lfsr_en( "Enables LFSR-type dithering"), need enable bit 2 is rdither_en(Enables running order dithering), need disable Fixes: a6b7c98afdca(drm/mediatek: add mtk_dither_set_common()) Signed-off-by: Yongqiang Niu Change-Id: I30258dd4129d17fb7d94b

[PATCH v6, 0/1] drm/mediatek: add dither 6 setting

2021-09-30 Thread Yongqiang Niu
base v5.15 Yongqiang Niu (1): drm/mediatek: add dither 6 setting drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.25.1

Re: [PATCH] drm/amdgpu: use generic fb helpers instead of setting up AMD own's.

2021-09-30 Thread Alex Deucher
@Christian Koenig Have you had a chance to look at this yet? Alex On Mon, Sep 20, 2021 at 4:44 AM Thomas Zimmermann wrote: > > Hi > > Am 20.09.21 um 10:41 schrieb Thomas Zimmermann: > > (cc'ing dri-devel) > > > > Hi > > > > Am 13.09.21 um 16:36 schrieb Alex Deucher: > >> On Thu, Sep 9, 2021 at 1

Re: [PATCH v1 4/4] drm/mediatek: add mt8195 hdmi TX support

2021-09-30 Thread Guillaume Ranquet
Hi Chun-Kuang. Thank you for your input. I have tried to find commonalities between the two drivers but I didn't find enough shared code to warrant that architecture. I'll have another look, especially now that I'm more familiar with the driver. Regarding 2, I have removed as much functionalities

[PATCH] fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)

2021-09-30 Thread Claudio
Scroll acceleration is disabled in fbcon by hard-wiring p->scrollmode = SCROLL_REDRAW. Remove the obsolete code in fbcon.c and fbdev/core/ Signed-off-by: Claudio Suarez --- - This is a task in the TODO list Documentation/gpu/todo.rst - The contact in the task is Daniel Vetter. He is/you are in c

Re: [PATCH v6 2/3] drm/bridge: ti-sn65dsi86: Use regmap_bulk_write API

2021-09-30 Thread Doug Anderson
Hi, On Wed, Sep 29, 2021 at 8:06 PM Bjorn Andersson wrote: > > The multi-register u16 write operation can use regmap_bulk_write() > instead of two separate regmap_write() calls. > > It's uncertain if this has any effect on the actual updates of the > underlying registers, but this at least gives

Re: [PATCH] drm/vc4: crtc: Make sure the HDMI controller is powered when disabling

2021-09-30 Thread nicolas saenz julienne
On Thu, 2021-09-23 at 20:50 +0200, Maxime Ripard wrote: > Since commit 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot > time"), during the initial setup of the driver we call into the VC4 HDMI > controller hooks to make sure the controller is properly disabled. > > However, we were never ma

Re: [PATCH v2 2/3] drm/i915/utils: do not depend on config being defined

2021-09-30 Thread Lucas De Marchi
On Thu, Sep 30, 2021 at 11:00:06AM +0100, Steven Price wrote: On 29/09/2021 19:33, Lucas De Marchi wrote: Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to return the right thing when the config is not defined rather than a build error, with the limitation that it can't be us

Re: [PATCH v2 2/3] dt-bindings: drm/bridge: ps8640: Add aux-bus child

2021-09-30 Thread Doug Anderson
Hi, On Wed, Sep 29, 2021 at 5:35 PM Philip Chen wrote: > > dp-aux-bus.yaml says we can list an eDP panel as a child of > an eDP controller node to represent the fact that the panel > is connected to the controller's DP AUX bus. > > Let's add it to the ps8640 bindings. > > Signed-off-by: Philip Ch

  1   2   >