Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-28 Thread Oded Gabbay
On Thu, Sep 23, 2021 at 12:22 PM Oded Gabbay wrote: > > On Sat, Sep 18, 2021 at 11:38 AM Oded Gabbay wrote: > > > > On Fri, Sep 17, 2021 at 3:30 PM Daniel Vetter wrote: > > > > > > On Thu, Sep 16, 2021 at 10:10:14AM -0300, Jason Gunthorpe wrote: > > > > On Thu, Sep 16, 2021 at 02:31:34PM +0200,

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > Now that SCM can be a loadable module, we have to add another > dependency to avoid link failures when ipa or adreno-gpu are > built-in: > > aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': > ipa_main.c:(.text+0xfc4): undefine

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Arnd Bergmann
On Tue, Sep 28, 2021 at 9:05 AM Kalle Valo wrote: > Arnd Bergmann writes: > > From: Arnd Bergmann > I assume I can continue to build test ATH10K_SNOC with x86 as before? > That's important for me. If yes, then: > > Acked-by: Kalle Valo > > -- > https://patchwork.kernel.org/project/linux-wireles

[PATCH 3/6] drm/aspeed: Add AST2600 support

2021-09-28 Thread tommy-huang
From: Joel Stanley The values for the threshold and scan line size come from the ASPEED SDK. The DAC register is SCUC0 in the AST2600 datasheet. It has the same layout as the previous generations. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- drivers/gpu/drm/aspeed/aspeed_gfx_dr

[PATCH 4/6] HACK: drm/aspeed: INTR_STS hadndling

2021-09-28 Thread tommy-huang
From: Joel Stanley The 2600 uses this register differently. THis is a TODO to come up with a method of handling that. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH] dt-bindings: display: simple: hardware can use ddc-i2c-bus

2021-09-28 Thread David Heidelberg
Both hardware and driver can communicate DDC over i2c bus. Fixes warnings as: arch/arm/boot/dts/tegra20-paz00.dt.yaml: panel: 'ddc-i2c-bus' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /home/runner/work/linux/linux/Documentation/devicetree/bindings/display/panel/panel

[PATCH 1/6] ARM: dts: aspeed: Add GFX node to AST2600

2021-09-28 Thread tommy-huang
From: Joel Stanley The GFX device is present in the AST2600 SoC. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi ind

[PATCH 5/6] HACK: drm/aspeed: Paramterise modes

2021-09-28 Thread tommy-huang
From: Joel Stanley The AST2600 will run at 1024x868. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed

[PATCH 6/6] dt-bindings: gpu: Add ASPEED GFX bindings document

2021-09-28 Thread tommy-huang
Add ast2600-gfx description for gfx driver. Signed-off-by: tommy-huang --- Documentation/devicetree/bindings/gpu/aspeed-gfx.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt b/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt index 9

[PATCH 0/6] *** Add AST2600 GFX node ***

2021-09-28 Thread tommy-huang
Add AST2600 GFX support first. Joel Stanley (5): ARM: dts: aspeed: Add GFX node to AST2600 ARM: dts: aspeed: ast2600-evb: Enable GFX device drm/aspeed: Add AST2600 support HACK: drm/aspeed: INTR_STS hadndling HACK: drm/aspeed: Paramterise modes tommy-huang (1): dt-bindings: gpu: Add A

[PATCH 2/6] ARM: dts: aspeed: ast2600-evb: Enable GFX device

2021-09-28 Thread tommy-huang
From: Joel Stanley Enable the GFX device with a framebuffer memory region. Signed-off-by: Joel Stanley Signed-off-by: tommy-huang --- arch/arm/boot/dts/aspeed-ast2600-evb.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/ar

Re: [PATCH] dma-buf: move dma-buf symbols into the DMA_BUF module namespace

2021-09-28 Thread Daniel Vetter
On Sat, Sep 25, 2021 at 03:47:00PM +0200, Greg Kroah-Hartman wrote: > In order to better track where in the kernel the dma-buf code is used, > put the symbols in the namespace DMA_BUF and modify all users of the > symbols to properly import the namespace to not break the build at the > same time. >

Re: refactor the i915 GVT support

2021-09-28 Thread Wang, Zhi A
Hey guys: After some investigation, I found the root cause this problem ("i915" module loading will be stuck with Christoph's refactor patches), which can be reproduced by building both i915 and kvmgt as kernel module and the loading i915. The root cause is: in Linux kernel loading, before a k

[GIT PULL] exynos-drm-fixes

2021-09-28 Thread Inki Dae
Hi Dave, Just one clean up to use helper function. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f: Linux 5.15-rc1 (2021-09-12 16:28:37 -0700) are available in the Git repository at: git://

Re: [PATCH] dma-buf: move dma-buf symbols into the DMA_BUF module namespace

2021-09-28 Thread Greg Kroah-Hartman
On Tue, Sep 28, 2021 at 09:31:45AM +0200, Daniel Vetter wrote: > On Sat, Sep 25, 2021 at 03:47:00PM +0200, Greg Kroah-Hartman wrote: > > In order to better track where in the kernel the dma-buf code is used, > > put the symbols in the namespace DMA_BUF and modify all users of the > > symbols to pro

[PATCH 2/2] [v2] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Arnd Bergmann
From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_available'

Re: [PATCH v3 8/9] dma-buf/sync_file: Add SET_DEADLINE ioctl

2021-09-28 Thread Pekka Paalanen
On Mon, 27 Sep 2021 07:36:05 -0700 Rob Clark wrote: > On Mon, Sep 27, 2021 at 1:42 AM Pekka Paalanen wrote: > > > > On Fri, 3 Sep 2021 11:47:59 -0700 > > Rob Clark wrote: > > > > > From: Rob Clark > > > > > > The initial purpose is for igt tests, but this would also be useful for > > > comp

Re: Regression with mainline kernel on rpi4

2021-09-28 Thread Maxime Ripard
Hi Daniel, On Sat, Sep 25, 2021 at 12:50:17AM +0200, Daniel Vetter wrote: > On Fri, Sep 24, 2021 at 3:30 PM Maxime Ripard wrote: > > > > On Wed, Sep 22, 2021 at 01:25:21PM -0700, Linus Torvalds wrote: > > > On Wed, Sep 22, 2021 at 1:19 PM Sudip Mukherjee > > > wrote: > > > > > > > > I added some

[PATCH 02/10] drm/gma500: Use to_gtt_range() everywhere

2021-09-28 Thread Thomas Zimmermann
Convert upcasts from struct drm_gem_object to struct gtt_range to to_gtt_range(). Some places used container_of() directly. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/gem.c | 4 ++-- drivers/gpu/drm/gma500/gma_display.c | 7 +++ 2 files changed, 5 insertions(+), 6 de

[PATCH 04/10] drm/gma500: Allocate GTT ranges in stolen memory with psb_gem_create()

2021-09-28 Thread Thomas Zimmermann
Support private objects for stolen memory in psb_gem_create() and convert users to psb_gem_create(). For stolen memory, psb_gem_create() now initializes the GEM object via drm_gem_private_object_init(). In the fbdev setup, replace the open-coded initialization of struct gtt_range with a call to ps

[PATCH 01/10] drm/gma500: Move helpers for struct gtt_range from gtt.c to gem.c

2021-09-28 Thread Thomas Zimmermann
Allocation and pinning helpers for struct gtt_range are GEM functions, so move them to gem.c. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/framebuffer.c | 1 - drivers/gpu/drm/gma500/gem.c | 133 +-- drivers/gpu/drm/gma500/g

[PATCH 00/10] drm/gma500: Refactor GEM code

2021-09-28 Thread Thomas Zimmermann
Bring GEM code up to current standards and untangle the connection to GTT helpers. The allocation and pinning helpers for struct gtt_range are located in the GTT code, but actually part of the GEM implementation. The patchset moves them to GEM code and refactors much of the implementation. Most of

[PATCH 09/10] drm/gma500: Rewrite GTT page insert/remove without struct gtt_range

2021-09-28 Thread Thomas Zimmermann
struct gtt_range represents a GEM object and should not be used for GTT setup. Change psb_gtt_insert() and psb_gtt_remove() to receive all necessary parameters from their caller. This also eliminates possible failure from psb_gtt_insert(). There's one exception in psb_gtt_restore(), which requires

[PATCH 08/10] drm/gma500: Set page-caching flags in GEM pin/unpin

2021-09-28 Thread Thomas Zimmermann
Caching of the GEM object's backing pages are unrelated to GTT management. Move the respective calls from GTT code to GEM code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/gem.c | 9 - drivers/gpu/drm/gma500/gtt.c | 17 ++--- drivers/gpu/drm/gma500/gtt.h | 2

[PATCH 05/10] drm/gma500: Rename psb_gtt_{pin, unpin}() to psb_gem_{pin, unpin}()

2021-09-28 Thread Thomas Zimmermann
Rename psb_gtt_pin() to psb_gem_pin() to reflect the semantics of the function. Same for psb_gtt_unpin(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/gem.c | 8 drivers/gpu/drm/gma500/gem.h | 4 ++-- drivers/gpu/drm/gma500/gma_dis

[PATCH 06/10] drm/gma500: Inline psb_gtt_attach_pages() and psb_gtt_detach_pages()

2021-09-28 Thread Thomas Zimmermann
psb_gtt_attach_pages() are not GTT functions but deal with the GEM object's SHMEM pages. The only callers of psb_gtt_attach_pages() and psb_gtt_detach_pages() are the GEM pin helpers. Inline the calls and cleanup the resulting code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/gem

[PATCH 03/10] drm/gma500: Reimplement psb_gem_create()

2021-09-28 Thread Thomas Zimmermann
Implement psb_gem_create() for general use. Create the GEM handle in psb_gem_create_dumb(). Allows to use psb_gem_create() for creating all of the GEM objects. While at it, clean-up drm_gem_dumb_create() to make it more readable. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/gem.c

[PATCH 07/10] drm/gma500: Inline psb_gtt_{alloc, free}_range() into rsp callers

2021-09-28 Thread Thomas Zimmermann
psb_gtt_alloc_range() allocates struct gtt_range, create the GTT resource and performs some half-baked initialization. Inline the function into its only caller psb_gem_create(). For creating the GTT resource, introduce a new helper, psb_gtt_alloc_resource() that hides the details of the GTT. For p

[PATCH 10/10] drm/gma500: Rename struct gtt_range to struct psb_gem_object

2021-09-28 Thread Thomas Zimmermann
struct gtt_range represents a GEM object. Rename the structure to struct psb_gem_object and update all users. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/framebuffer.c | 9 +- drivers/gpu/drm/gma500/gem.c | 106 +++-- d

Re: [PATCH] drm: rcar-du: Don't create encoder for unconnected LVDS outputs

2021-09-28 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Aug 23, 2021 at 4:54 PM Laurent Pinchart wrote: > On Mon, Aug 23, 2021 at 02:25:32PM +0200, Geert Uytterhoeven wrote: > > On Sun, Aug 22, 2021 at 2:36 AM Laurent Pinchart wrote: > > > On R-Car D3 and E3, the LVDS encoders provide the pixel clock to the DU, > > > even when LVDS

Re: [PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-09-28 Thread H. Nikolaus Schaller
Hi, > Am 27.09.2021 um 19:07 schrieb max...@cerno.tech: > > Hi, > > On Mon, Sep 27, 2021 at 06:44:21PM +0200, H. Nikolaus Schaller wrote: >> From: Sam Ravnborg >> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kakakhel >> >> S

[PATCH] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Guido Günther
If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in that case. This unbreaks e.g. using mxsfb with the nwl bridge and mipi panels. Fixes: b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge i

Re: [PATCH 04/11] ath11: Wstringop-overread warning

2021-09-28 Thread Kalle Valo
Arnd Bergmann wrote: > gcc-11 with the kernel address sanitizer prints a warning for this > driver: > > In function 'ath11k_peer_assoc_h_vht', > inlined from 'ath11k_peer_assoc_prepare' at > drivers/net/wireless/ath/ath11k/mac.c:1632:2: > drivers/net/wireless/ath/ath11k/mac.c:1164:13: error

Re: [PATCH] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Marek Vasut
On 9/28/21 10:55 AM, Guido Günther wrote: If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in that case. This unbreaks e.g. using mxsfb with the nwl bridge and mipi panels. Fixes: b776b0f00f24 ("drm: mxs

Re: [PATCH v4 03/10] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

2021-09-28 Thread Maxime Ripard
On Tue, Sep 28, 2021 at 10:59:45AM +0200, H. Nikolaus Schaller wrote: > >> +properties: > >> + compatible: > >> +items: > >> + - const: ingenic,jz4780-dw-hdmi > > > > This can just be a const, there's no need for the items > > Maybe starting with an enum is better if more compatible str

Re: [PATCH] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Guido Günther
Hi, On Tue, Sep 28, 2021 at 11:08:58AM +0200, Marek Vasut wrote: > On 9/28/21 10:55 AM, Guido Günther wrote: > > If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is > > returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in > > that case. > > > > This unbreaks

Re: [PATCH] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Marek Vasut
On 9/28/21 11:19 AM, Guido Günther wrote: Hi, On Tue, Sep 28, 2021 at 11:08:58AM +0200, Marek Vasut wrote: On 9/28/21 10:55 AM, Guido Günther wrote: If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in th

Re: [PATCH] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Lucas Stach
Am Dienstag, dem 28.09.2021 um 11:19 +0200 schrieb Guido Günther: > Hi, > On Tue, Sep 28, 2021 at 11:08:58AM +0200, Marek Vasut wrote: > > On 9/28/21 10:55 AM, Guido Günther wrote: > > > If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is > > > returned. Fallback to a reasonable d

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2021-09-28 Thread Maxime Ripard
On Sun, Sep 26, 2021 at 10:31:53PM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年9月17日周五 下午11:40写道: > > > +static void sprd_dsi_encoder_mode_set(struct drm_encoder *encoder, > > > + struct drm_display_mode *mode, > > > + struct drm_display

Re: [PATCH v4 03/10] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-09-28 Thread H. Nikolaus Schaller
> Am 28.09.2021 um 11:18 schrieb Maxime Ripard : > > On Tue, Sep 28, 2021 at 10:59:45AM +0200, H. Nikolaus Schaller wrote: +properties: + compatible: +items: + - const: ingenic,jz4780-dw-hdmi >>> >>> This can just be a const, there's no need for the items >> >> M

Re: [PATCH v4 02/10] drm/ingenic: Add support for JZ4780 and HDMI output

2021-09-28 Thread Paul Cercueil
Hi Nikolaus / Paul, Le lun., sept. 27 2021 at 18:44:20 +0200, H. Nikolaus Schaller a écrit : From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Tested on MIPS

Re: [PATCH] drm/amdgpu: fix clang out-of-range warning

2021-09-28 Thread Michel Dänzer
On 2021-09-27 14:19, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang-14 points out that comparing an 'unsigned int' against a large > 64-bit constantn is pointless: > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1206:18: error: result of > comparison of constant 4294967296 with expression

Re: [PATCH v4 10/10] drm/ingenic: add some jz4780 specific features

2021-09-28 Thread Paul Cercueil
Hi, Le lun., sept. 27 2021 at 18:44:28 +0200, H. Nikolaus Schaller a écrit : From: Paul Boddie The jz4780 has some features which need initialization according to the vendor kernel. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv

Re: [PATCH v4 10/10] drm/ingenic: add some jz4780 specific features

2021-09-28 Thread H. Nikolaus Schaller
Hi Paul, > Am 28.09.2021 um 11:58 schrieb Paul Cercueil : > > Hi, > > Le lun., sept. 27 2021 at 18:44:28 +0200, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> The jz4780 has some features which need initialization >> according to the vendor kernel. >> Signed-off-by: Paul Boddie >>

Re: [PATCH] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Marek Vasut
On 9/28/21 11:27 AM, Lucas Stach wrote: Am Dienstag, dem 28.09.2021 um 11:19 +0200 schrieb Guido Günther: Hi, On Tue, Sep 28, 2021 at 11:08:58AM +0200, Marek Vasut wrote: On 9/28/21 10:55 AM, Guido Günther wrote: If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is returned. F

Re: [PATCH v4 02/10] drm/ingenic: Add support for JZ4780 and HDMI output

2021-09-28 Thread H. Nikolaus Schaller
Hi, > Am 28.09.2021 um 11:35 schrieb Paul Cercueil : > > Hi Nikolaus / Paul, > > Le lun., sept. 27 2021 at 18:44:20 +0200, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> Add support for the LCD controller present on JZ4780 SoCs. >> This SoC uses 8-byte descriptors which extend the c

Re: [PATCH v2] component: do not leave master devres group open after bind

2021-09-28 Thread Takashi Iwai
On Wed, 22 Sep 2021 10:54:32 +0200, Kai Vehmanen wrote: (snip) > --- a/drivers/base/component.c > +++ b/drivers/base/component.c > @@ -246,7 +246,7 @@ static int try_to_bring_up_master(struct master *master, > return 0; > } > > - if (!devres_open_group(master->parent, NULL

Re: [PATCH] drm/i915/ttm: Rework object initialization slightly

2021-09-28 Thread Matthew Auld
On 27/09/2021 16:10, Thomas Hellström wrote: We may end up in i915_ttm_bo_destroy() in an error path before the object is fully initialized. In that case it's not correct to call __i915_gem_free_object(), because that function a) Assumes the gem object refcount is 0, which it isn't. b) frees the

Re: (subset) [PATCH v2 1/3] drm/probe-helper: Document drm_helper_hpd_irq_event() return value

2021-09-28 Thread Maxime Ripard
On Tue, 14 Sep 2021 12:17:22 +0200, Maxime Ripard wrote: > The documentation of the drm_helper_hpd_irq_event() function didn't > document the value that function was returning. Add that part as well. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: (subset) [PATCH v2 2/3] drm/probe-helper: Create a HPD IRQ event helper for a single connector

2021-09-28 Thread Maxime Ripard
On Tue, 14 Sep 2021 12:17:23 +0200, Maxime Ripard wrote: > The drm_helper_hpd_irq_event() function is iterating over all the > connectors when an hotplug event is detected. > > During that iteration, it will call each connector detect function and > figure out if its status changed. > > Finally,

Re: (subset) [PATCH v2 3/3] drm/vc4: hdmi: Actually check for the connector status in hotplug

2021-09-28 Thread Maxime Ripard
On Tue, 14 Sep 2021 12:17:24 +0200, Maxime Ripard wrote: > The drm_helper_hpd_irq_event() documentation states that this function > is "useful for drivers which can't or don't track hotplug interrupts for > each connector." and that "Drivers which support hotplug interrupts for > each connector ind

Re: [PATCH v2] component: do not leave master devres group open after bind

2021-09-28 Thread Kai Vehmanen
Hey, On Tue, 28 Sep 2021, Takashi Iwai wrote: > On Wed, 22 Sep 2021 10:54:32 +0200, Kai Vehmanen wrote: > > --- a/drivers/base/component.c > > +++ b/drivers/base/component.c > > @@ -246,7 +246,7 @@ static int try_to_bring_up_master(struct master *master, > > return 0; > > } > >

Re: [PATCH] drm/nouveau: avoid a use-after-free when BO init fails

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst and queued On Fri, Mar 26, 2021 at 10:41 PM Lyude Paul wrote: > > Reviewed-by: Lyude Paul > > On Wed, 2020-12-02 at 19:02 -0500, Jeremy Cline wrote: > > nouveau_bo_init() is backed by ttm_bo_init() and ferries its return code > > back to the caller. On failures, ttm_b

Re: [PATCH linux-next] drm/nouveau/mmu: drop unneeded assignment in the nvkm_uvmm_mthd_page()

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote: > > From: Luo penghao > > In order to keep the code style consistency of the whole file, > the 'ret' assignments should be deleted. > > The clang_analyzer complains as follows: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvm

Re: [PATCH linux-next] drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst but I will remove the unnecessary brackets as well On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote: > > From: Luo penghao > > In order to keep the code style consistency of the whole file, > the 'inst' assignments should be deleted. > > The clang_analyzer complains as fol

Re: [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote: > > When using single_open() for opening, single_release() should be > called, otherwise the 'op' allocated in single_open() will be leaked. > > Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support") > Report

Re: [PATCH 2/2] drm/nouveau/debugfs: fix file release memory leak

2021-09-28 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote: > > When using single_open() for opening, single_release() should be > called, otherwise the 'op' allocated in single_open() will be leaked. > > Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate int

Re: [PATCH v4 10/10] drm/ingenic: add some jz4780 specific features

2021-09-28 Thread H. Nikolaus Schaller
> Am 28.09.2021 um 12:06 schrieb H. Nikolaus Schaller : > >>> >>> + >>> + /* RGB output control may be superfluous. */ >>> + if (soc_info->has_rgbc) >>> + regmap_write(priv->map, JZ_REG_LCD_RGBC, >>> +JZ_LCD_RGBC_RGB_FORMAT_ENABLE | >>> +

Re: [PATCH] drm: rcar-du: Don't create encoder for unconnected LVDS outputs

2021-09-28 Thread Kieran Bingham
On 22/08/2021 01:36, Laurent Pinchart wrote: > On R-Car D3 and E3, the LVDS encoders provide the pixel clock to the DU, > even when LVDS outputs are not used. For this reason, the rcar-lvds > driver probes successfully on those platforms even if no further bridge > or panel is connected to the LVDS

Re: [PATCH v4 02/10] drm/ingenic: Add support for JZ4780 and HDMI output

2021-09-28 Thread H. Nikolaus Schaller
Hi Paul, > Am 28.09.2021 um 12:21 schrieb H. Nikolaus Schaller : > >>> @@ -1492,10 +1555,16 @@ static int ingenic_drm_init(void) >>> { >>> int err; >>> + if (IS_ENABLED(CONFIG_DRM_INGENIC_DW_HDMI)) { >>> + err = platform_driver_register(ingenic_dw_hdmi_driver_ptr); >>> +

[PATCH v1 0/5] mxsfb/nwl/panels: media bus format fixes

2021-09-28 Thread Guido Günther
commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if present") added bus format probing to mxsfb this exposed several issues in the display stack as used on the Librem 5: The nwl bridge and the panels didn't bother to set any media bus formats and in that case mxsfb would no

[PATCH v1 1/5] drm: mxsfb: Print failed bus format in hex

2021-09-28 Thread Guido Günther
media-bus-formats.h has them in hexadecimal as well so matching with that file saves one conversion when debugging. Signed-off-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/

[PATCH v1 4/5] drm/panel: mantix: Add media bus format

2021-09-28 Thread Guido Günther
This allows the DSI bridge to detect the correct bus format. We currently only support MEDIA_BUS_FMT_RGB888_1X24. Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf

[PATCH v1 5/5] drm/panel: st7703: Add media bus format

2021-09-28 Thread Guido Günther
This allows the DSI bridge to detect the correct bus format. We currently only support MEDIA_BUS_FMT_RGB888_1X24. Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703

[PATCH v1 3/5] drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts

2021-09-28 Thread Guido Günther
Components further up in the chain might ask us for supported formats. Without this MEDIA_BUS_FMT_FIXED is assumed which then breaks display output with mxsfb since it can't determine a proper bus format. We handle the bus formats that correspond to the DSI formats the bridge can potentially outp

[PATCH v1 2/5] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Guido Günther
If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in that case. This unbreaks e.g. using mxsfb with the nwl bridge and mipi panels. Fixes: b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge i

Re: [PATCH] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Guido Günther
Hi, On Tue, Sep 28, 2021 at 11:27:49AM +0200, Lucas Stach wrote: > Am Dienstag, dem 28.09.2021 um 11:19 +0200 schrieb Guido Günther: > > Hi, > > On Tue, Sep 28, 2021 at 11:08:58AM +0200, Marek Vasut wrote: > > > On 9/28/21 10:55 AM, Guido Günther wrote: > > > > If a bridge doesn't do any bus format

Re: [PATCH v1 2/5] drm: mxsfb: Set proper default bus format when using a bridge

2021-09-28 Thread Marek Vasut
On 9/28/21 2:16 PM, Guido Günther wrote: If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in that case. This unbreaks e.g. using mxsfb with the nwl bridge and mipi panels. Fixes: b776b0f00f24 ("drm: mxsf

Re: [PATCH v4 06/10] drm/ingenic: Add dw-hdmi driver for jz4780

2021-09-28 Thread Neil Armstrong
On 27/09/2021 18:44, H. Nikolaus Schaller wrote: > From: Paul Boddie > > A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 > HDMI support. This requires a new driver, plus device tree and configuration > modifications. > > Signed-off-by: Paul Boddie > Signed-off-by: Ez

[Bug 212425] Kernel warning at drivers/gpu/drm/ttm/ttm_bo.c:517

2021-09-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212425 Grzegorz Kowal (custos.men...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH v3 0/3] MSM8953 MDP/DSI PHY enablement

2021-09-28 Thread Sireesh Kodali
This patch series adds support for the MDP and DSI PHY as found on the MSM8953 platform (APQ8053, SDM450, SDA450, SDM625, SDM626). All the SoCs on this platform use the adreno 506 GPU. Changes since v2: - Changed dt-bindings to use enum instead of oneOf Changes since v1: - Split the dsi phy doc c

[PATCH v3 1/3] dt-bindings: msm: dsi: Add MSM8953 dsi phy

2021-09-28 Thread Sireesh Kodali
SoCs based on the MSM8953 platform use the 14nm DSI PHY driver Signed-off-by: Sireesh Kodali --- Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/de

[PATCH v3 2/3] drm/msm/dsi: Add phy configuration for MSM8953

2021-09-28 Thread Sireesh Kodali
From: Vladimir Lypak Add phy configuration for 14nm dsi phy found on MSM8953 SoC. Only difference from existing configurations are io_start addresses. Signed-off-by: Vladimir Lypak Reviewed-by: Dmitry Baryshkov Signed-off-by: Sireesh Kodali --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2

[PATCH v3 3/3] drm/msm/mdp5: Add configuration for MDP v1.16

2021-09-28 Thread Sireesh Kodali
From: Vladimir Lypak MDP version v1.16 is almost identical to v1.15 with most significant difference being presence of second DSI interface. MDP v1.16 is found on SoCs such as MSM8x53, SDM450, SDM632 (All with Adreno 506). Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali --- driver

Re: [PATCH 2/2] [v2] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Alex Elder
On 9/28/21 2:50 AM, Arnd Bergmann wrote: From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): und

Re: [PATCH v4 06/10] drm/ingenic: Add dw-hdmi driver for jz4780

2021-09-28 Thread H. Nikolaus Schaller
Hi Neil, > Am 28.09.2021 um 15:02 schrieb Neil Armstrong : > > On 27/09/2021 18:44, H. Nikolaus Schaller wrote: >> From: Paul Boddie >> >> A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 >> HDMI support. This requires a new driver, plus device tree and configuration

Re: refactor the i915 GVT support

2021-09-28 Thread Luis Chamberlain
On Tue, Sep 28, 2021 at 07:41:00AM +, Wang, Zhi A wrote: > Hey guys: > > After some investigation, I found the root cause this problem ("i915" > module loading will be stuck with Christoph's refactor patches), which > can be reproduced by building both i915 and kvmgt as kernel module and >

Re: [PATCH v4 06/10] drm/ingenic: Add dw-hdmi driver for jz4780

2021-09-28 Thread Paul Cercueil
Hi Nikolaus & Paul, Le lun., sept. 27 2021 at 18:44:24 +0200, H. Nikolaus Schaller a écrit : From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Signed-of

Re: [PATCH] drm/msm: Switch ordering of runpm put vs devfreq_idle

2021-09-28 Thread Akhil P Oommen
On 9/27/2021 8:59 PM, Rob Clark wrote: From: Rob Clark I've seen a few crashes like: Internal error: synchronous external abort: 9610 [#1] PREEMPT SMP Modules linked in: snd_seq_dummy snd_seq snd_seq_device bridge stp llc tun nf_nat_tftp nf_conntrack_tftp nf_nat_ftp nf_conntrack

[PATCH] [SUBMITTED 20210721] fbdev: simplefb: fix Kconfig dependencies

2021-09-28 Thread Arnd Bergmann
From: Arnd Bergmann Configurations with both CONFIG_FB_SIMPLE=y and CONFIG_DRM_SIMPLEDRM=m are allowed by Kconfig because the 'depends on !DRM_SIMPLEDRM' dependency does not disallow FB_SIMPLE as long as SIMPLEDRM is not built-in. This can however result in a build failure when cfb_fillrect() etc

Re: refactor the i915 GVT support

2021-09-28 Thread Wang, Zhi A
On 9/28/21 2:00 PM, Luis Chamberlain wrote: > On Tue, Sep 28, 2021 at 07:41:00AM +, Wang, Zhi A wrote: >> Hey guys: >> >> After some investigation, I found the root cause this problem ("i915" >> module loading will be stuck with Christoph's refactor patches), which >> can be reproduced by build

Re: refactor the i915 GVT support

2021-09-28 Thread Jason Gunthorpe
On Tue, Sep 28, 2021 at 02:35:06PM +, Wang, Zhi A wrote: > Yes. I was thinking of the possibility of putting off some work later so > that we don't need to make a lot of changes. GVT-g needs to take a > snapshot of GPU registers as the initial virtual states for other vGPUs, > which require

Re: [PATCH v3] drm/dp: Add Additional DP2 Headers

2021-09-28 Thread Harry Wentland
On 2021-09-27 15:23, Fangzhi Zuo wrote: > Include FEC, DSC, Link Training related headers. > > Change since v2 > - Align with the spec for DP_DSC_SUPPORT_AND_DSC_DECODER_COUNT > > Signed-off-by: Fangzhi Zuo Reviewed-by: Harry Wentland Harry > --- > This patch is based on top of the other DP2

[Bug 214029] [bisected] [amdgpu] Several memory leaks in amdgpu and ttm

2021-09-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214029 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added CC||christian.koe...@amd.co

[Bug 214029] [bisected] [amdgpu] Several memory leaks in amdgpu and ttm

2021-09-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214029 --- Comment #16 from Erhard F. (erhar...@mailbox.org) --- Created attachment 299007 --> https://bugzilla.kernel.org/attachment.cgi?id=299007&action=edit final bisect.log -- You may reply to this email to add a comment. You are receiving this

Re: [Freedreno] [PATCH] drm/msm: Switch ordering of runpm put vs devfreq_idle

2021-09-28 Thread Rob Clark
On Tue, Sep 28, 2021 at 7:52 AM Akhil P Oommen wrote: > > On 9/27/2021 8:59 PM, Rob Clark wrote: > > From: Rob Clark > > > > I've seen a few crashes like: > > > > Internal error: synchronous external abort: 9610 [#1] PREEMPT SMP > > Modules linked in: snd_seq_dummy snd_seq snd_seq_d

Re: linux-next: Tree for Sep 28 [drivers/gpu/drm/vc4/vc4.ko]

2021-09-28 Thread Randy Dunlap
On 9/28/21 12:23 AM, Stephen Rothwell wrote: Hi all, Changes since 20210927: on x86_64: ERROR: modpost: "devm_drm_of_get_bridge" [drivers/gpu/drm/vc4/vc4.ko] undefined! Full randconfig file is attached. -- ~Randy config-r5051.gz Description: application/gzip

[PATCH] drm/msm/dp: only signal audio when disconnected detected at dp_pm_resume

2021-09-28 Thread Kuogee Hsieh
Only signal audio when disconnected detected at dp_pm_resume since connected status will be signaled to audio at next plugin handler. Fixes: 078867ce04ed ("drm/msm/dp: signal audio plugged change at dp_pm_resume") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 10 +

[PATCH] drm/msm/dpu: Remove some nonsense

2021-09-28 Thread Rob Clark
From: Rob Clark These aren't used. And if we add use for them later, we should probably do something a bit more structured than string parsing. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 -- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 8

Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels

2021-09-28 Thread Andrzej Hajda
W dniu 23.09.2021 o 02:29, Laurent Pinchart pisze: > Hi Maxime, > > Thank you for the patch. > > I know this has already been merged, but I have a question. > > On Fri, Sep 10, 2021 at 03:09:39PM +0200, Maxime Ripard wrote: >> Display drivers so far need to have a lot of boilerplate to first >> r

Re: [PATCH] drm/msm/dpu: Remove some nonsense

2021-09-28 Thread Dmitry Baryshkov
On 28/09/2021 19:28, Rob Clark wrote: From: Rob Clark These aren't used. And if we add use for them later, we should probably do something a bit more structured than string parsing. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog

Re: [PATCH v5 2/2] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2021-09-28 Thread Bjorn Andersson
On Sat 25 Sep 16:25 CDT 2021, Uwe Kleine-K?nig wrote: > Hello Bjorn, > > On Fri, Sep 24, 2021 at 05:04:41PM -0500, Bjorn Andersson wrote: > > On Fri 24 Sep 02:54 CDT 2021, Uwe Kleine-K?nig wrote: > > > > +static int ti_sn65dsi86_read_u16(struct ti_sn65dsi86 *pdata, > > > > +

[PATCH v2] drm/amd/display: Only define DP 2.0 symbols if not already defined

2021-09-28 Thread Harry Wentland
[Why] For some reason we're defining DP 2.0 definitions inside our driver. Now that patches to introduce relevant definitions are slated to be merged into drm-next this is causing conflicts. In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c:33: In file included from ./drivers/gpu/d

Re: [PATCH v6 1/2] habanalabs: define uAPI to export FD for DMA-BUF

2021-09-28 Thread Jason Gunthorpe
On Sun, Sep 12, 2021 at 07:53:08PM +0300, Oded Gabbay wrote: > /* HL_MEM_OP_* */ > __u32 op; > - /* HL_MEM_* flags */ > + /* HL_MEM_* flags. > + * For the HL_MEM_OP_EXPORT_DMABUF_FD opcode, this field holds the > + * DMA-BUF file/FD flags. > + */ > __u32 fla

Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-09-28 Thread khsieh
On 2021-08-27 10:14, Bjorn Andersson wrote: On Fri 27 Aug 00:20 CDT 2021, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-08-25 16:42:31) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 2c7de43f655a..4a6132c18e57 100644 > --- a/drivers/gpu/drm

Re: [Freedreno] [PATCH v2 04/13] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-09-28 Thread Sean Paul
On Tue, Sep 21, 2021 at 04:34:59PM -0700, abhin...@codeaurora.org wrote: > On 2021-09-15 13:38, Sean Paul wrote: > > From: Sean Paul > > > > This patch expands upon the HDCP helper library to manage HDCP > > enable, disable, and check. > > > > Previous to this patch, the majority of the state ma

Re: [PATCH v6 2/2] habanalabs: add support for dma-buf exporter

2021-09-28 Thread Jason Gunthorpe
On Sun, Sep 12, 2021 at 07:53:09PM +0300, Oded Gabbay wrote: > From: Tomer Tayar > > Implement the calls to the dma-buf kernel api to create a dma-buf > object backed by FD. > > We block the option to mmap the DMA-BUF object because we don't support > DIRECT_IO and implicit P2P. This statement

RE: [PATCH v2] drm/amd/display: Only define DP 2.0 symbols if not already defined

2021-09-28 Thread Zuo, Jerry
[AMD Official Use Only] > -Original Message- > From: Harry Wentland > Sent: September 28, 2021 1:08 PM > To: Deucher, Alexander ; amd- > g...@lists.freedesktop.org; Zuo, Jerry > Cc: jani.nik...@intel.com; Li, Sun peng (Leo) ; > nat...@kernel.org; intel-...@lists.freedesktop.org; dri- > d

Re: [Freedreno] [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-09-28 Thread Sean Paul
On Tue, Sep 21, 2021 at 07:25:41PM -0700, abhin...@codeaurora.org wrote: > On 2021-09-15 13:38, Sean Paul wrote: > > From: Sean Paul > > > > This patch adds HDCP 1.x support to msm DP connectors using the new HDCP > > helpers. > > > > Cc: Stephen Boyd > > Signed-off-by: Sean Paul > > Link: > >

Re: [Freedreno] [PATCH v2 00/13] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2021-09-28 Thread Sean Paul
On Tue, Sep 21, 2021 at 07:30:29PM -0700, abhin...@codeaurora.org wrote: > Hi Sean > > On 2021-09-15 13:38, Sean Paul wrote: > > From: Sean Paul > > > > Hello again, > > This is the second version of the HDCP helper patchset. See version 1 > > here: https://patchwork.freedesktop.org/series/94623

  1   2   >