[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-09-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Andreas (icedragon...@web.de) changed: What|Removed |Added Kernel Version|5.14.3 |5.14.6 -- You may reply

Re: [RFC PATCH] drm/print: Add deprecation notes to DRM_...() functions

2021-09-22 Thread Thomas Zimmermann
Hi Am 21.09.21 um 17:28 schrieb Douglas Anderson: It's hard for someone (like me) who's not following closely to know what the suggested best practices are for error printing in DRM drivers. Add some hints to the header file. In general, my understanding is that: * When possible we should be us

Re: [PATCH 1/4] phy: mediatek: add support for phy-mtk-hdmi-mt8195

2021-09-22 Thread Chunfeng Yun
On Tue, 2021-09-07 at 10:37 +0200, Guillaume Ranquet wrote: > Add basic support for the mediatek hdmi phy on MT8195 SoC > > Signed-off-by: Guillaume Ranquet > --- > drivers/phy/mediatek/Makefile | 1 + > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 777 > + > d

Re: [RESEND][PATCH v2] video: backlight: Drop maximum brightness override for brightness zero

2021-09-22 Thread Lee Jones
On Tue, 21 Sep 2021, Marek Vasut wrote: > The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper > in backlight.c") says that gpio-backlight uses brightness as power state. > This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight: > Correct initial power state h

Re: [PULL] drm-misc-next

2021-09-22 Thread Maxime Ripard
Hi, On Mon, Sep 20, 2021 at 05:29:41PM -0500, Rob Herring wrote: > On Thu, Sep 16, 2021 at 2:31 AM Maxime Ripard wrote: > > > > Hi Dave, Daniel, > > > > Here's the first drm-misc-next PR for 5.16 > > > > Thanks! > > Maxime > > > > drm-misc-next-2021-09-16: > > drm-misc-next for $kernel-version: >

Re: [PATCH] drm/i915/selftests: exercise shmem_writeback with THP

2021-09-22 Thread Tvrtko Ursulin
On 21/09/2021 15:21, Matthew Auld wrote: In commit: commit 1e6decf30af5c5c75445ed6ad4e65a26de578a03 Author: Hugh Dickins Date: Thu Sep 2 14:54:43 2021 -0700 shmem: shmem_writepage() split unlikely i915 THP it looks THP + shmem_writeback was an unexpected combination, and ends up hitt

Re: [RESEND] [PATCH v2 1/2] dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX

2021-09-22 Thread Laurent Pinchart
Hi Geert, On Wed, Sep 22, 2021 at 08:43:57AM +0200, Geert Uytterhoeven wrote: > On Wed, Sep 22, 2021 at 3:27 AM Laurent Pinchart wrote: > > On Tue, Sep 21, 2021 at 05:53:52PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Jul 28, 2021 at 6:26 PM Laurent Pinchart wrote: > > > > The R-Car MIPI DSI/C

Re: [PATCH] drm/v3d: Make use of the helper function devm_platform_ioremap_resource_byname()

2021-09-22 Thread Melissa Wen
On 09/20, Melissa Wen wrote: > On 09/01, Cai Huoqing wrote: > > Use the devm_platform_ioremap_resource_byname() helper instead of > > calling platform_get_resource_byname() and devm_ioremap_resource() > > separately > > > > Signed-off-by: Cai Huoqing > > --- > > drivers/gpu/drm/v3d/v3d_drv.c | 5

Re: [PATCH] drm/bridge: Move devm_drm_of_get_bridge to bridge/panel.c

2021-09-22 Thread Maxime Ripard
On Mon, Sep 20, 2021 at 10:49:55PM +0200, Heiko Stübner wrote: > Hi Maxime, > > Am Freitag, 17. September 2021, 20:09:25 CEST schrieb Maxime Ripard: > > By depending on devm_drm_panel_bridge_add(), devm_drm_of_get_bridge() > > introduces a circular dependency between the modules drm (where > > dev

Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels

2021-09-22 Thread Maxime Ripard
Hi Patrik, On Tue, Sep 21, 2021 at 02:47:49PM +0200, Patrik Jakobsson wrote: > On Fri, Sep 10, 2021 at 3:10 PM Maxime Ripard wrote: > > > > Display drivers so far need to have a lot of boilerplate to first > > retrieve either the panel or bridge that they are connected to using > > drm_of_find_pa

Re: [PATCH 1/3] drm/bridge: Add a function to abstract away panels

2021-09-22 Thread Patrik Jakobsson
On Wed, Sep 22, 2021 at 10:23 AM Maxime Ripard wrote: > > Hi Patrik, > > On Tue, Sep 21, 2021 at 02:47:49PM +0200, Patrik Jakobsson wrote: > > On Fri, Sep 10, 2021 at 3:10 PM Maxime Ripard wrote: > > > > > > Display drivers so far need to have a lot of boilerplate to first > > > retrieve either t

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-22 Thread Pekka Paalanen
On Tue, 21 Sep 2021 14:05:05 -0400 Harry Wentland wrote: > On 2021-09-21 09:31, Pekka Paalanen wrote: > > On Mon, 20 Sep 2021 20:14:50 -0400 > > Harry Wentland wrote: > > > >> On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 > >> -0400 > >>> Harry Wentland wrote: >

Re: [PATCH 2/4] drm/mediatek: add mt8195 hdmi TX support

2021-09-22 Thread Chunfeng Yun
On Tue, 2021-09-07 at 10:37 +0200, Guillaume Ranquet wrote: > Add basic hdmi TX support for the mediatek mt8195 SoCs > > Signed-off-by: Guillaume Ranquet > --- > drivers/gpu/drm/mediatek/Kconfig | 10 + > drivers/gpu/drm/mediatek/Makefile |4 +- > drivers/gpu/drm/m

[PATCH 0/3] DG1 Lockdep warning fixes

2021-09-22 Thread Thomas Hellström
A couple of recent commits introduced lockdep warnings, breaking some DG1 BAT tests. Two fixes for those and one HAX patch making CI behave better. Kai Vehmanen (1): HAX: component: do not leave master devres group open after bind Thomas Hellström (2): drm/i915/gem: Fix a lockdep warning the

[PATCH 2/3] drm/i915/ttm: Fix lockdep warning in __i915_gem_free_object()

2021-09-22 Thread Thomas Hellström
In the mman selftest, some tests make the ttm_bo_init_reserved() fail, which may trigger a call to the i915_ttm_bo_destroy() function. However, at this point the gem object refcount is set to 1, which triggers a lockdep warning in __i915_gem_free_object() and a corresponding failure in DG1 BAT, i91

[PATCH 1/3] drm/i915/gem: Fix a lockdep warning the __i915_gem_is_lmem() function

2021-09-22 Thread Thomas Hellström
Somehow we managed to invert the test for i915_gem_object_evictable(), which causes a warning in DG1 BAT, igt@debugfs_test@read_all_entries. Fix the lock check to only warn if the object *is* indeed evictable and not protected from eviction by fences. Cc: Matthew Brost Fixes: 91160c839824 ("drm/

[PATCH 3/3] HAX: component: do not leave master devres group open after bind

2021-09-22 Thread Thomas Hellström
From: Kai Vehmanen In current code, the devres group for aggregate master is left open after call to component_master_add_*(). This leads to problems when the master does further managed allocations on its own. When any participating driver calls component_del(), this leads to immediate release o

Re: [PATCH v3 1/6] drm/vc4: select PM (openrisc)

2021-09-22 Thread Maxime Ripard
Hi Randy, On Sun, Sep 19, 2021 at 09:40:44AM -0700, Randy Dunlap wrote: > On 8/19/21 6:59 AM, Maxime Ripard wrote: > > We already depend on runtime PM to get the power domains and clocks for > > most of the devices supported by the vc4 driver, so let's just select it > > to make sure it's there, a

Re: [PATCH v2 2/2] drm/lease: allow empty leases

2021-09-22 Thread Pekka Paalanen
On Fri, 03 Sep 2021 13:00:32 + Simon Ser wrote: > This can be used to create a separate DRM file description, thus > creating a new GEM handle namespace. > > My use-case is wlroots. The library splits responsibilities between > separate components: the GBM allocator creates buffers, the GLES

Re: [PATCH v4 24/24] drm/exynos: dsi: Adjust probe order

2021-09-22 Thread Maxime Ripard
Hi Marek, On Fri, Sep 17, 2021 at 02:35:05PM +0200, Marek Szyprowski wrote: > Hi, > > On 13.09.2021 12:30, Andrzej Hajda wrote: > > W dniu 10.09.2021 o 12:12, Maxime Ripard pisze: > >> Without proper care and an agreement between how DSI hosts and devices > >> drivers register their MIPI-DSI enti

Re: Handling DRM master transitions cooperatively

2021-09-22 Thread Pekka Paalanen
On Tue, 14 Sep 2021 15:45:21 +0200 Daniel Vetter wrote: > On Thu, Sep 09, 2021 at 10:37:03AM +0300, Pekka Paalanen wrote: > > On Wed, 8 Sep 2021 18:27:09 +0200 > > Daniel Vetter wrote: > > > > > On Wed, Sep 8, 2021 at 9:36 AM Pekka Paalanen > > > wrote: > > > > > > > > On Tue, 7 Sep 2021

Re: [PATCH v4 02/24] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-09-22 Thread Maxime Ripard
Hi, On Tue, Sep 14, 2021 at 09:00:28PM +0200, Andrzej Hajda wrote: > > W dniu 14.09.2021 o 16:35, Maxime Ripard pisze: > > Hi, > > > > On Mon, Sep 13, 2021 at 08:29:37AM +0200, Andrzej Hajda wrote: > >> W dniu 10.09.2021 o 12:11, Maxime Ripard pisze: > >>> Interactions between bridges, panels, MI

[PATCH v2] component: do not leave master devres group open after bind

2021-09-22 Thread Kai Vehmanen
In current code, the devres group for aggregate master is left open after call to component_master_add_*(). This leads to problems when the master does further managed allocations on its own. When any participating driver calls component_del(), this leads to immediate release of resources. This ca

Deploying new iterator interface for dma-buf

2021-09-22 Thread Christian König
Hi guys, The version I've send out yesterday had a rather obvious coding error and I honestly forgot the cover letter. This one here is better tested and will now hopefully not be torn apart from the CI system immediately. I tried to address all review and documentation comments as best as I c

[PATCH 02/26] dma-buf: add dma_resv_for_each_fence

2021-09-22 Thread Christian König
A simpler version of the iterator to be used when the dma_resv object is locked. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 46 ++ include/linux/dma-resv.h | 19 2 files changed, 65 insertions(+) diff --git a/drivers/dm

[PATCH 03/26] dma-buf: use new iterator in dma_resv_copy_fences

2021-09-22 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 84 +++--- 1 file changed, 32 insertions(+), 52 deletions(-) diff --git a/dri

[PATCH 06/26] dma-buf: use new iterator in dma_resv_test_signaled

2021-09-22 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 57 +- 1 file changed, 7 insertions(+), 50 deletions(-) diff --git a/drive

[PATCH 05/26] dma-buf: use new iterator in dma_resv_wait_timeout

2021-09-22 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 69 +- 1 file changed, 8 insertions(+), 61 deletions(-) diff --git a/drive

[PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4

2021-09-22 Thread Christian König
Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they might be freed, improve kerneldoc, rename _cu

[PATCH 04/26] dma-buf: use new iterator in dma_resv_get_fences v2

2021-09-22 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 108 + 1 file changed, 36 insertions(+), 72

[PATCH 07/26] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

2021-09-22 Thread Christian König
This is probably a fix since we didn't even grabed a reference to the fences. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/g

[PATCH 14/26] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

2021-09-22 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 53 ++-- 1 file change

[PATCH 25/26] drm/etnaviv: replace dma_resv_get_excl_unlocked

2021-09-22 Thread Christian König
We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etna

[PATCH 08/26] drm/amdgpu: use the new iterator in amdgpu_sync_resv

2021-09-22 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 862eb3

[PATCH 10/26] drm/msm: use new iterator in msm_gem_describe

2021-09-22 Thread Christian König
Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

[PATCH 20/26] drm: use new iterator in drm_gem_fence_array_add_implicit v3

2021-09-22 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() v3: switch to locked version Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/

[PATCH 23/26] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

2021-09-22 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/g

[PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-09-22 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.

[PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object v2

2021-09-22 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() v3: use dma_resv_for_each_fence instead Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_request.c | 34 + 1 file changed, 5 insertions(+), 29 deletions(-) diff --git a/drivers

[PATCH 22/26] drm/nouveau: use the new iterator in nouveau_fence_sync

2021-09-22 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 05d0b3eb

[PATCH 24/26] drm/etnaviv: use new iterator in etnaviv_gem_describe

2021-09-22 Thread Christian König
Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 31 ++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index 8f1b5

[PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked

2021-09-22 Thread Christian König
Heureka, that's finally not used any more. Signed-off-by: Christian König --- include/linux/dma-resv.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h index 72e7ebaa675f..42ea6f667120 100644 --- a/include/linux/dm

[PATCH 16/26] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-09-22 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 51 +--- 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index f909aaa

[PATCH 09/26] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

2021-09-22 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 1129e17e9f09..4511cd

[PATCH 21/26] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-09-22 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_atomic_helper.c b/driv

[PATCH 11/26] drm/radeon: use new iterator in radeon_sync_resv

2021-09-22 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index 9257b60144c4..b991ba1

[PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-22 Thread Christian König
This is maybe even a fix since the RCU usage here looks incorrect. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915

[PATCH 17/26] drm/i915: use new iterator in i915_gem_object_wait_priority

2021-09-22 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 31 +--- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index a13193d

[PATCH 19/26] drm/i915: use new cursor in intel_prepare_plane_fb

2021-09-22 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/intel_display.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 134a6acbd8fb..

[PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-22 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++-- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_g

Re: Handling DRM master transitions cooperatively

2021-09-22 Thread Hans de Goede
Hi, On 9/22/21 10:56 AM, Pekka Paalanen wrote: > On Tue, 14 Sep 2021 15:45:21 +0200 > Daniel Vetter wrote: > >> On Thu, Sep 09, 2021 at 10:37:03AM +0300, Pekka Paalanen wrote: >>> On Wed, 8 Sep 2021 18:27:09 +0200 >>> Daniel Vetter wrote: >>> On Wed, Sep 8, 2021 at 9:36 AM Pekka Paalane

Re: Regression with mainline kernel on rpi4

2021-09-22 Thread Maxime Ripard
On Mon, Sep 20, 2021 at 06:21:42PM +0100, Sudip Mukherjee wrote: > On Mon, Sep 20, 2021 at 6:10 PM Maxime Ripard wrote: > > > > On Mon, Sep 20, 2021 at 05:35:00PM +0100, Sudip Mukherjee wrote: > > > On Mon, Sep 20, 2021 at 4:53 PM Maxime Ripard wrote: > > > > > > > > On Mon, Sep 20, 2021 at 05:43

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Fix a lockdep warning the __i915_gem_is_lmem() function

2021-09-22 Thread Matthew Auld
On Wed, 22 Sept 2021 at 09:38, Thomas Hellström wrote: > > Somehow we managed to invert the test for i915_gem_object_evictable(), > which causes a warning in DG1 BAT, igt@debugfs_test@read_all_entries. > > Fix the lock check to only warn if the object *is* indeed evictable and > not protected from

Re: Regression with mainline kernel on rpi4

2021-09-22 Thread Sudip Mukherjee
On Wed, Sep 22, 2021 at 10:57 AM Maxime Ripard wrote: > > On Mon, Sep 20, 2021 at 06:21:42PM +0100, Sudip Mukherjee wrote: > > On Mon, Sep 20, 2021 at 6:10 PM Maxime Ripard wrote: > > > > > > On Mon, Sep 20, 2021 at 05:35:00PM +0100, Sudip Mukherjee wrote: > > > > On Mon, Sep 20, 2021 at 4:53 PM

Re: [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 10:10, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++-- 1 file changed, 14 insertions(+), 21 deletion

Re: [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 10:10, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. I'm afraid I gazumped you here by removing this function shortly before you posted the respin. Regards, Tvrtko Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i9

Re: [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object v2

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 10:10, Christian König wrote: Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() v3: use dma_resv_for_each_fence instead Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_request.c | 34 + 1 file changed, 5 in

Re: [PATCH 2/3] drm/i915/ttm: Fix lockdep warning in __i915_gem_free_object()

2021-09-22 Thread Matthew Auld
On Wed, 22 Sept 2021 at 09:38, Thomas Hellström wrote: > > In the mman selftest, some tests make the ttm_bo_init_reserved() fail, > which may trigger a call to the i915_ttm_bo_destroy() function. > However, at this point the gem object refcount is set to 1, which > triggers a lockdep warning in __

Re: [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-22 Thread Christian König
Am 22.09.21 um 12:27 schrieb Tvrtko Ursulin: On 22/09/2021 10:10, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. I'm afraid I gazumped you here by removing this function shortly before you posted the respin. Is that already landed in drm-misc-next

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v7

2021-09-22 Thread Christian König
Totally forgotten to ping once more about that. Michel has tested this now and I think we should push it ASAP. So can I get an rb? Thanks, Christian. Am 23.07.21 um 10:04 schrieb Michel Dänzer: On 2021-07-20 3:11 p.m., Christian König wrote: Daniel pointed me towards this function and there

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

2021-09-22 Thread Jani Nikula
On Tue, 21 Sep 2021, Nathan Chancellor wrote: > On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: >> DP 2.0 brings some new DPCD addresses for PHY repeaters. >> >> Cc: dri-devel@lists.freedesktop.org >> Reviewed-by: Manasi Navare >> Signed-off-by: Jani Nikula >> --- >> include/drm/d

Re: [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 12:00, Christian König wrote: Am 22.09.21 um 12:27 schrieb Tvrtko Ursulin: On 22/09/2021 10:10, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. I'm afraid I gazumped you here by removing this function shortly before you posted the re

Re: [PATCH] drm/i915: Drop stealing of bits from i915_sw_fence function pointer

2021-09-22 Thread Jani Nikula
On Tue, 21 Sep 2021, Matthew Brost wrote: > Rather than stealing bits from i915_sw_fence function pointer use > seperate fields for function pointer and flags. If using two different > fields, the 4 byte alignment for the i915_sw_fence function pointer can > also be dropped. Yes, please, thank yo

[PATCH][next] drm/rockchip: Remove redundant assignment of pointer connector

2021-09-22 Thread Colin King
From: Colin Ian King The pointer connector is being assigned a value that is never read, it is being updated immediately afterwards. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/rockchip/rockchip_rgb.c |

Re: Regression with mainline kernel on rpi4

2021-09-22 Thread Maxime Ripard
On Wed, Sep 22, 2021 at 11:10:34AM +0100, Sudip Mukherjee wrote: > On Wed, Sep 22, 2021 at 10:57 AM Maxime Ripard wrote: > > > > On Mon, Sep 20, 2021 at 06:21:42PM +0100, Sudip Mukherjee wrote: > > > On Mon, Sep 20, 2021 at 6:10 PM Maxime Ripard wrote: > > > > > > > > On Mon, Sep 20, 2021 at 05:3

Re: [PATCH 2/3] drm/i915/ttm: Fix lockdep warning in __i915_gem_free_object()

2021-09-22 Thread Thomas Hellström
On 9/22/21 12:55 PM, Matthew Auld wrote: On Wed, 22 Sept 2021 at 09:38, Thomas Hellström wrote: In the mman selftest, some tests make the ttm_bo_init_reserved() fail, which may trigger a call to the i915_ttm_bo_destroy() function. However, at this point the gem object refcount is set to 1, wh

[PATCH] drm/etnaviv: fix another potential dma_resv DAG violation

2021-09-22 Thread Christian König
Setting the exclusive fence without waiting for the shared fences violates the DAG and is illegal. We really need to get away from this ASAP and make the driver interface more bullet prove. Signed-off-by: Christian König Cc: --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 6 +- 1 file c

Re: [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 11:21, Tvrtko Ursulin wrote: On 22/09/2021 10:10, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++--  

Re: [git pull] drm for 5.14-rc1

2021-09-22 Thread Maxime Ripard
On Mon, Sep 20, 2021 at 10:47:43AM -0700, Linus Torvalds wrote: > On Mon, Sep 20, 2021 at 10:33 AM Maxime Ripard wrote: > > > > What I was interested in was more about the context itself, and I'd > > still like an answer on whether it's ok to wait for a review for 5 > > months though, or if it's a

Re: [PATCH v4 09/14] drm/i915/ttm: add tt shmem backend

2021-09-22 Thread Thomas Hellström
Hi, Matthew, On 9/21/21 1:01 PM, Matthew Auld wrote: For cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such objects. For now this is still disabled. v2(Thomas): - Add optional try_

Re: [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-22 Thread Christian König
Am 22.09.21 um 13:46 schrieb Tvrtko Ursulin: On 22/09/2021 11:21, Tvrtko Ursulin wrote: On 22/09/2021 10:10, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/gem/i91

Re: [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 13:15, Christian König wrote: Am 22.09.21 um 13:46 schrieb Tvrtko Ursulin: On 22/09/2021 11:21, Tvrtko Ursulin wrote: On 22/09/2021 10:10, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Chri

Re: [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-22 Thread Christian König
Am 22.09.21 um 14:20 schrieb Tvrtko Ursulin: On 22/09/2021 13:15, Christian König wrote: Am 22.09.21 um 13:46 schrieb Tvrtko Ursulin: On 22/09/2021 11:21, Tvrtko Ursulin wrote: On 22/09/2021 10:10, Christian König wrote: This makes the function much simpler since the complex retry logic is

Re: [PATCH] drm/etnaviv: fix another potential dma_resv DAG violation

2021-09-22 Thread Lucas Stach
Am Mittwoch, dem 22.09.2021 um 13:41 +0200 schrieb Christian König: > Setting the exclusive fence without waiting for the shared > fences violates the DAG and is illegal. > > We really need to get away from this ASAP and make the > driver interface more bullet prove. Uh, what happened to Daniels

Re: [PATCH] drm/etnaviv: fix another potential dma_resv DAG violation

2021-09-22 Thread Christian König
Am 22.09.21 um 14:28 schrieb Lucas Stach: Am Mittwoch, dem 22.09.2021 um 13:41 +0200 schrieb Christian König: Setting the exclusive fence without waiting for the shared fences violates the DAG and is illegal. We really need to get away from this ASAP and make the driver interface more bullet pr

[PATCH] drm/bridge: dw-hdmi-cec: Make use of the helper function devm_add_action_or_reset()

2021-09-22 Thread Cai Huoqing
The helper function devm_add_action_or_reset() will internally call devm_add_action(), and if devm_add_action() fails then it will execute the action mentioned and return the error code. So use devm_add_action_or_reset() instead of devm_add_action() to simplify the error handling, reduce the code.

[PATCH] drm/i2c: tda9950: Make use of the helper function devm_add_action_or_reset()

2021-09-22 Thread Cai Huoqing
The helper function devm_add_action_or_reset() will internally call devm_add_action(), and if devm_add_action() fails then it will execute the action mentioned and return the error code. So use devm_add_action_or_reset() instead of devm_add_action() to simplify the error handling, reduce the code.

Re: [PATCH v4 10/14] drm/i915/ttm: hide shmem objects from TTM LRU

2021-09-22 Thread Matthew Auld
On 21/09/2021 12:48, Christian König wrote: Am 21.09.21 um 13:01 schrieb Matthew Auld: This is probably a NAK. But ideally we need to somehow prevent TTM from seeing shmem objects when doing its LRU swap walk. Since these are EXTERNAL they are ignored anyway, but keeping them in the LRU seems pr

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-22 Thread Tom Lendacky
On 9/21/21 4:58 PM, Kirill A. Shutemov wrote: On Tue, Sep 21, 2021 at 04:43:59PM -0500, Tom Lendacky wrote: On 9/21/21 4:34 PM, Kirill A. Shutemov wrote: On Tue, Sep 21, 2021 at 11:27:17PM +0200, Borislav Petkov wrote: On Wed, Sep 22, 2021 at 12:20:59AM +0300, Kirill A. Shutemov wrote: I stil

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

2021-09-22 Thread Alex Deucher
+ Harry, Leo Can you guys get someone to clean this up? Alex On Wed, Sep 22, 2021 at 7:10 AM Jani Nikula wrote: > > On Tue, 21 Sep 2021, Nathan Chancellor wrote: > > On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > >> DP 2.0 brings some new DPCD addresses for PHY repeaters. > >>

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-09-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #72 from Jerome C (m...@jeromec.com) --- Hi James, I noticed the patch that you asked us to try from comment 52 were also submitted to kernel 5.14.7 tested it, all is good for now Thanks Jerome -- You may reply to this email to a

Re: [PATCH v4 10/14] drm/i915/ttm: hide shmem objects from TTM LRU

2021-09-22 Thread Christian König
Am 22.09.21 um 15:34 schrieb Matthew Auld: On 21/09/2021 12:48, Christian König wrote: Am 21.09.21 um 13:01 schrieb Matthew Auld: This is probably a NAK. But ideally we need to somehow prevent TTM from seeing shmem objects when doing its LRU swap walk. Since these are EXTERNAL they are ignored

Re: [PATCH 0/5] drm/gma500: Managed cleanup

2021-09-22 Thread Patrik Jakobsson
On Mon, Sep 20, 2021 at 4:10 PM Thomas Zimmermann wrote: > > Switch gma500 to managed cleanup and remove the manual cleanup > code from the driver's PCI callbacks. > > Managed cleanup involves embedding the DRM device structure in the > driver's structure. In preparation, patch 1 replaces referenc

Re: [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-22 Thread Christian König
Am 22.09.21 um 12:21 schrieb Tvrtko Ursulin: On 22/09/2021 10:10, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++--  

Re: [PATCH v3 4/9] drm/scheduler: Add fence deadline support

2021-09-22 Thread Andrey Grodzovsky
On 2021-09-21 11:32 p.m., Rob Clark wrote: On Tue, Sep 21, 2021 at 7:18 PM Andrey Grodzovsky wrote: On 2021-09-21 4:47 p.m., Rob Clark wrote: On Tue, Sep 21, 2021 at 1:09 PM Andrey Grodzovsky wrote: On 2021-09-03 2:47 p.m., Rob Clark wrote: From: Rob Clark As the finished fence is the

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-22 Thread Kirill A. Shutemov
On Wed, Sep 22, 2021 at 08:40:43AM -0500, Tom Lendacky wrote: > On 9/21/21 4:58 PM, Kirill A. Shutemov wrote: > > On Tue, Sep 21, 2021 at 04:43:59PM -0500, Tom Lendacky wrote: > > > On 9/21/21 4:34 PM, Kirill A. Shutemov wrote: > > > > On Tue, Sep 21, 2021 at 11:27:17PM +0200, Borislav Petkov wrote

Re: [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 10:10, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they m

Re: [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 15:31, Christian König wrote: Am 22.09.21 um 12:21 schrieb Tvrtko Ursulin: On 22/09/2021 10:10, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/gem/i

Re: [PATCH v9 2/4] dt-bindings: mfd: logicvc: Add patternProperties for the display

2021-09-22 Thread Lee Jones
On Tue, 14 Sep 2021, Paul Kocialkowski wrote: > The LogiCVC multi-function device has a display part which is now > described in its binding. Add a patternProperties match for it. > > Signed-off-by: Paul Kocialkowski > --- > Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml | 3 +++ > 1

Re: [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4

2021-09-22 Thread Christian König
Am 22.09.21 um 16:36 schrieb Tvrtko Ursulin: + +/** + * dma_resv_iter_first_unlocked - first fence in an unlocked dma_resv obj. + * @cursor: the cursor with the current position + * + * Returns the first fence from an unlocked dma_resv obj. + */ +struct dma_fence *dma_resv_iter_first_unlocked(s

Re: [PATCH v3 4/9] drm/scheduler: Add fence deadline support

2021-09-22 Thread Rob Clark
On Wed, Sep 22, 2021 at 7:31 AM Andrey Grodzovsky wrote: > > > On 2021-09-21 11:32 p.m., Rob Clark wrote: > > On Tue, Sep 21, 2021 at 7:18 PM Andrey Grodzovsky > > wrote: > >> > >> On 2021-09-21 4:47 p.m., Rob Clark wrote: > >>> On Tue, Sep 21, 2021 at 1:09 PM Andrey Grodzovsky > >>> wrote: > >>

[PATCH] drm/i915: Drop stealing of bits from i915_sw_fence function pointer

2021-09-22 Thread Matthew Brost
Rather than stealing bits from i915_sw_fence function pointer use seperate fields for function pointer and flags. If using two different fields, the 4 byte alignment for the i915_sw_fence function pointer can also be dropped. v2: (CI) - Set new function field rather than flags in __i915_sw_fenc

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-22 Thread Harry Wentland
On 2021-09-20 20:14, Harry Wentland wrote: > On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 -0400 >> Harry Wentland wrote: >> >>> +If a display's maximum HDR white level is correctly reported it is trivial >>> +to convert between all of the above representations of

Re: [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 15:50, Christian König wrote: Am 22.09.21 um 16:36 schrieb Tvrtko Ursulin: + +/** + * dma_resv_iter_first_unlocked - first fence in an unlocked dma_resv obj. + * @cursor: the cursor with the current position + * + * Returns the first fence from an unlocked dma_resv obj. + */ +s

[PATCH] backlight: hx8357: Add SPI device ID table

2021-09-22 Thread Mark Brown
Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by adding a SPI device ID table. Fixes:

Re: [Intel-gfx] [PATCH] drm/i915: Drop stealing of bits from i915_sw_fence function pointer

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 15:57, Matthew Brost wrote: Rather than stealing bits from i915_sw_fence function pointer use seperate fields for function pointer and flags. If using two different fields, the 4 byte alignment for the i915_sw_fence function pointer can also be dropped. v2: (CI) - Set new fu

Re: [Intel-gfx] [PATCH] drm/i915: Drop stealing of bits from i915_sw_fence function pointer

2021-09-22 Thread Tvrtko Ursulin
On 22/09/2021 16:21, Tvrtko Ursulin wrote: On 22/09/2021 15:57, Matthew Brost wrote: Rather than stealing bits from i915_sw_fence function pointer use seperate fields for function pointer and flags. If using two different fields, the 4 byte alignment for the i915_sw_fence function pointer can

Re: Regression with mainline kernel on rpi4

2021-09-22 Thread Linus Torvalds
On Wed, Sep 22, 2021 at 3:11 AM Sudip Mukherjee wrote: > > That test script is triggering the openqa job, but its running only > after lava is able to login. The trace is appearing before the login > prompt even, so test_mainline.sh should not matter here. Side note: the traces might be more legi

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-22 Thread Harry Wentland
On 2021-09-22 04:31, Pekka Paalanen wrote: > On Tue, 21 Sep 2021 14:05:05 -0400 > Harry Wentland wrote: > >> On 2021-09-21 09:31, Pekka Paalanen wrote: >>> On Mon, 20 Sep 2021 20:14:50 -0400 >>> Harry Wentland wrote: >>> ... > >> Did anybody start any CM doc patches in Weston or Wayland

Re: Multiple DRI card detection in compositor systemd units

2021-09-22 Thread Simon Ser
Maybe try creating multiple physical seats with logind, and start each compositor on its own seat? A physical seat is a collection of devices like DRM nodes and evdev device files. Also udev creates files in /dev/dri/by-path/, these should be stable across reboots. `udevadm settle` before a compos

  1   2   >