[PATCH] drm: bridge: it66121: Added it66121 chip external screen status judgment.

2021-09-18 Thread Yunlongli
fix: Add further confirm if external screens are involved. log: In the actual tests, the IT66121 chip sometimes misjudged whether it had an external screen, so, reference the it66121_user_guid.pdf about Audio/Video data is stable or not A typical initialization of HDMI link should

[RFC PATCH 0/4] Add a DRM driver to support AI Processing Unit (APU)

2021-09-18 Thread Alexandre Bailon
This adds a DRM driver that implements communication between the CPU and an APU. This uses VirtIO buffer to exchange messages. For the data, we allocate a GEM object and map it using IOMMU to make it available to the APU. The driver is relatively generic, and should work with any SoC implementing h

[PATCH] drm: bridge: it66121: Added it66121 chip external screen status judgment.

2021-09-18 Thread Yunlongli
fix: Add further confirm if external screens are involved. log: In the actual tests, the IT66121 chip sometimes misjudged whether it had an external screen, so, reference the it66121_user_guid.pdf about Audio/Video data is stable or not A typical initialization of HDMI link should

[RFC PATCH 1/4] dt-bindings: Add bidings for mtk,apu-drm

2021-09-18 Thread Alexandre Bailon
This adds the device tree bindings for the APU DRM driver. Signed-off-by: Alexandre Bailon --- .../devicetree/bindings/gpu/mtk,apu-drm.yaml | 38 +++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpu/mtk,apu-drm.yaml diff --git a/Documen

[RFC PATCH 3/4] rpmsg: Add support of AI Processor Unit (APU)

2021-09-18 Thread Alexandre Bailon
Some Mediatek SoC provides hardware accelerator for AI / ML. This driver use the DRM driver to manage the shared memory, and use rpmsg to execute jobs on the APU. Signed-off-by: Alexandre Bailon --- drivers/rpmsg/Kconfig | 10 +++ drivers/rpmsg/Makefile| 1 + drivers/rpmsg/apu_rpmsg.c

[RFC PATCH 2/4] DRM: Add support of AI Processor Unit (APU)

2021-09-18 Thread Alexandre Bailon
Some Mediatek SoC provides hardware accelerator for AI / ML. This driver provides the infrastructure to manage memory shared between host CPU and the accelerator, and to submit jobs to the accelerator. The APU itself is managed by remoteproc so this drivers relies on remoteproc to found the APU and

[PATCH] drm: panel-orientation-quirks: Add quirk for GPD Win3

2021-09-18 Thread Mario
--- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index f6bdec7fa925..f6177c1d9872 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c

[RFC PATCH 4/4] ARM64: mt8183-pumpkin: Add the APU DRM device

2021-09-18 Thread Alexandre Bailon
This add the APU DRM device to pumkpin. Signed-off-by: Alexandre Bailon --- arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts index 7fbed2b7b

Re: [PATCH v5 00/16] Add MediaTek SoC DRM (vdosys1) support for mt8195

2021-09-18 Thread Markus Schneider-Pargmann
Hi Nancy, On Mon, Sep 06, 2021 at 03:15:23PM +0800, Nancy.Lin wrote: > The hardware path of vdosys1 with DPTx output need to go through by several > modules, such as, OVL_ADAPTOR and MERGE. > > Add DRM and these modules support by the patches below: > > Changes in v5: > - add mmsys reset contro

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-18 Thread Oded Gabbay
On Fri, Sep 17, 2021 at 3:30 PM Daniel Vetter wrote: > > On Thu, Sep 16, 2021 at 10:10:14AM -0300, Jason Gunthorpe wrote: > > On Thu, Sep 16, 2021 at 02:31:34PM +0200, Daniel Vetter wrote: > > > On Wed, Sep 15, 2021 at 10:45:36AM +0300, Oded Gabbay wrote: > > > > On Tue, Sep 14, 2021 at 7:12 PM Ja

[PATCH] panfrost: make mediatek_mt8183_supplies and mediatek_mt8183_pm_domains static

2021-09-18 Thread Jiapeng Chong
This symbol is not used outside of panfrost_drv.c, so marks it static. Fix the following sparse warning: drivers/gpu/drm/panfrost/panfrost_drv.c:641:12: warning: symbol 'mediatek_mt8183_supplies' was not declared. Should it be static? drivers/gpu/drm/panfrost/panfrost_drv.c:642:12: warning: symb

Re: [PATCH 14/15] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-18 Thread Fernando Ramos
On 21/09/18 01:17AM, Fernando Ramos wrote: > > > +#include > > > > Top-level headers generally come above the driver headers. Also, now that I > > think > > about this a bit more, all of the new includes in this set should probably > > be > > for 'drm_modeset_lock.h' instead of 'drm_drv.h'. >

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Michael Stapelberg
Hi, torvalds at linux-foundation.org (Linus Torvalds) writes: > Did I fix it up correctly? Who knows. The code makes more sense to me > now and seems valid. But I really *really* want to stress how locking > is important. As far as I can tell, this merge conflict resolution made my Raspberry Pi 3

[PATCH] drm/radeon: fix uninitialized bool variable

2021-09-18 Thread yangzhiwei
>From 23dc76b1a4c7eb516b2830e1d2bb588316e18e93 Mon Sep 17 00:00:00 2001 From: Zhiwei Yang Date: Sat, 18 Sep 2021 16:17:06 +0800 Subject: [PATCH] drm/radeon: fix uninitialized bool variable The bool variable detected_hpd_without_ddc in struct radeon_connector is uninitialized when first used,

[PATCH] drm/radeon: fix uninitialized bool variable

2021-09-18 Thread Zhiwei Yang
The bool variable detected_hpd_without_ddc in struct radeon_connector is uninitialized when first used, that may cause unnecessary ddc ops. Make it as false when a new connector is alloced. Signed-off-by: Zhiwei Yang --- drivers/gpu/drm/radeon/radeon_connectors.c | 4 1 file changed, 4 inse

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Simon Ser
CC Emma and Maxime On Saturday, September 18th, 2021 at 11:18, Michael Stapelberg wrote: > Hi, > > torvalds at linux-foundation.org (Linus Torvalds) writes: > > Did I fix it up correctly? Who knows. The code makes more sense to me > > now and seems valid. But I really *really* want to stress ho

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-09-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 --- Comment #9 from Nils Tonnätt (nils.tonna...@posteo.de) --- I've tested 5.15.0-0.rc1.20210917gitbdb575f87217 from Fedora's mainline kernel repo where this is already applied. But this triggers a segfault in gnome-shell (even with DP 1.2 turned

Re: [PATCH v2] drm/bridge: lt9611: Fix handling of 4k panels

2021-09-18 Thread Greg KH
On Fri, Sep 17, 2021 at 12:47:05PM -0700, Peter Collingbourne wrote: > On Thu, Dec 17, 2020 at 6:09 AM Robert Foss wrote: > > > > 4k requires two dsi pipes, so don't report MODE_OK when only a > > single pipe is configured. But rather report MODE_PANEL to > > signal that requirements of the panel

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-09-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 --- Comment #10 from Nils Tonnätt (nils.tonna...@posteo.de) --- I patched 5.14.5. I see now difference in behavior. When the screen stays black it often works to switch to a tty or turn off and on the display. Dmesg seems to became a little more v

Re: [PATCH] net: mana: Prefer struct_size over open coded arithmetic

2021-09-18 Thread Len Baker
Hi, On Sat, Sep 11, 2021 at 12:28:18PM +0200, Len Baker wrote: > As noted in the "Deprecated Interfaces, Language Features, Attributes, > and Conventions" documentation [1], size calculations (especially > multiplication) should not be performed in memory allocator (or similar) > function argument

Re: [PATCH] net: mana: Prefer struct_size over open coded arithmetic

2021-09-18 Thread Kees Cook
On September 18, 2021 6:20:10 AM PDT, Len Baker wrote: >Hi, > >On Sat, Sep 11, 2021 at 12:28:18PM +0200, Len Baker wrote: >> As noted in the "Deprecated Interfaces, Language Features, Attributes, >> and Conventions" documentation [1], size calculations (especially >> multiplication) should not

[PATCH] drm: bridge: it66121: Fix return value it66121_probe

2021-09-18 Thread Alex Bee
Currently it66121_probe returns -EPROBE_DEFER if the there is no remote endpoint found in the device tree which doesn't seem helpful, since this is not going to change later and it is never checked if the next bridge has been initialized yet. It will fail in that case later while doing drm_bridge_a

Re: [PATCH v3 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent

2021-09-18 Thread Marijn Suijten
On 2021-09-14 14:44:01, Stephen Boyd wrote: > Quoting Marijn Suijten (2021-09-11 06:19:19) > > All DSI PHY/PLL drivers were referencing their VCO parent clock by a > > global name, most of which don't exist or have been renamed. These > > clock drivers seem to function fine without that except the

RE: [PATCH] net: mana: Prefer struct_size over open coded arithmetic

2021-09-18 Thread Dexuan Cui
> From: Len Baker > Sent: Saturday, September 18, 2021 6:20 AM > ... > I have received a email from the linux-media subsystem telling that this > patch is not applicable. The email is the following: > > Regards, > Len The patch is already in the net-next tree: https://git.kernel.org/pub/scm/lin

Re: [PATCH] net: mana: Prefer struct_size over open coded arithmetic

2021-09-18 Thread Len Baker
Hi Kees, On Sat, Sep 18, 2021 at 06:51:51AM -0700, Kees Cook wrote: > > > On September 18, 2021 6:20:10 AM PDT, Len Baker wrote: > >Hi, > > > >On Sat, Sep 11, 2021 at 12:28:18PM +0200, Len Baker wrote: > >> As noted in the "Deprecated Interfaces, Language Features, Attributes, > >> and Convention

[Bug 214375] 5.14 Regression: Null pointer dereference in radeon_agp_head_init

2021-09-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214375 Calvin Walton (calvin.wal...@kepstin.ca) changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH v5 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-18 Thread Philip Chen
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs, which will simplify the future update on ps8640 driver. Reviewed-by: Douglas Anderson Signed-off-by: Philip Chen --- (no changes since v4) Changes in v4: - Remove excessive error logging from the probe function Changes in

[PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-18 Thread Philip Chen
Implement the first version of AUX support, which will be useful as we expand the driver to support varied use cases. Signed-off-by: Philip Chen --- Changes in v5: - Add a couple of syntax fixes accidentally uncommited in v4 Changes in v4: - Fix aux_transfer function: - Replace dev_err with D

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Linus Torvalds
On Sat, Sep 18, 2021 at 2:18 AM Michael Stapelberg wrote: > > torvalds at linux-foundation.org (Linus Torvalds) writes: > > Did I fix it up correctly? Who knows. The code makes more sense to me > > now and seems valid. But I really *really* want to stress how locking > > is important. > > As far a

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Michael Stapelberg
On Sat, 18 Sept 2021 at 21:24, Linus Torvalds wrote: > > On Sat, Sep 18, 2021 at 2:18 AM Michael Stapelberg > wrote: > > > > torvalds at linux-foundation.org (Linus Torvalds) writes: > > > Did I fix it up correctly? Who knows. The code makes more sense to me > > > now and seems valid. But I reall

Re: [PATCH v5 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-18 Thread Sam Ravnborg
Hi Philip, On Sat, Sep 18, 2021 at 10:21:16AM -0700, Philip Chen wrote: > Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs, > which will simplify the future update on ps8640 driver. > > Reviewed-by: Douglas Anderson > Signed-off-by: Philip Chen Looks good, Acked-by: Sam R

Re: [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-18 Thread Sam Ravnborg
Hi Philip, On Sat, Sep 18, 2021 at 10:21:17AM -0700, Philip Chen wrote: > Implement the first version of AUX support, which will be useful as > we expand the driver to support varied use cases. > > Signed-off-by: Philip Chen Patch is: Signed-off-by: Sam Ravnborg please consider a few follow-up

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Sudip Mukherjee
Hi Linus, On Sat, Sep 18, 2021 at 8:24 PM Linus Torvalds wrote: > > On Sat, Sep 18, 2021 at 2:18 AM Michael Stapelberg > wrote: > > > > torvalds at linux-foundation.org (Linus Torvalds) writes: > > > Did I fix it up correctly? Who knows. The code makes more sense to me > > > now and seems valid.

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Linus Torvalds
On Sat, Sep 18, 2021 at 1:13 PM Michael Stapelberg wrote: > > > Michael - do things work if you revert those two (sadly, they don't > > revert cleanly exactly _because_ of the other changes in the same > > area)? > > Reverting only 9984d6664ce9 is not sufficient, but reverting both > 9984d6664ce9

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Linus Torvalds
On Sat, Sep 18, 2021 at 3:00 PM Sudip Mukherjee wrote: > > Its still there. I am seeing it every night. This was from last night > - https://lava.qa.codethink.co.uk/scheduler/job/164#L1356 Note that that web server is not available at least to me. Looks like some internal name or limited dns, I

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Sudip Mukherjee
On Sat, Sep 18, 2021 at 11:15 PM Linus Torvalds wrote: > > On Sat, Sep 18, 2021 at 3:00 PM Sudip Mukherjee > wrote: > > > > Its still there. I am seeing it every night. This was from last night > > - https://lava.qa.codethink.co.uk/scheduler/job/164#L1356 > > Note that that web server is not avai

Re: [git pull] drm for 5.14-rc1

2021-09-18 Thread Linus Torvalds
On Sat, Sep 18, 2021 at 3:48 PM Sudip Mukherjee wrote: > > Also, I have now tested by reverting those two commits and I still get > the same trace on rpi4. Ok. I'm afraid we really need to have the VC4 people figure it out - I count do the two reverts that are reported to fix the RPi3 issue, but

Re: [RFC PATCH 2/4] DRM: Add support of AI Processor Unit (APU)

2021-09-18 Thread Hillf Danton
On Fri, 17 Sep 2021 14:59:43 +0200 Alexandre Bailon wrote: > +static DEFINE_IDA(req_ida); > +static LIST_HEAD(complete_node); I see accesses to complete_node in apu_drm_callback(), apu_job_timedout() and ioctl_gem_dequeue() without working out the serialization to avoid list corruption. Can you ad