Re: [Intel-gfx] [PATCH 04/14] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-09-14 Thread kernel test robot
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.15-rc1 next-20210914] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch

Re: [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Christian König
Am 13.09.21 um 14:41 schrieb Thomas Hellström: [SNIP] Let's say you have a struct ttm_object_vram and a struct ttm_object_gtt, both subclassing drm_gem_object. Then I'd say a driver would want to subclass those to attach identical data, extend functionality and provide a single i915_gem_object

Re: [PATCH v3 0/6] drm/vc4: hdmi: Fix CEC access while disabled

2021-09-14 Thread Maxime Ripard
On Thu, Aug 19, 2021 at 03:59:25PM +0200, Maxime Ripard wrote: > Hi, > > This series aims at fixing a complete and silent hang when one tries to use > CEC > while the display output is off. > > This can be tested with: > > echo off > /sys/class/drm/card0-HDMI-A-1/status > cec-ctl --tuner -p 1.0

Re: [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Thomas Hellström
On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: > Am 13.09.21 um 14:41 schrieb Thomas Hellström: > > [SNIP] > > > > > Let's say you have a struct ttm_object_vram and a struct > > > > > ttm_object_gtt, both subclassing drm_gem_object. Then I'd say > > > > > a > > > > > driver would want

Re: [PATCH v2 0/6] drm/displayid: VESA vendor block and drm/i915 MSO use of it

2021-09-14 Thread Maxime Ripard
Hi, On Mon, Sep 13, 2021 at 07:45:03PM +0300, Jani Nikula wrote: > On Tue, 31 Aug 2021, Jani Nikula wrote: > > v2 of https://patchwork.freedesktop.org/series/94161/ with the VESA OUI > > check and an OUI helper patch added. > > Maarten, Maxime, Thomas - may I have an ack for merging this via > d

Re: [Intel-gfx] [PATCH 08/27] drm/i915: Add logical engine mapping

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 17:50, Matthew Brost wrote: On Mon, Sep 13, 2021 at 10:24:43AM +0100, Tvrtko Ursulin wrote: On 10/09/2021 20:49, Matthew Brost wrote: On Fri, Sep 10, 2021 at 12:12:42PM +0100, Tvrtko Ursulin wrote: On 20/08/2021 23:44, Matthew Brost wrote: Add logical engine mapping. This is

Re: [Intel-gfx] [PATCH 04/27] drm/i915/guc: Take GT PM ref when deregistering context

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 18:12, Matthew Brost wrote: On Mon, Sep 13, 2021 at 10:55:59AM +0100, Tvrtko Ursulin wrote: On 20/08/2021 23:44, Matthew Brost wrote: Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while a deregister context H2G is in flight. FIXME: Move locking

Re: Accelerator drivers going forward (was Re: Habanalabs Open-Source TPC LLVM compiler and SynapseAI Core library)

2021-09-14 Thread Oded Gabbay
On Sun, Sep 12, 2021 at 10:32 PM Dave Airlie wrote: > > On Sun, 12 Sept 2021 at 23:55, Greg Kroah-Hartman > wrote: > > > > On Fri, Sep 10, 2021 at 06:10:27PM +0200, Daniel Vetter wrote: > > > Forgot to add dri-devel. > > > > > > On Fri, Sep 10, 2021 at 6:09 PM Daniel Vetter > > > wrote: > > > >

RE: [PATCH 2/4] drm/dp_mst: Only create connector for connected end device

2021-09-14 Thread Lin, Wayne
[Public] > -Original Message- > From: Lyude Paul > Sent: Thursday, September 2, 2021 6:00 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org > Cc: Kazlauskas, Nicholas ; Wentland, Harry > ; Zuo, Jerry > ; Wu, Hersen ; Juston Li > ; Imre Deak ; > Ville Syrjälä ; Daniel Vetter > ; Sea

Re: [PATCH 3/3] drm/vc4: dsi: Switch to devm_drm_of_get_bridge

2021-09-14 Thread Maxime Ripard
Hi, On Sun, Sep 12, 2021 at 09:46:46PM +0200, Sam Ravnborg wrote: > On Fri, Sep 10, 2021 at 03:09:41PM +0200, Maxime Ripard wrote: > > The new devm_drm_of_get_bridge removes most of the boilerplate we > > have to deal with. Let's switch to it. > > > > Signed-off-by: Maxime Ripard > > With the i

[PATCH v2 1/7] drm/i915/gem: Break out some shmem backend utils

2021-09-14 Thread Matthew Auld
From: Thomas Hellström Break out some shmem backend utils for future reuse by the TTM backend: shmem_alloc_st(), shmem_free_st() and __shmem_writeback() which we can use to provide a shmem-backed TTM page pool for cached-only TTM buffer objects. Main functional change here is that we now compute

[PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM

2021-09-14 Thread Matthew Auld
Add new flag to indicate special shmem based tt, which can directly handle swapping itself, and should be visible to some shrinker. As part of this we should skip the ttm_pages_allocated accounting, since such tt objects should already be reachable, and potentially reclaimable by some shrinker, if

[PATCH v2 3/7] drm/i915/ttm: add tt shmem backend

2021-09-14 Thread Matthew Auld
For cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such objects. For now this is still disabled. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Christian König --- drivers/gpu/d

[PATCH v2 7/7] drm/i915/ttm: enable shmem tt backend

2021-09-14 Thread Matthew Auld
Enable shmem tt backend, and enable shrinking. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index f02037a8cebd..

[PATCH v2 4/7] drm/i915/ttm: use cached system pages when evicting lmem

2021-09-14 Thread Matthew Auld
This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8 -

[PATCH v2 6/7] drm/i915/ttm: make evicted shmem pages visible to the shrinker

2021-09-14 Thread Matthew Auld
We currently just evict lmem objects to system memory when under memory pressure. For this case we lack the usual object mm.pages, which effectively hides the pages from the i915-gem shrinker, until we actually "attach" the TT to the object, or in the case of lmem-only objects it just gets migrated

[PATCH v2 5/7] drm/i915: try to simplify make_{un}shrinkable

2021-09-14 Thread Matthew Auld
Drop the atomic shrink_pin stuff, and just have make_{un}shrinkable update the shrinker visible lists immediately. This at least simplifies the next patch, and does make the behaviour more obvious. The potential downside is that make_unshrinkable now grabs a global lock even when the object itself

Re: [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Christian König
Am 14.09.21 um 10:27 schrieb Thomas Hellström: On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: Am 13.09.21 um 14:41 schrieb Thomas Hellström: [SNIP] Let's say you have a struct ttm_object_vram and a struct ttm_object_gtt, both subclassing drm_gem_object. Then I'd say a driver would w

Re: [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM

2021-09-14 Thread Christian König
Am 14.09.21 um 10:50 schrieb Matthew Auld: Add new flag to indicate special shmem based tt, which can directly handle swapping itself, and should be visible to some shrinker. As part of this we should skip the ttm_pages_allocated accounting, since such tt objects should already be reachable, and

Re: [PATCH 0/1] lib, stackdepot: Add helper to print stack entries into buffer.

2021-09-14 Thread Vlastimil Babka
On 9/10/21 16:10, Imran Khan wrote: > This change is in response to discussion at [1]. > The patch has been created on top of my earlier changes [2] and [3]. > If needed I can resend all of these patches together, though my > earlier patches have been Acked. I think you sent those at the beginning

Re: [PATCH] drm/sun4i: dw-hdmi: Fix HDMI PHY clock setup

2021-09-14 Thread Ondřej Jirman
Hello Jernej, On Mon, Sep 13, 2021 at 07:21:54PM +0200, Jernej Skrabec wrote: > Recent rework, which made HDMI PHY driver a platform device, inadvertely > reversed clock setup order. HW is very touchy about it. Proper way is to > handle controllers resets and clocks first and HDMI PHYs second. >

Re: [PATCH] drm/i915/dp: add a delay before setting panel brightness after power on

2021-09-14 Thread Jani Nikula
On Mon, 13 Sep 2021, Vasily Khoruzhick wrote: > Panel in my Dell XPS 7590, that uses Intel's HDR backlight interface to > control brightness, apparently needs a delay before setting brightness > after power on. Without this delay the panel does accept the setting > and may come up with some arbitr

Re: [PATCH 1/4] drm/i915: rename debugfs_gt files

2021-09-14 Thread Jani Nikula
On Wed, 08 Sep 2021, Lucas De Marchi wrote: > We shouldn't be using debugfs_ namespace for this functionality. Rename > debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions, > defines and structs follow suit. > > While at it and since we are renaming the header, sort the includes > alp

[PATCH v2 0/3] clk: Implement a clock request API

2021-09-14 Thread Maxime Ripard
Hi, This is a follow-up of the discussion here: https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ This implements a mechanism to raise and lower clock rates based on consumer workloads, with an example of such an implementation for the RaspberryPi4 HDMI controller. There

[PATCH v2 1/3] clk: Introduce a clock request API

2021-09-14 Thread Maxime Ripard
It's not unusual to find clocks being shared across multiple devices that need to change the rate depending on what the device is doing at a given time. The SoC found on the RaspberryPi4 (BCM2711) is in such a situation between its two HDMI controllers that share a clock that needs to be raised de

[PATCH v2 2/3] drm/vc4: hdmi: Convert to the new clock request API

2021-09-14 Thread Maxime Ripard
The new clock request API allows us to increase the rate of the HSM clock to match our pixel rate requirements while decreasing it when we're done, resulting in a better power-efficiency. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 15 ++- drivers/gpu/drm/vc4/vc

[PATCH v2 3/3] drm/vc4: hvs: Convert to the new clock request API

2021-09-14 Thread Maxime Ripard
From: Dom Cobley The new clock request API allows us to increase the rate of the core clock as required during mode set while decreasing it when we're done, resulting in a better power-efficiency. Signed-off-by: Dom Cobley Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 5 +++

[PATCH v2 1/3] drm/probe-helper: Document drm_helper_hpd_irq_event() return value

2021-09-14 Thread Maxime Ripard
The documentation of the drm_helper_hpd_irq_event() function didn't document the value that function was returning. Add that part as well. Signed-off-by: Maxime Ripard --- Changes from v2: - new patch --- drivers/gpu/drm/drm_probe_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 2/3] drm/probe-helper: Create a HPD IRQ event helper for a single connector

2021-09-14 Thread Maxime Ripard
The drm_helper_hpd_irq_event() function is iterating over all the connectors when an hotplug event is detected. During that iteration, it will call each connector detect function and figure out if its status changed. Finally, if any connector changed, it will notify the user-space and the clients

[PATCH v2 3/3] drm/vc4: hdmi: Actually check for the connector status in hotplug

2021-09-14 Thread Maxime Ripard
The drm_helper_hpd_irq_event() documentation states that this function is "useful for drivers which can't or don't track hotplug interrupts for each connector." and that "Drivers which support hotplug interrupts for each connector individually and which have a more fine-grained detect logic should

Re: [Intel-gfx] [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_request.c | 36 ++--- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/g

Re: [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Thomas Hellström
On Tue, 2021-09-14 at 10:53 +0200, Christian König wrote: > Am 14.09.21 um 10:27 schrieb Thomas Hellström: > > On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: > > > Am 13.09.21 um 14:41 schrieb Thomas Hellström: > > > > [SNIP] > > > > > > > Let's say you have a struct ttm_object_vram and

Re: [Intel-gfx] [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object

2021-09-14 Thread Christian König
Am 14.09.21 um 12:26 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/i915_request.c | 36 ++---   1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/dri

Re: [PATCH v2 2/3] drm/probe-helper: Create a HPD IRQ event helper for a single connector

2021-09-14 Thread Sam Ravnborg
Hi Maxime, On Tue, Sep 14, 2021 at 12:17:23PM +0200, Maxime Ripard wrote: > The drm_helper_hpd_irq_event() function is iterating over all the > connectors when an hotplug event is detected. > > During that iteration, it will call each connector detect function and > figure out if its status chang

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. Signed-off-by: Christian König --- drivers/dm

Re: [Intel-gfx] [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object

2021-09-14 Thread Tvrtko Ursulin
On 14/09/2021 11:39, Christian König wrote: Am 14.09.21 um 12:26 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/i915_request.c | 36 ++---   1 file changed, 7 i

Re: [PATCH] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-14 Thread Heiko Stübner
Hi, Am Mittwoch, 8. September 2021, 15:53:56 CEST schrieb Chris Morgan: > From: Chris Morgan > > After commit 928f9e268611 ("clk: fractional-divider: Hide > clk_fractional_divider_ops from wide audience") was merged it appears > that the DSI panel on my Odroid Go Advance stopped working. Upon cl

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-14 Thread Christian König
Am 14.09.21 um 12:53 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. Sig

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Borislav Petkov
On Wed, Sep 08, 2021 at 05:58:35PM -0500, Tom Lendacky wrote: > Introduce a powerpc version of the cc_platform_has() function. This will > be used to replace the powerpc mem_encrypt_active() implementation, so > the implementation will initially only support the CC_ATTR_MEM_ENCRYPT > attribute. >

Re: [PATCH v6, 00/15] Using component framework to support multi hardware decode

2021-09-14 Thread yunfei.d...@mediatek.com
Hi Ezequiel, On Fri, 2021-09-03 at 11:08 +0800, yunfei.d...@mediatek.com wrote: > Hi Ezequiel, > > Thanks for your suggestion. > On Thu, 2021-09-02 at 13:30 -0300, Ezequiel Garcia wrote: > > On Wed, 1 Sept 2021 at 05:32, Yunfei Dong > > > > wrote: > > > > > > This series adds support for multi

Re: [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. What you think is incorrect? Pointless extra rcu locking? Also, FWIW, I submitted a patch to remove this function altogether since its IMO pretty useless, just failed in getting an

Re: [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-14 Thread Christian König
Am 14.09.21 um 14:27 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. What you think is incorrect? Pointless extra rcu locking? Yeah, exactly that. I also wondered for a second if rcu_read_lock() can nest

Re: [Intel-gfx] [PATCH 17/26] drm/i915: use new iterator in i915_gem_object_wait_priority

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 29 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/driv

Re: [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

2021-09-14 Thread Maarten Lankhorst
Op 14-09-2021 om 08:50 schreef Peter Zijlstra: > On Mon, Sep 13, 2021 at 10:42:36AM +0200, Maarten Lankhorst wrote: > >>> +/** >>> + * ww_mutex_trylock - tries to acquire the w/w mutex with optional acquire >>> context >>> + * @ww: mutex to lock >>> + * @ww_ctx: optional w/w acquire context >>> +

Re: [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-14 Thread Tvrtko Ursulin
On 14/09/2021 13:32, Christian König wrote: Am 14.09.21 um 14:27 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. What you think is incorrect? Pointless extra rcu locking? Yeah, exactly that. I also won

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-14 Thread Tvrtko Ursulin
On 14/09/2021 12:25, Christian König wrote: Am 14.09.21 um 12:53 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences wher

Re: [Intel-gfx] [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 30 +++- 1 file changed, 9 insertions(+), 21 deletions

Re: [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-14 Thread Jason Gunthorpe
On Mon, Sep 13, 2021 at 04:31:54PM -0400, Eric Farman wrote: > > I rebased it and fixed it up here: > > > > https://github.com/jgunthorpe/linux/tree/vfio_ccw > > > > Can you try again? > > That does address the crash, but then why is it processing a BROKEN > event? Seems problematic. The stuff

Re: [PATCH v3 4/9] drm/scheduler: Add fence deadline support

2021-09-14 Thread Daniel Vetter
On Thu, Sep 09, 2021 at 08:22:59AM +0200, Christian König wrote: > Am 08.09.21 um 19:45 schrieb Daniel Vetter: > > On Fri, Sep 03, 2021 at 11:47:55AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > As the finished fence is the one that is exposed to userspace, and > > > therefore the on

Re: Handling DRM master transitions cooperatively

2021-09-14 Thread Daniel Vetter
On Thu, Sep 09, 2021 at 10:37:03AM +0300, Pekka Paalanen wrote: > On Wed, 8 Sep 2021 18:27:09 +0200 > Daniel Vetter wrote: > > > On Wed, Sep 8, 2021 at 9:36 AM Pekka Paalanen wrote: > > > > > > On Tue, 7 Sep 2021 14:42:56 +0200 > > > Hans de Goede wrote: > > > > > > > Hi, > > > > > > > > On 9

Re: [PATCH 1/2] drm/nouveau/ga102-: support ttm buffer moves via copy engine

2021-09-14 Thread Daniel Vetter
On Thu, Sep 09, 2021 at 08:37:23AM +1000, Ben Skeggs wrote: > On Thu, 9 Sept 2021 at 04:19, Daniel Vetter wrote: > > > > On Mon, Sep 06, 2021 at 10:56:27AM +1000, Ben Skeggs wrote: > > > From: Ben Skeggs > > > > > > We don't currently have any kind of real acceleration on Ampere GPUs, > > > but t

Re: [resend PATCH] drm/ttm: Fix a deadlock if the target BO is not idle during swap

2021-09-14 Thread Daniel Vetter
On Thu, Sep 09, 2021 at 09:10:39AM +0200, Christian König wrote: > Am 08.09.21 um 20:27 schrieb Daniel Vetter: > > On Tue, Sep 07, 2021 at 11:28:23AM +0200, Christian König wrote: > > > Am 07.09.21 um 11:05 schrieb Daniel Vetter: > > > > On Tue, Sep 07, 2021 at 08:22:20AM +0200, Christian König wro

Re: [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

2021-09-14 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 02:43:02PM +0200, Maarten Lankhorst wrote: > Op 14-09-2021 om 08:50 schreef Peter Zijlstra: > > On Mon, Sep 13, 2021 at 10:42:36AM +0200, Maarten Lankhorst wrote: > > > >>> +/** > >>> + * ww_mutex_trylock - tries to acquire the w/w mutex with optional > >>> acquire context

Re: [PATCH] dma-buf: system_heap: Avoid warning on mid-order allocations

2021-09-14 Thread Daniel Vetter
On Thu, Sep 09, 2021 at 02:37:41AM +, John Stultz wrote: > When trying to do mid-order allocations, set __GFP_NOWARN to > avoid warning messages if the allocation fails, as we will > still fall back to single page allocatitions in that case. > This is the similar to what we already do for large

Re: [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 12:38:00PM +0200, Thomas Hellström wrote: > On Tue, 2021-09-14 at 10:53 +0200, Christian König wrote: > > Am 14.09.21 um 10:27 schrieb Thomas Hellström: > > > On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: > > > > Am 13.09.21 um 14:41 schrieb Thomas Hellström: > >

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-14 Thread Daniel Vetter
On Sun, Sep 12, 2021 at 07:53:07PM +0300, Oded Gabbay wrote: > Hi, > Re-sending this patch-set following the release of our user-space TPC > compiler and runtime library. > > I would appreciate a review on this. I think the big open we have is the entire revoke discussions. Having the option to l

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Do error capture asynchronously

2021-09-14 Thread Daniel Vetter
On Mon, Sep 13, 2021 at 10:09:54PM -0700, Matthew Brost wrote: > An error capture allocates memory, memory allocations depend on resets, > and resets need to flush the G2H handlers to seal several races. If the > error capture is done from the G2H handler this creates a circular > dependency. To wo

[PATCH] DRM/Panel : abt-y030xx067a yellow tint fix

2021-09-14 Thread Christophe Branchereau
The previous parameters caused an unbalanced yellow tint. Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c b/drivers/gpu/drm/panel/panel-abt

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Refcount context during error capture

2021-09-14 Thread Daniel Vetter
On Mon, Sep 13, 2021 at 10:09:56PM -0700, Matthew Brost wrote: > From: John Harrison > > When i915 receives a context reset notification from GuC, it triggers > an error capture before resetting any outstanding requsts of that > context. Unfortunately, the error capture is not a time bound > oper

Re: [PATCH v2 3/3] drm/vc4: hdmi: Actually check for the connector status in hotplug

2021-09-14 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 12:17:24PM +0200, Maxime Ripard wrote: > The drm_helper_hpd_irq_event() documentation states that this function > is "useful for drivers which can't or don't track hotplug interrupts for > each connector." and that "Drivers which support hotplug interrupts for > each connect

Re: [PATCH v4 02/24] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-09-14 Thread Maxime Ripard
Hi, On Mon, Sep 13, 2021 at 08:29:37AM +0200, Andrzej Hajda wrote: > > W dniu 10.09.2021 o 12:11, Maxime Ripard pisze: > > Interactions between bridges, panels, MIPI-DSI host and the component > > framework are not trivial and can lead to probing issues when > > implementing a display driver. Let

Re: [PATCH 01/14] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-14 Thread Daniel Vetter
On Fri, Sep 10, 2021 at 10:26:42AM +0200, Christian König wrote: > Abstract the complexity of iterating over all the fences > in a dma_resv object. > > The new loop handles the whole RCU and retry dance and > returns only fences where we can be sure we grabbed the > right one. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files

2021-09-14 Thread Lucas De Marchi
On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote: On Wed, 08 Sep 2021, Lucas De Marchi wrote: We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions, defines and structs follow suit. While at it and si

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Christophe Leroy
Le 14/09/2021 à 13:58, Borislav Petkov a écrit : On Wed, Sep 08, 2021 at 05:58:35PM -0500, Tom Lendacky wrote: Introduce a powerpc version of the cc_platform_has() function. This will be used to replace the powerpc mem_encrypt_active() implementation, so the implementation will initially only

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Borislav Petkov
On Tue, Sep 14, 2021 at 04:47:41PM +0200, Christophe Leroy wrote: > Yes, see > https://lore.kernel.org/linuxppc-dev/20210914123919.58203...@canb.auug.org.au/T/#t Aha, more compiler magic stuff ;-\ Oh well, I guess that fix will land upstream soon. Thx. -- Regards/Gruss, Boris. https://pe

Re: [PATCH] dma-buf: system_heap: Avoid warning on mid-order allocations

2021-09-14 Thread Sumit Semwal
Thanks John! On Tue, 14 Sept 2021 at 19:26, Daniel Vetter wrote: > > On Thu, Sep 09, 2021 at 02:37:41AM +, John Stultz wrote: > > When trying to do mid-order allocations, set __GFP_NOWARN to > > avoid warning messages if the allocation fails, as we will > > still fall back to single page allo

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-14 Thread Oded Gabbay
On Tue, Sep 14, 2021 at 5:18 PM Daniel Vetter wrote: > > On Sun, Sep 12, 2021 at 07:53:07PM +0300, Oded Gabbay wrote: > > Hi, > > Re-sending this patch-set following the release of our user-space TPC > > compiler and runtime library. > > > > I would appreciate a review on this. > > I think the big

Re: [PATCH v2 3/3] drm/vc4: hdmi: Actually check for the connector status in hotplug

2021-09-14 Thread Maxime Ripard
Hi Daniel, On Tue, Sep 14, 2021 at 04:34:08PM +0200, Daniel Vetter wrote: > On Tue, Sep 14, 2021 at 12:17:24PM +0200, Maxime Ripard wrote: > > The drm_helper_hpd_irq_event() documentation states that this function > > is "useful for drivers which can't or don't track hotplug interrupts for > > eac

Re: [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files

2021-09-14 Thread Jani Nikula
On Tue, 14 Sep 2021, Lucas De Marchi wrote: > On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote: >>On Wed, 08 Sep 2021, Lucas De Marchi wrote: >>> We shouldn't be using debugfs_ namespace for this functionality. Rename >>> debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions

Re: [PATCH v2 2/3] drm/probe-helper: Create a HPD IRQ event helper for a single connector

2021-09-14 Thread Maxime Ripard
Hi Sam, On Tue, Sep 14, 2021 at 12:41:55PM +0200, Sam Ravnborg wrote: > On Tue, Sep 14, 2021 at 12:17:23PM +0200, Maxime Ripard wrote: > > The drm_helper_hpd_irq_event() function is iterating over all the > > connectors when an hotplug event is detected. > > > > During that iteration, it will cal

[PATCH] drm/rockchip: handle non-platform devices in rockchip_drm_endpoint_is_subdriver

2021-09-14 Thread Alex Bee
As discussed at [1] rockchip_drm_endpoint_is_subdriver will currently always return -ENODEV for non-platform-devices (e.g. external i2c bridges), what makes them never being considered in rockchip_rgb_init. As suggested at [1] this additionally adds a of_device_is_available for the node found, whi

Re: [PATCH 3/3] drm/i915: Enable -Wsometimes-uninitialized

2021-09-14 Thread Nick Desaulniers
On Tue, Aug 24, 2021 at 3:54 PM Nathan Chancellor wrote: > > This warning helps catch uninitialized variables. It should have been > enabled at the same time as commit b2423184ac33 ("drm/i915: Enable > -Wuninitialized") but I did not realize they were disabled separately. > Enable it now that i915

Re: [PATCH v2 2/3] drm/probe-helper: Create a HPD IRQ event helper for a single connector

2021-09-14 Thread Sam Ravnborg
On Tue, Sep 14, 2021 at 05:06:41PM +0200, Maxime Ripard wrote: > Hi Sam, > > On Tue, Sep 14, 2021 at 12:41:55PM +0200, Sam Ravnborg wrote: > > On Tue, Sep 14, 2021 at 12:17:23PM +0200, Maxime Ripard wrote: > > > The drm_helper_hpd_irq_event() function is iterating over all the > > > connectors whe

Re: [PATCH v2 1/3] drm/probe-helper: Document drm_helper_hpd_irq_event() return value

2021-09-14 Thread Sam Ravnborg
On Tue, Sep 14, 2021 at 12:17:22PM +0200, Maxime Ripard wrote: > The documentation of the drm_helper_hpd_irq_event() function didn't > document the value that function was returning. Add that part as well. > > Signed-off-by: Maxime Ripard Reviewed-by: Sam Ravnborg > > --- > > Changes from v2:

Re: [PATCH v2 3/3] drm/vc4: hdmi: Actually check for the connector status in hotplug

2021-09-14 Thread Sam Ravnborg
Hi Maxime, On Tue, Sep 14, 2021 at 12:17:24PM +0200, Maxime Ripard wrote: > The drm_helper_hpd_irq_event() documentation states that this function > is "useful for drivers which can't or don't track hotplug interrupts for > each connector." and that "Drivers which support hotplug interrupts for >

Re: [PATCH v5 1/3] dt-bindings: Add YAML bindings for NVDEC

2021-09-14 Thread Rob Herring
On Fri, Sep 10, 2021 at 01:42:45PM +0300, Mikko Perttunen wrote: > Add YAML device tree bindings for NVDEC, now in a more appropriate > place compared to the old textual Host1x bindings. > > Signed-off-by: Mikko Perttunen > --- > v5: > * Changed from nvidia,instance to nvidia,host1x-class optiona

Re: [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Thomas Hellström
On 9/14/21 4:07 PM, Daniel Vetter wrote: On Tue, Sep 14, 2021 at 12:38:00PM +0200, Thomas Hellström wrote: On Tue, 2021-09-14 at 10:53 +0200, Christian König wrote: Am 14.09.21 um 10:27 schrieb Thomas Hellström: On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: Am 13.09.21 um 14:41

Re: Re: [PATCH] drm/sun4i: dw-hdmi: Fix HDMI PHY clock setup

2021-09-14 Thread Jernej Škrabec
Hi! Dne torek, 14. september 2021 ob 10:59:22 CEST je Ondřej Jirman napisal(a): > Hello Jernej, > > On Mon, Sep 13, 2021 at 07:21:54PM +0200, Jernej Skrabec wrote: > > Recent rework, which made HDMI PHY driver a platform device, inadvertely > > reversed clock setup order. HW is very touchy about

Re: [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > On Tue, 14 Sept 2021 at 14:55, Matthew Brost wrote: > > > > From: Venkata Sandeep Dhanalakota > > > > Defining vma on stack can cause stack overflow, if > > vma gets populated with new fields. > > Is there some higher level locking s

Re: [PATCH v2 1/9] vfio/ccw: Use functions for alloc/free of the vfio_ccw_private

2021-09-14 Thread Cornelia Huck
On Fri, Sep 10 2021, Christoph Hellwig wrote: > On Thu, Sep 09, 2021 at 04:38:41PM -0300, Jason Gunthorpe wrote: >> + >> +private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); >> +if (!private) >> +return ERR_PTR(-ENOMEM); > > Nit: there is no need to add GFP_KERNEL when

Re: [PATCH] drm/hyperv: Fix double mouse pointers

2021-09-14 Thread Deepak Rawat
Thanks Dexuan, for the patch. A minor comment below. On Mon, Sep 13, 2021 at 11:27 AM Dexuan Cui wrote: > > It looks like Hyper-V supports a hardware cursor feature. It is not used > by Linux VM, but the Hyper-V host still draws a point as an extra mouse > pointer, which is unwanted, especially w

RE: [PATCH] drm/hyperv: Fix double mouse pointers

2021-09-14 Thread Haiyang Zhang
> -Original Message- > From: Deepak Rawat > Sent: Tuesday, September 14, 2021 11:59 AM > To: Dexuan Cui > Cc: Haiyang Zhang ; David Airlie > ; Daniel Vetter ; Thomas Zimmermann > ; dri-devel@lists.freedesktop.org; linux- > hyp...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject:

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-14 Thread Jason Gunthorpe
On Tue, Sep 14, 2021 at 04:18:31PM +0200, Daniel Vetter wrote: > On Sun, Sep 12, 2021 at 07:53:07PM +0300, Oded Gabbay wrote: > > Hi, > > Re-sending this patch-set following the release of our user-space TPC > > compiler and runtime library. > > > > I would appreciate a review on this. > > I thin

Re: [v6 0/4] drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail

2021-09-14 Thread Doug Anderson
Hi, On Mon, Sep 13, 2021 at 8:23 PM yangcong wrote: > > Compared to v5, squash this with patch #3 in the series in > drm/panel: boe-tv101wum-nl6 > > yangcong (4): > drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail > dt-bindings: drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V ra

Re: amdgpu: atomic API and cursor/overlay planes

2021-09-14 Thread Harry Wentland
On 2021-09-07 10:03, Simon Ser wrote: > Hi all, > > Recently I've been discussing with various people [1] [2] about amdgpu's > handling of KMS planes. AMD hardware is a bit special when it comes to > the cursor plane, and it's not always 100% clear how that maps with the > KMS API. > > Up until n

Re: [PATCH 01/14] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-14 Thread Daniel Vetter
On Fri, Sep 10, 2021 at 10:26:42AM +0200, Christian König wrote: > Abstract the complexity of iterating over all the fences > in a dma_resv object. > > The new loop handles the whole RCU and retry dance and > returns only fences where we can be sure we grabbed the > right one. > > Signed-off-by:

Re: [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

2021-09-14 Thread Jani Nikula
On Mon, 13 Sep 2021, Nathan Chancellor wrote: > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") >> disabled -Wsometimes-uninitialized as noisy but there have been a few >> fixes to clang that make the false p

Re: [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM

2021-09-14 Thread Matthew Auld
On Tue, 14 Sept 2021 at 10:03, Christian König wrote: > > Am 14.09.21 um 10:50 schrieb Matthew Auld: > > Add new flag to indicate special shmem based tt, which can directly > > handle swapping itself, and should be visible to some shrinker. > > > > As part of this we should skip the ttm_pages_allo

[PATCH] drm/msm: Do not run snapshot on non-DPU devices

2021-09-14 Thread Fabio Estevam
Since commit 98659487b845 ("drm/msm: add support to take dpu snapshot") the following NULL pointer dereference is seen on i.MX53: [ 3.275493] msm msm: bound 3000.gpu (ops a3xx_ops) [ 3.287174] [drm] Initialized msm 1.8.0 20130625 for msm on minor 0 [ 3.293915] 8<--- cut here --- [ 3.297012] Un

Re: [virtio-dev] [PATCH v1 09/12] drm/virtio: implement context init: allocate an array of fence contexts

2021-09-14 Thread Chia-I Wu
,On Mon, Sep 13, 2021 at 6:57 PM Gurchetan Singh wrote: > > > > > On Mon, Sep 13, 2021 at 11:52 AM Chia-I Wu wrote: >> >> . >> >> On Mon, Sep 13, 2021 at 10:48 AM Gurchetan Singh >> wrote: >> > >> > >> > >> > On Fri, Sep 10, 2021 at 12:33 PM Chia-I Wu wrote: >> >> >> >> On Wed, Sep 8, 2021 at 6

Re: [PATCH v3 03/16] drm/edid: Allow the querying/working with the panel ID from the EDID

2021-09-14 Thread Jani Nikula
On Wed, 08 Sep 2021, Doug Anderson wrote: > Hi, > > On Mon, Sep 6, 2021 at 3:05 AM Jani Nikula > wrote: >> >> > +{ >> > + struct edid *edid; >> > + u32 val; >> > + >> > + edid = drm_do_get_edid_blk0(drm_do_probe_ddc_edid, adapter, NULL, >> > NULL); >> > + >> > + /* >> > + *

Re: [PATCH v2 1/9] vfio/ccw: Use functions for alloc/free of the vfio_ccw_private

2021-09-14 Thread Jason Gunthorpe
On Tue, Sep 14, 2021 at 05:50:25PM +0200, Cornelia Huck wrote: > On Fri, Sep 10 2021, Christoph Hellwig wrote: > > > On Thu, Sep 09, 2021 at 04:38:41PM -0300, Jason Gunthorpe wrote: > >> + > >> + private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); > >> + if (!private) > >> + ret

Re: [PATCH 1/2] drm/i915/xehpsdv: Define MOCS table for XeHP SDV

2021-09-14 Thread Clint Taylor
Appears to match latest BSPEC Reviewed-by: Clint Taylor -Clint On 9/3/21 5:35 PM, Matt Roper wrote: From: Lucas De Marchi Like DG1, XeHP SDV doesn't have LLC/eDRAM control values due to being a dgfx card. XeHP SDV adds 2 more bits: L3_GLBGO to "push the Go point to memory for L3 destined t

Re: [Intel-gfx] [PATCH 08/27] drm/i915: Add logical engine mapping

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 09:34:08AM +0100, Tvrtko Ursulin wrote: > > On 13/09/2021 17:50, Matthew Brost wrote: > > On Mon, Sep 13, 2021 at 10:24:43AM +0100, Tvrtko Ursulin wrote: > > > > > > On 10/09/2021 20:49, Matthew Brost wrote: > > > > On Fri, Sep 10, 2021 at 12:12:42PM +0100, Tvrtko Ursulin

Re: [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix

2021-09-14 Thread Paul Cercueil
Hi Christophe, Le mar., sept. 14 2021 at 11:27:16 +0200, Christophe Branchereau a écrit : The previous parameters caused an unbalanced yellow tint. Signed-off-by: Christophe Branchereau Acked-by: Paul Cercueil Cheers, -Paul --- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 4 ++-- 1

Re: [PATCH v4 04/15] drm/edid: Use new encoded panel id style for quirks matching

2021-09-14 Thread Jani Nikula
On Thu, 09 Sep 2021, Douglas Anderson wrote: > In the patch ("drm/edid: Allow the querying/working with the panel ID > from the EDID") we introduced a different way of working with the > panel ID stored in the EDID. Let's use this new way for the quirks > code. > > Advantages of the new style: > *

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-14 Thread Borislav Petkov
On Wed, Sep 08, 2021 at 05:58:36PM -0500, Tom Lendacky wrote: > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c > index 18fe19916bc3..4b54a2377821 100644 > --- a/arch/x86/mm/mem_encrypt.c > +++ b/arch/x86/mm/mem_encrypt.c > @@ -144,7 +144,7 @@ void __init sme_unmap_bootdata(char

Re: [PATCH v4 04/15] drm/edid: Use new encoded panel id style for quirks matching

2021-09-14 Thread Doug Anderson
Hi, On Tue, Sep 14, 2021 at 11:16 AM Jani Nikula wrote: > > On Thu, 09 Sep 2021, Douglas Anderson wrote: > > In the patch ("drm/edid: Allow the querying/working with the panel ID > > from the EDID") we introduced a different way of working with the > > panel ID stored in the EDID. Let's use this

Re: [PATCH v4 02/15] drm/edid: Break out reading block 0 of the EDID

2021-09-14 Thread Jani Nikula
On Thu, 09 Sep 2021, Douglas Anderson wrote: > A future change wants to be able to read just block 0 of the EDID, so > break it out of drm_do_get_edid() into a sub-function. > > This is intended to be a no-op change--just code movement. > > Signed-off-by: Douglas Anderson > Acked-by: Sam Ravnborg

Re: [PATCH v4 03/15] drm/edid: Allow querying/working with the panel ID from the EDID

2021-09-14 Thread Jani Nikula
On Thu, 09 Sep 2021, Douglas Anderson wrote: > EDIDs have 32-bits worth of data which is intended to be used to > uniquely identify the make/model of a panel. This has historically > been used only internally in the EDID processing code to identify > quirks with panels. > > We'd like to use this p

  1   2   >