Re: [RFC][PATCH] drm/amdgpu/powerplay/smu10: Add custom profile

2021-09-08 Thread Daniel Gomez
On Tue, 7 Sept 2021 at 19:23, Alex Deucher wrote: > > On Tue, Sep 7, 2021 at 4:53 AM Daniel Gomez wrote: > > > > Add custom power profile mode support on smu10. > > Update workload bit list. > > --- > > > > Hi, > > > > I'm trying to add custom profile for the Raven Ridge but not sure if > > I'd n

Re: [PATCH v10 07/17] dt-bindings: display: mediatek: merge: add additional prop for mt8195

2021-09-08 Thread Jason-JH Lin
Hi Philipp, Thanks for the reviews. On Wed, 2021-09-08 at 08:39 +0200, Philipp Zabel wrote: > Hi Jason, > > On Wed, 2021-09-08 at 14:03 +0800, jason-jh.lin wrote: > > add MERGE additional properties description for mt8195: > > 1. async clock > > 2. fifo setting enable > > 3. reset controller > >

Re: Handling DRM master transitions cooperatively

2021-09-08 Thread Pekka Paalanen
On Tue, 7 Sep 2021 14:42:56 +0200 Hans de Goede wrote: > Hi, > > On 9/7/21 12:07 PM, Pekka Paalanen wrote: > > On Fri, 3 Sep 2021 21:08:21 +0200 > > Dennis Filder wrote: > > > >> Hans de Goede asked me to take a topic from a private discussion here. > >> I must also preface that I'm not a gr

Re: Handling DRM master transitions cooperatively

2021-09-08 Thread Hans de Goede
Hi, On 9/8/21 9:36 AM, Pekka Paalanen wrote: > On Tue, 7 Sep 2021 14:42:56 +0200 > Hans de Goede wrote: > >> Hi, >> >> On 9/7/21 12:07 PM, Pekka Paalanen wrote: >>> On Fri, 3 Sep 2021 21:08:21 +0200 >>> Dennis Filder wrote: >>> Hans de Goede asked me to take a topic from a private discu

Re: [PATCH v2 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume

2021-09-08 Thread Thomas Hellström
Hi, Matt, Thanks for reviewing. On 9/7/21 7:37 PM, Matthew Auld wrote: +    i915_gem_ww_unlock_single(backup); +    i915_gem_object_put(backup); I assume we need to set ttm.backup = NULL somewhere here on the failure path, or don't drop the ref? Or at least it looks like potential uaf lat

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-08 Thread Dmitry Baryshkov
Hi, On Tue, 7 Sept 2021 at 22:13, Jeffrey Hugo wrote: > > On Wed, Sep 1, 2021 at 12:11 PM AngeloGioacchino Del Regno > wrote: > > > > Bringup functionality for MSM8998 in the DPU, driver which is mostly > > the same as SDM845 (just a few variations). > > > > Signed-off-by: AngeloGioacchino Del R

Re: [PATCH v10 01/17] dt-bindings: arm: mediatek: mmsys: add power and gce properties

2021-09-08 Thread Enric Balletbo i Serra
Hi Jason, Thank you for your patch. One small comment below. On 8/9/21 8:02, jason-jh.lin wrote: > Power: > 1. Add description for power-domains property. > > GCE: > 1. Add description for mboxes property. > 2. Add description for mediatek,gce-client-reg property. > > Signed-off-by: jason-jh.li

Re: [PATCH v4] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 12:13, Eero Tamminen wrote: Hi, For completeness sake, it might be worth mentioning specifically what (synthetic) test-cases regress with THP patch. * Skylake GT4e:   20-25% SynMark TexMem*   (whereas all MemBW GPU tests either improve or are not affected) * Broxton J4205:

Re: linux-next: build failure after merge of the drm tree

2021-09-08 Thread Daniel Vetter
On Wed, Sep 8, 2021 at 5:14 AM Masahiro Yamada wrote: > > On Mon, Sep 6, 2021 at 4:34 PM Daniel Vetter wrote: > > > > On Mon, Sep 6, 2021 at 12:49 AM Stephen Rothwell > > wrote: > > > Hi all, > > > > > > On Thu, 2 Sep 2021 07:50:38 +1000 Stephen Rothwell > > > wrote: > > > > > > > > On Fri, 2

Re: [Intel-gfx] [PATCH] drm/i915: Get PM ref before accessing HW register

2021-09-08 Thread Tvrtko Ursulin
On 08/09/2021 00:27, Vinay Belgaumkar wrote: Seeing these errors when GT is likely in suspend state- "RPM wakelock ref not held during HW access" Ensure GT is awake before trying to access HW registers. Avoid reading the register if that is not the case. Signed-off-by: Vinay Belgaumkar Fix

Re: [PATCH] doc: gpu: Add document describing buffer exchange

2021-09-08 Thread Pekka Paalanen
On Sun, 5 Sep 2021 13:27:42 +0100 Daniel Stone wrote: > Since there's a lot of confusion around this, document both the rules > and the best practice around negotiating, allocating, importing, and > using buffers when crossing context/process/device/subsystem boundaries. > > This ties up all of

Re: [PATCH] doc: gpu: Add document describing buffer exchange

2021-09-08 Thread Simon Ser
> stride > I think what's clear is: - Per-plane property - In bytes - Offset between two consecutive rows How that applies to weird YUV formats is the tricky question… > Btw. there was a fun argument whether the same modifier value could > mean different things on different devices.

Re: [PATCH 1/8] drm/i915/xehp: Define compute class and engine

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 18:19, Matt Roper wrote: Introduce a Compute Command Streamer (CCS), which has access to the media and GPGPU pipelines (but not the 3D pipeline). To begin with, define the compute class/engine common functions, based on the existing render ones. Bspec: 46167, 45544 Original-patc

Re: Handling DRM master transitions cooperatively

2021-09-08 Thread Simon Ser
> On Tue, 07 Sep 2021 10:19:03 + > Simon Ser wrote: > > > FWIW, I've just hit a case where a compositor leaves a "rotation" KMS > > prop set behind, then Xorg tries to startup and fails because it doesn't > > reset this prop. So none of this is theoretical. > > > > I still think a "reset all K

Re: [PATCH 2/8] drm/i915/xehp: CCS shares the render reset domain

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 18:19, Matt Roper wrote: The reset domain is shared between render and all compute engines, so resetting one will affect the others. Note: Before performing a reset on an RCS or CCS engine, the GuC will attempt to preempt-to-idle the other non-hung RCS/CCS engines to avoid impac

Re: [PATCH 3/8] drm/i915/xehp: Add Compute CS IRQ handlers

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 18:19, Matt Roper wrote: Add execlists and GuC interrupts for compute CS into existing IRQ handlers. All compute command streamers belong to the same compute class, so the only change needed to enable their interrupts is to program their GT engine interrupt mask registers. CCS0

Re: [PATCH v10 01/17] dt-bindings: arm: mediatek: mmsys: add power and gce properties

2021-09-08 Thread Jason-JH Lin
Hi Enric, Thanks for the reviews. On Wed, 2021-09-08 at 10:32 +0200, Enric Balletbo i Serra wrote: > Hi Jason, > > Thank you for your patch. One small comment below. > > On 8/9/21 8:02, jason-jh.lin wrote: > > Power: > > 1. Add description for power-domains property. > > > > GCE: > > 1. Add de

Re: [PATCH 4/8] drm/i915/xehp: CCS should use RCS setup functions

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 18:19, Matt Roper wrote: The compute engine handles the same commands the render engine can (except 3D pipeline), so it makes sense that CCS is more similar to RCS than non-render engines. The CCS context state (lrc) is also similar to the render one, so reuse it. Note that the c

[PATCH v2 (repost)] fbmem: don't allow too huge resolutions

2021-09-08 Thread Tetsuo Handa
syzbot is reporting page fault at vga16fb_fillrect() [1], for vga16fb_check_var() is failing to detect multiplication overflow. if (vxres * vyres > maxmem) { vyres = maxmem / vxres; if (vyres < yres) return -ENOMEM; } Since no module would accept too huge resolutions where multi

Re: [PATCH] kernel/locking: Add context to ww_mutex_trylock.

2021-09-08 Thread Peter Zijlstra
On Tue, Sep 07, 2021 at 03:20:44PM +0200, Maarten Lankhorst wrote: > i915 will soon gain an eviction path that trylock a whole lot of locks > for eviction, getting dmesg failures like below: > > BUG: MAX_LOCK_DEPTH too low! > turning off the locking correctness validator. > depth: 48 max: 48! > 4

Re: [PATCH v2 5/6] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-08 Thread Matthew Auld
On 06/09/2021 17:55, Thomas Hellström wrote: Pinned context images are now reset during resume. Don't back them up, and assuming that rings can be assumed empty at suspend, don't back them up either. Introduce a new object flag, I915_BO_ALLOC_PM_VOLATILE meaning that an object is allowed to lose

Re: [PATCH v2 5/6] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-08 Thread Matthew Auld
On 06/09/2021 17:55, Thomas Hellström wrote: Pinned context images are now reset during resume. Don't back them up, and assuming that rings can be assumed empty at suspend, don't back them up either. Introduce a new object flag, I915_BO_ALLOC_PM_VOLATILE meaning that an object is allowed to lose

Re: [PATCH] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2021-09-08 Thread Dave Stevenson
Hi Marek and Andrzej On Tue, 7 Sept 2021 at 22:24, Marek Vasut wrote: > > On 9/7/21 7:29 PM, Andrzej Hajda wrote: > > > > W dniu 07.09.2021 o 16:25, Marek Vasut pisze: > >> On 9/7/21 9:31 AM, Andrzej Hajda wrote: > >>> On 07.09.2021 04:39, Marek Vasut wrote: > In rare cases, the bridge may n

Re: Handling DRM master transitions cooperatively

2021-09-08 Thread Pekka Paalanen
On Wed, 08 Sep 2021 09:51:54 + Simon Ser wrote: > > On Tue, 07 Sep 2021 10:19:03 + > > Simon Ser wrote: > > > > > FWIW, I've just hit a case where a compositor leaves a "rotation" KMS > > > prop set behind, then Xorg tries to startup and fails because it doesn't > > > reset this prop.

[drm:i915-uncore-vfunc 30/31] drivers/gpu/drm/i915/selftests/mock_uncore.c:47:2: error: implicit declaration of function 'ASSIGN_RAW_WRITE_MMIO_VFUNCS'

2021-09-08 Thread kernel test robot
tree: git://people.freedesktop.org/~airlied/linux.git i915-uncore-vfunc head: b42168f90718a90b11f2d52306d9aeaa9468 commit: 99aebd17891290abfca80c48eca01f4e02413fb3 [30/31] drm/i915/uncore: constify the register vtables. config: i386-randconfig-a014-20210908 (attached as .config) compiler

Re: [PATCH v2 1/3] dt-bindings: msm: dsi: Add MSM8953 dsi phy

2021-09-08 Thread Rob Herring
On Fri, Sep 03, 2021 at 10:38:42PM +0530, Sireesh Kodali wrote: > SoCs based on the MSM8953 platform use the 14nm DSI PHY driver > > Signed-off-by: Sireesh Kodali > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/D

[drm:i915-uncore-vfunc 31/31] make[4]: *** No rule to make target 'drivers/gpu/drm/i915/display/intel_display_trace_points.o', needed by 'drivers/gpu/drm/i915/i915.o'.

2021-09-08 Thread kernel test robot
-randconfig-a006-20210908 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): git remote add drm git://people.freedesktop.org/~airlied/linux.git git fetch --no-tags drm i915-uncore-vfunc git checkout b42168f90718a90b11f2d52306d9aeaa9468

Re: [PATCH v2 5/6] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-08 Thread Thomas Hellström
On Wed, 2021-09-08 at 12:07 +0100, Matthew Auld wrote: > On 06/09/2021 17:55, Thomas Hellström wrote: > > Pinned context images are now reset during resume. Don't back them > > up, > > and assuming that rings can be assumed empty at suspend, don't back > > them > > up either. > > > > Introduce a n

Re: [PATCH v2 5/6] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-08 Thread Matthew Auld
On 08/09/2021 13:26, Thomas Hellström wrote: On Wed, 2021-09-08 at 12:07 +0100, Matthew Auld wrote: On 06/09/2021 17:55, Thomas Hellström wrote: Pinned context images are now reset during resume. Don't back them up, and assuming that rings can be assumed empty at suspend, don't back them up eit

Enabling TTM kerneldoc

2021-09-08 Thread Christian König
Last round for this set I think, already got RBs for most patches. Only patch #2 is currently missing anything. Please point out anything which can be quickly improved and keep in mind that it's better to have this enabled with some typos than not enabled at all. Cheers, Christian.

[PATCH 1/8] drm/ttm: remove the outdated kerneldoc section

2021-09-08 Thread Christian König
Clean up to start over with new and more accurate documentation. Signed-off-by: Christian König Reviewed-by: Matthew Auld --- Documentation/gpu/drm-mm.rst | 49 1 file changed, 49 deletions(-) diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/dr

[PATCH 2/8] drm/ttm: add some general module kerneldoc

2021-09-08 Thread Christian König
For now just a brief description of what TTM is all about. Signed-off-by: Christian König --- Documentation/gpu/drm-mm.rst | 3 ++- drivers/gpu/drm/ttm/ttm_module.c | 12 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/drm-mm.rst b/Documentation

[PATCH 5/8] drm/ttm: enable TTM resource object kerneldoc v2

2021-09-08 Thread Christian König
Fix the last two remaining warnings and finally enable this. v2: add caching enum link Signed-off-by: Christian König Reviewed-by: Matthew Auld Reviewed-by: Alex Deucher --- Documentation/gpu/drm-mm.rst | 9 + include/drm/ttm/ttm_resource.h | 6 ++ 2 files changed, 11 insertions

[PATCH 4/8] drm/ttm: enable TTM device object kerneldoc v2

2021-09-08 Thread Christian König
Fix the remaining warnings, switch to inline structure documentation and finally enable this. v2: adjust based on suggestions from Alex Signed-off-by: Christian König Reviewed-by: Matthew Auld --- Documentation/gpu/drm-mm.rst | 9 + include/drm/ttm/ttm_device.h | 72 +++---

[PATCH 6/8] drm/ttm: enable TTM placement kerneldoc

2021-09-08 Thread Christian König
Fix the last remaining warning and finally enable this. Signed-off-by: Christian König Reviewed-by: Matthew Auld Reviewed-by: Alex Deucher --- Documentation/gpu/drm-mm.rst| 6 ++ include/drm/ttm/ttm_placement.h | 1 + 2 files changed, 7 insertions(+) diff --git a/Documentation/gpu/drm

[PATCH 7/8] drm/ttm: enable TTM TT object kerneldoc v2

2021-09-08 Thread Christian König
Fix the remaining warnings and finally enable this. v2: add caching enum link Signed-off-by: Christian König Reviewed-by: Matthew Auld Reviewed-by: Alex Deucher --- Documentation/gpu/drm-mm.rst | 9 + include/drm/ttm/ttm_tt.h | 11 --- 2 files changed, 17 insertions(+), 3

[PATCH 3/8] drm/ttm: add kerneldoc for enum ttm_caching

2021-09-08 Thread Christian König
Briefly describe what this is all about. Signed-off-by: Christian König Reviewed-by: Alex Deucher --- Documentation/gpu/drm-mm.rst | 3 +++ include/drm/ttm/ttm_caching.h | 17 + 2 files changed, 20 insertions(+) diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/dr

[PATCH 8/8] drm/ttm: enable TTM page pool kerneldoc

2021-09-08 Thread Christian König
Fix the remaining warnings and finally enable this. Signed-off-by: Christian König Reviewed-by: Alex Deucher --- Documentation/gpu/drm-mm.rst | 9 + include/drm/ttm/ttm_pool.h | 5 +++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/drm-mm.rst b/Doc

[drm:i915-vtable-cleanup 12/12] drivers/gpu/drm/i915/display/intel_audio.c:685:13: error: 'ilk_audio_codec_disable' defined but not used

2021-09-08 Thread kernel test robot
tree: git://people.freedesktop.org/~airlied/linux.git i915-vtable-cleanup head: b0d0061aeef594fc572295c0e3c02ba91596cbf6 commit: b0d0061aeef594fc572295c0e3c02ba91596cbf6 [12/12] drm/i915/display: constify the audio functions config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debi

Re: [PATCH 2/8] drm/ttm: add some general module kerneldoc

2021-09-08 Thread Matthew Auld
On Wed, 8 Sept 2021 at 14:29, Christian König wrote: > > For now just a brief description of what TTM is all about. > > Signed-off-by: Christian König Reviewed-by: Matthew Auld

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-08 Thread Caleb Connolly
On 08/09/2021 03:21, Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: [..] I am a bit confused. We don't define a power domai

[drm:i915-uncore-vfunc 31/31] drivers/gpu/drm/i915/i915_irq.c:52:10: fatal error: 'display/i915_display_trace.h' file not found

2021-09-08 Thread kernel test robot
tree: git://people.freedesktop.org/~airlied/linux.git i915-uncore-vfunc head: b42168f90718a90b11f2d52306d9aeaa9468 commit: b42168f90718a90b11f2d52306d9aeaa9468 [31/31] RFC: drm/i915: start splitting trace points config: i386-randconfig-a014-20210908 (attached as .config) compiler

[PATCH] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-08 Thread Chris Morgan
From: Chris Morgan After commit 928f9e268611 ("clk: fractional-divider: Hide clk_fractional_divider_ops from wide audience") was merged it appears that the DSI panel on my Odroid Go Advance stopped working. Upon closer examination of the problem, it looks like it was the fixup in the rockchip_drm

Re: [PATCH 4/8] drm/i915/xehp: CCS should use RCS setup functions

2021-09-08 Thread Tvrtko Ursulin
On 08/09/2021 11:13, Tvrtko Ursulin wrote: On 07/09/2021 18:19, Matt Roper wrote: The compute engine handles the same commands the render engine can (except 3D pipeline), so it makes sense that CCS is more similar to RCS than non-render engines. The CCS context state (lrc) is also similar to

Re: [PATCH 6/8] drm/i915/xehp: Define context scheduling attributes in lrc descriptor

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 18:19, Matt Roper wrote: In Dual Context mode the EUs are shared between render and compute command streamers. The hardware provides a field in the lrc descriptor to indicate the prioritization of the thread dispatch associated to the corresponding context. The context priority i

Re: [PATCH 7/8] drm/i915/xehp: Enable ccs/dual-ctx in RCU_MODE

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 18:19, Matt Roper wrote: We have to specify in the Render Control Unit Mode register when CCS is enabled. Bspec: 46034 Original-patch-by: Michel Thierry Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Vinay Belgaumkar Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Ara

Re: [Intel-gfx] [PATCH 8/8] drm/i915/xehp: Extend uninterruptible OpenCL workloads to CCS

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 18:19, Matt Roper wrote: From: John Harrison Now that OpenCL workloads can run on the compute engine, we need to set preempt_timeout_ms = 0 on the CCS engines too. Signed-off-by: John Harrison Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 9 +

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-08 Thread Jeffrey Hugo
On Wed, Sep 8, 2021 at 2:26 AM Dmitry Baryshkov wrote: > > Hi, > > On Tue, 7 Sept 2021 at 22:13, Jeffrey Hugo wrote: > > > > On Wed, Sep 1, 2021 at 12:11 PM AngeloGioacchino Del Regno > > wrote: > > > > > > Bringup functionality for MSM8998 in the DPU, driver which is mostly > > > the same as SD

Re: [PATCH v5 02/16] drm/sched: Allow using a dedicated workqueue for the timeout/fault tdr

2021-09-08 Thread Andrey Grodzovsky
On 2021-09-08 2:50 a.m., Boris Brezillon wrote: On Tue, 7 Sep 2021 14:53:58 -0400 Andrey Grodzovsky wrote: On 2021-06-29 7:24 a.m., Christian König wrote: Am 29.06.21 um 13:18 schrieb Boris Brezillon: Hi Christian, On Tue, 29 Jun 2021 13:03:58 +0200 Christian König wrote: Am 29.06.2

Re: [PATCH v5 02/16] drm/sched: Allow using a dedicated workqueue for the timeout/fault tdr

2021-09-08 Thread Boris Brezillon
On Wed, 8 Sep 2021 10:53:21 -0400 Andrey Grodzovsky wrote: > > Note that we need to be careful to not call the sync > > variant in helpers that are called from the interrupt handler itself > > to avoid deadlocks (i.e. drm_sched_stop()). > > > I am not clear here - which interrupt handler is d

Re: [PATCH] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2021-09-08 Thread Marek Vasut
On 9/8/21 1:11 PM, Dave Stevenson wrote: Hi Marek and Andrzej Hello Dave, skipping the protocol discussion, which I hope Andrej will pick up. [...] Usually video transmission starts in crtc->enable (CRTC->Encoder), and in encoder->enable (encoder->bridge), so in bridges->enable it would be

Re: [PATCH] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2021-09-08 Thread Dave Stevenson
On Wed, 8 Sept 2021 at 16:26, Marek Vasut wrote: > > On 9/8/21 1:11 PM, Dave Stevenson wrote: > > Hi Marek and Andrzej > > Hello Dave, > > skipping the protocol discussion, which I hope Andrej will pick up. > > [...] > > >>> Usually video transmission starts in crtc->enable (CRTC->Encoder), and >

Re: Handling DRM master transitions cooperatively

2021-09-08 Thread Dennis Filder
On Wed, Sep 08, 2021 at 09:51:54AM +, Simon Ser wrote: > > On Tue, 07 Sep 2021 10:19:03 + > > Simon Ser wrote: > > > > > FWIW, I've just hit a case where a compositor leaves a "rotation" KMS > > > prop set behind, then Xorg tries to startup and fails because it doesn't > > > reset this pro

Re: Handling DRM master transitions cooperatively

2021-09-08 Thread Dennis Filder
On Tue, Sep 07, 2021 at 05:52:41PM +0200, Sebastian Wick wrote: > > On Tue, 07 Sep 2021 10:19:03 + > > Simon Ser wrote: > > > > > FWIW, I've just hit a case where a compositor leaves a "rotation" KMS > > > prop set behind, then Xorg tries to startup and fails because it doesn't > > > reset thi

Re: Handling DRM master transitions cooperatively

2021-09-08 Thread Daniel Vetter
On Wed, Sep 8, 2021 at 9:36 AM Pekka Paalanen wrote: > > On Tue, 7 Sep 2021 14:42:56 +0200 > Hans de Goede wrote: > > > Hi, > > > > On 9/7/21 12:07 PM, Pekka Paalanen wrote: > > > On Fri, 3 Sep 2021 21:08:21 +0200 > > > Dennis Filder wrote: > > > > > >> Hans de Goede asked me to take a topic fro

Re: [Intel-gfx] [PATCH 1/8] drm/i915/xehp: Define compute class and engine

2021-09-08 Thread Daniel Vetter
On Tue, Sep 07, 2021 at 10:19:09AM -0700, Matt Roper wrote: > Introduce a Compute Command Streamer (CCS), which has access to > the media and GPGPU pipelines (but not the 3D pipeline). > > To begin with, define the compute class/engine common functions, based > on the existing render ones. > > Bs

Re: [Intel-gfx] [PATCH 2/8] drm/i915/xehp: CCS shares the render reset domain

2021-09-08 Thread Daniel Vetter
On Tue, Sep 07, 2021 at 10:19:10AM -0700, Matt Roper wrote: > The reset domain is shared between render and all compute engines, > so resetting one will affect the others. > > Note: Before performing a reset on an RCS or CCS engine, the GuC will > attempt to preempt-to-idle the other non-hung RCS

Re: [PATCH] Change igt_log level from IGT_LOG_WARN to IGT_LOG_INFO

2021-09-08 Thread Daniel Vetter
On Wed, Sep 08, 2021 at 12:03:56AM +0530, Jeevan B wrote: > change igt_warn to igt_info when unloading the snd module before > unbinding i915 until WA is fixed. > > Signed-off-by: Jeevan B Please submit per https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/CONTRIBUTING.md#sending-p

Re: [PATCH v2 (repost)] fbmem: don't allow too huge resolutions

2021-09-08 Thread Daniel Vetter
On Wed, Sep 08, 2021 at 07:27:49PM +0900, Tetsuo Handa wrote: > syzbot is reporting page fault at vga16fb_fillrect() [1], for > vga16fb_check_var() is failing to detect multiplication overflow. > > if (vxres * vyres > maxmem) { > vyres = maxmem / vxres; > if (vyres < yres) > return

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-09-08 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 04:01:40PM +0100, Tvrtko Ursulin wrote: > > On 02/09/2021 15:33, Daniel Vetter wrote: > > On Tue, Aug 31, 2021 at 02:18:15PM +0100, Tvrtko Ursulin wrote: > > > > > > On 31/08/2021 13:43, Daniel Vetter wrote: > > > > On Tue, Aug 31, 2021 at 10:15:03AM +0100, Tvrtko Ursulin

Re: [PATCH] drm/ttm: provide default page protection for UML

2021-09-08 Thread Daniel Vetter
On Sat, Sep 04, 2021 at 11:50:37AM +0800, David Gow wrote: > On Thu, Sep 2, 2021 at 10:46 PM Daniel Vetter wrote: > > > > On Thu, Sep 02, 2021 at 07:19:01AM +0100, Anton Ivanov wrote: > > > On 02/09/2021 06:52, Randy Dunlap wrote: > > > > On 9/1/21 10:48 PM, Anton Ivanov wrote: > > > > > On 02/09/

Re: [PATCH][next] drm/i915: clean up inconsistent indenting

2021-09-08 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 10:57:37PM +0100, Colin King wrote: > From: Colin Ian King > > There is a statement that is indented one character too deeply, > clean this up. > > Signed-off-by: Colin Ian King Queued to drm-intel-gt-next, thanks for patch. -Daniel > --- > drivers/gpu/drm/i915/gt/int

Re: [PATCH] drm/sched: Fix drm_sched_fence_free() so it can be passed an uninitialized fence

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 02:05:54PM +0200, Boris Brezillon wrote: > drm_sched_job_cleanup() will pass an uninitialized fence to > drm_sched_fence_free(), which will cause to_drm_sched_fence() to return > a NULL fence object, causing a NULL pointer deref when this NULL object > is passed to kmem_cach

Re: [PATCH] drm/i915/request: fix early tracepoints

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 12:24:05PM +0100, Matthew Auld wrote: > Currently we blow up in trace_dma_fence_init, when calling into > get_driver_name or get_timeline_name, since both the engine and context > might be NULL(or contain some garbage address) in the case of newly > allocated slab objects vi

Re: [PATCH v2 1/2] drm: document drm_mode_create_lease object requirements

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 01:00:16PM +, Simon Ser wrote: > validate_lease expects one CRTC, one connector and one plane. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Pekka Paalanen > Cc: Keith Packard Reviewed-by: Daniel Vetter > --- > include/uapi/drm/drm_mode.h | 3 +++ > 1 f

[PULL] drm-misc-fixes

2021-09-08 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. One patch is a potential deadlock in TTM, the other enables an additional plane in kmb. I'm slightly unhappy that the latter one ended up in -fixes as it's not a bugfix AFAICT. Best regards Thomas drm-misc-fixes-2021-09-08: Short summ

Re: [PATCH v3 4/9] drm/scheduler: Add fence deadline support

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 11:47:55AM -0700, Rob Clark wrote: > From: Rob Clark > > As the finished fence is the one that is exposed to userspace, and > therefore the one that other operations, like atomic update, would > block on, we need to propagate the deadline from from the finished > fence to

Re: [PATCH v3 5/9] drm/msm: Add deadline based boost support

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 11:47:56AM -0700, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark Why do you need a kthread_work here? Is this just to make sure you're running at realtime prio? Maybe a comment to that effect would be good. -Daniel > --- > drivers/gpu/drm/msm/msm_fence

Re: [PATCH v3 8/9] dma-buf/sync_file: Add SET_DEADLINE ioctl

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 11:47:59AM -0700, Rob Clark wrote: > From: Rob Clark > > The initial purpose is for igt tests, but this would also be useful for > compositors that wait until close to vblank deadline to make decisions > about which frame to show. > > Signed-off-by: Rob Clark Needs user

Re: [PATCH 13/14] drm/kmb: Enable alpha blended second plane

2021-09-08 Thread Thomas Zimmermann
Hi Am 03.08.21 um 07:10 schrieb Sam Ravnborg: Hi Anitha, On Mon, Aug 02, 2021 at 08:44:26PM +, Chrisanthus, Anitha wrote: Hi Sam, Thanks. Where should this go, drm-misc-fixes or drm-misc-next? Looks like a drm-misc-next candidate to me. I may improve something for existing users, but it

Re: [PATCH v3 5/9] drm/msm: Add deadline based boost support

2021-09-08 Thread Rob Clark
On Wed, Sep 8, 2021 at 10:48 AM Daniel Vetter wrote: > > On Fri, Sep 03, 2021 at 11:47:56AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Signed-off-by: Rob Clark > > Why do you need a kthread_work here? Is this just to make sure you're > running at realtime prio? Maybe a comment to that e

Re: [PATCH v3 7/9] dma-buf/fence-chain: Add fence deadline support

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 11:47:58AM -0700, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > drivers/dma-buf/dma-fence-chain.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/dma-buf/dma-fence-chain.c > b/drivers/dma-buf/dma-fence-chain.c >

Re: [PATCH v3 1/9] dma-fence: Add deadline awareness

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 11:47:52AM -0700, Rob Clark wrote: > From: Rob Clark > > Add a way to hint to the fence signaler of an upcoming deadline, such as > vblank, which the fence waiter would prefer not to miss. This is to aid > the fence signaler in making power management decisions, like boos

Re: [PATCH v3 6/9] dma-buf/fence-array: Add fence deadline support

2021-09-08 Thread Daniel Vetter
On Fri, Sep 03, 2021 at 11:47:57AM -0700, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > drivers/dma-buf/dma-fence-array.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/dma-buf/dma-fence-array.c > b/drivers/dma-buf/dma-fence-array.c > i

Re: [PATCH] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-08 Thread Andy Shevchenko
On Wed, Sep 08, 2021 at 08:53:56AM -0500, Chris Morgan wrote: > From: Chris Morgan > > After commit 928f9e268611 ("clk: fractional-divider: Hide > clk_fractional_divider_ops from wide audience") was merged it appears > that the DSI panel on my Odroid Go Advance stopped working. Upon closer > exam

Re: [PATCH v2 7/7] drm/gud: Add module parameter to control emulation: xrgb8888

2021-09-08 Thread Thomas Zimmermann
Hi Am 07.09.21 um 13:57 schrieb Noralf Trønnes: For devices that don't support XRGB give the user the ability to choose what's most important: Color depth or frames per second. Add an 'xrgb' module parameter to override the emulation format. Assume the user wants full control if xrgb88

Re: [PATCH v3 7/9] dma-buf/fence-chain: Add fence deadline support

2021-09-08 Thread Rob Clark
On Wed, Sep 8, 2021 at 10:54 AM Daniel Vetter wrote: > > On Fri, Sep 03, 2021 at 11:47:58AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Signed-off-by: Rob Clark > > --- > > drivers/dma-buf/dma-fence-chain.c | 13 + > > 1 file changed, 13 insertions(+) > > > > diff --git a/dr

Re: [PATCH] doc: gpu: Add document describing buffer exchange

2021-09-08 Thread Daniel Vetter
On Sun, Sep 05, 2021 at 01:27:42PM +0100, Daniel Stone wrote: > Since there's a lot of confusion around this, document both the rules > and the best practice around negotiating, allocating, importing, and > using buffers when crossing context/process/device/subsystem boundaries. > > This ties up a

[PATCH 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-08 Thread Philip Chen
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs, which will simplify the future update on ps8640 driver. Signed-off-by: Philip Chen --- drivers/gpu/drm/bridge/parade-ps8640.c | 66 +++--- 1 file changed, 39 insertions(+), 27 deletions(-) diff --git a/

[PATCH 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-08 Thread Philip Chen
Implement the first version of AUX support, which will be useful as we expand the driver to support varied use cases. Signed-off-by: Philip Chen --- drivers/gpu/drm/bridge/parade-ps8640.c | 123 + 1 file changed, 123 insertions(+) diff --git a/drivers/gpu/drm/bridge/par

Re: [PATCH v3 8/9] dma-buf/sync_file: Add SET_DEADLINE ioctl

2021-09-08 Thread Rob Clark
On Wed, Sep 8, 2021 at 10:50 AM Daniel Vetter wrote: > > On Fri, Sep 03, 2021 at 11:47:59AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > The initial purpose is for igt tests, but this would also be useful for > > compositors that wait until close to vblank deadline to make decisions > > ab

Re: [PATCH 1/2] drm/nouveau/ga102-: support ttm buffer moves via copy engine

2021-09-08 Thread Daniel Vetter
On Mon, Sep 06, 2021 at 10:56:27AM +1000, Ben Skeggs wrote: > From: Ben Skeggs > > We don't currently have any kind of real acceleration on Ampere GPUs, > but the TTM memcpy() fallback paths aren't really designed to handle > copies between different devices, such as on Optimus systems, and > res

Re: [PATCH] drm: mxsfb: Fix NULL pointer dereference crash on unload

2021-09-08 Thread Daniel Vetter
On Tue, Sep 07, 2021 at 04:49:00AM +0200, Marek Vasut wrote: > The mxsfb->crtc.funcs may already be NULL when unloading the driver, > in which case calling mxsfb_irq_disable() via drm_irq_uninstall() from > mxsfb_unload() leads to NULL pointer dereference. > > Since all we care about is masking th

Re: [resend PATCH] drm/ttm: Fix a deadlock if the target BO is not idle during swap

2021-09-08 Thread Daniel Vetter
On Tue, Sep 07, 2021 at 11:28:23AM +0200, Christian König wrote: > Am 07.09.21 um 11:05 schrieb Daniel Vetter: > > On Tue, Sep 07, 2021 at 08:22:20AM +0200, Christian König wrote: > > > Added a Fixes tag and pushed this to drm-misc-fixes. > > We're in the merge window, this should have been drm-mis

Re: [PATCH] kernel/locking: Add context to ww_mutex_trylock.

2021-09-08 Thread Daniel Vetter
On Wed, Sep 08, 2021 at 12:14:23PM +0200, Peter Zijlstra wrote: > On Tue, Sep 07, 2021 at 03:20:44PM +0200, Maarten Lankhorst wrote: > > i915 will soon gain an eviction path that trylock a whole lot of locks > > for eviction, getting dmesg failures like below: > > > > BUG: MAX_LOCK_DEPTH too low!

Re: [PATCH] drm/plane-helper: fix uninitialized variable reference

2021-09-08 Thread Daniel Vetter
On Tue, Sep 07, 2021 at 10:08:36AM -0400, Alex Xu (Hello71) wrote: > drivers/gpu/drm/drm_plane_helper.c: In function 'drm_primary_helper_update': > drivers/gpu/drm/drm_plane_helper.c:113:32: error: 'visible' is used > uninitialized [-Werror=uninitialized] > 113 | struct drm_plane_state p

Re: [PATCH v3 7/9] dma-buf/fence-chain: Add fence deadline support

2021-09-08 Thread Daniel Vetter
On Wed, Sep 08, 2021 at 11:19:15AM -0700, Rob Clark wrote: > On Wed, Sep 8, 2021 at 10:54 AM Daniel Vetter wrote: > > > > On Fri, Sep 03, 2021 at 11:47:58AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Signed-off-by: Rob Clark > > > --- > > > drivers/dma-buf/dma-fence-chain.c | 13

Re: [PATCH v3 8/9] dma-buf/sync_file: Add SET_DEADLINE ioctl

2021-09-08 Thread Daniel Vetter
On Wed, Sep 08, 2021 at 11:23:42AM -0700, Rob Clark wrote: > On Wed, Sep 8, 2021 at 10:50 AM Daniel Vetter wrote: > > > > On Fri, Sep 03, 2021 at 11:47:59AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > The initial purpose is for igt tests, but this would also be useful for > > > comp

[PATCH 0/2] drm/i915/gt: Locking splats PREEMPT_RT

2021-09-08 Thread Sebastian Andrzej Siewior
Clark Williams reported two issues with the i915 driver running on PREEMPT_RT. While #1 looks simple I have no idea about #2 thus the RFC. Sebastian

[RFC PATCH 2/2] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()

2021-09-08 Thread Sebastian Andrzej Siewior
execlists_dequeue() is invoked from a function which uses local_irq_disable() to disable interrupts so the spin_lock() behaves like spin_lock_irq(). This breaks PREEMPT_RT because local_irq_disable() + spin_lock() is not the same as spin_lock_irq(). execlists_dequeue_irq() and execlists_dequeue()

[PATCH 1/2] drm/i915/gt: Queue and wait for the irq_work item.

2021-09-08 Thread Sebastian Andrzej Siewior
Disabling interrupts and invoking the irq_work function directly breaks on PREEMPT_RT. PREEMPT_RT does not invoke all irq_work from hardirq context because some of the user have spinlock_t locking in the callback function. These locks are then turned into a sleeping locks which can not be acquired

[PATCH] drm/nouveau/nvkm: Replace -ENOSYS with -ENODEV

2021-09-08 Thread Guenter Roeck
nvkm test builds fail with the following error. drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c: In function 'nvkm_control_mthd_pstate_info': drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c:60:35: error: overflow in conversion from 'int' to '__s8' {aka 'signed char'}

Re: [PATCH 13/14] drm/kmb: Enable alpha blended second plane

2021-09-08 Thread Sam Ravnborg
Hi Thomas, On Wed, Sep 08, 2021 at 07:50:42PM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.08.21 um 07:10 schrieb Sam Ravnborg: > > Hi Anitha, > > > > On Mon, Aug 02, 2021 at 08:44:26PM +, Chrisanthus, Anitha wrote: > > > Hi Sam, > > > Thanks. Where should this go, drm-misc-fixes or drm-mi

[drm:i915-uncore-vfunc 30/31] drivers/gpu/drm/i915/selftests/mock_uncore.c:47:2: error: implicit declaration of function 'ASSIGN_RAW_WRITE_MMIO_VFUNCS'; did you mean 'MMIO_RAW_WRITE_VFUNCS'?

2021-09-08 Thread kernel test robot
tree: git://people.freedesktop.org/~airlied/linux.git i915-uncore-vfunc head: b42168f90718a90b11f2d52306d9aeaa9468 commit: 99aebd17891290abfca80c48eca01f4e02413fb3 [30/31] drm/i915/uncore: constify the register vtables. config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debia

Re: [PATCH v3 8/9] dma-buf/sync_file: Add SET_DEADLINE ioctl

2021-09-08 Thread Rob Clark
On Wed, Sep 8, 2021 at 11:49 AM Daniel Vetter wrote: > > On Wed, Sep 08, 2021 at 11:23:42AM -0700, Rob Clark wrote: > > On Wed, Sep 8, 2021 at 10:50 AM Daniel Vetter wrote: > > > > > > On Fri, Sep 03, 2021 at 11:47:59AM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > The initial

Re: [PATCH 2/8] drm/i915/xehp: CCS shares the render reset domain

2021-09-08 Thread Matt Roper
On Wed, Sep 08, 2021 at 11:07:07AM +0100, Tvrtko Ursulin wrote: > > On 07/09/2021 18:19, Matt Roper wrote: > > The reset domain is shared between render and all compute engines, > > so resetting one will affect the others. > > > > Note: Before performing a reset on an RCS or CCS engine, the GuC

Re: [PATCH v3 8/9] dma-buf/sync_file: Add SET_DEADLINE ioctl

2021-09-08 Thread Daniel Vetter
On Wed, Sep 8, 2021 at 9:36 PM Rob Clark wrote: > On Wed, Sep 8, 2021 at 11:49 AM Daniel Vetter wrote: > > On Wed, Sep 08, 2021 at 11:23:42AM -0700, Rob Clark wrote: > > > On Wed, Sep 8, 2021 at 10:50 AM Daniel Vetter wrote: > > > > > > > > On Fri, Sep 03, 2021 at 11:47:59AM -0700, Rob Clark wro

Re: [PATCH v3 10/16] drm/panel-simple: Non-eDP panels don't need "HPD" handling

2021-09-08 Thread Doug Anderson
Hi, On Sun, Sep 5, 2021 at 11:46 AM Sam Ravnborg wrote: > > On Wed, Sep 01, 2021 at 01:19:28PM -0700, Douglas Anderson wrote: > > All of the "HPD" handling added to panel-simple recently was for eDP > > panels. Remove it from panel-simple now that panel-simple-edp handles > > eDP panels. The "pre

Re: [PATCH] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2021-09-08 Thread Andrzej Hajda
W dniu 08.09.2021 o 13:11, Dave Stevenson pisze: > Hi Marek and Andrzej > > On Tue, 7 Sept 2021 at 22:24, Marek Vasut wrote: >> On 9/7/21 7:29 PM, Andrzej Hajda wrote: >>> W dniu 07.09.2021 o 16:25, Marek Vasut pisze: On 9/7/21 9:31 AM, Andrzej Hajda wrote: > On 07.09.2021 04:39, Marek

Re: [PATCH] drm: mxsfb: Fix NULL pointer dereference crash on unload

2021-09-08 Thread Marek Vasut
x27;m confused because I'm not even seeing this function anywhere in upstream. It is still here: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mxsfb/mxsfb_drv.c#n171 as of: 999569d59a0aa ("Add linux-next specific files for 20210908") Is there some other tree I should be looking at ?

  1   2   >