Re: [PATCH] drm/r128: fix build for UML

2021-09-02 Thread Johannes Berg
On Wed, 2021-09-01 at 19:17 -0700, Randy Dunlap wrote: > Fix a build error on CONFIG_UML, which does not support (provide) > wbinvd(). UML can use the generic mb() instead. > > ../drivers/gpu/drm/r128/ati_pcigart.c: In function ‘drm_ati_pcigart_init’: > ../drivers/gpu/drm/r128/ati_pcigart.c:218:2:

Re: [PATCH] drm/ttm: provide default page protection for UML

2021-09-02 Thread Anton Ivanov
On 02/09/2021 06:52, Randy Dunlap wrote: On 9/1/21 10:48 PM, Anton Ivanov wrote: On 02/09/2021 03:01, Randy Dunlap wrote: boot_cpu_data [struct cpuinfo_um (on UML)] does not have a struct member named 'x86', so provide a default page protection mode for CONFIG_UML. Mends this build error: ../d

Re: [PATCH] drm/ttm: provide default page protection for UML

2021-09-02 Thread Anton Ivanov
On 02/09/2021 03:01, Randy Dunlap wrote: boot_cpu_data [struct cpuinfo_um (on UML)] does not have a struct member named 'x86', so provide a default page protection mode for CONFIG_UML. Mends this build error: ../drivers/gpu/drm/ttm/ttm_module.c: In function ‘ttm_prot_from_caching’: ../drivers/gp

Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-09-02 Thread AngeloGioacchino Del Regno
Il 30/08/21 20:24, Marijn Suijten ha scritto: All DSI PHY/PLL drivers were referencing their VCO parent clock by a global name, most of which don't exist or have been renamed. These clock drivers seem to function fine without that except the 14nm driver for the sdm6xx [1]. At the same time all

Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-02 Thread AngeloGioacchino Del Regno
Il 30/08/21 20:24, Marijn Suijten ha scritto: The DSI PHY/PLL was relying on a global "xo" clock to be found, but the real clock is named "xo_board" in the DT. The standard nowadays is to never use global clock names anymore but require the firmware (DT) to provide every clock binding explicitly

Re: [PATCH] drm/ttm: provide default page protection for UML

2021-09-02 Thread Johannes Berg
On Thu, 2021-09-02 at 07:19 +0100, Anton Ivanov wrote: > > > > > > I have a question though - why all of DRM is not !UML in config. Not > > > like we can use them. > > > > I have no idea about that. > > Hopefully one of the (other) UML maintainers can answer you. > > Touche. > > We will discus

[Bug 212655] AMDGPU crashes when resuming from suspend when amd_iommu=on

2021-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212655 coxackie (kostas.karda...@gmail.com) changed: What|Removed |Added CC||kostas.karda...@gma

Re: [PATCH] drm/ttm: provide default page protection for UML

2021-09-02 Thread Johannes Berg
On Thu, 2021-09-02 at 09:10 +0100, Anton Ivanov wrote: > On 02/09/2021 08:43, Johannes Berg wrote: > > On Thu, 2021-09-02 at 07:19 +0100, Anton Ivanov wrote: > > > > > > > > > > I have a question though - why all of DRM is not !UML in config. Not > > > > > like we can use them. > > > > > > > > I

Re: [PATCH] drm/ttm: provide default page protection for UML

2021-09-02 Thread Christian König
Am 02.09.21 um 09:43 schrieb Johannes Berg: On Thu, 2021-09-02 at 07:19 +0100, Anton Ivanov wrote: I have a question though - why all of DRM is not !UML in config. Not like we can use them. I have no idea about that. Hopefully one of the (other) UML maintainers can answer you. Touche. We will

Regression with mainline kernel on rpi4

2021-09-02 Thread Sudip Mukherjee
Hi All, Our last night's test on rpi4 had a nasty trace. The test was with 7c636d4d20f8 ("Merge tag 'dt-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc"). Previous test was on 9e9fb7655ed5 ("Merge tag 'net-next-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next")

Re: [PATCH] drm/panfrost: Make use of the helper function devm_platform_ioremap_resource()

2021-09-02 Thread Steven Price
On 31/08/2021 08:53, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Reviewed-by: Steven Price I'll push this to drm-misc-next. Thanks, Steve > --- > dr

[PATCH] drm/lease: allow empty leases

2021-09-02 Thread Simon Ser
This can be used to create a separate DRM file description, thus creating a new GEM handle namespace. See [1]. Example usage in wlroots is available at [2]. [1]: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/110 [2]: https://github.com/swaywm/wlroots/pull/3158 Signed-off-by: Simon Ser

Re: [PATCH 2/5] drm/meson: Use common drm_fixed_16_16 helper

2021-09-02 Thread Neil Armstrong
On 01/09/2021 19:54, Alyssa Rosenzweig wrote: > Replace our open-coded FRAC_16_16 with the common drm_fixed_16_16 > helper to reduce code duplication between drivers. > > Signed-off-by: Alyssa Rosenzweig > Cc: linux-amlo...@lists.infradead.org > --- > drivers/gpu/drm/meson/meson_overlay.c | 7 ++

Re: [PATCH] drm/ttm: provide default page protection for UML

2021-09-02 Thread Anton Ivanov
On 02/09/2021 08:43, Johannes Berg wrote: On Thu, 2021-09-02 at 07:19 +0100, Anton Ivanov wrote: I have a question though - why all of DRM is not !UML in config. Not like we can use them. I have no idea about that. Hopefully one of the (other) UML maintainers can answer you. Touche. We wil

Re: [PATCH] drm/i915: Release i915_gem_context from a worker

2021-09-02 Thread Maarten Lankhorst
Op 31-08-2021 om 17:14 schreef Daniel Vetter: > On Tue, Aug 31, 2021 at 02:16:56PM +0200, Daniel Vetter wrote: >> On Tue, Aug 31, 2021 at 11:38:27AM +0200, Maarten Lankhorst wrote: >>> Op 14-08-2021 om 12:43 schreef Daniel Vetter: The only reason for this really is the i915_gem_engines->fence

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

2021-09-02 Thread Christian König
Hi Monk, Am 02.09.21 um 07:52 schrieb Liu, Monk: [AMD Official Use Only] I'm not sure I can add much to help this along, I'm sure Alex has some internal training, Once your driver is upstream, it belongs to upstream, you can maintain it, but you no longer control it 100%, it's a tradeoff, it'

Re: [PATCH] dma-buf: cleanup kerneldoc of removed component

2021-09-02 Thread Christian König
Am 01.09.21 um 16:53 schrieb Sumit Semwal: Hi Christian, On Wed, 1 Sept 2021 at 13:30, Christian König wrote: The seqno-fence was removed, cleanup the kerneldoc include as well. Signed-off-by: Christian König Fixes: 992c238188a8 ("dma-buf: nuke seqno-fence") Thanks for fixing; LGTM, please

[PATCH 0/6] drm/i915: Suspend / resume backup- and restore of LMEM.

2021-09-02 Thread Thomas Hellström
Implement backup and restore of LMEM during suspend / resume. What complicates things a bit is handling of pinned LMEM memory during suspend and the fact that we might be dealing with unmappable LMEM in the future, which makes us want to restrict the number of pinned objects that need memcpy resume

[PATCH 1/6] drm/i915/ttm: Implement a function to copy the contents of two TTM-base objects

2021-09-02 Thread Thomas Hellström
When backing up or restoring contents of pinned objects at suspend / resume time we need to allocate a new object as the backup. Add a function to facilitate copies between the two. Some data needs to be copied before the migration context is ready for operation, so make sure we can disable acceler

[PATCH 2/6] drm/i915/gem: Implement a function to process all gem objects of a region

2021-09-02 Thread Thomas Hellström
An upcoming common pattern is to traverse the region object list and perform certain actions on all objects in a region. It's a little tricky to get the list locking right, in particular since a gem object may change region unless it's pinned or the object lock is held. Define a function that does

[PATCH 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume

2021-09-02 Thread Thomas Hellström
Just evict unpinned objects to system. For pinned LMEM objects, make a backup system object and blit the contents to that. For now, for pinned objects, backup using gpu blits and restore using memcpy except for occasional user-space objects which are restored using gpu blits once the migration con

[PATCH 4/6] drm/i915/gt: Register the migrate contexts with their engines

2021-09-02 Thread Thomas Hellström
Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts. Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the pin

[PATCH 5/6] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-02 Thread Thomas Hellström
Pinned context images are now reset during resume. Don't back them up, and assuming that rings can be assumed empty at suspend, don't back them up either. Introduce a new object flag, I915_BO_ALLOC_PM_VOLATILE meaning that an object is allowed to lose its content on suspend. Signed-off-by: Thomas

[PATCH 6/6] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-02 Thread Thomas Hellström
We really only need memcpy restore for objects that affect the operability of the migrate context. That is, primarily the page-table objects of the migrate VM. Add an object flag, I915_BO_ALLOC_PM_EARLY for objects that need early restores using memcpy and a way to assign LMEM page-table object fl

Re: VKMS: New plane formats

2021-09-02 Thread Igor Matheus Andrade Torrente
On 9/1/21 5:24 PM, Simon Ser wrote: Ideally the final composition format would have enough precision for all of the planes. I think it'd make sense to use ARGB16161616 if the primary plane uses ARGB and an overlay plane uses ARGB16161616. To simplify the code, maybe it's fine to always use A

Re: [PATCH v6, 13/15] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

2021-09-02 Thread Rob Herring
On Wed, 01 Sep 2021 16:32:13 +0800, Yunfei Dong wrote: > Adds decoder dt-bindings for mt8192. > > Signed-off-by: Yunfei Dong > --- > v6: add decoder block diagram for Laurent's comments. > > This patch depends on "Mediatek MT8192 clock support"[1]. > > The definition of decoder clocks are in mt

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Release i915_gem_context from a worker

2021-09-02 Thread Tvrtko Ursulin
On 13/08/2021 21:30, Daniel Vetter wrote: The only reason for this really is the i915_gem_engines->fence callback engines_notify(), which exists purely as a fairly funky reference counting scheme for that. Otherwise all other callers are from process context, and generally fairly benign locking

Re: [PATCH 1/5] drm/ttm: cleanup ttm_resource_compat

2021-09-02 Thread Huang Rui
On Tue, Aug 31, 2021 at 07:21:06PM +0800, Christian König wrote: > Move that function into the resource handling and remove an unused parameter. > > Signed-off-by: Christian König Looks this patch is separate from others in this series. new_flags won't be used anymore. Reviewed-by: Huang Rui

[PATCH 3/3] dma-buf: DMABUF_SYSFS_STATS should depend on DMA_SHARED_BUFFER

2021-09-02 Thread Geert Uytterhoeven
DMA-BUF sysfs statistics are an option of DMA-BUF. It does not make much sense to bother the user with a question about DMA-BUF sysfs statistics if DMA-BUF itself is not enabled. Worse, enabling the statistics enables the feature. Fixes: bdb8d06dfefd666d ("dmabuf: Add the capability to expose DM

[PATCH 1/3] dma-buf: DMABUF_MOVE_NOTIFY should depend on DMA_SHARED_BUFFER

2021-09-02 Thread Geert Uytterhoeven
Move notify between drivers is an option of DMA-BUF. Enabling DMABUF_MOVE_NOTIFY without DMA_SHARED_BUFFER does not have any impact, as drivers/dma-buf/ is not entered during the build when DMA_SHARED_BUFFER is disabled. Fixes: bb42df4662a44765 ("dma-buf: add dynamic DMA-buf handling v15") Signed

[PATCH 2/3] dma-buf: DMABUF_DEBUG should depend on DMA_SHARED_BUFFER

2021-09-02 Thread Geert Uytterhoeven
DMA-BUF debug checks are an option of DMA-BUF. Enabling DMABUF_DEBUG without DMA_SHARED_BUFFER does not have any impact, as drivers/dma-buf/ is not entered during the build when DMA_SHARED_BUFFER is disabled. Fixes: 84335675f2223cbd ("dma-buf: Add debug option") Signed-off-by: Geert Uytterhoeven

[PATCH 0/3] dma-buf: Add missing dependencies on DMA_SHARED_BUFFER

2021-09-02 Thread Geert Uytterhoeven
Hi Sumit, Christian, This patch series adds missing dependencies on DMA_SHARED_BUFFER to various options of DMA-BUF, and drops a bogus select. As drivers/dma-buf/Kconfig contains interleaved options that select or depend on DMA_SHARED_BUFFER, they can't be wrapped inside a big "if DMA_SHA

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #42 from James Zhu (jam...@amd.com) --- Hi Jerome and kolAflash, Thanks for confirmation. I have a workaround for this issue. But I wish I can find the root cause or better workaround. James -- You may reply to this email to add a

Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-02 Thread Marijn Suijten
On 2021-09-01 20:46:34, Stephen Boyd wrote: > Quoting Marijn Suijten (2021-09-01 01:57:15) > > On 2021-08-31 22:35:56, Stephen Boyd wrote: > > > Quoting Marijn Suijten (2021-08-30 11:24:45) > > > > The DSI PHY/PLL was relying on a global "xo" clock to be found, but the > > > > real clock is named "

Re: [PATCH 4.19] fbmem: add margin check to fb_check_caps()

2021-09-02 Thread Geert Uytterhoeven
Hi Dongliang, On Thu, Sep 2, 2021 at 8:04 AM Dongliang Mu wrote: > [ Upstream commit a49145acfb975d921464b84fe00279f99827d816 ] Oops, looks like I missed when that one was submitted for review... > A fb_ioctl() FBIOPUT_VSCREENINFO call with invalid xres setting > or yres setting in struct fb_va

Re: [PATCH 2/5] drm/ttm: add busy and idle placement flags

2021-09-02 Thread Huang Rui
On Tue, Aug 31, 2021 at 07:21:07PM +0800, Christian König wrote: > More flexible than the busy placements. > > Signed-off-by: Christian König Patch 2 -> 5 are Acked-by: Huang Rui > --- > drivers/gpu/drm/ttm/ttm_bo.c| 8 +++- > include/drm/ttm/ttm_placement.h | 6 ++ > 2 files chan

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

2021-09-02 Thread Alex Deucher
On Thu, Sep 2, 2021 at 1:52 AM Liu, Monk wrote: > > [AMD Official Use Only] > > >>> > I'm not sure I can add much to help this along, I'm sure Alex has some > internal training, > Once your driver is upstream, it belongs to upstream, you can maintain it, > but you no longer control it 100%, it's

[PATCH] drm/panfrost: Calculate lock region size correctly

2021-09-02 Thread Steven Price
It turns out that when locking a region, the region must be a naturally aligned power of 2. The upshot of this is that if the desired region crosses a 'large boundary' the region size must be increased significantly to ensure that the locked region completely covers the desired region. Previous cal

Re: [PATCH 2/7] drm/format-helper: Add drm_fb_xrgb8888_to_rgb332()

2021-09-02 Thread Noralf Trønnes
Den 31.08.2021 14.23, skrev Daniel Vetter: > On Mon, Aug 30, 2021 at 02:08:14PM +0200, Noralf Trønnes wrote: >> >> >> Den 17.08.2021 15.56, skrev Daniel Vetter: >>> On Tue, Aug 17, 2021 at 02:29:12PM +0200, Noralf Trønnes wrote: Add XRGB emulation support for devices that can only do RG

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #43 from kolAflash (kolafl...@kolahilft.de) --- (In reply to James Zhu from comment #42) > Hi Jerome and kolAflash, > > Thanks for confirmation. I have a workaround for this issue. But I wish I > can find the root cause or better work

[PATCH 01/11] drm/i915: Release i915_gem_context from a worker

2021-09-02 Thread Daniel Vetter
The only reason for this really is the i915_gem_engines->fence callback engines_notify(), which exists purely as a fairly funky reference counting scheme for that. Otherwise all other callers are from process context, and generally fairly benign locking context. Unfortunately untangling that requi

[PATCH 02/11] drm/i915: Release ctx->syncobj on final put, not on ctx close

2021-09-02 Thread Daniel Vetter
gem context refcounting is another exercise in least locking design it seems, where most things get destroyed upon context closure (which can race with anything really). Only the actual memory allocation and the locks survive while holding a reference. This tripped up Jason when reimplementing the

[PATCH 03/11] drm/i915: Keep gem ctx->vm alive until the final put

2021-09-02 Thread Daniel Vetter
The comment added in commit b81dde719439c8f09bb61e742ed95bfc4b33946b Author: Chris Wilson Date: Tue May 21 22:11:29 2019 +0100 drm/i915: Allow userspace to clone contexts on creation and moved in commit 27dbae8f36c1c25008b7885fc07c57054b7dfba3 Author: Chris Wilson

[PATCH 05/11] drm/i915: Rename i915_gem_context_get_vm_rcu to i915_gem_context_get_eb_vm

2021-09-02 Thread Daniel Vetter
The important part isn't so much that this does an rcu lookup - that's more an implementation detail, which will also be removed. The thing that makes this different from other functions is that it's gettting you the vm that batchbuffers will run in for that gem context, which is either a full ppg

[PATCH 04/11] drm/i915: Drop code to handle set-vm races from execbuf

2021-09-02 Thread Daniel Vetter
Changing the vm from a finalized gem ctx is no longer possible, which means we don't have to check for that anymore. I was pondering whether to keep the check as a WARN_ON, but things go boom real bad real fast if the vm of a vma is wrong. Plus we'd need to also get the ggtt vm for !full-ppgtt pla

[PATCH 07/11] drm/i915: Add i915_gem_context_is_full_ppgtt

2021-09-02 Thread Daniel Vetter
And use it anywhere we have open-coded checks for ctx->vm that really only check for full ppgtt. Plus for paranoia add a GEM_BUG_ON that checks it's really only set when we have full ppgtt, just in case. gem_context->vm is different since it's NULL in ggtt mode, unlike intel_context->vm or gt->vm,

[PATCH 08/11] drm/i915: Use i915_gem_context_get_eb_vm in intel_context_set_gem

2021-09-02 Thread Daniel Vetter
Since commit ccbc1b97948ab671335e950271e39766729736c3 Author: Jason Ekstrand Date: Thu Jul 8 10:48:30 2021 -0500 drm/i915/gem: Don't allow changing the VM on running contexts (v4) the gem_ctx->vm can't change anymore. Plus we always set the intel_context->vm, so might as well use the help

[PATCH 06/11] drm/i915: Use i915_gem_context_get_eb_vm in ctx_getparam

2021-09-02 Thread Daniel Vetter
Consolidates the "which is the vm my execbuf runs in" code a bit. We do some get/put which isn't really required, but all the other users want the refcounting, and I figured doing a function just for this getparam to avoid 2 atomis is a bit much. Reviewed-by: Maarten Lankhorst Signed-off-by: Dani

[PATCH 09/11] drm/i915: Drop __rcu from gem_context->vm

2021-09-02 Thread Daniel Vetter
It's been invariant since commit ccbc1b97948ab671335e950271e39766729736c3 Author: Jason Ekstrand Date: Thu Jul 8 10:48:30 2021 -0500 drm/i915/gem: Don't allow changing the VM on running contexts (v4) this just completes the deed. I've tried to split out prep work for more

[PATCH 11/11] drm/i915: Stop rcu support for i915_address_space

2021-09-02 Thread Daniel Vetter
The full audit is quite a bit of work: - i915_dpt has very simple lifetime (somehow we create a display pagetable vm per object, so its _very_ simple, there's only ever a single vma in there), and uses i915_vm_close(), which internally does a i915_vm_put(). No rcu. Aside: wtf is i915_dpt do

[PATCH 10/11] drm/i915: use xa_lock/unlock for fpriv->vm_xa lookups

2021-09-02 Thread Daniel Vetter
We don't need the absolute speed of rcu for this. And i915_address_space in general dont need rcu protection anywhere else, after we've made gem contexts and engines a lot more immutable. Note that this semantically reverts commit aabbe344dc3ca5f7d8263a02608ba6179e8a4499 Author: Chris Wilson Dat

Re: [PATCH 2/7] drm/format-helper: Add drm_fb_xrgb8888_to_rgb332()

2021-09-02 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 04:08:14PM +0200, Noralf Trønnes wrote: > > > Den 31.08.2021 14.23, skrev Daniel Vetter: > > On Mon, Aug 30, 2021 at 02:08:14PM +0200, Noralf Trønnes wrote: > >> > >> > >> Den 17.08.2021 15.56, skrev Daniel Vetter: > >>> On Tue, Aug 17, 2021 at 02:29:12PM +0200, Noralf Trø

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-02 Thread Daniel Vetter
On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: > > On 2021-08-31 9:11 a.m., Daniel Vetter wrote: > > On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: > > > On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-19 5:30 a.m., Daniel V

Re: [PATCH] drm/lease: allow empty leases

2021-09-02 Thread Pekka Paalanen
On Thu, 02 Sep 2021 09:11:40 + Simon Ser wrote: > This can be used to create a separate DRM file description, thus > creating a new GEM handle namespace. See [1]. > > Example usage in wlroots is available at [2]. > > [1]: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/110 > [2]: h

Re: [RFC PATCH 0/4] Allow to use DRM fbdev emulation layer with CONFIG_FB disabled

2021-09-02 Thread Daniel Vetter
On Wed, Sep 01, 2021 at 11:08:10AM +0200, Javier Martinez Canillas wrote: > On 8/31/21 2:35 PM, Daniel Vetter wrote: > > On Sat, Aug 28, 2021 at 12:02:21AM +0200, Javier Martinez Canillas wrote: > > [snip] > > >> > >> We talked about a drmcon with Peter Robinson as well but then decided that > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-09-02 Thread Daniel Vetter
On Tue, Aug 31, 2021 at 02:18:15PM +0100, Tvrtko Ursulin wrote: > > On 31/08/2021 13:43, Daniel Vetter wrote: > > On Tue, Aug 31, 2021 at 10:15:03AM +0100, Tvrtko Ursulin wrote: > > > > > > On 30/08/2021 09:26, Daniel Vetter wrote: > > > > On Fri, Aug 27, 2021 at 03:44:42PM +0100, Tvrtko Ursulin

Re: [PATCH 1/2] dma-buf: clarify dma_fence_ops->wait documentation

2021-09-02 Thread Daniel Vetter
On Wed, Sep 01, 2021 at 02:02:39PM +0200, Christian König wrote: > This callback is pretty much deprecated and should not be used by new > implementations. > > Clarify that in the documentation as well. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > include/linux/dma

Re: [PATCH 2/2] dma-buf: clarify dma_fence_add_callback documentation

2021-09-02 Thread Daniel Vetter
On Wed, Sep 01, 2021 at 02:02:40PM +0200, Christian König wrote: > That the caller doesn't need to keep a reference is rather > risky and not defensive at all. > > Especially dma_buf_poll got that horrible wrong, so better > remove that sentence and also clarify that the callback > might be called

Re: [PATCH] drm/ttm: provide default page protection for UML

2021-09-02 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 07:19:01AM +0100, Anton Ivanov wrote: > On 02/09/2021 06:52, Randy Dunlap wrote: > > On 9/1/21 10:48 PM, Anton Ivanov wrote: > > > On 02/09/2021 03:01, Randy Dunlap wrote: > > > > boot_cpu_data [struct cpuinfo_um (on UML)] does not have a struct > > > > member named 'x86', s

Re: [PATCH] drm/lease: allow empty leases

2021-09-02 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 05:28:10PM +0300, Pekka Paalanen wrote: > On Thu, 02 Sep 2021 09:11:40 + > Simon Ser wrote: > > > This can be used to create a separate DRM file description, thus > > creating a new GEM handle namespace. See [1]. > > > > Example usage in wlroots is available at [2]. >

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Add i915_gem_context_is_full_ppgtt

2021-09-02 Thread Tvrtko Ursulin
On 02/09/2021 15:20, Daniel Vetter wrote: And use it anywhere we have open-coded checks for ctx->vm that really only check for full ppgtt. Plus for paranoia add a GEM_BUG_ON that checks it's really only set when we have full ppgtt, just in case. gem_context->vm is different since it's NULL in

[Bug 214289] New: amdgpu Msg issuing pre-check failed and SMU may be not in the right state!

2021-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214289 Bug ID: 214289 Summary: amdgpu Msg issuing pre-check failed and SMU may be not in the right state! Product: Drivers Version: 2.5 Kernel Version: 5.13.13 Hardware: Intel

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-09-02 Thread Tvrtko Ursulin
On 02/09/2021 15:33, Daniel Vetter wrote: On Tue, Aug 31, 2021 at 02:18:15PM +0100, Tvrtko Ursulin wrote: On 31/08/2021 13:43, Daniel Vetter wrote: On Tue, Aug 31, 2021 at 10:15:03AM +0100, Tvrtko Ursulin wrote: On 30/08/2021 09:26, Daniel Vetter wrote: On Fri, Aug 27, 2021 at 03:44:42PM

[PATCH] drm/panel: otm8009a: add a 60 fps mode

2021-09-02 Thread Raphael GALLAIS-POU - foss
This patch adds a 60 fps mode to the Orisetech OTM8009A panel. The 50 fps mode is left as preferred. Signed-off-by: Raphael Gallais-Pou --- .../gpu/drm/panel/panel-orisetech-otm8009a.c | 85 --- 1 file changed, 56 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/pane

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Release i915_gem_context from a worker

2021-09-02 Thread Daniel Vetter
On Thu, Sep 2, 2021 at 2:42 PM Tvrtko Ursulin wrote: > > > On 13/08/2021 21:30, Daniel Vetter wrote: > > The only reason for this really is the i915_gem_engines->fence > > callback engines_notify(), which exists purely as a fairly funky > > reference counting scheme for that. Otherwise all other c

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Add i915_gem_context_is_full_ppgtt

2021-09-02 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 03:54:36PM +0100, Tvrtko Ursulin wrote: > On 02/09/2021 15:20, Daniel Vetter wrote: > > And use it anywhere we have open-coded checks for ctx->vm that really > > only check for full ppgtt. > > > > Plus for paranoia add a GEM_BUG_ON that checks it's really only set > > when

[PATCH] drm/stm: ltdc: attach immutable zpos property to planes

2021-09-02 Thread Raphael GALLAIS-POU - foss
Defines plane ordering by hard-coding an immutable Z position from the first plane, used as primary layer, to the next ones as overlay in order of instantiation. This zpos is only an information as it is not possible to modify it, blending operations are still applied from the top to the bottom la

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-02 Thread Andrey Grodzovsky
On 2021-09-02 10:28 a.m., Daniel Vetter wrote: On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: On 2021-08-31 9:11 a.m., Daniel Vetter wrote: On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: O

[Bug 214289] amdgpu Msg issuing pre-check failed and SMU may be not in the right state!

2021-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214289 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

2021-09-02 Thread Daniel Vetter
On Thu, Sep 2, 2021 at 1:00 PM Christian König wrote: > > Hi Monk, > > Am 02.09.21 um 07:52 schrieb Liu, Monk: > > [AMD Official Use Only] > > > > I'm not sure I can add much to help this along, I'm sure Alex has some > > internal training, > > Once your driver is upstream, it belongs to upstream

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Release i915_gem_context from a worker

2021-09-02 Thread Tvrtko Ursulin
On 02/09/2021 16:05, Daniel Vetter wrote: On Thu, Sep 2, 2021 at 2:42 PM Tvrtko Ursulin wrote: On 13/08/2021 21:30, Daniel Vetter wrote: The only reason for this really is the i915_gem_engines->fence callback engines_notify(), which exists purely as a fairly funky reference counting scheme

[PATCH 2/2] drm/msm/mdp5: Add configuration for MDP v1.16

2021-09-02 Thread Sireesh Kodali
From: Vladimir Lypak MDP version v1.16 is almost identical to v1.15 with most significant difference being presence of second DSI interface. MDP v1.16 is found on SoCs such as MSM8x53, SDM450, SDM632 (All with Adreno 506). Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali --- driver

[PATCH 1/2] drm/msm/dsi: Add phy configuration for MSM8953

2021-09-02 Thread Sireesh Kodali
From: Vladimir Lypak Add phy configuration for 14nm dsi phy found on MSM8953 SoC. Only difference from existing configurations are io_start addresses. Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali --- .../bindings/display/msm/dsi-phy-14nm.yaml| 1 + drivers/gpu/drm/msm/dsi/

[PATCH 0/2] MSM8953 MDP/DSI PHY enablement

2021-09-02 Thread Sireesh Kodali
This patch series adds support for the MDP and DSI PHY as found on the MSM8953 platform (APQ8053, SDM450, SDA450, SDM625, SDM626). All the SoCs on this platform use the adreno 506 GPU. Vladimir Lypak (2): drm/msm/dsi: Add phy configuration for MSM8953 drm/msm/mdp5: Add configuration for MDP v1

Re: [PATCH v6, 00/15] Using component framework to support multi hardware decode

2021-09-02 Thread Ezequiel Garcia
On Wed, 1 Sept 2021 at 05:32, Yunfei Dong wrote: > > This series adds support for multi hardware decode into mtk-vcodec, by first > adding component framework to manage each hardware information: interrupt, > clock, register bases and power. Secondly add core thread to deal with core > hardware me

[Bug 214289] amdgpu Msg issuing pre-check failed and SMU may be not in the right state!

2021-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214289 --- Comment #2 from Michal Przybylowicz (michal.przybylow...@gmail.com) --- Created attachment 298645 --> https://bugzilla.kernel.org/attachment.cgi?id=298645&action=edit dmesg full dmesg extraced using: $ journalctl -k -b -1 --no-pager > ~/Do

[Bug 214289] amdgpu Msg issuing pre-check failed and SMU may be not in the right state!

2021-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214289 --- Comment #3 from Michal Przybylowicz (michal.przybylow...@gmail.com) --- Just one thing that I have noticed it looks like these messages appear when I do some interactions on webpages like clicking dropdown... I am using Vivaldi: 4.1.2369.21

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Add i915_gem_context_is_full_ppgtt

2021-09-02 Thread Tvrtko Ursulin
On 02/09/2021 16:22, Daniel Vetter wrote: On Thu, Sep 02, 2021 at 03:54:36PM +0100, Tvrtko Ursulin wrote: On 02/09/2021 15:20, Daniel Vetter wrote: And use it anywhere we have open-coded checks for ctx->vm that really only check for full ppgtt. Plus for paranoia add a GEM_BUG_ON that checks

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

2021-09-02 Thread Daniel Stone
Hi Monk, On Thu, 2 Sept 2021 at 06:52, Liu, Monk wrote: > I didn't mean your changes on AMD driver need my personal approval or review > ... and I'm totally already get used that our driver is not 100% under > control by AMDers, > but supposedly any one from community (including you) who tend

Re: [PATCH v5 25/25] drm/i915/guc: Add GuC kernel doc

2021-09-02 Thread John Harrison
On 9/1/2021 17:50, Daniele Ceraolo Spurio wrote: From: Matthew Brost Add GuC kernel doc for all structures added thus far for GuC submission and update the main GuC submission section with the new interface details. v2: - Drop guc_active.lock DOC v3: - Fixup a few kernel doc comments (Dani

RE: [Intel-gfx] [PATCH 07/11] drm/i915: Add i915_gem_context_is_full_ppgtt

2021-09-02 Thread Bloomfield, Jon
> -Original Message- > From: Tvrtko Ursulin > Sent: Thursday, September 2, 2021 9:42 AM > To: Daniel Vetter > Cc: Daniel Vetter ; DRI Development de...@lists.freedesktop.org>; Intel Graphics Development g...@lists.freedesktop.org>; Maarten Lankhorst > ; Vetter, Daniel > ; Bloomfield, Jo

Re: [PATCH v5 25/25] drm/i915/guc: Add GuC kernel doc

2021-09-02 Thread Daniele Ceraolo Spurio
On 9/2/2021 10:01 AM, John Harrison wrote: On 9/1/2021 17:50, Daniele Ceraolo Spurio wrote: From: Matthew Brost Add GuC kernel doc for all structures added thus far for GuC submission and update the main GuC submission section with the new interface details. v2:   - Drop guc_active.lock DO

Re: [PATCH v1 03/14] mm: add iomem vma selection for memory migration

2021-09-02 Thread Dan Williams
On Thu, Sep 2, 2021 at 1:18 AM Christoph Hellwig wrote: > > On Wed, Sep 01, 2021 at 11:40:43AM -0400, Felix Kuehling wrote: > > >>> It looks like I'm totally misunderstanding what you are adding here > > >>> then. Why do we need any special treatment at all for memory that > > >>> has normal stru

Re: [PATCH] drm/msm: remove unneeded variable

2021-09-02 Thread Lyude Paul
Reviewed-by: Lyude Paul Do you need me to push this? On Tue, 2021-08-31 at 04:51 -0700, cgel@gmail.com wrote: > From: Chi Minghao > > Fix the following coccicheck REVIEW: > ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable > > Reported-by: Zeal Robot > Signed-off-by: Chi Mi

Re: [PATCH v5 10/25] drm/i915/guc: Copy whole golden context, set engine state size of subset

2021-09-02 Thread John Harrison
On 9/1/2021 17:50, Daniele Ceraolo Spurio wrote: From: Matthew Brost When the GuC does a media reset, it copies a golden context state back into the corrupted context's state. The address of the golden context and the size of the engine state restore are passed in via the GuC ADS. The i915 had

Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-02 Thread Stephen Boyd
Quoting Marijn Suijten (2021-09-02 06:05:34) > On 2021-09-01 20:46:34, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-09-01 01:57:15) > > > On 2021-08-31 22:35:56, Stephen Boyd wrote: > > > > Quoting Marijn Suijten (2021-08-30 11:24:45) > > > > > The DSI PHY/PLL was relying on a global "xo" c

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Add i915_gem_context_is_full_ppgtt

2021-09-02 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 05:05:05PM +, Bloomfield, Jon wrote: > > -Original Message- > > From: Tvrtko Ursulin > > Sent: Thursday, September 2, 2021 9:42 AM > > To: Daniel Vetter > > Cc: Daniel Vetter ; DRI Development > de...@lists.freedesktop.org>; Intel Graphics Development > g...@

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Release i915_gem_context from a worker

2021-09-02 Thread Daniel Vetter
On Thu, Sep 2, 2021 at 6:20 PM Tvrtko Ursulin wrote: > On 02/09/2021 16:05, Daniel Vetter wrote: > > On Thu, Sep 2, 2021 at 2:42 PM Tvrtko Ursulin > > wrote: > >> > >> > >> On 13/08/2021 21:30, Daniel Vetter wrote: > >>> The only reason for this really is the i915_gem_engines->fence > >>> callbac

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #44 from James Zhu (jam...@amd.com) --- Created attachment 298651 --> https://bugzilla.kernel.org/attachment.cgi?id=298651&action=edit A workaround for suspend/resume hung issue The VCN block passed all ring tests, usually the vcn w

[PATCH][next] drm/amdgpu: clean up inconsistent indenting

2021-09-02 Thread Colin King
From: Colin Ian King There are a couple of statements that are indented one character too deeply, clean these up. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH][next] drm/amdgpu: sdma: clean up identation

2021-09-02 Thread Colin King
From: Colin Ian King There is a statement that is indented incorrectly. Clean it up. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/am

[PATCH][next] drm/i915: clean up inconsistent indenting

2021-09-02 Thread Colin King
From: Colin Ian King There is a statement that is indented one character too deeply, clean this up. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_execlists

Re: [PATCH v3 00/16] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-09-02 Thread Andrzej Hajda
Removed most CC: SMTP server protested. On 01.09.2021 22:19, Douglas Anderson wrote: > The goal of this patch series is to move away from hardcoding exact > eDP panels in device tree files. As discussed in the various patches > in this series (I'm not repeating everything here), most eDP panels

Re: [PATCH v5 02/25] drm/i915/guc: Fix outstanding G2H accounting

2021-09-02 Thread John Harrison
On 9/1/2021 17:49, Daniele Ceraolo Spurio wrote: From: Matthew Brost A small race that could result in incorrect accounting of the number of outstanding G2H. Basically prior to this patch we did not increment the number of outstanding G2H if we encoutered a GT reset while sending a H2G. This wa

Re: [PATCH 1/2] drm/msm/dsi: Add phy configuration for MSM8953

2021-09-02 Thread Dmitry Baryshkov
On 02/09/2021 18:59, Sireesh Kodali wrote: From: Vladimir Lypak Add phy configuration for 14nm dsi phy found on MSM8953 SoC. Only difference from existing configurations are io_start addresses. Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali --- .../bindings/display/msm/dsi-phy

Re: [PATCH 1/3] drm/msm/dpu1: Add DMA2, DMA3 clock control to enum

2021-09-02 Thread Dmitry Baryshkov
On 01/09/2021 21:11, AngeloGioacchino Del Regno wrote: The enum dpu_clk_ctrl_type misses DPU_CLK_CTRL_DMA{2,3} even though this driver does actually handle both, if present: add the two in preparation for adding support for SoCs having them. Signed-off-by: AngeloGioacchino Del Regno Reviewed

Re: [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-02 Thread Dmitry Baryshkov
On 01/09/2021 21:11, AngeloGioacchino Del Regno wrote: Bringup functionality for MSM8998 in the DPU, driver which is mostly the same as SDM845 (just a few variations). Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

Re: [PATCH v3 00/16] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-09-02 Thread Doug Anderson
Hi, On Thu, Sep 2, 2021 at 3:10 PM Andrzej Hajda wrote: > > Removed most CC: SMTP server protested. Yeah, it was because of the dang defconfig patches. My general policy is to send the cover letter to everyone even if not everyone gets CCed on all patches, but it ended up as a lot... Speaking of

[PATCH 0/2] Add support for querying hw info that UMDs need

2021-09-02 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. Test-with: 20210727002812.43469-2-john.c.harri...@intel.com UMD: https://github.com/intel/comput

[PATCH 2/2] drm/i915/uapi: Add query for hwconfig table

2021-09-02 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interes

  1   2   >