RE: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Liu, Monk
[AMD Official Use Only] what is that 'ts' representing for ? it looks to me the jiffies that it get scheduled to the ring, but a job scheduled to the ring doesn't represent it's being processed by hw. Thanks -- Monk Liu | Cloud-GPU Core team --

RE: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Liu, Monk
[AMD Official Use Only] Yeah, that "kthread_should_park" is also irrelevant looks to me as well and it delays the signaled job's cleanup/free Thanks -- Monk Liu | Cloud-GPU Core team -- -Original Message-

RE: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Liu, Monk
[AMD Official Use Only] >>> I'm not sure if the work_tdr is initialized when a maximum timeout is >>> specified. Please double check. Even timeout set to max the work_tdr is still initialized: int drm_sched_init(struct drm_gpu_scheduler *sched, const struct drm_sched_backend_o

Re: [PATCH] drm/i915: Actually delete gpu reloc selftests

2021-08-27 Thread Daniel Vetter
On Fri, Aug 20, 2021 at 07:59:04PM +0200, Daniel Vetter wrote: > On Fri, Aug 20, 2021 at 7:00 PM Rodrigo Vivi wrote: > > > > On Fri, Aug 20, 2021 at 05:49:32PM +0200, Daniel Vetter wrote: > > > In > > > > > > commit 8e02cceb1f1f4f254625e5338dd997ff61ab40d7 > > > Author: Daniel Vetter > > > Date:

[PATCH V4 00/10] PCI/VGA: Rework default VGA device selection

2021-08-27 Thread Huacai Chen
My original work is at [1]. Bjorn do some rework and extension in V2. It moves the VGA arbiter to the PCI subsystem, fixes a few nits, and breaks a few pieces to make the main patch a little smaller. V3 rewrite the commit log of the last patch (which is also summarized by Bjorn). V4 split the la

[PATCH V4 01/10] PCI/VGA: Move vgaarb to drivers/pci

2021-08-27 Thread Huacai Chen
From: Bjorn Helgaas The VGA arbiter is really PCI-specific and doesn't depend on any GPU things. Move it to the PCI subsystem. Signed-off-by: Bjorn Helgaas --- drivers/gpu/vga/Kconfig | 19 --- drivers/gpu/vga/Makefile | 1 - drivers/pci/Kconfig

[PATCH V4 02/10] PCI/VGA: Replace full MIT license text with SPDX identifier

2021-08-27 Thread Huacai Chen
From: Bjorn Helgaas Per Documentation/process/license-rules.rst, the SPDX MIT identifier is equivalent to including the entire MIT license text from LICENSES/preferred/MIT. Replace the MIT license text with the equivalent SPDX identifier. Signed-off-by: Bjorn Helgaas --- drivers/pci/vgaarb.c

[PATCH V4 03/10] PCI/VGA: Use unsigned format string to print lock counts

2021-08-27 Thread Huacai Chen
From: Bjorn Helgaas In struct vga_device, io_lock_cnt and mem_lock_cnt are unsigned, but we previously printed them with "%d", the signed decimal format. Print them with the unsigned format "%u" instead. Signed-off-by: Bjorn Helgaas --- drivers/pci/vgaarb.c | 2 +- 1 file changed, 1 insertion

[PATCH V4 04/10] PCI/VGA: Remove empty vga_arb_device_card_gone()

2021-08-27 Thread Huacai Chen
From: Bjorn Helgaas vga_arb_device_card_gone() has always been empty. Remove it. Signed-off-by: Bjorn Helgaas --- drivers/pci/vgaarb.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c index e4153ab70481..c984c76b3

[PATCH V4 05/10] PCI/VGA: Move vga_arb_integrated_gpu() earlier in file

2021-08-27 Thread Huacai Chen
Move vga_arb_integrated_gpu() earlier in file to prepare for future patch. No functional change intended. [bhelgaas: split to separate patch] Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas --- drivers/pci/vgaarb.c | 28 ++-- 1 file changed, 14 insertions(+), 14

[PATCH V4 06/10] PCI/VGA: Prefer vga_default_device()

2021-08-27 Thread Huacai Chen
Use the vga_default_device() interface consistently instead of directly testing vga_default. No functional change intended. [bhelgaas: split to separate patch and extended] Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas --- drivers/pci/vgaarb.c | 6 +++--- 1 file changed, 3 insertions

[PATCH V4 07/10] PCI/VGA: Split out vga_arb_update_default_device()

2021-08-27 Thread Huacai Chen
If there's no default VGA device, and we find a VGA device that owns the legacy VGA resources, we make that device the default. Split this logic out from vga_arbiter_add_pci_device() into a new function, vga_arb_update_default_device(). [bhelgaas: split another piece to separate patch] Signed-off

[PATCH V4 08/10] PCI/VGA: Log bridge control messages when adding devices

2021-08-27 Thread Huacai Chen
Previously vga_arb_device_init() iterated through all VGA devices and indicated whether legacy VGA routing to each could be controlled by an upstream bridge. But we determine that information in vga_arbiter_add_pci_device(), which we call for every device, so we can log it there without iterating

[PATCH V4 09/10] PCI/VGA: Rework default VGA device selection (Step 1)

2021-08-27 Thread Huacai Chen
Current default VGA device selection fails in some cases: - On BMC system, the AST2500 bridge [1a03:1150] does not implement PCI_BRIDGE_CTL_VGA [1]. This is perfectly legal but means the legacy VGA resources won't reach downstream devices unless they're included in the usual bridge

[PATCH V4 10/10] PCI/VGA: Rework default VGA device selection (Step 2)

2021-08-27 Thread Huacai Chen
Current default VGA device selection fails in some cases: - On BMC system, the AST2500 bridge [1a03:1150] does not implement PCI_BRIDGE_CTL_VGA [1]. This is perfectly legal but means the legacy VGA resources won't reach downstream devices unless they're included in the usual bridge

Re: [PATCH] MAINTAINERS: Add dri-devel for component.[hc]

2021-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 26, 2021 at 09:39:44PM +0200, Daniel Vetter wrote: > On Thu, Aug 26, 2021 at 12:56:26PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 26, 2021 at 11:13:43AM +0200, Daniel Vetter wrote: > > > dri-devel is the main user, and somehow there's been the assumption > > > that component stuf

Re: [PATCH 1/2] dma-buf: nuke DMA_FENCE_TRACE macros v2

2021-08-27 Thread Christian König
Am 26.08.21 um 10:55 schrieb Daniel Vetter: On Tue, Aug 24, 2021 at 10:12:24AM +0200, Christian König wrote: Just a gentle ping. Daniel any more comments on this? Still haven't seen a patch set to nuke the sw_sync igt tests. Otherwise this is just going to cause fails and reboots in our ci (we

[RFC PATCH 0/4] Allow to use DRM fbdev emulation layer with CONFIG_FB disabled

2021-08-27 Thread Javier Martinez Canillas
This patch series splits the fbdev core support in two different Kconfig symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to be disabled, while still using fbcon with the DRM fbdev emulation layer. The reason for doing this is that now with simpledrm we could just boot with s

[RFC PATCH 1/4] fbdev: Rename fb_*_device() functions names to match what they do

2021-08-27 Thread Javier Martinez Canillas
The fb_init_device() and fb_cleanup_device() functions only register and unregister sysfs attributes as their initialization and cleanup logic. Let's rename these functions to better match what they actually do. There's only a call to dev_set_drvdata() that's not related to the sysfs registration,

[RFC PATCH 2/4] fbdev: Move framebuffer_{alloc, release}() functions to fbmem.c

2021-08-27 Thread Javier Martinez Canillas
The framebuffer_alloc() and framebuffer_release() functions are much more related with the functions in drivers/fbdev/core/fbmem.c than the ones in drivers/fbdev/core/fbsysfs.c, that are only to manage sysfs attributes. Signed-off-by: Javier Martinez Canillas --- drivers/video/fbdev/core/fbmem.

[RFC PATCH 3/4] fbdev: Split frame buffer support in FB and FB_CORE symbols

2021-08-27 Thread Javier Martinez Canillas
Currently the CONFIG_FB option has to be enabled even if no legacy fbdev drivers are needed, in order to have support for a framebuffer console. The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB and so it can only be enabled if that dependency is enabled as well. That means

[RFC PATCH 4/4] drm: Make fbdev emulation depend on FB_CORE instead of FB

2021-08-27 Thread Javier Martinez Canillas
Now that the fbdev core has been split in FB_CORE and FB, make DRM fbdev emulation layer to just depend on the former. This allows to disable the CONFIG_FB option if is not needed, which will avoid the need to explicitly disable all the legacy fbdev drivers. Signed-off-by: Javier Martinez Canilla

[Bug 214197] New: [Asus G713QY] RX6800M not usable after exiting Vulkan application

2021-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214197 Bug ID: 214197 Summary: [Asus G713QY] RX6800M not usable after exiting Vulkan application Product: Drivers Version: 2.5 Kernel Version: 5.13.13 Hardware: x86-64

[Bug 214199] New: Sapphire NITRO+ RX 580 4G G5 - Secondary display doesn't wake up on boot, both displays won't wake up from suspend

2021-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214199 Bug ID: 214199 Summary: Sapphire NITRO+ RX 580 4G G5 - Secondary display doesn't wake up on boot, both displays won't wake up from suspend Product: Drivers Versio

[Bug 214199] Sapphire NITRO+ RX 580 4G G5 - Secondary display doesn't wake up on boot, both displays won't wake up from suspend

2021-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214199 --- Comment #1 from Zeljko (ker...@zeljko.anonaddy.com) --- Created attachment 298499 --> https://bugzilla.kernel.org/attachment.cgi?id=298499&action=edit Suspend dmesg -- You may reply to this email to add a comment. You are receiving this m

Re: [PATCH v1 02/14] mm: remove extra ZONE_DEVICE struct page refcount

2021-08-27 Thread Vlastimil Babka
On 8/25/21 19:49, Ralph Campbell wrote: > > On 8/25/21 4:15 AM, Vlastimil Babka wrote: >> On 8/25/21 05:48, Alex Sierra wrote: >>> From: Ralph Campbell >>> >>> ZONE_DEVICE struct pages have an extra reference count that complicates the >>> code for put_page() and several places in the kernel that

Re: [PATCH] MAINTAINERS: Add dri-devel for component.[hc]

2021-08-27 Thread Ezequiel Garcia
Hi Daniel, On Thu, 26 Aug 2021 at 06:13, Daniel Vetter wrote: > > dri-devel is the main user, and somehow there's been the assumption > that component stuff is unmaintained. > > References: > https://lore.kernel.org/dri-devel/CAAEAJfDWOzCJxZFNtxeT7Cvr2pWbYrfz-YnA81sVNs-rM=8...@mail.gmail.com/ >

[PATCH libdrm 00/25] Update Tegra support

2021-08-27 Thread Thierry Reding
From: Thierry Reding Hi all, this is the userspace part of the kernel patches that were recently merged into drm-next: https://patchwork.freedesktop.org/series/92378/ The goal is to provide a userspace implementation of the UAPI exposed by the kernel and show its usage in some test programs

[PATCH libdrm 01/25] tegra: Indent according to .editorconfig

2021-08-27 Thread Thierry Reding
From: Thierry Reding Reindent the sources according to the settings found in the newly added .editorconfig. Signed-off-by: Thierry Reding --- tegra/private.h | 18 +- tegra/tegra.c | 354 tegra/tegra.h | 12 +- tests/tegra/

[PATCH libdrm 04/25] tegra: Fix mmap() of GEM buffer objects

2021-08-27 Thread Thierry Reding
From: Thierry Reding Store 64-bit offset values and use libdrm's built-in drm_mmap() function instead of mmap() to ensure the full 64-bit offset is used. Signed-off-by: Thierry Reding --- tegra/private.h | 2 +- tegra/tegra.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff -

[PATCH libdrm 02/25] tegra: Remove unused IOCTL implementations

2021-08-27 Thread Thierry Reding
From: Thierry Reding The DRM_TEGRA_GEM_{GET,SET}_FLAGS and DRM_TEGRA_GEM_{GET,SET}_TILING IOCTLs were badly designed and have since been obsoleted by framebuffer modifiers. Remove these implementations to make it clear their usage is discouraged. Signed-off-by: Thierry Reding --- tegra/tegra-s

[PATCH libdrm 03/25] tegra: Extract common buffer object allocation code

2021-08-27 Thread Thierry Reding
From: Thierry Reding All of the buffer object allocation functions use the same boilerplate code. Move that code into a separate function that can be reused. Signed-off-by: Thierry Reding --- tegra/tegra.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions

[PATCH libdrm 07/25] tegra: Make API more consistent

2021-08-27 Thread Thierry Reding
From: Thierry Reding Most functions in libdrm_tegra take as first parameter the object that they operate on. Make the device and buffer object creation functions follow the same scheme. Signed-off-by: Thierry Reding --- tegra/tegra.c | 13 +++-- tegra/tegra.h | 10 +

[PATCH libdrm 06/25] tegra: Add PRIME support helpers

2021-08-27 Thread Thierry Reding
From: Thierry Reding These helpers facilitate exporting and importing buffer objects to and from PRIME file descriptors. Signed-off-by: Thierry Reding --- Changes in v3: - add drm_public annotations --- tegra/tegra-symbols.txt | 2 ++ tegra/tegra.c | 61 +

[PATCH libdrm 08/25] tegra: Install tegra-openclose test

2021-08-27 Thread Thierry Reding
From: Thierry Reding Allow this simple test to be installed so that it can easily be run on a target device. Signed-off-by: Thierry Reding --- tests/tegra/.gitignore | 2 +- tests/tegra/meson.build | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/tegra/.gitign

[PATCH libdrm 05/25] tegra: Add flink helpers

2021-08-27 Thread Thierry Reding
From: Thierry Reding Add helpers to export and import buffer objects via flink names. Signed-off-by: Thierry Reding --- Changes in v3: - add drm_public annotations --- tegra/tegra-symbols.txt | 2 ++ tegra/tegra.c | 50 + tegra/tegra.h

[PATCH libdrm 09/25] tegra: Update for new UABI

2021-08-27 Thread Thierry Reding
From: Thierry Reding This new UABI is a more modern version that works better with both old and recent chips. Signed-off-by: Thierry Reding --- include/drm/tegra_drm.h | 429 +--- 1 file changed, 404 insertions(+), 25 deletions(-) diff --git a/include/drm/t

[PATCH libdrm 12/25] tegra: Add job and push buffer APIs

2021-08-27 Thread Thierry Reding
From: Thierry Reding These new functions can be used to create a job on a given channel, add commands to the job using its push buffer and submit the job. Signed-off-by: Thierry Reding --- tegra/job.c | 164 tegra/meson.build | 2 +-

[PATCH libdrm 17/25] tests: tegra: Add syncpoint timeout test

2021-08-27 Thread Thierry Reding
From: Thierry Reding This test can be used to purposefully trigger a job timeout. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 9 ++ tests/tegra/syncpt-timeout.c | 163 +++ 2 files changed, 172 insertions(+) create mode 100644 tests/tegra/

[PATCH libdrm 15/25] tests: tegra: Add gr2d-fill test

2021-08-27 Thread Thierry Reding
From: Thierry Reding This test uses the IOCTLs for job submission and fences to fill a sub- region of the screen to a specific color using gr2d. Signed-off-by: Thierry Reding --- tests/tegra/.gitignore | 1 + tests/tegra/drm-test-tegra.c | 147 +++ tests

[PATCH libdrm 10/25] tegra: Include private.h in list of source files

2021-08-27 Thread Thierry Reding
From: Thierry Reding This makes sure that the proper dependencies are created and that the file is distributed. Signed-off-by: Thierry Reding --- tegra/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tegra/meson.build b/tegra/meson.build index edddf72bc0e7

[PATCH libdrm 14/25] tests: tegra: Add helper library for tests

2021-08-27 Thread Thierry Reding
From: Thierry Reding This library provides helpers for common functionality needed by test programs. Signed-off-by: Thierry Reding --- tests/tegra/drm-test.c | 248 tests/tegra/drm-test.h | 72 tests/tegra/meson.build | 7 ++ 3 files c

[PATCH libdrm 18/25] tests: tegra: Add VIC support

2021-08-27 Thread Thierry Reding
From: Thierry Reding Implement a small abstraction interface to allow different versions of VIC to be used transparently. An implementation will be chosen based on the VIC version number reported by the DRM_TEGRA_IOCTL_OPEN_CHANNEL IOCTL. Signed-off-by: Thierry Reding --- tests/tegra/host1x.h

[PATCH libdrm 16/25] tests: tegra: Add syncpt-wait test

2021-08-27 Thread Thierry Reding
From: Thierry Reding This is a very simple sanity test to check whether or not a syncpt can be incremented by a host1x client. This uses gr2d on Tegra20 through Tegra114 and VIC on Tegra124 and later. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 9 +++ tests/tegra/syncpt-wai

[PATCH libdrm 19/25] tests: tegra: Add VIC 3.0 support

2021-08-27 Thread Thierry Reding
From: Thierry Reding The Video Image Composer (VIC) 3.0 can be found on NVIDIA Tegra124 SoCs. Signed-off-by: Thierry Reding --- tegra/private.h | 6 + tests/tegra/meson.build | 2 + tests/tegra/vic.c | 8 +- tests/tegra/vic30.c | 509

[PATCH libdrm 25/25] tests: tegra: Add VIC flip test

2021-08-27 Thread Thierry Reding
From: Thierry Reding This test will attempt to use the VIC to blit one surface to another and perform a vertical flip. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 9 ++ tests/tegra/vic-flip.c | 333 2 files changed, 342 insertions(+)

[PATCH libdrm 22/25] tests: tegra: Add VIC 4.2 support

2021-08-27 Thread Thierry Reding
From: Thierry Reding The Video Image Composer (VIC) 4.2 can be found on NVIDIA Tegra194 SoCs. It uses a different class (C5B6) that is slightly incompatible with the class found on earlier generations, although it is backwards compatible with the class implemented on Tegra186 (B1B6). Signed-off-

[PATCH libdrm 13/25] tegra: Add syncpoint APIs

2021-08-27 Thread Thierry Reding
From: Thierry Reding These new functions can be used to allocate and free syncpoints, as well as wait for a syncpoint threshold to be reached. Jobs can also be waited on if a syncpoint was attached to them. Signed-off-by: Thierry Reding --- tegra/job.c | 23 + tegra/meson.

[PATCH libdrm 11/25] tegra: Add channel APIs

2021-08-27 Thread Thierry Reding
From: Thierry Reding These new functions can be used to open a channel to a given engine, map and unmap buffer objects to that channel, and close the channel. Signed-off-by: Thierry Reding --- tegra/channel.c | 195 tegra/meson.build | 2

[PATCH libdrm 23/25] tests: tegra: Add VIC clear test

2021-08-27 Thread Thierry Reding
From: Thierry Reding This test will attempt to use VIC to clear a surface. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 9 +++ tests/tegra/vic-clear.c | 173 2 files changed, 182 insertions(+) create mode 100644 tests/tegra/vic-clear.c

[PATCH libdrm 20/25] tests: tegra: Add VIC 4.0 support

2021-08-27 Thread Thierry Reding
From: Thierry Reding The Video Image Composer (VIC) 4.0 can be found on NVIDIA Tegra210 SoCs. It uses a different class (B0B6) that is slightly incompatible with the class found on earlier generations. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 2 + tests/tegra/vic.c |

[PATCH libdrm 21/25] tests: tegra: Add VIC 4.1 support

2021-08-27 Thread Thierry Reding
From: Thierry Reding The Video Image Composer (VIC) 4.1 can be found on NVIDIA Tegra186 SoCs. It uses a different class (B1B6) that is slightly incompatible with the class found on earlier generations. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 2 + tests/tegra/vic.c |

[PATCH libdrm 24/25] tests: tegra: Add VIC blit test

2021-08-27 Thread Thierry Reding
From: Thierry Reding This test will attempt to use the VIC to blit from one surface to another. Signed-off-by: Thierry Reding --- tests/tegra/meson.build | 9 ++ tests/tegra/vic-blit.c | 333 2 files changed, 342 insertions(+) create mode 100644 tes

[PATCH] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-08-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) when rendering is done on Intel dgfx and scanout/composition on Intel igfx. Before this patch the driver was not quite ready for that setup, mainly because it was able to emit a semaphore wait between th

TTM tt size larger than buffer object?

2021-08-27 Thread Thomas Hellström
Hi, Christian. We have a use-case with i915 where the data representation of a buffer object is larger in system memory than in LMEM/VRAM. Hence we'd like to create a ttm_tt that is larger than the buffer object itself. Quickly auditing the TTM code it looks like that should be pretty safe, as

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Andrey Grodzovsky
The TS  represents the point in time when the job was inserted into the pending list. I don't think it matters when it actually starts to be processed, what matters is when this job was inserted into pending list because right at that point you arm the TO timer (when no other is running already)

Re: [PATCH libdrm 19/25] tests: tegra: Add VIC 3.0 support

2021-08-27 Thread Michał Mirosław
On Fri, Aug 27, 2021 at 03:22:59PM +0200, Thierry Reding wrote: > From: Thierry Reding > > The Video Image Composer (VIC) 3.0 can be found on NVIDIA Tegra124 SoCs.a [...] > +static int vic30_clear(struct vic *v, struct vic_image *output, > + unsigned int alpha, unsigned int

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Andrey Grodzovsky
So we agree if (kthread_should_park()) return NULL should go away ? Andrey On 2021-08-27 3:46 a.m., Liu, Monk wrote: [AMD Official Use Only] Yeah, that "kthread_should_park" is also irrelevant looks to me as well and it delays the signaled job's cleanup/free Thanks

Re: DE2.0 YV12 playback issues after ea067aee45a8

2021-08-27 Thread Roman Stratiienko
+CC: jernej.skra...@gmail.com пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko : > > Hello Jernej, > > During local testing I faced an issue where YV12 buffers are displayed > all in blue. > > Issue can be fixed by reverting: > ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices") > > C

DE2.0 YV12 playback issues after ea067aee45a8

2021-08-27 Thread Roman Stratiienko
Hello Jernej, During local testing I faced an issue where YV12 buffers are displayed all in blue. Issue can be fixed by reverting: ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices") Could you have a look please? Best regards, Roman Stratiienko

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Christian König
Yes, I don't see any good reason for that either. Christian. Am 27.08.21 um 15:45 schrieb Andrey Grodzovsky: So we agree if (kthread_should_park()) return NULL should go away ? Andrey On 2021-08-27 3:46 a.m., Liu, Monk wrote: [AMD Official Use Only] Yeah, that "kthread_should_park" is also

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Christian König
I don't think that makes sense. See we don't want to start the time when the job is inserted into the ring buffer, but rather when it starts processing. Starting processing is a bit swampy defined, but just starting the timer when the previous job completes should be fine enough. Christian.

[PATCH v2] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-08-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) when rendering is done on Intel dgfx and scanout/composition on Intel igfx. Before this patch the driver was not quite ready for that setup, mainly because it was able to emit a semaphore wait between th

Re: TTM tt size larger than buffer object?

2021-08-27 Thread Christian König
Am 27.08.21 um 15:55 schrieb Thomas Hellström: Hi, Christian. We have a use-case with i915 where the data representation of a buffer object is larger in system memory than in LMEM/VRAM. Hence we'd like to create a ttm_tt that is larger than the buffer object itself. Quickly auditing the TTM c

Re: [v3 3/4] drm/panel: support for BOE and INX video mode panel

2021-08-27 Thread Doug Anderson
Hi, On Fri, Aug 27, 2021 at 1:24 AM yangcong wrote: > > Add driver for BOE tv110c9m-ll3 and Inx hj110iz-01a panel > both of those are 10.95" 1200x2000 panel. Your commit message would be a good place to note design choices you made in your patch. Maybe you might say: Support for these two panel

Re: [Intel-gfx] [PATCH v2] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-08-27 Thread Tvrtko Ursulin
On 27/08/2021 15:39, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) when rendering is done on Intel dgfx and scanout/composition on Intel igfx. Before this patch the driver was not quite ready for that setup, mainly because

[Bug 214197] [Asus G713QY] RX6800M not usable after exiting Vulkan application

2021-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214197 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

[PATCH 1/2] drm/bridge: it66121: Initialize {device,vendor}_ids

2021-08-27 Thread Paul Cercueil
These two arrays are populated with data read from the I2C device through regmap_read(), and the data is then compared with hardcoded vendor/product ID values of supported chips. However, the return value of regmap_read() was never checked. This is fine, as long as the two arrays are zero-initiali

[PATCH 2/2] drm/bridge: it66121: Wait for next bridge to be probed

2021-08-27 Thread Paul Cercueil
If run before the next bridge is initialized, of_drm_find_bridge() will give us a NULL pointer. If that's the case, return -EPROBE_DEFER; we may have more luck next time. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/bridge/ite-it66121.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a

Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-08-27 Thread Bjorn Andersson
On Fri 27 Aug 00:20 CDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-08-25 16:42:31) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > > b/drivers/gpu/drm/msm/dp/dp_display.c > > index 2c7de43f655a..4a6132c18e57 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_display.c > > +++ b/driv

[Bug 214197] [Asus G713QY] RX6800M not usable after exiting Vulkan application

2021-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214197 --- Comment #2 from Alex Deucher (alexdeuc...@gmail.com) --- Does this patch fix the issue? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=202ead5a3c589b0594a75cb99f080174f6851fed -- You may reply to this email to

Re: [RFC PATCH 0/4] Allow to use DRM fbdev emulation layer with CONFIG_FB disabled

2021-08-27 Thread Thomas Zimmermann
Hi Am 27.08.21 um 12:00 schrieb Javier Martinez Canillas: This patch series splits the fbdev core support in two different Kconfig symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to be disabled, while still using fbcon with the DRM fbdev emulation layer. I'm skeptical. D

Re: [PATCH v6 01/11] moduleparam: add data member to struct kernel_param

2021-08-27 Thread jim . cromie
On Wed, Aug 25, 2021 at 11:13 AM Jason Baron wrote: > > > > On 8/22/21 6:19 PM, Jim Cromie wrote: > > Add a const void* data member to the struct, to allow attaching > > private data that will be used soon by a setter method (via kp->data) > > to perform more elaborate actions. > > > > To attach t

Re: [PATCH v2 0/4] Various fixes to pass libdrm hotunplug tests

2021-08-27 Thread Andrey Grodzovsky
Ping Andrey On 2021-08-26 1:27 p.m., Andrey Grodzovsky wrote: Bunch of fixes to enable passing hotplug tests i previosly added here[1] with latest code. Once accepted I will enable the tests on libdrm side. [1] - https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/172 v2: Dropping VCE pa

Re: [PATCH v3] drm/amd/pm: And destination bounds checking to struct copy

2021-08-27 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 26, 2021 at 11:16 PM Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. > > The "Board Parameters" m

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Andrey Grodzovsky
As I mentioned to Monk before - what about cases such as in this test - https://gitlab.freedesktop.org/mesa/drm/-/commit/bc21168fa924d3fc4a000492e861f50a1a135b25 Here you don't have serialized sequence where when jobs finishes processing and second starts, they execute together  concurrently - fo

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Andreas (icedragon...@web.de) changed: What|Removed |Added Kernel Version|5.13.11 |5.13.13 -- You may reply

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Andrey Grodzovsky
Sure then. Andrey On 2021-08-27 2:30 p.m., Christian König wrote: Yeah, that's what I meant with that the start of processing a job is a bit swampy defined. Jobs overload, but we simply don't have another good indicator that a job started except that the previous one completed. It's still

[PATCH] drm: i810: Fix spelling mistake "constext" -> "context"

2021-08-27 Thread Colin King
From: Colin Ian King There is a spelling mistake in a printk message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i810/i810_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c index 9fb4dd6334

[PATCH] drm/amdgpu/swsmu: fix spelling mistake "minimun" -> "minimum"

2021-08-27 Thread Colin King
From: Colin Ian King There are three identical spelling mistakes in dev_err messages. Fix these. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 2 +- drivers/gpu/drm/amd/pm/swsmu/smu13/yellow

Re: [PATCH] drm/sched: fix the bug of time out calculation(v3)

2021-08-27 Thread Christian König
Yeah, that's what I meant with that the start of processing a job is a bit swampy defined. Jobs overload, but we simply don't have another good indicator that a job started except that the previous one completed. It's still better than starting the timer when pushing the job to the ring buff

[pull] amdgpu, amdkfd drm-next-5.15

2021-08-27 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.15. The following changes since commit 90a9266269eb9f71af1f323c33e1dca53527bd22: drm/amdgpu: Cancel delayed work when GFXOFF is disabled (2021-08-20 12:09:44 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/am

Re: [RFC PATCH 0/4] Allow to use DRM fbdev emulation layer with CONFIG_FB disabled

2021-08-27 Thread Daniel Vetter
On Fri, Aug 27, 2021 at 07:50:23PM +0200, Thomas Zimmermann wrote: > Hi > > Am 27.08.21 um 12:00 schrieb Javier Martinez Canillas: > > This patch series splits the fbdev core support in two different Kconfig > > symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to > > be disab

Re: [PATCH 1/2] dma-buf: nuke DMA_FENCE_TRACE macros v2

2021-08-27 Thread Daniel Vetter
On Fri, Aug 27, 2021 at 11:07:58AM +0200, Christian König wrote: > Am 26.08.21 um 10:55 schrieb Daniel Vetter: > > On Tue, Aug 24, 2021 at 10:12:24AM +0200, Christian König wrote: > > > Just a gentle ping. Daniel any more comments on this? > > Still haven't seen a patch set to nuke the sw_sync igt

[PATCH v3 0/4] Various fixes to pass libdrm hotunplug tests

2021-08-27 Thread Andrey Grodzovsky
Bunch of fixes to enable passing hotplug tests i previosly added here[1] with latest code. Once accepted I will enable the tests on libdrm side. [1] - https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/172 v2: Dropping VCE patch since relevant function already fixed in latest code. Moving

[PATCH v3 1/4] drm/ttm: Create pinned list

2021-08-27 Thread Andrey Grodzovsky
This list will be used to capture all non VRAM BOs not on LRU so when device is hot unplugged we can iterate the list and unmap DMA mappings before device is removed. v2: Reanme function to ttm_bo_move_to_pinned v3: Move the pinned list to ttm device Signed-off-by: Andrey Grodzovsky Suggested-by

[PATCH v3 2/4] drm/ttm: Clear all DMA mappings on demand

2021-08-27 Thread Andrey Grodzovsky
Used by drivers supporting hot unplug to handle all DMA IOMMU group related dependencies before the group is removed during device removal and we try to access it after free when last device pointer from user space is dropped. v3: Switch to ttm_bo_get_unless_zerom Iterate bdev for pinned list Swit

[PATCH v3 4/4] drm/amdgpu: Add a UAPI flag for hot plug/unplug

2021-08-27 Thread Andrey Grodzovsky
To support libdrm tests. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 6400259a7c4b..c2fdf67ff551 100644 -

[PATCH v3 3/4] drm/amdgpu: drm/amdgpu: Handle IOMMU enabled case

2021-08-27 Thread Andrey Grodzovsky
Handle all DMA IOMMU group related dependencies before the group is removed and we try to access it after free. v2: Move the actul handling function to TTM Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drive

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-27 Thread Doug Anderson
Hi, On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson wrote: > > +static int dp_parser_find_panel(struct dp_parser *parser) > +{ > + struct device_node *np = parser->pdev->dev.of_node; > + int rc; > + > + rc = drm_of_find_panel_or_bridge(np, 2, 0, &parser->drm_panel, NULL); Why p

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 Nils Tonnätt (nils.tonna...@posteo.de) changed: What|Removed |Added CC||nils.tonna...@pos

Re: [RFC PATCH 0/4] Allow to use DRM fbdev emulation layer with CONFIG_FB disabled

2021-08-27 Thread Javier Martinez Canillas
Hello Daniel and Thomas, On 8/27/21 10:20 PM, Daniel Vetter wrote: > On Fri, Aug 27, 2021 at 07:50:23PM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 27.08.21 um 12:00 schrieb Javier Martinez Canillas: >>> This patch series splits the fbdev core support in two different Kconfig >>> symbols: FB an

Re: drm: simpledrm: fbdev emulation error with CONFIG_DRM_SIMPLEDRM enabled

2021-08-27 Thread Amanoel Dawod
Hi On Thu, Aug 26, 2021, at 2:31 PM, Thomas Zimmermann wrote: > > You said that the resolution is 3840 x 2160, but the attached log says > 1024x768. I guess that the former is the monitor's native resolution and > the latter is the display mode? > Yes, that's the monitor native resolution and

[PATCH 0/2] Update 128b/132b MST Slot Information

2021-08-27 Thread Fangzhi Zuo
128b/132b MST start slot information is not the same as 8b/10b. Update based on encoding format after link detection or topology change. Fangzhi Zuo (2): drm: Update MST First Link Slot Information Based on Encoding Format drm/amdgpu: Example Usage in AMDGPU .../gpu/drm/amd/display/amdgpu_dm

[PATCH 1/2] drm: Update MST First Link Slot Information Based on Encoding Format

2021-08-27 Thread Fangzhi Zuo
8b/10b encoding format requires to reserve the first slot for recording metadata. Real data transmission starts from the second slot, with a total of available 63 slots available. In 128b/132b encoding format, metadata is transmitted separately in LLCP packet before MTP. Real data transmission sta

[PATCH 2/2] drm/amdgpu: Example Usage in AMDGPU

2021-08-27 Thread Fangzhi Zuo
1. Decide MST Link Encoding Cap 2. Update MST First Link Slot Information Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++- .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 10 ++ .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h

[PATCH v7 02/17] mei: pxp: export pavp client to me client bus

2021-08-27 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart Export PAVP client to work with i915 driver, for binding it uses kernel component framework. v2:drop debug prints, refactor match code to match mei_hdcp (Tomas) Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Ro

[PATCH v7 03/17] drm/i915/pxp: define PXP device flag and kconfig

2021-08-27 Thread Daniele Ceraolo Spurio
Ahead of the PXP implementation, define the relevant define flag and kconfig option. v2: flip kconfig default to N. Some machines have IFWIs that do not support PXP, so we need it to be an opt-in until we add support to query the caps from the mei device. Signed-off-by: Daniele Ceraolo Spurio Re

[PATCH v7 10/17] drm/i915/pxp: interfaces for using protected objects

2021-08-27 Thread Daniele Ceraolo Spurio
This api allow user mode to create protected buffers and to mark contexts as making use of such objects. Only when using contexts marked in such a way is the execution guaranteed to work as expected. Contexts can only be marked as using protected content at creation time (i.e. the parameter is imm

[PATCH v7 06/17] drm/i915/pxp: set KCR reg init

2021-08-27 Thread Daniele Ceraolo Spurio
The setting is required by hardware to allow us doing further protection operation such as sending commands to GPU or TEE. The register needs to be re-programmed on resume, so for simplicitly we bundle the programming with the component binding, which is automatically called on resume. Further HW

  1   2   >