Re: [PATCH v2 0/8] drm/bridge: Make panel and bridge probe order consistent

2021-08-09 Thread Jagan Teki
Hi Andrzej, On Wed, Aug 4, 2021 at 7:48 PM a.hajda wrote: > > Hi Maxime, > > I have been busy with other tasks, and I did not follow the list last > time, so sorry for my late response. > > On 28.07.2021 15:32, Maxime Ripard wrote: > > Hi, > > > > We've encountered an issue with the RaspberryPi D

Re: [PATCH v7 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-08-09 Thread 吴勇
On Thu, 2021-08-05 at 15:22 +0200, Dafna Hirschfeld wrote: > > On 30.07.21 04:52, Yong Wu wrote: > > MediaTek IOMMU-SMI diagram is like below. all the consumer connect > > with > > smi-larb, then connect with smi-common. > > > > M4U > > | > > smi-common > > | > >

Re: [PATCH v7 00/12] Clean up "mediatek,larb"

2021-08-09 Thread 吴勇
On Mon, 2021-08-02 at 11:51 +0200, Joerg Roedel wrote: > On Fri, Jul 30, 2021 at 10:52:26AM +0800, Yong Wu wrote: > > .../display/mediatek/mediatek,disp.txt| 9 > > .../bindings/media/mediatek-jpeg-decoder.yaml | 9 > > .../bindings/media/mediatek-jpeg-encoder.yaml | 9 >

Patch "drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled" has been added to the 5.13-stable tree

2021-08-09 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled to the 5.13-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH v7 00/12] Clean up "mediatek,larb"

2021-08-09 Thread j...@8bytes.org
On Mon, Aug 09, 2021 at 08:30:03AM +, Yong Wu (吴勇) wrote: > Thanks very much for your confirm. I will your Ack for iommu part in > the next version. Note that my ack is conditional on the premise that Matthias has reviewed the IOMMU parts. Thanks, Joerg

[Bug 214001] [bisected][regression] After commit "drm/ttm: Initialize debugfs from ttm_global_init()" kernels without debugfs explicitly set to 'allow all' fail to boot

2021-08-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214001 Linux_Chemist (untaintablean...@hotmail.co.uk) changed: What|Removed |Added Component|Video(DRI - non Intel) |Video(Oth

Re: [Letux-kernel] [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders

2021-08-09 Thread H. Nikolaus Schaller
Hi Paul, quick feedback: our HDMI on top compiles fine after fixing 2 merge conflicts, but dos not yet work. Will need some spare time with access to the CI20 board to research the issue, i.e. can not give feedback immediately. BR and thanks, Nikolaus > Am 08.08.2021 um 21:12 schrieb H. Nikolaus

Re: [PATCH 47/64] btrfs: Use memset_after() to clear end of struct

2021-08-09 Thread David Sterba
On Sat, Jul 31, 2021 at 08:25:51AM -0700, Kees Cook wrote: > On Thu, Jul 29, 2021 at 12:33:37PM +0200, David Sterba wrote: > > On Wed, Jul 28, 2021 at 02:56:31PM -0700, Kees Cook wrote: > > > On Wed, Jul 28, 2021 at 11:42:15AM +0200, David Sterba wrote: > > > > On Tue, Jul 27, 2021 at 01:58:38PM -0

Re: [PATCH 04/21] drm/i915/gvt: move the gvt code into kvmgt.ko

2021-08-09 Thread Joonas Lahtinen
Quoting Christoph Hellwig (2021-07-21 18:53:38) > Instead of having an option to build the gvt code into the main i915 > module, just move it into the kvmgt.ko module. This only requires > a new struct with three entries that the main i915 module needs to > request before enabling VGPU passthrough

Re: [PATCH v2 0/8] drm/bridge: Make panel and bridge probe order consistent

2021-08-09 Thread Andrzej Hajda
Hi Jagan, W dniu 09.08.2021 o 10:00, Jagan Teki pisze: > Hi Andrzej, > > On Wed, Aug 4, 2021 at 7:48 PM a.hajda wrote: >> Hi Maxime, >> >> I have been busy with other tasks, and I did not follow the list last >> time, so sorry for my late response. >> >> On 28.07.2021 15:32, Maxime Ripard wrote:

Re: [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled

2021-08-09 Thread Chun-Kuang Hu
Hi, Thomas: Thomas Zimmermann 於 2021年6月25日 週五 下午4:22寫道: > > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in mediatek. > Acked-by: Chun-Kuang Hu > Signed-off-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > Acked-by: Daniel

Re: [PATCH] nouveau: make backlight support non optional

2021-08-09 Thread Jani Nikula
On Sat, 24 Jul 2021, Arnd Bergmann wrote: > On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst wrote: >> >> we use the MXM_WMI in code. We also have to keep arm in mind and not >> break stuff there. So I will try to play around with your changes and >> see how that goes. > > Ok, should find any randcon

Re: [PATCH] drm/mediatek: Implement mmap as GEM object function

2021-08-09 Thread Chun-Kuang Hu
Hi, Thomas: Thomas Zimmermann 於 2021年6月24日 週四 下午5:01寫道: > > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > The respective mediatek functions are being removed. The file_operations > structure fops is now being created

Re: [PATCH] nouveau: make backlight support non optional

2021-08-09 Thread Arnd Bergmann
On Mon, Aug 9, 2021 at 3:20 PM Jani Nikula wrote: > > On Sat, 24 Jul 2021, Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst wrote: > >> > >> we use the MXM_WMI in code. We also have to keep arm in mind and not > >> break stuff there. So I will try to play around with your ch

[PATCH v2] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-09 Thread Imre Deak
Atm the EFI FB platform driver gets a runtime PM reference for the associated GFX PCI device during probing the EFI FB platform device and releases it only when the platform device gets unbound. When fbcon switches to the FB provided by the PCI device's driver (for instance i915/drmfb), the EFI FB

Re: [PATCH 1/3] drm/i915/guc: Fix several issues related to resets / request cancelation

2021-08-09 Thread Daniel Vetter
On Sun, Aug 08, 2021 at 11:07:55AM -0700, Matthew Brost wrote: > Resets are notoriously hard to get fully working and notoriously racey, > especially with selftests / IGTs that do all sorts of wild things that > would be near impossible to hit during normal use cases. Even though > likely impossibl

Re: [Intel-gfx] [PATCH 2/3] drm/i915/selftests: Fix memory corruption in live_lrc_isolation

2021-08-09 Thread Daniel Vetter
On Sun, Aug 08, 2021 at 11:07:56AM -0700, Matthew Brost wrote: > GuC submission has exposed an existing memory corruption in > live_lrc_isolation. We believe that some writes to the watchdog offsets > in the LRC (0x178 & 0x17c) can result in trashing of portions of the > address space. With GuC sub

Re: [Intel-gfx] [PATCH 3/3] drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H

2021-08-09 Thread Daniel Vetter
On Sun, Aug 08, 2021 at 11:07:57AM -0700, Matthew Brost wrote: > While debugging an issue with full GT resets I went down a rabbit hole > thinking the scrubbing of lost G2H wasn't working correctly. This proved > to be incorrect as this was working just fine but this chase inspired me > to write a

Re: [PATCH v2 5/5] drm/mediatek: Add support for main DDP path on MT8167

2021-08-09 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > Add the main (DSI) drm display path for MT8167. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Fabie

Re: linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-09 Thread Daniel Vetter
On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahtinen wrote: > Hi Matt, > > Always use the dim tooling when applying patches, it will do the right > thing with regards to adding the S-o-b. fd.o server rejects any pushes that haven't been done by dim, so how did this get through? Matt, can you

Re: [PATCH v2 2/5] dt-bindings: display: mediatek: dsi: add documentation for MT8167 SoC

2021-08-09 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > Add binding documentation for the MT8167 SoC. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Fabien

Re: [RFC v1 0/4] drm: Add support for DRM_CAP_DEFERRED_OUT_FENCE capability

2021-08-09 Thread Daniel Vetter
On Fri, Aug 06, 2021 at 07:27:13AM +, Kasireddy, Vivek wrote: > Hi Daniel, > > > > > > >>> The solution: > > > > > >>> - To ensure full framerate, the Guest compositor has to start > > > > > >>> it's repaint cycle > > > > (including > > > > > >>> the 9 ms wait) when the Host compositor sends

Re: [Intel-gfx] [PATCH] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-09 Thread Daniel Vetter
On Sat, Aug 07, 2021 at 06:21:10PM +0300, Imre Deak wrote: > On Thu, Aug 05, 2021 at 12:23:21AM +0200, Daniel Vetter wrote: > > On Mon, Aug 02, 2021 at 04:35:51PM +0300, Imre Deak wrote: > > > Atm the EFI FB driver gets a runtime PM reference for the associated GFX > > > PCI device during driver pr

Re: [PATCH] drm/mediatek: Test component initialization earlier in the function mtk_drm_crtc_create

2021-08-09 Thread Chun-Kuang Hu
Hi, Dafna: Dafna Hirschfeld 於 2021年7月13日 週二 上午2:12寫道: > > The initialization is currently tested in a later stage in > the function for no reason. > In addition, the test '!comp' will never fail since comp is > set with the '&' operator. Instead, test if a comp was not > initialized by testing "!

Re: [PATCH 10/46] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:07PM -0700, Matthew Brost wrote: > Taking a PM reference to prevent intel_gt_wait_for_idle from short > circuiting while a scheduling of user context could be enabled. > > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/i915/Makefile | 1 + > .

Re: [Intel-gfx] [PATCH 11/46] drm/i915/guc: Don't call switch_to_kernel_context with GuC submission

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:08PM -0700, Matthew Brost wrote: > Calling switch_to_kernel_context isn't needed if the engine PM reference > is taken while all contexts are pinned. By not calling > switch_to_kernel_context we save on issuing a request to the engine. > > Signed-off-by: Matthew Brost

Re: [PATCH 13/46] drm/i915: Add logical engine mapping

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:10PM -0700, Matthew Brost wrote: > Add logical engine mapping. This is required for split-frame, as > workloads need to be placed on engines in a logically contiguous manner. > > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 60

Re: [PATCH 14/46] drm/i915: Expose logical engine instance to user

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:11PM -0700, Matthew Brost wrote: > Expose logical engine instance to user via query engine info IOCTL. This > is required for split-frame workloads as these needs to be placed on > engines in a logically contiguous order. The logical mapping can change > based on fusin

Re: [PATCH v6 4/7] drm/mediatek: adjust to the alphabetic order for mediatek-drm

2021-08-09 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月6日 週五 上午4:52寫道: > > 1. Adjust to the alphabetic order for the define, function, struct >and array in mediatek-drm driver > 2. Remove the unsed define in mtk_drm_ddp_comp.c Separate the 2nd part to another patch. > > Signed-off-by: jason-jh.lin > --- > driv

Re: [Intel-gfx] [PATCH 15/46] drm/i915/guc: Introduce context parent-child relationship

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:12PM -0700, Matthew Brost wrote: > Introduce context parent-child relationship. Once this relationship is > created all pinning / unpinning operations are directed to the parent > context. The parent context is responsible for pinning all of its' > children and itself.

Re: [Intel-gfx] [PATCH 15/46] drm/i915/guc: Introduce context parent-child relationship

2021-08-09 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 04:37:55PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:12PM -0700, Matthew Brost wrote: > > Introduce context parent-child relationship. Once this relationship is > > created all pinning / unpinning operations are directed to the parent > > context. The paren

Re: [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift

2021-08-09 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年8月8日 週日 下午9:41寫道: > > The bridge chip ANX7625 requires the packets on lanes aligned at the end, > or ANX7625 will shift the screen. In anx7625_attach_dsi(), it call mipi_dsi_attach(), and it call into mtk_dsi_host_attach(). I would like to pass this information from a

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Akhil P Oommen
On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: Hi Rob, Akhil, On 29/07/2021 21:53, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly w

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Will Deacon
On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wrote: > On Mon, Aug 2, 2021 at 8:14 AM Will Deacon wrote: > > > > On Mon, Aug 02, 2021 at 08:08:07AM -0700, Rob Clark wrote: > > > On Mon, Aug 2, 2021 at 3:55 AM Will Deacon wrote: > > > > > > > > On Thu, Jul 29, 2021 at 10:08:22AM +0530, Sai P

[GIT PULL] mediatek drm fixes for 5.14

2021-08-09 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Fix dpi bridge bug. 2. Fix cursor plane no update. Regards, Chun-Kuang. The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3: Linux 5.14-rc1 (2021-07-11 15:07:40 -0700) are available in the Git repository at: https://git.kernel.

Re: [Intel-gfx] [PATCH 16/46] drm/i915/guc: Implement GuC parent-child context pin / unpin functions

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:13PM -0700, Matthew Brost wrote: > Implement GuC parent-child context pin / unpin functions in which in any > contexts in the relationship are pinned all the contexts are pinned. The > parent owns most of the pinning / unpinning process and the children > direct any pi

Re: [PATCH 19/46] drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_ids

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:16PM -0700, Matthew Brost wrote: > Assign contexts in parent-child relationship consecutive guc_ids. This > is accomplished by partitioning guc_id space between ones that need to > be consecutive (1/16 available guc_ids) and ones that do not (15/16 of > available guc_i

Re: [PATCH 20/46] drm/i915/guc: Add hang check to GuC submit engine

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:17PM -0700, Matthew Brost wrote: > The heartbeat uses a single instance of a GuC submit engine (GSE) to do > the hang check. As such if a different GSE's state machine hangs, the > heartbeat cannot detect this hang. Add timer to each GSE which in turn > can disable all

Re: [Intel-gfx] [PATCH 21/46] drm/i915/guc: Add guc_child_context_destroy

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:18PM -0700, Matthew Brost wrote: > Since child contexts do not own the guc_ids or GuC context registration, > child contexts can simply be freed on destroy. Add > guc_child_context_destroy context operation to do this. > > Signed-off-by: Matthew Brost > --- > driver

Re: [PATCH 1/2] dt-bindings: add bindings for the Sharp LS060T1SX01 panel

2021-08-09 Thread Rob Herring
On Sun, 08 Aug 2021 06:50:52 +0300, Dmitry Baryshkov wrote: > Add devicetree bindings for the Sharp LS060T1SX01 6.0" FullHD panel > using NT35695 driver. This panel can be found i.e. in the Dragonboard > Display Adapter bundle. > > Signed-off-by: Dmitry Baryshkov > --- > .../display/panel/sharp,

Re: [PATCH] dma-buf: Fix a few typos in dma-buf documentation

2021-08-09 Thread Randy Dunlap
On 8/9/21 5:22 AM, Gal Pressman wrote: Fix a few typos in the documentation: - Remove an extraneous 'or' - 'unpins' -> 'unpin' - 'braket' -> 'bracket' - 'mappinsg' -> 'mappings' - 'fullfills' -> 'fulfills' Signed-off-by: Gal Pressman Reviewed-by: Randy Dunlap Thanks. --- include/linux/d

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: > > On 8/8/2021 10:22 PM, Rob Clark wrote: > > On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly > > wrote: > >> > >> > >> > >> On 07/08/2021 21:04, Rob Clark wrote: > >>> On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly > >>> wrote: > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Caleb Connolly
On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: Hi Rob

Re: linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-09 Thread Matt Roper
On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: > On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahtinen wrote: > > Hi Matt, > > > > Always use the dim tooling when applying patches, it will do the right > > thing with regards to adding the S-o-b. > > fd.o server rejects any pus

Re: [Letux-kernel] [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders

2021-08-09 Thread Paul Cercueil
Hi Nikolaus, Le lun., août 9 2021 at 13:14:03 +0200, H. Nikolaus Schaller a écrit : Hi Paul, quick feedback: our HDMI on top compiles fine after fixing 2 merge conflicts, but dos not yet work. Will need some spare time with access to the CI20 board to research the issue, i.e. can not give fe

Re: [Intel-gfx] [PATCH 23/46] drm/i915/guc: Insert submit fences between requests in parent-child relationship

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:20PM -0700, Matthew Brost wrote: > The GuC must receive requests in the order submitted for contexts in a > parent-child relationship to function correctly. To ensure this, insert > a submit fence between the current request and last request submitted > for requests /

Re: [PATCH 25/46] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:22PM -0700, Matthew Brost wrote: > Display the workqueue status in debugfs for GuC contexts that are in > parent-child relationship. > > Signed-off-by: Matthew Brost > --- > .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 +-- > 1 file changed, 39

Re: [PATCH 26/46] drm/i915: Connect UAPI to GuC multi-lrc interface

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:23PM -0700, Matthew Brost wrote: > Introduce 'set parallel submit' extension to connect UAPI to GuC > multi-lrc interface. Kernel doc in new uAPI should explain it all. > > Cc: Tvrtko Ursulin > Signed-off-by: Matthew Brost UMD merge request link + igt patchwork lin

Re: [Intel-gfx] [PATCH 23/46] drm/i915/guc: Insert submit fences between requests in parent-child relationship

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 06:32:42PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:20PM -0700, Matthew Brost wrote: > > The GuC must receive requests in the order submitted for contexts in a > > parent-child relationship to function correctly. To ensure this, insert > > a submit fence b

Re: [PATCH 39/46] drm/i915: Force parallel contexts to use copy engine for reloc

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:36PM -0700, Matthew Brost wrote: > Submitting to a subset of hardware contexts is not allowed, so use the > copy engine for GPU relocations when using a parallel context. > > Signed-off-by: Matthew Brost Luckily I just pushed the patches to delete all this, so you c

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > > On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wrote: > > On Mon, Aug 2, 2021 at 8:14 AM Will Deacon wrote: > > > > > > On Mon, Aug 02, 2021 at 08:08:07AM -0700, Rob Clark wrote: > > > > On Mon, Aug 2, 2021 at 3:55 AM Will Deacon wrote:

Re: [PATCH 40/46] drm/i915: Multi-batch execbuffer2

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:37PM -0700, Matthew Brost wrote: > For contexts with width set to two or more, we add a mode to execbuf2 > which implies there are N batch buffers in the buffer list, each of > which will be sent to one of the engines from the engine map array > (I915_CONTEXT_PARAM_ENG

Re: [Intel-gfx] [PATCH 23/46] drm/i915/guc: Insert submit fences between requests in parent-child relationship

2021-08-09 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 04:39:48PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 06:32:42PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:20PM -0700, Matthew Brost wrote: > > > The GuC must receive requests in the order submitted for contexts in a > > > parent-child relation

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Will Deacon
On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > > On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wrote: > > > On Mon, Aug 2, 2021 at 8:14 AM Will Deacon wrote: > > > > On Mon, Aug 02, 2021 at 08:08:07AM -0700, Rob Clark wrote:

Re: [Intel-gfx] [PATCH 41/46] drm/i915: Eliminate unnecessary VMA calls for multi-BB submission

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:38PM -0700, Matthew Brost wrote: > Certain VMA functions in the execbuf IOCTL only need to be called on > first or last BB of a multi-BB submission. eb_relocate() on the first eb_relocate should be outright disallowed on multi lrc execbuf ioctl. There's no users of th

Re: [Intel-gfx] [PATCH 41/46] drm/i915: Eliminate unnecessary VMA calls for multi-BB submission

2021-08-09 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:07:44PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:38PM -0700, Matthew Brost wrote: > > Certain VMA functions in the execbuf IOCTL only need to be called on > > first or last BB of a multi-BB submission. eb_relocate() on the first > > eb_relocate should

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > > On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > > > On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wrote: > > > > On Mon, Aug 2, 2021 at 8:14 AM Will Deacon wrote: > > >

Re: [Intel-gfx] [PATCH 46/46] drm/i915/guc: Add delay before disabling scheduling on contexts

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:43PM -0700, Matthew Brost wrote: > Some workloads use lots of contexts that continually pin / unpin > contexts. With GuC submission an unpin translates to a schedule disable > H2G which puts pressure on both the i915 and GuC. A schedule disable can > also block future

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Akhil P Oommen
On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Will Deacon
On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > > > > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > > > On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > > > > On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wr

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Sai Prakash Ranjan
On 2021-08-09 23:10, Will Deacon wrote: On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > > On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > > > On Mon, Aug 02, 2021

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen wrote: > > On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > > > > > On 09/08/2021 17:12, Rob Clark wrote: > >> On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen > >> wrote: > >>> > >>> On 8/8/2021 10:22 PM, Rob Clark wrote: > On Sun, Aug 8, 2021 at 7:

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 10:47 AM Sai Prakash Ranjan wrote: > > On 2021-08-09 23:10, Will Deacon wrote: > > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > >> On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > >> > > >> > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > >

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Sai Prakash Ranjan
On 2021-08-09 23:37, Rob Clark wrote: On Mon, Aug 9, 2021 at 10:47 AM Sai Prakash Ranjan wrote: On 2021-08-09 23:10, Will Deacon wrote: > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: >> On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: >> > >> > On Mon, Aug 09, 2021 at 09:57:08

Re: [PATCH 10/46] drm/i915/guc: Take engine PM when a context is pinned with GuC submission

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 04:23:42PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:07PM -0700, Matthew Brost wrote: > > Taking a PM reference to prevent intel_gt_wait_for_idle from short > > circuiting while a scheduling of user context could be enabled. > > > > Signed-off-by: Matthew

Re: [Intel-gfx] [PATCH 11/46] drm/i915/guc: Don't call switch_to_kernel_context with GuC submission

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 04:27:01PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:08PM -0700, Matthew Brost wrote: > > Calling switch_to_kernel_context isn't needed if the engine PM reference > > is taken while all contexts are pinned. By not calling > > switch_to_kernel_context we sav

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 11:11 AM Sai Prakash Ranjan wrote: > > On 2021-08-09 23:37, Rob Clark wrote: > > On Mon, Aug 9, 2021 at 10:47 AM Sai Prakash Ranjan > > wrote: > >> > >> On 2021-08-09 23:10, Will Deacon wrote: > >> > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > >> >> On Mon,

Re: [PATCH] drm/amd/display: use do-while-0 for DC_TRACE_LEVEL_MESSAGE()

2021-08-09 Thread Alex Deucher
On Sun, Aug 8, 2021 at 10:52 PM Randy Dunlap wrote: > > Building with W=1 complains about an empty 'else' statement, so use the > usual do-nothing-while-0 loop to quieten this warning. > > ../drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:53: warning: > suggest braces around empty bo

Re: [PATCH] drm/amdgpu: fix kernel-doc warnings on non-kernel-doc comments

2021-08-09 Thread Alex Deucher
On Sat, Aug 7, 2021 at 7:38 PM Randy Dunlap wrote: > > Don't use "begin kernel-doc notation" (/**) for comments that are > not kernel-doc. This eliminates warnings reported by the 0day bot. > > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:89: warning: This comment starts with > '/**', but isn't a kern

Re: [PATCH 13/46] drm/i915: Add logical engine mapping

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 04:28:04PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:10PM -0700, Matthew Brost wrote: > > Add logical engine mapping. This is required for split-frame, as > > workloads need to be placed on engines in a logically contiguous manner. > > > > Signed-off-by: M

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-09 Thread Sai Prakash Ranjan
On 2021-08-10 00:00, Rob Clark wrote: On Mon, Aug 9, 2021 at 11:11 AM Sai Prakash Ranjan wrote: On 2021-08-09 23:37, Rob Clark wrote: > On Mon, Aug 9, 2021 at 10:47 AM Sai Prakash Ranjan > wrote: >> >> On 2021-08-09 23:10, Will Deacon wrote: >> > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob

Re: [PATCH 14/46] drm/i915: Expose logical engine instance to user

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 04:30:06PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:11PM -0700, Matthew Brost wrote: > > Expose logical engine instance to user via query engine info IOCTL. This > > is required for split-frame workloads as these needs to be placed on > > engines in a logi

Re: [PATCH] drm/amdgpu: Removed unnecessary if statement

2021-08-09 Thread Alex Deucher
On Mon, Aug 9, 2021 at 9:59 AM Sergio Miguéns Iglesias wrote: > > There was an "if" statement that did nothing so it was removed. > > Signed-off-by: Sergio Miguéns Iglesias Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 --- > 1 file changed, 3 deletions(-) > > diff

Re: [Intel-gfx] [PATCH 15/46] drm/i915/guc: Introduce context parent-child relationship

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 04:37:55PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:12PM -0700, Matthew Brost wrote: > > Introduce context parent-child relationship. Once this relationship is > > created all pinning / unpinning operations are directed to the parent > > context. The paren

Re: [Intel-gfx] [PATCH 15/46] drm/i915/guc: Introduce context parent-child relationship

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 04:40:11PM +0200, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 04:37:55PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:12PM -0700, Matthew Brost wrote: > > > Introduce context parent-child relationship. Once this relationship is > > > created all pinning /

Re: [PATCH] drm/i915: Release ctx->syncobj on final put, not on ctx close

2021-08-09 Thread Daniel Vetter
On Sun, Aug 8, 2021 at 2:56 AM Jason Ekstrand wrote: > > On August 6, 2021 15:18:59 Daniel Vetter wrote: > >> gem context refcounting is another exercise in least locking design it >> seems, where most things get destroyed upon context closure (which can >> race with anything really). Only the ac

[PATCH v2 0/2] Add support for Sharp LS060T1SX01 panel

2021-08-09 Thread Dmitry Baryshkov
Add driver to support Sharp LS06T1SX01 6.0" FullHD panel found e.g. in the kwaek.ca Dragonboard Display Adapter Bundle. Changes since v1: - Fix the id in the schema file Dmitry Baryshkov (2): dt-bindings: add bindings for the

[PATCH v2 2/2] drm/panel: Add support for Sharp LS060T1SX01 panel

2021-08-09 Thread Dmitry Baryshkov
Add driver to support Sharp LS06T1SX01 FullHD panel. The panel uses nt35695 driver IC. For example this LCD module can be found in the kwaek.ca Dragonboard Display Adapter Bundle. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Mak

[PATCH v2 1/2] dt-bindings: add bindings for the Sharp LS060T1SX01 panel

2021-08-09 Thread Dmitry Baryshkov
Add devicetree bindings for the Sharp LS060T1SX01 6.0" FullHD panel using NT35695 driver. This panel can be found i.e. in the Dragonboard Display Adapter bundle. Signed-off-by: Dmitry Baryshkov --- .../display/panel/sharp,ls060t1sx01.yaml | 51 +++ 1 file changed, 51 inserti

Re: [Intel-gfx] [PATCH 16/46] drm/i915/guc: Implement GuC parent-child context pin / unpin functions

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 05:17:34PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:13PM -0700, Matthew Brost wrote: > > Implement GuC parent-child context pin / unpin functions in which in any > > contexts in the relationship are pinned all the contexts are pinned. The > > parent owns m

Re: [PATCH v2 0/9] PCI/VGA: Rework default VGA device selection

2021-08-09 Thread Bjorn Helgaas
On Tue, Aug 03, 2021 at 12:06:44PM -0500, Bjorn Helgaas wrote: > On Sat, Jul 24, 2021 at 05:30:02PM +0800, Huacai Chen wrote: > > Hi, Bjorn, > > > > On Sat, Jul 24, 2021 at 8:10 AM Bjorn Helgaas wrote: > > > > > > On Fri, Jul 23, 2021 at 05:53:36PM +0800, Huacai Chen wrote: > > > > Hi, Bjorn, > >

Re: [PATCH 19/46] drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_ids

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 05:31:38PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:16PM -0700, Matthew Brost wrote: > > Assign contexts in parent-child relationship consecutive guc_ids. This > > is accomplished by partitioning guc_id space between ones that need to > > be consecutive (1

Re: [PATCH 20/46] drm/i915/guc: Add hang check to GuC submit engine

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 05:35:25PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:17PM -0700, Matthew Brost wrote: > > The heartbeat uses a single instance of a GuC submit engine (GSE) to do > > the hang check. As such if a different GSE's state machine hangs, the > > heartbeat cannot

Re: [Intel-gfx] [PATCH 21/46] drm/i915/guc: Add guc_child_context_destroy

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 05:36:12PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:18PM -0700, Matthew Brost wrote: > > Since child contexts do not own the guc_ids or GuC context registration, > > child contexts can simply be freed on destroy. Add > > guc_child_context_destroy context o

Re: [PATCH 25/46] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 06:36:44PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:22PM -0700, Matthew Brost wrote: > > Display the workqueue status in debugfs for GuC contexts that are in > > parent-child relationship. > > > > Signed-off-by: Matthew Brost > > --- > > .../gpu/drm/i91

Re: [Intel-gfx] [PATCH 46/46] drm/i915/guc: Add delay before disabling scheduling on contexts

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 07:17:27PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:43PM -0700, Matthew Brost wrote: > > Some workloads use lots of contexts that continually pin / unpin > > contexts. With GuC submission an unpin translates to a schedule disable > > H2G which puts pressur

Re: [PATCH 1/3] drm/i915/guc: Fix several issues related to resets / request cancelation

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 03:35:26PM +0200, Daniel Vetter wrote: > On Sun, Aug 08, 2021 at 11:07:55AM -0700, Matthew Brost wrote: > > Resets are notoriously hard to get fully working and notoriously racey, > > especially with selftests / IGTs that do all sorts of wild things that > > would be near im

Re: [Intel-gfx] [PATCH 2/3] drm/i915/selftests: Fix memory corruption in live_lrc_isolation

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 03:38:38PM +0200, Daniel Vetter wrote: > On Sun, Aug 08, 2021 at 11:07:56AM -0700, Matthew Brost wrote: > > GuC submission has exposed an existing memory corruption in > > live_lrc_isolation. We believe that some writes to the watchdog offsets > > in the LRC (0x178 & 0x17c)

Re: [Intel-gfx] [PATCH 3/3] drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 04:03:28PM +0200, Daniel Vetter wrote: > On Sun, Aug 08, 2021 at 11:07:57AM -0700, Matthew Brost wrote: > > While debugging an issue with full GT resets I went down a rabbit hole > > thinking the scrubbing of lost G2H wasn't working correctly. This proved > > to be incorrect

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Caleb Connolly
On 09/08/2021 18:58, Rob Clark wrote: On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 202

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 1:35 PM Caleb Connolly wrote: > > > > On 09/08/2021 18:58, Rob Clark wrote: > > On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen > > wrote: > >> > >> On 8/9/2021 9:48 PM, Caleb Connolly wrote: > >>> > >>> > >>> On 09/08/2021 17:12, Rob Clark wrote: > On Mon, Aug 9, 2021

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

2021-08-09 Thread Tom Lendacky
On 7/30/21 5:34 PM, Sean Christopherson wrote: > On Tue, Jul 27, 2021, Tom Lendacky wrote: >> @@ -451,7 +450,7 @@ void __init mem_encrypt_free_decrypted_mem(void) >> * The unused memory range was mapped decrypted, change the encryption >> * attribute from decrypted to encrypted before f

Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

2021-08-09 Thread Tom Lendacky
On 8/2/21 5:45 AM, Joerg Roedel wrote: > On Tue, Jul 27, 2021 at 05:26:09PM -0500, Tom Lendacky wrote: >> @@ -48,7 +47,7 @@ static void sme_sev_setup_real_mode(struct >> trampoline_header *th) >> if (prot_guest_has(PATTR_HOST_MEM_ENCRYPT)) >> th->flags |= TH_FLAGS_SME_ACTIVE; >>

[PATCH] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-09 Thread Kuogee Hsieh
Add drm debug logs to dp_pm_resume and dp_pm_suspend to help debug suspend/resume issues. Fixes: 355ab7428f09 ("drm/msm/dp: add debug logs to dp_pm_resume/suspend") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 13 + 1 file changed, 13 insertions(+) diff --gi

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

2021-08-09 Thread Tom Lendacky
On 8/2/21 7:42 AM, Christophe Leroy wrote: > > > Le 28/07/2021 à 00:26, Tom Lendacky a écrit : >> Replace occurrences of mem_encrypt_active() with calls to prot_guest_has() >> with the PATTR_MEM_ENCRYPT attribute. > > > What about > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2

Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

2021-08-09 Thread Kuppuswamy, Sathyanarayanan
On 8/9/21 2:59 PM, Tom Lendacky wrote: Not sure how TDX will handle AP booting, are you sure it needs this special setup as well? Otherwise a check for SEV-ES would be better instead of the generic PATTR_GUEST_PROT_STATE. Yes, I'm not sure either. I figure that change can be made, if needed,

Re: [PATCH 00/11] Implement generic prot_guest_has() helper function

2021-08-09 Thread Tom Lendacky
On 8/8/21 8:41 PM, Kuppuswamy, Sathyanarayanan wrote: > Hi Tom, > > On 7/27/21 3:26 PM, Tom Lendacky wrote: >> This patch series provides a generic helper function, prot_guest_has(), >> to replace the sme_active(), sev_active(), sev_es_active() and >> mem_encrypt_active() functions. >> >> It is ex

Re: [PATCH v2 0/6] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-08-09 Thread Doug Anderson
Hi, On Tue, Aug 3, 2021 at 1:41 PM Sam Ravnborg wrote: > > Hi Douglas, > > On Fri, Jul 30, 2021 at 02:26:19PM -0700, Douglas Anderson wrote: > > The goal of this patch series is to move away from hardcoding exact > > eDP panels in device tree files. As discussed in the various patches > > in this

Re: [PATCH v2 1/6] dt-bindings: drm/panel-simple: Introduce generic eDP panels

2021-08-09 Thread Doug Anderson
Hi, On Mon, Aug 2, 2021 at 6:39 AM Rob Herring wrote: > > On Fri, 30 Jul 2021 14:26:20 -0700, Douglas Anderson wrote: > > eDP panels generally contain almost everything needed to control them > > in their EDID. This comes from their DP heritage were a computer needs > > to be able to properly con

[PATCH] drm/amdgpu: Removed unnecessary if statement

2021-08-09 Thread Sergio Miguéns Iglesias
There was an "if" statement that did nothing so it was removed. Signed-off-by: Sergio Miguéns Iglesias --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c index 09b048647

  1   2   >