Re: [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-29 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 04:37:22PM +0200, Peter Zijlstra wrote: > On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: > > > Inside drm_is_current_master, using the outer drm_device.master_mutex > > > to protect re

Re: [PATCH 10/14] drm/tidss: Convert to Linux IRQ interfaces

2021-07-29 Thread Tomi Valkeinen
On 27/07/2021 21:27, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmer

Re: [RFC 1/4] dma-fence: Add deadline awareness

2021-07-29 Thread Daniel Vetter
On Wed, Jul 28, 2021 at 10:58:51AM -0700, Rob Clark wrote: > On Wed, Jul 28, 2021 at 10:23 AM Christian König > wrote: > > > > > > > > Am 28.07.21 um 17:15 schrieb Rob Clark: > > > On Wed, Jul 28, 2021 at 4:37 AM Christian König > > > wrote: > > >> Am 28.07.21 um 09:03 schrieb Christian König: >

[PATCH 2/3] dma-buf: nuke DMA_FENCE_TRACE macros

2021-07-29 Thread Christian König
Only the DRM GPU scheduler, radeon and amdgpu where using them and they depend on a non existing config option to actually emit some code. Nuke them and clean up the dma_fence_signal* return value. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence.c | 44 +--

[PATCH 3/3] dma-buf: nuke SW_SYNC debugfs files

2021-07-29 Thread Christian König
As we now knew controlling dma_fence synchronization from userspace is extremely dangerous and can not only deadlock drivers but trivially also the whole kernel memory management. Entirely remove this option. We now have in kernel unit tests to exercise the dma_fence framework and it's containers.

[PATCH 1/3] dma-buf: nuke seqno-fence

2021-07-29 Thread Christian König
Entirely unused. Signed-off-by: Christian König --- drivers/dma-buf/Makefile | 2 +- drivers/dma-buf/seqno-fence.c | 71 -- include/linux/seqno-fence.h | 109 -- 3 files changed, 1 insertion(+), 181 deletions(-) delete mode 100644 dr

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Daniel Vetter
On Wed, Jul 28, 2021 at 08:34:13AM -0700, Rob Clark wrote: > On Wed, Jul 28, 2021 at 6:24 AM Michel Dänzer wrote: > > > > On 2021-07-28 3:13 p.m., Christian König wrote: > > > Am 28.07.21 um 15:08 schrieb Michel Dänzer: > > >> On 2021-07-28 1:36 p.m., Christian König wrote: > > >>> Am 27.07.21 um

Re: [PATCH v3] drm: clarify usage of drm leases

2021-07-29 Thread Daniel Vetter
On Wed, Jul 28, 2021 at 06:27:39PM +0800, Desmond Cheong Zhi Xi wrote: > We make the following changes to the documentation of drm leases to > make it easier to reason about their usage. In particular, we clarify > the lifetime and locking rules of lease fields in drm_master: > > 1. Make it clear

Re: [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-29 Thread Daniel Vetter
On Wed, Jul 28, 2021 at 01:52:42PM -0700, Rob Clark wrote: > Hi Dave & Daniel, > > An early pull for v5.15 (there'll be more coming in a week or two), > consisting of the drm/scheduler conversion and a couple other small > series that one was based one. Mostly sending this now because IIUC > danv

Re: [PATCH 2/3] dma-buf: nuke DMA_FENCE_TRACE macros

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 09:03:29AM +0200, Christian König wrote: > Only the DRM GPU scheduler, radeon and amdgpu where using them and they depend > on a non existing config option to actually emit some code. > > Nuke them and clean up the dma_fence_signal* return value. > > Signed-off-by: Christi

Re: [PATCH 3/3] dma-buf: nuke SW_SYNC debugfs files

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 09:03:30AM +0200, Christian König wrote: > As we now knew controlling dma_fence synchronization from userspace is > extremely dangerous and can not only deadlock drivers but trivially also the > whole kernel memory management. > > Entirely remove this option. We now have in

Re: [PATCH 1/3] dma-buf: nuke seqno-fence

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 09:03:28AM +0200, Christian König wrote: > Entirely unused. > > Signed-off-by: Christian König Acked-by: Daniel Vetter > --- > drivers/dma-buf/Makefile | 2 +- > drivers/dma-buf/seqno-fence.c | 71 -- > include/linux/seqno-fence.h | 109 --

Re: [PATCH 2/3] dma-buf: nuke DMA_FENCE_TRACE macros

2021-07-29 Thread Christian König
Am 29.07.21 um 09:22 schrieb Daniel Vetter: On Thu, Jul 29, 2021 at 09:03:29AM +0200, Christian König wrote: Only the DRM GPU scheduler, radeon and amdgpu where using them and they depend on a non existing config option to actually emit some code. Nuke them and clean up the dma_fence_signal*

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 09:20:22AM +0200, Christoph Hellwig wrote: > On Wed, Jul 28, 2021 at 02:59:25PM -0300, Jason Gunthorpe wrote: > > On Wed, Jul 28, 2021 at 01:38:58PM +, Wang, Zhi A wrote: > > > > > I guess those APIs you were talking about are KVM-only. For other > > > hypervisors, e.g.

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Michel Dänzer
On 2021-07-28 4:30 p.m., Christian König wrote: > Am 28.07.21 um 15:57 schrieb Pekka Paalanen: >> On Wed, 28 Jul 2021 15:31:41 +0200 >> Christian König wrote: >> >>> Am 28.07.21 um 15:24 schrieb Michel Dänzer: On 2021-07-28 3:13 p.m., Christian König wrote: > Am 28.07.21 um 15:08 schrieb

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Michel Dänzer
On 2021-07-29 9:09 a.m., Daniel Vetter wrote: > On Wed, Jul 28, 2021 at 08:34:13AM -0700, Rob Clark wrote: >> On Wed, Jul 28, 2021 at 6:24 AM Michel Dänzer wrote: >>> On 2021-07-28 3:13 p.m., Christian König wrote: Am 28.07.21 um 15:08 schrieb Michel Dänzer: > On 2021-07-28 1:36 p.m., Chr

[PATCH] drm/amd/display: Fix typo in comments

2021-07-29 Thread Cai Huoqing
Remove the repeated word 'the' from comments Signed-off-by: Cai Huoqing --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- .../gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c | 2 +- .../drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c | 2 +- .../gpu/dr

Re: refactor the i915 GVT support

2021-07-29 Thread Wang, Zhi A
On 7/28/2021 8:59 PM, Jason Gunthorpe wrote: > On Wed, Jul 28, 2021 at 01:38:58PM +, Wang, Zhi A wrote: > >> I guess those APIs you were talking about are KVM-only. For other >> hypervisors, e.g. Xen, ARCN cannot use the APIs you mentioned. Not >> sure if you have already noticed that VFIO is K

[PATCH] gpu/drm/radeon: Fix typo in comments

2021-07-29 Thread Cai Huoqing
Remove the repeated word 'the' from comments Signed-off-by: Cai Huoqing --- drivers/gpu/drm/radeon/atombios.h | 4 ++-- drivers/gpu/drm/radeon/r300_reg.h | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 2 +- drivers/gpu/drm/radeon/radeon_fence.c | 2 +- drivers/gpu/drm/radeon/radeon_

Re: [PATCH 01/64] media: omap3isp: Extract struct group for memcpy() region

2021-07-29 Thread Dan Carpenter
On Thu, Jul 29, 2021 at 07:56:27AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 28, 2021 at 11:37:30PM +0200, David Sterba wrote: > > On Wed, Jul 28, 2021 at 02:37:20PM -0700, Bart Van Assche wrote: > > > On 7/28/21 2:14 AM, Dan Carpenter wrote: > > > > On Wed, Jul 28, 2021 at 10:59:22AM +0200, D

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Pekka Paalanen
On Wed, 28 Jul 2021 16:30:13 +0200 Christian König wrote: > Am 28.07.21 um 15:57 schrieb Pekka Paalanen: > > On Wed, 28 Jul 2021 15:31:41 +0200 > > Christian König wrote: > > > >> Am 28.07.21 um 15:24 schrieb Michel Dänzer: > >>> On 2021-07-28 3:13 p.m., Christian König wrote: > Am 28

Re: [PATCH 02/64] mac80211: Use flex-array for radiotap header bitmap

2021-07-29 Thread Dan Carpenter
On Wed, Jul 28, 2021 at 04:33:18PM -0700, Kees Cook wrote: > > Ah-ha, got it: > Thanks, Kees! Nice! regards, dan carpenter

[RFC v1 0/4] drm: Add support for DRM_CAP_DEFERRED_OUT_FENCE capability

2021-07-29 Thread Vivek Kasireddy
By separating the OUT_FENCE signalling from pageflip completion allows a Guest compositor to start a new repaint cycle with a new buffer instead of waiting for the old buffer to be free. This work is based on the idea/suggestion from Simon and Pekka. This capability can be a solution for this is

[RFC v1 1/4] drm: Add a capability flag to support deferred out_fence signalling

2021-07-29 Thread Vivek Kasireddy
If a driver supports this capability, it means that it will take ownership of signalling the OUT_FENCE from drm core. Therefore, the OUT_FENCE will no longer be signalled at pageflip completion time but instead at a later time as chosen by the driver. This capability may only be relevant for VKMS

[RFC v1 4/4] drm/virtio: Probe and implement VIRTIO_GPU_F_OUT_FENCE feature

2021-07-29 Thread Vivek Kasireddy
If this feature is available, the virtio-gpu driver will take ownership of signalling the OUT_FENCE instead of drm core. As a result, the OUT_FENCE will no longer be signalled along with pageflip completion but at a later time. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- drivers/gpu/dr

[RFC v1 3/4] drm/virtio: Add VIRTIO_GPU_CMD_RESOURCE_OUT_FENCE cmd

2021-07-29 Thread Vivek Kasireddy
This implements the hypercall interface for the resource_out_fence command. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 drivers/gpu/drm/virtio/virtgpu_vq.c | 17 + 2 files changed, 21 insertions(+) diff --git a/drivers/g

[RFC v1 2/4] virtio-gpu uapi: Add VIRTIO_GPU_F_OUT_FENCE feature

2021-07-29 Thread Vivek Kasireddy
This feature enables the Guest to wait to know when a resource is completely consumed by the Host. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/uapi/linux/virtio_gpu.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/linux/virtio_gpu.h b/include/uap

Re: [PATCH 3/3] dma-buf: nuke SW_SYNC debugfs files

2021-07-29 Thread Christian König
Am 29.07.21 um 09:23 schrieb Daniel Vetter: On Thu, Jul 29, 2021 at 09:03:30AM +0200, Christian König wrote: As we now knew controlling dma_fence synchronization from userspace is extremely dangerous and can not only deadlock drivers but trivially also the whole kernel memory management. Ent

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Christian König
Am 29.07.21 um 10:23 schrieb Pekka Paalanen: On Wed, 28 Jul 2021 16:30:13 +0200 Christian König wrote: Am 28.07.21 um 15:57 schrieb Pekka Paalanen: On Wed, 28 Jul 2021 15:31:41 +0200 Christian König wrote: Am 28.07.21 um 15:24 schrieb Michel Dänzer: On 2021-07-28 3:13 p.m., Christian Kö

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 10:17:43AM +0200, Michel Dänzer wrote: > On 2021-07-29 9:09 a.m., Daniel Vetter wrote: > > On Wed, Jul 28, 2021 at 08:34:13AM -0700, Rob Clark wrote: > >> On Wed, Jul 28, 2021 at 6:24 AM Michel Dänzer wrote: > >>> On 2021-07-28 3:13 p.m., Christian König wrote: > Am 28

Re: [PATCH 3/3] dma-buf: nuke SW_SYNC debugfs files

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 10:38 AM Christian König wrote: > Am 29.07.21 um 09:23 schrieb Daniel Vetter: > > On Thu, Jul 29, 2021 at 09:03:30AM +0200, Christian König wrote: > >> As we now knew controlling dma_fence synchronization from userspace is > >> extremely dangerous and can not only deadlock

Re: [PATCH] drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660

2021-07-29 Thread Dmitry Baryshkov
On 29/07/2021 01:20, Konrad Dybcio wrote: VDDA is not present and the specified load value is wrong. Fix it. Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 1 - drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 +- 2 files chang

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Pekka Paalanen
On Thu, 29 Jul 2021 10:43:16 +0200 Christian König wrote: > Am 29.07.21 um 10:23 schrieb Pekka Paalanen: > > On Wed, 28 Jul 2021 16:30:13 +0200 > > Christian König wrote: > > > >> Am 28.07.21 um 15:57 schrieb Pekka Paalanen: > >>> On Wed, 28 Jul 2021 15:31:41 +0200 > >>> Christian König wro

Re: [Regression] No framebuffer console on Rpi since 5.14-rc1

2021-07-29 Thread Maxime Ripard
Hi Stefan, On Wed, Jul 28, 2021 at 05:14:38PM +0200, Stefan Wahren wrote: > Hi, > > Am 15.07.21 um 18:35 schrieb Stefan Wahren: > > Hi guys, > > > > starting with Linux 5.14-rc1 the framebuffer console on Raspberry Pi 3/4 > > (no U-Boot, multi_v7_defconfig) isn't available anymore. The display >

Re: [PATCH v1 1/5] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

2021-07-29 Thread Jason-JH Lin
Hi Enric, Thanks for your review. On Wed, 2021-07-28 at 12:56 +0200, Enric Balletbo Serra wrote: > Hi Jason, > > Missatge de Jason-JH Lin del dia dt., 27 > de jul. 2021 a les 4:53: > > > > Hi Enric, > > > > On Mon, 2021-07-26 at 12:08 +0200, Enric Balletbo Serra wrote: > > > Hi Jason, > > >

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Pekka Paalanen
On Thu, 29 Jul 2021 11:03:36 +0200 Daniel Vetter wrote: > On Thu, Jul 29, 2021 at 10:17:43AM +0200, Michel Dänzer wrote: > > On 2021-07-29 9:09 a.m., Daniel Vetter wrote: > > > On Wed, Jul 28, 2021 at 08:34:13AM -0700, Rob Clark wrote: > > >> On Wed, Jul 28, 2021 at 6:24 AM Michel Dänzer >

Re: [PATCH v3 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes

2021-07-29 Thread Dan Carpenter
Hi Jason, url: https://github.com/0day-ci/linux/commits/Jason-Gunthorpe/Provide-core-infrastructure-for-managing-open-release/20210729-085124 base: https://github.com/awilliam/linux-vfio.git next config: x86_64-randconfig-m001-20210728 (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0

[PATCH rdma-next v3 0/3] SG fix together with update to RDMA umem

2021-07-29 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: * Rewrote to new API suggestion * Split for more patches v2: https://lore.kernel.org/lkml/cover.1626605893.git.leo...@nvidia.com * Changed implementation of first patch, based on our discussion with Christoph. https://lore.kernel.org/lkml/ynwavtt0qmqdx.

[PATCH rdma-next v3 1/3] lib/scatterlist: Provide a dedicated function to support table append

2021-07-29 Thread Leon Romanovsky
From: Maor Gottlieb RDMA is the only in-kernel user that uses __sg_alloc_table_from_pages to append pages dynamically. In the next patch. That mode will be extended and that function will get more parameters. So separate it into a unique function to make such change more clear. Signed-off-by: Ma

[PATCH rdma-next v3 3/3] RDMA: Use the sg_table directly and remove the opencoded version from umem

2021-07-29 Thread Leon Romanovsky
From: Maor Gottlieb This allows using the normal sg_table APIs and makes all the code cleaner. Remove sgt, nents and nmapd from ib_umem. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe --- drivers/infiniband/core/umem.c | 32 +--

[PATCH rdma-next v3 2/3] lib/scatterlist: Fix wrong update of orig_nents

2021-07-29 Thread Leon Romanovsky
From: Maor Gottlieb orig_nents should represent the number of entries with pages, but __sg_alloc_table_from_pages sets orig_nents as the number of total entries in the table. This is wrong when the API is used for dynamic allocation where not all the table entries are mapped with pages. It wasn't

[PATCH v2] drm/i915/selftests: prefer the create_user helper

2021-07-29 Thread Matthew Auld
No need to hand roll the set_placements stuff, now that that we have a helper for this. v2: add back the -ENODEV checking since it's possible for stolen to be probed, and yet still be non-functional Signed-off-by: Matthew Auld Cc: Jason Ekstrand Reviewed-by: Jason Ekstrand --- .../drm/i915/ge

Re: [RFC v1 2/4] virtio-gpu uapi: Add VIRTIO_GPU_F_OUT_FENCE feature

2021-07-29 Thread Gerd Hoffmann
On Thu, Jul 29, 2021 at 01:16:57AM -0700, Vivek Kasireddy wrote: > This feature enables the Guest to wait to know when a resource > is completely consumed by the Host. virtio spec update? What are the exact semantics? Why a new command? Can't you simply fence one of the commands sent anyway (se

Re: [RFC v1 4/4] drm/virtio: Probe and implement VIRTIO_GPU_F_OUT_FENCE feature

2021-07-29 Thread Gerd Hoffmann
Hi, > + bool has_out_fence; > + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_OUT_FENCE)) { > + vgdev->has_out_fence = true; > + vgdev->ddev->mode_config.deferred_out_fence = true; Looks like you don't need has_out_fence, you can just use vgdev->ddev->mode_co

Re: [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-07-29 Thread Dmitry Baryshkov
On 27/07/2021 02:13, Bjorn Andersson wrote: eDP panels might need some power sequencing and backlight management, so make it possible to associate a drm_panel with a DP instance and prepare and enable the panel accordingly. Signed-off-by: Bjorn Andersson The idea looks good from my point of v

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Christian König
Am 29.07.21 um 11:15 schrieb Pekka Paalanen: [SNIP] But how does it then help to wait on the CPU instead? A compositor does not "wait" literally. It would only check which state set is ready to be used, and uses the most recent set that is ready. Any state sets that are not ready are ignored an

Re: [PATCH 3/3] dma-buf: nuke SW_SYNC debugfs files

2021-07-29 Thread Christian König
Am 29.07.21 um 11:03 schrieb Daniel Vetter: On Thu, Jul 29, 2021 at 10:38 AM Christian König wrote: Am 29.07.21 um 09:23 schrieb Daniel Vetter: On Thu, Jul 29, 2021 at 09:03:30AM +0200, Christian König wrote: As we now knew controlling dma_fence synchronization from userspace is extremely dan

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Michel Dänzer
On 2021-07-29 12:14 p.m., Christian König wrote: > Am 29.07.21 um 11:15 schrieb Pekka Paalanen: >> [SNIP] >>> But how does it then help to wait on the CPU instead? >> A compositor does not "wait" literally. It would only check which state >> set is ready to be used, and uses the most recent set tha

[PATCH v4] drm/panel: Add support for E Ink VB3300-KCA

2021-07-29 Thread Alistair Francis
Add support for the 10.3" E Ink panel described at: https://www.eink.com/product.html?type=productdetail&id=7 Signed-off-by: Alistair Francis Acked-by: Rob Herring --- v4: - Fixup alphebetical sorting .../bindings/display/panel/panel-simple.yaml | 2 ++ .../devicetree/bindings/vendor-prefix

Re: [PATCH 47/64] btrfs: Use memset_after() to clear end of struct

2021-07-29 Thread David Sterba
On Wed, Jul 28, 2021 at 02:56:31PM -0700, Kees Cook wrote: > On Wed, Jul 28, 2021 at 11:42:15AM +0200, David Sterba wrote: > > On Tue, Jul 27, 2021 at 01:58:38PM -0700, Kees Cook wrote: > > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > > field bounds checking for mems

Re: [PATCH 02/64] mac80211: Use flex-array for radiotap header bitmap

2021-07-29 Thread David Sterba
On Wed, Jul 28, 2021 at 02:54:52PM -0700, Kees Cook wrote: > On Wed, Jul 28, 2021 at 11:23:23AM +0200, David Sterba wrote: > > On Wed, Jul 28, 2021 at 10:35:56AM +0300, Dan Carpenter wrote: > > > @@ -372,7 +372,7 @@ ieee80211_add_rx_radiotap_header(struct > > > ieee80211_local *local, > > >

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Tvrtko Ursulin
Hi Matt, On 28/07/2021 16:50, Matthew Auld wrote: Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the test being skipped, but if we ever re-enabl

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Matthew Auld
On 29/07/2021 11:53, Tvrtko Ursulin wrote: Hi Matt, On 28/07/2021 16:50, Matthew Auld wrote: Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Pekka Paalanen
On Thu, 29 Jul 2021 12:14:18 +0200 Christian König wrote: > Am 29.07.21 um 11:15 schrieb Pekka Paalanen: > > > > If the app happens to be frozen (e.g. some weird bug in fence handling > > to make it never ready, or maybe it's just bugged itself and never > > drawing again), then the app is frozen

Re: [PATCH v6 10/15] drm/i915/pxp: interfaces for using protected objects

2021-07-29 Thread Rodrigo Vivi
On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote: > This api allow user mode to create protected buffers and to mark > contexts as making use of such objects. Only when using contexts > marked in such a way is the execution guaranteed to work as expected. > > Contexts can onl

Re: [PATCH 0/4] Remove CNL - for drm-intel-gt-next

2021-07-29 Thread Rodrigo Vivi
On Wed, Jul 28, 2021 at 03:03:22PM -0700, Lucas De Marchi wrote: > This the part of https://patchwork.freedesktop.org/series/93056/ > that should go through drm-intel-gt-next branch. Acked-by: Rodrigo Vivi > > Lucas De Marchi (4): > drm/i915/gt: remove explicit CNL handling from intel_mocs.c

[PATCH 1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Tvrtko Ursulin
From: Matthew Auld Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the test being skipped, but if we ever re-enable THP we might start seeing the fa

[PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressions reported with an enabled IOMMU can be almost eliminated by turning them on, lets do that by adding a

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Christian König
Am 29.07.21 um 13:00 schrieb Pekka Paalanen: On Thu, 29 Jul 2021 12:14:18 +0200 Christian König wrote: Am 29.07.21 um 11:15 schrieb Pekka Paalanen: If the app happens to be frozen (e.g. some weird bug in fence handling to make it never ready, or maybe it's just bugged itself and never drawing

Re: [PATCH 2/6] drm/bridge: ti-sn65dsi86: Fix power off sequence

2021-07-29 Thread Robert Foss
Hey Doug, Thank you for submitting this. On Wed, 28 Jul 2021 at 18:46, Douglas Anderson wrote: > > When testing with a panel that's apparently a little more persnickety > about the correct power sequence (specifically Samsung ATNA33XC20), we > found that the ti-sn65dsi86 was doing things just sl

Re: [PATCH 3/6] drm/bridge: ti-sn65dsi86: Add some 100 us delays

2021-07-29 Thread Robert Foss
Hey Doug, Thanks for submitting this. On Wed, 28 Jul 2021 at 18:46, Douglas Anderson wrote: > > The manual has always said that we need 100 us delays in a few > places. Though it hasn't seemed to be a big deal to skip these, let's > add them in case it makes something happier. > > NOTE: this fix

Re: [PATCH 3/3] dma-buf: nuke SW_SYNC debugfs files

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 12:21 PM Christian König wrote: > Am 29.07.21 um 11:03 schrieb Daniel Vetter: > > On Thu, Jul 29, 2021 at 10:38 AM Christian König > > wrote: > >> Am 29.07.21 um 09:23 schrieb Daniel Vetter: > >>> On Thu, Jul 29, 2021 at 09:03:30AM +0200, Christian König wrote: > As w

Re: [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 1:19 PM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Usage of Transparent Hugepages was disabled in 9987da4b5dcf > ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it > appears majority of performance regressions reported with an enabled IOMMU > c

Re: [PATCH v3 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes

2021-07-29 Thread Jason Gunthorpe
On Thu, Jul 29, 2021 at 12:38:12PM +0300, Dan Carpenter wrote: > This should just be: > atomic_add(type->mbytes, &mbochs_avail_mbytes); Arg, yes, thanks Dan - I thought I got all of these. Jason

Re: [PATCH 25/64] drm/mga/mga_ioc32: Use struct_group() for memcpy() region

2021-07-29 Thread Daniel Vetter
On Wed, Jul 28, 2021 at 07:56:40AM +0200, Greg Kroah-Hartman wrote: > On Tue, Jul 27, 2021 at 01:58:16PM -0700, Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memcpy(), memmove(), and memset(), avoid > > intentionally writin

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 12:37:32PM +0300, Pekka Paalanen wrote: > On Thu, 29 Jul 2021 11:03:36 +0200 > Daniel Vetter wrote: > > > On Thu, Jul 29, 2021 at 10:17:43AM +0200, Michel Dänzer wrote: > > > On 2021-07-29 9:09 a.m., Daniel Vetter wrote: > > > > On Wed, Jul 28, 2021 at 08:34:13AM -0700,

[PATCH] vhost: Fix typo in comments

2021-07-29 Thread Cai Huoqing
fix typo for vhost Signed-off-by: Cai Huoqing --- drivers/vhost/scsi.c | 4 ++-- drivers/vhost/vhost.c | 2 +- drivers/vhost/vringh.c | 18 +- drivers/vhost/vsock.c | 6 +++--- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/

[PATCH] drm: Fix typo in comments

2021-07-29 Thread Cai Huoqing
fix typo for drm Signed-off-by: Cai Huoqing --- drivers/gpu/drm/drm_aperture.c | 2 +- drivers/gpu/drm/drm_atomic.c| 2 +- drivers/gpu/drm/drm_atomic_helper.c | 10 +- drivers/gpu/drm/drm_atomic_uapi.c | 6 +++--- drivers/gpu/drm/drm_auth.c

Re: [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Tvrtko Ursulin
On 29/07/2021 13:07, Daniel Vetter wrote: On Thu, Jul 29, 2021 at 1:19 PM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressio

Re: [PATCH 3/3] dma-buf: nuke SW_SYNC debugfs files

2021-07-29 Thread Christian König
Am 29.07.21 um 13:59 schrieb Daniel Vetter: On Thu, Jul 29, 2021 at 12:21 PM Christian König wrote: Am 29.07.21 um 11:03 schrieb Daniel Vetter: On Thu, Jul 29, 2021 at 10:38 AM Christian König wrote: Am 29.07.21 um 09:23 schrieb Daniel Vetter: On Thu, Jul 29, 2021 at 09:03:30AM +0200, Chris

Re: [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 2:21 PM Tvrtko Ursulin wrote: > On 29/07/2021 13:07, Daniel Vetter wrote: > > On Thu, Jul 29, 2021 at 1:19 PM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Usage of Transparent Hugepages was disabled in 9987da4b5dcf > >> ("drm/i915: Disable THP until

Re: [PATCH 3/3] dma-buf: nuke SW_SYNC debugfs files

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 2:25 PM Christian König wrote: > > Am 29.07.21 um 13:59 schrieb Daniel Vetter: > > On Thu, Jul 29, 2021 at 12:21 PM Christian König > > wrote: > >> Am 29.07.21 um 11:03 schrieb Daniel Vetter: > >>> On Thu, Jul 29, 2021 at 10:38 AM Christian König > >>> wrote: > Am 29

Re: [PATCH] drm/vc4: hdmi: Add debugfs prefix

2021-07-29 Thread Ivan T . Ivanov
Hi, Quoting Ivan T. Ivanov (2021-07-29 09:46:23) > Quoting Maxime Ripard (2021-07-28 14:54:19) > > Hi, > > > > On Fri, Jul 23, 2021 at 09:24:14AM +0200, Ivan T. Ivanov wrote: > > > Without prefix debugfs can't properly create component > > > debug information tree when driver register more than >

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Pekka Paalanen
On Thu, 29 Jul 2021 13:43:20 +0200 Christian König wrote: > Am 29.07.21 um 13:00 schrieb Pekka Paalanen: > > On Thu, 29 Jul 2021 12:14:18 +0200 > > Christian König wrote: > > > >> Am 29.07.21 um 11:15 schrieb Pekka Paalanen: > >>> If the app happens to be frozen (e.g. some weird bug in fence

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Pekka Paalanen
On Thu, 29 Jul 2021 14:18:29 +0200 Daniel Vetter wrote: > On Thu, Jul 29, 2021 at 12:37:32PM +0300, Pekka Paalanen wrote: > > On Thu, 29 Jul 2021 11:03:36 +0200 > > Daniel Vetter wrote: > > > > > On Thu, Jul 29, 2021 at 10:17:43AM +0200, Michel Dänzer wrote: > > > > On 2021-07-29 9:09 a.m.,

Re: [RFC PATCH 05/17] drm/exynos: dsi: Get the mode from bridge

2021-07-29 Thread Robert Foss
Hey Jagan, On Sun, 4 Jul 2021 at 11:04, Jagan Teki wrote: > > Now the exynos dsi driver is fully aware of bridge > handling, so get the display mode from bridge, mode_set > API instead of legacy encoder crtc. > > This makes bridge usage more efficient instead of relying > on encoder stack. > > Ad

[Bug 210263] brightness device returns ENXIO (?) on brightness restore at boot, with bootoption "quiet"

2021-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210263 Jonas Platte (jplatte+li...@posteo.de) changed: What|Removed |Added CC||jplatte+li...@pos

[PATCH 1/2] drm/i915/selftests: fixup igt_shrink_thp

2021-07-29 Thread Tvrtko Ursulin
From: Matthew Auld Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the test being skipped, but if we ever re-enable THP we might start seeing the fa

[PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressions reported with an enabled IOMMU can be almost eliminated by turning them on, lets just do that. To e

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Christian König
Am 29.07.21 um 14:49 schrieb Pekka Paalanen: On Thu, 29 Jul 2021 13:43:20 +0200 Christian König wrote: Am 29.07.21 um 13:00 schrieb Pekka Paalanen: On Thu, 29 Jul 2021 12:14:18 +0200 Christian König wrote: Am 29.07.21 um 11:15 schrieb Pekka Paalanen: If the app happens to be frozen (e.g

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 3:00 PM Pekka Paalanen wrote: > On Thu, 29 Jul 2021 14:18:29 +0200 > Daniel Vetter wrote: > > > On Thu, Jul 29, 2021 at 12:37:32PM +0300, Pekka Paalanen wrote: > > > On Thu, 29 Jul 2021 11:03:36 +0200 > > > Daniel Vetter wrote: > > > > > > > On Thu, Jul 29, 2021 at 10:17:

Re: [PATCH 2/2] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-29 Thread Daniel Vetter
On Thu, Jul 29, 2021 at 3:34 PM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Usage of Transparent Hugepages was disabled in 9987da4b5dcf > ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it > appears majority of performance regressions reported with an enabled IOMMU > c

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-29 Thread Pekka Paalanen
On Thu, 29 Jul 2021 15:41:09 +0200 Christian König wrote: > Am 29.07.21 um 14:49 schrieb Pekka Paalanen: > > On Thu, 29 Jul 2021 13:43:20 +0200 > > Christian König wrote: > > > >> Am 29.07.21 um 13:00 schrieb Pekka Paalanen: > >>> On Thu, 29 Jul 2021 12:14:18 +0200 > >>> Christian König wro

Re: [PATCH 02/11] x86/sev: Add an x86 version of prot_guest_has()

2021-07-29 Thread Tom Lendacky
On 7/28/21 8:22 AM, Christoph Hellwig wrote: > On Tue, Jul 27, 2021 at 05:26:05PM -0500, Tom Lendacky via iommu wrote: >> Introduce an x86 version of the prot_guest_has() function. This will be >> used in the more generic x86 code to replace vendor specific calls like >> sev_active(), etc. >> >> Wh

Re: [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-29 Thread Desmond Cheong Zhi Xi
On 29/7/21 3:00 pm, Daniel Vetter wrote: On Tue, Jul 27, 2021 at 04:37:22PM +0200, Peter Zijlstra wrote: On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: Inside drm_is_current_master, using the outer drm_devic

[PATCH v2 1/3] drm/msm/a6xx: Fix llcc configuration for a660 gpu

2021-07-29 Thread Akhil P Oommen
Add the missing scache_cntl0 register programing which is required for a660 gpu. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 46 --- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/d

[PATCH v2 3/3] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
This patch adds support for the gpu found in the Snapdragon 7c Gen 3 compute platform. This gpu is similar to the exisiting a660 gpu with minor delta in the programing sequence. As the Adreno GPUs are moving away from a numeric chipid based naming scheme to a string, it was decided to use 0x0603050

[PATCH v2 2/3] drm/msm/a6xx: Use rev to identify SKU

2021-07-29 Thread Akhil P Oommen
Use rev instead of revn to identify the SKU. This is in preparation to the introduction of 7c3 gpu which won't have a revn. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --gi

[bug report] drm/vmwgfx: Implement an infrastructure for read-coherent resources

2021-07-29 Thread Dan Carpenter
Hello Thomas Hellstrom, The patch fb80edb0d766: "drm/vmwgfx: Implement an infrastructure for read-coherent resources" from Mar 28, 2019, leads to the following static checker warning: drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c:461 vmw_bo_vm_fault() warn: missing conversion: 'page_

Re: [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-29 Thread Peter Zijlstra
On Thu, Jul 29, 2021 at 10:32:13PM +0800, Desmond Cheong Zhi Xi wrote: > Sounds good, will do. Thanks for the patch, Peter. > > Just going to make a small edit: > s/LOCK_STAT_NOT_HELD/LOCK_STATE_NOT_HELD/ Bah, I knew I should've compile tested it :-), Thanks!

Re: [bug report] drm/vmwgfx: Implement an infrastructure for read-coherent resources

2021-07-29 Thread Dan Carpenter
Huh... Vmware is blocking email to Thomas? "Recipient is not authorized to accept external mail" This seems like potentially a serious bug and I don't know how to report it. regards, dan carpenter On Thu, Jul 29, 2021 at 05:39:45PM +0300, Dan Carpenter wrote: > Hello Thomas Hellstrom, > > The

Re: [PATCH v6 10/15] drm/i915/pxp: interfaces for using protected objects

2021-07-29 Thread Daniele Ceraolo Spurio
On 7/29/2021 4:10 AM, Rodrigo Vivi wrote: On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote: This api allow user mode to create protected buffers and to mark contexts as making use of such objects. Only when using contexts marked in such a way is the execution guaranteed

Re: [RFC 1/4] dma-fence: Add deadline awareness

2021-07-29 Thread Rob Clark
On Thu, Jul 29, 2021 at 12:03 AM Daniel Vetter wrote: > > On Wed, Jul 28, 2021 at 10:58:51AM -0700, Rob Clark wrote: > > On Wed, Jul 28, 2021 at 10:23 AM Christian König > > wrote: > > > > > > > > > > > > Am 28.07.21 um 17:15 schrieb Rob Clark: > > > > On Wed, Jul 28, 2021 at 4:37 AM Christian Kö

[PATCH v3 0/3] Support Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
This series adds support for the gpu found in the Snapdragon 7c Gen 3 compute platform. This gpu is similar to the exisiting a660 gpu with minor delta in the programing sequence. As the Adreno GPUs are moving away from a numeric chipid based naming scheme to a string, it was decided to use 0x060305

[PATCH v3 2/3] drm/msm/a6xx: Use rev to identify SKU

2021-07-29 Thread Akhil P Oommen
Use rev instead of revn to identify the SKU. This is in preparation to the introduction of 7c3 gpu which won't have a revn. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --gi

[PATCH v3 1/3] drm/msm/a6xx: Fix llcc configuration for a660 gpu

2021-07-29 Thread Akhil P Oommen
Add the missing scache_cntl0 register programing which is required for a660 gpu. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 46 --- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/d

[PATCH v3 3/3] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-29 Thread Akhil P Oommen
This patch adds support for the gpu found in the Snapdragon 7c Gen 3 compute platform. This gpu is similar to the exisiting a660 gpu with minor delta in the programing sequence. As the Adreno GPUs are moving away from a numeric chipid based naming scheme to a string, it was decided to use 0x0603050

Re: [PATCH v2 2/3] drm/msm/a6xx: Use rev to identify SKU

2021-07-29 Thread Rob Clark
On Thu, Jul 29, 2021 at 7:33 AM Akhil P Oommen wrote: > > Use rev instead of revn to identify the SKU. This is in > preparation to the introduction of 7c3 gpu which won't have a > revn. > > Signed-off-by: Akhil P Oommen > --- > > (no changes since v1) > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c |

Re: [PATCH v4] drm/panel: Add support for E Ink VB3300-KCA

2021-07-29 Thread Sam Ravnborg
Hi Alistair, On Thu, Jul 29, 2021 at 08:33:58PM +1000, Alistair Francis wrote: > Add support for the 10.3" E Ink panel described at: > https://www.eink.com/product.html?type=productdetail&id=7 > > Signed-off-by: Alistair Francis > Acked-by: Rob Herring > --- > v4: > - Fixup alphebetical sortin

Re: [PATCH 01/14] drm/i915/guc/slpc: Initial definitions for SLPC

2021-07-29 Thread Michal Wajdeczko
On 28.07.2021 23:11, Vinay Belgaumkar wrote: > Add macros to check for SLPC support. This feature is currently supported > for Gen12+ and enabled whenever GuC submission is enabled/selected. > > Include templates for SLPC init/fini and enable. > > v2: Move SLPC helper functions to intel_guc_sl

  1   2   3   >