Re: [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers

2021-07-28 Thread jim . cromie
On Wed, Jul 21, 2021 at 1:55 PM Sean Paul wrote: > > From: Sean Paul > > Use drm logging helpers to add support for the upcoming tracefs > implementation. > > Signed-off-by: Sean Paul > Link: > https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-4-s...@poorly.run > #v5 > > Chang

Re: [PATCH 0/3] for_each_*_bit: move to find.h and reconsider

2021-07-28 Thread Yury Norov
Ping? On Fri, Jun 18, 2021 at 12:57:32PM -0700, Yury Norov wrote: > for_each_bit() macro family uses find_bit() functions, so it's better > to have for_each_bit() and find_bit() functions in the same header. > > This series puts for_each_bit() to a proper place and optimizes its > usage over the

Re: [RFC 1/4] dma-fence: Add deadline awareness

2021-07-28 Thread Rob Clark
On Wed, Jul 28, 2021 at 4:37 AM Christian König wrote: > > Am 28.07.21 um 09:03 schrieb Christian König: > > Am 27.07.21 um 16:25 schrieb Rob Clark: > >> On Tue, Jul 27, 2021 at 12:11 AM Christian König > >> wrote: > >>> Am 27.07.21 um 01:38 schrieb Rob Clark: > From: Rob Clark > > >>>

Re: [Regression] No framebuffer console on Rpi since 5.14-rc1

2021-07-28 Thread Stefan Wahren
Hi, Am 15.07.21 um 18:35 schrieb Stefan Wahren: > Hi guys, > > starting with Linux 5.14-rc1 the framebuffer console on Raspberry Pi 3/4 > (no U-Boot, multi_v7_defconfig) isn't available anymore. The display > shows the rainbow screen from the bootloader and than the HDMI screen > goes black instea

Re: [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking

2021-07-28 Thread Melissa Wen
On 07/28, Daniel Vetter wrote: > On Wed, Jul 28, 2021 at 1:29 PM Christian König > wrote: > > Am 27.07.21 um 13:09 schrieb Daniel Vetter: > > > Adding a few more people to this bikeshed. > > > > > > On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter > > > wrote: > > > > > >> @@ -349,6 +367,13 @@ int

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-28 Thread Rob Clark
On Wed, Jul 28, 2021 at 6:57 AM Pekka Paalanen wrote: > > On Wed, 28 Jul 2021 15:31:41 +0200 > Christian König wrote: > > > Am 28.07.21 um 15:24 schrieb Michel Dänzer: > > > On 2021-07-28 3:13 p.m., Christian König wrote: > > >> Am 28.07.21 um 15:08 schrieb Michel Dänzer: > > >>> On 2021-07-28 1:

Re: [PATCH 13/15] drm/i915/guc/slpc: Sysfs hooks for SLPC

2021-07-28 Thread Belgaumkar, Vinay
On 7/27/2021 9:59 AM, Michal Wajdeczko wrote: On 26.07.2021 21:07, Vinay Belgaumkar wrote: Update the get/set min/max freq hooks to work for SLPC case as well. Consolidate helpers for requested/min/max frequency get/set to intel_rps where the proper action can be taken depending on whether

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-28 Thread Rob Clark
On Wed, Jul 28, 2021 at 6:24 AM Michel Dänzer wrote: > > On 2021-07-28 3:13 p.m., Christian König wrote: > > Am 28.07.21 um 15:08 schrieb Michel Dänzer: > >> On 2021-07-28 1:36 p.m., Christian König wrote: > >>> Am 27.07.21 um 17:37 schrieb Rob Clark: > On Tue, Jul 27, 2021 at 8:19 AM Michel

[PATCH 0/7] drm: Extend COMPILE_TEST support to some ARM drivers

2021-07-28 Thread Laurent Pinchart
Hello, This patch series stems from subsystem-wide changes I wanted to compile-test with an ARM64 cross-compiler. My laziness to fire a 32-bit ARM build probably resulted in more time being spent writing these patches, but hopefully they'll turn out to be useful for more people :-) Patches 1/7 an

[PATCH 3/7] drm/imx/dcss: Enable COMPILE_TEST on all ARM64 platforms

2021-07-28 Thread Laurent Pinchart
To extend test coverage, relax the dependency on ARCH_MXC to also enable compilation when COMPILE_TEST is selected. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/imx/dcss/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/driver

[PATCH 1/7] drm/omap: Cast pointer to integer safely

2021-07-28 Thread Laurent Pinchart
On 64-bit platforms, the compiler complains that casting a void pointer to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned to fix this. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 2/7] drm/sti: Use correct printk format specifiers for size_t

2021-07-28 Thread Laurent Pinchart
The correct format specifier for size_t is %zu. Using %d (or %u) generates a warning on 64-bit platforms. Fix it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/sti/sti_hqvdp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/

[PATCH 4/7] drm/omap: Enable COMPILE_TEST on all ARM and ARM64 platforms

2021-07-28 Thread Laurent Pinchart
To extend test coverage, relax the dependency on ARCH_OMAP2PLUS or ARCH_MULTIPLATFORM to also enable compilation on ARM or ARM4 when COMPILE_TEST is selected. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 5/7] drm/sti: Enable COMPILE_TEST on all ARM and ARM64 platforms

2021-07-28 Thread Laurent Pinchart
To extend test coverage, relax the dependency on ARCH_STI or ARCH_MULTIPLATFORM to also enable compilation on ARM or ARM4 when COMPILE_TEST is selected. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/sti/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/g

[PATCH 7/7] drm/tilcdc: Enable COMPILE_TEST on all ARM64 platforms

2021-07-28 Thread Laurent Pinchart
To extend test coverage, support COMPILE_TEST on ARM64 in addition to ARM. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/tilcdc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig index 9f505a149990..

[PATCH 6/7] drm/tegra: Enable COMPILE_TEST on all ARM64 platforms

2021-07-28 Thread Laurent Pinchart
To extend test coverage, support COMPILE_TEST on ARM64 in addition to ARM. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/tegra/Kconfig | 2 +- drivers/gpu/host1x/Kconfig| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/dr

Re: [RESEND PATCH v6 01/14] drm/mipi_dbi: Convert pr_debug calls to DRM_DEBUG_DRIVER

2021-07-28 Thread jim . cromie
On Wed, Jul 21, 2021 at 1:55 PM Sean Paul wrote: > > From: Sean Paul > > Use the drm logging helpers to output these messages to ensure they'll > be included by the drm tracefs instance. > > Signed-off-by: Sean Paul > Link: > https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-2-

[PULL] drm-intel-fixes

2021-07-28 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-07-28: Display related fixes: - Fix vbt port mask - Fix around reading the right DSC disable fuse in display_ver 10 - Split display version 9 and 10 in intel_setup_outputs Thanks, Rodrigo. The following changes since commit ff1176468d368232b684

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, On Wed, Jul 28, 2021 at 03:11:08PM +, dan.sned...@microchip.com wrote: > On 7/28/21 7:00 AM, Sam Ravnborg wrote: > > [You don't often get email from s...@ravnborg.org. Learn why this is > > important at http://aka.ms/LearnAboutSenderIdentification.] > > > > EXTERNAL EMAIL: Do not cli

[PATCH] drm/i915/selftests: fixup igt_shrink_thp

2021-07-28 Thread Matthew Auld
Since the object might still be active here, the shrink_all will simply ignore it, which blows up in the test, since the pages will still be there. Currently THP is disabled which should result in the test being skipped, but if we ever re-enable THP we might start seeing the failure. Fix this by fo

[PATCH] drm/i915/selftests: prefer the create_user helper

2021-07-28 Thread Matthew Auld
No need to hand roll the set_placements stuff, now that that we have a helper for this. Also no need to handle the -ENODEV case here, since NULL mr implies missing device support, where the for_each_memory_region helper will always skip over such regions. Signed-off-by: Matthew Auld Cc: Jason Eks

Re: [RESEND PATCH v6 05/14] drm/print: rename drm_debug* to be more syslog-centric

2021-07-28 Thread jim . cromie
On Wed, Jul 21, 2021 at 1:55 PM Sean Paul wrote: > > From: Sean Paul > > In preparation for tracefs support, rename drm_debug related functions > to reflect that it targets the syslog. This will allow us to selectively > target syslog and/or tracefs. > > No functional changes here. I feel like a

Re: [RESEND PATCH v6 05/14] drm/print: rename drm_debug* to be more syslog-centric

2021-07-28 Thread jim . cromie
On Wed, Jul 21, 2021 at 1:55 PM Sean Paul wrote: > > From: Sean Paul > > In preparation for tracefs support, rename drm_debug related functions > to reflect that it targets the syslog. This will allow us to selectively > target syslog and/or tracefs. > > No functional changes here. > ... > +stati

Re: [PATCH] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-28 Thread Rodrigo Vivi
On Wed, Jul 28, 2021 at 03:12:49PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Usage of Transparent Hugepages was disabled in 9987da4b5dcf > ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it > appears majority of performance regressions reported with an enabled I

[RESEND] [PATCH v2 1/2] dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX

2021-07-28 Thread Laurent Pinchart
The R-Car MIPI DSI/CSI-2 TX is embedded in the Renesas R-Car V3U SoC. It can operate in either DSI or CSI-2 mode, with up to four data lanes. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- Looks like I forgot to CC the devicetree mailing list and Rob Herring on the first try. Re

Re: [Intel-gfx] [PATCH 1/1] drm/i915: dgfx cards need to wait on pcode's uncore init done

2021-07-28 Thread Rodrigo Vivi
On Tue, Jul 27, 2021 at 11:03:38PM +0530, badal.nila...@intel.com wrote: > From: Badal Nilawar > > In discrete cards, the graphics driver shouldn't proceed with the probe > or resume unless PCODE indicated everything is done, including memory > training and gt bring up. > > For this reason, the

Re: [PATCH 01/11] mm: Introduce a function to check for virtualization protection features

2021-07-28 Thread Borislav Petkov
On Wed, Jul 28, 2021 at 02:17:27PM +0100, Christoph Hellwig wrote: > So common checks obviously make sense, but I really hate the stupid > multiplexer. Having one well-documented helper per feature is much > easier to follow. We had that in x86 - it was called cpu_has_ where xxx is the feature bi

[GIT PULL FOR v5.15] R-Car DU fixes and improvements

2021-07-28 Thread Laurent Pinchart
Hi Dave and Daniel, The following changes since commit 15d27b15de965043d6f8e23bc7f34386fcd1a772: efi: sysfb_efi: fix build when EFI is not set (2021-07-27 11:52:51 +0200) are available in the Git repository at: git://linuxtv.org/pinchartl/media.git tags/du-next-20210728 for you to fetch

[PATCH 0/6] drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel

2021-07-28 Thread Douglas Anderson
The overall goal of this series is to make the Samsung ATNA33XC20 panel work more properly. As part of this, we have: * A bugfix for the recently abstracted DP AUX backlight code. * A bugfix for the sequencing of the ti-sn65dsi86 bridge driver. * Removal of the panel from panel-simple and moving

[PATCH 2/6] drm/bridge: ti-sn65dsi86: Fix power off sequence

2021-07-28 Thread Douglas Anderson
When testing with a panel that's apparently a little more persnickety about the correct power sequence (specifically Samsung ATNA33XC20), we found that the ti-sn65dsi86 was doing things just slightly wrong. Looking closely at the ti-sn65dsi86's datasheet, the power off sequence is supposed to be:

[PATCH 1/6] drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not specified

2021-07-28 Thread Douglas Anderson
The function drm_edp_backlight_init() is defined such that the "driver_pwm_freq_hz" parameter is optional--it's 0 if you don't want to futz with it. If you follow this variable through, you'll find out that if it's 0 we won't ever set the "bl->pwmgen_bit_count", leaving it as 0. That means that be

[PATCH 4/6] Revert "drm/panel-simple: Add Samsung ATNA33XC20"

2021-07-28 Thread Douglas Anderson
This reverts commit 4bfe6c8f7c23b01719671b69fd29b87a35ccd9d6. This panel's power sequencing really can't be handled properly by panel-simple because of the special sequencing needed for the EL_ON3 GPIO. The only way it was sorta working in the past was by trying to jam that signal into the "enable

[PATCH 5/6] Revert "drm/panel-simple: Support for delays between GPIO & regulator"

2021-07-28 Thread Douglas Anderson
This reverts commit 18a1488bf1e13fc3fc96d7948466b2166067c6c8. Those delays were added to support the Samsung ATNA33XC20 panel. However, we've moving that to its own panel driver and out of panel-simple. That means we don't need the ability to specify this delay. NOTE: it's unlikely we want to kee

[PATCH 3/6] drm/bridge: ti-sn65dsi86: Add some 100 us delays

2021-07-28 Thread Douglas Anderson
The manual has always said that we need 100 us delays in a few places. Though it hasn't seemed to be a big deal to skip these, let's add them in case it makes something happier. NOTE: this fixes no known issues but it seems good to make it right. Signed-off-by: Douglas Anderson --- drivers/gpu

[PATCH 6/6] drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel

2021-07-28 Thread Douglas Anderson
The Samsung ATNA33XC20 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. This panel is _almost_ able to be controlled in a "simple" way (and it originally was implemented in panel-simple.c), but it's really impossible to get the backlight semantics right there withou

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-28 Thread Christian König
Am 28.07.21 um 17:27 schrieb Rob Clark: On Wed, Jul 28, 2021 at 6:57 AM Pekka Paalanen wrote: On Wed, 28 Jul 2021 15:31:41 +0200 Christian König wrote: Am 28.07.21 um 15:24 schrieb Michel Dänzer: On 2021-07-28 3:13 p.m., Christian König wrote: Am 28.07.21 um 15:08 schrieb Michel Dänzer:

Re: [RFC 1/4] dma-fence: Add deadline awareness

2021-07-28 Thread Christian König
Am 28.07.21 um 17:15 schrieb Rob Clark: On Wed, Jul 28, 2021 at 4:37 AM Christian König wrote: Am 28.07.21 um 09:03 schrieb Christian König: Am 27.07.21 um 16:25 schrieb Rob Clark: On Tue, Jul 27, 2021 at 12:11 AM Christian König wrote: Am 27.07.21 um 01:38 schrieb Rob Clark: From: Rob

Re: [RFC 1/4] dma-fence: Add deadline awareness

2021-07-28 Thread Rob Clark
On Wed, Jul 28, 2021 at 10:23 AM Christian König wrote: > > > > Am 28.07.21 um 17:15 schrieb Rob Clark: > > On Wed, Jul 28, 2021 at 4:37 AM Christian König > > wrote: > >> Am 28.07.21 um 09:03 schrieb Christian König: > >>> Am 27.07.21 um 16:25 schrieb Rob Clark: > On Tue, Jul 27, 2021 at 12

Re: refactor the i915 GVT support

2021-07-28 Thread Jason Gunthorpe
On Wed, Jul 28, 2021 at 01:38:58PM +, Wang, Zhi A wrote: > I guess those APIs you were talking about are KVM-only. For other > hypervisors, e.g. Xen, ARCN cannot use the APIs you mentioned. Not > sure if you have already noticed that VFIO is KVM-only right now. There is very little hard conne

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, thanks for the quick feedback! On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: > On 7/28/21 8:44 AM, Sam Ravnborg wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Hi Dan, > > > > On Wed, Jul 28,

Re: [PATCH 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

2021-07-28 Thread Thomas Zimmermann
Hi Sam Am 28.07.21 um 15:31 schrieb Sam Ravnborg: Hi Thomas, On Tue, Jul 27, 2021 at 08:27:09PM +0200, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Thomas Zimmermann
Hi Am 28.07.21 um 20:11 schrieb Sam Ravnborg: Hi Dan, thanks for the quick feedback! On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: On 7/28/21 8:44 AM, Sam Ravnborg wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Re: [PATCH 36/64] scsi: ibmvscsi: Avoid multi-field memset() overflow by aiming at srp

2021-07-28 Thread Kees Cook
On Tue, Jul 27, 2021 at 09:39:39PM -0400, Martin K. Petersen wrote: > > Kees, > > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memset(), avoid intentionally writing across > > neighboring fields. > > > > Instead of writing beyond the end o

[PATCH] drm/i915: Disable bonding on gen12+ platforms

2021-07-28 Thread Matthew Brost
Disable bonding on gen12+ platforms aside from ones already supported by the i915 - TGL, RKL, and ADL-S. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/

[Bug 205089] amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2021-07-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205089 Alois Nespor (i...@aloisnespor.info) changed: What|Removed |Added CC||i...@aloisnespor.in

Re: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, > >> > >> Just to be sure... > >> Can you confirm that vbltest is working OK *before* this patch? > > > > Yes, can you please verify that it regressed. If so, this would mean > > that the driver misses vblank interrupts with the patch applied. > > Yes, unfortunately the vbltest works be

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 7:00 AM, Sam Ravnborg wrote: > [You don't often get email from s...@ravnborg.org. Learn why this is > important at http://aka.ms/LearnAboutSenderIdentification.] > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > I hope y

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread kernel test robot
] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jackie-Liu/drm-rcar-du-crtc-force-depends-on-cm

Re: [PATCH 15/64] ipw2x00: Use struct_group() for memcpy() region

2021-07-28 Thread Stanislav Yakovlev
On 28/07/2021, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field array bounds checking for memcpy(), memmove(), and memset(), > avoid intentionally writing across neighboring fields. > > Use struct_group() in struct libipw_qos_information_element aro

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Sam Ravnborg
Hi Dan, > > > > I think I got it - we need to set irq_enabled to true. > > The documentation says so: > > " > > * @irq_enabled: > > * > > * Indicates that interrupt handling is enabled, specifically > > vblank > > * handling. Drivers which don't use drm_ir

[early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-28 Thread Rob Clark
Hi Dave & Daniel, An early pull for v5.15 (there'll be more coming in a week or two), consisting of the drm/scheduler conversion and a couple other small series that one was based one. Mostly sending this now because IIUC danvet wanted it in drm-next so he could rebase on it. (Daniel, if you dis

Re: [PATCH 19/64] ip: Use struct_group() for memcpy() regions

2021-07-28 Thread Kees Cook
On Wed, Jul 28, 2021 at 07:55:53AM +0200, Greg Kroah-Hartman wrote: > > struct ethhdr { > > - unsigned char h_dest[ETH_ALEN]; /* destination eth addr */ > > - unsigned char h_source[ETH_ALEN]; /* source ether addr*/ > > + union { > > + struct { > > +

[PATCH 01/14] drm/i915/guc/slpc: Initial definitions for SLPC

2021-07-28 Thread Vinay Belgaumkar
Add macros to check for SLPC support. This feature is currently supported for Gen12+ and enabled whenever GuC submission is enabled/selected. Include templates for SLPC init/fini and enable. v2: Move SLPC helper functions to intel_guc_slpc.c/.h. Define basic template for SLPC structure in intel_g

[PATCH 03/14] drm/i915/guc/slpc: Adding SLPC communication interfaces

2021-07-28 Thread Vinay Belgaumkar
Add constants and params that are needed to configure SLPC. v2: Add a new abi header for SLPC. Replace bitfields with genmasks. Address other comments from Michal W. v3: Add slpc H2G format in abi, other review commments (Michal W) v4: Update status bits according to latest spec Signed-off-by:

[PATCH v4 00/14] drm/i915/guc/slpc: Enable GuC based power management features

2021-07-28 Thread Vinay Belgaumkar
This series enables Single Loop Power Control (SLPC) feature in GuC. GuC implements various power management algorithms as part of it's operation. These need to be specifically enabled by KMD. They replace the legacy host based management of these features. With this series, we will enable two PM

[PATCH 02/14] drm/i915/guc/slpc: Gate Host RPS when SLPC is enabled

2021-07-28 Thread Vinay Belgaumkar
Also ensure uc_init is called before we initialize RPS so that we can check for SLPC support. We do not need to enable up/down interrupts when SLPC is enabled. However, we still need the ARAT interrupt, which will be enabled separately later. Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundare

[PATCH 04/14] drm/i915/guc/slpc: Allocate, initialize and release SLPC

2021-07-28 Thread Vinay Belgaumkar
Allocate data structures for SLPC and functions for initializing on host side. v2: Address review comments (Michal W) v3: Remove unnecessary header includes (Michal W) v4: Rebase Reviewed-by: Michal Wajdeczko Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha --- drivers/gpu/

[PATCH 05/14] drm/i915/guc/slpc: Enable SLPC and add related H2G events

2021-07-28 Thread Vinay Belgaumkar
Add methods for interacting with GuC for enabling SLPC. Enable SLPC after GuC submission has been established. GuC load will fail if SLPC cannot be successfully initialized. Add various helper methods to set/unset the parameters for SLPC. They can be set using H2G calls or directly setting bits in

[PATCH 08/14] drm/i915/guc/slpc: Add get max/min freq hooks

2021-07-28 Thread Vinay Belgaumkar
Add helpers to read the min/max frequency being used by SLPC. This is done by send a H2G command which forces SLPC to update the shared data struct which can then be read. These helpers will be used in a sysfs patch later on. v2: Address review comments (Michal W) v3: Return err in case of query f

[PATCH 07/14] drm/i915/guc/slpc: Add methods to set min/max frequency

2021-07-28 Thread Vinay Belgaumkar
Add param set h2g helpers to set the min and max frequencies for use by SLPC. v2: Address review comments (Michal W) v3: Check for positive error code (Michal W) v4: Print generic error in set_param (Michal W) Signed-off-by: Sundaresan Sujaritha Signed-off-by: Vinay Belgaumkar --- drivers/gpu/

[PATCH 09/14] drm/i915/guc/slpc: Add debugfs for SLPC info

2021-07-28 Thread Vinay Belgaumkar
This prints out relevant SLPC info from the SLPC shared structure. We will send a H2G message which forces SLPC to update the shared data structure with latest information before reading it. v2: Address review comments (Michal W) v3: Remove unnecessary tasks from slpc_info (Michal W) v4: Rename f

[PATCH 06/14] drm/i915/guc/slpc: Remove BUG_ON in guc_submission_disable

2021-07-28 Thread Vinay Belgaumkar
The assumption when it was added was that GT would not be holding any gt_pm references. However, uc_init is called from gt_init_hw, which holds a forcewake ref. If SLPC enable fails, we will still be holding this ref, which will result in the BUG_ON. Reviewed-by: Matthew Brost Signed-off-by: Vina

[PATCH 10/14] drm/i915/guc/slpc: Enable ARAT timer interrupt

2021-07-28 Thread Vinay Belgaumkar
This interrupt is enabled during RPS initialization, and now needs to be done by SLPC code. It allows ARAT timer expiry interrupts to get forwarded to GuC. v2: Fix comment (Matthew Brost) Reviewed-by: Matthew Brost Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c

[PATCH 11/14] drm/i915/guc/slpc: Cache platform frequency limits

2021-07-28 Thread Vinay Belgaumkar
Cache rp0, rp1 and rpn platform limits into SLPC structure for range checking while setting min/max frequencies. Also add "soft" limits which keep track of frequency changes made from userland. These are initially set to platform min and max. v2: Address review comments (Michal W) v3: Formatting

[PATCH 14/14] drm/i915/guc/rc: Setup and enable GuCRC feature

2021-07-28 Thread Vinay Belgaumkar
This feature hands over the control of HW RC6 to the GuC. GuC decides when to put HW into RC6 based on it's internal busyness algorithms. GuCRC needs GuC submission to be enabled, and only supported on Gen12+ for now. When GuCRC is enabled, do not set HW RC6. Use a H2G message to tell GuC to enab

[PATCH 12/14] drm/i915/guc/slpc: Sysfs hooks for SLPC

2021-07-28 Thread Vinay Belgaumkar
Update the get/set min/max freq hooks to work for SLPC case as well. Consolidate helpers for requested/min/max frequency get/set to intel_rps where the proper action can be taken depending on whether SLPC is enabled. v2: Add wrappers for getting rp0/1/n frequencies, update softlimits in set min/ma

[PATCH 13/14] drm/i915/guc/slpc: Add SLPC selftest

2021-07-28 Thread Vinay Belgaumkar
Tests that exercise the SLPC get/set frequency interfaces. Clamp_max will set max frequency to multiple levels and check that SLPC requests frequency lower than or equal to it. Clamp_min will set min frequency to different levels and check if SLPC requests are higher or equal to those levels. v2

Re: [PATCH 02/64] mac80211: Use flex-array for radiotap header bitmap

2021-07-28 Thread Kees Cook
On Wed, Jul 28, 2021 at 10:35:56AM +0300, Dan Carpenter wrote: > On Tue, Jul 27, 2021 at 01:57:53PM -0700, Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memcpy(), memmove(), and memset(), avoid > > intentionally writing acr

Re: [Intel-gfx] [PATCH v3 3/5] drm/print: RFC add choice to use dynamic debug in drm-debug

2021-07-28 Thread jim . cromie
On Tue, Jul 27, 2021 at 10:03 AM Sean Paul wrote: > > On Thu, Jul 22, 2021 at 11:20 AM Sean Paul wrote: > > > > Reply-all fail. Adding everyone else back to my response. > > > On Tue, Jul 20, 2021 at 03:29:34PM +0200, Daniel Vetter wrote: > > > On Wed, Jul 14, 2021 at 11:51:36AM -0600, Jim Cromie

[PATCH] drm/msm/dp: update is_connected status base on sink count at dp_pm_resume()

2021-07-28 Thread Kuogee Hsieh
Currently at dp_pm_resume() is_connected state is decided base on hpd connection status only. This will put is_connected in wrongly "true" state at the scenario that dongle attached to DUT but without hmdi cable connecting to it. Fix this problem by adding read sink count from dongle and decided is

Re: [PATCH 01/64] media: omap3isp: Extract struct group for memcpy() region

2021-07-28 Thread Bart Van Assche
On 7/28/21 2:14 AM, Dan Carpenter wrote: On Wed, Jul 28, 2021 at 10:59:22AM +0200, David Sterba wrote: drivers/media/platform/omap3isp/ispstat.c | 5 +-- include/uapi/linux/omap3isp.h | 44 +-- 2 files changed, 36 insertions(+), 13 deletions(-) diff --git a/

Re: [PATCH 01/64] media: omap3isp: Extract struct group for memcpy() region

2021-07-28 Thread David Sterba
On Wed, Jul 28, 2021 at 02:37:20PM -0700, Bart Van Assche wrote: > On 7/28/21 2:14 AM, Dan Carpenter wrote: > > On Wed, Jul 28, 2021 at 10:59:22AM +0200, David Sterba wrote: > >>> drivers/media/platform/omap3isp/ispstat.c | 5 +-- > >>> include/uapi/linux/omap3isp.h | 44 +++

Re: [PATCH 48/64] drbd: Use struct_group() to zero algs

2021-07-28 Thread Bart Van Assche
On 7/27/21 1:58 PM, Kees Cook wrote: In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memset(), avoid intentionally writing across neighboring fields. Add a struct_group() for the algs so that memset() can correctly reason about the size. Signed-o

Re: [PATCH 02/64] mac80211: Use flex-array for radiotap header bitmap

2021-07-28 Thread Kees Cook
On Wed, Jul 28, 2021 at 11:23:23AM +0200, David Sterba wrote: > On Wed, Jul 28, 2021 at 10:35:56AM +0300, Dan Carpenter wrote: > > @@ -372,7 +372,7 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local > > *local, > > ieee80211_calculate_rx_timestamp(local, status, > >

Re: [PATCH 47/64] btrfs: Use memset_after() to clear end of struct

2021-07-28 Thread Kees Cook
On Wed, Jul 28, 2021 at 11:42:15AM +0200, David Sterba wrote: > On Tue, Jul 27, 2021 at 01:58:38PM -0700, Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memset(), avoid intentionally writing across > > neighboring fields. >

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 8:44 AM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > On Wed, Jul 28, 2021 at 03:11:08PM +, dan.sned...@microchip.com wrote: >> On 7/28/21 7:00 AM, Sam Ravnborg wrote: >>> [You don't often get em

Re: [PATCH 04/64] stddef: Introduce struct_group() helper macro

2021-07-28 Thread Kees Cook
On Wed, Jul 28, 2021 at 12:54:18PM +0200, Rasmus Villemoes wrote: > On 27/07/2021 22.57, Kees Cook wrote: > > > In order to have a regular programmatic way to describe a struct > > region that can be used for references and sizing, can be examined for > > bounds checking, avoids forcing the use of

[PATCH 3/4] drm/i915/gt: rename CNL references in intel_engine.h

2021-07-28 Thread Lucas De Marchi
With the removal of CNL, let's consider ICL as the first platform using that index. Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_engine.h | 2 +- drivers/gpu/drm/i915/i915_drv.h| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 1/4] drm/i915/gt: remove explicit CNL handling from intel_mocs.c

2021-07-28 Thread Lucas De Marchi
Only one reference to CNL that is not needed, but code is the same for GEN9_BC, so leave the code around and just remove the special case for CNL. Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 0/4] Remove CNL - for drm-intel-gt-next

2021-07-28 Thread Lucas De Marchi
This the part of https://patchwork.freedesktop.org/series/93056/ that should go through drm-intel-gt-next branch. Lucas De Marchi (4): drm/i915/gt: remove explicit CNL handling from intel_mocs.c drm/i915/gt: remove explicit CNL handling from intel_sseu.c drm/i915/gt: rename CNL references in

[PATCH 4/4] drm/i915/gt: remove GRAPHICS_VER == 10

2021-07-28 Thread Lucas De Marchi
Replace all remaining handling of GRAPHICS_VER {==,>=} 10 with {==,>=} 11. With the removal of CNL, there is no platform with graphics version equals 10. Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/debugfs_gt_pm.c | 10 ++--- drivers/gpu/drm/i915/g

[PATCH 2/4] drm/i915/gt: remove explicit CNL handling from intel_sseu.c

2021-07-28 Thread Lucas De Marchi
CNL is the only platform with GRAPHICS_VER == 10. With its removal we don't need to handle that version anymore. Also we can now reduce the max number of slices: the call to intel_sseu_set_info() with the highest number of slices comes from SKL and BDW with 3 slices. Recent platforms actually incr

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
On 7/28/21 11:11 AM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > > thanks for the quick feedback! > > On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote: >> On 7/28/21 8:44 AM, Sam Ravnbo

[PATCH] drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660

2021-07-28 Thread Konrad Dybcio
VDDA is not present and the specified load value is wrong. Fix it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 1 - drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c

Re: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
Hi Thomas, On 7/28/21 11:17 AM, Thomas Zimmermann wrote: > Hi > > Am 28.07.21 um 20:11 schrieb Sam Ravnborg: >> Hi Dan, >> >> thanks for the quick feedback! >> >> On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com >> wrote: >>> On 7/28/21 8:44 AM, Sam Ravnborg wrote: EXTERN

RE: [PATCH 09/14] drm/kmb : W/A for planar formats

2021-07-28 Thread Chrisanthus, Anitha
Please ignore this patch. Will combine this with 256B w/a patch. > -Original Message- > From: Chrisanthus, Anitha > Sent: Tuesday, July 27, 2021 5:31 PM > To: dri-devel@lists.freedesktop.org; Chrisanthus, Anitha > ; Dea, Edmund J > Subject: [PATCH 09/14] drm/kmb : W/A for planar formats

RE: [PATCH 04/14] drm/kmb : W/A for 256B cache alignment for video

2021-07-28 Thread Chrisanthus, Anitha
Hi Sam, Thanks for you review. > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 28, 2021 12:16 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Dea, Edmund J > > Subject: Re: [PATCH 04/14] drm/kmb : W/A for 256B cache alignment for video > > Hi Anith

RE: [PATCH 14/14] drm/kmb: Enable support for fbcon (framebuffer console)

2021-07-28 Thread Chrisanthus, Anitha
Hi Sam, Thanks for the review. > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 28, 2021 12:31 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Dea, Edmund J > > Subject: Re: [PATCH 14/14] drm/kmb: Enable support for fbcon (framebuffer > console) > >

Re: [PATCH 02/64] mac80211: Use flex-array for radiotap header bitmap

2021-07-28 Thread Kees Cook
On Wed, Jul 28, 2021 at 10:35:56AM +0300, Dan Carpenter wrote: > On Tue, Jul 27, 2021 at 01:57:53PM -0700, Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memcpy(), memmove(), and memset(), avoid > > intentionally writing acr

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

2021-07-28 Thread Dan.Sneddon
Hi Sam, On 7/28/21 12:08 PM, Sam Ravnborg wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Dan, > Just to be sure... Can you confirm that vbltest is working OK *before* this patch? >>> >>> Yes, can you please verify that

RE: [PATCH 12/14] drm/kmb: Fix possible oops in error handling

2021-07-28 Thread Chrisanthus, Anitha
Hi Sam, > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 28, 2021 12:27 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Dea, Edmund J > ; Dan Carpenter > Subject: Re: [PATCH 12/14] drm/kmb: Fix possible oops in error handling > > Hi Anitha, > > On

Re: [PATCH 02/64] mac80211: Use flex-array for radiotap header bitmap

2021-07-28 Thread Kees Cook
On Wed, Jul 28, 2021 at 10:35:56AM +0300, Dan Carpenter wrote: > On Tue, Jul 27, 2021 at 01:57:53PM -0700, Kees Cook wrote: > > [...] > > - /** > > -* @it_present: (first) present word > > -*/ > > - __le32 it_present; > > + union { > > + /** > > +* @it_present: (

Re: [PATCH v4 10/13] lib: test_hmm add module param for zone device type

2021-07-28 Thread Sierra Guiza, Alejandro (Alex)
On 7/22/2021 12:26 PM, Jason Gunthorpe wrote: On Thu, Jul 22, 2021 at 11:59:17AM -0500, Sierra Guiza, Alejandro (Alex) wrote: On 7/22/2021 7:23 AM, Jason Gunthorpe wrote: On Sat, Jul 17, 2021 at 02:21:32PM -0500, Alex Sierra wrote: In order to configure device generic in test_hmm, two module

[Bug 213373] [drm] [radeon] memory leak at parsing radeon_atombios_parse_power_table

2021-07-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213373 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #297249|0 |1 is obsolete|

[PATCH 0/1] Fix gem_ctx_persistence failures with GuC submission

2021-07-28 Thread Matthew Brost
Should fix below failures with GuC submission for the following tests: gem_exec_balancer --r noheartbeat gem_ctx_persistence --r heartbeat-close Not going to fix: gem_ctx_persistence --r heartbeat-many gem_ctx_persistence --r heartbeat-stop As the above tests change the heartbeat value to 0 (off)

[PATCH 1/1] drm/i915: Check if engine has heartbeat when closing a context

2021-07-28 Thread Matthew Brost
If an engine associated with a context does not have a heartbeat, ban it immediately. This is needed for GuC submission as a idle pulse doesn't kick the context off the hardware where it then can check for a heartbeat and ban the context. This patch also updates intel_engine_has_heartbeat to be a

[PATCH v3 00/14] Provide core infrastructure for managing open/release

2021-07-28 Thread Jason Gunthorpe
This is in support of Max's series to split vfio-pci. For that to work the reflck concept embedded in vfio-pci needs to be sharable across all of the new VFIO PCI drivers which motivated re-examining how this is implemented. Another significant issue is how the VFIO PCI core includes code like:

[PATCH v3 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme

2021-07-28 Thread Jason Gunthorpe
Platform simply wants to run some code when the device is first opened/last closed. Use the core framework and locking for this. Aside from removing a bit of code this narrows the locking scope from a global lock. Signed-off-by: Jason Gunthorpe Signed-off-by: Yishai Hadas Reviewed-by: Cornelia

[PATCH v3 08/14] vfio/pci: Move to the device set infrastructure

2021-07-28 Thread Jason Gunthorpe
From: Yishai Hadas PCI wants to have the usual open/close_device() logic with the slight twist that the open/close_device() must be done under a singelton lock shared by all of the vfio_devices that are in the PCI "reset group". The reset group, and thus the device set, is determined by what dev

[PATCH v3 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes

2021-07-28 Thread Jason Gunthorpe
Convert mbochs to use an atomic scheme for this like mtty was changed into. The atomic fixes various race conditions with probing. Add the missing error unwind. Also add the missing kfree of mdev_state->pages. Fixes: 681c1615f891 ("vfio/mbochs: Convert to use vfio_register_group_dev()") Reported-b

<    1   2   3   >