Re: [RFC 1/4] dma-fence: Add deadline awareness

Am 27.07.21 um 16:25 schrieb Rob Clark: On Tue, Jul 27, 2021 at 12:11 AM Christian König wrote: Am 27.07.21 um 01:38 schrieb Rob Clark: From: Rob Clark Add a way to hint to the fence signaler of an upcoming deadline, such as vblank, which the fence waiter would prefer not to miss. This is t

Re: [PATCH 01/14] drm/kmb: Enable LCD DMA for low TVDDCV

Hi Anitha, On Tue, Jul 27, 2021 at 05:31:13PM -0700, Anitha Chrisanthus wrote: > From: Edmund Dea > > There's an undocumented dependency between LCD layer enable bits [2-5] > and the AXI pipelined read enable bit [28] in the LCD_CONTROL register. > The proper order of operation is: > > 1) Clear

Re: [PATCH 02/14] drm/kmb: Define driver date and major/minor version

Hi Anitha, On Tue, Jul 27, 2021 at 05:31:14PM -0700, Anitha Chrisanthus wrote: > From: Edmund Dea > > Added macros for date and version > > Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") > Signed-off-by: Edmund Dea Your s-o-b is missing. I find it of no use with macros here,

Re: [PATCH 04/14] drm/kmb : W/A for 256B cache alignment for video

Hi Anitha, On Tue, Jul 27, 2021 at 05:31:16PM -0700, Anitha Chrisanthus wrote: > For B0 silicon, the media driver pads the decoded video dmabufs for 256B > alignment. This is the backing buffer of the framebuffer and info in the > drm frame buffer is not correct for these buffers as this is done >

Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

On 7/27/2021 5:46 AM, Stephen Boyd wrote: Quoting Akhil P Oommen (2021-07-24 10:29:00) Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This patch has dependency on the GPUCC bindings patch here: https://patchwork.kernel.org/project/linux-arm-msm/patch/16

Re: [PATCH 10/14] drm/kmb: Enable ADV bridge after modeset

On Tue, Jul 27, 2021 at 05:31:22PM -0700, Anitha Chrisanthus wrote: > On KMB, ADV bridge must be programmed and powered on prior to > MIPI DSI HW initialization. > > Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver") > Signed-off-by: Anitha Chrisanthus > --- > drivers/gpu/drm/k

Re: [PATCH 12/14] drm/kmb: Fix possible oops in error handling

Hi Anitha, On Tue, Jul 27, 2021 at 05:31:24PM -0700, Anitha Chrisanthus wrote: > If kmb_dsi_init() fails the "kmb->kmb_dsi" variable is an error pointer. > This can potentially result in kernel panic when kmb_dsi_host_unregister is > called. > > Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for Keem

Re: [PATCH 13/14] drm/kmb: Enable alpha blended second plane

Hi Anitha, On Tue, Jul 27, 2021 at 05:31:25PM -0700, Anitha Chrisanthus wrote: > From: Edmund Dea > > Enable one additional plane that is alpha blended on top > of the primary plane. > > Signed-off-by: Edmund Dea Your s-o-b is missing. With this fixed: Acked-by: Sam Ravnborg > --- > drivers/

Re: [PATCH 14/14] drm/kmb: Enable support for fbcon (framebuffer console)

Hi Anitha, On Tue, Jul 27, 2021 at 05:31:26PM -0700, Anitha Chrisanthus wrote: > From: Edmund Dea > > Enable support for fbcon (framebuffer console). > The user can initialize fbcon by loading kmb-drm with the parameter > console=1. I do not see the poit of the boot parameter?? Why is it needed

Re: [PATCH 02/64] mac80211: Use flex-array for radiotap header bitmap

On Tue, Jul 27, 2021 at 01:57:53PM -0700, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. > > The it_present member of struct ieee80211_

Re: [PATCH 12/14] drm/kmb: Fix possible oops in error handling

On Tue, Jul 27, 2021 at 05:31:24PM -0700, Anitha Chrisanthus wrote: > If kmb_dsi_init() fails the "kmb->kmb_dsi" variable is an error pointer. > This can potentially result in kernel panic when kmb_dsi_host_unregister is > called. > > Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display"

[PATCH 3/9] phy: phy-mtk-tphy: support type switch by pericfg

Add support type switch between USB3, PCIe, SATA and SGMII by pericfg register, this is used to take the place of efuse or jumper. Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-tphy.c | 84 - 1 file changed, 82 insertions(+), 2 deletions(-) diff --git

[PATCH 1/9] dt-bindings: phy: mediatek: tphy: support type switch by pericfg

Add support type switch by pericfg register between USB3, PCIe, SATA, SGMII, this is used to replace the way through efuse or jumper. Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/mediatek,tphy.yaml | 16 1 file changed, 16 insertions(+) diff --git a/Documentati

[PATCH 4/9] phy: phy-mtk-tphy: print error log using child device

Print error log using child devices instead of parent device. Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-tphy.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c index a65020

[PATCH 5/9] phy: phy-mtk-tphy: remove error log of ioremap failure

devm_ioremap_resource() will print log if error happens. Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-tphy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c index 9d4b34298137..cdcef865fe9e 100644 --- a

[PATCH 6/9] phy: phy-mtk-ufs: use clock bulk to get clocks

Use clock bulk helpers to get/enable/disable clocks Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-ufs.c | 44 -- 1 file changed, 11 insertions(+), 33 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-ufs.c b/drivers/phy/mediatek/phy-mtk-ufs.c ind

[PATCH 2/9] phy: phy-mtk-tphy: use clock bulk to get clocks

Use clock bulk helpers to get/enable/disable clocks Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-tphy.c | 43 + 1 file changed, 13 insertions(+), 30 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c i

[PATCH 8/9] phy: phy-mtk-mipi-dsi: remove dummy assignment of error number

Return the error number directly without assignment Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c index 01cf31633

[PATCH 9/9] phy: phy-mtk-mipi-dsi: convert to devm_platform_ioremap_resource

Use devm_platform_ioremap_resource to simplify code Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c index 61c942fb

[PATCH 7/9] phy: phy-mtk-hdmi: convert to devm_platform_ioremap_resource

Use devm_platform_ioremap_resource to simplify code Signed-off-by: Chunfeng Yun --- drivers/phy/mediatek/phy-mtk-hdmi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c index 8ad8f717ef43..5fb421

Re: [Intel-gfx] [PATCH 03/33] drm/i915: Hold reference to intel_context over life of i915_request

On Tue, Jul 27, 2021 at 2:06 AM Matthew Brost wrote: > Hold a reference to the intel_context over life of an i915_request. > Without this an i915_request can exist after the context has been > destroyed (e.g. request retired, context closed, but user space holds a > reference to the request from a

[PATCH] drm/i915/gt: Fix a lockdep warning with disable interrupts

When disable local interrupt irq of CPU hardware, some spin_lock are called by inside signal_irq_work(), intel_breadcrumbs_disarm_irq() and intel_breadcrumbs_arm_irq(). RT complains about might sleep inside interrupt disable by spin_lock, so switch spin_lock to spin_lock_irqsave with the shutdown

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

Hi Randy, On Tue, Jul 27, 2021 at 7:06 AM Randy Dunlap wrote: > When # CONFIG_EFI is not set, there are 2 definitions of > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > and the __init function from sysfb_efi.c should not be used. > > ../drivers/firmware/efi/sysfb_efi.c:337:13:

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

On Wed, 28 Jul 2021 at 10:39, Geert Uytterhoeven wrote: > > Hi Randy, > > On Tue, Jul 27, 2021 at 7:06 AM Randy Dunlap wrote: > > When # CONFIG_EFI is not set, there are 2 definitions of > > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > > and the __init function from sysfb_efi.

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Jackie, On 28/07/2021 09:42, Jackie Liu wrote: > From: Jackie Liu > > After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"), > the cmm module must be included in the crtc. We cannot remove this > configuration option separately. Therefore, simply linking them together >

Re: [PATCH 01/64] media: omap3isp: Extract struct group for memcpy() region

On Wed, Jul 28, 2021 at 10:59:22AM +0200, David Sterba wrote: > > drivers/media/platform/omap3isp/ispstat.c | 5 +-- > > include/uapi/linux/omap3isp.h | 44 +-- > > 2 files changed, 36 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/media/platform/omap

Re: [PATCH v7] drm/bridge: add it6505 driver

Hey Allen, Sorry about the slow reviewing, let's have a look at this driver. Running 'checkpatch --strict' reveals a few checks and warnings that should be fixed. On Fri, 16 Jul 2021 at 09:38, allen wrote: > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP outp

Re: [PATCH v2 2/3] drm: clarify usage of drm leases

On 27/7/21 9:04 pm, Daniel Vetter wrote: On Sat, Jul 24, 2021 at 07:18:23PM +0800, Desmond Cheong Zhi Xi wrote: We make the following changes to the documentation of drm leases to make it easier to reason about their usage. In particular, we clarify the lifetime and locking rules of lease fields

Re: [PATCH 06/64] bnxt_en: Use struct_group_attr() for memcpy() region

On Tue, Jul 27, 2021 at 2:01 PM Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. > > Use struct_group() around members queue_id, min_bw

Re: [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

Am 27.07.21 um 20:27 schrieb Thomas Zimmermann: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. The interrupt number retur

[PATCH v3] drm: clarify usage of drm leases

We make the following changes to the documentation of drm leases to make it easier to reason about their usage. In particular, we clarify the lifetime and locking rules of lease fields in drm_master: 1. Make it clear that &drm_device.mode_config.idr_mutex protects the lease idr and list structures

Re: [PATCH v2 09/14] soc: mediatek: mmsys: Add reset controller support for MT8195 vdosys1

Hi Nancy, Missatge de Nancy.Lin del dia dc., 28 de jul. 2021 a les 8:01: > > Hi Enric, > > Thanks for your review. > > On Fri, 2021-07-23 at 12:57 +0200, Enric Balletbo Serra wrote: > > Hi Nancy, > > > > Thank you for your patch. > > > > Missatge de Nancy.Lin del dia dj., 22 de > > jul. > > 2021

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

On 28/07/2021 10:34, Jackie Liu wrote: > Hi Kieran. > > Thanks for replying to the email so quickly. > > 在 2021/7/28 下午4:58, Kieran Bingham 写道: >> Hi Jackie, >> >> On 28/07/2021 09:42, Jackie Liu wrote: >>> From: Jackie Liu >>> >>> After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM >

Re: [PATCH 04/64] stddef: Introduce struct_group() helper macro

On 27/07/2021 22.57, Kees Cook wrote: > In order to have a regular programmatic way to describe a struct > region that can be used for references and sizing, can be examined for > bounds checking, avoids forcing the use of intermediate identifiers, > and avoids polluting the global namespace, intr

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Jackie, On Wed, Jul 28, 2021 at 05:34:38PM +0800, Jackie Liu wrote: > 在 2021/7/28 下午4:58, Kieran Bingham 写道: > > On 28/07/2021 09:42, Jackie Liu wrote: > >> From: Jackie Liu > >> > >> After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM > >> operations"), > >> the cmm module must be

Re: [PATCH v1 1/5] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

Hi Jason, Missatge de Jason-JH Lin del dia dt., 27 de jul. 2021 a les 4:53: > > Hi Enric, > > On Mon, 2021-07-26 at 12:08 +0200, Enric Balletbo Serra wrote: > > Hi Jason, > > > > Missatge de Jason-JH Lin del dia dl., 26 > > de jul. 2021 a les 9:02: > > > > > > On Fri, 2021-07-23 at 13:13 +0200,

Re: [PATCH 2/2] drm/vc4: hdmi: Remove unused struct

On Wed, 7 Jul 2021 at 10:36, Maxime Ripard wrote: > > Commit 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") removed the > references to the vc4_hdmi_audio_component_drv structure, but not the > structure itself resulting in a warning. Remove it. > > Fixes: 91e99e113929 ("drm/vc4: hdmi: Regist

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Jackie, On 28/07/2021 10:57, Jackie Liu wrote: > Hi Kieran. > > How about this. > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig > b/drivers/gpu/drm/rcar-du/Kconfig > index b47e74421e34..14cf3e6415d7 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -

Re: [PATCH 1/5] drm/vmwgfx: unbind in vmw_ttm_unpopulate

Am 26.07.21 um 22:03 schrieb Dave Airlie: On Tue, 27 Jul 2021 at 05:35, Christian König wrote: Am 26.07.21 um 02:03 schrieb Dave Airlie: [SNIP] But you know, normal human: Only equipped with one head and two hands and not cloneable. I'm the same, but I'm not seeing where this problem happens

Re: [PATCH 34/64] fortify: Detect struct member overflows in memcpy() at compile-time

On 27/07/2021 22.58, Kees Cook wrote: > At its core, FORTIFY_SOURCE uses the compiler's __builtin_object_size() > internal[0] to determine the available size at a target address based on > the compile-time known structure layout details. It operates in two > modes: outer bounds (0) and inner bound

Re: [PATCH 62/64] netlink: Avoid false-positive memcpy() warning

On 28/07/2021 07.49, Greg Kroah-Hartman wrote: > On Tue, Jul 27, 2021 at 01:58:53PM -0700, Kees Cook wrote: >> In preparation for FORTIFY_SOURCE performing compile-time and run-time >> field bounds checking for memcpy(), memmove(), and memset(), avoid >> intentionally writing across neighboring fie

Re: [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking

Am 27.07.21 um 13:09 schrieb Daniel Vetter: Adding a few more people to this bikeshed. On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter wrote: @@ -349,6 +367,13 @@ int drm_sched_job_init(struct drm_sched_job *job, struct drm_sched_entity *entity,

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: > Hi Jackie, > > On 28/07/2021 10:57, Jackie Liu wrote: > > Hi Kieran. > > > > How about this. > > > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig > > b/drivers/gpu/drm/rcar-du/Kconfig > > index b47e74421e34..14cf3e6415d7 100644 >

Re: [RFC 0/4] dma-fence: Deadline awareness

Am 27.07.21 um 17:37 schrieb Rob Clark: On Tue, Jul 27, 2021 at 8:19 AM Michel Dänzer wrote: On 2021-07-27 5:12 p.m., Rob Clark wrote: On Tue, Jul 27, 2021 at 7:50 AM Michel Dänzer wrote: On 2021-07-27 1:38 a.m., Rob Clark wrote: From: Rob Clark Based on discussion from a previous series[

Re: [RFC 1/4] dma-fence: Add deadline awareness

Am 28.07.21 um 09:03 schrieb Christian König: Am 27.07.21 um 16:25 schrieb Rob Clark: On Tue, Jul 27, 2021 at 12:11 AM Christian König wrote: Am 27.07.21 um 01:38 schrieb Rob Clark: From: Rob Clark Add a way to hint to the fence signaler of an upcoming deadline, such as vblank, which the f

Re: [PATCH 2/2] drm/vc4: hdmi: Remove unused struct

On Wed, Jul 28, 2021 at 12:01:34PM +0100, Dave Stevenson wrote: > On Wed, 7 Jul 2021 at 10:36, Maxime Ripard wrote: > > > > Commit 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") removed the > > references to the vc4_hdmi_audio_component_drv structure, but not the > > structure itself resultin

Re: [PATCH 00/11] Implement generic prot_guest_has() helper function

Am 28.07.21 um 00:26 schrieb Tom Lendacky: This patch series provides a generic helper function, prot_guest_has(), to replace the sme_active(), sev_active(), sev_es_active() and mem_encrypt_active() functions. It is expected that as new protected virtualization technologies are added to the kern

Re: [PATCH] drm/vc4: hdmi: Add debugfs prefix

Hi, On Fri, Jul 23, 2021 at 09:24:14AM +0200, Ivan T. Ivanov wrote: > Without prefix debugfs can't properly create component > debug information tree when driver register more than > one component per device, in this case two. Fix this. > > debugfs: Directory 'fef00700.hdmi' with parent 'vc4-hdmi

[PATCH v3 2/2] arm64: dts: qcom: sc7280: Add gpu thermal zone cooling support

From: Manaf Meethalavalappu Pallikunhi Add cooling-cells property and the cooling maps for the gpu thermal zones to support GPU thermal cooling. Signed-off-by: Manaf Meethalavalappu Pallikunhi Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 29

[PATCH v3 1/2] arm64: dts: qcom: sc7280: Add gpu support

Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This has dependency on the below GPUCC bindings patch which is already accepted in clk-next: https://patchwork.kernel.org/project/linux-clk/list/?series=514831&state=%2A&archive=both Changes in v3: - Re-order

Re: [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking

On Wed, Jul 28, 2021 at 1:29 PM Christian König wrote: > Am 27.07.21 um 13:09 schrieb Daniel Vetter: > > Adding a few more people to this bikeshed. > > > > On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter > > wrote: > > > >> @@ -349,6 +367,13 @@ int drm_sched_job_init(struct drm_sched_job *job, >

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Jackie / Laurent, On 28/07/2021 12:30, Laurent Pinchart wrote: > On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: >> Hi Jackie, >> >> On 28/07/2021 10:57, Jackie Liu wrote: >>> Hi Kieran. >>> >>> How about this. >>> >>> diff --git a/drivers/gpu/drm/rcar-du/Kconfig >>> b/drivers/g

Re: [PATCH v7] drm/bridge: add it6505 driver

Hi Allen, On Fri, Jul 16, 2021 at 03:27:32PM +0800, allen wrote: > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Tested-by: Hsin-yi Wang > Signed-off-by: Hermes Wu > Signed-off-by: Allen Chen prompted by Roberts review here are

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Jackie On 28/07/2021 13:21, Jackie Liu wrote: > Hi Kieran. > > 在 2021/7/28 下午8:13, Kieran Bingham 写道: >> Hi Jackie / Laurent, >> >> On 28/07/2021 12:30, Laurent Pinchart wrote: >>> On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: Hi Jackie, On 28/07/2021 10:57, Ja

linux-next: build failure after merge of the amdgpu tree

Hi all, After merging the amdgpu tree, today's linux-next build (x86 allmodconfig) failed like this: ERROR: modpost: "dc_dsc_stream_bandwidth_in_kbps" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Probably caused by commit b6b76b0315ed7b ("drm/amd/display: Fixed EdidUtility build errors"

Re: [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking

Am 28.07.21 um 14:09 schrieb Daniel Vetter: On Wed, Jul 28, 2021 at 1:29 PM Christian König wrote: Am 27.07.21 um 13:09 schrieb Daniel Vetter: Adding a few more people to this bikeshed. On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter wrote: @@ -349,6 +367,13 @@ int drm_sched_job_init(struct

[PULL] drm-misc-fixes

Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. Besides the patches, it contains a backmerge of drm-fixes. Best regards Thomas drm-misc-fixes-2021-07-28: Short summary of fixes pull: * panel: Fix bpc for ytc700tlag_05_201c * ttm: debugfs init fixes The following changes since co

[PATCH 1/5] drm/vmwgfx: unbind in vmw_ttm_unpopulate

Doing this in vmw_ttm_destroy() is to late. It turned out that this is not a good idea at all because it leaves pointers to freed up system memory pages in the GART tables of the drivers. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 +++-- 1 file changed

[PATCH 2/5] drm/amdgpu: unbind in amdgpu_ttm_tt_unpopulate

Doing this in amdgpu_ttm_backend_destroy() is to late. It turned out that this is not a good idea at all because it leaves pointers to freed up system memory pages in the GART tables of the drivers. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++- 1 file chang

[PATCH 3/5] drm/nouveau: unbind in nouveau_ttm_tt_unpopulate

Doing this in nouveau_ttm_tt_destroy()/nouveau_sgdma_destroy() is to late. It turned out that this is not a good idea at all because it leaves pointers to freed up system memory pages in the GART tables of the drivers. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c|

[PATCH 4/5] drm/radeon: unbind in radeon_ttm_tt_unpopulate()

Doing this in radeon_ttm_tt_destroy() is to late. It turned out that this is not a good idea at all because it leaves pointers to freed up system memory pages in the GART tables of the drivers. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 5 ++--- 1 file changed, 2 i

[PATCH 5/5] drm/ttm: remove ttm_tt_destroy_common v2

Move the functionality into ttm_tt_fini and ttm_bo_tt_destroy instead. We don't need this any more since we removed the unbind from the destroy code paths in the drivers. Also add a warning to ttm_tt_fini() if we try to fini a still populated TT object. v2: instead of reverting the patch move th

Re: [RFC 0/4] dma-fence: Deadline awareness

On 2021-07-28 1:36 p.m., Christian König wrote: > Am 27.07.21 um 17:37 schrieb Rob Clark: >> On Tue, Jul 27, 2021 at 8:19 AM Michel Dänzer wrote: >>> On 2021-07-27 5:12 p.m., Rob Clark wrote: On Tue, Jul 27, 2021 at 7:50 AM Michel Dänzer wrote: > On 2021-07-27 1:38 a.m., Rob Clark wrote:

Re: [RFC 0/4] dma-fence: Deadline awareness

Am 28.07.21 um 15:08 schrieb Michel Dänzer: On 2021-07-28 1:36 p.m., Christian König wrote: Am 27.07.21 um 17:37 schrieb Rob Clark: On Tue, Jul 27, 2021 at 8:19 AM Michel Dänzer wrote: On 2021-07-27 5:12 p.m., Rob Clark wrote: On Tue, Jul 27, 2021 at 7:50 AM Michel Dänzer wrote: On 2021-07

Re: [RFC 0/4] dma-fence: Deadline awareness

On 2021-07-28 3:13 p.m., Christian König wrote: > Am 28.07.21 um 15:08 schrieb Michel Dänzer: >> On 2021-07-28 1:36 p.m., Christian König wrote: >>> Am 27.07.21 um 17:37 schrieb Rob Clark: On Tue, Jul 27, 2021 at 8:19 AM Michel Dänzer wrote: > On 2021-07-27 5:12 p.m., Rob Clark wrote: >>>

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

Hi, On Tue, Jul 27, 2021 at 11:20:54AM +0200, Daniel Vetter wrote: > On Mon, Jul 26, 2021 at 05:16:57PM +0200, Maxime Ripard wrote: > > Hi Daniel, > > > > On Wed, Jul 21, 2021 at 02:05:01PM +0200, Daniel Vetter wrote: > > > On Tue, Jul 20, 2021 at 03:45:19PM +0200, Maxime Ripard wrote: > > > > In

Re: [PATCH 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

Hi Thomas, On Tue, Jul 27, 2021 at 08:27:09PM +0200, Thomas Zimmermann wrote: > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > DRM IRQ callbacks are now being called directly

Re: [RFC 0/4] dma-fence: Deadline awareness

Am 28.07.21 um 15:24 schrieb Michel Dänzer: On 2021-07-28 3:13 p.m., Christian König wrote: Am 28.07.21 um 15:08 schrieb Michel Dänzer: On 2021-07-28 1:36 p.m., Christian König wrote: Am 27.07.21 um 17:37 schrieb Rob Clark: On Tue, Jul 27, 2021 at 8:19 AM Michel Dänzer wrote: On 2021-07-27

[PATCH v2 0/8] drm/bridge: Make panel and bridge probe order consistent

Hi, We've encountered an issue with the RaspberryPi DSI panel that prevented the whole display driver from probing. The issue is described in detail in the commit 7213246a803f ("drm/vc4: dsi: Only register our component once a DSI device is attached"), but the basic idea is that since the panel i

[PATCH v2 1/8] Revert "drm/vc4: dsi: Only register our component once a DSI device is attached"

This reverts commit 7213246a803f9b8da0677adb9ae06a3d8b806d02. The commit 7213246a803f ("drm/vc4: dsi: Only register our component once a DSI device is attached") aimed at preventing an endless probe loop between the DSI host driver and its panel/bridge where both would wait for each other to probe

[PATCH v2 2/8] drm/bridge: Add a function to abstract away panels

Display drivers so far need to have a lot of boilerplate to first retrieve either the panel or bridge that they are connected to using drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc functions or create a drm panel bridge through drm_panel_bridge_add. In order to reduce t

[PATCH v2 3/8] drm/bridge: Add documentation sections

The bridge documentation overview is quite packed already, and we'll add some more documentation that isn't part of an overview at all. Let's add some sections to the documentation to separate each bits. Reviewed-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- Documentation/gpu/drm-kms-helpe

[PATCH v2 4/8] drm/bridge: Document the probe issue with MIPI-DSI bridges

Interactions between bridges, panels, MIPI-DSI host and the component framework are not trivial and can lead to probing issues when implementing a display driver. Let's document the various cases we need too consider, and the solution to support all the cases. Signed-off-by: Maxime Ripard --- Do

[PATCH v2 6/8] drm/vc4: dsi: Switch to drm_of_get_bridge

The new drm_of_get_bridge removes most of the boilerplate we have to deal with. Let's switch to it. Signed-off-by: Maxime Ripard fixup! drm/vc4: dsi: Switch to drm_of_get_bridge --- drivers/gpu/drm/vc4/vc4_drv.c | 2 ++ drivers/gpu/drm/vc4/vc4_dsi.c | 28 2 files c

[PATCH v2 5/8] drm/panel: Create attach and detach callbacks

This is a partial revert of 87154ff86bf6 ("drm: Remove unnecessary drm_panel_attach and drm_panel_detach"). In order to make the probe order expectation more consistent between bridges, let's create attach and detach hooks for the panels as well to match what is there for bridges. Most drivers ha

[PATCH v2 8/8] drm/panel: raspberrypi-touchscreen: Remove MIPI-DSI driver

The driver was using a two-steps initialisation when probing with the i2c probe first registering the MIPI-DSI device, and then when that device was probed the driver would attach the device to its host. This resulted in a fairly non-standard probe logic. The previous commit changed that logic ent

[PATCH v2 7/8] drm/panel: raspberrypi-touchscreen: Use the attach hook

Now that we have an attach hook available for panels as well, let's use it for the RaspberryPi 7" DSI panel. This now mimics what all the other bridges in a similar situation are doing, and we avoid our probe order issue entirely. Signed-off-by: Maxime Ripard --- .../drm/panel/panel-raspberrypi

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

Hi Jagan, On Tue, Jul 27, 2021 at 03:12:09PM +0530, Jagan Teki wrote: > On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > > > Interactions between bridges, panels, MIPI-DSI host and the component > > framework are not trivial and can lead to probing issues when > > implementing a display d

RE: refactor the i915 GVT support

Hi Jason: I guess those APIs you were talking about are KVM-only. For other hypervisors, e.g. Xen, ARCN cannot use the APIs you mentioned. Not sure if you have already noticed that VFIO is KVM-only right now. GVT-g is designed for many hypervisors not only KVM. In the design, we implemented an

Re: refactor the i915 GVT support

A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH v2 1/5] drm/vc4: hdmi: Make sure the controller is powered up during bind

Hi Maxime On Wed, 7 Jul 2021 at 10:23, Maxime Ripard wrote: > > In the bind hook, we actually need the device to have the HSM clock > running during the final part of the display initialisation where we > reset the controller and initialise the CEC component. > > Failing to do so will result in a

Re: [PATCH v2 0/5] drm/vc4: hdmi: Fix CEC access while disabled

Hi Maxime On Wed, 7 Jul 2021 at 10:23, Maxime Ripard wrote: > > Hi, > > This series aims at fixing a complete and silent hang when one tries to use > CEC > while the display output is off. > > This can be tested with: > > echo off > /sys/class/drm/card0-HDMI-A-1/status > cec-ctl --tuner -p 1.0.0

Re: [RFC 0/4] dma-fence: Deadline awareness

On Wed, 28 Jul 2021 15:31:41 +0200 Christian König wrote: > Am 28.07.21 um 15:24 schrieb Michel Dänzer: > > On 2021-07-28 3:13 p.m., Christian König wrote: > >> Am 28.07.21 um 15:08 schrieb Michel Dänzer: > >>> On 2021-07-28 1:36 p.m., Christian König wrote: > At least AMD hardware is

Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

Hi Dan, I hope you can fine to test this patch from Thomas. If this works then we can forget about my attempt to do the same. Hi Thomas, IRQ_NOTCONNECTED check seems redundant, as mentioned in another patch already. With that considered: Reviewed-by: Sam Ravnborg We shall wait for testing fro

Re: [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

On Mon, Jan 11, 2021 at 07:45:02PM +0530, Sai Prakash Ranjan wrote: > commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") > removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went > the memory type setting required for the non-coherent masters to use > system cache.

Re: [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

On Wed, Jul 28, 2021 at 6:27 AM Christian König wrote: > > Am 27.07.21 um 20:27 schrieb Thomas Zimmermann: > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > don't benefit from using it. > > > > DRM IRQ ca

Re: [PATCH 14/14] drm: IRQ midlayer is now legacy

Hi Thomas, On Tue, Jul 27, 2021 at 08:27:21PM +0200, Thomas Zimmermann wrote: > Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use > the prefix drm_legacy_, and move declarations to drm_legacy.h. > In struct drm_device, move the fields irq and irq_enabled behind > CONFIG_DRM_LEGACY

[PATCH] drm/i915: Use Transparent Hugepages when IOMMU is enabled

From: Tvrtko Ursulin Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressions reported with an enabled IOMMU can be almost eliminated by turning them on, lets do that by adding a

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

在 2021/7/28 下午7:30, Laurent Pinchart 写道: On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: Hi Jackie, On 28/07/2021 10:57, Jackie Liu wrote: Hi Kieran. How about this. diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index b47e74421e34..14cf3e64

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Kieran. 在 2021/7/28 下午8:24, Kieran Bingham 写道: > Hi Jackie > > On 28/07/2021 13:21, Jackie Liu wrote: >> Hi Kieran. >> >> 在 2021/7/28 下午8:13, Kieran Bingham 写道: >>> Hi Jackie / Laurent, >>> >>> On 28/07/2021 12:30, Laurent Pinchart wrote: On Wed, Jul 28, 2021 at 12:09

Re: [PATCH 02/64] mac80211: Use flex-array for radiotap header bitmap

On Wed, Jul 28, 2021 at 10:35:56AM +0300, Dan Carpenter wrote: > @@ -372,7 +372,7 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local > *local, > ieee80211_calculate_rx_timestamp(local, status, >mpdulen, 0), >

[PATCH] drm: rcar-du: crtc: force depends on cmm

From: Jackie Liu After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"), the cmm module must be included in the crtc. We cannot remove this configuration option separately. Therefore, simply linking them together is the best solution, otherwise some errors will be reported.

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Kieran. How about this. diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index b47e74421e34..14cf3e6415d7 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 config DRM_RCAR_DU

Re: [PATCH 47/64] btrfs: Use memset_after() to clear end of struct

On Tue, Jul 27, 2021 at 01:58:38PM -0700, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Use memset_after() so memset() doesn't get confused about writing >

Re: [PATCH 01/64] media: omap3isp: Extract struct group for memcpy() region

On Tue, Jul 27, 2021 at 01:57:52PM -0700, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. Wrap the target region > in a common named str

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

On Mon, 26 Jul 2021 at 17:10, Tvrtko Ursulin wrote: > > > On 26/07/2021 16:14, Jason Ekstrand wrote: > > On Mon, Jul 26, 2021 at 3:31 AM Maarten Lankhorst > > wrote: > >> > >> Op 23-07-2021 om 13:34 schreef Matthew Auld: > >>> From: Chris Wilson > >>> > >>> Jason Ekstrand requested a more effici

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Kieran. 在 2021/7/28 下午8:13, Kieran Bingham 写道: Hi Jackie / Laurent, On 28/07/2021 12:30, Laurent Pinchart wrote: On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: Hi Jackie, On 28/07/2021 10:57, Jackie Liu wrote: Hi Kieran. How about this. diff --git a/drivers/gpu/drm/rca

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

Hi Kieran. Thanks for replying to the email so quickly. 在 2021/7/28 下午4:58, Kieran Bingham 写道: Hi Jackie, On 28/07/2021 09:42, Jackie Liu wrote: From: Jackie Liu After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"), the cmm module must be included in the crtc. We cann

Re: [RFC 0/4] dma-fence: Deadline awareness

Am 28.07.21 um 15:57 schrieb Pekka Paalanen: On Wed, 28 Jul 2021 15:31:41 +0200 Christian König wrote: Am 28.07.21 um 15:24 schrieb Michel Dänzer: On 2021-07-28 3:13 p.m., Christian König wrote: Am 28.07.21 um 15:08 schrieb Michel Dänzer: On 2021-07-28 1:36 p.m., Christian König wrote: At

Re: [RESEND PATCH v6 02/14] drm/sil164: Convert dev_printk to drm_dev_dbg

hi Sean, one little niggle here. On Wed, Jul 21, 2021 at 1:55 PM Sean Paul wrote: > > From: Sean Paul > > Use the drm debug helper instead of dev_printk in order to leverage the > upcoming tracefs support > > Signed-off-by: Sean Paul > Link: > https://patchwork.freedesktop.org/patch/msgid/202

  1   2   3   >