Re: [PATCH v4 3/4] drm/amd/display: Add control mechanism for FPU utilization

2021-07-27 Thread Christian König
Am 27.07.21 um 02:52 schrieb Rodrigo Siqueira: DC invokes DC_FPU_START/END in multiple parts of the code; this can create a situation where we invoke this FPU operation in a nested way or exit too early. For avoiding this situation, this commit adds a mechanism where dc_fpu_begin/end manages the

Re: [PATCH v4 4/4] drm/amd/display: Add DC_FP helper to check FPU state

2021-07-27 Thread Christian König
Am 27.07.21 um 02:52 schrieb Rodrigo Siqueira: To fully isolate FPU operations in a single place, we must avoid situations where compilers spill FP values to registers due to FP enable in a specific C file. Note that even if we isolate all FPU functions in a single file and call its interface fro

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread Ard Biesheuvel
On Tue, 27 Jul 2021 at 07:05, Randy Dunlap wrote: > > When # CONFIG_EFI is not set, there are 2 definitions of > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > and the __init function from sysfb_efi.c should not be used. > > ../drivers/firmware/efi/sysfb_efi.c:337:13: error: rede

Re: [RFC 1/4] dma-fence: Add deadline awareness

2021-07-27 Thread Christian König
Am 27.07.21 um 01:38 schrieb Rob Clark: From: Rob Clark Add a way to hint to the fence signaler of an upcoming deadline, such as vblank, which the fence waiter would prefer not to miss. This is to aid the fence signaler in making power management decisions, like boosting frequency as the deadl

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread Javier Martinez Canillas
On 7/27/21 7:04 AM, Randy Dunlap wrote: > When # CONFIG_EFI is not set, there are 2 definitions of > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > and the __init function from sysfb_efi.c should not be used. > > ../drivers/firmware/efi/sysfb_efi.c:337:13: error: redefinition of

Re: [PATCH v2] drm: add logging for RMFB ioctl

2021-07-27 Thread Pekka Paalanen
On Mon, 26 Jul 2021 22:04:21 +0200 Sam Ravnborg wrote: > Hi Simon, > > On Mon, Jul 26, 2021 at 07:49:06AM +, Simon Ser wrote: > > We already have logging for ADDFB2. Add some logging for RMFB as > > well. > > > > This can be handy when trying to find out why a CRTC gets magically > > disabl

Re: [PATCH] drm: document DRM_IOCTL_MODE_RMFB

2021-07-27 Thread Pekka Paalanen
On Mon, 26 Jul 2021 07:50:32 + Simon Ser wrote: > Since there's no struct to attach the docs to, document the IOCTL > definition. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Pekka Paalanen > Cc: Leandro Ribeiro > --- > include/uapi/drm/drm.h | 10 ++ > 1 file changed,

Re: [PATCH v3] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-07-27 Thread Sam Ravnborg
Hi Nicolas, On Tue, Jul 27, 2021 at 09:45:21AM +0800, Nicolas Boichat wrote: > Many of the DSI flags have names opposite to their actual effects, > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually > be disabled. Fix this by including _NO_ in the flag names, e.g. > MIPI_DSI_MODE_NO

Re: [Intel-gfx] [PATCH 31/47] drm/i915/guc: Reset implementation for new GuC interface

2021-07-27 Thread Tvrtko Ursulin
On 26/07/2021 23:48, Matthew Brost wrote: On Thu, Jul 15, 2021 at 10:36:51AM +0100, Tvrtko Ursulin wrote: On 24/06/2021 08:05, Matthew Brost wrote: Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Fu

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread Thomas Zimmermann
Hi Am 27.07.21 um 07:04 schrieb Randy Dunlap: When # CONFIG_EFI is not set, there are 2 definitions of sysfb_apply_efi_quirks(). The stub from sysfb.h should be used and the __init function from sysfb_efi.c should not be used. ../drivers/firmware/efi/sysfb_efi.c:337:13: error: redefinition of

Re: [PATCH v4 5/7] drm/panfrost: Add a new ioctl to submit batches

2021-07-27 Thread Daniel Vetter
On Mon, Jul 26, 2021 at 12:27:06PM +0200, Boris Brezillon wrote: > On Thu, 8 Jul 2021 14:10:45 +0200 > Christian König wrote: > > > >> --- a/drivers/gpu/drm/panfrost/panfrost_job.c > > >> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > > >> @@ -254,6 +254,9 @@ static int panfrost_acquire_object_f

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-27 Thread Daniel Vetter
On Mon, Jul 26, 2021 at 05:16:57PM +0200, Maxime Ripard wrote: > Hi Daniel, > > On Wed, Jul 21, 2021 at 02:05:01PM +0200, Daniel Vetter wrote: > > On Tue, Jul 20, 2021 at 03:45:19PM +0200, Maxime Ripard wrote: > > > Interactions between bridges, panels, MIPI-DSI host and the component > > > framew

Re: [PATCH] drm/panel-sony-acx424akp: Modernize backlight handling

2021-07-27 Thread Sam Ravnborg
Hi Linus, On Thu, Jul 15, 2021 at 11:28:08AM +0200, Linus Walleij wrote: > This converts the internal backlight in the Sony ACX424AKP > driver to do it the canonical way: > > - Assign the panel->backlight during probe. > - Let the panel framework handle the backlight. > - Make the backlight .set_

Re: [PATCH] drm: document drm_mode_get_property

2021-07-27 Thread Daniel Vetter
On Mon, Jul 26, 2021 at 08:34:14AM +, Simon Ser wrote: > On Wednesday, July 21st, 2021 at 13:39, Daniel Vetter wrote: > > > I think it would be really good to link to > > > > https://dri.freedesktop.org/docs/drm/gpu/drm-kms.html#modeset-base-object-abstraction > > > > for all the property rel

Re: [PATCH] drm: document drm_mode_get_property

2021-07-27 Thread Simon Ser
On Tuesday, July 27th, 2021 at 11:26, Daniel Vetter wrote: > I think the least intrusive one is `Title Test`_ or so. There's also other > places where we use :ref: but that's more cumbersome to read in plain > text. Yeah, tried it, doesn't work. The link doesn't appear.

Re: [PATCH 1/5] drm/vmwgfx: unbind in vmw_ttm_unpopulate

2021-07-27 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 06:03:12AM +1000, Dave Airlie wrote: > On Tue, 27 Jul 2021 at 05:35, Christian König > wrote: > > > > Am 26.07.21 um 02:03 schrieb Dave Airlie: > > > [SNIP] > > >> But you know, normal human: Only equipped with one head and two hands > > >> and not cloneable. > > > I'm the

Re: [PATCH v5 00/15] drm/i915: Introduce Intel PXP

2021-07-27 Thread Lionel Landwerlin
On 16/07/2021 07:10, Daniele Ceraolo Spurio wrote: PXP (Protected Xe Path) is an i915 component, available on GEN12+, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. The main changes in v5 are: - Rebased to n

[PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Javier Martinez Canillas
The Generic System Framebuffers support is built when the COMPILE_TEST option is enabled. But this wrongly assumes that all the architectures declare a struct screen_info. This is true for most architectures, but at least the following do not: arc, m68k, microblaze, openrisc, parisc and s390. By

Re: [PATCH v2 0/9] PCI/VGA: Rework default VGA device selection

2021-07-27 Thread Daniel Vetter
On Fri, Jul 23, 2021 at 05:43:35PM -0500, Bjorn Helgaas wrote: > On Fri, Jul 23, 2021 at 10:27:08AM +0200, Daniel Vetter wrote: > > On Fri, Jul 23, 2021 at 06:51:59AM +0100, Christoph Hellwig wrote: > > > On Thu, Jul 22, 2021 at 04:29:11PM -0500, Bjorn Helgaas wrote: > > > > From: Bjorn Helgaas >

Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

2021-07-27 Thread Daniel Vetter
On Fri, Jul 23, 2021 at 07:22:46PM +0200, Sam Ravnborg wrote: > On Fri, Jul 23, 2021 at 10:57:56AM +0200, Daniel Vetter wrote: > > On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote: > > > From: Chenyang Li > > > > > > This patch adds an initial DRM driver for the Loongson LS7A1000 > > >

Re: [PATCH v2] drm: add logging for RMFB ioctl

2021-07-27 Thread Daniel Vetter
On Mon, Jul 26, 2021 at 07:49:06AM +, Simon Ser wrote: > We already have logging for ADDFB2. Add some logging for RMFB as > well. > > This can be handy when trying to find out why a CRTC gets magically > disabled. > > v2: make log message more explicit, add log messages to > drm_framebuffer_r

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-27 Thread Jagan Teki
On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > Interactions between bridges, panels, MIPI-DSI host and the component > framework are not trivial and can lead to probing issues when > implementing a display driver. Let's document the various cases we need > too consider, and the solution

Re: [PATCH] drm: document DRM_IOCTL_MODE_RMFB

2021-07-27 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 11:09:13AM +0300, Pekka Paalanen wrote: > On Mon, 26 Jul 2021 07:50:32 + > Simon Ser wrote: > > > Since there's no struct to attach the docs to, document the IOCTL > > definition. > > > > Signed-off-by: Simon Ser > > Cc: Daniel Vetter > > Cc: Pekka Paalanen > > Cc:

Re: [PATCH 0/2] Add support for querying hw info that UMDs need

2021-07-27 Thread Daniel Vetter
On Mon, Jul 26, 2021 at 07:21:43PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > Various UMDs require hardware configuration information about the > current platform. A bunch of static information is available in a > fixed table that can be retrieved from the GuC. > > Test-wi

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 11:30:15AM +0200, Javier Martinez Canillas wrote: > The Generic System Framebuffers support is built when the COMPILE_TEST > option is enabled. But this wrongly assumes that all the architectures > declare a struct screen_info. > > This is true for most architectures, but a

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 11:15:36AM +0200, Thomas Zimmermann wrote: > Hi > > Am 27.07.21 um 07:04 schrieb Randy Dunlap: > > When # CONFIG_EFI is not set, there are 2 definitions of > > sysfb_apply_efi_quirks(). The stub from sysfb.h should be used > > and the __init function from sysfb_efi.c should

Re: [PATCH] drm/bridge: dw-mipi-dsi: Find the possible DSI devices

2021-07-27 Thread Robert Foss
Pushed to drm-misc-next

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Geert Uytterhoeven
Hi Javier, On Tue, Jul 27, 2021 at 11:33 AM Javier Martinez Canillas wrote: > The Generic System Framebuffers support is built when the COMPILE_TEST > option is enabled. But this wrongly assumes that all the architectures > declare a struct screen_info. > > This is true for most architectures, bu

Re: [PATCH 2/3] drm/plane: check that fb_damage is set up when used

2021-07-27 Thread Daniel Vetter
On Fri, Jul 23, 2021 at 10:34:56AM +0200, Daniel Vetter wrote: > There's two stages of manual upload/invalidate displays: > - just handling dirtyfb and uploading the entire fb all the time > - looking at damage clips > > In the latter case we support it through fbdev emulation (with > fb_defio), a

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-27 Thread Tvrtko Ursulin
On 26/07/2021 19:17, Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 11:31 AM Tvrtko Ursulin wrote: On 26/07/2021 17:20, Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 11:08 AM Tvrtko Ursulin wrote: On 26/07/2021 16:42, Jason Ekstrand wrote: On Mon, Jul 26, 2021 at 10:30 AM Jason Ekstrand

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Javier Martinez Canillas
Hello Geert, On 7/27/21 12:03 PM, Geert Uytterhoeven wrote: [snip] > Thanks for your patch! > You are welcome. >> --- a/drivers/firmware/Kconfig >> +++ b/drivers/firmware/Kconfig >> @@ -254,7 +254,7 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT >> config SYSFB >> bool >> default y

Re: [PATCH v3] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-07-27 Thread Nicolas Boichat
On Tue, Jul 27, 2021 at 4:35 PM Sam Ravnborg wrote: > > Hi Nicolas, > On Tue, Jul 27, 2021 at 09:45:21AM +0800, Nicolas Boichat wrote: > > Many of the DSI flags have names opposite to their actual effects, > > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually > > be disabled. Fix

Re: [RFC 3/4] drm/atomic-helper: Set fence deadline for vblank

2021-07-27 Thread Michel Dänzer
On 2021-07-27 1:38 a.m., Rob Clark wrote: > From: Rob Clark > > For an atomic commit updating a single CRTC (ie. a pageflip) calculate > the next vblank time, and inform the fence(s) of that deadline. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/drm_atomic_helper.c | 36 +++

Re: [PATCH v4 03/18] drm/sched: Add dependency tracking

2021-07-27 Thread Daniel Vetter
Adding a few more people to this bikeshed. On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter wrote: > @@ -349,6 +367,13 @@ int drm_sched_job_init(struct drm_sched_job *job, >struct drm_sched_entity *entity, >void *owner); > void drm_sched_job_arm(str

linux-next: manual merge of the drm-misc tree with the drm-next tree

2021-07-27 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/vmwgfx/vmwgfx_drv.h between commit: ebc9ac7c3dfe ("drm/vmwgfx: Update device headers") from the drm-next tree and commit: be4f77ac6884 ("drm/vmwgfx: Cleanup fifo mmio handling") from the drm-misc t

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Geert Uytterhoeven
Hi Javier, On Tue, Jul 27, 2021 at 12:22 PM Javier Martinez Canillas wrote: > On 7/27/21 12:03 PM, Geert Uytterhoeven wrote: > >> --- a/drivers/firmware/Kconfig > >> +++ b/drivers/firmware/Kconfig > >> @@ -254,7 +254,7 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT > >> config SYSFB > >> bool

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Javier Martinez Canillas
On 7/27/21 1:17 PM, Geert Uytterhoeven wrote: [snip] >> Not enabling this, would mean that a platform device to match a driver >> supporting the EFI GOP framebuffer (e.g: simple{drm,fb} or efifb) will >> not be registered. Which will lead to not having an early framebuffer. > > Do all (embedded)

Re: [PATCH 10/10] drm/i915: Remove i915_globals

2021-07-27 Thread Daniel Vetter
On Mon, Jul 26, 2021 at 10:51:26AM -0500, Jason Ekstrand wrote: > On Fri, Jul 23, 2021 at 2:29 PM Daniel Vetter wrote: > > > > No longer used. > > > > Cc: Jason Ekstrand > > Signed-off-by: Daniel Vetter > > Reviewed-by: Jason Ekstrand > > But, also, tvrtko is right that dumping all that stuff

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Geert Uytterhoeven
Hi Javier, On Tue, Jul 27, 2021 at 1:32 PM Javier Martinez Canillas wrote: > On 7/27/21 1:17 PM, Geert Uytterhoeven wrote: > >> Not enabling this, would mean that a platform device to match a driver > >> supporting the EFI GOP framebuffer (e.g: simple{drm,fb} or efifb) will > >> not be registered

Re: linux-next: manual merge of the drm-misc tree with the drm-next tree

2021-07-27 Thread Daniel Vetter
On Tue, Jul 27, 2021 at 1:15 PM Mark Brown wrote: > > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.h > > between commit: > > ebc9ac7c3dfe ("drm/vmwgfx: Update device headers") > > from the drm-next tree and commit: > > be4

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Mark Brown
On Tue, Jul 27, 2021 at 01:32:29PM +0200, Javier Martinez Canillas wrote: > On 7/27/21 1:17 PM, Geert Uytterhoeven wrote: > > Do all (embedded) EFI systems have a frame buffer? > That's a good question. I don't know if all EFI firmwares are expected > to provide a GOP or not. But even the u-boot

Re: [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes

2021-07-27 Thread Boris Brezillon
On Mon, 12 Jul 2021 19:53:34 +0200 Daniel Vetter wrote: > Hi all, > > Quick new version since the previous one was a bit too broken: > - dropped the bug-on patch to avoid breaking amdgpu's gpu reset failure > games > - another attempt at splitting job_init/arm, hopefully we're getting > ther

Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures

2021-07-27 Thread Javier Martinez Canillas
Hello Geert, On 7/27/21 1:39 PM, Geert Uytterhoeven wrote: [snip] >>> Perhaps SYSFB should be selected by SYSFB_SIMPLEFB, FB_VESA, >>> and FB_EFI? >> >> It's another option, yes. I just thought that the use of select was not >> encouraged and using depends was less fragile / error prone. > > Se

Re: linux-next: manual merge of the drm-misc tree with the drm-next tree

2021-07-27 Thread Mark Brown
On Tue, Jul 27, 2021 at 01:41:30PM +0200, Daniel Vetter wrote: > On Tue, Jul 27, 2021 at 1:15 PM Mark Brown wrote: > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.h > > between commit: > > ebc9ac7c3dfe ("drm/vmwgfx: Update device h

[PATCH v2 01/11] drm/i915: Check for nomodeset in i915_init() first

2021-07-27 Thread Daniel Vetter
When modesetting (aka the full pci driver, which has nothing to do with disable_display option, which just gives you the full pci driver without the display driver) is disabled, we load nothing and do nothing. So move that check first, for a bit of orderliness. With Jason's module init/exit table

[PATCH v2 03/11] drm/i915: move i915_buddy slab to direct module init/exit

2021-07-27 Thread Daniel Vetter
With the global kmem_cache shrink infrastructure gone there's nothing special and we can convert them over. I'm doing this split up into each patch because there's quite a bit of noise with removing the static global.slab_blocks to just a slab_blocks. v2: Make slab static (Jason, 0day) Reviewed-

[PATCH v2 02/11] drm/i915: move i915_active slab to direct module init/exit

2021-07-27 Thread Daniel Vetter
With the global kmem_cache shrink infrastructure gone there's nothing special and we can convert them over. I'm doing this split up into each patch because there's quite a bit of noise with removing the static global.slab_cache to just a slab_cache. v2: Make slab static (Jason, 0day) Reviewed-by

[PATCH v2 04/11] drm/i915: move intel_context slab to direct module init/exit

2021-07-27 Thread Daniel Vetter
With the global kmem_cache shrink infrastructure gone there's nothing special and we can convert them over. I'm doing this split up into each patch because there's quite a bit of noise with removing the static global.slab_ce to just a slab_ce. v2: Make slab static (Jason, 0day) Reviewed-by: Jaso

[PATCH v2 06/11] drm/i915: move gem_objects slab to direct module init/exit

2021-07-27 Thread Daniel Vetter
With the global kmem_cache shrink infrastructure gone there's nothing special and we can convert them over. I'm doing this split up into each patch because there's quite a bit of noise with removing the static global.slab_objects to just a slab_objects. v2: Make slab static (Jason, 0day) Reviewe

[PATCH v2 07/11] drm/i915: move request slabs to direct module init/exit

2021-07-27 Thread Daniel Vetter
With the global kmem_cache shrink infrastructure gone there's nothing special and we can convert them over. I'm doing this split up into each patch because there's quite a bit of noise with removing the static global.slab_requests|execute_cbs to just a slab_requests|execute_cbs. v2: Make slab sta

[PATCH v2 05/11] drm/i915: move gem_context slab to direct module init/exit

2021-07-27 Thread Daniel Vetter
With the global kmem_cache shrink infrastructure gone there's nothing special and we can convert them over. I'm doing this split up into each patch because there's quite a bit of noise with removing the static global.slab_luts to just a slab_luts. v2: Make slab static (Jason, 0day) Reviewed-by:

[PATCH v2 08/11] drm/i915: move scheduler slabs to direct module init/exit

2021-07-27 Thread Daniel Vetter
With the global kmem_cache shrink infrastructure gone there's nothing special and we can convert them over. I'm doing this split up into each patch because there's quite a bit of noise with removing the static global.slab_dependencies|priorities to just a slab_dependencies|priorities. v2: Make sl

[PATCH v2 10/11] drm/i915: Remove i915_globals

2021-07-27 Thread Daniel Vetter
No longer used. Cc: Jason Ekstrand Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/Makefile | 1 - drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 - drivers/gpu/drm/i915/i915_globals.c | 53 --- drivers/gpu/drm/i915/i915_globals.h | 25 - drive

[PATCH v2 09/11] drm/i915: move vma slab to direct module init/exit

2021-07-27 Thread Daniel Vetter
With the global kmem_cache shrink infrastructure gone there's nothing special and we can convert them over. I'm doing this split up into each patch because there's quite a bit of noise with removing the static global.slab_vmas to just a slab_vmas. We have to keep i915_drv.h include in i915_global

[PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-07-27 Thread Daniel Vetter
The module init code is somewhat misplaced in i915_pci.c, since it needs to pull in init/exit functions from every part of the driver and pollutes the include list a lot. Extract an i915_module.c file which pulls all the bits together, and allows us to massively trim the include list of i915_pci.c

Re: refactor the i915 GVT support

2021-07-27 Thread Jason Gunthorpe
On Thu, Jul 22, 2021 at 01:26:36PM +0200, Gerd Hoffmann wrote: > Hi, > > > https://github.com/intel/gvt-linux/blob/topic/gvt-xengt/drivers/gpu/drm/i915/gvt/xengt.c > > > But it's hard for some customers to contribute their own "hypervisor" > > module to the upstream Linux kernel. I am thinking

Re: [PATCH v2 2/3] drm: clarify usage of drm leases

2021-07-27 Thread Daniel Vetter
On Sat, Jul 24, 2021 at 07:18:23PM +0800, Desmond Cheong Zhi Xi wrote: > We make the following changes to the documentation of drm leases to > make it easier to reason about their usage. In particular, we clarify > the lifetime and locking rules of lease fields in drm_master: > > 1. Make it clear

Re: [PATCH v2 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-27 Thread Daniel Vetter
On Sat, Jul 24, 2021 at 07:18:22PM +0800, Desmond Cheong Zhi Xi wrote: > Inside drm_is_current_master, using the outer drm_device.master_mutex > to protect reads of drm_file.master makes the function prone to creating > lock hierarchy inversions. Instead, we can use the > drm_file.master_lookup_loc

[PATCH AUTOSEL 5.13 17/21] drm/amd/display: Fix comparison error in dcn21 DML

2021-07-27 Thread Sasha Levin
From: Victor Lu [ Upstream commit ec3102dc6b36c692104c4a0546d4119de59a3bc1 ] [why] A comparison error made it possible to not iterate through all the specified prefetch modes. [how] Correct "<" to "<=" Reviewed-by: Dmytro Laktyushkin Reviewed-by: Yongqiang Sun Acked-by: Rodrigo Siqueira Sig

[PATCH AUTOSEL 5.13 18/21] drm/amd/display: Fix max vstartup calculation for modes with borders

2021-07-27 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit d7940911fc0754d99b208f0e3098762d39f403a0 ] [Why] Vertical and horizontal borders in timings are treated as increasing the active area - vblank and hblank actually shrink. Our input into DML does not include these borders so it incorrectly assumes it h

[PATCH AUTOSEL 5.10 15/17] drm/amd/display: Fix comparison error in dcn21 DML

2021-07-27 Thread Sasha Levin
From: Victor Lu [ Upstream commit ec3102dc6b36c692104c4a0546d4119de59a3bc1 ] [why] A comparison error made it possible to not iterate through all the specified prefetch modes. [how] Correct "<" to "<=" Reviewed-by: Dmytro Laktyushkin Reviewed-by: Yongqiang Sun Acked-by: Rodrigo Siqueira Sig

[PATCH AUTOSEL 5.10 16/17] drm/amd/display: Fix max vstartup calculation for modes with borders

2021-07-27 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit d7940911fc0754d99b208f0e3098762d39f403a0 ] [Why] Vertical and horizontal borders in timings are treated as increasing the active area - vblank and hblank actually shrink. Our input into DML does not include these borders so it incorrectly assumes it h

Re: [PATCH 02/15] drm/i915/guc/slpc: Initial definitions for SLPC

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > Add macros to check for SLPC support. This feature is currently supported > for Gen12+ and enabled whenever GuC submission is enabled/selected. > > Include templates for SLPC init/fini and enable. > > v2: Move SLPC helper functions to intel_guc_sl

[PATCH v2 1/5] video: fbdev: ssd1307fb: Propagate errors via ssd1307fb_update_display()

2021-07-27 Thread Geert Uytterhoeven
Make ssd1307fb_update_display() return an error code, so callers that can handle failures can propagate it. Signed-off-by: Geert Uytterhoeven Acked-by: Sam Ravnborg --- v2: - Add Acked-by. --- drivers/video/fbdev/ssd1307fb.c | 18 -- 1 file changed, 12 insertions(+), 6 deletio

[PATCH v2 3/5] video: fbdev: ssd1307fb: Extract ssd1307fb_set_{col, page}_range()

2021-07-27 Thread Geert Uytterhoeven
Extract the code to set the column and page ranges into two helper functions. Signed-off-by: Geert Uytterhoeven Acked-by: Sam Ravnborg --- v2: - Use two separate helpers instead of a single combined helper, - Add Acked-by. --- drivers/video/fbdev/ssd1307fb.c | 57 +--

[PATCH v2 4/5] video: fbdev: ssd1307fb: Optimize screen updates

2021-07-27 Thread Geert Uytterhoeven
Currently, each screen update triggers an I2C transfer of all screen data, up to 1 KiB of data for a 128x64 display, which takes at least 20 ms in Fast mode. Reduce the amount of transferred data by only updating the rectangle that changed. Remove the calls to ssd1307fb_set_col_range() and ssd130

[PATCH v2 5/5] video: fbdev: ssd1307fb: Cache address ranges

2021-07-27 Thread Geert Uytterhoeven
Cache the column and page ranges, to avoid doing unneeded I2C transfers when the values haven't changed. Signed-off-by: Geert Uytterhoeven Acked-by: Sam Ravnborg --- v2: - Add Acked-by, - Rebase. --- drivers/video/fbdev/ssd1307fb.c | 27 +-- 1 file changed, 25 insert

[PATCH v2 2/5] video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display()

2021-07-27 Thread Geert Uytterhoeven
Simplify the nested loops to handle conversion from linear frame buffer to ssd1307 page layout: 1. Move last page handling one level up, as the value of "m" is the same inside a page, 2. array->data[] is filled linearly, so there is no need to recalculate array_idx over and over again

[PATCH v2 0/5] video: fbdev: ssd1307fb: Optimizations and improvements

2021-07-27 Thread Geert Uytterhoeven
Hi all, This patch series optimizes console operations on ssd1307fb, after the customary fixes and cleanups. Currently, each screen update triggers an I2C transfer of all screen data, up to 1 KiB of data for a 128x64 display, which takes at least 20 ms in Fast mode. While many displays a

Re: [Intel-gfx] [PATCH v3 3/5] drm/print: RFC add choice to use dynamic debug in drm-debug

2021-07-27 Thread Sean Paul
On Tue, Jul 20, 2021 at 03:29:34PM +0200, Daniel Vetter wrote: > On Wed, Jul 14, 2021 at 11:51:36AM -0600, Jim Cromie wrote: > > drm's debug system uses distinct categories of debug messages, encoded > > in an enum (DRM_UT_), which are mapped to bits in drm.debug. > > drm_debug_enabled() does a lot

Re: [PATCH 04/15] drm/i915/guc/slpc: Adding SLPC communication interfaces

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > Add constants and params that are needed to configure SLPC. > > v2: Add a new abi header for SLPC. Replace bitfields with > genmasks. Address other comments from Michal W. > > v3: Add slpc H2G format in abi, other review commments (Michal W) > >

Re: [Intel-gfx] [PATCH v3 3/5] drm/print: RFC add choice to use dynamic debug in drm-debug

2021-07-27 Thread Sean Paul
On Thu, Jul 22, 2021 at 11:20 AM Sean Paul wrote: > Reply-all fail. Adding everyone else back to my response. > On Tue, Jul 20, 2021 at 03:29:34PM +0200, Daniel Vetter wrote: > > On Wed, Jul 14, 2021 at 11:51:36AM -0600, Jim Cromie wrote: > > > drm's debug system uses distinct categories of debu

Re: [PATCH 05/15] drm/i915/guc/slpc: Allocate, initialize and release SLPC

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > Allocate data structures for SLPC and functions for > initializing on host side. > > v2: Address review comments (Michal W) > v3: Remove unnecessary header includes (Michal W) > > Signed-off-by: Vinay Belgaumkar > Signed-off-by: Sundaresan Sujari

Re: [PATCH] Fix i.MX IPU-v3 offset calculations for (semi)planar U/V formats

2021-07-27 Thread Philipp Zabel
On Mon, 2021-06-07 at 12:49 +0200, Krzysztof Hałasa wrote: > Video captured in 1400x1050 resolution (bytesperline aka stride = 1408 > bytes) is invalid. Fix it. > > Signed-off-by: Krzysztof Halasa Thank you, I've prefixed the subject with "gpu: ipu-v3:" and applied to imx-drm/next. regards Phil

Re: [PATCH v2] gpu: ipu-v3: use swap()

2021-07-27 Thread Philipp Zabel
On Tue, 2021-07-13 at 15:05 +0100, Salah Triki wrote: > Use swap() instead of implementing it since it makes code cleaner. > > Signed-off-by: Salah Triki > --- > > Changes since v1: > - Remove the declaration of tmp > - Fix typo in the description Thank you, I've changed the subject

Re: [RFC 1/4] dma-fence: Add deadline awareness

2021-07-27 Thread Rob Clark
On Tue, Jul 27, 2021 at 12:11 AM Christian König wrote: > > Am 27.07.21 um 01:38 schrieb Rob Clark: > > From: Rob Clark > > > > Add a way to hint to the fence signaler of an upcoming deadline, such as > > vblank, which the fence waiter would prefer not to miss. This is to aid > > the fence signa

Re: [RFC 3/4] drm/atomic-helper: Set fence deadline for vblank

2021-07-27 Thread Rob Clark
On Tue, Jul 27, 2021 at 3:44 AM Michel Dänzer wrote: > > On 2021-07-27 1:38 a.m., Rob Clark wrote: > > From: Rob Clark > > > > For an atomic commit updating a single CRTC (ie. a pageflip) calculate > > the next vblank time, and inform the fence(s) of that deadline. > > > > Signed-off-by: Rob Clar

Re: [PATCH] drm/pl111: Remove unused including

2021-07-27 Thread Randy Dunlap
On 7/26/21 10:21 PM, Cai Huoqing wrote: > Remove including that don't need it. > > Signed-off-by: Cai Huoqing Acked-by: Randy Dunlap as reported by 'make versioncheck': ../drivers/gpu/drm/pl111/pl111_display.c: 14 linux/version.h not needed. ../drivers/gpu/drm/pl111/pl111_drv.c: 47 linux/ver

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-27 Thread Michel Dänzer
On 2021-07-27 1:38 a.m., Rob Clark wrote: > From: Rob Clark > > Based on discussion from a previous series[1] to add a "boost" mechanism > when, for example, vblank deadlines are missed. Instead of a boost > callback, this approach adds a way to set a deadline on the fence, by > which the waiter

Re: [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-07-27 Thread Tvrtko Ursulin
On 27/07/2021 13:10, Daniel Vetter wrote: The module init code is somewhat misplaced in i915_pci.c, since it needs to pull in init/exit functions from every part of the driver and pollutes the include list a lot. Extract an i915_module.c file which pulls all the bits together, and allows us to

Re: [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes

2021-07-27 Thread Melissa Wen
On 07/12, Daniel Vetter wrote: > Hi all, > > Quick new version since the previous one was a bit too broken: > - dropped the bug-on patch to avoid breaking amdgpu's gpu reset failure > games > - another attempt at splitting job_init/arm, hopefully we're getting > there. > > Note that Christian

Re: [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-27 Thread Peter Zijlstra
On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: > > Inside drm_is_current_master, using the outer drm_device.master_mutex > > to protect reads of drm_file.master makes the function prone to creating > > lock hie

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-27 Thread Rob Clark
On Tue, Jul 27, 2021 at 7:50 AM Michel Dänzer wrote: > > On 2021-07-27 1:38 a.m., Rob Clark wrote: > > From: Rob Clark > > > > Based on discussion from a previous series[1] to add a "boost" mechanism > > when, for example, vblank deadlines are missed. Instead of a boost > > callback, this approa

Re: [Intel-gfx] [PATCH 06/15] drm/i915/guc/slpc: Enable SLPC and add related H2G events

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > Add methods for interacting with GuC for enabling SLPC. Enable > SLPC after GuC submission has been established. GuC load will > fail if SLPC cannot be successfully initialized. Add various > helper methods to set/unset the parameters for SLPC. They

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-27 Thread Michel Dänzer
On 2021-07-27 5:12 p.m., Rob Clark wrote: > On Tue, Jul 27, 2021 at 7:50 AM Michel Dänzer wrote: >> >> On 2021-07-27 1:38 a.m., Rob Clark wrote: >>> From: Rob Clark >>> >>> Based on discussion from a previous series[1] to add a "boost" mechanism >>> when, for example, vblank deadlines are missed.

Re: [Intel-gfx] [PATCH 08/15] drm/i915/guc/slpc: Add methods to set min/max frequency

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > Add param set h2g helpers to set the min and max frequencies s/h2g/H2G > for use by SLPC. > > v2: Address review comments (Michal W) > v3: Check for positive error code (Michal W) > > Signed-off-by: Sundaresan Sujaritha > Signed-off-by: Vinay B

Re: [PATCH v2 0/5] video: fbdev: ssd1307fb: Optimizations and improvements

2021-07-27 Thread Sam Ravnborg
Hi Geert, On Tue, Jul 27, 2021 at 03:47:25PM +0200, Geert Uytterhoeven wrote: > Hi all, > > This patch series optimizes console operations on ssd1307fb, after the > customary fixes and cleanups. > > Currently, each screen update triggers an I2C transfer of all screen > data, up to 1 KiB of

Re: [Intel-gfx] [PATCH 09/15] drm/i915/guc/slpc: Add get max/min freq hooks

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > Add helpers to read the min/max frequency being used > by SLPC. This is done by send a H2G command which forces > SLPC to update the shared data struct which can then be > read. These helpers will be used in a sysfs patch later > on. > > v2: Addres

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-27 Thread Rob Clark
On Tue, Jul 27, 2021 at 8:19 AM Michel Dänzer wrote: > > On 2021-07-27 5:12 p.m., Rob Clark wrote: > > On Tue, Jul 27, 2021 at 7:50 AM Michel Dänzer wrote: > >> > >> On 2021-07-27 1:38 a.m., Rob Clark wrote: > >>> From: Rob Clark > >>> > >>> Based on discussion from a previous series[1] to add a

Re: [PATCH 15/15] drm/i915/guc/rc: Setup and enable GUCRC feature

2021-07-27 Thread Matt Roper
On Mon, Jul 26, 2021 at 12:08:00PM -0700, Vinay Belgaumkar wrote: > This feature hands over the control of HW RC6 to the GuC. > GuC decides when to put HW into RC6 based on it's internal > busyness algorithms. > > GUCRC needs GuC submission to be enabled, and only > supported on Gen12+ for now. >

Re: [PATCH 10/15] drm/i915/guc/slpc: Add debugfs for SLPC info

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > This prints out relevant SLPC info from the SLPC shared structure. > > We will send a h2g message which forces SLPC to update the s/h2g/H2G > shared data structure with latest information before reading it. > > v2: Address review comments (Micha

Re: [PATCH 11/15] drm/i915/guc/slpc: Enable ARAT timer interrupt

2021-07-27 Thread Matthew Brost
On Mon, Jul 26, 2021 at 12:07:56PM -0700, Vinay Belgaumkar wrote: > This interrupt is enabled during RPS initialization, and > now needs to be done by SLPC code. It allows ARAT timer > expiry interrupts to get forwarded to GuC. > > Signed-off-by: Vinay Belgaumkar > --- > drivers/gpu/drm/i915/gt/

Re: [PATCH 12/15] drm/i915/guc/slpc: Cache platform frequency limits

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > Cache rp0, rp1 and rpn platform limits into SLPC structure > for range checking while setting min/max frequencies. > > Also add "soft" limits which keep track of frequency changes > made from userland. These are initially set to platform min > and

[pull] drm/msm: drm-msm-fixes-2021-07-27 for v5.14-rc4

2021-07-27 Thread Rob Clark
Hi Dave & Daniel, A few fixes for v5.14, including a fix for a crash if display triggers an iommu fault (which tends to happen at probe time on devices with bootloader fw that leaves display enabled as kernel starts) The following changes since commit ff1176468d368232b684f75e82563369208bc371:

[PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select

2021-07-27 Thread Marek Vasut
Decoder input LVDS format is a property of the decoder chip or even its strapping. Add DT property data-mapping the same way lvds-panel does, to define the LVDS data mapping. Signed-off-by: Marek Vasut Cc: Laurent Pinchart Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org To: dri

[PATCH V4 2/2] drm/bridge: lvds-codec: Add support for LVDS data mapping select

2021-07-27 Thread Marek Vasut
Decoder input LVDS format is a property of the decoder chip or even its strapping. Handle data-mapping the same way lvds-panel does. In case data-mapping is not present, do nothing, since there are still legacy bindings which do not specify this property. Signed-off-by: Marek Vasut Cc: Laurent Pi

Re: [PATCH 15/15] drm/i915/guc/rc: Setup and enable GUCRC feature

2021-07-27 Thread Belgaumkar, Vinay
On 7/27/2021 8:37 AM, Matt Roper wrote: On Mon, Jul 26, 2021 at 12:08:00PM -0700, Vinay Belgaumkar wrote: This feature hands over the control of HW RC6 to the GuC. GuC decides when to put HW into RC6 based on it's internal busyness algorithms. GUCRC needs GuC submission to be enabled, and on

Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-27 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Randy-Dunlap/efi-sysfb_efi-fix-build-when-EFI-is-not-set/20210727-130620 base:2265c5286967c58db9a99ed1b74105977507e690 config: x86_64-randc

Re: [PATCH 13/15] drm/i915/guc/slpc: Sysfs hooks for SLPC

2021-07-27 Thread Michal Wajdeczko
On 26.07.2021 21:07, Vinay Belgaumkar wrote: > Update the get/set min/max freq hooks to work for > SLPC case as well. Consolidate helpers for requested/min/max > frequency get/set to intel_rps where the proper action can > be taken depending on whether SLPC is enabled. > > v2: Add wrappers for

[PATCH v3 00/13] drm/msm: drm scheduler conversion and cleanups

2021-07-27 Thread Rob Clark
From: Rob Clark Conversion to gpu_scheduler, and bonus removal of drm_gem_object_put_locked() v2: Fix priority mixup (msm UAPI has lower numeric priority value as higher priority, inverse of drm/scheduler) and add some comments in the UAPI header to clarify. Now that we move active

  1   2   3   4   >