Re: [RESEND PATCH v6 00/14] drm/trace: Mirror DRM debug logs to tracefs

2021-07-22 Thread Sean Paul
On Thu, Jul 22, 2021 at 9:48 AM Sean Paul wrote: > > On Thu, Jul 22, 2021 at 3:49 AM Pekka Paalanen wrote: > > > > On Wed, 21 Jul 2021 13:55:07 -0400 > > Sean Paul wrote: > > > > > From: Sean Paul > > > > > > Hi all, > > > I just had the pleasure of rebasing this set on our CrOS downstream > >

Re: [Intel-gfx] [PATCH 24/47] drm/i915/guc: Add several request trace points

2021-07-22 Thread Tvrtko Ursulin
On 20/07/2021 02:59, Matthew Brost wrote: On Tue, Jul 13, 2021 at 10:06:17AM +0100, Tvrtko Ursulin wrote: On 24/06/2021 08:04, Matthew Brost wrote: Add trace points for request dependencies and GuC submit. Extended existing request trace points to include submit fence value,, guc_id, and rin

Re: [Intel-gfx] [PATCH] drm/i915: Ditch i915 globals shrink infrastructure

2021-07-22 Thread Tvrtko Ursulin
On 22/07/2021 14:37, Jason Ekstrand wrote: On Thu, Jul 22, 2021 at 5:34 AM Tvrtko Ursulin wrote: On 22/07/2021 11:16, Daniel Vetter wrote: On Thu, Jul 22, 2021 at 11:02:55AM +0100, Tvrtko Ursulin wrote: On 21/07/2021 19:32, Daniel Vetter wrote: This essentially reverts commit 84a107492052

Re: [PATCH 5.12 237/242] drm/ast: Remove reference to struct drm_device.pdev

2021-07-22 Thread Greg Kroah-Hartman
On Mon, Jul 19, 2021 at 04:35:21PM +0200, Thomas Zimmermann wrote: > hi > > Am 19.07.21 um 13:23 schrieb Greg Kroah-Hartman: > > On Mon, Jul 19, 2021 at 05:57:30PM +0800, Xiaotian Feng wrote: > > > On Fri, Jul 16, 2021 at 5:13 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > From: Thomas Zimme

Re: [PATCH 3/3] drm/panel-simple: add Gopher 2b LCD panel

2021-07-22 Thread Paul Cercueil
Hi Artjom, Le jeu., juil. 22 2021 at 17:04:32 +0300, Artjom Vejsel a écrit : The Gopher 2b LCD panel is used in Gopher 2b handhelds. It's simple panel with NewVision NV3047 driver, but SPI lines are not connected. It has no specific name, since it's unique to that handhelds. lot name at AliExp

Re: [PATCH 2/3] drm: clarify lifetime/locking for drm_master's lease fields

2021-07-22 Thread Daniel Vetter
On Thu, Jul 22, 2021 at 3:03 PM Desmond Cheong Zhi Xi wrote: > > On 22/7/21 6:35 pm, Daniel Vetter wrote: > > On Thu, Jul 22, 2021 at 05:29:28PM +0800, Desmond Cheong Zhi Xi wrote: > >> In particular, we make it clear that &drm_device.mode_config.idr_mutex > >> protects the lease idr and list stru

Re: [PATCH v3] drm/shmobile: Convert to Linux IRQ interfaces

2021-07-22 Thread Thomas Zimmermann
Hi, if there are no further comments on this patch, I'd like to merge it soon. Am 20.07.21 um 10:09 schrieb Thomas Zimmermann: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. v3:

Re: [PATCH v2 04/14] vfio: Provide better generic support for open/release vfio_device_ops

2021-07-22 Thread Cornelia Huck
On Tue, Jul 20 2021, Jason Gunthorpe wrote: > Currently the driver ops have an open/release pair that is called once > each time a device FD is opened or closed. Add an additional set of > open/close_device() ops which are called when the device FD is opened for > the first time and closed for th

[PATCH] backlight: pwm_bl: Improve bootloader/kernel device handover

2021-07-22 Thread Daniel Thompson
Currently there are (at least) two problems in the way pwm_bl starts managing the enable_gpio pin. Both occur when the backlight is initially off and the driver finds the pin not already in output mode and, as a result, unconditionally switches it to output-mode and asserts the signal. Problem 1:

Re: [PATCH v2 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme

2021-07-22 Thread Cornelia Huck
On Tue, Jul 20 2021, Jason Gunthorpe wrote: > Platform simply wants to run some code when the device is first > opened/last closed. Use the core framework and locking for this. Aside > from removing a bit of code this narrows the locking scope from a global > lock. > > Signed-off-by: Yishai Hada

Re: [PATCH] drm/mediatek: mtk-dpi: Set out_fmt from config if not the last bridge

2021-07-22 Thread Chun-Kuang Hu
Hi, Hsin-yi: Hsin-Yi Wang 於 2021年7月12日 週一 下午5:47寫道: > > atomic_get_output_bus_fmts() is only called when the bridge is the last > element in the bridge chain. > > If mtk-dpi is not the last bridge, the format of output_bus_cfg is > MEDIA_BUS_FMT_FIXED, and mtk_dpi_dual_edge() will fail to write c

[PATCH v2] backlight: pwm_bl: Improve bootloader/kernel device handover

2021-07-22 Thread Daniel Thompson
Currently there are (at least) two problems in the way pwm_bl starts managing the enable_gpio pin. Both occur when the backlight is initially off and the driver finds the pin not already in output mode and, as a result, unconditionally switches it to output-mode and asserts the signal. Problem 1:

Re: [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Rob Clark
On Thu, Jul 22, 2021 at 1:42 AM Christian König wrote: > > Am 21.07.21 um 21:03 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 09:34:43AM -0700, Rob Clark wrote: > >> On Wed, Jul 21, 2021 at 12:59 AM Daniel Vetter wrote: > >>> On Wed, Jul 21, 2021 at 12:32 AM Rob Clark wrote: > On Tue,

Re: [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Rob Clark
On Thu, Jul 22, 2021 at 2:28 AM Christian König wrote: > > Am 22.07.21 um 11:08 schrieb Daniel Vetter: > > [SNIP] > >> As far as I know wake_up_state() tries to run the thread on the CPU it was > >> scheduled last, while wait_event_* makes the thread run on the CPU who > >> issues the wake by defa

Re: [Intel-gfx] [PATCH 06/51] drm/i915/guc: Implement GuC context operations for new inteface

2021-07-22 Thread Matthew Brost
On Thu, Jul 22, 2021 at 09:57:00AM +0200, Michal Wajdeczko wrote: > > > On 22.07.2021 01:51, Daniele Ceraolo Spurio wrote: > > > > > > On 7/19/2021 9:04 PM, Matthew Brost wrote: > >> On Mon, Jul 19, 2021 at 05:51:46PM -0700, Daniele Ceraolo Spurio wrote: > >>> > >>> On 7/16/2021 1:16 PM, Matthe

[PATCH 3/3] drm/panel-simple: add Gopher 2b LCD panel

2021-07-22 Thread Artjom Vejsel
The Gopher 2b LCD panel is used in Gopher 2b handhelds. It's simple panel with NewVision NV3047 driver, but SPI lines are not connected. It has no specific name, since it's unique to that handhelds. lot name at AliExpress: 4.3 inch 40PIN TFT LCD Screen COG NV3047 Drive IC 480(RGB)*272 No Touch 24Bi

Re: [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-22 Thread Boqun Feng
On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: > > Inside drm_is_current_master, using the outer drm_device.master_mutex > > to protect reads of drm_file.master makes the function prone to creating > > lock hie

[PATCH 0/3] add Gopher 2b LCD panel

2021-07-22 Thread Artjom Vejsel
The Gopher 2b LCD panel is used in Gopher 2b handhelds. It's simple panel with NewVision NV3047 driver, but SPI lines are not connected. It has no specific name, since it's unique to that handhelds. lot name at AliExpress: 4.3 inch 40PIN TFT LCD Screen COG NV3047 Drive IC 480(RGB)*272 No Touch 24Bi

[PATCH 1/3] dt-bindings: Add QiShenglong vendor prefix

2021-07-22 Thread Artjom Vejsel
Add vendor prefix for Shenzhen QiShenglong Industrialist Co., Ltd. QiShenglong is a Chinese manufacturer of handheld gaming consoles, most of which run (very old) versions of Linux. QiShenglong is known as Hamy. Signed-off-by: Artjom Vejsel --- Documentation/devicetree/bindings/vendor-prefixes.y

[PATCH 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel

2021-07-22 Thread Artjom Vejsel
Add DT bindings for QiShenglong Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel. Signed-off-by: Artjom Vejsel --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/D

Re: [PATCH v4 10/13] lib: test_hmm add module param for zone device type

2021-07-22 Thread Sierra Guiza, Alejandro (Alex)
On 7/22/2021 7:23 AM, Jason Gunthorpe wrote: On Sat, Jul 17, 2021 at 02:21:32PM -0500, Alex Sierra wrote: In order to configure device generic in test_hmm, two module parameters should be passed, which correspon to the SP start address of each device (2) spm_addr_dev0 & spm_addr_dev1. If no pa

[RESEND] gpu: ipu-v3: use swap()

2021-07-22 Thread Salah Triki
Use swap() instead of implementing it since it makes code cleaner. Signed-off-by: Salah Triki --- drivers/gpu/ipu-v3/ipu-image-convert.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c i

Re: [PATCH 1/4] drm/vmwgfx: Add support for CursorMob and CursorBypass 4

2021-07-22 Thread Zack Rusin
On 7/14/21 3:30 AM, Thomas Zimmermann wrote: @@ -301,8 +301,12 @@ static void vmw_print_capabilities2(uint32_t capabilities2)   DRM_INFO("  Grow oTable.\n"); These macros have been out of fashion for a while. There's drm_info(), drm_warn(), drm_err(), etc as replacements. They also pri

Re: [PATCH v4 10/13] lib: test_hmm add module param for zone device type

2021-07-22 Thread Jason Gunthorpe
On Thu, Jul 22, 2021 at 11:59:17AM -0500, Sierra Guiza, Alejandro (Alex) wrote: > > On 7/22/2021 7:23 AM, Jason Gunthorpe wrote: > > On Sat, Jul 17, 2021 at 02:21:32PM -0500, Alex Sierra wrote: > > > In order to configure device generic in test_hmm, two > > > module parameters should be passed, wh

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Andreas (icedragon...@web.de) changed: What|Removed |Added Kernel Version|5.12.11 - 5.13.3|5.12.11 - 5.13.4 -- You

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Andreas (icedragon...@web.de) changed: What|Removed |Added Kernel Version|5.12.11 - 5.13.4|5.13.4 --- Comment #18 fr

Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-07-22 Thread Lyude Paul
On Tue, 2021-07-13 at 15:24 -0700, khs...@codeaurora.org wrote: > On 2021-07-07 01:37, Jani Nikula wrote: > > On Tue, 06 Jul 2021, Kuogee Hsieh wrote: > > > From: Rajkumar Subbiah > > > > > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + > > > selftests") added some debug

[RFC PATCH] drm/i915/guc/slpc: slpc_decode_min_freq() can be static

2021-07-22 Thread kernel test robot
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:217:5: warning: symbol 'slpc_decode_min_freq' was not declared. Should it be static? drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:229:5: warning: symbol 'slpc_decode_max_freq' was not declared. Should it be static? Reported-by: kernel test robot Signed

Re: [PATCH 06/14] drm/i915/guc/slpc: Enable SLPC and add related H2G events

2021-07-22 Thread kernel test robot
Hi Vinay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.14-rc2 next-20210722] [If your patch is applied to the wrong git tree

Re: [PATCH v4 2/4] drm/shmem-helper: Switch to vmf_insert_pfn

2021-07-22 Thread Thomas Zimmermann
Hi, I'm not knowledgeable enougth to give this a full review. If you can just answer my questions, fell free to add an Acked-by: Thomas Zimmermann to the patch. :) Am 13.07.21 um 22:51 schrieb Daniel Vetter: We want to stop gup, which isn't the case if we use vmf_insert_page What is gup?

Re: [PATCH v4 3/4] drm/shmem-helpers: Allocate wc pages on x86

2021-07-22 Thread Thomas Zimmermann
Hi Am 13.07.21 um 22:51 schrieb Daniel Vetter: intel-gfx-ci realized that something is not quite coherent anymore on some platforms for our i915+vgem tests, when I tried to switch vgem over to shmem helpers. After lots of head-scratching I realized that I've removed calls to drm_clflush. And we

Re: [PATCH v4 4/4] drm/vgem: use shmem helpers

2021-07-22 Thread Thomas Zimmermann
Hi Am 13.07.21 um 22:51 schrieb Daniel Vetter: Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a

Re: [PATCH v2 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:01) > DP cable should always connect to DPU during the entire PHY compliance > testing run. Since DP PHY compliance test is executed at irq_hpd event > context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off(). > dp_ctrl_off() is used for unpl

Re: [PATCH] backlight: pwm_bl: Avoid backlight flicker if backlight control GPIO is input

2021-07-22 Thread Marek Vasut
On 7/22/21 1:28 PM, Daniel Thompson wrote: On Wed, Jul 21, 2021 at 08:46:42PM +0200, Marek Vasut wrote: On 7/21/21 6:12 PM, Daniel Thompson wrote: On Wed, Jul 21, 2021 at 05:09:57PM +0200, Marek Vasut wrote: On 7/21/21 12:49 PM, Daniel Thompson wrote: I'm not sure that's correct, we can simpl

Re: [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-22 Thread Daniel Vetter
On Thu, Jul 22, 2021 at 6:00 PM Boqun Feng wrote: > > On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: > > > Inside drm_is_current_master, using the outer drm_device.master_mutex > > > to protect reads of drm_

Re: [PATCH v2 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:02) > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index 27fb0f0..92cf331 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -1634,6 +1617,24 @@ void dp_ctrl_handle_sink_reques

Re: [PATCH v2 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:03) > Aux hardware calibration sequence requires resetting the aux controller > in order for the new setting to take effect. However resetting the AUX > controller will also clear HPD interrupt status which may accidentally > cause pending unplug interrupt to

Re: [PATCH v2 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:07) > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index 6a013b0..20951c8 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -1638,6 +1638,25 @@ static bool dp_ctrl_clock_recov

Re: [PATCH v2 6/7] drm/msm/dp: do not end dp link training until video is ready

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:06) > Initialize both pre-emphasis and voltage swing level to 0 before > start link training and do not end link training until video is > ready to reduce the period between end of link training and video > start to meet Link Layer CTS requirement. This fixes

Re: [PATCH 3/3] drm/vmwgfx: fix potential UAF in vmwgfx_surface.c

2021-07-22 Thread Zack Rusin
On 7/22/21 5:29 AM, Desmond Cheong Zhi Xi wrote: drm_file.master should be protected by either drm_device.master_mutex or drm_file.master_lookup_lock when being dereferenced. However, drm_master_get is called on unprotected file_priv->master pointers in vmw_surface_define_ioctl and vmw_gb_surface

Re: [PATCH v2 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:05) > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c > b/drivers/gpu/drm/msm/dp/dp_panel.c > index 88196f7..0fdb551 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -303,7 +303,12 @@ void dp_panel_handle_sink_req

Re: [PATCH v2 4/7] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-07-22 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-13 08:54:04) > Remove special handling of replug interrupt and instead treat replug event > as a sequential unplug followed by a plugin event. This is needed to meet > the requirements of DP Link Layer CTS test case 4.2.1.3. > > Changes in V2: > -- add fixes statement

nouveau broken again on Riva TNT2 in 5.14.0-rc2

2021-07-22 Thread Ondrej Zary
Hello, nouveau is broken again: [ 58.795794] BUG: kernel NULL pointer dereference, address: 017c [ 58.795835] #PF: supervisor read access in kernel mode [ 58.795844] #PF: error_code(0x) - not-present page [ 58.795851] *pde = [ 58.795862] Oops: [#1] SMP [ 58.795875

Re: [PATCH 1/5] dt-bindings: msm/dp: Change reg definition

2021-07-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-21 19:42:23) > reg was defined as one region covering the entire DP block, but the > memory map is actually split in 4 regions and obviously the size of > these regions differs between platforms. > > Switch the reg to require that all four regions are specified inst

Re: [PATCH v3 3/5] drm/print: RFC add choice to use dynamic debug in drm-debug

2021-07-22 Thread jim . cromie
Thanks for the feedback! On Tue, Jul 20, 2021 at 9:29 AM Daniel Vetter wrote: > > On Wed, Jul 14, 2021 at 11:51:36AM -0600, Jim Cromie wrote: > > drm's debug system uses distinct categories of debug messages, encoded > > in an enum (DRM_UT_), which are mapped to bits in drm.debug. > > drm_debug_

Re: nouveau broken again on Riva TNT2 in 5.14.0-rc2

2021-07-22 Thread Karol Herbst
hey thanks for the report. This is a known issue and the fix is pending in drm-mist-fixes and should land in 5.14 soonish. On Thu, Jul 22, 2021 at 9:29 PM Ondrej Zary wrote: > > Hello, > nouveau is broken again: > > [ 58.795794] BUG: kernel NULL pointer dereference, address: 017c > [ 58.

Re: [PATCH 43/51] drm/i915/guc: Support request cancellation

2021-07-22 Thread Daniele Ceraolo Spurio
On 7/16/2021 1:17 PM, Matthew Brost wrote: This adds GuC backend support for i915_request_cancel(), which in turn makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. This needs a bit of explanation on why we're using fences for this instead of other simpler options. Signed-off-by: Matthew Brost

[Bug 213823] New: Broken power management for amdgpu

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213823 Bug ID: 213823 Summary: Broken power management for amdgpu Product: Drivers Version: 2.5 Kernel Version: 5.13.4 Hardware: All OS: Linux Tree: Mainline

[Bug 213823] Broken power management for amdgpu

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213823 Bruno Pagani (bruno.n.pag...@gmail.com) changed: What|Removed |Added CC||bruno.n.pag...@g

[Bug 213823] Broken power management for amdgpu

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213823 Bruno Pagani (bruno.n.pag...@gmail.com) changed: What|Removed |Added Regression|No |Yes -- You may

Re: [PATCH 2/5] drm/msm/dp: Use devres for ioremap()

2021-07-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-21 19:42:24) > The non-devres version of ioremap is used, which requires manual > cleanup. But the code paths leading here is mixed with other devres > users, so rely on this for ioremap as well to simplify the code. > > Signed-off-by: Bjorn Andersson > --- Review

Re: [PATCH 3/5] drm/msm/dp: Refactor ioremap wrapper

2021-07-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-21 19:42:25) > In order to deal with multiple memory ranges in the following commit > change the ioremap wrapper to not poke directly into the dss_io_data > struct. > > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/dp/dp_parser.c | 28 ++--

Re: [PATCH 4/5] drm/msm/dp: Store each subblock in the io region

2021-07-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-21 19:42:26) > Not all platforms has DP_P0 at offset 0x1000 from the beginning of the > DP block. So dss_io_data into representing each of the sub-regions, to "So dss_io_data into" doesn't make sense to me. Is some word or words missing? > make it possible in the

Re: [PATCH 43/51] drm/i915/guc: Support request cancellation

2021-07-22 Thread Matthew Brost
On Thu, Jul 22, 2021 at 12:56:56PM -0700, Daniele Ceraolo Spurio wrote: > > > On 7/16/2021 1:17 PM, Matthew Brost wrote: > > This adds GuC backend support for i915_request_cancel(), which in turn > > makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. > > This needs a bit of explanation on why we're usi

Re: [PATCH 5/5] drm/msm/dp: Allow sub-regions to be specified in DT

2021-07-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-21 19:42:27) > Not all platforms has P0 at an offset of 0x1000 from the base address, > so add support for specifying each sub-region in DT. The code falls back > to the predefined offsets in the case that only a single reg is > specified, in order to support existi

Re: [PATCH] drm/msm/dp: Initialize the INTF_CONFIG register

2021-07-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-21 19:44:34) > Some bootloaders set the widebus enable bit in the INTF_CONFIG register, > but configuration of widebus isn't yet supported ensure that the > register has a known value, with widebus disabled. > > Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driv

[Bug 213823] Broken power management for amdgpu

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213823 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v2 1/2] drm/msm/dsi: update dsi register header file for tpg

2021-07-22 Thread Stephen Boyd
Quoting Abhinav Kumar (2021-07-21 19:50:31) > Update the DSI controller header XML file to add registers > and bitfields to support rectangular checkered pattern > generator. > > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 2/2] drm/msm/dsi: add support for dsi test pattern generator

2021-07-22 Thread Stephen Boyd
Quoting Abhinav Kumar (2021-07-21 19:50:32) > During board bringups its useful to have a DSI test pattern > generator to isolate a DPU vs a DSI issue and focus on the relevant > hardware block. > > To facilitate this, add an API which triggers the DSI controller > test pattern. The expected output

Re: [PATCH 50/51] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Daniele Ceraolo Spurio
On 7/16/2021 1:17 PM, Matthew Brost wrote: Implement a simple static mapping algorithm of the i915 priority levels (int, -1k to 1k exposed to user) to the 4 GuC levels. Mapping is as follows: i915 level < 0 -> GuC low level (3) i915 level == 0 -> GuC normal level (2) i91

Re: [PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-22 Thread Stephen Boyd
Quoting maitreye (2021-07-21 16:19:40) > From: Maitreyee Rao > > Add trace points across the MSM DP driver to help debug > interop issues. > > Changes in v4: > - Changed goto statement and used if else-if I think drm likes to see all the changelog here to see patch evolution. > > Signed-off-by:

[PATCH v2 0/9] PCI/VGA: Rework default VGA device selection

2021-07-22 Thread Bjorn Helgaas
From: Bjorn Helgaas This is a little bit of rework and extension of Huacai's nice work at [1]. It moves the VGA arbiter to the PCI subsystem, fixes a few nits, and breaks a few pieces off Huacai's patch to make the main patch a little smaller. That last patch is still not very small, and it nee

[PATCH v2 1/9] PCI/VGA: Move vgaarb to drivers/pci

2021-07-22 Thread Bjorn Helgaas
From: Bjorn Helgaas The VGA arbiter is really PCI-specific and doesn't depend on any GPU things. Move it to the PCI subsystem. Signed-off-by: Bjorn Helgaas --- drivers/gpu/vga/Kconfig | 19 --- drivers/gpu/vga/Makefile | 1 - drivers/pci/Kconfig

[PATCH v2 2/9] PCI/VGA: Replace full MIT license text with SPDX identifier

2021-07-22 Thread Bjorn Helgaas
From: Bjorn Helgaas Per Documentation/process/license-rules.rst, the SPDX MIT identifier is equivalent to including the entire MIT license text from LICENSES/preferred/MIT. Replace the MIT license text with the equivalent SPDX identifier. Signed-off-by: Bjorn Helgaas --- drivers/pci/vgaarb.c

[PATCH v2 3/9] PCI/VGA: Use unsigned format string to print lock counts

2021-07-22 Thread Bjorn Helgaas
From: Bjorn Helgaas In struct vga_device, io_lock_cnt and mem_lock_cnt are unsigned, but we previously printed them with "%d", the signed decimal format. Print them with the unsigned format "%u" instead. Signed-off-by: Bjorn Helgaas --- drivers/pci/vgaarb.c | 2 +- 1 file changed, 1 insertion

[PATCH v2 5/9] PCI/VGA: Move vga_arb_integrated_gpu() earlier in file

2021-07-22 Thread Bjorn Helgaas
From: Huacai Chen Move vga_arb_integrated_gpu() earlier in file to prepare for future patch. No functional change intended. [bhelgaas: split to separate patch] Link: https://lore.kernel.org/r/20210705100503.1120643-1-chenhua...@loongson.cn Signed-off-by: Huacai Chen Signed-off-by: Bjorn Helgaas

[PATCH v2 4/9] PCI/VGA: Remove empty vga_arb_device_card_gone()

2021-07-22 Thread Bjorn Helgaas
From: Bjorn Helgaas vga_arb_device_card_gone() has always been empty. Remove it. Signed-off-by: Bjorn Helgaas --- drivers/pci/vgaarb.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c index e4153ab70481..c984c76b3

[PATCH v2 7/9] PCI/VGA: Split out vga_arb_update_default_device()

2021-07-22 Thread Bjorn Helgaas
From: Huacai Chen If there's no default VGA device, and we find a VGA device that owns the legacy VGA resources, we make that device the default. Split this logic out from vga_arbiter_add_pci_device() into a new function, vga_arb_update_default_device(). [bhelgaas: split another piece to separa

[PATCH v2 9/9] PCI/VGA: Rework default VGA device selection

2021-07-22 Thread Bjorn Helgaas
From: Huacai Chen Needs a better subject and a commit log. Link: https://lore.kernel.org/r/20210705100503.1120643-1-chenhua...@loongson.cn --- drivers/pci/vgaarb.c | 158 ++- 1 file changed, 66 insertions(+), 92 deletions(-) diff --git a/drivers/pci/vgaa

[PATCH v2 8/9] PCI/VGA: Log bridge control messages when adding devices

2021-07-22 Thread Bjorn Helgaas
From: Huacai Chen Previously vga_arb_device_init() iterated through all VGA devices and indicated whether legacy VGA routing to each could be controlled by an upstream bridge. But we determine that information in vga_arbiter_add_pci_device(), which we call for every device, so we can log it ther

[PATCH v2 6/9] PCI/VGA: Prefer vga_default_device()

2021-07-22 Thread Bjorn Helgaas
From: Huacai Chen Use the vga_default_device() interface consistently instead of directly testing vga_default. No functional change intended. [bhelgaas: split to separate patch and extended] Link: https://lore.kernel.org/r/20210705100503.1120643-1-chenhua...@loongson.cn Signed-off-by: Huacai Ch

Re: [PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-22 Thread maitreye
Thank you Stephen. On 2021-07-22 13:31, Stephen Boyd wrote: Quoting maitreye (2021-07-21 16:19:40) From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v4: - Changed goto statement and used if else-if I think drm likes to see all the chang

Re: [PATCH 50/51] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Matthew Brost
On Thu, Jul 22, 2021 at 01:26:30PM -0700, Daniele Ceraolo Spurio wrote: > > > On 7/16/2021 1:17 PM, Matthew Brost wrote: > > Implement a simple static mapping algorithm of the i915 priority levels > > (int, -1k to 1k exposed to user) to the 4 GuC levels. Mapping is as > > follows: > > > > i915 l

Re: [PATCH v2 1/9] PCI/VGA: Move vgaarb to drivers/pci

2021-07-22 Thread Randy Dunlap
On 7/22/21 2:29 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The VGA arbiter is really PCI-specific and doesn't depend on any GPU > things. Move it to the PCI subsystem. > > Signed-off-by: Bjorn Helgaas > --- > drivers/gpu/vga/Kconfig | 19 --- > drivers/gpu/vg

Re: [PATCH 50/51] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Daniele Ceraolo Spurio
@@ -1756,15 +1796,119 @@ static int guc_context_alloc(struct intel_context *ce) return lrc_alloc(ce, ce->engine); } +static void guc_context_set_prio(struct intel_guc *guc, +struct intel_context *ce, +u8 prio) +{ +

Re: [PATCH 50/51] drm/i915/guc: Implement GuC priority management

2021-07-22 Thread Matthew Brost
On Thu, Jul 22, 2021 at 02:50:24PM -0700, Daniele Ceraolo Spurio wrote: > > > > > > > @@ -1756,15 +1796,119 @@ static int guc_context_alloc(struct > > > > intel_context *ce) > > > > return lrc_alloc(ce, ce->engine); > > > >} > > > > +static void guc_context_set_prio(struct intel_guc

Re: [PATCH v2 1/9] PCI/VGA: Move vgaarb to drivers/pci

2021-07-22 Thread Bjorn Helgaas
On Thu, Jul 22, 2021 at 02:38:43PM -0700, Randy Dunlap wrote: > On 7/22/21 2:29 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > The VGA arbiter is really PCI-specific and doesn't depend on any GPU > > things. Move it to the PCI subsystem. > > > > Signed-off-by: Bjorn Helgaas > > --- >

[Bug 213823] Broken power management for amdgpu

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213823 --- Comment #3 from Bruno Pagani (bruno.n.pag...@gmail.com) --- Created attachment 298009 --> https://bugzilla.kernel.org/attachment.cgi?id=298009&action=edit dmesg 5.12 -- You may reply to this email to add a comment. You are receiving this

[Bug 213823] Broken power management for amdgpu

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213823 --- Comment #4 from Bruno Pagani (bruno.n.pag...@gmail.com) --- Created attachment 298011 --> https://bugzilla.kernel.org/attachment.cgi?id=298011&action=edit dmesg 5.13 -- You may reply to this email to add a comment. You are receiving this

Re: [PATCH v4] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-22 Thread Stephen Boyd
Quoting maitr...@codeaurora.org (2021-07-22 14:33:43) > Thank you Stephen. > > On 2021-07-22 13:31, Stephen Boyd wrote: > > Quoting maitreye (2021-07-21 16:19:40) > >> From: Maitreyee Rao > >> > >> Add trace points across the MSM DP driver to help debug > >> interop issues. > >> > >> Changes in v4

[Bug 213823] Broken power management for amdgpu

2021-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213823 --- Comment #5 from Bruno Pagani (bruno.n.pag...@gmail.com) --- (In reply to Alex Deucher from comment #2) > Please attach your full dmesg outputs. Can you bisect? Done. Unfortunately no: I’ve never done so before, so while I expect to be techni

[PATCH] drm/msm/dp: signal audio plugged change at dp_pm_resume

2021-07-22 Thread Kuogee Hsieh
There is a scenario that dp cable is unplugged from DUT during system suspended will cause audio option state does not match real connection state. Fix this problem by Signaling audio plugged change with realtime connection status at dp_pm_resume() so that audio option will be in correct state aft

[PATCH 0/3] drm/msm: Improved devfreq tuning

2021-07-22 Thread Rob Clark
From: Rob Clark This is the outcome of trying to fix some bad gpu freq behavior seen in some use-cases, in particular mobile games that throttle themselves to 30fps. With the existing tuning, we'd end up spending most of the time that we should be running fast at a low freq, and most of the idle

[PATCH 1/3] drm/msm: Split out devfreq handling

2021-07-22 Thread Rob Clark
From: Rob Clark Before we start adding more cleverness, split it into it's own file. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 +- drivers/gpu/drm/msm/msm_gpu.c | 116 +- drivers/gpu/drm/m

[PATCH 2/3] drm/msm: Split out get_freq() helper

2021-07-22 Thread Rob Clark
From: Rob Clark In the next patch, it grows a bit more, so lets not duplicate the logic in multiple places. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gpu

[PATCH 3/3] drm/msm: Devfreq tuning

2021-07-22 Thread Rob Clark
From: Rob Clark This adds a few things to try and make frequency scaling better match the workload: 1) Longer polling interval to avoid whip-lashing between too-high and too-low frequencies in certain workloads, like mobile games which throttle themselves to 30fps. Previously our polli

Re: [PATCH v4] drm/mediatek: Fix cursor plane didn't update

2021-07-22 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月22日 週四 上午9:47寫道: > > The cursor plane should use the current plane state in atomic_async_update > because it would not be the new plane state in the global atomic state > since _swap_state happened when those hook are run. > > Fix cursor plane issue by below modif

Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-07-22 Thread khsieh
On 2021-07-22 10:53, Lyude Paul wrote: On Tue, 2021-07-13 at 15:24 -0700, khs...@codeaurora.org wrote: On 2021-07-07 01:37, Jani Nikula wrote: > On Tue, 06 Jul 2021, Kuogee Hsieh wrote: > > From: Rajkumar Subbiah > > > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + > >

[PATCH] dma-buf: heaps: Set allocation limit for system heap

2021-07-22 Thread Hridya Valsaraju
This patch limits the size of total memory that can be requested in a single allocation from the system heap. This would prevent a buggy/malicious client from depleting system memory by requesting for an extremely large allocation which might destabilize the system. The limit is set to half the si

Re: [PATCH 2/3] drm/plane: check that fb_damage is set up when used

2021-07-22 Thread Souza, Jose
On Wed, 2021-07-21 at 15:30 +0200, Daniel Vetter wrote: > There's two stages of manual upload/invalidate displays: > - just handling dirtyfb and uploading the entire fb all the time > - looking at damage clips > > In the latter case we support it through fbdev emulation (with > fb_defio), atomic p

Re: [PATCH 3/3] drm/plane: Move drm_plane_enable_fb_damage_clips into core

2021-07-22 Thread Souza, Jose
On Wed, 2021-07-21 at 15:30 +0200, Daniel Vetter wrote: > We're trying to have a fairly strict split between core functionality > that defines the uapi, including the docs, and the helper functions to > implement it. > > Move drm_plane_enable_fb_damage_clips and associated kerneldoc into > drm_pla

Re: [PATCH 1/3] drm/plane: remove drm_helper_get_plane_damage_clips

2021-07-22 Thread Souza, Jose
On Wed, 2021-07-21 at 15:30 +0200, Daniel Vetter wrote: > It's not used. Drivers should instead use the helpers anyway. > > Currently both vbox and i915 hand-roll this and it's not the greatest. > vbox looks buggy, and i915 does a bit much that helpers would take > care of I think. > > Also impro

[PATCH 03/33] drm/i915: Hold reference to intel_context over life of i915_request

2021-07-22 Thread Matthew Brost
Hold a reference to the intel_context over life of an i915_request. Without this an i915_request can exist after the context has been destroyed (e.g. request retired, context closed, but user space holds a reference to the request from an out fence). In the case of GuC submission + virtual engine,

[PATCH 08/33] drm/i915/guc: Reset implementation for new GuC interface

2021-07-22 Thread Matthew Brost
Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Future patches will offload the engine hang check to GuC but we will continue to maintain this legacy path as a fallback and this code path is also required

[PATCH 02/33] drm/i915/guc: Make hangcheck work with GuC virtual engines

2021-07-22 Thread Matthew Brost
From: John Harrison The serial number tracking of engines happens at the backend of request submission and was expecting to only be given physical engines. However, in GuC submission mode, the decomposition of virtual to physical engines does not happen in i915. Instead, requests are submitted to

[PATCH 00/33] Remaining patches for basic GuC submission

2021-07-22 Thread Matthew Brost
The remaining patches for basic GuC submission [1]. Need 4 more RB and CI results to get this merged. Signed-off-by: Matthew Brost [1] https://patchwork.freedesktop.org/series/91840/ Daniele Ceraolo Spurio (1): drm/i915/guc: Unblock GuC submission on Gen11+ John Harrison (11): drm/i915/gu

[PATCH 04/33] drm/i915/guc: Disable bonding extension with GuC submission

2021-07-22 Thread Matthew Brost
Update the bonding extension to return -ENODEV when using GuC submission as this extension fundamentally will not work with the GuC submission interface. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 + 1 file changed, 5 insertio

[PATCH 12/33] drm/i915/guc: Handle context reset notification

2021-07-22 Thread Matthew Brost
GuC will issue a reset on detecting an engine hang and will notify the driver via a G2H message. The driver will service the notification by resetting the guilty context to a simple state or banning it completely. v2: (John Harrison) - Move msg[0] lookup after length check v3: (John Harrison)

[PATCH 11/33] drm/i915/guc: Suspend/resume implementation for new interface

2021-07-22 Thread Matthew Brost
The new GuC interface introduces an MMIO H2G command, INTEL_GUC_ACTION_RESET_CLIENT, which is used to implement suspend. This MMIO tears down any active contexts generating a context reset G2H CTB for each. Once that step completes the GuC tears down the CTB channels. It is safe to suspend once thi

[PATCH 09/33] drm/i915: Reset GPU immediately if submission is disabled

2021-07-22 Thread Matthew Brost
If submission is disabled by the backend for any reason, reset the GPU immediately in the heartbeat code as the backend can't be reenabled until the GPU is reset. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 63 +++

<    1   2   3   >