Re: [PATCH 2/2 v4] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-15 Thread Linus Walleij
On Thu, Jul 15, 2021 at 4:25 AM Doug Anderson wrote: > > - Alter the logic so that we assign the backlight handle to > > panel->backlight directly and save some code. > > Officially this is disallowed according to comments. ...and I quote: > > /** > * @backlight: > * > * Backlight device, us

[PATCH] drm/panel: Document internal backlight handling

2021-07-15 Thread Linus Walleij
Panels with internal backlight need to assign their backlight member directly. Reported-by: Doug Anderson Signed-off-by: Linus Walleij --- include/drm/drm_panel.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 336

Re: [PATCH v3 0/2] allow simple{fb, drm} drivers to be used on non-x86 EFI platforms

2021-07-15 Thread Thomas Zimmermann
Hi Am 13.07.21 um 18:59 schrieb Javier Martinez Canillas: On 6/25/21 3:09 PM, Javier Martinez Canillas wrote: The simplefb and simpledrm drivers match against a "simple-framebuffer" device, but for aarch64 this is only registered when using Device Trees and there's a node with a "simple-framebu

Re: [PATCH] drm/omapdrm: Remove outdated comment

2021-07-15 Thread Thomas Zimmermann
ping for review Am 06.07.21 um 09:31 schrieb Thomas Zimmermann: The comment refers to drm_irq_install() et al, which are not used by omapdrm. The functions are part of the DRM IRQ midlayer and shouldn't be used any longer. Remove the comment. Signed-off-by: Thomas Zimmermann --- drivers/gpu/

[PULL] drm-misc-fixes

2021-07-15 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the PR for drm-misc-fixes. I merged drm-misc-next-fixes into it to pick up patches that were left over from the previous release cycle. The vmwgfx change comes from that. The other patches fix current errors. Best regards Thomas drm-misc-fixes-2021-07-15: Short summary

Re: [PATCH v6 06/11] drm/mediatek: Add pm runtime support for ovl and rdma

2021-07-15 Thread Yong Wu
On Wed, 2021-07-14 at 10:44 +0200, Dafna Hirschfeld wrote: > > On 14.07.21 04:56, Yong Wu wrote: > > From: Yongqiang Niu > > > > Prepare for smi cleaning up "mediatek,larb". > > > > Display use the dispsys device to call pm_rumtime_get_sync before. > > This patch add pm_runtime_xx with ovl and

Re: [PATCH v6 00/11] Clean up "mediatek,larb"

2021-07-15 Thread Yong Wu
On Wed, 2021-07-14 at 10:56 +0200, Dafna Hirschfeld wrote: > Hi > > Thanks for the patchset. > > I tested it on mt8173 (elm) with chromeos userspace. > Before that patchset, the test: > > tast -verbose run -build=false 10.42.0.175 video.DecodeAccel.h264 > > sometimes passed and sometimes failed

Re: [PATCH 02/13] vfio: Introduce a vfio_uninit_group_dev() API call

2021-07-15 Thread Leon Romanovsky
On Wed, Jul 14, 2021 at 09:20:31PM -0300, Jason Gunthorpe wrote: > From: Max Gurtovoy > > This pairs with vfio_init_group_dev() and allows undoing any state that is > stored in the vfio_device unrelated to registration. Add appropriately > placed calls to all the drivers. > > The following patch

Re: Aw: [PATCH v6 00/11] Clean up "mediatek,larb"

2021-07-15 Thread Yong Wu
On Wed, 2021-07-14 at 10:59 +0200, Frank Wunderlich wrote: > Hi, > > sorry this (or the 2 depency-series) cause a NULL Pointer deref in > iommu_group_remove_device on mt7623/bpi-r2 Hi Frank, Thanks for your report. mt7623 use mtk_iommu_v1.c. I will try to reproduce this locally. > > i wonder

[PATCH] drivers/gpu/drm/i915/display: remove boilerplate code using LOCK_ALL macros

2021-07-15 Thread Marco Kurzynski
Replaced the boilerplate code for intel_display.c with DRM_MODESET_LOCK_ALL macros per the TODO in gpu (I apologize if I did something wrong, this is my first contribution of hopefully many, so excited!!!) Signed-off-by: Marco Kurzynski --- drivers/gpu/drm/i915/display/intel_display.c | 14 ++--

[PATCH] drm/msm: mdp4: drop vblank get/put from prepare/complete_commit

2021-07-15 Thread David Heidelberg
msm_atomic is doing vblank get/put's already, currently there no need to duplicate the effort in MDP4 Fix warning: ... WARNING: CPU: 3 PID: 79 at drivers/gpu/drm/drm_vblank.c:1194 drm_vblank_put+0x1cc/0x1d4 ... and multiple vblank time-outs: ... msm 510.mdp: vblank time out, crtc=1 ... Teste

[PATCH] drm/ttm: add a check against null pointer dereference

2021-07-15 Thread Zheyu Ma
When calling ttm_range_man_fini(), 'man' may be uninitialized, which may cause a null pointer dereference bug. Fix this by checking if it is a null pointer. This log reveals it: [7.902580 ] BUG: kernel NULL pointer dereference, address: 0058 [7.905721 ] RIP: 0010:ttm_range_ma

Re: [PATCH v6 03/11] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-07-15 Thread Yong Wu
On Wed, 2021-07-14 at 10:26 +0200, Dafna Hirschfeld wrote: > > On 14.07.21 04:56, Yong Wu wrote: > > MediaTek IOMMU-SMI diagram is like below. all the consumer connect with > > smi-larb, then connect with smi-common. > > > > M4U > > | > > smi-common > > | > >

Re: [PATCH] drm/omapdrm: Remove outdated comment

2021-07-15 Thread Daniel Vetter
On Thu, Jul 15, 2021 at 10:13 AM Thomas Zimmermann wrote: > > ping for review > > Am 06.07.21 um 09:31 schrieb Thomas Zimmermann: > > The comment refers to drm_irq_install() et al, which are not used by > > omapdrm. The functions are part of the DRM IRQ midlayer and shouldn't > > be used any longe

Re: [PATCH 0/3] drm/vc4: hdmi: Interrupt fixes

2021-07-15 Thread Maxime Ripard
On Wed, Jul 07, 2021 at 11:05:12AM +0100, Dave Stevenson wrote: > Hi Maxime > > On Wed, 7 Jul 2021 at 10:51, Maxime Ripard wrote: > > > > Hi, > > > > Those are three fixes for race conditions we currently have in the vc4 HDMI > > driver with regard to the interrupts handling. > > > > The first tw

Re: [PATCH] drm/panel: Document internal backlight handling

2021-07-15 Thread Daniel Vetter
On Thu, Jul 15, 2021 at 10:02 AM Linus Walleij wrote: > > Panels with internal backlight need to assign their backlight member > directly. > > Reported-by: Doug Anderson > Signed-off-by: Linus Walleij > --- > include/drm/drm_panel.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >

Re: [PATCH] drm/vc4: hdmi: Remove drm_encoder->crtc usage

2021-07-15 Thread Maxime Ripard
On Wed, Jul 07, 2021 at 05:35:53PM +0200, Thomas Zimmermann wrote: > > > Am 07.07.21 um 16:19 schrieb Maxime Ripard: > > The drm_encoder crtc pointer isn't really fit for an atomic driver, > > let's rely on the connector state instead. > > > > Signed-off-by: Maxime Ripard > > Acked-by: Thomas

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-07-15 Thread Pekka Paalanen
On Wed, 14 Jul 2021 20:18:57 +0200 Werner Sembach wrote: > Am 01.07.21 um 13:30 schrieb Werner Sembach: > > Am 01.07.21 um 09:42 schrieb Pekka Paalanen: > >> On Wed, 30 Jun 2021 11:42:10 +0200 > >> Werner Sembach wrote: > >> > >>> Am 30.06.21 um 10:21 schrieb Pekka Paalanen: > On Tue,

[RFC 0/8] Per client GPU stats

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Same old work but now rebased and series ending with some DRM docs proposing the common specification which should enable nice common userspace tools to be written. For the moment I only have intel_gpu_top converted to use this and that seems to work okay. v2: * Added prot

[RFC 1/8] drm/i915: Explicitly track DRM clients

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tracking DRM clients more explicitly will allow later patches to accumulate past and current GPU usage in a centralised place and also consolidate access to owning task pid/name. Unique client id is also assigned for the purpose of distinguishing/ consolidating between multi

[RFC 3/8] drm/i915: Track runtime spent in closed and unreachable GEM contexts

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes. As GEM contexts are closed we want to have the DRM client remember how much GPU time they used (per class) so later we can used it for smarter

[RFC 4/8] drm/i915: Track all user contexts per client

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We soon want to start answering questions like how much GPU time is the context belonging to a client which exited still using. To enable this we start tracking all context belonging to a client on a separate list. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamse

[RFC 2/8] drm/i915: Make GEM contexts track DRM clients

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Make GEM contexts keep a reference to i915_drm_client for the whole of of their lifetime which will come handy in following patches. v2: Don't bother supporting selftests contexts from debugfs. (Chris) v3 (Lucas): Finish constructing ctx before adding it to the list v4 (Ram)

[RFC 5/8] drm/i915: Track context current active time

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track context active (on hardware) status together with the start timestamp. This will be used to provide better granularity of context runtime reporting in conjunction with already tracked pphwsp accumulated runtime. The latter is only updated on context save so does not g

[RFC 8/8] drm/amdgpu: Convert to common fdinfo format

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Convert fdinfo format to one documented in drm-usage-stats.rst. Opens: * Does it work for AMD? * What are the semantics of AMD engine utilisation reported in percents? Can it align with what i915 does or needs to document the alternative in the specification document

[RFC 6/8] drm: Document fdinfo format specification

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Proposal to standardise the fdinfo text format as optionally output by DRM drivers. Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM. i91

[RFC 7/8] drm/i915: Expose client engine utilisation via fdinfo

2021-07-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similar to AMD commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for i915. Example of the output: pos:0 flags: 012 mnt_id: 21 drm-driver:

[PATCH] drm/panel-sony-acx424akp: Modernize backlight handling

2021-07-15 Thread Linus Walleij
This converts the internal backlight in the Sony ACX424AKP driver to do it the canonical way: - Assign the panel->backlight during probe. - Let the panel framework handle the backlight. - Make the backlight .set_brightness() turn the backlight off completely if blank. - Fix some dev_err_probe()

Re: [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

2021-07-15 Thread Thomas Zimmermann
Hi, for the change Acked-by: Thomas Zimmermann but there are some style issues AFAICS. Am 15.07.21 um 04:05 schrieb Yang Yingliang: Replace pci_enable_device() with pcim_enable_device(), pci_disable_device() will be called in release automatically. Reported-by: Hulk Robot Signed-off-by:

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-15 Thread Pekka Paalanen
On Wed, 14 Jul 2021 12:13:58 -0400 Harry Wentland wrote: > On 2021-07-14 3:35 a.m., Pekka Paalanen wrote: > > On Tue, 13 Jul 2021 09:54:35 -0400 > > Harry Wentland wrote: > > > >> On 2021-07-13 3:52 a.m., Pekka Paalanen wrote: > >>> On Mon, 12 Jul 2021 12:15:59 -0400 > >>> Harry Wentland w

Re: [Intel-gfx] [PATCH 31/47] drm/i915/guc: Reset implementation for new GuC interface

2021-07-15 Thread Tvrtko Ursulin
On 24/06/2021 08:05, Matthew Brost wrote: Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Future patches will offload the engine hang check to GuC but we will continue to maintain this legacy path as a

Re: Questions over DSI within DRM.

2021-07-15 Thread Maxime Ripard
Hi Dave, On Tue, Jul 06, 2021 at 05:44:58PM +0100, Dave Stevenson wrote: > On Tue, 6 Jul 2021 at 16:13, Maxime Ripard wrote: > > > > > On a similar theme, some devices want the clock lane in HS mode early > > > > > so they can use it in place of an external oscillator, but the data > > > > > lane

Re: [PATCH v6 RESEND 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dj., 24 de juny 2021 a les 12:55: > > drm_dev_register() sets connector->registration_state to > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > drm_connector_set_panel_orientation() is first called after > drm_dev

[PATCH v2] drm/shmobile: Convert to Linux IRQ interfaces

2021-07-15 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. v2: * handle errors in platform_get_irq() (Geert, Sergei) * store IRQ number in struct shmob_drm_device (Laurent) Signed

[PATCH v2] drm/ingenic: Convert to Linux IRQ interfaces

2021-07-15 Thread Thomas Zimmermann
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. This patch also fixes a bug where the driver didn't release the IRQ. v2: * automatically release IRQ via devm_request_irq() (Pau

[PATCH 0/4] Some DG1 uAPI cleanup

2021-07-15 Thread Matthew Auld
Test-with: 20210715100932.2605648-1-matthew.a...@intel.com Chris Wilson (1): drm/i915/userptr: Probe existence of backing struct pages upon creation Matthew Auld (3): drm/i915/uapi: reject caching ioctls for discrete drm/i915/uapi: convert drm_i915_gem_userptr to kernel doc drm/i915/u

[PATCH 1/4] drm/i915/uapi: reject caching ioctls for discrete

2021-07-15 Thread Matthew Auld
It's a noop on DG1, and in the future when need to support other devices which let us control the coherency, then it should be an immutable creation time property for the BO. This will likely be controlled through a new gem_create_ext extension. v2: add some kernel doc for the discrete changes, an

[PATCH 2/4] drm/i915/uapi: convert drm_i915_gem_userptr to kernel doc

2021-07-15 Thread Matthew Auld
Add the missing kernel-doc. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Maarten Lankhorst Cc: Tvrtko Ursulin Cc: Jordan Justen Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Daniel Vetter Cc: Ramalingam C --- include/uapi/drm/i915_drm.h | 40 - 1

[PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-15 Thread Matthew Auld
From: Chris Wilson Jason Ekstrand requested a more efficient method than userptr+set-domain to determine if the userptr object was backed by a complete set of pages upon creation. To be more efficient than simply populating the userptr using get_user_pages() (as done by the call to set-domain or

[PATCH 4/4] drm/i915/uapi: reject set_domain for discrete

2021-07-15 Thread Matthew Auld
The CPU domain should be static for discrete, and on DG1 we don't need any flushing since everything is already coherent, so really all this does is an object wait, for which we have an ioctl. Longer term the desired caching should be an immutable creation time property for the BO, which can be set

Re: [PATCH v2] drm/shmobile: Convert to Linux IRQ interfaces

2021-07-15 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Jul 15, 2021 at 11:57 AM Thomas Zimmermann wrote: > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > v2: > * handle errors in platform_get_irq() (Geer

Re: [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-15 Thread Daniel Vetter
On Wed, Jul 14, 2021 at 06:12:54PM -0400, Andrey Grodzovsky wrote: > > On 2021-07-13 12:45 p.m., Daniel Vetter wrote: > > On Tue, Jul 13, 2021 at 6:11 PM Andrey Grodzovsky > > wrote: > > > On 2021-07-13 5:10 a.m., Daniel Vetter wrote: > > > > On Tue, Jul 13, 2021 at 9:25 AM Christian König > > >

Re: [PATCH] drm/mediatek: dpi: fix NULL dereference in mtk_dpi_bridge_atomic_check

2021-07-15 Thread Hsin-Yi Wang
On Mon, Jul 12, 2021 at 4:08 PM Frank Wunderlich wrote: > > From: Frank Wunderlich > > bridge->driver_private is not set (NULL) so use bridge_to_dpi(bridge) > like it's done in bridge_atomic_get_output_bus_fmts > > Fixes: ec8747c52434 ("drm/mediatek: dpi: Add bus format negotiation") > Signed-off

Re: [PATCH v2] drm/of: free the iterator object on failure

2021-07-15 Thread Steven Price
On 14/07/2021 16:26, Laurent Pinchart wrote: > Hi Steven, > > Thank you for the patch. > > On Wed, Jul 14, 2021 at 03:33:00PM +0100, Steven Price wrote: >> When bailing out due to the sanity check the iterator value needs to be >> freed because the early return prevents for_each_child_of_node() f

Re: [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-15 Thread Tvrtko Ursulin
On 15/07/2021 11:15, Matthew Auld wrote: From: Chris Wilson Jason Ekstrand requested a more efficient method than userptr+set-domain to determine if the userptr object was backed by a complete set of pages upon creation. To be more efficient than simply populating the userptr using get_user_p

Re: [PATCH v2] drm/shmobile: Convert to Linux IRQ interfaces

2021-07-15 Thread Thomas Zimmermann
Am 15.07.21 um 12:16 schrieb Geert Uytterhoeven: Hi Thomas, On Thu, Jul 15, 2021 at 11:57 AM Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. v2:

Re: [PATCH v2] drm/ingenic: Convert to Linux IRQ interfaces

2021-07-15 Thread paul
On 2021-07-15 12:02, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. This patch also fixes a bug where the driver didn't release the IRQ. v2: * autom

Re: [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

2021-07-15 Thread Yang Yingliang
On 2021/7/15 17:30, Thomas Zimmermann wrote: Hi, for the change Acked-by: Thomas Zimmermann but there are some style issues AFAICS. OK, need I resend it with the style changes and your ack ? Am 15.07.21 um 04:05 schrieb Yang Yingliang: Replace pci_enable_device() with pcim_enable_devi

Re: [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-15 Thread Daniel Vetter
On Thu, Jul 15, 2021 at 11:33:10AM +0100, Tvrtko Ursulin wrote: > > On 15/07/2021 11:15, Matthew Auld wrote: > > From: Chris Wilson > > > > Jason Ekstrand requested a more efficient method than userptr+set-domain > > to determine if the userptr object was backed by a complete set of pages > > up

Re: [PATCH v6 RESEND 2/3] drm/mediatek: init panel orientation property

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dj., 24 de juny 2021 a les 12:55: > > Init panel orientation property after connector is initialized. Let the > panel driver decides the orientation value later. > > Signed-off-by: Hsin-Yi Wang > Acked-by: Chun-Kuang Hu Te

Re: [Intel-gfx] [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-15 Thread Matthew Auld
On Thu, 15 Jul 2021 at 11:33, Tvrtko Ursulin wrote: > > > On 15/07/2021 11:15, Matthew Auld wrote: > > From: Chris Wilson > > > > Jason Ekstrand requested a more efficient method than userptr+set-domain > > to determine if the userptr object was backed by a complete set of pages > > upon creation

Re: [PATCH v6 RESEND 3/3] arm64: dts: mt8183: Add panel rotation

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for the patch. Missatge de Hsin-Yi Wang del dia dj., 27 de maig 2021 a les 9:42: > > krane, kakadu, and kodama boards have a default panel rotation. > > Signed-off-by: Hsin-Yi Wang It looks good to me, so Reviewed-by: Enric Balletbo i Serra and, on a Lenovo IdeaPad Due

Re: [PATCH v3] backlight: ktd253: Stabilize backlight

2021-07-15 Thread Lee Jones
On Tue, 13 Jul 2021, Linus Walleij wrote: > On Fri, Jun 4, 2021 at 8:34 AM Linus Walleij wrote: > > > Remove interrupt disablement during backlight setting. It is > > way to dangerous and makes platforms instable by having it > > miss vblank IRQs leading to the graphics derailing. > > > > The co

Re: [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-15 Thread Tvrtko Ursulin
On 15/07/2021 12:07, Daniel Vetter wrote: On Thu, Jul 15, 2021 at 11:33:10AM +0100, Tvrtko Ursulin wrote: On 15/07/2021 11:15, Matthew Auld wrote: From: Chris Wilson Jason Ekstrand requested a more efficient method than userptr+set-domain to determine if the userptr object was backed by a

Re: [Intel-gfx] [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-15 Thread Tvrtko Ursulin
On 15/07/2021 12:09, Matthew Auld wrote: On Thu, 15 Jul 2021 at 11:33, Tvrtko Ursulin wrote: On 15/07/2021 11:15, Matthew Auld wrote: From: Chris Wilson Jason Ekstrand requested a more efficient method than userptr+set-domain to determine if the userptr object was backed by a complete se

[PATCH v4] backlight: ktd253: Stabilize backlight

2021-07-15 Thread Linus Walleij
Remove interrupt disablement during backlight setting. It is way to dangerous and makes platforms instable by having it miss vblank IRQs leading to the graphics derailing. The code is using ndelay() which is not available on platforms such as ARM and will result in 32 * udelay(1) which is substant

Re: [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

2021-07-15 Thread Thomas Zimmermann
Hi Am 15.07.21 um 13:03 schrieb Yang Yingliang: On 2021/7/15 17:30, Thomas Zimmermann wrote: Hi, for the change Acked-by: Thomas Zimmermann but there are some style issues AFAICS. OK, need I resend it with the style changes and your ack ? Please do. I'll merge it a few days later if n

Re: [PATCH 2/4] drm/i915/uapi: convert drm_i915_gem_userptr to kernel doc

2021-07-15 Thread Maarten Lankhorst
Op 15-07-2021 om 12:15 schreef Matthew Auld: > Add the missing kernel-doc. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst > Cc: Tvrtko Ursulin > Cc: Jordan Justen > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Daniel Vetter > Cc: Ramalingam C > --- > incl

Patch "drm/dp_mst: Do not set proposed vcpi directly" has been added to the 5.10-stable tree

2021-07-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/dp_mst: Do not set proposed vcpi directly to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-dp_m

Patch "drm/dp_mst: Do not set proposed vcpi directly" has been added to the 5.12-stable tree

2021-07-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/dp_mst: Do not set proposed vcpi directly to the 5.12-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-dp_m

Patch "drm/dp_mst: Do not set proposed vcpi directly" has been added to the 5.13-stable tree

2021-07-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/dp_mst: Do not set proposed vcpi directly to the 5.13-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-dp_m

Re: [PATCH 02/13] vfio: Introduce a vfio_uninit_group_dev() API call

2021-07-15 Thread Jason Gunthorpe
On Thu, Jul 15, 2021 at 06:49:05AM +0300, Leon Romanovsky wrote: > On Wed, Jul 14, 2021 at 09:20:31PM -0300, Jason Gunthorpe wrote: > > From: Max Gurtovoy > > > > This pairs with vfio_init_group_dev() and allows undoing any state that is > > stored in the vfio_device unrelated to registration. Ad

Re: [Intel-gfx] [PATCH] drm/i915: Check object_can_migrate from object_migrate

2021-07-15 Thread Matthew Auld
On Wed, 14 Jul 2021 at 21:45, Jason Ekstrand wrote: > > We don't roll them together entirely because there are still a couple > cases where we want a separate can_migrate check. For instance, the > display code checks that you can migrate a buffer to LMEM before it > accepts it in fb_create. The

[PATCH -next v2 resend] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

2021-07-15 Thread Yang Yingliang
Replace pci_enable_device() with pcim_enable_device(), pci_disable_device() will be called in release automatically. v2: use pcim_enable_device() Signed-off-by: Yang Yingliang Reported-by: Hulk Robot Acked-by: Thomas Zimmermann --- drivers/gpu/drm/bochs/bochs_drv.c | 2 +- 1 file changed, 1

Re: [PATCH 00/13] Provide core infrastructure for managing open/release

2021-07-15 Thread Kirti Wankhede
On 7/15/2021 5:50 AM, Jason Gunthorpe wrote: Prologue: This is the first series of three to send the "mlx5_vfio_pci" driver that has been discussed on the list for a while now. - Reorganize reflck to support splitting vfio_pci - Split vfio_pci into vfio_pci/vfio_pci_core and provide infra

[Bug 213391] AMDGPU retries page fault with some specific processes amdgpu and sometimes followed [gfxhub0] retry page fault until *ERROR* ring gfx timeout, but soft recovered

2021-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213391 --- Comment #33 from Leandro Jacques (ls...@yahoo.com) --- Created attachment 297881 --> https://bugzilla.kernel.org/attachment.cgi?id=297881&action=edit Kernel crash log for linux firmware version 20210511.7685cf4 amdgpu kernel crash log when

[Bug 213391] AMDGPU retries page fault with some specific processes amdgpu and sometimes followed [gfxhub0] retry page fault until *ERROR* ring gfx timeout, but soft recovered

2021-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213391 --- Comment #34 from Leandro Jacques (ls...@yahoo.com) --- Created attachment 297883 --> https://bugzilla.kernel.org/attachment.cgi?id=297883&action=edit Linux Firmware version info 20210511.7685cf4 Firmware info as of the moment when the syste

[Bug 209457] AMDGPU resume fail with RX 580 GPU

2021-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209457 --- Comment #39 from Leandro Jacques (ls...@yahoo.com) --- (In reply to Alex Deucher from comment #38) > > You have a Picasso system. The original bug was about an RX 580. I don't > think this is the same issue. Sounds like you are seeing this

[PULL] drm-intel-fixes

2021-07-15 Thread Rodrigo Vivi
Hi Dave and Daniel, I was unsure about the -EDEADLK one based on Daniel's comment on dri-devel, but Ville's response and the patch looks reasonable to me. Also they are in sync with the test cases. So if anything needs to still change on that area I believe it can be a follow-up work. Here goes d

Re: [PATCH] drm/panel: Document internal backlight handling

2021-07-15 Thread Doug Anderson
Hi, On Thu, Jul 15, 2021 at 1:02 AM Linus Walleij wrote: > > Panels with internal backlight need to assign their backlight member > directly. > > Reported-by: Doug Anderson > Signed-off-by: Linus Walleij > --- > include/drm/drm_panel.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(

Re: [PATCH v8 00/14] drm/tegra: Introduce a modern UABI

2021-07-15 Thread Dmitry Osipenko
14.07.2021 18:26, Mikko Perttunen пишет: ... > While my goal of course is to enable proper use of Host1x on the newer > SoCs, there is absolutely no intention to forget about the older SoCs. > Observably, to me at least, GR2D and GR3D are working -- the test suites > are passing (though I did not p

Re: [pull] amdgpu, amdkfd drm-fixes-5.14

2021-07-15 Thread Alex Deucher
On Thu, Jul 15, 2021 at 12:52 AM Sam Ravnborg wrote: > > Hi Alex, > > On Wed, Jul 14, 2021 at 06:08:58PM -0400, Alex Deucher wrote: > > Hi Dave, Daniel, > > > > Fixes for 5.14. The big change here is unifying the SMU13 code. This was > > new code added in 5.14 to support Yellow Carp, but we've s

Re: [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup

2021-07-15 Thread Thomas Zimmermann
Am 13.07.21 um 15:59 schrieb Daniel Vetter: Some vague evidences suggests this can go wrong. Try to prevent it by holding the right mutex and clearing ->deferred_setup to make sure we later on don't accidentally try to re-register the fbdev when the driver thought it had it all cleaned up alrea

Re: [PATCH v2 resent] drm/i915: Add TTM offset argument to mmap.

2021-07-15 Thread Matthew Auld
On Wed, 14 Jul 2021 at 13:28, Maarten Lankhorst wrote: > > The FIXED mapping is only used for ttm, and tells userspace that the > mapping type is pre-defined. This disables the other type of mmap > offsets when discrete memory is used, so fix the selftests as well. > > Document the struct as well,

[PATCH] drm/amdgpu/display: make a const array common_rates static, makes object smaller

2021-07-15 Thread Colin King
From: Colin Ian King Don't populate the const array common_rates on the stack but instead it static. Makes the object code smaller by 80 bytes: Before: textdata bss dec hex filename 268019 98322 256 366597 59805 ../display/amdgpu_dm/amdgpu_dm.o After: textdat

[PATCH] drm: bridge: make const array frs_limits static, makes object smaller

2021-07-15 Thread Colin King
From: Colin Ian King Don't populate the const array frs_limits on the stack but instead it static. Makes the object code smaller by 128 bytes: Before: textdata bss dec hex filename 251557440 64 326597f93 ./drivers/gpu/drm/bridge/tc358768.o After: textd

Re: [PATCH 00/13] Provide core infrastructure for managing open/release

2021-07-15 Thread Jason Gunthorpe
On Thu, Jul 15, 2021 at 06:58:31PM +0530, Kirti Wankhede wrote: > > Review of all the drivers show that they are either already open coding > > the first/last semantic or are buggy and missing it. All drivers are > > migrated/fixed to the new open/close_device ops and the unused per-FD > > open()/

Re: [PATCH] drm/panel-simple: Power the panel when probing DP AUX backlight

2021-07-15 Thread Doug Anderson
Hi, On Wed, Jul 14, 2021 at 9:34 AM Douglas Anderson wrote: > > When I tried booting up a device that needed the DP AUX backlight, I > found an error in the logs: > panel-simple-dp-aux: probe of aux-ti_sn65dsi86.aux.0 failed with error -110 > > The aux transfers were failing because the panel w

Re: [PATCH] drm/dp: For drm_panel_dp_aux_backlight(), init backlight as disabled

2021-07-15 Thread Doug Anderson
Hi, On Wed, Jul 14, 2021 at 10:17 AM Douglas Anderson wrote: > > Even after the DP AUX backlight on my board worked OK after applying > the patch ("drm/panel-simple: Power the panel when probing DP AUX > backlight") [1], I still noticed some strange timeouts being reported > by ti_sn_aux_transfer

Re: [PATCH v8 01/14] gpu: host1x: Add DMA fence implementation

2021-07-15 Thread Dmitry Osipenko
09.07.2021 22:31, Thierry Reding пишет: > diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c > new file mode 100644 > index ..06c6b86237bd > --- /dev/null > +++ b/drivers/gpu/host1x/fence.c > @@ -0,0 +1,209 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Syn

Re: [PATCH v8 09/14] drm/tegra: Implement new UAPI

2021-07-15 Thread Dmitry Osipenko
09.07.2021 22:31, Thierry Reding пишет: > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c > index cddee6425461..6ee08e49ec57 100644 > --- a/drivers/gpu/drm/tegra/drm.c > +++ b/drivers/gpu/drm/tegra/drm.c > @@ -21,6 +21,7 @@ > #include > #include > > +#include "uapi.h" >

Re: [pull] amdgpu, amdkfd drm-fixes-5.14

2021-07-15 Thread Michel Dänzer
On 2021-07-15 4:07 p.m., Alex Deucher wrote: > On Thu, Jul 15, 2021 at 12:52 AM Sam Ravnborg wrote: >> On Wed, Jul 14, 2021 at 06:08:58PM -0400, Alex Deucher wrote: >>> Hi Dave, Daniel, >>> >>> Fixes for 5.14. The big change here is unifying the SMU13 code. This was >>> new code added in 5.14 to

Re: [PATCH] drm/amdgpu/display: make a const array common_rates static, makes object smaller

2021-07-15 Thread Alex Deucher
On Thu, Jul 15, 2021 at 10:37 AM Colin King wrote: > > From: Colin Ian King > > Don't populate the const array common_rates on the stack but instead it > static. Makes the object code smaller by 80 bytes: > > Before: >textdata bss dec hex filename > 268019 98322 256 36

Re: [PATCH] drm/amd/display: Fix 10bit 4K display on CIK GPUs

2021-07-15 Thread Alex Deucher
On Wed, Jul 14, 2021 at 4:15 AM Liviu Dudau wrote: > > Commit 72a7cf0aec0c ("drm/amd/display: Keep linebuffer pixel depth at > 30bpp for DCE-11.0.") doesn't seems to have fixed 10bit 4K rendering over > DisplayPort for CIK GPUs. On my machine with a HAWAII GPU I get a broken > image that looks lik

Re: [PATCH v2 1/8] dt-bindings: display: msm: dsi-controller-main: restore assigned-clocks

2021-07-15 Thread Rob Herring
On Sat, 10 Jul 2021 00:07:22 +0300, Dmitry Baryshkov wrote: > Restore the assgined-clocks and assigned-clock-parents properties that > were lost during the txt -> YAML conversion. > > Signed-off-by: Dmitry Baryshkov > --- > .../display/msm/dsi-controller-main.yaml| 17 + >

[drm-intel:drm-intel-gt-next 29/30] drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: sparse: sparse: incorrect type in assignment (different address spaces)

2021-07-15 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-gt-next head: ca06f93638362bf83584cdf33897822bf1578cf9 commit: 0eee9977f9d3d8f1e40175dada55b3d00121ac79 [29/30] drm/i915/gem: Roll all of context creation together config: x86_64-randconfig-s022-20210715 (attached as .config) compiler

[Regression] No framebuffer console on Rpi since 5.14-rc1

2021-07-15 Thread Stefan Wahren
Hi guys, starting with Linux 5.14-rc1 the framebuffer console on Raspberry Pi 3/4 (no U-Boot, multi_v7_defconfig) isn't available anymore. The display shows the rainbow screen from the bootloader and than the HDMI screen goes black instead of kernel messages. I bisected the issue: 62fb9874f5da54

[PATCH 1/5] drm: Define DRM_FORMAT_MAX_PLANES

2021-07-15 Thread Thomas Zimmermann
DRM uses a magic number of 4 for the maximum number of planes per color format. Declare this constant via DRM_FORMAT_MAX_PLANES and update the related code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 14 -- include/drm/drm_fourcc.h

[PATCH 2/5] drm/gem: Provide drm_gem_fb_{vmap,vunmap}()

2021-07-15 Thread Thomas Zimmermann
Move framebuffer vmap code from shadow-buffered plane state into the new interfaces drm_gem_fb_vmap() and drm_gem_fb_vunmap(). These functions provide mappings of a framebuffer's BOs into kernel address space. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_at

[PATCH 0/5] drm: Provide framebuffer vmap helpers

2021-07-15 Thread Thomas Zimmermann
Add the new helpers drm_gem_fb_vmap() and drm_gem_fb_vunmap(), which provide vmap/vunmap for all BOs of a framebuffer. Convert shadow- plane helpers, gud and vkms. Callers of GEM vmap and vunmap functions used to do the minumum work or get some detail wrong. Therefore shadow-plane helpers were int

[PATCH 3/5] drm/gem: Clear mapping addresses for unused framebuffer planes

2021-07-15 Thread Thomas Zimmermann
Set the returned mapping address to NULL if a framebuffer plane does not have a BO associated with it. Likewise, ignore mappings of NULL during framebuffer unmap operations. Allows users of the functions to perform unmap operations of certain BOs by themselfes. Signed-off-by: Thomas Zimmermann --

[PATCH 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

2021-07-15 Thread Thomas Zimmermann
Abstract the framebuffer details by mapping its BOs with a call to drm_gem_fb_vmap(). Unmap with drm_gem_fb_vunmap(). The call to drm_gem_fb_vmap() ensures that all BOs are mapped correctly. Gud still only supports single-plane formats. No functional changes. Signed-off-by: Thomas Zimmermann --

[PATCH 5/5] drm/vkms: Map output framebuffer BOs with drm_gem_fb_vmap()

2021-07-15 Thread Thomas Zimmermann
Abstract the framebuffer details by mappings its BOs with a call to drm_gem_fb_vmap(). Unmap with drm_gem_fb_vunamp(). Before, the output address with stored as raw pointer in the priv field of struct drm_writeback_job. Introduce the new type struct vkms_writeback_job, which holds the output mappi

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-15 Thread Harry Wentland
On 2021-07-15 5:34 a.m., Pekka Paalanen wrote: > On Wed, 14 Jul 2021 12:13:58 -0400 > Harry Wentland wrote: > >> On 2021-07-14 3:35 a.m., Pekka Paalanen wrote: >>> On Tue, 13 Jul 2021 09:54:35 -0400 >>> Harry Wentland wrote: >>> On 2021-07-13 3:52 a.m., Pekka Paalanen wrote: > O

Patch "drm/ast: Remove reference to struct drm_device.pdev" has been added to the 5.10-stable tree

2021-07-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: Remove reference to struct drm_device.pdev to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: dr

Patch "drm/ast: Remove reference to struct drm_device.pdev" has been added to the 5.12-stable tree

2021-07-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: Remove reference to struct drm_device.pdev to the 5.12-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: dr

Patch "drm/ast: Remove reference to struct drm_device.pdev" has been added to the 5.13-stable tree

2021-07-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ast: Remove reference to struct drm_device.pdev to the 5.13-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: dr

Re: [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-15 Thread Kenneth Graunke
On Thursday, July 15, 2021 4:27:44 AM PDT Tvrtko Ursulin wrote: > > On 15/07/2021 12:07, Daniel Vetter wrote: > > On Thu, Jul 15, 2021 at 11:33:10AM +0100, Tvrtko Ursulin wrote: > >> > >> On 15/07/2021 11:15, Matthew Auld wrote: > >>> From: Chris Wilson > >>> > >>> Jason Ekstrand requested a more

[PATCH 0/4] drm: Make modeset locking easier

2021-07-15 Thread Ville Syrjala
From: Ville Syrjälä While staring at some DRM_MODESET_LOCK_ALL_{BEGIN,END}() conversions I decided I don't really like what those macros do. The main problems that I see: - the magic goto inside limits their usefulness to baically a single statement, unless you're willing to look inside and

[PATCH 1/4] drm: Introduce drm_modeset_lock_ctx_retry()

2021-07-15 Thread Ville Syrjala
From: Ville Syrjälä Quite a few places are hand rolling the modeset lock backoff dance. Let's suck that into a helper macro that is easier to use without forgetting some steps. The main downside is probably that the implementation of drm_with_modeset_lock_ctx() is a bit harder to read than a han

  1   2   >