Re: [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 8:53 AM Christian König wrote: > Am 08.07.21 um 19:37 schrieb Daniel Vetter: > > If it does, someone managed to set up a sched_entity without > > schedulers, which is just a driver bug. > > NAK, it is perfectly valid for rq selection to fail. There isn't a better way to exp

Re: [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Christian König
Am 09.07.21 um 09:14 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 8:53 AM Christian König wrote: Am 08.07.21 um 19:37 schrieb Daniel Vetter: If it does, someone managed to set up a sched_entity without schedulers, which is just a driver bug. NAK, it is perfectly valid for rq selection to fai

Re: [PATCH v5] Documentation: gpu: Mention the requirements for new properties

2021-07-09 Thread Pekka Paalanen
On Tue, 6 Jul 2021 18:12:44 +0200 Maxime Ripard wrote: > New KMS properties come with a bunch of requirements to avoid each > driver from running their own, inconsistent, set of properties, > eventually leading to issues like property conflicts, inconsistencies > between drivers and semantics, e

Re: [PATCH 2/2] drm/stm: ltdc: add crtc background color property support

2021-07-09 Thread Pekka Paalanen
On Wed, 7 Jul 2021 08:48:55 + Raphael GALLAIS-POU - foss wrote: > This patch comes from the need to display small resolution pictures with > very few DDR usage. In practice, using a background color, produced by the > drm CRTC, around this picture allows to fetch less data in memory than > se

Re: [PATCH] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 8:58 AM Christian König wrote: > > > > Am 08.07.21 um 23:54 schrieb Daniel Vetter: > > It might be good enough on x86 with just READ_ONCE, but the write side > > should then at least be WRITE_ONCE because x86 has total store order. > > > > It's definitely not enough on arm.

Re: [PATCH] fbcon: garbage collect fbdev scrolling acceleration

2021-07-09 Thread Geert Uytterhoeven
On Fri, Jul 9, 2021 at 3:04 AM Hamza Mahfooz wrote: > As per commit 39aead8373b3 ("fbcon: Disable accelerated scrolling"), we can > now remove all of the code that was made redundant by disabling scrolling > acceleration. Bummer, more code to revert to re-enable acceleration in the _56_ fbdev dri

Re: [PATCH 2/2] drm/ttm: Fix COW check

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 8:38 AM Christian König wrote: > > > > Am 08.07.21 um 21:36 schrieb Alex Deucher: > > From: Felix Kuehling > > > > KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. > > is_cow_mapping returns true for these mappings. Add a check for > > vm_flags & VM_WRITE to a

Re: [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 9:23 AM Christian König wrote: > Am 09.07.21 um 09:14 schrieb Daniel Vetter: > > On Fri, Jul 9, 2021 at 8:53 AM Christian König > > wrote: > >> Am 08.07.21 um 19:37 schrieb Daniel Vetter: > >>> If it does, someone managed to set up a sched_entity without > >>> schedulers,

Re: [PATCH v5] Documentation: gpu: Mention the requirements for new properties

2021-07-09 Thread Daniel Vetter
On Fri, Jul 09, 2021 at 10:24:44AM +0300, Pekka Paalanen wrote: > On Tue, 6 Jul 2021 18:12:44 +0200 > Maxime Ripard wrote: > > > New KMS properties come with a bunch of requirements to avoid each > > driver from running their own, inconsistent, set of properties, > > eventually leading to issues

Re: [PATCH] fbcon: garbage collect fbdev scrolling acceleration

2021-07-09 Thread Daniel Vetter
On Thu, Jul 08, 2021 at 09:00:38PM -0400, Hamza Mahfooz wrote: > As per commit 39aead8373b3 ("fbcon: Disable accelerated scrolling"), we can That commit is only in 5.11, so not yet even in an LTS. We should wait at least that long. Also there's some objections from Geert. -Daniel > now remove all

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-09 Thread Pekka Paalanen
On Wed, 7 Jul 2021 08:48:47 + Raphael GALLAIS-POU - foss wrote: > Some display controllers can be programmed to present non-black colors > for pixels not covered by any plane (or pixels covered by the > transparent regions of higher planes). Compositors that want a UI with > a solid color ba

Re: [PATCH] drm/gma500: Fix end of loop tests for list_for_each_entry

2021-07-09 Thread Daniel Vetter
On Fri, Jul 09, 2021 at 01:09:59PM +0530, Harshvardhan Jha wrote: > The list_for_each_entry() iterator, "connector" in this code, can never be > NULL. If we exit the loop without finding the correct connector then > "connector" points invalid memory that is an offset from the list head. > This wi

[PATCH] dim/drm-misc: Add rule to not push patches with issues

2021-07-09 Thread Daniel Vetter
We kinda left this out, and I like the wording from the drm-intel side, so add that. Motivated by a discussion with Christian. Cc: Christian König Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Signed-off-by: Daniel Vetter --- committer-drm-misc.rst | 3 +++ 1 file changed, 3

Re: [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Christian König
Am 09.07.21 um 10:00 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 9:23 AM Christian König wrote: Am 09.07.21 um 09:14 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 8:53 AM Christian König wrote: Am 08.07.21 um 19:37 schrieb Daniel Vetter: If it does, someone managed to set up a sched_entit

Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues

2021-07-09 Thread Christian König
Am 09.07.21 um 10:11 schrieb Daniel Vetter: We kinda left this out, and I like the wording from the drm-intel side, so add that. Motivated by a discussion with Christian. Cc: Christian König Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Signed-off-by: Daniel Vetter Revi

[PATCH v5] drm/ast: Disable fast reset after DRAM initial

2021-07-09 Thread KuoHsiang Chou
[Bug][AST2500] V1: When AST2500 acts as stand-alone VGA so that DRAM and DVO initialization have to be achieved by VGA driver with P2A (PCI to AHB) enabling. However, HW suggests disable Fast reset mode after DRAM initializaton, because fast reset mode is mainly designed for ARM ICE debugger. Once

Re: [PATCH v3 16/20] drm/msm: always wait for the exclusive fence

2021-07-09 Thread Christian König
Am 08.07.21 um 19:37 schrieb Daniel Vetter: From: Christian König Drivers also need to to sync to the exclusive fence when a shared one is present. Signed-off-by: Christian König [danvet: Not that hard to compile-test on arm ...] Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: Sean Paul Cc:

[PATCH] drm/gma500: Fix end of loop tests for list_for_each_entry

2021-07-09 Thread Harshvardhan Jha
The list_for_each_entry() iterator, "connector" in this code, can never be NULL. If we exit the loop without finding the correct connector then "connector" points invalid memory that is an offset from the list head. This will eventually lead to memory corruption and presumably a kernel crash. Fi

Re: [PATCH v5] Documentation: gpu: Mention the requirements for new properties

2021-07-09 Thread Pekka Paalanen
On Fri, 9 Jul 2021 10:02:28 +0200 Daniel Vetter wrote: > On Fri, Jul 09, 2021 at 10:24:44AM +0300, Pekka Paalanen wrote: > > On Tue, 6 Jul 2021 18:12:44 +0200 > > Maxime Ripard wrote: > > > > > New KMS properties come with a bunch of requirements to avoid each > > > driver from running their

Re: [PATCH 0/2] Add "BACKGROUND_COLOR" drm property

2021-07-09 Thread Raphael Gallais-Pou
On 7/7/21 1:42 PM, Daniel Vetter wrote: On Wed, Jul 07, 2021 at 09:03:03AM +, Simon Ser wrote: Hi, Thanks for working on this. Do you have plans for user-space implementations and IGT? Note that these parts are mandatory, and there's a patch floating around further clarifying what's all

Re: [PATCH v3 16/20] drm/msm: always wait for the exclusive fence

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 10:48 AM Christian König wrote: > Am 08.07.21 um 19:37 schrieb Daniel Vetter: > > From: Christian König > > > > Drivers also need to to sync to the exclusive fence when > > a shared one is present. > > > > Signed-off-by: Christian König > > [danvet: Not that hard to compil

Re: [PATCH 0/2] Add "BACKGROUND_COLOR" drm property

2021-07-09 Thread Simon Ser
On Friday, July 9th, 2021 at 11:09, Raphael Gallais-Pou wrote: > We don't usually test with piglit and igt-gpu-tools. Instead, modetest > utility of the libdrm is used quite often (as is it the case in order to > test this property). Just to make it extra clear: regardless of how you bring up y

Re: [PATCH 2/2 v3] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-09 Thread Jagan Teki
On Thu, Jul 8, 2021 at 5:25 AM Linus Walleij wrote: > > This adds a driver for panels based on the WideChips WS2401 display > controller. This display controller is used in the Samsung LMS380KF01 > display found in the Samsung GT-I8160 (Codina) mobile phone and > possibly others. > > As is common

[PATCH] gpu: drm: Remove unneeded variable: "ret"

2021-07-09 Thread dingsenjie
From: dingsenjie remove unneeded variable: "ret". Signed-off-by: dingsenjie --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 4 +--- drivers/gpu/drm/msm/dp/dp_link.c | 13 - 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/ms

Aw: Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-09 Thread Frank Wunderlich
Hi, i've found it :) hdmi-problem is caused by commit 440147639ac79f699a4eb9811d0bc39d3cc815f4 Author: CK Hu Date: Wed Mar 17 19:17:10 2021 +0100 soc: mediatek: mmsys: Use an array for setting the routing registers but i cannot revert it alone, but after reverting all mmsys-patches hdmi

Re: Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-09 Thread Enric Balletbo Serra
Hi Frank, Missatge de Frank Wunderlich del dia dv., 9 de jul. 2021 a les 12:02: > > Hi, > > i've found it :) > > hdmi-problem is caused by > > commit 440147639ac79f699a4eb9811d0bc39d3cc815f4 > Author: CK Hu > Date: Wed Mar 17 19:17:10 2021 +0100 > > soc: mediatek: mmsys: Use an array for s

Aw: Re: Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-09 Thread Frank Wunderlich
> Gesendet: Freitag, 09. Juli 2021 um 12:24 Uhr > Von: "Enric Balletbo Serra" > If this is the offending commit, could you try if the following patch > fixes the issue for you? > > https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.13-next/fixes&id=db39994e0bd852

[v1] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-07-09 Thread Kalyan Thota
Add safe lut configuration for all the targets in dpu driver as per QOS recommendation. Issue reported on SC7280: With wait-for-safe feature in smmu enabled, RT client buffer levels are checked to be safe before smmu invalidation. Since display was always set to unsafe it was delaying the invalid

Re: [PATCH] video: backlight: Only set maximum brightness for gpio-backlight

2021-07-09 Thread Daniel Thompson
On Thu, Jul 08, 2021 at 11:10:58AM +0200, Marek Vasut wrote: > The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper > in backlight.c") says that gpio-backlight uses brightness as power state. > Other backlight drivers do not, so limit this workaround to gpio-backlight. > > Th

Aw: Re: Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-09 Thread Frank Wunderlich
> Gesendet: Freitag, 09. Juli 2021 um 12:38 Uhr > Von: "Frank Wunderlich" > An: "Enric Balletbo Serra" > Cc: "CK Hu" , "Dafna Hirschfeld" > , "chunkuang Hu" , > "Thomas Zimmermann" , "David Airlie" , > "linux-kernel" , "Enric Balletbo i Serra" > , "moderated list:ARM/Mediatek SoC support" >

Re: [v1] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-07-09 Thread Dmitry Baryshkov
On Fri, 9 Jul 2021 at 13:41, Kalyan Thota wrote: > > Add safe lut configuration for all the targets in dpu > driver as per QOS recommendation. > > Issue reported on SC7280: > > With wait-for-safe feature in smmu enabled, RT client > buffer levels are checked to be safe before smmu invalidation. >

[PATCH] drm/vgem: Restore mmap functionality

2021-07-09 Thread Thomas Zimmermann
Commit 375cca1cfeb5 ("drm/vgem: Implement mmap as GEM object function") accidentally removed the actual mmap functionality from vgem. Restore the original implementation and VMA flags. Fixes access to unmapped memory: [ 106.591744] BUG: KASAN: vmalloc-out-of-bounds in do_fault+0x38/0x480 [ 106.

[PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-09 Thread Maarten Lankhorst
This is only used for ttm, and tells userspace that the mapping type is ignored. This disables the other type of mmap offsets when discrete memory is used, so fix the selftests as well. Document the struct as well, so it shows up in docbook correctly. Changes since v1: - Add docbook entries. Sig

Re: [PATCH] drm/vgem: Implement mmap as GEM object function

2021-07-09 Thread Thomas Zimmermann
Hi Am 08.07.21 um 23:37 schrieb Daniel Vetter: On Thu, Jun 24, 2021 at 11:52 AM Thomas Zimmermann wrote: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective vgem functions are being removed. The file_operatio

[PATCH] dma-buf: fix and rework dma_buf_poll v6

2021-07-09 Thread Christian König
Daniel pointed me towards this function and there are multiple obvious problems in the implementation. First of all the retry loop is not working as intended. In general the retry makes only sense if you grab the reference first and then check the sequence values. Then we should always also wait

[PATCH 1/1] drm: drm_fourcc: add NV20 and NV30 format

2021-07-09 Thread Sandy Huang
DRM_FORMAT_NV20 and DRM_FORMAT_NV30 is a 2 plane format suitable for linear layouts, this two format is similar to NV15 has no padding between component, but NV15 is 4:2:0 sub-sampling, NV20 is 4:2:2 sub-sampling and NV30 is no-sampling. = UVUV = 4 * 10 bits = 40 bits = 5 bytes The '20' and

Re: [PATCH] MAINTAINERS: Add Raphael Gallais-Pou as STM32 DRM maintainer

2021-07-09 Thread Philippe CORNU
On 7/8/21 2:54 PM, Raphael GALLAIS-POU - foss wrote: Add Raphael Gallais-Pou as STM32 DRM maintainer. Signed-off-by: Raphael Gallais-Pou --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0f1171ceaf8b..4fa3bfc00f57 100644 --- a/MAINTAINERS

Re: [PATCH] dma-buf: fix and rework dma_buf_poll v5

2021-07-09 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on tegra-drm/drm/tegra/for-next] [also build test WARNING on v5.13] [cannot apply to linus/master next-20210709] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submi

Re: [PATCH] drm/msm: Fix display fault handling

2021-07-09 Thread Yassine Oudjana
On Wed, Jul 7 2021 at 21:57:05 +0400, Rob Clark wrote: > From: Rob Clark > > It turns out that when the display is enabled by the bootloader, we > can > get some transient iommu faults from the display. Which doesn't go > over > too well when we install a fault handler that is gpu specifi

Re: [Freedreno] [PATCH v1 0/7] drm/msm/dpu: add support for idependent DSI config

2021-07-09 Thread Alexey Minnekhanov
08.07.2021 15:28, Dmitry Baryshkov wrote: This patchseries adds support for independent DSI config to DPU1 display subdriver. Also drop one of msm_kms_funcs callbacks, made unnecessary now. Tested on RB5 (dpu, dsi). Previous iteration was tested by Alexey Minnekhanov. Changes since v1: - rena

Re: [PATCH] video: backlight: Only set maximum brightness for gpio-backlight

2021-07-09 Thread Marek Vasut
On 7/9/21 1:03 PM, Daniel Thompson wrote: On Thu, Jul 08, 2021 at 11:10:58AM +0200, Marek Vasut wrote: The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c") says that gpio-backlight uses brightness as power state. Other backlight drivers do not, so limit thi

Re: [PATCH] video: backlight: Only set maximum brightness for gpio-backlight

2021-07-09 Thread Noralf Trønnes
Den 09.07.2021 15.19, skrev Marek Vasut: > On 7/9/21 1:03 PM, Daniel Thompson wrote: >> On Thu, Jul 08, 2021 at 11:10:58AM +0200, Marek Vasut wrote: >>> The note in c2adda27d202f ("video: backlight: Add of_find_backlight >>> helper >>> in backlight.c") says that gpio-backlight uses brightness as

[PATCH] video: backlight: Drop maximum brightness override for brightness zero

2021-07-09 Thread Marek Vasut
The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c") says that gpio-backlight uses brightness as power state. This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight: Correct initial power state handling") and other backlight drivers do not requ

Re: [PATCH] video: backlight: Drop maximum brightness override for brightness zero

2021-07-09 Thread Noralf Trønnes
Den 09.07.2021 15.26, skrev Marek Vasut: > The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper > in backlight.c") says that gpio-backlight uses brightness as power state. > This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight: > Correct initial power stat

Re: [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20

2021-07-09 Thread Doug Anderson
Hi, On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan wrote: > > This series adds the support for the eDP panel that needs the backlight > controlling over the DP AUX channel using DPCD registers of the panel > as per the VESA's standard. > > This series also adds support for the Samsung eDP AMOLED p

Re: [PATCH] drm/vgem: Restore mmap functionality

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 1:47 PM Thomas Zimmermann wrote: > > Commit 375cca1cfeb5 ("drm/vgem: Implement mmap as GEM object function") > accidentally removed the actual mmap functionality from vgem. Restore > the original implementation and VMA flags. Ah yes that explains things. Reviewed-by: Danie

Re: [Intel-gfx] [PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 1:41 PM Maarten Lankhorst wrote: > > This is only used for ttm, and tells userspace that the mapping type is > ignored. This disables the other type of mmap offsets when discrete > memory is used, so fix the selftests as well. > > Document the struct as well, so it shows up

Re: [PATCH 2/2 v3] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-09 Thread Linus Walleij
On Fri, Jul 9, 2021 at 11:25 AM Jagan Teki wrote: > > + /* Assert reset >=1 ms */ > > + gpiod_set_value_cansleep(ws->reset, 1); > > + usleep_range(1000, 5000); > > + /* De-assert reset */ > > + gpiod_set_value_cansleep(ws->reset, 0); > > + /* Wait >= 10 ms */ >

[PATCH] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Matthew Auld
EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it possible for userspace to bypass the GTT caching bits set by the kernel, as per the given object cache_level. This is troublesome since the heavy flush we apply when first acquiring the pages is skipped if the kernel thinks the objec

Re: [PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-09 Thread Dennis Dalessandro
On 7/6/21 1:59 PM, Jason Gunthorpe wrote: > I can not say the same about other company's RDMA driver > distributions, Daniel's description of "minimal effort to get > goodwill" would match others much better. Not sure what other RDMA driver you are talking about but as for Cornelis Networks, we do

[PATCH v2] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Matthew Auld
EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it possible for userspace to bypass the GTT caching bits set by the kernel, as per the given object cache_level. This is troublesome since the heavy flush we apply when first acquiring the pages is skipped if the kernel thinks the objec

[PATCH] drm/vgem: Restore mmap functionality

2021-07-09 Thread Thomas Zimmermann
Commit 375cca1cfeb5 ("drm/vgem: Implement mmap as GEM object function") accidentally removed the actual mmap functionality from vgem. Restore the original implementation and VMA flags. Fixes access to unmapped memory: [ 106.591744] BUG: KASAN: vmalloc-out-of-bounds in do_fault+0x38/0x480 [ 106.

Re: [Intel-gfx] [PATCH] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 5:19 PM Matthew Auld wrote: > > EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it > possible for userspace to bypass the GTT caching bits set by the kernel, > as per the given object cache_level. This is troublesome since the heavy > flush we apply when first

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-09 Thread Raphael Gallais-Pou
On 7/9/21 10:04 AM, Pekka Paalanen wrote: On Wed, 7 Jul 2021 08:48:47 + Raphael GALLAIS-POU - foss wrote: Some display controllers can be programmed to present non-black colors for pixels not covered by any plane (or pixels covered by the transparent regions of higher planes). Composito

Re: [Intel-gfx] [PATCH] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Matthew Auld
On Fri, 9 Jul 2021 at 17:13, Daniel Vetter wrote: > > On Fri, Jul 9, 2021 at 5:19 PM Matthew Auld wrote: > > > > EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it > > possible for userspace to bypass the GTT caching bits set by the kernel, > > as per the given object cache_level.

Re: Re: Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-09 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2021年7月9日 週五 下午7:28寫道: > > > Gesendet: Freitag, 09. Juli 2021 um 12:38 Uhr > > Von: "Frank Wunderlich" > > An: "Enric Balletbo Serra" > > Cc: "CK Hu" , "Dafna Hirschfeld" > > , "chunkuang Hu" , > > "Thomas Zimmermann" , "David Airlie" > > , "linux-kernel" , "Enr

Re: [Intel-gfx] [PATCH] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 6:35 PM Matthew Auld wrote: > > On Fri, 9 Jul 2021 at 17:13, Daniel Vetter wrote: > > > > On Fri, Jul 9, 2021 at 5:19 PM Matthew Auld wrote: > > > > > > EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it > > > possible for userspace to bypass the GTT caching

Re: [PATCH 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-09 Thread khsieh
On 2021-07-08 00:21, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:20) Main link symbol locked is achieved at end of link training 2. Some dongle main link symbol may become unlocked again if host did not end link training soon enough after completion of link training 2. Host have t

Re: [PATCH v3] drm/panel: Add support for E Ink VB3300-KCA

2021-07-09 Thread Sam Ravnborg
Hi Alistair, On Thu, Jul 08, 2021 at 09:57:35PM +1000, Alistair Francis wrote: > Add support for the 10.3" E Ink panel described at: > https://www.eink.com/product.html?type=productdetail&id=7 > > Signed-off-by: Alistair Francis > Acked-by: Rob Herring > --- > .../bindings/display/panel/panel-

Re: [PATCH 1/2 v3] drm/panel: Add DT bindings for Samsung LMS380KF01

2021-07-09 Thread Sam Ravnborg
Hi Linus, On Thu, Jul 08, 2021 at 01:43:14AM +0200, Linus Walleij wrote: > This adds device tree bindings for the Samsung Mobile Displays > LMS380KF01 RGB DPI display panel. > > Cc: devicet...@vger.kernel.org > Cc: phone-de...@vger.kernel.org > Cc: Douglas Anderson > Cc: Noralf Trønnes > Signed

Re: [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-09 Thread khsieh
On 2021-07-08 00:33, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:15) Reduce link rate and re start link training if link training 1 failed due to loss of clock recovery done to fix Link Layer CTS case 4.3.1.7. Also only update voltage and pre-emphasis swing level after link train

Re: [PATCH 2/2 v3] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-09 Thread Sam Ravnborg
Hi Linus, On Thu, Jul 08, 2021 at 01:43:15AM +0200, Linus Walleij wrote: > This adds a driver for panels based on the WideChips WS2401 display > controller. This display controller is used in the Samsung LMS380KF01 > display found in the Samsung GT-I8160 (Codina) mobile phone and > possibly others

Re: [PATCH v3 1/2] drm/panel: simple: Add support for EDT ETMV570G2DHU panel

2021-07-09 Thread Sam Ravnborg
Hi Yunus, On Tue, Jul 06, 2021 at 09:59:07AM +0200, Yunus Bas wrote: > From: Stefan Riedmueller > > This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel > to DRM simple panel driver. > > Signed-off-by: Stefan Riedmueller > Signed-off-by: Yunus Bas > --- > Changes in v3: >

[PATCH v1] fix vmwgfx compilation error due to a missing include

2021-07-09 Thread Tong Zhang
This patch fixes vmwgfx driver compilation error due to a missing include drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’: drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of function ‘ttm_range_man_init’ [-Werror=implicit-function-declaration] 678

Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel

2021-07-09 Thread Sam Ravnborg
Hi Yunus, On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote: > From: Stefan Riedmueller > > This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd > panel to DRM simple panel driver. > > Signed-off-by: Stefan Riedmueller > Signed-off-by: Yunus Bas > --- > Changes in v3: >

Re: [PATCH] drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c

2021-07-09 Thread Jagan Teki
On Fri, Jul 2, 2021 at 10:58 AM Jagan Teki wrote: > > Hi Sam and Thierry, > > On Tue, May 25, 2021 at 12:12 AM Jagan Teki > wrote: > > > > ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per > > recent testing in i.MX8MM platform. > > > > Fix it. > > > > Signed-off-by: Jagan Teki > > --- >

Re: [PATCH 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-07-09 Thread khsieh
On 2021-07-08 00:14, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:18) Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c |

Re: [PATCH] drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c

2021-07-09 Thread Sam Ravnborg
Hi Jagan, On Fri, Jul 09, 2021 at 11:43:53PM +0530, Jagan Teki wrote: > On Fri, Jul 2, 2021 at 10:58 AM Jagan Teki wrote: > > > > Hi Sam and Thierry, > > > > On Tue, May 25, 2021 at 12:12 AM Jagan Teki > > wrote: > > > > > > ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per > > > recent t

Re: [PATCH 01/12] drm/mgag200: Select clock in PLL update functions

2021-07-09 Thread Sam Ravnborg
Hi Thomas, On Mon, Jul 05, 2021 at 02:45:04PM +0200, Thomas Zimmermann wrote: > Put the clock-selection code into each of the PLL-update functions to > make them select the correct pixel clock. > > The pixel clock for video output was not actually set before programming > the clock's values. It w

Re: [PATCH 02/12] drm/mgag200: Return errno codes from PLL compute functions

2021-07-09 Thread Sam Ravnborg
On Mon, Jul 05, 2021 at 02:45:05PM +0200, Thomas Zimmermann wrote: > Return -EINVAL if there's no PLL configuration for the given pixel > clock. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > di

Re: [PATCH 03/12] drm/mgag200: Remove P_ARRAY_SIZE

2021-07-09 Thread Sam Ravnborg
On Mon, Jul 05, 2021 at 02:45:06PM +0200, Thomas Zimmermann wrote: > Replace P_ARRAY_SIZE by array pre-initializing and ARRAY_SIZE(). No > functional changes. > > Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg

Re: [PATCH v3 1/2] drm/panel: simple: Add support for EDT ETMV570G2DHU panel

2021-07-09 Thread Yunus Bas
Hi Sam, Am Freitag, dem 09.07.2021 um 20:08 +0200 schrieb Sam Ravnborg: > Hi Yunus, > > On Tue, Jul 06, 2021 at 09:59:07AM +0200, Yunus Bas wrote: > > From: Stefan Riedmueller > > > > This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd > > panel > > to DRM simple panel driver. >

Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel

2021-07-09 Thread Yunus Bas
Hi Sam, Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg: > Hi Yunus, > > On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote: > > From: Stefan Riedmueller > > > > This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd > > panel to DRM simple panel driver. > >

Re: [PATCH 04/12] drm/mgag200: Split PLL setup into compute and update functions

2021-07-09 Thread Sam Ravnborg
Ho Thomas, On Mon, Jul 05, 2021 at 02:45:07PM +0200, Thomas Zimmermann wrote: > The _set_plls() functions compute a pixel clock's PLL values > and program the hardware accordingly. This happens during atomic > commits. > > For atomic modesetting, it's better to separate computation and > programm

Re: [PATCH 05/12] drm/mgag200: Introduce separate variable for PLL S parameter

2021-07-09 Thread Sam Ravnborg
On Mon, Jul 05, 2021 at 02:45:08PM +0200, Thomas Zimmermann wrote: > The S parameter is controls the loop filter bandwidth when programming > the PLL. It's currently stored as part of P (i.e., the clock divider.) > Add a separate variable for S prepares the PLL code for a further > refactoring. >

[PATCH v8 00/14] drm/tegra: Introduce a modern UABI

2021-07-09 Thread Thierry Reding
From: Thierry Reding Hi all, Mikko has been away for a few weeks, so I've been testing and revising the new UABI patches in the meantime. There are very minor changes to the naming of some of the UABI fields, but other than that it's mostly unchanged from v7. One notable change is that mappings

[PATCH v8 01/14] gpu: host1x: Add DMA fence implementation

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Add an implementation of dma_fences based on syncpoints. Syncpoint interrupts are used to signal fences. Additionally, after software signaling has been enabled, a 30 second timeout is started. If the syncpoint threshold is not reached within this period, the fence is signal

[PATCH v8 02/14] gpu: host1x: Add no-recovery mode

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Add a new property for jobs to enable or disable recovery i.e. CPU increments of syncpoints to max value on job timeout. This allows for a more solid model for hanged jobs, where userspace doesn't need to guess if a syncpoint increment happened because the job completed, or

[PATCH v8 03/14] gpu: host1x: Add job release callback

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Add a callback field to the job structure, to be called just before the job is to be freed. This allows the job's submitter to clean up any of its own state, like decrement runtime PM refcounts. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding --- drivers/gpu

[PATCH v8 04/14] gpu: host1x: Add support for syncpoint waits in CDMA pushbuffer

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Add support for inserting syncpoint waits in the CDMA pushbuffer. These waits need to be done in HOST1X class, while gather submitted by the application execute in engine class. Support is added by converting the gather list of job into a command list that can include both

[PATCH v8 05/14] drm/tegra: Extract tegra_gem_lookup

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen The static function host1x_bo_lookup in drm.c is also useful elsewhere. Extract it as tegra_gem_lookup in gem.c. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 20 +++- drivers/gpu/drm/tegra/gem.c | 13 +

[PATCH v8 06/14] drm/tegra: Add new UAPI to header

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Update the tegra_drm.h UAPI header, adding the new proposed UAPI. The old staging UAPI is left in for now, with minor modification to avoid name collisions. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding --- Changes in v8: - renamed hardware_flags to capabil

[PATCH v8 07/14] drm/tegra: Boot VIC during runtime PM resume

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen With the new UAPI implementation, engines are powered on and off when there are active jobs, and the core code handles channel allocation. To accommodate that, boot the engine as part of runtime PM instead of using the open_channel callback, which is not used by the new subm

[PATCH v8 08/14] drm/tegra: Allocate per-engine channel in core code

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen To avoid code duplication, allocate the per-engine shared channel in the core code instead. This is the usual channel that all jobs are submitted to when MLOCKing is not in use. Once MLOCKs are implemented on Host1x side, we can also update this to avoid allocating a shared

[PATCH v8 09/14] drm/tegra: Implement new UAPI

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Implement the non-submission parts of the new UAPI, including channel management and memory mapping. The UAPI is under the CONFIG_DRM_TEGRA_STAGING config flag for now. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding --- Changes in v8: - rebase on top of late

[PATCH v8 10/14] drm/tegra: Implement syncpoint management UAPI

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Implement TegraDRM IOCTLs for allocating and freeing syncpoints. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 5 drivers/gpu/drm/tegra/uapi.c | 52 drivers/gpu/drm/tegra/uapi.h

[PATCH v8 11/14] drm/tegra: Implement syncpoint wait UAPI

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Implement new syncpoint wait UAPI. This is different from the legacy one in taking an absolute timestamp in line with modern DRM conventions. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding --- Changes in v8: - rebase on top of latest UABI changes drivers/g

[PATCH v8 12/14] drm/tegra: Implement job submission part of new UAPI

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Implement the job submission IOCTL with a minimum feature set. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding --- Changes in v8: - rebased on top of latest UABI changes drivers/gpu/drm/tegra/Makefile| 2 + drivers/gpu/drm/tegra/drm.c | 4 +-

[PATCH v8 13/14] drm/tegra: Add job firewall

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Add a firewall that validates jobs before submission to ensure they don't do anything they aren't allowed to do, like accessing memory they should not access. The firewall is functionality-wise a copy of the firewall already implemented in gpu/host1x. It is copied here as i

[PATCH v8 14/14] drm/tegra: Bump driver version

2021-07-09 Thread Thierry Reding
From: Mikko Perttunen Bump driver version to 1.0.0 to allow userspace to detect availability of new interfaces. Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegr

Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel

2021-07-09 Thread Sam Ravnborg
Hi Yunus, On Fri, Jul 09, 2021 at 07:02:52PM +, Yunus Bas wrote: > Hi Sam, > > Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg: > > Hi Yunus, > > > > On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote: > > > From: Stefan Riedmueller > > > > > > This patch adds support

Re: [PATCH 2/2] drm/ttm: Fix COW check

2021-07-09 Thread Felix Kuehling
On 2021-07-09 2:38 a.m., Christian König wrote: Am 08.07.21 um 21:36 schrieb Alex Deucher: From: Felix Kuehling KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. is_cow_mapping returns true for these mappings. Add a check for vm_flags & VM_WRITE to avoid mmap failures on private

Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel

2021-07-09 Thread Yunus Bas
Am Freitag, dem 09.07.2021 um 21:30 +0200 schrieb Sam Ravnborg: > Hi Yunus, > > On Fri, Jul 09, 2021 at 07:02:52PM +, Yunus Bas wrote: > > Hi Sam, > > > > Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg: > > > Hi Yunus, > > > > > > On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yun

Re: [PATCH] drm/gma500: Add the missed drm_gem_object_put() in psb_user_framebuffer_create()

2021-07-09 Thread Patrik Jakobsson
On Tue, Jun 29, 2021 at 1:52 PM Jing Xiangfeng wrote: > > psb_user_framebuffer_create() misses to call drm_gem_object_put() in an > error path. Add the missed function call to fix it. > Sorry for the delay, I'm currently on vacation. Looks good. Thanks for the patch. Applied to drm-misc-next -P

Re: [PATCH 2/2] drm/ttm: Fix COW check

2021-07-09 Thread Christian König
Am 09.07.21 um 21:31 schrieb Felix Kuehling: On 2021-07-09 2:38 a.m., Christian König wrote: Am 08.07.21 um 21:36 schrieb Alex Deucher: From: Felix Kuehling KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. is_cow_mapping returns true for these mappings. Add a check for vm_flag

Re: [PATCH v1] fix vmwgfx compilation error due to a missing include

2021-07-09 Thread Randy Dunlap
On 7/9/21 11:09 AM, Tong Zhang wrote: > This patch fixes vmwgfx driver compilation error due to a missing include > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’: > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of > function ‘ttm_range_man_ini

[PATCH v4 1/2] drm/panel: simple: Add support for EDT ETMV570G2DHU panel

2021-07-09 Thread Yunus Bas
From: Stefan Riedmueller This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel to DRM simple panel driver. Signed-off-by: Stefan Riedmueller Signed-off-by: Yunus Bas --- Changes in v4: - Moved code to proper place to keep alphabetic order --- drivers/gpu/drm/panel/panel-si

[PATCH v4 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel

2021-07-09 Thread Yunus Bas
From: Stefan Riedmueller This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver. Signed-off-by: Stefan Riedmueller Signed-off-by: Yunus Bas --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+

Re: [PATCH v1] fix vmwgfx compilation error due to a missing include

2021-07-09 Thread Dave Airlie
cc'ing Christian to fix this I assume it was ttm refactor? > > This patch fixes vmwgfx driver compilation error due to a missing include > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’: > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of > func

[PATCH] drm/of: free the right object

2021-07-09 Thread Julia Lawall
There is no need to free a NULL value. Instead, free the object that is leaking due to the iterator. The semantic patch that finds this problem is as follows: // @@ expression x,e; identifier f; @@ x = f(...); if (x == NULL) { ... when any when != x = e * of_node_put

  1   2   >