[PATCH 33/53] drm/i915/dg2: Add fake PCH

2021-07-01 Thread Matt Roper
As with DG1, DG2 has an ICL-style south display interface provided on the same PCI device. Add a fake PCH to ensure DG2 takes the appropriate codepaths for south display handling. Bspec: 54871, 50062, 49961, 53673 Cc: Lucas De Marchi Signed-off-by: Matt Roper Signed-off-by: Aditya Swarup Signe

[PATCH 14/53] drm/i915/xehp: handle new steering options

2021-07-01 Thread Matt Roper
From: Daniele Ceraolo Spurio Xe_HP is more modular then its predecessors and as a consequence it has more types of replicated registers. As with l3bank regions on previous platforms, we may need to explicitly re-steer accesses to these new types of ranges at runtime if we can't find a single def

[PATCH 31/53] drm/i915/dg2: Report INSTDONE_GEOM values in error state

2021-07-01 Thread Matt Roper
Xe_HPG adds some additional INSTDONE_GEOM debug registers; the Mesa team has indicated that having these reported in the error state would be useful for debugging GPU hangs. These registers are replicated per-DSS with gslice steering. Cc: Lionel Landwerlin Signed-off-by: Matt Roper --- drivers

[PATCH 06/53] drm/i915/selftests: Allow for larger engine counts

2021-07-01 Thread Matt Roper
From: John Harrison Increasing the engine count causes a couple of local array variables to exceed the kernel stack limit. So make them dynamic allocations instead. Signed-off-by: John Harrison Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/selfte

[PATCH 18/53] drm/i915/xehpsdv: Add maximum sseu limits

2021-07-01 Thread Matt Roper
Due to the removal of legacy slices and the transition to a gslice/cslice/mslice/etc. design, we'll internally store all DSS under "slice0." Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_sseu.c | 5 - drivers/gpu/drm/i915/gt/intel_sseu.h | 2 +- drivers/gpu/drm/

[PATCH 37/53] drm/i915/dg2: Setup display outputs

2021-07-01 Thread Matt Roper
DG2 has outputs on DDI A-D attached to what the bspec diagram shows as "Combo PHY A-D." Note that despite being labelled "combo" the PHYs on these outputs are Synopsys PHYs rather than traditional Intel combo PHY technology. Cc: Anusha Srivatsa Signed-off-by: Matt Roper --- drivers/gpu/drm/i91

[PATCH 41/53] drm/i915/dg2: DG2 has fixed memory bandwidth

2021-07-01 Thread Matt Roper
DG2 doesn't have a SAGV or QGV points that determine memory bandwidth. Instead it has a constant amount of memory bandwidth available to display that does not need to be reduced based on the number of active planes. For simplicity, we'll just modify driver initialization to create a single dummy Q

[PATCH 26/53] drm/i915/dg2: Add forcewake table

2021-07-01 Thread Matt Roper
The DG2 forcewake table is very similar to the one used by XeHP SDV (and both platforms are even presented as a single table in the bspec). For the most part DG2 starts using a few additional ranges that were 'reserved' on XeHP SDV and stops using some others. However there is a single range (0xd

[PATCH 30/53] drm/i915/dg2: Maintain backward-compatible nested batch behavior

2021-07-01 Thread Matt Roper
For tgl+, the per-context setting of MI_MODE[12] determines whether the bits of a nested MI_BATCH_BUFFER_START instruction should be interpreted in the traditional manner or whether they should instead use a new tgl+ meaning that breaks backward compatibility, but allows nesting into 3rd-level batc

[PATCH 39/53] drm/i915/dg2: Don't program BW_BUDDY registers

2021-07-01 Thread Matt Roper
Although the BW_BUDDY registers still exist, they are not used for anything on DG2. This change is expected to hold true for future dgpu's too. Bspec: 49218 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 1 file changed, 4 insertions(+) diff --git a/d

[PATCH 38/53] drm/i915/dg2: Add dbuf programming

2021-07-01 Thread Matt Roper
DG2 extends our DDB to four DBuf slices; pipes A+B only have access to the first two slices, whereas pipes C+D only have access to the second two. Confusingly, our bspec decided to switch from 1-based numbering of dbuf slices (S1, S2) to 0-based numbering (S0, S1, S2, S3) in Display13. At the mom

[PATCH 23/53] drm/i915/xehpsdv: Read correct RP_STATE_CAP register

2021-07-01 Thread Matt Roper
The RP_STATE_CAP register is no longer part of the MCHBAR on XEHPSDV; this register is now a per-tile register at GTTMMADDR offset 0x250014. Cc: Rodrigo Vivi Signed-off-by: Matt Roper Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_rps.c | 4 +++- drivers/gpu/drm/i915/i915_reg

[PATCH 21/53] drm/i915/xehpsdv: Define MOCS table for XeHP SDV

2021-07-01 Thread Matt Roper
From: Lucas De Marchi Like DG1, XeHP SDV doesn't have LLC/eDRAM control values due to being a dgfx card. XeHP SDV adds 2 more bits: L3_GLBGO to "push the Go point to memory for L3 destined transaction" and L3_LKP to "enable Lookup for uncacheable accesses". Bspec: 45101 Cc: Daniele Ceraolo Spuri

[PATCH 20/53] drm/i915/xehpsdv: Define steering tables

2021-07-01 Thread Matt Roper
Define and initialize the MMIO ranges for which XeHP SDV requires MSLICE and LNCF steering. Bspec: 66534 Cc: Tvrtko Ursulin Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt.c | 19 ++- drivers/gpu/drm/i915/gt/intel_workarounds.c

[PATCH 50/53] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable

2021-07-01 Thread Matt Roper
From: Anusha Srivatsa DSC can be supported per DP connector. This patch creates a per connector debugfs node to expose the Input and Compressed BPP. The same node can be used from userspace to force DSC to a certain BPP. force_dsc_bpp is written through this debugfs node to force DSC BPP to all

[PATCH 51/53] drm/i915/display/dsc: Set BPP in the kernel

2021-07-01 Thread Matt Roper
From: Anusha Srivatsa Set compress BPP in kernel while connector DP or eDP Cc: Vandita Kulkarni Cc: Navare Manasi D Signed-off-by: Anusha Srivatsa Signed-off-by: Patnana Venkata Sai Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dp.c | 23 ++- 1 file c

[PATCH 22/53] drm/i915/xehpsdv: factor out function to read RP_STATE_CAP

2021-07-01 Thread Matt Roper
From: Lucas De Marchi Instead of maintaining the same if ladder in 3 different places, add a function to read RP_STATE_CAP. Signed-off-by: Lucas De Marchi Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/debugfs_gt_pm.c | 8 +++- drivers/gpu/drm/i915/gt/intel_rps.c | 17

[PATCH 32/53] drm/i915/dg2: Define MOCS table for DG2

2021-07-01 Thread Matt Roper
Bspec: 45101, 45427 Cc: Ramalingam C (v5) Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_mocs.c | 35 +++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c index 0c9d0b93

[PATCH 07/53] drm/i915/xehp: Extra media engines - Part 1 (engine definitions)

2021-07-01 Thread Matt Roper
From: John Harrison Xe_HP can have a lot of extra media engines. This patch adds the basic definitions for them. Cc: Tvrtko Ursulin Signed-off-by: John Harrison Signed-off-by: Tomas Winkler Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 ++- drivers/gpu/drm/

[PATCH 45/53] drm/i915/dg2: Update modeset sequences

2021-07-01 Thread Matt Roper
DG2 has some changes to the expected modesetting sequences when compared to gen12. Adjust our driver logic accordingly. Although the DP sequence is pretty similar to TGL's, there are some steps that change, so let's split the handling for that out into a separate function. Bspec: 54128 Cc: Lucas

[PATCH 44/53] drm/i915/dg2: Add vswing programming for SNPS phys

2021-07-01 Thread Matt Roper
Vswing programming for SNPS PHYs is just a single step -- look up the value that corresponds to the voltage level from a table and program it into the SNPS_PHY_TX_EQ register. Bspec: 53920 Cc: Matt Atwood Signed-off-by: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/int

[PATCH 29/53] drm/i915/dg2: Add new LRI reg offsets

2021-07-01 Thread Matt Roper
From: Akeem G Abodunrin New LRI register offsets were introduced for DG2, this patch adds those extra registers, and create new register table for setting offsets to compare with HW generated context image - especially for gt_lrc test. Also updates general purpose register with scratch offset for

[PATCH 43/53] drm/i915/dg2: Add MPLLB programming for HDMI

2021-07-01 Thread Matt Roper
At the moment we don't have a proper algorithm that can be used to calculate PHY settings for arbitrary HDMI link rates. The PHY tables here should support the regular modes of real-world HDMI monitors. Bspec: 54032 Cc: Matt Atwood Signed-off-by: Matt Roper Signed-off-by: Vandita Kulkarni ---

[PATCH 04/53] drm/i915/xehp: VDBOX/VEBOX fusing registers are enable-based

2021-07-01 Thread Matt Roper
From: Tvrtko Ursulin On Xe_HP the fusing register is renamed and changed to have the "enable" semantics, but otherwise remains compatible (mmio address, bitmask ranges) with older platforms. To simplify things we do not add a new register definition but just stop inverting the fusing masks befor

[PATCH 46/53] drm/i915/dg2: Classify DG2 PHY types

2021-07-01 Thread Matt Roper
Although the bspec labels four of DG2's outputs as "combo PHY," the underlying PHYs in both cases are actually Synopsys PHYs that are programmed completely differently than the traditional Intel "combo" PHY units. As such, we don't want intel_phy_is_combo to take us down legacy programming paths,

[PATCH 47/53] drm/i915/dg2: Wait for SNPS PHY calibration during display init

2021-07-01 Thread Matt Roper
Initialization of the PHY is handled by the hardware/firmware, but the driver should wait up to 25ms for the PHY to report that its calibration has completed. Bspec: 49189 Bspec: 50107 Cc: Matt Atwood Signed-off-by: Matt Roper --- .../gpu/drm/i915/display/intel_display_power.c| 5 + dr

[PATCH 48/53] drm/i915/dg2: Update lane disable power state during PSR

2021-07-01 Thread Matt Roper
From: Gwan-gyeong Mun The PSR enable/disable sequences now require that we program an extra register in the PHY to adjust the lane disable power setting. Bspec: 49274 Bspec: 53885 Cc: Anusha Srivatsa Signed-off-by: Matt Roper Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/in

[PATCH 53/53] drm/i915/dg2: Configure PCON in DP pre-enable path

2021-07-01 Thread Matt Roper
From: Ankit Nautiyal Add the functions to configure HDMI2.1 pcon for DG2, before DP link training. Signed-off-by: Ankit Nautiyal Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_ddi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi

[PATCH 36/53] drm/i915/dg2: Don't wait for AUX power well enable ACKs

2021-07-01 Thread Matt Roper
On DG2 we're supposed to just wait 600us after programming the well before moving on; there won't be an ack from the hardware. Bspec: 49296 Signed-off-by: Matt Roper --- .../gpu/drm/i915/display/intel_display_power.c | 16 .../gpu/drm/i915/display/intel_display_power.h | 6

[PATCH 49/53] drm/i915/dg2: Add DG2 to the PSR2 defeature list

2021-07-01 Thread Matt Roper
From: José Roberto de Souza PSR2 is not supported on DG2. Cc: Caz Yokoyama Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_psr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i9

[PATCH 35/53] drm/i915/dg2: Skip shared DPLL handling

2021-07-01 Thread Matt Roper
DG2 has no shared DPLL's or DDI clock muxing. The Port PLL is embedded within the PHY. Bspec: 54032 Bspec: 54034 Cc: Lucas De Marchi Cc: Mohammed Khajapasha Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display.c | 10 +++--- drivers/gpu/drm/i915/display/intel_dpll_mgr

[PATCH 40/53] drm/i915/dg2: Don't read DRAM info

2021-07-01 Thread Matt Roper
DG2 does not use system DRAM information for BW_BUDDY programming or watermark workarounds, so there's no need to read this out at startup. Cc: Anusha Srivatsa Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_dram.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 12/53] drm/i915/xehp: Handle new device context ID format

2021-07-01 Thread Matt Roper
From: Stuart Summers Xe_HP changes the format of the context ID from past platforms. Cc: Robert M. Fosha Signed-off-by: Stuart Summers Signed-off-by: Umesh Nerlige Ramappa Signed-off-by: Matt Roper --- .../drm/i915/gt/intel_execlists_submission.c | 74 --- drivers/gpu/drm/i

Re: [PATCH] drm/msm/dsi: drop gdsc regulator handling

2021-07-01 Thread Bjorn Andersson
On Wed 30 Jun 19:00 CDT 2021, Dmitry Baryshkov wrote: > None of supported devies uses "gdsc" regulator for DSI. GDSC support is > now implemented as a power domain. Drop old code and config handling > gdsc regulator requesting and enabling. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn

Re: [Freedreno] [RFC 2/6] drm/msm/dpu: support setting up two independent DSI connectors

2021-07-01 Thread abhinavk
On 2021-06-09 14:17, Dmitry Baryshkov wrote: Move setting up encoders from set_encoder_mode to _dpu_kms_initialize_dsi() / _dpu_kms_initialize_displayport(). This allows us to support not only "single DSI" and "dual DSI" but also "two independent DSI" configurations. In future this would also hel

Re: [git pull] drm for 5.14-rc1

2021-07-01 Thread Felix Kuehling
Am 2021-07-01 um 4:15 p.m. schrieb Linus Torvalds: > On Wed, Jun 30, 2021 at 9:34 PM Dave Airlie wrote: >> Hi Linus, >> >> This is the main drm pull request for 5.14-rc1. >> >> I've done a test pull into your current tree, and hit two conflicts >> (one in vc4, one in amdgpu), both seem pretty triv

Re: [PATCH v2] drm/meson: fix potential NULL pointer exception in meson_drv_unbind()

2021-07-01 Thread Martin Blumenstingl
Hello, first of all: thanks for your patch and sorry for being late with my review question. On Fri, Jun 18, 2021 at 7:28 AM Jiajun Cao wrote: > > Fix a potential NULL pointer exception when meson_drv_unbind() > attempts to operate on the driver_data priv which may be NULL. > Add a null pointer

[PATCH] drm/panel: Fix up DT bindings for Samsung lms397kf04

2021-07-01 Thread Linus Walleij
Improve the bindings and make them more usable: - Pick in spi-cpha and spi-cpol from the SPI node parent, this will specify that we are "type 3" in the device tree rather than hardcoding it in the operating system. - Drop the u32 ref from the SPI frequency: comes in from the SPI host binding

Re: [PATCH 23/53] drm/i915/xehpsdv: Read correct RP_STATE_CAP register

2021-07-01 Thread Rodrigo Vivi
On Thu, Jul 01, 2021 at 01:23:57PM -0700, Matt Roper wrote: > The RP_STATE_CAP register is no longer part of the MCHBAR on XEHPSDV; this > register is now a per-tile register at GTTMMADDR offset 0x250014. > > Cc: Rodrigo Vivi > Signed-off-by: Matt Roper > Signed-off-by: Lucas De Marchi Reviewe

Re: [PATCH 16/53] drm/i915/xehpsdv: add initial XeHP SDV definitions

2021-07-01 Thread Rodrigo Vivi
On Thu, Jul 01, 2021 at 01:23:50PM -0700, Matt Roper wrote: > From: Lucas De Marchi > > XeHP SDV is a Intel® dGPU without display. This is just the definition > of some basic platform macros, by large a copy of current state of > Tigerlake which does not reflect the end state of this platform. >

Re: [PATCH 04/53] drm/i915/xehp: VDBOX/VEBOX fusing registers are enable-based

2021-07-01 Thread Lucas De Marchi
On Thu, Jul 01, 2021 at 01:23:38PM -0700, Matt Roper wrote: From: Tvrtko Ursulin On Xe_HP the fusing register is renamed and changed to have the "enable" semantics, but otherwise remains compatible (mmio address, bitmask ranges) with older platforms. To simplify things we do not add a new regi

Re: [Intel-gfx] [PATCH 05/53] drm/i915/gen12: Use fuse info to enable SFC

2021-07-01 Thread Lucas De Marchi
On Thu, Jul 01, 2021 at 01:23:39PM -0700, Matt Roper wrote: From: Venkata Sandeep Dhanalakota In Gen12 there are various fuse combinations and in each configuration vdbox engine may be connected to SFC depending on which engines are available, so we need to set the SFC capability based on fuse

[PATCH] drm/dbi: Print errors for mipi_dbi_command()

2021-07-01 Thread Linus Walleij
The macro mipi_dbi_command() does not report errors unless you wrap it in another macro to do the error reporting. Report a rate-limited error so we know what is going on. Drop the only user in DRM using mipi_dbi_command() and actually checking the error explicitly, let it use mipi_dbi_command_bu

Re: [PATCH 06/53] drm/i915/selftests: Allow for larger engine counts

2021-07-01 Thread Lucas De Marchi
On Thu, Jul 01, 2021 at 01:23:40PM -0700, Matt Roper wrote: From: John Harrison Increasing the engine count causes a couple of local array variables to exceed the kernel stack limit. So make them dynamic allocations instead. Signed-off-by: John Harrison Signed-off-by: Daniele Ceraolo Spurio

Re: [PATCH v2] drm/panfrost:report the full raw fault information instead

2021-07-01 Thread Chunyou Tang
Hi Steve, > You didn't answer my previous question: > > > Is this device working with the kbase/DDK proprietary driver? I don't know whether I used kbase/DDK,I only know I used the driver of panfrost in linux 5.11. > What you are describing sounds like a hardware integration issue, so > it would

Re: [PATCH v15 12/12] of: Add plumbing for restricted DMA pool

2021-07-01 Thread Guenter Roeck
pecific files for 20210701 # good: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13 git bisect start 'HEAD' 'v5.13' # bad: [f63c4fda987a19b1194cc45cb72fd5bf968d9d90] Merge remote-tracking branch 'rdma/for-next' git bisect bad f63c4fda987a19b1194cc45cb72fd5bf968d9d90 #

Re: [PATCH 2/2] drm/vc4: hdmi: Convert to gpiod

2021-07-01 Thread Nathan Chancellor
On Mon, May 24, 2021 at 03:18:52PM +0200, Maxime Ripard wrote: > The new gpiod interface takes care of parsing the GPIO flags and to > return the logical value when accessing an active-low GPIO, so switching > to it simplifies a lot the driver. > > Signed-off-by: Maxime Ripard > --- > drivers/gp

Re: [PATCH 0/4] mgag200: Various cleanups

2021-07-01 Thread Thomas Zimmermann
Hi Sam Am 01.07.21 um 19:58 schrieb Sam Ravnborg: Hi Thomas, On Thu, Jul 01, 2021 at 02:43:12PM +0200, Thomas Zimmermann wrote: Cleanup several nits in the driver's init code. Also move constant data into the RO data segment. No functional changes. Tested on mgag200 HW. Thomas Zimmermann (4)

Re: [PATCH] drm/panel: Fix up DT bindings for Samsung lms397kf04

2021-07-01 Thread Sam Ravnborg
Hi Linus, On Thu, Jul 01, 2021 at 11:36:18PM +0200, Linus Walleij wrote: > Improve the bindings and make them more usable: > > - Pick in spi-cpha and spi-cpol from the SPI node parent, > this will specify that we are "type 3" in the device tree > rather than hardcoding it in the operating sys

Re: [PATCH] drm/panel: panel-simple: Fix proper bpc for ytc700tlag_05_201c

2021-07-01 Thread Jagan Teki
Hi Sam and Thierry, On Tue, May 25, 2021 at 12:12 AM Jagan Teki wrote: > > ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per > recent testing in i.MX8MM platform. > > Fix it. > > Signed-off-by: Jagan Teki > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH] drm/dbi: Print errors for mipi_dbi_command()

2021-07-01 Thread Sam Ravnborg
Hi Linus, On Fri, Jul 02, 2021 at 12:25:18AM +0200, Linus Walleij wrote: > The macro mipi_dbi_command() does not report errors unless you wrap it > in another macro to do the error reporting. > > Report a rate-limited error so we know what is going on. > > Drop the only user in DRM using mipi_db

Re: [Intel-gfx] [PATCH v1 2/2] drm/i915/gem: Migrate to system at dma-buf attach time

2021-07-01 Thread kernel test robot
Hi "Michael, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.13 next-20210701] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '

<    1   2