Re: [PATCH v3 2/2] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2021-06-24 Thread Uwe Kleine-König
Hello Bjorn, On Wed, Jun 23, 2021 at 06:08:32PM -0500, Bjorn Andersson wrote: > On Wed 23 Jun 03:29 CDT 2021, Uwe Kleine-K?nig wrote: > > On Tue, Jun 22, 2021 at 08:12:48PM -0500, Bjorn Andersson wrote: > > > On Tue 22 Jun 15:29 CDT 2021, Uwe Kleine-K?nig wrote: > > > > On Mon, Jun 21, 2021 at 10:

[PULL] drm-misc-next-fixes

2021-06-24 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the drm-misc-next-fixes PR for this week. Best regards Thomas drm-misc-next-fixes-2021-06-24: Short summary of fixes pull: * amdgpu: Fix test for allocation failures The following changes since commit 24ff3dc18b99c4b912ab1746e803ddb3be5ced4c: drm/dp_mst: Add missi

[PATCH v3 01/27] drm/amdgpu: Track IRQ state in local device state

2021-06-24 Thread Thomas Zimmermann
Replace usage of struct drm_device.irq_enabled with the driver's own state field struct amdgpu_device.irq.installed. The field in the DRM device structure is considered legacy and should not be used by KMS drivers. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel V

[PATCH v3 00/27] Deprecate struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
Remove references to struct drm_device.irq_enabled from modern DRM drivers and core. KMS drivers enable IRQs for their devices internally. They don't have to keep track of the IRQ state via irq_enabled. For vblanking, it's cleaner to test for vblanking support directly than to test for enabled IRQ

[PATCH v3 02/27] drm/hibmc: Call drm_irq_uninstall() unconditionally

2021-06-24 Thread Thomas Zimmermann
Remove the check around drm_irq_uninstall(). The same test is done by the function internally. The tested state in irq_enabled is considered obsolete and should not be used by KMS drivers. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Tian Tao Acked-by: Daniel Vetter

[PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-24 Thread Thomas Zimmermann
For KMS drivers, replace the IRQ check in VBLANK ioctls with a check for vblank support. IRQs might be enabled wthout vblanking being supported. This change also removes the DRM framework's only dependency on IRQ state for non-legacy drivers. For legacy drivers with userspace modesetting, the orig

[PATCH v3 07/27] drm/komeda: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in komeda. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Liviu Dudau Acked-by: Daniel Vetter --- drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 1 file

[PATCH v3 03/27] drm/radeon: Track IRQ state in local device state

2021-06-24 Thread Thomas Zimmermann
Replace usage of struct drm_device.irq_enabled with the driver's own state field struct radeon_device.irq.installed. The field in the DRM device structure is considered legacy and should not be used by KMS drivers. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel V

[PATCH v3 05/27] drm/armada: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in armada. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm

[PATCH v3 08/27] drm/malidp: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in malidp. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Liviu Dudau Acked-by: Daniel Vetter --- drivers/gpu/drm/arm/malidp_drv.c | 4 1 file changed, 4 del

[PATCH v3 09/27] drm/exynos: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in exynos. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 -- 1 file changed, 10 deletions(-

[PATCH v3 06/27] drm/i915: Track IRQ state in local device state

2021-06-24 Thread Thomas Zimmermann
Replace usage of struct drm_device.irq_enabled with the driver's own state field struct drm_i915_private.irq_enabled. The field in the DRM device structure is considered legacy and should not be used by KMS drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ dri

[PATCH v3 11/27] drm/imx: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in imx. v3: * move dcss changes into separate patch (Laurentiu) Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/imx-d

[PATCH v3 10/27] drm/kirin: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in kirin. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH v3 12/27] drm/imx/dcss: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in dcss. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Laurentiu Palcu Acked-by: Daniel Vetter --- drivers/gpu/drm/imx/dcss/dcss-kms.c | 3 --- 1 file changed, 3

[PATCH v3 16/27] drm/rcar-du: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in rcar-du. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gp

[PATCH v3 14/27] drm/nouveau: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in nouveau. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_drm.c | 3 --- 1 file changed, 3 deletions(-) diff --

[PATCH v3 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in mediatek. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 -- 1 file changed, 6 deletions(-) di

[PATCH v3 15/27] drm/omapdrm: Track IRQ state in local device state

2021-06-24 Thread Thomas Zimmermann
Replace usage of struct drm_device.irq_enabled with the driver's own state field struct omap_drm_device.irq_enabled. The field in the DRM device structure is considered legacy and should not be used by KMS drivers. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel V

[PATCH v3 17/27] drm/rockchip: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in rockchip. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 -- 1 file changed, 6 deletions(-

[PATCH v3 21/27] drm/tegra: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in tegra. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/tegra/drm.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/dr

[PATCH v3 19/27] drm/stm: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in stm. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/stm/ltdc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/g

[PATCH v3 18/27] drm/sti: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in sti. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/sti/sti_compositor.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/

[PATCH v3 23/27] drm/vc4: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vc4. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/vc4/vc4_kms.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/g

[PATCH v3 22/27] drm/tidss: Don't use struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't use it in tidss. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/tidss/tidss_irq.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/

[PATCH v3 20/27] drm/sun4i: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in sun4i. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/sun4i/sun4i_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/d

[PATCH v3 25/27] drm/vmwgfx: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vmxgfx. All usage of the field within vmwgfx can safely be removed. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/vmwgfx/vmwg

[PATCH v3 24/27] drm/vkms: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vkms. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vkms/vkms_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_

[PATCH v3 26/27] drm/xlnx: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in xlnx. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/

[PATCH v3 27/27] drm/zte: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thomas Zimmermann
The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in zte. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Daniel Vetter --- drivers/gpu/drm/zte/zx_drm_drv.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/

Re: [PATCH 3/6] KVM: x86/mmu: avoid struct page in MMU

2021-06-24 Thread Paolo Bonzini
On 24/06/21 05:57, David Stevens wrote: static int __direct_map(struct kvm_vcpu *vcpu, gpa_t gpa, u32 error_code, - int map_writable, int max_level, kvm_pfn_t pfn, + int map_writable, int max_level, + const struct kvm_pfn_page *p

Re: [PATCH 10/15] drm/vram-helpers: Create DRM_GEM_VRAM_PLANE_HELPER_FUNCS

2021-06-24 Thread Thomas Zimmermann
Am 22.06.21 um 18:55 schrieb Daniel Vetter: Like we have for the shadow helpers too, and roll it out to drivers. Acked-by: Tian Tao Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Hans de Goede Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: David Airlie Cc: Daniel V

Re: [PATCH 10/15] drm/vram-helpers: Create DRM_GEM_VRAM_PLANE_HELPER_FUNCS

2021-06-24 Thread Thomas Zimmermann
Hi Am 22.06.21 um 18:55 schrieb Daniel Vetter: Like we have for the shadow helpers too, and roll it out to drivers. In addition to the plane-helper macro, you may also want to add DRM_GEM_VRAM_SIMPLE_DISPLAY_PIPE_FUNCS and use it in bochs. Best regards Thomas Acked-by: Tian Tao Signed-o

Re: [PATCH v2 01/12] drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv

2021-06-24 Thread Boris Brezillon
On Mon, 21 Jun 2021 15:38:56 +0200 Boris Brezillon wrote: > Jobs can be in-flight when the file descriptor is closed (either because > the process did not terminate properly, or because it didn't wait for > all GPU jobs to be finished), and apparently panfrost_job_close() does > not cancel alread

Re: [PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-24 Thread Jani Nikula
On Thu, 24 Jun 2021, Thomas Zimmermann wrote: > For KMS drivers, replace the IRQ check in VBLANK ioctls with a check for > vblank support. IRQs might be enabled wthout vblanking being supported. > > This change also removes the DRM framework's only dependency on IRQ state > for non-legacy drivers.

Re: [Linaro-mm-sig] [PATCH v3 1/2] habanalabs: define uAPI to export FD for DMA-BUF

2021-06-24 Thread Christian König
Am 24.06.21 um 07:34 schrieb Christoph Hellwig: On Wed, Jun 23, 2021 at 10:00:29PM +0300, Oded Gabbay wrote: I understand the argument and I agree that for the generic case, the top of the stack can't assume anything. Having said that, in this case the SGL is encapsulated inside a dma-buf object

Re: [PATCH v3 06/27] drm/i915: Track IRQ state in local device state

2021-06-24 Thread Jani Nikula
On Thu, 24 Jun 2021, Thomas Zimmermann wrote: > Replace usage of struct drm_device.irq_enabled with the driver's > own state field struct drm_i915_private.irq_enabled. The field in > the DRM device structure is considered legacy and should not be > used by KMS drivers. > > Signed-off-by: Thomas Zi

[Bug 212469] plymouth animation freezes during shutdown

2021-06-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212469 popov895 (popov...@ukr.net) changed: What|Removed |Added CC||popov...@ukr.net --- Commen

[PULL] drm-intel-fixes

2021-06-24 Thread Jani Nikula
Hi Dave & Daniel - One more fix for v5.13, stable material. Fix a memset zeroing memory beyond the intended struct member. drm-intel-fixes-2021-06-24: drm/i915 fixes for v5.13: - Fix memset size for infoframe.vsc to avoid clobbering data BR, Jani. The following changes since commit 13311e742

Re: [PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-24 Thread Thomas Zimmermann
Hi Am 24.06.21 um 10:06 schrieb Jani Nikula: On Thu, 24 Jun 2021, Thomas Zimmermann wrote: For KMS drivers, replace the IRQ check in VBLANK ioctls with a check for vblank support. IRQs might be enabled wthout vblanking being supported. This change also removes the DRM framework's only depende

Re: [PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-24 Thread Thomas Zimmermann
Hi Am 24.06.21 um 10:06 schrieb Jani Nikula: On Thu, 24 Jun 2021, Thomas Zimmermann wrote: For KMS drivers, replace the IRQ check in VBLANK ioctls with a check for vblank support. IRQs might be enabled wthout vblanking being supported. This change also removes the DRM framework's only depende

Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver

2021-06-24 Thread Krzysztof Kozlowski
On 24/06/2021 04:48, Fabio Estevam wrote: > Hi Jagan/Laurent, > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart > wrote: > >> Looking at the register set, it seems to match the Exynos 5433, >> supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage >> that driver instead of addi

Re: [PATCH 08/15] drm/: drm_gem_plane_helper_prepare_fb is now the default

2021-06-24 Thread Philipp Zabel
On Tue, 2021-06-22 at 18:55 +0200, Daniel Vetter wrote: > No need to set it explicitly. > [...] > drivers/gpu/drm/imx/ipuv3-plane.c | 1 - > 14 files changed, 15 deletions(-) > [...] > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c > b/drivers/gpu/drm/imx/ipuv3-plane.c > index 8710f55

Re: [PATCH v3 11/27] drm/imx: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Philipp Zabel
On Thu, 2021-06-24 at 09:29 +0200, Thomas Zimmermann wrote: > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in imx. > > v3: > * move dcss changes into separate patch (Laurentiu) > > Signed-off-by: Thomas Zimmermann > Reviewed-by:

[PATCH v10 0/3] drm/i915: Move system memory to TTM for discrete

2021-06-24 Thread Thomas Hellström
Early implementation of moving system memory for discrete cards over to TTM. We first add the notion of objects being migratable under the object lock to i915 gem, and add some asserts to verify that objects are either locked or pinned when the placement is checked by the gem code. Patch 2 deals w

[PATCH v10 2/3] drm/i915/ttm: Adjust gem flags and caching settings after a move

2021-06-24 Thread Thomas Hellström
After a TTM move or object init we need to update the i915 gem flags and caching settings to reflect the new placement. Currently caching settings are not changed during the lifetime of an object, although that might change moving forward if we run into performance issues or issues with WC system p

[PATCH v10 3/3] drm/i915/ttm: Use TTM for system memory

2021-06-24 Thread Thomas Hellström
For discrete, use TTM for both cached and WC system memory. That means we currently rely on the TTM memory accounting / shrinker. For cached system memory we should consider remaining shmem-backed, which can be implemented from our ttm_tt_populate callback. We can then also reuse our own very elabo

[PATCH v10 1/3] drm/i915: Update object placement flags to be mutable

2021-06-24 Thread Thomas Hellström
The object ops i915_GEM_OBJECT_HAS_IOMEM and the object I915_BO_ALLOC_STRUCT_PAGE flags are considered immutable by much of our code. Introduce a new mem_flags member to hold these and make sure checks for these flags being set are either done under the object lock or with pages properly pinned. Th

Re: [RFC PATCH 4/9] phy: samsung: Add SEC DSIM DPHY driver

2021-06-24 Thread Krzysztof Kozlowski
On 21/06/2021 09:24, Jagan Teki wrote: > Samsung SEC MIPI DSIM DPHY controller is part of registers > available in SEC MIPI DSIM bridge for NXP's i.MX8M Mini and > Nano Processors. > > Add phy driver for it. > > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Signed-off-by: Jagan Teki > --- > d

Re: [Intel-gfx] [PATCH] drm/i915: add back the avail tracking

2021-06-24 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 08:35:30PM +0100, Matthew Auld wrote: > On Wed, 23 Jun 2021 at 20:15, Daniel Vetter wrote: > > > > On Wed, Jun 23, 2021 at 06:27:06PM +0100, Matthew Auld wrote: > > > Looks like it got lost along the way, so add it back. This is needed for > > > the region query uAPI where

Re: [PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-24 Thread Jani Nikula
On Thu, 24 Jun 2021, Thomas Zimmermann wrote: > Hi > > Am 24.06.21 um 10:06 schrieb Jani Nikula: >> On Thu, 24 Jun 2021, Thomas Zimmermann wrote: >>> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c >>> index 3417e1ac7918..10fe16bafcb6 100644 >>> --- a/drivers/gpu/drm/drm_

[PATCH] drm/etnaviv: Implement mmap as GEM object function

2021-06-24 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective etnaviv functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zim

[PATCH] drm/exynox: Implement mmap as GEM object function

2021-06-24 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective exynos functions are being removed. The file_operations structure exynos_drm_driver_fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-o

[PATCH] drm/mediatek: Implement mmap as GEM object function

2021-06-24 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective mediatek functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zi

[PATCH] drm/msm: Implement mmap as GEM object function

2021-06-24 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective msm functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zimmerm

[PATCH] drm/qxl: Remove empty qxl_gem_prime_mmap()

2021-06-24 Thread Thomas Zimmermann
The function qxl_gem_prime_mmap() returns an error. The two callers of gem_prime_mmap are drm_fbdev_fb_mmap() and drm_gem_dmabuf_mmap(), which both already handle NULL-callbacks with an error code. So clear gem_prime_mmap in qxl and remove qxl_gem_prime_mmap(). Signed-off-by: Thomas Zimmermann --

Re: [PATCH v2 1/2] drm/panfrost: Use a threaded IRQ for job interrupts

2021-06-24 Thread Steven Price
On 21/06/2021 17:09, Steven Price wrote: > On 21/06/2021 15:02, Boris Brezillon wrote: >> This should avoid uneccessary interrupt-context switches when the GPU >> is passed a lot of short jobs. > > LGTM: > > Reviewed-by: Steven Price Well actually... see below. >> >> v2: >> * New patch >> >> S

Re: [PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-24 Thread Thomas Zimmermann
Hi Am 24.06.21 um 10:51 schrieb Jani Nikula: On Thu, 24 Jun 2021, Thomas Zimmermann wrote: Hi Am 24.06.21 um 10:06 schrieb Jani Nikula: On Thu, 24 Jun 2021, Thomas Zimmermann wrote: diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index 3417e1ac7918..10fe16bafcb6 10

Re: [PATCH] drm/etnaviv: Implement mmap as GEM object function

2021-06-24 Thread Lucas Stach
Am Donnerstag, dem 24.06.2021 um 10:58 +0200 schrieb Thomas Zimmermann: > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > The respective etnaviv functions are being removed. The file_operations > structure fops is now b

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-24 Thread Steven Price
Hi Boris, I tested it out and I see a performance improvement with Mesa which is nice! However a few concerns noted below. On 21/06/2021 15:02, Boris Brezillon wrote: > From: Steven Price > > The hardware has a set of '_NEXT' registers that can hold a second job > while the first is executing.

[PATCH] drm/amdgpu: Avoid printing of stack contents on firmware load error

2021-06-24 Thread Jiri Kosina
From: Jiri Kosina In case when psp_init_asd_microcode() fails to load ASD microcode file, psp_v12_0_init_microcode() tries to print the firmware filename that failed to load before bailing out. This is wrong because: - the firmware filename it would want it print is an incorrect one as psp_

Re: [PATCH] drm/qxl: Remove empty qxl_gem_prime_mmap()

2021-06-24 Thread Gerd Hoffmann
On Thu, Jun 24, 2021 at 11:05:00AM +0200, Thomas Zimmermann wrote: > The function qxl_gem_prime_mmap() returns an error. The two callers > of gem_prime_mmap are drm_fbdev_fb_mmap() and drm_gem_dmabuf_mmap(), > which both already handle NULL-callbacks with an error code. So clear > gem_prime_mmap in

Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn

2021-06-24 Thread Marc Zyngier
Hi David, On Thu, 24 Jun 2021 04:57:45 +0100, David Stevens wrote: > > From: David Stevens > > Return a struct kvm_pfn_page containing both a pfn and an optional > struct page from the gfn_to_pfn family of functions. This differentiates > the gup and follow_fault_pfn cases, which allows caller

Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn

2021-06-24 Thread Paolo Bonzini
On 24/06/21 10:52, Nicholas Piggin wrote: For now, wrap all calls to gfn_to_pfn functions in the new helper function. Callers which don't need the page struct will be updated in follow-up patches. Hmm. You mean callers that do need the page will be updated? Normally if there will be leftover use

Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns

2021-06-24 Thread Paolo Bonzini
On 24/06/21 10:43, Nicholas Piggin wrote: Excerpts from David Stevens's message of June 24, 2021 1:57 pm: From: David Stevens Changelog? This looks like a bug, should it have a Fixes: tag? Probably has been there forever... The best way to fix the bug would be to nuke mmu_audit.c, which I'

[PATCH] drm/vgem: Implement mmap as GEM object function

2021-06-24 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective vgem functions are being removed. The file_operations structure vgem_driver_fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: T

Re: [Linaro-mm-sig] [PATCH v3 1/2] habanalabs: define uAPI to export FD for DMA-BUF

2021-06-24 Thread Christian König
Am 24.06.21 um 10:12 schrieb Christoph Hellwig: On Thu, Jun 24, 2021 at 10:07:14AM +0200, Christian König wrote: The key point is that accessing the underlying pages even when DMA-bufs are backed by system memory is illegal. Daniel even created a patch which mangles the page pointers in sg_table

[PATCH] drm/xen: Implement mmap as GEM object function

2021-06-24 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective xen functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zimmerm

[PATCH] drm/rockchip: Implement mmap as GEM object function

2021-06-24 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective rockchip functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zi

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-24 Thread Boris Brezillon
On Thu, 24 Jun 2021 10:23:51 +0100 Steven Price wrote: > > static void panfrost_job_handle_irq(struct panfrost_device *pfdev, u32 > > status) > > { > > - int j; > > + struct panfrost_job *done[NUM_JOB_SLOTS][2] = {}; > > + struct panfrost_job *failed[NUM_JOB_SLOTS] = {}; > > + u32 js_s

Re: [PATCH] drm/vgem: Implement mmap as GEM object function

2021-06-24 Thread Christian König
Am 24.06.21 um 11:52 schrieb Thomas Zimmermann: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective vgem functions are being removed. The file_operations structure vgem_driver_fops is now being created by the hel

Re: [PATCH 3/6] KVM: x86/mmu: avoid struct page in MMU

2021-06-24 Thread Marc Zyngier
On Thu, 24 Jun 2021 09:58:00 +0100, Nicholas Piggin wrote: > > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: > > From: David Stevens > > out_unlock: > > if (is_tdp_mmu_root(vcpu->kvm, vcpu->arch.mmu->root_hpa)) > > read_unlock(&vcpu->kvm->mmu_lock); > > els

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-24 Thread Steven Price
On 24/06/2021 10:56, Boris Brezillon wrote: > On Thu, 24 Jun 2021 10:23:51 +0100 > Steven Price wrote: > >>> static void panfrost_job_handle_irq(struct panfrost_device *pfdev, u32 >>> status) >>> { >>> - int j; >>> + struct panfrost_job *done[NUM_JOB_SLOTS][2] = {}; >>> + struct panfrost

Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn

2021-06-24 Thread Paolo Bonzini
On 24/06/21 11:57, Nicholas Piggin wrote: Needing kvm_pfn_page_unwrap is a sign that something might be buggy, so it's a good idea to move the short name to the common case and the ugly kvm_pfn_page_unwrap(gfn_to_pfn(...)) for the weird one. In fact I'm not sure there should be any kvm_pfn_page_

Re: [PATCH 3/6] KVM: x86/mmu: avoid struct page in MMU

2021-06-24 Thread Paolo Bonzini
On 24/06/21 12:06, Marc Zyngier wrote: On Thu, 24 Jun 2021 09:58:00 +0100, Nicholas Piggin wrote: Excerpts from David Stevens's message of June 24, 2021 1:57 pm: From: David Stevens out_unlock: if (is_tdp_mmu_root(vcpu->kvm, vcpu->arch.mmu->root_hpa)) read_unlock(&v

Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn

2021-06-24 Thread Paolo Bonzini
On 24/06/21 12:17, Nicholas Piggin wrote: If all callers were updated that is one thing, but from the changelog it sounds like that would not happen and there would be some gfn_to_pfn users left over. But yes in the end you would either need to make gfn_to_pfn never return a page found via follo

Re: [PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-24 Thread Liviu Dudau
On Thu, Jun 24, 2021 at 11:07:57AM +0200, Thomas Zimmermann wrote: > Hi > > Am 24.06.21 um 10:51 schrieb Jani Nikula: > > On Thu, 24 Jun 2021, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 24.06.21 um 10:06 schrieb Jani Nikula: > > > > On Thu, 24 Jun 2021, Thomas Zimmermann wrote: > > > > >

Re: [PATCH 4/6] KVM: arm64/mmu: avoid struct page in MMU

2021-06-24 Thread Marc Zyngier
On Thu, 24 Jun 2021 04:57:47 +0100, David Stevens wrote: > > From: David Stevens > > Avoid converting pfns returned by follow_fault_pfn to struct pages to > transiently take a reference. The reference was originally taken to > match the reference taken by gup. However, pfns returned by > follow

Re: [PATCH] drm/etnaviv: Implement mmap as GEM object function

2021-06-24 Thread Thomas Zimmermann
Hi Am 24.06.21 um 11:11 schrieb Lucas Stach: Am Donnerstag, dem 24.06.2021 um 10:58 +0200 schrieb Thomas Zimmermann: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective etnaviv functions are being removed. The

Re: [PATCH v3 16/27] drm/rcar-du: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Thu, Jun 24, 2021 at 09:29:05AM +0200, Thomas Zimmermann wrote: > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in rcar-du. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart >

Re: [PATCH v3 24/27] drm/vkms: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Thu, Jun 24, 2021 at 09:29:13AM +0200, Thomas Zimmermann wrote: > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in vkms. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart > --

Re: [PATCH] drm/etnaviv: Implement mmap as GEM object function

2021-06-24 Thread Lucas Stach
Am Donnerstag, dem 24.06.2021 um 12:47 +0200 schrieb Thomas Zimmermann: > Hi > > Am 24.06.21 um 11:11 schrieb Lucas Stach: > > Am Donnerstag, dem 24.06.2021 um 10:58 +0200 schrieb Thomas Zimmermann: > > > Moving the driver-specific mmap code into a GEM object function allows > > > for using DRM he

[PATCH] drm/i915: Reinstate the mmap ioctl for some platforms

2021-06-24 Thread Thomas Hellström
Reinstate the mmap ioctl for all current integrated platforms. The intention was really to have it disabled for discrete graphics where we enforce a single mmap mode. Fixes: 35cbd91eb541 ("drm/i915: Disable mmap ioctl for gen12+") Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915

[PATCH v6 RESEND 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-06-24 Thread Hsin-Yi Wang
drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel orientation

[PATCH v6 RESEND 2/3] drm/mediatek: init panel orientation property

2021-06-24 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/mediate

[PATCH v6 RESEND 3/3] arm64: dts: mt8183: Add panel rotation

2021-06-24 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi inde

Re: [Mesa-dev] [PATCH] dma-buf: Document dma-buf implicit fencing/resv fencing rules

2021-06-24 Thread Daniel Stone
Hi, On Wed, 23 Jun 2021 at 17:20, Daniel Vetter wrote: > +* > +* IMPLICIT SYNCHRONIZATION RULES: > +* > +* Drivers which support implicit synchronization of buffer access as > +* e.g. exposed in `Implicit Fence Poll Support`_ should follow the > +*

Re: [PATCH v2 1/2] drm/i915: support forcing the page size with lmem

2021-06-24 Thread Thomas Hellström
On 6/23/21 4:16 PM, Matthew Auld wrote: For some specialised objects we might need something larger than the regions min_page_size due to some hw restriction, and slightly more hairy is needing something smaller with the guarantee that such objects will never be inserted into any GTT, which is

[PATCH v2] drm/amdgpu: Avoid printing of stack contents on firmware load error

2021-06-24 Thread Jiri Kosina
From: Jiri Kosina In case when psp_init_asd_microcode() fails to load ASD microcode file, psp_v12_0_init_microcode() tries to print the firmware filename that failed to load before bailing out. This is wrong because: - the firmware filename it would want it print is an incorrect one as psp_

Re: [PATCH] drm/i915: Reinstate the mmap ioctl for some platforms

2021-06-24 Thread Matthew Auld
On Thu, 24 Jun 2021 at 11:53, Thomas Hellström wrote: > > Reinstate the mmap ioctl for all current integrated platforms. > The intention was really to have it disabled for discrete graphics > where we enforce a single mmap mode. > > Fixes: 35cbd91eb541 ("drm/i915: Disable mmap ioctl for gen12+") >

Re: [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-24 Thread Robin Murphy
On 2021-06-24 07:05, Claire Chang wrote: On Thu, Jun 24, 2021 at 1:43 PM Christoph Hellwig wrote: On Wed, Jun 23, 2021 at 02:44:34PM -0400, Qian Cai wrote: is_swiotlb_force_bounce at /usr/src/linux-next/./include/linux/swiotlb.h:119 is_swiotlb_force_bounce() was the new function introduced i

Re: [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-24 Thread Will Deacon
On Thu, Jun 24, 2021 at 12:14:39PM +0100, Robin Murphy wrote: > On 2021-06-24 07:05, Claire Chang wrote: > > On Thu, Jun 24, 2021 at 1:43 PM Christoph Hellwig wrote: > > > > > > On Wed, Jun 23, 2021 at 02:44:34PM -0400, Qian Cai wrote: > > > > is_swiotlb_force_bounce at > > > > /usr/src/linux-ne

[Bug 213561] [bisected][regression] AMD GPU can no longer enter idle state after commit

2021-06-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213561 hagar-du...@wanadoo.fr changed: What|Removed |Added CC||hagar-du...@wanadoo.fr --- Comme

[PATCH] drm/amdgpu: Fix resource leak on probe error path

2021-06-24 Thread Jiri Kosina
From: Jiri Kosina This reverts commit 4192f7b5768912ceda82be2f83c87ea7181f9980. It is not true (as stated in the reverted commit changelog) that we never unmap the BAR on failure; it actually does happen properly on amdgpu_driver_load_kms() -> amdgpu_driver_unload_kms() -> amdgpu_device_fini(

Re: [Mesa-dev] [PATCH] dma-buf: Document dma-buf implicit fencing/resv fencing rules

2021-06-24 Thread Daniel Vetter
On Thu, Jun 24, 2021 at 1:08 PM Daniel Stone wrote: > > Hi, > > On Wed, 23 Jun 2021 at 17:20, Daniel Vetter wrote: > > +* > > +* IMPLICIT SYNCHRONIZATION RULES: > > +* > > +* Drivers which support implicit synchronization of buffer access > > as > > +* e.g

[PATCH v2] drm/i915: Reinstate the mmap ioctl for some platforms

2021-06-24 Thread Thomas Hellström
Reinstate the mmap ioctl for all current integrated platforms. The intention was really to have it disabled for discrete graphics where we enforce a single mmap mode. Fixes: 35cbd91eb541 ("drm/i915: Disable mmap ioctl for gen12+") Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v2:

Re: [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-24 Thread Robin Murphy
On 2021-06-24 12:18, Will Deacon wrote: On Thu, Jun 24, 2021 at 12:14:39PM +0100, Robin Murphy wrote: On 2021-06-24 07:05, Claire Chang wrote: On Thu, Jun 24, 2021 at 1:43 PM Christoph Hellwig wrote: On Wed, Jun 23, 2021 at 02:44:34PM -0400, Qian Cai wrote: is_swiotlb_force_bounce at /usr/s

[Bug 213561] [bisected][regression] AMD GPU can no longer enter idle state after commit

2021-06-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213561 --- Comment #4 from Linux_Chemist (untaintablean...@hotmail.co.uk) --- Yes, it seems this commit was also pushed into 5.12.13 so users with similar hardware (gfx10) may also be experiencing this. -- You may reply to this email to add a comment.

Re: [PATCH v14 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-24 Thread Will Deacon
On Thu, Jun 24, 2021 at 12:34:09PM +0100, Robin Murphy wrote: > On 2021-06-24 12:18, Will Deacon wrote: > > On Thu, Jun 24, 2021 at 12:14:39PM +0100, Robin Murphy wrote: > > > On 2021-06-24 07:05, Claire Chang wrote: > > > > On Thu, Jun 24, 2021 at 1:43 PM Christoph Hellwig wrote: > > > > > > > >

Re: [PATCH v2 0/6] drm/bridge: ti-sn65dsi86: Misc improvements

2021-06-24 Thread Robert Foss
Applied to drm-misc-next https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0715786771f24190b3f2dcdcaf2af263c1ef46eb On Thu, 24 Jun 2021 at 02:03, Laurent Pinchart wrote: > > Hello, > > This patch series contains miscellaneous improvements to the > ti-sn65dsi86 driver, and prepares it for opti

  1   2   3   4   >