Re: [PATCH] drm: qxl: ensure surf.data is ininitialized

2021-06-09 Thread Gerd Hoffmann
On Tue, Jun 08, 2021 at 05:13:13PM +0100, Colin King wrote: > From: Colin Ian King > > The object surf is not fully initialized and the uninitialized > field surf.data is being copied by the call to qxl_bo_create > via the call to qxl_gem_object_create. Set surf.data to zero > to ensure garbage d

[PATCH -next v2] drm/nouveau/gr: use list_move instead of list_del/list_add in nv40.c

2021-06-09 Thread Baokun Li
Using list_move() instead of list_del() + list_add() in nv40.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/nouveau/nvkm/engine/gr/nv40.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engin

Re: [PATCH] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-09 Thread Thomas Zimmermann
Hi Am 08.06.21 um 14:39 schrieb Daniel Vetter: On Tue, Jun 8, 2021 at 1:07 PM Thomas Zimmermann wrote: Hi Am 08.06.21 um 11:23 schrieb Daniel Vetter: On Tue, Jun 8, 2021 at 11:18 AM Daniel Vetter wrote: On Tue, Jun 08, 2021 at 11:03:01AM +0200, Thomas Zimmermann wrote: Replace the IRQ c

[PATCH -next v2] drm/nouveau/sw: use list_move instead of list_del/list_add in base.c

2021-06-09 Thread Baokun Li
Using list_move() instead of list_del() + list_add() in base.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/nouveau/nvkm/engine/sw/base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engin

Re: nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device

2021-06-09 Thread Christian König
Am 09.06.21 um 08:57 schrieb Ondrej Zary: [SNIP] Thanks for the heads up. So the problem with my patch is already fixed, isn't it? The NULL pointer dereference in nouveau_bo_wr16 introduced in 141b15e59175aa174ca1f7596188bd15a7ca17ba was fixed by aea656b0d05ec5b8ed5beb2f94c4dd42ea834e9d. That'

[PATCH -next v2] drm/radeon: use list_move instead of list_del/list_add in radeon_vm.c

2021-06-09 Thread Baokun Li
Using list_move() instead of list_del() + list_add() in radeon_vm.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/radeon/radeon_vm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/dr

[PATCH -next v2] drm/vmwgfx: Use list_move_tail instead of list_del/list_add_tail in vmwgfx_cmdbuf.c

2021-06-09 Thread Baokun Li
Using list_move_tail() instead of list_del() + list_add_tail() in vmwgfx_cmdbuf.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgf

Re: nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device

2021-06-09 Thread Ondrej Zary
On Wednesday 09 June 2021, Christian König wrote: > Am 09.06.21 um 08:57 schrieb Ondrej Zary: > > [SNIP] > >> Thanks for the heads up. So the problem with my patch is already fixed, > >> isn't it? > > The NULL pointer dereference in nouveau_bo_wr16 introduced in > > 141b15e59175aa174ca1f7596188bd15

[PATCH -next v2] drm/vmwgfx: Use list_move_tail instead of list_del/list_add_tail in vmwgfx_cmdbuf_res.c

2021-06-09 Thread Baokun Li
Using list_move_tail() instead of list_del() + list_add_tail() in vmwgfx_cmdbuf_res.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/d

[PATCH -next v2] drm/msm: Use list_move_tail instead of list_del/list_add_tail in msm_gem.c

2021-06-09 Thread Baokun Li
Using list_move_tail() instead of list_del() + list_add_tail() in msm_gem.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/msm/msm_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drive

[PATCH -next] drm/hyperv: Remove unused variable

2021-06-09 Thread Pu Lehui
Fixes gcc '-Wunused-const-variable' warning: drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning: 'hyperv_modifiers' defined but not used [-Wunused-const-variable=] Signed-off-by: Pu Lehui --- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 - 1 file changed, 5 deletions(-) di

[PATCH 1/1] drm/panfrost: remove spamming to syslog

2021-06-09 Thread Eero Lehtinen
This patch removes Panfrost spamming messages to syslog that causes a poor performance and crashes of the Xfce desktop with a Amlogic S912 TV box. See the old bug in: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3143 Signed-off-by: Eero Lehtinen --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c

Re: [PATCH v5, 4/4] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-06-09 Thread Chun-Jie Chen
On Mon, 2021-04-12 at 22:04 +0800, Yongqiang Niu wrote: > mt8192 has different routing registers than mt8183 > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mt8192-mmsys.h | 68 > + > drivers/soc/mediatek/mtk-mmsys.c| 7 > 2 files chang

Re: [Intel-gfx] [PATCH 25/31] drm/i915/gem: Don't allow changing the VM on running contexts (v2)

2021-06-09 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926 base: git://anongit.freedesktop.org/d

[PULL] drm-misc-next

2021-06-09 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the PR for drm-misc-next for this week. The big highlight is the new DRM driver for HyperV graphics output. And TTM saw some refactoring to its internals. Best regards Thomas drm-misc-next-2021-06-09: drm-misc-next for 5.14: UAPI Changes: * drm/panfrost: Export AFBC

Re: [PATCH v5, 4/4] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-06-09 Thread Matthias Brugger
On 09/06/2021 00:59, Chun-Jie Chen wrote: > On Mon, 2021-04-12 at 22:04 +0800, Yongqiang Niu wrote: >> mt8192 has different routing registers than mt8183 >> >> Signed-off-by: Yongqiang Niu >> --- >> drivers/soc/mediatek/mt8192-mmsys.h | 68 >> + >> drivers/s

Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4

2021-06-09 Thread Matthias Brugger
On 12/04/2021 16:04, Yongqiang Niu wrote: > This patch add component RDMA4 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/soc/mediatek/mtk-mmsys.h > b/includ

Re: [PATCH v2 4/9] drm/i915/gt: Add an insert_entry for gen8_ppgtt

2021-06-09 Thread Matthew Auld
On 09/06/2021 07:34, Thomas Hellström wrote: From: Chris Wilson In the next patch, we will want to write a PTE for an explicit dma address, outside of the usual vma. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld

Re: [PATCH -next] drm/hyperv: Remove unused variable

2021-06-09 Thread Thomas Zimmermann
Hi Am 09.06.21 um 04:49 schrieb Pu Lehui: Fixes gcc '-Wunused-const-variable' warning: drivers/gpu/drm/hyperv/hyperv_drm_modeset.c:152:23: warning: 'hyperv_modifiers' defined but not used [-Wunused-const-variable=] Signed-off-by: Pu Lehui --- drivers/gpu/drm/hyperv/hyperv_drm_modeset

Re: [PATCH v2 5/9] drm/i915/gt: Add a routine to iterate over the pagetables of a GTT

2021-06-09 Thread Matthew Auld
On 09/06/2021 07:34, Thomas Hellström wrote: From: Chris Wilson In the next patch, we will want to look at the dma addresses of individual page tables, so add a routine to iterate over them. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld

Re: [PATCH v2 6/9] drm/i915/gt: Export the pinned context constructor and destructor

2021-06-09 Thread Matthew Auld
On 09/06/2021 07:34, Thomas Hellström wrote: From: Chris Wilson Allow internal clients to create and destroy a pinned context. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 24/31] drm/i915/gem: Delay context creation (v2)

2021-06-09 Thread kernel test robot
the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926 b

Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix sparse warnings

2021-06-09 Thread Robert Foss
Hey Marek, Thanks for submitting this. On Tue, 8 Jun 2021 at 16:22, Marek Vasut wrote: > > Fix the following sparse warnings generated by "make C=1": > > drivers/gpu/drm/bridge/ti-sn65dsi83.c:429:13: warning: incorrect type in > assignment (different base types) > drivers/gpu/drm/bridge/ti-sn65

[Bug 213373] [drm] [radeon] memory leak at parsing radeon_atombios_parse_power_table

2021-06-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213373 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #297247|0 |1 is obsolete|

Re: [PATCH 1/1] drm/vmwgfx: use ttm_bo_move_null() when there is nothing to move

2021-06-09 Thread Das, Nirmoy
On 6/9/2021 8:38 AM, Christian König wrote: Am 08.06.21 um 20:13 schrieb Nirmoy Das: Use ttm_bo_move_null() instead of ttm_bo_assign_mem(). Signed-off-by: Nirmoy Das Reviewed-by: Christian König Looks like I've forgot to push that one. *sigh* I'm getting old. Nah, you have too many stu

Re: [PATCH] drm/i915: apply WaEnableVGAAccessThroughIOPort as needed

2021-06-09 Thread Emil Velikov
On Fri, 4 Jun 2021 at 16:49, Emil Velikov wrote: > > From: Emil Velikov > > Currently as the workaround is applied the screen flickers. As a result > we do not achieve seamless boot experience. > > Avoiding the issue in the common use-case might be hard, although we can > resolve it for dual GPU

Re: nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device

2021-06-09 Thread Christian König
Am 09.06.21 um 09:10 schrieb Ondrej Zary: On Wednesday 09 June 2021, Christian König wrote: Am 09.06.21 um 08:57 schrieb Ondrej Zary: [SNIP] Thanks for the heads up. So the problem with my patch is already fixed, isn't it? The NULL pointer dereference in nouveau_bo_wr16 introduced in 141b15e5

[PATCH] drm: Lock pointer access in drm_master_release()

2021-06-09 Thread Desmond Cheong Zhi Xi
This patch eliminates the following smatch warning: drivers/gpu/drm/drm_auth.c:320 drm_master_release() warn: unlocked access 'master' (line 318) expected lock '&dev->master_mutex' The 'file_priv->master' field should be protected by the mutex lock to '&dev->master_mutex'. This is because other p

Re: [PATCH] ARM: config: Refresh mutli v7

2021-06-09 Thread Arnd Bergmann
On Tue, Jun 8, 2021 at 6:49 PM Hans Verkuil wrote: > On 08/06/2021 18:14, Arnd Bergmann wrote: > > Right now it is inherent to the driver. It is probably possible to drop > support > for video overlay devices if CONFIG_FB=n, but it is not something I have time > for. It's just a test driver (albe

Re: [PATCH v10 07/10] mm: Device exclusive memory access

2021-06-09 Thread Alistair Popple
On Wednesday, 9 June 2021 4:33:52 AM AEST Peter Xu wrote: > On Mon, Jun 07, 2021 at 05:58:52PM +1000, Alistair Popple wrote: > > [...] > > > +static bool page_make_device_exclusive_one(struct page *page, > > + struct vm_area_struct *vma, unsigned long address, void *priv) > > +{ > > +

[PATCH] drm/amd/display: use ARRAY_SIZE for base60_refresh_rates

2021-06-09 Thread Jiapeng Chong
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element. Clean up the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/core/dc_resource.c:448:47-48: WARNING: Use ARRAY_SIZE. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/c

Re: [PATCH] drm/mcde: Fix off by 10^3 in calculation

2021-06-09 Thread Stephan Gerhold
On Tue, Jun 08, 2021 at 11:33:18PM +0200, Linus Walleij wrote: > The calclulation of how many bytes we stuff into the > DSI pipeline for video mode panels is off by three > orders of magnitude because we did not account for the > fact that the DRM mode clock is in kilohertz rather > than hertz. >

[PATCH] drm/amd/display: Fix duplicate included clk_mgr.h

2021-06-09 Thread Jiapeng Chong
Clean up the following includecheck warning: ./drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hwseq.c: clk_mgr.h is included more than once. No functional change. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hwseq.c | 1 - 1 file changed, 1

Re: [Intel-gfx] [PATCH 30/31] drm/i915: Finalize contexts in GEM_CONTEXT_CREATE on version 13+

2021-06-09 Thread kernel test robot
drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926 base: git://anongit.freedesktop.org/drm/d

Re: [PATCH 1/1] drm/panfrost: remove spamming to syslog

2021-06-09 Thread Robin Murphy
On 2021-06-08 18:18, Eero Lehtinen wrote: This patch removes Panfrost spamming messages to syslog that causes a poor performance and crashes of the Xfce desktop with a Amlogic S912 TV box. See the old bug in: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3143 There is certainly an argument

[PATCH 1/4] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-06-09 Thread Simon Ser
This function sends a hotplug uevent with a CONNECTOR property. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_sysfs.c | 25 + include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c i

[PATCH 2/4] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
This function is the same as drm_kms_helper_hotplug_event, but takes a connector instead of a device. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 20 include/drm/drm_probe_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/

[PATCH 3/4] drm/connector: use drm_sysfs_connector_hotplug_event

2021-06-09 Thread Simon Ser
In drm_connector_register, use drm_sysfs_connector_hotplug_event instead of drm_sysfs_hotplug_event, because the hotplug event only updates a single connector. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 4/4] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
When updating a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 ++-- 2 files c

[PATCH 0/4] drm: add per-connector hotplug events

2021-06-09 Thread Simon Ser
When a uevent only updates a single connector, add a CONNECTOR property to the uevent. This allows user-space to ignore other connectors when handling the uevent. This is purely an optimization, drivers can still send a uevent without the CONNECTOR property. The CONNECTOR property is already set w

Re: [PATCH v9 02/11] dt-bindings: drm: Introduce the DP AUX bus

2021-06-09 Thread Linus Walleij
On Mon, Jun 7, 2021 at 7:06 PM Douglas Anderson wrote: > We want to be able to list an eDP panel as a child of an eDP > controller node to represent the fact that the panel is connected to > the controller's DP AUX bus. Though the panel and the controller are > connected in several ways, the DP A

Re: [PATCH v9 03/11] dt-bindings: drm/bridge: ti-sn65dsi86: Add aux-bus child

2021-06-09 Thread Linus Walleij
On Mon, Jun 7, 2021 at 7:06 PM Douglas Anderson wrote: > The patch ("dt-bindings: drm: Introduce the DP AUX bus") talks about > how using the DP AUX bus is better than learning how to slice > bread. Let's add it to the ti-sn65dsi86 bindings. > > Signed-off-by: Douglas Anderson > Reviewed-by: Ro

Re: [PATCH v9 06/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC

2021-06-09 Thread Linus Walleij
On Mon, Jun 7, 2021 at 7:06 PM Douglas Anderson wrote: > If panel-simple is instantiated as a DP AUX bus endpoint then we have > access to the DP AUX bus. Let's stash it in the panel-simple > structure, leaving it NULL for the cases where the panel is > instantiated in other ways. > > If we happe

Re: [PATCH v9 07/11] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev

2021-06-09 Thread Linus Walleij
On Mon, Jun 7, 2021 at 7:06 PM Douglas Anderson wrote: > On its own, this change looks a little strange and doesn't do too much > useful. To understand why we're doing this we need to look forward to > future patches where we're going to probe our panel using the new DP > AUX bus. See the patch (

Re: [PATCH v9 10/11] drm/bridge: ti-sn65dsi86: Improve probe errors with dev_err_probe()

2021-06-09 Thread Linus Walleij
On Mon, Jun 7, 2021 at 7:06 PM Douglas Anderson wrote: > As I was testing to make sure that the DEFER path worked well with my > patch series, I got tired of seeing this scary message in my logs just > because the panel needed to defer: > [drm:ti_sn_bridge_probe] *ERROR* could not find any pane

Re: [PATCH 1/4] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-06-09 Thread Jani Nikula
On Wed, 09 Jun 2021, Simon Ser wrote: > This function sends a hotplug uevent with a CONNECTOR property. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_sysfs.c | 25 + > include/drm/drm_sysfs.h | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/driv

[PATCH 0/9] drm: Implement gem_prime_mmap with drm_gem_prime_mmap()

2021-06-09 Thread Thomas Zimmermann
Replace all remaining implementations of struct drm_driver.gem_prime_mmap with use drm_gem_prime_mmap(). For each affected driver, put the mmap code into struct drm_gem_object_funcs.mmap. With the latter change in place, create struct file_operations via DEFINE_DRM_GEM_FOPS(). As next steps, remai

[PATCH 1/9] drm/etnaviv: Implement mmap as GEM object function

2021-06-09 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective etnaviv functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zim

[PATCH 2/9] drm/exynox: Implement mmap as GEM object function

2021-06-09 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective exynos functions are being removed. The file_operations structure exynos_drm_driver_fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-o

[PATCH 7/9] drm/xen: Implement mmap as GEM object function

2021-06-09 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective xen functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zimmerm

[PATCH 4/9] drm/msm: Implement mmap as GEM object function

2021-06-09 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective msm functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zimmerm

[PATCH 8/9] drm/rockchip: Implement mmap as GEM object function

2021-06-09 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective rockchip functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zi

[PATCH 5/9] drm/qxl: Remove empty qxl_gem_prime_mmap()

2021-06-09 Thread Thomas Zimmermann
The function qxl_gem_prime_mmap() returns an error. The two callers of gem_prime_mmap are drm_fbdev_fb_mmap() and drm_gem_dmabuf_mmap(), which both already handle NULL-callbacks with an error code. So clear gem_prime_mmap in qxl and remove qxl_gem_prime_mmap(). Signed-off-by: Thomas Zimmermann --

[PATCH 3/9] drm/mediatek: Implement mmap as GEM object function

2021-06-09 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective mediatek functions are being removed. The file_operations structure fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: Thomas Zi

[PATCH 6/9] drm/vgem: Implement mmap as GEM object function

2021-06-09 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective vgem functions are being removed. The file_operations structure vgem_driver_fops is now being created by the helper macro DEFINE_DRM_GEM_FOPS(). Signed-off-by: T

[PATCH 9/9] drm: Update documentation and TODO of gem_prime_mmap hook

2021-06-09 Thread Thomas Zimmermann
The hook gem_prime_mmap in struct drm_driver is deprecated. Document the new requirements. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst | 11 --- include/drm/drm_drv.h | 11 +++ 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/Documentation/

Re: [Intel-gfx] [PATCH 16/31] drm/i915/gem: Add an intermediate proto_context struct (v4)

2021-06-09 Thread Daniel Vetter
On Tue, Jun 08, 2021 at 11:35:58PM -0500, Jason Ekstrand wrote: > The current context uAPI allows for two methods of setting context > parameters: SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM. The > former is allowed to be called at any time while the later happens as > part of GEM_CONTEXT_CR

Re: [Intel-gfx] [PATCH 25/31] drm/i915/gem: Don't allow changing the VM on running contexts (v2)

2021-06-09 Thread Daniel Vetter
On Tue, Jun 08, 2021 at 11:36:07PM -0500, Jason Ekstrand wrote: > When the APIs were added to manage VMs more directly from userspace, the > questionable choice was made to allow changing out the VM on a context > at any time. This is horribly racy and there's absolutely no reason why > any usersp

Re: [Intel-gfx] [PATCH 25/31] drm/i915/gem: Don't allow changing the VM on running contexts (v2)

2021-06-09 Thread Daniel Vetter
On Wed, Jun 09, 2021 at 01:34:00PM +0200, Daniel Vetter wrote: > On Tue, Jun 08, 2021 at 11:36:07PM -0500, Jason Ekstrand wrote: > > When the APIs were added to manage VMs more directly from userspace, the > > questionable choice was made to allow changing out the VM on a context > > at any time.

Re: [Intel-gfx] [PATCH 30/31] drm/i915: Finalize contexts in GEM_CONTEXT_CREATE on version 13+

2021-06-09 Thread Daniel Vetter
On Tue, Jun 08, 2021 at 11:36:12PM -0500, Jason Ekstrand wrote: > All the proto-context stuff for context creation exists to allow older > userspace drivers to set VMs and engine sets via SET_CONTEXT_PARAM. > Drivers need to update to use CONTEXT_CREATE_EXT_* for this going > forward. Force the is

Re: [Intel-gfx] [PATCH 24/31] drm/i915/gem: Delay context creation (v2)

2021-06-09 Thread kernel test robot
the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926 b

Re: [Intel-gfx] [PATCH 31/31] drm/i915: Drop some RCU usage around context VMs

2021-06-09 Thread Daniel Vetter
On Tue, Jun 08, 2021 at 11:36:13PM -0500, Jason Ekstrand wrote: > This instance now only happens during context creation so there's no way > we can race with a context close/destroy. We don't need to bother with > the RCU and can access the pointer directly. > > Signed-off-by: Jason Ekstrand Th

Re: [Intel-gfx] [PATCH 24/31] drm/i915/gem: Delay context creation (v2)

2021-06-09 Thread kernel test robot
applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926 b

Re: [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration

2021-06-09 Thread Daniel Vetter
On Wed, Jun 09, 2021 at 08:34:27AM +0200, Thomas Hellström wrote: > A couple of patches from Chris which implement pipelined migration and > clears by atomically writing the PTEs in place before performing the > actual blit. > > Some ww utilities mainly for the accompanying selftests added by Thom

Computation of return value being discarded in get_cpu_power() in drivers/platform/x86/intel_ips.c

2021-06-09 Thread Colin Ian King
Hi, I was reviewing some old unassigned variable warnings from static analysis by Coverity and found an issue introduced with the following commit: commit aa7ffc01d254c91a36bf854d57a14049c6134c72 Author: Jesse Barnes Date: Fri May 14 15:41:14 2010 -0700 x86 platform driver: intelligent po

[PATCH v1 2/4] dt-bindings: vendor-prefixes: Add an entry for SKOV A/S

2021-06-09 Thread Oleksij Rempel
Add "skov" entry for the SKOV A/S: https://www.skov.com/en/ Signed-off-by: Oleksij Rempel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/v

[PATCH v1 3/4] dt-bindings: arm: fsl: add SKOV imx6q and imx6dl based boards

2021-06-09 Thread Oleksij Rempel
Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. Signed-off-by: Oleksij Rempel --- Documentation/devicetree/bindings/arm/fsl.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index e

[PATCH v1 0/4] Mainline imx6 based SKOV boards

2021-06-09 Thread Oleksij Rempel
Mainline imx6 based DTs for SKOV A/S boards Oleksij Rempel (3): dt-bindings: display: simple: add some Logic Technologies and Multi-Inno panels dt-bindings: vendor-prefixes: Add an entry for SKOV A/S dt-bindings: arm: fsl: add SKOV imx6q and imx6dl based boards Sam Ravnborg (1): ARM:

[PATCH v1 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards

2021-06-09 Thread Oleksij Rempel
From: Sam Ravnborg Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. Signed-off-by: Sam Ravnborg Signed-off-by: Søren Andersen Signed-off-by: Juergen Borleis Signed-off-by: Ulrich Ölmann Signed-off-by: Michael Grzeschik Signed-off-by: Marco Felsch Signed-off-by: Lucas Stach Signed-off

[PATCH v1 1/4] dt-bindings: display: simple: add some Logic Technologies and Multi-Inno panels

2021-06-09 Thread Oleksij Rempel
Add Logictechno and Multi-Inno panels: - Logic Technologies LTTD800x480 L2RT 7" 800x480 TFT Resistive Touch Module - Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch Module - Multi-Inno Technology Co.,Ltd MI1010AIT-1CP 10.1" 1280x800 LVDS IPS Cap Touch Mod. Signed-off-by: O

Re: [PATCH v2 7/9] drm/i915/gt: Pipelined page migration

2021-06-09 Thread Matthew Auld
On 09/06/2021 07:34, Thomas Hellström wrote: From: Chris Wilson If we pipeline the PTE updates and then do the copy of those pages within a single unpreemptible command packet, we can submit the copies and leave them to be scheduled without having to synchronously wait under a global lock. In o

Re: [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration

2021-06-09 Thread Thomas Hellström
On 6/9/21 1:48 PM, Daniel Vetter wrote: On Wed, Jun 09, 2021 at 08:34:27AM +0200, Thomas Hellström wrote: A couple of patches from Chris which implement pipelined migration and clears by atomically writing the PTEs in place before performing the actual blit. Some ww utilities mainly for the a

Re: [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration

2021-06-09 Thread Matthew Auld
On 09/06/2021 13:16, Thomas Hellström wrote: On 6/9/21 1:48 PM, Daniel Vetter wrote: On Wed, Jun 09, 2021 at 08:34:27AM +0200, Thomas Hellström wrote: A couple of patches from Chris which implement pipelined migration and clears by atomically writing the PTEs in place before performing the act

Re: [PATCH v2 04/12] ASoC: hdmi-codec: Add iec958 controls

2021-06-09 Thread Mark Brown
On Tue, May 25, 2021 at 03:23:46PM +0200, Maxime Ripard wrote: > The IEC958 status bits can be exposed and modified by the userspace > through dedicated ALSA controls. > > This patch implements those controls for the hdmi-codec driver. It > relies on a default value being setup at probe time that

Re: [PATCH v2 7/9] drm/i915/gt: Pipelined page migration

2021-06-09 Thread Matthew Auld
On 09/06/2021 07:34, Thomas Hellström wrote: From: Chris Wilson If we pipeline the PTE updates and then do the copy of those pages within a single unpreemptible command packet, we can submit the copies and leave them to be scheduled without having to synchronously wait under a global lock. In o

Re: [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration

2021-06-09 Thread Thomas Hellström
On 6/9/21 2:20 PM, Matthew Auld wrote: On 09/06/2021 13:16, Thomas Hellström wrote: On 6/9/21 1:48 PM, Daniel Vetter wrote: On Wed, Jun 09, 2021 at 08:34:27AM +0200, Thomas Hellström wrote: A couple of patches from Chris which implement pipelined migration and clears by atomically writing t

Re: [PATCH] drm/i915: Add relocation exceptions for two other platforms

2021-06-09 Thread Daniel Vetter
On Tue, Jun 01, 2021 at 04:24:42PM +0200, Zbigniew Kempczyński wrote: > We have established previously we stop using relocations starting > from gen12 platforms with Tigerlake as an exception. We keep this > statement but we want to enable relocations conditionally for > Rocketlake and Alderlake un

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

2021-06-09 Thread Daniel Vetter
On Fri, Jun 04, 2021 at 01:27:15PM +0200, Christian König wrote: > Am 04.06.21 um 10:57 schrieb Daniel Vetter: > > On Fri, Jun 04, 2021 at 09:00:31AM +0200, Christian König wrote: > > > Am 02.06.21 um 21:19 schrieb Daniel Vetter: > > > > On Wed, Jun 02, 2021 at 08:52:38PM +0200, Christian König wro

Re: [Intel-gfx] [PATCH 13/20] drm/i915/guc: Relax CTB response timeout

2021-06-09 Thread Daniel Vetter
On Fri, Jun 04, 2021 at 11:35:39AM -0700, Matthew Brost wrote: > On Fri, Jun 04, 2021 at 10:33:07AM +0200, Daniel Vetter wrote: > > On Wed, Jun 02, 2021 at 10:16:23PM -0700, Matthew Brost wrote: > > > From: Michal Wajdeczko > > > > > > In upcoming patch we will allow more CTB requests to be sent

Re: handle exclusive fence similar to shared ones

2021-06-09 Thread Daniel Vetter
On Mon, Jun 07, 2021 at 06:25:42PM +0200, Christian König wrote: > > > Am 07.06.21 um 17:09 schrieb Daniel Vetter: > > On Mon, Jun 07, 2021 at 11:59:11AM +0200, Christian König wrote: > > > Am 07.06.21 um 10:58 schrieb Daniel Vetter: > > > > Hi Christian, > > > > > > > > So unfortunately I got d

Re: [PATCH v2 8/9] drm/i915/gt: Pipelined clear

2021-06-09 Thread Matthew Auld
On 09/06/2021 07:34, Thomas Hellström wrote: From: Chris Wilson Update the PTE and emit a clear within a single unpreemptible packet such that we can schedule and pipeline clears. Signed-off-by: Chris Wilson Co-developed-by: Thomas Hellström Signed-off-by: Thomas Hellström --- drivers/gpu

Trouble with TTM patches w/nouveau in linux-next

2021-06-09 Thread Mikko Perttunen
Hi, I'm observing nouveau not initializing recently on linux-next on my Tegra186 Jetson TX2 board. Specifically it looks like BO allocation is failing when initializing the sync subsystem: [ 21.858149] nouveau 1700.gpu: DRM: failed to initialise sync subsystem, -28 I have been bisect

Re: linux-next: build failure after merge of the drm-misc tree

2021-06-09 Thread Daniel Vetter
On Tue, Jun 08, 2021 at 09:11:57AM +0200, Christian König wrote: > Am 08.06.21 um 09:06 schrieb Felix Kuehling: > > Am 2021-06-08 um 2:55 a.m. schrieb Christian König: > > > Hi Felix, > > > > > > that should already be fixed in drm-tip as part of the merge of the > > > TTM changes. > > No, the pre

Re: [Mesa-dev] Linux Graphics Next: Userspace submission update

2021-06-09 Thread Christian König
Am 09.06.21 um 15:19 schrieb Daniel Vetter: [SNIP] Yeah, we call this the lightweight and the heavyweight tlb flush. The lighweight can be used when you are sure that you don't have any of the PTEs currently in flight in the 3D/DMA engine and you just need to invalidate the TLB. The heavyweigh

Re: [Intel-gfx] [RFC PATCH 36/97] drm/i915/guc: Add non blocking CTB send function

2021-06-09 Thread Michal Wajdeczko
On 08.06.2021 10:39, Tvrtko Ursulin wrote: > > On 07/06/2021 18:31, Matthew Brost wrote: >> On Thu, May 27, 2021 at 04:11:50PM +0100, Tvrtko Ursulin wrote: >>> >>> On 27/05/2021 15:35, Matthew Brost wrote: On Thu, May 27, 2021 at 11:02:24AM +0100, Tvrtko Ursulin wrote: > > On 26/05

[PATCH 1/1] drm/radeon: fix a null-ptr-deref error

2021-06-09 Thread Nirmoy Das
Check for NULL value in ttm resource before passing. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/radeon/radeon_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index bfaaa3c969a3..6e0

Re: handle exclusive fence similar to shared ones

2021-06-09 Thread Christian König
Am 09.06.21 um 15:42 schrieb Daniel Vetter: [SNIP] That won't work. The problem is that you have only one exclusive slot, but multiple submissions which execute out of order and compose the buffer object together. That's why I suggested to use the dma_fence_chain to circumvent this. But if you

Re: [Intel-gfx] [RFC PATCH 36/97] drm/i915/guc: Add non blocking CTB send function

2021-06-09 Thread Michal Wajdeczko
On 07.06.2021 19:31, Matthew Brost wrote: > On Thu, May 27, 2021 at 04:11:50PM +0100, Tvrtko Ursulin wrote: >> >> On 27/05/2021 15:35, Matthew Brost wrote: >>> On Thu, May 27, 2021 at 11:02:24AM +0100, Tvrtko Ursulin wrote: On 26/05/2021 19:10, Matthew Brost wrote: [snip] >>>

Re: [PATCH v2 9/9] drm/i915/gt: Setup a default migration context on the GT

2021-06-09 Thread Matthew Auld
On 09/06/2021 07:34, Thomas Hellström wrote: From: Chris Wilson Set up a default migration context on the GT and use it from the selftests. Add a perf selftest and make sure we exercise LMEM if available. Signed-off-by: Chris Wilson Co-developed-by: Thomas Hellström Signed-off-by: Thomas Hel

Re: Trouble with TTM patches w/nouveau in linux-next

2021-06-09 Thread Christian König
Hi Mikko, strange sounds like Nouveau was somehow also using the GEM workaround for VMWGFX as well. But -12 means -ENOMEM which doesn't fits into the picture. I will try with a G710, but if that doesn't yields anything I need some more input from you. Thanks for the report, Christian. Am

Re: [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration

2021-06-09 Thread Thomas Hellström
On 6/9/21 3:08 PM, Thomas Hellström wrote: On 6/9/21 2:20 PM, Matthew Auld wrote: On 09/06/2021 13:16, Thomas Hellström wrote: On 6/9/21 1:48 PM, Daniel Vetter wrote: On Wed, Jun 09, 2021 at 08:34:27AM +0200, Thomas Hellström wrote: A couple of patches from Chris which implement pipelined

Re: [Nouveau] Trouble with TTM patches w/nouveau in linux-next

2021-06-09 Thread Ilia Mirkin
Christian - potentially relevant is that Tegra doesn't have VRAM at all -- all GTT (or GART or whatever it's called nowadays). No fake/stolen VRAM. Cheers, -ilia On Wed, Jun 9, 2021 at 10:18 AM Christian König wrote: > > Hi Mikko, > > strange sounds like Nouveau was somehow also using the GEM

Re: [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration

2021-06-09 Thread Daniel Vetter
On Wed, Jun 09, 2021 at 04:35:57PM +0200, Thomas Hellström wrote: > > On 6/9/21 3:08 PM, Thomas Hellström wrote: > > > > On 6/9/21 2:20 PM, Matthew Auld wrote: > > > On 09/06/2021 13:16, Thomas Hellström wrote: > > > > > > > > On 6/9/21 1:48 PM, Daniel Vetter wrote: > > > > > On Wed, Jun 09, 202

Re: [Nouveau] Trouble with TTM patches w/nouveau in linux-next

2021-06-09 Thread Christian König
Good point, but I think that is unrelated. My suspicion is rather that nouveau is not initializing the underlying GEM object for internal allocations. So what happens is the same as on VMWGFX that TTM doesn't know anything about the size to of the BO resulting in a kmalloc() with a random val

Re: [PATCH 0/4] drm: add per-connector hotplug events

2021-06-09 Thread Daniel Vetter
On Wed, Jun 09, 2021 at 10:39:03AM +, Simon Ser wrote: > When a uevent only updates a single connector, add a CONNECTOR property > to the uevent. This allows user-space to ignore other connectors when > handling the uevent. This is purely an optimization, drivers can still > send a uevent witho

Re: [PATCH 0/4] drm: add per-connector hotplug events

2021-06-09 Thread Simon Ser
On Wednesday, June 9th, 2021 at 17:03, Daniel Vetter wrote: > On Wed, Jun 09, 2021 at 10:39:03AM +, Simon Ser wrote: > > When a uevent only updates a single connector, add a CONNECTOR property > > to the uevent. This allows user-space to ignore other connectors when > > handling the uevent. T

Re: [PATCH v2 1/2] documentation: Update #nouveau IRC channel network

2021-06-09 Thread Karol Herbst
On Mon, May 31, 2021 at 5:11 AM Alyssa Rosenzweig wrote: > > Like many free software projects, Nouveau recently moved from Freenode > to OFTC. Update the reference. > > Signed-off-by: Alyssa Rosenzweig > Cc: David Airlie > Cc: Daniel Vetter > Cc: linux-ker...@vger.kernel.org > --- > Documentat

Re: [Nouveau] Trouble with TTM patches w/nouveau in linux-next

2021-06-09 Thread Ilia Mirkin
GEM init happens here: https://cgit.freedesktop.org/drm/drm/tree/drivers/gpu/drm/nouveau/nouveau_gem.c#n221 Note the bo alloc / gem init / bo init dance. I don't think there is a GEM object for internal allocations at all -- we just allocate bo's directly and that's it. Perhaps you meant somethi

Re: [Nouveau] Trouble with TTM patches w/nouveau in linux-next

2021-06-09 Thread Christian König
Yeah, exactly that's the root cause of the problem. GEM objects are the base class for TTM BOs for quite a while now. So we at least need to initialize them or otherwise at least the size of the object is not available. Going to send a fix in a few minutes. Thanks, Christian. Am 09.06.21 um

Re: [PATCH v9 11/11] arm64: dts: qcom: sc7180-trogdor: Move panel under the bridge chip

2021-06-09 Thread Bjorn Andersson
On Mon 07 Jun 12:05 CDT 2021, Douglas Anderson wrote: > Putting the panel under the bridge chip (under the aux-bus node) > allows the panel driver to get access to the DP AUX bus, enabling all > sorts of fabulous new features. > > While we're at this, get rid of a level of hierarchy for the panel

  1   2   3   >