[PATCH] RDMA/umem: fix missing automated rename

2021-06-07 Thread Christian König
This occasions was missed during the recent rename of the function. Signed-off-by: Christian König Reported-by: kernel test robot Reported-by: Stephen Rothwell --- drivers/infiniband/core/umem_dmabuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/

Re: nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device

2021-06-07 Thread Ondrej Zary
On Saturday 05 June 2021 21:43:52 Ondrej Zary wrote: > Hello, > I'm testing 5.13.0-rc4 and nouveau crashes with NULL pointer dereference in > nouveau_bo_sync_for_device. > Found various reports like this but that was back in februaryso that should > be fixed now. So it is the same bug. Broken si

nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device

2021-06-07 Thread Ondrej Zary
Hello, I'm testing 5.13.0-rc4 and nouveau crashes with NULL pointer dereference in nouveau_bo_sync_for_device. Found various reports like this but that was back in februaryso that should be fixed now. [ 21.003216] BUG: kernel NULL pointer dereference, address: [ 21.003235] #PF: supe

Re: [PATCH v2 2/2] drm/panel: Add support for SONY JDI Synaptics panel

2021-06-07 Thread Marijn Suijten
On Sat, 5 Jun 2021 at 12:49, Konrad Dybcio wrote: > > From: AngeloGioacchino Del Regno > > This commit adds support for Synaptics+JDI display panels > used in SONY Xperia X, X Compact, X Performance, XZ and XZs > smartphones. > > Due to the nature of phone manufacturing, it is impossible > to ret

Re: nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device

2021-06-07 Thread Ondrej Zary
On Saturday 05 June 2021 23:34:23 Ondrej Zary wrote: > On Saturday 05 June 2021 21:43:52 Ondrej Zary wrote: > > Hello, > > I'm testing 5.13.0-rc4 and nouveau crashes with NULL pointer dereference in > > nouveau_bo_sync_for_device. > > Found various reports like this but that was back in februaryso

[syzbot] WARNING in dlfb_set_video_mode/usb_submit_urb

2021-06-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c2131f7e Merge tag 'gfs2-v5.13-rc2-fixes' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1204b5d3d0 kernel config: https://syzkaller.appspot.com/x/.config?x=e2ecf1aa681aadc1 das

Re: [PATCH 0/9] Enhance pipe color support for multi segmented luts

2021-06-07 Thread Pekka Paalanen
On Fri, 4 Jun 2021 14:51:25 -0400 Harry Wentland wrote: > On 2021-06-01 6:41 a.m., Uma Shankar wrote: > > Modern hardwares have multi segmented lut approach to prioritize > > the darker regions of the spectrum. This series introduces a new > > UAPI to define the lut ranges supported by the respec

Re: [PATCH 2/2] drm/vc4: hdmi: Convert to gpiod

2021-06-07 Thread Maxime Ripard
On Fri, Jun 04, 2021 at 11:45:36PM +0200, Linus Walleij wrote: > On Fri, Jun 4, 2021 at 10:01 AM Maxime Ripard wrote: > > On Fri, May 28, 2021 at 01:57:56AM +0200, Linus Walleij wrote: > > > On Mon, May 24, 2021 at 3:19 PM Maxime Ripard wrote: > > > > > > > The new gpiod interface takes care of p

Re: [PATCH 2/4] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-07 Thread Maxime Ripard
Hi, On Fri, Jun 04, 2021 at 07:17:21PM +0200, Werner Sembach wrote: > Add a new general drm property "active bpc" which can be used by graphic > drivers > to report the applied bit depth per pixel back to userspace. Just a heads up, we'll need an open source project that has accepted it before m

Re: New uAPI for color management proposal and feedback request

2021-06-07 Thread Maxime Ripard
Hi, On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > Hello, > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" > drm properties I propose 4 new properties: "preferred pixel encoding", > "active color depth", "active color range", and "active pixel > encodin

Re: [PATCH 2/4] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-07 Thread Pekka Paalanen
On Fri, 4 Jun 2021 19:17:21 +0200 Werner Sembach wrote: > Add a new general drm property "active bpc" which can be used by graphic > drivers > to report the applied bit depth per pixel back to userspace. > > While "max bpc" can be used to change the color depth, there was no way to > check >

[PATCH v10 00/10] Add support for SVM atomics in Nouveau

2021-06-07 Thread Alistair Popple
Hi Andrew, This is an update to address some comments on the previous version of this series. Most are code comment updates, although there were a couple of code changes as well. The most significant are: - Re-introduce the check of VM_LOCKED under the PTL in page_mlock_one(). This was presen

[PATCH v10 01/10] mm: Remove special swap entry functions

2021-06-07 Thread Alistair Popple
Remove multiple similar inline functions for dealing with different types of special swap entries. Both migration and device private swap entries use the swap offset to store a pfn. Instead of multiple inline functions to obtain a struct page for each swap entry type use a common function pfn_swap

[PATCH v10 02/10] mm/swapops: Rework swap entry manipulation code

2021-06-07 Thread Alistair Popple
Both migration and device private pages use special swap entries that are manipluated by a range of inline functions. The arguments to these are somewhat inconsitent so rework them to remove flag type arguments and to make the arguments similar for both read and write entry creation. Signed-off-by

[PATCH v10 03/10] mm/rmap: Split try_to_munlock from try_to_unmap

2021-06-07 Thread Alistair Popple
The behaviour of try_to_unmap_one() is difficult to follow because it performs different operations based on a fairly large set of flags used in different combinations. TTU_MUNLOCK is one such flag. However it is exclusively used by try_to_munlock() which specifies no other flags. Therefore rather

[PATCH v10 04/10] mm/rmap: Split migration into its own function

2021-06-07 Thread Alistair Popple
Migration is currently implemented as a mode of operation for try_to_unmap_one() generally specified by passing the TTU_MIGRATION flag or in the case of splitting a huge anonymous page TTU_SPLIT_FREEZE. However it does not have much in common with the rest of the unmap functionality of try_to_unma

[PATCH v10 05/10] mm: Rename migrate_pgmap_owner

2021-06-07 Thread Alistair Popple
MMU notifier ranges have a migrate_pgmap_owner field which is used by drivers to store a pointer. This is subsequently used by the driver callback to filter MMU_NOTIFY_MIGRATE events. Other notifier event types can also benefit from this filtering, so rename the 'migrate_pgmap_owner' field to 'owne

[PATCH v10 06/10] mm/memory.c: Allow different return codes for copy_nonpresent_pte()

2021-06-07 Thread Alistair Popple
Currently if copy_nonpresent_pte() returns a non-zero value it is assumed to be a swap entry which requires further processing outside the loop in copy_pte_range() after dropping locks. This prevents other values being returned to signal conditions such as failure which a subsequent change requires

[PATCH v10 07/10] mm: Device exclusive memory access

2021-06-07 Thread Alistair Popple
Some devices require exclusive write access to shared virtual memory (SVM) ranges to perform atomic operations on that memory. This requires CPU page tables to be updated to deny access whilst atomic operations are occurring. In order to do this introduce a new swap entry type (SWP_DEVICE_EXCLUSIV

[PATCH v10 08/10] mm: Selftests for exclusive device memory

2021-06-07 Thread Alistair Popple
Adds some selftests for exclusive device memory. Signed-off-by: Alistair Popple Acked-by: Jason Gunthorpe Tested-by: Ralph Campbell Reviewed-by: Ralph Campbell --- lib/test_hmm.c | 124 +++ lib/test_hmm_uapi.h| 2 + tools/testing/s

[PATCH v10 09/10] nouveau/svm: Refactor nouveau_range_fault

2021-06-07 Thread Alistair Popple
Call mmu_interval_notifier_insert() as part of nouveau_range_fault(). This doesn't introduce any functional change but makes it easier for a subsequent patch to alter the behaviour of nouveau_range_fault() to support GPU atomic operations. Signed-off-by: Alistair Popple Reviewed-by: Ben Skeggs

[PATCH v10 10/10] nouveau/svm: Implement atomic SVM access

2021-06-07 Thread Alistair Popple
Some NVIDIA GPUs do not support direct atomic access to system memory via PCIe. Instead this must be emulated by granting the GPU exclusive access to the memory. This is achieved by replacing CPU page table entries with special swap entries that fault on userspace access. The driver then grants th

Re: [PATCH 2/4] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-07 Thread Werner Sembach
Am 07.06.21 um 09:40 schrieb Maxime Ripard: Hi, On Fri, Jun 04, 2021 at 07:17:21PM +0200, Werner Sembach wrote: Add a new general drm property "active bpc" which can be used by graphic drivers to report the applied bit depth per pixel back to userspace. Just a heads up, we'll need an open so

Re: New uAPI for color management proposal and feedback request

2021-06-07 Thread Pekka Paalanen
On Mon, 7 Jun 2021 09:48:05 +0200 Maxime Ripard wrote: > I've started to implement this for the raspberrypi some time ago. > > https://github.com/raspberrypi/linux/pull/4201 > > It's basically two properties: a bitmask of the available output pixel > encoding to report both what the display and

Re: [QUESTION] drmModeAtomicCommit returns -EINVAL on return

2021-06-07 Thread Michel Dänzer
On 2021-06-05 6:06 a.m., Sichem Zhou wrote: > > 1. Is there any way to debug when the functions like drmModeSetCrtc, > drmModePageFlip and drmModeAtomicCommit returns non zero, besides > getting the errno? Enable appropriate debugging bits in /sys/module/drm/parameters/debug, reproduce problem,

Re: [PATCH] drm/sun4i: de3: Be explicit about supported modifiers

2021-06-07 Thread Daniel Stone
On Sat, 5 Jun 2021 at 08:36, Jernej Skrabec wrote: > Currently only linear formats are supported in sun4i-drm driver, but > SoCs like H6 supports AFBC variant of some of them in multiple cores > (GPU, VPU, DE3). Panfrost already implements AFBC compression and is > sometimes confused what should b

Re: [PATCH] drm/sun4i: de3: Be explicit about supported modifiers

2021-06-07 Thread Maxime Ripard
On Sat, Jun 05, 2021 at 09:35:34AM +0200, Jernej Skrabec wrote: > From: Piotr Oniszczuk > > Currently only linear formats are supported in sun4i-drm driver, but > SoCs like H6 supports AFBC variant of some of them in multiple cores > (GPU, VPU, DE3). Panfrost already implements AFBC compression a

Re: [PATCH 2/4] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-07 Thread Werner Sembach
Am 07.06.21 um 09:52 schrieb Pekka Paalanen: On Fri, 4 Jun 2021 19:17:21 +0200 Werner Sembach wrote: Add a new general drm property "active bpc" which can be used by graphic drivers to report the applied bit depth per pixel back to userspace. While "max bpc" can be used to change the color

[PATCH v2] drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device

2021-06-07 Thread Ondrej Jirman
From: Saravana Kannan On sunxi boards that use HDMI output, HDMI device probe keeps being avoided indefinitely with these repeated messages in dmesg: platform 1ee.hdmi: probe deferral - supplier 1ef.hdmi-phy not ready There's a fwnode_link being created with fw_devlink=on between

Re: handle exclusive fence similar to shared ones

2021-06-07 Thread Daniel Vetter
Hi Christian, So unfortunately I got distracted with some i915 bugs and fun last week completely, so didn't get around to it. On Sun, Jun 6, 2021 at 12:03 PM Christian König wrote: > > Hi Daniel, > > as discussed here are the patches which change the handle around exclusive > fence handling. >

Re: [PATCH 0/2] cleanup patches for PM reference leak

2021-06-07 Thread yukuai (C)
ping ... On 2021/05/29 17:11, yukuai (C) wrote: ping ... On 2021/05/17 16:14, Yu Kuai wrote: Yu Kuai (2):    drm/v3d: Fix PM reference leak in v3d_get_param_ioctl()    drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident()   drivers/gpu/drm/v3d/v3d_debugfs.c | 4 ++--   drivers/gpu/drm/v3d/

Re: [PATCH v2] drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device

2021-06-07 Thread Andre Przywara
On Mon, 7 Jun 2021 10:58:36 +0200 Ondrej Jirman wrote: Hi, > From: Saravana Kannan > > On sunxi boards that use HDMI output, HDMI device probe keeps being > avoided indefinitely with these repeated messages in dmesg: > > platform 1ee.hdmi: probe deferral - supplier 1ef.hdmi-phy >

Re: handle exclusive fence similar to shared ones

2021-06-07 Thread Christian König
Am 07.06.21 um 10:58 schrieb Daniel Vetter: Hi Christian, So unfortunately I got distracted with some i915 bugs and fun last week completely, so didn't get around to it. On Sun, Jun 6, 2021 at 12:03 PM Christian König wrote: Hi Daniel, as discussed here are the patches which change the handl

Re: [PATCH 10/10] drm/ttm: flip the switch for driver allocated resources v2

2021-06-07 Thread Intel
On 6/2/21 12:09 PM, Christian König wrote: Instead of both driver and TTM allocating memory finalize embedding the ttm_resource object as base into the driver backends. v2: fix typo in vmwgfx grid mgr and double init in amdgpu_vram_mgr.c Signed-off-by: Christian König Reviewed-by: Matthew Au

Re: [PATCH] RDMA/umem: fix missing automated rename

2021-06-07 Thread kernel test robot
st to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christian-K-nig/RDMA-umem-fix-missing-automated-rename/20210607-150846 base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next config: pow

[PATCH] drm/amd/display: Fix duplicate included dce110_hw_sequencer.h

2021-06-07 Thread Jiapeng Chong
Clean up the following includecheck warning: ./drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c: dce110_hw_sequencer.h is included more than once. No functional change. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequenc

Re: [PATCH] RDMA/umem: fix missing automated rename

2021-06-07 Thread kernel test robot
st to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christian-K-nig/RDMA-umem-fix-missing-automated-rename/20210607-150846 base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next config: mips-

Re: [PATCH 10/10] drm/ttm: flip the switch for driver allocated resources v2

2021-06-07 Thread Christian König
Am 07.06.21 um 12:15 schrieb Thomas Hellström (Intel): On 6/2/21 12:09 PM, Christian König wrote: Instead of both driver and TTM allocating memory finalize embedding the ttm_resource object as base into the driver backends. v2: fix typo in vmwgfx grid mgr and double init in amdgpu_vram_mgr.c

[PATCH] drm/ttm: fix missing res assignment in ttm_range_man_alloc

2021-06-07 Thread Christian König
That somehow got missing. Signed-off-by: Christian König Fixes: cb1c81467af3 ("drm/ttm: flip the switch for driver allocated resources v2") --- drivers/gpu/drm/ttm/ttm_range_manager.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_range_ma

Re: [PATCH 10/10] drm/ttm: flip the switch for driver allocated resources v2

2021-06-07 Thread Intel
On 6/7/21 12:37 PM, Christian König wrote: Am 07.06.21 um 12:15 schrieb Thomas Hellström (Intel): On 6/2/21 12:09 PM, Christian König wrote: Instead of both driver and TTM allocating memory finalize embedding the ttm_resource object as base into the driver backends. v2: fix typo in vmwgfx g

[PATCH] drm/msm: export hangcheck_period in debugfs

2021-06-07 Thread Samuel Iglesias Gonsalvez
While keeping the previous default value for hangcheck period, we allow now the possibility of configuring its value via debugfs. Signed-off-by: Samuel Iglesias Gonsalvez --- drivers/gpu/drm/msm/msm_debugfs.c | 3 +++ drivers/gpu/drm/msm/msm_drv.c | 1 + drivers/gpu/drm/msm/msm_drv.h | 3

Re: [PATCH] drm/ttm: fix missing res assignment in ttm_range_man_alloc

2021-06-07 Thread Intel
On 6/7/21 12:40 PM, Christian König wrote: That somehow got missing. Signed-off-by: Christian König Fixes: cb1c81467af3 ("drm/ttm: flip the switch for driver allocated resources v2") Reported-by: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/ttm_range_manag

Re: [PATCH] drm/amdgpu: Fix a a typo in a comment

2021-06-07 Thread Christian König
Am 05.06.21 um 11:06 schrieb Christophe JAILLET: s/than/then/ Signed-off-by: Christophe JAILLET Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/

Re: [PATCH 02/21] drm: Add Plane Degamma Mode property

2021-06-07 Thread Pekka Paalanen
On Fri, 4 Jun 2021 14:24:28 -0400 Harry Wentland wrote: > On 2021-06-01 6:51 a.m., Uma Shankar wrote: > > Add Plane Degamma Mode as an enum property. Create a helper > > function for all plane color management features. > > > > This is an enum property with values as blob_id's and exposes > > th

Re: [PATCH] RDMA/umem: fix missing automated rename

2021-06-07 Thread Christian König
Ping. Can anybody give me a quick rb or ack-by? The driver currently doesn't compile without this on the drm-misc-next branch. Thanks, Christian. Am 07.06.21 um 09:06 schrieb Christian König: This occasions was missed during the recent rename of the function. Signed-off-by: Christian König

Re: [PATCH v3] backlight: ktd253: Stabilize backlight

2021-06-07 Thread Daniel Thompson
On Fri, Jun 04, 2021 at 08:32:01AM +0200, Linus Walleij wrote: > Remove interrupt disablement during backlight setting. It is > way to dangerous and makes platforms instable by having it > miss vblank IRQs leading to the graphics derailing. > > The code is using ndelay() which is not available on

Re: [PATCH v2] drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device

2021-06-07 Thread Maxime Ripard
On Mon, Jun 07, 2021 at 10:58:36AM +0200, Ondrej Jirman wrote: > From: Saravana Kannan > > On sunxi boards that use HDMI output, HDMI device probe keeps being > avoided indefinitely with these repeated messages in dmesg: > > platform 1ee.hdmi: probe deferral - supplier 1ef.hdmi-phy >

[PATCH][next] drm/amd/display: Fix two spelling mistakes, clean wide lines

2021-06-07 Thread Colin King
From: Colin Ian King There are two spelling mistakes in dml_print messages, fix these and clear up checkpatch warning on overly wide line length. Signed-off-by: Colin Ian King --- .../drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletio

Re: [PATCH] drm/i915/display: remove duplicated argument

2021-06-07 Thread Imre Deak
On Sat, Jun 05, 2021 at 11:22:07AM +0800, Wan Jiabing wrote: > Fix the following coccicheck warning: > > ./drivers/gpu/drm/i915/display/intel_display_power.c:3081:1-28: > duplicated argument to & or | > > This commit fixes duplicate argument. It might be a typo. > But what I can do is to remove

Re: [PATCH] drm/radeon: Always call radeon_suspend_kms() in radeon_pci_shutdown()

2021-06-07 Thread Christian König
Am 07.06.21 um 14:27 schrieb Tiezhu Yang: radeon_suspend_kms() puts the hw in the suspend state (all asics), it should always call radeon_suspend_kms() in radeon_pci_shutdown(), this is a normal cleanup process to avoid more operations on radeon, just remove #ifdef CONFIG_PPC64 and the related co

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

2021-06-07 Thread Christian König
Thomas any comments on this? Is the purpose of this now clear enough? Thanks, Christian. Am 01.06.21 um 14:25 schrieb Christian König: From: Lang Yu Sometimes drivers need to use bounce buffers to evict BOs. While those reside in some domain they are not necessarily suitable for CS. Add a f

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

2021-06-07 Thread Intel
Sure. LGTM, Reviewed-by: Thomas Hellström On 6/7/21 2:36 PM, Christian König wrote: Thomas any comments on this? Is the purpose of this now clear enough? Thanks, Christian. Am 01.06.21 um 14:25 schrieb Christian König: From: Lang Yu Sometimes drivers need to use bounce buffers to evict

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

2021-06-07 Thread Christian König
Thanks! Lang can anybody from your team give as an reviewed-by/test-by on the amdgpu patches? I just want another pair of eyes looking over it. If nobody else has time I will ask Nirmoy for a quick testing round. Thanks, Christian. Am 07.06.21 um 14:38 schrieb Thomas Hellström (Intel): Sure

[PATCH] drm/msm: cleanup coding style a bit

2021-06-07 Thread Bernard Zhao
cleanup coding style a bit Signed-off-by: Bernard Zhao --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a4xx_gpu.c b/drivers/gpu/drm/msm/adreno/a4xx_gpu.c index 82bebb40234d..87e834850e44 100644 --- a/dr

Re: [PATCH] drm/ttm: fix deref of bo->ttm without holding the lock v2

2021-06-07 Thread Christian König
Am 28.05.21 um 15:06 schrieb Thomas Hellström: On 5/28/21 3:00 PM, Christian König wrote: We need to grab the resv lock first before doing that check. v2 (chk): simplify the change for -fixes Signed-off-by: Christian König Signed-off-by: Thomas Hellström Hmm, OK, but this doesn't fix t

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

2021-06-07 Thread Yu, Lang
[AMD Official Use Only] Thanks,please let Nirmoy do it. Regards, Lang 获取 Outlook for iOS 发件人: Christian König 发送时间: Monday, June 7, 2021 8:41:49 PM 收件人: Thomas Hellström (Intel) ; Yu, Lang 抄送: dri-devel@lists.freedesktop.org 主题: Re: [PA

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

2021-06-07 Thread Christian König
Hi Nirmoy, can you give that patch set a testing round and an review? The memory stress test with low VRAM on APUs should be sufficient and you should have that setup still around. Thanks in advance, Christian. Am 07.06.21 um 14:58 schrieb Yu, Lang: [AMD Official Use Only] Thanks,please

Re: [PATCH] drm/amdkfd: remove duplicate include of kfd_svm.h

2021-06-07 Thread Felix Kuehling
Am 2021-06-04 um 10:54 p.m. schrieb Wan Jiabing: > kfd_svm.h is included duplicately in commit 42de677f7 > ("drm/amdkfd: register svm range"). > > After checking possible related header files, > remove the former one to make the code format more reasonable. > > Signed-off-by: Wan Jiabing Rev

Re: [PATCH] RDMA/umem: fix missing automated rename

2021-06-07 Thread Alex Deucher
Reviewed-by: Alex Deucher On Mon, Jun 7, 2021 at 7:01 AM Christian König wrote: > > Ping. Can anybody give me a quick rb or ack-by? > > The driver currently doesn't compile without this on the drm-misc-next > branch. > > Thanks, > Christian. > > Am 07.06.21 um 09:06 schrieb Christian König: > >

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

2021-06-07 Thread Will Deacon
[Adding VC4 folks -- please see the KASAN splat below!] Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in -next) is causing vc4 to hang on Rpi3b due to a probable driver bug. Will On Mon, Jun 07, 2021 at 02:08:59PM +0100, Mark Rutland wrote: > On Mon, Jun 07, 2021 at 0

[PATCH] drm/malidp: convert sysfs snprintf to sysfs_emit

2021-06-07 Thread Xuezhi Zhang
From: Xuezhi Zhang Fix the following coccicheck warning: drivers/gpu/drm/arm/malidp_drv.c:657:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang --- drivers/gpu/drm/arm/malidp_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_

Re: [PATCH] drm/radeon: Always call radeon_suspend_kms() in radeon_pci_shutdown()

2021-06-07 Thread Alex Deucher
On Mon, Jun 7, 2021 at 8:30 AM Christian König wrote: > > Am 07.06.21 um 14:27 schrieb Tiezhu Yang: > > radeon_suspend_kms() puts the hw in the suspend state (all asics), > > it should always call radeon_suspend_kms() in radeon_pci_shutdown(), > > this is a normal cleanup process to avoid more ope

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

2021-06-07 Thread Arnd Bergmann
On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > [Adding VC4 folks -- please see the KASAN splat below!] > > Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in > -next) is causing vc4 to hang on Rpi3b due to a probable driver bug. The great news for the patch that c

[PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

2021-06-07 Thread Christian König
We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for this is that vmf_insert_mixed_prot() always tries to grab a reference to the underlaying page on architect

Re: [PATCH] drm/ttm: fix deref of bo->ttm without holding the lock v2

2021-06-07 Thread Pan, Xinhui
[AMD Official Use Only] Looks good to me. From: Christian König Sent: Monday, June 7, 2021 8:52:21 PM To: dri-devel@lists.freedesktop.org ; Pan, Xinhui ; Das, Nirmoy ; Huang, Ray Cc: Thomas Hellström Subject: Re: [PATCH] drm/ttm: fix deref of bo->ttm without h

Re: [PATCH] drm/ttm: fix deref of bo->ttm without holding the lock v2

2021-06-07 Thread Christian König
I take that as an reviewed-by :) Thanks, Christian. Am 07.06.21 um 16:14 schrieb Pan, Xinhui: [AMD Official Use Only] Looks good to me. *From:* Christian König *Sent:* Monday, June 7, 2021 8:52:21 PM *To:* dri-devel@li

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

2021-06-07 Thread Mark Rutland
On Mon, Jun 07, 2021 at 02:39:54PM +0100, Will Deacon wrote: > [Adding VC4 folks -- please see the KASAN splat below!] > > Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in > -next) is causing vc4 to hang on Rpi3b due to a probable driver bug. > > Will > > On Mon, Jun

Re: [PATCH 0/7] libdrm tests for hot-unplug fe goature

2021-06-07 Thread Andrey Grodzovsky
Hey, MR created at https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/172, please help review. Andrey On 2021-06-03 10:26 p.m., Alex Deucher wrote: Code review happens on gitlab now for libdrm. Alex On Thu, Jun 3, 2021 at 6:02 PM Grodzovsky, Andrey wrote: Is libdrm on gitlab ? I was

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

2021-06-07 Thread Das, Nirmoy
On 6/7/2021 3:01 PM, Christian König wrote: Hi Nirmoy, can you give that patch set a testing round and an review? Sure! I will get back asap. The memory stress test with low VRAM on APUs should be sufficient and you should have that setup still around. Thanks in advance, Christian. Am

Re: [PATCH] drm/amd/display: Verify Gamma & Degamma LUT sizes in amdgpu_dm_atomic_check

2021-06-07 Thread Mark Yacoub
On Fri, Jun 4, 2021 at 4:17 PM Harry Wentland wrote: > > > > On 2021-06-04 1:01 p.m., Mark Yacoub wrote: > > From: Mark Yacoub > > > > For each CRTC state, check the size of Gamma and Degamma LUTs so > > unexpected and larger sizes wouldn't slip through. > > > > TEST: IGT:kms_color::pipe-invalid

Re: handle exclusive fence similar to shared ones

2021-06-07 Thread Daniel Vetter
On Mon, Jun 07, 2021 at 11:59:11AM +0200, Christian König wrote: > Am 07.06.21 um 10:58 schrieb Daniel Vetter: > > Hi Christian, > > > > So unfortunately I got distracted with some i915 bugs and fun last > > week completely, so didn't get around to it. > > > > On Sun, Jun 6, 2021 at 12:03 PM Chri

Re: [PATCH v6 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-06-07 Thread Deepak Rawat
On Thu, 2021-05-27 at 15:35 +0200, Thomas Zimmermann wrote: > Hi > > if no further comments come in, this can be moved in a few days. > Since > you'll be the maintainer, you should request commit access to the > drm-misc repository. See > >   > https://drm.pages.freedesktop.org/maintainer-to

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

2021-06-07 Thread Maxime Ripard
On Mon, Jun 07, 2021 at 03:57:41PM +0200, Arnd Bergmann wrote: > On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > > > [Adding VC4 folks -- please see the KASAN splat below!] > > > > Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in > > -next) is causing vc4 to hang

Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3

2021-06-07 Thread Das, Nirmoy
Hi Christian and Lang, I can't apply it cleanly because of https://patchwork.freedesktop.org/patch/436305/. This series needs a rebase. Regards, Nirmoy On 6/7/2021 4:42 PM, Das, Nirmoy wrote: On 6/7/2021 3:01 PM, Christian König wrote: Hi Nirmoy, can you give that patch set a testing

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

2021-06-07 Thread Mark Rutland
On Mon, Jun 07, 2021 at 03:57:41PM +0200, Arnd Bergmann wrote: > On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > > > [Adding VC4 folks -- please see the KASAN splat below!] > > > > Background here is that reducing ARCH_DMA_MINALIGN to 64 on arm64 (queued in > > -next) is causing vc4 to hang

Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES)

2021-06-07 Thread Arnd Bergmann
On Mon, Jun 7, 2021 at 5:17 PM Maxime Ripard wrote: > On Mon, Jun 07, 2021 at 03:57:41PM +0200, Arnd Bergmann wrote: > > On Mon, Jun 7, 2021 at 3:39 PM Will Deacon wrote: > > > On Mon, Jun 07, 2021 at 02:08:59PM +0100, Mark Rutland wrote: > > > > On Mon, Jun 07, 2021 at 01:01:18PM +0100, Mark Rut

[PATCH AUTOSEL 5.12 14/49] drm/tegra: sor: Do not leak runtime PM reference

2021-06-07 Thread Sasha Levin
From: "Pavel Machek (CIP)" [ Upstream commit 73a395c46704304b96bc5e2ee19be31124025c0c ] It's theoretically possible for the runtime PM reference to leak if the code fails anywhere between the pm_runtime_resume_and_get() and pm_runtime_put() calls, so make sure to release the runtime PM reference

[PATCH AUTOSEL 5.12 15/49] gpu: host1x: Split up client initalization and registration

2021-06-07 Thread Sasha Levin
From: Thierry Reding [ Upstream commit 0cfe5a6e758fb20be8ad3e8f10cb087cc8033eeb ] In some cases we may need to initialize the host1x client first before registering it. This commit adds a new helper that will do nothing but the initialization of the data structure. At the same time, the initial

[PATCH AUTOSEL 5.12 16/49] drm/tegra: sor: Fully initialize SOR before registration

2021-06-07 Thread Sasha Levin
From: Thierry Reding [ Upstream commit 5dea42759bcef74b0802ea64b904409bc37f9045 ] Before registering the SOR host1x client, make sure that it is fully initialized. This avoids a potential race condition between the SOR's probe and the host1x device initialization in cases where the SOR is the fi

[PATCH AUTOSEL 5.12 41/49] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-06-07 Thread Sasha Levin
From: Bindu Ramamurthy [ Upstream commit ba8e59773ae59818695d1e20b8939282da80ec8c ] [Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams, these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non z

[PATCH AUTOSEL 5.12 42/49] drm/amdgpu: refine amdgpu_fru_get_product_info

2021-06-07 Thread Sasha Levin
From: Jiansong Chen [ Upstream commit 5cfc912582e13b05d71fb7acc4ec69ddfa9af320 ] 1. eliminate potential array index out of bounds. 2. return meaningful value for failure. Signed-off-by: Jiansong Chen Reviewed-by: Jack Gui Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../gpu/d

[PATCH AUTOSEL 5.12 43/49] drm/amd/display: Fix overlay validation by considering cursors

2021-06-07 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 33f409e60eb0c59a4d0d06a62ab4642a988e17f7 ] A few weeks ago, we saw a two cursor issue in a ChromeOS system. We fixed it in the commit: drm/amd/display: Fix two cursor duplication when using overlay (read the commit message for more details) After this

[PATCH AUTOSEL 5.12 44/49] drm/amd/display: Fix potential memory leak in DMUB hw_init

2021-06-07 Thread Sasha Levin
From: Roman Li [ Upstream commit c5699e2d863f58221044efdc3fa712dd32d55cde ] [Why] On resume we perform DMUB hw_init which allocates memory: dm_resume->dm_dmub_hw_init->dc_dmub_srv_create->kzalloc That results in memory leak in suspend/resume scenarios. [How] Allocate memory for the DC wrapper t

[PATCH AUTOSEL 5.12 45/49] drm/amd/amdgpu:save psp ring wptr to avoid attack

2021-06-07 Thread Sasha Levin
From: Victor Zhao [ Upstream commit 2370eba9f552eaae3d8aa1f70b8e9eec5c560f9e ] [Why] When some tools performing psp mailbox attack, the readback value of register can be a random value which may break psp. [How] Use a psp wptr cache machanism to aovid the change made by attack. v2: unify chang

[PATCH AUTOSEL 5.10 10/39] drm/tegra: sor: Do not leak runtime PM reference

2021-06-07 Thread Sasha Levin
From: "Pavel Machek (CIP)" [ Upstream commit 73a395c46704304b96bc5e2ee19be31124025c0c ] It's theoretically possible for the runtime PM reference to leak if the code fails anywhere between the pm_runtime_resume_and_get() and pm_runtime_put() calls, so make sure to release the runtime PM reference

[PATCH AUTOSEL 5.10 11/39] gpu: host1x: Split up client initalization and registration

2021-06-07 Thread Sasha Levin
From: Thierry Reding [ Upstream commit 0cfe5a6e758fb20be8ad3e8f10cb087cc8033eeb ] In some cases we may need to initialize the host1x client first before registering it. This commit adds a new helper that will do nothing but the initialization of the data structure. At the same time, the initial

[PATCH AUTOSEL 5.10 12/39] drm/tegra: sor: Fully initialize SOR before registration

2021-06-07 Thread Sasha Levin
From: Thierry Reding [ Upstream commit 5dea42759bcef74b0802ea64b904409bc37f9045 ] Before registering the SOR host1x client, make sure that it is fully initialized. This avoids a potential race condition between the SOR's probe and the host1x device initialization in cases where the SOR is the fi

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

2021-06-07 Thread Intel
On 6/7/21 3:58 PM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for this is that vmf_insert_mixed_prot() always tries to grab a

[PATCH AUTOSEL 5.10 31/39] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-06-07 Thread Sasha Levin
From: Bindu Ramamurthy [ Upstream commit ba8e59773ae59818695d1e20b8939282da80ec8c ] [Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams, these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non z

[PATCH AUTOSEL 5.10 32/39] drm/amdgpu: refine amdgpu_fru_get_product_info

2021-06-07 Thread Sasha Levin
From: Jiansong Chen [ Upstream commit 5cfc912582e13b05d71fb7acc4ec69ddfa9af320 ] 1. eliminate potential array index out of bounds. 2. return meaningful value for failure. Signed-off-by: Jiansong Chen Reviewed-by: Jack Gui Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../gpu/d

[PATCH AUTOSEL 5.10 34/39] drm/amd/display: Fix potential memory leak in DMUB hw_init

2021-06-07 Thread Sasha Levin
From: Roman Li [ Upstream commit c5699e2d863f58221044efdc3fa712dd32d55cde ] [Why] On resume we perform DMUB hw_init which allocates memory: dm_resume->dm_dmub_hw_init->dc_dmub_srv_create->kzalloc That results in memory leak in suspend/resume scenarios. [How] Allocate memory for the DC wrapper t

[PATCH AUTOSEL 5.10 33/39] drm/amd/display: Fix overlay validation by considering cursors

2021-06-07 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 33f409e60eb0c59a4d0d06a62ab4642a988e17f7 ] A few weeks ago, we saw a two cursor issue in a ChromeOS system. We fixed it in the commit: drm/amd/display: Fix two cursor duplication when using overlay (read the commit message for more details) After this

[PATCH AUTOSEL 5.10 35/39] drm/amd/amdgpu:save psp ring wptr to avoid attack

2021-06-07 Thread Sasha Levin
From: Victor Zhao [ Upstream commit 2370eba9f552eaae3d8aa1f70b8e9eec5c560f9e ] [Why] When some tools performing psp mailbox attack, the readback value of register can be a random value which may break psp. [How] Use a psp wptr cache machanism to aovid the change made by attack. v2: unify chang

[PATCH AUTOSEL 5.4 09/29] drm/tegra: sor: Do not leak runtime PM reference

2021-06-07 Thread Sasha Levin
From: "Pavel Machek (CIP)" [ Upstream commit 73a395c46704304b96bc5e2ee19be31124025c0c ] It's theoretically possible for the runtime PM reference to leak if the code fails anywhere between the pm_runtime_resume_and_get() and pm_runtime_put() calls, so make sure to release the runtime PM reference

[PATCH AUTOSEL 5.4 24/29] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-06-07 Thread Sasha Levin
From: Bindu Ramamurthy [ Upstream commit ba8e59773ae59818695d1e20b8939282da80ec8c ] [Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams, these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non z

[PATCH AUTOSEL 5.4 25/29] drm/amd/display: Fix overlay validation by considering cursors

2021-06-07 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 33f409e60eb0c59a4d0d06a62ab4642a988e17f7 ] A few weeks ago, we saw a two cursor issue in a ChromeOS system. We fixed it in the commit: drm/amd/display: Fix two cursor duplication when using overlay (read the commit message for more details) After this

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

2021-06-07 Thread Christian König
Am 07.06.21 um 18:13 schrieb Thomas Hellström (Intel): On 6/7/21 3:58 PM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for t

Re: handle exclusive fence similar to shared ones

2021-06-07 Thread Christian König
Am 07.06.21 um 17:09 schrieb Daniel Vetter: On Mon, Jun 07, 2021 at 11:59:11AM +0200, Christian König wrote: Am 07.06.21 um 10:58 schrieb Daniel Vetter: Hi Christian, So unfortunately I got distracted with some i915 bugs and fun last week completely, so didn't get around to it. On Sun, Jun

Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

2021-06-07 Thread Intel
On 6/2/21 12:09 PM, Christian König wrote: ... @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, */ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, const struct ttm_place *place, -

[PATCH v9 00/11] drm: Fix EDID reading on ti-sn65dsi86 by introducing the DP AUX bus

2021-06-07 Thread Douglas Anderson
The primary goal of this series is to try to properly fix EDID reading for eDP panels using the ti-sn65dsi86 bridge. Previously we had a patch that added EDID reading but it turned out not to work at bootup. This caused some extra churn at bootup as we tried (and failed) to read the EDID several t

  1   2   3   >