Re: [PATCH] drm/ast: Add detect function support

2021-05-26 Thread Thomas Zimmermann
Hi, thanks for the patch. Am 25.05.21 um 03:55 schrieb ainux.w...@gmail.com: From: Ainux The existence of the connector cannot be detected, so add the detect function to support. Signed-off-by: Ainux --- drivers/gpu/drm/ast/ast_drv.c | 2 ++ drivers/gpu/drm/ast/ast_mode.c | 19

Re: [PATCH v9 07/10] mm: Device exclusive memory access

2021-05-26 Thread John Hubbard
On 5/25/21 4:51 AM, Balbir Singh wrote: ... How beneficial is this code to nouveau users? I see that it permits a part of OpenCL to be implemented, but how useful/important is this in the real world? That is a very good question! I've not reviewed the code, but a sample program with the descri

Re: [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names

2021-05-26 Thread Thomas Zimmermann
Am 25.05.21 um 17:13 schrieb Javier Martinez Canillas: Framebuffer devices that are registered by DRM drivers for fbdev emulation have a "drmfb" suffix in their name. But makes them to be quite confusing for drivers that already have "drm" in their name: $ cat /proc/fb 0 rockchipdrmdrmfb $ ca

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2021-05-26 Thread Thomas Hellström
On 5/25/21 5:48 PM, Christian König wrote: Am 25.05.21 um 12:07 schrieb Thomas Hellström: On Tue, 2021-05-25 at 10:58 +0100, Matthew Auld wrote: On Tue, 25 May 2021 at 10:32, Thomas Hellström wrote: On 5/25/21 11:18 AM, Matthew Auld wrote: On Fri, 21 May 2021 at 16:33, Thomas Hellström

Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel

2021-05-26 Thread Stefan Riedmüller
Hi, gentle ping for this small series. Regards, Stefan On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote: > The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. > Add the corresponding connector type and 8 bpc as default bus_format. > > Signed-off-by: Stefan Riedmue

[PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL

2021-05-26 Thread Geert Uytterhoeven
The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded Controller, and is accessed using I2C tunneling through the Embedded Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent asking the user about this driver when configuring a kernel without support for the ChromeOS

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-26 Thread Chunyan Zhang
Hi Robin, On Tue, 18 May 2021 at 00:35, Robin Murphy wrote: > On 2021-05-17 10:27, Joerg Roedel wrote: > > On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote: > >> Cc Robin & Joerg > > > > This is just some GPU internal MMU being used here, it seems. It doesn't > > use the IOMMU core co

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-26 Thread Chunyan Zhang
resend for switching to plain text mode. On Wed, 26 May 2021 at 15:59, Chunyan Zhang wrote: > > Hi Robin, > > On Tue, 18 May 2021 at 00:35, Robin Murphy wrote: >> >> On 2021-05-17 10:27, Joerg Roedel wrote: >> > On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote: >> >> Cc Robin & Joerg

[PATCH v2] drm/exynos: use pm_runtime_resume_and_get()

2021-05-26 Thread Inki Dae
Use pm_runtime_resume_and_get() instead of pm_runtime_get_sync() to deal with usage counter. pm_runtime_get_sync() increases the usage counter even when it failed, which makes callers to forget to decrease the usage counter and resulted in reference leak. pm_runtime_resume_and_get() function decre

Re: [Intel-gfx] [RFC PATCH 60/97] drm/i915: Track 'serial' counts for virtual engines

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:52, Matthew Brost wrote: On Tue, May 25, 2021 at 11:16:12AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: From: John Harrison The serial number tracking of engines happens at the backend of request submission and was expecting to only be given phys

[PATCH 00/34] Rid W=1 warnings from GPU

2021-05-26 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (34): drm/amd/pm/inc/smu_v13_0: Move table into the only source file that uses it drm/amd/pm/swsmu/smu13/aldebaran_ppt: Remove unu

[PATCH 10/34] drm/amd/display/dc/bios/bios_parser: Fix formatting and misnaming issues

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: expecting prototype for get_ss_info_from_table(). Prototype was for get_ss_info_from_tbl() instead drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1562: warnin

[PATCH 07/34] drm/amd/pm/powerplay/hwmgr/vega20_hwmgr: Provide function name 'vega20_init_smc_table()'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_hwmgr.c:781: warning: expecting prototype for Initializes the SMC table and uploads it(). Prototype was for vega20_init_smc_table() instead Cc: Evan Quan Cc: Alex Deucher Cc: "Christian K

[PATCH 05/34] drm/amd/pm/powerplay/hwmgr/vega12_hwmgr: Provide 'vega12_init_smc_table()' function name

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_hwmgr.c:812: warning: expecting prototype for Initializes the SMC table and uploads it(). Prototype was for vega12_init_smc_table() instead Cc: Evan Quan Cc: Alex Deucher Cc: "Christian K

[PATCH 03/34] drm/amd/pm/powerplay/hwmgr/smu7_thermal: Provide function name for 'smu7_fan_ctrl_set_default_mode()'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_thermal.c:132: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc

[PATCH 02/34] drm/amd/pm/swsmu/smu13/aldebaran_ppt: Remove unused variable 'ret'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c: In function ‘aldebaran_is_dpm_running’: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1260:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc:

[PATCH 19/34] drm/amd/amdgpu/amdgpu_device: Make local function static

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4624:6: warning: no previous prototype for ‘amdgpu_device_recheck_guilty_jobs’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: a

[PATCH 26/34] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead Cc: Hyun Kwon Cc: Laurent Pinchart Cc: David Airlie Cc: Daniel Vetter Cc: Michal Simek Cc: Philipp Zab

[PATCH 20/34] drm/amd/display/amdgpu_dm/amdgpu_dm: Fix kernel-doc formatting issue

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:608: warning: Function parameter or member 'interrupt_params' not described in 'dm_dcn_vertical_interrupt0_high_irq' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian Kön

[PATCH 01/34] drm/amd/pm/inc/smu_v13_0: Move table into the only source file that uses it

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/inc/smu_v13_0.h:54:43: warning: ‘smu13_thermal_policy’ defined but not used [-Wunused-const-variable=] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Kevin Wang Cc: amd-...@list

[PATCH 06/34] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Kernel-doc headers must contain function names

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:547: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hw

[PATCH 04/34] drm/amd/pm/powerplay/hwmgr/vega12_thermal: Provide function name

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_thermal.c:171: warning: expecting prototype for Set the requested temperature range for high and low alert signals(). Prototype was for vega12_thermal_set_temperature_range() instead Cc: E

[PATCH 09/34] drm/amd/display/dc/bios/command_table_helper2: Fix function name 'dal_cmd_table_helper_transmitter_bp_to_atom2()'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper2.c:141: warning: expecting prototype for translate_transmitter_bp_to_atom2(). Prototype was for dal_cmd_table_helper_transmitter_bp_to_atom2() instead Cc: Harry Wentland Cc: Leo

[PATCH 12/34] drm/amd/display/amdgpu_dm/amdgpu_dm: Functions must directly follow their headers

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:608: warning: Function parameter or member 'interrupt_params' not described in 'dm_dcn_vertical_interrupt0_high_irq' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian Kön

[PATCH 22/34] drm/amd/display/dc/core/dc: Convert function headers to kernel-doc

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3324: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3344: warning: Cannot understa

[PATCH 14/34] drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c: In function ‘dal_gpio_service_create’: drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c:71:4: warning: implicit conversion from ‘enum dce_version’ to ‘enum dce_environment

[PATCH 16/34] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’ In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:28: drive

[PATCH 30/34] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vgem/vgem_drv.c:47: warning: expecting prototype for This is vgem, a (non-hardware(). Prototype was for DRIVER_NAME() instead Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Adam Jackson Cc: Ben

[PATCH 18/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:29: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:7270:45: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd

[PATCH 28/34] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c:33: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Ve

[PATCH 23/34] drm/amd/display/dmub/src/dmub_srv_stat: Convert function header to kernel-doc

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv_stat.c:38: warning: Cannot understand * Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König"

[PATCH 17/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK}

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:29: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:7270:45: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd

[PATCH 13/34] drm/amd/display/dc/dce/dmub_outbox: Convert over to kernel-doc

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_outbox.c:30: warning: Cannot understand * Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc:

[PATCH 15/34] drm/amd/display/dc/dce110/dce110_hw_sequencer: Include our own header

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:927:6: warning: no previous prototype for ‘dce110_edp_wait_for_T12’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David A

[PATCH 29/34] drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/panel/panel-sitronix-st7701.c:42: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jagan Teki Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: D

[PATCH 08/34] drm/amd/display/dc/bios/command_table_helper: Fix function name for 'dal_cmd_table_helper_transmitter_bp_to_atom()'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper.c:127: warning: expecting prototype for translate_transmitter_bp_to_atom(). Prototype was for dal_cmd_table_helper_transmitter_bp_to_atom() instead Cc: Harry Wentland Cc: Leo Li

[PATCH 31/34] drm/exynos/exynos7_drm_decon: Fix incorrect naming of 'decon_shadow_protect_win()'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/exynos/exynos7_drm_decon.c:355: warning: expecting prototype for shadow_protect_win(). Prototype was for decon_shadow_protect_win() instead Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: David Airlie

[PATCH 27/34] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_tt.c:398: warning: Function parameter or member 'num_pages' not described in 'ttm_tt_mgr_init' drivers/gpu/drm/ttm/ttm_tt.c:398: warning: Function parameter or member 'num_dma32_pages' not described in 'ttm_tt_mgr_init'

[PATCH 25/34] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/xlnx/zynqmp_disp.c:101: warning: expecting prototype for enum zynqmp_disp_id. Prototype was for enum zynqmp_disp_layer_id instead Cc: Hyun Kwon Cc: Laurent Pinchart Cc: David Airlie Cc: Daniel Vetter Cc: Michal Simek Cc: dri-

[PATCH 11/34] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:50:1: warning: no previous prototype for ‘tu102_mc_intr_unarm’ [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:62:1: warning: no previous prototype for ‘tu102_mc_intr_rearm’ [-

[PATCH 33/34] drm/vboxvideo/hgsmi_base: Place function names into headers

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vboxvideo/hgsmi_base.c:12: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/vboxvideo/hgsmi_base.c:42: warning: expecting prototype for Notify

[PATCH 21/34] drm/amd/display/dc/dce110/dce110_hw_sequencer: Include header containing our prototypes

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:929:6: warning: no previous prototype for ‘dce110_edp_wait_for_T12’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David A

[PATCH 32/34] drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps, res}_ioctl()'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/exynos/exynos_drm_ipp.c:105: warning: expecting prototype for exynos_drm_ipp_ioctl_get_res_ioctl(). Prototype was for exynos_drm_ipp_get_res_ioctl() instead drivers/gpu/drm/exynos/exynos_drm_ipp.c:153: warning: expecting prototyp

[PATCH 24/34] drm/amd/display/modules/hdcp/hdcp_psp: Remove unused function 'mod_hdcp_hdcp1_get_link_encryption_status()'

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König"

[PATCH 34/34] drm/vboxvideo/modesetting: Provide function names for prototype headers

2021-05-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vboxvideo/modesetting.c:11: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/vboxvideo/modesetting.c:54: warning: This comment starts with '/**

Re: [Intel-gfx] [RFC PATCH 36/97] drm/i915/guc: Add non blocking CTB send function

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:21, Matthew Brost wrote: On Tue, May 25, 2021 at 10:21:00AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:13, Matthew Brost wrote: Add non blocking CTB send function, intel_guc_send_nb. In order to support a non blocking CTB send function a spin lock is needed to protect the

Re: [Intel-gfx] [RFC PATCH 55/97] drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:07, Matthew Brost wrote: On Tue, May 25, 2021 at 11:06:00AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: When running the GuC the GPU can't be considered idle if the GuC still has contexts pinned. As such, a call has been added in intel_gt_wait_for_

Re: [Intel-gfx] [RFC PATCH 53/97] drm/i915/guc: Disable semaphores when using GuC scheduling

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:01, Matthew Brost wrote: On Tue, May 25, 2021 at 10:52:01AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: Disable semaphores when using GuC scheduling as semaphores are broken in the current GuC firmware. What is "current"? Given that the patch its

Re: [Intel-gfx] [RFC PATCH 39/97] drm/i915/guc: Increase size of CTB buffers

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:15, Matthew Brost wrote: On Tue, May 25, 2021 at 10:24:09AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:13, Matthew Brost wrote: With the introduction of non-blocking CTBs more than one CTB can be in flight at a time. Increasing the size of the CTBs should reduce how often

[PATCH] drm/rockchip: kick firmware-based framebuffer when initializing

2021-05-26 Thread Icenowy Zheng
Since U-Boot now supports EFI and FB passing via EFI GOP, when booting rockchip SoCs via EFI, a EFI FB is available. However, currently when re-initializing display pipeline, the EFI FB is not removed, lead to fbcon not working (because the EFI FB is no longer bound to the display pipeline although

Re: EPOLL for drm_syncfile (was Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6))

2021-05-26 Thread Simon Ser
On Sunday, May 23rd, 2021 at 11:34 PM, Daniel Stone wrote: > On the other hand, as soon as the sync point becomes available, the > winsys will want to immediately extract a sync_file from it With today's APIs, yes, but if we ever get drm_syncobj timeline support in KMS/EGL(/Vulkan?) maybe this

[PATCH 1/1] drm/i915: Add Wa_14010733141

2021-05-26 Thread Aditya Swarup
The WA requires the following procedure for VDBox SFC reset: If (MFX-SFC usage is 1) { 1.Issue a MFX-SFC forced lock 2.Wait for MFX-SFC forced lock ack 3.Check the MFX-SFC usage bit If (MFX-SFC usage bit is 1) Reset VDBOX and SFC else

[PATCH 0/1] Adding Wa_14010733141 for SFC reset

2021-05-26 Thread Aditya Swarup
Need an ack for push to intel gt branch. The patch has already been reviewed by Daniele. Aditya Swarup (1): drm/i915: Add Wa_14010733141 drivers/gpu/drm/i915/gt/intel_reset.c | 194 +- drivers/gpu/drm/i915/i915_reg.h | 6 + 2 files changed, 137 insertions(+), 63

[PATCH] drm/i915/params: Align visibility of device level and global modparams

2021-05-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have a few modparams which get conditionaly exposed based on a Kconfig options and in most cases this also means portions of the driver implementing the respective feature are also left out. Align the visibility of device level and global modparams to make them consistent

[PATCH] drm/kconfig: Remove unused select of DRM_KMS_FB_HELPER

2021-05-26 Thread Thomas Zimmermann
The option DRM_KMS_FB_HELPER has been removed. Also remove the last remaining select statement for it. Signed-off-by: Thomas Zimmermann Fixes: 91185d55b32e ("drm: Remove DRM_KMS_FB_HELPER Kconfig option") Reported-by: Geert Uytterhoeven Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard

Re: [Intel-gfx] [PATCH 1/1] Let userspace know if they can trust timeslicing by including it as part of the I915_PARAM_HAS_SCHEDULER::I915_SCHEDULER_CAP_TIMESLICING

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 15:47, Daniel Vetter wrote: On Tue, May 25, 2021 at 03:19:47PM +0100, Tvrtko Ursulin wrote: + dri-devel as per process On 25/05/2021 14:55, Tejas Upadhyay wrote: v2: Only declare timeslicing if we can safely preempt userspace. Commit message got butchered up somehow so you'l

RE: [PATCH v4] drm/ast: Disable fast reset after DRAM initial

2021-05-26 Thread Kuo-Hsiang Chou
-Original Message- From: Kuo-Hsiang Chou Sent: Friday, May 07, 2021 5:27 PM To: tzimmerm...@suse.de; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org Cc: airl...@redhat.com; airl...@linux.ie; dan...@ffwll.ch; Jenmin Yuan ; Kuo-Hsiang Chou ; Arc Sung Subject: [PATCH v4]

Re: [Intel-gfx] [RFC PATCH 49/97] drm/i915/guc: Disable engine barriers with GuC during unpin

2021-05-26 Thread Tvrtko Ursulin
On 06/05/2021 20:14, Matthew Brost wrote: Disable engine barriers for unpinning with GuC. This feature isn't needed with the GuC as it disables context scheduling before unpinning Just isn't needed or causes a problem somehow? which guarantees the HW will not reference the context. Hence it

Re: [PATCH v4] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-05-26 Thread Christian König
Hi Hridya, Am 25.05.21 um 20:37 schrieb Hridya Valsaraju: This patch allows statistics to be enabled for each DMA-BUF in sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. The following stats will be exposed by the interface: /sys/kernel/dmabuf/buffers//exporter_name /sys/kernel/dmabuf/bu

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2021-05-26 Thread Christian König
Am 26.05.21 um 09:39 schrieb Thomas Hellström: [SNIP] I think the long term goal is to use memremap all over the place, to just not have to bother with the __iomem annotation. But to do that io- mapping.h needs to support memremap. But for now we need to be strict about __iomem unless we're in a

vc4: hdmi: audio: ASoC: error at snd_soc_dai_startup on fef00700.hdmi

2021-05-26 Thread Stefan Wahren
Hi, yesterday i was testing with Linux 5.13-rc3 on my Raspberry Pi 4 B (multi_v7_defconfig) and i'm getting the following errors during boot: [   25.947494] vc4_hdmi fef00700.hdmi: ASoC: error at snd_soc_dai_startup on fef00700.hdmi: -19 [   25.947512]  MAI: soc_pcm_open() failed (-19) [   25.947

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2021-05-26 Thread Thomas Hellström
On Wed, 2021-05-26 at 12:45 +0200, Christian König wrote: > Am 26.05.21 um 09:39 schrieb Thomas Hellström: > > [SNIP] > > > > I think the long term goal is to use memremap all over the > > > > place, to > > > > just not have to bother with the __iomem annotation. But to do > > > > that io- > > > >

Re: [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

2021-05-26 Thread Christian König
Am 25.05.21 um 23:17 schrieb Jason Ekstrand: None of these helpers actually leak any RCU details to the caller. They all assume you have a genuine reference, take the RCU read lock, and retry if needed. Naming them with an _rcu is likely to cause callers more panic than needed. I'm really won

Re: [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-26 Thread Christian König
Am 25.05.21 um 23:17 schrieb Jason Ekstrand: Modern userspace APIs like Vulkan are built on an explicit synchronization model. This doesn't always play nicely with the implicit synchronization used in the kernel and assumed by X11 and Wayland. The client -> compositor half of the synchronizatio

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Daniel Stone
Hey, On Mon, 24 May 2021 at 18:11, Jason Ekstrand wrote: > On Sat, May 22, 2021 at 3:05 PM Daniel Stone wrote: > > So far, so good. I really like both your series up until this > > narrative point; as I was saying in the userspace-fence thread, the > > WSI<->client thread is certainly pulling a

[PATCH v2] drm/ast: Add detect function support

2021-05-26 Thread ainux . wang
From: Ainux The existence of the connector cannot be detected, so add the detect function to support. Signed-off-by: Ainux --- drivers/gpu/drm/ast/ast_mode.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/

Re: [Nouveau] [PATCH 11/34] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static

2021-05-26 Thread Karol Herbst
On Wed, May 26, 2021 at 10:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:50:1: warning: no previous > prototype for ‘tu102_mc_intr_unarm’ [-Wmissing-prototypes] > drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:62:1

Re: [PATCH v2 05/12] ASoC: hdmi-codec: Add a prepare hook

2021-05-26 Thread Mark Brown
On Tue, May 25, 2021 at 03:23:47PM +0200, Maxime Ripard wrote: > The IEC958 status bit is usually set by the userspace after hw_params > has been called, so in order to use whatever is set by the userspace, we > need to implement the prepare hook. Let's add it to the hdmi_codec_ops, > and mandate t

Re: [PATCH v2 04/12] ASoC: hdmi-codec: Add iec958 controls

2021-05-26 Thread Mark Brown
On Tue, May 25, 2021 at 03:23:46PM +0200, Maxime Ripard wrote: > The IEC958 status bits can be exposed and modified by the userspace > through dedicated ALSA controls. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v2 03/12] ASoC: hdmi-codec: Rework to support more controls

2021-05-26 Thread Mark Brown
On Tue, May 25, 2021 at 03:23:45PM +0200, Maxime Ripard wrote: > We're going to add more controls to support the IEC958 output, so let's > rework the control registration a bit to support more of them. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-26 Thread Daniel Stone
Hi Christian, On Wed, 26 May 2021 at 12:02, Christian König wrote: > Am 25.05.21 um 23:17 schrieb Jason Ekstrand: > > This new IOCTL solves this problem by allowing us to get a snapshot of > > the implicit synchronization state of a given dma-buf in the form of a > > sync file. It's effectively

Re: [PATCH] drm/kconfig: Remove unused select of DRM_KMS_FB_HELPER

2021-05-26 Thread Maxime Ripard
On Wed, May 26, 2021 at 12:08:25PM +0200, Thomas Zimmermann wrote: > The option DRM_KMS_FB_HELPER has been removed. Also remove the last > remaining select statement for it. > > Signed-off-by: Thomas Zimmermann > Fixes: 91185d55b32e ("drm: Remove DRM_KMS_FB_HELPER Kconfig option") > Reported-by:

[PATCH v4 00/15] drm/i915: Move LMEM (VRAM) management over to TTM

2021-05-26 Thread Thomas Hellström
This is an initial patch series to move discrete memory management over to TTM. It will be followed up shortly with adding more functionality. The buddy allocator is temporarily removed along with its selftests and It is replaced with the TTM range manager and some selftests are adjusted to accoun

[PATCH v4 01/15] drm/i915: Untangle the vma pages_mutex

2021-05-26 Thread Thomas Hellström
Any sleeping dma_resv lock taken while the vma pages_mutex is held will cause a lockdep splat. Move the i915_gem_object_pin_pages() call out of the pages_mutex critical section. Signed-off-by: Thomas Hellström Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_vma.c | 29 +

[PATCH v4 05/15] drm/i915/ttm: Embed a ttm buffer object in the i915 gem object

2021-05-26 Thread Thomas Hellström
Embed a struct ttm_buffer_object into the i915 gem object, making sure we alias the gem object part. It's a bit unfortunate that the struct ttm_buffer_ojbect embeds a gem object since we otherwise could make the TTM part private to the TTM backend, and use the usual i915 gem object for the other ba

[PATCH v4 06/15] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2021-05-26 Thread Thomas Hellström
The internal ttm_bo_util memcpy uses ioremap functionality, and while it probably might be possible to use it for copying in- and out of sglist represented io memory, using io_mem_reserve() / io_mem_free() callbacks, that would cause problems with fault(). Instead, implement a method mapping page-b

[PATCH v4 09/15] drm/ttm: Document and optimize ttm_bo_pipeline_gutting()

2021-05-26 Thread Thomas Hellström
If the bo is idle when calling ttm_bo_pipeline_gutting(), we unnecessarily create a ghost object and push it out to delayed destroy. Fix this by adding a path for idle, and document the function. Also avoid having the bo end up in a bad state vulnerable to user-space triggered kernel BUGs if the c

[PATCH v4 15/15] drm/i915: Use ttm mmap handling for ttm bo's.

2021-05-26 Thread Thomas Hellström
From: Maarten Lankhorst Use the ttm handlers for servicing page faults, and vm_access. We do our own validation of read-only access, otherwise use the ttm handlers as much as possible. Because the ttm handlers expect the vma_node at vma->base, we slightly need to massage the mmap handlers to lo

[PATCH v4 03/15] drm/i915: Fix i915_sg_page_sizes to record dma segments rather than physical pages

2021-05-26 Thread Thomas Hellström
All users of this function actually want the dma segment sizes, but that's not what's calculated. Fix that and rename the function to i915_sg_dma_sizes to reflect what's calculated. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 2 +-

[PATCH v4 14/15] drm/vma: Add a driver_private member to vma_node.

2021-05-26 Thread Thomas Hellström
From: Maarten Lankhorst This allows drivers to distinguish between different types of vma_node's. The readonly flag was unused and is thus removed. Signed-off-by: Maarten Lankhorst Reviewed-by: Thomas Hellström --- drivers/gpu/drm/drm_gem.c | 9 - include/drm/drm_vma_manager.h | 2

[PATCH v4 02/15] drm/i915: Don't free shared locks while shared

2021-05-26 Thread Thomas Hellström
We are currently sharing the VM reservation locks across a number of gem objects with page-table memory. Since TTM will individiualize the reservation locks when freeing objects, including accessing the shared locks, make sure that the shared locks are not freed until that is done. For PPGTT we add

[PATCH v4 04/15] drm/i915/ttm Initialize the ttm device and memory managers

2021-05-26 Thread Thomas Hellström
Temporarily remove the buddy allocator and related selftests and hook up the TTM range manager for i915 regions. Also modify the mock region selftests somewhat to account for a fragmenting manager. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld #v2 --- v2: - Fix an error unwind in lm

[PATCH v4 10/15] drm/ttm, drm/amdgpu: Allow the driver some control over swapping

2021-05-26 Thread Thomas Hellström
We are calling the eviction_valuable driver callback at eviction time to determine whether we actually can evict a buffer object. The upcoming i915 TTM backend needs the same functionality for swapout, and that might actually be beneficial to other drivers as well. Add an eviction_valuable call al

[PATCH v4 08/15] drm/ttm: Use drm_memcpy_from_wc_dbm for TTM bo moves

2021-05-26 Thread Thomas Hellström
Use fast wc memcpy for reading out of wc memory for TTM bo moves. Cc: Dave Airlie Cc: Christian König Cc: Daniel Vetter Signed-off-by: Thomas Hellström -- v4: - Clarify when we try drm_memcpy_from_wc_dbm (Reported by Matthew Auld) - Be paranoid about when drm_memcpy_from_wc_dbm may fail (Repor

[PATCH v4 07/15] drm, drm/i915: Move the memcpy_from_wc functionality to core drm

2021-05-26 Thread Thomas Hellström
Memcpy from wc will be used as well by TTM memcpy. Move it to core drm, and make the interface do the right thing even on !X86. Cc: Christian König Cc: Daniel Vetter Cc: Dave Airlie Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v4: - Fix !X86 path (Reported by Matthew Auld) --

[PATCH v4 12/15] drm/i915/lmem: Verify checks for lmem residency

2021-05-26 Thread Thomas Hellström
Since objects can be migrated or evicted when not pinned or locked, update the checks for lmem residency or future residency so that the value returned is not immediately stale. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v2: Simplify i915_gem_object_migratable() (Reported by M

[PATCH v4 13/15] drm/i915: Disable mmap ioctl for gen12+

2021-05-26 Thread Thomas Hellström
From: Maarten Lankhorst The paltform should exclusively use mmap_offset, one less path to worry about for discrete. Signed-off-by: Maarten Lankhorst Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gp

[PATCH v4 11/15] drm/i915/ttm: Introduce a TTM i915 gem object backend

2021-05-26 Thread Thomas Hellström
Most logical place to introduce TTM buffer objects is as an i915 gem object backend. We need to add some ops to account for added functionality like delayed delete and LRU list manipulation. Initially we support only LMEM and SYSTEM memory, but SYSTEM (which in this case means evicted LMEM objects

Re: [PATCH v4 0/7] drm: Clean up mmap for TTM-based GEM drivers

2021-05-26 Thread Christian König
Patches #1-#4 are Reviewed-by: Christian König Patches #5 and #6 are Acked-by: Christian König Patch #7 already has my rb. I would say push that to drm-misc-next ASAP. Regards, Christian. Am 25.05.21 um 17:10 schrieb Thomas Zimmermann: Implement mmap via struct drm_gem_object_functions.mma

Re: [PATCH] drm/rockchip: kick firmware-based framebuffer when initializing

2021-05-26 Thread Thomas Zimmermann
Hi I think we already fixed this at [1]. Apparently no on epicked it up. If you awant to test, I'll add your Tested-by before merging the patch. Best regards Thomas [1] https://lore.kernel.org/dri-devel/20210516074833.451643-1-javi...@redhat.com/ Am 26.05.21 um 10:55 schrieb Icenowy Zheng:

Re: [PATCH v7 14/15] dt-bindings: of: Add restricted DMA pool

2021-05-26 Thread Will Deacon
Hi Claire, On Tue, May 18, 2021 at 02:42:14PM +0800, Claire Chang wrote: > Introduce the new compatible string, restricted-dma-pool, for restricted > DMA. One can specify the address and length of the restricted DMA memory > region by restricted-dma-pool in the reserved-memory node. > > Signed-of

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Vlad Zahorodnii
On 5/24/21 8:11 PM, Jason Ekstrand wrote: On Sat, May 22, 2021 at 3:05 PM Daniel Stone wrote: Hi, On Thu, 20 May 2021 at 20:00, Jason Ekstrand wrote: In the Vulkan world, this is useful for dealing with the out-fence from vkQueuePresent. Current Linux window-systems (X11, Wayland, etc.) al

Re: [PATCH 13/18] drm/i915/guc: Relax CTB response timeout

2021-05-26 Thread Michal Wajdeczko
On 26.05.2021 08:42, Matthew Brost wrote: > From: Michal Wajdeczko > > In upcoming patch we will allow more CTB requests to be sent in > parallel to the GuC for processing, so we shouldn't assume any more > that GuC will always reply without 10ms. > > Use bigger value from CONFIG_DRM_I915_GUC

[RESEND PATCH] drm/panel: ld9040: reference spi_device_id table

2021-05-26 Thread Krzysztof Kozlowski
Reference the spi_device_id table to silence W=1 warning: drivers/gpu/drm/panel/panel-samsung-ld9040.c:377:35: warning: ‘ld9040_ids’ defined but not used [-Wunused-const-variable=] This also would be needed for matching the driver if booted without CONFIG_OF (although it's not necessarily r

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Daniel Vetter
On Wed, May 26, 2021 at 1:09 PM Daniel Stone wrote: > > Hey, > > On Mon, 24 May 2021 at 18:11, Jason Ekstrand wrote: > > On Sat, May 22, 2021 at 3:05 PM Daniel Stone wrote: > > > So far, so good. I really like both your series up until this > > > narrative point; as I was saying in the userspace

Re: [PATCH 15/18] drm/i915/guc: Ensure H2G buffer updates visible before tail update

2021-05-26 Thread Michal Wajdeczko
On 26.05.2021 08:42, Matthew Brost wrote: > Ensure H2G buffer updates are visible before descriptor tail updates by > inserting a barrier between the H2G buffer update and the tail. The > barrier is simple wmb() for SMEM and is register write for LMEM. This is > needed if more than 1 H2G can be

[PATCH -next] drm/amdgpu: Fix Wunused-label warning

2021-05-26 Thread YueHaibing
If CONFIG_64BIT is n, build warns: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:333:1: warning: label ‘exit’ defined but not used [-Wunused-label] Fixes: f89f8c6bafd0 ("drm/amdgpu: Guard against write accesses after device removal") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/amdgp

Re: [Intel-gfx] [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-26 Thread Christian König
Am 26.05.21 um 13:31 schrieb Daniel Stone: Hi Christian, On Wed, 26 May 2021 at 12:02, Christian König wrote: Am 25.05.21 um 23:17 schrieb Jason Ekstrand: This new IOCTL solves this problem by allowing us to get a snapshot of the implicit synchronization state of a given dma-buf in the for

Re: [PATCH v3 08/12] drm/ttm: Use drm_memcpy_from_wc_dbm for TTM bo moves

2021-05-26 Thread Christian König
Am 21.05.21 um 17:32 schrieb Thomas Hellström: Use fast wc memcpy for reading out of wc memory for TTM bo moves. Cc: Dave Airlie Cc: Christian König Cc: Daniel Vetter Signed-off-by: Thomas Hellström Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 9 - 1 f

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Daniel Stone
Hey, On Wed, 26 May 2021 at 13:35, Daniel Vetter wrote: > On Wed, May 26, 2021 at 1:09 PM Daniel Stone wrote: > > Yeah, I don't think there's any difference between shared and > > exclusive wrt safety. The difference lies in, well, exclusive putting > > a hard serialisation barrier between every

  1   2   3   >